{
"_more_changes": false,
"_number": 280590,
"branch": "master",
"change_id": "I65b55d1c337b2d71156ab8d9fcb405070268c1f6",
"created": "2019-05-10 02:28:08.000000000",
"current_revision": "7a4dbc29e79c9ab7d82a95820fb826fbe1901c40",
"deletions": 3,
"has_review_started": true,
"hashtags": [],
"id": "fuchsia~master~I65b55d1c337b2d71156ab8d9fcb405070268c1f6",
"insertions": 209,
"labels": {
"Code-Review": {},
"Commit-Message-has-tags": {
"approved": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
"Commit-Queue": {
"optional": true,
"recommended": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
"No-Patches-File": {
"approved": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
"Owner-Approved": {
"approved": {
"_account_id": 1
}
},
"Testability-Review": {}
},
"mergeable": true,
"messages": [
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T02:28:08Z",
"id": "86e6189f5d5f32c010c148c7af7338d41b91e2b2",
"message": "Uploaded patch set 1.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T02:36:05Z",
"id": "5c9305f1fc029b4be0639784f741791f89616c44",
"message": "Patch Set 1:\n\nTo make this landable before fixing everything, I see two options:\n 1. Add a bunch of things to the allowlist with TODO to remove them when their deps are cleaned up.\n 2. Add `metadata={driver_denylist_barrier=[]}` to each broken driver() to explicitly defeat the check with a TODO comment to fix up the deps. These could start as all TODO(ZX-2863) but for any nontrivial ones get an individual bug filed blocking ZX-2863 to track the work on that one driver.\n\nI prefer #2 even though it's more places to touch, because it surfaces the TODOs where the work needs to be done. It looks like ~25 drivers fail the check today.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T03:33:36Z",
"id": "0af23caad0ca53ae2da84790ad5f2506822385a4",
"message": "Uploaded patch set 2.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T03:35:35Z",
"id": "afd048d82d03cea58fd95f00301633410826638f",
"message": "Patch Set 2: Commit-Queue+1",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:plugin"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-10T03:35:41Z",
"id": "4201894209874a99f7a34554f74afb6a87f08338",
"message": "Patch Set 2:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-10T03:35:35.0Z\", \"revision\": \"a78528a52435bcb3c2f10f6f61ebacf86f56126b\"}",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T03:39:51Z",
"id": "970b394ef81bfc954fa038ac9ab95a45f064f6f6",
"message": "Patch Set 2: -Commit-Queue",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-10T03:39:53Z",
"id": "691c177211922ff5ace18d52bf27db88c2a4ffdc",
"message": "Patch Set 2:\n\nDry run: Try jobs failed on following builders:\n zircon-arm64-clang-no_user_linker_gc-build_only on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440704)\n zircon-arm64-clang-qemu_kvm on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440512)\n zircon-arm64-gcc-no_opt-build_only on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440384)\n zircon-arm64-gcc-qemu on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440480)\n zircon-arm64-gcc-release-build_only on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440880)\n zircon-host-linux on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440672)\n zircon-x64-clang-qemu_kvm on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440400)\n zircon-x64-gcc-no_opt-build_only on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440576)\n zircon-x64-gcc-qemu_kvm on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913879218676440864)",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T03:53:24Z",
"id": "3d8615f69c13e121f885dee9b51086bc5766be95",
"message": "Uploaded patch set 3.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T03:53:36Z",
"id": "7c776621065c27d39c929b2f169304a371452e7a",
"message": "Patch Set 3: Commit-Queue+1",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:plugin"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-10T03:53:41Z",
"id": "43c7d1e3a03b1ed17cf6341121a2c246c6270b53",
"message": "Patch Set 3:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-10T03:53:36.0Z\", \"revision\": \"575332d77a5551f6491679b94c5beb1d45931983\"}",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T04:04:26Z",
"id": "e6fcf6a2a32fe1b6424ad839f7898659f3d7d5ea",
"message": "Patch Set 3: -Commit-Queue",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-10T04:04:27Z",
"id": "78f8ae9a10d76f19d44ab9d72aebf9068c771f48",
"message": "Patch Set 3:\n\nDry run: Try jobs failed on following builders:\n zircon-x64-gcc-qemu_kvm on luci.fuchsia.try (JOB_FAILED,
https://ci.chromium.org/b/8913878085853551776)",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5155,
"email": "teisenbe@google.com",
"name": "Todd Eisenberger"
},
"date": "2019-05-10T17:50:29Z",
"id": "66641f1d7ebe9c2bb6be2f92f9365c0cd910fb98",
"message": "Patch Set 3: Code-Review+1\n\nIt would be good to send out an email alongside this, since I suspect folks will get surprised when their new drivers start getting these build errors",
"real_author": {
"_account_id": 5155,
"email": "teisenbe@google.com",
"name": "Todd Eisenberger"
}
},
{
"author": {
"_account_id": 5020,
"email": "kulakowski@google.com",
"name": "George Kulakowski"
},
"date": "2019-05-10T21:06:16Z",
"id": "a3aeb84c76c26279f81b3dacf80c87c3a7b2a6a7",
"message": "Patch Set 3: Code-Review+1\n\nLeaving a +2 for Todd when he's happy on the PSA front",
"real_author": {
"_account_id": 5020,
"email": "kulakowski@google.com",
"name": "George Kulakowski"
}
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T23:30:46Z",
"id": "3e84da06289212e32b0cfbda33c9fb0a2169cd08",
"message": "Patch Set 3:\n\n> Patch Set 3: Code-Review+1\n> \n> It would be good to send out an email alongside this, since I suspect folks will get surprised when their new drivers start getting these build errors\n\nI will certainly send a PSA when this is about to land.\n\nCould probably use a +2 from Julie or Petr wrt GN bits too, since I presume George and Todd are not testifying about those.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T23:31:16Z",
"id": "21fe628bcbb4f40f82c93e977e03098d01663193",
"message": "Uploaded patch set 4: Patch Set 3 was rebased.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5155,
"email": "teisenbe@google.com",
"name": "Todd Eisenberger"
},
"date": "2019-05-10T23:31:31Z",
"id": "ac2bfd92534b2978569f1c1cb55f63ab6982db35",
"message": "Patch Set 3:\n\nYeah, my +1 was definitely \"the change seems reasonable, but I don't speak GN very well\"",
"real_author": {
"_account_id": 5155,
"email": "teisenbe@google.com",
"name": "Todd Eisenberger"
}
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T23:31:34Z",
"id": "c29dbd67bda9a4621d775b371aecd70acbbc7966",
"message": "Patch Set 4: Commit-Queue+1",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:plugin"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-10T23:31:45Z",
"id": "da79720c95710324e218d9a470077214890dad18",
"message": "Patch Set 4:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-10T23:31:34.0Z\", \"revision\": \"0b4de4fff94aa4ad247e847724ae9c5af525e05d\"}",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-10T23:49:26Z",
"id": "75cccf2e6ffafdd25809c1e28a83fc978405bc3f",
"message": "Patch Set 4: -Commit-Queue",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-10T23:49:28Z",
"id": "a2c6cfb8e1781d774f874bbf231b51cc2e78b470",
"message": "Patch Set 4:\n\nDry run: This CL passed the CQ dry run.",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-15T01:23:21Z",
"id": "3bdeba56bbca0aef58ddad67c94367c5c5320c73",
"message": "Uploaded patch set 5.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-15T01:24:05Z",
"id": "20bd3197298bb55da57719b5da0b012c36d03607",
"message": "Patch Set 5: Commit-Queue+1",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:plugin"
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-15T01:24:12Z",
"id": "08de5d2b30664e807fc9bff9583eb3f7ba1002f5",
"message": "Patch Set 5:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-15T01:24:05.0Z\", \"revision\": \"8d23140fde58a64c5ab18e187de0bda67b189ad7\"}",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-15T01:28:16Z",
"id": "c27b9977b44e0bded85ab6d6fe08e6e6781e3f5d",
"message": "Uploaded patch set 6: Commit message was updated.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-15T02:07:19Z",
"id": "d41f54fabac4a9d54e1e413dbfa50725eede600d",
"message": "Patch Set 6:\n\nI think this can land now. PTAL",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-15T02:20:26Z",
"id": "8d1212e74db5a03da59573d5798696a0b2a23fc0",
"message": "Uploaded patch set 7.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-18T11:21:08Z",
"id": "e0661e7383c73042bbe900d86e7f66113a6f78a7",
"message": "Uploaded patch set 8: Patch Set 7 was rebased.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-18T11:22:00Z",
"id": "3628c6f9ef5a43bbc76bacaa07163b27692675e0",
"message": "Patch Set 8: Commit-Queue+1\n\nPetr/Julie: please review GN changes",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-18T11:22:10Z",
"id": "d39cf50e1ed5cbda7f216ab93dae2f624a84be99",
"message": "Patch Set 8:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-18T11:22:00.0Z\", \"revision\": \"3f92b28a50f4901c81d6a8bb402e2e0878a2d5cf\"}",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-18T11:33:36Z",
"id": "dbf6accdbfc9faf804285c5e5333ec02a37c6850",
"message": "Uploaded patch set 9.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:newPatchSet"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-25T07:31:59Z",
"id": "d1cedb77d2066f289262ec7e021606b19be3070b",
"message": "Removed reviewer George Kulakowski.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"tag": "autogenerated:gerrit:deleteReviewer"
},
{
"author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"date": "2019-05-25T07:32:24Z",
"id": "01775f4cf1d6f5293462101b9730a5d6f72892fe",
"message": "Patch Set 9: Commit-Queue+1\n\nJulie/Petr: please review GN. This has been pending for some time now.",
"real_author": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
},
{
"author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"date": "2019-05-25T07:32:30Z",
"id": "2e430877afa8c707bfba6541837ffec0351948a5",
"message": "Patch Set 9:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-25T07:32:24.0Z\", \"revision\": \"7a4dbc29e79c9ab7d82a95820fb826fbe1901c40\"}",
"real_author": {
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
},
"tag": "autogenerated:cq:dry-run"
}
],
"owner": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
"project": "fuchsia",
"revert_of": 0,
"reviewers": {
"CC": [
{
"_account_id": 7350,
"email": "commit-bot@chromium.org",
"name": "CQ bot account: commit-bot@chromium.org"
}
],
"REMOVED": null,
"REVIEWER": [
{
"_account_id": 5050,
"email": "phosek@google.com",
"name": "Petr Hosek"
},
{
"_account_id": 5155,
"email": "teisenbe@google.com",
"name": "Todd Eisenberger"
},
{
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
},
{
"_account_id": 18703,
"email": "juliehockett@google.com",
"name": "Julie Hockett"
}
]
},
"revisions": {
"7a4dbc29e79c9ab7d82a95820fb826fbe1901c40": {
"_number": 9,
"commit": {
"author": {},
"committer": {}
},
"kind": "REWORK",
"ref": "refs/changes/90/280590/9",
"uploader": {
"_account_id": 5235,
"email": "mcgrathr@google.com",
"name": "Roland McGrath"
}
}
},
"status": "NEW",
"subject": "[zircon][gn] Enforce shared-library allowlist when linking drivers at build time",
"submit_type": "REBASE_IF_NECESSARY",
"submitted": "",
"submitter": {},
"topic": "",
"unresolved_comment_count": 0,
"updated": "2019-05-25 07:32:30.000000000"
}