Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 44838 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8915850815215195040 LOGDOG_STREAM_PROJECT: v8 LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itWxgPqP/luci_context.733566705 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm352-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 44488ec648f58411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: efb60af1f7facfc5c4cb2ea955e7c1e781a3d15e Support "noreferrer" for window.open() Joonghun Park, Thu Apr 18 07:25:49 2019 +0000 60810e693cfffdb8e645982c39a9d94cefce6189 Revert "Update vulkan_content_browsertests expectations" Corentin Wallez, Thu Apr 18 07:10:19 2019 +0000 9491e76384c8eb7c09457927d45e12d8dc95172c Remove echo cancellation type constraint from getUserMedia and its origin trial. Henrik Grunell, Thu Apr 18 07:08:27 2019 +0000 3c60fbd10b2a08dfdf25004482d8e91c06396bb6 Roll src/third_party/skia ced2b79d00f9..847d55be4e62 (3 commits) chromium-autoroll, Thu Apr 18 07:06:21 2019 +0000 83aa918eb2b70bb46bf0c991b182ae1dfbd14a59 Add minimal range to touch adjustment range Ella Ge, Thu Apr 18 07:03:02 2019 +0000 73874506ee1177402755baac69ab621a10906085 ArcSelectFilesHandler : Avoid mocking SelectFileDialog in unit tests Satoshi Niwa, Thu Apr 18 06:57:42 2019 +0000 5d9ecc050d30d8aac21ede2d6456f5d8542ea43c GWP-ASan: Vary the allocating sampling frequency Vlad Tsyrklevich, Thu Apr 18 06:31:08 2019 +0000 4bf46d7ec97816063d87fa4061e9210f2edb9c63 Roll src-internal 9cb73239a3ac..6fd4a82355a9 (1 commits) chromium-internal-autoroll, Thu Apr 18 06:18:36 2019 +0000 929ed318cb4607eeee61b95ecb7e3b5b61994253 WebAssociatedURLLoaderTest: update terminology for CORS safelisted headers Daniel Cheng, Thu Apr 18 06:15:46 2019 +0000 61437a59a60de67b70d07c95ffa3c9e9bec556af Move disk space check from CrostiniRestarter to the installer view Fergus Dall, Thu Apr 18 06:04:10 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit efb60af1f7facfc5c4cb2ea955e7c1e781a3d15e Author: Joonghun Park <pjh0718@gmail.com> Date: Thu Apr 18 07:25:49 2019 +0000 Support "noreferrer" for window.open() This change is following specs below. 1) https://github.com/whatwg/html/pull/4331 2) https://html.spec.whatwg.org/multipage/window-object.html And this CL includes the behavior change below. When noreferrer is specified, the created window is not shown in app popup form. This behavior matches with Chromium and Firefox's handling way for "noopener". Bug: 931207 Change-Id: Ia1c8f99dc6936952cc70bfa21d1eece741b7edcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541376 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Joonghun Park <pjh0718@gmail.com> Cr-Commit-Position: refs/heads/master@{#652063} .../public/renderer/window_features_converter.cc | 6 +++ third_party/blink/public/web/web_window_features.h | 6 +++ .../blink/renderer/core/frame/local_dom_window.cc | 7 ++-- .../renderer/core/loader/navigation_policy_test.cc | 46 ++++++++++++++++++++++ .../blink/renderer/core/page/create_window.cc | 8 +++- .../renderer/core/page/window_features_test.cc | 30 ++++++++++++++ ...n-features-tokenization-noreferrer-expected.txt | 11 ------ .../window-open-noreferrer-expected.txt | 4 -- 8 files changed, 99 insertions(+), 19 deletions(-) commit 60810e693cfffdb8e645982c39a9d94cefce6189 Author: Corentin Wallez <cwallez@chromium.org> Date: Thu Apr 18 07:10:19 2019 +0000 Revert "Update vulkan_content_browsertests expectations" This reverts commit 9fd8382057d83c92a4b86b6feb982c91f6a37ecb. Reason for revert: re-introduced tests cause failure on multiple GPU FYI builders. Original change's description: > Update vulkan_content_browsertests expectations > > A regression lead to viz::SkiaOutputDeviceVulkan::UpdateDrawSurface crashing. > This has since been fixed (crbug.com/952231). > > This combined with falling back to GL Renderer was leading to the test only > having flaky failures. > > We have recently added a testing flag to prevent this false positive: > "--disable-vulkan-fallback-to-gl-for-testing" which this change adds to the > tests. So that we reliably catch failures going forward. > > This change also re-enables > AuraWindowVideoCaptureDeviceBrowserTest.ErrorsOutIfWindowHasGoneBeforeDeviceStart > which was failing due to crbug.com/948249 which has since been fixed. > > This change also removes the test exceptions for vulkan_content_browsertests > aside from TSAN and Intel HD 630, which are failing for other reasons > > TEST=vulkan_content_browsertests > > Bug: 940723, 930943 > Change-Id: Id187c41718a91b4401db9ff2549d6556d1820c4d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568088 > Commit-Queue: Jonathan Ross <jonross@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651751} TBR=backer@chromium.org,kbr@chromium.org,jonross@chromium.org Change-Id: I0f8e1b592090370c9b6488c173105969252ae41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940723, 930943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571694 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#652062} testing/buildbot/chromium.gpu.fyi.json | 122 +-------------------- .../filters/vulkan.content_browsertests.filter | 3 +- testing/buildbot/test_suite_exceptions.pyl | 5 +- testing/buildbot/test_suites.pyl | 2 +- 4 files changed, 10 insertions(+), 122 deletions(-) commit 9491e76384c8eb7c09457927d45e12d8dc95172c Author: Henrik Grunell <grunell@chromium.org> Date: Thu Apr 18 07:08:27 2019 +0000 Remove echo cancellation type constraint from getUserMedia and its origin trial. The internal code for the constraint will be removed in follow-up CL(s). Bug: 953653 Change-Id: Ief991a325dd667a94f5b5c2e2107181c234bd0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570021 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Auto-Submit: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#652061} .../public/mojom/web_feature/web_feature.mojom | 1 - .../modules/mediastream/media_constraints_impl.cc | 5 ----- .../modules/mediastream/media_stream_track.cc | 6 ------ .../mediastream/media_track_capabilities.idl | 2 -- .../mediastream/media_track_constraint_set.idl | 2 -- .../modules/mediastream/media_track_settings.idl | 1 - .../media_track_supported_constraints.idl | 2 -- .../modules/mediastream/user_media_request.cc | 6 ------ .../platform/runtime_enabled_features.json5 | 5 ----- .../MediaStreamTrack-getCapabilities.html | 21 ++++----------------- .../mediastream/MediaStreamTrack-getSettings.html | 4 ---- 11 files changed, 4 insertions(+), 51 deletions(-) commit 3c60fbd10b2a08dfdf25004482d8e91c06396bb6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 07:06:21 2019 +0000 Roll src/third_party/skia ced2b79d00f9..847d55be4e62 (3 commits) https://skia.googlesource.com/skia.git/+log/ced2b79d00f9..847d55be4e62 git log ced2b79d00f9..847d55be4e62 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c832cdd75f75..82bcffa78747 (7 commits) 2019-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 84c3a94e1450..abaecd5f2ba7 (6 commits) Created with: gclient setdep -r src/third_party/skia@847d55be4e62 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ie8add6b081e694f486c6c7de0b3309fed7fd8a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573343 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652060} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 83aa918eb2b70bb46bf0c991b182ae1dfbd14a59 Author: Ella Ge <eirage@chromium.org> Date: Thu Apr 18 07:03:02 2019 +0000 Add minimal range to touch adjustment range Previously, when we do touch adjustment for touch events, we don't have a minimal range. However, there are some devices doesn't report radius. This causes touch adjustment doesn't take effect on those devices. This CL adds a minimal size to the touch adjustment size, similar to the kMinGestureBoundsLengthDips in GestureConfigurationAndroid (which apply the min/max bounds to gesture events). This CL updates 2 web_tests. touch-event.html failed with the CL because the touch event was target to the input box, so adding a margin to avoid that. hit-test-counts DoubleFingerTouch increased by 1 because previously it doesn't have radius and there was no rect-based hit-test for it. Bug: 949130 Change-Id: I936ce3385063422e8559b348242b499ed3d9d7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567084 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652059} .../blink/renderer/core/page/touch_adjustment.cc | 11 ++++++++--- .../renderer/core/page/touch_adjustment_test.cc | 22 ++++++++++++++++++++++ .../web_tests/fast/dom/shadow/touch-event.html | 2 +- .../fast/events/hit-test-counts-expected.txt | 8 ++++---- .../web_tests/fast/events/hit-test-counts.html | 4 ++-- 5 files changed, 37 insertions(+), 10 deletions(-) commit 73874506ee1177402755baac69ab621a10906085 Author: Satoshi Niwa <niwa@google.com> Date: Thu Apr 18 06:57:42 2019 +0000 ArcSelectFilesHandler : Avoid mocking SelectFileDialog in unit tests It is not very easy to create mocks for SelectFileDialog and SelectFileDialogExtension for several reasons. (e.g. destructor is private) In this CL we rename SelectFileDialogScriptExecutor to SelectFileDialogHolder and use it as a general wrapper for SelectFileDialog, not just a proxy for ExecuteJavaScript method. This makes writing unit tests easier for further patches (e.g. crrev.com/c/1564355) BUG=b:64281746 TEST=out/Default/unit_tests --gtest_filter="ArcSelectFilesHandlerTest.*" Change-Id: I8b0804b33503020913083ab1e91ea1103c0ee6f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567545 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#652058} .../arc/fileapi/arc_select_files_handler.cc | 64 ++++++++-------- .../arc/fileapi/arc_select_files_handler.h | 35 +++++---- .../fileapi/arc_select_files_handler_unittest.cc | 86 ++++++---------------- 3 files changed, 71 insertions(+), 114 deletions(-) commit 5d9ecc050d30d8aac21ede2d6456f5d8542ea43c Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Apr 18 06:31:08 2019 +0000 GWP-ASan: Vary the allocating sampling frequency Pick the allocating sampling frequency from a range of [multiplier, multiplier*range). The distribution is unevenly skewed towards smaller allocating sampling frequencies by using the formula multiplier*(range**rand(0,1)). This change helps address that different processes have different numbers of allocations, some long-lived. In order to try to evenly sample all types of processes, GWP-ASan needs to sample with different sampling frequencies. Bug: 937020 Change-Id: If48b37a3fdaebf1b202c734ebece10a766b37e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566767 Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652057} components/gwp_asan/client/gwp_asan.cc | 49 +++++++++++++++++++++++++++------- 1 file changed, 40 insertions(+), 9 deletions(-) commit 4bf46d7ec97816063d87fa4061e9210f2edb9c63 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 06:18:36 2019 +0000 Roll src-internal 9cb73239a3ac..6fd4a82355a9 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9cb73239a3ac..6fd4a82355a9 Created with: gclient setdep -r src-internal@6fd4a82355a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: If6508cd5f076ea80bebeeebe0990d284d697858c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573341 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652056} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 929ed318cb4607eeee61b95ecb7e3b5b61994253 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 18 06:15:46 2019 +0000 WebAssociatedURLLoaderTest: update terminology for CORS safelisted headers Followup to https://crrev.com/c/1566765. Bug: 842296 Change-Id: Ia99c6d75a0cf16ea0c5e82818c50772244dca3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570482 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#652055} .../exported/web_associated_url_loader_impl_test.cc | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit 61437a59a60de67b70d07c95ffa3c9e9bec556af Author: Fergus Dall <sidereal@google.com> Date: Thu Apr 18 06:04:10 2019 +0000 Move disk space check from CrostiniRestarter to the installer view Currently, we don't check how much free disk space there is until we try to create the VM disk image. This means, among other things, that we will try (and fail) to install cros_termina even if there isn't enough space for it, and that the user won't be told that there's an issue until after they've downloaded cros_termina. Additionally, the installer view currently doesn't distinguish disk space errors from other errors, so this isn't visible in our metrics or the errors shown to the user. This CL changes the installer view to check if there's enough disk space to install crostini before trying, and reports the error case to both the user and our metrics. Bug: 953545 Change-Id: I73ef8159663d2c49fe604b3960b2a0a506bf003d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570986 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#652054} chrome/app/chromeos_strings.grdp | 3 ++ .../browser/chromeos/crostini/crostini_manager.cc | 14 ------- .../ui/views/crostini/crostini_installer_view.cc | 46 +++++++++++++++++++++- .../ui/views/crostini/crostini_installer_view.h | 5 +++ .../crostini_installer_view_browsertest.cc | 12 ++++++ tools/metrics/histograms/enums.xml | 1 + 6 files changed, 66 insertions(+), 15 deletions(-) commit 3889a29c4b4cbb20077b253a3e13e48e9e0296a8 Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Date: Thu Apr 18 06:04:06 2019 +0000 update whitelist for Deterministic Linux (dbg) builder PNaCl build artifacts are failing to pass compare_build_artifacts. Let me exclude them. Bug: 954056, 947903 Change-Id: I84d95690b7b7518296f3b29eecb4ac2a1bcbee82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573305 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#652053} tools/determinism/deterministic_build_whitelist.pyl | 5 +++++ 1 file changed, 5 insertions(+) commit 0f98632373b0e3c34ff95473c4ad81e30e0ba5fe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 06:01:45 2019 +0000 Roll src/third_party/skia 14c90c1ca218..ced2b79d00f9 (1 commits) https://skia.googlesource.com/skia.git/+log/14c90c1ca218..ced2b79d00f9 git log 14c90c1ca218..ced2b79d00f9 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src a3585f70a100..f968f64cdf27 (436 commits) Created with: gclient setdep -r src/third_party/skia@ced2b79d00f9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I0dbf2811b322a012a7e86d47600e3f5673428469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572968 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652052} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4461f14faa5783c09099833bee9320585e581416 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Apr 18 06:01:04 2019 +0000 Remove gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT. GPU_READ_CPU_READ_WRITE_PERSISTENT is always handled the same way as GPU_READ_CPU_READ_WRITE, so we no longer need it. Change-Id: I5ab71dd9c80427f9d3a8c1d46050b66fd77138d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570813 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652051} cc/raster/one_copy_raster_buffer_provider.cc | 13 ++----- cc/raster/one_copy_raster_buffer_provider.h | 1 - gpu/command_buffer/build_raster_cmd_buffer.py | 1 - .../raster_cmd_validation_implementation_autogen.h | 1 - .../common/gpu_memory_buffer_impl_io_surface.cc | 1 - .../common/gpu_memory_buffer_impl_shared_memory.cc | 1 - .../common/gpu_memory_buffer_impl_test_template.h | 41 ++++++++++------------ gpu/ipc/common/gpu_memory_buffer_support.cc | 3 -- gpu/ipc/host/gpu_memory_buffer_support.cc | 3 +- .../gpu_memory_buffer_factory_test_template.h | 16 ++++----- ui/gfx/buffer_types.h | 5 +-- ui/gfx/buffer_usage_util.cc | 2 -- ui/gfx/linux/client_native_pixmap_dmabuf.cc | 2 -- .../linux/client_native_pixmap_factory_dmabuf.cc | 1 - ui/gfx/mojo/buffer_types.mojom | 3 +- ui/gfx/mojo/buffer_types_struct_traits.h | 5 --- ui/ozone/platform/drm/gpu/drm_thread.cc | 1 - .../platform/wayland/gpu/gbm_pixmap_wayland.cc | 1 - 18 files changed, 31 insertions(+), 70 deletions(-) commit f2865fd3afa1be22af59f64f2a81798253f72b7d Author: Ren-Pei Zeng <kamesan@chromium.org> Date: Thu Apr 18 05:58:38 2019 +0000 media/gpu: Fix image format determination for JPEG decode In VaapiWrapper::GetJpegDecodeSuitableImageFourCC() (added by crrev.com/c/1494803), allow obtaining NV12 images from a 4:2:0 JPEG decode for the Mesa Gallium driver since it is actually supported. This CL also enables VJD unittest to compare NV12 format VA image to the reference result. Bug: 868400 Test: Pass VJD unittest in grunt. Change-Id: I8ef220836e53e049e2ea69c583c1846fdaa350c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569372 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Ren-Pei Zeng <kamesan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652050} media/gpu/vaapi/vaapi_jpeg_decoder_unittest.cc | 65 ++++++++++++++++++++++---- media/gpu/vaapi/vaapi_wrapper.cc | 6 ++- 2 files changed, 59 insertions(+), 12 deletions(-) commit 4e7c572f065892de9e15a8e01f988fdad400e7f0 Author: Ryo Hashimoto <hashimoto@chromium.org> Date: Thu Apr 18 05:55:56 2019 +0000 arc: Eliminate possibility of race between wayland and mojo Client surface ID of exo::Surface is set via wayland while ArcCustomTabView is instanciated via mojo. When the view is created before the ID is set, it fails to find the surface. Fix this by observing ID change. BUG=b:130296376 TEST=manually Change-Id: Ia57d92a42f354e49926cb506926f527ed41abed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569374 Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#652049} ash/custom_tab/arc_custom_tab_view.cc | 86 +++++++++++++++++++++++++---------- ash/custom_tab/arc_custom_tab_view.h | 19 ++++++-- components/exo/surface.cc | 5 +- components/exo/surface.h | 3 ++ 4 files changed, 82 insertions(+), 31 deletions(-) commit d60a05a77feb9463e33b9c50f28fc53964afe078 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Apr 18 05:47:56 2019 +0000 GWP-ASan: Enable GWP-ASan by default GWP-ASan is now enabled for 1% of stable users, enable it on ToT with matching parameters. Enable it only for 20% of processes to limit sampling overhead, and so that we can use more memory per process making sampling more even for processes with many allocations. (Processes with many allocations are likely to run out of allocations sooner since some are bound to live until process exit.) Bug: 896019, 937020 Change-Id: Iaa69cd23a4423f67c6a732ef5abd22ea19f92313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570257 Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#652048} components/gwp_asan/client/gwp_asan.cc | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) commit 93bd98c641c23d45adbb26dcb31a21ba9f1b197d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 05:39:41 2019 +0000 Roll src/third_party/chromite 18b3cbd0b9cc..d635edced1d1 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/18b3cbd0b9cc..d635edced1d1 git log 18b3cbd0b9cc..d635edced1d1 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 jclinton@chromium.org Add logging to code paths assoc. w/ deciding a build has already been 2019-04-18 xixuan@google.com chromite: Change parsing for run_suite trampoline. Created with: gclient setdep -r src/third_party/chromite@d635edced1d1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I203ff8b96f82a09f2267ea28f5ba06d092cc7e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572967 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652047} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3e4873769182047997bff08e00768a344afc28ef Author: Hayato Ito <hayato@chromium.org> Date: Thu Apr 18 05:37:21 2019 +0000 Change my watchlist email TBR=tkent Change-Id: I7a7bb9e3271f72af26c2603188e6ef6fe6cfac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573302 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#652046} WATCHLISTS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 16721b98cf4207d3f73fa2fc6cff722e0ea2dacd Author: Kouhei Ueno <kouhei@chromium.org> Date: Thu Apr 18 05:34:01 2019 +0000 SignedExchange Add browsertest for bad MICE (small) This CL adds another variant of the test added in crrev.com/651571 , but with smaller body size to trigger crrev.com/651606 Bug: 953150, 953175 Change-Id: I9fc2be14c9d2c01a5549ef4685afa89841e0a149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573419 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Auto-Submit: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652045} .../signed_exchange_request_handler_browsertest.cc | 30 +++++++++++++++++++-- content/test/data/sxg/generate-test-sxgs.sh | 7 +++++ .../sxg/test.example.org_test_bad_mice_small.sxg | Bin 0 -> 729 bytes ...e.org_test_bad_mice_small.sxg.mock-http-headers | 3 +++ 4 files changed, 38 insertions(+), 2 deletions(-) commit 436ad15b4211df7133319cbcf5965fb51cb13707 Author: Adam Rice <ricea@chromium.org> Date: Thu Apr 18 05:32:41 2019 +0000 Make some methods public for use by TransformStream Move some methods of ReadableStreamDefaultController and WritableStreamDefaultController to the public section so that they can be used by TransformStream. This change only moves methods around and doesn't change any functionality. BUG=902633 Change-Id: I4f437e0e8528ae4886c3ed1b1f94199afcbb872d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572764 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#652044} .../streams/readable_stream_default_controller.cc | 78 +++++++++++----------- .../streams/readable_stream_default_controller.h | 21 +++--- .../streams/writable_stream_default_controller.cc | 26 ++++---- .../streams/writable_stream_default_controller.h | 13 ++-- 4 files changed, 72 insertions(+), 66 deletions(-) commit 1cb36120ecb030c5a209d638d6519c2bbe86865d Author: Christopher Lam <calamity@chromium.org> Date: Thu Apr 18 05:29:44 2019 +0000 [Bookmarks] Port bookmarkManagerPrivate ExtensionAPITests to WebUI. This CL removes the ExtensionAPITests for bookmarkManagerPrivate to WebUI as the WebUI is the only consumer of this API. In order to remove the API from Extension manifests, we need to move the test away from the ExtensionAPITest framework, so it has been moved to the chrome://bookmarks WebUI tests instead. Bug: 938695 Change-Id: I11ef89876c73a73a0da64988d170e02f560223b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566269 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#652043} .../bookmark_manager_private_apitest.cc | 77 ------ .../ui/webui/bookmarks/bookmarks_browsertest.cc | 49 ++++ .../ui/webui/bookmarks/bookmarks_browsertest.h | 3 + chrome/common/extensions/api/_api_features.json | 20 +- .../extensions/api/_permission_features.json | 9 - chrome/test/BUILD.gn | 1 - .../bookmark_manager/edit_disabled/manifest.json | 11 - .../bookmark_manager/edit_disabled/test.html | 6 - .../bookmark_manager/edit_disabled/test.js | 76 ------ .../bookmark_manager/standard/manifest.json | 11 - .../api_test/bookmark_manager/standard/test.html | 6 - .../api_test/bookmark_manager/standard/test.js | 293 --------------------- .../data/webui/bookmarks/bookmarks_browsertest.js | 36 +++ .../data/webui/bookmarks/extension_api_test.js | 269 +++++++++++++++++++ .../bookmarks/extension_api_test_edit_disabled.js | 73 +++++ chrome/test/data/webui/bookmarks/test_util.js | 44 ++++ 16 files changed, 478 insertions(+), 506 deletions(-) commit d23de83631a64fc4079c9bf871ddafe72bede03f Author: Ting Shao <ting.shao@intel.com> Date: Thu Apr 18 05:29:17 2019 +0000 ServiceWorker: Extends ServiceWorkerNewScriptloader for resuming paused download If ServiceWorkerImportedScriptUpdateCheck is enabled, there are two phases in updating: byte-to-byte checking and launching a new service worker for install/activate events. If script change is found in phase one, the download of changed script is paused. In the second phase, we need to resume the paused download to avoid making new network request again. This patch is for second phase: Extends ServiceWorkerNewScriptLoader to support resuming download of remaining script data from network. Bug: 648295 Change-Id: I3bde3896d3093dfbfc0b9310a0410473adc3387d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547410 Commit-Queue: Ting Shao <ting.shao@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652042} .../service_worker/service_worker_cache_writer.h | 2 + .../service_worker_installed_script_loader.cc | 30 +- .../service_worker_new_script_loader.cc | 265 ++++++++++++++++- .../service_worker_new_script_loader.h | 148 ++++++++-- .../service_worker_new_script_loader_unittest.cc | 327 ++++++++++++++++++--- .../service_worker_script_loader_factory.cc | 5 +- .../service_worker_single_script_update_checker.cc | 122 +++++--- .../service_worker_single_script_update_checker.h | 33 +-- .../service_worker/service_worker_test_utils.cc | 136 +++++++++ .../service_worker/service_worker_test_utils.h | 60 ++++ .../service_worker/service_worker_update_checker.h | 4 +- .../common/service_worker/service_worker_utils.cc | 40 +++ .../common/service_worker/service_worker_utils.h | 8 + 13 files changed, 1013 insertions(+), 167 deletions(-) commit 5f796464d4b1a855abab9409e33ee41e8e8b1d7c Author: Fergus Dall <sidereal@google.com> Date: Thu Apr 18 05:16:59 2019 +0000 Add metrics to crostini installer. Currently, there are a significant number of install failures we don't have much visibility into, especially on low-powered devices. This CL adds metrics for free disk space and time to install, and records failures due to network flake in the correct bucket, to give us a better understanding of this. Change-Id: I34ce13eabb698a9962db3da8cfe76eb48e33c3b4 Bug: 953545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569369 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#652041} .../ui/views/crostini/crostini_installer_view.cc | 100 ++++++++++++++++++--- .../ui/views/crostini/crostini_installer_view.h | 8 ++ tools/metrics/histograms/histograms.xml | 88 ++++++++++++++++++ 3 files changed, 186 insertions(+), 10 deletions(-) commit 3b67caec5b27d77b10892d5ed1dc8bc5982ad0e2 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 05:13:49 2019 +0000 Roll src-internal d7524794413f..9cb73239a3ac (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7524794413f..9cb73239a3ac Created with: gclient setdep -r src-internal@9cb73239a3ac The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I6a3dfe0529711d7ab8e8e878ca0cf035cdbb8343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573340 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652040} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c26662c9b3e64164c782605e5cc150a513275c89 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Apr 18 05:13:41 2019 +0000 [Files app] Refactor file_manager_commands.js * getCommandEntries and getParentEntry (similar refactors): - Change to check for element attributes instead of "instanceof". This makes the check for non-null simpler. - Checks if the "entry" attribute is non-null before returning it. - Check if the event started from the action bar and if so returns the current selection, because action bar can only act on the currently selected files (from file list). * getElementVolumeInfo: - Change to check if the element source of the event has a volumeInfo, which can be the case for VolumeItem in directory tree. - Otherwise just rely on getCommandEntry and return the volumeInfo from such entry. * getCurrentVolumeInfo: - Removed since getElementVolumeInfo already accounts for directory tree and file list. Returning the "currently selected directory" is wrong for directory tree, since user can right click anywhere in the tree. Bug: 889153 Change-Id: Id2fa1c0e0040682d4eedeb7070ff7446814c5a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571119 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#652039} .../foreground/js/file_manager_commands.js | 123 +++++++++------------ ui/file_manager/file_manager/test/check_select.js | 4 +- 2 files changed, 53 insertions(+), 74 deletions(-) commit 08cf436878b69fba3e65fc71da0df118549658fc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 05:07:42 2019 +0000 Roll src/third_party/swiftshader d853c12d34f5..abaecd5f2ba7 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d853c12d34f5..abaecd5f2ba7 git log d853c12d34f5..abaecd5f2ba7 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 bclayton@google.com VkFormat.cpp: Replace ASSERT with UNIMPLEMENTED Created with: gclient setdep -r src/third_party/swiftshader@abaecd5f2ba7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5fcc4a36c569f666c3480da4350526c7e8035354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573225 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652038} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7f9ec907dc88780d79d8cb1a6dd8466a05cb6256 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 18 05:07:00 2019 +0000 Make blink::WebGestureEvent a scoped enum. Also remove the sentinel count value in favor of kMaxValue: the chrome clang plugin checks that this value is correctly set in scoped enumerations. Bug: 742517 Tbr: alexmos@chromium.org Tbr: rdevlin.cronin@chromium.org Tbr: tdresser@chromium.org Tbr: thestig@chromium.org Tbr: wjmaclean@chromium.org Change-Id: Ic3227bb2864791512ce9c3eeecf2c114794c2261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570481 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#652037} .../apps/guest_view/web_view_browsertest.cc | 4 +- .../browser/apps/platform_apps/app_browsertest.cc | 2 +- chrome/browser/pdf/pdf_extension_test.cc | 6 +- .../chrome_site_per_process_browsertest.cc | 4 +- components/guest_view/browser/guest_view_base.cc | 3 +- .../accessibility/hit_testing_browsertest.cc | 4 +- .../frame_host/render_widget_host_view_guest.cc | 2 +- .../input/compositor_event_ack_browsertest.cc | 4 +- .../renderer_host/input/fling_browsertest.cc | 8 +- .../renderer_host/input/fling_controller.cc | 36 ++++--- .../input/fling_controller_unittest.cc | 71 +++++++------ .../input/fling_scheduler_unittest.cc | 4 +- .../input/gesture_event_queue_unittest.cc | 65 ++++++------ .../renderer_host/input/input_router_impl.cc | 2 +- .../input/input_router_impl_unittest.cc | 113 ++++++++++---------- .../input/mock_input_router_client.cc | 2 +- .../renderer_host/input/mouse_wheel_event_queue.cc | 10 +- .../input/mouse_wheel_event_queue_unittest.cc | 2 +- .../render_widget_host_latency_tracker_unittest.cc | 20 ++-- .../input/scroll_latency_browsertest.cc | 5 +- .../input/synthetic_gesture_target_android.cc | 2 +- .../input/synthetic_gesture_target_base.cc | 4 +- .../input/synthetic_smooth_move_gesture.cc | 4 +- .../input/synthetic_touchpad_pinch_gesture.cc | 6 +- .../renderer_host/input/touch_action_filter.cc | 2 +- .../input/touch_action_filter_unittest.cc | 4 +- .../browser/renderer_host/input/touch_emulator.cc | 4 +- .../input/touchpad_pinch_browsertest.cc | 12 +-- .../input/touchpad_pinch_event_queue_unittest.cc | 8 +- .../input/web_input_event_builders_android.cc | 2 +- .../input/web_input_event_builders_mac.mm | 2 +- .../input/web_input_event_util_unittest.cc | 2 +- .../input/wheel_scroll_latching_browsertest.cc | 2 +- .../browser/renderer_host/overscroll_controller.cc | 6 +- .../overscroll_controller_unittest.cc | 118 ++++++++++----------- .../renderer_host/render_widget_host_impl.cc | 43 ++++---- .../renderer_host/render_widget_host_impl.h | 7 +- .../render_widget_host_input_event_router.cc | 39 +++---- ...nder_widget_host_input_event_router_unittest.cc | 22 ++-- .../renderer_host/render_widget_host_unittest.cc | 14 +-- .../render_widget_host_view_android.cc | 9 +- .../renderer_host/render_widget_host_view_aura.cc | 2 +- .../render_widget_host_view_aura_unittest.cc | 86 +++++++-------- .../renderer_host/render_widget_host_view_base.cc | 2 +- .../render_widget_host_view_child_frame.cc | 4 +- ...render_widget_host_view_child_frame_unittest.cc | 18 ++-- .../renderer_host/render_widget_host_view_cocoa.mm | 3 +- .../render_widget_host_view_event_handler.cc | 5 +- .../renderer_host/render_widget_host_view_mac.mm | 3 +- .../renderer_host/render_widget_targeter.cc | 4 +- content/browser/site_per_process_browsertest.cc | 20 ++-- .../site_per_process_hit_test_browsertest.cc | 22 ++-- .../web_contents_view_aura_browsertest.cc | 8 +- .../common/input/gesture_event_stream_validator.cc | 4 +- .../gesture_event_stream_validator_unittest.cc | 2 +- .../common/input/input_event_stream_validator.cc | 2 +- content/common/input_messages.h | 2 +- content/public/test/browser_test_utils.cc | 22 ++-- content/public/test/render_view_test.cc | 2 +- .../renderer/input/render_widget_input_handler.cc | 2 +- .../renderer/render_widget_fullscreen_pepper.cc | 2 +- content/shell/test_runner/event_sender.cc | 18 ++-- .../browser/app_window/app_web_contents_helper.cc | 3 +- .../blink/public/platform/web_gesture_device.h | 14 +-- .../blink/public/platform/web_gesture_event.h | 10 +- .../blink/public/web/web_active_fling_parameters.h | 2 +- .../core/events/web_input_event_conversion_test.cc | 34 +++--- .../blink/renderer/core/exported/web_frame_test.cc | 16 +-- .../core/exported/web_plugin_container_test.cc | 2 +- .../blink/renderer/core/exported/web_view_impl.cc | 2 +- .../blink/renderer/core/exported/web_view_test.cc | 30 +++--- .../renderer/core/frame/browser_controls_test.cc | 4 +- .../renderer/core/frame/visual_viewport_test.cc | 4 +- .../renderer/core/input/event_handler_test.cc | 14 +-- .../blink/renderer/core/input/ime_on_focus_test.cc | 2 +- .../core/input/overscroll_behavior_test.cc | 6 +- .../blink/renderer/core/input/scroll_manager.cc | 16 +-- .../blink/renderer/core/input/scroll_snap_test.cc | 6 +- .../blink/renderer/core/layout/scrollbars_test.cc | 2 +- .../core/page/scrolling/root_scroller_test.cc | 4 +- .../core/page/scrolling/scroll_metrics_test.cc | 16 +-- .../core/paint/link_highlight_impl_test.cc | 12 +-- .../blink/renderer/core/scroll/scrollbar.cc | 12 +-- ui/events/blink/blink_event_util.cc | 24 +++-- ui/events/blink/blink_event_util_unittest.cc | 6 +- ui/events/blink/fling_booster_unittest.cc | 19 ++-- ui/events/blink/input_handler_proxy.cc | 41 +++---- ui/events/blink/input_handler_proxy_unittest.cc | 53 ++++----- .../input_scroll_elasticity_controller_unittest.cc | 6 +- ui/events/blink/scroll_predictor.cc | 2 +- ui/events/blink/scroll_predictor_unittest.cc | 6 +- ui/events/blink/web_input_event.cc | 4 +- ui/events/blink/web_input_event_traits.cc | 6 +- ui/events/gestures/blink/web_gesture_curve_impl.cc | 2 +- 94 files changed, 652 insertions(+), 640 deletions(-) commit e1264c1a572117e0eb955d4db1c1caaf08990fcb Author: Anthony Steinhauser <asteinhauser@google.com> Date: Thu Apr 18 05:03:10 2019 +0000 Removing dead safebrowsing flags. Bug: 74848 Change-Id: Id6d2a1c102ea390a10f2d7fae352a309468259fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573241 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#652036} components/safe_browsing/common/safebrowsing_switches.cc | 12 ------------ components/safe_browsing/common/safebrowsing_switches.h | 2 -- 2 files changed, 14 deletions(-) commit d5f1b6e3b2c508c52ac4874cd5ed4fea8b60ba68 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Apr 18 04:17:25 2019 +0000 Update profile menu edges for overflow. Top corners of profile menus are sharper than bottom corners, probably due to an overflow of the content on the edges. A 2 pixel margin is added to the top (which was already added to the bottom) to over come the issue. See https://screenshot.googleplex.com/x66vzNYUO7z for screenshots of current state. Bug: 950854 Change-Id: I4398d0483243fde8bdac71fa3986da9bb6a07da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570169 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#652035} chrome/browser/ui/views/profiles/profile_menu_view_base.cc | 4 ---- 1 file changed, 4 deletions(-) commit 5f6e2bb187b96fbc682f60c8875ad64513936ad0 Author: Aleks Totic <atotic@chromium.org> Date: Thu Apr 18 04:15:46 2019 +0000 [LayoutNG] Use LayoutObject::ComputeIsAbsoluteContainer when possible Another replacement for Style::IsAbsoluteContainer Bug: 740993 Change-Id: Ib25e916b99ac97d3b06149d5cfc70731d83cec8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572964 Auto-Submit: Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#652034} third_party/blink/renderer/core/layout/layout_block.cc | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) commit d512301e7cd8217c764370547aa7a1421bfd6876 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Apr 18 04:14:45 2019 +0000 Update SandboxFileSystemBackendUnittest for in-memory file system. SandboxFileSystemBackedUnittest is updated to run tests for both enabled and disabled cases of in-memory file system. It's also updated to expect root path for incognito mode if in-memory file system is enabled and file system type is temporary. Bug: 93417 Change-Id: I9bcd586560ed0bbbb31e370c37b3e73262cc66b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571408 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#652033} .../sandbox_file_system_backend_unittest.cc | 43 ++++++++++++++++------ 1 file changed, 31 insertions(+), 12 deletions(-) commit b4f359b086cba5be55547714ccd213d7a85fec31 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 04:08:33 2019 +0000 Roll src/third_party/chromite 2b492ccf0cbc..18b3cbd0b9cc (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/2b492ccf0cbc..18b3cbd0b9cc git log 2b492ccf0cbc..18b3cbd0b9cc --date=short --no-merges --format='%ad %ae %s' 2019-04-18 jclinton@chromium.org config: Unbreak head from chump Created with: gclient setdep -r src/third_party/chromite@18b3cbd0b9cc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I3b7f6400da70fb50bfb5a87bdc2a65437bfccd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573339 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652032} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f968f64cdf27ad20bafeb7596c3db8c3f9f72e4a Author: Meredith Lane <meredithl@chromium.org> Date: Thu Apr 18 03:52:40 2019 +0000 Decouples AOM boolean properties from the accessibility tree This change is the first in a series that will remove the ability for AOM to modify the underlying accessibility tree. These change will be introduced in separate CLs for each property type, the first being boolean attributes. This change comes about due to changes in the API, an explanation of which can be found at: https://github.com/WICG/aom/blob/gh-pages/explainer.md#what-happened-to-accessiblenode BUG=746523 Change-Id: Ia8042aef643c1394e582df44e0fea95ac8eef624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570329 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#652031} .../blink/renderer/core/aom/accessible_node.cc | 7 ------ .../accessibility_object_model_test.cc | 6 ++++-- .../accessibility/aom-boolean-properties.html | 25 ++++++++++++---------- 3 files changed, 18 insertions(+), 20 deletions(-) commit 81d476b01dc71b90eccc60fc50749e49bcd1296b Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Apr 18 03:51:40 2019 +0000 Update V8 to version 7.5.289. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/35b9bf5c..409e6bfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iafe33a04783972b72c6693690c755ce1c5c1cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572960 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652030} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aedf146b408063395221d9778649e80e02f7935b Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 03:49:10 2019 +0000 Roll src-internal 7a9beaaff358..d7524794413f (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a9beaaff358..d7524794413f Created with: gclient setdep -r src-internal@d7524794413f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I4d2638f35816804d2ef0cee2db99f96b7e1b6821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573338 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652029} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 07ada9d595637a00a0453b96a443a8373fdf61f4 Author: Ken Buchanan <kenrb@chromium.org> Date: Thu Apr 18 03:44:00 2019 +0000 Track transport usage for WebAuthentication in UMA This adds an UMA histogram to track prominence of different transports used for security key authenticatiion in WebAuthn. Bug: 803825 Change-Id: Iab71f69b7a4d919dd225e2a88c8b147c933c6258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572285 Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#652028} device/fido/fido_transport_protocol.h | 14 +++++++++----- device/fido/get_assertion_request_handler.cc | 7 +++++++ tools/metrics/histograms/enums.xml | 8 ++++++++ tools/metrics/histograms/histograms.xml | 11 +++++++++++ 4 files changed, 35 insertions(+), 5 deletions(-) commit f0234451437784b3bdc8ec1ee03a0cd5bbe582b4 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Thu Apr 18 03:39:22 2019 +0000 Fixed an exception in sharing This is very similar to the crash fixed with CL : https://chromium-review.googlesource.com/c/chromium/src/+/1562252 Bug: 930108 Change-Id: I64a61f66a6234e0a106bcec77449136b4e44c61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570254 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#652027} .../download/home/list/DateOrderedListCoordinator.java | 13 +++++++++++-- .../chrome/browser/download/ui/DownloadManagerUi.java | 2 ++ 2 files changed, 13 insertions(+), 2 deletions(-) commit 225bd3fe1310a55d5b5b33bbc0a74e58379e0ea2 Author: Alexey Baskakov <loyso@chromium.org> Date: Thu Apr 18 03:39:17 2019 +0000 WebApp: Move web_app_utils.* to components/web_app_utils.* Bug: 877898 Change-Id: I8c88f2040e16ba1002e15d0f03d7ec3e92cb622e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572761 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#652026} chrome/browser/chromeos/BUILD.gn | 1 + chrome/browser/chromeos/android_sms/android_sms_service_factory.cc | 2 +- chrome/browser/ui/web_applications/web_app_metrics_factory.cc | 2 +- .../browser/ui/web_applications/web_app_ui_delegate_impl_factory.cc | 2 +- chrome/browser/web_applications/BUILD.gn | 2 -- .../browser/web_applications/bookmark_apps/test_web_app_provider.cc | 2 +- chrome/browser/web_applications/components/BUILD.gn | 2 ++ chrome/browser/web_applications/{ => components}/web_app_utils.cc | 2 +- chrome/browser/web_applications/{ => components}/web_app_utils.h | 6 +++--- chrome/browser/web_applications/web_app_database_factory.cc | 2 +- chrome/browser/web_applications/web_app_icon_manager.cc | 2 +- chrome/browser/web_applications/web_app_install_manager.cc | 2 +- chrome/browser/web_applications/web_app_install_task.cc | 2 +- chrome/browser/web_applications/web_app_install_task_unittest.cc | 2 +- chrome/browser/web_applications/web_app_provider.cc | 2 +- chrome/browser/web_applications/web_app_provider_factory.cc | 2 +- chrome/browser/web_applications/web_app_utils_unittest.cc | 2 +- 17 files changed, 19 insertions(+), 18 deletions(-) commit 7b227441f53192499ca57e905aaad26336031768 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 03:31:55 2019 +0000 Roll src/third_party/swiftshader 7945a51e1075..d853c12d34f5 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/7945a51e1075..d853c12d34f5 git log 7945a51e1075..d853c12d34f5 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 bclayton@google.com Reactor: Add support for calling C functions. 2019-04-18 bclayton@google.com Reactor: Expose Capabilities. Created with: gclient setdep -r src/third_party/swiftshader@d853c12d34f5 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/130746922,chromium:b/130746922 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id81e7003afb87d792f04652f4523633119a075ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572679 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652025} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7a43745c80454b65e1e8f7fe5c2a97fd1c02ddb7 Author: Noel Gordon <noel@chromium.org> Date: Thu Apr 18 03:29:15 2019 +0000 [piexwasm] tests.html: remove an unused parameter ImageBuffer.process() stopped using the |reject| parameter a while ago so let's clean up. Bug: 935285 Change-Id: I80578d5d511a8361f96a96fd6b60e6d80a886f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572987 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#652024} ui/file_manager/image_loader/piex/tests.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit de74cef322e878f308d03f3d85043fb27a91978f Author: Bo Liu <boliu@chromium.org> Date: Thu Apr 18 03:27:29 2019 +0000 android: Allow removing max connection in content Add constructors that remove assumptions that there is a fixed maximum number of service connections. Nothing uses the new constructors yet except for tests, so should be no change in behavoir. ChildProcessRanking changes is somewhat substantial, changing from array to ArrayList. Bug: 953307 Change-Id: If6842edc95a4a8a0906b757c30102fde83ee5e1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570695 Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#652023} .../chromium/content/browser/BindingManager.java | 20 +++++-- .../content/browser/ChildProcessRanking.java | 66 +++++++++++++--------- .../content/browser/ChildProcessRankingTest.java | 34 ++++++++++- 3 files changed, 88 insertions(+), 32 deletions(-) commit 5f1445229949812cab0486f36177c3d7ae80d5a8 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Thu Apr 18 03:17:11 2019 +0000 Updating trunk VERSION from 3769.0 to 3770.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I593f8bf631e6eecf67872d4f46f10bc5dfaafa2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573177 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#652022} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c4cc8923cb2d21452358814a411642603af3d337 Author: Shivani Sharma <shivanisha@chromium.org> Date: Thu Apr 18 03:11:17 2019 +0000 History intervention: same document entries to be marked skippable together. consider the case: 1. [A, A#1, click, B] At this time both A and A#1 are non-skippable due to the click. 2. Go back. A#1 is now the "current entry". A and A#1 are still non-skippable. 3. Let it now redirect without any user gesture to C [A, A#1 (skippable), C] At this time A#1 is marked as skippable but A is not. With this Cl both A and A#1 will be marked as skippable. Bug: 907167 Change-Id: I5c2889d3e0e7d81b209ec828bab799d2b99aa11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558157 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#652021} .../frame_host/navigation_controller_impl.cc | 61 +++------- .../frame_host/navigation_controller_impl.h | 8 ++ .../navigation_controller_impl_browsertest.cc | 128 +++++++++++++++++++++ 3 files changed, 155 insertions(+), 42 deletions(-) commit 76c21d89914a72d9486fea90a5e01f3c51ac5401 Author: Robert Ogden <robertogden@chromium.org> Date: Thu Apr 18 03:05:14 2019 +0000 Disable the Data Saver Overflow Menu Item in the Tab Switcher UX asked that we not show the Data Saver item in the tab switcher. See bug for more details. Bug: 952101 Change-Id: I48b06a330a8a19d2095c01def1bef9366eda907a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570477 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#652020} .../java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 3285102e40f3917ae7b057be2784587478275c48 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Thu Apr 18 03:00:54 2019 +0000 Refactor SignedExchangeHandlerTest This is a follow-up to https://crrev.com/c/1569371. Adds utility functions to simplify test cases' setup. Bug: 953165 Change-Id: I3bc29aa75c4f65542db9c0f5abd82686813e73c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572763 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#652019} .../signed_exchange_handler_unittest.cc | 402 +++++---------------- 1 file changed, 95 insertions(+), 307 deletions(-) commit 03006281aa823d5fa0b2e72ad12d514221433970 Author: Matt Reynolds <mattreynolds@google.com> Date: Thu Apr 18 02:57:03 2019 +0000 Add IDL and stub implementations for WebHID types This CL adds IDL for types that will be used for the WebHID API. BUG=890096 Change-Id: I4f4db2250aec05c38516fd663d52a3434c28c8b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559344 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#652018} .../public/mojom/web_feature/web_feature.mojom | 7 ++ .../renderer/core/events/event_type_names.json5 | 1 + .../modules/event_target_modules_names.json5 | 1 + third_party/blink/renderer/modules/hid/BUILD.gn | 12 +++ third_party/blink/renderer/modules/hid/DEPS | 1 + third_party/blink/renderer/modules/hid/hid.cc | 24 ++++++ third_party/blink/renderer/modules/hid/hid.h | 19 ++++- third_party/blink/renderer/modules/hid/hid.idl | 20 ++++- .../renderer/modules/hid/hid_collection_info.cc | 60 +++++++++++++ .../renderer/modules/hid/hid_collection_info.h | 45 ++++++++++ .../renderer/modules/hid/hid_collection_info.idl | 32 +++++++ .../renderer/modules/hid/hid_connection_event.cc | 36 ++++++++ .../renderer/modules/hid/hid_connection_event.h | 34 ++++++++ .../renderer/modules/hid/hid_connection_event.idl | 15 ++++ .../modules/hid/hid_connection_event_init.idl | 11 +++ .../blink/renderer/modules/hid/hid_device.cc | 98 ++++++++++++++++++++++ .../blink/renderer/modules/hid/hid_device.h | 67 +++++++++++++++ .../blink/renderer/modules/hid/hid_device.idl | 65 ++++++++++++++ .../renderer/modules/hid/hid_device_filter.idl | 13 +++ .../modules/hid/hid_device_request_options.idl | 10 +++ .../renderer/modules/hid/hid_input_report_event.cc | 41 +++++++++ .../renderer/modules/hid/hid_input_report_event.h | 43 ++++++++++ .../modules/hid/hid_input_report_event.idl | 16 ++++ .../modules/hid/hid_input_report_event_init.idl | 12 +++ .../blink/renderer/modules/hid/hid_report_info.cc | 29 +++++++ .../blink/renderer/modules/hid/hid_report_info.h | 35 ++++++++ .../blink/renderer/modules/hid/hid_report_info.idl | 20 +++++ .../blink/renderer/modules/hid/hid_report_item.cc | 17 ++++ .../blink/renderer/modules/hid/hid_report_item.h | 48 +++++++++++ .../blink/renderer/modules/hid/hid_report_item.idl | 82 ++++++++++++++++++ .../blink/renderer/modules/hid/navigator_hid.idl | 2 +- .../blink/renderer/modules/modules_idl_files.gni | 10 +++ ...d-properties-after-frame-navigated-expected.txt | 2 + ...rties-after-frame-removed-and-gced-expected.txt | 2 + ...hed-properties-after-frame-removed-expected.txt | 2 + ...ached-window-after-frame-navigated-expected.txt | 2 + ...rties-after-frame-removed-and-gced-expected.txt | 2 + ...hed-properties-after-frame-removed-expected.txt | 2 + .../global-interface-listing-expected.txt | 68 +++++++++++++++ tools/metrics/histograms/enums.xml | 7 ++ 40 files changed, 1009 insertions(+), 4 deletions(-) commit c3e0677a29bd3822c16cc236fd8b76bc3bf0362d Author: Suman Kancherla <sumankancherla@chromium.org> Date: Thu Apr 18 02:52:49 2019 +0000 [ui/vr] On WMR, make initial indicators timeout to 10sec WMR has this long animation sequence that lasts for about 7sec after the VR presentation starts. During this time, initial indicators displaying granted permissions, timeout and disappear. So, this change makes the timeout for WMR alone to be 10sec. Bug: 952491 Change-Id: Ic98c11ddff0b167409a762929ca6424352bd4aa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573097 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#652017} chrome/browser/vr/BUILD.gn | 1 + chrome/browser/vr/ui_host/vr_ui_host_impl.cc | 16 +++++++++++++++- chrome/browser/vr/ui_host/vr_ui_host_impl.h | 1 + chrome/browser/vr/ui_scene_constants.h | 1 + chrome/browser/vr/ui_scene_creator.cc | 13 ++++++++++++- chrome/browser/vr/ui_unittest.cc | 6 ++++-- 6 files changed, 34 insertions(+), 4 deletions(-) commit aec905fd62a9e44d78a3046c235a3722a1bc5fd1 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 02:51:29 2019 +0000 Roll src-internal 9b00cca25d78..7a9beaaff358 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b00cca25d78..7a9beaaff358 Created with: gclient setdep -r src-internal@7a9beaaff358 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: Iad38d4559526f13712369cd4248ceec421a8f532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573280 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652016} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd81063126427d9c967f134f6d87f481cb470fab Author: Suman Kancherla <sumankancherla@chromium.org> Date: Thu Apr 18 02:49:39 2019 +0000 [ui/vr] Enable in-headset notification on screen capture request. When a getDisplayMedia() request comes in while the user has a VR headset on, there is no way they can figure out that their intervention is needed on the browser. This change shows an in-headset notification about the external prompt. Bug: 950142 Change-Id: Ib163d03b9a717de2cf8c6029fa33f2a60d7fe09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561961 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#652015} chrome/browser/BUILD.gn | 2 + .../media/webrtc/desktop_media_picker_manager.cc | 34 +++++++++++++++ .../media/webrtc/desktop_media_picker_manager.h | 51 ++++++++++++++++++++++ .../desktop_capture/desktop_media_picker_views.cc | 5 +++ .../desktop_media_picker_views_unittest.cc | 14 +++++- chrome/browser/vr/ui_host/vr_ui_host_impl.cc | 49 ++++++++++++++------- chrome/browser/vr/ui_host/vr_ui_host_impl.h | 10 ++++- 7 files changed, 147 insertions(+), 18 deletions(-) commit 232de609da51c47fa557f386782217f8a89bb267 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 02:44:51 2019 +0000 Roll src/third_party/catapult 2b57c67c9177..4e967e7e447d (1 commits) https://chromium.googlesource.com/catapult.git/+log/2b57c67c9177..4e967e7e447d git log 2b57c67c9177..4e967e7e447d --date=short --no-merges --format='%ad %ae %s' 2019-04-18 crouleau@chromium.org [Telemetry] Clean up local server process handle to remove red herring. Created with: gclient setdep -r src/third_party/catapult@4e967e7e447d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953365 TBR=oysteine@chromium.org Change-Id: I213bae136dd47940d7eb5793428141423bf8be8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573279 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652014} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 012bea0a560626025f95799134741a0aa59f0b2c Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Thu Apr 18 02:34:59 2019 +0000 [autofill assistant] Introduce small delay between key presses. Introduce a small delay between key presses while simulate_key_presses is true. This hopefully will allow any JS from the website to have time to process the events. Bug: b/124505757 Change-Id: I3ab90bde3434043ae9988a9e0b7ff43fdf6e86fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567920 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#652013} .../browser/actions/action_delegate.h | 2 + .../browser/actions/autofill_action.cc | 1 + .../browser/actions/mock_action_delegate.h | 4 +- .../browser/actions/set_form_field_value_action.cc | 7 ++- .../autofill_assistant/browser/script_executor.cc | 10 +++- .../autofill_assistant/browser/script_executor.h | 2 + .../autofill_assistant/browser/service.proto | 6 ++ .../autofill_assistant/browser/web_controller.cc | 44 ++++++++++---- .../autofill_assistant/browser/web_controller.h | 11 +++- .../browser/web_controller_browsertest.cc | 67 ++++++++++++++++++++-- .../autofill_assistant_target_website.html | 15 +++++ 11 files changed, 147 insertions(+), 22 deletions(-) commit 413428528973b12945a7e1bc2693b942a898aa78 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 02:23:53 2019 +0000 Roll src/third_party/chromite d11b57d42ec0..2b492ccf0cbc (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/d11b57d42ec0..2b492ccf0cbc git log d11b57d42ec0..2b492ccf0cbc --date=short --no-merges --format='%ad %ae %s' 2019-04-18 tomhughes@chromium.org chromeos_config: make moblab-generic-vm experimental Created with: gclient setdep -r src/third_party/chromite@2b492ccf0cbc The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I9fc74850905210dbf5e124e7142b27417e3e747c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573278 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652012} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 43576c308180811d93ab808b1f18e07e0b0242d8 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Apr 18 02:21:25 2019 +0000 Android: Trigger history navigation with edge swipe This CL hooks up to history navigation logic swipe gesture from left/right edge. For native pages, this is still driven by HistoryNavigationLayout. Most of the changes have to do with rendered pages which relied on SwipeRefreshHandler where the overscroll event were plumbed. Now touch events are fed to NavigationHandler at ContentView for Tab. TabContentViewDelegate is an implementation of ContentView.Delegate that takes care of it. Bug: 925242 Change-Id: Ifddd5c8473226ef0d01d48155f5a58bd3dc0bbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547547 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#652011} chrome/android/chrome_java_sources.gni | 3 +- chrome/android/chrome_test_java_sources.gni | 1 + .../chrome/browser/feed/FeedNewTabPage.java | 1 + .../java/res/layout/explore_sites_page_layout.xml | 1 + .../android/java/res/layout/recent_tabs_page.xml | 1 + .../chrome/browser/SwipeRefreshHandler.java | 17 +-- .../chrome/browser/bookmarks/BookmarkManager.java | 9 ++ .../chrome/browser/bookmarks/BookmarkPage.java | 1 + .../chrome/browser/download/DownloadPage.java | 1 + .../download/home/DownloadManagerCoordinator.java | 7 +- .../home/DownloadManagerCoordinatorImpl.java | 6 + .../browser/download/ui/DownloadManagerUi.java | 4 + .../browser/explore_sites/ExploreSitesPage.java | 7 +- .../gesturenav/HistoryNavigationLayout.java | 63 ++++---- .../browser/gesturenav/NavigationHandler.java | 142 ++++++++++-------- .../chrome/browser/history/HistoryManager.java | 9 ++ .../chrome/browser/history/HistoryPage.java | 1 + .../chrome/browser/ntp/IncognitoNewTabPage.java | 1 + .../chrome/browser/ntp/NewTabPageView.java | 1 + .../chrome/browser/ntp/RecentTabsManager.java | 8 + .../chrome/browser/ntp/RecentTabsPage.java | 7 +- .../src/org/chromium/chrome/browser/tab/Tab.java | 7 +- .../chrome/browser/tab/TabContentViewDelegate.java | 81 +++++++++++ .../chromium/chrome/browser/tab/TabHelpers.java | 5 + .../widget/selection/SelectableListLayout.java | 8 + .../browser/download/DownloadActivityTest.java | 1 + .../download/home/DownloadActivityV2Test.java | 1 + .../browser/gesturenav/NavigationHandlerTest.java | 162 +++++++++++++++++++++ .../embedder_support/view/ContentView.java | 35 +++++ .../android/overscroll_controller_android.cc | 19 ++- ui/android/overscroll_refresh.cc | 25 +++- ui/android/overscroll_refresh.h | 14 +- ui/android/overscroll_refresh_unittest.cc | 47 +++--- 33 files changed, 547 insertions(+), 149 deletions(-) commit ea12ae0847a9b0417225989ef4054cc5b74a53aa Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Apr 18 02:16:18 2019 +0000 Async Clipboard: Rename tests and group tests in directories. New directories (relative paths from //src/third_party/blink/web_tests/): - `{clipboard/async-clipboard,external/wpt/clipboard-apis}/text-write-read`, to hold text R/W tests. - `external/wpt/clipboard-apis/events`, to hold tests ensuring firing of copy/cut/paste events. - 'clipboard/async-clipboard/permissions`, to hold tests testing for granted/denied permissions properly allowing/denying a readText/writeText command. File renames: - Instead of `read-text` meaning a call to `navigator.clipboard.readText`, and `read-blobtext` meaning a call to navigator.clipboard.write(ClipboardItem with text), tests are now named as per function call names, for `readText` and `read`. Similar for write functions. Bug: 952650 Change-Id: I605577142a778f8aaaad38a947473cf21c962987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570707 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#652010} third_party/blink/web_tests/NeverFixTests | 16 ++++++++-------- .../readText-denied.https.html} | 6 +++--- .../readText-granted.https.html} | 6 +++--- .../writeText-denied.https.html} | 6 +++--- .../writeText-granted.https.html} | 6 +++--- .../async-write-read.https.html} | 6 +++--- .../async-write-readText.https.html} | 6 +++--- .../async-writeText-read.https.html} | 6 +++--- .../async-writeText-readText.https.html} | 6 +++--- .../clipboard-apis/{ => events}/copy-event-manual.html | 0 .../clipboard-apis/{ => events}/cut-event-manual.html | 0 .../clipboard-apis/{ => events}/paste-event-manual.html | 0 .../async-write-read-manual.https.html} | 0 .../async-write-readText-manual.https.html} | 0 .../async-writeText-read-manual.https.html} | 0 .../async-writeText-readText-manual.https.html} | 0 16 files changed, 32 insertions(+), 32 deletions(-) commit b8fc51279ab9473241d9e0ddece0091ecf582dfb Author: Gayane Petrosyan <gayane@chromium.org> Date: Thu Apr 18 02:09:27 2019 +0000 [Chrome colors] Color work for autogenerated themes. One more interation of a color generation for autogenerated theme. Given an initial color we try to generate a second color that will have enough contrast with the first color as well as white or dark grey text will have enough contrast on both colors. If that proves not possible then we darken the initial color and start again. Bug: 930202 Change-Id: I17528ac64a5789e8e9e22e5c7dfdd160819b6da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565164 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#652009} chrome/browser/themes/browser_theme_pack.cc | 203 +++++++++++++++------ chrome/browser/themes/browser_theme_pack.h | 16 +- .../browser/themes/browser_theme_pack_unittest.cc | 111 +++++++++-- ui/gfx/color_utils.cc | 10 +- ui/gfx/color_utils.h | 13 +- 5 files changed, 264 insertions(+), 89 deletions(-) commit 4cb48787ea7f4a59e58305395a737ee0bf24f145 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 01:57:04 2019 +0000 Roll src/third_party/angle e3c7134c2717..82bcffa78747 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/e3c7134c2717..82bcffa78747 git log e3c7134c2717..82bcffa78747 --date=short --no-merges --format='%ad %ae %s' 2019-04-18 jie.a.chen@intel.com Disable parallel compile for d3d11 compute Created with: gclient setdep -r src/third_party/angle@82bcffa78747 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I596be0516b7f024d3e177965e176b80afa030031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572316 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652008} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 722aeb36519752d3f458b120a80b6cc7397652cd Author: Anupam Snigdha <snianu@microsoft.com> Date: Thu Apr 18 01:52:56 2019 +0000 UIA: Fire UIA_TextEdit_TextChangedEventId on composition This change has the initial implementation of firing UIA_TextEdit_TextChangedEventId event. This event is fired whenever TSF notifies of an ongoing or committed composition to accessibility. Bug: 928949 Change-Id: I7c59f4ba9696cda1afbfd7dd9fcf6a07837f09ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566672 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#652007} .../renderer_host/render_widget_host_view_aura.cc | 7 +- .../renderer_host/render_widget_host_view_aura.h | 9 ++- .../ax_platform_node_textprovider_win_unittest.cc | 6 +- ui/accessibility/platform/ax_platform_node_win.cc | 58 ++++++++++++++- ui/accessibility/platform/ax_platform_node_win.h | 13 +++- ui/base/ime/dummy_text_input_client.cc | 4 +- ui/base/ime/dummy_text_input_client.h | 5 +- ui/base/ime/text_input_client.h | 6 +- ui/base/ime/win/tsf_text_store.cc | 25 +++++-- ui/base/ime/win/tsf_text_store_unittest.cc | 85 +++++++++++++++++++++- ui/views/controls/prefix_selector.cc | 4 +- ui/views/controls/prefix_selector.h | 5 +- ui/views/controls/textfield/textfield.cc | 5 +- ui/views/controls/textfield/textfield.h | 5 +- 14 files changed, 213 insertions(+), 24 deletions(-) commit bd145bc1188bfa52f850002cfa5e289fd095b10f Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Apr 18 01:49:03 2019 +0000 Roll src-internal 8d6e1e0bfd92..9b00cca25d78 (11 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d6e1e0bfd92..9b00cca25d78 Created with: gclient setdep -r src-internal@9b00cca25d78 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:130424602 TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: Ifae6b8a8496d6281bcb2819d60d8f41cb10a3b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572315 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652006} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a51f2e012e9002e4dfb2a43d35dda5efa882215b Author: Ben Pastene <bpastene@chromium.org> Date: Thu Apr 18 01:46:10 2019 +0000 Mark all Tast tests as non-idempotent. Tast likes to download things from the internet mid-test. So we can't assume retrying a run will produce the same results. Bug: 923426 Change-Id: I98d3d91a61e9702fe48052197fab25b2c9adf657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573168 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#652005} testing/buildbot/chromium.chromiumos.json | 6 ++++-- testing/buildbot/chromium.fyi.json | 3 +++ testing/buildbot/test_suites.pyl | 22 ++++++++++++++++++---- 3 files changed, 25 insertions(+), 6 deletions(-) commit 61310faedf50da1621ff2d98de291c2c87aeff49 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 01:42:23 2019 +0000 Roll src/third_party/catapult 8f7609127524..2b57c67c9177 (2 commits) https://chromium.googlesource.com/catapult.git/+log/8f7609127524..2b57c67c9177 git log 8f7609127524..2b57c67c9177 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 rmhasan@google.com [Typ] Fixes issue with error message printed for tags from non disjoint tag sets 2019-04-17 crouleau@chromium.org [Telemetry] Log Metrics calculation errors with a stack trace. Created with: gclient setdep -r src/third_party/catapult@2b57c67c9177 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:953076,chromium:953365 TBR=oysteine@chromium.org Change-Id: Ie598e927c14248aeb3f6f3b8dc16c99eef78f863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572312 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652004} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2705e2c73a9a2f526a6ffb271f4fd83cd9af47eb Author: Jia <jiameng@chromium.org> Date: Thu Apr 18 01:26:28 2019 +0000 [On-device adaptive brightness] Log model behaviour. Bug: 881215 Change-Id: I2628aa4cc3116c98d790a9ae38ac03c07dccf2b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570988 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#652003} .../auto_screen_brightness/gaussian_trainer.cc | 89 ++++++++++++++++++++-- tools/metrics/histograms/enums.xml | 9 +++ tools/metrics/histograms/histograms.xml | 28 +++++++ 3 files changed, 118 insertions(+), 8 deletions(-) commit 347fb6774f9df90ef3cdf2cc7e810166064d306b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 01:24:57 2019 +0000 Roll src/third_party/webrtc 797ede8e712f..852bffb6063a (1 commits) https://webrtc.googlesource.com/src.git/+log/797ede8e712f..852bffb6063a git log 797ede8e712f..852bffb6063a --date=short --no-merges --format='%ad %ae %s' 2019-04-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision adf8e94df9..14d9f48eb3 (651832:651940) Created with: gclient setdep -r src/third_party/webrtc@852bffb6063a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic4555e20361779e4e6ea1c80235d15fb337c88d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572314 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652002} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ecfadbde6f0f16b7fa4fbe9bb5b73262283ad9ce Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 01:22:18 2019 +0000 Roll src/third_party/skia e64e6327a156..14c90c1ca218 (1 commits) https://skia.googlesource.com/skia.git/+log/e64e6327a156..14c90c1ca218 git log e64e6327a156..14c90c1ca218 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 bungeman@google.com Reland "Remove includes from SkFontTypes.h" Created with: gclient setdep -r src/third_party/skia@14c90c1ca218 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ia526f14ec9b21e1b287111340b2b3e0dc13d9ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572310 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#652001} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d7b5942c6064b39b7f4055d56041cc7147af21db Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Apr 18 01:19:19 2019 +0000 [Files app] ES6 class for mock_chrome.js Bug: 778674 Change-Id: I40905537692fe2018952a7f3da88cae35b66dcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571326 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#652000} ui/file_manager/base/js/mock_chrome.js | 131 +++++++++++++++++---------------- 1 file changed, 66 insertions(+), 65 deletions(-) commit 7cd8a6a2d9320a0dd6009bb110ec4ae50a2d584a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 01:12:51 2019 +0000 Roll src/third_party/chromite 588e388cd5e2..d11b57d42ec0 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/588e388cd5e2..d11b57d42ec0 git log 588e388cd5e2..d11b57d42ec0 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jrosenth@chromium.org chromeos-config: mark veyron_minnie experimental 2019-04-17 dburger@chromium.org Add a unittest to check config skew, old and new. Created with: gclient setdep -r src/third_party/chromite@d11b57d42ec0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ibcfb3be277c196ae2856fc462d7fd24de4c49bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572313 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651999} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 81a34961fd403563391cb4e08b86454e8678e38a Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Apr 18 01:09:26 2019 +0000 media: Fix non-conformant EGL config for HDR video ANGLE changed eglChooseConfig to be more strict for EGL conformance. That broke HDR video with DXVA since it requests fp16 configs without specifying that color component type is float. This CL fixes that. Bug: 951381 Change-Id: I1bfc8c19ed35a01727c8cbe11314fc5eb07bba21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573000 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#651998} .../windows/dxva_video_decode_accelerator_win.cc | 26 ++++++++++++++-------- ui/gl/gl_surface_egl.cc | 12 ++++++++-- ui/gl/gl_surface_egl.h | 1 + 3 files changed, 28 insertions(+), 11 deletions(-) commit 80d72d8cd21cf76df583e29676b987ac1e3b90e9 Author: Mark Pearson <mpearson@chromium.org> Date: Thu Apr 18 01:04:43 2019 +0000 Omnibox - Add Answer Suggestion Used Histogram to non-Android Platforms Tested interactively using about:histograms Tested interactively. Bug: 950344 Change-Id: I1d391d0a88dddef5c25ee4e1c71181e26e797d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565417 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#651997} .../android/omnibox/autocomplete_controller_android.cc | 11 +---------- components/omnibox/browser/omnibox_edit_model.cc | 2 ++ components/omnibox/browser/suggestion_answer.cc | 13 +++++++++++++ components/omnibox/browser/suggestion_answer.h | 4 ++++ 4 files changed, 20 insertions(+), 10 deletions(-) commit 5d84b4fd097ccae4c6c5fed088c2ab694896e315 Author: Xing Liu <xingliu@chromium.org> Date: Thu Apr 18 01:02:53 2019 +0000 Android notification: Add age metric for send tab to self feature. Previously we have added the age metric for notification content click, action click and dismiss. This CL adds the age metrics for send tab to self feature. Bug: 942743 Change-Id: I4912add324ffce8ab54ba11b6494923011090977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565441 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#651996} .../NotificationIntentInterceptor.java | 2 +- .../notifications/NotificationUmaTracker.java | 25 ++++++++++++++++++---- tools/metrics/histograms/histograms.xml | 16 ++++++++++++++ 3 files changed, 38 insertions(+), 5 deletions(-) commit af13f76d7ebcd4db5afaf58cf5e826db54190385 Author: Alexei Filippov <alph@chromium.org> Date: Thu Apr 18 01:01:15 2019 +0000 [heap profiler] Drop now unused Memlog tests. This is a follow-up for r651916. Change-Id: I48a56c15e25286a0e1c4aeca742f93d5b6808bff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573093 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#651995} .../browser/profiling_host/memlog_browsertest.cc | 44 ++++++++-------------- 1 file changed, 15 insertions(+), 29 deletions(-) commit a709a2315a95fa9871992aa619686af6b14b7cf8 Author: Sammie Quon <sammiequon@google.com> Date: Thu Apr 18 01:00:03 2019 +0000 wallpaper: Cache a downsampled image on first paint. This will make entering overview wallpaper animation more performant as that paints the wallpaper multiple times a second. I tested this by making the wallpaper animate while the overview windows are animating and using the AnimationSmoothness uma stats. It's not the best way and the results have some noise sometimes but I think it's good enought to verify that this is an improvement. Test: manual Bug: 953890 Change-Id: If472e417e667840707ec55a79178d569cda4ca40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573085 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#651994} ash/wallpaper/wallpaper_view.cc | 51 ++++++++++++++++++++++++----------------- ash/wallpaper/wallpaper_view.h | 6 ++++- 2 files changed, 35 insertions(+), 22 deletions(-) commit 5adec40047489f0f7d4acfc2603fd8ed196d59ba Author: Nate Fischer <ntfschr@chromium.org> Date: Thu Apr 18 00:59:14 2019 +0000 AW NS: make SetMojoCookieManager atomic This fixes a race condition that could happen during content layer initialization. If an application initialized WebView (and therefore, content layer) while also modifying the cookie database on a background thread, the most recent modifications would not be persisted, as we would have already began to flush the net::CookieStore to disk (and the edits could go to the CookieStore after it's flushed). To address this, we maintain our own task queue. Normally, we remove tasks almost immediately after they're added to the queue (modulo a thread-hop). However, during SwapMojoCookieManager, we instead don't remove any tasks until the operation is completely done (then, we run all the tasks). Bug: 933461 Test: $ run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess \ Test: -f CookieManagerTest.* Test: $ android_webview/tools/run_cts.py \ Test: -f WebViewDeviceSideStartupTest#* -m CtsWebViewStartupApp.apk Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I99491854339e97cadb1caa94a2ab37637b0c6409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570697 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#651993} android_webview/browser/cookie_manager.cc | 48 ++++++++++++++++++++++++++----- android_webview/browser/cookie_manager.h | 17 ++++++++++- 2 files changed, 57 insertions(+), 8 deletions(-) commit 9b3a1ab54f3f9ef904fbeee218e48a5805a8e47b Author: bsheedy <bsheedy@chromium.org> Date: Thu Apr 18 00:57:40 2019 +0000 Support sandboxed process for VR perf tests Adds support for running the VR perf tests with the sandboxed XR process enabled for runtimes that support it. Also drive-by makes the mock runtime directory default to a subdirectory of the output directory. Bug: 939178, 949619 Change-Id: I4eab49a9f34d83739fe7deb847e02dce6091c35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572557 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#651992} chrome/browser/vr/test/run_xr_browser_tests.py | 14 +++--- tools/perf/contrib/vr_benchmarks/BUILD.gn | 5 ++- .../vr_benchmarks/desktop_runtimes/base_runtime.py | 50 +++++++++++++++++++++- .../desktop_runtimes/openvr_runtimes.py | 16 ++++--- .../vr_benchmarks/desktop_runtimes/wmr_runtimes.py | 3 ++ .../contrib/vr_benchmarks/shared_vr_page_state.py | 4 +- tools/perf/contrib/vr_benchmarks/vr_benchmarks.py | 3 +- 7 files changed, 77 insertions(+), 18 deletions(-) commit 6d7564e72aa0e4efa76630574f8b64e666536e15 Author: Gayane Petrosyan <gayane@chromium.org> Date: Thu Apr 18 00:55:43 2019 +0000 Remove 'Customize' label for narrow windows. Remove 'Customize' label from entry point button when window is too narrow. https://screenshot.googleplex.com/xHEzOCVC4Hi.png Bug: 937969 Change-Id: If66c725e9031f835f8420f4ac47469cb437230d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572866 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#651991} .../resources/local_ntp/custom_backgrounds.css | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) commit de523294b5324babd0beb8c9065f5577a0a8b662 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Apr 18 00:52:13 2019 +0000 gpu: Check for changes in GL headers for autogen files Changes in headers e.g. adding enums can cause changes in autogen files without any changes in generator scripts. Bug: 945670 Change-Id: Ib9b90bbf4ca6209fb3d19219acace9a3ecb3bb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573160 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651990} gpu/command_buffer/PRESUBMIT.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit 0b54fd75ecef33d036c07c9cc73de62d68a97871 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Thu Apr 18 00:46:49 2019 +0000 Ping validity URL (which uses inner request URL for now) on navigations Primarily for measurement. Bug: 952811 Change-Id: I2c161d87e79d7b5416758b4bab0070a533450fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567558 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#651989} content/browser/BUILD.gn | 2 + .../browser/web_package/signed_exchange_loader.cc | 42 +++++- .../browser/web_package/signed_exchange_loader.h | 6 +- .../web_package/signed_exchange_loader_unittest.cc | 95 +++++++++++- .../web_package/signed_exchange_validity_pinger.cc | 163 +++++++++++++++++++++ .../web_package/signed_exchange_validity_pinger.h | 80 ++++++++++ content/public/common/content_features.cc | 4 + content/public/common/content_features.h | 1 + tools/metrics/histograms/enums.xml | 6 + tools/metrics/histograms/histograms.xml | 21 +++ 10 files changed, 405 insertions(+), 15 deletions(-) commit 58225c89a22ef06b86372b40c127243c16d606b8 Author: Alex Moshchuk <alexmos@chromium.org> Date: Thu Apr 18 00:45:01 2019 +0000 Prevent locked processes from being reused for same-site, non-isolated navigations. Previously, RenderProcessHostImpl::IsSuitableHost() allowed a process locked to foo.com to be reused for any navigation to foo.com. However, this is not always correct with dynamic isolated origins, as the foo.com navigation could happen in an older BrowsingInstance where foo.com is not isolated and does not require a dedicated process. In that case, it's wrong to reuse a process to host both the isolated and non-isolated foo.com pages, since the non-isolated foo.com page could later allow other sites into the process locked to foo.com. This CL fixes IsSuitableHost() to check for this case. This bug was caught by a CHECK in SiteInstanceImpl::LockToOriginIfNeeded(), which was firing in Site Isolation Android trials. Bug: 950453 Change-Id: Ic3a894b4455b67c902fdb9d548ff1e742b2ce468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570473 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#651988} .../browser/child_process_security_policy_impl.cc | 26 +-------- .../browser/child_process_security_policy_impl.h | 17 ------ .../frame_host/webui_navigation_browsertest.cc | 16 +++--- content/browser/isolated_origin_browsertest.cc | 60 +++++++++++++++++++-- .../renderer_host/render_process_host_impl.cc | 40 +++++++------- content/browser/site_instance_impl.cc | 62 +++++++++------------- content/browser/site_instance_impl.h | 36 +++++++++---- 7 files changed, 135 insertions(+), 122 deletions(-) commit 4044b161146a34cc16b858732c8367affb4c62e6 Author: dpapad <dpapad@chromium.org> Date: Thu Apr 18 00:44:51 2019 +0000 Fix styleguide violations ServiceWorker debug UI. Specifically only fixing styleguide violations that are caught by presubmit checks. There are more violations (naming of properties, function arguments) which are not addressed in this CL. Bug: None Change-Id: Ifffb06770bc28eb4f759dcb25f267ec8256d4d93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573084 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#651987} .../service_worker/serviceworker_internals.js | 28 +++++++++++----------- 1 file changed, 14 insertions(+), 14 deletions(-) commit 3615b55458f702e7aa3fb929b7c7f67a76bf9b38 Author: rbpotter <rbpotter@chromium.org> Date: Thu Apr 18 00:42:05 2019 +0000 Print Preview: Remove unnecessary border Don't show the border under "More settings" if the system dialog link and open PDF in preview links are both unavailable. Bug: 953664 Change-Id: I8912c839005cf1d09279f0b14bace6217b73e422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572816 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#651986} chrome/browser/resources/print_preview/new/link_container.html | 6 ++++++ chrome/browser/resources/print_preview/new/link_container.js | 1 + 2 files changed, 7 insertions(+) commit d3028bb853ba450f6f0b89bb0e7a3550ad49ed69 Author: Brandon Wylie <wylieb@chromium.org> Date: Thu Apr 18 00:41:36 2019 +0000 [Image Fetcher] Support ImageFetcherConfig of the fetchGIf method Bug: 949331 Change-Id: Ic5f0e0546a97411af50f4f94fe4d9c1c2119d6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572861 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651985} .../chrome/browser/image_fetcher/CachedImageFetcher.java | 10 ++++++---- .../chrome/browser/image_fetcher/ImageFetcherBridge.java | 11 ++++++----- .../chrome/browser/image_fetcher/NetworkImageFetcher.java | 2 +- .../browser/image_fetcher/CachedImageFetcherTest.java | 13 ++++++++----- .../browser/android/image_fetcher/image_fetcher_bridge.cc | 14 ++++++++------ .../browser/android/image_fetcher/image_fetcher_bridge.h | 1 + 6 files changed, 30 insertions(+), 21 deletions(-) commit 463c5456446d5cb63849e34dbd376ec9220218e0 Author: David Staessens <dstaessens@chromium.org> Date: Thu Apr 18 00:40:02 2019 +0000 media/gpu/test: Add test video frame rate to video metadata. This CL adds the test video's frame rate to the metadata .json file associated with each test video. This is required by the new capped video decoder performance test currently being added. TEST=ran new VDA tests on nocturne BUG=925714 Change-Id: I3f692676378adf05e00f2e270370212949fb97dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571123 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#651984} media/gpu/test/video_player/video.cc | 12 ++++++++++++ media/gpu/test/video_player/video.h | 3 +++ media/test/data/test-25fps.h264.json | 1 + media/test/data/test-25fps.vp8.json | 1 + media/test/data/test-25fps.vp9.json | 1 + media/test/data/test-25fps.vp9_2.json | 1 + 6 files changed, 19 insertions(+) commit 7879310fa15b2f25a0252dcaa9f9c2a476625648 Author: Jeff Fisher <jeffish@microsoft.com> Date: Thu Apr 18 00:35:22 2019 +0000 DevTools: Right align overlay buttons This small patch moves the cancel/stop buttons in overlays for Audits and Performance panels to the right edge to align with window.alert() and other browser UX. Audits: https://i.imgur.com/HDJhTIC.png Performance: https://i.imgur.com/C2Qggiv.png Change-Id: I2b338b55cf63b4b8ba5313358965e09564442542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572535 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#651983} .../blink/renderer/devtools/front_end/audits2/audits2Dialog.css | 2 ++ .../renderer/devtools/front_end/timeline/timelineStatusDialog.css | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) commit a49bda7a9d77725756df6585aac2551361d2b58b Author: Aleks Totic <atotic@chromium.org> Date: Thu Apr 18 00:30:19 2019 +0000 [LayoutNG] More correct IsOOF for LayoutInline I've introduced LayoutObject::ComputeIsAbsoluteContainer in this CL https://chromium-review.googlesource.com/c/chromium/src/+/1563432 It should be used if you want to compute whether a particular LayoutObject can be an OOF container. ComputedStyle::CanContainAbsolutePositionObjects misses a lot of cases where LayoutObject properties cause Element to become OOF container. Bug: 740993 Change-Id: I72b2181029889edbc00409f4d97bb1547678c81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572927 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Auto-Submit: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#651982} third_party/blink/renderer/core/layout/layout_inline.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 17af96ee7299fba1ca5dca3882b0fc6135557556 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Thu Apr 18 00:20:16 2019 +0000 [Autofill] Implements GetLabelForProfile for address + contact forms. This implementation has the following changes: 1. Passing the profiles to Create() rather than to GetLabels() to determine whether phone numbers and email addresses should be shown on address + contact forms. This allows us to keep the implementation of GetLabels(), which would be the same for each non-address-plus-contact- form LabelFormatter, in the base class. 2. Adding two functions to label_formatter_utils for helping to determine whether phones and emails should be included in labels. 3. Having LabelFormatters store a reference to the profiles. 4. A bit of clean-up in label_formatter_utils. Screenshots Note that the text in the name fields changes for filtering. Phone and email not shown for 1 suggestion for address plus contact: https://screenshot.googleplex.com/w4aPQY6b3hb Phone not shown when it's the same across all suggestions: https://screenshot.googleplex.com/HEhZWtmSuyk Email not shown when it's the same across all suggestions: https://screenshot.googleplex.com/29xy0kvaVp0 Phone and email not shown when they're the same across all suggestions: https://screenshot.googleplex.com/HuZAest6mfZ Bug: 936168 Change-Id: I52cced242d54d0a3f7c881619fe1c27ae9081714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566373 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#651981} components/autofill/core/browser/BUILD.gn | 1 + .../address_contact_form_label_formatter.cc | 120 ++------ .../browser/address_contact_form_label_formatter.h | 24 +- ...ddress_contact_form_label_formatter_unittest.cc | 333 +++++++++------------ .../address_email_form_label_formatter_unittest.cc | 75 +++-- .../address_form_label_formatter_unittest.cc | 59 ++-- .../address_phone_form_label_formatter_unittest.cc | 74 +++-- .../contact_form_label_formatter_unittest.cc | 72 +++-- .../autofill/core/browser/label_formatter.cc | 8 +- components/autofill/core/browser/label_formatter.h | 21 +- .../core/browser/label_formatter_unittest.cc | 4 +- .../autofill/core/browser/label_formatter_utils.cc | 12 - .../autofill/core/browser/label_formatter_utils.h | 14 - .../core/browser/label_formatter_utils_unittest.cc | 5 +- .../autofill/core/browser/personal_data_manager.cc | 2 +- .../core/browser/personal_data_manager_unittest.cc | 126 ++++++-- 16 files changed, 473 insertions(+), 477 deletions(-) commit a7c573e369487c7978abab5aeb5ccd6cce7b9658 Author: Jarryd <jarrydg@chromium.org> Date: Thu Apr 18 00:19:29 2019 +0000 Quota: Add fileSystem to usage details. Previously, we did not include filesystem in the quota usage details because it's non-standard, and thus the reporting would be non-standard. It makes sense to have now because the new native filesystem API will have some shared storage area with the old filesystem API, so quota will report details for sandboxed filesystem storage. The logic here is that quota should report on all sandboxed storage. Unsandboxed filesystem storage will not be reported in quota - when a user approves storing outside the sandbox, the data belongs to the user instead of the site, so it should not be attributed to the site nor deleted with the rest of the site's data. Bug: 904000 Change-Id: Iab8ccc20f27d3bf093551adb441362cc740103b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570662 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#651980} .../renderer/modules/quota/storage_manager.cc | 3 +++ .../modules/quota/storage_usage_details.idl | 2 +- ...usage-details-filesystem.https.tentative.any.js | 31 ++++++++++++++++++++++ 3 files changed, 35 insertions(+), 1 deletion(-) commit aa3288fba4443d5e390f54e3da85121d54cbd6fc Author: Staphany Park <staphany@chromium.org> Date: Thu Apr 18 00:18:38 2019 +0000 Roll src/third_party/googletest/src/ b617b2771..9f893b995 (13 commits) https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/b617b277186e..9f893b99598b $ git log b617b2771..9f893b995 --date=short --no-merges --format='%ad %ae %s' 2019-04-16 absl-team Googletest export 2019-04-15 absl-team Googletest export 2019-04-12 calvin Sort Haiku platform definition alphabetically. 2019-04-11 calvin Add Haiku platform support. 2019-04-11 rong.ou replace test case with test suite in the primer 2019-04-09 davidben MSVC C5046 warning is unavailable in MSVC 2015. 2019-04-09 rong.ou add missing period 2019-04-07 gennadiycivil Update README.md 2019-04-06 ivo.kirov Update ForDummies.md 2019-04-04 absl-team Googletest export 2019-02-21 yaneurabeya clang: explicitly enable/disable RTTI support with the compiler 2019-04-02 absl-team Googletest export 2019-03-29 yaneurabeya Handle GTEST_SKIP() when calling `Environment::SetUp()` Created with: roll-dep src/third_party/googletest/src Change-Id: I06e82adb0b7ae0cfc318bc3ca5d36748ca8038aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567961 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#651979} DEPS | 2 +- third_party/googletest/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 8fe3bf563f6a4c4b6db131f3373a2f479ffab0e2 Author: Alexander Timin <altimin@chromium.org> Date: Thu Apr 18 00:17:49 2019 +0000 [bfcache] Account for plugins in the bfcache metrics R=haraken@chromium.org BUG=933147 Change-Id: I6c865f40444a9035bdf7eb1e802d0136b586d2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545880 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#651978} .../renderer/core/html/html_plugin_element.cc | 7 ++++++ .../blink/renderer/core/html/plugin_document.cc | 6 +++++ third_party/blink/renderer/core/scheduler/DEPS | 5 +++++ .../scheduler/scheduler_affecting_features_test.cc | 26 ++++++++++++++++++++++ .../platform/scheduler/common/scheduling_policy.cc | 1 + .../platform/scheduler/public/scheduling_policy.h | 4 +++- 6 files changed, 48 insertions(+), 1 deletion(-) commit a2da1cc4338c1694b2fdf020076d3ac80f1413e5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 00:17:26 2019 +0000 Roll src/third_party/swiftshader d1fff586eae3..7945a51e1075 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d1fff586eae3..7945a51e1075 git log d1fff586eae3..7945a51e1075 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 bclayton@google.com Reactor: Add support for printing Longs. Created with: gclient setdep -r src/third_party/swiftshader@7945a51e1075 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I90cec4096a2c54dee129ed0545b920d079db77d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572308 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651977} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 766c2ad9b387457c4538cc702d4a0e5c73dc83f2 Author: Aran Gilman <gilmanmh@google.com> Date: Thu Apr 18 00:15:41 2019 +0000 Add flag to enable reader mode to chrome://flags. This has the same effect as running chrome with --enable-dom-distiller from the command line. Bug: 925965 Change-Id: Ic2438c3a9a4b8db16271eb2483c919c9e3817235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566680 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#651976} chrome/browser/about_flags.cc | 5 +++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 5 +++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 1 + 5 files changed, 19 insertions(+) commit 0139825495101047b860186281365d46ce119d08 Author: Aleks Totic <atotic@chromium.org> Date: Thu Apr 18 00:14:29 2019 +0000 Revert "Reland "Prevent browser tests and wpt from trying to use audio devices."" This reverts commit 054e3fc18c98b5ed665139b85e284da83c12ff7b. Reason for revert: https://crbug.com/953787 Sheriffing Original change's description: > Reland "Prevent browser tests and wpt from trying to use audio devices." > > This is a reland of 72582d8bfb67184986406cd26d8b189342c59bf0 > > Original change's description: > > Prevent browser tests and wpt from trying to use audio devices. > > > > This stops ALSA from logging errors (caused by trying to use audio when > > there is no audio hardware present). These logs currently make up a > > large proportion of any browser_test log on Chrome OS and a few percent > > of any webkit_layout_tests logs on Linux bots. > > > > Bug: 846157 > > Change-Id: I0602ce9a561d2880eb7c968519690bd246525a66 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557024 > > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > > Reviewed-by: Peter Beverloo <peter@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Commit-Queue: Max Morin <maxmorin@chromium.org> > > Auto-Submit: Max Morin <maxmorin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#650205} > > Tbr: sky, guidou > Bug: 846157 > Change-Id: I739fc222cf261f2bad06d6f926ecdab7e743f730 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565977 > Auto-Submit: Max Morin <maxmorin@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Commit-Queue: Max Morin <maxmorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650781} TBR=sky@chromium.org,peter@chromium.org,guidou@chromium.org,olka@chromium.org,maxmorin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846157 Change-Id: I386d362c03723ec4eebc4b50187053f6ff9f0432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573086 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#651975} chrome/browser/media/webrtc/webrtc_browsertest_base.cc | 1 - content/browser/webrtc/webrtc_content_browsertest_base.cc | 2 -- content/public/test/browser_test_base.cc | 12 ------------ content/public/test/browser_test_base.h | 7 ------- content/shell/browser/web_test/web_test_browser_main.cc | 8 -------- 5 files changed, 30 deletions(-) commit 59d399bd76e9cd7fbaa94cec6227905cd7c01a9c Author: Hui(Andy) Wu <wuandy@chromium.org> Date: Thu Apr 18 00:13:59 2019 +0000 [autofill assistant] Build autobot as a DFM and install on demand. Builds autobot as a DFM to reduce binary size. And implement on-demand install for the module, using default UI DFM provided. A future CL will move most of java code to DFM, except AutofillAssistantFacade and an interface to DFM. The reason for this split is to test this CL first before making code structure change, as DFM is currently difficult to test during developing. Change-Id: I3ab98a5e3c02e1c7230eb5d19e73fcc1b6faf257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531288 Commit-Queue: Hui Wu <wuandy@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#651974} chrome/android/BUILD.gn | 19 ++++- .../android/features/autofill_assistant/BUILD.gn | 19 ++++- .../autofill_assistant_module_tmpl.gni | 38 ++++++++++ .../autofill_assistant/java/AndroidManifest.xml | 19 +++++ .../autofill_assistant/DynamicModuleCheckImpl.java | 11 +++ .../details/AssistantDetailsViewBinder.java | 8 +- .../android_chrome_autofill_assistant_strings.grd | 2 +- .../features/autofill_assistant/public/java/DEPS | 1 + .../AutofillAssistantFacade.java | 85 ++++++++++++++++++---- .../autofill_assistant/DynamicModuleCheck.java | 16 ++++ .../autofill_assistant/public/java_sources.gni | 1 + .../features/module_names_to_package_ids.gni | 1 + .../java/strings/android_chrome_strings.grd | 8 ++ components/autofill_assistant/browser/metrics.h | 3 +- tools/metrics/histograms/histograms.xml | 1 + 15 files changed, 209 insertions(+), 23 deletions(-) commit 9c11d08aaca61243560e05a515f8048ba32f8944 Author: Daniel Rubery <drubery@chromium.org> Date: Thu Apr 18 00:11:41 2019 +0000 Populate is_incognito in download pings We don't send CSBRRs for dangerous download recovery while Incognito. This means we can't measure CTR for Incognito downloads. To fix that, we can populate this field, and discard dowload pings while Incognito. Change-Id: I549a1669f1555cad8bb4667c622aaf6f02567de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572530 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#651973} .../safe_browsing/download_protection/check_client_download_request.cc | 1 + 1 file changed, 1 insertion(+) commit 23c23b32cff527e9a6d089598952c05a4a5c9032 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 18 00:04:56 2019 +0000 Roll src/third_party/chromite 5a01970efa3a..588e388cd5e2 (4 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/5a01970efa3a..588e388cd5e2 git log 5a01970efa3a..588e388cd5e2 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jrosenth@chromium.org chromeos-config: mark guado, guado_moblab important 2019-04-17 jrosenth@chromium.org chromeos-config: mark lakitu experimental 2019-04-17 jrosenth@chromium.org chromeos-config: mark gale, whirlwind, cyan experimental 2019-04-17 dhanyaganesh@chromium.org auth.py: Don't mute output on login Created with: gclient setdep -r src/third_party/chromite@588e388cd5e2 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iadc312e45fef8df9056c8768c2e8a885dab6ff15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572643 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651972} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5935a30196ef32c54157c0f377cc16d33dfb998a Author: Rahul Arakeri <arakeri@microsoft.com> Date: Thu Apr 18 00:04:44 2019 +0000 [Reland] Compositor threaded scrollbar scrolling - part 1 The original CL failed layout tests on Mac. The reason is that the MockScrollbars on Mac are different from that on Windows and Linux (crbug.com/953847). This caused the newly added layout tests to fail. Additionally, web tests are not run on mac-rel which is why this wasn't caught earlier. Reverted CL: https://chromium-review.googlesource.com/c/chromium/src/+/1512536 The reverted CL is in Patchset 2. This feature will be staged under the flag "Enable Compositor threaded scrollbar scrolling". There will be follow up changelists which deal with thumb drags, continuous arrow scrolls, etc This CL enables fast scrollers to scroll on the compositor thread when a user clicks on any of the arrows on a composited root scrollbar. How it works: When a mousedown arrives at the renderer, it gets hit tested. If a composited scrollbar was hit, the MouseEvent gets dropped and a GestureScrollBegin and a GestureScrollUpdate get added to the CompositorThreadEventQueue. These gesture scroll events contain scroll deltas based on which scrollbar part was hit (arrows for now). On a mouseup, a GestureScrollEnd is added to the queue. They are then dispatched (as Gesture events) in a VSync aligned manner. For more information, here's a link to the intent-to-implement: https://groups.google.com/a/chromium.org/forum/#!topic/input-dev/6ACOSDoAik4/discussion TBR=dcheng@chromium.org,alexmos@chromium.org Bug: 148501 Change-Id: I986adedbc6f9160793d79cebfa206ec3ea603b53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572638 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Cr-Commit-Position: refs/heads/master@{#651971} cc/BUILD.gn | 2 + cc/input/input_handler.cc | 2 + cc/input/input_handler.h | 34 ++- cc/input/scrollbar.h | 16 +- cc/input/scrollbar_controller.cc | 89 +++++++ cc/input/scrollbar_controller.h | 40 ++++ cc/layers/painted_scrollbar_layer.cc | 4 + cc/layers/painted_scrollbar_layer.h | 2 + cc/layers/painted_scrollbar_layer_impl.cc | 29 ++- cc/layers/painted_scrollbar_layer_impl.h | 6 + cc/layers/scrollbar_layer_impl_base.cc | 25 ++ cc/layers/scrollbar_layer_impl_base.h | 4 + cc/test/fake_scrollbar.cc | 8 + cc/test/fake_scrollbar.h | 4 + cc/trees/layer_tree_host_impl.cc | 19 +- cc/trees/layer_tree_host_impl.h | 9 +- cc/trees/layer_tree_host_impl_unittest.cc | 13 +- cc/trees/layer_tree_host_pixeltest_scrollbars.cc | 2 + .../render_widget_host_input_event_router.cc | 6 + .../blink/public/platform/web_gesture_device.h | 7 + .../blink/renderer/core/scroll/scrollable_area.cc | 2 +- .../core/scroll/scrollbar_layer_delegate.cc | 8 + .../core/scroll/scrollbar_layer_delegate.h | 2 + third_party/blink/web_tests/TestExpectations | 14 ++ third_party/blink/web_tests/VirtualTestSuites | 8 + .../mouse-scrolling-on-div-scrollbar.html | 68 ++++++ .../mouse-scrolling-on-root-scrollbar.html | 44 ++++ .../README.md | 2 + .../README.txt | 2 + ui/events/blink/DEPS | 1 + ui/events/blink/input_handler_proxy.cc | 103 +++++++- ui/events/blink/input_handler_proxy.h | 10 +- ui/events/blink/input_handler_proxy_client.h | 6 +- ui/events/blink/input_handler_proxy_unittest.cc | 261 ++++++++++++++------- 34 files changed, 739 insertions(+), 113 deletions(-) commit e96f0436879cc5fac8a8c158f364f562584d575d Author: Alex Newcomer <newcomer@chromium.org> Date: Thu Apr 18 00:03:50 2019 +0000 cros: Fix crash on launcher close Fix the launcher crashing when it is closed with an active drag. Just trigger the drag cleanup when the AppListView begins to animate closed. Before, we were waiting on the AppsGridView dtor to clean up drag, but this can trigger a layout which isn't really useful, and can crash. Bug: 937503 Change-Id: Id0912c60a87ac860e7f5db9a444e1754af55deae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572930 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651970} ash/app_list/views/app_list_view.cc | 7 +++++-- ash/app_list/views/contents_view.cc | 4 ++++ 2 files changed, 9 insertions(+), 2 deletions(-) commit 1e6a4d7b28fd05a89633df971483970b6b8d8e2c Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Apr 18 00:03:39 2019 +0000 [ios] Implement FindInPageManager::StopFinding Bug: 919685 Change-Id: I266520f7e9cf11f0323eb8b9f4be320618457ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569228 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#651969} ios/web/find_in_page/find_in_page_constants.h | 2 + ios/web/find_in_page/find_in_page_constants.mm | 2 + ios/web/find_in_page/find_in_page_manager_impl.mm | 17 ++++++- .../find_in_page_manger_impl_unittest.mm | 21 ++++++++ .../find_in_page/find_in_page_manager_delegate.h | 6 ++- ios/web/web_state/js/find_in_page_js_unittest.mm | 57 ++++++++++++++++++++++ ios/web/web_state/js/resources/find_in_page.js | 8 +-- 7 files changed, 105 insertions(+), 8 deletions(-) commit 1d5d27199a59f6e36989e5ad3bf4ac3a7b34c6dd Author: Kristi Park <kristipark@chromium.org> Date: Thu Apr 18 00:02:46 2019 +0000 [NTP] Increase left/right padding in shortcut title pill Increase padding from 4px to 8px. Before: https://screenshot.googleplex.com/KbmSFM7jFKL.png After: https://screenshot.googleplex.com/7HnoUMk5B2t.png Bug: 930947 Change-Id: If5ed77c4c085ebc962748a85ddc25ec0cc1a94a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572868 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#651968} chrome/browser/resources/local_ntp/most_visited_single.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit f34bda9f4b1a400e389e12a8ba732cc2553e3014 Author: Adam Langley <agl@chromium.org> Date: Thu Apr 18 00:02:30 2019 +0000 device/fido: add test showing issue with truncated UTF-8 strings. Webauthn allows authenticators to truncate strings in the user entity. However, since authenticators aren't UTF-8 aware, when they truncate such strings they may truncate a multi-byte code-point and thus create invalid CBOR. This change adds a test to exercise this case. A future change will address it and update this test. Change-Id: I8fa88f4b7354b94da92a750bc79404caff838177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567094 Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#651967} device/fido/fido_test_data.h | 24 +++++++++++++++++++ device/fido/get_assertion_handler_unittest.cc | 33 +++++++++++++++++++++++++++ 2 files changed, 57 insertions(+) commit 4a960ac6d967643654224207df22597c464d765d Author: Jacob DeWitt <jacde@chromium.org> Date: Thu Apr 18 00:01:38 2019 +0000 Refactor Gamepad update logic Move logic from NavigatorGamepad::SampleGamepad to a new method on NavigatorGamepad from blink::Gamepad, which is required for the WebXR Gamepad integration. blink: :Gamepad::UpdateFromDeviceState. This removes another dependency Change-Id: I850ed78d1c990f14389fc365c03503a692aeda2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565685 Commit-Queue: Jacob DeWitt <jacde@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#651966} .../blink/renderer/modules/gamepad/gamepad.cc | 70 +++++++++++++++++++++- .../blink/renderer/modules/gamepad/gamepad.h | 16 ++++- .../modules/gamepad/gamepad_comparisons_test.cc | 23 ++++--- .../renderer/modules/gamepad/navigator_gamepad.cc | 59 ++---------------- .../renderer/modules/gamepad/navigator_gamepad.h | 1 - 5 files changed, 103 insertions(+), 66 deletions(-) commit f92caa497425a40fe1e8bf913a0688f641fd9f4a Author: Alexei Filippov <alph@chromium.org> Date: Wed Apr 17 23:58:08 2019 +0000 DevTools: Show Schedule Style Recalculation events on timeline The "Reveal" button on Recalc Style events is supposed to show the initiator, but it was hidden. Change-Id: I8e40e929206aa64e0b0ca5e1292691c7c849e9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572360 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651965} .../blink/renderer/devtools/front_end/timeline/TimelineUIUtils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe909bb937bb90aec25997dc5e04abedf4e7618f Author: Georges Winkenbach <gwink@chromium.org> Date: Wed Apr 17 23:58:04 2019 +0000 Chrome OS: Add top-row remapping for keyboard layout 3 Add mapping from function -> action key and action -> function key depending on state of search key and foce-function-key preference for new keyboard layout 3. Handle key codes that are mapped to Dom code without Vkey values: KEY_SCALE == Dom code SHOW_ALL_WINDOWS KEY_SWITCHVIDEOMODE == Dom code DISPLAY_TOGGLE_INT_EXT Map VKey_Zoom_Toogle to proper action for full-scree-toggle behavior. Bug: 952935, b:124881771 Change-Id: Ic709322c611e12df5ffad73f9f51947a3f8c5af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497592 Auto-Submit: Georges Winkenbach <gwink@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org> Commit-Queue: Georges Winkenbach <gwink@chromium.org> Cr-Commit-Position: refs/heads/master@{#651964} .../chromeos/events/event_rewriter_unittest.cc | 418 +++++++++++++++++++++ ui/chromeos/events/event_rewriter_chromeos.cc | 200 +++++++++- ui/chromeos/events/event_rewriter_chromeos.h | 19 +- 3 files changed, 621 insertions(+), 16 deletions(-) commit 90f793c8b6b9acca85a9ab535c962c2bdf5a1e14 Author: Changwan Ryu <changwan@google.com> Date: Wed Apr 17 23:55:53 2019 +0000 Add additional check for flakiness in KeepScreenOnActive test I suspect that in some cases media playback finishes too early. If media playback is finished, then it will enter 'paused' state. But that does not mean that the underlying logic is incorrect. Rather, the test itself should be fixed, for example, by increasing the media length. Increasing the media size can have a negative impact on the test running time, so checking this first. Bug: 936757 Change-Id: If02ceb008f5eab7c08aeef173947540cba4731f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565379 Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651963} .../test/AwContentsClientFullScreenTest.java | 18 +++++++++++++----- .../content_public/browser/test/util/DOMUtils.java | 2 +- 2 files changed, 14 insertions(+), 6 deletions(-) commit 7225a299284d89bf5b489fca3c89519db082b46f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 23:54:32 2019 +0000 Roll src/third_party/catapult acbf095c15e9..8f7609127524 (1 commits) https://chromium.googlesource.com/catapult.git/+log/acbf095c15e9..8f7609127524 git log acbf095c15e9..8f7609127524 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 rmhasan@google.com [Typ] Include line number in Expectation instance Created with: gclient setdep -r src/third_party/catapult@8f7609127524 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948891,chromium:698902 TBR=oysteine@chromium.org Change-Id: Id6aeb723869c258f9d548f46a68f694549f51388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572647 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651962} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 50a80636167bbd73d7cd84fb24251e738cb3bea6 Author: Kayce Basques <kayce@google.com> Date: Wed Apr 17 23:53:28 2019 +0000 DevTools: Update What's New for Chrome 75 Bug: 953814 Change-Id: Iecf1f9359c4a10d1815fe7ad98fd44766d7f8116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572524 Commit-Queue: Kayce Basques <kayce@google.com> Auto-Submit: Kayce Basques <kayce@google.com> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651961} .../devtools/front_end/Images/whatsnew.png | Bin 11902 -> 12180 bytes .../devtools/front_end/help/ReleaseNoteText.js | 35 +++++++++++++++++++++ 2 files changed, 35 insertions(+) commit e2f57e585369a00e68e2a69710fbfaaa655c6a71 Author: Ted Choc <tedchoc@chromium.org> Date: Wed Apr 17 23:53:24 2019 +0000 Ensure WiFi access is gated by FINE location permission. BUG=953427 Change-Id: I3d4a2e3c127db2d0bab894cf061e87d85dde4ba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572925 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#651960} .../chromium/chrome/browser/omnibox/geo/PlatformNetworksManager.java | 5 +++++ 1 file changed, 5 insertions(+) commit a121bc41fc2f8ae5e9037ff7f70296a64be7cef2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 23:47:34 2019 +0000 Roll src/third_party/SPIRV-Tools/src 21712068feee..ac878fcbdd64 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/21712068feee..ac878fcbdd64 git log 21712068feee..ac878fcbdd64 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 33432579+alan-baker@users.noreply.github.com Remove unreachable block validation (#2525) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ac878fcbdd64 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I965b93599b9facd516a8cdc86f742e671a740e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572307 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651959} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b0be036087da5ea9ac9f225a2d0a31f9dd739d8b Author: khachatryan <khachatryan@chromium.org> Date: Wed Apr 17 23:46:53 2019 +0000 [ChromeDriver] Update negative test filter according to the latest changes Java tests PageLoadingTest.testShouldTimeoutIfAPageTakesTooLongToLoadAfterClick and PageLoadingTest.testShouldDoNothingIfThereIsNothingToGoBackTo have dependency while they run in a test suit. Disabling PageLoadingTest.testShouldTimeoutIfAPageTakesTooLongToLoadAfterClick for now. Bug: chromedriver:2861 Change-Id: If8dde745b34ad2421ae2bad03a78fa5a798ea7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572874 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651958} chrome/test/chromedriver/test/test_expectations | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit a04d31bd54d076a7672e177ec350a3082af8b6f7 Author: Chris Harrelson <chrishtr@chromium.org> Date: Wed Apr 17 23:46:02 2019 +0000 [Crash] Don't pump pending speculations if the parser is stopped. This could be due to stopping or detach of the parser. PumpPendingSpeculations() already has a DCHECK that IsStopped returns false, and a similar method to ResumeParsingAfterPause, ResumeParsingAfterYield, also has an IsStopped check. I was not able to reproduce the crashes in the attached bug, so can't write a useful test to exercise this situation. Bug: 949041 Change-Id: Id5c37b98c0171b4ed5e56d2553484e87f729bff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570531 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651957} third_party/blink/renderer/core/html/parser/html_document_parser.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 43175ff0ca29d8dbb36748baf680051ae60964b0 Author: Dan Harrington <harringtond@chromium.org> Date: Wed Apr 17 23:45:00 2019 +0000 Made ClientPolicyController immutable Previously, it used mutable data members, and was unsafe for multithreaded use, depending on the methods called. Now it should be safe for multithreaded use. I also removed methods not currently in use. Change-Id: I124db9326d6de323a2fcbad80be6b5ad8a4fd682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559583 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#651956} .../offline_pages/core/client_policy_controller.cc | 118 ++++++--------------- .../offline_pages/core/client_policy_controller.h | 37 ++----- .../core/client_policy_controller_unittest.cc | 14 --- 3 files changed, 37 insertions(+), 132 deletions(-) commit cf7646eb69f95af7304adb6f902e72abb975efdb Author: Alex Newcomer <newcomer@chromium.org> Date: Wed Apr 17 23:44:17 2019 +0000 Cros:Fix crash, closing app list while dragging an app. Just check the widget exists before calling it. Bug: 937503 Change-Id: I15a6f058ef6604891d97664e53636ad778f4bea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572929 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#651955} ash/app_list/views/apps_grid_view.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 2d1614aaeb20f19c6c3ba5419c3bbe92f7cdfe33 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 23:38:54 2019 +0000 Roll src/third_party/webrtc e0ab81c8c6e5..797ede8e712f (1 commits) https://webrtc.googlesource.com/src.git/+log/e0ab81c8c6e5..797ede8e712f git log e0ab81c8c6e5..797ede8e712f --date=short --no-merges --format='%ad %ae %s' 2019-04-17 qingsi@webrtc.org Revert "Surface ICE candidates that match an updated candidate filter." Created with: gclient setdep -r src/third_party/webrtc@797ede8e712f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idbfec289f001e8866368816343d96d5cdff85c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572646 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651954} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8eca30e8240c0deddd3d233f2f066d3149b02e83 Author: Victor Costan <pwnall@chromium.org> Date: Wed Apr 17 23:37:03 2019 +0000 sql: Remove Sqlite.SizeKB.* histograms. The histograms were added in https://crrev.com/15499003 and have become unused. Bug: 953143 Change-Id: I32fc9eabdefe09e9a5837c3bcf4594187025f3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568628 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Reviewed-by: Steven Holte <holte@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#651953} sql/database.cc | 14 -------------- tools/metrics/histograms/histograms.xml | 3 +++ 2 files changed, 3 insertions(+), 14 deletions(-) commit a6b8961a7703b57f1d4589968cbb28907f4eba43 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 23:31:41 2019 +0000 Roll src/third_party/skia 5b39dc81534a..e64e6327a156 (2 commits) https://skia.googlesource.com/skia.git/+log/5b39dc81534a..e64e6327a156 git log 5b39dc81534a..e64e6327a156 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 benjaminwagner@google.com Add __init__.py to page_sets 2019-04-17 robertphillips@google.com Non-substantive changes Created with: gclient setdep -r src/third_party/skia@e64e6327a156 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: If8f8e6498cd6ff46e917aac455bcd84f7ccf0be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572642 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651952} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d7cd6fffc43454e8f564abe52cfddf0a235721f5 Author: Saman Sami <samans@chromium.org> Date: Wed Apr 17 23:29:40 2019 +0000 Remove trace event in SurfaceLayer::SetOldestAcceptableFallback After elimination of OnFirstSurfaceActivation, embedders no longer call SetFallbackSurfaceId (now called SetOldestAcceptableFallback), so there shouldn't be a trace event for submission flow in this method. Bug: 893850 Change-Id: Icea41b6b210a86281c98c9fed23c4bbe1b5b8172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572183 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#651951} cc/layers/surface_layer.cc | 6 ------ cc/layers/surface_layer_impl.cc | 13 ------------- 2 files changed, 19 deletions(-) commit 32e1fabd61826e27299ad2038affbb17f6f6de46 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 23:27:09 2019 +0000 Roll Fuchsia SDK from 891592798553 to 891589959621 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib63d68f897fb46af168d6636d3524c4a43edcb34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572645 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651950} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 0ffce4feffd56fbccbbaaa07b77aaf8fc92513dd Author: Tim Volodine <timvolodine@chromium.org> Date: Wed Apr 17 23:22:17 2019 +0000 [AW NS] Add UMA for error codes in the onReceivedError callback (for NS rollout regression analysis). The error code information is useful for tracking potential regressions during network service rollout (using server side experiment). A changing distribution of errors might point to a regression. It's possible some errors are not reported or are reported differently when the network service is enabled, because we don't necessarily have test coverage for these cases (see e.g. redirects related patch in [1]). Note regarding the placement of the UMA recording, postOnReceivedError() happens in: - AwContentsClientBridge.onReceivedError - AwContents.BackgroundThreadClientImpl.shouldInterceptRequest so the optimal place for recording this UMA seems to be the AwContentsClient class. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1536059 BUG=948770,945922,841556 Change-Id: Ic434c9dc588d9533a80b036bdbedb5ce80d723bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549125 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651949} .../chromium/android_webview/AwContentsClient.java | 5 +++++ tools/metrics/histograms/enums.xml | 20 ++++++++++++++++++++ tools/metrics/histograms/histograms.xml | 12 ++++++++++++ 3 files changed, 37 insertions(+) commit dceada3daaabab96248d81fac194d786d5235f93 Author: Noel Gordon <noel@chromium.org> Date: Wed Apr 17 23:21:20 2019 +0000 [piexwasm] tests.html: import page <style> from tests.css Bug: 935285 Change-Id: I6799ba4805b8f65567722de3cf5be3c17abc8265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572979 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#651948} ui/file_manager/image_loader/piex/tests.css | 21 +++++++++++++++++++++ ui/file_manager/image_loader/piex/tests.html | 10 ++-------- 2 files changed, 23 insertions(+), 8 deletions(-) commit c067b74f8bcbbbfb0d91f3307f4409928c8ff2c8 Author: Sahel Sharify <sahel@chromium.org> Date: Wed Apr 17 23:19:07 2019 +0000 Rename ManifestIconSelector(MIS)::FindBestMatchingIcon This is a follow up cl for the following comment to rename MIS::FindBestMatchingIcon to MIS::FindBestMatchingSquareIcon and MIS::FindBestMatchingLandscapeIcon to MIS::FindBestMatchingIcon. https://chromium-review.googlesource.com/c/chromium/src/+/1544139/7..17/third_party/blink/common/manifest/manifest_icon_selector.cc TBR=jbroman@chromium.org Bug: 879741 Change-Id: I2bcc4161eadc734b57f7809ef3b0a8043a170710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572545 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#651947} chrome/browser/android/shortcut_helper.cc | 2 +- .../browser/android/webapps/add_to_homescreen_data_fetcher.cc | 2 +- chrome/browser/installable/installable_manager.cc | 2 +- components/payments/content/installable_payment_app_crawler.cc | 9 ++++----- content/browser/payments/payment_app_info_fetcher.cc | 2 +- content/browser/payments/payment_instrument_icon_fetcher.cc | 2 +- third_party/blink/common/manifest/manifest_icon_selector.cc | 10 +++++----- .../blink/common/manifest/manifest_icon_selector_unittest.cc | 4 ++-- .../blink/public/common/manifest/manifest_icon_selector.h | 4 ++-- .../modules/background_fetch/background_fetch_icon_loader.cc | 2 +- 10 files changed, 19 insertions(+), 20 deletions(-) commit 55c35f31c5361f8069da5cbbe19c33d3f8e7cbba Author: Becky Zhou <huayinz@chromium.org> Date: Wed Apr 17 23:17:41 2019 +0000 [Dark] Update reader mode appearance menu background in dark mode Note that UX is okay with the selected button background is kept as is for now. Bug: 953366 Change-Id: I92bcd4448dceddccfeca98bb220ccc93e78bbf94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572869 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651946} chrome/android/java/res/values/colors.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d2ebee6252330d247bd634a3fbeb85eb5c791ea9 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Wed Apr 17 23:15:22 2019 +0000 [layoutng] Make OOF use the cached preferred width when available Setting the override logical height is necessary to make external/wpt/css/css-sizing/intrinsic-percent-replaced-005.html pass. Change-Id: I7087033ec67e62438f27522defed41fcd87517fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560011 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#651945} .../renderer/core/layout/ng/ng_length_utils.cc | 37 ++++++++++++++++++++-- .../renderer/core/layout/ng/ng_length_utils.h | 11 ++++++- .../core/layout/ng/ng_out_of_flow_layout_part.cc | 4 +-- 3 files changed, 47 insertions(+), 5 deletions(-) commit ac6ad4fde883a60c1578dce5c058b08b087e2155 Author: Nancy Li <nancyly@google.com> Date: Wed Apr 17 23:13:59 2019 +0000 [USB Internals Test] Add initial ui test for chrome://usb-internals Added test for the basic JS methods for displaying the devices table. Bug: 928923 Change-Id: I4a9eb4414cecc3921d0f06e13a9abfe55fd96a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1556454 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Nancy Li <nancyly@google.com> Cr-Commit-Position: refs/heads/master@{#651944} .../resources/usb_internals/usb_internals.js | 34 ++-- chrome/test/data/webui/BUILD.gn | 1 + .../test/data/webui/usb_internals_browsertest.js | 201 +++++++++++++++++++++ 3 files changed, 225 insertions(+), 11 deletions(-) commit 518dfe44492c04b6fcbed19a73ba579179fb1b4a Author: Kristi Park <kristipark@chromium.org> Date: Wed Apr 17 23:09:20 2019 +0000 [NTP] Darken fakebox text and fix text padding Darken fakebox hint text from GG600 to GG700 to meet min-contrast requirements. Also fix the hint text padding to prevent overlap with the microphone icon for some languages. Before: https://screenshot.googleplex.com/oguATKFkLjL.png After: https://screenshot.googleplex.com/KeSvjHAnC14.png Bug: 952944 Change-Id: I0a928363f6a2c85d19ebb4e1a87df912751a5dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572928 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#651943} chrome/browser/resources/local_ntp/local_ntp.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 50be449d897f92f296595612a15663411acd588e Author: Alexander Timin <altimin@chromium.org> Date: Wed Apr 17 23:07:59 2019 +0000 [bfcache] Plumb feature usage metrics to the browser process Notify RenderFrameHostImpl each time a set of scheduler-tracked features changes and record these features as a part of HistoryNavigation in BackForwardCacheMetrics. Design doc: https://docs.google.com/document/d/1kq2usbHRfpSlv_cLRa5i_oljCbQ6IzEthmNmA6e9MGI/edit R=creis@chromium.org CC=​​kinuko@chromium.org BUG=933147 Change-Id: I8270a9e6f00592ec77e6b5a0d5adecb9729bd1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546097 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651942} .../frame_host/back_forward_cache_metrics.cc | 7 ++++++ .../frame_host/back_forward_cache_metrics.h | 20 +++++++++++----- .../back_forward_cache_metrics_browsertest.cc | 28 ++++++++++++++++++++++ .../browser/frame_host/render_frame_host_impl.cc | 11 +++++++++ .../browser/frame_host/render_frame_host_impl.h | 15 ++++++++++++ .../frame_host/render_frame_host_manager.cc | 16 +++++++++++++ content/common/frame.mojom | 7 ++++++ content/renderer/render_frame_impl.cc | 5 ++++ content/renderer/render_frame_impl.h | 1 + .../back_forward_cache/page_with_pageshow.html | 7 ++++++ content/test/test_render_frame.cc | 2 ++ .../blink/public/web/web_local_frame_client.h | 4 ++++ .../core/exported/local_frame_client_impl.cc | 8 +++++++ .../core/exported/local_frame_client_impl.h | 1 + .../blink/renderer/core/frame/local_frame.cc | 4 ++++ .../blink/renderer/core/frame/local_frame.h | 1 + .../blink/renderer/core/frame/local_frame_client.h | 5 ++++ .../scheduler/main_thread/frame_scheduler_impl.cc | 28 ++++++++++++++++++++++ .../scheduler/main_thread/frame_scheduler_impl.h | 4 ++++ .../main_thread/frame_scheduler_impl_unittest.cc | 2 ++ .../platform/scheduler/public/frame_scheduler.h | 7 ++++++ .../worker/worker_thread_scheduler_unittest.cc | 2 ++ tools/metrics/ukm/ukm.xml | 7 ++++++ 23 files changed, 186 insertions(+), 6 deletions(-) commit ba518c0b3113b0034f5e5048d5545df0dd4929a9 Author: Aleks Totic <atotic@chromium.org> Date: Wed Apr 17 23:03:56 2019 +0000 Revert "Reland "[Switch Access] Refactor focus for clarity around back button"" This reverts commit 654df64a5e8ea5782367325cd6df147696538893. Reason for revert: https://crbug.com/953969 Failing tests: SwitchAccessNavigationManagerTest.MoveBackAndForth SwitchAccessNavigationManagerTest.MoveBackward etc. Original change's description: > Reland "[Switch Access] Refactor focus for clarity around back button" > > This is a reland of 91a61a310cc9b8451719e9bd6dd04919935ea0f1 > > Original change's description: > > [Switch Access] Refactor focus for clarity around back button > > > > Bug: None > > Change-Id: I3318ae4d5f37d67e7fe5abb894f9edacddc785d4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549944 > > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > > Reviewed-by: Katie Dektar <katie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#647532} > > Bug: None > Change-Id: I5fbb04a2c11c7e77afc98891dc60f795bb9f2c0d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553812 > Reviewed-by: Katie Dektar <katie@chromium.org> > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Cr-Commit-Position: refs/heads/master@{#651826} TBR=katie@chromium.org,anastasi@google.com Change-Id: Iae17f89364ca5cf7af23f916b32576058cbd16b4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1573001 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#651941} .../chromeos/switch_access/back_button_manager.js | 25 +----- .../chromeos/switch_access/navigation_manager.js | 97 ++++++++++++---------- .../switch_access/navigation_manager_test.extjs | 38 ++++----- 3 files changed, 71 insertions(+), 89 deletions(-) commit 14d9f48eb3189731fe97c6369c6df5975077c1f7 Author: Dana Fried <dfried@chromium.org> Date: Wed Apr 17 22:59:27 2019 +0000 Navigating in current tab ensures tab is focused. If accessibility focus was set to a toolbar element prior to opening a menu and a menu item navigated to a page (settings or otherwise), the browser contents pane was not automatically re-focused. This fixes the bug. Bug: 926492 Change-Id: I92e07e0571e580f6638aa5036112d2fd2799f120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570190 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#651940} chrome/browser/ui/chrome_pages.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 0338fc1d5a1db321e50fe53fe6bd9e8595429676 Author: Edward Jung <edwardjung@chromium.org> Date: Wed Apr 17 22:57:21 2019 +0000 chrome://dino fix regression reinstate invert original invert distance Regression introduced: https://chromium-review.googlesource.com/c/chromium/src/+/1547980 Change-Id: I27ef54d90394b93b09ef2e673eeb80cf291e3ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572399 Reviewed-by: Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#651939} components/neterror/resources/offline.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 30dbf99d2683730f995c4315acd02233b349fd29 Author: Jonathan Metzman <metzman@chromium.org> Date: Wed Apr 17 22:55:59 2019 +0000 Reland "Don't build seed corpora in most configs and delete duplicated config" This is a reland of 3b8a3ffc8ee941944e3cc13ac5bf63b167cfcc06 Original change's description: > Don't build seed corpora in most configs and delete duplicated config > > Only build seed corpora where it is necessary, in order to reduce > build sizes. > > Bug: 952412 > Change-Id: I6e529226d4ba51fd547c1869525a9f094fdcd998 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566454 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Jonathan Metzman <metzman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650506} Bug: 952412 Change-Id: I0ce44fb063784db1d7e4215fb69868cbe6e5e9ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572639 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#651938} tools/mb/mb_config.pyl | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) commit 951325803874f32582d77fbb53d2d3e97fb3deac Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Apr 17 22:54:55 2019 +0000 Use double type to idl files in third_party/blink/renderer/modules/imagecapture This CL updates IDL files to follow spec APIs and changes float type to double type of c++/java implementation using Point2D struct. Bug: 938800 Change-Id: I50064e6530457c9499a21613544579cd0f31cd1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554462 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#651937} base/android/jni_array.cc | 19 +++++++++++++++++++ base/android/jni_array.h | 8 ++++++++ media/capture/mojom/image_capture.mojom | 4 ++-- .../java/src/org/chromium/media/VideoCapture.java | 2 +- .../src/org/chromium/media/VideoCaptureCamera.java | 6 +++--- .../src/org/chromium/media/VideoCaptureCamera2.java | 12 +++++++----- .../video/android/video_capture_device_android.cc | 6 +++--- .../capture/video/chromeos/camera_device_delegate.cc | 6 +++--- .../blink/renderer/modules/imagecapture/point_2d.idl | 4 ++-- .../wpt/resources/chromium/image_capture.mojom.js | 12 ++++++------ 10 files changed, 54 insertions(+), 25 deletions(-) commit 1a5b2cf17456d4ba82638d28b64239a9d927eddb Author: Brandon Jones <bajones@chromium.org> Date: Wed Apr 17 22:50:18 2019 +0000 Update navigator.xr.requestSession to take a mode directly Updates Chrome's WebXR implementation to match the latest spec changes. Also means the removal of a file and slight reduction of code for most of the tests and samples! Bug: 953450 Change-Id: Ia0cbe48668909edbc9a2ff388a03e2a880c79bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570217 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#651936} .../html/test_inline_identity_available.html | 2 +- .../test_stationary_reference_space_rejects.html | 2 +- ...sentation_promise_rejected_if_don_canceled.html | 2 +- ...presentation_promise_unresolved_during_don.html | 2 +- .../e2e_test_files/resources/webxr_boilerplate.js | 11 ++++------- .../blink/renderer/modules/modules_idl_files.gni | 1 - third_party/blink/renderer/modules/xr/xr.cc | 16 ++++++++-------- third_party/blink/renderer/modules/xr/xr.h | 3 +-- third_party/blink/renderer/modules/xr/xr.idl | 2 +- .../modules/xr/xr_session_creation_options.idl | 8 -------- .../wpt/webxr/idlharness.https.window-expected.txt | 6 +++--- .../xrDevice_requestSession_immersive.https.html | 2 +- ..._requestSession_immersive_no_gesture.https.html | 2 +- ...requestSession_immersive_unsupported.https.html | 2 +- .../xrDevice_requestSession_no_mode.https.html | 22 ++++++++++++++++++++++ ...uestSession_non_immersive_no_gesture.https.html | 4 +--- .../external/wpt/webxr/xrFrame_getPose.https.html | 6 ++---- .../external/wpt/webxr/xrFrame_lifetime.https.html | 7 ++----- .../webxr/xrRigidTransform_constructor.https.html | 3 +-- .../wpt/webxr/xrRigidTransform_inverse.https.html | 3 +-- .../xrSession_cancelAnimationFrame.https.html | 7 ++----- ...n_cancelAnimationFrame_invalidhandle.https.html | 7 ++----- .../external/wpt/webxr/xrSession_end.https.html | 7 ++----- .../xrSession_identity_referenceSpace.https.html | 7 ++----- .../external/wpt/webxr/xrSession_mode.https.html | 2 +- ...xrSession_prevent_multiple_exclusive.https.html | 6 +++--- ...requestAnimationFrame_callback_calls.https.html | 7 ++----- ...ion_requestAnimationFrame_data_valid.https.html | 3 +-- ..._requestAnimationFrame_getViewerPose.https.html | 7 ++----- .../xrSession_requestReferenceSpace.https.html | 7 ++----- .../xrSession_transfer_outputContext.https.html | 4 ++-- third_party/blink/web_tests/xr/ar_hittest.html | 2 +- .../web_tests/xr/events_session_resetpose.html | 4 ++-- .../blink/web_tests/xr/events_session_select.html | 2 +- .../xr/events_session_select_subframe.html | 2 +- .../xr/exclusive_requestFrame_nolayer.html | 4 ++-- .../blink/web_tests/xr/getInputPose_hand.html | 2 +- .../web_tests/xr/getInputPose_handedness.html | 2 +- .../blink/web_tests/xr/getInputPose_ray.html | 2 +- .../xr/navigator_xr_blocks_getVRDisplays.html | 2 +- .../blink/web_tests/xr/navigator_xr_detached.html | 2 +- .../xr/xrBoundedReferenceSpace_updates.html | 2 +- .../blink/web_tests/xr/xrFrame_getPose.html | 2 +- .../web_tests/xr/xrInputSource_add_remove.html | 2 +- .../xr/xrReferenceSpace_originOffset.html | 2 +- .../xr/xrSession_environmentBlendMode.html | 4 ++-- .../xrSession_environmentProviderDisconnect.html | 2 +- .../xrSession_requestAnimationFrame_timestamp.html | 4 ++-- ...tationaryReferenceSpace_floorlevel_updates.html | 4 ++-- third_party/blink/web_tests/xr/xrView_match.html | 2 +- .../blink/web_tests/xr/xrView_oneframeupdate.html | 2 +- .../blink/web_tests/xr/xrViewport_valid.html | 2 +- .../web_tests/xr/xrWebGLLayer_constructor.html | 2 +- .../xr/xrWebGLLayer_dirty_framebuffer.html | 2 +- .../xr/xrWebGLLayer_framebuffer_draw.html | 2 +- .../xr/xrWebGLLayer_framebuffer_scale.html | 2 +- .../xr/xrWebGLLayer_incompatible_device.html | 2 +- .../xr/xrWebGLLayer_non_exclusive_adjust_size.html | 2 +- .../xr/xrWebGLLayer_opaque_framebuffer.html | 4 ++-- .../web_tests/xr/xrWebGLLayer_viewport_scale.html | 2 +- .../webxr_test_pages/webxr-samples/360-photos.html | 4 ++-- .../webxr-samples/fallback-rendering.html | 4 ++-- .../webxr-samples/framebuffer-scaling.html | 2 +- .../webxr-samples/input-selection.html | 4 ++-- .../webxr-samples/input-tracking.html | 4 ++-- .../webxr-samples/magic-window.html | 4 ++-- .../webxr_test_pages/webxr-samples/mirroring.html | 4 +--- .../webxr-samples/positional-audio.html | 4 ++-- .../webxr-samples/proposals/phone-ar-hit-test.html | 4 ++-- .../webxr-samples/reduced-bind-rendering.html | 4 ++-- .../webxr_test_pages/webxr-samples/room-scale.html | 4 ++-- .../webxr-samples/spectator-mode.html | 4 ++-- .../webxr-samples/stereo-video.html | 4 ++-- .../webxr-samples/tests/cube-sea.html | 4 ++-- .../webxr-samples/tests/offscreen-canvas.html | 4 ++-- .../webxr-samples/tests/permission-request.html | 4 ++-- .../webxr-samples/tests/pointer-painter.html | 4 ++-- .../webxr-samples/tests/sponza.html | 4 ++-- .../webxr-samples/viewport-scaling.html | 4 ++-- .../webxr-samples/xr-barebones.html | 2 +- .../webxr-samples/xr-presentation.html | 2 +- 81 files changed, 147 insertions(+), 171 deletions(-) commit 8a68ef695005cd92a5c93acb0c97bc8b93fcbe17 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Wed Apr 17 22:48:01 2019 +0000 [iOS] Ignore scrolls past bottom when FS provider is uninitialized. When the FullscreenProvider is uninitialized, fullscreen is implemented by resizing the entire web view. When this occurs, the contentOffset updates caused by the UIScrollView "snap back" CADisplayLink animation interfere with the frame adjustments. These scrolls should be ignored, as they produce a jittery animation. This issue does not occur for smooth scrolling, as the frame is not adjusted in that scenario. Bug: 920966 Change-Id: Ie918b825c83ec48436093dbad29fbcc063a18efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549287 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#651935} ios/chrome/browser/ui/fullscreen/fullscreen_model.mm | 10 ++++++++-- .../browser/ui/fullscreen/fullscreen_model_unittest.mm | 13 +++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) commit af52a25a8260e65c488cb8bf22fe745075b44309 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 22:45:05 2019 +0000 Update V8 to version 7.5.288. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0d449a89..35b9bf5c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ice46a45073a2b8ff27b2d731649da3b13a59db3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572209 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651934} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ca2b6b87e0de960137cb63f08c6749c61295dd70 Author: Sergey Ulanov <sergeyu@google.com> Date: Wed Apr 17 22:43:02 2019 +0000 [Fuchsia] Add VK_FUCHSIA_buffer_collection in vulkan_fuchsia_ext.h VK_FUCHSIA_buffer_collection Vulkan extension will be used on Fuchsia to create NativePixmap's backed by sysmem buffers. Bug: 852011 Change-Id: I13dbe16be248e6279bd31874e27e18516bdbd0c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572899 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#651933} gpu/vulkan/fuchsia/vulkan_fuchsia_ext.h | 97 +++++++++++++++++++++++++++++++++ gpu/vulkan/generate_bindings.py | 4 ++ gpu/vulkan/vulkan_function_pointers.cc | 26 +++++++++ gpu/vulkan/vulkan_function_pointers.h | 16 ++++++ 4 files changed, 143 insertions(+) commit ea4ecec0e45578b008d55251f31a004ea4adabbb Author: Darwin Huang <huangdarwin@chromium.org> Date: Wed Apr 17 22:37:41 2019 +0000 Async Clipboard: Add spec link for web tests. Make tests, and the interfaces they test, more clear by adding links to specifications being tested. Bug: 952650 Change-Id: I875531e1f4a62c9a045cc81b075bdb847a4c4475 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570535 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#651932} third_party/blink/web_tests/clipboard/async-clipboard/README.md | 2 +- .../async-clipboard/async-navigator-clipboard-basics.https.html | 1 + .../async-clipboard/async-write-blobtext-read-blobtext.https.html | 1 + .../clipboard/async-clipboard/async-write-blobtext-read-text.https.html | 1 + .../clipboard/async-clipboard/async-write-text-read-blobtext.https.html | 1 + .../clipboard/async-clipboard/async-write-text-read-text.https.html | 1 + .../web_tests/clipboard/async-clipboard/readtext-denied.https.html | 1 + .../web_tests/clipboard/async-clipboard/readtext-granted.https.html | 1 + .../web_tests/clipboard/async-clipboard/writetext-denied.https.html | 1 + .../web_tests/clipboard/async-clipboard/writetext-granted.https.html | 1 + .../web_tests/external/wpt/clipboard-apis/async-interfaces.https.html | 2 +- .../wpt/clipboard-apis/async-navigator-clipboard-basics.https.html | 1 + .../wpt/clipboard-apis/async-write-blobs-read-blobs-manual.https.html | 1 + .../clipboard-apis/async-write-blobtext-read-blobtext-manual.https.html | 1 + .../wpt/clipboard-apis/async-write-blobtext-read-text-manual.https.html | 1 + .../wpt/clipboard-apis/async-write-image-read-image-manual.https.html | 1 + .../wpt/clipboard-apis/async-write-text-read-blobtext-manual.https.html | 1 + .../wpt/clipboard-apis/async-write-text-read-text-manual.https.html | 1 + .../web_tests/external/wpt/clipboard-apis/clipboard-item.https.html | 1 + third_party/blink/web_tests/http/tests/clipboard/README.md | 2 +- .../web_tests/http/tests/clipboard/async-write-blobs-read-blobs.html | 1 + .../web_tests/http/tests/clipboard/async-write-image-read-image.html | 1 + 22 files changed, 22 insertions(+), 3 deletions(-) commit 85efcd85f3c01abb8e9d60d279f3f0bc3bc763d8 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 17 22:35:20 2019 +0000 flags: assign bypass-app-banner-engagement-checks Bug: None Change-Id: I0e786a45cd2af877a39b04382042499fe6b15ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571010 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#651931} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 838f8e844cac7effa1f94d00b7c390bc87f326cd Author: Xiaohan Wang <xhwang@chromium.org> Date: Wed Apr 17 22:35:08 2019 +0000 Add more SecureOriginAllowlistTest cases Add a few tests cases mostly to help people not familiar with net/ code to understand how the secure origin allow list works. Test: Adds new test cases. Change-Id: Ic802cf168081814bbd84f59ae0833cbbb922ee77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572374 Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#651930} .../cpp/is_potentially_trustworthy_unittest.cc | 33 ++++++++++++++++++++++ 1 file changed, 33 insertions(+) commit 5bb043d44c6116714e882a9d8fe7b5cb33af1f73 Author: Greg Kerr <kerrnel@chromium.org> Date: Wed Apr 17 22:33:36 2019 +0000 macOS V2 Sandbox: Add iokit properties and mach services to profile. This adds an additional mach service (the lsd.mapdb endpoint) and an iokit property to the V2 GPU sandbox profile. Bug: 917445 Change-Id: If10f614d5a14e64a37bf0cd97af8d220cbe9167d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572818 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#651929} services/service_manager/sandbox/mac/gpu_v2.sb | 1 + 1 file changed, 1 insertion(+) commit ce551e5cb9b5326863c5b6df1022c56dfcea7642 Author: Lan Wei <lanwei@chromium.org> Date: Wed Apr 17 22:33:33 2019 +0000 Send a fake mouse move to update hover for layout change In order to remove the timer to send the fake mouse move event to update hover for layout change case, we will send the fake mouse event at the begin after it performs the post layout task. Bug: 877132 Change-Id: I6bc23580b471ca6b1df5f721b74815fc8ffb8a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551438 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651928} .../blink/renderer/core/exported/web_view_impl.cc | 4 +- .../blink/renderer/core/frame/local_frame_view.cc | 11 +++++- .../renderer/core/input/mouse_event_manager.cc | 8 +++- ...> update-mouse-cursor-after-layout-change.html} | 10 ++--- ....html => update_hover_after_layout_change.html} | 23 ++++------- ...e_hover_after_layout_change_at_begin_frame.html | 44 ++++++++++++++++++++++ .../blink/web_tests/resources/gesture-util.js | 9 +++++ 7 files changed, 82 insertions(+), 27 deletions(-) commit 05084df72e75cf9241a525761bdeb4ad14b6795c Author: Yi Gu <yigu@chromium.org> Date: Wed Apr 17 22:32:06 2019 +0000 [Animation Worklet] Playing a running animation should not crash Upon playing a worklet animation we attach the animation to the worklet animation controller. Playing the running animation again leads to duplicated attaching. Rather, the second animation.play() should be a no-op. Change-Id: Ibc664bb8fa7fd2b1e124d1cbf2986b169a5a53c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572799 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#651927} .../modules/animationworklet/worklet_animation.cc | 2 +- ...ttps.html => worklet-animation-play.https.html} | 24 ++++++++++++++++++++-- 2 files changed, 23 insertions(+), 3 deletions(-) commit d77d2216433680ac19a7d8de77995fee944195c8 Author: Stephen Martinis <martiniss@chromium.org> Date: Wed Apr 17 22:29:41 2019 +0000 Remove old merge_profiles.py link The need for it was removed in https://crrev.com/c/1560571. Bug: 923711 Change-Id: Ie3f34d6e672e2dae54b41fdba845f4b94e750d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559363 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#651926} testing/merge_scripts/code_coverage/merge_profiles.py | 1 - 1 file changed, 1 deletion(-) commit 15bdb160ffbef10a247744e899195db1c011c151 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Apr 17 22:27:42 2019 +0000 Download Home : Changed empty state strings Updated the empty state strings shown on tabs for both regular and search mode. One of the strings requires an embedded settings icon, which was added with the help of an ImageSpan. Bug: 951824 Change-Id: I292220bf9ccaad6deb8eec674a5ffe1558527fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566212 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#651925} .../browser/download/home/empty/EmptyCoordinator.java | 12 ++---------- chrome/android/java/strings/android_chrome_strings.grd | 13 +++++-------- 2 files changed, 7 insertions(+), 18 deletions(-) commit c969dc06716126fad4f70d9d71c92be8db57c6b8 Author: David Bertoni <dbertoni@chromium.org> Date: Wed Apr 17 22:24:34 2019 +0000 [Extensions] Replace calls to render_frame_host()->GetProcess() ->GetID() with source_process_id(). Service Worker-based extension functions will not have access to a RenderFrameHost, so this CL removes one use of the render_frame_host() accessor. This is a trivial change, since the source_process_id_ data member of ExtensionFunction has the RenderProcessHost ID. Bug: 950185 Change-Id: I1bd1e0d70bbdb180a627fb9cb1cbd5cac45d81d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552292 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#651924} .../api/desktop_capture/desktop_capture_api.cc | 5 ++--- .../api/desktop_capture/desktop_capture_base.cc | 9 +++----- .../api/developer_private/developer_private_api.cc | 8 +++---- .../extensions/api/downloads/downloads_api.cc | 3 +-- .../api/downloads/downloads_api_browsertest.cc | 3 +++ .../image_writer_private_api.cc | 6 ++--- .../api/page_capture/page_capture_api.cc | 7 ++---- .../webrtc_desktop_capture_private_api.cc | 6 ++--- .../browser/api/app_window/app_window_api.cc | 6 ++--- .../browser/api/declarative/declarative_api.cc | 5 +---- .../browser/api/file_system/file_system_api.cc | 21 ++++++++--------- .../extension_view/extension_view_internal_api.cc | 5 +---- .../api/guest_view/guest_view_internal_api.cc | 10 ++++----- .../guest_view/web_view/web_view_internal_api.cc | 26 +++++++++------------- extensions/browser/api/runtime/runtime_api.cc | 5 +---- 15 files changed, 47 insertions(+), 78 deletions(-) commit ab484d90a9c26cabb1a50268dd08a1bc9c3767f2 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Apr 17 22:24:03 2019 +0000 [fuchsia] Remove the chromium.web implementation in WebEngine. Bug: 946732 Change-Id: I6d597d88369848ea3cf7bae140ee6581aa849892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570529 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#651923} fuchsia/base/BUILD.gn | 1 - fuchsia/engine/BUILD.gn | 17 - fuchsia/engine/DEPS | 1 - fuchsia/engine/browser/context_impl.cc | 13 - fuchsia/engine/browser/context_impl.h | 2 - .../browser/context_impl_legacy_browsertest.cc | 175 --- .../browser/frame_impl_legacy_browsertest.cc | 1229 -------------------- fuchsia/engine/context_provider_impl.h | 1 - .../context_provider_impl_legacy_unittest.cc | 289 ----- fuchsia/engine/context_provider_impl_unittest.cc | 1 - fuchsia/engine/context_provider_main.cc | 5 - fuchsia/engine/legacy_context_bridge.cc | 33 - fuchsia/engine/legacy_context_bridge.h | 38 - fuchsia/engine/legacy_context_provider_bridge.cc | 35 - fuchsia/engine/legacy_context_provider_bridge.h | 34 - fuchsia/engine/legacy_frame_bridge.cc | 164 --- fuchsia/engine/legacy_frame_bridge.h | 71 -- .../engine/legacy_navigation_controller_bridge.cc | 121 -- .../engine/legacy_navigation_controller_bridge.h | 45 - .../legacy_navigation_event_listener_bridge.cc | 52 - .../legacy_navigation_event_listener_bridge.h | 41 - fuchsia/engine/test/web_engine_browser_test.cc | 9 - fuchsia/engine/test/web_engine_browser_test.h | 3 - fuchsia/runners/BUILD.gn | 2 - .../runners/cast/cast_runner_integration_test.cc | 1 - 25 files changed, 2383 deletions(-) commit c32c68bfec1fe31c25578b15c5f2c2f3c0eb2025 Author: Matthew Denton <mpdenton@chromium.org> Date: Wed Apr 17 22:23:18 2019 +0000 Fixed Disk Cache LPM fuzzer CHECK for GetAvailableRange callback Bug: 951247 Change-Id: I52b49d0d9f22147bba14d6bd91ab4949de6acca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572923 Auto-Submit: Matthew Denton <mpdenton@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#651922} net/disk_cache/disk_cache_fuzzer.cc | 3 +++ 1 file changed, 3 insertions(+) commit 84b229f21647833ff6e97ca5e537c8f331be95f8 Author: Xing Liu <xingliu@chromium.org> Date: Wed Apr 17 22:22:41 2019 +0000 Close notification tray for PWA notification buttons. We use a broadcast receiver to track notification metrics in NotificationIntentInterceptor. After clicking notification button, the Android notification tray UI will not automatically close for intents handled in a broadcast receiver. We must close it manually in code. Bug: 952194 Change-Id: I1d7d0de8716f8c5c8ba23ac597576e7ff9aeb115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566729 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#651921} .../org/chromium/chrome/browser/webapps/WebappLauncherActivity.java | 5 +++++ 1 file changed, 5 insertions(+) commit 59dabafbc4b7d9a3bc8cdd5f9c3e8087ebd36539 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 22:11:17 2019 +0000 Roll src/third_party/webrtc 011d3a125e15..e0ab81c8c6e5 (3 commits) https://webrtc.googlesource.com/src.git/+log/011d3a125e15..e0ab81c8c6e5 git log 011d3a125e15..e0ab81c8c6e5 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 steveanton@webrtc.org Change steveanton watchlist email 2019-04-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 14c052d7be..adf8e94df9 (651715:651832) 2019-04-17 qingsi@webrtc.org Surface ICE candidates that match an updated candidate filter. Created with: gclient setdep -r src/third_party/webrtc@e0ab81c8c6e5 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6d7056a288245b389e10d7400307f6bf11321405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572105 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651920} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e21d9ee455e5abea3015f33c9e0ae4c1488c2d78 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 22:08:40 2019 +0000 Import wpt@9e9aa0453b996c6f8c9d765c757c8d0be5fad0b3 Using wpt-import in Chromium 01111fb832bccd10a7005d2c997997ab93a1af16. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" c1940432ee "[WPT/common/security-features] Merge subresource path construction" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Ic5995121f16af52263adce411550fbbcda7b93be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572363 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651919} .../web_tests/external/WPT_BASE_MANIFEST_6.json | 37 +++++++++++----------- .../external/wpt/tools/wptrunner/requirements.txt | 2 +- 2 files changed, 20 insertions(+), 19 deletions(-) commit dc3560cb8b40a9aa22a4ee9c1e129782e3b4b4a4 Author: Alex Moshchuk <alexmos@chromium.org> Date: Wed Apr 17 22:05:07 2019 +0000 When possible, swap BrowsingInstances when navigating to a newly isolated origin Currently, when a page triggers dynamic isolation for an origin and then navigates to that origin, the navigation does not end up in a dedicated process. This is because dynamic isolation only takes effect on future BrowsingInstances, and renderer-initiated (as well as same-site) navigations don't typically swap BrowsingInstances. This CL introduces a heuristic to look for such cases, and swap BrowsingInstances when this is safe to do, namely if the navigation is for a main frame, and there are no scripting references to the navigating frame from other windows. This will help protect sites sooner in the password-triggered isolation mode that we use on Android. For example, after typing in a password and submitting a same-site form, the resulting navigation should in many cases be able to swap BrowsingInstances and utilize a dedicated process. Bug: 941218 Change-Id: I7dfd198d71f1e5bd17754684a4ac3d05b8a6d6fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546861 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#651918} chrome/browser/chrome_navigation_browsertest.cc | 17 +- .../frame_host/render_frame_host_manager.cc | 59 +++++++ content/browser/isolated_origin_browsertest.cc | 190 +++++++++++++++++++++ 3 files changed, 264 insertions(+), 2 deletions(-) commit d2fe0910fec842a71987d04763b6fa92cceacaaa Author: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Date: Wed Apr 17 22:04:31 2019 +0000 traffic_annotation_extractor: strip plugin arguments Arguments passed to traffic_annotation_extractor that are related to plugins (e.g. find-bad-constructs) will now be ignored. This should fix CQ and waterfall issues with network annotation checks. Bug: 949382 Change-Id: I5b9003a008524ab30c58e031e1307d1a0d13396d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570918 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#651917} .../clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp | 2 ++ tools/traffic_annotation/bin/README.md | 2 +- tools/traffic_annotation/bin/linux64/traffic_annotation_extractor.sha1 | 2 +- .../traffic_annotation/bin/win32/traffic_annotation_extractor.exe.sha1 | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) commit 1b7b8807dfda546d0d07ffd6773b4580604a30e2 Author: Alexei Filippov <alph@chromium.org> Date: Wed Apr 17 22:01:43 2019 +0000 [heap profiler] Remove support for Out-of-process Heap Profiler. OOPHP has been replaced with a lightweight in-process memory allocation sampling profiler. BUG=949663,923459 TBR=rockot@google.com Change-Id: I6d5cca68246295d6de1ea15a1caf16c9f6eed1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570422 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Sergey Volk <servolk@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#651916} .../android_webview/test/HeapProfilingTest.java | 17 +- .../poisson_allocation_sampler.h | 2 +- base/threading/thread_local_storage.h | 5 - .../ProfilingProcessHostAndroidTest.java | 42 +- chrome/app/chrome_main_delegate.cc | 1 - chrome/app/generated_resources.grd | 3 - chrome/browser/about_flags.cc | 13 - chrome/browser/chrome_content_browser_client.cc | 13 +- chrome/browser/flag-metadata.json | 9 - chrome/browser/flag-never-expire-list.json | 2 - chrome/browser/flag_descriptions.cc | 7 - chrome/browser/flag_descriptions.h | 5 - .../browser/profiling_host/memlog_browsertest.cc | 16 +- chromecast/browser/cast_content_browser_client.cc | 19 +- chromecast/browser/cast_content_browser_client.h | 1 - .../heap_profiling/heap_profiling_test_shim.cc | 2 - .../heap_profiling/heap_profiling_test_shim.h | 1 - .../heap_profiling/HeapProfilingTestShim.java | 8 +- components/heap_profiling/supervisor.cc | 19 +- components/heap_profiling/supervisor.h | 2 - components/heap_profiling/test_driver.cc | 8 +- components/heap_profiling/test_driver.h | 5 - components/services/heap_profiling/BUILD.gn | 33 -- components/services/heap_profiling/DEPS | 1 - .../services/heap_profiling/allocation_event.h | 4 +- .../services/heap_profiling/allocation_tracker.cc | 123 ------ .../services/heap_profiling/allocation_tracker.h | 98 ----- .../services/heap_profiling/connection_manager.cc | 132 ++----- .../services/heap_profiling/connection_manager.h | 31 +- .../heap_profiling/heap_profiling_service.cc | 31 +- .../heap_profiling/heap_profiling_service.h | 1 - .../services/heap_profiling/json_exporter.cc | 2 +- components/services/heap_profiling/json_exporter.h | 1 - .../services/heap_profiling/public/cpp/BUILD.gn | 8 - .../services/heap_profiling/public/cpp/client.cc | 49 +-- .../services/heap_profiling/public/cpp/client.h | 10 +- .../heap_profiling/public/cpp/controller.cc | 13 +- .../heap_profiling/public/cpp/controller.h | 2 - .../public/cpp/sampling_profiler_wrapper.cc | 428 +-------------------- .../public/cpp/sampling_profiler_wrapper.h | 29 +- .../heap_profiling/public/cpp/sender_pipe.h | 69 ---- .../heap_profiling/public/cpp/sender_pipe_posix.cc | 107 ------ .../public/cpp/sender_pipe_unittest.cc | 95 ----- .../heap_profiling/public/cpp/sender_pipe_win.cc | 177 --------- .../services/heap_profiling/public/cpp/settings.cc | 5 - .../services/heap_profiling/public/cpp/settings.h | 1 - .../services/heap_profiling/public/cpp/stream.h | 92 ----- .../services/heap_profiling/public/cpp/switches.cc | 4 - .../services/heap_profiling/public/cpp/switches.h | 4 - .../public/mojom/heap_profiling_client.mojom | 23 +- .../public/mojom/heap_profiling_service.mojom | 9 +- components/services/heap_profiling/receiver.h | 35 -- .../services/heap_profiling/receiver_pipe.cc | 38 -- components/services/heap_profiling/receiver_pipe.h | 61 --- .../services/heap_profiling/receiver_pipe_posix.cc | 72 ---- .../services/heap_profiling/receiver_pipe_posix.h | 41 -- .../services/heap_profiling/receiver_pipe_win.cc | 85 ---- .../services/heap_profiling/receiver_pipe_win.h | 53 --- .../services/heap_profiling/stream_fuzzer.cc | 49 --- .../services/heap_profiling/stream_fuzzer.dict | 6 - .../services/heap_profiling/stream_parser.cc | 243 ------------ components/services/heap_profiling/stream_parser.h | 92 ----- .../heap_profiling/stream_parser_unittest.cc | 272 ------------- .../services/heap_profiling/stream_receiver.h | 35 -- 64 files changed, 119 insertions(+), 2745 deletions(-) commit 3a554bbcea3febe6d6b4ef5636a0fc3e3796a2e6 Author: Chris Lu <thegreenfrog@chromium.org> Date: Wed Apr 17 22:00:58 2019 +0000 [ios] Turn on UMA feature flag by default Bug: 931289 Change-Id: Ibd211f4a28d394793b986ad835015ac9c4948768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569748 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#651915} components/ukm/ios/features.cc | 2 +- ios/chrome/browser/ui/settings/BUILD.gn | 1 + ios/chrome/browser/ui/settings/password/BUILD.gn | 1 + .../privacy_table_view_controller_unittest.mm | 4 +- ios/chrome/browser/ui/settings/settings_egtest.mm | 85 ++++++++++++++-------- 5 files changed, 60 insertions(+), 33 deletions(-) commit 59a9ce0b57d56c7030be0ebcf708645ad6ef5c53 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 22:00:15 2019 +0000 Roll src/third_party/perfetto 054acd5a4ade..3d46e0d12b17 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/054acd5a4ade..3d46e0d12b17 git log 054acd5a4ade..3d46e0d12b17 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 fmayer@google.com Revert "Enable LTO in Android tree." Created with: gclient setdep -r src/third_party/perfetto@3d46e0d12b17 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia94856319fe7815765fad56316c33866095274e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572101 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651914} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 875b740b284c7a8ad7a04597e2348d8969c1cdf6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 21:59:53 2019 +0000 Roll src/third_party/angle 0f7a2330c026..e3c7134c2717 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/0f7a2330c026..e3c7134c2717 git log 0f7a2330c026..e3c7134c2717 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jonahr@google.com Add script to collect information from tests running on bots. Created with: gclient setdep -r src/third_party/angle@e3c7134c2717 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I07af31c9683bb2f4897029d03566fefc51e352bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572106 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651913} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 20d9aa5490139ec179e63353e89c87d280feb8f7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 21:57:06 2019 +0000 Roll src/third_party/chromite 99b17bbcf7c4..5a01970efa3a (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/99b17bbcf7c4..5a01970efa3a git log 99b17bbcf7c4..5a01970efa3a --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jclinton@chromium.org paygen: Constrain the number of parallel delta_generator processes 2019-04-17 dhanyaganesh@chromium.org lib/auth.py: Enable manual login on eng workstations Created with: gclient setdep -r src/third_party/chromite@5a01970efa3a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib580fb15f5d91eed86d2d4db01d1f8b6cbd78c8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572104 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651912} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1cecb81a596d655db4d862caf5a005ff952e8e83 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Apr 17 21:54:57 2019 +0000 [Autofill Assistant] Introduce AssistantActionsCarouselCoordinator. This CL introduces a new carousels in which we display actions. Video: go/aa-carousel-v2 Change-Id: Ib8f61e13bda91f796c9c5741e217edcee0599a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565002 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#651911} .../android/features/autofill_assistant/BUILD.gn | 2 + .../layout/autofill_assistant_button_filled.xml | 2 +- .../layout/autofill_assistant_button_hairline.xml | 2 +- .../java/res/values-v17/dimens.xml | 2 + .../AssistantBottomBarCoordinator.java | 7 +- .../AssistantActionsCarouselCoordinator.java | 234 +++++++++++++++++++++ .../carousel/AssistantCarouselCoordinator.java | 161 +------------- .../carousel/AssistantChipViewHolder.java | 5 +- .../AssistantSuggestionsCarouselCoordinator.java | 164 +++++++++++++++ .../AutofillAssistantUiTest.java | 8 +- .../autofill_assistant/ui_controller_android.cc | 12 +- 11 files changed, 429 insertions(+), 170 deletions(-) commit a00994b12df8e4dbadddb9ca7fbe99c6ac0c8622 Author: Alex Cooper <alcooper@chromium.org> Date: Wed Apr 17 21:54:45 2019 +0000 Expose Windows Mixed Reality Gamepad data to WebVR This change implements support for GetNextGamepadData in WMR. In doing so, it also refactors the LockedParseWindowsSourceState to return a struct which contains all the data necessary to make either a WebVR or WebXR gamepad (with some data massaging needed). Future work could refactor these structs into their own files/proper classes with some of the anonymous namespace methods implemented as their class methods. Bug: 951607 Change-Id: I5ef17939fd731f60c2424bd986b9552a8b8fe87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566673 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651910} device/gamepad/gamepad_pad_state_provider.h | 3 +- device/vr/isolated_gamepad_data_fetcher.cc | 22 +- .../mixed_reality_input_helper.cc | 375 ++++++++++++++++++--- .../mixed_reality_input_helper.h | 35 +- .../mixed_reality_renderloop.cc | 15 +- tools/metrics/histograms/enums.xml | 1 + 6 files changed, 398 insertions(+), 53 deletions(-) commit 862c37b12b198e8604c1bd8515421a555b2b6fca Author: Kevin Bailey <krb@chromium.org> Date: Wed Apr 17 21:50:29 2019 +0000 [omnibox] Don't show site name when in keyword mode Currently we show the site name with the first suggestion of a group of suggestions from that site. But in keyword mode, we're already displaying the site name in the Omnibox, and all the suggestions should be from there, so displaying it again is redundant. Bug: 883901 Change-Id: Ic292180d4e463ed50f56c0f0d6faf7b75ee3dd73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565440 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#651909} .../omnibox/browser/autocomplete_controller.cc | 10 +++++++++- .../omnibox/browser/autocomplete_controller.h | 5 +++++ .../omnibox/browser/autocomplete_provider.cc | 22 ++++++++++++++++++++++ components/omnibox/browser/autocomplete_provider.h | 7 +++++++ components/omnibox/browser/search_provider.cc | 17 ++++++----------- 5 files changed, 49 insertions(+), 12 deletions(-) commit 2ffa79eb3ca96ee9e00d3423b5b42663d6687f05 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 21:47:56 2019 +0000 Roll src/third_party/skia 105d7c24c9b4..5b39dc81534a (4 commits) https://skia.googlesource.com/skia.git/+log/105d7c24c9b4..5b39dc81534a git log 105d7c24c9b4..5b39dc81534a --date=short --no-merges --format='%ad %ae %s' 2019-04-17 halcanary@google.com SkQP: fix model colorspace (16-bit gold images) 2019-04-17 egdaniel@google.com Add struct to wrap all the gpu flush options. 2019-04-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-17 reed@google.com Reland "Simplify SkTypeface::charsToGlyphs API to require UTF32 input" Created with: gclient setdep -r src/third_party/skia@5b39dc81534a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I7fc04285250ce2f053ffe122976ef2e301e7c1aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572103 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651908} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 812e7d822be499ade457e083621d45acd535779f Author: Marijn Kruisselbrink <mek@chromium.org> Date: Wed Apr 17 21:46:01 2019 +0000 [Native File System] Move tests to WPT and re-enable them. Bug: 922735 Change-Id: I33c62397a6c3c8993ffdd6ab0abe60a12d92cef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532902 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#651907} third_party/blink/web_tests/TestExpectations | 4 ++-- third_party/blink/web_tests/VirtualTestSuites | 5 +++++ .../FileSystemBaseHandle-copyTo.tentative.window.js} | 9 +-------- .../FileSystemBaseHandle-moveTo.tentative.window.js} | 11 ++--------- .../FileSystemBaseHandle-remove.tentative.window.js} | 10 ++-------- ...stemDirectoryHandle-getDirectory.tentative.window.js} | 9 +-------- ...ileSystemDirectoryHandle-getFile.tentative.window.js} | 10 ++-------- .../FileSystemWriter.tentative.window.js} | 8 +------- .../web_tests/external/wpt/native-file-system/README.md | 2 ++ .../wpt/native-file-system}/resources/test-helpers.js | 16 +++------------- .../external/wpt/native-file-system/README.txt | 2 ++ 11 files changed, 23 insertions(+), 63 deletions(-) commit 3613f23ea40499ca0de09babbc8c545c88232353 Author: yilkal <yilkal@chromium.org> Date: Wed Apr 17 21:39:22 2019 +0000 Disable child time zone setting Bug: 928544 Change-Id: Ice2bc932092e8534a849a4f63d4195b919115735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558581 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#651906} .../extensions/api/settings_private/generated_time_zone_pref_base.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9f25017463ee6cbfa63166b152212b5f705af328 Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Apr 17 21:37:32 2019 +0000 [Image Fetcher] Replace AnswersImageFetcher with CachedImageFetcher Removing a duplicate cached image fetcher here. Bug: 934950 Change-Id: I0063aa8e26cbd4c0a0acb7f3c59f4ee86116e2db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481955 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#651905} chrome/android/BUILD.gn | 1 - chrome/android/chrome_java_sources.gni | 1 - .../org/chromium/chrome/browser/BitmapCache.java | 8 ++ .../browser/image_fetcher/CachedImageFetcher.java | 3 + .../chrome/browser/image_fetcher/ImageFetcher.java | 6 ++ .../browser/image_fetcher/ImageFetcherFactory.java | 42 +++++---- .../image_fetcher/InMemoryCachedImageFetcher.java | 7 +- .../browser/image_fetcher/NetworkImageFetcher.java | 3 + .../chrome/browser/omnibox/LocationBar.java | 5 + .../chrome/browser/omnibox/LocationBarLayout.java | 6 ++ .../omnibox/suggestions/AnswersImageFetcher.java | 104 --------------------- .../suggestions/AutocompleteCoordinator.java | 7 +- .../omnibox/suggestions/AutocompleteMediator.java | 7 +- .../answer/AnswerSuggestionProcessor.java | 66 ++++++++----- .../browser/toolbar/top/CustomTabToolbar.java | 3 + .../chrome/browser/toolbar/top/ToolbarLayout.java | 2 + .../image_fetcher/ImageFetcherFactoryTest.java | 15 +-- .../browser/image_fetcher/ImageFetcherTest.java | 3 + chrome/browser/BUILD.gn | 1 - .../android/omnibox/answers_image_bridge.cc | 77 --------------- tools/metrics/histograms/histograms.xml | 2 + 21 files changed, 133 insertions(+), 236 deletions(-) commit 6c18981e987053f4ce082da8d974400917ddc247 Author: Kristi Park <kristipark@chromium.org> Date: Wed Apr 17 21:35:57 2019 +0000 [NTP] Remove commented code in tests This slipped in somehow. Change-Id: I7711d85a9da6d4f77cecd979b65a178090f5241e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572372 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#651904} chrome/browser/ui/search/local_ntp_test_utils.cc | 64 ------------------------ 1 file changed, 64 deletions(-) commit 4e24db799defc6b569890e0d28bda8682189f6d0 Author: Karan Bhatia <karandeepb@chromium.org> Date: Wed Apr 17 21:33:28 2019 +0000 DocServer: Make some dummy schema changes to verify auto-update fix. This CL makes some dummy schema changes to some extension APIs. This is used to test whether r651051 fixed the DocServer. BUG=513780 Change-Id: Ifc7c4cab3c2d4198252e781262e704ed383dacc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572236 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651903} chrome/common/extensions/api/devtools/inspected_window.json | 2 +- chrome/common/extensions/api/top_sites.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit dba4b35129f3aa50e7b3534e08098095927cb3b2 Author: Jazz Xu <jazzhsu@chromium.org> Date: Wed Apr 17 21:32:38 2019 +0000 [Media Controls] Icon update Update icons for mid overlay UI. Bug: 928443 Change-Id: I772368c5b8f4074ef5414354b8283e95ac7db353 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570256 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#651902} .../touchless/resources/ic_fast_forward.svg | 5 +---- .../touchless/resources/ic_fast_rewind.svg | 5 +---- .../touchless/resources/ic_mid_background.svg | 4 ++++ .../media_controls/touchless/resources/ic_pause.svg | 5 +---- .../touchless/resources/ic_play_arrow.svg | 5 +---- .../touchless/resources/ic_volume_down.svg | 5 +---- .../media_controls/touchless/resources/ic_volume_up.svg | 5 +---- .../touchless/resources/mediaControlsTouchless.css | 17 +++++++++-------- 8 files changed, 19 insertions(+), 32 deletions(-) commit 80383379a5c37b2251377e8cbb0bf1584baa2021 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Apr 17 21:29:24 2019 +0000 SpeechRecognition: Remove separate target for error code mojom I initially kept a separate target because content_java didn't have a dependency to blink/public/mojom:mojom_platform_java, and I didn't want to add the dependency just for an enum. It looks like we now have the dependency, so the seperate target isn't needed anymore. Change-Id: I9249aab101f18abd58c604f33523ed1140f7ec47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571485 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#651901} content/public/android/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 13 +------------ 2 files changed, 1 insertion(+), 13 deletions(-) commit 1653bfa2ed04659d2234184c762c19caf1b311a4 Author: tby <tby@chromium.org> Date: Wed Apr 17 21:29:00 2019 +0000 [Dolphin] Make unit tests use a QUEUED task environment. Using QUEUED means that PostTasks are not executed until RunUntilIdle() is called, which makes tests that check behaviour before IO in a PostTask completes more robust. This change also affects the corresponding Roselle test. Bug: 921444 Change-Id: Ic84fd8a4815e2008483824d65396dec6f2923ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571118 Reviewed-by: Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#651900} .../search/search_result_ranker/app_search_result_ranker_unittest.cc | 4 +++- .../search/search_result_ranker/recurrence_ranker_unittest.cc | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) commit 939fa23eb94b0f62f9dd04490927eb3d5e503a8e Author: Jonathan Backer <backer@chromium.org> Date: Wed Apr 17 21:20:52 2019 +0000 Enable hi-precision video tests Changes include: (a) enable tests (b) apply resource_offset unpremul to be consistent with GLRenderer (c) silence some LOG spam on DCHECK enabled builds Bug: 950965 Change-Id: I42cb6ca96f6f377b83e5e793bf6ea51bfccf8849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572367 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#651899} components/viz/service/display/renderer_pixeltest.cc | 6 ++---- components/viz/service/display/skia_renderer.cc | 6 +++--- .../viz/service/display_embedder/skia_output_surface_impl.cc | 8 +++++++- 3 files changed, 12 insertions(+), 8 deletions(-) commit 6ddadb12cbbc9c0b7c923644667ed33c5a535ff0 Author: Mike Wasserman <msw@chromium.org> Date: Wed Apr 17 21:19:12 2019 +0000 Avoid BrowserShortcutLauncherItemController crashes on null windows No-op if the browser's window is null in ExecuteCommand. See the bug for some basic investigation notes. Bug: 937088 Test: Fewer crash reports for this function. Change-Id: I05bd7249be38f35db4e82dcde13c0dc19164b690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572898 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#651898} .../ui/ash/launcher/browser_shortcut_launcher_item_controller.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 23e8e238f7645a65b073ee1dba430c41cc997206 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Wed Apr 17 21:18:49 2019 +0000 [Autofill] Functions to determine when contact data is the same. This CL was split off from the below CL. https://chromium-review.googlesource.com/c/chromium/src/+/1566373/10 These functions will be used to help create labels for address contact forms. When a phone number or an email address is the same across all profiles being used to make dropdown suggestions, then it should not be shown. It is preferable to not display the same phone number or email address to the user in the context of address plus contact forms in order to shorten the length of the label. Bug: 936168 Change-Id: If3a5066cb0bcda189f19e11140d89b6675da0d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571009 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#651897} .../autofill/core/browser/label_formatter_utils.cc | 44 ++++++ .../autofill/core/browser/label_formatter_utils.h | 17 ++- .../core/browser/label_formatter_utils_unittest.cc | 152 ++++++++++++++++++++- .../autofill/core/browser/phone_number_i18n.cc | 2 + 4 files changed, 212 insertions(+), 3 deletions(-) commit 613ebffa020159c9b82d5b0891cc6d6a7cabe12d Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Apr 17 21:04:17 2019 +0000 [Extensions Bindings] Consolidate RendererMessagingService Since native bindings are now the only bindings system for extensions, remove the base class of RendererMessagingService, and consolidate all functionality in NativeRendererMessagingService: - Remove renderer_messaging_service.* - De-virtualize methods and transfer comments to NativeRendererMessagingService - Move functionality from renderer_messaging_service.cc to native_renderer_messaging_service.cc - Update references and includes to point to NativeRendererMessagingService Bug: 938998 Change-Id: Ia2458a0fc12d75409b106f6d2e11a772628dfe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545497 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#651896} extensions/renderer/BUILD.gn | 2 - extensions/renderer/dispatcher.cc | 8 +- extensions/renderer/extension_frame_helper.cc | 15 +- .../renderer/native_extension_bindings_system.cc | 4 - .../renderer/native_extension_bindings_system.h | 3 - .../renderer/native_renderer_messaging_service.cc | 182 +++++++++++++++++- .../renderer/native_renderer_messaging_service.h | 78 +++++++- extensions/renderer/renderer_messaging_service.cc | 209 --------------------- extensions/renderer/renderer_messaging_service.h | 122 ------------ extensions/renderer/worker_thread_dispatcher.cc | 10 +- 10 files changed, 266 insertions(+), 367 deletions(-) commit 4ffc37949cfc0f24bacddbd458fe8406169a7e62 Author: W. James MacLean <wjmaclean@chromium.org> Date: Wed Apr 17 21:03:35 2019 +0000 Track external pinch gesture active state separately. This CL corrects a logic error in the pinch re-raster throttling logic for OOPIFs. Prior to this CL, it's possible for pinch_gesture_active_ on the main-frame's compositor to be incorrectly overwritten to |false| while a gesture is still active. This CL corrects that by tracking local and internal pinch gesture activity separately, and using a logical-OR of the two to control the re-raster logic. Bug: 924336, 951861, 951924 Change-Id: I4ef7a699038cd523abc671b23bb0a94f4b28a849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572099 Commit-Queue: James MacLean <wjmaclean@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#651895} cc/trees/layer_tree_host.cc | 3 ++- cc/trees/layer_tree_host_impl.h | 11 ++++++++--- cc/trees/layer_tree_host_impl_unittest.cc | 24 ++++++++++++++++++++++++ 3 files changed, 34 insertions(+), 4 deletions(-) commit a1ae74b57df4e0d1cb93896f1311053541bb2a8b Author: Suzy Li <suzyli@google.com> Date: Wed Apr 17 21:03:12 2019 +0000 Support the UVM extension at blink layer and mojo The UVM extension[1] enables RPs to discover the user verification method that was used during a WebAuthn request. The change adds UVM extension at blink layers and authenticator.mojom and corresponding part to convert/Resolve between IDL dictionary and mojom structure. [1] https://w3c.github.io/webauthn/#sctn-uvm-extension Bug: 920748 Change-Id: Iba8ac201e06252817be35e9c8b4c9e78b2ace58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534288 Commit-Queue: Suzy Li <suzyli@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#651894} .../public/mojom/webauthn/authenticator.mojom | 46 ++++++++++++++++++++++ .../authentication_extensions_client_inputs.idl | 2 + .../authentication_extensions_client_outputs.idl | 4 ++ .../credential_manager_type_converters.cc | 11 ++++++ .../credentialmanager/credentials_container.cc | 27 +++++++++++++ 5 files changed, 90 insertions(+) commit 2e7ce4aa721480936174b963b3c2f1d18a29c028 Author: Céline O'Neil <celineo@google.com> Date: Wed Apr 17 21:01:23 2019 +0000 Turn off frame rate limit for CompositorFrame fuzzer. If the fuzzing iterations are faster than the frame rate, the CompositorFrameSinkSupport can fall behind and OnBeginFrame may not be called during each iteration. (It is certainly not called at a consistent time within each iteration.) Passing the disable_frame_rate_limit parameter to the RootCompositorFrameSink makes it use a BackToBackBeginFrameSource rather than a DelayBasedFrameSource. R=kylechar@chromium.org Bug: 923088 Change-Id: Iba02a0623e5b45695503db1436cba3cfb3a9f113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572213 Commit-Queue: Céline O'Neil <celineo@google.com> Auto-Submit: Céline O'Neil <celineo@google.com> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#651893} .../viz/service/compositor_frame_fuzzer/fuzzer_browser_process.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit fb647177c3da3461b0975ea7864e5785243b9e2f Author: Peter Boström <pbos@chromium.org> Date: Wed Apr 17 21:01:16 2019 +0000 Add context menus to Extensions menu entries Implements ShowContextMenuForViewImpl and IsMenuRunning inside ExtensionsMenuButton. This is done by using the HoverButton secondary view to add a "More actions" context-menu button. Regardless of how the context menus inside the Extensions menu were triggered (button, actionless extension, right-clicking the menu entries) the context menu will anchor to the additional-actions button to inform users about its existence. Bug: chromium:943702 Change-Id: Id6ab6e0ddacd4298884206bbe13ad59cb1460a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570771 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#651892} chrome/app/generated_resources.grd | 3 + .../ui/views/extensions/extensions_menu_button.cc | 91 ++++++++++++++++++++-- .../ui/views/extensions/extensions_menu_button.h | 22 +++++- chrome/browser/ui/views/hover_button.cc | 11 ++- chrome/browser/ui/views/hover_button.h | 1 + 5 files changed, 119 insertions(+), 9 deletions(-) commit ef28147c8433c224f823bc2a47d9500d7008addf Author: Aleks Totic <atotic@chromium.org> Date: Wed Apr 17 20:59:52 2019 +0000 Revert "TrustStoreMac: Use internal implementation for IsSelfSigned" This reverts commit 6ef07c67d055f6982252a82856bf5dec05d07958. Reason for revert: https://crbug.com/953911 Mac 10.11 net_unittest failure Original change's description: > TrustStoreMac: Use internal implementation for IsSelfSigned > > This is significantly faster (about 80x in some quick testing). > > Also remove the now unused x509_util_mac IsSelfSigned function. > > Bug: 410574 > Change-Id: I60cfc40d5f5a5dab419566836555cb4828148c6f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570768 > Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> > Commit-Queue: Matt Mueller <mattm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651774} TBR=rsleevi@chromium.org,mattm@chromium.org Change-Id: Ie04e46f6703050317aaa21293a8361b534e026ce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 410574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572862 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#651891} net/cert/internal/trust_store_mac.cc | 19 ++++--------------- net/cert/x509_util_mac.cc | 36 ++++++++++++++++++++++++++++++++++++ net/cert/x509_util_mac.h | 3 +++ 3 files changed, 43 insertions(+), 15 deletions(-) commit 8efc25a63c155cc92a77594aa658faa531b0fb5d Author: mark a. foltz <mfoltz@chromium.org> Date: Wed Apr 17 20:56:32 2019 +0000 [Mirror Service] Disable adaptive latency in mirror service. This mirrors a bugfix in the upstream Media Router extension. Bug: openscreen:44 Change-Id: I236f1d6be6a0ff64b63216343b1c31bee5dcdbba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572265 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#651890} components/mirroring/service/mirror_settings.cc | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) commit 04e2171d363081f728ac08cacb5cde53712b4848 Author: Carlos Caballero <carlscab@google.com> Date: Wed Apr 17 20:56:29 2019 +0000 Refactor work_queue_unittest.cc No need to create a SequenceManager Change-Id: I0de23b4d94b74fc86e0401ce8d7a44d98d97e2c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571585 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#651889} base/task/sequence_manager/work_queue_unittest.cc | 26 +++++++++++++---------- 1 file changed, 15 insertions(+), 11 deletions(-) commit 3366c411a2689e1dedac2b730ecc940bdd5694c0 Author: Aaron Colwell <acolwell@google.com> Date: Wed Apr 17 20:55:28 2019 +0000 Remove redundant assignment to |expected_render_process_host_id_|. Removing an assignment to |expected_render_process_host_id_| because the ResetExpectedProcess() call right before the statement contains the exact same assigment. This extra assignment implied there might be some extra case we needed to handle when in fact this isn't the case. Change-Id: I579a56f8c5248de638aae089e678b31cd45685a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572261 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#651888} content/browser/frame_host/navigation_request.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit db36432ea654d7fd1be59f7e98d1de2706f97cb0 Author: Kyle Milka <kmilka@chromium.org> Date: Wed Apr 17 20:52:10 2019 +0000 [NTP] Update README Remove mentions of the remote NTP from chrome/browser/search/README. Bug: 583289 Change-Id: I16b3f1b9f5a915a4fa416c801f1ed959273fd086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570143 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#651887} chrome/browser/search/README.md | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) commit 62e2574d87ab12baa20aa603c1b231c413dcda9d Author: Corentin Wallez <cwallez@chromium.org> Date: Wed Apr 17 20:49:46 2019 +0000 Disable use_dawn on Mac for the branch point BUG=chromium:852089 TBR=kbr@chromium.org Change-Id: I63ba202ac4eb937088ee471a84d8d49ef0a2334a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571690 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#651886} ui/gl/features.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f49c7319d4a6f6d2441a71ec2df324e9d2af5603 Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Apr 17 20:48:37 2019 +0000 [PM] Remove usage of PageSignalObserver from TabManager. This is another step in the path to migrating the PageSignal mechanism. BUG=931407 Change-Id: I3e0b7503e6cf90eb1b058aa2edee4c9363753e74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571014 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651885} .../resource_coordinator/tab_load_tracker.cc | 6 +- .../resource_coordinator/tab_load_tracker.h | 5 +- chrome/browser/resource_coordinator/tab_manager.cc | 19 +++- chrome/browser/resource_coordinator/tab_manager.h | 5 - ...manager_resource_coordinator_signal_observer.cc | 113 +++++++++++++++------ ..._manager_resource_coordinator_signal_observer.h | 54 ++++++++-- 6 files changed, 147 insertions(+), 55 deletions(-) commit 23b8f23ec08198bfa684d557dec0295c7ece5194 Author: yilkal <yilkal@chromium.org> Date: Wed Apr 17 20:46:56 2019 +0000 Reland "Replace indicator icon to kite for users under parental supervision." This is a reland of adde9d0e1997a737501057cff70e4869a8c1e03a Original change's description: > Replace indicator icon to kite for users under parental supervision. > > Bug: 944118 > Change-Id: I6ac8ce83c6037a6c6db3b15a111414c68707c8aa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548567 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#650543} Bug: 944118 Change-Id: Ia7211da37a272825a4613568f1f10fa8e0091d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566764 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651884} chrome/app/chromeos_strings.grdp | 4 +++- .../resources/settings/chromeos/os_settings_ui/os_settings_ui.js | 2 ++ chrome/browser/resources/settings/settings_ui/settings_ui.js | 2 ++ .../browser/ui/webui/policy_indicator_localized_strings_provider.cc | 1 + chrome/common/extensions/api/settings_private.idl | 3 ++- chrome/test/data/webui/cr_elements/cr_policy_strings.js | 1 + third_party/closure_compiler/externs/settings_private.js | 3 ++- ui/webui/resources/cr_elements/icons.html | 1 + .../resources/cr_elements/policy/cr_policy_indicator_behavior.js | 6 ++++++ ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js | 2 ++ 10 files changed, 22 insertions(+), 3 deletions(-) commit 4e7f57cba831b679838e686b7dd5cebe7ac2d4c5 Author: David Tseng <dtseng@chromium.org> Date: Wed Apr 17 20:45:25 2019 +0000 Fixes to automation selection api - renaming anchor -> start, focus -> end, to match new api semantics - add idl definitions for new selection* properties - fixup ChromeVox closure (check for undefined focusObject) - add TODOs where needed Change-Id: Icd1aeced5ed2b5a63207e75f150958e3b067a241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565110 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#651883} .../chromeos/chromevox/cvox2/background/editing.js | 48 ++++++++++++---------- chrome/common/extensions/api/automation.idl | 19 +++++++++ third_party/closure_compiler/externs/automation.js | 32 ++++++++------- 3 files changed, 63 insertions(+), 36 deletions(-) commit b07a6bc535b3f703dae217f6a6086ec165099aaf Author: Brandon Wylie <wylieb@chromium.org> Date: Wed Apr 17 20:43:23 2019 +0000 [Touchless] Refresh last tab button for new specifications Secondary benefit is adding drawables for rounded rect focused/ unfocused states which we can use for new feed buttons. Bug: 936052 Change-Id: If19842d9eb9be0404064373a74b31e6d66bfff80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566220 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651882} .../java/res/layout/open_last_tab_button.xml | 42 +++++++++++++---- .../touchless/java/res/values-v17/dimens.xml | 6 +-- .../chrome/browser/touchless/OpenLastTabView.java | 55 +++++++--------------- 3 files changed, 53 insertions(+), 50 deletions(-) commit d4cfd598b4ad6e63d351c37f54ac87c967a781f1 Author: manuk <manukh@chromium.org> Date: Wed Apr 17 20:43:12 2019 +0000 [omnibox]: Dedupe builtin provider's classification. This is the 10th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. Ignoring `/` slashes and interchanging 'about' and the embedder about scheme (e.g. 'chrome'), the user text is always a prefix of builtin suggestions. Previously, ACMatchClassifications were constructed manually by comparing lengths of input and match texts while compensating for optional symbols ('/' and ':'). With this CL, we remove some of the minor duplicated logic regarding determining trailing styles and reduce the manual creation by using `ClassifyTermMatches`. We still create `TermMatches` manually, but `ClassifyTermMatches` will create `ACMatchClassifications` from the `TermMatches`, which is simpler than creating the `ACMatchClassifications` manually. Unfortunately, we can't use `FindTermMatches` to create the `TermMatches` because the builtin provider treats 'about' and the embedder about scheme interchangeably (except for 'about:blank'). This CL does not change the suggestion texts, scoring, or classification; it only dedupes computing the classifications. Bug: 366623 Change-Id: I528a54c8b94fdd6b8dccbb3a3370b21c9efb1dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572205 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#651881} components/omnibox/browser/builtin_provider.cc | 31 +++++++++++++------------- 1 file changed, 15 insertions(+), 16 deletions(-) commit 794c2ee5326226ddd3884c11be6afc5246f696a1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 20:38:21 2019 +0000 Roll src/third_party/chromite e72d09e780ce..99b17bbcf7c4 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/e72d09e780ce..99b17bbcf7c4 git log e72d09e780ce..99b17bbcf7c4 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 tomhughes@chromium.org lakitu-st: mark experimental due to failing builds Created with: gclient setdep -r src/third_party/chromite@99b17bbcf7c4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I8006b0f17cb9fea109a093cba9f670cebe2e8bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572620 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651880} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7902696e44b5d354f412d7e12b8979f09d91c1a2 Author: Johannes Henkel <johannes@chromium.org> Date: Wed Apr 17 20:37:41 2019 +0000 [DevTools] Roll inspector_protocol. New Revision: 34bdcd1fb46ec80fb22908ee03fdb7cacf2575ac - SpanFrom for string literals - CBOREncoder fix for envelopes > 4GB Change-Id: Iee560b91f837149bfd6327aae5ea4280d61daa1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572499 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#651879} third_party/inspector_protocol/README.chromium | 2 +- .../inspector_protocol/encoding/encoding.cc | 71 ++++++++++++++++------ third_party/inspector_protocol/encoding/encoding.h | 11 ++++ .../inspector_protocol/encoding/encoding_test.cc | 28 +++++++-- .../inspector_protocol/lib/encoding_cpp.template | 71 ++++++++++++++++------ .../inspector_protocol/lib/encoding_h.template | 11 ++++ 6 files changed, 153 insertions(+), 41 deletions(-) commit 0479c9a954d273f0580c4d81fe5bfb52a172b588 Author: Emil A Eklund <eae@chromium.org> Date: Wed Apr 17 20:36:27 2019 +0000 Remove unnecessary DrawText methods Remove unused DrawText methods from Font and GraphicsContext. Also merge one of the templetized DrawTextInternal methods into the calling method. Change-Id: I9b19ad4b2d4cc9bcf462c25a38b92c17fa4bd693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572207 Auto-Submit: Emil A Eklund <eae@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#651878} third_party/blink/renderer/platform/fonts/font.cc | 9 -------- third_party/blink/renderer/platform/fonts/font.h | 5 ----- .../renderer/platform/graphics/graphics_context.cc | 25 ++++------------------ .../renderer/platform/graphics/graphics_context.h | 14 ++---------- 4 files changed, 6 insertions(+), 47 deletions(-) commit 9fbdfd6c01aebbf8ff78527b411d8fc0cdc1eeb5 Author: Rohan Pavone <rohpavone@chromium.org> Date: Wed Apr 17 20:36:23 2019 +0000 [ChromeDriver] No active element returns kNoSuchElement. When no document element, returns no such element instead of "null" JSON object. Bug: chromedriver:2850 Change-Id: I2b9d962c43ce934de1336e07643a1909d306888c Test: webdriver/tests/get_active_element/get.py:test_missing_document_element goes from FAIL => PASS. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570690 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Auto-Submit: Rohan Pavone <rohpavone@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#651877} chrome/test/chromedriver/element_util.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit 209fd4e373ee99ea9c4c19be5a317ddd1b8fe9b6 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Apr 17 20:32:43 2019 +0000 Revert "Test offsetLeft/offsetTop of multi-line inline elements" This reverts commit 07b1529d17138ce3b6441394d451e1d7d3cbe841. We need to think more about the expected behavior. Original change's description: > Test offsetLeft/offsetTop of multi-line inline elements > > Bug: 953572 > Change-Id: If3160a817ad784ea7c48f8f5ed7717f6de1bbff3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570474 > Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Koji Ishii <kojii@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651616} TBR=wangxianzhu@chromium.org,kojii@chromium.org Change-Id: Id017a3a0d7c8a4197d30c85fa7220e6e8ea8f160 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 953572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572858 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#651876} .../enable-blink-features=LayoutNG | 1 - .../cssom-view/offsetTopLeftInlineMultiLine.html | 55 ---------------------- 2 files changed, 56 deletions(-) commit ae933a3dcaea14d68f06d0dff6ce2cffa366d9ba Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 17 20:29:40 2019 +0000 Roll src-internal db8bc8a9d46c..8d6e1e0bfd92 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db8bc8a9d46c..8d6e1e0bfd92 Created with: gclient setdep -r src-internal@8d6e1e0bfd92 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I168e2aa42e0909062f9f9facc46004da0f8b5a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572194 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651875} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c1e1c1e18507224bb3ab45d61e24d3180f709fbe Author: Manuel Rego Casasnovas <rego@igalia.com> Date: Wed Apr 17 20:28:42 2019 +0000 [css-contain] Disable CompositingInputsRoot optimization for iframes Iframes with "contain: strict" are causing crashes in CompositingRequirementsUpdater::UpdateRecursive(). This patch disables the CompositingInputsRoot optimization for that case to avoid the problems. Similar to what we do in r650009 for sticky elements. BUG=953159 TEST=fast/css/containment/compositing-inputs-root-iframe-crash.html Change-Id: I1f14310e24570137759f8456072c0bd090639346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570170 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651874} third_party/blink/renderer/core/paint/paint_layer.cc | 5 ++++- .../containment/compositing-inputs-root-iframe-crash-expected.txt | 1 + .../css/containment/compositing-inputs-root-iframe-crash.html | 8 ++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) commit aa457b6d8ca55721370d6b521d536eec622a29bd Author: Avery Musbach <amusbach@chromium.org> Date: Wed Apr 17 20:28:32 2019 +0000 split view: Adjust duration of white bar animation for divider dragging The present CL changes the duration of the animation where the divider handle morphs into a circle when dragging starts or back to its original shape when dragging ends. The desired duration is specified here: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#project-resizing Test: manual Bug: 953819 Change-Id: I79267c9a6d1d2451ed771068beb35593fb4724af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572519 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#651873} ash/wm/splitview/split_view_divider.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2373f29e5810d7da6a3bd64ebb4b56215c7562a6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 20:27:32 2019 +0000 Roll src/third_party/perfetto 084712c40e18..054acd5a4ade (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/084712c40e18..054acd5a4ade git log 084712c40e18..054acd5a4ade --date=short --no-merges --format='%ad %ae %s' 2019-04-17 treehugger-gerrit@google.com Merge "Switch to just choosing a random file name rather then TempFile::Create()" Created with: gclient setdep -r src/third_party/perfetto@054acd5a4ade The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8d79a4409914260a95ddffc1b78b1ec89be0673e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572197 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651872} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 24053f815bac1aefb973bfa6773ef26cd810165f Author: Katie D <katie@chromium.org> Date: Wed Apr 17 20:24:37 2019 +0000 Add UMA to see if docked magnifier is enabled 45 secs after startup. Bug: 951549 Change-Id: Iaf9abb6078eead4a3933665b073a2a02cf49064e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565267 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#651871} .../accessibility/accessibility_manager.cc | 64 ++++++++++++---------- tools/metrics/histograms/histograms.xml | 10 ++++ 2 files changed, 46 insertions(+), 28 deletions(-) commit b9b9f6e51dada95ad71d254532f6504e312bc10b Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Wed Apr 17 20:23:27 2019 +0000 Limit PIN support only to IPPS, USB and IPP-over-USB printers. Bug: 848942 Change-Id: Ib3efeb2c0eb7d53c213d15621d5b97637c9bd94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557029 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651870} .../local_printer_handler_chromeos.cc | 5 ++- .../print_preview/local_printer_handler_default.cc | 1 + components/policy/resources/policy_templates.json | 2 +- .../printing/browser/printer_capabilities.cc | 12 +++++- components/printing/browser/printer_capabilities.h | 5 ++- .../browser/printer_capabilities_unittest.cc | 49 +++++++++++++++++++--- 6 files changed, 63 insertions(+), 11 deletions(-) commit 89fdab75eab8850801a02acf6c58b305be0eb20c Author: Eric Stevenson <estevenson@chromium.org> Date: Wed Apr 17 20:19:06 2019 +0000 Android: Disable EffectiveTouchActionPropagatesAcrossNestedFrames. It's flaky: expected_touch_action Which is: 63 whitelisted_touch_action.value() Which is: 15 TBR: boliu@chromium.org Bug: 951513 Change-Id: If560777787a8ffa51660f4a170901692d2a3a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572361 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#651869} content/browser/site_per_process_browsertest.cc | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit e703aa1a8de259cb200b0784e61c1623cb3f4fd4 Author: Jonathan Metzman <metzman@chromium.org> Date: Wed Apr 17 20:14:38 2019 +0000 Don't add seed corpus as a dependency in seed corpus disabled builds This replaces the previous strategy of doing a dry run of the build, which broke the builders which expected the archives to be created. Bug: 952412 Change-Id: I77d4fa95c9dae1e248fed0e20fd460cfdd18f9bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572547 Reviewed-by: Abhishek Arya <inferno@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651868} testing/libfuzzer/archive_corpus.py | 5 ----- testing/libfuzzer/fuzzer_test.gni | 10 +++------- 2 files changed, 3 insertions(+), 12 deletions(-) commit 30152a93f6f404f5b37b35c18f67b2ff145b7268 Author: Jonathan Backer <backer@chromium.org> Date: Wed Apr 17 20:11:53 2019 +0000 Cache texture representation Bug: 935980 Change-Id: I04b0f8b8dd93bc478edc628871620a2c80b13366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572098 Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651867} .../service/external_vk_image_backing.cc | 90 ++++++++++++---------- .../service/external_vk_image_backing.h | 1 + .../service/external_vk_image_gl_representation.cc | 4 +- 3 files changed, 50 insertions(+), 45 deletions(-) commit 89014a4476ec198e6241be7f3cd76488e540e733 Author: Mike Wittman <wittman@chromium.org> Date: Wed Apr 17 20:09:37 2019 +0000 [Sampling profiler] Use separate build ids for V8 code ranges There may be value in distinguishing code executing in the embedded code range from code in the heap code range. The former consists exclusively of builtin functions compiled into Chrome, while the latter contains mostly web-created functions. Bug: 909957 Change-Id: Ia4516dfe26c89d8c7e3bd765dc976e5e5c221806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570810 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651866} chrome/renderer/v8_unwinder.cc | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) commit cee97d55b3ba9c208db9bb5227633e6c944bafad Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Apr 17 20:07:28 2019 +0000 Consider AutofillAssistant height in CompositorViewHolder. This CL introduces the AutofillAssistantSizeManager to expose the height of the Autofill Assistant feature to the CompositorViewHolder such that it is considered when computing the size of the view area. Change-Id: I23529c5d89bf8970b0cbe42f67b180ae361d5e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565007 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#651865} chrome/android/chrome_java_sources.gni | 4 +- .../autofill_assistant_bottom_sheet_toolbar.xml | 2 +- .../java/res/values-v17/dimens.xml | 1 + .../AssistantBottomBarCoordinator.java | 43 +++++++++++++- .../autofill_assistant/AssistantCoordinator.java | 8 ++- .../overlay/AssistantOverlayCoordinator.java | 7 ++- .../overlay/AssistantOverlayDrawable.java | 24 ++++++-- .../chromium/chrome/browser/ChromeActivity.java | 6 +- .../KeyboardExtensionSizeManager.java | 45 --------------- ...Impl.java => KeyboardExtensionViewResizer.java} | 7 ++- .../keyboard_accessory/ManualFillingComponent.java | 7 ++- .../ManualFillingCoordinator.java | 5 +- .../keyboard_accessory/ManualFillingMediator.java | 15 ++--- .../browser/compositor/CompositorViewHolder.java | 66 ++++++++++++---------- .../browser/compositor/CompositorViewResizer.java | 45 +++++++++++++++ .../customtabs/CustomTabBottomBarDelegate.java | 5 +- .../chrome/browser/snackbar/BottomContainer.java | 16 +++--- 17 files changed, 192 insertions(+), 114 deletions(-) commit e3e420efd94375036e3e81979c424cc456b7a312 Author: Akihiro Ota <akihiroota@chromium.org> Date: Wed Apr 17 19:57:40 2019 +0000 Force PosInSet and SetSize to be 0 when tree is unserializing. Calling GetPosInSet and GetSetSize during a tree update has been causing numerous crashes. This change forces GetPosInSet and GetSetSize to return 0 if the tree is updating; the update state is stored in a member on AXTree. Bug: 951263 Change-Id: I5efb8e3b86ff13ca15a49273cbc2b4d04c00d67f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559163 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#651864} .../event/add-hidden-attribute-expected-win.txt | 2 +- .../add-hidden-attribute-subtree-expected-win.txt | 2 +- .../event/remove-child-expected-win.txt | 2 +- ui/accessibility/ax_node.cc | 8 +++++ ui/accessibility/ax_node.h | 1 + ui/accessibility/ax_tree.cc | 18 ++++++++++ ui/accessibility/ax_tree.h | 6 ++++ ui/accessibility/ax_tree_unittest.cc | 39 ++++++++++++++++++++++ 8 files changed, 75 insertions(+), 3 deletions(-) commit 61d91964ca8727be2995a68bdcc5b6280f381306 Author: Jonathan Metzman <metzman@chromium.org> Date: Wed Apr 17 19:51:25 2019 +0000 [AFL] Link builds dynamically Use component build for ClusterFuzz's AFL builds to reduce build sizes. This will cause some fuzz targets to break on ClusterFuzz. However, the fuzzer breakages are probably not worth the large amounts of space the builds take up as a result. Bug: 913631, 701825 Change-Id: I27d0667834f58d34cba7a0b0c44edc7f2a1e82f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566716 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Abhishek Arya <inferno@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651863} tools/mb/mb_config.pyl | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 3150ec36af31387e01d6898f8fce9c50b98dbb1a Author: Mike Wasserman <msw@chromium.org> Date: Wed Apr 17 19:49:59 2019 +0000 Convert Webcursor CHECKs to DCHECKs Bug: 953752 Change-Id: I3d0b13ca1bed4b7d1d2cd7c0677be1bffd698015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572196 Commit-Queue: Michael Wasserman <msw@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#651862} content/common/cursors/webcursor.cc | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) commit 971d9ab59cd1d9f8f373ccdedefb4a3fa8a355db Author: Jonathan Metzman <metzman@chromium.org> Date: Wed Apr 17 19:49:01 2019 +0000 [AFL] Dont defer forkserver in merkle_integrity_source_stream_fuzzer Fuzzer seems to timeout with deferred forkserver, probably because it is creating threads early. Don't defer so timeouts go away. Change-Id: I45542998dda7be4937911cd3bead87fc914eccae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570919 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651861} content/test/fuzzer/BUILD.gn | 1 + 1 file changed, 1 insertion(+) commit 2f39421c6ae7b3d84fe7ee2353f0b91a30be3489 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 19:45:32 2019 +0000 Roll src/third_party/angle 3b2c6bfd4353..0f7a2330c026 (3 commits) https://chromium.googlesource.com/angle/angle.git/+log/3b2c6bfd4353..0f7a2330c026 git log 3b2c6bfd4353..0f7a2330c026 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 jonahr@google.com Modify test result output from dEQP tests for visualization script. 2019-04-17 geofflang@chromium.org Implement GL_CHROMIUM_lose_context. 2019-04-17 syoussefi@chromium.org Vulkan: Clear surface images if emulated format Created with: gclient setdep -r src/third_party/angle@0f7a2330c026 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I90e5df905b75fdc5e76da5a3ea1d4c85470fc6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572189 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651860} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 01111fb832bccd10a7005d2c997997ab93a1af16 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 19:43:34 2019 +0000 Roll src/third_party/skia 5155e09d1466..105d7c24c9b4 (3 commits) https://skia.googlesource.com/skia.git/+log/5155e09d1466..105d7c24c9b4 git log 5155e09d1466..105d7c24c9b4 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 bsalomon@google.com Add flag to map buffer flags in GrCaps to indicate whether mapping a 2019-04-17 borenet@google.com [infra] More work on chrome_release_branch 2019-04-17 mtklein@google.com Add clang-cl arm64 builds Created with: gclient setdep -r src/third_party/skia@105d7c24c9b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I62f45dc493b66b2d707c2509d1175c0c1e2b3b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572188 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651859} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 59aff5d992638d22a50c9c2280d15025e329e841 Author: Kevin Ellis <kevers@chromium.org> Date: Wed Apr 17 19:41:28 2019 +0000 Fix spec compliance of getComputedTiming().progress. Bug: 827616 Change-Id: I874cce34e52d53e8ec52799343f8da8e8a50a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569553 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651858} .../renderer/core/animation/animation_effect.cc | 83 ++----- .../renderer/core/animation/timing_calculations.h | 114 +++++----- .../core/animation/timing_calculations_test.cc | 243 +++++++++++++-------- .../simple-iteration-progress-expected.txt | 52 ----- 4 files changed, 225 insertions(+), 267 deletions(-) commit 35d7207b5ee124134647f257bf6da0c177d561f7 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 19:40:42 2019 +0000 Import wpt@dbc26ae4859e45f4df342445c1a622a6e88b3d8b Using wpt-import in Chromium 3ece7f0bcd6d9e2d91cd3a476c40c5fc941f4989. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" c1940432ee "[WPT/common/security-features] Merge subresource path construction" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: If9e98a2df4fc08b8e3f580c76cf485df5a34533a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572267 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651857} third_party/blink/web_tests/TestExpectations | 5 +- .../web_tests/external/WPT_BASE_MANIFEST_6.json | 390 ++++++++++++++++++++- .../external/wpt/common/get-host-info.sub.js | 5 + .../abort/general.any.serviceworker-expected.txt | 49 +-- .../abort/general.any.sharedworker-expected.txt | 49 +-- .../api/abort/general.any.worker-expected.txt | 49 +-- .../basic/mode-same-origin.any.worker-expected.txt | 4 + .../api/basic/referrer.any.worker-expected.txt | 4 + .../api/cors/cors-basic.any.worker-expected.txt | 4 + .../cors-cookies-redirect.any.worker-expected.txt | 4 + .../api/cors/cors-cookies.any.worker-expected.txt | 4 + .../cors/cors-no-preflight.any.worker-expected.txt | 4 + .../api/cors/cors-origin.any.worker-expected.txt | 4 + .../cors-preflight-cache.any.worker-expected.txt | 4 + ...ght-not-cors-safelisted.any.worker-expected.txt | 4 + ...cors-preflight-redirect.any.worker-expected.txt | 11 +- ...cors-preflight-referrer.any.worker-expected.txt | 4 + .../cors-preflight-star.any.worker-expected.txt | 4 + .../cors-preflight-status.any.worker-expected.txt | 4 + .../cors/cors-preflight.any.worker-expected.txt | 4 + ...rs-redirect-credentials.any.worker-expected.txt | 4 + ...cors-redirect-preflight.any.worker-expected.txt | 4 + .../api/cors/cors-redirect.any.worker-expected.txt | 4 + ...back-to-original-origin.any.worker-expected.txt | 4 + .../redirect/redirect-mode.any.worker-expected.txt | 34 ++ .../redirect-origin.any.worker-expected.txt | 4 + .../redirect-referrer.any.worker-expected.txt | 4 + .../redirect-to-dataurl.any.worker-expected.txt | 4 + .../fetch.any.sharedworker-expected.txt | 4 + .../fetch.any.worker-expected.txt | 4 + .../fetch.https.any.serviceworker-expected.txt | 4 + .../fetch.https.any.sharedworker-expected.txt | 4 + .../fetch.https.any.worker-expected.txt | 4 + .../scheme-restriction.any.worker-expected.txt | 4 + .../syntax.any.worker-expected.txt | 4 + .../fetch/origin/no-cors.any.worker-expected.txt | 4 + .../external/wpt/interfaces/wake-lock.idl | 9 +- .../operators/mo-paint-lspace-rspace.html | 2 +- .../crossorigin-sandwich-TAO.sub.html | 46 +++ .../crossorigin-sandwich-no-TAO.sub.html | 45 +++ .../resource-timing/resources/multi_redirect.py | 20 +- .../serviceworker/cache-match.https-expected.txt | 2 +- .../worker/cache-match.https-expected.txt | 2 +- ...ing-video-with-range-request.https-expected.txt | 4 +- ...tch-request-css-cross-origin.https-expected.txt | 9 + .../fetch-request-html-imports.https-expected.txt | 4 + .../multipart-image.https-expected.txt | 9 + .../opaque-response-preloaded.https-expected.txt | 5 + ...resource-timing-cross-origin.https-expected.txt | 4 + ...-with-body-accessed-response.https-expected.txt | 23 ++ .../service-worker-csp-connect.https-expected.txt | 4 + .../service-worker-csp-default.https-expected.txt | 4 + .../service-worker-csp-script.https-expected.txt | 4 + .../wake-lock/idlharness.https.any-expected.txt | 13 +- .../idlharness.https.any.worker-expected.txt | 11 +- .../service-worker-csp-default.https-expected.txt | 8 - .../service-worker-csp-script.https-expected.txt | 8 - 57 files changed, 724 insertions(+), 216 deletions(-) commit 756c7b7300300219cab122a748106ad16582b084 Author: Ryan Hansberry <hansberry@chromium.org> Date: Wed Apr 17 19:40:23 2019 +0000 [Bluetooth] Pairing system dialog: polish title and height. Display the dialog title in HTML in order to inherit correct styling (in a manner consistent with dialogs like InternetConfigDialog), and set height to 375px, the height of its Settings webui dialog analog. Bug: 856565 Change-Id: I8b353d849804a4c3066f802fae30a60e33efa60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570693 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#651856} .../bluetooth_pairing_dialog/bluetooth_pairing_dialog.html | 3 ++- chrome/browser/ui/webui/chromeos/bluetooth_pairing_dialog.cc | 8 ++++---- 2 files changed, 6 insertions(+), 5 deletions(-) commit 832a7a94510131951f4a09b7ccdf5f4d688ffe1e Author: Saman Sami <samans@chromium.org> Date: Wed Apr 17 19:39:03 2019 +0000 viz: Eliminate closing of surfaces There are a few issues with current implementation of closing surfaces: 1) It rejects any CompositorFrame that comes to the fallback surface. I'm not sure this is a good idea, because even though the frame is not for the primary surface, it still allows us to have something to show for the next display frame. What we really want is activating the frame immediately so that an ack is sent back to the client and it is unblocked for the next frame. 2) Closing the surface currently only affects future CompositorFrames. If a pending frame already exists, it is not activated. 3) It only closes the first surface in the range. We should close all surfaces in the range other than the last surface. This CL replaces closing surfaces with a different mechanism that marks surfaces as fallback and prevents them from ever blocking. Bug: 938947 Change-Id: Ida86143427f9bad1bb323e6edd9b45116e813735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558452 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#651855} .../surface_synchronization_unittest.cc | 80 ++++++++-------------- components/viz/service/surfaces/surface.cc | 45 ++++-------- components/viz/service/surfaces/surface.h | 19 +++-- .../service/surfaces/surface_allocation_group.cc | 10 +++ 4 files changed, 58 insertions(+), 96 deletions(-) commit 236f9235d8cb4d8f8cf752754b5c6d9a77b4075e Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Apr 17 19:37:31 2019 +0000 apk_operations: argv fails on user devices This modifies apk_operations to raise an error when trying to set CLI flags on user build devices. This is an exception if setting flags for WebView (WebView never supports flags on non-user builds), and is a warning for other APKs. For the "launch" command, this only warns if the user explicitly passed a value for "--args". This is to avoid spamming the user in the default case if they didn't intend to modify flags (i.e., we're clearing already cleared flags). This is a follow-up to http://crrev/c/1458369. Bug: 918727, 918221 Test: out/Default/bin/monochrome_apk launch url --args='one two three' Test: out/Default/bin/system_webview_apk argv --args='one two three' Test: Upload to gerrit > open file > click "gitiles" (to check markdown) Change-Id: Ida4f095ce26cc01ab64073addb04c987f4d0614a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568783 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651854} android_webview/docs/commandline-flags.md | 39 +++++++++++++--------- build/android/adb_command_line.py | 27 ++++++++------- build/android/apk_operations.py | 5 +++ .../gyp/create_bundle_wrapper_script.pydeps | 4 +++ 4 files changed, 48 insertions(+), 27 deletions(-) commit 0941203461bf077a8f5a8fc2a2ac3b762fd7227d Author: Roman Sorokin <rsorokin@chromium.org> Date: Wed Apr 17 19:28:01 2019 +0000 Chrome OS: Switch DemoSession browser tests to use DeviceStateMixin Also switched to OobeBaseTest Bug: 952855 Change-Id: I3161b83da25041e4ca48df92a8409075c5039de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572122 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651853} .../login/demo_mode/demo_session_browsertest.cc | 183 ++++++++------------- .../chromeos/login/test/device_state_mixin.cc | 10 +- .../chromeos/login/test/device_state_mixin.h | 4 + 3 files changed, 79 insertions(+), 118 deletions(-) commit d5d51019630bca6639a4a4285204a45ee298a0ad Author: David Tseng <dtseng@chromium.org> Date: Wed Apr 17 19:27:14 2019 +0000 Make views::TabStrip have role ignored for accessibility AXTree::GetSetSize will ignore this view when descending down the views tree to count tabs. Previously, TabStrip had an unknown accessibility role, which causes AXTree::GetSetSize to stop counting and not desecnd into the tab strip's children. Bug: 876404 Change-Id: Ib9e39f2c1ef0c4c3ef398775450015e2b3edc09f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565082 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#651852} ui/views/controls/tabbed_pane/tabbed_pane.cc | 2 ++ 1 file changed, 2 insertions(+) commit 06cbca85bf41541223444e3536831072cc37b725 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Apr 17 19:26:56 2019 +0000 [Mac] [Reland] On the Touch Bar, use individual back/forward buttons instead of semented control. This relands the original change, fixing a use-after-free when BrowserWindowDefaultTouchBar outlives its profile. Original change's description: > This is a design tweak which also enables the back and forward buttons > to be placed separately. Existing customized Touch Bars which contain > the grouped item still work; see the code comment for details. > > I used Cocoa bindings for the buttons' enabled states instead of holding > pointers to them because I initially thought that the Touch Bar might allow the > group and individual buttons to coexist. Turns out no, but I kept the KVO > implementation because I like it. > > It also includes a couple of other changes that came up while writing > this patch and during code review: > > - The unit tests no longer look for a hard-coded list of items in a > specific order. Instead, they verify that BrowserWindowDefaultTouchBar > can create the items it claims to be able to create, and that no > known-valid identifiers have stopped working. > > - BrowserWindowDefaultTouchBar returns nil if it doesn't know about an > identifier, instead of returning an empty Touch Bar item. > > Bug: 937935 > Change-Id: I8cdc6347bc667b0a24fa24fe2c6a56661747ac98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534238 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Auto-Submit: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649899} Bug: 937935, 945772 Change-Id: I77bf9b6d14bef875f271f8fbd4468e6cdc30434e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568846 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651851} .../touchbar/browser_window_default_touch_bar.h | 31 +- .../touchbar/browser_window_default_touch_bar.mm | 320 ++++++++++----------- .../browser_window_default_touch_bar_unittest.mm | 214 ++++++++------ .../touchbar/browser_window_touch_bar_controller.h | 3 - .../browser_window_touch_bar_controller.mm | 80 +----- 5 files changed, 303 insertions(+), 345 deletions(-) commit 8f822dff89bf4a29c74381de6231849c11cb91a2 Author: Jonathan Backer <backer@chromium.org> Date: Wed Apr 17 19:25:42 2019 +0000 Reland "Refactor SkiaOutputSurfaceImplTest.SubmitPaint for on screen" This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1566685 Bug: 952231 Change-Id: Ifc193d8745fbe8ea6702b73adda6cb0f3b5a1943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572227 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651850} components/viz/service/BUILD.gn | 5 ++- .../viz/service/display/renderer_pixeltest.cc | 24 +++++++++---- .../skia_output_device_offscreen.cc | 16 ++++++--- .../skia_output_surface_impl_unittest.cc | 42 ++++++++++++++++------ gpu/vulkan/BUILD.gn | 24 +++++++++---- 5 files changed, 83 insertions(+), 28 deletions(-) commit f1d1719947ffdbd44feb644b27bb06fa448215b3 Author: Mike Wittman <wittman@chromium.org> Date: Wed Apr 17 19:25:05 2019 +0000 [Sampling profiler] Implement V8 unwinder Implements the Unwinder subclass necessary to use the V8 asynchronous unwind functionality with the StackSamplingProfiler. Does yet make use of the unwinder. Bug: 909957 Change-Id: I3974e0a4c2ed7eac36715d3deb84074b2c65af1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566371 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651849} base/profiler/register_context.h | 4 + base/profiler/stack_sampler_impl.cc | 1 + chrome/renderer/BUILD.gn | 2 + chrome/renderer/chrome_content_renderer_client.cc | 1 + chrome/renderer/v8_unwinder.cc | 100 ++++++++++++++++++++++ chrome/renderer/v8_unwinder.h | 35 ++++++++ 6 files changed, 143 insertions(+) commit afe88a5e935e0a47619225253888a2869c25e8aa Author: Mike Wittman <wittman@chromium.org> Date: Wed Apr 17 19:24:34 2019 +0000 [Sampling profiler] Avoid setting an aux unwinder when unsupported Applies the same IsProfilerEnabledForCurrentProcess() check to ThreadProfiler::AddAuxUnwinder() as is used for the other member functions, to avoid trying to set an aux unwinder on a null profiler. Bug: 909957 Change-Id: I1f131132d6bf021e3502d175b068854c98856f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570608 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651848} chrome/common/thread_profiler.cc | 3 +++ 1 file changed, 3 insertions(+) commit 49b8de2ef66a2341484224af17fe92fd6ec0658f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 19:24:00 2019 +0000 Roll src/third_party/shaderc/src 59a49bc5cdff..60caf55788c6 (1 commits) https://chromium.googlesource.com/external/github.com/google/shaderc/+log/59a49bc5cdff..60caf55788c6 git log 59a49bc5cdff..60caf55788c6 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 fjhenigman@users.noreply.github.com Package and upload builds. (#595) Created with: gclient setdep -r src/third_party/shaderc/src@60caf55788c6 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6d625744ffb53b862fd6f04f34cc9661970e04bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572190 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651847} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7d9828cab420d05cc5950c38a20362e53df65290 Author: Nate Fischer <ntfschr@chromium.org> Date: Wed Apr 17 19:23:27 2019 +0000 WebView Tools: write a script to handle taking netlog This adds a script for taking a WebView netlog. This handles appending to the CLI flags, choosing a suitable on-device filepath in the app's data directory, and pulling the file off the device at the end. This updates the markdown documentation to promote the new script. Bug: 902039, 918221 Test: Manual - use the script with both NS on & off Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Iaf57bb4ab5e692e0b8467df6ce1d36cc2874339f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570198 Reviewed-by: Paul Miller <paulmiller@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651846} android_webview/docs/net-debugging.md | 31 ++++++-- android_webview/tools/record_netlog.py | 135 +++++++++++++++++++++++++++++++++ 2 files changed, 160 insertions(+), 6 deletions(-) commit 10e33b2c71273d71d5bdec1e3b474110513328d6 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Apr 17 19:20:55 2019 +0000 UIDevTools Mac: Hide highlight on disable Change-Id: I8160bc9123cc2c4640601cbc91b19638a59cc1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570288 Reviewed-by: Wei Li <weili@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651845} components/ui_devtools/views/overlay_agent_mac.mm | 1 + 1 file changed, 1 insertion(+) commit 7856e7b3521bfc63871cac2864c484ccca460561 Author: Mike Wittman <wittman@chromium.org> Date: Wed Apr 17 19:18:14 2019 +0000 [Sampling profiler] Use auxiliary unwinder when walking stack Implements an stack walking algorithm using the native and auxiliary unwinders, to unwind stacks that contain both native and non-native frames. When an auxiliary unwinder is in place to support v8 unwinding this will enable walking stacks with interleaved native and v8 code. Bug: 909957 Change-Id: I62fb9b650f53b3c0413b2e7dacf8ffa487a0e1a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566350 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651844} base/profiler/native_unwinder_mac.cc | 13 +- base/profiler/native_unwinder_win.cc | 32 ++--- base/profiler/stack_sampler_impl.cc | 51 +++++++- base/profiler/stack_sampler_impl.h | 14 +- base/profiler/stack_sampler_impl_unittest.cc | 187 ++++++++++++++++++++++++++- base/profiler/unwinder.h | 4 + 6 files changed, 269 insertions(+), 32 deletions(-) commit fd75c5f85b6109fd605f693024ec3428dc021892 Author: Jun Mukai <mukai@chromium.org> Date: Wed Apr 17 19:17:44 2019 +0000 Reland "Allow recording the app-list animation smoothness by target state" This is a reland of 6c1fef8086c9ea5884bf5fdd9fdacb0739b73a9d TBR=holte@chromium.org Original change's description: > Allow recording the app-list animation smoothness by target state > > This adds new uma histograms to track the animation smoothness > by the target state. > > Bug: 951853 > Test: manually > Change-Id: Iea1a7a31dc3afc6af7dae377a558b280c8ed2afe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565532 > Commit-Queue: Jun Mukai <mukai@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651475} Bug: 951853 Change-Id: I194e7cf530bb2a9d517df05a98b1cb5f3e31f857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572270 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#651843} ash/app_list/views/app_list_view.cc | 51 +++++++++++++++++----- .../ash/launcher_animations_interactive_uitest.cc | 10 ++++- tools/metrics/histograms/histograms.xml | 14 +++++- 3 files changed, 62 insertions(+), 13 deletions(-) commit e36922ddfdf761b8a1cd5419b1bfe8284ea3fb90 Author: Sebastien Lalancette <seblalancette@chromium.org> Date: Wed Apr 17 19:15:56 2019 +0000 [AF] Added fieldtrial testing config for AutofillOffNoServerData. I also had to remove the autocomplete="off" from a lot of FormStructureBrowserTest test cases. Basically, since we're not really querying the Autofill server during browser tests, then all of the "server" predictions are set as NO_SERVER_DATA. Now, in conjunction with the AutofillOffNoServerData, this means that any input in these tests that has autocomplete="off" would have their predicted type overwritten as UNKNOWN_TYPE. To make sure that the tests still cover client-side heuristics (like they were intending to), I'm removing the autocomplete="off" attributes from failing tests, which means they're now properly testing these heuristics. Bug: 949784 Change-Id: I2c0c3f20e5ccd01936510c2461e9ebd8c477fb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569745 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651842} .../input/017_checkout_advanceautoparts.com.html | 32 +- .../heuristics/input/018_checkout_ae.com.html | 26 +- .../input/023_checkout_gamestop.com.html | 962 ++++++++++----------- .../heuristics/input/026_checkout_ikea.com.html | 268 +++--- .../heuristics/input/027_checkout_jcrew.com.html | 66 +- .../heuristics/input/046_register_bestbuy.com.html | 10 +- .../heuristics/input/055_register_imdb.com.html | 2 +- .../heuristics/input/057_register_live.com.html | 46 +- .../heuristics/input/062_register_newegg.com.html | 36 +- .../input/063_register_officedepot.com.html | 522 +++++------ .../input/070_register_signup.live.com.html | 46 +- .../heuristics/input/077_register_yahoo.com.html | 68 +- .../autofill/heuristics/input/081_crbug_64569.html | 88 +- .../autofill/heuristics/input/083_crbug_87517.html | 6 +- .../autofill/heuristics/input/087_crbug_98286.html | 2 +- .../input/092_checkout_alaskaair.com.html | 502 +++++------ .../input/093_checkout_m_walmart.com.html | 10 +- .../input/101_checkout_m_bestbuy.com.html | 62 +- .../heuristics/input/102_checkout_m_macys.com.html | 20 +- .../heuristics/input/103_checkout_peapod.com.html | 20 +- .../input/106_checkout_m_amazon.com.html | 12 +- .../heuristics/input/107_checkout_m_apple.com.html | 6 +- .../input/110_checkout_harryanddavid.com.html | 210 ++--- .../input/112_checkout_m_llbean.com.html | 8 +- .../input/114_cc_checkout_wayfair.com.html | 8 +- .../input/117_cc_checkout_macys.com.html | 6 +- .../autofill/heuristics/input/123_bug_459132.html | 222 ++--- .../autofill/heuristics/input/127_bug_463986.html | 20 +- .../autofill/heuristics/input/130_bug_465576.html | 4 +- .../autofill/heuristics/input/131_bug_465587.html | 6 +- .../autofill/heuristics/input/132_bug_469012.html | 2 +- .../autofill/heuristics/input/133_bug_469472.html | 4 +- .../autofill/heuristics/input/135_bug_471831.html | 2 +- .../autofill/heuristics/input/136_bug_497850.html | 6 +- .../autofill/heuristics/input/137_bug_555010.html | 28 +- .../input/138_cc_checkout_united.com.html | 30 +- .../input/141_checkout_cc_keurig.com.html | 10 +- .../input/142_cc_checkout_netaporter.com.html | 6 +- .../input/148_payment_dickblick.com.html | 16 +- .../heuristics/input/151_ticketmaster.com.html | 6 +- .../input/156_buyAlbum_bandcamp.com_price.html | 2 +- testing/variations/fieldtrial_testing_config.json | 21 + 42 files changed, 1725 insertions(+), 1704 deletions(-) commit e86496bd2ff9d2543de34985c04da18b807f7d52 Author: Xing Liu <xingliu@chromium.org> Date: Wed Apr 17 19:12:48 2019 +0000 Notification scheduler: Implements ScheduledNotificationManager. This CL introduces ScheduledNotificationManager class which loads data from storage and hold scheduled notifications in memory. Bug: 930968 Change-Id: I3190cc89ab453ef231ff0ca91fbdadd5a29b49e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566213 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#651841} chrome/browser/notifications/scheduler/BUILD.gn | 3 + .../notifications/scheduler/notification_entry.cc | 2 +- .../notifications/scheduler/notification_entry.h | 4 + .../notifications/scheduler/notification_params.cc | 6 +- .../notifications/scheduler/notification_params.h | 5 +- .../scheduler/scheduled_notification_manager.cc | 140 +++++++++++++ .../scheduler/scheduled_notification_manager.h | 74 +++++++ .../scheduled_notification_manager_unittest.cc | 228 +++++++++++++++++++++ 8 files changed, 458 insertions(+), 4 deletions(-) commit 9cb36dc0a364e5c608b72839834f996da2daf77f Author: Maggie Chen <magchen@chromium.org> Date: Wed Apr 17 19:10:59 2019 +0000 Remove |has_surface_damage| from shared_quad_state |has_surface_damage| is no longer used. The underlay optimization had been replaced by occluding_damage_rect. |has_surface_damage| had been removed from both Windows and Chrome OS overlay processors. See CL 1510075. https://chromium-review.googlesource.com/c/chromium/src/+/1510075. Bug:947800 Change-Id: I8ef09411db8855e150453c28d3f5a1e1c4f22074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570630 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#651840} components/viz/common/quads/shared_quad_state.h | 7 -- components/viz/service/display/overlay_unittest.cc | 1 - .../viz/service/display/surface_aggregator.cc | 47 +++++------ .../viz/service/display/surface_aggregator.h | 3 - .../service/display/surface_aggregator_unittest.cc | 93 ---------------------- 5 files changed, 18 insertions(+), 133 deletions(-) commit dac745963c67a458cb2b6614a580335890db8f47 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Apr 17 19:10:05 2019 +0000 Omnibox: Suggestion Transparency - Clock icon for search history matches If the suggestion transparency flag is on, use the clock icon for search history matches. Bug: 929477 Change-Id: I39d33dc5139857cf6397c20762e632eeaf68f45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572250 Reviewed-by: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#651839} components/omnibox/browser/autocomplete_match.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit a786f3198bad67965dc84a7752a1c23139be9c0d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 19:05:13 2019 +0000 Update V8 to version 7.5.287. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fd3e5e3a..0d449a89 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33a38e6bf8cde155b7de2055920c858c742e5f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572232 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651838} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 81ae501d391106c24b9b1e05165dc356c396b85e Author: Darwin Huang <huangdarwin@chromium.org> Date: Wed Apr 17 19:04:23 2019 +0000 Async Clipboard: Create ClipboardItem and use for read/write. - Creates a ClipboardItem. - Uses ClipboardItem for navigator.clipboard.{read,write}() - Updates navigator.clipboard tests and adds ClipboardItem tests. - Final CL for shipping new Async Clipboard API w/image support! :D Bug: 150835 Change-Id: Ic7059fbbb87c60487af8ad0d8a9e5ab92978f8f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553383 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651837} .../blink/renderer/modules/clipboard/BUILD.gn | 2 + .../blink/renderer/modules/clipboard/clipboard.cc | 5 +- .../blink/renderer/modules/clipboard/clipboard.h | 4 +- .../blink/renderer/modules/clipboard/clipboard.idl | 4 +- .../renderer/modules/clipboard/clipboard_item.cc | 61 +++++++++++++++++ .../renderer/modules/clipboard/clipboard_item.h | 41 ++++++++++++ .../renderer/modules/clipboard/clipboard_item.idl | 18 +++++ .../modules/clipboard/clipboard_promise.cc | 69 ++++++++++--------- .../renderer/modules/clipboard/clipboard_promise.h | 12 ++-- .../blink/renderer/modules/modules_idl_files.gni | 1 + .../async-navigator-clipboard-basics.https.html | 36 ++++++---- .../async-write-blobtext-read-blobtext.https.html | 17 +++-- .../async-write-blobtext-read-text.https.html | 9 ++- .../async-write-text-read-blobtext.https.html | 15 +++-- .../async-interfaces.https-expected.txt | 24 +++---- .../async-navigator-clipboard-basics.https.html | 27 ++++---- .../async-write-blobs-read-blobs-manual.https.html | 20 ++++-- ...-write-blobtext-read-blobtext-manual.https.html | 17 +++-- ...sync-write-blobtext-read-text-manual.https.html | 9 ++- .../async-write-image-read-image-manual.https.html | 18 +++-- ...sync-write-text-read-blobtext-manual.https.html | 15 +++-- .../wpt/clipboard-apis/clipboard-item.https.html | 77 ++++++++++++++++++++++ .../clipboard/async-write-blobs-read-blobs.html | 24 ++++--- .../clipboard/async-write-image-read-image.html | 18 +++-- .../global-interface-listing-expected.txt | 5 ++ 25 files changed, 412 insertions(+), 136 deletions(-) commit 685cc4f0564399b15d6b7e6c9c45a214d3e78fcb Author: Christian Fremerey <chfremer@chromium.org> Date: Wed Apr 17 19:04:00 2019 +0000 [Video Capture Service] Add test cases for enumeration of virtual devices for multi-client API Bug: 783442 Change-Id: Ifcceaf981b5841872280149b882f5d3949ca9dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553174 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651836} ...ideo_capture_service_enumeration_browsertest.cc | 108 ++++++++++++++++++--- 1 file changed, 95 insertions(+), 13 deletions(-) commit 1a8383b848896e565b99ac5b25f7697d4229f293 Author: Etienne Bergeron <etienneb@chromium.org> Date: Wed Apr 17 19:03:18 2019 +0000 Remove DisableFontSmoothing which is causing flakiness on unittests The class DisableFontSmoothing is modifying a system wide setting that affect rendering. Unfortunately, that setting is also affecting other unittests. The call to SystemParametersInfo is modifying a system-wide setting: see: https://docs.microsoft.com/en-us/windows/desktop/api/winuser/nf-winuser-systemparametersinfoa It seems to have first appeared in https://codereview.chromium.org/100255 to cater for the test -- RenderViewTest.PrintLayoutTest. Chrome tests should not modify the global state of the system. Unittests should be able to handle different configurations. Every tests are passing correctly. If some tests are failing or disabled because of this class, we should fix it by detecting if fonts smoothing is activated or not. Bug: 953293, 759870 Change-Id: Ib1899f00ba18ae530da2a078933ff8b0a0983f45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569969 Reviewed-by: Wei Li <weili@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651835} printing/image_win.cc | 38 +------------------------------------- 1 file changed, 1 insertion(+), 37 deletions(-) commit 8cb8151310ed1a15b40e541175ebf27e07157f0e Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Wed Apr 17 19:02:57 2019 +0000 [Extensions] Add new manifest key for host permissions Host permissions for Manifest V3 can only be specified in the new manifest key |host_permissions|. Hosts in |permissions| or |optional_permissions| will trigger an install warning. Bug: 62898 Change-Id: I5f12dfadfcdcad522cc231478ff2cb405ebd2648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560730 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#651834} chrome/common/extensions/api/_features.md | 4 +- .../extension_manifests_initvalue_unittest.cc | 2 + .../manifest_tests/permissions_parser_unittest.cc | 38 +++++++++++++++ .../manifest_tests/host_permissions_key.json | 12 +++++ .../host_permissions_key_invalid_hosts.json | 9 ++++ .../init_invalid_host_permissions_invalid.json | 6 +++ extensions/common/api/_manifest_features.json | 5 ++ extensions/common/manifest_constants.cc | 4 ++ extensions/common/manifest_constants.h | 3 ++ .../common/manifest_handlers/permissions_parser.cc | 57 +++++++++++++++++++++- extensions/common/manifest_test.cc | 27 +++++++++- extensions/common/manifest_test.h | 16 +++--- 12 files changed, 171 insertions(+), 12 deletions(-) commit 999110c2e8cfa16568d3b0daa56d3b6fccacde54 Author: Rohit Rao <rohitrao@chromium.org> Date: Wed Apr 17 19:00:59 2019 +0000 [ios] Compiles ChromeActions under EG2. Creates ChromeActionsAppInterface to serve as the eDO interface for actions-related helpers, following the pattern established for EG2 helpers. Uses the C++ wrappers to handle conversions from std::string to pure ObjC objects suitable for transfer over IPC. BUG=922813 Change-Id: Ic9e8f31af179f3a3cedcf29e92320ef0e12db1b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569750 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#651833} ios/chrome/test/earl_grey/BUILD.gn | 9 ++ ios/chrome/test/earl_grey/chrome_actions.mm | 83 +++-------------- .../test/earl_grey/chrome_actions_app_interface.h | 38 ++++++++ .../test/earl_grey/chrome_actions_app_interface.mm | 103 +++++++++++++++++++++ ios/chrome/test/earl_grey2/smoke_egtest.mm | 44 +++++++-- ios/testing/earl_grey/BUILD.gn | 2 + ios/testing/earl_grey/earl_grey_app.h | 8 ++ ios/testing/earl_grey/earl_grey_app.mm | 15 +++ 8 files changed, 228 insertions(+), 74 deletions(-) commit adf8e94df9a1995c2bf61a0efd88d6eda240ffe1 Author: Robert Sesek <rsesek@chromium.org> Date: Wed Apr 17 18:59:42 2019 +0000 Use pthread_mach_thread_np() in ComputeThreadTicks(). Using mach_thread_self() returns a reference that must be deallocated with a separate system call. Using the cached port stored by pthreads means not having to issue two system calls to get the thread ticks. Change-Id: Ic3a1e8cbe74a88f070a1c6843b03778132a53b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572438 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#651832} base/time/time_mac.cc | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) commit 30929267dc5157f96bf41a105a14c05029a562ce Author: Regan Hsu <hsuregan@chromium.org> Date: Wed Apr 17 18:52:54 2019 +0000 [CrOS SplitSettings] Copy browser settings-main and settings-basic to OS. This CL copies the settings-main and settings-basic polymer components used by the currently combined OS and Browser settings page to the future exclusive OS settings page. This CL also renames settings-* to os-settings-* in os settings. Bug: 950007 Change-Id: I7a0412964de498683bf329683411812503024f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566621 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: May Lippert <maybelle@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651831} .../browser/resources/settings/chromeos/BUILD.gn | 6 +- .../resources/settings/chromeos/os_settings.html | 6 +- .../settings/chromeos/os_settings_main/BUILD.gn | 25 ++ .../os_settings_main/os_settings_main.html | 91 +++++ .../chromeos/os_settings_main/os_settings_main.js | 242 +++++++++++++ .../{settings_menu => os_settings_menu}/BUILD.gn | 4 +- .../os_settings_menu.html} | 4 +- .../os_settings_menu.js} | 6 +- .../settings/chromeos/os_settings_page/BUILD.gn | 26 ++ .../os_settings_page/os_settings_page.html | 295 ++++++++++++++++ .../chromeos/os_settings_page/os_settings_page.js | 386 +++++++++++++++++++++ .../{settings_ui => os_settings_ui}/BUILD.gn | 6 +- .../os_settings_ui.html} | 16 +- .../os_settings_ui.js} | 2 +- .../resources/settings/os_settings_resources.grd | 32 +- 15 files changed, 1107 insertions(+), 40 deletions(-) commit 818969632703c243b7ab58a11805cf43edfcd613 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 18:52:25 2019 +0000 Roll src/third_party/perfetto 854d22feaf4b..084712c40e18 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/854d22feaf4b..084712c40e18 git log 854d22feaf4b..084712c40e18 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 ilkos@google.com Merge "Fix start_ts associations" 2019-04-17 cferris@google.com Merge "Modify initialize function for changed parameter." Created with: gclient setdep -r src/third_party/perfetto@084712c40e18 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ia03904098cbadb1350c5024b07bd7620b4c90dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572187 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651830} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e01e7fe64089d3998a762e254bd3ffc1a882a671 Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Apr 17 18:49:08 2019 +0000 Omnibox: After unelision, ignore tiny drags until mouseup Right now, when the user double-clicks a word within an elided URL, we trigger unelision on the second mousedown. During unelision, the text shifts. If the mouse moves at all during the second mouseup, the selection may change unexpectedly. This is ordinarily not a problem, but since the text has shifted underneath the user, even tiny mouse movements can cause large selection changes. This CL fixes that by applying a minimum threshold to any drag movements (8px). Any drag movements smaller than that are ignored. This threshold is active until mouseup. Bug: 951447 Change-Id: I584b827e408e2d03e20d76bb0bd3b038e193e80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570571 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#651829} chrome/browser/ui/views/omnibox/omnibox_view_views.cc | 18 ++++++++++++------ chrome/browser/ui/views/omnibox/omnibox_view_views.h | 13 +++++++++---- .../ui/views/omnibox/omnibox_view_views_unittest.cc | 13 ++++++++++++- 3 files changed, 33 insertions(+), 11 deletions(-) commit aac5a6823905c1d0c8d2c946e2adb73ee2aa7ff9 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 17 18:43:32 2019 +0000 Roll src-internal d7ea5259bb00..db8bc8a9d46c (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d7ea5259bb00..db8bc8a9d46c Created with: gclient setdep -r src-internal@db8bc8a9d46c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I8ec60a6ed8def71661f76398e7ace0590f012d92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572181 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651828} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 076fb9e161568fa524f7c65c3f3c83abf9337f14 Author: Alexei Filippov <alph@chromium.org> Date: Wed Apr 17 18:42:18 2019 +0000 DevTools: Reformat TimelineUIUtils strings. Change-Id: I41534e7523fe04c07051da087c9c5b19b332de15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572269 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#651827} .../devtools/front_end/timeline/TimelineUIUtils.js | 432 +++++++++------------ 1 file changed, 175 insertions(+), 257 deletions(-) commit 654df64a5e8ea5782367325cd6df147696538893 Author: Anastasia Helfinstein <anastasi@google.com> Date: Wed Apr 17 18:41:55 2019 +0000 Reland "[Switch Access] Refactor focus for clarity around back button" This is a reland of 91a61a310cc9b8451719e9bd6dd04919935ea0f1 Original change's description: > [Switch Access] Refactor focus for clarity around back button > > Bug: None > Change-Id: I3318ae4d5f37d67e7fe5abb894f9edacddc785d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549944 > Commit-Queue: Anastasia Helfinstein <anastasi@google.com> > Reviewed-by: Katie Dektar <katie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647532} Bug: None Change-Id: I5fbb04a2c11c7e77afc98891dc60f795bb9f2c0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553812 Reviewed-by: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#651826} .../chromeos/switch_access/back_button_manager.js | 25 +++++- .../chromeos/switch_access/navigation_manager.js | 97 ++++++++++------------ .../switch_access/navigation_manager_test.extjs | 38 +++++---- 3 files changed, 89 insertions(+), 71 deletions(-) commit 773e37c3d3c0a2d8907beea4a70b9c5cd19de9f4 Author: Steve Kobes <skobes@chromium.org> Date: Wed Apr 17 18:41:04 2019 +0000 Add UMA and UKM for main-frame jank scores. The original UMA and UKM include subframes since crrev.com/645061. Reporting the main frame jank separately will assist our analysis. UKM collection review doc: go/lsukmrevmf Bug: 581518 Change-Id: I5f9119492033a31d6896e35cd08ae848378907d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553653 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#651825} .../observers/ukm_page_load_metrics_observer.cc | 33 ++++++++++++++-------- .../ukm_page_load_metrics_observer_unittest.cc | 23 +++++++++++++++ tools/metrics/histograms/histograms.xml | 13 ++++++++- tools/metrics/ukm/ukm.xml | 14 +++++++-- 4 files changed, 69 insertions(+), 14 deletions(-) commit 24a35f79b313299b73b5af5d600ee1d9055069e5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 18:40:33 2019 +0000 Roll src/third_party/depot_tools e72279d25f75..1e2cb1573bd2 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e72279d25f75..1e2cb1573bd2 git log e72279d25f75..1e2cb1573bd2 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 maruel@chromium.org [roll-dep] Ignore chromium-autoroll rolls Created with: gclient setdep -r src/third_party/depot_tools@1e2cb1573bd2 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I4dc48ec04dc56b694a0a2ec9d65f107c2cb82af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572186 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651824} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a882d2725862dc7022917ac6f8d523c623325de2 Author: Becky Zhou <huayinz@chromium.org> Date: Wed Apr 17 18:39:46 2019 +0000 Fix java.lang.IndexOutOfBoundsException in theme preference Fix a crash introduced from http://crrev/c/1556779 Bug: 942771 Change-Id: I86e05da12c15447a9ad5f551b5e39683778e3f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570920 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651823} .../browser/preferences/themes/RadioButtonGroupThemePreference.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 9deaebefc4f2cf80932541b36a756c9c08e88cb4 Author: Caroline Rising <corising@chromium.org> Date: Wed Apr 17 18:37:57 2019 +0000 Fix bug where bubble mirroring state for off screen/window is sticky. Mirroring state would be sticky when the bubble anchor changed but not when the bubble would be recreated. Bug: 910739 Change-Id: Ia9a9609b2959fe8133437da5966fdc7f41c32a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570539 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#651822} ui/views/bubble/bubble_dialog_delegate_view.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 12 +- ui/views/bubble/bubble_frame_view.h | 3 +- ui/views/bubble/bubble_frame_view_unittest.cc | 380 +++++++++++++++---------- 4 files changed, 240 insertions(+), 157 deletions(-) commit 373a44b2d6880875ffaf3d222596ae278056c07a Author: Adrienne Walker <enne@chromium.org> Date: Wed Apr 17 18:36:51 2019 +0000 gpu: Disable OOPR with validating cmd decoder on Windows Bug: 949773 Change-Id: I390333a7b9f5c67c4200fd28cc5d08b2719a7905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570131 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#651821} gpu/config/gpu_util.cc | 7 +++++++ gpu/ipc/service/gpu_init.cc | 10 ++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) commit adbe9610409c04fdc3eb75dd5e978b4b3defba65 Author: Nate Chapin <japhet@chromium.org> Date: Wed Apr 17 18:35:57 2019 +0000 Make frame_test_helpers's BeginNavigation load synchronous in the same cases as real code RenderFrameImpl::CommitSyncNavigation() runs a navigation synchronous only if (1) the navigation will load as empty, and (2) it is the first navigation in the frame. TestWebFrameClient::BeginNavigation now follows the same rules. Bug: 855189 Change-Id: Ic5858ab1d8617a359d44f5e8cbc034de5bc4bf34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548050 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#651820} .../renderer/controller/oom_intervention_impl_test.cc | 15 ++++++++++++++- .../blink/renderer/core/exported/web_frame_test.cc | 2 +- third_party/blink/renderer/core/exported/web_view_test.cc | 2 ++ .../blink/renderer/core/frame/frame_test_helpers.cc | 2 +- third_party/blink/renderer/core/loader/document_loader.cc | 13 ------------- third_party/blink/renderer/core/loader/frame_loader.cc | 15 +++++++++++++++ 6 files changed, 33 insertions(+), 16 deletions(-) commit 3e8e7154c61d46a2a0e316cb8271570242e91d9c Author: Austin Eng <enga@chromium.org> Date: Wed Apr 17 18:33:27 2019 +0000 Remove use_dawn=true from gpu fyi bots Now that Dawn is tested on the chromium.dawn waterfall, it is no longer needed to have use_dawn=true on the gpu fyi bots. Bug: 948902 Change-Id: I6abd029b63e5d845879baaf3eb1cca76ee7eae8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572262 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#651819} tools/mb/mb_config.pyl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5c342e0e027d9409356b5f1cbd437d88d8e20c61 Author: Aleks Totic <atotic@chromium.org> Date: Wed Apr 17 18:31:32 2019 +0000 [Sheriff] failing test update Update expectations for http/tests/devtools/elements/styles-3/styles-add-blank-property.js http/tests/devtools/elements/styles-4/styles-update-from-js.js TBR: atotic@chromium.org Bug: 938884,946716 Change-Id: Id57c4e781770a706fac559e3152c4277ea09d286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572272 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#651818} third_party/blink/web_tests/TestExpectations | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit fdbe5041350ff413daf97e368a2b55036c6dd404 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Apr 17 18:26:05 2019 +0000 Do not use GetProvisionalDocumentLoader in RFI::WillSendRequestInternal Provisional document loader is going away (see step 8.d from the doc linked to the bug), so we explicitly pass DocumentState and ui::PageTransition to WillSendRequestInternal. This required splitting GetTransitionType as well, since it uses WebDocumentLoader internally. Bug: 855189 Change-Id: I03e9f342d258e56c2eff97128fa8461f27f2fb5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522334 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651817} content/renderer/render_frame_impl.cc | 115 +++++++++++++++++++--------------- content/renderer/render_frame_impl.h | 12 ++-- 2 files changed, 70 insertions(+), 57 deletions(-) commit aad705a94b57a10176e69b9de20de51390f71950 Author: Tim Song <tengs@chromium.org> Date: Wed Apr 17 18:25:28 2019 +0000 Ash Tray: Update color of recording icon in user chooser. The proper color should be dark red according to the specs. BUG=953242 Change-Id: I509587210eff6422ab48a29b189785b67c103f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570543 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#651816} ash/system/tray/tray_constants.h | 2 ++ ash/system/unified/user_chooser_view.cc | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) commit a753044d832be2ed2c22295ec2a75fdad2ea3498 Author: Katie D <katie@chromium.org> Date: Wed Apr 17 18:24:01 2019 +0000 Only adds the a11y labels menu item if it isn't the only thing in the menu. This fixes a UX issue where menus that have no other content and otherwise wouldn't be shown are shown when a screen reader is enabled. For example, in the Files app in Chrome OS, there are some areas that have no context menu, and just showing this one is counter intuitive. Bug: 953063 Change-Id: Ib6516d1aa33c207b5dc66e2ecd4032faf8b50363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568653 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#651815} .../accessibility_labels_menu_observer.h | 5 ++++- .../renderer_context_menu/render_view_context_menu.cc | 14 ++++++++++++-- .../renderer_context_menu/render_view_context_menu.h | 4 +++- 3 files changed, 19 insertions(+), 4 deletions(-) commit d3a4183811a810ed0a2a6bb546749461b959099b Author: Will Cassella <cassew@google.com> Date: Wed Apr 17 18:19:37 2019 +0000 Account for inverted selection when determining if the user has backspaced. The omnibox disables autocompletion if the user has backspaced - detected by checking the current text size against the previous text size. An exception to this is trailing selected text, which is not considered when comparing the size. Previously only the selection_end field was used to determine the size of the selection, which is incorrect in the case of an inverted selection (where the selection start is greater than the end). This fixes that. Bug: 951375 Change-Id: Ie245db06570e3b6df8d41a7645d60429973eecf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570751 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#651814} .../src/org/chromium/chrome/browser/vr/VrBrowserNativeUiTest.java | 2 -- chrome/browser/vr/elements/omnibox_text_field.cc | 6 ++++-- 2 files changed, 4 insertions(+), 4 deletions(-) commit 582e0b1a531c683781be24258f69fd171df31d32 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Apr 17 18:19:29 2019 +0000 Remove src-side configs for non-swarming Android testers on chromium.fyi. This turns down the following bots: https://ci.chromium.org/p/chromium/builders/ci/Android%20Find%20Annotated%20Test It's been red and unmaintained for a while. https://ci.chromium.org/p/chromium/builders/ci/Android%20Remoting%20Tests Same thing. https://ci.chromium.org/p/chromium/builders/ci/Android%20VR%20Tests Its tests moved to the main android waterfall. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20Builder%20%28dbg%29 Served to only trigger the prev three testers. Bug: 952610 Change-Id: Iafaeb7d430f9d12d8a5440b60c98cb96174139f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570658 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#651813} infra/config/cr-buildbucket.cfg | 20 --- infra/config/luci-milo.cfg | 16 -- infra/config/luci-scheduler.cfg | 44 ----- testing/buildbot/chromium.fyi.json | 322 ------------------------------------- testing/buildbot/test_suites.pyl | 169 ------------------- testing/buildbot/waterfalls.pyl | 8 - tools/mb/mb_config.pyl | 1 - 7 files changed, 580 deletions(-) commit cb366dde3f4202e51c87306629c7c2bf7e7c9e97 Author: Malay Keshav <malaykeshav@chromium.org> Date: Wed Apr 17 18:17:55 2019 +0000 Remove clipping from the rounded corner shader This patch removes the clipping portion from the rounded corner shader. This is not needed and as the layer with the rounded corner is already masked to bounds and clipped. This clipping also caused bugs due to it not performing any blending for partial pixels. Bug: 952100 Change-Id: Ib006e1cc52144db33ed209edda42b9371963f45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570687 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: enne <enne@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#651812} components/viz/service/display/shader.cc | 7 ------- 1 file changed, 7 deletions(-) commit 23d9c44c286adb79c93922cf11231f0aab8c5002 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 17 18:17:18 2019 +0000 NetworkStateHandler changes to suport mojo A small handful of NetworkStateHandler changes that will be required to support mojo. These have been extracted out to keep the follow-up CL introducing the mojo API to a reasonable size. Bug: 862420 Change-Id: I9a7b2da5bf4a3bfc2aae5797dca6d536fd760e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570759 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#651811} chromeos/network/device_state.h | 1 + chromeos/network/network_state.cc | 4 ++++ chromeos/network/network_state.h | 13 ++++++++++--- chromeos/network/network_state_handler.cc | 4 ++++ chromeos/network/network_state_handler.h | 1 + chromeos/network/network_state_test_helper.cc | 14 ++++++++++++-- chromeos/network/network_state_test_helper.h | 4 ++++ 7 files changed, 36 insertions(+), 5 deletions(-) commit adc71d00ccb8fe09f0237939b564e91fca46e0ee Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 17 18:15:54 2019 +0000 Eliminate chromeos/dbus from ash/BUILD.gn and DEPS This CL: * Adds an AshDBusHelper class to Ash to create and/or track dbus::Bus * Passes the dbus::Bus instance from Chrome to Ash via ShellInitParams in classic / SingleProcessMash mode. * Removes //chromeos/dbus as a dependency in //ash, adds the minimum required dbus related dependencies, and adds or updates comments for dependencies that need to be removed. Bug: 951017 Change-Id: Ic1196da6688c49d612842352808dad99c19cd62e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561834 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651810} ash/BUILD.gn | 24 +++++++----- ash/DEPS | 3 +- ash/ash_service.cc | 35 ++++++++--------- ash/ash_service.h | 3 ++ ash/dbus/DEPS | 1 + ash/dbus/README.md | 15 ++++++-- ash/dbus/ash_dbus_helper.cc | 66 +++++++++++++++++++++++++++++++++ ash/dbus/ash_dbus_helper.h | 60 ++++++++++++++++++++++++++++++ ash/dbus/ash_dbus_services.cc | 9 +---- ash/dbus/ash_dbus_services.h | 11 ++++-- ash/shell.cc | 29 ++++++++------- ash/shell.h | 9 ++++- ash/shell_init_params.h | 6 +++ chrome/browser/ui/ash/ash_shell_init.cc | 3 ++ chrome/test/BUILD.gn | 5 ++- 15 files changed, 218 insertions(+), 61 deletions(-) commit b7e1f19bb266074c9e454e5bf34e9a4d96fd7768 Author: Katie D <katie@chromium.org> Date: Wed Apr 17 18:15:47 2019 +0000 Adds link to help center article for accessibility labels. The article is being written for M75. Bug: 953095 Change-Id: Icc3c6fd5892662993f83ebe21976d5d15c7ba6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568318 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#651809} .../renderer_context_menu/accessibility_labels_bubble_model.cc | 2 +- chrome/common/url_constants.cc | 3 +++ chrome/common/url_constants.h | 4 ++++ 3 files changed, 8 insertions(+), 1 deletion(-) commit 7650630d0ff5fcc02b29e221e96067932bd52a28 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 18:14:21 2019 +0000 Roll src/third_party/webrtc 6f5e84894e74..011d3a125e15 (18 commits) https://webrtc.googlesource.com/src.git/+log/6f5e84894e74..011d3a125e15 git log 6f5e84894e74..011d3a125e15 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 srte@webrtc.org Revert "Cleanup in NetworkEmulationManagerImpl." 2019-04-17 danilchap@webrtc.org Use DefaultTaskQueueFactory instead of Global in test RealTimeController 2019-04-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3904a4338b..14c052d7be (651612:651715) 2019-04-17 dklee@google.com Revert "Ensure that we always set values for min and max audio bitrate." 2019-04-17 artit@google.com Revert "Only process cross traffic simulation if added." 2019-04-17 srte@webrtc.org Removes TimeMicros interface from ThreadProcessingFakeClock. 2019-04-17 dklee@google.com Ensure that we always set values for min and max audio bitrate. 2019-04-17 srte@webrtc.org Make MessageQueue processing an optional feature of FakeClock 2019-04-17 mirtad@webrtc.org Prepare to move SPS VUI rewriting out of H.264 packetizer. 2019-04-17 srte@webrtc.org Cleanup in NetworkEmulationManagerImpl. 2019-04-17 hbos@webrtc.org Implement RTCOutboundRtpStreamStats.retransmitted[Bytes/Packets]Sent. 2019-04-17 nisse@webrtc.org Expose send parameters for RemoteEstimatorProxy for field trial. 2019-04-17 perkj@webrtc.org Add field trial to AimdRateController to only increase while not in ALR 2019-04-17 eladalon@webrtc.org Rename "UpdateLayerConfig" to "NextFrameConfig" 2019-04-17 eladalon@webrtc.org OnLossNotification() receives references 2019-04-17 srte@webrtc.org Only process cross traffic simulation if added. 2019-04-17 nisse@webrtc.org Drop usage of legacy VCMPacketRequestCallback 2019-04-17 nisse@webrtc.org Don't call VideoReceiver::SetNackSettings Created with: gclient setdep -r src/third_party/webrtc@011d3a125e15 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic0db264363b96dc4865964c7125bab2f9fef5010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572185 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651808} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 054cf153ae3d5110cc168bd9ff250c42101672d5 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 17 18:12:03 2019 +0000 flags: remove reset-app-list-install-state This flag doesn't do anything. Bug: 953690 Change-Id: I71c038a2299613523f09b9d04eb0d87e8b1561b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572242 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651807} ash/public/cpp/app_list/app_list_switches.cc | 5 ----- ash/public/cpp/app_list/app_list_switches.h | 1 - chrome/browser/about_flags.cc | 11 ----------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 7 ------- chrome/browser/flag_descriptions.h | 3 --- 6 files changed, 32 deletions(-) commit c7450911427751580a40b8f58e7ba8e19362b2b7 Author: John Rummell <jrummell@chromium.org> Date: Wed Apr 17 18:11:12 2019 +0000 Enable Common Encryption mode 'cbcs' on Android If the device supports it, playback of videos encrypted using pattern encryption with AES 128 bit keys in Cipher Block Chaining mode (CBC) will be allowed. Tested CBCS playback by using the Widevine integration console. Tested CBCS encryption scheme query by running the W3C drm-check-encryption-scheme.https.html test with flag EncryptedMediaEncryptionSchemeQuery enabled. BUG=813845 TEST=see above Change-Id: I3babfc2c4afe114ce2b3d18a5556f5a27f15a93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546500 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#651806} components/cdm/browser/cdm_message_filter_android.cc | 5 +++++ components/cdm/common/cdm_messages_android.h | 2 ++ components/cdm/renderer/android_key_systems.cc | 10 ++++++++-- content/browser/media/encrypted_media_browsertest.cc | 3 --- media/media_options.gni | 3 ++- 5 files changed, 17 insertions(+), 6 deletions(-) commit 20aff309a06d5335323a72d1dbf4a6ac3df91661 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Wed Apr 17 18:09:12 2019 +0000 Update Length debug visualizer Matches the source change in https://crrev.com/c/1437282 R=brucedawson@chromium.org Change-Id: Id641b1445479b48cd1eb4224f93a60932e02800e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572241 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#651805} tools/win/DebugVisualizers/webkit.natvis | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 020c9f129a8bcfd00397ca1021577efa7dd05fc6 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Wed Apr 17 18:08:52 2019 +0000 Use outsideSettings address space for OTMT worker fetch After this CL, all references to address space that can occur during off-the-main-thread worker script fetch use FetchClientSettingsObject::GetAddressSpace(), and thus use outsideSettings' address space correctly. There are still direct calls to SecurityContext::AddressSpace(), but they are used for insideSettings fetch. Bug: 945215, 878274 Change-Id: Ie006e3c06966b24d38847ffc84e30291a7973c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570632 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#651804} .../renderer/core/workers/dedicated_worker_global_scope.cc | 2 +- .../renderer/core/workers/shared_worker_global_scope.cc | 2 +- .../blink/renderer/core/workers/worker_global_scope.cc | 13 +++++++++---- .../modules/service_worker/service_worker_global_scope.cc | 2 +- 4 files changed, 12 insertions(+), 7 deletions(-) commit 1ead79d9ace3ff19592ee07ebf1d0a9ecbdbbeac Author: Charlie Harrison <csharrison@chromium.org> Date: Wed Apr 17 18:07:52 2019 +0000 Extend SubresourceFilter.IndexRuleset.Verify.Status histogram expiry This histogram is still useful for debugging, and for evaluating whether we need to implement re-indexing. TBR=jkarlin@chromium.org Bug: None Change-Id: Ib75a7c2984046d1c049154548bfd82c803a1360d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572239 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#651803} tools/metrics/histograms/histograms.xml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 63893bf5c35397398c8550ce099db9677f2a20aa Author: Mohamed Heikal <mheikal@chromium.org> Date: Wed Apr 17 18:04:27 2019 +0000 Revert "Reland "Do not create PrefetchGCMAppHander in reduced mode"" This reverts commit d84a0fe3c1e3b42dc055ac8724aef2d2a2bac27f. Reason for revert: performance regression crbug.com/950549 Original change's description: > Reland "Do not create PrefetchGCMAppHander in reduced mode" > > > Reason for reland: Original cl always created prefetch service when full > browser starts to make sure to create gcm handler. Unfortunately, this was on > the critical path, thus a performance regression. There is also a crash that > seems to be caused by the original cl where the gcm driver is created twice. > > In this new version of the cl, the PrefetchServiceFactory uses > FullBrowserTransitionManager to register a callback when full browser is > loaded, however, the callback is not registered if prefetch service is never > created, thus solving the performance issue (also, clearer I belive). > > > Original change's description: > > > Do not create PrefetchGCMAppHander in reduced mode > > > > > > If in reduced mode, we cannot create PrefetchGCMAppHandler. Instead we pass the > > > prefetch service a closure to create the gcm app handler on demand. > > > > > > This cl also changes the signature of the getter for PrefetchGCMHandler in > > > PrefetchService to require a profile to be passed in. This ensures that: > > > 1) the getter can only be called in full browser mode (there is no profile in > > > reduced mode). > > > 2) if PrefetchGCMHandler hadn't been created yet, then it can be > > > created on demand using the aforementioned profile. > > > > > > Bug: 934337 > > > Change-Id: I7e813f425e0ba8687f9b519b4300fa7eec014929 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495737 > > > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > > > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > > Reviewed-by: Xi Han <hanxi@chromium.org> > > > Reviewed-by: Jian Li <jianli@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#640470} > > > Bug: 934337, 944952, 943271 > Change-Id: Id4cf79cfc09998d946d2ec0685294aa553f02fa4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538779 > Reviewed-by: Carlos Knippschild <carlosk@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647321} TBR=carlosk@chromium.org,mheikal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934337, 950549 Change-Id: Ib5088fce99ec425d26e3cd756145db6f5b289567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564534 Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#651802} .../prefetch/prefetch_service_factory.cc | 25 ++++---------- .../core/prefetch/prefetch_dispatcher_impl.cc | 3 +- .../offline_pages/core/prefetch/prefetch_service.h | 2 -- .../core/prefetch/prefetch_service_impl.cc | 38 +++------------------- .../core/prefetch/prefetch_service_impl.h | 5 ++- .../core/prefetch/prefetch_service_test_taco.cc | 11 +++---- .../core/prefetch/stub_prefetch_service.cc | 1 - .../prefetch/tasks/generate_page_bundle_task.cc | 21 +++++++++++- .../prefetch/tasks/generate_page_bundle_task.h | 7 ++++ .../tasks/generate_page_bundle_task_unittest.cc | 13 +++++--- 10 files changed, 55 insertions(+), 71 deletions(-) commit 2122650ca9ef3159398540de107285c8a4b339be Author: Jacob Dufault <jdufault@google.com> Date: Wed Apr 17 18:01:44 2019 +0000 cros: Update shelf localized content on locale change Bug: 943491 Change-Id: I24fb4c0bb8ed7aacdde17509e89b145035f38f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568188 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#651801} ash/shelf/login_shelf_view.cc | 32 +++++++++++++++++++++++++++----- ash/shelf/login_shelf_view.h | 10 +++++++++- 2 files changed, 36 insertions(+), 6 deletions(-) commit 89aadba3d34c31fefcb8877173536b3f3e19d555 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 17:58:16 2019 +0000 Roll src/third_party/SPIRV-Tools/src 3aad3e9228b3..21712068feee (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/3aad3e9228b3..21712068feee git log 3aad3e9228b3..21712068feee --date=short --no-merges --format='%ad %ae %s' 2019-04-17 zoddicus@users.noreply.github.com Validate that SPIR-V binary is encoded as little endian for WebGPU (#2523) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@21712068feee The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iac7fe715afd97ac24fb90935faf24231bdbad37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572184 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651800} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c9ed0810a9b629f83af507b9593d4ce1efffda68 Author: Sinan Sahin <sinansahin@google.com> Date: Wed Apr 17 17:57:41 2019 +0000 Update the photo picker colors for dark mode Also, replace disabled_text_color with default_text_color_tertiary Bug: 951231 Change-Id: I95b148c6372bb4f20d0c32d7317058130be0eb53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570185 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#651799} .../java/res/color/item_chooser_row_text_color.xml | 3 ++- chrome/android/java/res/drawable/checkmark_blue.xml | 2 +- .../java/res/layout/clear_browsing_data_tabs.xml | 2 +- .../java/res/layout/photo_picker_bitmap_view.xml | 2 +- .../android/java/res/layout/photo_picker_dialog.xml | 2 +- chrome/android/java/res/values-v17/styles.xml | 2 +- chrome/android/java/res/values/colors.xml | 7 +------ .../android/java/res_night/values-night/colors.xml | 4 ++++ .../browser/photo_picker/PhotoPickerToolbar.java | 4 +++- .../browser/photo_picker/PickerBitmapView.java | 20 ++++++++------------ .../browser/widget/findinpage/FindToolbar.java | 2 +- .../res/color/default_icon_color_secondary_list.xml | 11 +++++++++++ ui/android/java/res/values-v17/styles.xml | 6 +++--- ui/android/java/res/values/color_palette.xml | 4 +++- ui/android/java/res/values/colors.xml | 3 ++- ui/android/java/res_night/values-night/colors.xml | 2 +- 16 files changed, 44 insertions(+), 32 deletions(-) commit 613c977608e12b9219d50df788758b9564c5a743 Author: Tina Wang <tinazwang@chromium.org> Date: Wed Apr 17 17:57:12 2019 +0000 [SendTabToSelf] Add icon to Windows notification Previously the notification on Windows doesn't have an image on the left. Add Chrome logo to be the image. Previous: https://screenshot.googleplex.com/czHKUPwf9Bu Now(image will change base on channel): https://screenshot.googleplex.com/p3oeicKOEf5 Bug: 952428 Change-Id: Ibc972b977806d8f8c2e4b44fa852f12dd40a0827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565448 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#651798} .../desktop_notification_handler.cc | 11 +++--- .../send_tab_to_self_desktop_util.cc | 41 ++++++++++++++++++++++ .../send_tab_to_self_desktop_util.h | 4 +++ 3 files changed, 51 insertions(+), 5 deletions(-) commit fc5a7c582a8cbd681951aed97fb3e4c30e52226b Author: Dominik Röttsches <drott@chromium.org> Date: Wed Apr 17 17:53:26 2019 +0000 Use DWrite backend for variable fonts when possible In order to avoid rendering inconsistencies between static and variable fonts on Windows, run variable fonts through Skia's DWrite backend when the system's DWrite version supports it. As the test, use a default typeface to probe and ask for the variation axis parameters of the current instance. If Skia return -1, it means, it was unable to access the API for retrieving variations axes information. If that's the case, we need to use FreeType, otherwise use DWrite. While we do not have bot coverage for Windows 10 RS3 ourselves, Skia does test DWrite variable font support, so I believe it's okay to land that, our own bot coverage is tracked in issue 953520. Bug: 953447 Change-Id: I9684f92004531d6bafef33aefafa3894e4c46203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569947 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#651797} third_party/blink/renderer/platform/BUILD.gn | 2 ++ .../platform/fonts/web_font_typeface_factory.cc | 3 ++ .../fonts/win/dwrite_font_format_support.cc | 36 ++++++++++++++++++++++ .../fonts/win/dwrite_font_format_support.h | 15 +++++++++ 4 files changed, 56 insertions(+) commit b3fed15813c37888b42fc7db03dce3583781a1f9 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Apr 17 17:51:17 2019 +0000 site_settings: Remove assertions about ask options that no longer apply Starting with commit a69ab67be ("Implement desktop UI for the WebUSB guard permission"), it is possible to have an "Ask" option in chrome://settings/content/siteDetails that can be chosen by users. However, doing so (rather than selecting the "Ask (default)" option) triggered two assertions that no longer seem to make sense: * "Ask" as an option is no longer just for display; * It can also be selected as a user preference rather coming only from extensions or a policy. The assertion were being hit whenever the option was chosen as well as when the site details page was reloaded, in which case the items loaded after the WebUSB option were all blank. Bug: 771703, 947112 Change-Id: Ic2c0bfe0d4cc1bccfe87c2fa756c7284e4883853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569926 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#651796} .../settings/site_settings/site_details_permission.js | 10 ++++------ .../webui/settings/site_details_permission_tests.js | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 6 deletions(-) commit 3e0b3d0237ac42bf67e3c76a6e53d1b5882359ca Author: Ken Rockot <rockot@google.com> Date: Wed Apr 17 17:51:03 2019 +0000 Revert "[mojo-core] Add the concept of port slots" This reverts commit d3b3ab90a1f2f625a64c55e1c55c5b342b84b09f. Reason for revert: Abandoning the effort to remove associated interfaces, so reverting changes which landed in support of it. https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit# Original change's description: > [mojo-core] Add the concept of port slots > > Ports are the two-way relocatable messaging endpoints used as a backing > for Mojo message pipe handles. Each port is essentially a message- > receiving queue, and the mutual independence of each port's queue is > fundamental to a port's ability to be relocated efficiently and thus be > suitable to support message pipes. > > This CL introduces the concept of "slots" on an individual port, > effectively allowing for messages in the port's queue to be routed to > different consumers referencing the port. Messages are now sent on a > specific slot by the sender, and received on a corresponding peer slot > on the peer port. If multiple messages are received for different slots > on a port, they still must be read (and are still only exposed) in > sequential order. > > This is a precursor to supporting shared message ordering across > multiple independent message pipes in Mojo, a feature which will > ultimately replace the bindings concept of "associated interfaces". > > See bug for design doc link. > > Bug: 941809 > Change-Id: I84e6f35831d918178e9eb2cc32c8701d1808e4e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538778 > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#648299} TBR=rockot@google.com,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941809 Change-Id: Ia25c1fc965d508a37eeee8900604a601547c0a08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572225 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#651795} mojo/core/node_controller.cc | 8 +- mojo/core/node_controller.h | 2 +- mojo/core/ports/BUILD.gn | 2 - mojo/core/ports/event.cc | 53 +--- mojo/core/ports/event.h | 56 ----- mojo/core/ports/message_queue.cc | 121 +++------ mojo/core/ports/message_queue.h | 62 +---- mojo/core/ports/node.cc | 513 +++++++++++--------------------------- mojo/core/ports/node.h | 89 +------ mojo/core/ports/node_delegate.h | 8 +- mojo/core/ports/port.cc | 21 -- mojo/core/ports/port.h | 33 +-- mojo/core/ports/ports_unittest.cc | 417 +------------------------------ mojo/core/ports/slot_ref.cc | 28 --- mojo/core/ports/slot_ref.h | 43 ---- 15 files changed, 213 insertions(+), 1243 deletions(-) commit 863f348fc9c7eb0161ad7a68b627fc37423caf35 Author: Ken Rockot <rockot@google.com> Date: Wed Apr 17 17:47:50 2019 +0000 Revert "[mojo-core] Introduce PortAttachment" This reverts commit d6d91a56b93b7b8e4cbb6769d3faad6123861131. Reason for revert: Abandoning the effort to remove associated interfaces, so reverting changes which landed in support of it. https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit# Original change's description: > [mojo-core] Introduce PortAttachment > > This is a simple refactoring CL which replaces the list of PortName > values in a UserMessageEvent with a list of PortAttachment structures. > This new structure type is a PortName and an optional SlotId, allowing > for internal Mojo serialization to signal that a serialized message pipe > handle should be encoded as a spliced-in slot on the transmission pipe > rather than as an actual port transfer. > > No functional changes are made here, this is just groundwork to reduce > churn in a follow-up CL. > > See bug for design doc link. > > Bug: 941809 > Change-Id: Id1c33a1fd81cf3879c350a3a241ef0791ef60ad3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542304 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648417} TBR=rockot@google.com,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941809 Change-Id: Id9b4999e60c18713121d262b22b1fc32dd0b2f3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572299 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#651794} mojo/core/data_pipe_consumer_dispatcher.cc | 21 +++++++--------- mojo/core/data_pipe_consumer_dispatcher.h | 4 +-- mojo/core/data_pipe_producer_dispatcher.cc | 21 +++++++--------- mojo/core/data_pipe_producer_dispatcher.h | 4 +-- mojo/core/dispatcher.cc | 4 +-- mojo/core/dispatcher.h | 19 +++++++------- mojo/core/message_pipe_dispatcher.cc | 15 +++++------ mojo/core/message_pipe_dispatcher.h | 15 ++++++----- mojo/core/platform_handle_dispatcher.cc | 9 +++---- mojo/core/platform_handle_dispatcher.h | 4 +-- mojo/core/ports/event.cc | 13 ++-------- mojo/core/ports/event.h | 13 ++-------- mojo/core/ports/node.cc | 22 ++++++++-------- mojo/core/ports/ports_unittest.cc | 40 +++++++++++++++--------------- mojo/core/shared_buffer_dispatcher.cc | 9 +++---- mojo/core/shared_buffer_dispatcher.h | 4 +-- 16 files changed, 93 insertions(+), 124 deletions(-) commit 6032978cc0febe88b0bead3e5fbf7afd7c083d7a Author: Matt Wolenetz <wolenetz@chromium.org> Date: Wed Apr 17 17:45:45 2019 +0000 MSE: Remove field trial configuration for MseBufferByPts MseBufferByPts is enabled by default in trunk (in M75). This change removes the field trial configuration. BUG=760264,807793,771349 Change-Id: Iee62ba1e9d62b2a5196985e124dbd9c78ac40add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570772 Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651793} testing/variations/fieldtrial_testing_config.json | 19 ------------------- 1 file changed, 19 deletions(-) commit 1654dce4998d4f8403795c230f8662c9a26b1ee9 Author: Nate Chapin <japhet@chromium.org> Date: Wed Apr 17 17:40:46 2019 +0000 Reland "Make navigating a new window look more like the spec" Wrap frame lookup and creating a new window into a single API that relatively closely tracks the spec at https://html.spec.whatwg.org/#the-rules-for-choosing-a-browsing-context-given-a-browsing-context-name In addition to better matching the flow/ordering of the spec, this change fixes a bug where we would sometimes convert a navigation targeted at _top or _parent into a new window if the source frame couldn't navigate the target frame. Bug: 944213, 914587 Change-Id: I5bbede0b557bdb9b0dc19155959d9c2bfd8e4941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569967 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#651792} .../blink/renderer/core/frame/ad_tracker_test.cc | 2 +- .../blink/renderer/core/frame/local_dom_window.cc | 62 +++++++--------------- .../blink/renderer/core/frame/local_frame.cc | 9 ---- .../blink/renderer/core/frame/local_frame.h | 3 -- .../renderer/core/frame/web_local_frame_impl.cc | 3 +- .../blink/renderer/core/loader/frame_loader.cc | 17 ++---- .../blink/renderer/core/page/create_window.cc | 8 +-- .../blink/renderer/core/page/create_window.h | 4 +- third_party/blink/renderer/core/page/frame_tree.cc | 52 ++++++++++++++++-- third_party/blink/renderer/core/page/frame_tree.h | 16 +++++- .../new-window-sandboxed-iframe-expected.txt | 17 ------ .../navigation/new-window-sandboxed-iframe.html | 9 ---- ...window-sandboxed-iframe-destination-iframe.html | 6 --- .../new-window-sandboxed-iframe-destination.html | 1 - .../new-window-sandboxed-iframe-iframe.html | 7 --- .../sandboxed-iframe-form-top-expected.txt | 1 - 16 files changed, 95 insertions(+), 122 deletions(-) commit 4a3ec138538ba381b6f75b98b4fa89b976223037 Author: Mike Dougherty <michaeldo@chromium.org> Date: Wed Apr 17 17:40:21 2019 +0000 [iOS] Add note about enabling crash reporting in local debug builds TBR=olivierrobin@chromium.org Bug: None Change-Id: Ic8a9344bb5ccd6c22c9ee6d4f6d784beb44f9dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570915 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#651791} components/crash/README | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) commit 89f982be22935315448ab82493997565993fbd11 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 17:39:22 2019 +0000 Roll src/third_party/skia e88d4382e1cf..5155e09d1466 (5 commits) https://skia.googlesource.com/skia.git/+log/e88d4382e1cf..5155e09d1466 git log e88d4382e1cf..5155e09d1466 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 egdaniel@google.com Revert "added more SPIR-V RelaxedPrecision decorations" 2019-04-17 jvanverth@google.com Make Metal render loop more stable 2019-04-17 mtklein@google.com roll clang_win 2019-04-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-04-17 robertphillips@google.com Reland "Revert "Simplify SkTypeface::charsToGlyphs API to require UTF32 input"" Created with: gclient setdep -r src/third_party/skia@5155e09d1466 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ia2d97f43820e4c46a26f9de4b65529b3db50062a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572182 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651790} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e35c5b49704ed27556e5014c008b3d70698d30e9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 17:39:07 2019 +0000 Roll src/third_party/perfetto 7342ae0bd748..854d22feaf4b (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7342ae0bd748..854d22feaf4b git log 7342ae0bd748..854d22feaf4b --date=short --no-merges --format='%ad %ae %s' 2019-04-17 fmayer@google.com Roll trace_to_text for heap_profile. Created with: gclient setdep -r src/third_party/perfetto@854d22feaf4b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:130665360 TBR=perfetto-bugs@google.com Change-Id: Id2ef8f27fd08efbeb3f5f24fbd8e4d244bdd5864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572079 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651789} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a5acfb37999e2f43b475381406a0c85fa2620c4 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Wed Apr 17 17:34:27 2019 +0000 Lookalikes: Add feature parameter to display the interstitial for top domains This CL adds a boolean topsites parameter to the LookalikeUrlNavigationSuggestionsUI feature. When enabled, the interstitial will be displayed for both site engagement and top domain heuristics. When disabled, it will only be shown for the site engagement heuristic. Bug: 951555 Change-Id: Idd8f5f47b3b4185ff5256d6982096ba135756988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570078 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#651788} .../lookalike_url_navigation_throttle.cc | 14 +- ...ookalike_url_navigation_throttle_browsertest.cc | 214 +++++++++++++-------- 2 files changed, 147 insertions(+), 81 deletions(-) commit ea7093a855e45a0bcdff6f4ba1f492a4c4cc4a4d Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Apr 17 17:33:31 2019 +0000 Avoid crash-inducing layout checks when determining table roles For some reason this fixes the crash, although the other layout checks in NativeRoleIgnoringAria() seem to be ok. Bug: 945286 Change-Id: I2b2f9450a5a2e98f4a8c34169d86ef54aff74a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570820 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#651787} .../blink/renderer/modules/accessibility/ax_layout_object.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 683a70218f4b3a33ddb2eb8560488a4343a293db Author: Drew Stonebraker <stonebraker@chromium.org> Date: Wed Apr 17 17:31:58 2019 +0000 Modify format of version codes file to fit Omaha expectations Change the characters that get written to the chrome_versions.txt output file so that it can be read by the parser Omaha uses. Bug: 953059 Change-Id: I219dd2360cacf6d9bed2316478d86e733c4dcb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570699 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Drew Stonebraker <stonebraker@chromium.org> Cr-Commit-Position: refs/heads/master@{#651786} build/util/version.gni | 20 -------------------- 1 file changed, 20 deletions(-) commit 89dcdae52fbc2a5370d6f02148f467944835500b Author: Becky Zhou <huayinz@chromium.org> Date: Wed Apr 17 17:28:43 2019 +0000 [Dark] InfoBar dark support + Hold InfoBarContainer in activity context - Not instantiating InfoBarContainer until tab is attached - Close all infobars before destroy - Clear Java side InfoBar object when closing InfoBar - Add icon drawable tint + Fix a number of leaks - Tablet and top toolbar HomeButton holding on to HomepageManager Observer - ReaderModeManager delegate holding activity implicitly on native - BottomSheetController holding VrModeObserver - InputMethodManagerWrapperImpl holding activity Bug: 934577, 934909, 934908 Change-Id: I73ddff2549a921bfff37897bb7aff5622471c6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540080 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#651785} chrome/android/chrome_java_sources.gni | 1 + .../AutofillAssistantUiTest.java | 4 +- .../org/chromium/chrome/browser/vr/VrShell.java | 5 +- .../res/layout/infobar_control_description.xml | 2 +- .../java/res/layout/infobar_control_message.xml | 5 +- chrome/android/java/res/values/colors.xml | 2 +- .../chromium/chrome/browser/ChromeActivity.java | 5 +- .../browser/banners/SwipableOverlayView.java | 2 +- .../browser/customtabs/CustomTabActivity.java | 5 +- .../browser/dom_distiller/ReaderModeManager.java | 11 + .../chrome/browser/infobar/AdsBlockedInfoBar.java | 2 +- .../browser/infobar/AppBannerInfoBarAndroid.java | 4 +- .../infobar/AutofillCreditCardFillingInfoBar.java | 5 +- .../browser/infobar/AutofillSaveCardInfoBar.java | 3 +- .../chrome/browser/infobar/ConfirmInfoBar.java | 11 +- .../browser/infobar/DataReductionPromoInfoBar.java | 23 +- .../browser/infobar/DownloadProgressInfoBar.java | 2 +- .../browser/infobar/DuplicateDownloadInfoBar.java | 2 +- .../browser/infobar/FramebustBlockInfoBar.java | 2 +- .../infobar/GeneratedPasswordSavedInfoBar.java | 4 +- .../chromium/chrome/browser/infobar/InfoBar.java | 32 +- .../browser/infobar/InfoBarCompactLayout.java | 23 +- .../chrome/browser/infobar/InfoBarContainer.java | 449 ++++++++++----------- .../browser/infobar/InfoBarContainerLayout.java | 31 +- .../browser/infobar/InfoBarContainerView.java | 260 ++++++++++++ .../chrome/browser/infobar/InfoBarLayout.java | 44 +- .../infobar/InstallableAmbientBadgeInfoBar.java | 2 +- .../chrome/browser/infobar/InstantAppsInfoBar.java | 2 +- .../chrome/browser/infobar/NearOomInfoBar.java | 2 +- .../browser/infobar/NearOomReductionInfoBar.java | 2 +- .../chrome/browser/infobar/PermissionInfoBar.java | 5 +- .../chrome/browser/infobar/PreviewsInfoBar.java | 3 +- .../browser/infobar/PreviewsLitePageInfoBar.java | 4 +- .../chrome/browser/infobar/ReaderModeInfoBar.java | 2 +- .../browser/infobar/SavePasswordInfoBar.java | 4 +- .../SearchGeolocationDisclosureInfoBar.java | 3 +- .../chrome/browser/infobar/SurveyInfoBar.java | 2 +- .../browser/infobar/TranslateCompactInfoBar.java | 4 +- .../browser/infobar/UpdatePasswordInfoBar.java | 5 +- .../send_tab_to_self/SendTabToSelfInfoBar.java | 2 +- .../chrome/browser/tab/TabWebContentsObserver.java | 2 + .../tabmodel/TabModelSelectorTabObserver.java | 7 +- .../chrome/browser/toolbar/top/ToolbarPhone.java | 9 +- .../chrome/browser/toolbar/top/ToolbarTablet.java | 9 +- .../widget/bottomsheet/BottomSheetController.java | 22 +- .../ManualFillingIntegrationTest.java | 4 +- .../browser/infobar/InfoBarContainerTest.java | 18 +- .../chrome/browser/infobar/InfoBarTest.java | 2 +- .../chromium/chrome/browser/widget/ScrimTest.java | 3 +- .../bottomsheet/BottomSheetControllerTest.java | 3 +- .../browser/ui/android/infobars/infobar_android.cc | 1 + .../android/infobars/infobar_container_android.cc | 7 +- .../WebContentsAccessibilityImpl.java | 2 +- .../content/browser/input/ImeAdapterImpl.java | 4 +- 54 files changed, 690 insertions(+), 384 deletions(-) commit 6cc6ea23753202c5b9f14723f10ceb1738b02f55 Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Apr 17 17:28:34 2019 +0000 Media Router WebUI: replace paper-icon-button with cr-icon-button Bug: 736891 Change-Id: I9d53d847850288638a1fff51e348cfbcd3b64705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570540 Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#651784} .../media_router_container/media_router_container.html | 7 ++++--- .../elements/media_router_header/media_router_header.css | 8 ++++---- .../elements/media_router_header/media_router_header.html | 14 +++++++------- .../elements/route_controls/route_controls.html | 13 +++++++------ .../browser/resources/media_router/media_router_common.css | 5 +++++ 5 files changed, 27 insertions(+), 20 deletions(-) commit f2ec6ecf9ce9a11ec2a8ac2c6e17605aba64adbb Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 17 17:26:28 2019 +0000 [Sync] Enable TwoClientDictionarySyncTest.Limit on win dbg + asan Many fixes have landed since this test was disabled. It's therefore worth giving it a try and enable it again. Bug: 889505 Change-Id: Iedf8ae64a002ea508f8304c67248c68d5e88cd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572339 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#651783} .../sync/test/integration/two_client_dictionary_sync_test.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit fc81377902e8d045550b448aaa8bb9b3de630d0e Author: Marijn Kruisselbrink <mek@chromium.org> Date: Wed Apr 17 17:26:17 2019 +0000 Fix typo in text_encoder_stream.h Change-Id: I39b60fb4607ee1e6b1987abf89c4f9e39a90d181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564586 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#651782} third_party/blink/renderer/modules/encoding/text_encoder_stream.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b5fbad6f71ab7213f0b3dc8294e1bb6466dd484 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 17:22:02 2019 +0000 Update V8 to version 7.5.286. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58da6c5b..fd3e5e3a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I96320a2bf1f746f57475af0cee622c31ef527fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572223 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651781} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 305d31565c9d45ca20811861f163a6cf8bf5775e Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Apr 17 17:19:47 2019 +0000 [unified-consent] Enable UnifiedConsent by default on Desktop Bug: 811351 Change-Id: I60104b8ec57aa86a8472bab631ca61c5d011d7ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565989 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#651780} .../signin/sync_confirmation_handler_unittest.cc | 51 +++++++++++++++++----- components/unified_consent/feature.cc | 13 +++++- components/unified_consent/feature_unittest.cc | 7 +++ 3 files changed, 58 insertions(+), 13 deletions(-) commit f24d0db6e839437df7df8fb2f42b89edf0d2a983 Author: Min Chen <minch@google.com> Date: Wed Apr 17 17:16:30 2019 +0000 Read side volume button location info from file into Accelerator. Bug: 937907 Change-Id: I4341c58bc0f0dc22938d4e58711827b033ec1965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565627 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#651779} ash/accelerators/accelerator_controller.cc | 52 ++++++++++++++++++---- ash/accelerators/accelerator_controller.h | 52 +++++++++++++++++++++- .../accelerator_controller_unittest.cc | 50 +++++++++++++++++++++ 3 files changed, 144 insertions(+), 10 deletions(-) commit cc7e1e278587ff4ebe3921852eea938c8c62f567 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Wed Apr 17 17:12:54 2019 +0000 [Sheriff]: Marking synthetic-pinch-zoom-gesture-touchscreen-desktop.html as flaky Looks like it's now flaky on several Linux and Win10 bots as well. TBR=masonfreed@chromium.org Bug: 953725 Change-Id: I28513be624f25dd9a04c2f4864a545d2d6f5d946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570913 Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#651778} third_party/blink/web_tests/TestExpectations | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit cceed1b6d274a9c9ac8c877c5a0ec0d9c02abcc5 Author: Timothy Loh <timloh@chromium.org> Date: Wed Apr 17 17:11:53 2019 +0000 Fix missing angle bracket in basic_page.html Bug: 950431 Change-Id: Ic7ddbefa4be3644bd088a2d19e1bdb698e60326a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571121 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#651777} chrome/browser/resources/settings/basic_page/basic_page.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 675bd26b273825bd1ddeaf48f22aa2a1901f4efa Author: Tony de Luna <tonydeluna@chromium.org> Date: Wed Apr 17 17:10:43 2019 +0000 Enable sync consent tests on regular chormium build This cl moves sync consent tests to the normal chromium build target. Made fixes to the sync consent tests: * Added FakeGaia mixin to allow the call to ShowSigninScreenForTest to complete. * Updated the OOBE JS API call for updating language locale. * SyncConsentPolicyDisableTest now waits for user session to start because OOBE flow can finish before the Waiter started, causing the Waiter to wait forever. Moved the is_official_build_ flag in WizardController to static scope because a new WizardController instance is created as part of the login flow. This meant that setting is_official_build_ to true during the test would be overriden when the new WizardController instace is created. Added a helper function ForceOfficialBulidForTesting to WizardController that temporarily overrides is_official_build_ during the execution of a test. Removes some WizardController friend classes that only needed access to the private is_official_build_ flag. TBR=antrim@chromium.org Bug: 952388 Change-Id: I5bd87ef4a21b4a265bdde94656fc2380c770473a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570215 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#651776} .../login/configuration_based_oobe_browsertest.cc | 6 ++--- .../login/demo_mode/demo_setup_browsertest.cc | 3 ++- .../enrollment/hands_off_enrollment_browsertest.cc | 3 ++- .../login/sync_consent_interactive_ui_test.cc | 29 +++++++++++++-------- chrome/browser/chromeos/login/wizard_controller.cc | 22 ++++++++++++---- chrome/browser/chromeos/login/wizard_controller.h | 13 +++------- .../login/wizard_controller_browsertest.cc | 30 ++++++++++++---------- chrome/test/BUILD.gn | 4 +-- 8 files changed, 63 insertions(+), 47 deletions(-) commit efad3ec3d35c6718e095ac2ccf569d1e3881eb58 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Wed Apr 17 17:07:05 2019 +0000 Reland "Reland "[TaskScheduler]: Simplify sequence preemption logic."" This is a reland of 328f55781b6911025c18a6a1bf2ca640906eba9e Issue was: When run_policy is changed during execution of GetWork() under lock, it is possible that the DCHECK GetNumAwakeWorkersLockRequired() > GetDesiredNumAwakeWorkersLockRequired() triggers. Fix: The DCHECK was a sanity check based on an assumption no longer true, so remove DCHECK. TestCanRunPolicyLoad was improve to always trigger the DCHECK when present. GetDesiredNumAwakeWorkersLockRequired() was also modified to always return at least the number of workers currently running a task. Fix: GetDesiredNumAwakeWorkersLockRequired returns at least num_running_tasks_. Original change's description: > Reland "[TaskScheduler]: Simplify sequence preemption logic." > > This is a reland of 5d4c05db6d02f9422b3a7b6fb2b6b637691ccc2e > > Problem: PlatformNativeWorkerPool::RunNextSequenceImpl expects sequence > returned from GetWork() to be non-null and DCHECK. > Solution: Handle null sequences by skipping RunAndPopNextTask. > > Original change's description: > > [TaskScheduler]: Simplify sequence preemption logic. > > > > This CL removes preempted sequences from TaskTracker, > > removing need for CanScheduleSequenceObserver and > > simplifying shutdown. > > A CanRunPolicy enum is used instead, specifying whether > > or not tasks at a given priority can run. > > When CanRunPolicy is updated, wakeup workers needs > > to be done as appropriate. > > > > In addition, Shutdown was split in 2 phases start + complete > > to allow caller (TaskScheduler) to update CanRunPolicy after > > shutdown was started. > > > > This CL was recycled from: > > https://chromium-review.googlesource.com/c/chromium/src/+/1478007 > > I took ownership because simplifying Sequence lifecycle > > will simplify implementation of job API. > > > > TBR=gab@chromium.org > > > > Bug: 889029 > > Change-Id: Ie5dbc226705880c5e598e013aa2dd3e7e874158b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531161 > > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > > Reviewed-by: François Doray <fdoray@chromium.org> > > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648346} > > Bug: 889029, 950383 > Change-Id: I1f64517d312e65fb59ae235373b4f4d504da87dd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1557861 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#649399} Bug: 889029, 950383 Change-Id: I306bf7119034fcd3b917946f1f561344374bb718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564791 Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#651775} base/BUILD.gn | 2 +- base/task/thread_pool/can_run_policy_test.h | 191 +++++++++ .../thread_pool/can_schedule_sequence_observer.h | 27 -- .../thread_pool/platform_native_worker_pool.cc | 43 +- .../task/thread_pool/platform_native_worker_pool.h | 1 + .../scheduler_single_thread_task_runner_manager.cc | 173 +++++--- .../scheduler_single_thread_task_runner_manager.h | 4 + ...r_single_thread_task_runner_manager_unittest.cc | 78 ++-- base/task/thread_pool/scheduler_worker.cc | 3 +- base/task/thread_pool/scheduler_worker.h | 10 +- base/task/thread_pool/scheduler_worker_pool.cc | 38 +- base/task/thread_pool/scheduler_worker_pool.h | 24 +- .../task/thread_pool/scheduler_worker_pool_impl.cc | 63 +-- base/task/thread_pool/scheduler_worker_pool_impl.h | 1 + .../scheduler_worker_pool_impl_unittest.cc | 69 +++- .../thread_pool/scheduler_worker_pool_unittest.cc | 58 ++- .../thread_pool/scheduler_worker_stack_unittest.cc | 3 - base/task/thread_pool/scheduler_worker_unittest.cc | 19 +- base/task/thread_pool/task_tracker.cc | 317 ++------------ base/task/thread_pool/task_tracker.h | 226 ++-------- .../thread_pool/task_tracker_posix_unittest.cc | 8 +- base/task/thread_pool/task_tracker_unittest.cc | 458 +++------------------ base/task/thread_pool/test_utils.cc | 10 +- base/task/thread_pool/test_utils.h | 6 +- base/task/thread_pool/thread_pool.cc | 4 +- base/task/thread_pool/thread_pool.h | 5 +- base/task/thread_pool/thread_pool_impl.cc | 58 ++- base/task/thread_pool/thread_pool_impl.h | 20 +- base/task/thread_pool/thread_pool_impl_unittest.cc | 69 ++++ base/test/thread_pool_test_helpers_android.cc | 2 +- 30 files changed, 889 insertions(+), 1101 deletions(-) commit 6ef07c67d055f6982252a82856bf5dec05d07958 Author: Matt Mueller <mattm@chromium.org> Date: Wed Apr 17 17:03:21 2019 +0000 TrustStoreMac: Use internal implementation for IsSelfSigned This is significantly faster (about 80x in some quick testing). Also remove the now unused x509_util_mac IsSelfSigned function. Bug: 410574 Change-Id: I60cfc40d5f5a5dab419566836555cb4828148c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570768 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#651774} net/cert/internal/trust_store_mac.cc | 19 +++++++++++++++---- net/cert/x509_util_mac.cc | 36 ------------------------------------ net/cert/x509_util_mac.h | 3 --- 3 files changed, 15 insertions(+), 43 deletions(-) commit 6099951acbfc1c3257d74aeadc916685cd474fa8 Author: Ehsan Karamad <ekaramad@chromium.org> Date: Wed Apr 17 17:02:00 2019 +0000 [ FeaturePolicy ] downloads-without-user-activation The CL implements a new feature policy hidden behind the flag FeaturePolicyForSandbox. The policy is the feature policy counterpart to the sandbox flag 'allow-downloads-without-user-activation'. This policy is used to help migrate sandbox flags implementation on top of feature policies. PA: https://github.com/w3c/webappsec-feature-policy/issues/289 TBR=alexmos@chromium.org Bug: 812381 Change-Id: I234bb0486313ab350827315843db22525c2ceaac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538966 Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#651773} content/common/frame_messages.h | 1 + content/renderer/render_frame_impl.cc | 6 +-- content/renderer/render_view_browsertest.cc | 2 +- .../blink/common/feature_policy/feature_policy.cc | 3 ++ third_party/blink/common/frame/frame_policy.cc | 12 ++++-- .../blink/public/common/frame/frame_policy.h | 11 +++++- .../mojom/feature_policy/feature_policy.mojom | 3 ++ third_party/blink/public/web/web_local_frame.h | 10 ++++- .../core/execution_context/security_context.cc | 3 ++ .../feature_policy/feature_policy_features.json5 | 5 +++ .../blink/renderer/core/frame/sandbox_flags.cc | 4 +- .../renderer/core/frame/web_local_frame_impl.cc | 46 ++++++++++++++++++++-- .../renderer/core/frame/web_local_frame_impl.h | 3 +- .../renderer/core/html/html_frame_owner_element.h | 3 ++ .../renderer/core/html/html_iframe_element.cc | 8 +++- .../blink/renderer/core/html/html_iframe_element.h | 4 ++ .../renderer/core/html/html_iframe_element_test.cc | 2 +- .../blink/renderer/core/loader/frame_loader.h | 4 ++ .../feature-policy-for-sandbox/resources/helper.js | 4 +- .../feature-policy-features-expected.txt | 1 + tools/metrics/histograms/enums.xml | 1 + 21 files changed, 116 insertions(+), 20 deletions(-) commit 6bf849ee80eb83061e3c1713a3397aade65158ae Author: Reilly Grant <reillyg@chromium.org> Date: Wed Apr 17 16:59:56 2019 +0000 [Android] Check device permission before reading serial number In Android Q calling UsbDevice.getSerialNumber() when the calling application does not have permission to access the device will throw a SecurityException. Bug: 952956 Change-Id: I2c335f39b528ea0e72eede46f98291d21bfe284c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571005 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#651772} .../org/chromium/device/usb/ChromeUsbService.java | 8 ++++++- device/usb/usb_device_android.cc | 25 ++++++++++++++-------- device/usb/usb_service_android.cc | 11 +++++++--- device/usb/usb_service_android.h | 4 ++-- 4 files changed, 33 insertions(+), 15 deletions(-) commit 37a1c6e8e037088a66f3ea89989dbf714eeb9e4e Author: Bo Liu <boliu@chromium.org> Date: Wed Apr 17 16:58:17 2019 +0000 Remove pixel test suppressions Submit this after all bots have generated new reference images for these tests. Bug: 899399 Change-Id: Ib3a48a5955796e9e3638b11a6176bb8e935ebfe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568387 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651771} .../gpu/gpu_tests/test_expectations/pixel_expectations.txt | 12 ------------ 1 file changed, 12 deletions(-) commit c2835aaa20dcc30c8995017bcd92618a8dcac9c9 Author: Nate Chapin <japhet@chromium.org> Date: Wed Apr 17 16:58:11 2019 +0000 Don't route appcache foreign entry reloads through NavigationScheduler Bug: 914587 Change-Id: Ic851c6ad1d8e78af40f6bb8df3d310ed5c472e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570232 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#651770} .../renderer/core/loader/appcache/application_cache_host.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit ba412b51b21baa0d49016503fb42db297595e126 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Apr 17 16:49:02 2019 +0000 Add chrome_all_tast_tests to the fyi cros VM test bot. This will hopefully increase the chance of a test flake on the fyi bot so I can test out the failure reporting changes I'm making. Bug: 923426 Change-Id: Ibfda3b2af9f9240cfc72c5544ff56dfc2aa5c6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572259 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#651769} testing/buildbot/chromium.fyi.json | 18 ++++++++++++++++++ testing/buildbot/test_suites.pyl | 5 +++++ 2 files changed, 23 insertions(+) commit eabd777d26d55f18161dfb6abf30fa171850e084 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 16:47:13 2019 +0000 Roll src/third_party/angle 20a716319262..3b2c6bfd4353 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/20a716319262..3b2c6bfd4353 git log 20a716319262..3b2c6bfd4353 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 spang@chromium.org Vulkan: Implement glImportMemoryFdEXT Created with: gclient setdep -r src/third_party/angle@3b2c6bfd4353 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I98284c36d5ea84dc173255081b7acb0ff1f6d08c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572178 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651768} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cbdc2c593437738a24f446613026d4c5d3c7d9d7 Author: Huanzhong Huang <huanzhong@google.com> Date: Wed Apr 17 16:44:40 2019 +0000 [iOS] Reserve accessory view space in CBD cells Reserve the space needed for an accessory view in each CBD items, so that text labels don't reach the far right end of a cell, and therefore cell selection doesn't result in text label width shrinkage. Bug: 935346 Change-Id: I6c13d82c3eb45555710447040de49550410650a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571411 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#651767} .../cells/table_view_clear_browsing_data_item.mm | 24 +++++++++++++++++++--- 1 file changed, 21 insertions(+), 3 deletions(-) commit 836906b555dcada28fd7fb26d4df56eb2495bfab Author: Carlos Caballero <carlscab@google.com> Date: Wed Apr 17 16:43:46 2019 +0000 Make WorkerThreads use only one SequenceManager instance Currently WorkerThreads have a SequenceManager on top of the MessageLoop provided by base::Thread. This patch removes that duplication which was also causing a test to flake. There is really no need to use base::Thread, moreover it makes it hard hard to trigger shutdown and to make sure that initialization and destruction happen on the worker thread. So to have better control we use a base::SimpleThread instead. This patch has the small side effect that the thread name of WorkerThreads has now the tid as a suffix (imposed by the SimpleThread api). Bug: 934088 Change-Id: Ib771a5e2c756a0e8a02e6eed00a78da5d794e633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552812 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#651766} .../renderer/platform/scheduler/common/thread.cc | 4 +- .../platform/scheduler/main_thread/main_thread.cc | 2 - .../platform/scheduler/main_thread/main_thread.h | 1 - .../renderer/platform/scheduler/public/thread.h | 2 +- .../test/renderer_scheduler_test_support.cc | 1 - .../blink/renderer/platform/scheduler/worker/DEPS | 3 + .../scheduler/worker/worker_scheduler_unittest.cc | 2 +- .../platform/scheduler/worker/worker_thread.cc | 147 ++++++++++++--------- .../platform/scheduler/worker/worker_thread.h | 87 ++++++++---- .../scheduler/worker/worker_thread_unittest.cc | 22 --- 10 files changed, 150 insertions(+), 121 deletions(-) commit 4c60e6b03d79008cbfc45bccdd6a79795f7af745 Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Apr 17 16:41:11 2019 +0000 [PM] Add LastNavigationId to WebContentsProxy A policy message arriving on the UI thread may be bound to a contents that no longer exists, but in some cases the contents may still exist but have been renavigated. The LastNavigationId allows dropping policy messages that are only relevant to a particular navigation. This helps in migrating users of PSG/PSR/PSO away from that functionality. BUG=931407 Change-Id: I9182bd8fb558ff27d1a70917159d5eef4b99ccef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571008 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651765} .../browser/performance_manager/performance_manager_tab_helper.cc | 5 +++++ chrome/browser/performance_manager/performance_manager_tab_helper.h | 5 +++++ chrome/browser/performance_manager/web_contents_proxy.h | 6 ++++++ 3 files changed, 16 insertions(+) commit fb99d6e814540ba03d4c61933a74fb83657ffdf6 Author: Jonathan Backer <backer@chromium.org> Date: Wed Apr 17 16:40:23 2019 +0000 Revert "Refactor SkiaOutputSurfaceImplTest.SubmitPaint for on screen" This reverts commit a67d4d6f7e2ac32fabac423dabb4f3f6b172be03. Bug: 953476 Change-Id: I26daaa894110219d2f35573d4f0c520deade9245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572219 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#651764} components/viz/service/BUILD.gn | 5 +-- .../viz/service/display/renderer_pixeltest.cc | 18 ++++------ .../skia_output_device_offscreen.cc | 16 +++------ .../skia_output_surface_impl_unittest.cc | 42 ++++++---------------- gpu/vulkan/BUILD.gn | 24 ++++--------- 5 files changed, 28 insertions(+), 77 deletions(-) commit 489174fe2c21445b1f4db895a3610fcde471f235 Author: Alan Wink <alanwink@chromium.org> Date: Wed Apr 17 16:34:52 2019 +0000 Enable KidsManagementUrlClassification by default Bug: 935032 Change-Id: Ifebd7227120d90b9388fd9491b9a307a82a0991a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571545 Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Alan Wink <alanwink@chromium.org> Cr-Commit-Position: refs/heads/master@{#651763} chrome/common/chrome_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3ece7f0bcd6d9e2d91cd3a476c40c5fc941f4989 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 16:32:28 2019 +0000 Roll src/third_party/swiftshader 8e2440d06f5a..d1fff586eae3 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/8e2440d06f5a..d1fff586eae3 git log 8e2440d06f5a..d1fff586eae3 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 amaiorano@google.com Fix 2D texture image functions not returning GL_INVALID_ENUM with target == GL_TEXTURE_3D Created with: gclient setdep -r src/third_party/swiftshader@d1fff586eae3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/116827965 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I2e5c4cbe6154e0df18fdbd175637c2c05832c3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571527 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651762} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5abd263dfd3044b8ad9f132712c9cd356101f2af Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 17 16:31:21 2019 +0000 Elim DBusThreadManager from ash unit tests This also includes removal of unnecessary includes of dbus_thread_manager.h and improved DEPS restrictions. Bug: 951017 Change-Id: I5f75b3b01423a1a69e5929561bcc95b95a4e612c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560444 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#651761} ash/DEPS | 13 +++++++------ ash/accelerators/accelerator_controller.cc | 1 - ash/accelerators/accelerator_unittest.cc | 3 +++ ash/dbus/ash_dbus_services.cc | 10 ++++------ ash/detachable_base/detachable_base_handler.cc | 1 - ash/display/projecting_observer.cc | 1 - ash/login/ui/lock_contents_view.cc | 1 - ash/login/ui/login_auth_user_view.cc | 1 - ash/shell.cc | 4 +++- ash/shell/content/client/DEPS | 1 + ash/shell/content/client/shell_browser_main_parts.cc | 2 -- ash/shutdown_controller.cc | 2 -- ash/system/audio/display_speaker_controller.cc | 1 - ash/system/brightness/brightness_controller_chromeos.cc | 1 - .../keyboard_brightness_controller.cc | 1 - ash/system/network/auto_connect_notifier_unittest.cc | 16 +++++++--------- .../wifi_toggle_notification_controller_unittest.cc | 6 +++--- ash/system/night_light/night_light_controller.cc | 1 - ash/system/power/notification_reporter_unittest.cc | 1 - ash/system/power/peripheral_battery_notifier.cc | 1 - ash/system/power/power_button_controller.cc | 1 - ash/system/power/power_button_display_controller.cc | 1 - ash/system/power/power_event_observer.cc | 1 - ash/system/power/power_status.cc | 1 - ash/system/power/video_activity_notifier.cc | 1 - ash/system/power/video_activity_notifier_unittest.cc | 1 - ash/system/status_area_widget_unittest.cc | 6 +++--- .../unified/unified_system_tray_controller_unittest.cc | 6 +++--- ash/system/unified/unified_system_tray_model.cc | 1 - ash/test/ash_test_helper.cc | 12 ------------ ash/test/ash_test_helper.h | 1 - ash/wm/tablet_mode/tablet_mode_controller_unittest.cc | 1 - .../ui/ash/network/network_state_notifier_unittest.cc | 8 +++++--- 33 files changed, 39 insertions(+), 70 deletions(-) commit ba53a47cabdeba6caa3b40ec6b421fdd972c80e3 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Apr 17 16:29:31 2019 +0000 Remove obsolete TODO The TODO reference a bug that is marked as fixed, so remove it assuming it is now obsolete (the bug was targetting M-42). Bug: 416823 Change-Id: I354df401da061e7ca188c99426f3d5891edbf9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569714 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#651760} ios/chrome/browser/signin/authentication_service.mm | 8 -------- 1 file changed, 8 deletions(-) commit 787f8cf52850585e4a16b64f7686296040add847 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Apr 17 16:28:00 2019 +0000 [Autofill Assistant] Improve look in dark mode. Screenshots: * https://screenshot.googleplex.com/dvVs0G3rN9N.png * https://screenshot.googleplex.com/QL1OL5toepz.png * https://screenshot.googleplex.com/F62S8zJT6JK.png Bug: 944056 Binary-Size: Adding assets for the Autofill Assistant feature which will be in a DFM for M75 Change-Id: Ia97102ca0cbb5fc55bd184fc57ee67a74b02ac96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552874 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#651759} .../drawable-hdpi/autofill_assistant_onboarding_bg.png | Bin 19000 -> 0 bytes .../drawable-hdpi/autofill_assistant_onboarding_try.png | Bin 7051 -> 0 bytes .../autofill_assistant_onboarding_try.png | Bin 0 -> 2481 bytes .../autofill_assistant_onboarding_try.png | Bin 0 -> 9129 bytes .../res/drawable-night/autofill_assistant_shadow_bg.xml | 12 ++++++++++++ .../drawable-xhdpi/autofill_assistant_onboarding_bg.png | Bin 21226 -> 0 bytes .../autofill_assistant_onboarding_try.png | Bin 7206 -> 0 bytes .../autofill_assistant_onboarding_bg.png | Bin 33659 -> 0 bytes .../autofill_assistant_onboarding_try.png | Bin 15021 -> 0 bytes .../java/res/drawable/ic_tick_outline_48dp.xml | 5 ++--- .../layout/autofill_assistant_bottom_sheet_content.xml | 4 ++-- .../res/layout/autofill_assistant_button_hairline.xml | 1 + .../res/layout/autofill_assistant_payment_request.xml | 3 +-- .../java/res/values-night-v17/colors.xml | 13 +++++++++++++ 14 files changed, 31 insertions(+), 7 deletions(-) commit 743d05ad350003c9e07362e2c8a66eaf73ee9802 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 16:27:10 2019 +0000 Import wpt@5a6fad3aa59a2979b46141c55ea3cac85359b4c7 Using wpt-import in Chromium c1d1c4af2990ff086d1482dc26d58501dff3d099. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" 4e9215207a "[Code Health] Remove unnecessary reference file for web test" c1940432ee "[WPT/common/security-features] Merge subresource path construction" 40465b7400 "[Animation Worklet] Copy the effects of a migrating animator over to new global scope" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I066890bba89d18e4495445fe1145ed2fea7fa631 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571487 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651758} .../web_tests/external/WPT_BASE_MANIFEST_6.json | 4 ++-- .../web_tests/external/wpt/interfaces/webxr.idl | 20 +++++++++----------- .../wpt/webxr/idlharness.https.window-expected.txt | 9 +++++---- 3 files changed, 16 insertions(+), 17 deletions(-) commit b0e0d7f34ee8dd08695021e6c4a159d44c40fb1e Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 17 16:25:18 2019 +0000 [FCM] Migrate HasPersistedMessages pref to include subscription IDs Before this CL: There was a one global Boolean to signal if there are persisted FCM messages. But messages are replayed per subscription upon registration, so it's in efficient to keep one global flag. After this CL: This is replaced with a set of subscription ids that have persisted messages. Bug: 946486 Change-Id: I36836d224561568b84472786d0828e4dd40531fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569936 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#651757} .../chromium/components/gcm_driver/GCMDriver.java | 45 ++++++------ .../gcm_driver/LazySubscriptionsManager.java | 81 +++++++++++++++++----- .../gcm_driver/LazySubscriptionsManagerTest.java | 42 +++++++++-- 3 files changed, 121 insertions(+), 47 deletions(-) commit 7d291fccf821648345ce771daf4e00443e9bbc75 Author: Ken Rockot <rockot@chromium.org> Date: Wed Apr 17 16:25:02 2019 +0000 Revert "Reland "[mojo-core] Support pipe splicing"" This reverts commit ef0704201f0b67785d8efb2c640d5a3add3e5bdc. Reason for revert: Circular refs leaking MessagePipeDispatcher instances. Also, abandoning the effort to remove associated interfaces for now: https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit#heading=h.csbpv04y875v Original change's description: > Reland "[mojo-core] Support pipe splicing" > > This is a reland of afff956d5971a116ceb38bea91732e157f0ba9c4 > > Fixes some trivial uninitialized value bugs only caught by MSAN after > landing. PS1 is the original CL, PS2 is the diff which fixes the bugs. > > Original change's description: > > [mojo-core] Support pipe splicing > > > > This change allows message pipes to be "spliced" into other message > > pipes, unifying their message queues while retaining their logical > > independence for routing of written messages. > > > > This is supported by adding an array of per-handle options and flags to > > MojoAppendMessageDataOptions. If a handle is marked with > > MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE when appended to a message, > > sending that message will effectively cause the handle and its peer to > > be spliced into the sending pipe. > > > > See bug for design doc link. > > > > Bug: 941809 > > Change-Id: I191fb4df4c1586bcee91a3ccf595d76869451e7b > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548145 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648579} > > Bug: 941809 > Change-Id: Ia66fa98810fae88023c71b50e5b6fd3862c4474e > TBR: oksamyt@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1558190 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#648743} TBR=rockot@google.com,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941809,950454,951085,950983 Change-Id: I84ec6a14f0b1dccbb213ff9426c96af061c274a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570704 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#651756} mojo/core/BUILD.gn | 1 - mojo/core/core.cc | 39 +-- mojo/core/data_pipe_consumer_dispatcher.cc | 25 +- mojo/core/data_pipe_consumer_dispatcher.h | 4 +- mojo/core/data_pipe_control_message.cc | 3 +- mojo/core/data_pipe_producer_dispatcher.cc | 25 +- mojo/core/data_pipe_producer_dispatcher.h | 4 +- mojo/core/dispatcher.h | 1 - mojo/core/handle_table.cc | 3 +- mojo/core/message_pipe_dispatcher.cc | 139 +++----- mojo/core/message_pipe_dispatcher.h | 31 +- mojo/core/message_unittest.cc | 18 +- mojo/core/node_controller.cc | 29 +- mojo/core/node_controller.h | 20 +- mojo/core/ports/event.cc | 10 +- mojo/core/ports/event.h | 7 +- mojo/core/ports/node.cc | 153 ++++----- mojo/core/ports/node.h | 8 +- mojo/core/ports/port.cc | 10 +- mojo/core/ports/port.h | 18 +- mojo/core/spliced_message_pipe_unittest.cc | 350 --------------------- mojo/core/user_message_impl.cc | 81 +---- mojo/core/user_message_impl.h | 20 +- mojo/public/c/system/message_pipe.h | 49 +-- mojo/public/cpp/bindings/lib/buffer.cc | 2 +- .../cpp/bindings/tests/validation_unittest.cc | 2 +- mojo/public/cpp/system/message_pipe.cc | 2 +- 27 files changed, 199 insertions(+), 855 deletions(-) commit bec3b12196009ad18039b9391201c04a9ad366d5 Author: Avery Musbach <amusbach@chromium.org> Date: Wed Apr 17 16:22:41 2019 +0000 overview: Scale up the dragged overview item by 10% instead of 8% Before the present CL, the bounds of the dragged overview item are outset horizontally by 4% of the width, and vertically by 4% of the height. The outset in each dimension is on both sides, for a total of an 8% increase in size along that dimension. According to the specification, it should be 10%: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html Test: manual Bug: 953519 Change-Id: Iea690ebc851bcc6fb573fd66d91f26a7a4d92bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570692 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#651755} ash/wm/overview/overview_item.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit aa9908adc6438d08d59493cefb6a491b84e44bbf Author: Peter Kasting <pkasting@chromium.org> Date: Wed Apr 17 16:21:58 2019 +0000 Replace child_count()/child_at() with STL algorithms. These functions are deprecated. Where we can't map the existing functionality to algorithms, they're being replaced by range-based for, iterators, etc. In the cases in this CL, the underlying functionality maps to STL algorithms, so make use of them; this provides the most high-level description of the intent of the code, and in many cases can be simplified further in C++20 with ranges. See also https://sean-parent.stlab.cc/presentations/2013-09-11-cpp-seasoning/cpp-seasoning.pdf for arguments against loops (range-based or otherwise). Bug: 940135 Change-Id: Ic4ef8a9fd6840645180472828e91306414bb795b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565507 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#651754} ash/app_list/views/app_list_view_unittest.cc | 11 +++---- ash/app_list/views/page_switcher.cc | 23 +++++++------- ash/assistant/ui/assistant_container_view.cc | 35 ++++++++-------------- .../ui/main_stage/assistant_main_stage.cc | 27 +++++++++-------- .../views/keyboard_shortcut_item_view.cc | 11 ++++--- ash/login/ui/login_test_utils.cc | 12 +++----- ash/login/ui/login_test_utils.h | 2 +- ash/media/media_notification_view_unittest.cc | 14 ++++----- ash/shelf/login_shelf_view_unittest.cc | 11 ++++--- .../message_center/unified_message_list_view.cc | 21 +++++++------ ash/system/tray/tray_bubble_view.cc | 13 ++++---- ash/system/tray/tray_detailed_view.cc | 20 +++++-------- ash/system/unified/feature_pods_container_view.cc | 21 +++++-------- ash/system/unified/unified_system_tray_view.cc | 10 ++++--- ui/chromeos/ime/candidate_view_unittest.cc | 31 ++++++++++--------- 15 files changed, 113 insertions(+), 149 deletions(-) commit 68c4de4bcc1dd52ead2a972e62fd1cea2a6bbb5d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 16:21:32 2019 +0000 Roll src/third_party/glslang/src 0527c9db8148..805b09f92203 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/0527c9db8148..805b09f92203 git log 0527c9db8148..805b09f92203 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 johnkslang@users.noreply.github.com Merge pull request #1753 from pixeljetstream/ckubischnv_dumpbuiltins Created with: gclient setdep -r src/third_party/glslang/src@805b09f92203 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I722e69057f6d83dd1998a878972d4bec1306289f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572179 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651753} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aaccbc05120b30f33a0f9ada8f21103d3b8d92c4 Author: Richard Knoll <knollr@chromium.org> Date: Wed Apr 17 16:20:52 2019 +0000 Update notification timestamp over time. This updates the relative time shown in non-native MD notifications as time goes by. Bug: 910089 Change-Id: Ie403c6b00c2f3b5508a5ed63d19d1b650787f83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547518 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651752} ash/media/media_notification_view.cc | 4 +- ui/message_center/BUILD.gn | 7 +- .../views/notification_header_view.cc | 30 ++- ui/message_center/views/notification_header_view.h | 14 +- .../views/notification_header_view_unittest.cc | 100 ++++++++++ ui/message_center/views/notification_view_md.cc | 3 +- ui/message_center/views/relative_time_formatter.cc | 81 ++++++++ ui/message_center/views/relative_time_formatter.h | 24 +++ .../views/relative_time_formatter_unittest.cc | 203 +++++++++++++++++++++ ui/message_center/views/timestamp_view.cc | 71 ------- ui/message_center/views/timestamp_view.h | 29 --- ui/message_center/views/timestamp_view_unittest.cc | 167 ----------------- 12 files changed, 444 insertions(+), 289 deletions(-) commit 9fd8382057d83c92a4b86b6feb982c91f6a37ecb Author: jonross <jonross@chromium.org> Date: Wed Apr 17 16:20:29 2019 +0000 Update vulkan_content_browsertests expectations A regression lead to viz::SkiaOutputDeviceVulkan::UpdateDrawSurface crashing. This has since been fixed (crbug.com/952231). This combined with falling back to GL Renderer was leading to the test only having flaky failures. We have recently added a testing flag to prevent this false positive: "--disable-vulkan-fallback-to-gl-for-testing" which this change adds to the tests. So that we reliably catch failures going forward. This change also re-enables AuraWindowVideoCaptureDeviceBrowserTest.ErrorsOutIfWindowHasGoneBeforeDeviceStart which was failing due to crbug.com/948249 which has since been fixed. This change also removes the test exceptions for vulkan_content_browsertests aside from TSAN and Intel HD 630, which are failing for other reasons TEST=vulkan_content_browsertests Bug: 940723, 930943 Change-Id: Id187c41718a91b4401db9ff2549d6556d1820c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568088 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Jonathan Backer <backer@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#651751} testing/buildbot/chromium.gpu.fyi.json | 122 ++++++++++++++++++++- .../filters/vulkan.content_browsertests.filter | 3 +- testing/buildbot/test_suite_exceptions.pyl | 5 +- testing/buildbot/test_suites.pyl | 2 +- 4 files changed, 122 insertions(+), 10 deletions(-) commit 92eec70c9193bdf026704fed30a1f660ce3abcb2 Author: Lily Chen <chlily@chromium.org> Date: Wed Apr 17 16:17:42 2019 +0000 Remove net::CookieSameSite::DEFAULT_MODE enum value Force callers to specify a SameSite mode instead of relying on defaults which may be subject to change. Also removes blink::WebCanonicalCookie::kDefaultSameSiteMode. Bug: 953306 Change-Id: Iaea2224a28a169804048ad9f765e811374a9836f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567955 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#651750} .../browsing_data_remover_browsertest.cc | 2 +- .../counters/site_data_counting_helper_unittest.cc | 10 ++-- .../chromeos/login/profile_auth_data_unittest.cc | 6 +- .../api/browsing_data/browsing_data_test.cc | 2 +- .../browser/extensions/api/cookies/cookies_api.cc | 4 +- .../extensions/api/cookies/cookies_helpers.cc | 18 +++--- .../api/cookies/cookies_helpers_unittest.cc | 2 +- .../extensions/api/cookies/cookies_unittest.cc | 8 +-- .../net/chrome_network_service_browsertest.cc | 2 +- .../browser/consistency_cookie_manager_android.cc | 2 +- .../core/browser/gaia_cookie_manager_service.cc | 2 +- .../browsing_data_remover_impl_unittest.cc | 2 +- .../net/quota_policy_cookie_store_unittest.cc | 2 +- ios/net/cookies/cookie_cache_unittest.cc | 2 +- ios/net/cookies/cookie_store_ios_test_util.mm | 2 +- ios/net/cookies/system_cookie_util.mm | 2 +- ios/net/cookies/system_cookie_util_unittest.mm | 4 +- net/cookies/canonical_cookie_unittest.cc | 67 +++++++++++----------- net/cookies/cookie_constants.cc | 8 +-- net/cookies/cookie_constants.h | 9 +-- net/cookies/cookie_deletion_info_unittest.cc | 21 +++---- net/cookies/cookie_monster_store_test.cc | 2 +- net/cookies/cookie_monster_unittest.cc | 45 ++++++++------- net/cookies/cookie_store_unittest.h | 26 ++++----- net/cookies/parsed_cookie.cc | 2 +- net/cookies/parsed_cookie_unittest.cc | 8 +-- .../sqlite/sqlite_persistent_cookie_store.cc | 4 +- .../sqlite_persistent_cookie_store_perftest.cc | 2 +- .../sqlite_persistent_cookie_store_unittest.cc | 36 ++++++------ .../session_cleanup_cookie_store_unittest.cc | 2 +- .../blink/public/platform/web_canonical_cookie.h | 5 +- .../platform/exported/web_canonical_cookie.cc | 4 -- .../platform/exported/web_canonical_cookie_test.cc | 9 ++- 33 files changed, 156 insertions(+), 166 deletions(-) commit 0f559f7eb8994bdd68d783c24567a26f92f8bac1 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Apr 17 16:15:06 2019 +0000 [iOS] Add separator for the toolbars This CL adds a separator between the two toolbars and the content on the screen. Bug: 912963 Change-Id: I1a386c5ffb1cbe9cdbfd25000df7adcd5b00f4e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571417 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#651749} .../content_suggestions_header_view.h | 4 ++++ .../content_suggestions_header_view.mm | 23 ++++++++++++++++++++++ .../content_suggestions_header_view_controller.mm | 2 ++ .../browser/ui/toolbar/primary_toolbar_view.mm | 16 +++++++++++++++ .../browser/ui/toolbar/public/toolbar_constants.h | 5 +++++ .../browser/ui/toolbar/public/toolbar_constants.mm | 3 +++ .../browser/ui/toolbar/secondary_toolbar_view.mm | 14 +++++++++++++ 7 files changed, 67 insertions(+) commit a9e21191aeb4c29ecf577edde5cc6af8e28724cb Author: Mike Wittman <wittman@chromium.org> Date: Wed Apr 17 16:14:19 2019 +0000 [Sampling profiler] Fix UnloadingLibrary test expectation Update the expectation to match the wait_until_unloaded case. This should have been updated along with that case in http://crrev.com/645138 but was overlooked. Bug: 953714 Change-Id: I168f6690fdb32081930cae0c1ae57021219d471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572221 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651748} base/profiler/stack_sampling_profiler_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 14712af95474f87865f4ceb0319bf9af333be83b Author: Carlos Caballero <carlscab@google.com> Date: Wed Apr 17 16:13:01 2019 +0000 Reland "Remove MessageLoopBase" This is a reland of 58017e6cc6dd25207cae01ebe2d7961d12a46b3f with a fix for base_unittests failing on chromium.memory/win-asan (https://crbug.com/953465) Original change's description: > Remove MessageLoopBase > > Bug: 891670 > Change-Id: Iff6a2b4685f455509553779c7c04afd3c6f6c4e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538289 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651343} Bug: 891670 Change-Id: I5271b84caaa204093203284342fe0289843844d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570030 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#651747} base/message_loop/message_loop.cc | 57 +++------ base/message_loop/message_loop.h | 136 +++------------------ base/message_loop/message_loop_current.cc | 52 ++++---- base/message_loop/message_loop_current.h | 18 +-- base/message_loop/message_loop_unittest.cc | 16 +-- base/message_loop/message_pump_perftest.cc | 8 +- base/message_loop/message_pump_unittest.cc | 14 +-- base/task/sequence_manager/sequence_manager_impl.h | 44 +++---- 8 files changed, 109 insertions(+), 236 deletions(-) commit 1929b6888013c15dd39bb4e3d66c1a6b6a2b0f11 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 16:10:58 2019 +0000 Roll Fuchsia SDK from 891595251730 to 891592798553 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia4358f355bd200b43dd7f72c979f4f6a8f6d559a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572080 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651746} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 2c1a063977df0b4b653058415f1a4b38691e25ce Author: Becca Hughes <beccahughes@chromium.org> Date: Wed Apr 17 16:10:12 2019 +0000 [Media Controller] Add SuspendAllSessions Add SuspendAllSessions mojo API to suspend all media sessions. This will be used to pause playback when the audio output is detached. BUG=905923 Change-Id: I540ef1a78ec6f9e8d7eec0b4cb39f783db58e641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568831 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#651745} services/media_session/audio_focus_manager.cc | 5 ++++ services/media_session/audio_focus_manager.h | 1 + .../media_session/media_controller_unittest.cc | 30 ++++++++++++++++++++++ .../public/mojom/media_controller.mojom | 3 +++ 4 files changed, 39 insertions(+) commit a4bda7b436add2044c64c0b83753e8c8a9012662 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Apr 17 16:08:24 2019 +0000 chromeos: Parse test results when using the host-side Tast runner. Bug: 923426 Change-Id: I26920165476cbc5a6cb7d03329e66d346528f1d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565617 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#651744} build/chromeos/test_runner.py | 69 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 68 insertions(+), 1 deletion(-) commit 154c24ad4e68ebe6132e148d4715d7224bfdf2bc Author: Stephane Zermatten <szermatt@chromium.org> Date: Wed Apr 17 16:08:00 2019 +0000 [Autofill Assistant] Delete controller while a script is running. With this change, the AA controller is deleted immediately, even when a script is running, no matter what action is it. This simplifies the shutdown procedure and makes it overall more robust. This solves an immediate issue with wait for navigation preventing shutdown. There used to be ownership issues that prevented it from working properly. These issues seems to have been fixed. Bug: b/128300038 Change-Id: Ieeeccc9bcf3cc996072ef87b97b9fe741842adb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569116 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#651743} .../android/autofill_assistant/client_android.cc | 9 ++--- .../browser/actions/action_delegate.h | 7 +--- .../browser/actions/mock_action_delegate.h | 4 +- .../browser/actions/prompt_action.cc | 14 +------ .../browser/actions/prompt_action.h | 1 - .../browser/actions/prompt_action_unittest.cc | 20 +++++----- .../autofill_assistant/browser/controller.cc | 45 +++------------------- components/autofill_assistant/browser/controller.h | 27 +++---------- .../browser/controller_unittest.cc | 2 +- .../browser/fake_script_executor_delegate.cc | 2 - .../browser/fake_script_executor_delegate.h | 1 - .../autofill_assistant/browser/script_executor.cc | 37 +----------------- .../autofill_assistant/browser/script_executor.h | 13 +------ .../browser/script_executor_delegate.h | 1 - .../autofill_assistant/browser/script_tracker.cc | 9 ----- .../autofill_assistant/browser/script_tracker.h | 11 ------ 16 files changed, 31 insertions(+), 172 deletions(-) commit c1960d07828c00fb93e350fd53f31a41073492ef Author: Thomas Tangl <tangltom@chromium.org> Date: Wed Apr 17 16:06:02 2019 +0000 [unified-consent] Enable UnifiedConsent for DiceBrowserTest Remove ScopedAccountConsistency so that UnifiedConsent is enabled through the fieldtrial features. ScopedAccountConsistency can be removed because kDice is already default in the tests. Bug: 811351 Change-Id: I9d5a6de0dca8c31edfacf0ced0b242ac1eb02f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571685 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#651742} chrome/browser/signin/dice_browsertest.cc | 56 +++++++--------------- .../browser/ui/webui/signin/login_ui_test_utils.cc | 12 +++-- .../signin/core/browser/account_reconcilor.h | 2 +- 3 files changed, 27 insertions(+), 43 deletions(-) commit e792be31be61ff6545dd2c2e4529794dba230bf0 Author: George Burgess IV <gbiv@chromium.org> Date: Wed Apr 17 16:03:59 2019 +0000 afdo: Make our updater support arbitrary gs:// links These profiles will be specially rolled just for Android and Linux, so we'll probably put them in a different location than our current profiles. Since it's easier to land a change on master than on a branch, and we're probably going to give this rolling a shot on M75, ... Bug: 858856 Change-Id: Idd8cef23f7daddbb40c2a8b18a852c386eef1efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570572 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#651741} chrome/android/profiles/update_afdo_profile.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit 5667a5f12e08c894467401a0ae3f3ca55efd9649 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Apr 17 16:01:07 2019 +0000 Re-order method call in AuthenticationService::SignIn On both Chrome on iOS and iOS WebView, the sign-in workflow consists of the following operations performed in order: 1. copying the information about the account from the SSO library to the IdentityManager via LegacySeedAccountInfo() 2. setting the primary account information using the account_id acquired from the previous step 3. synchronizing the list of accounts between the SSO library and the IdentityManager via LegacyReloadAccountsFromSystem() However, AuthenticationService intermingled this with other steps that are unrelated: clearing the kSigninShouldPromptForSigninAgain preference and calling PrepareForFirstSyncSetup(). It would become possible to refactor the sign-in workflow on iOS so that the legacy API calls are internalized into the Identity Service implementation if those calls where not intermingled. Looking at what they do, it is safe to move them before the call to LegacySeedAccountInfo() because LegacySeedPrimaryAccount() does not result in any callbacks to be invoked, and the implementation does not depend on the system modified by those two calls. Bug: 926940 Change-Id: Ie129675ae4a65e9b065885a205c6990468d1649a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569865 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#651740} ios/chrome/browser/signin/authentication_service.mm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 7a28364470838890f07653f8622e466d887d12c6 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Apr 17 16:00:39 2019 +0000 Remove duplicated call to ReloadCredentialsFromIdentities The first thing that ComputeHaveAccountsChanged() does is invoke ReloadCredentialsFromIdentities() passing !is_in_foreground_ for value of should_prompt. Before this change, when the app was leaving the background, it would end up calling ReloadCredentialsFromIdentities() twice, first with should_prompt set to true, and then set to false. After this change, the method will only be called once. This is safe as the second call to the method would be a no-op from the point of view of outside code: - if the primary account refresh token was lost, then the user would has been signed out during the first call (with a notification) and on the second call it would have returned early - if the primary account refresh token is still present, then the second call will just reload the same list of account (this assumes that SSO library does not change the list of account asynchronously) There is one difference introduced by this change. The value of the preference prefs::kSigninShouldPromptForSigninAgain is set to the value passed to should_prompt in the last call. So before this change the value would have been set to false, while after the change it ends up being set to true. Setting the preference to false looks like it is a bug however. Reading the code, it appears the code sets this to true when a primary account was configured but the refresh token is lost in order to prompt the user for the credentials. It is indeed set to true if the refresh token is lost while the app is in the foreground, so it is weird to have it set to false if the same event happens if it occurred while the app was in the background. Another reason for qualifying this behaviour as a bug is that the call to ReloadCredentialsFromIdentities() explicitly pass true, and only the second indirect call inside the method ComputeHaveAccountsChanged() was passing false. Bug: none Change-Id: Ic3fdcac71bbcce4a3198a58f39f8cbddb5be611b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569124 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#651739} ios/chrome/browser/signin/authentication_service.mm | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) commit 5263f346f1fb957d17ff68a0e372ce1fc2c5b05d Author: Owen Min <zmin@chromium.org> Date: Wed Apr 17 15:59:12 2019 +0000 Read cloud policy overrides policy from platform policy provider directly. When we create the MachineLevelUserCloudPolicyManager, we need to provide a flag to indicate whether cloud policy has higher priority than the platform one. Since the |local_state| is not ready yet, We will read it from platform policy provider directly. Bug: 749530 Test: Manually on Win/Mac/Linux. Change-Id: I84222156199460f651ffb7638dead41bf264da01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568037 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651738} .../policy/chrome_browser_policy_connector.cc | 3 +- .../machine_level_user_cloud_policy_controller.cc | 33 +++++++++++++++++++++- .../machine_level_user_cloud_policy_controller.h | 3 +- 3 files changed, 36 insertions(+), 3 deletions(-) commit a27ebc157d71dfe3c369c9720239fc5507868429 Author: Kaan Alsan <alsan@google.com> Date: Wed Apr 17 15:56:58 2019 +0000 Add tracing for compositor frame pipeline Created CompositorFrameReporter class to report execution times of certain phases within a Compositor frame's pipeline to show trace events. Reporters are managed by CompositorFrameReportingController class which keeps track of reporters at different phases. This class belongs to CompositorTimingHistory, which makes calls to indicate that certain phases have begun/ended. Currently, only phases for the multi-threaded compositor are tracked. The general order of the phases are: - BeginImplFrameToSendBeginMainFrame - SendBeginMainFrameToCommit - Commit - CommitEndToActivate - Activate - ActivateEndToSubimtCompositorFrame - SubmitCompositorFrame Sample trace: https://drive.google.com/file/d/1il9m0smq7iQRfUKl0n52_6fZdSSRZarV/view?usp=sharing Doc: https://docs.google.com/document/d/1UDVTqBKckFVSyxhdebCFIiupUwFmHkT7h0G_HjxZGsA/edit?usp=sharing Change-Id: I6473ad3431af7754c6d7cfc9f1c8368dc897477b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1448513 Commit-Queue: Kaan Alsan <alsan@google.com> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#651737} cc/BUILD.gn | 7 + cc/scheduler/compositor_frame_reporter.cc | 56 ++++++++ cc/scheduler/compositor_frame_reporter.h | 67 +++++++++ .../compositor_frame_reporting_controller.cc | 123 ++++++++++++++++ .../compositor_frame_reporting_controller.h | 65 +++++++++ ...mpositor_frame_reporting_controller_unittest.cc | 156 +++++++++++++++++++++ cc/scheduler/compositor_timing_history.cc | 30 +++- cc/scheduler/compositor_timing_history.h | 17 ++- cc/scheduler/compositor_timing_history_unittest.cc | 20 ++- cc/scheduler/scheduler.cc | 3 +- .../fake_compositor_frame_reporting_controller.cc | 46 ++++++ .../fake_compositor_frame_reporting_controller.h | 34 +++++ cc/test/layer_tree_test.cc | 7 +- cc/test/scheduler_test_common.cc | 15 +- cc/test/scheduler_test_common.h | 11 +- cc/trees/layer_tree_host.h | 1 + cc/trees/layer_tree_host_impl.cc | 3 + cc/trees/layer_tree_host_impl.h | 10 ++ cc/trees/proxy_impl.cc | 5 +- cc/trees/proxy_impl.h | 2 - cc/trees/single_thread_proxy.cc | 6 +- 21 files changed, 655 insertions(+), 29 deletions(-) commit 4e4ae4ae91aaf562f8ef73a25c6b54646e68774b Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Apr 17 15:52:36 2019 +0000 Re-enable original expectations for RTCPeerConnection onnegotationneede tests Bug: 740501 Change-Id: I0a5caf723806cfdb4923150885c29508d367afff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570032 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#651736} third_party/blink/web_tests/TestExpectations | 4 +--- .../webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt | 10 ---------- 2 files changed, 1 insertion(+), 13 deletions(-) commit 25ac5ddfcf4a6613be98759c60d8fafda520fc71 Author: Saman Sami <samans@chromium.org> Date: Wed Apr 17 15:51:41 2019 +0000 Fix frame rejection and eviction when parent sequence number is reset When embed token is reset, we should not enforce that sequence numbers monotonically increase. Also, any call to EvictSurface should only affect surfaces with the same embed token as the evicted id. Bug: 931801 Change-Id: I3cc1ecc80197b02fe0a3c5cffed4988cfd8e5d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570247 Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#651735} .../frame_sinks/compositor_frame_sink_support.cc | 41 ++++++++++-------- .../frame_sinks/compositor_frame_sink_support.h | 4 +- .../compositor_frame_sink_support_unittest.cc | 48 ++++++++++++++++++++++ 3 files changed, 76 insertions(+), 17 deletions(-) commit 0fa8eb0588fe0433ace6be9f1717c65015eabbaa Author: Khushal <khushalsagar@chromium.org> Date: Wed Apr 17 15:51:08 2019 +0000 viz: Add FrameRateDecider to choose the optimal refresh rate. Introduce a new class (FrameRateDecider) to decide the refresh rate for the display in cases where multiple refresh rates are supported by the current display. The FrameRateDecider chooses the optimum rate based on the content producers which are animating and onscreen. R=ericrk@chromium.org, kylechar@chromium.org Change-Id: I595f207c07057a0a72914100e672af741cde99e4 Bug: 938106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555593 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#651734} .../viz/common/frame_sinks/begin_frame_args.h | 6 + components/viz/service/BUILD.gn | 5 + components/viz/service/display/display.cc | 33 ++- components/viz/service/display/display.h | 12 +- .../viz/service/display/frame_rate_decider.cc | 148 ++++++++++++ .../viz/service/display/frame_rate_decider.h | 88 +++++++ .../service/display/frame_rate_decider_unittest.cc | 260 +++++++++++++++++++++ .../viz/service/frame_sinks/video_detector.h | 2 +- components/viz/service/hit_test/hit_test_manager.h | 2 +- components/viz/service/surfaces/surface_client.h | 12 + .../viz/service/surfaces/surface_observer.cc | 14 ++ components/viz/service/surfaces/surface_observer.h | 17 +- components/viz/test/BUILD.gn | 2 + components/viz/test/fake_surface_observer.h | 2 +- components/viz/test/stub_surface_client.cc | 21 ++ components/viz/test/stub_surface_client.h | 46 ++++ 16 files changed, 655 insertions(+), 15 deletions(-) commit b3d38226b244008130c5e3e2388b16675f55efe3 Author: Eugene But <eugenebut@google.com> Date: Wed Apr 17 15:49:58 2019 +0000 Fix restricted pages for legacy navigation manager. WKWebView passes nil WKNavigation object to WKNavigationDelegate callbacks when last committed item represents restricted web page. nil WKNavigation confuses existing chrome code, and the app crashes because navigation never gets committed and committed item is expected in webView:didFinishNavigation:. This CL adds early return and commits pending item for web::kWebKitErrorUrlBlockedByContentFilter errors to prevent placeholder navigations, which will cause a crash. This CL makes crbug.com/950488 reproducible for legacy navigation manager. Bug: 944044, 950488 TEST=load, reload and perform a back forward navigation to restricted URLs Change-Id: I158c55137f70909b503b1698e82ec77b60d312b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570530 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#651733} ios/web/web_state/ui/crw_web_controller.mm | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) commit f952894ef5d45640c834483e3a71be1aba767547 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 15:46:41 2019 +0000 Update V8 to version 7.5.285. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca659d06..58da6c5b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I70bd96b3239595ceade98b205f6f7a266a0294ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571486 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651732} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c280fc71b502e2a8779a5be898b60ddd97a4efe0 Author: Bo Liu <boliu@chromium.org> Date: Wed Apr 17 15:46:09 2019 +0000 viz: Call DidPresent when SwapAck is suppressed Webview suppresses SwapAck because calling SwapAck synchronously will mean it happens before DidSwap. However webview now requires presentation feedbacks to go through the normal code path in viz, so remove that check. Change-Id: I63ec790da644325c5990b80648c93770aa826aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570911 Commit-Queue: Bo <boliu@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Bo <boliu@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#651731} .../viz/service/display_embedder/skia_output_surface_impl_non_ddl.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 0d660b94791b60cf11ec2a432e3da6109546f74d Author: Alex Clarke <alexclarke@chromium.org> Date: Wed Apr 17 15:44:27 2019 +0000 Revert "Fix MOCK_TIME bug with racy cross thread immediate task posting" This reverts commit e7eac012ddf1a834935bbb50a696a7f4d223767b. Reason for revert: Looks like one of the tests is failing on ios Original change's description: > Fix MOCK_TIME bug with racy cross thread immediate task posting > > In https://crrev.com/c/1564008 we have a test that only cares about main > thread delayed tasks. However it invokes an API which as a side effect > triggers cross thread PostTask to the main thread. These tasks are > uninteresting except occasionally they happen in the window between > MockTimeDomain::DelayTillNextTask and > MockTimeDomain::MaybeFastForwardToNextTask. Due to a bug in > MaybeFastForwardToNextTask it was treating this racy cross thread post > the same as running out of tasks and exiting early. > > This is clearly undesirable and this patch fixes that behaviour. > > Change-Id: I98a96c98c8ae56fd22bc2b9ea452d46565354127 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565983 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651677} TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org Change-Id: Id8850f47c66400d59e8aa43e04f3bf5d25205e08 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571687 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#651730} base/task/sequence_manager/time_domain.h | 2 +- base/test/scoped_task_environment.cc | 22 ++---- base/test/scoped_task_environment.h | 3 - base/test/scoped_task_environment_unittest.cc | 102 ++------------------------ 4 files changed, 12 insertions(+), 117 deletions(-) commit 258c19a7aaa9aad88494bee70ad3c5943152a9f5 Author: Emily Stark <estark@google.com> Date: Wed Apr 17 15:44:14 2019 +0000 Add lookalike interstitial metrics to histograms.xml These metrics were added earlier when the lookalike interstitial was created, but they weren't added to histograms.xml so they don't show up on the UMA dashboard. Bug: 933520 Change-Id: Ib2839caf03cc5ac4f8022f073c74a9daf8da8fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570472 Reviewed-by: Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#651729} tools/metrics/histograms/histograms.xml | 8 ++++++++ 1 file changed, 8 insertions(+) commit 0a4e162b5511ee25a2ba5ac2140f805bfd38a0a6 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Apr 17 15:38:14 2019 +0000 [Autofill Assistant] Fix spacing between poodle and status message. Change-Id: Idce427c63a86a02e71e9e26e63a868ce204478c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571645 Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#651728} .../java/res/layout/autofill_assistant_bottom_sheet_content.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4b5ee3103dd72c718e3689e506bff9570248df14 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Apr 17 15:33:36 2019 +0000 Revert "[Background Sync] Keep the browser alive" This reverts commit 7ba68304700fa2a04cf32a583b5edfde1ab41b40. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 651700 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vN2JhNjgzMDQ3MDBmYTJhMDRjZjMyYTU4M2I1ZWRmZGUxYWI0MWI0MAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/90491 Sample Failed Step: browser_tests Sample Flaky Test: BackgroundSyncBrowserTest.VerifyShutdownBehavior Original change's description: > [Background Sync] Keep the browser alive > > When the (one-shot) sync event can be fired at the time of registering. > The keepalive is cancelled after the first attempt of firing the event > has completed, regardless of whether it was successful. > > Bug: 949486 > > Change-Id: I6a1f6bfe2bdd820bc8fc05828e8f226922323368 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550833 > Commit-Queue: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#651700} Change-Id: If0760fe0df8cbf7ed552b8d7b818dab403de8d4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 949486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572220 Cr-Commit-Position: refs/heads/master@{#651727} .../browser/background/background_mode_manager.cc | 2 - .../background_sync/background_sync_browsertest.cc | 115 --------------------- .../background_sync_controller_impl.cc | 20 ---- .../background_sync_controller_impl.h | 16 --- chrome/test/BUILD.gn | 1 - .../background_sync_browsertest.html | 12 --- .../background_sync/background_sync_browsertest.js | 29 ------ .../background_sync_service_worker.js | 14 --- components/keep_alive_registry/keep_alive_types.cc | 2 - components/keep_alive_registry/keep_alive_types.h | 3 - .../background_sync/background_sync_manager.cc | 64 ++---------- .../background_sync/background_sync_manager.h | 16 +-- .../public/browser/background_sync_controller.h | 13 --- content/test/mock_background_sync_controller.cc | 5 - content/test/mock_background_sync_controller.h | 2 - 15 files changed, 13 insertions(+), 301 deletions(-) commit 596c6057c45515596134a4fd18dd0309f98e8857 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Apr 17 15:33:08 2019 +0000 Roll src-internal 91e5b46b8d77..d7ea5259bb00 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91e5b46b8d77..d7ea5259bb00 Created with: gclient setdep -r src-internal@d7ea5259bb00 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=etiennep@chromium.org,hayato@chromium.org,atotic@chromium.org Change-Id: I47cb99106785a73c0e063929df27fd3c9f56b4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571533 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651726} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d6b289a095e6cd8fc5050c5c764ede3ac87ee312 Author: Michael Ludwig <michaelludwig@google.com> Date: Wed Apr 17 15:30:54 2019 +0000 Use proper content area for right/bottom tiles Bug: 953283 Change-Id: I978fd4fc5c0830b7c03d885889d6435b313a983a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571012 Reviewed-by: Jonathan Backer <backer@chromium.org> Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#651725} components/viz/service/display/skia_renderer.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 48b4d96c7d4f97ee61dd56a19ae924d6b7b75e79 Author: Lukasz Suder <lsuder@google.com> Date: Wed Apr 17 15:29:53 2019 +0000 [Autofill Assistant] Change OnBoarding version based on experiment. Experiment Ids are passed to the AssistantOnboardingCoordinator, where they are used to pick the onboarding variant. Bug: 806868 Bug: b/123679241 Change-Id: I0c897c0973e49bf49d134a7d21764246779c7a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570019 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#651724} .../AssistantBottomBarCoordinator.java | 4 +- .../autofill_assistant/AssistantCoordinator.java | 4 +- .../AssistantOnboardingCoordinator.java | 10 +++-- .../AutofillAssistantUiController.java | 4 +- .../AutofillAssistantUiTest.java | 3 +- .../AutofillAssistantClient.java | 13 +++--- .../AutofillAssistantFacade.java | 48 ++++++++++++++++++---- .../android/autofill_assistant/client_android.cc | 3 +- .../android/autofill_assistant/client_android.h | 8 ++-- .../autofill_assistant/ui_controller_android.cc | 5 ++- .../autofill_assistant/ui_controller_android.h | 6 ++- 11 files changed, 75 insertions(+), 33 deletions(-) commit 417baf2782e0e060ea3bd96d0aab4e7714387ed4 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Apr 17 15:29:50 2019 +0000 Fix flakiness in TwoClientSearchEnginesSyncTest Recent investigations surfaced an issue outside tests, with a problematic scenario leading to duplicates if two clients enable sync simultaneously (or very close in time). The underlying issue is that prepopulated search engines use random GUIDs as sync identifiers, and this can lead to both clients committing creations, if the downloaded remote data doesn't contain such search engines (which can happen if sync is enabled simultaneously). While this underlying issue gets addressed, we work it around in tests by waiting until the two clients converge (with or without duplicates). Bug: 953650,953711 Change-Id: I36f435099889fbcb3c3d9f2eba2c215ccef786dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1572118 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#651723} .../two_client_search_engines_sync_test.cc | 60 +++++++++++++++++----- 1 file changed, 48 insertions(+), 12 deletions(-) commit b9d9f0c2b22df8be6ba597958a6afdf007478805 Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Wed Apr 17 15:23:03 2019 +0000 Do not update AppList from AppSearchProvider::ViewClosing() Calling ClearResults sends updated search results to Ash and ultimately causes a DCHECK (see linked bug). Introduce a version of this method that does not send an update. Bug: 948441 Test: type "Set" in search box, hit Enter - no DCHECK Change-Id: I1f8fd9598841c34b17396e74be1dddb6ece1dbf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570569 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#651722} chrome/browser/ui/app_list/search/app_search_provider.cc | 2 +- chrome/browser/ui/app_list/search/search_provider.cc | 4 ++++ chrome/browser/ui/app_list/search/search_provider.h | 4 ++++ 3 files changed, 9 insertions(+), 1 deletion(-) commit cbe74a999fed797542e0d2bc6284382415600f09 Author: Charlene Yan <cyan@chromium.org> Date: Wed Apr 17 15:22:46 2019 +0000 Fix to disable bubble dialogs from dragging. Non bubble dialogs can be dragged by clicking in some arbitrarily-sized top part of the dialog. Dragging is now agnostic of whether the title is visible. For example, EnterpriseStartupDialogView does not show a window title, but would want to remain draggable. Bug: 951693 Change-Id: Icefb1d1ed49ee97bd6984c7fad417170c3458396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566684 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#651721} .../bubble/bubble_dialog_delegate_view_unittest.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 8 ++-- ui/views/window/dialog_delegate_unittest.cc | 47 ++-------------------- 3 files changed, 8 insertions(+), 49 deletions(-) commit d1574c2e22476aace7b6f19bb8d940332c30250a Author: Sahel Sharify <sahel@chromium.org> Date: Wed Apr 17 15:20:50 2019 +0000 Allow landscape icons to be used in Payment Handler header. This cl has the following changes: 1- ManifestIconSelector::FindBestMatchingIcon considers square icons only, ManifestIconSelector::FindBestMatchingLandscapeIcon is added to provide GURLS for landscape icons as well. 2- Change ManifestIconDownloader to download landscape icons as well. Bug: 879741 Change-Id: If620b0da64735b6ce902e9ee73eafb04de79a481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544139 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#651720} .../payment_handler_web_flow_view_controller.cc | 14 +- .../views/payments/payment_request_views_util.cc | 12 +- .../content/installable_payment_app_crawler.cc | 17 +- .../browser/manifest/manifest_icon_downloader.cc | 51 +++- .../manifest/manifest_icon_downloader_unittest.cc | 113 +++++--- .../browser/payments/payment_app_info_fetcher.cc | 6 +- .../payments/payment_instrument_icon_fetcher.cc | 6 +- content/public/browser/manifest_icon_downloader.h | 18 +- .../common/manifest/manifest_icon_selector.cc | 31 ++- .../manifest/manifest_icon_selector_unittest.cc | 308 ++++++++++++--------- .../common/manifest/manifest_icon_selector.h | 13 +- 11 files changed, 370 insertions(+), 219 deletions(-) commit da677d331996b570e44604c980a86bfc871b89b3 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Apr 17 15:07:09 2019 +0000 MacViews: Don't try to reorder child views without a root view Under some circumstances, this can be called while the widget is destructing. See linked bug for details. It would be ideal to, in addition to this, prune whatever code path is making this happen from running while the view hierarchy is destructing, but the crash stack has too much inlining to easily figure out exactly what that path is. Bug: 951518 Change-Id: Icc6386aee63456c58f7cb356c5e7fd6b5a30ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569523 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#651719} ui/views/cocoa/bridged_native_widget_host_impl.mm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit cae6e6ebf4e86b4fb7a6733b5a15eaa836e750c7 Author: Ken Rockot <rockot@google.com> Date: Wed Apr 17 15:05:04 2019 +0000 Revert "Reland "[mojo] Shared message ordering for C++ bindings"" This reverts commit 4aff7056adba1f3e0e8466a02172ec234bc227d7. Reason for revert: Abandoning the effort to stuff message ordering into Mojo core. https://docs.google.com/document/d/14kPFSg-Wpfj--AzKKvhjMvtukoQSGQVpGxON5TqVVs0/edit# Original change's description: > Reland "[mojo] Shared message ordering for C++ bindings" > > This is a reland of a095e3b2b24e25cec601f85253520e3df038e2d5 > > PS2 is the fix, PS1 the original CL. This was just some uninitialized > padding bytes in a control message. > > Original change's description: > > [mojo] Shared message ordering for C++ bindings > > > > Implements support for the [ShareMessageOrder] attribute on mojom method > > parameters and struct fields. If the field or parameter is a > > pending_receiver or pending_remote type (or a container of one of those > > types), its handle will be attached to the encompassing serialized > > message with the new MOJO_APPEND_MESSAGE_DATA_HANDLE_FLAG_SPLICE flag > > set, meaning that interface pipe will begin to share message ordering > > with the sending pipe after message transmission. > > > > This support should be sufficient to fully replace usage of associated > > interfaces while eliminating all bindings-layer encoding and routing > > support for multiplexed pipes. > > > > See bug for design doc link. > > > > Bug: 941809 > > Change-Id: I5629497705e4e747f9d63ef8198091d7917a41a4 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548611 > > Commit-Queue: Ken Rockot <rockot@google.com> > > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648747} > > Bug: 941809 > Change-Id: Ief79131f13e4a8b08232aafb100c466b8750fc29 > TBR: oksamyt@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559256 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#649027} TBR=rockot@google.com,oksamyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941809 Change-Id: Ib50135c63fc2eb93205ede22a2af89e283010e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570538 Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#651718} mojo/core/ports/event.cc | 1 - mojo/public/cpp/bindings/lib/message.cc | 54 ++--- .../cpp/bindings/lib/serialization_context.cc | 10 - .../cpp/bindings/lib/serialization_context.h | 24 -- mojo/public/cpp/bindings/message.h | 10 - mojo/public/cpp/bindings/tests/BUILD.gn | 3 - .../bindings/tests/share_message_order_unittest.cc | 254 --------------------- mojo/public/interfaces/bindings/tests/BUILD.gn | 8 - .../bindings/tests/share_message_order.test-mojom | 40 ---- .../generators/cpp_templates/struct_macros.tmpl | 9 - .../bindings/generators/mojom_cpp_generator.py | 4 +- .../tools/bindings/pylib/mojom/generate/module.py | 59 +---- 12 files changed, 19 insertions(+), 457 deletions(-) commit d8de80a221559443b05f2bcb9b5e7891efb1e80e Author: Rayan Kanso <rayankans@chromium.org> Date: Wed Apr 17 15:04:13 2019 +0000 [Background Sync] Forward fix flaky UKM test. The test was checking the number of UKM entries, but it turns out that unrelated evetns are sometimes logged making the test flaky. The test now only checks metrics related to the test. Bug: 948811 Change-Id: Ib64b50f02c9d10c8c889a74e15b307e8064f2200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570174 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#651717} .../background_sync/background_sync_metrics_browsertest.cc | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit bb19e124cf84849a092a7ed080fb574beac11302 Author: May Lippert <maybelle@chromium.org> Date: Wed Apr 17 15:02:11 2019 +0000 Create watchlist for changes to forked browser settings BUG=none Change-Id: Ib25823d69cc0e5926ecb1780ac5debe6af752e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570689 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#651716} WATCHLISTS | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 14c052d7be555c748f77c851c30488ac2ae7c657 Author: James Cook <jamescook@chromium.org> Date: Wed Apr 17 14:57:23 2019 +0000 chromeos: Add test for SettingsWindowManager with SplitSettings feature With SplitSettings, browser settings opens in a tab, but OS settings open in a window. Delete an old test that was never running. The test was left over from a time when we had experimental support for settings-in-a-window on non-Chrome OS platforms. That support was removed in 2017. Bug: 950007 Test: added to browser_tests Change-Id: I8c2738263cbb43530fdcd6119aab2a2e2d088446 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570577 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#651715} ...settings_window_manager_browsertest_chromeos.cc | 108 +++++++-------------- 1 file changed, 37 insertions(+), 71 deletions(-) commit 398af01d36d52a4a275ed59eed2d1dd44820aee5 Author: Ryan Sleevi <rsleevi@chromium.org> Date: Wed Apr 17 14:57:14 2019 +0000 Remove the Legacy Symantec PKI policy Remove the Enterprise Policy for enabling the Legacy Symantec PKI. Certificates issued directly by the legacy PKI will no longer be trusted by default in any version of Chrome. Support for the SSLConfig option is still maintained for embedders, such as Android WebView, which may wish to adhere to locally defined or system-wide policies around trust. Bug: 953321 Change-Id: I15cb23734be19e3ec53af0e9adcc49102fe06550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569515 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651714} .../configuration_policy_handler_list_factory.cc | 3 -- chrome/browser/ssl/ssl_browsertest.cc | 21 ------------ .../browser/ssl/ssl_config_service_manager_pref.cc | 9 ----- .../ssl_config_service_manager_pref_unittest.cc | 38 ---------------------- chrome/common/pref_names.cc | 6 ---- chrome/common/pref_names.h | 1 - chrome/test/data/policy/policy_test_cases.json | 8 +---- components/policy/resources/policy_templates.json | 2 +- 8 files changed, 2 insertions(+), 86 deletions(-) commit 756dd962b1a242a64b45bde73783b36b7c5954b1 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Wed Apr 17 14:53:37 2019 +0000 interactive_ui_tests: Use rpath for non-component build So that interactive_ui_tests running on ChromeOS device could find libassistant.so for branded build. This eliminates the need to use LD_LIBRARY_PATH to run the test. Bug: 939010 Change-Id: If6f2f14fff78d68132444db6f21e070a25558f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570532 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#651713} chrome/test/BUILD.gn | 3 +++ 1 file changed, 3 insertions(+) commit 4fed2b62679dc0edafc733b02af7d34f1988a1d8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 14:52:01 2019 +0000 Roll src/third_party/depot_tools 7e7523be4e21..e72279d25f75 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e7523be4e21..e72279d25f75 git log 7e7523be4e21..e72279d25f75 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 hferreiro@igalia.com Keep warning about unversioned trees until removed Created with: gclient setdep -r src/third_party/depot_tools@e72279d25f75 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id0231a8839a554befbcd12e3e06ed968d01c78f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571446 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651712} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe68b0d8c1b652dc7b9d4faea9d808c508065af0 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Apr 17 14:51:41 2019 +0000 Eliminate DBusThreadManager dependency from BluezDBusManager This also includes a bit of cleanup: * Explicit fake initialization for bluez::BluezDBusManager * BluezDBusManager::Initialize() moved to dbus_helper.cc with other dbus client init * BluezDBusThreadManager::Initialize() is called from BluezDBusManager::Initialize() on both linux and cros (it was called from outside Initialize() in all cases anyway). Bug: 951017 Change-Id: I3ad2d6e432b4305982ae7c093965233f3ba27748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1560385 Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#651711} ash/ash_service.cc | 7 +++--- .../content/client/shell_browser_main_parts.cc | 2 +- ash/test/ash_test_helper.cc | 2 +- chrome/browser/chrome_browser_main_linux.cc | 3 +-- .../chromeos/chrome_browser_main_chromeos.cc | 4 ---- chrome/browser/chromeos/dbus/dbus_helper.cc | 4 ++++ .../test/view_event_test_platform_part_chromeos.cc | 2 +- content/shell/browser/shell_browser_main_parts.cc | 2 +- device/bluetooth/BUILD.gn | 5 +---- device/bluetooth/dbus/bluez_dbus_manager.cc | 25 ++++++++++++++-------- device/bluetooth/dbus/bluez_dbus_manager.h | 18 ++++++++++------ .../dbus/dbus_bluez_manager_wrapper_linux.cc | 3 +-- .../shell/browser/shell_browser_main_parts.cc | 7 +++--- 13 files changed, 45 insertions(+), 39 deletions(-) commit 6647da61ef03f4faec45a31e8ef6d6e4968d87bd Author: Alexandre Frechette <frechette@chromium.org> Date: Wed Apr 17 14:48:02 2019 +0000 Use .bin geolanguage data. Enforce geolanguage data test as a unittest. Bug: 952327 Change-Id: Ifb71b9f7b62c2d17cf8f89bdeec1be49962ff8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1566413 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#651710} .gitattributes | 1 + .gitignore | 1 - .../browser/ulp_language_code_locator/BUILD.gn | 24 +- ...e-data_rank0.txt => geolanguage-data_rank0.bin} | Bin ...e-data_rank1.txt => geolanguage-data_rank1.bin} | Bin ...e-data_rank2.txt => geolanguage-data_rank2.bin} | Bin 7510 -> 7511 bytes .../ulp_language_code_locator/update_data.sh | 2 +- .../test/data/language/celltolang-data_rank0.csv | 32223 +++++++++++++++++++ .../test/data/language/celltolang-data_rank1.csv | 24508 ++++++++++++++ .../test/data/language/celltolang-data_rank2.csv | 15098 +++++++++ 10 files changed, 71835 insertions(+), 22 deletions(-) commit d59c8e3e4549ac88e0f9d5071f32ee8191bfb1a1 Author: Alexandre Frechette <frechette@chromium.org> Date: Wed Apr 17 14:47:56 2019 +0000 Adding some padding at the end of languages' info strings. One Chrome OS and Windows, we sometimes have a button right next a language's info strings in the language settings page. This adds some spacing to make it a bit more roomy and avoid the two being to close to each other. SCREENSHOT: https://drive.google.com/open?id=1q2zuKIBJAGI0TH8Bq91K43IbWYuB01Ld Bug: 931587 Change-Id: Ia51c0564962f9a8b9eb0d537882ada5a37f25e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565077 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Alexandre Frechette <frechette@chromium.org> Cr-Commit-Position: refs/heads/master@{#651709} .../browser/resources/settings/languages_page/languages_page.html | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 9625b393c91469dbc4f2c9b019cd042ce3c60be1 Author: Clemens Arbesser <arbesser@google.com> Date: Wed Apr 17 14:42:50 2019 +0000 [Autofill Assistant] Fixed bug where the PR continue button was sometimes not working. In particular, if no or only incomplete payment methods were stored in Chrome, the Autofill Assistant PR would always disable the continue button, even if the script did not ask for the payment method. This made it impossible to complete the flow in cases where the payment method section was never shown at all. Bug: b/130716232 Change-Id: Icd738f565a089378ba30275e1b60219e5f8d1c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571419 Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#651708} components/autofill_assistant/browser/controller.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit e8d814bbce188fc9227cee0d56b9c91cdf0ab698 Author: Stephane Zermatten <szermatt@chromium.org> Date: Wed Apr 17 14:40:33 2019 +0000 [Autofill Assistant] Track navigation state, wait for navigation to end. With this page, the controller tracks navigation state and makes it available to the script executor. The script executor then: - report errors as navigation error when navigation has failed. - report navigation start and end to action results, to help debugging - delays waiting when navigation is in progress. This affects WaitForDom as well as all actions that use ShortWaitForElement. The goal of this change is to make it clearer what errors are navigation errors and hopefully decrease the number of errors due to slow network. This should improve the situation on unmodified scripts. This change does not yet provide ways for waiting for navigation to have happened or for the page to have become interactive. Bug: b/129115591 Change-Id: I33f33d26062cd58fbfdeaf56beb5d9d2fd423f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1561104 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#651707} .../autofill_assistant/browser/client_status.cc | 26 ++- .../autofill_assistant/browser/client_status.h | 19 +- .../autofill_assistant/browser/controller.cc | 60 +++++- components/autofill_assistant/browser/controller.h | 14 ++ .../browser/controller_unittest.cc | 188 +++++++++++++++--- .../browser/fake_script_executor_delegate.cc | 16 ++ .../browser/fake_script_executor_delegate.h | 19 ++ .../autofill_assistant/browser/retry_timer.h | 5 +- .../browser/retry_timer_unittest.cc | 25 +++ .../autofill_assistant/browser/script_executor.cc | 123 +++++++++--- .../autofill_assistant/browser/script_executor.h | 33 ++-- .../browser/script_executor_delegate.h | 38 ++++ .../browser/script_executor_unittest.cc | 220 ++++++++++++++++++++- .../autofill_assistant/browser/service.proto | 34 +++- .../autofill_assistant/browser/web_controller.cc | 4 +- 15 files changed, 731 insertions(+), 93 deletions(-) commit 62f8f7a64743bd3154ecd7960e715ae47c425855 Author: Yann Dago <ydago@chromium.org> Date: Wed Apr 17 14:31:55 2019 +0000 Mark ExtensionInstallListsMergeEnabled policy as future Change-Id: I1b5b832520a192fddbc08c8046b12984b4557349 Bug: 953296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569747 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#651706} components/policy/resources/policy_templates.json | 1 + 1 file changed, 1 insertion(+) commit 227502412a1add2a71d933611fe6d5db47d95d6b Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Apr 17 14:25:12 2019 +0000 [AF Wallet Metadata] Add single-client tests for conversion of addresses This CL adds tests for address conversion. It is part of invastigation of a discrepancy between the Directory implementation and the USS implementation. Bug: 953693 Change-Id: Ice25a8e8afd40714ebd338e1df0f3599939adf86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570033 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651705} .../integration/single_client_wallet_sync_test.cc | 92 ++++++++++++++++++++++ .../browser/sync/test/integration/wallet_helper.cc | 51 ++++++++++-- .../browser/sync/test/integration/wallet_helper.h | 23 +++++- .../browser/webdata/autofill_sync_bridge_util.cc | 77 +++++++++--------- .../browser/webdata/autofill_sync_bridge_util.h | 4 + 5 files changed, 200 insertions(+), 47 deletions(-) commit 06cf5ff92bdf80b170b64da492c77aa6b971fbae Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Apr 17 14:21:08 2019 +0000 [Sync::USS] Implementing NigoriLocalChangeProc. in NigoriModelTypeProc. Bug: 922900 Change-Id: I6e95b0221fd043bb836795a74ecb37510c11a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530766 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#651704} components/sync/BUILD.gn | 2 + components/sync/nigori/DEPS | 2 + .../sync/nigori/nigori_local_change_processor.cc | 19 ++++ .../sync/nigori/nigori_local_change_processor.h | 25 +++-- .../sync/nigori/nigori_model_type_processor.cc | 73 +++++++++++-- .../sync/nigori/nigori_model_type_processor.h | 26 +++-- .../nigori/nigori_model_type_processor_unittest.cc | 120 +++++++++++++++++++++ 7 files changed, 247 insertions(+), 20 deletions(-) commit 33147733e27b950a33b9ff1078e82675cb05e1f7 Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Wed Apr 17 14:12:57 2019 +0000 Don't compute style for disconnected CorrespondingElement(). When removing a corresponding element that has never been attached, the instance mapping is not yet set up, so the <use> shadow tree isn't invalidated. This causes crashes if we attempt to compute the style for a disconnected element. This is a work-around for issue 943955 until we have a proper solution (issue 953263). R=fs@opera.com BUG=943955,953263 Change-Id: If116b83bf2fca142e7d06cc29e114c6cd6db814a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569136 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#651703} third_party/blink/renderer/core/BUILD.gn | 1 + third_party/blink/renderer/core/svg/svg_element.cc | 3 +- .../blink/renderer/core/svg/svg_element_test.cc | 55 ++++++++++++++++++++++ 3 files changed, 58 insertions(+), 1 deletion(-) commit 925d2e663d2ea5ecd957dffa993851b9a9153e6a Author: Henrik Boström <hbos@chromium.org> Date: Wed Apr 17 14:11:07 2019 +0000 Ship RTCDtlsTransport and RTCIceTransport. Intent to Ship: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/blink-dev/bm-eQd1fKRQ/o3DqG4wxEAAJ The intent covers both interfaces, but note that there is a separate intent to experiment with RTCQuicTransport and RTCIceTransport here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xXf23VY_8uM This CL does ship the RTCIceTransport constructor that is part of the RTCIceTransport extension due to limitations of the IDL bindings. The alternative would have been to throw an exception if the constructor is invoked (which is the only thing that we don't need to ship), but this may do more harm than good. The RTCIceTransport is not useful on its own and being able to construct it now does not enable any QUIC usage. Other extension methods are still behind flag. This CL also makes some minor changes: - rtcp_transport is renamed rtcpTransport, this was a typo. - getRemoteCertificates() is removed because it is not implemented (yet!). Bug: 907849 Change-Id: I8cc90cc30545c48c3cae290da20a588398e81dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569012 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#651702} .../modules/peerconnection/rtc_dtls_transport.cc | 6 ----- .../modules/peerconnection/rtc_dtls_transport.h | 3 --- .../modules/peerconnection/rtc_dtls_transport.idl | 3 ++- .../modules/peerconnection/rtc_ice_transport.cc | 1 + .../modules/peerconnection/rtc_ice_transport.idl | 11 ++++---- .../modules/peerconnection/rtc_rtp_receiver.cc | 2 +- .../modules/peerconnection/rtc_rtp_receiver.h | 2 +- .../modules/peerconnection/rtc_rtp_receiver.idl | 2 +- .../modules/peerconnection/rtc_rtp_sender.cc | 2 +- .../modules/peerconnection/rtc_rtp_sender.h | 2 +- .../modules/peerconnection/rtc_rtp_sender.idl | 2 +- .../platform/runtime_enabled_features.json5 | 2 +- .../webrtc/idlharness.https.window-expected.txt | 14 +++++----- .../global-interface-listing-expected.txt | 30 ++++++++++++++++++++++ .../webrtc/idlharness.https.window-expected.txt | 8 +++--- .../global-interface-listing-expected.txt | 5 ++-- 16 files changed, 58 insertions(+), 37 deletions(-) commit 344017b45ac7c4c94742ec577fe3babc0dfd271a Author: Guillaume Jenkins <gujen@google.com> Date: Wed Apr 17 13:59:35 2019 +0000 Update Persian dictionary - Update Persian dictionary to version 8-0 - Roll src/third_party/hunspell_dictionaries/ 83f465973..3874188bd (1 commit) https://chromium.googlesource.com/chromium/deps/hunspell_dictionaries.git/+log/f7ce90e84f5a..83f4659730b4 $ git log 83f465973..3874188bd --date=short --no-merges --format='%ad %ae %s' 2019-04-12 mostafa.sedaghat Update Persian dictionay Created with: roll-dep src/third_party/hunspell_dictionaries Change-Id: I4d8937f8555b51b5d3aaeab237e820152bd8a60c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570285 Reviewed-by: manuk hovanesian <manukh@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#651701} AUTHORS | 1 + DEPS | 2 +- components/spellcheck/common/spellcheck_common.cc | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) commit 7ba68304700fa2a04cf32a583b5edfde1ab41b40 Author: Mugdha Lakhani <nator@chromium.org> Date: Wed Apr 17 13:57:06 2019 +0000 [Background Sync] Keep the browser alive When the (one-shot) sync event can be fired at the time of registering. The keepalive is cancelled after the first attempt of firing the event has completed, regardless of whether it was successful. Bug: 949486 Change-Id: I6a1f6bfe2bdd820bc8fc05828e8f226922323368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550833 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#651700} .../browser/background/background_mode_manager.cc | 2 + .../background_sync/background_sync_browsertest.cc | 115 +++++++++++++++++++++ .../background_sync_controller_impl.cc | 20 ++++ .../background_sync_controller_impl.h | 16 +++ chrome/test/BUILD.gn | 1 + .../background_sync_browsertest.html | 12 +++ .../background_sync/background_sync_browsertest.js | 29 ++++++ .../background_sync_service_worker.js | 14 +++ components/keep_alive_registry/keep_alive_types.cc | 2 + components/keep_alive_registry/keep_alive_types.h | 3 + .../background_sync/background_sync_manager.cc | 64 ++++++++++-- .../background_sync/background_sync_manager.h | 16 ++- .../public/browser/background_sync_controller.h | 13 +++ content/test/mock_background_sync_controller.cc | 5 + content/test/mock_background_sync_controller.h | 2 + 15 files changed, 301 insertions(+), 13 deletions(-) commit c1d1c4af2990ff086d1482dc26d58501dff3d099 Author: Yann Dago <ydago@chromium.org> Date: Wed Apr 17 13:40:51 2019 +0000 Remove feature flag link-managed-notice-to-management-page Bug: 953329 Change-Id: I50bced6cc6f71e0359c78188afd8883e6b0de39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569518 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#651699} chrome/browser/about_flags.cc | 6 ------ chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- chrome/browser/ui/browser_command_controller.cc | 8 +------- chrome/browser/ui/webui/managed_ui_handler.cc | 10 +--------- chrome/common/chrome_features.cc | 4 ---- chrome/common/chrome_features.h | 2 -- testing/variations/fieldtrial_testing_config.json | 17 ----------------- 9 files changed, 2 insertions(+), 59 deletions(-) commit 1b6db40331b2245bad669ccee0c00b6a8d75fa3f Author: Yann Dago <ydago@chromium.org> Date: Wed Apr 17 13:40:22 2019 +0000 Management WebUI: Remove duplicate link to management page from settings Bug: 879146 Change-Id: Id461109a2fff5b3d077158abefb638dd5527c7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569511 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#651698} .../settings/settings_main/settings_main.html | 20 ------------- .../settings/settings_main/settings_main.js | 8 ----- .../test/data/webui/settings/settings_main_test.js | 34 ---------------------- 3 files changed, 62 deletions(-) commit 7769b86b3fb912a490a00661b396d3953c141516 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Wed Apr 17 13:35:55 2019 +0000 ThreadPool: Ensure COM is not initialized in PlatformNativeWorkerPoolWin with WorkerEnvironment::None Upon destruction, a PTP_POOL object might not destroy the threads it created, and another PTP_POOL object created in the same process might reuse the old threads. Consequently, it is possible to be on a COM initialized thread even if PlatformNativeWorkerPoolWin was created with WorkerEnvironment::NONE. In this case, COM is uninitialized by explicitly resetting the ScopedCOMInitializer in thread local storage. Note that previous behaviour did not cause any issues in production, since at most one PlatformNativeWorkerPoolWin was created in a process. However, in ThreadPoolWorkerPoolTest, one PlatformNativeWorkerPoolWin is created per test. A test that expected COM to be unintialized was flaky, as a COM initialized thread created by a previous test was being reused. Bug: 952926 Change-Id: I8239b57af1638009a8e317645cda6cf49944a710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570650 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#651697} .../thread_pool/platform_native_worker_pool_win.cc | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) commit 217112d6ba4d6f1a70037b95383e793f8c695e84 Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Apr 17 13:35:50 2019 +0000 [MediaRecorder] Pause WebmMuxer only if not null There are some cases in which the muxer is null, which lead to crashes. Bug: 949046 Change-Id: I1525f290146f65e398c574d4149c9e30484ac91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569927 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#651696} content/renderer/media_recorder/media_recorder_handler.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 31b7a786e67fda7c14c91bbf14685d164cd1dc9c Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Apr 17 13:30:09 2019 +0000 media/gpu/test: Move CreateDmabufFrameFromVideoFrame to video_frame_helpers CreateDmabufDrameFromVideoFrame in video_encode_accelerator_unittest_helpers creates Dmabuf-backed VideoFrame from memory backed VideoFrame. It is not encoder test specific. In fact, image_processor_test would like to test Dmabuf backed video frame in input. Therefore, I move the function to video_frame_helpers. Additionally, the function uses texture_ref to create Dmabuf backed video frame. It can be replaced with CreatePlatformVideoFrame today. The part of copying plane is also wrong. I fixed that in this CL too. Bug: None Test: image_processor_unittest Test: video_encode_accelerator_unittest Test: video_decode_accelerator_unittest w/wo video_frame_validator Test: video_decode_accelerator_tests w/wo video_frame_validator Change-Id: Idc98e52297de0d8917f2c8bdb93626c61f9c8750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564350 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#651695} media/gpu/BUILD.gn | 3 +- media/gpu/test/BUILD.gn | 15 ---- .../test/image_processor/image_processor_client.cc | 4 +- media/gpu/test/texture_ref.cc | 8 -- media/gpu/test/texture_ref.h | 6 -- .../video_encode_accelerator_unittest_helpers.cc | 80 ------------------- .../video_encode_accelerator_unittest_helpers.h | 21 ----- media/gpu/test/video_frame_helpers.cc | 91 +++++++++++++++++----- media/gpu/test/video_frame_helpers.h | 21 ++--- media/gpu/video_encode_accelerator_unittest.cc | 11 ++- 10 files changed, 93 insertions(+), 167 deletions(-) commit 8be8a002261d1fbfdd5ffc28d997ac987c775a3f Author: Niels Möller <nisse@chromium.org> Date: Wed Apr 17 13:29:49 2019 +0000 Delete CodecSpecificInfo argument from webrtc::VideoDecoder::Decode Bug: webrtc:10379, webrtc:9304 Change-Id: If92d7162e942a33a28660787140605e22c247c09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564167 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#651694} content/renderer/media/webrtc/rtc_video_decoder.cc | 8 ++--- content/renderer/media/webrtc/rtc_video_decoder.h | 1 - .../media/webrtc/rtc_video_decoder_adapter.cc | 12 ++++---- .../media/webrtc/rtc_video_decoder_adapter.h | 2 +- .../webrtc/rtc_video_decoder_adapter_unittest.cc | 16 +++++----- .../media/webrtc/rtc_video_decoder_factory.cc | 4 +-- .../media/webrtc/rtc_video_decoder_unittest.cc | 34 +++++++++------------- 7 files changed, 29 insertions(+), 48 deletions(-) commit 3836a3555cdf410b6604f0517a451882bb436836 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 17 13:22:58 2019 +0000 flags: remove disable-audio-support-for-desktop-share Bug: None Change-Id: I595d5e2c5b201f103c1812db52bdb9c84f31a7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568827 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651693} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag-metadata.json | 5 ----- .../media/webrtc/webrtc_getdisplaymedia_browsertest.cc | 18 +++++++----------- .../renderer_host/media/media_stream_manager.cc | 15 +-------------- content/public/common/content_switches.cc | 4 ---- content/public/common/content_switches.h | 1 - 6 files changed, 8 insertions(+), 39 deletions(-) commit 1281a9aec765f4cf04b855775267c8d5e08a32c1 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Apr 17 13:18:08 2019 +0000 flags: remove disable-captive-portal-bypass-proxy This retains the preference controlling this feature, but removes the flag and the switch the flag is connected to. Bug: 953690 Change-Id: Id8d477eac23434c8fe165532dab34ecade8fd47a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569645 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#651692} chrome/browser/about_flags.cc | 7 ------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 7 ------- chrome/browser/flag_descriptions.h | 3 --- .../ui/ash/network/network_portal_notification_controller.cc | 9 ++------- chromeos/constants/chromeos_switches.cc | 4 ---- chromeos/constants/chromeos_switches.h | 2 -- 7 files changed, 2 insertions(+), 35 deletions(-) commit 6541a64f7801cd7f3560958334935cc06d63df07 Author: Oleg Davydov <burunduk@chromium.org> Date: Wed Apr 17 13:17:33 2019 +0000 Increase fetch priority for policy-forced extensions When fetch extensions from chrome web store, there is a header which indicated pritority (or “interactivity”) of extension fetch. Usually it is high (FOREGROUND) when user manually clicked “Add to Chrome” in the store, and low (BACKGROUND) otherwise. Background fetches could be throttled on a store server-side (eg. due to bandwidth limit), which is perfectly OK for background updates, but is harmful for new installs (which can occur not only because of user click, but also because of extension forcelist policy). Therefore we have to set priority to foreground for policy-based extension downloads. Bug: 904600, 917700 Change-Id: I25ac15e71398f833261cd0cb1116785fcf7a241d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569019 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#651691} chrome/browser/extensions/extension_service.cc | 7 ++++ .../extensions/extension_service_unittest.cc | 49 +++++++++++++++++++++- .../extensions/pending_extension_manager.cc | 9 ++++ .../browser/extensions/pending_extension_manager.h | 3 ++ .../extensions/updater/extension_updater.cc | 5 +++ .../browser/extensions/updater/extension_updater.h | 4 ++ .../updater/extension_downloader_test_helper.cc | 7 ++++ .../updater/extension_downloader_test_helper.h | 4 ++ 8 files changed, 87 insertions(+), 1 deletion(-) commit c53b052a4335b57665112edffe5efc0e6dd1fcc3 Author: Marc Treib <treib@chromium.org> Date: Wed Apr 17 12:59:06 2019 +0000 Remove SyncService::IsFirstSetupInProgress It had a trivial implementation (IsSetupInProgress() && !IsFirstSetupComplete) which is now just moved to the (few) call sites. IMO this generally makes it clearer what is going on (e.g. some of the callers really care about only one of the two bits). Bug: 839834 Change-Id: I94b132e9db19b9afca6ac8ecd13b52dbdd93e0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569140 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#651690} chrome/browser/sync/sync_ui_util.cc | 2 +- chrome/browser/sync/sync_ui_util.h | 2 +- chrome/browser/ui/webui/settings/people_handler.cc | 15 +++++++++------ .../unified_consent/unified_consent_browsertest.cc | 3 ++- components/sync/driver/sync_service.cc | 4 ---- components/sync/driver/sync_service.h | 12 ------------ components/unified_consent/unified_consent_service.cc | 8 ++++---- ios/chrome/browser/sync/sync_setup_service.cc | 12 ++++++------ 8 files changed, 23 insertions(+), 35 deletions(-) commit f3cac83fbd14f278b4622171a2e7355dd1bf2961 Author: Matthias Körber <koerber@google.com> Date: Wed Apr 17 12:55:02 2019 +0000 Implemented votes for crowd-sourcing special symbol requirements for password generation. Bug: 953668, 552420 Change-Id: I84033515393f540068d9576b5fe4b2e131a06559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1567751 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#651689} components/autofill/core/browser/form_structure.cc | 7 ++- components/autofill/core/browser/form_structure.h | 24 +++++++++- .../autofill/core/browser/proto/server.proto | 9 +++- .../core/browser/votes_uploader.cc | 53 ++++++++++++++++++---- .../password_manager/core/browser/votes_uploader.h | 4 +- .../core/browser/votes_uploader_unittest.cc | 47 ++++++++++++++++++- 6 files changed, 130 insertions(+), 14 deletions(-) commit dea62f7b1eb96fee1c5f2d45b912e3f9b4fee541 Author: Henrik Boström <hbos@chromium.org> Date: Wed Apr 17 12:40:19 2019 +0000 Interpret getStats(callback, nonsense) as getStats(callback). This fixes the regression described in the referenced bug. The rtc_peer_connection.idl used to rely on [LegacyInterfaceTypeChecking] which would make invalid second arguments, such as the common misuse of an "errorCallback", be accepted by ignoring the second argument. When this was removed, this caused regressions in popular apps that incorrectly assumed the second argument was also a callback. In order to not break apps, this CL updates the custom bindings logic to allow nonsense second arguments by ignoring them instead of throwing TypeError. This continues not to inform misuses of the legacy API, but making this API more type-friendly would require more use counters and deprecation warnings. Deprecation warnings can wait until we are ready to remove the legacy API altogether. Bug: 953512 Change-Id: Ie211cf8a4921812e5d243a513fbd95b224885440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570172 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#651688} .../modules/peerconnection/rtc_peer_connection.cc | 60 ++++++++++++---------- .../modules/peerconnection/rtc_peer_connection.h | 17 +++--- .../modules/peerconnection/rtc_peer_connection.idl | 20 ++++---- ...RTCPeerConnection-getStats-overrides.https.html | 5 +- .../RTCPeerConnection-stats-expected.txt | 9 ++++ .../peerconnection/RTCPeerConnection-stats.html | 12 ++++- 6 files changed, 73 insertions(+), 50 deletions(-) commit cac1e737825fafc0787b1b057381733027d5c9ea Author: Shawn Anastasio <shawnanastasio@gmail.com> Date: Wed Apr 17 12:37:36 2019 +0000 [blink] Introduce support for ppc64 This commit introduces support for the ppc64 architecture to blink. Included is an assembly implementation of PushAllRegisters written by Dan Horák and myself, a slight modification to the heap to disable guard pages on ppc64 written by Timothy Pearson, and minor BUILD.gn changes. This change is part of the effort to upstream a set of patches that allow chromium to build and run on ppc64le hosts available here: https://wiki.raptorcs.com/wiki/Porting/Chromium Change-Id: I0afb7b12c4cdb8b04012e672b2fa2409c3ef2a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554650 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#651687} .../blink/renderer/platform/heap/asm/BUILD.gn | 4 ++ .../platform/heap/asm/SaveRegisters_ppc64.S | 54 ++++++++++++++++++++++ .../blink/renderer/platform/heap/heap_page.h | 3 +- .../blink/renderer/platform/wtf/dtoa/utils.h | 2 +- 4 files changed, 61 insertions(+), 2 deletions(-) commit 62e41348cda06adc32c3b2e352e9f4895a8995f6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Apr 17 12:37:18 2019 +0000 Roll src/third_party/perfetto a38230fbc78d..7342ae0bd748 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/a38230fbc78d..7342ae0bd748 git log a38230fbc78d..7342ae0bd748 --date=short --no-merges --format='%ad %ae %s' 2019-04-17 treehugger-gerrit@google.com Merge "Fix crash in shmem with invalid size." Created with: gclient setdep -r src/third_party/perfetto@7342ae0bd748 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idb33fa3f12bcfa19303bd4c0a404e68d6a51da5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570238 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651686} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 50df5f0cb8d6177deae590cf83c5073f36b00d21 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Apr 17 12:34:28 2019 +0000 Update V8 to version 7.5.279.2 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/32513693..ca659d06 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ec8c5241a1307768be09d3d1a8c3ecb0426da47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1571067 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#651685} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1b480def933a7b0c4ad4f461c48bc305adcc4106 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Wed Apr 17 12:33:27 2019 +0000 Notification Delegation: Show ManagedBy in Page Info dialog and Site Settings. BUG: 945282 Change-Id: I8310b4939819d39f5cc7417e8cb195ac73772b91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569216 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#651684} .../page_info/PermissionParamsListBuilder.java | 38 ++++--- .../preferences/ChromeImageViewPreference.java | 12 ++- .../website/SingleWebsitePreferences.java | 113 +++++++++++++++------ .../java/strings/android_chrome_strings.grd | 6 ++ ...DS_WEBSITE_NOTIFICATION_MANAGED_BY_APP.png.sha1 | 1 + 5 files changed, 128 insertions(+), 42 deletions(-) commit 474e1affad0baf5a42f984b4ee102e8a725987e1 Author: Eric Seckler <eseckler@chromium.org> Date: Wed Apr 17 12:29:33 2019 +0000 perfetto: Actually intern source locations :) Turns out we were reemitting them on every event right now. Change-Id: I84738b35e4d14878fc56d30530facec19ab07a10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1569948 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#651683} .../cpp/perfetto/trace_event_data_source_unittest.cc | 14 +++++++++++++- .../cpp/perfetto/track_event_thread_local_event_sink.cc | 15 +++++++++------ 2 files changed, 22 insertions(+), 7 deletions(-) commit f0ca11a0057f4a450f9c63a730ce01a6ec14f37e Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Apr 17 12:18:13 2019 +0000 media/gpu/test: Add a class to do common set up for video tests VideoPlayerTestEnvironment does common set up for video tests, Ozone setup and vaapi sandbox initialization. This code will be reusable for other tests. I create CommonVideoTestEnvironment to do this common setup. Bug: None Test: video_decode_accelerator_tests Change-Id: I0d5b421670e93d2f1a3fcac33dbe87c0d6c5de2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564283 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#651682} media/gpu/test/BUILD.gn | 27 ++++--- .../video_player/video_player_test_environment.cc | 72 ------------------ .../video_player/video_player_test_environment.h | 29 +------ media/gpu/test/video_test_environment.cc | 88 ++++++++++++++++++++++ media/gpu/test/video_test_environment.h | 58 ++++++++++++++ 5 files changed, 165 insertions(+), 109 deletions(-) commit 341212ac6f0e86d8041c45b29bf6a508d6549b72 Author: Olya Kalitova <okalitova@chromium.org> Date: Wed Apr 17 12:17:33 2019 +0000 Add handling of cancelled PluginVm image downloads PluginVm image downloads that are tracked by download service when it is initialized are cancelled once client receives information about them. Before this CL information that these downloads were cancelled was propagated to PluginVmImageManager which we do not want. So this Cl stops this information for being propagated. Bug: 951338 Change-Id: I40b1a7251241cc99e7886dbb0437d6671e461ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1564126 Reviewed-by: Alex Oldemeier <aoldemeier@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#651681} .../plugin_vm/plugin_vm_image_download_client.cc | 19 ++++++++++++++++++- .../plugin_vm/plugin_vm_image_download_client.h | 4 ++++ 2 files changed, 22 insertions(+), 1 deletion(-) Updated tag 'tree_truth' (was cfef1fe44db2)