Back to build
Raw log | Switch to full mode | Login

{ "_more_changes": false, "_number": 217560, "branch": "master", "change_id": "I6972ae9e358c03d2ffaddb6a68b56e6fdec3288d", "created": "2018-10-26 00:59:48.000000000", "current_revision": "d89ec905226aa2894c3b5bed955616c8862a2c69", "deletions": 5, "has_review_started": true, "hashtags": [], "id": "zircon~master~I6972ae9e358c03d2ffaddb6a68b56e6fdec3288d", "insertions": 27, "labels": { "Code-Review": { "approved": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" } }, "Commit-Message-has-TEST-line": { "approved": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, "Commit-Message-has-tags": { "approved": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, "Commit-Queue": { "optional": true, "recommended": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } }, "No-Patches-File": { "approved": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } } }, "mergeable": true, "messages": [ { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-10-26T00:59:48Z", "id": "f38cde2b0eb1c46d035986c47b42169cadf4f860", "message": "Uploaded patch set 1.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5045, "email": "travisg@google.com", "name": "Travis Geiselbrecht" }, "date": "2018-10-27T04:42:26Z", "id": "d521c6dd4a51cd1332e81d73c6da5cc7d81af802", "message": "Patch Set 1:\n\nHmm, this actually seems wrong. It should be the MANAGE_THREAD write, though the code seems wrong. Will look into it.", "real_author": { "_account_id": 5045, "email": "travisg@google.com", "name": "Travis Geiselbrecht" } }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-10-28T00:40:10Z", "id": "7eac5fbe40709fac2b10de15dbd93f6125c9f473", "message": "Uploaded patch set 2.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-10-28T00:41:45Z", "id": "cc636642dd1428adb1122cd060ae48743114b512", "message": "Patch Set 2:\n\n> Patch Set 1:\n> \n> Hmm, this actually seems wrong. It should be the MANAGE_THREAD write, though the code seems wrong. Will look into it.\n\nI've updated this to check MANAGE_PROCESS, as the docs for MANAGE_PROCESS say that it should cover the creation of threads.\n\nI can see an argument for it being MANAGE_THREAD though as well, so if this should change, I'm happy to do that.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-10-28T00:46:00Z", "id": "70e702afbb50f8c9dd221ca6f3ce22234e576550", "message": "Patch Set 2:\n\nTravis said that I should add you to this review.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, { "author": { "_account_id": 19116, "email": "maniscalco@google.com", "name": "Nick Maniscalco" }, "date": "2018-11-05T19:55:58Z", "id": "37ffd4eb1a7485b0408958b4615d3dc690fdd484", "message": "Patch Set 2: Commit-Queue+1", "real_author": { "_account_id": 19116, "email": "maniscalco@google.com", "name": "Nick Maniscalco" }, "tag": "autogenerated:plugin" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2018-11-05T19:56:02Z", "id": "8b7df1283cf87edf5fc3f92d66f83d6efee3f255", "message": "Patch Set 2:\n\nDry run: CQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/217560/2\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2018-11-05T19:55:58.0Z\", \"cq_cfg_revision\": \"42f357ccfddfd816275b937cd798f7174ae91f3f\", \"revision\": \"ad0cf3318594e78bdbaef1d5abb2532271ee6d4f\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 19116, "email": "maniscalco@google.com", "name": "Nick Maniscalco" }, "date": "2018-11-05T19:58:16Z", "id": "7d42d1a90bceda198d61f3102f5f4693977925bc", "message": "Patch Set 2: Code-Review+1\n\n(1 comment)", "real_author": { "_account_id": 19116, "email": "maniscalco@google.com", "name": "Nick Maniscalco" } }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2018-11-05T20:01:57Z", "id": "90f25ef18b71c80bd4ee90b9b9c7ea87e9a9360e", "message": "Patch Set 2:\n\n(1 comment)", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } }, { "author": { "_account_id": 19116, "email": "maniscalco@google.com", "name": "Nick Maniscalco" }, "date": "2018-11-05T20:12:13Z", "id": "688773245248441e6fa8225058f96e90fff77bb6", "message": "Patch Set 2: -Commit-Queue", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2018-11-05T20:12:13Z", "id": "3c7038daafb53663240c6dc3e90642945c2b2cfc", "message": "Patch Set 2:\n\nDry run: This issue passed the CQ dry run.", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" }, "date": "2018-12-06T23:32:11Z", "id": "22422e05b8fd7750a3ae21dae2b97577413a3100", "message": "Patch Set 2:\n\n(1 comment)\n\nCould you add garnet & topaz trybots? I tried to do something close to this, and things got busterated (but maybe this is a bit more conservative, so it might be fine.)\n\nCould you also please amend syscalls.abigen near https://fuchsia.googlesource.com/zircon/+/HEAD/system/public/zircon/syscalls.abigen#318 ? (That's currently only for generating documentation, but I'd like it to do functional things at some point too.)", "real_author": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" } }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-12-07T06:07:09Z", "id": "df0d3d06184dbbdbaf7a30cab5c769ee6baeea82", "message": "Uploaded patch set 3.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-12-07T06:10:43Z", "id": "477f1bbf6eb9eb7148e55172b06a45d65835aadd", "message": "Patch Set 3:\n\n> Patch Set 2:\n> \n> (1 comment)\n> \n> Could you add garnet & topaz trybots? I tried to do something close to this, and things got busterated (but maybe this is a bit more conservative, so it might be fine.)\n> \n> Could you also please amend syscalls.abigen near https://fuchsia.googlesource.com/zircon/+/HEAD/system/public/zircon/syscalls.abigen#318 ? (That's currently only for generating documentation, but I'd like it to do functional things at some point too.)\n\nI don't know how to add additional trybots. (I'm not a Google person.)\n\nI've updated this to address the merge conflicts, changed it to require MANAGE_THREAD rather than MANAGE_PROCESS, and updated the abigen files. I changed the test as well to use a different invalid right as you requested.\n\nShould this be MANAGE_THREAD or MANAGE_PROCESS?\n\nAlso, thread_start is going to need similar updates ...", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-12-07T06:11:21Z", "id": "275f12dedae68e91d06145744dbc156a08e91723", "message": "Patch Set 3:\n\nAnd while I did the update, I have so far only compiled it and haven't run on qemu yet.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, { "author": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" }, "date": "2018-12-07T06:38:10Z", "id": "24e505cfb9120016325e39f041f9eb8ee79aee83", "message": "Patch Set 3:\n\n(1 comment)\n\nI think MANAGE_THREAD makes sense here on Process for thread creation. The created Thread would also need MANAGE_THREAD to be able to be started. I don't love the three MANAGE_ rights tbh, I find it a bit confusing as to what they might imply.\n\n(There should be a \"CHOOSE TRYBOTS\" in the bottom right? But maybe it's only visible to certain people, I'm not sure. It also flakily just doesn't show up ~50% of the time, even for @google.com, so ... /shrug. I'll add a few anyway.)", "real_author": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" } }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-12-07T14:07:48Z", "id": "ebb32f862e73424a8f3a7c43b137e13ae9d3e3c0", "message": "Uploaded patch set 4.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "date": "2018-12-07T14:09:04Z", "id": "0294c590315076b02fb1a06f23777a661f44d161", "message": "Patch Set 4:\n\nUpdated the syscall doc per your comment.", "real_author": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } }, { "author": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" }, "date": "2018-12-07T18:39:10Z", "id": "40e17b49f86fdf1cea149c0c263512751c9155ee", "message": "Patch Set 4: Code-Review+2", "real_author": { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" } }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2018-12-08T00:52:19Z", "id": "701eaa5e3f271ea3c2e269d25f732875d88f99ba", "message": "Patch Set 4: Commit-Queue+1", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "tag": "autogenerated:plugin" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2018-12-08T00:52:21Z", "id": "60d90e0b88e84eedda784398f6aa0c553b503c96", "message": "Patch Set 4:\n\nDry run: CQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/217560/4\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2018-12-08T00:52:19.0Z\", \"cq_cfg_revision\": \"8dd4d11e2eed89d46a26b8a354e75598f89f0c3e\", \"revision\": \"d89ec905226aa2894c3b5bed955616c8862a2c69\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" } ], "owner": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" }, "project": "zircon", "revert_of": 0, "reviewers": { "CC": [ { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" } ], "REMOVED": null, "REVIEWER": [ { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, { "_account_id": 5045, "email": "travisg@google.com", "name": "Travis Geiselbrecht" }, { "_account_id": 7766, "email": "scottmg@google.com", "name": "Scott Graham" }, { "_account_id": 19116, "email": "maniscalco@google.com", "name": "Nick Maniscalco" }, { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } ] }, "revisions": { "d89ec905226aa2894c3b5bed955616c8862a2c69": { "_number": 4, "commit": { "author": {}, "committer": {} }, "kind": "REWORK", "ref": "refs/changes/60/217560/4", "uploader": { "_account_id": 31976, "email": "bruce.mitchener@gmail.com", "name": "Bruce Mitchener" } } }, "status": "NEW", "subject": "[syscall][tasks] thread_create requires MANAGE_THREAD on process.", "submit_type": "REBASE_IF_NECESSARY", "submitted": "", "submitter": {}, "topic": "", "unresolved_comment_count": 3, "updated": "2018-12-08 00:52:21.000000000" }