Back to build
Raw log | Switch to full mode | Login

{ "_more_changes": false, "_number": 235280, "branch": "master", "change_id": "I0fadcbaf0670f1f23f332f07becdfb64e56a3b9a", "created": "2018-12-18 19:27:01.000000000", "current_revision": "e4802eda21a088a05b5673f2899edd724d7f225d", "deletions": 0, "has_review_started": true, "hashtags": [], "id": "tools~master~I0fadcbaf0670f1f23f332f07becdfb64e56a3b9a", "insertions": 83, "labels": { "Code-Review": { "approved": { "_account_id": 30867, "email": "dhobsd@google.com", "name": "Devon H. O'Dell" } }, "Commit-Queue": { "approved": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "optional": true }, "No-Patches-File": { "approved": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } } }, "mergeable": true, "messages": [ { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-18T19:27:01Z", "id": "f07ac0a34d8620bddb6f44408134f306a9434584", "message": "Uploaded patch set 1.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-18T19:28:44Z", "id": "1f7779a3ce7d6bc9dbe86ab1d2e93c52b01a6f90", "message": "Uploaded patch set 2.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-18T19:33:50Z", "id": "6aad3c14b30b607f835e94301c8a8d15832b964f", "message": "Patch Set 2:\n\nJosh mentioned that Kendal has trouble getting SSH to work.\n\nThis is something I used for early version of botanist that was SSH rather than TFTP based and it used to work (I haven't tried it recently). I've been also using it for GCE instances as well. One tricky bit that's important is to set sufficient timeout and wrap the connection logic in retry block, otherwise the client might fail to connect if the daemon isn't ready yet. Hopefully it's useful.\n\nI'm not super happy about the Upload/Download API, this is something that will need improvement. Today I'd use WriterTo/ReaderFrom interface like I did for TFTP which is IMO cleaner.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } }, { "author": { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" }, "date": "2018-12-18T20:08:26Z", "id": "acd84ad00e971f0c7efeef5d2ac47269719d52a8", "message": "Patch Set 2:\n\n> Patch Set 2:\n> \n> Josh mentioned that Kendal has trouble getting SSH to work.\n> \n> This is something I used for early version of botanist that was SSH rather than TFTP based and it used to work (I haven't tried it recently). I've been also using it for GCE instances as well. One tricky bit that's important is to set sufficient timeout and wrap the connection logic in retry block, otherwise the client might fail to connect if the daemon isn't ready yet. Hopefully it's useful.\n> \n> I'm not super happy about the Upload/Download API, this is something that will need improvement. Today I'd use WriterTo/ReaderFrom interface like I did for TFTP which is IMO cleaner.\n\nNice! I see the mistake I was making, I was attempting to use the same set of keys for the key-exchange algorithm and the authentication step. I'll adapt this code to my own change if you don't plan on submitting it. This is a huge help.", "real_author": { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" } }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-18T22:07:57Z", "id": "061dc6f9155decf24a657daca056e800859254f5", "message": "Patch Set 2:\n\n> Patch Set 2:\n> \n> > Patch Set 2:\n> > \n> > Josh mentioned that Kendal has trouble getting SSH to work.\n> > \n> > This is something I used for early version of botanist that was SSH rather than TFTP based and it used to work (I haven't tried it recently). I've been also using it for GCE instances as well. One tricky bit that's important is to set sufficient timeout and wrap the connection logic in retry block, otherwise the client might fail to connect if the daemon isn't ready yet. Hopefully it's useful.\n> > \n> > I'm not super happy about the Upload/Download API, this is something that will need improvement. Today I'd use WriterTo/ReaderFrom interface like I did for TFTP which is IMO cleaner.\n> \n> Nice! I see the mistake I was making, I was attempting to use the same set of keys for the key-exchange algorithm and the authentication step. I'll adapt this code to my own change if you don't plan on submitting it. This is a huge help.\n\nUp to you, if you want to land this as initial version and iterate on it, that's fine with me, if you want to incorporate it into your change, that's fine as well.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-18T22:08:57Z", "id": "35e6820bcae084c48e710e5adeee7572eca4d34e", "message": "Patch Set 2:\n\n> Patch Set 2:\n> \n> Josh mentioned that Kendal has trouble getting SSH to work.\n> \n> This is something I used for early version of botanist that was SSH rather than TFTP based and it used to work (I haven't tried it recently). I've been also using it for GCE instances as well. One tricky bit that's important is to set sufficient timeout and wrap the connection logic in retry block, otherwise the client might fail to connect if the daemon isn't ready yet. Hopefully it's useful.\n> \n> I'm not super happy about the Upload/Download API, this is something that will need improvement. Today I'd use WriterTo/ReaderFrom interface like I did for TFTP which is IMO cleaner.\n\nIf you want to start with this change, I could probably trim it down even more and just keep \"NewKeyPair\" and \"NewConnection\" functions.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } }, { "author": { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" }, "date": "2018-12-18T22:14:35Z", "id": "8377c0dff72443389553c2cba1b8a03e44054550", "message": "Patch Set 2:\n\n> Patch Set 2:\n> \n> > Patch Set 2:\n> > \n> > Josh mentioned that Kendal has trouble getting SSH to work.\n> > \n> > This is something I used for early version of botanist that was SSH rather than TFTP based and it used to work (I haven't tried it recently). I've been also using it for GCE instances as well. One tricky bit that's important is to set sufficient timeout and wrap the connection logic in retry block, otherwise the client might fail to connect if the daemon isn't ready yet. Hopefully it's useful.\n> > \n> > I'm not super happy about the Upload/Download API, this is something that will need improvement. Today I'd use WriterTo/ReaderFrom interface like I did for TFTP which is IMO cleaner.\n> \n> If you want to start with this change, I could probably trim it down even more and just keep \"NewKeyPair\" and \"NewConnection\" functions.\n\nIterating on this as-is SGTM. Leaving in Upload/Download for now is also fine; If we want something different we can just refactor it later.", "real_author": { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" } }, { "author": { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" }, "date": "2018-12-18T22:50:50Z", "id": "0d748c7b5aed2619ae8e7ab8c45ff264d163903e", "message": "Patch Set 2: Code-Review+2\n\n(3 comments)", "real_author": { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" } }, { "author": { "_account_id": 30867, "email": "dhobsd@google.com", "name": "Devon H. O'Dell" }, "date": "2018-12-18T23:22:10Z", "id": "de99531bb0e739c892cc55ce75b69b6a61720f40", "message": "Patch Set 2:\n\n(2 comments)", "real_author": { "_account_id": 30867, "email": "dhobsd@google.com", "name": "Devon H. O'Dell" } }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-19T00:40:25Z", "id": "b2497b05624936daa204389a1fbce639e67b752e", "message": "Uploaded patch set 3.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 30867, "email": "dhobsd@google.com", "name": "Devon H. O'Dell" }, "date": "2018-12-19T00:41:13Z", "id": "33da289ddfab019ebccf41573be774ff59eb6043", "message": "Patch Set 3: Code-Review+2", "real_author": { "_account_id": 30867, "email": "dhobsd@google.com", "name": "Devon H. O'Dell" } }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-19T00:42:14Z", "id": "f6bf0319f8941ba1cd1111f39ce6986ad789b025", "message": "Patch Set 3:\n\n(4 comments)", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-19T00:42:43Z", "id": "ca7131b2a1140ef550643b8e5fa1a16652e144b2", "message": "Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-19T00:42:55Z", "id": "257bb981f4faa9ba318e6ce7d19780c212ded8ed", "message": "Uploaded patch set 5.", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "date": "2018-12-19T00:43:07Z", "id": "6b8ed18d4e620463f9b18eb3f3eb8a28799b0a0b", "message": "Patch Set 5: Commit-Queue+2", "real_author": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2018-12-19T00:43:12Z", "id": "a9058272e4772cad647f85ed556e3861ad252c9b", "message": "Patch Set 5:\n\nCQ is trying the patch.\n\nNote: The patchset sent to CQ was uploaded after this CL was approved.\n\"\" https://fuchsia-review.googlesource.com/c/235280/5\n\nReference: fuchsia-review.googlesource.com/235280/5\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2018-12-19T00:43:07.0Z\", \"cq_cfg_revision\": \"d5a7c76be64806939144575df3a701771b3a2754\", \"revision\": \"e4802eda21a088a05b5673f2899edd724d7f225d\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:full-run" } ], "owner": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, "project": "tools", "revert_of": 0, "reviewers": { "CC": [ { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" } ], "REMOVED": null, "REVIEWER": [ { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" }, { "_account_id": 18706, "email": "kjharland@google.com", "name": "Kendal Harland" }, { "_account_id": 23653, "email": "joshuaseaton@google.com", "name": "Joshua Seaton" }, { "_account_id": 30867, "email": "dhobsd@google.com", "name": "Devon H. O'Dell" } ] }, "revisions": { "e4802eda21a088a05b5673f2899edd724d7f225d": { "_number": 5, "commit": { "author": {}, "committer": {} }, "kind": "REWORK", "ref": "refs/changes/80/235280/5", "uploader": { "_account_id": 5050, "email": "phosek@google.com", "name": "Petr Hosek" } } }, "status": "NEW", "subject": "[ssh] Simple SSH and SFTP support", "submit_type": "REBASE_IF_NECESSARY", "submitted": "", "submitter": {}, "topic": "", "unresolved_comment_count": 0, "updated": "2018-12-19 00:43:12.000000000" }