Back to build
Raw log | Switch to full mode | Login

{ "_more_changes": false, "_number": 247212, "branch": "master", "change_id": "I6bee8f66c3e9ce9c93eae67875f64d7c1a9812bf", "created": "2019-01-28 17:05:38.000000000", "current_revision": "2a94f50ba057c9edff8d5e78ab7a284cb3f18339", "deletions": 1734, "has_review_started": true, "hashtags": [], "id": "zircon~master~I6bee8f66c3e9ce9c93eae67875f64d7c1a9812bf", "insertions": 1818, "labels": { "Code-Review": { "approved": { "_account_id": 5005, "email": "voydanoff@google.com", "name": "Mike Voydanoff" } }, "Commit-Message-has-TEST-line": { "approved": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } }, "Commit-Message-has-tags": { "approved": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } }, "Commit-Queue": { "approved": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, "optional": true }, "No-Patches-File": { "approved": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } } }, "mergeable": true, "messages": [ { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-28T17:05:38Z", "id": "03383143eda42b48896f09a616fd1ef229631fba", "message": "Uploaded patch set 1.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-28T17:10:22Z", "id": "35f4d73e29e6c27fb0a2a17eeaa3091e42090c7a", "message": "Uploaded patch set 2.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5005, "email": "voydanoff@google.com", "name": "Mike Voydanoff" }, "date": "2019-01-28T23:23:16Z", "id": "361ef9df11624f8c2d0fd90b40771f6c21522798", "message": "Patch Set 2:\n\n(4 comments)\n\nLooks good! Just a few nits.", "real_author": { "_account_id": 5005, "email": "voydanoff@google.com", "name": "Mike Voydanoff" } }, { "author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, "date": "2019-01-29T16:59:06Z", "id": "2156d004e46c99d37877557b78f643b817c9f6a6", "message": "Patch Set 2: Code-Review+1\n\n(1 comment)", "real_author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" } }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-30T16:15:11Z", "id": "0937c0a3f2e37a14dc26f9fb9edfa29627886a14", "message": "Uploaded patch set 3.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-30T16:15:56Z", "id": "60022cb965f13f8d42cd416ffbd561ef3558a681", "message": "Patch Set 3:\n\n(4 comments)\n\n> Patch Set 2:\n> \n> (4 comments)\n> \n> Looks good! Just a few nits.\n\nmade the changes and uploaded patch set 3", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-30T16:16:41Z", "id": "4b6b22330cd5ac54d2294fdbca1c6921c2684c74", "message": "Patch Set 3:\n\n> Patch Set 2: Code-Review+1\n> \n> (1 comment)\n\nI think i fixed the indentation issue by running clang-format again.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-30T16:31:08Z", "id": "0f1d7beacc7208b023128cfcf3fce058a8aa1846", "message": "Uploaded patch set 4.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-30T16:41:05Z", "id": "9a0d2aed8bf8d3340acef8bfe95f2f433360b19d", "message": "Uploaded patch set 5.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "date": "2019-01-30T16:41:51Z", "id": "103d8219b092266c4a601cae3ef66ae2f0562ae5", "message": "Patch Set 5:\n\n> Patch Set 2: Code-Review+1\n> \n> (1 comment)\n\nI think its now finally fixed. I manually changed the indentation. running clang-format was messing up this file.", "real_author": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } }, { "author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, "date": "2019-01-30T16:46:25Z", "id": "688764425415175b88bb8defb168e64edb9dde88", "message": "Patch Set 5: Code-Review+2", "real_author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" } }, { "author": { "_account_id": 5005, "email": "voydanoff@google.com", "name": "Mike Voydanoff" }, "date": "2019-01-30T16:49:42Z", "id": "fb2cb795b066e481f250719d34552df867c68967", "message": "Patch Set 5: Code-Review+2", "real_author": { "_account_id": 5005, "email": "voydanoff@google.com", "name": "Mike Voydanoff" } }, { "author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, "date": "2019-01-30T17:18:48Z", "id": "a89b365888755f24de86a67b054231c501b6e636", "message": "Patch Set 5: Commit-Queue+2", "real_author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" } }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-30T17:18:53Z", "id": "fb430a5357e65eb634fee7f0b2c4dbc34f3db085", "message": "Patch Set 5:\n\nCQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/247212/5\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-01-30T17:18:48.0Z\", \"cq_cfg_revision\": \"dd97db5f211f7861f68535dab1da37ae435cac27\", \"revision\": \"2a94f50ba057c9edff8d5e78ab7a284cb3f18339\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:full-run" }, { "author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, "date": "2019-01-30T17:18:54Z", "id": "bec8363ee83646afb25010cd50802bee1499a7c3", "message": "Removed Code-Review+2 by Brijen Raval <braval@google.com>\n", "real_author": { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, "tag": "autogenerated:gerrit:deleteVote" } ], "owner": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" }, "project": "zircon", "revert_of": 0, "reviewers": { "CC": [ { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" } ], "REMOVED": null, "REVIEWER": [ { "_account_id": 5005, "email": "voydanoff@google.com", "name": "Mike Voydanoff" }, { "_account_id": 19772, "email": "braval@google.com", "name": "Brijen Raval" }, { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } ] }, "revisions": { "2a94f50ba057c9edff8d5e78ab7a284cb3f18339": { "_number": 5, "commit": { "author": {}, "committer": {} }, "kind": "REWORK", "ref": "refs/changes/12/247212/5", "uploader": { "_account_id": 31910, "email": "rsubr@google.com", "name": "Ramya Subramanian" } } }, "status": "NEW", "subject": "[board][vim] Convert to c++", "submit_type": "REBASE_IF_NECESSARY", "submitted": "", "submitter": {}, "topic": "", "unresolved_comment_count": 2, "updated": "2019-01-30 17:18:54.000000000" }