Back to build
Raw log | Switch to full mode | Login

{ "_more_changes": false, "_number": 248413, "branch": "master", "change_id": "Idc986ef47a996d2080d15ab680dc0b2255bb5c8d", "created": "2019-01-30 01:49:44.000000000", "current_revision": "38c3ed1faffe66a1c8e24e3fd9fbbce6c26ffd8e", "deletions": 1418, "has_review_started": true, "hashtags": [], "id": "zircon~master~Idc986ef47a996d2080d15ab680dc0b2255bb5c8d", "insertions": 8, "labels": { "Code-Review": { "approved": { "_account_id": 5116, "email": "johngro@google.com", "name": "John Grossman" } }, "Commit-Message-has-TEST-line": { "approved": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } }, "Commit-Message-has-tags": { "approved": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } }, "Commit-Queue": { "approved": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "optional": true }, "No-Patches-File": { "approved": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } } }, "mergeable": true, "messages": [ { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:49:44Z", "id": "3d0f46f21040237825ae6afc5b6dd51afc219cd6", "message": "Uploaded patch set 1.", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:53:16Z", "id": "e275ea85c213c5351f5f8c93388eec016968df81", "message": "Patch Set 1: Commit-Queue+1", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-30T01:53:29Z", "id": "24c4c0a43d0784347f0c55eaf40b558d953c4053", "message": "Patch Set 1:\n\nDry run: CQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/248413/1\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-01-30T01:53:16.0Z\", \"cq_cfg_revision\": \"dd97db5f211f7861f68535dab1da37ae435cac27\", \"revision\": \"50222fc4e293b4e868466db36234fccf41939ba6\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:53:56Z", "id": "72dbc1bbe8f436a611b2fee9e5257b2c774a6f65", "message": "Uploaded patch set 2.", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:54:05Z", "id": "cf1cc973e3d08e130c295a0c1ee1554a863b1d4a", "message": "Patch Set 2: Commit-Queue+1", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "tag": "autogenerated:plugin" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-30T01:54:10Z", "id": "907ffe3dd1deb41d646c90b4a42d3ec9284beac8", "message": "Patch Set 2:\n\nDry run: CQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/248413/2\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-01-30T01:54:05.0Z\", \"cq_cfg_revision\": \"dd97db5f211f7861f68535dab1da37ae435cac27\", \"revision\": \"f61e559a147293a629a3b0a9ab400f0f4d465519\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:56:23Z", "id": "41bf9e4adbc655b398d0880f13e954323cc1e111", "message": "Patch Set 2: -Commit-Queue", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-30T01:56:25Z", "id": "af5ae2c80777e8d3375e53f68f44de31c9dc047a", "message": "Patch Set 2:\n\nDry run: Try jobs failed on following builders:\n zircon-arm64-clang-qemu on luci.fuchsia.try (JOB_FAILED, https://ci.chromium.org/b/8922945299955781200)\n zircon-x64-clang-dawson_canyon on luci.fuchsia.try (JOB_FAILED, https://ci.chromium.org/b/8922945299955781120)\n zircon-x64-clang-no_opt-build_only on luci.fuchsia.try (JOB_FAILED, https://ci.chromium.org/b/8922945299955781408)\n zircon-x64-gcc-no_opt-build_only on luci.fuchsia.try (JOB_FAILED, https://ci.chromium.org/b/8922945299955781248)", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:58:19Z", "id": "e0a4960e640b538bd5b6f429b4a27c2c007d09a0", "message": "Uploaded patch set 3.", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T01:58:24Z", "id": "6b67b0fcab54fb36001fc668afa6685cf0486cff", "message": "Patch Set 3: Commit-Queue+1", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "tag": "autogenerated:plugin" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-30T01:58:34Z", "id": "473e5accf71ffbeb6bbf1a415d5878bb149d8dbf", "message": "Patch Set 3:\n\nDry run: CQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/248413/3\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-01-30T01:58:24.0Z\", \"cq_cfg_revision\": \"dd97db5f211f7861f68535dab1da37ae435cac27\", \"revision\": \"38c3ed1faffe66a1c8e24e3fd9fbbce6c26ffd8e\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-30T02:15:45Z", "id": "b9b3e6a8ad4ed7ed873562a364c05a4997e6f185", "message": "Patch Set 3: -Commit-Queue", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-30T02:15:46Z", "id": "bf5029c2d0b33885427dd1a05a3d5a5502393903", "message": "Patch Set 3:\n\nDry run: This issue passed the CQ dry run.", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 5116, "email": "johngro@google.com", "name": "John Grossman" }, "date": "2019-01-30T19:03:24Z", "id": "718ea9a6b5b19f546f4dca53ad88c30cad44773c", "message": "Patch Set 3: Code-Review+2\n\nlgtm\n\nIf it is helpful at all, I have this already prepared.\n\nhttps://fuchsia-review.googlesource.com/c/zircon/+/248672\n\nI'm using it for some of my work in progress, but I had not uploaded it yes as Roland seemed to want to be very conservative when it came to only adding stuff to ktl when there was work which immediately needed it.\n\nIf you plan to convert all of the atomics in the kernel to a std:: alias, this might be useful.", "real_author": { "_account_id": 5116, "email": "johngro@google.com", "name": "John Grossman" } }, { "author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "date": "2019-01-31T10:28:28Z", "id": "4c1b99a5831669976b19cbe276bcc04d68b54706", "message": "Patch Set 3: Commit-Queue+2\n\n> Patch Set 3: Code-Review+2\n> \n> lgtm\n> \n> If it is helpful at all, I have this already prepared.\n> \n> https://fuchsia-review.googlesource.com/c/zircon/+/248672\n> \n> I'm using it for some of my work in progress, but I had not uploaded it yes as Roland seemed to want to be very conservative when it came to only adding stuff to ktl when there was work which immediately needed it.\n> \n> If you plan to convert all of the atomics in the kernel to a std:: alias, this might be useful.\n\nYeah, it's getting to the point where I'm preparing a more comprehensive plan of what's needed where. That WIP is a big part.", "real_author": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-01-31T10:28:35Z", "id": "55fa8d59cbe10bab6f3e3e9d828ba285210209bd", "message": "Patch Set 3:\n\nCQ is trying the patch.\n\nReference: fuchsia-review.googlesource.com/248413/3\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-01-31T10:28:28.0Z\", \"cq_cfg_revision\": \"7c14a65d137d70c649a36a5e854a1fe53ff311c8\", \"revision\": \"38c3ed1faffe66a1c8e24e3fd9fbbce6c26ffd8e\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:full-run" } ], "owner": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, "project": "zircon", "revert_of": 0, "reviewers": { "CC": [ { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, { "_account_id": 28851, "email": "crjohns@google.com", "name": "Christopher Johnson" } ], "REMOVED": null, "REVIEWER": [ { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, { "_account_id": 5116, "email": "johngro@google.com", "name": "John Grossman" } ] }, "revisions": { "38c3ed1faffe66a1c8e24e3fd9fbbce6c26ffd8e": { "_number": 3, "commit": { "author": {}, "committer": {} }, "kind": "REWORK", "ref": "refs/changes/13/248413/3", "uploader": { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" } } }, "status": "NEW", "subject": "[fbl] Only allow fbl::atomic in the kernel", "submit_type": "REBASE_IF_NECESSARY", "submitted": "", "submitter": {}, "topic": "", "unresolved_comment_count": 0, "updated": "2019-01-31 10:28:35.000000000" }