Back to build
Raw log | Switch to full mode | Login

{ "_more_changes": false, "_number": 274089, "branch": "master", "change_id": "I72e2fb62939b99701494f6f1cd7832b2882ec4f2", "created": "2019-04-19 23:46:10.000000000", "current_revision": "dc06475004878d830edfd63904672dc422ab000e", "deletions": 2, "has_review_started": true, "hashtags": [], "id": "fuchsia~master~I72e2fb62939b99701494f6f1cd7832b2882ec4f2", "insertions": 15, "labels": { "Code-Review": {}, "Commit-Message-has-tags": { "approved": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } }, "Commit-Queue": { "optional": true, "recommended": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } }, "No-Patches-File": { "approved": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } }, "Owner-Review-Vote": {} }, "mergeable": true, "messages": [ { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-19T23:46:10Z", "id": "5f6cb09186980204ffbea7db792d54836e443a04", "message": "Uploaded patch set 1.", "real_author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-19T23:47:00Z", "id": "3f773b183ef98a9d5d94be5faf6da7d36c45a799", "message": "Patch Set 1: Commit-Queue+1", "real_author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-04-19T23:47:07Z", "id": "403a6f986576e254b3a2c758344baa720bc0d2c5", "message": "Patch Set 1:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-04-19T23:47:00.0Z\", \"revision\": \"ba4f625c6ad035d6f14f95069565784a7988615c\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" }, "date": "2019-04-20T00:23:05Z", "id": "70b105f149f99aafe1541fd94227c4a475762391", "message": "Patch Set 1:\n\nI thought we were going to use getentropy ?", "real_author": { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" } }, { "author": { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" }, "date": "2019-04-20T00:24:49Z", "id": "a43dad1cbf5df074a6c634d9e3d2f178d012436b", "message": "Patch Set 1: Code-Review-1\n\n(2 comments)\n\nI'd prefer to use getentropy if possible.", "real_author": { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" } }, { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-20T00:33:00Z", "id": "d7901b200a5f498243756c77980522675827208d", "message": "Patch Set 1: -Commit-Queue", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-04-20T00:33:01Z", "id": "32f86ac75b723f3c597cfd46e243af732424639d", "message": "Patch Set 1:\n\nDry run: This issue passed the CQ dry run.", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-20T04:02:07Z", "id": "cdffc528bed9aa8fd61162af778c2e63cf1db0d6", "message": "Patch Set 1:\n\n> Patch Set 1: Code-Review-1\n> \n> (2 comments)\n> \n> I'd prefer to use getentropy if possible.\n\nPer that same chat thread, |getentropy| doesn't seem to be available on our workstation's version of linux/glibc. I'm happy to use it if possible, but as far as I can tell, it simply isn't there.\n\nPlease let me know if this isn't the direction you want src/lib to go, and I can look into just not using src/lib/uuid in catapult converter (this logic is small enough that inlining a portable equivalent of it in catapult_converter would probably be fine).\n\nWill address other comments after we finish discussing this higher level one.", "real_author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } }, { "author": { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" }, "date": "2019-04-20T04:25:10Z", "id": "a4fdab6ae0a1813f11c09d858407e30d1a13abfa", "message": "Patch Set 1:\n\n> Per that same chat thread, |getentropy| doesn't seem to be available on our workstation's version of linux/glibc. I'm happy to use it if possible, but as far as I can tell, it simply isn't there.\n\nThat's too bad. Is http://man7.org/linux/man-pages/man2/getrandom.2.html available?\n\n> Please let me know if this isn't the direction you want src/lib to go, and I can look into just not using src/lib/uuid in catapult converter (this logic is small enough that inlining a portable equivalent of it in catapult_converter would probably be fine).\n\nI'd prefer this library not depend on open() or other file-related code. If we can get a syscall or a syscall wrapper on Linux that is equivalent to zx_cprng_draw, then it's fine to have here. Otherwise, I'd prefer for catapult to go another direction.", "real_author": { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" } }, { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-20T07:28:02Z", "id": "ca4e8881e73fc5bd363d7d514388f28f581a9191", "message": "Uploaded patch set 2.", "real_author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-20T07:29:58Z", "id": "6ae42a72c683da70ab626cc33c92a5354004c2a7", "message": "Patch Set 2: Commit-Queue+1", "real_author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "tag": "autogenerated:plugin" }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-04-20T07:30:07Z", "id": "df36054751c5f1fd617a8f2a1fba802989e695d5", "message": "Patch Set 2:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-04-20T07:29:58.0Z\", \"revision\": \"dc06475004878d830edfd63904672dc422ab000e\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" }, { "author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "date": "2019-04-20T07:30:55Z", "id": "a04f809c3ef534f9680c747286d7ed8a66186d7b", "message": "Patch Set 2:\n\n(2 comments)\n\n> Patch Set 1:\n> \n> > Per that same chat thread, |getentropy| doesn't seem to be available on our workstation's version of linux/glibc. I'm happy to use it if possible, but as far as I can tell, it simply isn't there.\n> \n> That's too bad. Is http://man7.org/linux/man-pages/man2/getrandom.2.html available?\n> \n> > Please let me know if this isn't the direction you want src/lib to go, and I can look into just not using src/lib/uuid in catapult converter (this logic is small enough that inlining a portable equivalent of it in catapult_converter would probably be fine).\n> \n> I'd prefer this library not depend on open() or other file-related code. If we can get a syscall or a syscall wrapper on Linux that is equivalent to zx_cprng_draw, then it's fine to have here. Otherwise, I'd prefer for catapult to go another direction.\n\nYes, it looks like http://man7.org/linux/man-pages/man2/getrandom.2.html is available. I switched to that. And then that should address the file-related code concern.", "real_author": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } } ], "owner": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" }, "project": "fuchsia", "revert_of": 0, "reviewers": { "CC": [ { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" } ], "REMOVED": null, "REVIEWER": [ { "_account_id": 5020, "email": "kulakowski@google.com", "name": "George Kulakowski" }, { "_account_id": 5275, "email": "abarth@google.com", "name": "Adam Barth" }, { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } ] }, "revisions": { "dc06475004878d830edfd63904672dc422ab000e": { "_number": 2, "commit": { "author": {}, "committer": {} }, "kind": "REWORK", "ref": "refs/changes/89/274089/2", "uploader": { "_account_id": 28063, "email": "nathanrogers@google.com", "name": "Nathan Rogers" } } }, "status": "NEW", "subject": "[uuid] Add getrandom based random bytes support (for linux support)", "submit_type": "REBASE_IF_NECESSARY", "submitted": "", "submitter": {}, "topic": "", "unresolved_comment_count": 2, "updated": "2019-04-20 07:30:55.000000000" }