Back to build
Raw log | Switch to full mode | Login

{ "_more_changes": false, "_number": 277790, "branch": "master", "change_id": "I9517257c900e736faf599b329b0340217bf62563", "created": "2019-05-04 00:28:02.000000000", "current_revision": "90f1fcef4fc94061cbbc514edb9902567d6cb415", "deletions": 1, "has_review_started": true, "hashtags": [], "id": "fuchsia~master~I9517257c900e736faf599b329b0340217bf62563", "insertions": 102, "labels": { "API-Review": {}, "Code-Review": { "approved": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" } }, "Commit-Message-has-tags": { "approved": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, "Commit-Queue": { "optional": true, "recommended": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, "No-Patches-File": { "approved": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, "Owner-Review-Vote": {}, "Testability-Review": {} }, "mergeable": true, "messages": [ { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-04T00:28:02Z", "id": "47a293c05c7d417848f4f67b0a87eeab6b6af061", "message": "Uploaded patch set 1.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-04T01:41:53Z", "id": "5e597c068fa0ca0c30210a1d652a1aa0041847bc", "message": "Uploaded patch set 2.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" }, "date": "2019-05-06T22:19:48Z", "id": "c07900659c55eb9e1bc210b9518ae7384df65799", "message": "Patch Set 2:\n\n(2 comments)", "real_author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" } }, { "author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" }, "date": "2019-05-06T22:24:12Z", "id": "3ca9e933878e440521f716d962fbd8f51c9681c2", "message": "Patch Set 2:\n\n(1 comment)", "real_author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-06T22:35:29Z", "id": "fe27df2792dcab6953eac8445016876210a26834", "message": "Uploaded patch set 3.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-06T23:04:21Z", "id": "bfb15de63a75fa9cf81976b50be7ab5df8c6f316", "message": "Uploaded patch set 4.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-06T23:39:21Z", "id": "5e5bd8144272d2282377645e942260485f5d87c0", "message": "Patch Set 4:\n\n(3 comments)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" }, "date": "2019-05-07T16:16:05Z", "id": "78c9f1692f24f282cff2467b0ce1ce3c1d07050f", "message": "Patch Set 4:\n\n(2 comments)", "real_author": { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-07T22:16:22Z", "id": "fad9a23e65429b436de8989e930a766fa8d24478", "message": "Patch Set 4:\n\n(2 comments)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-07T22:29:43Z", "id": "e09516c17496f5a65ea80e5b32308dd133e8030c", "message": "Uploaded patch set 5.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-07T22:31:52Z", "id": "7fcdcfb939527833c01a844ee5fb551d9e9a27fe", "message": "Uploaded patch set 6.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-07T22:33:48Z", "id": "930d0826207d10aa136ce54870b312cd1e9095cb", "message": "Uploaded patch set 7.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" }, "date": "2019-05-07T22:57:49Z", "id": "9ed437f7912c48e7c5355e4f76bbbfb4c759cde7", "message": "Patch Set 7:\n\n(2 comments)", "real_author": { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-08T21:18:19Z", "id": "b7eb6bfd9688a9e9e02b05ef9a700b992cc4d1c8", "message": "Uploaded patch set 8.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-08T21:20:47Z", "id": "f42041da5b389224da3dba6ea31b12c7d35fd8cf", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" }, "date": "2019-05-15T23:39:17Z", "id": "e47a212bcda827b133c77a9fb1350f154d6a85db", "message": "Patch Set 8: Code-Review+2\n\nLooks like FactoryStore is gone from the current patchset which was my last concern.\n\nAndy any final concern?", "real_author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" } }, { "author": { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" }, "date": "2019-05-16T16:51:04Z", "id": "c4fed35395b680282cab2770e33f0c94fc2ce10c", "message": "Patch Set 8: Code-Review+2", "real_author": { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" } }, { "author": { "_account_id": 5155, "email": "teisenbe@google.com", "name": "Todd Eisenberger" }, "date": "2019-05-16T20:14:36Z", "id": "5b548a3e6c4171939548bc24096142ac22e8f1a9", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 5155, "email": "teisenbe@google.com", "name": "Todd Eisenberger" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-16T21:19:21Z", "id": "a70875b894b0fecb19ccdffdfd4ca1af1c104f6e", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 5155, "email": "teisenbe@google.com", "name": "Todd Eisenberger" }, "date": "2019-05-17T00:21:50Z", "id": "c0eb876ba86146aee39c38f7d51f9f85df445b11", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 5155, "email": "teisenbe@google.com", "name": "Todd Eisenberger" } }, { "author": { "_account_id": 31692, "email": "bryanhenry@google.com", "name": "Bryan Henry" }, "date": "2019-05-21T22:00:38Z", "id": "7f64422677884a2ce9a9a387eff65345117b66b2", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 31692, "email": "bryanhenry@google.com", "name": "Bryan Henry" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-21T23:55:23Z", "id": "c16b07a8f30f66cf70fc112ea62439d304198a44", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-21T23:55:28Z", "id": "8910506286d1351bd488ac4971150bc8ad3f98e9", "message": "Removed reviewer George Kulakowski.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:deleteReviewer" }, { "author": { "_account_id": 31692, "email": "bryanhenry@google.com", "name": "Bryan Henry" }, "date": "2019-05-22T00:01:04Z", "id": "9697edd413b4240ecfd2c824bf888ead3bb4d545", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 31692, "email": "bryanhenry@google.com", "name": "Bryan Henry" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-22T00:49:58Z", "id": "303a116666cdadc0c5e27186273bfaa730800e35", "message": "Patch Set 8:\n\n(1 comment)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-22T01:50:33Z", "id": "2ffe7135cfaa4de1de8222e1b7ecdbaa9a91ab0e", "message": "Uploaded patch set 9.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-22T02:03:37Z", "id": "ac391b152c698a03cc29971d52c67f6547861c3e", "message": "Patch Set 9:\n\n(1 comment)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" }, "date": "2019-05-22T17:30:50Z", "id": "5fbae90557963cd795a27a4a25e14eb367d6fb9f", "message": "Patch Set 9:\n\nI lost track here but looks like we moved to fuchsia.build because a single property overlap?\n\nI don't think some of the fuchsia.build are part of a \"build\", like serial or language.", "real_author": { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-22T20:38:08Z", "id": "f6712f22d894ee1ec50d4247959903cff5a652dc", "message": "Patch Set 9:\n\n> Patch Set 9:\n> \n> I lost track here but looks like we moved to fuchsia.build because a single property overlap?\n> \n> I don't think some of the fuchsia.build are part of a \"build\", like serial or language.\n\nI think the library name is debatable and I don't have a strong preference for \"build\". I think it has the potential to be bloated like android.os.Build has been which contains a superset of the functions I've proposed here.\n\nIf we decide to keep everything in fuchsia.factory, bryanhenry@ mentioned that some of these properties are not necessarily set by the factory so there's some naming confusion here.\n\nIf you have better name or structure in mind, I'm all ears! :-)", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-22T21:40:07Z", "id": "6d243c81c631259d877a14967547b5b5dadc300b", "message": "Uploaded patch set 10.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-24T01:53:52Z", "id": "c6fa28117a81a1a4822590c9567c12ea6d338d96", "message": "Uploaded patch set 11.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "tag": "autogenerated:gerrit:newPatchSet" }, { "author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "date": "2019-05-24T01:55:25Z", "id": "0740bc3aa3d3757fd0adf53d0b49bb128461c122", "message": "Patch Set 11: Commit-Queue+1\n\nRemoved FIDL build target from SDK. Will land SDK inclusion separately.", "real_author": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } }, { "author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "date": "2019-05-24T01:55:28Z", "id": "5be9ae42ca6966f1f6c951b4eab5a167c1c3f217", "message": "Patch Set 11:\n\nDry run: CQ is trying the patch.\n\n\n\nBot data: {\"action\": \"start\", \"triggered_at\": \"2019-05-24T01:55:25.0Z\", \"revision\": \"90f1fcef4fc94061cbbc514edb9902567d6cb415\"}", "real_author": { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, "tag": "autogenerated:cq:dry-run" } ], "owner": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, "project": "fuchsia", "revert_of": 0, "reviewers": { "CC": [ { "_account_id": 5155, "email": "teisenbe@google.com", "name": "Todd Eisenberger" }, { "_account_id": 7350, "email": "commit-bot@chromium.org", "name": "CQ bot account: commit-bot@chromium.org" }, { "_account_id": 18132, "email": "porce@google.com", "name": "Jiwoong Lee" }, { "_account_id": 19930, "email": "awolter@google.com", "name": "Aidan Wolter" }, { "_account_id": 27522, "email": "rjascani@google.com", "name": "RJ Ascani" }, { "_account_id": 31692, "email": "bryanhenry@google.com", "name": "Bryan Henry" } ], "REMOVED": null, "REVIEWER": [ { "_account_id": 5039, "email": "cpu@google.com", "name": "Carlos Pizano" }, { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" }, { "_account_id": 31760, "email": "quanwanandy@google.com", "name": "Andy Wan" } ] }, "revisions": { "90f1fcef4fc94061cbbc514edb9902567d6cb415": { "_number": 11, "commit": { "author": {}, "committer": {} }, "kind": "REWORK", "ref": "refs/changes/90/277790/11", "uploader": { "_account_id": 31699, "email": "mbrunson@google.com", "name": "Michael Brunson" } } }, "status": "NEW", "subject": "[factory][sdk] Add Factory/Build FIDL interfaces.", "submit_type": "REBASE_IF_NECESSARY", "submitted": "", "submitter": {}, "topic": "", "unresolved_comment_count": 0, "updated": "2019-05-24 01:55:28.000000000" }