Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 CLUTTER_IM_MODULE: xim DBUS_SESSION_BUS_ADDRESS: unix:abstract=/tmp/dbus-G6xcLsFlbW DEFAULTS_PATH: /usr/share/gconf/gnome-fallback.default.path DESKTOP_AUTOSTART_ID: 1021f924b347b7213e154453427376217000000018900005 DESKTOP_SESSION: gnome-fallback DEVSHELL_CLIENT_PORT: 47863 DISPLAY: :0 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GDMSESSION: gnome-fallback GDM_LANG: en_US GIO_LAUNCHED_DESKTOP_FILE: /home/chrome-bot/.config/autostart/swarming.desktop GIO_LAUNCHED_DESKTOP_FILE_PID: 2251 GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 GNOME_DESKTOP_SESSION_ID: this-is-deprecated GPG_AGENT_INFO: /run/user/1000/keyring-dL6LfF/gpg:0:1 GTK_IM_MODULE: ibus GTK_MODULES: overlay-scrollbar:unity-gtk-module HOME: /home/chrome-bot IM_CONFIG_PHASE: 1 INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task INSTANCE: JOB: dbus LANG: en_US.UTF-8 LANGUAGE: en_US: LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8927412477585882416 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itN2yI6t/luci_context.059437268 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MANDATORY_PATH: /usr/share/gconf/gnome-fallback.mandatory.path NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/opt/dell/srvadmin/bin PWD: /b/s/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 QT4_IM_MODULE: xim QT_IM_MODULE: ibus QT_QPA_PLATFORMTHEME: appmenu-qt5 SELINUX_INIT: YES SESSION: gnome-fallback SESSIONTYPE: gnome-session SESSION_MANAGER: local/build227-b4:@/tmp/.ICE-unix/1890,unix/build227-b4:/tmp/.ICE-unix/1890 SHELL: /bin/bash SHLVL: 1 SSH_AUTH_SOCK: /run/user/1000/keyring-dL6LfF/ssh SWARMING_BOT_ID: build227-b4 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 41b75a6d91659211 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TEXTDOMAIN: im-config TEXTDOMAINDIR: /usr/share/locale/ TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t UPSTART_SESSION: unix:abstract=/com/ubuntu/upstart-session/1000/1612 USER: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython XAUTHORITY: /home/chrome-bot/.Xauthority XDG_CONFIG_DIRS: /etc/xdg/xdg-gnome-fallback:/usr/share/upstart/xdg:/etc/xdg XDG_CURRENT_DESKTOP: Unity XDG_DATA_DIRS: /usr/share/gnome-fallback:/usr/share/gnome:/usr/local/share/:/usr/share/ XDG_GREETER_DATA_DIR: /var/lib/lightdm-data/chrome-bot XDG_MENU_PREFIX: gnome- XDG_RUNTIME_DIR: /run/user/1000 XDG_SEAT: seat0 XDG_SEAT_PATH: /org/freedesktop/DisplayManager/Seat0 XDG_SESSION_ID: c2 XDG_SESSION_PATH: /org/freedesktop/DisplayManager/Session0 XDG_VTNR: 7 XMODIFIERS: @im=ibus _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd IndexedDB: Convert WebIDBValue usage to blink IDBValue Chase Phillips, Tue Dec 11 18:31:50 2018 +0000 124b041802d8db51ff1614ff429a3389acd5cdfc Clean up sequences and sequence checking in //device/usb Reilly Grant, Tue Dec 11 18:28:48 2018 +0000 54c407df40a98eddd2e72ddca894ff860b3d6a33 Updating XTBs based on .GRDs from branch master Krishna Govind, Tue Dec 11 18:28:39 2018 +0000 7ff583308e6209af7f37f5a2605dfb9aa6c21a72 Roll src/third_party/skia 4f738832a976..3bdc3f5f9c0b (4 commits) chromium-autoroll, Tue Dec 11 18:25:39 2018 +0000 3941fd2b0532841210a3ba5e8dfead73506ecdca [CrOS MultiDevice] Remove unusued ProximityAuth code. Ryan Hansberry, Tue Dec 11 18:22:51 2018 +0000 cd964bbc72f222ccdebc589f419865a288fee10a [iOS] Add flag for Search for Copied Image feature Robbie Gibson, Tue Dec 11 18:22:21 2018 +0000 58e6d60884950afe8e8383741a742eca4cd96b91 third_party/libwebp/fuzzing: Disable ExtractAndCropOrScale() Yannis Guyon, Tue Dec 11 18:21:47 2018 +0000 e75b360015a48be36fac3e391dfdaa490f6a9f62 Fix const/let in internet_detail_page.js Alexander Hendrich, Tue Dec 11 18:21:12 2018 +0000 ccd2c27cc73b8e6c8583ddc12bc75c5d6333d26a Navigation: Removing NavigateAndCommitRendererInitiated from unit tests. Arthur Hemery, Tue Dec 11 18:20:40 2018 +0000 357ee3d982a6109792f6b4472b96ca0eb9167b84 Roll src/third_party/perfetto c8b5fd3f2752..1ec085624fc7 (1 commits) chromium-autoroll, Tue Dec 11 18:12:56 2018 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 62e3aa7666726a1fa9d6fede7bb61bdc3b0347fd Author: Chase Phillips <cmp@chromium.org> Date: Tue Dec 11 18:31:50 2018 +0000 IndexedDB: Convert WebIDBValue usage to blink IDBValue Bug: 717812 Change-Id: I90c36249357705d3a1bc215b8c02278f59993622 Reviewed-on: https://chromium-review.googlesource.com/c/1359862 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615600} .../modules/v8/v8_binding_for_modules_test.cc | 16 +++--- .../blink/renderer/modules/indexeddb/BUILD.gn | 2 - .../renderer/modules/indexeddb/idb_factory.cc | 11 ++-- .../renderer/modules/indexeddb/idb_observation.cc | 2 +- .../blink/renderer/modules/indexeddb/idb_value.cc | 22 -------- .../blink/renderer/modules/indexeddb/idb_value.h | 15 +---- .../modules/indexeddb/indexed_db_callbacks_impl.cc | 55 +++++++++--------- .../modules/indexeddb/indexed_db_callbacks_impl.h | 5 +- .../modules/indexeddb/mock_web_idb_callbacks.cc | 9 +-- .../modules/indexeddb/mock_web_idb_callbacks.h | 17 +++--- .../renderer/modules/indexeddb/web_idb_callbacks.h | 10 ++-- .../modules/indexeddb/web_idb_callbacks_impl.cc | 35 +++++------- .../modules/indexeddb/web_idb_callbacks_impl.h | 10 ++-- .../modules/indexeddb/web_idb_cursor_impl.cc | 6 +- .../modules/indexeddb/web_idb_cursor_impl.h | 6 +- .../indexeddb/web_idb_cursor_impl_unittest.cc | 16 +++--- .../modules/indexeddb/web_idb_observation.h | 9 +-- .../renderer/modules/indexeddb/web_idb_value.cc | 55 ------------------ .../renderer/modules/indexeddb/web_idb_value.h | 65 ---------------------- 19 files changed, 100 insertions(+), 266 deletions(-) commit 124b041802d8db51ff1614ff429a3389acd5cdfc Author: Reilly Grant <reillyg@chromium.org> Date: Tue Dec 11 18:28:48 2018 +0000 Clean up sequences and sequence checking in //device/usb This change: * Switches all remaining SingleThreadTaskRunners to SequencedTaskRunners. * Switches all remaining ThreadCheckers to SequenceCheckers. * Removes shared TaskRunners wherever possible, preferring to use the task scheduler's PostTask() method or creating a dedicated TaskRunner when one is needed. * Renames FileThreadHelpers to BlockingTaskHelpers. * Adds base::ScopedBlockingCall annotations when calling into libusb functions that can potentially block. Change-Id: I538704faf7e668015c509bf2c8a03db6d0522fb3 Reviewed-on: https://chromium-review.googlesource.com/c/1368776 Reviewed-by: Ovidio Henriquez <odejesush@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615599} device/usb/mock_usb_service.cc | 2 +- device/usb/usb_context.h | 1 - device/usb/usb_device_handle.h | 1 - device/usb/usb_device_handle_impl.cc | 111 +++++++++++++++++++--------------- device/usb/usb_device_handle_impl.h | 24 ++++---- device/usb/usb_device_handle_usbfs.cc | 65 ++++++++++---------- device/usb/usb_device_handle_usbfs.h | 9 ++- device/usb/usb_device_handle_win.cc | 58 ++++++++++-------- device/usb/usb_device_handle_win.h | 18 ++---- device/usb/usb_device_impl.cc | 5 +- device/usb/usb_device_impl.h | 4 +- device/usb/usb_device_linux.cc | 6 +- device/usb/usb_device_linux.h | 2 +- device/usb/usb_device_win.cc | 45 +++++++------- device/usb/usb_device_win.h | 16 ++--- device/usb/usb_service.cc | 15 ++--- device/usb/usb_service.h | 12 +--- device/usb/usb_service_android.cc | 3 +- device/usb/usb_service_impl.cc | 63 ++++++++----------- device/usb/usb_service_impl.h | 2 + device/usb/usb_service_linux.cc | 30 ++++----- device/usb/usb_service_linux.h | 5 +- device/usb/usb_service_win.cc | 14 ++--- device/usb/usb_service_win.h | 1 + 24 files changed, 246 insertions(+), 266 deletions(-) commit 54c407df40a98eddd2e72ddca894ff860b3d6a33 Author: Krishna Govind <govind@chromium.org> Date: Tue Dec 11 18:28:39 2018 +0000 Updating XTBs based on .GRDs from branch master R=cmasso@chromium.org Change-Id: I0aa1ad64b28d9f2c919cf0441060f13c4c0d7388 Reviewed-on: https://chromium-review.googlesource.com/c/1371253 Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#615598} .../strings/ash_components_strings_am.xtb | 2 - .../strings/ash_components_strings_ar.xtb | 2 - .../strings/ash_components_strings_bg.xtb | 2 - .../strings/ash_components_strings_bn.xtb | 2 - .../strings/ash_components_strings_ca.xtb | 2 - .../strings/ash_components_strings_cs.xtb | 2 - .../strings/ash_components_strings_da.xtb | 2 - .../strings/ash_components_strings_de.xtb | 2 - .../strings/ash_components_strings_el.xtb | 2 - .../strings/ash_components_strings_en-GB.xtb | 2 - .../strings/ash_components_strings_es-419.xtb | 2 - .../strings/ash_components_strings_es.xtb | 2 - .../strings/ash_components_strings_et.xtb | 2 - .../strings/ash_components_strings_fa.xtb | 2 - .../strings/ash_components_strings_fi.xtb | 2 - .../strings/ash_components_strings_fil.xtb | 2 - .../strings/ash_components_strings_fr.xtb | 2 - .../strings/ash_components_strings_gu.xtb | 2 - .../strings/ash_components_strings_hi.xtb | 2 - .../strings/ash_components_strings_hr.xtb | 2 - .../strings/ash_components_strings_hu.xtb | 2 - .../strings/ash_components_strings_id.xtb | 2 - .../strings/ash_components_strings_it.xtb | 2 - .../strings/ash_components_strings_iw.xtb | 2 - .../strings/ash_components_strings_ja.xtb | 2 - .../strings/ash_components_strings_kn.xtb | 2 - .../strings/ash_components_strings_ko.xtb | 2 - .../strings/ash_components_strings_lt.xtb | 2 - .../strings/ash_components_strings_lv.xtb | 2 - .../strings/ash_components_strings_ml.xtb | 2 - .../strings/ash_components_strings_mr.xtb | 2 - .../strings/ash_components_strings_ms.xtb | 2 - .../strings/ash_components_strings_nl.xtb | 2 - .../strings/ash_components_strings_no.xtb | 2 - .../strings/ash_components_strings_pl.xtb | 2 - .../strings/ash_components_strings_pt-BR.xtb | 2 - .../strings/ash_components_strings_pt-PT.xtb | 2 - .../strings/ash_components_strings_ro.xtb | 2 - .../strings/ash_components_strings_ru.xtb | 2 - .../strings/ash_components_strings_sk.xtb | 2 - .../strings/ash_components_strings_sl.xtb | 2 - .../strings/ash_components_strings_sr.xtb | 2 - .../strings/ash_components_strings_sv.xtb | 2 - .../strings/ash_components_strings_sw.xtb | 2 - .../strings/ash_components_strings_ta.xtb | 2 - .../strings/ash_components_strings_te.xtb | 2 - .../strings/ash_components_strings_th.xtb | 2 - .../strings/ash_components_strings_tr.xtb | 2 - .../strings/ash_components_strings_uk.xtb | 2 - .../strings/ash_components_strings_vi.xtb | 2 - .../strings/ash_components_strings_zh-CN.xtb | 2 - .../strings/ash_components_strings_zh-TW.xtb | 2 - ash/strings/ash_strings_am.xtb | 11 +- ash/strings/ash_strings_ar.xtb | 11 +- ash/strings/ash_strings_bg.xtb | 9 ++ ash/strings/ash_strings_bn.xtb | 11 +- ash/strings/ash_strings_ca.xtb | 9 ++ ash/strings/ash_strings_cs.xtb | 9 ++ ash/strings/ash_strings_da.xtb | 9 ++ ash/strings/ash_strings_de.xtb | 9 ++ ash/strings/ash_strings_el.xtb | 9 ++ ash/strings/ash_strings_en-GB.xtb | 9 ++ ash/strings/ash_strings_es-419.xtb | 9 ++ ash/strings/ash_strings_es.xtb | 9 ++ ash/strings/ash_strings_et.xtb | 9 ++ ash/strings/ash_strings_fa.xtb | 9 ++ ash/strings/ash_strings_fi.xtb | 9 ++ ash/strings/ash_strings_fil.xtb | 9 ++ ash/strings/ash_strings_fr.xtb | 9 ++ ash/strings/ash_strings_gu.xtb | 11 +- ash/strings/ash_strings_hi.xtb | 9 ++ ash/strings/ash_strings_hr.xtb | 9 ++ ash/strings/ash_strings_hu.xtb | 11 +- ash/strings/ash_strings_id.xtb | 11 +- ash/strings/ash_strings_it.xtb | 9 ++ ash/strings/ash_strings_iw.xtb | 9 ++ ash/strings/ash_strings_ja.xtb | 9 ++ ash/strings/ash_strings_kn.xtb | 11 +- ash/strings/ash_strings_ko.xtb | 9 ++ ash/strings/ash_strings_lt.xtb | 11 +- ash/strings/ash_strings_lv.xtb | 11 +- ash/strings/ash_strings_ml.xtb | 11 +- ash/strings/ash_strings_mr.xtb | 9 ++ ash/strings/ash_strings_ms.xtb | 9 ++ ash/strings/ash_strings_nl.xtb | 9 ++ ash/strings/ash_strings_no.xtb | 9 ++ ash/strings/ash_strings_pl.xtb | 9 ++ ash/strings/ash_strings_pt-BR.xtb | 9 ++ ash/strings/ash_strings_pt-PT.xtb | 9 ++ ash/strings/ash_strings_ro.xtb | 9 ++ ash/strings/ash_strings_ru.xtb | 11 +- ash/strings/ash_strings_sk.xtb | 9 ++ ash/strings/ash_strings_sl.xtb | 11 +- ash/strings/ash_strings_sr.xtb | 11 +- ash/strings/ash_strings_sv.xtb | 9 ++ ash/strings/ash_strings_sw.xtb | 9 ++ ash/strings/ash_strings_ta.xtb | 9 ++ ash/strings/ash_strings_te.xtb | 11 +- ash/strings/ash_strings_th.xtb | 11 +- ash/strings/ash_strings_tr.xtb | 11 +- ash/strings/ash_strings_uk.xtb | 9 ++ ash/strings/ash_strings_vi.xtb | 9 ++ ash/strings/ash_strings_zh-CN.xtb | 9 ++ ash/strings/ash_strings_zh-TW.xtb | 3 + .../translations/android_chrome_strings_am.xtb | 24 +++- .../translations/android_chrome_strings_ar.xtb | 26 ++++- .../translations/android_chrome_strings_bg.xtb | 24 +++- .../translations/android_chrome_strings_bn.xtb | 26 ++++- .../translations/android_chrome_strings_ca.xtb | 22 +++- .../translations/android_chrome_strings_cs.xtb | 24 +++- .../translations/android_chrome_strings_da.xtb | 24 +++- .../translations/android_chrome_strings_de.xtb | 22 +++- .../translations/android_chrome_strings_el.xtb | 24 +++- .../translations/android_chrome_strings_en-GB.xtb | 22 +++- .../translations/android_chrome_strings_es-419.xtb | 24 +++- .../translations/android_chrome_strings_es.xtb | 24 +++- .../translations/android_chrome_strings_et.xtb | 22 +++- .../translations/android_chrome_strings_fa.xtb | 22 +++- .../translations/android_chrome_strings_fi.xtb | 22 +++- .../translations/android_chrome_strings_fil.xtb | 24 +++- .../translations/android_chrome_strings_fr.xtb | 22 +++- .../translations/android_chrome_strings_gu.xtb | 24 +++- .../translations/android_chrome_strings_hi.xtb | 24 +++- .../translations/android_chrome_strings_hr.xtb | 24 +++- .../translations/android_chrome_strings_hu.xtb | 26 ++++- .../translations/android_chrome_strings_id.xtb | 28 ++++- .../translations/android_chrome_strings_it.xtb | 24 +++- .../translations/android_chrome_strings_iw.xtb | 26 ++++- .../translations/android_chrome_strings_ja.xtb | 26 ++++- .../translations/android_chrome_strings_kn.xtb | 24 +++- .../translations/android_chrome_strings_ko.xtb | 22 +++- .../translations/android_chrome_strings_lt.xtb | 28 ++++- .../translations/android_chrome_strings_lv.xtb | 26 ++++- .../translations/android_chrome_strings_ml.xtb | 26 ++++- .../translations/android_chrome_strings_mr.xtb | 22 +++- .../translations/android_chrome_strings_ms.xtb | 22 +++- .../translations/android_chrome_strings_nl.xtb | 22 +++- .../translations/android_chrome_strings_no.xtb | 22 +++- .../translations/android_chrome_strings_pl.xtb | 24 +++- .../translations/android_chrome_strings_pt-BR.xtb | 24 +++- .../translations/android_chrome_strings_pt-PT.xtb | 24 +++- .../translations/android_chrome_strings_ro.xtb | 22 +++- .../translations/android_chrome_strings_ru.xtb | 28 ++++- .../translations/android_chrome_strings_sk.xtb | 24 +++- .../translations/android_chrome_strings_sl.xtb | 26 ++++- .../translations/android_chrome_strings_sr.xtb | 28 ++++- .../translations/android_chrome_strings_sv.xtb | 24 +++- .../translations/android_chrome_strings_sw.xtb | 26 ++++- .../translations/android_chrome_strings_ta.xtb | 24 +++- .../translations/android_chrome_strings_te.xtb | 42 +++++-- .../translations/android_chrome_strings_th.xtb | 26 ++++- .../translations/android_chrome_strings_tr.xtb | 26 ++++- .../translations/android_chrome_strings_uk.xtb | 22 +++- .../translations/android_chrome_strings_vi.xtb | 22 +++- .../translations/android_chrome_strings_zh-CN.xtb | 24 +++- .../translations/android_chrome_strings_zh-TW.xtb | 1 - chrome/app/resources/chromium_strings_am.xtb | 1 - chrome/app/resources/chromium_strings_ar.xtb | 1 - chrome/app/resources/chromium_strings_bg.xtb | 1 - chrome/app/resources/chromium_strings_bn.xtb | 1 - chrome/app/resources/chromium_strings_ca.xtb | 1 - chrome/app/resources/chromium_strings_cs.xtb | 1 - chrome/app/resources/chromium_strings_da.xtb | 1 - chrome/app/resources/chromium_strings_de.xtb | 1 - chrome/app/resources/chromium_strings_el.xtb | 1 - chrome/app/resources/chromium_strings_en-GB.xtb | 1 - chrome/app/resources/chromium_strings_es-419.xtb | 1 - chrome/app/resources/chromium_strings_es.xtb | 1 - chrome/app/resources/chromium_strings_et.xtb | 1 - chrome/app/resources/chromium_strings_fa.xtb | 1 - chrome/app/resources/chromium_strings_fi.xtb | 1 - chrome/app/resources/chromium_strings_fil.xtb | 1 - chrome/app/resources/chromium_strings_fr.xtb | 1 - chrome/app/resources/chromium_strings_gu.xtb | 1 - chrome/app/resources/chromium_strings_hi.xtb | 1 - chrome/app/resources/chromium_strings_hr.xtb | 1 - chrome/app/resources/chromium_strings_hu.xtb | 1 - chrome/app/resources/chromium_strings_id.xtb | 1 - chrome/app/resources/chromium_strings_it.xtb | 1 - chrome/app/resources/chromium_strings_iw.xtb | 1 - chrome/app/resources/chromium_strings_ja.xtb | 1 - chrome/app/resources/chromium_strings_kn.xtb | 1 - chrome/app/resources/chromium_strings_ko.xtb | 1 - chrome/app/resources/chromium_strings_lt.xtb | 1 - chrome/app/resources/chromium_strings_lv.xtb | 1 - chrome/app/resources/chromium_strings_ml.xtb | 1 - chrome/app/resources/chromium_strings_mr.xtb | 1 - chrome/app/resources/chromium_strings_ms.xtb | 1 - chrome/app/resources/chromium_strings_nl.xtb | 1 - chrome/app/resources/chromium_strings_no.xtb | 1 - chrome/app/resources/chromium_strings_pl.xtb | 1 - chrome/app/resources/chromium_strings_pt-BR.xtb | 1 - chrome/app/resources/chromium_strings_pt-PT.xtb | 1 - chrome/app/resources/chromium_strings_ro.xtb | 1 - chrome/app/resources/chromium_strings_ru.xtb | 1 - chrome/app/resources/chromium_strings_sk.xtb | 1 - chrome/app/resources/chromium_strings_sl.xtb | 1 - chrome/app/resources/chromium_strings_sr.xtb | 1 - chrome/app/resources/chromium_strings_sv.xtb | 1 - chrome/app/resources/chromium_strings_sw.xtb | 1 - chrome/app/resources/chromium_strings_ta.xtb | 1 - chrome/app/resources/chromium_strings_te.xtb | 28 ++--- chrome/app/resources/chromium_strings_th.xtb | 1 - chrome/app/resources/chromium_strings_tr.xtb | 1 - chrome/app/resources/chromium_strings_uk.xtb | 1 - chrome/app/resources/chromium_strings_vi.xtb | 1 - chrome/app/resources/chromium_strings_zh-CN.xtb | 1 - chrome/app/resources/chromium_strings_zh-TW.xtb | 1 - chrome/app/resources/generated_resources_am.xtb | 24 ++-- chrome/app/resources/generated_resources_ar.xtb | 34 +++--- chrome/app/resources/generated_resources_bg.xtb | 26 +++-- chrome/app/resources/generated_resources_bn.xtb | 28 +++-- chrome/app/resources/generated_resources_ca.xtb | 24 ++-- chrome/app/resources/generated_resources_cs.xtb | 26 +++-- chrome/app/resources/generated_resources_da.xtb | 24 ++-- chrome/app/resources/generated_resources_de.xtb | 24 ++-- chrome/app/resources/generated_resources_el.xtb | 24 ++-- chrome/app/resources/generated_resources_en-GB.xtb | 22 ++-- .../app/resources/generated_resources_es-419.xtb | 28 +++-- chrome/app/resources/generated_resources_es.xtb | 28 +++-- chrome/app/resources/generated_resources_et.xtb | 24 ++-- chrome/app/resources/generated_resources_fa.xtb | 24 ++-- chrome/app/resources/generated_resources_fi.xtb | 24 ++-- chrome/app/resources/generated_resources_fil.xtb | 24 ++-- chrome/app/resources/generated_resources_fr.xtb | 24 ++-- chrome/app/resources/generated_resources_gu.xtb | 24 ++-- chrome/app/resources/generated_resources_hi.xtb | 24 ++-- chrome/app/resources/generated_resources_hr.xtb | 28 +++-- chrome/app/resources/generated_resources_hu.xtb | 30 +++-- chrome/app/resources/generated_resources_id.xtb | 28 +++-- chrome/app/resources/generated_resources_it.xtb | 26 +++-- chrome/app/resources/generated_resources_iw.xtb | 26 +++-- chrome/app/resources/generated_resources_ja.xtb | 28 +++-- chrome/app/resources/generated_resources_kn.xtb | 30 +++-- chrome/app/resources/generated_resources_ko.xtb | 22 ++-- chrome/app/resources/generated_resources_lt.xtb | 32 ++--- chrome/app/resources/generated_resources_lv.xtb | 28 +++-- chrome/app/resources/generated_resources_ml.xtb | 41 ++++--- chrome/app/resources/generated_resources_mr.xtb | 22 ++-- chrome/app/resources/generated_resources_ms.xtb | 22 ++-- chrome/app/resources/generated_resources_nl.xtb | 24 ++-- chrome/app/resources/generated_resources_no.xtb | 32 ++--- chrome/app/resources/generated_resources_pl.xtb | 26 +++-- chrome/app/resources/generated_resources_pt-BR.xtb | 26 +++-- chrome/app/resources/generated_resources_pt-PT.xtb | 24 ++-- chrome/app/resources/generated_resources_ro.xtb | 26 +++-- chrome/app/resources/generated_resources_ru.xtb | 30 +++-- chrome/app/resources/generated_resources_sk.xtb | 26 +++-- chrome/app/resources/generated_resources_sl.xtb | 28 +++-- chrome/app/resources/generated_resources_sr.xtb | 28 +++-- chrome/app/resources/generated_resources_sv.xtb | 24 ++-- chrome/app/resources/generated_resources_sw.xtb | 28 +++-- chrome/app/resources/generated_resources_ta.xtb | 24 ++-- chrome/app/resources/generated_resources_te.xtb | 130 +++++++++++---------- chrome/app/resources/generated_resources_th.xtb | 30 +++-- chrome/app/resources/generated_resources_tr.xtb | 26 +++-- chrome/app/resources/generated_resources_uk.xtb | 26 +++-- chrome/app/resources/generated_resources_vi.xtb | 26 +++-- chrome/app/resources/generated_resources_zh-CN.xtb | 26 +++-- chrome/app/resources/generated_resources_zh-TW.xtb | 13 +-- chrome/app/resources/google_chrome_strings_am.xtb | 1 - chrome/app/resources/google_chrome_strings_ar.xtb | 1 - chrome/app/resources/google_chrome_strings_bg.xtb | 1 - chrome/app/resources/google_chrome_strings_bn.xtb | 1 - chrome/app/resources/google_chrome_strings_ca.xtb | 1 - chrome/app/resources/google_chrome_strings_cs.xtb | 1 - chrome/app/resources/google_chrome_strings_da.xtb | 1 - chrome/app/resources/google_chrome_strings_de.xtb | 1 - chrome/app/resources/google_chrome_strings_el.xtb | 1 - .../app/resources/google_chrome_strings_en-GB.xtb | 1 - .../app/resources/google_chrome_strings_es-419.xtb | 1 - chrome/app/resources/google_chrome_strings_es.xtb | 1 - chrome/app/resources/google_chrome_strings_et.xtb | 1 - chrome/app/resources/google_chrome_strings_fa.xtb | 1 - chrome/app/resources/google_chrome_strings_fi.xtb | 1 - chrome/app/resources/google_chrome_strings_fil.xtb | 1 - chrome/app/resources/google_chrome_strings_fr.xtb | 1 - chrome/app/resources/google_chrome_strings_gu.xtb | 1 - chrome/app/resources/google_chrome_strings_hi.xtb | 1 - chrome/app/resources/google_chrome_strings_hr.xtb | 1 - chrome/app/resources/google_chrome_strings_hu.xtb | 1 - chrome/app/resources/google_chrome_strings_id.xtb | 1 - chrome/app/resources/google_chrome_strings_it.xtb | 1 - chrome/app/resources/google_chrome_strings_iw.xtb | 1 - chrome/app/resources/google_chrome_strings_ja.xtb | 1 - chrome/app/resources/google_chrome_strings_kn.xtb | 1 - chrome/app/resources/google_chrome_strings_ko.xtb | 1 - chrome/app/resources/google_chrome_strings_lt.xtb | 1 - chrome/app/resources/google_chrome_strings_lv.xtb | 1 - chrome/app/resources/google_chrome_strings_ml.xtb | 1 - chrome/app/resources/google_chrome_strings_mr.xtb | 1 - chrome/app/resources/google_chrome_strings_ms.xtb | 1 - chrome/app/resources/google_chrome_strings_nl.xtb | 1 - chrome/app/resources/google_chrome_strings_no.xtb | 1 - chrome/app/resources/google_chrome_strings_pl.xtb | 1 - .../app/resources/google_chrome_strings_pt-BR.xtb | 1 - .../app/resources/google_chrome_strings_pt-PT.xtb | 1 - chrome/app/resources/google_chrome_strings_ro.xtb | 1 - chrome/app/resources/google_chrome_strings_ru.xtb | 1 - chrome/app/resources/google_chrome_strings_sk.xtb | 1 - chrome/app/resources/google_chrome_strings_sl.xtb | 1 - chrome/app/resources/google_chrome_strings_sr.xtb | 1 - chrome/app/resources/google_chrome_strings_sv.xtb | 1 - chrome/app/resources/google_chrome_strings_sw.xtb | 1 - chrome/app/resources/google_chrome_strings_ta.xtb | 1 - chrome/app/resources/google_chrome_strings_te.xtb | 27 +++-- chrome/app/resources/google_chrome_strings_th.xtb | 1 - chrome/app/resources/google_chrome_strings_tr.xtb | 1 - chrome/app/resources/google_chrome_strings_uk.xtb | 1 - chrome/app/resources/google_chrome_strings_vi.xtb | 1 - .../app/resources/google_chrome_strings_zh-CN.xtb | 1 - .../app/resources/google_chrome_strings_zh-TW.xtb | 1 - .../chromevox/strings/chromevox_strings_am.xtb | 6 + .../chromevox/strings/chromevox_strings_ar.xtb | 6 + .../chromevox/strings/chromevox_strings_bg.xtb | 6 + .../chromevox/strings/chromevox_strings_bn.xtb | 6 + .../chromevox/strings/chromevox_strings_ca.xtb | 6 + .../chromevox/strings/chromevox_strings_cs.xtb | 6 + .../chromevox/strings/chromevox_strings_da.xtb | 6 + .../chromevox/strings/chromevox_strings_de.xtb | 6 + .../chromevox/strings/chromevox_strings_el.xtb | 6 + .../chromevox/strings/chromevox_strings_en-GB.xtb | 6 + .../chromevox/strings/chromevox_strings_es-419.xtb | 6 + .../chromevox/strings/chromevox_strings_es.xtb | 6 + .../chromevox/strings/chromevox_strings_et.xtb | 6 + .../chromevox/strings/chromevox_strings_fa.xtb | 6 + .../chromevox/strings/chromevox_strings_fi.xtb | 6 + .../chromevox/strings/chromevox_strings_fil.xtb | 6 + .../chromevox/strings/chromevox_strings_fr.xtb | 6 + .../chromevox/strings/chromevox_strings_gu.xtb | 6 + .../chromevox/strings/chromevox_strings_hi.xtb | 8 +- .../chromevox/strings/chromevox_strings_hr.xtb | 8 +- .../chromevox/strings/chromevox_strings_hu.xtb | 8 +- .../chromevox/strings/chromevox_strings_id.xtb | 6 + .../chromevox/strings/chromevox_strings_it.xtb | 6 + .../chromevox/strings/chromevox_strings_iw.xtb | 6 + .../chromevox/strings/chromevox_strings_ja.xtb | 6 + .../chromevox/strings/chromevox_strings_kn.xtb | 6 + .../chromevox/strings/chromevox_strings_ko.xtb | 6 + .../chromevox/strings/chromevox_strings_lt.xtb | 8 +- .../chromevox/strings/chromevox_strings_lv.xtb | 8 +- .../chromevox/strings/chromevox_strings_ml.xtb | 6 + .../chromevox/strings/chromevox_strings_mr.xtb | 6 + .../chromevox/strings/chromevox_strings_ms.xtb | 6 + .../chromevox/strings/chromevox_strings_nl.xtb | 6 + .../chromevox/strings/chromevox_strings_no.xtb | 6 + .../chromevox/strings/chromevox_strings_pl.xtb | 6 + .../chromevox/strings/chromevox_strings_pt-BR.xtb | 6 + .../chromevox/strings/chromevox_strings_pt-PT.xtb | 6 + .../chromevox/strings/chromevox_strings_ro.xtb | 6 + .../chromevox/strings/chromevox_strings_ru.xtb | 6 + .../chromevox/strings/chromevox_strings_sk.xtb | 6 + .../chromevox/strings/chromevox_strings_sl.xtb | 6 + .../chromevox/strings/chromevox_strings_sr.xtb | 6 + .../chromevox/strings/chromevox_strings_sv.xtb | 6 + .../chromevox/strings/chromevox_strings_sw.xtb | 8 +- .../chromevox/strings/chromevox_strings_ta.xtb | 8 +- .../chromevox/strings/chromevox_strings_te.xtb | 6 + .../chromevox/strings/chromevox_strings_th.xtb | 6 + .../chromevox/strings/chromevox_strings_tr.xtb | 8 +- .../chromevox/strings/chromevox_strings_uk.xtb | 6 + .../chromevox/strings/chromevox_strings_vi.xtb | 6 + .../chromevox/strings/chromevox_strings_zh-CN.xtb | 8 +- .../chromevox/strings/chromevox_strings_zh-TW.xtb | 1 + chromeos/strings/chromeos_strings_am.xtb | 4 - chromeos/strings/chromeos_strings_ar.xtb | 4 - chromeos/strings/chromeos_strings_bg.xtb | 4 - chromeos/strings/chromeos_strings_bn.xtb | 4 - chromeos/strings/chromeos_strings_ca.xtb | 4 - chromeos/strings/chromeos_strings_cs.xtb | 4 - chromeos/strings/chromeos_strings_da.xtb | 4 - chromeos/strings/chromeos_strings_de.xtb | 4 - chromeos/strings/chromeos_strings_el.xtb | 4 - chromeos/strings/chromeos_strings_en-GB.xtb | 4 - chromeos/strings/chromeos_strings_es-419.xtb | 4 - chromeos/strings/chromeos_strings_es.xtb | 4 - chromeos/strings/chromeos_strings_et.xtb | 4 - chromeos/strings/chromeos_strings_fa.xtb | 4 - chromeos/strings/chromeos_strings_fi.xtb | 4 - chromeos/strings/chromeos_strings_fil.xtb | 4 - chromeos/strings/chromeos_strings_fr.xtb | 4 - chromeos/strings/chromeos_strings_gu.xtb | 4 - chromeos/strings/chromeos_strings_hi.xtb | 4 - chromeos/strings/chromeos_strings_hr.xtb | 4 - chromeos/strings/chromeos_strings_hu.xtb | 4 - chromeos/strings/chromeos_strings_id.xtb | 4 - chromeos/strings/chromeos_strings_it.xtb | 4 - chromeos/strings/chromeos_strings_iw.xtb | 4 - chromeos/strings/chromeos_strings_ja.xtb | 4 - chromeos/strings/chromeos_strings_kn.xtb | 4 - chromeos/strings/chromeos_strings_ko.xtb | 4 - chromeos/strings/chromeos_strings_lt.xtb | 4 - chromeos/strings/chromeos_strings_lv.xtb | 4 - chromeos/strings/chromeos_strings_ml.xtb | 4 - chromeos/strings/chromeos_strings_mr.xtb | 4 - chromeos/strings/chromeos_strings_ms.xtb | 4 - chromeos/strings/chromeos_strings_nl.xtb | 4 - chromeos/strings/chromeos_strings_no.xtb | 4 - chromeos/strings/chromeos_strings_pl.xtb | 4 - chromeos/strings/chromeos_strings_pt-BR.xtb | 4 - chromeos/strings/chromeos_strings_pt-PT.xtb | 4 - chromeos/strings/chromeos_strings_ro.xtb | 4 - chromeos/strings/chromeos_strings_ru.xtb | 4 - chromeos/strings/chromeos_strings_sk.xtb | 4 - chromeos/strings/chromeos_strings_sl.xtb | 4 - chromeos/strings/chromeos_strings_sr.xtb | 4 - chromeos/strings/chromeos_strings_sv.xtb | 4 - chromeos/strings/chromeos_strings_sw.xtb | 4 - chromeos/strings/chromeos_strings_ta.xtb | 4 - chromeos/strings/chromeos_strings_te.xtb | 4 - chromeos/strings/chromeos_strings_th.xtb | 4 - chromeos/strings/chromeos_strings_tr.xtb | 4 - chromeos/strings/chromeos_strings_uk.xtb | 4 - chromeos/strings/chromeos_strings_vi.xtb | 4 - chromeos/strings/chromeos_strings_zh-CN.xtb | 4 - chromeos/strings/chromeos_strings_zh-TW.xtb | 4 - .../policy/resources/policy_templates_am.xtb | 9 ++ .../policy/resources/policy_templates_ar.xtb | 11 +- .../policy/resources/policy_templates_bg.xtb | 9 ++ .../policy/resources/policy_templates_bn.xtb | 11 +- .../policy/resources/policy_templates_ca.xtb | 13 ++- .../policy/resources/policy_templates_cs.xtb | 9 ++ .../policy/resources/policy_templates_da.xtb | 9 ++ .../policy/resources/policy_templates_de.xtb | 9 ++ .../policy/resources/policy_templates_el.xtb | 9 ++ .../policy/resources/policy_templates_en-GB.xtb | 9 ++ .../policy/resources/policy_templates_es-419.xtb | 15 ++- .../policy/resources/policy_templates_es.xtb | 9 ++ .../policy/resources/policy_templates_et.xtb | 9 ++ .../policy/resources/policy_templates_fa.xtb | 9 ++ .../policy/resources/policy_templates_fi.xtb | 9 ++ .../policy/resources/policy_templates_fil.xtb | 9 ++ .../policy/resources/policy_templates_fr.xtb | 11 +- .../policy/resources/policy_templates_gu.xtb | 9 ++ .../policy/resources/policy_templates_hi.xtb | 9 ++ .../policy/resources/policy_templates_hr.xtb | 9 ++ .../policy/resources/policy_templates_hu.xtb | 9 ++ .../policy/resources/policy_templates_id.xtb | 9 ++ .../policy/resources/policy_templates_it.xtb | 11 +- .../policy/resources/policy_templates_iw.xtb | 9 ++ .../policy/resources/policy_templates_ja.xtb | 9 ++ .../policy/resources/policy_templates_kn.xtb | 15 ++- .../policy/resources/policy_templates_ko.xtb | 9 ++ .../policy/resources/policy_templates_lt.xtb | 9 ++ .../policy/resources/policy_templates_lv.xtb | 9 ++ .../policy/resources/policy_templates_ml.xtb | 19 ++- .../policy/resources/policy_templates_mr.xtb | 9 ++ .../policy/resources/policy_templates_ms.xtb | 9 ++ .../policy/resources/policy_templates_nl.xtb | 13 ++- .../policy/resources/policy_templates_no.xtb | 9 ++ .../policy/resources/policy_templates_pl.xtb | 9 ++ .../policy/resources/policy_templates_pt-BR.xtb | 17 ++- .../policy/resources/policy_templates_pt-PT.xtb | 15 ++- .../policy/resources/policy_templates_ro.xtb | 9 ++ .../policy/resources/policy_templates_ru.xtb | 9 ++ .../policy/resources/policy_templates_sk.xtb | 11 +- .../policy/resources/policy_templates_sl.xtb | 9 ++ .../policy/resources/policy_templates_sr.xtb | 9 ++ .../policy/resources/policy_templates_sv.xtb | 9 ++ .../policy/resources/policy_templates_sw.xtb | 9 ++ .../policy/resources/policy_templates_ta.xtb | 15 ++- .../policy/resources/policy_templates_te.xtb | 73 +++++++----- .../policy/resources/policy_templates_th.xtb | 11 +- .../policy/resources/policy_templates_tr.xtb | 13 ++- .../policy/resources/policy_templates_uk.xtb | 11 +- .../policy/resources/policy_templates_vi.xtb | 15 ++- .../policy/resources/policy_templates_zh-CN.xtb | 9 ++ components/strings/components_strings_am.xtb | 20 ++-- components/strings/components_strings_ar.xtb | 28 ++--- components/strings/components_strings_bg.xtb | 14 +-- components/strings/components_strings_bn.xtb | 20 ++-- components/strings/components_strings_ca.xtb | 14 +-- components/strings/components_strings_cs.xtb | 22 ++-- components/strings/components_strings_da.xtb | 16 +-- components/strings/components_strings_de.xtb | 16 +-- components/strings/components_strings_el.xtb | 20 ++-- components/strings/components_strings_en-GB.xtb | 12 +- components/strings/components_strings_es-419.xtb | 12 +- components/strings/components_strings_es.xtb | 14 +-- components/strings/components_strings_et.xtb | 16 +-- components/strings/components_strings_fa.xtb | 24 ++-- components/strings/components_strings_fi.xtb | 12 +- components/strings/components_strings_fil.xtb | 22 ++-- components/strings/components_strings_fr.xtb | 12 +- components/strings/components_strings_gu.xtb | 22 ++-- components/strings/components_strings_hi.xtb | 14 +-- components/strings/components_strings_hr.xtb | 18 ++- components/strings/components_strings_hu.xtb | 18 ++- components/strings/components_strings_id.xtb | 20 ++-- components/strings/components_strings_it.xtb | 16 +-- components/strings/components_strings_iw.xtb | 18 ++- components/strings/components_strings_ja.xtb | 14 +-- components/strings/components_strings_kn.xtb | 16 +-- components/strings/components_strings_ko.xtb | 20 ++-- components/strings/components_strings_lt.xtb | 18 ++- components/strings/components_strings_lv.xtb | 16 +-- components/strings/components_strings_ml.xtb | 16 +-- components/strings/components_strings_mr.xtb | 14 +-- components/strings/components_strings_ms.xtb | 12 +- components/strings/components_strings_nl.xtb | 12 +- components/strings/components_strings_no.xtb | 16 +-- components/strings/components_strings_pl.xtb | 14 +-- components/strings/components_strings_pt-BR.xtb | 14 +-- components/strings/components_strings_pt-PT.xtb | 18 ++- components/strings/components_strings_ro.xtb | 10 +- components/strings/components_strings_ru.xtb | 22 ++-- components/strings/components_strings_sk.xtb | 18 ++- components/strings/components_strings_sl.xtb | 24 ++-- components/strings/components_strings_sr.xtb | 18 ++- components/strings/components_strings_sv.xtb | 16 +-- components/strings/components_strings_sw.xtb | 18 ++- components/strings/components_strings_ta.xtb | 14 +-- components/strings/components_strings_te.xtb | 50 ++++---- components/strings/components_strings_th.xtb | 24 ++-- components/strings/components_strings_tr.xtb | 24 ++-- components/strings/components_strings_uk.xtb | 24 ++-- components/strings/components_strings_vi.xtb | 24 ++-- components/strings/components_strings_zh-CN.xtb | 18 ++- components/strings/components_strings_zh-TW.xtb | 21 ++-- .../strings/translations/content_strings_te.xtb | 8 +- extensions/strings/extensions_strings_te.xtb | 2 +- .../strings/resources/ios_chromium_strings_te.xtb | 2 +- .../resources/ios_google_chrome_strings_te.xtb | 2 +- .../app/strings/resources/ios_strings_am.xtb | 4 +- .../app/strings/resources/ios_strings_ar.xtb | 4 +- .../app/strings/resources/ios_strings_bg.xtb | 2 +- .../app/strings/resources/ios_strings_bn.xtb | 6 +- .../app/strings/resources/ios_strings_ca.xtb | 2 +- .../app/strings/resources/ios_strings_cs.xtb | 4 +- .../app/strings/resources/ios_strings_da.xtb | 2 +- .../app/strings/resources/ios_strings_de.xtb | 2 +- .../app/strings/resources/ios_strings_el.xtb | 5 +- .../app/strings/resources/ios_strings_en-GB.xtb | 2 +- .../app/strings/resources/ios_strings_es-419.xtb | 2 +- .../app/strings/resources/ios_strings_es.xtb | 2 +- .../app/strings/resources/ios_strings_et.xtb | 2 +- .../app/strings/resources/ios_strings_fa.xtb | 2 +- .../app/strings/resources/ios_strings_fi.xtb | 2 +- .../app/strings/resources/ios_strings_fil.xtb | 4 +- .../app/strings/resources/ios_strings_fr.xtb | 2 +- .../app/strings/resources/ios_strings_gu.xtb | 4 +- .../app/strings/resources/ios_strings_hi.xtb | 2 +- .../app/strings/resources/ios_strings_hr.xtb | 4 +- .../app/strings/resources/ios_strings_hu.xtb | 4 +- .../app/strings/resources/ios_strings_id.xtb | 6 +- .../app/strings/resources/ios_strings_it.xtb | 2 +- .../app/strings/resources/ios_strings_iw.xtb | 2 +- .../app/strings/resources/ios_strings_ja.xtb | 6 +- .../app/strings/resources/ios_strings_kn.xtb | 6 +- .../app/strings/resources/ios_strings_ko.xtb | 2 +- .../app/strings/resources/ios_strings_lt.xtb | 4 +- .../app/strings/resources/ios_strings_lv.xtb | 4 +- .../app/strings/resources/ios_strings_ml.xtb | 6 +- .../app/strings/resources/ios_strings_mr.xtb | 2 +- .../app/strings/resources/ios_strings_ms.xtb | 2 +- .../app/strings/resources/ios_strings_nl.xtb | 2 +- .../app/strings/resources/ios_strings_no.xtb | 4 +- .../app/strings/resources/ios_strings_pl.xtb | 2 +- .../app/strings/resources/ios_strings_pt-BR.xtb | 2 +- .../app/strings/resources/ios_strings_pt-PT.xtb | 4 +- .../app/strings/resources/ios_strings_ro.xtb | 2 +- .../app/strings/resources/ios_strings_ru.xtb | 6 +- .../app/strings/resources/ios_strings_sk.xtb | 2 +- .../app/strings/resources/ios_strings_sl.xtb | 4 +- .../app/strings/resources/ios_strings_sr.xtb | 4 +- .../app/strings/resources/ios_strings_sv.xtb | 2 +- .../app/strings/resources/ios_strings_sw.xtb | 2 +- .../app/strings/resources/ios_strings_ta.xtb | 4 +- .../app/strings/resources/ios_strings_te.xtb | 12 +- .../app/strings/resources/ios_strings_th.xtb | 6 +- .../app/strings/resources/ios_strings_tr.xtb | 4 +- .../app/strings/resources/ios_strings_uk.xtb | 2 +- .../app/strings/resources/ios_strings_vi.xtb | 2 +- .../app/strings/resources/ios_strings_zh-CN.xtb | 2 +- .../app/strings/resources/ios_strings_zh-TW.xtb | 1 - remoting/resources/remoting_strings_am.xtb | 2 +- remoting/resources/remoting_strings_ar.xtb | 2 +- remoting/resources/remoting_strings_bn.xtb | 2 +- remoting/resources/remoting_strings_es.xtb | 2 +- remoting/resources/remoting_strings_gu.xtb | 2 +- remoting/resources/remoting_strings_hu.xtb | 2 +- remoting/resources/remoting_strings_id.xtb | 2 +- remoting/resources/remoting_strings_kn.xtb | 2 +- remoting/resources/remoting_strings_lt.xtb | 2 +- remoting/resources/remoting_strings_lv.xtb | 2 +- remoting/resources/remoting_strings_ml.xtb | 2 +- remoting/resources/remoting_strings_ru.xtb | 2 +- remoting/resources/remoting_strings_sl.xtb | 2 +- remoting/resources/remoting_strings_sr.xtb | 4 +- remoting/resources/remoting_strings_te.xtb | 20 ++-- remoting/resources/remoting_strings_th.xtb | 2 +- remoting/resources/remoting_strings_tr.xtb | 2 +- .../resources/address_input_strings_am.xtb | 8 +- .../resources/address_input_strings_ar.xtb | 16 +-- .../resources/address_input_strings_bg.xtb | 4 +- .../resources/address_input_strings_bn.xtb | 6 +- .../resources/address_input_strings_ca.xtb | 4 +- .../resources/address_input_strings_cs.xtb | 12 +- .../resources/address_input_strings_da.xtb | 6 +- .../resources/address_input_strings_de.xtb | 6 +- .../resources/address_input_strings_el.xtb | 10 +- .../resources/address_input_strings_en-GB.xtb | 4 +- .../resources/address_input_strings_es-419.xtb | 2 +- .../resources/address_input_strings_es.xtb | 4 +- .../resources/address_input_strings_et.xtb | 6 +- .../resources/address_input_strings_fa.xtb | 14 +-- .../resources/address_input_strings_fi.xtb | 2 +- .../resources/address_input_strings_fil.xtb | 10 +- .../resources/address_input_strings_fr.xtb | 2 +- .../resources/address_input_strings_gu.xtb | 10 +- .../resources/address_input_strings_hi.xtb | 2 +- .../resources/address_input_strings_hr.xtb | 6 +- .../resources/address_input_strings_hu.xtb | 4 +- .../resources/address_input_strings_id.xtb | 6 +- .../resources/address_input_strings_it.xtb | 6 +- .../resources/address_input_strings_iw.xtb | 8 +- .../resources/address_input_strings_ja.xtb | 2 +- .../resources/address_input_strings_kn.xtb | 2 +- .../resources/address_input_strings_ko.xtb | 10 +- .../resources/address_input_strings_lt.xtb | 4 +- .../resources/address_input_strings_lv.xtb | 2 +- .../resources/address_input_strings_ml.xtb | 4 +- .../resources/address_input_strings_mr.xtb | 4 +- .../resources/address_input_strings_ms.xtb | 2 +- .../resources/address_input_strings_nl.xtb | 2 +- .../resources/address_input_strings_no.xtb | 6 +- .../resources/address_input_strings_pl.xtb | 4 +- .../resources/address_input_strings_pt-BR.xtb | 4 +- .../resources/address_input_strings_pt-PT.xtb | 6 +- .../resources/address_input_strings_ru.xtb | 8 +- .../resources/address_input_strings_sk.xtb | 8 +- .../resources/address_input_strings_sl.xtb | 12 +- .../resources/address_input_strings_sr.xtb | 6 +- .../resources/address_input_strings_sv.xtb | 6 +- .../resources/address_input_strings_sw.xtb | 6 +- .../resources/address_input_strings_ta.xtb | 2 +- .../resources/address_input_strings_th.xtb | 8 +- .../resources/address_input_strings_tr.xtb | 8 +- .../resources/address_input_strings_uk.xtb | 12 +- .../resources/address_input_strings_vi.xtb | 12 +- .../resources/address_input_strings_zh-CN.xtb | 6 +- .../resources/address_input_strings_zh-TW.xtb | 14 +-- .../translations/ui_chromeos_strings_te.xtb | 18 +-- ui/strings/translations/ui_strings_am.xtb | 1 - ui/strings/translations/ui_strings_ar.xtb | 1 - ui/strings/translations/ui_strings_bg.xtb | 1 - ui/strings/translations/ui_strings_bn.xtb | 1 - ui/strings/translations/ui_strings_ca.xtb | 1 - ui/strings/translations/ui_strings_cs.xtb | 1 - ui/strings/translations/ui_strings_da.xtb | 1 - ui/strings/translations/ui_strings_de.xtb | 1 - ui/strings/translations/ui_strings_el.xtb | 1 - ui/strings/translations/ui_strings_en-GB.xtb | 1 - ui/strings/translations/ui_strings_es-419.xtb | 1 - ui/strings/translations/ui_strings_es.xtb | 1 - ui/strings/translations/ui_strings_et.xtb | 1 - ui/strings/translations/ui_strings_fa.xtb | 1 - ui/strings/translations/ui_strings_fi.xtb | 1 - ui/strings/translations/ui_strings_fil.xtb | 1 - ui/strings/translations/ui_strings_fr.xtb | 1 - ui/strings/translations/ui_strings_gu.xtb | 1 - ui/strings/translations/ui_strings_hi.xtb | 1 - ui/strings/translations/ui_strings_hr.xtb | 1 - ui/strings/translations/ui_strings_hu.xtb | 1 - ui/strings/translations/ui_strings_id.xtb | 1 - ui/strings/translations/ui_strings_it.xtb | 1 - ui/strings/translations/ui_strings_iw.xtb | 3 +- ui/strings/translations/ui_strings_ja.xtb | 1 - ui/strings/translations/ui_strings_kn.xtb | 1 - ui/strings/translations/ui_strings_ko.xtb | 1 - ui/strings/translations/ui_strings_lt.xtb | 1 - ui/strings/translations/ui_strings_lv.xtb | 1 - ui/strings/translations/ui_strings_ml.xtb | 1 - ui/strings/translations/ui_strings_mr.xtb | 1 - ui/strings/translations/ui_strings_ms.xtb | 1 - ui/strings/translations/ui_strings_nl.xtb | 1 - ui/strings/translations/ui_strings_no.xtb | 1 - ui/strings/translations/ui_strings_pl.xtb | 1 - ui/strings/translations/ui_strings_pt-BR.xtb | 1 - ui/strings/translations/ui_strings_pt-PT.xtb | 1 - ui/strings/translations/ui_strings_ro.xtb | 1 - ui/strings/translations/ui_strings_ru.xtb | 1 - ui/strings/translations/ui_strings_sk.xtb | 1 - ui/strings/translations/ui_strings_sl.xtb | 1 - ui/strings/translations/ui_strings_sr.xtb | 1 - ui/strings/translations/ui_strings_sv.xtb | 1 - ui/strings/translations/ui_strings_sw.xtb | 1 - ui/strings/translations/ui_strings_ta.xtb | 1 - ui/strings/translations/ui_strings_te.xtb | 1 - ui/strings/translations/ui_strings_th.xtb | 1 - ui/strings/translations/ui_strings_tr.xtb | 1 - ui/strings/translations/ui_strings_uk.xtb | 1 - ui/strings/translations/ui_strings_vi.xtb | 1 - ui/strings/translations/ui_strings_zh-CN.xtb | 1 - ui/strings/translations/ui_strings_zh-TW.xtb | 1 - 695 files changed, 4023 insertions(+), 2156 deletions(-) commit 7ff583308e6209af7f37f5a2605dfb9aa6c21a72 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 18:25:39 2018 +0000 Roll src/third_party/skia 4f738832a976..3bdc3f5f9c0b (4 commits) https://skia.googlesource.com/skia.git/+log/4f738832a976..3bdc3f5f9c0b git log 4f738832a976..3bdc3f5f9c0b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 bsalomon@google.com Move some Gr headers from include/gpu to include/private and src/gpu. 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2661e8408331..7cfb50cd5f50 (1 commits) 2018-12-11 scroggo@google.com Treat kWEBP encode with quality=100 as lossless 2018-12-11 reed@google.com change convex scan converter to be defensive Created with: gclient setdep -r src/third_party/skia@3bdc3f5f9c0b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:899689 TBR=ethannicholas@chromium.org Change-Id: I8654098ad7ea12d70046b041654d0cfddc1d07ee Reviewed-on: https://chromium-review.googlesource.com/c/1372088 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615597} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3941fd2b0532841210a3ba5e8dfead73506ecdca Author: Ryan Hansberry <hansberry@chromium.org> Date: Tue Dec 11 18:22:51 2018 +0000 [CrOS MultiDevice] Remove unusued ProximityAuth code. Change-Id: I0c9c61c9671e6cbfebf419f1f148f268d79eb5e4 Reviewed-on: https://chromium-review.googlesource.com/c/1370855 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#615596} chrome/browser/ui/BUILD.gn | 3 - chrome/browser/ui/proximity_auth/OWNERS | 4 - .../proximity_auth/proximity_auth_error_bubble.h | 34 ----- chrome/browser/ui/views/proximity_auth/OWNERS | 4 - .../proximity_auth_error_bubble_view.cc | 150 --------------------- .../proximity_auth_error_bubble_view.h | 79 ----------- 6 files changed, 274 deletions(-) commit cd964bbc72f222ccdebc589f419865a288fee10a Author: Robbie Gibson <rkgibson@google.com> Date: Tue Dec 11 18:22:21 2018 +0000 [iOS] Add flag for Search for Copied Image feature Bug: 913958 Change-Id: Ib942171d8f94e7b37cb91cdebe52c5e02141917e Reviewed-on: https://chromium-review.googlesource.com/c/1371893 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615595} ios/chrome/browser/about_flags.mm | 3 +++ ios/chrome/browser/ios_chrome_flag_descriptions.cc | 5 +++++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 ++++ ios/chrome/browser/ui/ui_feature_flags.cc | 3 +++ ios/chrome/browser/ui/ui_feature_flags.h | 3 +++ 5 files changed, 18 insertions(+) commit 58e6d60884950afe8e8383741a742eca4cd96b91 Author: Yannis Guyon <yguyon@google.com> Date: Tue Dec 11 18:21:47 2018 +0000 third_party/libwebp/fuzzing: Disable ExtractAndCropOrScale() WEBP_REDUCE_SIZE is defined in chromium, disabling WebPPictureCrop() and WebPPictureRescale(), crashing ExtractAndCropOrScale() in fuzz.h. Disable ExtractAndCropOrScale() without returning an error when WEBP_REDUCE_SIZE is defined. BUG=chromium:912455 Change-Id: I10f66de59498f664d7e0603cfd10698fa3f5f114 Reviewed-on: https://chromium-review.googlesource.com/c/1368108 Commit-Queue: Yannis Guyon <yguyon@google.com> Reviewed-by: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#615594} third_party/libwebp/fuzzing/fuzz.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit e75b360015a48be36fac3e391dfdaa490f6a9f62 Author: Alexander Hendrich <hendrich@chromium.org> Date: Tue Dec 11 18:21:12 2018 +0000 Fix const/let in internet_detail_page.js These changes show up as presubmit errors when working on internet_detail_page.js. Bug: none Change-Id: Ie1d3d8fb061f607d47f71fc3345a37c9e4851041 Reviewed-on: https://chromium-review.googlesource.com/c/1371867 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#615593} .../resources/settings/internet_page/internet_detail_page.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit ccd2c27cc73b8e6c8583ddc12bc75c5d6333d26a Author: Arthur Hemery <ahemery@chromium.org> Date: Tue Dec 11 18:20:40 2018 +0000 Navigation: Removing NavigateAndCommitRendererInitiated from unit tests. This patch removes deprecated method RenderFrameHostTester::NavigateAndCommitRendererInitiated and its remaining uses in unit tests. Bug: 728571 Change-Id: I6bd3c51a11b0892b9e3e0ebc0f9ea263f27a223d Reviewed-on: https://chromium-review.googlesource.com/c/1369936 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615592} .../frame_host/navigation_controller_impl_unittest.cc | 11 +++++++---- .../browser/renderer_host/render_view_host_unittest.cc | 5 +++-- content/public/test/test_renderer_host.h | 5 ----- content/test/test_render_frame_host.cc | 15 --------------- content/test/test_render_frame_host.h | 3 --- 5 files changed, 10 insertions(+), 29 deletions(-) commit 357ee3d982a6109792f6b4472b96ca0eb9167b84 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 18:12:56 2018 +0000 Roll src/third_party/perfetto c8b5fd3f2752..1ec085624fc7 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/c8b5fd3f2752..1ec085624fc7 git log c8b5fd3f2752..1ec085624fc7 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 eseckler@google.com Merge "trace writer: Send patches after completing fragmented packet" Created with: gclient setdep -r src/third_party/perfetto@1ec085624fc7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic6abac689f30af8a98120e210957b599be44d5b8 Reviewed-on: https://chromium-review.googlesource.com/c/1372087 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615591} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a758607cb4c0b8aeb6ef2900acd1af17a9f0f37 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 18:12:28 2018 +0000 Roll src/third_party/chromite bdff670a66b9..e98d9aa1ef9b (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/bdff670a66b9..e98d9aa1ef9b git log bdff670a66b9..e98d9aa1ef9b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 yueherngl@google.com flapjack: add board and paladin Created with: gclient setdep -r src/third_party/chromite@e98d9aa1ef9b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I17c3fec3522100def0ec2d29b5d7fd364026d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/1372090 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615590} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c54fed4c214b03abecc96d97a337c82933250cfc Author: Jeremy Roman <jbroman@chromium.org> Date: Tue Dec 11 18:11:02 2018 +0000 Remove wtf/atomics.h. Bug: 736037 Change-Id: Ic43002666a0d33296b86b16400590f43ec628ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1372233 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615589} .../blink/renderer/modules/webdatabase/database.cc | 1 - third_party/blink/renderer/platform/heap/heap.h | 1 - .../blink/renderer/platform/heap/page_memory.cc | 1 - third_party/blink/renderer/platform/wtf/BUILD.gn | 1 - third_party/blink/renderer/platform/wtf/atomics.h | 402 --------------------- 5 files changed, 406 deletions(-) commit b8a6caa0e7a9130f76f83e9c91913c022b1acbe8 Author: David 'Digit' Turner <digit@google.com> Date: Tue Dec 11 18:09:23 2018 +0000 android: Update bundletool to 0.7.2 This allows --mode=system and --mode=universal (which replaces the obsolete --universal option). BUG=912934 R=jbudorick@chromium.org,benmason@chromium.org,tiborg@chromium.org,agrieve@chromium.org Change-Id: Ibd69369ff5aac5410409534319683f1f5db0f2d1 Reviewed-on: https://chromium-review.googlesource.com/c/1371844 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615588} DEPS | 2 +- build/android/gyp/bundletool.py | 2 +- build/android/pylib/utils/app_bundle_utils.py | 3 ++- third_party/android_build_tools/bundletool/README.chromium | 2 +- third_party/android_build_tools/bundletool/cipd.yaml | 6 +++--- 5 files changed, 8 insertions(+), 7 deletions(-) commit 02725453c39524386610ac4eba1e970b22bd9d6f Author: Theresa <twellington@chromium.org> Date: Tue Dec 11 18:08:17 2018 +0000 Set content description on menu image button instead of wrapper BUG=452615 Change-Id: Ibc5b6782c2116ca21435e1afa52f41f5f9dc9ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1371900 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615587} .../java/src/org/chromium/chrome/browser/toolbar/MenuButton.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 942d506c198bfe0892dbf1fbf6ffcc6c8b252e34 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Dec 11 18:07:56 2018 +0000 Removing dead code from GaiaAuthFetcher Removing ResponseCookies parameter from GaiaAuthFetcher::DispatchFetchedRequest() Change-Id: Ib63c24d88ea996cbd99f50789492cf0bc9f9d7fd Reviewed-on: https://chromium-review.googlesource.com/c/1371891 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615586} google_apis/gaia/gaia_auth_consumer.h | 4 ---- google_apis/gaia/gaia_auth_fetcher.cc | 15 +-------------- google_apis/gaia/gaia_auth_fetcher.h | 1 - ios/chrome/browser/signin/gaia_auth_fetcher_ios.h | 1 - ios/chrome/browser/signin/gaia_auth_fetcher_ios.mm | 9 +++------ 5 files changed, 4 insertions(+), 26 deletions(-) commit 2436b2f13d17a72091143b0041a74d586f584308 Author: Matt Menke <mmenke@chromium.org> Date: Tue Dec 11 18:07:11 2018 +0000 Don't pool HTTP2 sessions used for tunnels and direct connections. Pooling sockets from independent socket pools together breaks layering assumptions. A later point in time, these pools will also need to wrap lower layer objects than ClientSocketHandles. Bug: 895562 Change-Id: I8235f244048475bcb64bf48b3e15309e8607e85e Reviewed-on: https://chromium-review.googlesource.com/c/1362192 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615585} net/http/bidirectional_stream_unittest.cc | 6 +- net/http/http_network_transaction_unittest.cc | 383 ++++++++++++++++++--- net/http/http_proxy_client_socket_wrapper.cc | 4 +- net/http/http_stream_factory_job.cc | 23 +- net/http/http_stream_factory_unittest.cc | 6 +- net/socket/ssl_client_socket_pool_unittest.cc | 14 +- .../bidirectional_stream_spdy_impl_unittest.cc | 1 + net/spdy/http2_push_promise_index_test.cc | 2 + net/spdy/spdy_http_stream_unittest.cc | 1 + net/spdy/spdy_network_transaction_unittest.cc | 43 ++- net/spdy/spdy_proxy_client_socket_unittest.cc | 1 + net/spdy/spdy_session.cc | 3 +- net/spdy/spdy_session_fuzzer.cc | 1 + net/spdy/spdy_session_key.cc | 12 +- net/spdy/spdy_session_key.h | 14 + net/spdy/spdy_session_pool.cc | 9 +- net/spdy/spdy_session_pool_unittest.cc | 70 ++-- net/spdy/spdy_session_unittest.cc | 15 +- net/spdy/spdy_stream_unittest.cc | 6 +- .../websocket_basic_stream_adapters_test.cc | 1 + ...ebsocket_handshake_stream_create_helper_test.cc | 1 + 21 files changed, 485 insertions(+), 131 deletions(-) commit f07ff30bdf17be64976e30027cd86e3421f061f0 Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Dec 11 18:05:53 2018 +0000 [Background Fetch] total-download-exceeded -> download-total-exceeded Update BackgroundFetchRegistration idl file to include the new changes in the spec. Bug: 913867 Change-Id: Ie94bc1a064734021e5bd98541d9ab47a4006aaf4 Reviewed-on: https://chromium-review.googlesource.com/c/1371387 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#615584} .../background_fetch_delegate_impl.cc | 6 ++-- .../background_fetch/background_fetch.proto | 2 +- .../background_fetch_delegate_proxy.cc | 9 +++--- .../background_fetch_event_dispatcher.cc | 3 +- .../background_fetch/storage/database_helpers.cc | 6 ++-- .../background_fetch/background_fetch.mojom | 4 +-- .../background_fetch_registration.cc | 4 +-- .../background_fetch_registration.idl | 36 ++++++++++++---------- 8 files changed, 36 insertions(+), 34 deletions(-) commit 04a493964ca15017062c3f0d821f282fcc34f657 Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Dec 11 18:04:08 2018 +0000 Simplify TaskQueueSelector Based on the reverted https://crrev.com/c/1361103 but without any policy changes. I feel most of the changes are a net improvement in readability so I'd like to land them anyway. Change-Id: I3a60bfb3e5c6171c915f00afbbeb58ee2da01690 Reviewed-on: https://chromium-review.googlesource.com/c/1371428 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615583} .../task/sequence_manager/sequence_manager_impl.cc | 17 +- base/task/sequence_manager/sequence_manager_impl.h | 3 +- base/task/sequence_manager/task_queue_selector.cc | 205 +++++++++------------ base/task/sequence_manager/task_queue_selector.h | 115 ++++-------- .../task_queue_selector_unittest.cc | 166 ++++++++--------- base/task/sequence_manager/work_queue_sets.cc | 21 +-- base/task/sequence_manager/work_queue_sets.h | 5 +- .../sequence_manager/work_queue_sets_unittest.cc | 97 +++------- base/task/sequence_manager/work_queue_unittest.cc | 63 +++---- 9 files changed, 262 insertions(+), 430 deletions(-) commit 6e598fc4441c22995aacff7da88934fa9f82f3ce Author: Dominik Röttsches <drott@chromium.org> Date: Tue Dec 11 18:03:50 2018 +0000 Add method to retrieve path and ttc index, refactor AddFontFiles DirectWrite will only ever give us one file - we do not need an implementation for retrieving multiple files per IDWriteFont. In upcoming changes for unique local font matching for src: local(...) @font-face declarations, we need a way to retrieve the ttc index of a matched font. Taking those two aspects into account, refactor AddFontFiles to rely on a new method FontFilePathAndTtcIndex which retrieves path and ttc index for a IDWriteFont. Also move helper methods to anonymous namespace. No functional changes to the DWriteFontProxy mojo interface, which this DWriteFontProxyImpl implements. Implementation mostly moved and restructured, but mostly unchanged and taken from previous code. Bug: 889864 Change-Id: Ida13667533eb338bb62083026ddbb386b8dcf0b2 Reviewed-on: https://chromium-review.googlesource.com/c/1371884 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#615582} .../dwrite_font_proxy_message_filter_win.cc | 243 +++++++++++---------- .../dwrite_font_proxy_message_filter_win.h | 8 - tools/metrics/histograms/enums.xml | 1 + 3 files changed, 132 insertions(+), 120 deletions(-) commit ad12d44124812f22484eb4d123e4a3b4aaac93b9 Author: Peter Boström <pbos@chromium.org> Date: Tue Dec 11 18:02:22 2018 +0000 Reland "Disable the new tab-loading animation" This reverts commit 742b8857c4dd0ab4550f7b2c1f200ce5be406b9c. Reason for revert: Flaky tests should be fixed in r615470. Bug: chromium:912543, chromium:913135, chromium:913784 Original change's description: > Revert "Disable the new tab-loading animation" > > This reverts commit 355b8185716292a8f145c77168ee89148ecabf31. > > Reason for revert: Made several tests flaky: https://crbug.com/912543 > > Original change's description: > > Disable the new tab-loading animation > > > > Makes sure that a lot of animation-related code is bypassed when the > > new-tab-animation flag is off. This should hopefully fix a couple of > > performance regressions that have not yet been root caused so that they > > don't go out with M72. > > > > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > > Change-Id: Id3f131db427eb3ee1618d6c9683fd5e47dc134e8 > > Reviewed-on: https://chromium-review.googlesource.com/c/1364212 > > Reviewed-by: Sidney San Martín <sdy@chromium.org> > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#614199} > > TBR=pbos@chromium.org,sdy@chromium.org > > Change-Id: Ib4c022a255ad085c1716d3559a7f84dcb61c2785 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 > Reviewed-on: https://chromium-review.googlesource.com/c/1366359 > Reviewed-by: Jeffrey Yasskin <jyasskin@chromium.org> > Commit-Queue: Jeffrey Yasskin <jyasskin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614440} TBR=jyasskin@chromium.org,pbos@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:912328, chromium:905745, chromium:905918, chromium:910265 Change-Id: I3981455a00f743fae535de4626179dcceab9b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/1372236 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615581} chrome/browser/ui/views/tabs/tab_icon.cc | 29 ++++++++++++++++++++++---- chrome/browser/ui/views/tabs/tab_unittest.cc | 31 +++++++++++++++++++++------- chrome/common/chrome_features.cc | 2 +- 3 files changed, 50 insertions(+), 12 deletions(-) commit 98ea933514779a84a747a2fa4dd8c280d602b7c1 Author: Aiden Benner <abenner@google.com> Date: Tue Dec 11 18:01:24 2018 +0000 JNI: Mockable JNI refactor tool Adds script for refactoring non-static native methods to static native methods using @JCaller and for refactoring static native methods that to use mockable natives. Bug: 898261 Change-Id: I5188a99c55bba028c375a9bf43d029a2c6752b08 Reviewed-on: https://chromium-review.googlesource.com/c/1361782 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615580} base/android/jni_generator/jni_refactorer.py | 424 +++++++++++++++++++++++++++ 1 file changed, 424 insertions(+) commit 6a4a425fdd7343dab3948c2dce293c109e0aabf8 Author: David Bokan <bokan@chromium.org> Date: Tue Dec 11 18:00:32 2018 +0000 [BlinkGenPropertyTrees] Fix layer commit for wheel handler region When a wheel event listener is added or removed on a page, we set each layer as having a WheelEventHandlerRegion equal to the entire bounds of the layer. This happens in Layer::PushPropertiesTo. This means that when an event listener is changed, we need to cause all layers to need a push properties and commit. Prior to this CL, this happens in LayerTreeHost::SetEventListenerProperties by setting SetNeedsFullTreeSync and SetSubtreePropertyChanged. However, as noted by surrounding comments, this looks wrong; SetNeedsFullTreeSync only causes the tree structure to be synced, properties aren't pushed. SetSubtreePropertyChanged causes a property sync only on the root layer. This works prior to BGPT because SetNeedsFullTreeSync causes a property tree rebuild during which all layers are marked as needing a property push. See PropertyTreeBuilderContext::BuildPropertyTreesInternal which calls SetLayerPropertyTreeChangedForChild for all child layers as the tree is built. When BGPT is turned on, property trees are built in Blink independent of the layer tree so this doesn't cause us to SetNeedsPushProperties. This CL fixes SetEventListenerProperties to set the correct flags to propagate the listener state to the active tree. This CL fixes: PointerLockBrowserTest.PointerLockWheelEventRouting TouchpadPinchBrowserTest.WheelListenerAllowingPinch/0 TouchpadPinchBrowserTest.WheelListenerAllowingPinch/1 With BGPT turned on. Bug: 912334,881011 Change-Id: I4446ccfd32de12e618219e5fa15c48f5093bcc98 Reviewed-on: https://chromium-review.googlesource.com/c/1369059 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615579} cc/trees/layer_tree_host.cc | 22 ++++++---------------- 1 file changed, 6 insertions(+), 16 deletions(-) commit 0d5d9e6b4c1ede29757150b2c26c68a798578a73 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 17:58:05 2018 +0000 Roll src/third_party/webrtc e011cb742d99..7025535b4bb4 (4 commits) https://webrtc.googlesource.com/src.git/+log/e011cb742d99..7025535b4bb4 git log e011cb742d99..7025535b4bb4 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d5698f682d..573be0639f (615355:615506) 2018-12-11 andersc@webrtc.org Fix header import in broadcast extension. 2018-12-11 terelius@webrtc.org Print media types for streams using the new event log format. 2018-12-11 saza@webrtc.org Change the type of indW32 back to int32_t Created with: gclient setdep -r src/third_party/webrtc@7025535b4bb4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:906379 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0780646df3dae1ae436f82e3cfe3f897ec48ca41 Reviewed-on: https://chromium-review.googlesource.com/c/1372086 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615578} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dcfb31a91b024ce331664ee5184622530cdd257b Author: Ben Pastene <bpastene@chromium.org> Date: Tue Dec 11 17:57:29 2018 +0000 Configure "Mac Builder (dbg)" to build "all". Will watch for cycle time increases on the CQ bot: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/mac_chromium_compile_dbg_ng R=dpranke, erikchen, jbudorick Bug: 910227 Change-Id: I73f6e5cc18e707aebe6689034a734ee96fbaa97b Reviewed-on: https://chromium-review.googlesource.com/c/1370949 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#615577} testing/buildbot/chromium.mac.json | 5 +++++ testing/buildbot/waterfalls.pyl | 5 +++++ 2 files changed, 10 insertions(+) commit f176173706f1ee0432ecd443e9b7966eede5f6c9 Author: Dominik Röttsches <drott@chromium.org> Date: Tue Dec 11 17:56:44 2018 +0000 Remove deprecated loading mode switches These switches were used in an trial to figure out whether they help with the Windows empty font handle issues. These trials have now been expired without the intended results and are no longer used. Bug: 889864 Change-Id: I9ed1376d989b59a71e325cd54604faeaae71a5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1371807 Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#615576} content/browser/renderer_host/OWNERS | 3 +++ .../dwrite_font_proxy_message_filter_win.cc | 25 +++------------------- .../dwrite_font_proxy_message_filter_win.h | 3 --- 3 files changed, 6 insertions(+), 25 deletions(-) commit bdddd379baa19955fe32126aafa1039af9f3d0b6 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 17:56:24 2018 +0000 Import wpt@5dd605cdfae1ab110f1262e7bd52e0083f9784f8 Using wpt-import in Chromium bf0201649f47dd8d9b608799866a635854e241d1. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I640242d27bf5607e8fe5aa25bbddfcbfe5c2eb43 Reviewed-on: https://chromium-review.googlesource.com/c/1372228 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615575} .../blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 19 ++++++++++++++----- .../the-script-element/muted-errors.sub.html | 8 ++++++++ .../the-script-element/resources/syntax-error.js | 1 + 3 files changed, 23 insertions(+), 5 deletions(-) commit 697289282618af5803d9ce516461d538e749ef84 Author: Gabriel Marin <gmx@chromium.org> Date: Tue Dec 11 17:52:05 2018 +0000 PerfProvider: Add a baseline collector class Add MetricCollector, a baseline class for collectors. It implements the common functionality for a collector and the interaction between the various defined triggers. The majority of the implementation is copied from the PerfProvider class. The unit tests are mostly new. Added rules to compile the class and the associated unit tests, but the code will not be used in prod until a later CL that adds a perf events collector to replace PerfProvider. BUG=b:116527691 TEST=Unit tests pass Change-Id: Ia4053f0a70a2db2c4c5bf12ca9a9817a310ffad9 Reviewed-on: https://chromium-review.googlesource.com/c/1357598 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#615574} chrome/browser/BUILD.gn | 2 + chrome/browser/metrics/perf/metric_collector.cc | 206 ++++++++++++++ chrome/browser/metrics/perf/metric_collector.h | 123 +++++++++ .../metrics/perf/metric_collector_unittest.cc | 305 +++++++++++++++++++++ chrome/test/BUILD.gn | 1 + 5 files changed, 637 insertions(+) commit ce94c51f4bc3840de776af24e0a6fbf7c1afea93 Author: Florin Malita <fmalita@chromium.org> Date: Tue Dec 11 17:51:01 2018 +0000 Remove unused "anticlockwise" Path parameters AddArc and AddEllipse take an "anticlockwise" parameter, which is no longer used. Remove the args and hoist related DCHECKs into CanvasPath's AdjustEndAngle (where the actual adjustment is applied). Change-Id: I445379021635b1a6d3fa35c36e9bae6a2563a66b Reviewed-on: https://chromium-review.googlesource.com/c/1366441 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Fredrik Söderquist <fs@opera.com> Reviewed-by: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#615573} .../renderer/modules/canvas/canvas2d/canvas_path.cc | 10 +++++----- third_party/blink/renderer/platform/graphics/path.cc | 20 ++++++-------------- third_party/blink/renderer/platform/graphics/path.h | 9 +++------ 3 files changed, 14 insertions(+), 25 deletions(-) commit b7f402a95386e6e0c9e31850b0d5d356d5258f8b Author: Linwan Song <lwsong@google.com> Date: Tue Dec 11 17:50:57 2018 +0000 Link raster tasks to frames by adding frame ids as a tracing argument. This change links tile raster tasks to the tile manager that initiated them. Tile managers are in turn linked to a frame, which is processed by telemetry later on to determine the time difference between when raster tasks start to when the compositor frame is submitted. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I876a029f6db1e664aafe945fcdd629da3bdc681e Bug: 912730 Reviewed-on: https://chromium-review.googlesource.com/c/1286889 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: weiliangc <weiliangc@chromium.org> Reviewed-by: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#615572} cc/mojo_embedder/async_layer_tree_frame_sink.cc | 4 ++-- cc/raster/task.h | 3 +++ cc/tiles/tile_manager.cc | 1 + cc/trees/layer_tree_frame_sink.h | 6 ++++++ cc/trees/layer_tree_host_impl.cc | 3 +++ content/renderer/categorized_worker_pool.cc | 3 ++- 6 files changed, 17 insertions(+), 3 deletions(-) commit 30fbb99c379e3aa5cd9db30649fdf370681ae334 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Tue Dec 11 17:36:57 2018 +0000 Vaapi decode: split |decoder_|s GetRequiredNumOfPictures() This CL reduces the amount of PictureBuffers requested to be allocated by the |client_| when we are not |decode_using_client_picture_buffers_|. Instead, it "splits" the requested allocations into - the actual needed PictureBuffers (A) - the codec's requested reference frames (B) (a new method GetNumReferenceFrames() is added to AcceleratedVideoDecoder for this). This splitting saves a lot of memory, since we allocate A+B buffers instead of 2*(A+B). (B is 5 and A is 4-VP8, 4-12 H264/VP9) Test: crosvideo changing resolutions for each codec, v_d_a_unittest on nocturne (KBL) and caroline (SKL). Bug: 909926 Change-Id: I1fce92863beddce0e8b221861cf156b9c3ad0c0f Reviewed-on: https://chromium-review.googlesource.com/c/1363807 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615571} media/gpu/accelerated_video_decoder.h | 8 ++- media/gpu/h264_decoder.cc | 12 +++- media/gpu/h264_decoder.h | 12 +--- media/gpu/vaapi/vaapi_video_decode_accelerator.cc | 79 +++++++++++++++------- media/gpu/vaapi/vaapi_video_decode_accelerator.h | 16 +++-- .../vaapi_video_decode_accelerator_unittest.cc | 28 +++++--- media/gpu/vp8_decoder.cc | 13 +++- media/gpu/vp8_decoder.h | 1 + media/gpu/vp9_decoder.cc | 11 ++- media/gpu/vp9_decoder.h | 1 + 10 files changed, 120 insertions(+), 61 deletions(-) commit 541c2952f6896bdc75d2151153cb4dfa83b42646 Author: ccameron <ccameron@chromium.org> Date: Tue Dec 11 17:28:47 2018 +0000 Reland "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness." This reverts commit 00c1b7ab0080db58436431b6dbe1956b2457abbc. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness." > > This reverts commit 0c873bf2265189967d77b2cbccee70cfd14e9db9. > > Reason for revert: Fix for flake in crrev.com/615269 > > Original change's description: > > [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness. > > > > Tbr: ccameron@chromium.org > > Bug: 913490 > > Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f > > Reviewed-on: https://chromium-review.googlesource.com/c/1369721 > > Commit-Queue: Samuel Huang <huangs@chromium.org> > > Reviewed-by: Samuel Huang <huangs@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#615159} > > TBR=huangs@chromium.org,ccameron@chromium.org > > Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 913490 > Reviewed-on: https://chromium-review.googlesource.com/c/1370571 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615274} TBR=huangs@chromium.org,ccameron@chromium.org Change-Id: I72829b7b404a571095123f2ffd028ff189563ee8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913490 Reviewed-on: https://chromium-review.googlesource.com/c/1371931 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615570} chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c8e3b11f0cf55aeec0d6de5e4500bbb2ec8e8488 Author: Marc Treib <treib@chromium.org> Date: Tue Dec 11 17:28:25 2018 +0000 Integration test for UMA Sync.ModelTypeEntityChange3 during initial sync This test covers initial sync, i.e. when there are pre-existing autofill profiles at the time Sync is turned on. Bug: 904390 Change-Id: I7c7f32f9ceb754c5d517a8e182eca6415a2abc61 Reviewed-on: https://chromium-review.googlesource.com/c/1371845 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615569} .../integration/two_client_autofill_sync_test.cc | 51 +++++++++++++++++++++- 1 file changed, 50 insertions(+), 1 deletion(-) commit 93457c2766b87bb015e124db70f24f786c73b3a7 Author: wutao <wutao@chromium.org> Date: Tue Dec 11 17:27:34 2018 +0000 app_list: Remove flag kEnableContinueReading This feature has been enabled by default since M70 and stable enough to be always on. Bug: 913694 Test: manual and coverred by unittest Change-Id: Ice7240c8d47e45b89324c85de85d398dc9233df8 Reviewed-on: https://chromium-review.googlesource.com/c/1371066 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615568} ash/public/cpp/app_list/app_list_features.cc | 6 ------ ash/public/cpp/app_list/app_list_features.h | 5 ----- chrome/browser/about_flags.cc | 3 --- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- chrome/browser/ui/app_list/search/app_search_provider.cc | 3 --- .../ui/app_list/search/tests/app_search_provider_unittest.cc | 3 --- 7 files changed, 29 deletions(-) commit ed3421d6d468adc0567e8924b81812cbe276dd0b Author: wutao <wutao@chromium.org> Date: Tue Dec 11 17:26:59 2018 +0000 ksv: Clean up flag kAshEnableKeyboardShortcutViewer The old keyboard overlay has been removed in M72 and the flag kAshEnableKeyboardShortcutViewer is also removed. Bug: 778874 Test: manual Change-Id: I6ab9c350728c1e81f2d2437ac089187c4ab604c6 Reviewed-on: https://chromium-review.googlesource.com/c/1371073 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615567} chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- 2 files changed, 8 deletions(-) commit 1301db2eac6ec7041e62476d942c57e8a86a16f1 Author: Boris Sazonov <bsazonov@chromium.org> Date: Tue Dec 11 17:08:01 2018 +0000 [Signin][Android] Remove redundant resetSigninState calls This CL removes two SigninTestUtil.resetSigninState calls from tests. ClearBrowsingDataPreferencesBasicTest calls resetSigninState before starting a test, when these preferences are already wiped by SigninTestUtil setup method. HistoryActivityTest calls resetSigninState right before calling SigninManager.signOut, which should clear the state as the part of the sign-out process. Bug: 738533 Change-Id: I646313550ec0c52e979520f62c9a49e9ff137427 Reviewed-on: https://chromium-review.googlesource.com/c/1371804 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615566} .../src/org/chromium/chrome/browser/history/HistoryActivityTest.java | 1 - .../preferences/privacy/ClearBrowsingDataPreferencesBasicTest.java | 2 -- 2 files changed, 3 deletions(-) commit a4092d3194dc77ee32bb2011c77f23561812f488 Author: edchin <edchin@chromium.org> Date: Tue Dec 11 17:07:48 2018 +0000 [ios] Fix imports in bvc This CL removes unnecessary imports and forward declarations from the header file, and move them to the necessary implementation files. Change-Id: If6e41ffe9d85d063f2b14e4c74b12b06b46261b7 Reviewed-on: https://chromium-review.googlesource.com/c/1370581 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615565} ios/chrome/app/application_delegate/app_state.mm | 1 + ios/chrome/browser/ui/browser_view_controller.h | 3 --- ios/chrome/browser/ui/browser_view_controller.mm | 1 + ios/chrome/browser/ui/main/browser_coordinator.mm | 1 + ios/chrome/browser/ui/overscroll_actions/BUILD.gn | 1 + .../browser/ui/overscroll_actions/overscroll_actions_controller.mm | 1 + 6 files changed, 5 insertions(+), 3 deletions(-) commit db51afdcd4928ea61df2a6460333b7d646295c8a Author: Josh Karlin <jkarlin@chromium.org> Date: Tue Dec 11 17:05:39 2018 +0000 [AdTagging] Add documentation for ad tagging Bug: 851533 Change-Id: I6cc6def8e7def7b6231dfb7e735a66b596b90b36 Reviewed-on: https://chromium-review.googlesource.com/c/1371964 Reviewed-by: Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615564} docs/ad_tagging.md | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) commit 08ccc70ade86d0c8705250635fd97ebaa5fb41ef Author: Tien Mai <tienmai@chromium.org> Date: Tue Dec 11 17:05:13 2018 +0000 Add icon to gcp_installer / gcp_setup executables. Bug: 899236 Change-Id: Id541261326bfd44528b08ebc6b0edbe5fafb317f Reviewed-on: https://chromium-review.googlesource.com/c/1370313 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#615563} chrome/credential_provider/setup/BUILD.gn | 19 +++++++++++++++++++ chrome/credential_provider/setup/gcp_icon.ico | Bin 0 -> 192708 bytes .../setup/gcp_setup_resources.grd | 17 +++++++++++++++++ 3 files changed, 36 insertions(+) commit a737e67c572f5ff4688290376fcfe664f1e630a2 Author: edchin <edchin@chromium.org> Date: Tue Dec 11 17:03:32 2018 +0000 [ios] Migrate autofill from BVC Bug: 905524 Change-Id: I5699e4b01c3a7f91bd98458e83064811aff53980 Reviewed-on: https://chromium-review.googlesource.com/c/1371218 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615562} ios/chrome/browser/ui/browser_view_controller.mm | 6 ------ ios/chrome/browser/ui/main/BUILD.gn | 1 + ios/chrome/browser/ui/main/browser_coordinator.mm | 6 ++++++ 3 files changed, 7 insertions(+), 6 deletions(-) commit aa663ca4fdbfbad7cb74882ec82ee4f58f78d441 Author: Aran Gilman <gilmanmh@google.com> Date: Tue Dec 11 17:02:26 2018 +0000 Forward column index attribute for rows as well as cells & headers. Bug: 832289 Change-Id: If82589e3e690fbf31b8806182e61568d8263119f Reviewed-on: https://chromium-review.googlesource.com/c/1368945 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#615561} content/renderer/accessibility/blink_ax_tree_source.cc | 15 ++++++++------- .../blink/renderer/modules/exported/web_ax_object.cc | 2 +- 2 files changed, 9 insertions(+), 8 deletions(-) commit 41ab8b8c61c9504168cb36f49d22ae96d417bc17 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Dec 11 17:01:27 2018 +0000 Make WebFrameContentDumper use Element.innerText This patch changes WebFrameContentDumper to use Element.innerText instead of its ad-hoc TextDumper, so that its output is more predictable. This patch also allows all WebFrameSwapTest to pass in LayoutNG. Bug: 781434 Change-Id: I961fa43c1821e2a0e7eae6b01a6affe884eacc72 Reviewed-on: https://chromium-review.googlesource.com/c/1371145 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615560} .../core/exported/web_frame_content_dumper.cc | 139 +-------------------- .../blink/renderer/core/exported/web_frame_test.cc | 8 +- 2 files changed, 9 insertions(+), 138 deletions(-) commit 7bd657367736788827897ae856030f84618cdb37 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 16:59:38 2018 +0000 Roll src-internal 84629852e33d..a030e16bdf09 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84629852e33d..a030e16bdf09 Created with: gclient setdep -r src-internal@a030e16bdf09 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8ff88d678adc149dc066d8f1000f1c2ae1e98bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1372084 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615559} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit add6fd18f3430c37d7e69aaa99d7aedec86c9c96 Author: Aga Wronska <agawronska@chromium.org> Date: Tue Dec 11 16:58:24 2018 +0000 Fix DeviceManagementRequestAuthTest.CannotUseOAuthTokenAsAuthData in official builds. Removed string from ASSERT_DEATH, because official tests strip the string passed to CHECK(false) and LOG(FATAL). Bug: 913441 Change-Id: Ib68905b60d214064f341262789b31f763e8108b3 Reviewed-on: https://chromium-review.googlesource.com/c/1370307 Reviewed-by: Lutz Justen <ljusten@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#615558} .../policy/core/common/cloud/device_management_service_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e90c3a033b0743b58d3d790662b2788476dac5de Author: Kevin McNee <mcnee@chromium.org> Date: Tue Dec 11 16:58:08 2018 +0000 Reland "Refactor OOPIF scroll bubbling state and cancellation" This is a reland of b9e5ed2a6f6cacce39c19a36bb76a940244def99 Original change's description: > Refactor OOPIF scroll bubbling state and cancellation > > Whether or not a child is bubbling scroll was being tracked in both > CrossProcessFrameConnector and RenderWidgetHostViewChildFrame. It's > simpler to just have it in RWHVCF. > > There are several cases where we generate fake scroll updates when > cancelling scroll bubbling. This is a relic from the non-scroll latching > code paths and has been removed. We also deduplicate the scroll bubbling > cancellation code. > > We were tracking the view from which scroll events are bubbled by keeping > a reference to that view's parent. We now just keep a reference to the > originating view directly. > > We also now properly cancel scroll bubbling when a child detaches. > > Bug: 828422, 897216 > Change-Id: Iee983bd9ea05b324d556c66320a1bc5e544de057 > Reviewed-on: https://chromium-review.googlesource.com/c/1357563 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615184} Tbr: kenrb@chromium.org Bug: 828422, 897216 Change-Id: If529545300f6bbb7a7056cdbebbd8317cb274f7a Reviewed-on: https://chromium-review.googlesource.com/c/1371010 Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615557} .../frame_host/cross_process_frame_connector.cc | 17 +- .../frame_host/cross_process_frame_connector.h | 2 - .../render_widget_host_input_event_router.cc | 231 ++++++++++++--------- .../render_widget_host_input_event_router.h | 29 ++- .../render_widget_host_view_child_frame.cc | 33 ++- 5 files changed, 170 insertions(+), 142 deletions(-) commit 26cbade5de8d3803d9bf83ee1686022056e2d295 Author: Vladimir Levin <vmpstr@chromium.org> Date: Tue Dec 11 16:56:36 2018 +0000 [DL] Handle forced layouts. If the layout is forced, then we temporarily allow the processing of the subtree. The locked element's frame rect still remains to be the same as at the time the lock was acquired. R=chrishtr@chromium.org, mstensho@chromium.org, futhark@chromium.org Bug: 907613, 882663 Change-Id: I9d1f63c287a73e7a8f3cbc9cb5acc2a009ddd024 Reviewed-on: https://chromium-review.googlesource.com/c/1363957 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#615556} .../core/display_lock/display_lock_context.cc | 57 +++++++++++++-- .../core/display_lock/display_lock_context.h | 29 +++++++- third_party/blink/renderer/core/dom/document.cc | 20 ++++++ .../lock-before-append/measure-forced-layout.html | 84 ++++++++++++++++++++++ 4 files changed, 183 insertions(+), 7 deletions(-) commit fada5812d8c5cfd49fb05cdefe77c703997a687e Author: Ken Rockot <rockot@chromium.org> Date: Tue Dec 11 16:49:54 2018 +0000 [mojo-core] Don't accept HANDLEs from non-brokers On Windows, non-broker processes should only accept HANDLEs in messages coming from the broker and/or inviter process. This is because a non-broker or invitee receiver has to assume the sender has already duplicated sent HANDLEs into the receiver's process, and making that assumption requires a level of trust that should not be granted to arbitrary peers. This constraint is already met today under normal circumstances, but a malicious or misbehaving process could easily violate it, tricking an unassuming receiver into attempting double-ownership of an existing handle or closure of an invalid handle value, both of which can result in a crash (though thankfully nothing worse, because of ScopedHandleVerifier). This adds an option to Channel which allows it to reject incoming platform handles and essentially treat them as malformed messages. The option is set on Windows for any non-broker process's receiving Channel endpoint which is not connected directly to a broker process or to the process which invited that client. The Channel fuzzer also sets this option to avoid a crash since it exercises only the non-broker receiving path today. A follow-up CL will extend fuzzer coverage to include broker receivers as well. Bug: 909713 Change-Id: Ie0fece347fcf23d6f8111be4e41398f22d617531 Reviewed-on: https://chromium-review.googlesource.com/c/1363649 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615555} mojo/core/broker_host.cc | 1 + mojo/core/channel.cc | 9 ++++- mojo/core/channel.h | 17 ++++++++- mojo/core/channel_fuchsia.cc | 6 ++- mojo/core/channel_fuzzer.cc | 2 + mojo/core/channel_posix.cc | 8 +++- mojo/core/channel_unittest.cc | 75 +++++++++++++++++++++++++++++++++++-- mojo/core/channel_win.cc | 9 ++++- mojo/core/node_channel.cc | 11 ++++-- mojo/core/node_channel.h | 4 ++ mojo/core/node_channel_fuzzer.cc | 2 + mojo/core/node_controller.cc | 41 +++++++++++++------- mojo/core/test/run_all_unittests.cc | 9 ++++- services/test/run_all_unittests.cc | 5 ++- 14 files changed, 168 insertions(+), 31 deletions(-) commit f5af1abbbe19b919a32abe86ba0827ffb4250ff1 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Dec 11 16:44:00 2018 +0000 [CompositeAfterPaint] Ensure animation timeline is attached to host We need to attach the document animation timeline to the animation host to make animations work. In pre-CompositeAfterPaint, this is done from PaintLayerCompositor. For CompositeAfterPaint, attach animation timeline from Document::Initialize() and WebLocalFrameImpl::SetFrameWidget(). Bug: 702353 Change-Id: I5e19add5196e5b52ebcade42b58e336051b111e6 Reviewed-on: https://chromium-review.googlesource.com/c/1368994 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615554} third_party/blink/renderer/core/dom/document.cc | 21 ++++++++++++++++++++- third_party/blink/renderer/core/dom/document.h | 5 +++++ .../renderer/core/frame/web_local_frame_impl.cc | 8 ++++++++ .../blink/renderer/core/page/chrome_client_impl.cc | 7 ++++--- .../enable-blink-features=CompositeAfterPaint | 4 ---- 5 files changed, 37 insertions(+), 8 deletions(-) commit b188cd82b0f877078b2a7f87169a4a16a1f9507d Author: Jamie Madill <jmadill@chromium.org> Date: Tue Dec 11 16:38:53 2018 +0000 Revert "Re-enable video pixel tests after rebaselining" This reverts commit 1a9264ddffb97e645ae936840846a741dfefee24. Reason for revert: rebaseline didn't seem to work. Failing builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28AMD%29/3655 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20FYI%20Release%20%28NVIDIA%29/3470 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29/2954 Failing tests: gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_VP9 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_VP9 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_DirectComposition_Video_MP4 gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_Video_MP4 Original change's description: > Re-enable video pixel tests after rebaselining > > The tests were marked as failing and version numbers were incremented in > https://crrev.com/c/1182222, but I forgot to re-enable the tests. > > Bug: 869677, 913138, 858826, 819635, 774809 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08 > Reviewed-on: https://chromium-review.googlesource.com/c/1214364 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615353} TBR=kbr@chromium.org,sunnyps@chromium.org Change-Id: I553c10ca8022a90a0afa73ffafa44aa5bbf4e2d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869677, 913138, 858826, 819635, 774809 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1372234 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#615553} content/test/gpu/gpu_tests/pixel_expectations.py | 33 ++++++++++++------------ 1 file changed, 16 insertions(+), 17 deletions(-) commit 44502ac0122e17034e6837d566bf0e6f243e2b7d Author: Jeremy Roman <jbroman@chromium.org> Date: Tue Dec 11 16:22:40 2018 +0000 Update HeapTest to use modern atomics. A combination of std::atomic (for a raw GC count) and appropriate higher-level primitives from base is used to replace the current use of atomics. Bug: 736037 Change-Id: Id4856d4b8d21ff989694bbece70c61d86c686323 Reviewed-on: https://chromium-review.googlesource.com/c/1369720 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615552} .../blink/renderer/platform/heap/heap_test.cc | 68 ++++++++++------------ 1 file changed, 31 insertions(+), 37 deletions(-) commit a04367ec5b12b0507e9ae3db71232a444226b743 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 16:20:34 2018 +0000 Roll src/third_party/skia 9cabb4f98e99..4f738832a976 (3 commits) https://skia.googlesource.com/skia.git/+log/9cabb4f98e99..4f738832a976 git log 9cabb4f98e99..4f738832a976 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 caryclark@skia.org fix bookmaker 2018-12-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-11 kjlubick@google.com [canvaskit] Refactor Canvas2D JS into own files Created with: gclient setdep -r src/third_party/skia@4f738832a976 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I961018fd96caecd13c2d8a371501981f262f6a53 Reviewed-on: https://chromium-review.googlesource.com/c/1371710 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615551} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19657d423fdddf3e5441e4145f1fa394c7bc2dfc Author: Eric Karl <ericrk@chromium.org> Date: Tue Dec 11 16:20:09 2018 +0000 Remove obsolete Vulkan code from CompositorImpl Android CompositorImpl Android had obsolete Vulkan prototype code. Removing this as all Vulkan access should happen on Viz process. Removes a DCHECK we were hitting when running with the new Vulkan code. Bug: 848375 Change-Id: Ifba9927809290618346867e52ad71f3edc2b66a9 Reviewed-on: https://chromium-review.googlesource.com/c/1370935 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615550} .../renderer_host/compositor_impl_android.cc | 177 --------------------- .../renderer_host/compositor_impl_android.h | 4 - 2 files changed, 181 deletions(-) commit 7948a399469304b2d85a88e35bc1e2aa84f946ad Author: sebsg <sebsg@chromium.org> Date: Tue Dec 11 16:18:56 2018 +0000 [AF] Add metric to record parsed forms by type (address / cc) Bug: 910372 Change-Id: Ic0859c1fab02010f22664d0138d6e3516012545f Reviewed-on: https://chromium-review.googlesource.com/c/1358649 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615549} .../autofill/core/browser/autofill_manager.cc | 17 ++++ .../autofill/core/browser/autofill_metrics.cc | 10 ++ .../autofill/core/browser/autofill_metrics.h | 7 ++ .../core/browser/autofill_metrics_unittest.cc | 108 +++++++++++++++++++++ tools/metrics/actions/actions.xml | 14 +++ tools/metrics/histograms/enums.xml | 1 + 6 files changed, 157 insertions(+) commit d1ea5ce2954f0a597577a4dd2c6de62e44f958cb Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 16:18:03 2018 +0000 Update V8 to version 7.3.90. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9a1b0e72..72448bed Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1b37dea72dce8da3904aa7c6f490b8a0ad88f78a Reviewed-on: https://chromium-review.googlesource.com/c/1372024 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615548} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 810dc7db812e42eb2a792c3fc841807fa574658e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 16:14:30 2018 +0000 Roll src/third_party/perfetto 152255fcc745..c8b5fd3f2752 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/152255fcc745..c8b5fd3f2752 git log 152255fcc745..c8b5fd3f2752 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 lalitm@google.com Merge "perfetto: fix tracing test on Android ASAN" Created with: gclient setdep -r src/third_party/perfetto@c8b5fd3f2752 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I079a8f7540ce6d1ac814a6d1c64ad0748d1f10bb Reviewed-on: https://chromium-review.googlesource.com/c/1372085 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615547} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 174bc95009e44245e8cbd5d00690bfeff11a409d Author: Josh Karlin <jkarlin@chromium.org> Date: Tue Dec 11 16:07:11 2018 +0000 [AdTagging] Add whitelist rules to smaller filter list Change-Id: I21b6ea7ddeb722bf91ce184c9d21c35baedf8749 Reviewed-on: https://chromium-review.googlesource.com/c/1372046 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615546} components/subresource_filter/FILTER_LIST_GENERATION.md | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) commit aacc21d3fceb5bfd871db51c8c102108cad29c1a Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 16:04:58 2018 +0000 Reland "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz." This reverts commit 9ef757a81180101de6b2e09c57509077d8588376. Reason for revert: is again needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457 was reverted Original change's description: > Revert "Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz." > > This reverts commit 0baa5bdf0ed91499211384b636161ae9749f5ade. > > Reason for revert: is not needed after https://chromium-review.googlesource.com/c/chromium/src/+/1362457 > > Original change's description: > > Make //third_party/fontconfig explicitly depend on //third_party:freetype_harfbuzz. > > > > Bug: 911836 > > Change-Id: Ia76687b3cb8d329792e5ef0310faee93d05344f2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1361725 > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Commit-Queue: Max Moroz <mmoroz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#613792} > > TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 911836 > Change-Id: Ibc4c88faadd5c1e603fc0f26ce956c282909798e > Reviewed-on: https://chromium-review.googlesource.com/c/1365083 > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614534} TBR=bungeman@chromium.org,mmoroz@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911836 Change-Id: Id09d7c0394e8c5eb445aa19ba5a62f8fa251ecb0 Reviewed-on: https://chromium-review.googlesource.com/c/1371885 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615545} third_party/fontconfig/BUILD.gn | 3 +++ 1 file changed, 3 insertions(+) commit 3fced0e3bc235f36f5b87906ed2883078a895666 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 16:04:26 2018 +0000 Roll src/third_party/webrtc 8f66ddbae325..e011cb742d99 (3 commits) https://webrtc.googlesource.com/src.git/+log/8f66ddbae325..e011cb742d99 git log 8f66ddbae325..e011cb742d99 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 terelius@webrtc.org Move chart proto for event_log_visualizer. 2018-12-11 nisse@webrtc.org Rename EncodedImage::_size to capacity_, make private. 2018-12-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aec72e9e9c..d5698f682d (615246:615355) Created with: gclient setdep -r src/third_party/webrtc@e011cb742d99 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5a31afacdbc38767ae24412a821ba8738974fbcc Reviewed-on: https://chromium-review.googlesource.com/c/1371711 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615544} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19cdae86d6482445ed480eeb9af72b38d1e51c81 Author: Dan Elphick <delphick@chromium.org> Date: Tue Dec 11 16:03:51 2018 +0000 [cleanup] Fix many deprecated v8 calls in extensions/renderer Replaces many deprecated uses of v8 functions Object::Get/Set, Value::ToString, in extensions/renderer with versions that return Maybe/MaybeLocals or by using casts if there are already checks that ensure the cast will always succeed. Bug: v8:7279, v8:7283, v8:8562, chromium:913942 Change-Id: I4aeec76251bd11dfc274156d8d00586e04e9a99e Reviewed-on: https://chromium-review.googlesource.com/c/1353985 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615543} .../activity_log_converter_strategy_unittest.cc | 150 +++++++++++++-------- extensions/renderer/api_activity_logger.cc | 6 +- extensions/renderer/dispatcher.cc | 5 +- extensions/renderer/module_system.cc | 6 +- extensions/renderer/module_system_test.cc | 13 +- extensions/renderer/v8_context_native_handler.cc | 22 +-- 6 files changed, 130 insertions(+), 72 deletions(-) commit 95b2ab89102f1b6aa1accf098304c8ef5a2d3924 Author: Nico Weber <thakis@chromium.org> Date: Tue Dec 11 16:03:21 2018 +0000 mac: Remove edit_xibs.sh. chrome_nibs.gyp went away a while ago, and gyp is no longer deps'd in. Bug: none Change-Id: I71d7503b0f95ff15575653da7efe35e4e62a6fcd Reviewed-on: https://chromium-review.googlesource.com/c/1371928 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615542} build/mac/edit_xibs.sh | 19 ------------------- 1 file changed, 19 deletions(-) commit eeb4f38b44a6858074fa93a5c6d55661b88d19ee Author: Michael Ludwig <michaelludwig@google.com> Date: Tue Dec 11 16:02:47 2018 +0000 Suppress layout tests for Skia rectangle change Bug: 913948 Change-Id: I2712119f0ff48a56d1a8b994dc470e76b37250d2 Reviewed-on: https://chromium-review.googlesource.com/c/1371925 Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#615541} third_party/blink/web_tests/TestExpectations | 39 +++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) commit 5f881fd56a137dc15337ece268f4e67ce761bd9e Author: Ned Nguyen <nednguyen@google.com> Date: Tue Dec 11 16:02:14 2018 +0000 Specify gpu dimension for linux-perf-fyi Bug:913625 Change-Id: Id6751f4af3aedac41fd3968a58a797b785cfbd84 TBR=jbudorick@chromium.org, bradhall@chromium.org NOTRY=true # linux_chromium_rel_ng flake Change-Id: Id6751f4af3aedac41fd3968a58a797b785cfbd84 Reviewed-on: https://chromium-review.googlesource.com/c/1371646 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615540} testing/buildbot/chromium.perf.fyi.json | 1 + 1 file changed, 1 insertion(+) commit c83119b466cfd63fd1eb616ee86b22ede5db3c4e Author: John Chen <johnchen@chromium.org> Date: Tue Dec 11 16:01:41 2018 +0000 [ChromeDriver] Add Cookie spec compliance Make Add Cookie command compliant to W3C spec. Also added a set of helper functions to help parsing some property types used in W3C spec. ChromeDriver now passes all WPT WebDriver tests related to cookie. Bug: chromedriver:2002 Change-Id: I3779a14e010bca865498a9d40710974e38ede829 Reviewed-on: https://chromium-review.googlesource.com/c/1366925 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#615539} chrome/test/chromedriver/chrome/web_view_impl.cc | 4 +- chrome/test/chromedriver/util.cc | 107 +++++++++++ chrome/test/chromedriver/util.h | 43 +++++ chrome/test/chromedriver/util_unittest.cc | 222 +++++++++++++++++++++++ chrome/test/chromedriver/window_commands.cc | 35 +++- docs/chromedriver_status.md | 2 +- 6 files changed, 403 insertions(+), 10 deletions(-) commit 73db295652160905067b685719d98372e7a9f9a2 Author: Florian Uunk <feuunk@chromium.org> Date: Tue Dec 11 16:01:07 2018 +0000 Make sure PDM has the sync service before waiting The AutofillProfileDataTypeController waits for PDM to load all its data before doing data association. However, with Butter, PDM needs to ask the sync service whether the sync feature is enabled to know whether to read the server cards from the local or account database. Currently, PDM only gets the sync service whenever we create an AutofillManager, which isn't always the case on startup. This CL adds a quick fix, where we also pass the sync service to PDM in the AutofillProfileDataTypeController, so we know for sure it can load all data. A better fix would be to have a single place where we pass the sync service to PDM, and remove both the call in AutofillManager and this new call. Bug: 913945 Change-Id: Ia872cb8ce0cb97467237665e5a92b1d70eb1c2bc Reviewed-on: https://chromium-review.googlesource.com/c/1371427 Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615538} .../webdata/autofill_profile_data_type_controller.cc | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) commit 97e994e7d60b769bca77baa924b51cb473264c4e Author: Owen Min <zmin@chromium.org> Date: Tue Dec 11 15:51:53 2018 +0000 Disable ReportSafeBrowsingData by default. Disable this data upload as it's not used by server. Change-Id: I7da2e3b82aef19318a3ed5ec6c00f2cabe15fb2b Reviewed-on: https://chromium-review.googlesource.com/c/1370723 Reviewed-by: Marc-André Decoste <mad@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615537} .../chrome_desktop_report_request_helper_unittest.cc | 3 +++ chrome/browser/extensions/api/enterprise_reporting_private/prefs.cc | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) commit 97d45bc021d18994864d653fcec1145025a5a7d4 Author: Jeremy Roman <jbroman@chromium.org> Date: Tue Dec 11 15:50:03 2018 +0000 Use std::atomic for DeferredTaskHandler::audio_thread_ and all other atomics in webaudio. These are the ones that didn't explicitly include wtf/atomics.h and so were missed earlier. Bug: 736037,247328 Change-Id: I407d1ad6f53c058866bb4a98ca910768fe9ce6c5 Reviewed-on: https://chromium-review.googlesource.com/c/1370187 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615536} .../renderer/modules/webaudio/audio_buffer_source_node.h | 11 +++++++---- .../renderer/modules/webaudio/audio_scheduled_source_node.h | 7 ++++--- .../blink/renderer/modules/webaudio/deferred_task_handler.cc | 3 +-- .../blink/renderer/modules/webaudio/deferred_task_handler.h | 8 +++----- .../blink/renderer/modules/webaudio/realtime_analyser.cc | 1 - .../blink/renderer/modules/webaudio/realtime_analyser.h | 9 ++++++--- 6 files changed, 21 insertions(+), 18 deletions(-) commit a82bda8239b3580a20c48efe5909052ea4fee215 Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue Dec 11 15:48:39 2018 +0000 [ScrollTimeline] Add README.md to fast/animation/scroll-animations This CL adds a README.md to the fast/animations/scroll-animations directory, explaining when that directory should be used vs external/wpt/scroll-animations (aka, rarely). Bug: 911254 Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c TBR=yigu@chromium.org Change-Id: Id24ee770dcbe070b1f89ffe925edbacbba4a673c Reviewed-on: https://chromium-review.googlesource.com/c/1367825 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#615535} .../blink/web_tests/fast/animation/scroll-animations/README.md | 6 ++++++ 1 file changed, 6 insertions(+) commit bf0201649f47dd8d9b608799866a635854e241d1 Author: Jesse Doherty <jwd@chromium.org> Date: Tue Dec 11 15:40:01 2018 +0000 Plumb a key from MetricsServiceClient to use when signing metrics uploads. There will need to be a follow up CL that adds an implementation for Chrome to provide an actual key. Bug: 906202 Change-Id: Ib471b1124e19b11755b410f384a447f929a1b547 Reviewed-on: https://chromium-review.googlesource.com/c/1351709 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#615534} components/metrics/metrics_log_manager_unittest.cc | 2 +- components/metrics/metrics_log_store.cc | 9 ++-- components/metrics/metrics_log_store.h | 7 ++- components/metrics/metrics_log_store_unittest.cc | 16 +++---- components/metrics/metrics_reporting_service.cc | 4 +- components/metrics/metrics_service_client.cc | 5 ++ components/metrics/metrics_service_client.h | 4 ++ components/metrics/persisted_logs.cc | 12 +++-- components/metrics/persisted_logs.h | 22 +++++++-- components/metrics/persisted_logs_unittest.cc | 56 ++++++++++++++++++---- components/ukm/ukm_reporting_service.cc | 4 +- components/ukm/ukm_service_unittest.cc | 2 +- 12 files changed, 109 insertions(+), 34 deletions(-) commit 75f86906ffc92d57bbdcc86eed6d6b7cbd9d0884 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Dec 11 15:39:31 2018 +0000 mash: Fix ui_devtools shutdown UAF ash::Shell owned by ChromeBrowserMainExtraPartsAsh is released before UiDevToolsServer owned by ChromeBrowserMainExtraPartsViews. This causes a use-after-free in DOMAgentAura dtor when it tries to RemoveObserver from the already released Env of ash::Shell. Fix the issue by explicitly releasing |devtools_server_| in ChromeBrowserMainExtraPartsViews::PostMainMessageLoopRun. Bug: 896977 Change-Id: I07172d8014dc17c1a91a11e220579a13ad0524b0 Reviewed-on: https://chromium-review.googlesource.com/c/1370832 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615533} chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit df919902f0c64dc12f916d18c90765840fc62d1d Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 15:38:39 2018 +0000 Import wpt@69d00d5f81ac1b29673878368055d24390819cc8 Using wpt-import in Chromium 3e8e3c9e30366a5c4a3b4469a6592ed8e7fac345. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I5349c5b8538c4f94cb3341c878c95cbc7b3a73b7 Reviewed-on: https://chromium-review.googlesource.com/c/1371647 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615532} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 48 +++- .../the-script-element/muted-errors.sub.html | 8 + .../the-script-element/resources/throw.js | 1 + ...ent-handler-attributes-body-window-expected.txt | 117 +++++++- .../event-handler-attributes-body-window.html | 35 +-- ...handler-attributes-frameset-window-expected.txt | 313 +++++++++++++++++++++ .../event-handler-attributes-frameset-window.html | 28 ++ .../event-handler-attributes-window-body.html | 49 ---- .../events/resources/event-handler-body.js | 39 +++ .../testdriver/actions/elementPosition.html.ini | 3 - .../testdriver/actions/elementTiming.html.ini | 5 +- .../testdriver/actions/eventOrder.html.ini | 6 +- .../testdriver/actions/pause.html.ini | 6 +- 13 files changed, 546 insertions(+), 112 deletions(-) commit 79d671a0fab2b784324cb3b9d8d37800b5c7a2c9 Author: John Budorick <jbudorick@chromium.org> Date: Tue Dec 11 15:32:58 2018 +0000 blinkpy: switch to luci.chromium.try version of android_blink_rel. Bug: 731964,913687 Change-Id: Ie7de1a0aba1316b8916219afb766b18e95dc5549 Reviewed-on: https://chromium-review.googlesource.com/c/1372026 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615531} third_party/blink/tools/blinkpy/common/config/builders.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a40281ad05cfadc7af229ed5657139b67c2beaed Author: Li Hao <hao.x.li@intel.com> Date: Tue Dec 11 15:29:50 2018 +0000 Only overrides v8_current_cpu in mac toolchain when declared Sometimes we expect to build mac target without v8, but there is a warning that v8_current_cpu is set as a build argument, but not appeared in declare_args(). If the declaration file v8_target_cpu.gni is not imported, we should not override it. Change-Id: I04ef533a565fb9272aa1117ccea1bdee022f5c9a Reviewed-on: https://chromium-review.googlesource.com/c/1369645 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#615530} AUTHORS | 1 + build/toolchain/mac/BUILD.gn | 20 ++++++++++++++++---- 2 files changed, 17 insertions(+), 4 deletions(-) commit c18b832585db80ae890edafec2029a63a1460047 Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Dec 11 15:28:43 2018 +0000 Add FontLoading task queue CSS Font Loading spec refers a font-loading task queue. Add a queue matching that name and update it to use that queue. Change-Id: I885962521f2a17f3b35b181d3dc1066cc86a4e6e Reviewed-on: https://chromium-review.googlesource.com/c/1370707 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615529} third_party/blink/public/platform/task_type.h | 5 ++++- third_party/blink/renderer/core/css/font_face_set.cc | 2 +- .../renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc | 1 + .../blink/renderer/platform/scheduler/main_thread/task_type_names.cc | 2 ++ .../blink/renderer/platform/scheduler/worker/worker_scheduler.cc | 1 + tools/metrics/histograms/enums.xml | 3 +++ 6 files changed, 12 insertions(+), 2 deletions(-) commit 4938612668f2625a3ad35af38c21dd793ad9e632 Author: Sami Kyostila <skyostil@chromium.org> Date: Tue Dec 11 15:28:31 2018 +0000 base: Don't do delayed work after quitting in Mac message pump This patch fixes a problem in the Mac message pump where we kept calling Delegate::DoDelayedWork even if a previous call to Delegate::DoWork caused the runloop to quit. This matches the behavior outlined in message_pump.h[1] as well as that of the other platform-specific pumps. We also introduce a message pump unit test that verifies behavior across all message pump types. Bug: 891670 [1] https://cs.chromium.org/chromium/src/base/message_loop/message_pump.h?rcl=a28a6097182e739c4a8c600b538fcc07681fc7a3&l=58 Change-Id: I00ccb5c55ac8551259a2febd343ec64fdd55630d Reviewed-on: https://chromium-review.googlesource.com/c/1370367 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615528} base/BUILD.gn | 1 + base/message_loop/message_pump_mac.h | 31 ++++++++----- base/message_loop/message_pump_mac.mm | 43 +++++++++++------- base/message_loop/message_pump_mac_unittest.mm | 10 ++++- base/message_loop/message_pump_unittest.cc | 60 ++++++++++++++++++++++++++ 5 files changed, 117 insertions(+), 28 deletions(-) commit d8f76d5717a9737bb0f60588162ec5fff76ae3cd Author: David 'Digit' Turner <digit@google.com> Date: Tue Dec 11 15:26:58 2018 +0000 Android: fix missing resources packaging. This CL fixes compile_resources.py to ensure that it correctly includes missing localized strings into the final APK. The problem was that some android_resources() targets declared some Filipino resources under values-fil/ directories, and some Indonesian ones under values-in/ 'fil' is a 3-letter ISO 639-2 language code, that was not supported before Android 5.0/Lollipop. Hence, our script only tried to include strings from 2-letter locale qualifiers, excluding the -fil one entirely. Due to the problem above, most packages place their localized strings for Filipino are placed under 'values-tl/' instead, because 'tl' matches Tagalog, a related but lesser spoken language in the Philippines. Except a few packages that still use values-fil/, for examples see [2]. 'in' is a new 2-letter ISO 639-2 language code, but due to compatibility concerns, our script wants to use 'id' instead for the Indonesian language (see [1] for a little bit more details). A few packages provide their localized strings for Indonesian under values-in/, which was ignored [3]. This CL fixes the issue by renaming "newer" locale qualifiers to "older" ones. This is done by extracting the qualifier from values-<locale>, converting it to its Chromium version, then back to its Android version. In practice it also deals with BCP 47 codes, as in: values-fil/ -> values-tl/ values-in/ -> values-id/ values-b+en+US -> values-en-rUS/ The last example above is not relevant, but opens the door to supporting more locales in Chromium in the future. The end result is adding missing localized strings for Filipino and Indonesian for 30 string resources (listed below). This ends up increasing the size of MonochromePublic.apk by about 2000 bytes. BUG=921044 R=agrieve@chromium.org,estevenson@chromium.org,yfriedman@chromium.org,torne@chromium.org [1] https://developer.android.com/reference/java/util/Locale The section in the Locale() constructor that reads: * ISO 639 is not a stable standard; some of the language codes it defines (specifically "iw", "ji", and "in") have changed. This constructor accepts both the old codes ("iw", "ji", and "in") and the new codes ("he", "yi", and "id"), but all other API on Locale will return only the OLD codes. Older Android system releases could only read compiled resources from obsolete config locale qualifier (e.g. 'in' for Indonesian). [2] https://cs.chromium.org/chromium/src/third_party/feed/src/src/main/java/com/google/android/libraries/feed/basicstream/internal/viewholders/res/?q=values-fil&sq=package:chromium&dr [2] https://cs.chromium.org/search/?q=values-fil/&sq=package:chromium&type=cs [3] https://cs.chromium.org/search/?q=values-id/&sq=package:chromium&type=cs [4] List of affected string resources: back_button_content_description cancel_button dialog_button_got_it dialog_button_open_help_center dialog_message_incompatible_phone dialog_message_no_cardboard dialog_title dialog_title_incompatible_phone dialog_title_vr_core_not_enabled dialog_title_vr_core_not_installed dialog_title_warning dialog_vr_core_not_enabled dialog_vr_core_not_installed go_to_playstore_button go_to_vr_listeners_settings_button more_button_label no_browser_text no_suggestions place_your_phone_into_cardboard place_your_viewer_into_viewer_format settings_button_content_description setup_button snackbar_fetch_failed snackbar_fetch_no_new_suggestions suggestions_section_empty switch_viewer_action switch_viewer_prompt zero_state_text_afternoon zero_state_text_evening zero_state_text_morning To obtain this list, process the unoptimized resources archives (where resource names are not obfuscated) as follows: aapt dump resources \ out/Release/obj/chrome/android/monochrome_public_apk.unoptimized.ap_ | \ sed -e 's/d=0x[0-9a-f]*//g' > /tmp/A/Resources.txt Do this for the build before and after this CL is applied and compare the results. The 'sed' part is used to get rid of irrelevant differences in each resource allocation. Change-Id: I4a7d961d68de381106347072a69eda6751d1bf7f Reviewed-on: https://chromium-review.googlesource.com/c/1367730 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615527} build/android/gyp/compile_resources.py | 65 +++++++++++++++++++++++++++++++++- 1 file changed, 64 insertions(+), 1 deletion(-) commit cc91158a5505d55b66cd01b5da2d4ad973e9ffd9 Author: Justin DeWitt <dewittj@chromium.org> Date: Tue Dec 11 15:25:48 2018 +0000 [EoS] Fix formatting of ExploreSitesPageTest This causes a lint error on the official builders. Bug: 894334,913755,913012 Change-Id: I9dbaa9932873755639d22618b3d758ef87c840cb Reviewed-on: https://chromium-review.googlesource.com/c/1370587 Reviewed-by: Cathy Li <chili@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615526} .../chrome/browser/explore_sites/ExploreSitesPageTest.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit d43bac39964ca4a6335786b2fcd5bb91197c4f6b Author: Oleh Prypin <oprypin@chromium.org> Date: Tue Dec 11 15:13:48 2018 +0000 Pull isolated perf output files for all retries instead of clobbering The Android test runner, when retries were enabled, previously would overwrite the isolated-script-test-perf-output JSON file with the latest try, which means that all previous results would be lost. Now it will still write to the provided 'file-name.json' first, but then for following tries it will write to 'file-name_1.json', 'file-name_2.json', etc., which can allow to salvage the results in post-processing. Unrelated change in behavior due to refactoring: --app-data-file previously used this naming scheme for outputs: ['file-name_0.ext', 'file-name_1.ext', ...]; now it's ['file-name.ext', 'file-name_1.ext', ...]. Bug: 755660 Change-Id: Id8ecb506ef91504b925178b433544faa3db8c476 Reviewed-on: https://chromium-review.googlesource.com/c/1371426 Commit-Queue: Oleh Prypin <oprypin@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615525} .../pylib/local/device/local_device_gtest_run.py | 48 ++++++++++++---------- 1 file changed, 27 insertions(+), 21 deletions(-) commit 1aaf9f1ecd500142cb76c4ec0fbe2cd4963e5dbe Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Dec 11 15:07:20 2018 +0000 Ensure minidumps capture LazilyDeallocatedDeque size As a temporary measure add an aliased variable to record the size of the queue. Bug: 912541 Change-Id: I874fcc7cb463b3b891fbe875d42539e72d771767 Reviewed-on: https://chromium-review.googlesource.com/c/1371809 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615524} base/task/sequence_manager/lazily_deallocated_deque.h | 9 +++++++++ 1 file changed, 9 insertions(+) commit ba5fd2ae8690c6e46f78defdf5401661185f06e7 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Tue Dec 11 14:56:19 2018 +0000 [Autofill] Increase the limit for the number of fields to 250 According to metrics, 0.3% of forms have >100 fields (the current limit), increase the limit to 250 in order to cover all forms. Autofill throttling limits the number of queries/uploads are sent for a given form by a given user. Therefore, uploading huge forms wouldn't flood network. Bug: 857454 Change-Id: Ia92a3d6f2033159df121d8728a263c70ee7914f7 Reviewed-on: https://chromium-review.googlesource.com/c/1369772 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615523} components/autofill/core/browser/form_structure.cc | 4 ++-- components/autofill/core/browser/form_structure_unittest.cc | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) commit 2f23bb9f1a536c3cfcd01432b3b5c522f4cbb5b2 Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 14:55:31 2018 +0000 Mark target_blank_implicit_noopener.tentative.html as failing on Mac This test is consistently failing on Mac since the last wpt roll. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913932, 626703 TBR=robertma@chromium.org Change-Id: I071d68a9003edecf4b24b10b4adfe1c86cf7da61 Reviewed-on: https://chromium-review.googlesource.com/c/1371904 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615522} third_party/blink/web_tests/TestExpectations | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 1ab0d68135460e3d9186665774cdec024e0c4994 Author: Tim Schumann <tschumann@chromium.org> Date: Tue Dec 11 14:49:33 2018 +0000 Clarify error message when failing to parse a pref value Change-Id: I1b762a554913d0e3b3df0792c2ff845c4dde5a53 Reviewed-on: https://chromium-review.googlesource.com/c/1370365 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#615521} components/sync_preferences/pref_model_associator.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b1525775f8eb45cd60230ff8329e99167011d979 Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 14:45:00 2018 +0000 Revert "[Reland #3] Use the SequenceManager in ScopedTaskEnvironment" This reverts commit d1317fc30ce4e9ef08c5197c0f67767dfe585df4. Reason for revert: SyncSchedulerImplTest is failing and this is the most likely culprit. More information in the linked bug. Bug: 913946 Original change's description: > [Reland #3] Use the SequenceManager in ScopedTaskEnvironment > > A reland of https://crrev.com/c/1324391 > > This is necessary because we want content::TestBrowserThreadBundle to > own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment > and you can't have two SequenceManagers on the same thread. > > This patch allows ScopedTaskEnvironment to optionally work with an > externally owned SequenceManager solving the problem. > > This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, > > We now have the ability to mock time on the UI and IO threads. > > RE HttpServiceTest change HttpServiceTest.MultipleRequests was failing > mysteriously on fuschia on the bots only (not locally). IO_MOCK_TIME seems > to have fixed this. > > > TBR=gab@chromium.org,fdoray@chromium.org,wez@chromium.org > > Bug: 863341, 891670, 708584 > Change-Id: I95444a0a50f8b577c5fae62c12c8423c7e8f21d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1361863 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615496} TBR=wez@chromium.org,gab@chromium.org,fdoray@chromium.org,skyostil@chromium.org,alexclarke@chromium.org Change-Id: If5ff0362758b5270eb3113d2fd6eeeb7facc37c3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863341, 891670, 708584 Reviewed-on: https://chromium-review.googlesource.com/c/1371811 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615520} base/test/scoped_task_environment.cc | 295 +++++--------------------- base/test/scoped_task_environment.h | 52 ++--- base/test/scoped_task_environment_unittest.cc | 8 - webrunner/net_http/http_service_unittest.cc | 2 +- 4 files changed, 73 insertions(+), 284 deletions(-) commit 5573d1f00e2a0c50f4e7c92439d254f8c88dd0a3 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Dec 11 14:36:27 2018 +0000 Android: Add proguard flag to prevent obfuscation of BackgroundTask classes These classes need to be the same across releases. Bug: 913116 Change-Id: I57dc8928f24944f0234863f5fcfc248886c6a7cc Reviewed-on: https://chromium-review.googlesource.com/c/1371244 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615519} components/background_task_scheduler/BUILD.gn | 2 ++ components/background_task_scheduler/android/proguard.flags | 8 ++++++++ 2 files changed, 10 insertions(+) commit 42998e125184ab82a0a54bd8b2691c3f1b303523 Author: Florent Castelli <orphis@chromium.org> Date: Tue Dec 11 14:33:38 2018 +0000 Implement RTCRtpReceiver.getParameters() Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/LXJUzctTVfM/p4J-WrzbBgAJ Bug: 908911 Change-Id: I8e82cc588fb991458e2372fe1dcb9db459cd36b5 Reviewed-on: https://chromium-review.googlesource.com/c/1363276 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615518} .../media/webrtc/fake_rtc_rtp_transceiver.cc | 6 ++ .../media/webrtc/fake_rtc_rtp_transceiver.h | 1 + content/renderer/media/webrtc/rtc_rtp_receiver.cc | 9 +++ content/renderer/media/webrtc/rtc_rtp_receiver.h | 1 + .../blink/public/platform/web_rtc_rtp_receiver.h | 2 + .../blink/renderer/modules/modules_idl_files.gni | 2 + .../peerconnection/rtc_rtp_decoding_parameters.idl | 7 +++ .../peerconnection/rtc_rtp_receive_parameters.idl | 8 +++ .../modules/peerconnection/rtc_rtp_receiver.cc | 41 +++++++++++++ .../modules/peerconnection/rtc_rtp_receiver.h | 2 + .../modules/peerconnection/rtc_rtp_receiver.idl | 3 +- .../modules/peerconnection/rtc_rtp_sender.cc | 71 +++++++++++++--------- .../modules/peerconnection/rtc_rtp_sender.h | 4 ++ .../external/wpt/webrtc/RTCRtpParameters-helper.js | 2 + .../RTCRtpReceiver-getParameters-expected.txt | 4 +- .../wpt/webrtc/RTCRtpReceiver-getParameters.html | 49 +++++++++++++-- .../webrtc/idlharness.https.window-expected.txt | 2 +- .../global-interface-listing-expected.txt | 1 + .../RTCRtpReceiver-getParameters-expected.txt | 4 +- .../webrtc/idlharness.https.window-expected.txt | 4 +- .../global-interface-listing-expected.txt | 1 + 21 files changed, 184 insertions(+), 40 deletions(-) commit 305f852f9a12583ebe0eaa5ed1508380e5b56dc1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 14:30:37 2018 +0000 Roll src/third_party/perfetto 3c2ff12d419d..152255fcc745 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/3c2ff12d419d..152255fcc745 git log 3c2ff12d419d..152255fcc745 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com Fix test failure on is_debug. Created with: gclient setdep -r src/third_party/perfetto@152255fcc745 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If77220fecdba346d3506e552c69fa9d8ed3ffeb8 Reviewed-on: https://chromium-review.googlesource.com/c/1371709 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615517} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 932fb1811874f0e33a1cf776e352c92d76ea7166 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 14:29:18 2018 +0000 Roll src-internal 757effd70e5f..84629852e33d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/757effd70e5f..84629852e33d Created with: gclient setdep -r src-internal@84629852e33d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic04ded354bf2c823a6c08eec6163ed351980325c Reviewed-on: https://chromium-review.googlesource.com/c/1371708 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615516} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 21a6dd4b4ba62708038819f8a0e87882429db31e Author: Rayan Kanso <rayankans@chromium.org> Date: Tue Dec 11 14:20:08 2018 +0000 [Background Fetch] Create a cache entry handler for BGF. The handler uses the side data blob to store the request body if any. Bug: 774054 Change-Id: I14ec3e992543937bef7a601bcb603103842c6acf Reviewed-on: https://chromium-review.googlesource.com/c/1363205 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Reviewed-by: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#615515} content/browser/BUILD.gn | 2 + .../background_fetch_data_manager_unittest.cc | 70 +++++++++++++++++ .../storage/cache_entry_handler_impl.cc | 88 ++++++++++++++++++++++ .../storage/cache_entry_handler_impl.h | 46 +++++++++++ .../storage/mark_request_complete_task.cc | 4 +- .../browser/cache_storage/cache_storage_cache.cc | 29 +++++-- .../cache_storage_cache_entry_handler.cc | 54 +++++++++---- .../cache_storage_cache_entry_handler.h | 20 +++-- 8 files changed, 280 insertions(+), 33 deletions(-) commit 79782f306a809e7bf6081a2815e61f5b785c8fdf Author: Joe Mason <joenotcharles@google.com> Date: Tue Dec 11 14:17:42 2018 +0000 Load the Chrome Cleaner partner logo SVG with GetRawDataResource. The logo now has a title attr in it for screen readers. But when it's set as the background of a <span>, or as an <img> src, screen readers don't look at the tags inside. For the screen reader to view the tag it seems the <svg> element must be part of the DOM tree. So after the <svg> element is loaded from a resource, add it directly to the page. R=hcarmona@chromium.org Bug: 767130 Change-Id: I1de73057ba59df114fdb142baab9fc66f210995f Reviewed-on: https://chromium-review.googlesource.com/c/1370833 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615514} .../settings/chrome_cleanup_page/chrome_cleanup_page.html | 6 +++--- .../settings/md_settings_localized_strings_provider.cc | 15 ++++++++++++++- chrome/browser/ui/webui/settings/md_settings_ui.cc | 8 -------- 3 files changed, 17 insertions(+), 12 deletions(-) commit cd06525fb4a75d3529d2090c5cd61b5cd5e582e6 Author: Marc Treib <treib@chromium.org> Date: Tue Dec 11 14:11:00 2018 +0000 PersonalDataManager: Make some methods static or const Bug: none Change-Id: I8f0360e7f3ff166aa321a9041b6dd5865dcf5988 Reviewed-on: https://chromium-review.googlesource.com/c/1371425 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615513} .../autofill/core/browser/personal_data_manager.cc | 35 ++++++++++++---------- .../autofill/core/browser/personal_data_manager.h | 14 +++++---- 2 files changed, 27 insertions(+), 22 deletions(-) commit 75a648a7b293a457600dee0518a5a8e7c52af542 Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 14:07:33 2018 +0000 Revert "Add autofill_profile integration test for UMA Sync.ModelTypeEntityChange3" This reverts commit 05142837eebe9a1c5cde711f09d21fdbb195ca4d. Reason for revert: Added test flakes on most Mac versions. Bug: 913939 Original change's description: > Add autofill_profile integration test for UMA Sync.ModelTypeEntityChange3 > > The new test is similar to the existing PersonalDataManagerSanity test, > but adds checks for the Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE > histogram. > Compared to PersonalDataManagerSanity, the new test skips the step of > adding a duplicate profile, since that seems to produce flaky results. > > Bug: 904390 > Change-Id: Ic85050dcab80e53ea1a5e1fa63f61db5e6c2cb09 > Reviewed-on: https://chromium-review.googlesource.com/c/1369778 > Reviewed-by: Jan Krcal <jkrcal@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615461} TBR=treib@chromium.org,jkrcal@chromium.org Change-Id: I1da849dfe70d5523b8d211d0d6d592c101672456 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 904390 Reviewed-on: https://chromium-review.googlesource.com/c/1371888 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615512} .../integration/two_client_autofill_sync_test.cc | 147 +-------------------- 1 file changed, 1 insertion(+), 146 deletions(-) commit f1dba9d26a5dcfdf751707b36459377efd3e380b Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 13:59:08 2018 +0000 Update V8 to version 7.3.85. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff281cc4..9a1b0e72 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id3e47c4585c77e1d6a0a9a4a259a13889ec47031 Reviewed-on: https://chromium-review.googlesource.com/c/1371645 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615511} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3e8e3c9e30366a5c4a3b4469a6592ed8e7fac345 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 13:28:58 2018 +0000 Import wpt@19d3a235abd449f452e418947b3720d73fc718ce Using wpt-import in Chromium 447dc435c51c829be3b61997f8d8fb2e29a1fb5a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I42c4d57343eac3172b9e4a303d7cff1eac201f89 Reviewed-on: https://chromium-review.googlesource.com/c/1371644 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615510} third_party/blink/web_tests/TestExpectations | 2 + .../web_tests/external/WPT_BASE_MANIFEST_5.json | 57 +- .../attribute-case/cssom-expected.txt | 60 ++ .../attribute-selectors/attribute-case/cssom.html | 3 + .../attribute-case/resources/syntax-quirks.html | 2 +- .../attribute-case/resources/syntax-xml.xhtml | 2 +- .../attribute-case/semantics-expected.txt | 911 +++++++++++++++++++++ .../attribute-case/semantics.html | 115 ++- .../attribute-case/syntax-expected.txt | 562 +++++++++++++ .../attribute-selectors/attribute-case/syntax.html | 30 +- 10 files changed, 1734 insertions(+), 10 deletions(-) commit 703eff8e700f96e56470d16d5f0a968860e52ebf Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Dec 11 13:26:11 2018 +0000 [iOS][Translate] Refactors popup menu UI for reuse - Removes dependency of :popup_menu_ui to the tools popup menu and navigation popup menu logic, i.e., PopupMenuCommands, coordinator, and mediator, allowing it to be reused in the new translate infobar for the language selection as well as translate options popup menus. - Moves reusable UI targets to ios/chrome/browser/ui/popup_menu/publicenu. Bug: 910994 Change-Id: I16229bd0d8d64ba4e20498bdb3ea283b780f0678 Reviewed-on: https://chromium-review.googlesource.com/c/1358114 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615509} ios/chrome/browser/ui/popup_menu/BUILD.gn | 80 ++++------- ios/chrome/browser/ui/popup_menu/cells/BUILD.gn | 6 +- .../popup_menu/cells/popup_menu_navigation_item.h | 2 +- .../popup_menu/cells/popup_menu_navigation_item.mm | 2 +- .../ui/popup_menu/cells/popup_menu_tools_item.h | 2 +- .../ui/popup_menu/cells/popup_menu_tools_item.mm | 2 +- .../ui/popup_menu/popup_menu_action_handler.h | 34 +++++ .../ui/popup_menu/popup_menu_action_handler.mm | 150 ++++++++++++++++++++ .../popup_menu_action_handler_commands.h | 21 +++ .../browser/ui/popup_menu/popup_menu_constants.h | 10 +- .../browser/ui/popup_menu/popup_menu_constants.mm | 6 - .../ui/popup_menu/popup_menu_coordinator.mm | 30 ++-- .../browser/ui/popup_menu/popup_menu_mediator.h | 8 +- .../browser/ui/popup_menu/popup_menu_mediator.mm | 21 ++- .../ui/popup_menu/popup_menu_mediator_unittest.mm | 4 +- .../browser/ui/popup_menu/popup_menu_presenter.h | 25 ---- .../popup_menu_table_view_controller_commands.h | 16 --- ios/chrome/browser/ui/popup_menu/public/BUILD.gn | 44 ++++++ .../browser/ui/popup_menu/public/cells/BUILD.gn | 16 +++ .../{ => public}/cells/popup_menu_footer_item.h | 6 +- .../{ => public}/cells/popup_menu_footer_item.mm | 2 +- .../{ => public}/cells/popup_menu_item.h | 6 +- .../popup_menu/{ => public}/popup_menu_consumer.h | 10 +- .../ui/popup_menu/public/popup_menu_presenter.h | 26 ++++ .../{ => public}/popup_menu_presenter.mm | 49 ++++--- .../public/popup_menu_presenter_delegate.h | 23 ++++ .../popup_menu_table_view_controller.h | 23 ++-- .../popup_menu_table_view_controller.mm | 152 +++------------------ .../popup_menu_table_view_controller_delegate.h | 25 ++++ .../ui/popup_menu/public/popup_menu_ui_constants.h | 18 +++ .../popup_menu/public/popup_menu_ui_constants.mm | 14 ++ .../{ => public}/popup_menu_view_controller.h | 10 +- .../{ => public}/popup_menu_view_controller.mm | 14 +- .../public/popup_menu_view_controller_delegate.h | 21 +++ 34 files changed, 540 insertions(+), 338 deletions(-) commit bc7cfa6993305837d194dbcd18350cb3535bdee6 Author: Arthur Hemery <ahemery@chromium.org> Date: Tue Dec 11 13:22:42 2018 +0000 Navigation: Removed deprecated error functions TestRenderFrameHost. This patch removes deprecated methods RenderFrameHostTester::SimulateNavigationError and SimulateNavigationErrorPageCommit as well as their remaining uses in unit tests. Bug: 728571 Change-Id: I8f1d6b825cf80aad0680c3fd95a283897b19ebe8 Reviewed-on: https://chromium-review.googlesource.com/c/1370175 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#615508} .../navigation_controller_impl_unittest.cc | 7 ++-- .../renderer_host/render_process_host_unittest.cc | 8 ++-- content/test/test_render_frame_host.cc | 45 ---------------------- content/test/test_render_frame_host.h | 8 ---- 4 files changed, 7 insertions(+), 61 deletions(-) commit 66308504a8e28cd4e6e597842af202a342c71ffc Author: Jakob Gruber <jgruber@chromium.org> Date: Tue Dec 11 13:11:26 2018 +0000 Add use counters for IsRegExp A spec change to simplify IsRegExp has been proposed: https://github.com/tc39/ecma262/pull/1318 This CL adds use counters for cases in which the spec change would alter behavior: 1. o[@@match] is trueish but o is not a JSRegExp 2. o[@@match] is falseish (but not undefined) and o is a JSRegExp This is the Chromium side of required changes. The V8-side CL: https://crrev.com/c/1360630 Bug: v8:8522 Change-Id: I2ec9b1a5f54f8e70a02e48f280a548871990aabd Reviewed-on: https://chromium-review.googlesource.com/c/1360730 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#615507} third_party/blink/public/platform/web_feature.mojom | 2 ++ third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc | 6 ++++++ tools/metrics/histograms/enums.xml | 2 ++ 3 files changed, 10 insertions(+) commit 573be0639f7a41d4f103307d40b7d28d3d7f7a55 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 13:01:16 2018 +0000 Roll src/third_party/depot_tools fed2cb39c320..52411ecf1fa5 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fed2cb39c320..52411ecf1fa5 git log fed2cb39c320..52411ecf1fa5 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 sortie@google.com Add windows .bat file for gsutil.py. Created with: gclient setdep -r src/third_party/depot_tools@52411ecf1fa5 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5716ec83309d0687fc4897212381997e2374bac2 Reviewed-on: https://chromium-review.googlesource.com/c/1371706 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615506} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb7edc936d998ec5fc822580f8d076fa0d25d8b6 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 12:56:35 2018 +0000 Roll src-internal 58b1f41bf2fc..757effd70e5f (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/58b1f41bf2fc..757effd70e5f Created with: gclient setdep -r src-internal@757effd70e5f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I72059db2c1ae9f356311302948e043da14b5e44d Reviewed-on: https://chromium-review.googlesource.com/c/1371705 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615505} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b8a1977e84b471e42a6b6798dc2a607dfb28e91 Author: Mikel Astiz <mastiz@chromium.org> Date: Tue Dec 11 12:54:45 2018 +0000 Fix flakiness in SingleClientSessionsSyncTest.CookieJarMismatch Unless something is done about it, there is a race between signin code trying to fetch "real" cookiejar information using GaiaAuthFetcher, and the test faking equivalent information and injecting it via ProfileSyncService::OnGaiaAccountsInCookieUpdatedWithCallback(). Usually, signin logic is fast enough to avoid test failures, but occasionally the fetching takes long and an empty list of accounts is injected at a last stage (after navigations to kURL2), interfering with test expectations. Bug: 789129 Change-Id: I95b0f691bd047216309888d345c68e1eb26ab869 Reviewed-on: https://chromium-review.googlesource.com/c/1371386 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615504} .../integration/single_client_sessions_sync_test.cc | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) commit d7e9b01e2a51474f9ff417b956f16a4f3beb641e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 12:54:15 2018 +0000 Roll src/third_party/perfetto bfb8c97cb567..3c2ff12d419d (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/bfb8c97cb567..3c2ff12d419d git log bfb8c97cb567..3c2ff12d419d --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com fuzzing: Do no copy unneeded data files. Created with: gclient setdep -r src/third_party/perfetto@3c2ff12d419d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:69150303 TBR=perfetto-bugs@google.com Change-Id: I7b09f0d39d545600624c2a319a0b853425bd030a Reviewed-on: https://chromium-review.googlesource.com/c/1371704 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615503} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0d37fb92c058ad2c170e07812b3b2cc0154c4342 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Dec 11 12:46:42 2018 +0000 Add API to convert AccountTrackerService::FindAccountInfoByXXX Add methods to find AccountInfo using either account id, email address or gaia id to IdentityManager. They are wrapper around the corresponding method of AccountTrackerService (with a call to GetAccountInfoForAccountWithValidRefreshToken to get the logic to deal with kSupervisedUserPseudoEmail). Add unit tests for the new methods. Bug: 912170 Change-Id: Ic7da17b0f22c85349b89cb44d272a3a6b4f6d573 Reviewed-on: https://chromium-review.googlesource.com/c/1365245 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#615502} services/identity/public/cpp/identity_manager.cc | 45 +++++++++++++ services/identity/public/cpp/identity_manager.h | 23 +++++++ .../public/cpp/identity_manager_unittest.cc | 76 ++++++++++++++++++++++ 3 files changed, 144 insertions(+) commit 1fe84051c4a92c7578fbbf71e7d292dc1fb5f287 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Tue Dec 11 12:45:42 2018 +0000 Remove PrimaryAccountMutatorTest test fixture The fixture made code more convoluted as the default test environment had to be created in the constructor (as the tests expected it) and then recreated afterwards for the ClearPrimaryAccount tests. Instead not using the fixture make the tests more straight-forward as the objects used by each individual tests are explicitly created. This adds some boilerplate, but logic of RunClearPrimaryAccountTest is now clear (previously you had to check in the test what the value of the account consistency method was, while now it is expliclty passed to the method). This follow the recommendation from the following tips of the week https://abseil.io/tips/122 that recommends avoiding fixtures. Bug: none Change-Id: Ia8af245f7b1a3bdeddb7a09fb9baa54a371b8512 Reviewed-on: https://chromium-review.googlesource.com/c/1363199 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#615501} .../public/cpp/primary_account_mutator_unittest.cc | 789 ++++++++++++--------- 1 file changed, 436 insertions(+), 353 deletions(-) commit 2545cc4292cd8343302b111104201f60a1701a63 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Dec 11 12:31:31 2018 +0000 [iOS][Translate] Moves LanguageSelectionHnadler out of infobarcoordinator Instead of passing the id<LanguageSelectionHandler> to the ChromeIOSTranslateClient during construction which is prone to error due to dependency on the order in which ChromeIOSTranslateClient and the InfobarCoordinator are initialized, this CL modifies the LanguageSelectionCoordinator to observe the WebStateList and set/unset the id<LanguageSelectionHandler> on instances of ChromeIOSTranslateClient when appropriate. This fixes a DCHECK during ChromeIOSTranslateClient construction and helps make the feature more self-contained as the InfobarCoordinator/Mediator no longer needs to know about the languageSelectionHandler. TBR=rohitrao@ Bug: 912502 Change-Id: Id3769f10a0ed638821afdd9578bd263700768299 Reviewed-on: https://chromium-review.googlesource.com/c/1366467 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615500} .../before_translate_infobar_controller.mm | 1 + .../translate/chrome_ios_translate_client.h | 17 ++- .../translate/chrome_ios_translate_client.mm | 22 ++-- ios/chrome/browser/ui/browser_view_controller.mm | 4 +- ios/chrome/browser/ui/infobars/BUILD.gn | 1 + .../ui/infobars/infobar_container_coordinator.h | 5 - .../ui/infobars/infobar_container_coordinator.mm | 13 --- .../ui/infobars/infobar_container_mediator.h | 5 - .../ui/infobars/infobar_container_mediator.mm | 16 --- ios/chrome/browser/ui/main/BUILD.gn | 1 + ios/chrome/browser/ui/main/browser_coordinator.mm | 14 +++ ios/chrome/browser/ui/translate/BUILD.gn | 3 + .../ui/translate/language_selection_coordinator.h | 19 ++- .../ui/translate/language_selection_coordinator.mm | 100 +++++++--------- .../ui/translate/language_selection_mediator.h | 18 ++- .../ui/translate/language_selection_mediator.mm | 127 +++++++++++++++++++-- 16 files changed, 223 insertions(+), 143 deletions(-) commit 5aeb932e04f7f94225f5eb804967f3985ed3de9d Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue Dec 11 12:31:11 2018 +0000 Constructable Stylesheets with replace methods The draft spec for Constructable Stylesheets has moved on from factory functions to normal constructors for CSSStyleSheets, with methods to replace the contents of a constructed stylesheet synchronously or asynchronously. This CL replaces the old factory functions to normal constructors, and implements replace and replaceSync method, the constructed flag, and the disallow modification flag. Not implemented in this CL: allow usage of constructed stylesheets in multiple Documents, FrozenArray instead of StyleSheetList for adoptedStyleSheets. Draft spec: https://wicg.github.io/construct-stylesheets/index.html Bug: 807560 Change-Id: I3c4ea296338d03585ede6332bf29d6732b71c816 Reviewed-on: https://chromium-review.googlesource.com/c/1347647 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615499} .../blink/renderer/core/css/css_style_sheet.cc | 79 +++++++++++++ .../blink/renderer/core/css/css_style_sheet.h | 19 ++++ .../blink/renderer/core/css/css_style_sheet.idl | 6 + .../renderer/core/css/css_style_sheet_test.cc | 110 ------------------ .../renderer/core/css/style_sheet_contents.cc | 7 +- third_party/blink/renderer/core/dom/document.cc | 59 ---------- third_party/blink/renderer/core/dom/document.h | 26 ----- third_party/blink/renderer/core/dom/document.idl | 5 - third_party/blink/renderer/core/dom/tree_scope.cc | 18 +-- .../external/wpt/css/cssom/interfaces-expected.txt | 6 +- .../fast/css/CSSStyleSheet-constructable.html | 123 ++++++++++++++------- .../web_tests/fast/css/constructable-import.css | 2 +- .../fast/dom/custom/define-with-default-style.html | 2 +- .../fast/dom/dom-constructors-expected.txt | 4 +- .../blink/web_tests/fast/dom/dom-constructors.html | 2 +- .../global-interface-listing-expected.txt | 5 +- 16 files changed, 208 insertions(+), 265 deletions(-) commit 5a482ae50fa95b3aa7a792450b4c6b8bbfa1e4c2 Author: Tim Volodine <timvolodine@chromium.org> Date: Tue Dec 11 12:20:27 2018 +0000 [AW NS] Initial AndroidStreamReaderURLLoader implementation and tests This patch implements the initial bits for the custom URLLoader that reads from an android InputStream and returns the results (instead of fetching response from an actual network). The general idea is to have this custom AndroidStreamReaderURLLoader take care of a number of things: 1. provide response in the context of shouldInterceptRequest callback 2. allow to read special url like file://android_asset/ to obtain app resources and assets. This patch aims to provide support for the shouldInterceptRequest callback. In particular it makes sure the stream is opened, correctly positioned (range seek), response headers are initialized, etc... Going forward some bits will be implemented further: i.e. returning and writing the actual body response via mojo pipes. Approximately speaking the AndroidStreamReaderURLLoader is the network service counterpart of AndroidStreamReaderURLRequestJob (which is used by the current net/ code path). The patch also adds some relevant corresponding unit tests for the loader. BUG=893566,841556 Change-Id: I15247813f2b359445a2e9d45a18c8e595dfebdb2 Reviewed-on: https://chromium-review.googlesource.com/c/1363184 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#615498} android_webview/BUILD.gn | 2 + android_webview/browser/DEPS | 4 + .../android_stream_reader_url_loader.cc | 242 +++++++++++++++++++++ .../android_stream_reader_url_loader.h | 76 +++++++ .../android_stream_reader_url_loader_unittest.cc | 170 +++++++++++++++ android_webview/test/BUILD.gn | 1 + 6 files changed, 495 insertions(+) commit 9aadea2b2c22ea9fa6dda5cfd53af577e6e193b6 Author: Kent Tamura <tkent@chromium.org> Date: Tue Dec 11 12:19:23 2018 +0000 Form-associated custom elements: customElements.define() should check existence of 'value' property setter on a prototype chain This is a follow-up of crrev.com/613499. Bug: 905922 Bug: https://github.com/w3c/webcomponents/issues/187 Change-Id: I0c364d1f3031dde063d40867b5b93cde8a4bdc0e Reviewed-on: https://chromium-review.googlesource.com/c/1370240 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615497} .../v8/script_custom_element_definition_builder.cc | 47 +++++++++++++++++++--- .../tentative/form-association.html | 15 +++++++ 2 files changed, 57 insertions(+), 5 deletions(-) commit d1317fc30ce4e9ef08c5197c0f67767dfe585df4 Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Dec 11 12:19:20 2018 +0000 [Reland #3] Use the SequenceManager in ScopedTaskEnvironment A reland of https://crrev.com/c/1324391 This is necessary because we want content::TestBrowserThreadBundle to own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment and you can't have two SequenceManagers on the same thread. This patch allows ScopedTaskEnvironment to optionally work with an externally owned SequenceManager solving the problem. This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, We now have the ability to mock time on the UI and IO threads. RE HttpServiceTest change HttpServiceTest.MultipleRequests was failing mysteriously on fuschia on the bots only (not locally). IO_MOCK_TIME seems to have fixed this. TBR=gab@chromium.org,fdoray@chromium.org,wez@chromium.org Bug: 863341, 891670, 708584 Change-Id: I95444a0a50f8b577c5fae62c12c8423c7e8f21d6 Reviewed-on: https://chromium-review.googlesource.com/c/1361863 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615496} base/test/scoped_task_environment.cc | 295 +++++++++++++++++++++----- base/test/scoped_task_environment.h | 52 +++-- base/test/scoped_task_environment_unittest.cc | 8 + webrunner/net_http/http_service_unittest.cc | 2 +- 4 files changed, 284 insertions(+), 73 deletions(-) commit f326f2b3fdb13584493bb594ad07da5f85c02c23 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Tue Dec 11 11:53:42 2018 +0000 [ChromeOS][Flaky] Disable three flaky ChromeVox tests This CL disabled these flaky tests: TextFocusFeedback DoubleFocusAlertDialogFeedback ToggleOnKeyUp They have caused failures recently and show a history of flakiness: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ChromeVoxEventWatcherUnitTest TBR=dmazzoni@chromium.org Bug: 912390, 622387 Change-Id: If7647be13420ff98df3a51d0fa156635f181c074 Reviewed-on: https://chromium-review.googlesource.com/c/1371476 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615495} .../chromevox/chromevox/injected/event_watcher_test.unitjs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit e4d3737ee90e2cebbe4ddb105be8c214f0a49cf0 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 11:50:18 2018 +0000 Roll src-internal fabd12d5c959..58b1f41bf2fc (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fabd12d5c959..58b1f41bf2fc Created with: gclient setdep -r src-internal@58b1f41bf2fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I46ffec1a5aec51a8d01717f847a1156fe3baac33 Reviewed-on: https://chromium-review.googlesource.com/c/1371504 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615494} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dad9f500302e7dc6039700b8e0c8a4b11e29de26 Author: Max Morin <maxmorin@chromium.org> Date: Tue Dec 11 11:49:37 2018 +0000 Remove power monitoring from AudioThreadHangMonitor. The current code has two bugs. 1. PowerMonitor::RemoveObserver isn't called at destruction. Oops. 2. PowerMonitor::AddObserver is called from a task scheduler thread, which can race with the power monitor being destructed on the main thread. 1 is straightforward to fix but 2 isn't really. The power monitor isn't adding much value, so let's just remove it. Bug: 912922, 912997 Change-Id: I11cbc028d6ef4a9767096f2553d1cc340aa86e57 Reviewed-on: https://chromium-review.googlesource.com/c/1371390 Reviewed-by: Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615493} media/audio/audio_thread_hang_monitor.cc | 16 ---------------- media/audio/audio_thread_hang_monitor.h | 12 ++---------- 2 files changed, 2 insertions(+), 26 deletions(-) commit 0c41037a73d66769c850e59214d6d471f071ab0e Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 11:36:33 2018 +0000 Revert "Add RPATH to shared libraries" This reverts commit 3b3db14346589ff4069d004883b52d0a01690fe5. Reason for revert: Strongest suspect for the last 40 failures of telemetry_perf_unittests and telemetry_unittests which failed being unable to find some shared libraries. Bug:913070 Original change's description: > Add RPATH to shared libraries > > Fixes libfontconfig.so not being able to find libfreetype_harfbuzz.so: > > $ ldd libfontconfig.so | grep freetype_harfbuzz > libfreetype_harfbuzz.so => not found > $ ls libfreetype_harfbuzz.so > libfreetype_harfbuzz.so > > R=​thakis > > Bug: 911836,912366 > Change-Id: Ia0aaed8fc2c745b02cecf9ee3ce9888c1d8ccf77 > Reviewed-on: https://chromium-review.googlesource.com/c/1362457 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614255} TBR=thakis@chromium.org,dpranke@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 911836, 912366 Change-Id: Ief4c7258208a2903bb06685d4edc76f482f7a0bf Reviewed-on: https://chromium-review.googlesource.com/c/1371385 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615492} build/config/BUILD.gn | 2 -- build/config/gcc/BUILD.gn | 21 ++++++--------------- 2 files changed, 6 insertions(+), 17 deletions(-) commit 8e3fd55482ce22d1210abd82624258c1fdca846e Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 11:35:13 2018 +0000 Mark compositing/transitions/transform-on-large-layer.html crashing In addition to timeouts, the mentioned test shows gpu crashes. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913865, 900641 TBR=gogerald@chromium.org Change-Id: Id1d59744cbd3fb50df822789e1332d77d778756e Reviewed-on: https://chromium-review.googlesource.com/c/1371444 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615491} third_party/blink/web_tests/TestExpectations | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6c781857419f5209ff15bf5dca5208f39ab6a4a5 Author: Thomas Tangl <tangltom@chromium.org> Date: Tue Dec 11 11:32:12 2018 +0000 [unified-consent] Create settings-sync-controls element All sync data type toggles are moved into one polymer element. Note: There is no structural change in this CL. In a follow-up CL the toggles are moved to a subpage which is accessible from the sync page. Bug: 912598 Change-Id: I7d07a7051d34840d94a1229c7dae92fa2c1e680c Reviewed-on: https://chromium-review.googlesource.com/c/1367648 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615490} .../settings/people_page/sync_controls.html | 174 +++++++++++++++++++++ .../settings/people_page/sync_controls.js | 149 ++++++++++++++++++ .../resources/settings/people_page/sync_page.html | 165 +------------------ .../resources/settings/people_page/sync_page.js | 104 ------------ .../resources/settings/settings_resources.grd | 11 +- .../data/webui/settings/cr_settings_browsertest.js | 27 ++++ .../webui/settings/people_page_sync_controls.js | 109 +++++++++++++ .../webui/settings/people_page_sync_page_test.js | 61 +------- 8 files changed, 474 insertions(+), 326 deletions(-) commit 68c6c04a910b0fe59fc542ac75eb4f5e69baa2ab Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 11:08:22 2018 +0000 Roll src/third_party/perfetto 53a0082b847f..bfb8c97cb567 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/53a0082b847f..bfb8c97cb567 git log 53a0082b847f..bfb8c97cb567 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 primiano@google.com Merge "Fix build using system clang." Created with: gclient setdep -r src/third_party/perfetto@bfb8c97cb567 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Idece3bb67663352d473355928df1eb1f50745ac5 Reviewed-on: https://chromium-review.googlesource.com/c/1371040 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615489} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eb972d37a211f4f9f384db726d509396aaab86b8 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 10:54:38 2018 +0000 Update V8 to version 7.3.84. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5ca85e30..ff281cc4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I934f41f3d3db43dcf98058ca1e971b20a2a20505 Reviewed-on: https://chromium-review.googlesource.com/c/1370900 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615488} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 818e594f6e09dc5b60011278ee36a5e46ddb483c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 10:53:58 2018 +0000 Roll src/third_party/dawn a49242766a10..d86edb310a70 (1 commits) https://dawn.googlesource.com/dawn.git/+log/a49242766a10..d86edb310a70 git log a49242766a10..d86edb310a70 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 brandon1.jones@intel.com Implement BufferCopyView.imageHeight Parameter Created with: gclient setdep -r src/third_party/dawn@d86edb310a70 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ib46668179950f949baeb3af01a530df6669f9139 Reviewed-on: https://chromium-review.googlesource.com/c/1371042 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615487} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 700d1805883ddddc32ad6c6057f5b3e11c4a350d Author: Roberto Carrillo <robertocn@google.com> Date: Tue Dec 11 10:52:58 2018 +0000 [code coverage] Add fuzzer target. This change adds a single fuzzer target to the continuous code coverage bot and the matching trybot. R=stgao,liaoyuke,jbudorick,mmoroz Change-Id: Iab4af3dbfcfbce608b42a3089913f30d6753382d Reviewed-on: https://chromium-review.googlesource.com/c/1364690 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615486} testing/buildbot/chromium.fyi.json | 8 ++++++ testing/buildbot/gn_isolate_map.pyl | 13 ++++++++++ testing/buildbot/test_suites.pyl | 10 +++++++- testing/buildbot/tryserver.chromium.linux.json | 8 ++++++ testing/libfuzzer/BUILD.gn | 10 ++++++++ tools/code_coverage/run_fuzz_target.py | 35 ++++++++++++++++++++++++++ tools/mb/mb_config.pyl | 4 +-- 7 files changed, 85 insertions(+), 3 deletions(-) commit 2e1e507d5b922a215e32bf7981e72fe3883997be Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 10:52:00 2018 +0000 Revert "RemoteMacViews: Fix hang at command-Q" This reverts commit 464fae69315d22b6bce86525bb73305bd0cc7296. Reason for revert: Causes heavy flakiness (14/17 on Mac 10.11) and attempted fix showed no effect: https://crrev.com/c/1369136 TBR=ccameron@chromium.org Bug: 902583 Original change's description: > RemoteMacViews: Fix hang at command-Q > > When we call -[NSApp terminate] in the app shim process, this does > not immediately terminate. Rather, it > 0. Sends the message appShimController_->host()->QuitApp() and waits > for a reply before actually terminating. > 1. In the browser, this call hits ExtensionAppShimHandler:: > CloseBrowsersForApp > 2. Which will end up calling NativeWidgetMac::Close > 3. Which will then politely request that the app shim process close > the corresponding window via > views_bridge_mac::mojom::BridgedNativeWidget::CloseWindow > 4. Which will send an ack back to the browser via > views_bridge_mac::mojom::BridgedNativeWidgetHost::OnWindowHasClosed > 5. Whereupon the browser window will be registered as closed, and a > close message will be sent to the app shim, and the wait for > termination will break > > This ends up not working at step 3. Our suspended terminate ends up > running a nested message loop inside a mojo message handler, and so > it will never execute the CloseWindow message, and therefore never > close. > > Change the logic at [0] to send the QuitApp message, and then > immediately terminate the application. > > Bug: 902583 > Change-Id: I60fd7b5fdf9f145369d06219e8ebef36cdcd0f44 > Reviewed-on: https://chromium-review.googlesource.com/c/1364220 > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614922} TBR=ccameron@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 902583 Change-Id: I34a3300dc188cdd0de58692042ce131a8639117f Reviewed-on: https://chromium-review.googlesource.com/c/1371475 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615485} chrome/app_shim/app_shim_controller.mm | 2 +- chrome/app_shim/app_shim_delegate.h | 6 ++++++ chrome/app_shim/app_shim_delegate.mm | 22 +++++++++++++++++----- ui/views_bridge_mac/bridged_native_widget_impl.mm | 7 ++++++- 4 files changed, 30 insertions(+), 7 deletions(-) commit 447dc435c51c829be3b61997f8d8fb2e29a1fb5a Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 10:47:31 2018 +0000 Import wpt@1a75f34650cc64f7185bc74c0a7c58e92a51a507 Using wpt-import in Chromium 154ccf484000311e976dbdc6de04391da69da219. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I33fe622c06b23e31831704dae9817fb2a54120ce Reviewed-on: https://chromium-review.googlesource.com/c/1370899 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615484} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 24 +- .../the-navigator-object/protocol.https.html | 258 +++++++++------------ 2 files changed, 117 insertions(+), 165 deletions(-) commit 624045587baefaab9fc7a601cacfc8488071381a Author: Eric Seckler <eseckler@chromium.org> Date: Tue Dec 11 10:42:47 2018 +0000 tracing: Port ARC tracing agent to perfetto Adds a new DataSource for the ARC++ system tracing agent. Each ArcTracingBridge registers with the data source and keeps track of its state, so that the data source can coordinate tracing between all the bridges. TBR=oysteine@google.com Test: Manually capture a trace with and without perfetto backend. Bug: 900603 Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3 Reviewed-on: https://chromium-review.googlesource.com/c/1360736 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#615483} chrome/browser/chromeos/arc/tracing/DEPS | 4 + .../chromeos/arc/tracing/arc_tracing_bridge.cc | 372 ++++++++++++++++++--- .../chromeos/arc/tracing/arc_tracing_bridge.h | 82 +++-- services/tracing/BUILD.gn | 9 + services/tracing/perfetto/json_trace_exporter.cc | 12 + .../tracing/public/mojom/perfetto_service.mojom | 1 + 6 files changed, 399 insertions(+), 81 deletions(-) commit 3a584d80cd29c2798ba9d4ecdda5031163230e6b Author: Elad Alon <eladalon@chromium.org> Date: Tue Dec 11 10:39:55 2018 +0000 Change default output period of startEventLogging() to 5000ms Bug: 775415 Change-Id: I44d028c36558df47c0dd33cc853d4e50938c49bc Reviewed-on: https://chromium-review.googlesource.com/c/1370945 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#615482} .../webrtc_logging_private_apitest.cc | 14 -------------- .../media/webrtc/webrtc_event_log_manager_common.cc | 2 -- .../browser/media/webrtc/webrtc_event_log_manager_common.h | 1 - .../media/webrtc/webrtc_event_log_manager_remote.cc | 11 +++++------ .../media/webrtc/webrtc_event_log_manager_unittest.cc | 13 ------------- chrome/browser/resources/hangout_services/manifest.json | 2 +- chrome/browser/resources/hangout_services/thunk.js | 2 +- 7 files changed, 7 insertions(+), 38 deletions(-) commit eb8419e06d91d874f4ebc292257323582b108dcd Author: Edward Jung <edwardjung@chromium.org> Date: Tue Dec 11 10:31:42 2018 +0000 Remove the hover pointer when flag descriptions are not hidden Bug: 900536 Change-Id: Ia48b90e99c52cdb3ab35b952f8647007698048d8 Reviewed-on: https://chromium-review.googlesource.com/c/1370366 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#615481} components/flags_ui/resources/flags.css | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 0d557dedf31c8cf30bee794ea983b5a16f899b0e Author: Yuki Shiino <yukishiino@chromium.org> Date: Tue Dec 11 10:27:02 2018 +0000 v8binding: Do not hold a cross origin ScriptState in IDL callback interface Make IDL callback interface not hold a ScriptState of its creation context when it's cross origin from the incumbent realm. This is the same fix as https://crrev.com/c/1314023 for IDL callback interface. Bug: 886588, 883643 Change-Id: I38887c8d460d2b6879818bb31427f04a15dcf815 Reviewed-on: https://chromium-review.googlesource.com/c/1343816 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#615480} .../renderer/bindings/core/v8/js_event_listener.h | 3 +- .../bindings/templates/callback_interface.cc.tmpl | 13 ------ .../bindings/templates/callback_interface.h.tmpl | 14 ++---- .../renderer/bindings/templates/methods.cc.tmpl | 7 +-- .../results/core/v8_test_callback_interface.cc | 13 ------ .../results/core/v8_test_callback_interface.h | 16 +++---- .../core/v8_test_legacy_callback_interface.cc | 13 ------ .../core/v8_test_legacy_callback_interface.h | 16 +++---- .../bindings/tests/results/core/v8_test_object.cc | 52 +++------------------ .../tests/results/core/v8_test_typedefs.cc | 8 +--- .../platform/bindings/callback_interface_base.cc | 53 ++++++++++++++++------ .../platform/bindings/callback_interface_base.h | 6 +-- 12 files changed, 70 insertions(+), 144 deletions(-) commit f2128a1506a602ec711696169ade34aa9f771997 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Dec 11 10:25:14 2018 +0000 WPT: CSS: Add same-origin tests for loading error stylesheets. This adds a test that a stylesheet that failed to load is considered cross-origin. That is, accessing |styleSheet.rules| throws a SecurityError. This aligns with the specifications: - cssRules checks the `origin-clean` flag: https://drafts.csswg.org/cssom/#dom-cssstylesheet-cssrules - This is set to true iff CORS-same-origin: https://html.spec.whatwg.org/multipage/links.html#link-type-stylesheet - CORS-same-origin is false for "error" responses: https://html.spec.whatwg.org/multipage/urls-and-fetching.html#cors-same-origin Bug: 911974 Change-Id: I558e6d3dfa564b15284c393ffc35b80f54a9bc4e Reviewed-on: https://chromium-review.googlesource.com/c/1371307 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#615479} .../external/wpt/css/cssom/stylesheet-same-origin.sub-expected.txt | 3 +++ .../external/wpt/css/cssom/stylesheet-same-origin.sub.html | 6 ++++++ .../external/wpt/css/cssom/support/malformed-http-response.asis | 1 + 3 files changed, 10 insertions(+) commit ad82ea677e33c49e7b4690bb1653c5e2f5b9c099 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 10:21:51 2018 +0000 Roll src-internal b04ad33a6ff2..fabd12d5c959 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b04ad33a6ff2..fabd12d5c959 Created with: gclient setdep -r src-internal@fabd12d5c959 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie3b83e657bf7f7fce7655cd2a4450b7a80e754cb Reviewed-on: https://chromium-review.googlesource.com/c/1371041 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615478} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b9a13914eb0c744543f5ec1c9b3b6f8c410ccfd9 Author: Yi Su <mrsuyi@chromium.org> Date: Tue Dec 11 10:18:38 2018 +0000 Fix logic defect of while-loop in find_in_page.js This CL fixes a logic defect of a while-loop in the "isElementVisible_" function of find_in_page.js. This defect may cause a Js exception of trying to get "ownerDocument" property on "null". Bug: 912717 Change-Id: I32b39315983004b28fd6a2000b9ff7317225f8bf Reviewed-on: https://chromium-review.googlesource.com/c/1370173 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615477} ios/chrome/browser/find_in_page/resources/find_in_page.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 5e71410fff94dfa8565487ee318dcab37f65a0dc Author: Yi Su <mrsuyi@chromium.org> Date: Tue Dec 11 10:18:11 2018 +0000 Remove unnecessary comments in find_in_page.js. This CL removes the remaining comments about scrolling in find_in_page.js. Bug: 911780 Change-Id: Ie2ce2c4c45e2f829dba2338446943da63da13946 Reviewed-on: https://chromium-review.googlesource.com/c/1365896 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615476} ios/chrome/browser/find_in_page/resources/find_in_page.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 02d7d52f7396cb7a5e17c83e1da77fb4877047f7 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Dec 11 10:14:41 2018 +0000 WPT: CSS: Add cross-origin redirect tests. This adds tests that stylesheets that result from requests that were redirected cross-origin are considered cross-origin. Note that A->B->A redirects, which redirect from cross-origin to same-origin, are considered cross-origin. See https://github.com/whatwg/fetch/issues/737 and https://github.com/whatwg/fetch/pull/834. In Blink, we have redirect tests at http/tests/security/cannot-read-cssrules-redirect.html. This WPT addition will supersede that test, but I won't yet remove it since it asserts the opposite for the A->B->A case. I can remove the test when Blink changes to pass this WPT test. Bug: 911974 Change-Id: Ie015c0390829299de7c29cff6685ddfcd774c66f Reviewed-on: https://chromium-review.googlesource.com/c/1370162 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615475} .../cssom/stylesheet-same-origin.sub-expected.txt | 10 +++++ .../wpt/css/cssom/stylesheet-same-origin.sub.html | 50 +++++++++++++++------- 2 files changed, 45 insertions(+), 15 deletions(-) commit 811eb98e0165e41687f00f5a155d7080422b1b2e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 10:00:32 2018 +0000 Roll src/third_party/skia 264843e30745..9cabb4f98e99 (1 commits) https://skia.googlesource.com/skia.git/+log/264843e30745..9cabb4f98e99 git log 264843e30745..9cabb4f98e99 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@9cabb4f98e99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I2de3c5dc1c1a5b17947f8be476eac57818ee2d24 Reviewed-on: https://chromium-review.googlesource.com/c/1371256 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615474} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c35a4307ef33675024311b29c16448f81fda7474 Author: Koji Ishii <kojii@chromium.org> Date: Tue Dec 11 09:50:49 2018 +0000 [LayoutNG] Remove unneeded comments in a test This patch removes a comment in a test that is not needed. It was a left over in r615053 (CL:1366472). Bug: 904291 Change-Id: I785080fd401426261d6259c22f5f20059fdcba1f Reviewed-on: https://chromium-review.googlesource.com/c/1370148 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#615473} .../blink/web_tests/fast/text/absolute-in-inline-block-change-crash.html | 1 - 1 file changed, 1 deletion(-) commit 87406132518479f505ae1d110894641f057f8d63 Author: Boris Sazonov <bsazonov@chromium.org> Date: Tue Dec 11 09:49:11 2018 +0000 [Signin][Android] Wipe account list in OAuth2TokenService test This CL addsSigninTestUtil.resetSigninState call to OAuth2TokenServiceIntegrationTest.tearDown, so all signin-related prefs are wiped and the state doesn't leak from the test. Bug: 908542 Change-Id: I43b37d76bd24e14687a4e9d0ab35d2e88d283f6f Reviewed-on: https://chromium-review.googlesource.com/c/1369940 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615472} .../chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java | 2 ++ 1 file changed, 2 insertions(+) commit 13b272dac5fa0ec98704e43265344fde7fcc2934 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Dec 11 09:38:09 2018 +0000 [iOS] Fix switch compression resistance priority This CL increases the switch compression resistance priority to make sure that it doesn't get too compressed by the label. Bug: 912698 Change-Id: Ib8926b6fbcc60394506a9b348e9f79e4a11fae5d Reviewed-on: https://chromium-review.googlesource.com/c/1370274 Reviewed-by: Yi Su <mrsuyi@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615471} ios/chrome/browser/ui/settings/cells/settings_switch_item.mm | 4 ++++ 1 file changed, 4 insertions(+) commit 49dd35bd0b884b3bdfd0f86867bb4a6114f77af3 Author: Tsuyoshi Horo <horo@chromium.org> Date: Tue Dec 11 09:30:06 2018 +0000 Ignores the default favicon request in ChromeServiceWorkerFetchTest Currently if the default favicon request is caught by the testing service worker the test fails. This is causing the test flakiness. To fix this flakiness, this CL change the fetch event handler of the service worker to ignore the default favicon request. Bug: 912543 Change-Id: Icdddd902a4547361320f43db5b9090270ba74509 Reviewed-on: https://chromium-review.googlesource.com/c/1370160 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615470} chrome/browser/chrome_service_worker_browsertest.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit f00a8440a5cba688aeb1250898f5e53aef43836c Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 09:17:17 2018 +0000 Roll src-internal 8a7be9d55a9c..b04ad33a6ff2 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a7be9d55a9c..b04ad33a6ff2 Created with: gclient setdep -r src-internal@b04ad33a6ff2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I07ce2495c2f1f849b57cbc435a5a865bbd1522f6 Reviewed-on: https://chromium-review.googlesource.com/c/1371255 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615469} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3e255aed3c9924035b27ed04226f1dbd22d6884e Author: Leszek Swirski <leszeks@chromium.org> Date: Tue Dec 11 09:08:56 2018 +0000 [blink] Remove IsFinished check for TextForInspector There are some edge cases where IsLoaded is true but IsFinishedInternal is not (yet) true, so remove that check and expand the comment. Bug: 865098 Bug: 899217 Bug: 909858 Change-Id: I886df54c9a373e7431938aadd4a6a1a4d256d7dc Reviewed-on: https://chromium-review.googlesource.com/c/1369789 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#615468} .../blink/renderer/core/loader/resource/script_resource.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit 154ccf484000311e976dbdc6de04391da69da219 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 08:57:38 2018 +0000 Roll AFDO from 73.0.3636.0_rc-r1 to 73.0.3637.0_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I74bc59cee5321321971257c15ddf89fe9773c1a9 Reviewed-on: https://chromium-review.googlesource.com/c/1371039 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615467} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 33be12e56e110a54e73caf77a553b655d36f338c Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Dec 11 08:54:34 2018 +0000 [iOS] Add scroll view to TabGrid's empty view This CL changes the view displayed when the TabGrid is empty to add a scroll view. The scroll view allows the user to display the whole text even with large fonts. Bug: 896302 Change-Id: I94696f969aa1f7ae05be626bde2c10248f00b6df Reviewed-on: https://chromium-review.googlesource.com/c/1363281 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615466} ios/chrome/browser/ui/tab_grid/grid/BUILD.gn | 1 + .../browser/ui/tab_grid/grid/grid_empty_view.h | 16 +++++ .../ui/tab_grid/grid/grid_view_controller.h | 3 +- .../ui/tab_grid/grid/grid_view_controller.mm | 21 ++++-- .../ui/tab_grid/tab_grid_empty_state_view.h | 5 +- .../ui/tab_grid/tab_grid_empty_state_view.mm | 82 ++++++++++++++++++---- 6 files changed, 108 insertions(+), 20 deletions(-) commit 043c95f211872d0739ed6d94e8c54ca2e29757cc Author: Friedrich Horschig [CET] <fhorschig@chromium.org> Date: Tue Dec 11 08:49:32 2018 +0000 Revert "Move toolbar to new FlexLayout, demonstrating new layout manager." This reverts commit d080cfa6b2816045a60cc2d16d2bf67ff1c15d8a. Reason for revert: Suspected culprit for ExtensionApiTabTest.UpdateWindowResize failure on network_service_browser_tests (failing on chromium.mac/Mac10.12 Tests). Bug: 913848 Original change's description: > Move toolbar to new FlexLayout, demonstrating new layout manager. > > Vastly simplifies layout in the toolbar and makes it mostly declarative with a > single init function, rather than complex, bespoke - and sometimes incorrect - > Layout(), GetMinimumSize(), etc. methods. > > Because of a logical change in the way the UI works when an extension is > uninstalled, we uncovered a possible read-after-free in the extension install > UI (shows up in some ASAN tests). So we plumbed the scoped_refptr through from > crx_installer to the UI so that the memory would be valid until the bubble is > closed. > > See parent CL for FlexLayout details and future work. > > Bug: 898632 > Change-Id: I2cfe5b6119dc2886f88ae12675f8184cf90d56fd > Reviewed-on: https://chromium-review.googlesource.com/c/1331041 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615372} TBR=rdevlin.cronin@chromium.org,bsep@chromium.org,dfried@chromium.org Change-Id: Ie93f170c2c6048072820f2d6dc9950f75bc4aa94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 898632 Reviewed-on: https://chromium-review.googlesource.com/c/1371384 Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615465} chrome/browser/extensions/crx_installer.cc | 2 +- .../extensions/crx_installer_browsertest.cc | 3 +- .../browser/extensions/extension_install_prompt.cc | 17 +- .../browser/extensions/extension_install_prompt.h | 7 +- .../ui/extensions/extension_install_ui_default.cc | 14 +- .../ui/extensions/extension_install_ui_default.h | 2 +- .../ui/extensions/extension_installed_bubble.cc | 22 +- .../ui/extensions/extension_installed_bubble.h | 13 +- chrome/browser/ui/toolbar/toolbar_actions_bar.cc | 7 +- .../ui/views/location_bar/location_bar_view.cc | 3 +- .../tabs/tab_drag_controller_interactive_uitest.cc | 13 +- .../ui/views/toolbar/browser_actions_container.cc | 45 +--- .../ui/views/toolbar/browser_actions_container.h | 16 +- .../ui/views/toolbar/browser_app_menu_button.cc | 19 +- .../ui/views/toolbar/browser_app_menu_button.h | 5 +- chrome/browser/ui/views/toolbar/toolbar_button.cc | 19 +- chrome/browser/ui/views/toolbar/toolbar_button.h | 8 +- chrome/browser/ui/views/toolbar/toolbar_view.cc | 263 ++++++++++++++------- chrome/browser/ui/views/toolbar/toolbar_view.h | 23 +- .../api_test/window_update/sizing/test.js | 2 +- extensions/browser/install/extension_install_ui.h | 6 +- 21 files changed, 272 insertions(+), 237 deletions(-) commit 7df0a8a06e77c737a586226e91b43a0697f81c4c Author: David Jean <djean@google.com> Date: Tue Dec 11 08:25:25 2018 +0000 [ios] Add flag for iOS password generation Bug: 886583 Change-Id: I107a11cdcd9d299533789cffed8c3446561f4968 Reviewed-on: https://chromium-review.googlesource.com/c/1365432 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#615464} ios/chrome/browser/BUILD.gn | 1 + ios/chrome/browser/experimental_flags.h | 3 +++ ios/chrome/browser/experimental_flags.mm | 5 +++++ ios/chrome/browser/passwords/BUILD.gn | 14 ++++++++++++-- .../browser/passwords/credential_manager_egtest.mm | 2 +- .../browser/passwords/credential_manager_features.h | 17 ----------------- ios/chrome/browser/passwords/password_controller.mm | 2 +- ...ager_features.cc => password_manager_features.cc} | 7 +++++-- .../browser/passwords/password_manager_features.h | 20 ++++++++++++++++++++ ios/chrome/browser/web/chrome_web_client.mm | 2 +- ios/chrome/browser/web/chrome_web_client_unittest.mm | 2 +- 11 files changed, 50 insertions(+), 25 deletions(-) commit a273f200fdc050016fc34f8dc000d088ae08c1be Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Dec 11 08:21:49 2018 +0000 remove hash_multimap and hash_multiset Bug: 576864 Change-Id: I3290cb0876f3ca84ec0efb13922b2756138b9492 Reviewed-on: https://chromium-review.googlesource.com/c/1369763 Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615463} base/containers/hash_tables.h | 15 --------------- .../browser/supervised_user/supervised_user_url_filter.cc | 9 +++++---- 2 files changed, 5 insertions(+), 19 deletions(-) commit e065b573f789b01eb5b8883e72664ccaa89130b2 Author: Lei Zhang <thestig@chromium.org> Date: Tue Dec 11 08:00:41 2018 +0000 Make Mac custom paper sizes available in Print Preview. Read and parse the plist, and tell Print Preview about the custom paper sizes. BUG=477699 Change-Id: Ia22e2d95e627d1796b1346ab6e3baeef89a9f2ae Reviewed-on: https://chromium-review.googlesource.com/c/1364228 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615462} chrome/browser/about_flags.cc | 7 + chrome/browser/flag-metadata.json | 5 + chrome/browser/flag_descriptions.cc | 4 + chrome/browser/flag_descriptions.h | 3 + .../print_preview/local_printer_handler_default.cc | 23 ++- components/printing/browser/features.cc | 5 + components/printing/browser/features.h | 5 + components/printing/common/BUILD.gn | 11 ++ .../printing/common/printer_capabilities_mac.h | 28 +++ .../printing/common/printer_capabilities_mac.mm | 78 ++++++++ .../common/printer_capabilities_mac_unittest.mm | 197 +++++++++++++++++++++ tools/metrics/histograms/enums.xml | 2 + 12 files changed, 361 insertions(+), 7 deletions(-) commit 05142837eebe9a1c5cde711f09d21fdbb195ca4d Author: Marc Treib <treib@chromium.org> Date: Tue Dec 11 08:00:16 2018 +0000 Add autofill_profile integration test for UMA Sync.ModelTypeEntityChange3 The new test is similar to the existing PersonalDataManagerSanity test, but adds checks for the Sync.ModelTypeEntityChange3.AUTOFILL_PROFILE histogram. Compared to PersonalDataManagerSanity, the new test skips the step of adding a duplicate profile, since that seems to produce flaky results. Bug: 904390 Change-Id: Ic85050dcab80e53ea1a5e1fa63f61db5e6c2cb09 Reviewed-on: https://chromium-review.googlesource.com/c/1369778 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#615461} .../integration/two_client_autofill_sync_test.cc | 147 ++++++++++++++++++++- 1 file changed, 146 insertions(+), 1 deletion(-) commit 7a5586e5a9570ed44f88a68a5d24fd16d3fa4f96 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 07:59:36 2018 +0000 Roll src/third_party/skia ae0d860ba31b..264843e30745 (1 commits) https://skia.googlesource.com/skia.git/+log/ae0d860ba31b..264843e30745 git log ae0d860ba31b..264843e30745 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@264843e30745 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ie41dd4f4977bf51bd0d31225f555d62f0a6dafde Reviewed-on: https://chromium-review.googlesource.com/c/1371252 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615460} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 393179e13cbd04c0f833b92a4290990f5d98a05f Author: Rob Buis <rbuis@igalia.com> Date: Tue Dec 11 07:55:47 2018 +0000 Fix generate-test-certs.sh script Openssl does not take --subj parameter, but -subj. Bug: 803774 Change-Id: Ie5e1da18941468fc66ea567134a49178b4260aba Reviewed-on: https://chromium-review.googlesource.com/c/1370177 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#615459} .../external/wpt/signed-exchange/resources/generate-test-certs.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9d37e79b44ca024f8584ceb65323333291af9d2d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 07:53:01 2018 +0000 Roll src-internal d31d9e9af460..8a7be9d55a9c (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d31d9e9af460..8a7be9d55a9c Created with: gclient setdep -r src-internal@8a7be9d55a9c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iac716d778c5208ad7431b0daa4cdb1cde8f832fb Reviewed-on: https://chromium-review.googlesource.com/c/1371251 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615458} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8f676a7626ff06c8fff6572f912f6674f9ba1598 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Dec 11 07:51:23 2018 +0000 Worker: Move SharedWorkerConnectListener into its own file for cleanup Bug: 911415 Change-Id: I8f4a0e452bb508fa5ccb2c9f9701e1b9834b8b81 Reviewed-on: https://chromium-review.googlesource.com/c/1370163 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615457} third_party/blink/renderer/DEPS | 1 + third_party/blink/renderer/core/workers/BUILD.gn | 2 + .../core/workers/shared_worker_connect_listener.cc | 53 +++++++++++++++++ .../core/workers/shared_worker_connect_listener.h | 34 +++++++++++ .../workers/shared_worker_repository_client.cc | 66 ++-------------------- 5 files changed, 96 insertions(+), 60 deletions(-) commit 6e0ac280be977e9ba147f7b84d50c406e5ab8e5f Author: François Beaufort <beaufort.francois@gmail.com> Date: Tue Dec 11 07:47:00 2018 +0000 Remove apacible from Picture-in-Picture OWNERS Following Chris Palmer's email[1], this CL removes apacible from Picture-in-Picture related OWNERS as she is not actively working on Chromium. [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZgEddsRE6do/UPcD-sptBgAJ Change-Id: I77f12a916c359c92dc329a5b59076983ecd86269 Reviewed-on: https://chromium-review.googlesource.com/c/1361729 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#615456} chrome/browser/picture_in_picture/OWNERS | 3 +-- chrome/browser/ui/views/overlay/OWNERS | 5 ++--- content/browser/picture_in_picture/OWNERS | 3 +-- tools/metrics/actions/actions.xml | 4 ++-- 4 files changed, 6 insertions(+), 9 deletions(-) commit b07599ca0f2ba045a41c06e4b66d12a573817cb2 Author: Cathy Li <chili@chromium.org> Date: Tue Dec 11 07:46:40 2018 +0000 [Explore sites]: Ensure that we have full rows of sites for each category at the start. We limit the maximum number of rows shown by how many sites each category had to begin with (before any blacklisting occurs). Bug: 911362 Change-Id: I35ac39870422248ae830050bb6ccf4f405960f4d Reviewed-on: https://chromium-review.googlesource.com/c/1359694 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615455} .../explore_sites/ExploreSitesCategory.java | 28 +++++++++-- .../ExploreSitesCategoryCardView.java | 48 ++++++++++++------- .../browser/explore_sites/ExploreSitesPage.java | 9 +++- .../browser/explore_sites/ExploreSitesSection.java | 2 + .../browser/explore_sites/ExploreSitesSite.java | 19 +++++--- .../explore_sites/ExploreSitesPageTest.java | 2 +- .../ExploreSitesCategoryUnitTest.java | 13 +++-- .../android/explore_sites/explore_sites_bridge.cc | 3 +- .../explore_sites_service_impl_unittest.cc | 4 +- .../android/explore_sites/explore_sites_types.cc | 9 +++- .../android/explore_sites/explore_sites_types.h | 7 ++- .../android/explore_sites/get_catalog_task.cc | 16 ++++--- .../explore_sites/get_catalog_task_unittest.cc | 56 ++++++++++++++-------- 13 files changed, 151 insertions(+), 65 deletions(-) commit a3a875162fadbd939162dd1bf0e1753a212815e5 Author: Reka Norman <rekanorman@google.com> Date: Tue Dec 11 07:45:29 2018 +0000 [App Management] Fix FakePageHandler This CL updates the FakePageHandler to use generated Mojo types. Bug: 906508 Change-Id: Ib04a9118e7ad7de6ac1aa9dfdf2d232c3280034a Reviewed-on: https://chromium-review.googlesource.com/c/1370232 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615454} .../resources/app_management/fake_page_handler.js | 38 ++++++++++++++++------ .../resources/app_management/main_view.html | 4 +-- 2 files changed, 30 insertions(+), 12 deletions(-) commit 5acf485f076325a00a61bd1120da193588ca8d71 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 07:33:09 2018 +0000 Roll src/third_party/chromite 768c73895b2f..bdff670a66b9 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/768c73895b2f..bdff670a66b9 git log 768c73895b2f..bdff670a66b9 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 athilenius@google.com Added a find_project_path script, updated repo_manifest lib Created with: gclient setdep -r src/third_party/chromite@bdff670a66b9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0d317d3eb531673796b8aa47ed41a98b4c2e69ca Reviewed-on: https://chromium-review.googlesource.com/c/1371250 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615453} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5cefea18d48d775ab0e55e601b82aa473d27cb90 Author: Simon Que <sque@google.com> Date: Tue Dec 11 07:02:20 2018 +0000 tools/mb: Add Linux Goma RBE Prod builder to config BUG=913249 Change-Id: Icacda434b78bc09b85290734f888f914dc91d3ac Reviewed-on: https://chromium-review.googlesource.com/c/1369547 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#615452} tools/mb/mb_config.pyl | 1 + 1 file changed, 1 insertion(+) commit 8d678f89ac9bbc6f02c01842473ada033d8babdc Author: Eric Karl <ericrk@chromium.org> Date: Tue Dec 11 06:51:00 2018 +0000 Add SII method to upload data at creation and use for LTHI Adds a method to SharedImage interface (SII) which allows us to create a shared image and upload initial data in a single command. This method is then used in LTHI to convert the UI Resource uploader code to SII. As SII can't rely on the command buffer, it uses the following pattern for uploads: - Allocate a 1MB (or required size) block of shared memory. - Sub allocate from it for each upload, duplicating the SHM and transferring ownership to the GPU service for each upload. - When the current shared memory buffer is used up, drop it on the client side. It will be kept alive by the duplicated handles passed to the service, until these are no longer needed. - Repeat. This may be a bit inefficient, so we may need a more complex allocation scheme in the future. Bug: 906794 Change-Id: Ie91ab352b06097da6e00f80582b0cc92d690a6f9 Reviewed-on: https://chromium-review.googlesource.com/c/1343346 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615451} cc/trees/layer_tree_host_impl.cc | 88 +++++--- cc/trees/layer_tree_host_impl.h | 2 +- cc/trees/layer_tree_host_impl_unittest.cc | 40 ++-- cc/trees/layer_tree_host_unittest.cc | 16 +- cc/trees/layer_tree_host_unittest_context.cc | 17 +- components/viz/test/test_context_provider.cc | 11 + components/viz/test/test_context_provider.h | 6 + gpu/command_buffer/client/shared_image_interface.h | 11 + .../service/shared_image_backing_factory.h | 7 + ...shared_image_backing_factory_ahardwarebuffer.cc | 12 ++ .../shared_image_backing_factory_ahardwarebuffer.h | 7 + .../shared_image_backing_factory_gl_texture.cc | 233 ++++++++++++++++++--- .../shared_image_backing_factory_gl_texture.h | 12 ++ ...ed_image_backing_factory_gl_texture_unittest.cc | 119 +++++++++++ gpu/command_buffer/service/shared_image_factory.cc | 13 ++ gpu/command_buffer/service/shared_image_factory.h | 6 + gpu/command_buffer/service/wrapped_sk_image.cc | 11 + gpu/command_buffer/service/wrapped_sk_image.h | 7 + gpu/ipc/client/shared_image_interface_proxy.cc | 141 +++++++++++++ gpu/ipc/client/shared_image_interface_proxy.h | 16 ++ gpu/ipc/common/gpu_messages.h | 16 ++ gpu/ipc/in_process_command_buffer.cc | 46 ++++ gpu/ipc/in_process_command_buffer.h | 7 + gpu/ipc/service/shared_image_stub.cc | 68 ++++++ gpu/ipc/service/shared_image_stub.h | 6 + 25 files changed, 824 insertions(+), 94 deletions(-) commit 8febfeb0c584adda674a8bc382787f3a53e874f0 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Dec 11 06:49:10 2018 +0000 Use OnceClosure in SharedMemoryDataConsumerHandle Bug: 911036 Change-Id: I1096638e46760674d9c9a85522f775f767f0faa1 Reviewed-on: https://chromium-review.googlesource.com/c/1370234 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#615450} .../loader/shared_memory_data_consumer_handle.cc | 16 +++++++++------- .../renderer/loader/shared_memory_data_consumer_handle.h | 2 +- .../shared_memory_data_consumer_handle_unittest.cc | 8 ++++---- content/renderer/loader/web_url_loader_impl.cc | 2 +- 4 files changed, 15 insertions(+), 13 deletions(-) commit 1270bcb7a2f436fa681e2950d5204ece28098a11 Author: Sidney San Martín <sdy@chromium.org> Date: Tue Dec 11 06:45:59 2018 +0000 Pass swipe gesture events over Mojo. Bug: 913688 Change-Id: Ibd0124bd99389142c4538fdb6c55ca2c634f6f42 Reviewed-on: https://chromium-review.googlesource.com/c/1371164 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615449} ui/events/mojo/event_constants.mojom | 3 ++- ui/events/mojo/event_struct_traits.cc | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) commit 38567472c0ae1f3673c1be502852a51f5be85d8c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 06:35:08 2018 +0000 Update V8 to version 7.3.83. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f88410f8..5ca85e30 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id130e26eed952d7d9ff0a64c0c19531612c22ce6 Reviewed-on: https://chromium-review.googlesource.com/c/1370859 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615448} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8138bc49f55ccfcc90e53edadba377f6c4c78ed7 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Dec 11 06:23:35 2018 +0000 ResourceLoadScheduler: Remove stale configuration for launched feature ResourceLoadScheduler was already launched, and enabled by default. fieldtrial_testing_config.json does not need to have a configuration for testing performance on the feature. Bug: 729954 Change-Id: Ie7d468ad320980c857e3612dbff3f18cc2b74bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1369550 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#615447} testing/variations/fieldtrial_testing_config.json | 23 ----------------------- 1 file changed, 23 deletions(-) commit a39a155b8fda09ea9ae5168f05266dbe8ed81d0a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 06:12:19 2018 +0000 Roll src-internal ea2cff61234c..d31d9e9af460 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea2cff61234c..d31d9e9af460 Created with: gclient setdep -r src-internal@d31d9e9af460 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I886418486b60a062c29400f1d0663311c55ddfed Reviewed-on: https://chromium-review.googlesource.com/c/1371249 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615446} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 32929f531a58a3cadf185d351d1a3382863fa062 Author: Ryan Tseng <hinoka@google.com> Date: Tue Dec 11 06:11:19 2018 +0000 Reland: Replace blink::ToIsolate(ExecutionContext) with blink::ExecutionContext->GetIsolate() And remove blink::ToIsolate(ExecutionContext) altogether. Originally https://chromium-review.googlesource.com/c/chromium/src/+/1355944 The difference is added checks in: * AsyncTaskCanceled * AllAsyncTasksCanceled for nullptr ExecutionContext. Bug: 889542, 911800 Change-Id: Icef90fadbc89019118119f044dde8f10ddffa72f Reviewed-on: https://chromium-review.googlesource.com/c/1366358 Commit-Queue: Ryan Tseng <hinoka@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615445} .../bindings/core/v8/script_event_listener.cc | 2 +- .../bindings/core/v8/script_promise_property_base.cc | 2 +- .../bindings/core/v8/script_promise_property_test.cc | 2 +- .../renderer/bindings/core/v8/v8_binding_for_core.cc | 16 ---------------- .../renderer/bindings/core/v8/v8_binding_for_core.h | 1 - .../core/frame/csp/content_security_policy.cc | 2 +- .../renderer/core/html/html_frame_element_base.cc | 2 +- .../blink/renderer/core/messaging/message_port.cc | 2 +- third_party/blink/renderer/core/probe/core_probes.cc | 17 +++++++++++------ .../renderer/core/trustedtypes/trusted_types_util.cc | 9 +++++---- .../blink/renderer/core/workers/dedicated_worker.cc | 2 +- .../core/workers/dedicated_worker_messaging_proxy.cc | 4 ++-- .../blink/renderer/core/workers/experimental/task.cc | 8 ++++---- .../renderer/core/xmlhttprequest/xml_http_request.cc | 2 +- .../blink/renderer/modules/indexeddb/idb_key_range.cc | 19 +++++++++---------- .../payments/abort_payment_respond_with_observer.cc | 4 ++-- .../can_make_payment_respond_with_observer.cc | 4 ++-- .../payments/payment_request_respond_with_observer.cc | 2 +- .../service_worker/fetch_respond_with_observer.cc | 7 +++---- .../time_zone_monitor/time_zone_monitor_client.cc | 2 +- 20 files changed, 48 insertions(+), 61 deletions(-) commit 2e3b6f28f1319693ffa0a8d55c4c1eba8facc465 Author: Sara Kato <sarakato@chromium.org> Date: Tue Dec 11 06:09:49 2018 +0000 Add check for node role when calling boundsForRange. This boundsForRange should return null in Non-arc, non-text nodes. Otherwise, since bounds for these nodes exist (eg - on images), highlighting for these would occur unexpectedly on select-to-speak side. Test: Manual Bug: 908509 Change-Id: I344a050a9033d7d839cb242b1fc56196ec28bcce Reviewed-on: https://chromium-review.googlesource.com/c/1358105 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by: Yuki Awano <yawano@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615444} chrome/browser/extensions/api/automation/automation_apitest.cc | 3 ++- chrome/renderer/resources/extensions/automation/automation_node.js | 5 +++++ .../data/extensions/api_test/automation/sites/bounds_for_range.html | 2 +- .../extensions/api_test/automation/tests/tabs/bounds_for_range.js | 6 ++++-- 4 files changed, 12 insertions(+), 4 deletions(-) commit c2577c9003ff792deea933c6573f20242ecd8f1a Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 05:58:41 2018 +0000 Import wpt@912d5081b62d6e6a2f847935c82722e31cca7a1f Using wpt-import in Chromium 2bcd17a0a69b8272918718795f8ca12e23820d20. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts eroman@chromium.org, rsleevi@chromium.org: external/wpt/WebCryptoAPI foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure ksakamoto@chromium.org: external/wpt/resource-timing panicker@chromium.org: external/wpt/user-timing rmcilroy@chromium.org: external/wpt/requestidlecallback tdresser@chromium.org: external/wpt/hr-time external/wpt/navigation-timing yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a940f1891ee1fab3deac0ed104cc1c7a66bd1ca Reviewed-on: https://chromium-review.googlesource.com/c/1371217 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615443} third_party/blink/web_tests/TestExpectations | 3 + .../web_tests/external/WPT_BASE_MANIFEST_5.json | 326 ++++++++++++++++++--- .../external/wpt/WebCryptoAPI/sign_verify/ecdsa.js | 2 + .../external/wpt/WebCryptoAPI/sign_verify/hmac.js | 2 + .../external/wpt/WebCryptoAPI/sign_verify/rsa.js | 2 + .../wpt/common/performance-timeline-utils.js | 7 +- .../css-fonts/font-variant-alternates-parsing.html | 3 +- .../currentcolor-animation-001.html | 4 +- .../transitions-animatable-properties-01.html | 6 +- .../wpt/css/css-values/calc-unit-analysis.html | 18 +- .../css-variables/test_variable_legal_values.html | 6 +- .../css/cssom-view/offsetParent_element_test.html | 10 +- .../external/wpt/css/cssom/computed-style-001.html | 20 +- .../external/wpt/css/cssom/computed-style-005.html | 10 +- .../external/wpt/css/cssom/inline-style-001.html | 31 +- .../wpt/css/cssom/medialist-interfaces-001.html | 23 +- .../wpt/css/cssom/medialist-interfaces-002.html | 12 +- .../wpt/css/cssom/medialist-interfaces-003.html | 9 +- .../wpt/css/cssom/medialist-interfaces-004.html | 8 +- .../wpt/css/cssom/style-sheet-interfaces-001.html | 39 ++- .../wpt/css/cssom/style-sheet-interfaces-002.html | 12 +- .../wpt/css/mediaqueries/test_media_queries.html | 12 +- .../canvas-remote-read-remote-image-redirect.html | 27 ++ .../external/wpt/hr-time/monotonic-clock.any.js | 9 +- .../the-img-element/available-images-onload.html | 33 +++ .../button-click-submits-expected.txt | 14 + .../the-button-element/button-click-submits.html | 61 ++++ .../support/target_blank_iplicit_noopener.html | 6 + ..._blank_implicit_noopener.tentative-expected.txt | 13 + .../target_blank_implicit_noopener.tentative.html | 60 ++++ .../the-script-element/muted-errors.sub.html | 19 +- .../testdriver/actions/elementPosition.html.ini | 6 +- .../testdriver/actions/elementTiming.html.ini | 2 +- .../wpt/infrastructure/testdriver/file_upload.py | 2 + .../infrastructure/testdriver/file_upload.sub.html | 26 ++ .../infrastructure/testdriver/file_upload_data.txt | 1 + .../web_tests/external/wpt/interfaces/webxr.idl | 22 +- .../resources/webperftestharness.js | 7 +- .../test_navigation_redirectCount_none.html | 3 +- .../test_no_previous_document.html | 3 +- .../test_timing_attributes_order.html | 3 +- .../test_timing_client_redirect.html | 5 +- .../wpt/navigation-timing/test_timing_reload.html | 3 +- .../test_timing_xserver_redirect.html | 5 +- .../external/wpt/requestidlecallback/basic.html | 12 +- .../resources/webperftestharness.js | 15 +- .../user-timing/resources/webperftestharness.js | 7 +- ..._blank_implicit_noopener.tentative-expected.txt | 0 48 files changed, 718 insertions(+), 211 deletions(-) commit 1b5d37c474c39afc6eaa7a369b97eaa78106df24 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Dec 11 05:55:02 2018 +0000 [CompositeAfterPaint] Plumb ViewportProperties and Settings to PaintArtifactCompositor For now ViewportProperties contains the page scale node only, and Settings contains prefer_compositing_to_lcd_text only. In the future they will contain more properties/settings. Change-Id: I760b79191aa25a8fc489aa9c4d9ab1dc1e6204fc Reviewed-on: https://chromium-review.googlesource.com/c/1370278 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615442} .../blink/renderer/core/frame/local_frame_view.cc | 9 +++++++- .../compositing/paint_artifact_compositor.cc | 19 +++++++++-------- .../compositing/paint_artifact_compositor.h | 14 ++++++++++++- .../compositing/paint_artifact_compositor_test.cc | 24 +++++++++++----------- 4 files changed, 44 insertions(+), 22 deletions(-) commit cceefec615766cbe2fbaaad334347a680eeee53f Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Dec 11 05:51:52 2018 +0000 mojo: Add a externs_js_library target for js_libraries that type check Some interfaces depend on many other interfaces. Before this patch users would have to manually add externs for every interface used. This CL introduces a new target that js_libraries can use to include all the necessary externs to use an interface. Bug: 849993 Change-Id: I97acb7bbbd604e7ebeb1cb5fe814e4afecefe2d6 Reviewed-on: https://chromium-review.googlesource.com/c/1369485 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#615441} chrome/browser/resources/app_management/BUILD.gn | 21 ++------------------- chrome/browser/resources/md_downloads/BUILD.gn | 15 ++------------- mojo/public/tools/bindings/mojom.gni | 22 ++++++++++++++++++++++ 3 files changed, 26 insertions(+), 32 deletions(-) commit 304d00ba30545c8ccdcc6725648a2e406d57aa1f Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Dec 11 05:49:23 2018 +0000 service worker: Remove fetch-* http tests redundant with WPT tests. Remove the following tests: - fetch-canvas-tainting.html - fetch-cors-xhr.html - fetch-csp.html These are redundant with corresponding WPT tests. They previously could not be removed without losing test coverage because the WPT tests were being skipped due to time outs, see https://codereview.chromium.org/2805313003/. But those WPT tests are now passing. A small exception is the WPT fetch-canvas-tainting* tests flakily timeout, but they are still enabled and mostly passing so we won't lose test coverage. These tests were originally written at r179595 and upstreamed to WPT at https://github.com/web-platform-tests/wpt/commit/b2e3ab765e26436850208dbdcf747c3be75b1999. Bug: 688116, 373120 Change-Id: Ic2dc2ddc322aae89b1e06e5a16b1ed8c30265d00 Reviewed-on: https://chromium-review.googlesource.com/c/1370236 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615440} .../tests/serviceworker/fetch-canvas-tainting.html | 44 ---- .../http/tests/serviceworker/fetch-cors-xhr.html | 44 ---- .../tests/serviceworker/fetch-csp-expected.txt | 8 - .../http/tests/serviceworker/fetch-csp.html | 117 ---------- .../resources/fetch-canvas-tainting-iframe.html | 254 --------------------- .../resources/fetch-cors-xhr-iframe.html | 190 --------------- .../serviceworker/resources/fetch-csp-iframe.html | 16 -- 7 files changed, 673 deletions(-) commit 3c3a6bf89f098f528d1af34f94c85d6dec60a367 Author: John Z Wu <jzw@chromium.org> Date: Tue Dec 11 05:45:36 2018 +0000 Remove user consents from //ios/web_view. ios webview uses butter sync which does not need overall sync consent because it will never be enabled. Bug: 873790 Change-Id: Id6f6dfd6ebd424f2d3c385a85f425171d03ef1d9 Reviewed-on: https://chromium-review.googlesource.com/c/1371203 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#615439} ios/web_view/internal/sync/web_view_sync_client.mm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) commit 9979287ce644a1ae2bad70dd6e0671429406a0af Author: John Z Wu <jzw@chromium.org> Date: Tue Dec 11 05:42:56 2018 +0000 Enable new feature flag needed for butter sync. A new flag was added recently that prevented server cards from being offered as autofill suggestions. We simply enable to restore the intended behavior. Change-Id: I537ae79a6bf6acfef081f9002654e4d4fc202fe5 Reviewed-on: https://chromium-review.googlesource.com/c/1371202 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#615438} ios/web_view/internal/web_view_web_main_parts.mm | 1 + 1 file changed, 1 insertion(+) commit b5b7717b7137efdd1ef344dcd0348a6211f6fd57 Author: Sam McNally <sammc@chromium.org> Date: Tue Dec 11 05:41:28 2018 +0000 Use file metadata from DriveFS in quickview when available. MetadataBoxController uses the availability of externalFileUrl in file metadata to decide whether to obtain metadata via ExternalMetadataProvider or by reading the file. With DriveFS, externalFileUrl is not set but ExternalMetadataProvider should be used for fetching metadata. Also use alternateUrl (which is only set for Drive files) to detect files where this metadata provider should be used. Also skip FSP metadata requests when none of the metadata fields are available via the FSP API. Bug: 913738, 587231 Change-Id: I95636e6bcf1d21cea3366d17363ab6300b1d59f8 Reviewed-on: https://chromium-review.googlesource.com/c/1370154 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615437} .../chromeos/extensions/file_manager/private_api_drive.cc | 4 ++++ .../file_manager/foreground/js/metadata_box_controller.js | 6 +++--- .../integration_tests/file_manager/quick_view.js | 13 +++++++++++++ 3 files changed, 20 insertions(+), 3 deletions(-) commit f592cd1790b171298d5ca8851acaa34207d348d9 Author: Yusuke Sato <yusukes@chromium.org> Date: Tue Dec 11 05:34:40 2018 +0000 arc: Pass CHROMEOS_USER variable to the arcvm job This allows the job to use userdata.qcow in the user's /home. BUG=b:118408409 TEST=sign in, confirm the job is running Change-Id: I1bcb5ff1cfcae06a7ce404b17ffd2c329419736e Reviewed-on: https://chromium-review.googlesource.com/c/1367085 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#615436} components/arc/arc_vm_client_adapter.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit fb53f31261cea052b03ba4eb801901ab7b684356 Author: Fergal Daly <fergal@chromium.org> Date: Tue Dec 11 05:31:39 2018 +0000 [CSS] Fix test for css invalidation so that it fails without ::part. The test was testing that the element ended up green (starting red) however, if the browser has no support at all for ::part then the element actually starts green and stays green. Bug: 805271 Change-Id: Ida40c7963aa3a00c3d197b1309ddaea49e4f3b92 Reviewed-on: https://chromium-review.googlesource.com/c/1369500 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615435} .../css/css-shadow-parts/invalidation-change-part-name-idl-setter.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 210930c9863d4493698baa012babfeb4bec20497 Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Dec 11 05:28:34 2018 +0000 [WebMIDI] Remove call to RenderProcessHost::FromID Bug: 582328 Change-Id: I733060f119871b3de35c147e6d3eb1d6c83663f1 Reviewed-on: https://chromium-review.googlesource.com/c/1366299 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#615434} content/browser/media/midi_host.cc | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) commit 1a637e24e548a6d07f38f25246800fa452311d3c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 05:24:53 2018 +0000 Roll src/third_party/skia 40bd76027f8e..ae0d860ba31b (2 commits) https://skia.googlesource.com/skia.git/+log/40bd76027f8e..ae0d860ba31b git log 40bd76027f8e..ae0d860ba31b --date=short --no-merges --format='%ad %ae %s' 2018-12-11 reed@google.com move intercepts call to textblob 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 153e0224da45..f5c88e7e1c1a (2 commits) Created with: gclient setdep -r src/third_party/skia@ae0d860ba31b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Id3ef54967dde692a364dcf9a2815c56e53de3c8a Reviewed-on: https://chromium-review.googlesource.com/c/1371248 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615433} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 220fc84e2fee980d98f20c276d454316a1974fee Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Dec 11 04:54:17 2018 +0000 Worker: Simplify ownership model of SharedWorkerRepositoryClient Before this CL, SharedWorkerRepositoryClient is created in RenderFrameImpl::Initialize() and owned by WebLocalFrameImpl[*]. This needed unnecessary plumbing between blink/renderer and content/renderer. This CL removes the path, and instead makes Document own SharedWorkerRepositoryClient as Supplement<Document>. This changes the ownership model of SharedWorkerRepositoryClient from per-Frame to per-Document, but it shouldn't affect behavior. Also, this removes the mechanism to manage multiple Documents from SharedWorkerRepositoryClient (see ClientMap/Set in the class). As mentioned above, the client is a per-Frame (per-Document) object, and the mechanism doesn't make sense. [*] This was necessary for communicating with renderer's embedder but the path was removed by recent refactorings (Onion Soup). Bug: 911415 Change-Id: If9ae00b0fbdde99d8a0256dc7381fab5c72ff317 Reviewed-on: https://chromium-review.googlesource.com/c/1370224 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615432} content/renderer/render_frame_impl.cc | 2 - third_party/blink/public/web/web_local_frame.h | 6 -- third_party/blink/renderer/core/dom/document.cc | 4 -- .../core/exported/local_frame_client_impl.cc | 6 -- .../core/exported/local_frame_client_impl.h | 2 - .../blink/renderer/core/frame/local_frame_client.h | 5 -- .../renderer/core/frame/web_local_frame_impl.cc | 7 --- .../renderer/core/frame/web_local_frame_impl.h | 9 --- .../blink/renderer/core/workers/shared_worker.cc | 28 ++++------ .../workers/shared_worker_repository_client.cc | 64 +++++++++++----------- .../core/workers/shared_worker_repository_client.h | 52 ++++++++---------- 11 files changed, 67 insertions(+), 118 deletions(-) commit c4777f8cc64fdf756c1124c79da2ff332eafeb2f Author: rbpotter <rbpotter@chromium.org> Date: Tue Dec 11 04:47:23 2018 +0000 Print Preview: Fix polish bug with custom margins radio button Previously, the height of the custom margins error message was fixed at 2 lines of text. However, this resulted in the message being cut off for some languages/font sizes. Allowing a variable height error message broke the logic setting the custom radio button's position, so this CL updates the positioning logic so that the radio button stays centered on the cr-input regardless of the height of the error message. Bug: 911958 Change-Id: If9e1655e0d2bb87de46ac3c1749b5b07cd831bd7 Reviewed-on: https://chromium-review.googlesource.com/c/1369027 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#615431} chrome/browser/resources/print_preview/new/pages_settings.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 4860ebe6332c280e746869167c3e10dfbaeeb907 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Dec 11 04:43:41 2018 +0000 Gardening: resource-timing.https.html now passes. The 'generated response' test used to fail. Fixed by r615063. Bug: 840881 Change-Id: Ia5773ee28ac4d9b2195f98f8dedd731fa166502e TBR: npm No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1370159 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#615430} third_party/blink/web_tests/TestExpectations | 5 ----- 1 file changed, 5 deletions(-) commit baf9f739cb5f615fd7758bc7a476a9d1859b2796 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 04:40:24 2018 +0000 Roll src/third_party/webrtc 69540f44196e..8f66ddbae325 (9 commits) https://webrtc.googlesource.com/src.git/+log/69540f44196e..8f66ddbae325 git log 69540f44196e..8f66ddbae325 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 steveanton@webrtc.org Move is_unified_plan flag to a member variable 2018-12-10 steveanton@webrtc.org [Unified Plan] Fix issues with recycling m= sections 2018-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a1b00bf181..aec72e9e9c (615131:615246) 2018-12-10 terelius@webrtc.org Remove support for having multiple SSRCs in an RtcEventVideoSendStreamConfig. 2018-12-10 benwright@webrtc.org New statistic added to VideoReceiveStream to determine latency to first decode. 2018-12-10 terelius@webrtc.org Fix header extension mapping bug in RTC event log analyzer. 2018-12-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6dec3971c..a1b00bf181 (614285:615131) 2018-12-10 srte@webrtc.org Adds trial to fall back to probe rate if ack rate is missing. 2018-12-10 srte@webrtc.org Using more accurate receive time calculation in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@8f66ddbae325 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:899680,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iadd4ec06946097473111d30398341877f8149812 Reviewed-on: https://chromium-review.googlesource.com/c/1370653 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615429} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 015014924bd3def93f8c8335b66ac3f2014f85c9 Author: Sam McNally <sammc@chromium.org> Date: Tue Dec 11 04:35:52 2018 +0000 Provide the alternate URL as the drag and drop URL for hosted docs. With the old Drive integration, all files were accessed via externalfile: URLs. Those for hosted docs redirected to the actual URL for accessing that doc. With DriveFS, real file: URLs are used so no externalfile: URLs exist. The drag and drop code populates the File and, if available, the externalfile: URL in the DataTransfer. For hosted docs under DriveFS, this is insufficient as the files are not openable. However, the alternateUrl is the URL needed to access the hosted doc so substitute it for the externalfile: URL for hosted docs. Bug: 913725 Change-Id: Ib9456042e1e864b378b71db404e1ea406959b1fe Reviewed-on: https://chromium-review.googlesource.com/c/1370152 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615428} .../file_manager/foreground/js/file_transfer_controller.js | 14 ++++++++++---- .../foreground/js/metadata/external_metadata_provider.js | 3 +++ 2 files changed, 13 insertions(+), 4 deletions(-) commit 55111f45b671d305dffe0e4dafa3f29ae6062064 Author: Cecilia Ni <ceciliani@google.com> Date: Tue Dec 11 04:35:21 2018 +0000 [App Management] Make app list expandable. This CL makes the app list show 4 apps by default with the rest in an expandable list. Bug: 1369498 Change-Id: I7e559d806dc85c64a6f01661e5ba2e0e89604c38 Reviewed-on: https://chromium-review.googlesource.com/c/1369498 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#615427} chrome/app/app_management_strings.grdp | 5 +- chrome/browser/browser_resources.grd | 9 ++- chrome/browser/resources/app_management/BUILD.gn | 10 ++- chrome/browser/resources/app_management/app.html | 8 ++- .../resources/app_management/constants.html | 1 + .../browser/resources/app_management/constants.js | 6 ++ .../resources/app_management/fake_page_handler.js | 2 + .../resources/app_management/main_view.html | 62 ++++++++++++++--- .../browser/resources/app_management/main_view.js | 80 +++++++++++++++++++++- .../ui/webui/app_management/app_management_ui.cc | 3 + 10 files changed, 169 insertions(+), 17 deletions(-) commit 31754647b0b6ac47dbbf589ba32de7de80217ec2 Author: Richard Li <richard.li@intel.com> Date: Tue Dec 11 04:33:00 2018 +0000 [OnionSoup] de-couple and remove content::BackgroundFetchRegistration The typemapping between content::BackgroundFetchRegistration and blink.mojom.BackgroundFetchRegistration causes the dependence for //third_party/blink/public:blink_headers. The dependence is a block for moving background_fetch.mojom into blink/public/mojom/. In this CL, content::BackgroundFetchRegistration is removed. In the future, background_fetch_types.typemap will be removed, and then background_fetch.mojom is able to move to new place. Change-Id: I913f64dd4e2ed47deacdfeda1e77781fcda3373a Reviewed-on: https://chromium-review.googlesource.com/c/1365079 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#615426} .../background_fetch/background_fetch_context.cc | 22 ++-- .../background_fetch/background_fetch_context.h | 4 +- .../background_fetch_data_manager.h | 2 +- .../background_fetch_data_manager_observer.h | 7 +- .../background_fetch_data_manager_unittest.cc | 96 ++++++++-------- ...background_fetch_embedded_worker_test_helper.cc | 16 +-- .../background_fetch_embedded_worker_test_helper.h | 13 ++- .../background_fetch_event_dispatcher.cc | 26 ++--- .../background_fetch_event_dispatcher.h | 18 +-- .../background_fetch_event_dispatcher_unittest.cc | 16 +-- .../background_fetch_job_controller.cc | 4 +- .../background_fetch_job_controller.h | 8 +- .../background_fetch_job_controller_unittest.cc | 3 +- .../background_fetch_registration_notifier.cc | 2 +- .../background_fetch_registration_notifier.h | 7 +- ...kground_fetch_registration_notifier_unittest.cc | 14 +-- .../background_fetch/background_fetch_scheduler.cc | 14 +-- .../background_fetch/background_fetch_scheduler.h | 10 +- .../background_fetch_service_impl.cc | 4 +- .../background_fetch_service_unittest.cc | 123 +++++++++++---------- .../background_fetch/background_fetch_test_base.cc | 5 +- .../background_fetch/background_fetch_test_base.h | 4 +- .../storage/create_metadata_task.cc | 8 +- .../storage/create_metadata_task.h | 4 +- .../background_fetch/storage/database_helpers.cc | 2 +- .../background_fetch/storage/database_helpers.h | 2 +- .../storage/get_initialization_data_task.cc | 2 +- .../storage/get_initialization_data_task.h | 3 +- .../storage/get_registration_task.cc | 6 +- .../storage/get_registration_task.h | 2 +- .../service_worker/embedded_worker_test_helper.cc | 47 ++++---- .../service_worker/embedded_worker_test_helper.h | 17 ++- .../background_fetch_struct_traits.cc | 19 ---- .../background_fetch_struct_traits.h | 41 ------- .../background_fetch_struct_traits_unittest.cc | 22 ---- .../background_fetch/background_fetch_types.cc | 27 ----- .../background_fetch/background_fetch_types.h | 40 ------- .../background_fetch_types.typemap | 5 +- .../service_worker_context_client.cc | 30 ++--- .../service_worker/service_worker_context_client.h | 8 +- .../background_fetch/background_fetch.mojom | 5 +- 41 files changed, 285 insertions(+), 423 deletions(-) commit 65f35c8cef7c30126b95d65f45bcea58c6a5e055 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Dec 11 04:21:20 2018 +0000 Changed Downloads translations when MyFilesVolumes is enabled Change util.getEntryLabel to special case Downloads folder to translate. Change DirectoryTree and FileList to use util.getEntryLabel for translating the entry labels and util.compareLabel for sorting the entries. Change FileList related types to carry volume manager to be able to pass LocationInfo to be able to use getEntryLabel for displaying and sorting entries on File List, as follows: - Add VolumeManager to FileListContext constructor, since this type is constructed only once. - Change DirectoryContents constructor to forward VolumeManager from FileListContext to FileListModel. - FileListModel uses VolumeManager to get LocationInfo to sort entries by labels. Add Closure markup for DirectoryContents attributes related to this change to add clarity for developers and stronger type in Closure. As part of this changed DirectoryContents.fileList_ to be always FileListModel instead of switching to a empty ArrayDataModel from |setFileList|. Test will come in follow up CL. :-) Bug: 873539 Change-Id: I46dd1879c14cbf046f5da5d96c29b34f13d404a1 Reviewed-on: https://chromium-review.googlesource.com/c/1370151 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615425} ui/file_manager/file_manager/common/js/util.js | 37 ++++++++++++++----- .../foreground/js/directory_contents.js | 25 +++++++++---- .../file_manager/foreground/js/directory_model.js | 8 ++--- .../file_manager/foreground/js/file_list_model.js | 41 ++++++++++++++++++++++ .../foreground/js/ui/directory_tree.js | 10 ++++-- .../file_manager/foreground/js/ui/file_grid.js | 3 +- .../file_manager/foreground/js/ui/file_table.js | 3 +- .../foreground/js/ui/file_table_list.js | 9 ++--- 8 files changed, 110 insertions(+), 26 deletions(-) commit 31c987118b6a8a77a1477ab50ebc99fe6c2f0009 Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Tue Dec 11 04:15:13 2018 +0000 content: Create a small compositor component. Create a small content/renderer/compositor component to contain the code needed to manage the compositor (i.e. LayerTreeView and related code). This code should not have any dependencies on the rest of the code in content. Enforce this by way of explicit DEPS rules. This would make it easier to relocate the compositor out of content when desired (see earlier discussions in crbug.com/838693, crrev.com/c/1126490). Move up the rest of the code under content/renderer/gpu into content/renderer/. Bug: none Change-Id: I5b0c043c6577f1d6aa5f12f6243713c9e8c35d32 Reviewed-on: https://chromium-review.googlesource.com/c/1360430 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615424} content/renderer/BUILD.gn | 21 ++++---- content/renderer/DEPS | 3 ++ .../android/synchronous_layer_tree_frame_sink.cc | 2 +- content/renderer/compositor/BUILD.gn | 22 ++++++++ content/renderer/compositor/DEPS | 12 +++++ content/renderer/{gpu => compositor}/OWNERS | 0 .../{gpu => compositor}/compositor_dependencies.h | 10 ++-- .../{gpu => compositor}/layer_tree_view.cc | 4 +- .../renderer/{gpu => compositor}/layer_tree_view.h | 16 +++--- .../{gpu => compositor}/layer_tree_view_delegate.h | 6 +-- .../layer_tree_view_unittest.cc | 2 +- .../renderer/{gpu => }/frame_swap_message_queue.cc | 11 ++-- .../renderer/{gpu => }/frame_swap_message_queue.h | 6 +-- .../{gpu => }/frame_swap_message_queue_unittest.cc | 9 ++-- content/renderer/gpu/DEPS | 5 -- .../{gpu => }/gpu_benchmarking_extension.cc | 58 +++++++++------------- .../{gpu => }/gpu_benchmarking_extension.h | 11 ++-- content/renderer/input/frame_input_handler_impl.cc | 2 +- .../renderer/input/render_widget_input_handler.cc | 2 +- .../renderer/input/widget_input_handler_impl.cc | 2 +- .../renderer/input/widget_input_handler_manager.cc | 2 +- .../media/android/stream_texture_factory.h | 2 +- .../{gpu => }/queue_message_swap_promise.cc | 4 +- .../{gpu => }/queue_message_swap_promise.h | 6 +-- .../queue_message_swap_promise_unittest.cc | 11 ++-- content/renderer/render_frame_impl.cc | 4 +- content/renderer/render_thread_impl.cc | 2 +- content/renderer/render_thread_impl.h | 2 +- content/renderer/render_view_browsertest.cc | 2 +- content/renderer/render_view_impl.cc | 2 +- content/renderer/render_widget.cc | 6 +-- content/renderer/render_widget.h | 2 +- .../renderer/render_widget_fullscreen_pepper.cc | 2 +- content/renderer/render_widget_unittest.cc | 2 +- .../{gpu => }/stream_texture_host_android.cc | 2 +- .../{gpu => }/stream_texture_host_android.h | 6 +-- content/shell/test_runner/BUILD.gn | 1 + .../test_runner/test_runner_for_specific_view.cc | 2 +- content/test/BUILD.gn | 10 ++-- content/test/fake_compositor_dependencies.h | 2 +- content/test/stub_layer_tree_view_delegate.h | 2 +- content/test/web_test_support.cc | 2 +- third_party/blink/renderer/core/DEPS | 2 +- .../blink/renderer/core/frame/frame_test_helpers.h | 2 +- third_party/blink/renderer/core/testing/DEPS | 2 +- .../renderer/core/testing/sim/sim_compositor.h | 2 +- 46 files changed, 151 insertions(+), 137 deletions(-) commit 634d6f264b17596c05ec94c623b18fc545ec898d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 04:12:25 2018 +0000 Roll src-internal 7f98851124b4..ea2cff61234c (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f98851124b4..ea2cff61234c Created with: gclient setdep -r src-internal@ea2cff61234c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic6e4b986b5510e43911e5dd53cc11d5517ccff5f Reviewed-on: https://chromium-review.googlesource.com/c/1370652 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615423} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7688eb868aa9659a24979efc6bffd551f20080a3 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Tue Dec 11 04:11:08 2018 +0000 Updating trunk VERSION from 3637.0 to 3638.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I3a2c55aac4b8ed8000550c8093cc96139918deab Reviewed-on: https://chromium-review.googlesource.com/c/1371127 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#615422} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e87d3deac44fc7a1de0636990835e733496947aa Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 04:08:09 2018 +0000 Update V8 to version 7.3.82. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09253406..f88410f8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I49f831d7e7f0cdbfa407f6b98655a4808aabbdc8 Reviewed-on: https://chromium-review.googlesource.com/c/1371198 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615421} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 86acb09b8c7ae2bc4c97a8ee23b0d8ebef8c96e9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 04:05:23 2018 +0000 Roll src/third_party/skia a10494c302e6..40bd76027f8e (1 commits) https://skia.googlesource.com/skia.git/+log/a10494c302e6..40bd76027f8e git log a10494c302e6..40bd76027f8e --date=short --no-merges --format='%ad %ae %s' 2018-12-11 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@40bd76027f8e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I4d5d48fcdeaa0385ad99f9f0f30aa61a2f17d139 Reviewed-on: https://chromium-review.googlesource.com/c/1371246 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615420} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 703db889020eaed8a0cd525f8c5a6be76186983d Author: Kent Tamura <tkent@chromium.org> Date: Tue Dec 11 04:00:55 2018 +0000 Drop isomorphic decoding from fragment navigation When Chrome opens a URL with a fragment id, it decodes %xx for UTF-8, and decodes it for isomorphic-decode [1] if it is invalid for UTF-8. Then tries to find an element with the decoding result as an ID. No other browsers do isomorphic-decode, and it's not defined by the standard. This CL removes this non-standard behavior. This CL doesn't apply Blink's intent process. This is a very small behavior change, and affects only 0.0016% of page views. * Implementation - Add a flag to disable isomorphic-decode to url::DecodeURLEscapeSequences(), and apply the new behavior only to blink::LocalFrameView::ProcessUrlFragment(). - Remove unnecessary UseCounters. chromestatus: https://www.chromestatus.com/feature/4885685374812160 [1] https://infra.spec.whatwg.org/#isomorphic-decode Change-Id: I17788e3697484701db66dbfef53bd1cae4598c51 Bug: 845824 Reviewed-on: https://chromium-review.googlesource.com/c/1333178 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615419} android_webview/renderer/aw_render_frame_ext.cc | 5 +- .../providers/cast/cast_media_source.cc | 4 +- chrome/test/chromedriver/server/http_handler.cc | 3 +- components/arc/intent_helper/link_handler_model.cc | 1 + .../common/content_security_policy/csp_source.cc | 4 +- .../blink/public/platform/web_feature.mojom | 9 -- .../renderer/bindings/core/v8/script_controller.cc | 3 +- .../core/css/resolver/element_style_resources.cc | 4 +- .../core/exported/web_plugin_container_impl.cc | 3 +- third_party/blink/renderer/core/fileapi/file.cc | 3 +- .../blink/renderer/core/frame/csp/csp_source.cc | 3 +- .../core/frame/csp/source_list_directive.cc | 3 +- .../blink/renderer/core/frame/local_frame_view.cc | 51 ++---------- third_party/blink/renderer/core/frame/location.cc | 3 +- .../renderer/core/frame/web_local_frame_impl.cc | 3 +- .../blink/renderer/core/html/image_document.cc | 3 +- .../core/html/media/media_fragment_uri_parser.cc | 12 ++- .../blink/renderer/core/loader/form_submission.cc | 3 +- .../blink/renderer/core/page/create_window.cc | 3 +- .../blink/renderer/core/svg/svg_resource.cc | 4 +- .../blink/renderer/core/svg/svg_uri_reference.cc | 4 +- .../blink/renderer/core/svg/svg_use_element.cc | 4 +- .../blink/renderer/core/url/url_search_params.cc | 3 +- .../blink/renderer/platform/weborigin/kurl.cc | 9 +- .../blink/renderer/platform/weborigin/kurl.h | 9 +- .../blink/renderer/platform/weborigin/kurl_test.cc | 12 ++- .../renderer/platform/weborigin/security_origin.cc | 3 +- .../fragment-and-encoding-2-expected.txt | 6 -- .../fragment-and-encoding-expected.txt | 7 -- tools/metrics/histograms/enums.xml | 18 ++-- url/url_util.cc | 23 ++---- url/url_util.h | 21 ++--- url/url_util_unittest.cc | 96 ++++++++++++---------- 33 files changed, 157 insertions(+), 185 deletions(-) commit 9639de0797593971c5b56e3cecefcac60fd86d28 Author: Casey Piper <piperc@chromium.org> Date: Tue Dec 11 03:57:19 2018 +0000 Add logs when requests are proxied to WebAuthn Whenever a request is received by cryptotoken, and that request is then proxied to WebAuthn, log this instance to the background console. Change-Id: I180f6fbbd3b512dab9f4549742b52f97a36542f1 Reviewed-on: https://chromium-review.googlesource.com/c/1371084 Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Casey Piper <piperc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615418} chrome/browser/resources/cryptotoken/enroller.js | 1 + chrome/browser/resources/cryptotoken/signer.js | 1 + 2 files changed, 2 insertions(+) commit c23362773a94551285d023d48d8af0f734186965 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Dec 11 03:56:44 2018 +0000 Worker: Move SharedWorkerRepositoryClientImpl from core/exported/ to core/workers/ For cleanup, this CL moves SharedWorkerRepositoryClientImpl from core/exported/ to core/workers/, and merge it to SharedWorkerRepositoryClient. Change-Id: I694198b596ef572f064fa0638e82251e53decc0f Bug: 911415 Reviewed-on: https://chromium-review.googlesource.com/c/1369757 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615417} third_party/blink/renderer/core/exported/BUILD.gn | 2 - .../core/exported/local_frame_client_impl.cc | 4 +- .../shared_worker_repository_client_impl.h | 98 ---------------------- .../renderer/core/frame/web_local_frame_impl.cc | 4 +- .../renderer/core/frame/web_local_frame_impl.h | 6 +- third_party/blink/renderer/core/workers/BUILD.gn | 1 + .../shared_worker_repository_client.cc} | 15 ++-- .../core/workers/shared_worker_repository_client.h | 51 ++++++++--- 8 files changed, 56 insertions(+), 125 deletions(-) commit 29d62643351b1cf142de933d7e785f64b5aac83c Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Dec 11 03:56:15 2018 +0000 DevTools: Enable the Accessibility domain for OOPIFs Change-Id: I4821b09569a302f8a3039a864f2dddac445bfcf3 Reviewed-on: https://chromium-review.googlesource.com/c/1370887 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#615416} third_party/blink/renderer/modules/modules_initializer.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2bcd17a0a69b8272918718795f8ca12e23820d20 Author: Kent Tamura <tkent@chromium.org> Date: Tue Dec 11 03:39:20 2018 +0000 blinkpy: Rename function names and variable names related to "layout test directory" to "web_test" Also, update symbols and comments around them. This CL has no behavior changes. Bug: 843412 Change-Id: Ic1c2381e5d431fdedf5978d510cc9018e101d70d Reviewed-on: https://chromium-review.googlesource.com/c/1370157 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615415} .../blinkpy/common/checkout/baseline_optimizer.py | 20 ++--- .../common/checkout/baseline_optimizer_unittest.py | 14 ++-- .../blink/tools/blinkpy/common/host_mock.py | 2 +- .../blink/tools/blinkpy/common/path_finder.py | 9 +-- .../tools/blinkpy/common/path_finder_unittest.py | 12 +-- .../commands/copy_existing_baselines_unittest.py | 4 +- .../tools/blinkpy/tool/commands/flaky_tests.py | 2 +- .../tool/commands/optimize_baselines_unittest.py | 10 +-- .../blink/tools/blinkpy/tool/commands/queries.py | 6 +- .../tools/blinkpy/tool/commands/rebaseline.py | 10 +-- .../tools/blinkpy/tool/commands/rebaseline_cl.py | 16 ++-- .../tool/commands/rebaseline_cl_unittest.py | 8 +- .../blinkpy/tool/commands/rebaseline_server.py | 12 +-- .../tool/commands/rebaseline_test_unittest.py | 4 +- .../blinkpy/tool/commands/rebaseline_unittest.py | 6 +- .../blink/tools/blinkpy/w3c/chromium_finder.py | 2 +- .../blinkpy/w3c/directory_owners_extractor.py | 10 +-- .../blink/tools/blinkpy/w3c/import_notifier.py | 10 +-- third_party/blink/tools/blinkpy/w3c/test_copier.py | 12 +-- .../blink/tools/blinkpy/w3c/test_importer.py | 24 +++--- .../tools/blinkpy/w3c/wpt_expectations_updater.py | 16 ++-- .../w3c/wpt_expectations_updater_unittest.py | 6 +- .../blink/tools/blinkpy/w3c/wpt_manifest.py | 6 +- .../tools/blinkpy/web_tests/controllers/manager.py | 6 +- .../web_tests/controllers/single_test_runner.py | 2 +- .../web_tests/controllers/web_test_finder.py | 6 +- .../blinkpy/web_tests/lint_test_expectations.py | 8 +- .../web_tests/lint_test_expectations_unittest.py | 2 +- .../web_tests/models/test_expectations_unittest.py | 8 +- .../blinkpy/web_tests/models/test_run_results.py | 2 +- .../blink/tools/blinkpy/web_tests/port/android.py | 18 ++--- .../blink/tools/blinkpy/web_tests/port/base.py | 64 +++++++-------- .../tools/blinkpy/web_tests/port/base_unittest.py | 38 ++++----- .../tools/blinkpy/web_tests/port/browser_test.py | 2 +- .../web_tests/port/browser_test_unittest.py | 4 +- .../blink/tools/blinkpy/web_tests/port/driver.py | 6 +- .../blinkpy/web_tests/port/driver_unittest.py | 4 +- .../blink/tools/blinkpy/web_tests/port/fuchsia.py | 4 +- .../tools/blinkpy/web_tests/port/port_testcase.py | 6 +- .../blink/tools/blinkpy/web_tests/port/test.py | 28 +++---- .../blink/tools/blinkpy/web_tests/port/win.py | 2 +- .../tools/blinkpy/web_tests/run_webkit_tests.py | 2 +- .../blinkpy/web_tests/run_webkit_tests_unittest.py | 92 +++++++++++----------- .../tools/blinkpy/web_tests/servers/apache_http.py | 4 +- .../tools/blinkpy/web_tests/servers/pywebsocket.py | 6 +- .../tools/blinkpy/web_tests/servers/wptserve.py | 4 +- .../blink/tools/blinkpy/web_tests/try_flag.py | 4 +- .../tools/blinkpy/web_tests/try_flag_unittest.py | 8 +- .../web_tests/update_expectations_unittest.py | 4 +- 49 files changed, 277 insertions(+), 278 deletions(-) commit 503b1b9f7723226fbfe248f9cb876af17bb1c2d2 Author: Yue Cen <rsgingerrs@chromium.org> Date: Tue Dec 11 03:38:37 2018 +0000 Password manager: Remove ellipsis in masked state Bug: 912321 Change-Id: Ibfddb6628b06fe5111f873cf7716a210d47deb36 Reviewed-on: https://chromium-review.googlesource.com/c/1370369 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615414} .../browser/resources/settings/autofill_page/password_list_item.html | 4 ++++ 1 file changed, 4 insertions(+) commit 0965beb5b7dedfb9afe16fe6b355411c51a52b58 Author: Alex Moshchuk <alexmos@chromium.org> Date: Tue Dec 11 03:22:01 2018 +0000 Add Site Isolation Android FYI filter file to BUILD.gn This is a followup to https://crrev.com/c/1365982, which introduced a new filter file for Site Isolation Android content_browsertests, but forgot to add it to BUILD.gn. Change-Id: I33d9626562886bd5b5b7eec051a40bc9169ed627 Reviewed-on: https://chromium-review.googlesource.com/c/1371197 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615413} testing/buildbot/filters/BUILD.gn | 1 + 1 file changed, 1 insertion(+) commit ee261c6dcce9b2d11bd54a3378291341c9105234 Author: Dan Beam <dbeam@chromium.org> Date: Tue Dec 11 03:21:00 2018 +0000 Revert "Revert "Downloads: detect failed file icons and show default thumbnail"" This reverts commit 14d25fb9050e3a5b9eea892514325e7a44d9e894. This is a roll-forward with a fix to the URL of an iconset to load (see the diff between patchsets 1 and 2). NOPRESUBMIT=true # existing issue in destination.js Bug: 855259, 912678 Change-Id: I3aeb26263de682ecb2f0596e336ec20ab5c19807 Reviewed-on: https://chromium-review.googlesource.com/c/1371079 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615412} chrome/browser/browser_resources.grd | 2 + chrome/browser/resources/md_downloads/BUILD.gn | 9 ++++ .../resources/md_downloads/icon_loader.html | 4 ++ .../browser/resources/md_downloads/icon_loader.js | 52 ++++++++++++++++++++++ chrome/browser/resources/md_downloads/item.html | 23 ++++++---- chrome/browser/resources/md_downloads/item.js | 38 +++++++++++----- .../resources/print_preview/data/destination.js | 2 +- chrome/browser/resources/print_preview/icons.html | 1 - .../print_preview/new/destination_dialog.html | 1 + .../print_preview/new/destination_list_item.html | 1 + .../ui/webui/md_downloads/md_downloads_ui.cc | 3 ++ chrome/test/data/webui/icon_test.html | 6 +++ .../webui/md_downloads/downloads_browsertest.js | 3 ++ chrome/test/data/webui/md_downloads/item_tests.js | 45 +++++++++++++++---- .../test/data/webui/md_downloads/test_support.js | 23 ++++++++++ ui/webui/resources/cr_elements/icons.html | 1 + ui/webui/resources/js/icon.js | 11 +++++ 17 files changed, 195 insertions(+), 30 deletions(-) commit 75bcaf1e2cfd05ebc5960f8d8eb7c192bf37c0f5 Author: Erik Luo <luoe@chromium.org> Date: Tue Dec 11 03:20:40 2018 +0000 DevTools: show default focus style for radio input Screenshot: https://imgur.com/a/33LFGai Bug: 894341 Change-Id: I90abb517bb08358fa932335648be15ca0e9cab2b Reviewed-on: https://chromium-review.googlesource.com/c/1367108 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615411} third_party/blink/renderer/devtools/front_end/ui/inspectorCommon.css | 4 ++++ 1 file changed, 4 insertions(+) commit 90c853aae4b8e1e538f6b486f0a0a30fa1c655dc Author: Pavel Feldman <pfeldman@chromium.org> Date: Tue Dec 11 03:02:56 2018 +0000 DevTools: allow for custom geolocation overrides. Bug: 649657 Change-Id: I76bae556b1196336b9da03cf924e31d97a1e238f Reviewed-on: https://chromium-review.googlesource.com/c/1371210 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615410} third_party/blink/renderer/devtools/BUILD.gn | 6 +- .../front_end/Images/accelerometer-back.png | Bin 865 -> 0 bytes .../front_end/Images/accelerometer-back.svg | 69 ++++++++ .../front_end/Images/accelerometer-front.png | Bin 470 -> 0 bytes .../front_end/Images/accelerometer-front.svg | 28 +++ .../front_end/emulation/GeolocationsSettingsTab.js | 189 +++++++++++++++++++++ .../devtools/front_end/emulation/SensorsView.js | 74 ++++---- .../emulation/geolocationsSettingsTab.css | 94 ++++++++++ .../devtools/front_end/emulation/module.json | 31 +++- .../devtools/front_end/emulation/sensors.css | 32 ++-- 10 files changed, 464 insertions(+), 59 deletions(-) commit 02de02be61c0564bbbfef0d868e2b543572b3c86 Author: Sungguk Lim <limasdf@gmail.com> Date: Tue Dec 11 03:01:53 2018 +0000 Add onChanged event callback to StorageArea When new value is updated by StorageArea.set(), chrome.storage.onChanged callback and newly added StorageArea.onChanged callback would be called at the same time. Bug: 863277 Change-Id: I9076fdf1c55f5c2d5e913e3c671aab6630cee304 Reviewed-on: https://chromium-review.googlesource.com/c/1329802 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#615409} .../extensions/api/storage/settings_apitest.cc | 36 +++++++ .../native_bindings/extension/background.js | 1 + .../api_test/settings/storage_area/background.js | 33 ++++++ .../api_test/settings/storage_area/manifest.json | 10 ++ .../browser/api/storage/storage_api_unittest.cc | 35 +++++-- extensions/browser/api/storage/storage_frontend.cc | 55 ++++++++-- .../browser/extension_event_histogram_value.h | 3 + extensions/common/api/storage.json | 14 +++ extensions/renderer/resources/storage_area.js | 4 + extensions/renderer/storage_area.cc | 111 ++++++++++++++++----- extensions/renderer/storage_area.h | 7 ++ extensions/renderer/storage_area_unittest.cc | 38 +++++++ tools/metrics/histograms/enums.xml | 3 + 13 files changed, 306 insertions(+), 44 deletions(-) commit c317f6ffbd77d43eceeb799d7f45a0a60a741995 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 03:01:50 2018 +0000 Roll src/third_party/depot_tools 762a25693faf..fed2cb39c320 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/762a25693faf..fed2cb39c320 git log 762a25693faf..fed2cb39c320 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 brucedawson@chromium.org Fix ucrt source path when packaging the Windows toolchain Created with: gclient setdep -r src/third_party/depot_tools@fed2cb39c320 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I89fe17d53ed093db892056b008df969759be0f85 Reviewed-on: https://chromium-review.googlesource.com/c/1370651 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615408} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8392d79669d9f3bc48357635e6c873ec1ec71b09 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Dec 11 02:59:49 2018 +0000 [CompositeAfterPaint] Fix opaque status of composited multicol contents When an object has multiple fragments, the original method in BoxPainter::BackgroundIsKnownToBeOpaque() didn't work because the object's VisualRect is the bounding box of all fragments' visual rects, which is likely to cover areas that are not covered by painted background. Now Let BoxPainter::BackgroundIsKnownToBeOpaque() return false if there are multiple fragments. BTW, rebaseline multicol tests containing composited contents. The old baselines expect single fragment for the composited contents which is a SPv1 quirk. CompositeAfterPaint can correctly fragment composited contents. Change-Id: Icdabe2a0eabdf2e1541481f5c09b796c33a9370a Reviewed-on: https://chromium-review.googlesource.com/c/1370276 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615407} third_party/blink/renderer/core/paint/box_painter.cc | 6 ++++++ .../core/paint/ng/ng_box_fragment_painter.cc | 7 +++++++ .../enable-blink-features=CompositeAfterPaint | 19 ++----------------- .../multicol/composited-inner-multicol-expected.png | Bin 0 -> 14044 bytes .../composited-layer-multiple-fragments-expected.png | Bin 0 -> 9918 bytes ...-layer-multiple-fragments-translated-expected.png | Bin 0 -> 11217 bytes .../multicol/composited-layer-nested-expected.png | Bin 0 -> 9918 bytes .../composited-layer-will-change-expected.png | Bin 0 -> 9938 bytes ...omposited-opacity-2nd-and-3rd-column-expected.png | Bin 0 -> 12373 bytes .../multicol/composited-relpos-clipped-expected.png | Bin 0 -> 12033 bytes .../fast/multicol/composited-relpos-expected.png | Bin 0 -> 12000 bytes .../composited-relpos-in-clipped-expected.png | Bin 0 -> 10057 bytes ...sited-relpos-overlapping-will-change-expected.png | Bin 0 -> 12350 bytes .../multicol/composited-relpos-resize-expected.png | Bin 0 -> 10080 bytes ...ited-with-child-layer-in-next-column-expected.png | Bin 0 -> 11458 bytes ...posited-with-overflow-in-next-column-expected.png | Bin 0 -> 7097 bytes .../span/invalid-spanner-in-transform-expected.png | Bin 0 -> 7501 bytes ...sited-relpos-overlapping-will-change-expected.png | Bin 0 -> 11464 bytes ...sited-relpos-overlapping-will-change-expected.png | Bin 0 -> 12085 bytes 19 files changed, 15 insertions(+), 17 deletions(-) commit 6d714fc196e4eb82b54d81b2123126d60cbdaf9b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:57:15 2018 +0000 Roll src/third_party/chromite 6d522d4fe25f..768c73895b2f (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/6d522d4fe25f..768c73895b2f git log 6d522d4fe25f..768c73895b2f --date=short --no-merges --format='%ad %ae %s' 2018-12-11 zhuohao@chromium.org rammus: add mapping for factory-rammus-11289.B 2018-12-11 lamontjones@chromium.org cros_build_lib: Return a list from GetImageDiskPartitionInfo Created with: gclient setdep -r src/third_party/chromite@768c73895b2f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5be6b9a157429c7b29b50992592c793a7b94b50f Reviewed-on: https://chromium-review.googlesource.com/c/1371194 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615406} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 52a1ac72f5cce11433ed9f4324b7de1253de1cc5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:56:57 2018 +0000 Roll src/third_party/skia 15640698497a..a10494c302e6 (1 commits) https://skia.googlesource.com/skia.git/+log/15640698497a..a10494c302e6 git log 15640698497a..a10494c302e6 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 caryclark@skia.org remove legacy switch Created with: gclient setdep -r src/third_party/skia@a10494c302e6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:843966 TBR=ethannicholas@chromium.org Change-Id: I317bbc0e19278427b380be8160c6e46d1f9c302c Reviewed-on: https://chromium-review.googlesource.com/c/1370650 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615405} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8099a1eb65c74427e876b8e056a3a28fb8e60c10 Author: Robert Ma <robertma@chromium.org> Date: Tue Dec 11 02:54:21 2018 +0000 [blinkpy] Make buildbot.fetch_results return None if build is invalid `fetch_results` is only used to fetch results from a specific run, so we should be able to safely assume that builder_name and build_number are not None. The same check is also added to `get_step_name` to prevent misuse. On the other hand, `fetch_layout_test_results` may be used to fetch the latest accumulated results, where URLs are constructed from `results_url`, so we don't add the check to either of these functions. Bug: 913687 Change-Id: Ie8b96fd22ea8e7edc804296689b11411e36ae82a Reviewed-on: https://chromium-review.googlesource.com/c/1371021 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615404} third_party/blink/tools/blinkpy/common/net/buildbot.py | 7 +++++++ .../blink/tools/blinkpy/common/net/buildbot_unittest.py | 10 +++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) commit 5cf349115227577bb6b972d12212514e215c963c Author: Donna Wu <donna.wu@intel.com> Date: Tue Dec 11 02:53:19 2018 +0000 Rename Serial Mojo interfaces for W3C Serial API. This CL is a preparation for W3C Serial API implementation in Blink. Several Serial Mojo interfaces have been renamed: * SerialDeviceEnumerator --> SerialPortManager. * SerialDeviceInfo --> SerialPortInfo. * SerialIoHandler --> SerialPort. * SerialDeviceControlSignals --> SerialPortControlSignals BUG=908833 Change-Id: Ie95722f9f368d049006da8cfe19ec15159895b9d Reviewed-on: https://chromium-review.googlesource.com/c/1365075 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Donna Wu <donna.wu@intel.com> Cr-Commit-Position: refs/heads/master@{#615403} device/serial/serial_device_enumerator.h | 2 +- device/serial/serial_device_enumerator_linux.cc | 6 +-- device/serial/serial_device_enumerator_linux.h | 2 +- device/serial/serial_device_enumerator_mac.cc | 23 +++++----- device/serial/serial_device_enumerator_mac.h | 2 +- device/serial/serial_device_enumerator_unittest.cc | 2 +- device/serial/serial_device_enumerator_win.cc | 19 ++++---- device/serial/serial_device_enumerator_win.h | 2 +- device/serial/serial_io_handler.h | 2 +- device/serial/serial_io_handler_posix.cc | 6 +-- device/serial/serial_io_handler_posix.h | 2 +- device/serial/serial_io_handler_win.cc | 6 +-- device/serial/serial_io_handler_win.h | 2 +- extensions/browser/api/serial/serial_api.cc | 8 ++-- extensions/browser/api/serial/serial_api.h | 10 ++--- extensions/browser/api/serial/serial_apitest.cc | 51 ++++++++++------------ extensions/browser/api/serial/serial_connection.cc | 4 +- extensions/browser/api/serial/serial_connection.h | 21 +++++---- .../browser/api/webcam_private/visca_webcam.cc | 17 ++++---- .../browser/api/webcam_private/visca_webcam.h | 2 +- .../api/webcam_private/visca_webcam_unittest.cc | 11 +++-- services/device/BUILD.gn | 4 +- services/device/device_service.cc | 27 +++++------- services/device/device_service.h | 5 +-- services/device/manifest.json | 4 +- services/device/public/mojom/serial.mojom | 12 ++--- services/device/serial/BUILD.gn | 8 ++-- ...rial_io_handler_impl.cc => serial_port_impl.cc} | 46 ++++++++++--------- ...serial_io_handler_impl.h => serial_port_impl.h} | 18 ++++---- ...pl_unittest.cc => serial_port_impl_unittest.cc} | 17 ++++---- ...merator_impl.cc => serial_port_manager_impl.cc} | 18 ++++---- ...numerator_impl.h => serial_port_manager_impl.h} | 18 ++++---- ...est.cc => serial_port_manager_impl_unittest.cc} | 14 +++--- 33 files changed, 187 insertions(+), 204 deletions(-) commit e3034da0612ec7d327515331889e2d1579eaf818 Author: Simon Que <sque@google.com> Date: Tue Dec 11 02:49:51 2018 +0000 infra/config: Milo links for Linux Goma RBE prod rel builders This CL updates the LUCI Milo config to show links/tabs for the new builders, which will be added in a separate CL. Existing staging builders are explicitly categorized as "staging". BUG=913249 Change-Id: Iad29427c8673a592eb5fd074211980910cbc983c Reviewed-on: https://chromium-review.googlesource.com/c/1368849 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#615402} infra/config/global/luci-milo.cfg | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) commit 1995d2c7d234af7b464bd423f340b8f1ef467581 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:49:40 2018 +0000 Roll src/third_party/pdfium 1ccf890a09a3..f4f8cc56aacf (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/1ccf890a09a3..f4f8cc56aacf git log 1ccf890a09a3..f4f8cc56aacf --date=short --no-merges --format='%ad %ae %s' 2018-12-11 thestig@chromium.org Roll third_party/binutils/ 4110e0919..2be73f7fb (1 commit) Created with: gclient setdep -r src/third_party/pdfium@f4f8cc56aacf The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:718157 TBR=dsinclair@chromium.org Change-Id: I8d4b53f64fabc8647349c3766852e89947b22ad1 Reviewed-on: https://chromium-review.googlesource.com/c/1371193 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615401} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit de0ed4dea83f0629c994c97dcdf2b980ce5bc080 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Tue Dec 11 02:46:05 2018 +0000 [Extensions] Case insensitive api_call filtering in the activity log DB Currently, the activity log API filters the api_name field using case sensitive string equality if a filter for api_name is provided for chrome.activityLogPrivate.getExtensionActivities. This CL changes the matching scheme to be a case insensitive prefix match, similar to what is used for the page_url and arg_url fields. This should make the activity log easier to use when a user is filtering by specific api calls. Bug: 832354 Change-Id: I725542657a5879141426f621631ec69ccd88af9e Reviewed-on: https://chromium-review.googlesource.com/c/1371187 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615400} chrome/browser/extensions/activity_log/counting_policy.cc | 4 ++-- .../extensions/activity_log/counting_policy_unittest.cc | 14 ++++++++++++++ .../extensions/activity_log/fullstream_ui_policy.cc | 4 ++-- .../activity_log/fullstream_ui_policy_unittest.cc | 14 ++++++++++++++ 4 files changed, 32 insertions(+), 4 deletions(-) commit d477cd3a0cd31e9843e210fea0f5bf2f953d196c Author: Scott Violet <sky@chromium.org> Date: Tue Dec 11 02:45:10 2018 +0000 aura: WindowPortMus don't always create ClientSurfaceEmbedder ClientSurfaceEmbedder was being created any time Window::SetEmbedFrameSinkId() was being called. ClientSurfaceEmbedder is *only* needed if Embed() was also called on this window. This patch makes it so ClientSurfaceEmbedder is only created if Embed() is called. BUG=none TEST=none Change-Id: I463458abb1248f1661358d4062389fa9a21f9446 Reviewed-on: https://chromium-review.googlesource.com/c/1369098 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615399} ui/aura/mus/window_port_mus.cc | 28 ++++++++++++++++++------- ui/aura/mus/window_port_mus.h | 3 +++ ui/aura/mus/window_port_mus_unittest.cc | 17 +++++++++++++-- ui/aura/mus/window_tree_client_unittest.cc | 8 +++---- ui/aura/test/mus/window_port_mus_test_helper.cc | 1 + 5 files changed, 43 insertions(+), 14 deletions(-) commit 4db3f315a43daaee2889ef751606078f7f08f48b Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Dec 11 02:44:37 2018 +0000 Enable lock screen notification by default This CL enables the lock screen notification which was behind the flag. Bug: b/111391270 Change-Id: I5d3776c9c5c39f8ce488ec26d80af967f73126b8 Reviewed-on: https://chromium-review.googlesource.com/c/1370145 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#615398} ash/public/cpp/ash_features.cc | 2 +- .../unified_message_center_view_unittest.cc | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) commit a3ac94bfc9ec4f2188e7c07f0d79e0f42c313eca Author: Rob Schonberger <robsc@chromium.org> Date: Tue Dec 11 02:44:06 2018 +0000 In File Saving for Result Ranker, shrink blocking scope and add logs. Add syslogs when failing. Change-Id: I86487b8047fa75ae10707701cfb7f2055d47a1bf Reviewed-on: https://chromium-review.googlesource.com/c/1369490 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615397} .../search_result_ranker/app_search_result_ranker.cc | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) commit 975400ca7ed3851f5fcfcaa2bf9b6f8af87c15ea Author: Ken Rockot <rockot@google.com> Date: Tue Dec 11 02:41:15 2018 +0000 [service-manager] service => service_executable This cleans up service executable support in the client library and its usage around the tree. Namely: - The GN service() template is renamed to service_executable() - The public/cpp/standalone_service directory is renamed to public/cpp/service_executable - The code in aforementioned directory is simplified and unused switches deleted - Unused dependencies on the above stuff have been removed TBR=sky@chromium.org Bug: 911217 Change-Id: I08244059ef9e473df2f4a33303e3b3979efeb933 Reviewed-on: https://chromium-review.googlesource.com/c/1367087 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#615396} ash/BUILD.gn | 4 +- ash/components/quick_launch/BUILD.gn | 6 +-- ash/components/quick_launch/main.cc | 2 +- components/services/filesystem/BUILD.gn | 4 +- components/services/filesystem/main.cc | 2 +- components/services/font/BUILD.gn | 4 +- components/services/font/main.cc | 2 +- components/services/leveldb/BUILD.gn | 4 +- components/services/leveldb/main.cc | 2 +- mash/catalog_viewer/BUILD.gn | 6 +-- mash/catalog_viewer/main.cc | 2 +- mash/example/views_examples/BUILD.gn | 6 +-- mash/example/views_examples/views_examples.cc | 2 +- mash/example/window_type_launcher/BUILD.gn | 6 +-- .../window_type_launcher/window_type_launcher.cc | 2 +- mash/session/BUILD.gn | 4 +- mash/session/main.cc | 2 +- mash/task_viewer/BUILD.gn | 6 +-- mash/task_viewer/main.cc | 2 +- media/mojo/services/BUILD.gn | 4 +- media/mojo/services/main.cc | 2 +- services/audio/BUILD.gn | 4 +- services/audio/service_main.cc | 2 +- services/catalog/public/tools/catalog.gni | 5 +- services/resource_coordinator/BUILD.gn | 1 - services/service_manager/README.md | 2 +- services/service_manager/background/tests/BUILD.gn | 4 +- services/service_manager/embedder/BUILD.gn | 2 +- services/service_manager/embedder/main.cc | 56 +++++++++------------- services/service_manager/public/cpp/service.gni | 45 ----------------- .../public/cpp/service_executable.gni | 31 ++++++++++++ .../BUILD.gn | 15 +++--- .../DEPS | 0 .../main.cc | 9 ++-- .../service_executable_environment.cc} | 26 +++++----- .../service_executable_environment.h | 46 ++++++++++++++++++ .../service_main.h | 6 +-- .../cpp/standalone_service/standalone_service.h | 31 ------------ .../public/cpp/standalone_service/switches.cc | 15 ------ .../public/cpp/standalone_service/switches.h | 16 ------- services/service_manager/runner/host/BUILD.gn | 16 ++----- .../runner/host/host_test_service_main.cc | 2 +- .../runner/host/service_process_launcher.cc | 1 - services/service_manager/standalone/BUILD.gn | 5 -- services/service_manager/tests/BUILD.gn | 2 +- services/service_manager/tests/connect/BUILD.gn | 12 ++--- .../tests/connect/connect_test_class_app.cc | 2 +- .../tests/connect/connect_test_exe.cc | 2 +- .../tests/connect/connect_test_package.cc | 2 +- .../tests/connect/connect_test_singleton_app.cc | 2 +- services/service_manager/tests/lifecycle/BUILD.gn | 10 ++-- services/service_manager/tests/lifecycle/app.cc | 2 +- .../service_manager/tests/lifecycle/package.cc | 2 +- services/service_manager/tests/lifecycle/parent.cc | 2 +- .../service_manager/tests/service_manager/BUILD.gn | 6 +-- .../tests/service_manager/embedder.cc | 2 +- .../tests/service_manager/target.cc | 2 +- services/service_manager/tests/shutdown/BUILD.gn | 6 +-- .../tests/shutdown/shutdown_client_app.cc | 2 +- .../tests/shutdown/shutdown_service_app.cc | 2 +- services/video_capture/BUILD.gn | 4 +- services/video_capture/service_main.cc | 2 +- services/viz/BUILD.gn | 4 +- services/viz/main.cc | 2 +- services/ws/ime/test_ime_driver/BUILD.gn | 4 +- services/ws/ime/test_ime_driver/main.cc | 2 +- services/ws/test_ws/BUILD.gn | 4 +- services/ws/test_ws/test_ws.cc | 2 +- 68 files changed, 218 insertions(+), 278 deletions(-) commit ea1f3ca634e14da91834869c7aa4e9922a8448f0 Author: khmel@chromium.org <khmel@chromium.org> Date: Tue Dec 11 02:40:12 2018 +0000 arc: Extend autotest private API for ARC app launcher. This adds set of new function to autotest API related to ARC app launcher in order to be able to write comprehensive autotests that are closer what actual user does for ARC. TEST=Together with crrev.com/i/727872. Extra browser tests added. BUG=b:120623980 BUG=b:120280395 Change-Id: Iac747f811a1f2d9f59a62a417e2cb2d77a593ea5 Reviewed-on: https://chromium-review.googlesource.com/c/1368825 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615395} .../autotest_private/autotest_private_api.cc | 141 ++++++++++++++++++++- .../autotest_private/autotest_private_api.h | 40 ++++++ .../autotest_private/autotest_private_apitest.cc | 39 +++++- chrome/common/extensions/api/autotest_private.idl | 46 +++++++ .../extensions/api_test/autotest_private/test.js | 122 ++++++++++++++++-- .../browser/extension_function_histogram_value.h | 4 + tools/metrics/histograms/enums.xml | 4 + 7 files changed, 384 insertions(+), 12 deletions(-) commit cb81f8aec78b746cef4a6fa91ebf3ab4b12ace73 Author: Erik Luo <luoe@chromium.org> Date: Tue Dec 11 02:37:53 2018 +0000 DevTools: do not hide dialog on Esc with modifiers Users expect pressing 'Escape' to hide dialogs in DevTools, except when used with another modifier, e.g. 'Shift-Esc'. Bug: 854548 Change-Id: I33f5052c44c70cacd2a4197161a502ac9c69fcee Reviewed-on: https://chromium-review.googlesource.com/c/1366485 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615394} third_party/blink/renderer/devtools/front_end/ui/Dialog.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit f3aa4e7567483fb1a4d494134ef90f0bd141b835 Author: Regan Hsu <hsuregan@chromium.org> Date: Tue Dec 11 02:37:49 2018 +0000 [CrOS MultiDevice] Remove kMultiDevice API flags from smart lock code. Removing kMultiDevice flags and associated code paths that will no longer occur. Bug: 912743 Change-Id: Iabb917876b570b8df953f22a30eb05787a5ef1ef Reviewed-on: https://chromium-review.googlesource.com/c/1370485 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#615393} .../easy_unlock/chrome_proximity_auth_client.cc | 44 ----- .../easy_unlock/chrome_proximity_auth_client.h | 19 -- .../easy_unlock/easy_unlock_service_regular.cc | 192 +++------------------ .../easy_unlock/easy_unlock_service_regular.h | 25 --- .../easy_unlock_service_signin_chromeos.cc | 17 +- .../proximity_auth/mock_proximity_auth_client.cc | 5 - .../proximity_auth/mock_proximity_auth_client.h | 9 - .../proximity_auth/proximity_auth_client.h | 24 --- 8 files changed, 29 insertions(+), 306 deletions(-) commit 2b74dd4c029c3244b0c45b954c62251b13bcd8b4 Author: Eric Roman <eroman@chromium.org> Date: Tue Dec 11 02:35:39 2018 +0000 Use NetLogStringValue() in place of EscapeExternalHandlerValue(). Bug: 657115 Change-Id: I70526b30ea51fe77343d1e8783cc01cc84a4c68e Reviewed-on: https://chromium-review.googlesource.com/c/1369005 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615392} net/spdy/header_coalescer.cc | 10 +++++----- net/spdy/header_coalescer_test.cc | 9 +++++---- 2 files changed, 10 insertions(+), 9 deletions(-) commit c302f5a91fc2c7b136684dad112683b348fcd392 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:28:52 2018 +0000 Roll src/third_party/angle 149eb33bb49f..f5c88e7e1c1a (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/149eb33bb49f..f5c88e7e1c1a git log 149eb33bb49f..f5c88e7e1c1a --date=short --no-merges --format='%ad %ae %s' 2018-12-11 jmadill@chromium.org Refactor and inline DrawElements validation. Created with: gclient setdep -r src/third_party/angle@f5c88e7e1c1a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Id37a1c48477c00e1fd96feab087f6c8c52a1ff91 Reviewed-on: https://chromium-review.googlesource.com/c/1371188 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615391} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit caaa683015faaf885bee462ad07e43063bb8b421 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 02:27:22 2018 +0000 Roll src-internal ddee6ce9c58a..7f98851124b4 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddee6ce9c58a..7f98851124b4 Created with: gclient setdep -r src-internal@7f98851124b4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:889221 TBR=mmoss@chromium.org Change-Id: Id4d6a4f17c58d47d1568e5a7ebb3f3d4d37cbac0 Reviewed-on: https://chromium-review.googlesource.com/c/1371184 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615390} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 754de5c68be65866470be5fa1771f45c04f1080f Author: Tina Wang <tinazwang@chromium.org> Date: Tue Dec 11 02:26:07 2018 +0000 Fixed thumbnails overlapping when zoom out the page Setting the max height of the title container, so the title container won't change size while zooming out. Screenshots: https://screenshot.googleplex.com/7EO54hxQi5N https://screenshot.googleplex.com/kiDgYGzWrW9 https://screenshot.googleplex.com/uEgd1xRDOF4 Bug: 912861 Change-Id: I4f49488965584b8bef0f0203b7e4291df967e706 Reviewed-on: https://chromium-review.googlesource.com/c/1368591 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#615389} chrome/browser/resources/local_ntp/most_visited_single.css | 2 ++ 1 file changed, 2 insertions(+) commit 01ced2e366033bdfe16cdafe7386dc97d87255e8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:21:37 2018 +0000 Roll src/third_party/perfetto faae590fff1a..53a0082b847f (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/faae590fff1a..53a0082b847f git log faae590fff1a..53a0082b847f --date=short --no-merges --format='%ad %ae %s' 2018-12-11 fmayer@google.com Merge "Find src directory in same directory as fuzzer." Created with: gclient setdep -r src/third_party/perfetto@53a0082b847f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ic6eaa7e7f2d57961e3a43dd1a5ed0514e5a4fee6 Reviewed-on: https://chromium-review.googlesource.com/c/1370649 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615388} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 267428faed554af30b9f1193ce5447f0750621da Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Dec 11 02:21:05 2018 +0000 Reland "Remove WaitSyncTokenCHROMIUM command" This reverts commit c19106d109d4d36871c11bfb5a683d222583dd15. Original change's description: > Remove WaitSyncTokenCHROMIUM command > > After migrating InProcessCommandBuffer to use GPU scheduler, most tasks > are scheduled after their sync token dependencies are satisifed (see > crrev.com/c/1157874). > > The one exception was the WaitSyncToken IPC used by ReturnFrontBuffer > for pepper, which specifies a sync token, and waits while handling the > message. > > Change ReturnFrontBuffer to contain the sync token, and use it to > specify the dependency to the scheduler. > > Remove WaitSyncTokenCHROMIUM command, since sync token dependencies are > specified as task metadata in all cases. > > Make other cleanups such as removing unnecessary sync token tests, and > make sure the sync token code paths are not used where unsupported by > using NOTREACHED. > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: Ieee4f6e2427a59a4e0c4b3c983cb489741241272 > Bug: 778753 > Reviewed-on: https://chromium-review.googlesource.com/c/1168155 > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599849} Bug: 778753, 895984 TBR=dcheng@chromium.org,boliu@chromium.org,piman@chromium.org Change-Id: I07943fdcbb131566718d51e78f134975ec53b62e Reviewed-on: https://chromium-review.googlesource.com/c/1361870 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615387} .../browser/deferred_gpu_command_service.cc | 8 -- .../browser/deferred_gpu_command_service.h | 1 - gpu/BUILD.gn | 1 - gpu/command_buffer/build_gles2_cmd_buffer.py | 7 +- gpu/command_buffer/build_raster_cmd_buffer.py | 7 +- gpu/command_buffer/client/client_test_helper.h | 2 +- .../client/gles2_cmd_helper_autogen.h | 10 -- gpu/command_buffer/client/gles2_implementation.cc | 7 +- .../client/gles2_implementation_unittest.cc | 5 +- gpu/command_buffer/client/gpu_control.h | 8 +- .../client/raster_cmd_helper_autogen.h | 10 -- gpu/command_buffer/client/raster_implementation.cc | 9 +- .../client/raster_implementation_unittest.cc | 5 +- .../common/gles2_cmd_format_autogen.h | 67 ---------- .../common/gles2_cmd_format_test_autogen.h | 15 --- gpu/command_buffer/common/gles2_cmd_ids_autogen.h | 121 +++++++++--------- .../common/raster_cmd_format_autogen.h | 69 ----------- .../common/raster_cmd_format_test_autogen.h | 35 +++--- gpu/command_buffer/common/raster_cmd_ids_autogen.h | 29 +++-- .../service/command_buffer_direct.cc | 97 +-------------- gpu/command_buffer/service/command_buffer_direct.h | 21 ---- gpu/command_buffer/service/decoder_client.h | 10 -- gpu/command_buffer/service/gles2_cmd_decoder.cc | 28 ----- .../service/gles2_cmd_decoder_passthrough_doers.cc | 9 -- .../gles2_cmd_decoder_passthrough_handlers.cc | 25 ---- .../service/gles2_cmd_decoder_unittest_base.cc | 6 - .../service/gles2_cmd_decoder_unittest_base.h | 2 - .../service/memory_program_cache_unittest.cc | 1 - .../service/passthrough_program_cache_unittest.cc | 1 - .../service/program_manager_unittest.cc | 1 - .../raster_cmd_validation_implementation_autogen.h | 7 +- gpu/command_buffer/service/raster_decoder.cc | 28 ----- .../service/raster_decoder_unittest.cc | 1 - .../service/raster_decoder_unittest_base.cc | 3 - .../service/raster_decoder_unittest_base.h | 1 - gpu/command_buffer/tests/decoder_perftest.cc | 30 ++--- gpu/command_buffer/tests/fuzzer_main.cc | 7 +- gpu/command_buffer/tests/gl_fence_sync_unittest.cc | 91 -------------- gpu/command_buffer/tests/gl_manager.cc | 40 +++--- gpu/command_buffer/tests/gl_manager.h | 9 +- gpu/gles2_conform_support/egl/context.cc | 29 +++-- gpu/gles2_conform_support/egl/context.h | 2 +- gpu/ipc/client/command_buffer_proxy_impl.cc | 18 +-- gpu/ipc/client/command_buffer_proxy_impl.h | 8 +- gpu/ipc/client/gpu_channel_host.cc | 3 +- gpu/ipc/command_buffer_task_executor.h | 7 -- gpu/ipc/common/gpu_messages.h | 9 +- gpu/ipc/gpu_in_process_thread_service.cc | 11 -- gpu/ipc/gpu_in_process_thread_service.h | 1 - gpu/ipc/in_process_command_buffer.cc | 91 +++++--------- gpu/ipc/in_process_command_buffer.h | 9 +- gpu/ipc/service/command_buffer_stub.cc | 56 +++------ gpu/ipc/service/command_buffer_stub.h | 9 +- gpu/ipc/service/gles2_command_buffer_stub.cc | 2 + gpu/ipc/service/gpu_channel.cc | 135 ++++++++++++--------- ppapi/proxy/ppapi_command_buffer_proxy.cc | 17 +-- ppapi/proxy/ppapi_command_buffer_proxy.h | 2 +- 57 files changed, 312 insertions(+), 931 deletions(-) commit be6bec8d74c853d83e9afea2d192d9d1fa463264 Author: dpapad <dpapad@chromium.org> Date: Tue Dec 11 02:18:54 2018 +0000 WebUI: Fix flaky <managed-footnote> tests. The test flakes because of PolymerTest.testIronIcons() which is problematic in multiple ways: 1) It only works with Shadom DOM v0 (tracked by https://crbug.com/885401) 2) It suffers from timing issues, where the iron-icon being checked has not been fully populated yet (for example missing the internal <svg> element by the time the check occurs). Clearing the DOM in teardown() works around the problem by effectively making testIronIcons() a no-op for this test. Bug: 913708 Change-Id: I643f2cf457e7bd2f3f4056452f7ccce308556972 Reviewed-on: https://chromium-review.googlesource.com/c/1371083 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615386} chrome/test/data/webui/cr_components/managed_footnote_test.js | 4 ++++ 1 file changed, 4 insertions(+) commit c1ec9a691e6699c6bd09b5ac8b093108f51483b8 Author: Jason Guo <jiahuiguo@chromium.org> Date: Tue Dec 11 02:17:57 2018 +0000 [M72][Paradise] Add checkbox uncheck warning text on the migration dialog per UX requirements. Bug: 897998 Change-Id: Id68513c6ad568767359d40f09b7a71abefc7118a Reviewed-on: https://chromium-review.googlesource.com/c/1361708 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615385} .../autofill/local_card_migration_dialog_view.cc | 5 ++ .../autofill/local_card_migration_dialog_view.h | 1 + .../ui/views/autofill/migratable_card_view.cc | 96 +++++++++++++++++----- .../ui/views/autofill/migratable_card_view.h | 7 ++ components/autofill_strings.grdp | 3 + 5 files changed, 90 insertions(+), 22 deletions(-) commit 630f1690aac12a8a96b9e4edccae8718834c3a68 Author: Eugene But <eugenebut@google.com> Date: Tue Dec 11 02:11:07 2018 +0000 Fix external file presentation. This bug is a regression, because ios/web started presenting error pages if hasControllerForURL: returns NO and the URL is not a WebUI URL. ios/web change was a reasonable change, but BVC did not follow API contract and returned NO from hasControllerForURL: even if controller existed. Return YES from hasControllerForURL: for kChromeUIExternalFileHost if NativeController actually exists. This change enforces existing API constract for CRWNativeContentProvider. EG tests do not have good infrastructure to write end-to-end test for external URLs. BVC is also not testable, so this CL does not include tests. Bug: 902271 Change-Id: I81c08b439460bcbf81f0e7234f9cdbe57938e6fe Reviewed-on: https://chromium-review.googlesource.com/c/1370931 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#615384} ios/chrome/browser/ui/browser_view_controller.mm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 8eed09b1ff9a59c6cc6e0386aa40dddffdcefe3a Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Dec 11 02:10:43 2018 +0000 Use config specified aspect ratio in D3D11VideoDecoder Other decoder implementations (VDA, ffmpeg, etc.) use the aspect ratio from the config when setting natural size of video frames. Duplicate the logic from VDA to D3D11VideoDecoder. Found due to failing Pixel_Video_MP4_FourColors_Aspect_4x3 test in CL to enable D3D11VideoDecoder (and decode swap chain) on waterfall: https://chromium-review.googlesource.com/c/chromium/src/+/1364341 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win7_chromium_rel_ng/145995 Bug: 837337 Change-Id: I54a3928646f6d71dec26e9995efe4eb7bda458d7 Reviewed-on: https://chromium-review.googlesource.com/c/1368774 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615383} media/gpu/windows/d3d11_video_decoder.cc | 23 +++++++++++++---------- media/gpu/windows/d3d11_video_decoder.h | 2 +- 2 files changed, 14 insertions(+), 11 deletions(-) commit b5d9dcabf36d4dbb656ed731c4b1934085d966d2 Author: Shu Chen <shuchen@google.com> Date: Tue Dec 11 02:08:03 2018 +0000 Alow French BEPO keyboard for login/lock screen. Bug: 910036 Change-Id: If84c2e82863edc2057c46e81ad1feb35a86e4a53 Reviewed-on: https://chromium-review.googlesource.com/c/1370155 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615382} ui/base/ime/chromeos/component_extension_ime_manager.cc | 1 + 1 file changed, 1 insertion(+) commit 7e802b3ba3cec408e97bdec7527be095d4e0af8c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 02:01:49 2018 +0000 Roll src/third_party/catapult 60a61e85fed1..74c92bb22076 (1 commits) https://chromium.googlesource.com/catapult.git/+log/60a61e85fed1..74c92bb22076 git log 60a61e85fed1..74c92bb22076 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 benjhayden@chromium.org Add SparseDiagnostic index for _FindOrInsertDiagnosticsOutOfOrder Created with: gclient setdep -r src/third_party/catapult@74c92bb22076 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:906685 TBR=sullivan@chromium.org Change-Id: I4195a550775a54f26d803d6c4c7350be20f692f0 Reviewed-on: https://chromium-review.googlesource.com/c/1370984 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615381} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 22363333c25c9f1751fa2322a0b42331063c9a3d Author: Melissa Zhang <melzhang@google.com> Date: Tue Dec 11 02:00:13 2018 +0000 Implement App Struct and Pass Apps to AppManagement This CL defines the app struct and gives apps from the user's profile to AppManagement. It also informs the AppManagement UI of any updates to apps, including uninstallation. BUG=906508 Change-Id: I20f1483563d8252c1060212dbbfd9cb9d560f790 Reviewed-on: https://chromium-review.googlesource.com/c/1365090 Commit-Queue: Melissa Zhang <melzhang@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#615380} chrome/browser/BUILD.gn | 3 +- chrome/browser/browser_resources.grd | 25 ++++--- chrome/browser/resources/app_management/BUILD.gn | 84 ++++++++++++---------- .../resources/app_management/browser_proxy.html | 5 ++ chrome/browser/ui/BUILD.gn | 3 +- chrome/browser/ui/webui/DEPS | 1 + chrome/browser/ui/webui/app_management/BUILD.gn | 4 ++ .../ui/webui/app_management/app_management.mojom | 20 +++++- .../app_management/app_management_page_handler.cc | 35 ++++++++- .../app_management/app_management_page_handler.h | 11 ++- .../ui/webui/app_management/app_management_ui.cc | 10 +++ .../ui/webui/chrome_web_ui_controller_factory.cc | 2 +- .../bindings/generators/mojom_js_generator.py | 20 +++--- 13 files changed, 159 insertions(+), 64 deletions(-) commit 5c6efdbd991f7c25ad9f47a6fdda6367d6707dbf Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Dec 11 01:57:45 2018 +0000 Update V8 to version 7.3.81. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2ee9340..09253406 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7af414e692d261a6dfe48f734f5c4309e0b47ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1371018 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615379} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 01bec8133c691c8eeb0fea9baa6f82abbacf628c Author: Ned Nguyen <nednguyen@google.com> Date: Tue Dec 11 01:56:02 2018 +0000 Add pool dimension for linux-perf-fyi tests Bug: 913625 Change-Id: I6d9f28e374b1751afcdd2ffb40d03d3c8ee87434 Reviewed-on: https://chromium-review.googlesource.com/c/1370495 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#615378} testing/buildbot/chromium.perf.fyi.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 2695c291212a60adb91e7ec0aeff215241ea7479 Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Dec 11 01:50:04 2018 +0000 DelayedIncomingQueue::SweepCancelledTasks to operate in place We've had some OOMs in SweepCancelledTasks because it was hamstrung by the std::priority_queue API. Here we take advantage of the fact the queue is backed by a std::vector and that it's a heap in order to efficently remove canceled tasks in place. This should fix OOMs caused by SweepCancelledTasks. Bug: 912541 Change-Id: I4bfce9dc399dd90bce90e03e76db38171a575278 Reviewed-on: https://chromium-review.googlesource.com/c/1369780 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615377} .../sequence_manager_impl_unittest.cc | 37 +++++++++++++ base/task/sequence_manager/task_queue_impl.cc | 62 ++++++++++------------ base/task/sequence_manager/task_queue_impl.h | 11 +++- 3 files changed, 74 insertions(+), 36 deletions(-) commit f576f392eafe6cb7541e8b9698ad42197a3b67d3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 01:50:01 2018 +0000 Roll src/third_party/chromite 24c806768f57..6d522d4fe25f (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/24c806768f57..6d522d4fe25f git log 24c806768f57..6d522d4fe25f --date=short --no-merges --format='%ad %ae %s' 2018-12-10 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@6d522d4fe25f The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8860cb66e3dbb0447ee16e076f06449637a5dada Reviewed-on: https://chromium-review.googlesource.com/c/1370648 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615376} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 98b8843c81184ec4be690ceb5fd1382b05842ef2 Author: Megan Jablonski <megjablon@google.com> Date: Tue Dec 11 01:47:21 2018 +0000 Fix Lite mode translation error Bug: 912813 Change-Id: Id2e9fc4ff9ab2f525c8717ad827841900f3145dd Reviewed-on: https://chromium-review.googlesource.com/c/1370929 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#615375} chrome/android/java/strings/android_chrome_strings.grd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 234c90912ed41094328ae5cfa98ec846fc30721a Author: Christian Biesinger <cbiesinger@chromium.org> Date: Tue Dec 11 01:46:59 2018 +0000 Add perf test for contain: contents Adds the testcase from crbug.com/667370 as a perf test, so we can track improvements to it. R=chrishtr@chromium.org Bug: 667370 Change-Id: I5b9a4854b21de4fc26a5f515154a93d9148890ef Reviewed-on: https://chromium-review.googlesource.com/c/1357543 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#615374} .../layout/contain-content-style-change.html | 58 ++++++++++++++++++++++ 1 file changed, 58 insertions(+) commit 85061cd6a7533cf84232fa06e1ec3ef5437a17c1 Author: danakj <danakj@chromium.org> Date: Tue Dec 11 01:45:54 2018 +0000 Disable flaky ChromeVOX tests. Flaky as per https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjg3NDYwNzljMDQ1NmQzYjQwOTFlN2QwNmZkMDU4NTY2OTFhNWJiNww TBR=dmazzoni@chromium.org Change-Id: I4428d1fbc78a8c06f099b5ee99c21fbe433af82e Bug: 622387 Reviewed-on: https://chromium-review.googlesource.com/c/1371105 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615373} .../chromeos/chromevox/chromevox/injected/event_watcher_test.unitjs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit d080cfa6b2816045a60cc2d16d2bf67ff1c15d8a Author: Dana Fried <dfried@chromium.org> Date: Tue Dec 11 01:45:33 2018 +0000 Move toolbar to new FlexLayout, demonstrating new layout manager. Vastly simplifies layout in the toolbar and makes it mostly declarative with a single init function, rather than complex, bespoke - and sometimes incorrect - Layout(), GetMinimumSize(), etc. methods. Because of a logical change in the way the UI works when an extension is uninstalled, we uncovered a possible read-after-free in the extension install UI (shows up in some ASAN tests). So we plumbed the scoped_refptr through from crx_installer to the UI so that the memory would be valid until the bubble is closed. See parent CL for FlexLayout details and future work. Bug: 898632 Change-Id: I2cfe5b6119dc2886f88ae12675f8184cf90d56fd Reviewed-on: https://chromium-review.googlesource.com/c/1331041 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#615372} chrome/browser/extensions/crx_installer.cc | 2 +- .../extensions/crx_installer_browsertest.cc | 3 +- .../browser/extensions/extension_install_prompt.cc | 17 +- .../browser/extensions/extension_install_prompt.h | 7 +- .../ui/extensions/extension_install_ui_default.cc | 14 +- .../ui/extensions/extension_install_ui_default.h | 2 +- .../ui/extensions/extension_installed_bubble.cc | 22 +- .../ui/extensions/extension_installed_bubble.h | 13 +- chrome/browser/ui/toolbar/toolbar_actions_bar.cc | 7 +- .../ui/views/location_bar/location_bar_view.cc | 3 +- .../tabs/tab_drag_controller_interactive_uitest.cc | 13 +- .../ui/views/toolbar/browser_actions_container.cc | 45 +++- .../ui/views/toolbar/browser_actions_container.h | 16 +- .../ui/views/toolbar/browser_app_menu_button.cc | 19 +- .../ui/views/toolbar/browser_app_menu_button.h | 5 +- chrome/browser/ui/views/toolbar/toolbar_button.cc | 19 +- chrome/browser/ui/views/toolbar/toolbar_button.h | 8 +- chrome/browser/ui/views/toolbar/toolbar_view.cc | 263 +++++++-------------- chrome/browser/ui/views/toolbar/toolbar_view.h | 23 +- .../api_test/window_update/sizing/test.js | 2 +- extensions/browser/install/extension_install_ui.h | 6 +- 21 files changed, 237 insertions(+), 272 deletions(-) commit c8c2769f4dd8c5761af90b3a39529c338c149257 Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Tue Dec 11 01:38:37 2018 +0000 Handle the release of sync tokens for image decode acceleration. This CL adds code to make the gpu::ImageDecodeAcceleratorStub use the gpu::Scheduler to release decode sync tokens when a decode is completed. A new interface is created, ImageDecodeAcceleratorWorker, which will eventually be implemented to carry out the actual hardware decode. Upon receiving an IPC request, the ImageDecodeAcceleratorStub does the following: 1) Schedule a task in the GPU scheduler to release the decode sync token. This task, encapsulated by the ProcessCompletedDecode() method, is not run until the decode completes. 2) Ask the ImageDecodeAcceleratorWorker to do the actual decode. Upon completion, the worker calls the OnCompletedDecode() method which enables the scheduler sequence so that the task created in (1) can run. Test: created unit tests for the added behavior. Bug: 868400 Change-Id: I562ed5a81badca578acb468864f67942eacf2f43 Reviewed-on: https://chromium-review.googlesource.com/c/1355528 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#615371} components/viz/service/gl/gpu_service_impl.cc | 3 +- gpu/BUILD.gn | 2 + gpu/command_buffer/service/scheduler.cc | 8 +- gpu/ipc/service/BUILD.gn | 3 +- gpu/ipc/service/gpu_channel.cc | 9 +- gpu/ipc/service/gpu_channel.h | 4 +- gpu/ipc/service/gpu_channel_manager.cc | 11 +- gpu/ipc/service/gpu_channel_manager.h | 7 + gpu/ipc/service/gpu_channel_test_common.cc | 3 +- gpu/ipc/service/gpu_channel_test_common.h | 7 +- gpu/ipc/service/image_decode_accelerator_stub.cc | 114 ++++++++- gpu/ipc/service/image_decode_accelerator_stub.h | 38 ++- .../image_decode_accelerator_stub_unittest.cc | 281 +++++++++++++++++++++ gpu/ipc/service/image_decode_accelerator_worker.h | 38 +++ 14 files changed, 504 insertions(+), 24 deletions(-) commit 7c679720af6e8a2451705abf1acdcd7fe080c5a6 Author: dpapad <dpapad@chromium.org> Date: Tue Dec 11 01:37:03 2018 +0000 WebUI: Enable no-var and prefer-const ESLint rules for most folders. Specifically: - Update chrome/browser/resources/.eslintrc.js to have the desired ESLint checks. - Explicitly override the default checks for folders that still have plenty of violations (bluetooth_internals/, chromeos/, cryptotoken/, local_ntp/, media_router/) Bug: 792774,720034 Change-Id: I505b9ce7773bb706c47757447260630a3c4a38b1 Reviewed-on: https://chromium-review.googlesource.com/c/1357531 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615370} .../{chromeos/multidevice_setup => }/.eslintrc.js | 5 +---- .../{md_downloads => bluetooth_internals}/.eslintrc.js | 7 ++----- .../browser/resources/{discards => chromeos}/.eslintrc.js | 7 ++----- chrome/browser/resources/chromeos/chromevox/.eslintrc.js | 4 ---- .../resources/chromeos/select_to_speak/.eslintrc.js | 1 - .../browser/resources/chromeos/switch_access/.eslintrc.js | 1 - .../resources/{md_history => cryptotoken}/.eslintrc.js | 7 ++----- chrome/browser/resources/eoc_internals/.eslintrc.js | 13 ------------- .../resources/{md_bookmarks => local_ntp}/.eslintrc.js | 7 ++----- chrome/browser/resources/management/.eslintrc.js | 13 ------------- chrome/browser/resources/md_user_manager/.eslintrc.js | 13 ------------- .../resources/{md_extensions => media_router}/.eslintrc.js | 7 ++----- chrome/browser/resources/omnibox/.eslintrc.js | 13 ------------- chrome/browser/resources/pdf/.eslintrc.js | 14 -------------- chrome/browser/resources/print_preview/.eslintrc.js | 13 ------------- chrome/browser/resources/settings/.eslintrc.js | 13 ------------- chrome/browser/resources/snippets_internals/.eslintrc.js | 13 ------------- .../resources/welcome/onboarding_welcome/.eslintrc.js | 13 ------------- 18 files changed, 11 insertions(+), 153 deletions(-) commit 41a1fad4c04e0c753656e710a06d38cae263bcef Author: Bruce Dawson <brucedawson@chromium.org> Date: Tue Dec 11 01:36:32 2018 +0000 Fix ucrt redist path Recent versions of the 10.0.17763 SDK have rearranged the redist directory where we find the UCRT DLLs. This change updates the toolchain script so that it looks in the new (versioned) directory first, and falls back to the old unversioned directory if that doesn't work. Without this change we still soon start seeing build failures when using the locally installed toolchain on clean installs. See also http://crrev.com/c/1370609 for the depot tools packaging version of this change. Change-Id: If9144b42838b0537f6159b34e0a84eda30a85548 Reviewed-on: https://chromium-review.googlesource.com/c/1371017 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615369} build/vs_toolchain.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit e70927a7e223b3df1a32ab319cab446588b958b6 Author: Matt Wolenetz <wolenetz@chromium.org> Date: Tue Dec 11 01:34:48 2018 +0000 MSE: Relax expectations for init segment and parsing when fuzzing Adds a PipelineIntegrationTestBase kDemuxerMayPassOrFail test type and conditions expectations of MSE pipeline interactions on that flag: allow any number of init segment received callbacks (including none) to occur during the parse. Also changes the boolean MockMediaSource expect_append_success_ to an enum with a third value of kSuccessOrFailure to allow either append success or failure to not fail the mock's related assertions. These allow suppressing two kinds of spurious gtest failures and stack trace outputs during fuzzing of scenarios that can include a variety of parse inputs (not all well-formed). BUG=894460 TEST=A locally concocted fuzzer case which fails to append successfully and which doesn't ever emit an initialization segment received callback no longer emits stack traces or gtest expectation or assertion failures Change-Id: I2afd3bec01f1c0b194cfa6fc7d8644f88420df2d Reviewed-on: https://chromium-review.googlesource.com/c/1371020 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615368} media/test/mock_media_source.cc | 13 ++++++++++--- media/test/mock_media_source.h | 14 +++++++++++--- media/test/pipeline_integration_fuzzertest.cc | 10 +++++++++- media/test/pipeline_integration_test.cc | 9 ++++++--- media/test/pipeline_integration_test_base.cc | 4 +++- media/test/pipeline_integration_test_base.h | 1 + 6 files changed, 40 insertions(+), 11 deletions(-) commit a30eb958a93f6f19086b40c008316c6be1bcddfa Author: agrieve <agrieve@chromium.org> Date: Tue Dec 11 01:33:16 2018 +0000 Revert "Android: Use d8's desugaring for debug" This reverts commit 54ab13b87d886318f8b443c5d675375587e2ab12. Reason for revert: Broke cronet_smoketests_platform_only_instrumentation_apk (see bug) Original change's description: > Android: Use d8's desugaring for debug > > Rather than using desugar.jar, simply fold desugaring into the dexing > step. This works for debug and we may try it with release builds later, > but since release builds take much longer anyways, it's not as urgent. > > Estimated savings: ~3.9s > > Change-Id: I34b968ff1080c5238e41fe88864de9f2c7452da3 > Bug: 906803 > Reviewed-on: https://chromium-review.googlesource.com/c/1362101 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: agrieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615234} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: Ib1a1f7efb89b6f766b9d0589d12d3cf38a02f7ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906803, 913679 Reviewed-on: https://chromium-review.googlesource.com/c/1371191 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615367} build/android/gyp/dex.py | 20 +------------------- build/config/android/internal_rules.gni | 20 +------------------- 2 files changed, 2 insertions(+), 38 deletions(-) commit 0cbbe6d5f8d991a55bfaefdb10f08b0e151e4407 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Dec 11 01:28:52 2018 +0000 Make invalid WebUI requests fail before HeadersComplete Current behavior is to call NotifyHeadersComplete, which makes the request succeed. It only fails later while delivering the data (which is nullptr already). This has a side-effect: navigation to such an invalid url is treated as a success on the browser side, which is different from regular urls. Fixing it in turn exposed two bugs: - UrlDataManagerBackendTest used non-existing resource, which now results in a navigation failure. Changed it to use an existing resource. - Android WebView was not able to fetch safe_browsing_ui resources because of the missing GetDataResourceBytes implementation. Existing tests tried to navigate to these resources and navigation succeeded, while the resource itself was not available and loading failed later in the pipeline. Added the missing function to AwContentClient. Bug: 855189 Change-Id: I078794601a4fef09e835fddd8a1a2f903a34a8d9 Reviewed-on: https://chromium-review.googlesource.com/c/1364223 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615366} android_webview/common/aw_content_client.cc | 6 ++++++ android_webview/common/aw_content_client.h | 1 + .../ui/webui/chrome_url_data_manager_browsertest.cc | 16 +++++++++++++++- content/browser/webui/url_data_manager_backend.cc | 6 ++++++ .../browser/webui/url_data_manager_backend_unittest.cc | 5 ++--- 5 files changed, 30 insertions(+), 4 deletions(-) commit 8b0688262b28a8d9a674e3d86059e87612c17ff4 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Dec 11 01:25:56 2018 +0000 Fix VolumeEntry createReader when root entry isn't resolved Bug: 913375 Change-Id: Ic147f0523c0183f4ede2c536d60095d6a5ff08be Reviewed-on: https://chromium-review.googlesource.com/c/1370227 Reviewed-by: Stuart Langley <slangley@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615365} .../common/js/files_app_entry_types.js | 5 ++- .../common/js/files_app_entry_types_unittest.js | 42 ++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) commit c29ac50a0cfcdcdf014c1be6f33ba197bdf94b42 Author: David Black <dmblack@google.com> Date: Tue Dec 11 01:24:25 2018 +0000 Create AssistantAlarmTimerModel. Adds a model to AssistantAlarmTimerController to track alarm/timer state and notify a pool of observers. Bug: b:119688929 Change-Id: I1ed33836872470b383e4d15a45a9e1cf774df746 Reviewed-on: https://chromium-review.googlesource.com/c/1345089 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615364} ash/BUILD.gn | 3 + ash/assistant/assistant_alarm_timer_controller.cc | 64 ++++++++++++++++---- ash/assistant/assistant_alarm_timer_controller.h | 24 +++++++- ash/assistant/model/assistant_alarm_timer_model.cc | 70 ++++++++++++++++++++++ ash/assistant/model/assistant_alarm_timer_model.h | 65 ++++++++++++++++++++ .../model/assistant_alarm_timer_model_observer.h | 43 +++++++++++++ 6 files changed, 256 insertions(+), 13 deletions(-) commit a9da525a3ad075bde0ba99914179e8bbf0b14469 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Tue Dec 11 01:20:30 2018 +0000 [AppCache] Fix first_party_url_ DCHECK. An empty first_party_url_ is a perfectly valid value, so equating it with the field being not set does not make much sense. Instead add a separate dcheck-only bool to track wether we've set it yet. Bug: 843797 Change-Id: Ifa114e4fc3a54c6950d0a58e961a51d6994e8285 Reviewed-on: https://chromium-review.googlesource.com/c/1371009 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615363} content/browser/appcache/appcache_host.cc | 7 +++++- content/browser/appcache/appcache_host.h | 25 ++++++++-------------- content/browser/appcache/appcache_host_unittest.cc | 4 ++-- .../appcache/appcache_storage_impl_unittest.cc | 2 +- .../appcache/appcache_update_job_unittest.cc | 2 +- 5 files changed, 19 insertions(+), 21 deletions(-) commit 7f0981084e492e08440d56736c759f65dde81cab Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Dec 11 01:14:45 2018 +0000 Files app: Fix Downloads icon in File List Change Download icon in the File List to be the customized icon when MyFilesVolume is enabled. Move the icon overrides from DirectoryTree to FileType to be able to share between DirectoryTree and FileList. Add FileType unittest. Add tests of the FileType.getIcon function. Test: browser_tests --gtest_filter="FileManagerJsTest.FileType" Bug: 873539 Change-Id: Ie7c3562c069084c147c8e9bb59e0f105de8836c3 Reviewed-on: https://chromium-review.googlesource.com/c/1369752 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615362} .../chromeos/file_manager/file_manager_jstest.cc | 4 +++ ui/file_manager/file_manager/common/js/BUILD.gn | 9 +++++ .../file_manager/common/js/file_type.js | 28 ++++++++++++++-- .../file_manager/common/js/file_type_unittest.js | 39 ++++++++++++++++++++++ .../foreground/js/ui/directory_tree.js | 21 +----------- .../file_manager/foreground/js/ui/file_grid.js | 3 +- .../file_manager/foreground/js/ui/file_table.js | 4 ++- .../foreground/js/ui/file_table_list.js | 7 ++-- 8 files changed, 89 insertions(+), 26 deletions(-) commit d1f09384f3b92ce01f6ed59907bd089310a29aa3 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Dec 11 01:08:43 2018 +0000 Added checks to prune out redundant download updates Download file keeps sending us updates about its status in a loop even though the download can be in a paused state. Added a check to prune out these updates if there is no change to the bytes received. This will enable us to clean up the code to avoid the state-dependent AddObserver/RemoveObserver calls in the download observers such as DownloadController. Bug: 913085 Change-Id: I915de9d8f95ba5320529ddfe761404c008678576 Reviewed-on: https://chromium-review.googlesource.com/c/1368650 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615361} chrome/browser/android/download/download_controller.cc | 4 +--- components/download/internal/common/download_item_impl.cc | 3 +++ 2 files changed, 4 insertions(+), 3 deletions(-) commit f5f6190327a5c25f1a90377019001ce8772beb14 Author: John Budorick <jbudorick@chromium.org> Date: Tue Dec 11 01:07:42 2018 +0000 luci: add configuration for android_blink_rel. Also explicitly specifies the buildbot version for use by blink until the luci version is demonstrably stable. Bug: 731964 Change-Id: Id2f3cc170da1cc2d8546b7c8f0e81ab08d834eec Reviewed-on: https://chromium-review.googlesource.com/c/1369637 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615360} infra/config/global/cr-buildbucket.cfg | 5 +++++ infra/config/global/luci-milo.cfg | 2 +- third_party/blink/tools/blinkpy/common/config/builders.json | 1 + third_party/blink/tools/blinkpy/common/host_mock.py | 2 +- third_party/blink/tools/blinkpy/common/net/git_cl_unittest.py | 2 +- 5 files changed, 9 insertions(+), 3 deletions(-) commit 2689dca1949bbca47f56c079388dbfb399f7c753 Author: Regan Hsu <hsuregan@chromium.org> Date: Tue Dec 11 01:07:33 2018 +0000 [CrOS MultiDevice] Adjust DeviceType protos to work around Apiary issue. When making apiary calls to CryptAuth, the DeviceType value in DeviceClassifier is always being sent as UNKNOWN because the proto is not properly serialized. This CL changes the value in DeviceClassifier from DeviceType to string, and adds the proper conversion functions and integrates them in CryptAuth. Bug: 866154 Change-Id: Iba957a44189efdad2078c7e3b354225453f8917b Reviewed-on: https://chromium-review.googlesource.com/c/1362196 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#615359} .../services/device_sync/proto/cryptauth_api.proto | 11 ++--- chromeos/services/device_sync/proto/enum_util.cc | 49 ++++++++++++++++++++++ chromeos/services/device_sync/proto/enum_util.h | 17 ++++++++ .../cryptauth/cryptauth_client_impl_unittest.cc | 8 +++- .../cryptauth/cryptauth_device_manager_impl.cc | 11 +++-- .../cryptauth_device_manager_impl_unittest.cc | 7 +++- components/cryptauth/device_classifier_util.cc | 4 +- 7 files changed, 92 insertions(+), 15 deletions(-) commit 477bded16edfd03e404afe8864d32e88bac5ff3c Author: Joel Einbinder <einbinder@chromium.org> Date: Tue Dec 11 01:05:23 2018 +0000 DevTools: Protocol Monitor quality of life improvements Errors are now shown and highlighted in red. The filter bar now supports filtering without a category specified. Right Click -> Filter to show only messages with the same method name. Right Click -> Documentation to open the protocol documentation website. Change-Id: Id49b0bc81420de5658d46b9f86d07d0d13701289 Reviewed-on: https://chromium-review.googlesource.com/c/1370314 Commit-Queue: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#615358} .../front_end/protocol_monitor/ProtocolMonitor.js | 30 +++++++++++++++++++--- .../front_end/protocol_monitor/protocolMonitor.css | 5 ++++ .../renderer/devtools/front_end/ui/Toolbar.js | 15 +++-------- .../tracing/timeline-misc/timeline-filtering.js | 4 +-- 4 files changed, 38 insertions(+), 16 deletions(-) commit 6c30be45d7e9bd4a1f896d2906af9ccc2eb867cf Author: Pavel Feldman <pfeldman@chromium.org> Date: Tue Dec 11 01:04:22 2018 +0000 DevTools: surface the PWA installability warnings in the manifest view. Bug: 901352 Change-Id: Ide68cbab11d9599d3fe59aef274f12f429df346f Reviewed-on: https://chromium-review.googlesource.com/c/1370371 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615357} .../front_end/resources/AppManifestView.js | 49 +++++++++++++--------- 1 file changed, 29 insertions(+), 20 deletions(-) commit 6205ad09fc390adce5dd0a66a6e1e71348d1857a Author: Sky Malice <skym@google.com> Date: Tue Dec 11 01:01:41 2018 +0000 [Feed] Stop obfuscation of FeedRefreshTask class name. Bug: 913696 Change-Id: I29fe62f4022c464330385c9e6e4d3253f2f3273c Reviewed-on: https://chromium-review.googlesource.com/c/1370555 Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#615356} .../core/java/src/org/chromium/chrome/browser/feed/FeedRefreshTask.java | 2 ++ 1 file changed, 2 insertions(+) commit d5698f682d8b2742017df6c81e0bd8e6a3063189 Author: Christopher Cameron <ccameron@chromium.org> Date: Tue Dec 11 00:59:20 2018 +0000 Mac OOP-R GPU crashes: Add paint op instrumentation Save the current paint to a crash key while executing that op. The hope is that this will reveal a single op that is responsible for the vast majority of crashes. Remove old no-longer-needed instrumentation. Bug: 906453 Change-Id: I2bedc11b8bea0eea637b60cd8b89839ada08924e Reviewed-on: https://chromium-review.googlesource.com/c/1371007 Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615355} gpu/command_buffer/service/raster_decoder.cc | 43 ++++++++++------------ .../service/raster_decoder_unittest.cc | 4 -- 2 files changed, 20 insertions(+), 27 deletions(-) commit 28f86ce6b099dde8bfa78b8968772bd8c3ef9753 Author: Paul Wankadia <junyer@chromium.org> Date: Tue Dec 11 00:54:49 2018 +0000 Roll src/third_party/re2/src/ 749d64c35..f620af75b (3 commits) https://chromium.googlesource.com/external/github.com/google/re2.git/+log/749d64c35e09..f620af75bd69 $ git log 749d64c35..f620af75b --date=short --no-merges --format='%ad %ae %s' 2018-12-09 junyer Improve fuzzer coverage a little. 2018-11-22 junyer Make the NFA execution engine use Prog::EmptyFlags(). 2018-11-06 junyer Improve the "MATCHING WITH SUBSTRING EXTRACTION" comment again. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 0 Change-Id: I3f8db84994270634e9e45d135b662feb3264686d Reviewed-on: https://chromium-review.googlesource.com/c/1369764 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615354} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1a9264ddffb97e645ae936840846a741dfefee24 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Dec 11 00:52:48 2018 +0000 Re-enable video pixel tests after rebaselining The tests were marked as failing and version numbers were incremented in https://crrev.com/c/1182222, but I forgot to re-enable the tests. Bug: 869677, 913138, 858826, 819635, 774809 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7fdb28c3dbaa7aad4137b16d8f9bf8fe15fe9a08 Reviewed-on: https://chromium-review.googlesource.com/c/1214364 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615353} content/test/gpu/gpu_tests/pixel_expectations.py | 33 ++++++++++++------------ 1 file changed, 17 insertions(+), 16 deletions(-) commit c22d02669f1bcffd045fee5e6876760748ffb96c Author: John Delaney <johnidel@chromium.org> Date: Tue Dec 11 00:49:02 2018 +0000 Migrate PLM observers counting bytes to OnResourceDataUpdate Move observers recording these byte histograms to OnResourceDataUpdate instead of OnLoadedResource. OnResourceDataUpdate contains information on incomplete resources, and thus should be the interface for counting bytes moving forward. Bug: 894168 Change-Id: Ida8f79271af918a2778b0e06005884d3cf672222 Reviewed-on: https://chromium-review.googlesource.com/c/1302660 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615352} .../observers/core_page_load_metrics_observer.cc | 21 ++-- .../observers/core_page_load_metrics_observer.h | 6 +- .../core_page_load_metrics_observer_unittest.cc | 123 +++++---------------- .../observers/media_page_load_metrics_observer.cc | 17 +-- .../observers/media_page_load_metrics_observer.h | 5 +- .../media_page_load_metrics_observer_unittest.cc | 48 ++------ .../previews_page_load_metrics_observer.cc | 18 +-- .../previews_page_load_metrics_observer.h | 3 - ...previews_page_load_metrics_observer_unittest.cc | 111 ++++--------------- .../tab_restore_page_load_metrics_observer.cc | 17 +-- .../tab_restore_page_load_metrics_observer.h | 5 +- ..._restore_page_load_metrics_observer_unittest.cc | 47 ++------ .../test/page_load_metrics_test_util.cc | 37 ++++++- .../test/page_load_metrics_test_util.h | 22 +++- tools/metrics/histograms/histograms.xml | 35 ++++-- 15 files changed, 192 insertions(+), 323 deletions(-) commit 8cf31311ba541b7d9004de54c5e0f30ec9d82417 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Dec 11 00:46:31 2018 +0000 Roll src-internal 632d83f7f4d0..ddee6ce9c58a (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/632d83f7f4d0..ddee6ce9c58a Created with: gclient setdep -r src-internal@ddee6ce9c58a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I012bf52e803bb74549221aab1fea8b8c602769ad Reviewed-on: https://chromium-review.googlesource.com/c/1370987 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615351} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9d0831f91e0055dffa5092bd8515bccc6b6f1496 Author: Kent Tamura <tkent@chromium.org> Date: Tue Dec 11 00:42:21 2018 +0000 Rename some classes in blinkpy - LayoutTestResult -> WebTestResult - LayoutTestResults -> WebTestResults - LayoutTestFinder -> WebTestFinder - LayoutTestRunner -> WebTestRunner Bug: 843412 Change-Id: I656c7aba1edb6279e0197ff1b2f6323fac19e45d Reviewed-on: https://chromium-review.googlesource.com/c/1369553 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#615350} .../blink/tools/blinkpy/common/net/buildbot.py | 22 ++++++++++---------- .../tools/blinkpy/common/net/buildbot_unittest.py | 6 +++--- ...{layout_test_results.py => web_test_results.py} | 24 +++++++++++----------- ...ts_unittest.py => web_test_results_unittest.py} | 20 +++++++++--------- .../tools/blinkpy/tool/commands/rebaseline_cl.py | 14 ++++++------- .../tool/commands/rebaseline_cl_unittest.py | 4 ++-- .../blinkpy/tool/commands/rebaseline_server.py | 4 ++-- .../blinkpy/tool/commands/rebaseline_unittest.py | 18 ++++++++-------- .../tools/blinkpy/w3c/wpt_expectations_updater.py | 2 +- .../w3c/wpt_expectations_updater_unittest.py | 14 ++++++------- .../tools/blinkpy/web_tests/controllers/manager.py | 8 ++++---- .../{layout_test_finder.py => web_test_finder.py} | 2 +- ...der_unittest.py => web_test_finder_unittest.py} | 10 ++++----- .../{layout_test_runner.py => web_test_runner.py} | 2 +- ...nner_unittest.py => web_test_runner_unittes.py} | 6 +++--- .../blinkpy/web_tests/models/test_expectations.py | 2 +- .../tools/blinkpy/web_tests/try_flag_unittest.py | 8 ++++---- 17 files changed, 83 insertions(+), 83 deletions(-) commit 96125d78c9977190a9bafa065f9b0ba38f749215 Author: Sammie Quon <sammiequon@google.com> Date: Tue Dec 11 00:41:15 2018 +0000 overview: Escape and back exit overview even with no windows. Test: manual Bug: 902096 Change-Id: Iedc156cd8db16ab337b80a236a314d7a99bcd5cd Reviewed-on: https://chromium-review.googlesource.com/c/1370951 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#615349} ash/wm/overview/window_selector.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 5fe432ffc97808da0d270c97dc08756758a23e4d Author: Kenneth Russell <kbr@chromium.org> Date: Tue Dec 11 00:35:35 2018 +0000 Fix ColorMask state management in validating command decoder. GLES2DecoderImpl::ClearLevelUsingGL was bypassing ContextState's management of the color mask, causing the wrong color mask to be used, and the RGB-on-RGBA emulation for WebGL's back buffer on macOS to break. Tested by new WebGL conformance test in: https://github.com/KhronosGroup/WebGL/pull/2751 Bug: 911918 Change-Id: I255b11915af8ed3ddb7adfa64d7667b32c3be2df Reviewed-on: https://chromium-review.googlesource.com/c/1366923 Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615348} gpu/command_buffer/service/gles2_cmd_decoder.cc | 2 +- gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) commit 6c5397d97c8760eac002429061ccd4833c72a9b3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 00:34:56 2018 +0000 Roll src/third_party/perfetto f81bcea780c2..faae590fff1a (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/f81bcea780c2..faae590fff1a git log f81bcea780c2..faae590fff1a --date=short --no-merges --format='%ad %ae %s' 2018-12-10 lalitm@google.com Merge "trace_processor: Regression test for negative ts_end" Created with: gclient setdep -r src/third_party/perfetto@faae590fff1a The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie1fa01373f7644a3db691b52ca74dc891abf82b3 Reviewed-on: https://chromium-review.googlesource.com/c/1370569 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615347} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 17ccdcf4045144a735a84138ab6b41c3098808d2 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Dec 11 00:30:55 2018 +0000 Revert "[swarming] Remove non CIPD managed luci-go package" This reverts commit d5c1c0b4189d3e625d7e5a1c0568f255d911d5b6. Reason for revert: broke internal builder https://bugs.chromium.org/p/chromium/issues/detail?id=913158 Original change's description: > [swarming] Remove non CIPD managed luci-go package > > Bug: 851596 > Change-Id: I834ccae440b5590525644e4ad9e9d3c952038547 > Reviewed-on: https://chromium-review.googlesource.com/c/1364976 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614359} TBR=maruel@chromium.org,tikuta@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 851596, 913158 Change-Id: Ic2efd0397871271df5c0d41a0731088d53386f71 Reviewed-on: https://chromium-review.googlesource.com/c/1370225 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615346} DEPS | 38 ++++++++++++++++++++++++++++++++++++ tools/luci-go/.gitignore | 5 ++++- tools/luci-go/linux64/isolate.sha1 | 1 + tools/luci-go/mac64/isolate.sha1 | 1 + tools/luci-go/win64/isolate.exe.sha1 | 1 + 5 files changed, 45 insertions(+), 1 deletion(-) commit 1013b5f2f241c36f6598d1064305270ead3feebe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 00:25:11 2018 +0000 Roll src/third_party/pdfium 844f8dec9606..1ccf890a09a3 (2 commits) https://pdfium.googlesource.com/pdfium.git/+log/844f8dec9606..1ccf890a09a3 git log 844f8dec9606..1ccf890a09a3 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 thestig@chromium.org Prevent a divide by zero in CFX_RTFBreak::GetDisplayPos(). 2018-12-10 tsepez@chromium.org Remove xfa_basic_data.cpp representation dependence on XFA_SCRIPTATTRIBUTEINFO Created with: gclient setdep -r src/third_party/pdfium@1ccf890a09a3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:913557 TBR=dsinclair@chromium.org Change-Id: I216c0c84559f14b2255def6164a7be5aeb03dd38 Reviewed-on: https://chromium-review.googlesource.com/c/1370986 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615345} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 041a652ebd1154bcc855f5251a6513c2350da196 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Tue Dec 11 00:20:53 2018 +0000 [Fuchsia] Add package_deps for test targets. This is necessary to provide true end-to-end testing of Fuchsia packages as end users will use them. Test: Locally, chromium.far is installed with castrunner_unittests. Bug: 901955 Change-Id: I9bb4f4fb17a5cb6b7a004209304fc6be992a2069 Reviewed-on: https://chromium-review.googlesource.com/c/1368990 Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#615344} testing/test.gni | 6 +++++- webrunner/BUILD.gn | 8 +++++++- 2 files changed, 12 insertions(+), 2 deletions(-) commit 4fab1094a96e7684397a30217d0fdd843bb9f5e4 Author: Dana Fried <dfried@chromium.org> Date: Tue Dec 11 00:16:54 2018 +0000 Prominent buttons receive a lighter background on focus. This corresponds with material design standards. It does not affect GTK themes on Linux, which are already using a hack to get an appropriate color for prominent buttons. Bug: 900774 Change-Id: I84efa8681fd69aba4e6f34df9adeb05a2a7532c5 Reviewed-on: https://chromium-review.googlesource.com/c/1369033 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615343} chrome/browser/ui/libgtkui/native_theme_gtk.cc | 1 + ui/gfx/color_palette.h | 1 + ui/native_theme/common_theme.cc | 2 ++ ui/native_theme/native_theme.h | 1 + ui/native_theme/native_theme_dark_aura.cc | 2 ++ ui/views/controls/button/md_text_button.cc | 13 ++++++++++++- ui/views/controls/button/md_text_button.h | 8 +++++--- 7 files changed, 24 insertions(+), 4 deletions(-) commit a0f5518f34af5aac503af2ee1242626194f913bf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 00:15:52 2018 +0000 Roll src/third_party/dawn 07df605a2bfb..a49242766a10 (1 commits) https://dawn.googlesource.com/dawn.git/+log/07df605a2bfb..a49242766a10 git log 07df605a2bfb..a49242766a10 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 shaobo.yan@intel.com Render Pipeline Descriptorization -- Part I Created with: gclient setdep -r src/third_party/dawn@a49242766a10 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie242ff1486eb7cad7840de32fc9f1464f7c62e83 Reviewed-on: https://chromium-review.googlesource.com/c/1371005 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615342} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 17e1310d067d7eb5fb00e04da7c88ab97e1f6eca Author: David Grogan <dgrogan@chromium.org> Date: Tue Dec 11 00:15:48 2018 +0000 [LayoutNG] Stop casting LayoutNGFlexibleBox to LayoutFlexibleBox LayoutNGFlexibleBox allowed itself to be casted to a LayoutFlexibleBox but it wasn't one. This caused crashes, naturally. I audited all the calls to IsFlexibleBox* and IsFlexItem*, updating to NG where appropriate. Bug: 845235, 909021 Change-Id: Ibb3ee32a5f7a78b5d46702ad7426597f23e39d2a Reviewed-on: https://chromium-review.googlesource.com/c/1368690 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#615341} .../core/css/properties/computed_style_utils.cc | 2 +- .../core/dom/first_letter_pseudo_element.cc | 2 +- third_party/blink/renderer/core/dom/text.cc | 5 ++-- .../blink/renderer/core/editing/visible_units.cc | 3 ++- .../renderer/core/layout/flexible_box_algorithm.cc | 8 ++++--- .../blink/renderer/core/layout/layout_block.cc | 14 +++++++---- .../renderer/core/layout/layout_block_flow.cc | 2 +- .../blink/renderer/core/layout/layout_box.cc | 10 ++++---- .../blink/renderer/core/layout/layout_box.h | 22 +++++++++++------ .../core/layout/layout_deprecated_flexible_box.h | 1 + .../renderer/core/layout/layout_flexible_box.h | 2 ++ .../blink/renderer/core/layout/layout_media.cc | 2 +- .../blink/renderer/core/layout/layout_object.cc | 2 +- .../blink/renderer/core/layout/layout_object.h | 6 ++--- .../blink/renderer/core/layout/layout_table.cc | 2 +- .../core/layout/ng/layout_ng_flexible_box.h | 3 ++- .../renderer/core/layout/ng/ng_layout_input_node.h | 2 +- .../renderer/core/layout/ng/ng_length_utils.cc | 2 +- .../core/layout/table_layout_algorithm_auto.cc | 2 +- .../blink/renderer/core/layout/text_autosizer.cc | 2 +- third_party/blink/web_tests/TestExpectations | 28 +++++++++------------- 21 files changed, 68 insertions(+), 54 deletions(-) commit c787c722913a959ab495390780ab8bb647e3f7e8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Dec 11 00:10:36 2018 +0000 Roll src/third_party/skia d1ca6726734f..15640698497a (4 commits) https://skia.googlesource.com/skia.git/+log/d1ca6726734f..15640698497a git log d1ca6726734f..15640698497a --date=short --no-merges --format='%ad %ae %s' 2018-12-10 herb@google.com Convert ShoudDrawAsPath to use SkFont 2018-12-10 bsalomon@google.com Use texparameterf[v] 2018-12-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-10 reed@google.com add test (and fix) for glyphsToUnichars Created with: gclient setdep -r src/third_party/skia@15640698497a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Idbdc5ea2955c1a1527734a5f7c23ee5ef43f1621 Reviewed-on: https://chromium-review.googlesource.com/c/1370985 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615340} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7d3def8575ecd2e5e2e7ab7f585961206007bd25 Author: Matthew Denton <mpdenton@chromium.org> Date: Tue Dec 11 00:04:51 2018 +0000 Adds LPM-based SQLite fuzzer This adds a grammar-based SQLite fuzzer based on libprotobuf-mutator. This includes fuzzing for general SQL statements, FTS3, SQL expressions, and SQLite's printf and strftime functions. R=metzman@chromium.org, pwnall@chromium.org Bug: 909886 Change-Id: I2ccd4c868f9349f63b76666206ea6c5bdf78aef5 Reviewed-on: https://chromium-review.googlesource.com/c/1366875 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615339} third_party/sqlite/BUILD.gn | 123 + third_party/sqlite/fuzz/DEPS | 1 + third_party/sqlite/fuzz/icu_codes.proto | 189 ++ third_party/sqlite/fuzz/sql_expr_fuzzer.cc | 30 + third_party/sqlite/fuzz/sql_fuzzer.cc | 42 + .../sqlite/fuzz/sql_multithreaded_fuzzer.cc | 79 + third_party/sqlite/fuzz/sql_printf_fuzzer.cc | 30 + third_party/sqlite/fuzz/sql_queries.proto | 23 + third_party/sqlite/fuzz/sql_query_grammar.proto | 1653 ++++++++++++ .../sqlite/fuzz/sql_query_proto_to_string.cc | 2667 ++++++++++++++++++++ .../sqlite/fuzz/sql_query_proto_to_string.h | 26 + third_party/sqlite/fuzz/sql_run_queries.cc | 135 + third_party/sqlite/fuzz/sql_run_queries.h | 17 + third_party/sqlite/fuzz/sql_strftime_fuzzer.cc | 30 + 14 files changed, 5045 insertions(+) commit 73dabd9844e91bf6585bc65ae17cefc8d54df3c3 Author: Yiming Zhou <uwyiming@google.com> Date: Tue Dec 11 00:04:46 2018 +0000 Add autofill bots to cr-buildbucket. Bug: 855301 Change-Id: I1b20b18ff37742abc70387ce8ce469eedf24e4bb Reviewed-on: https://chromium-review.googlesource.com/c/1370910 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#615338} infra/config/global/cr-buildbucket.cfg | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit 7621ec92507d5a1b65e292f94a3180cbc99cae72 Author: Jonathan Backer <backer@chromium.org> Date: Tue Dec 11 00:02:44 2018 +0000 Fix up vulkan prototype Chrome runs with these flags: --enable-features=VizDisplayCompositor,UseSkiaRenderer,UiGpuRasterization --use-gl=any --enable-oop-rasterization --enable-vulkan Change-Id: Iee0642e91b848eb095bbc79fd887b40e1e6ede87 Reviewed-on: https://chromium-review.googlesource.com/c/1370831 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#615337} gpu/command_buffer/service/raster_decoder.cc | 9 +++++++-- gpu/command_buffer/service/raster_decoder_context_state.cc | 7 +++++++ 2 files changed, 14 insertions(+), 2 deletions(-) commit 659af052f1573e9fd5e8dd939d969dd1739f46ab Author: Jason Guo <jiahuiguo@chromium.org> Date: Tue Dec 11 00:00:34 2018 +0000 Add check to only offer paradise if user enables full sync. Bug: 897998 Change-Id: I533f4de58ccf602be85fc9f24922ea04c32f7941 Reviewed-on: https://chromium-review.googlesource.com/c/1368581 Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615336} .../core/browser/local_card_migration_manager.cc | 5 ++- .../local_card_migration_manager_unittest.cc | 36 ++++++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) commit 6b8956295e9044cdace59c9b9cfba1c0258d3843 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Dec 10 23:59:24 2018 +0000 [Extensions] Add CreationFlags to chrome://extensions-internals Include the stringified creation flags data for installed extensions in chrome://extensions-internals. Bug: None Change-Id: I289f081f6888126b000ddf76386a0216a8cd5160 Reviewed-on: https://chromium-review.googlesource.com/c/1363799 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615335} .../extensions/extensions_internals_source.cc | 37 ++++++++++++++++++++++ 1 file changed, 37 insertions(+) commit 1b2c7055c1f452e460004d30c87a6a987a456b1a Author: Daniel Cheng <dcheng@chromium.org> Date: Mon Dec 10 23:59:11 2018 +0000 Add run_with_dummy_home.py to speed up browser tests by 5x on gLinux. This is useful for isolating tests from the insanity that might reside in $HOME. For example, certain NSS configurations can cause process startup to be extremely slow. Preliminary numbers indicate a 5.4x speedup when running all content_browsertests with 20 parallel jobs on gLinux. Bug: 913027 Change-Id: I87097223aca2e121b557c2a982ec0cbc9cd2321c Reviewed-on: https://chromium-review.googlesource.com/c/1368589 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615334} testing/run_with_dummy_home.py | 59 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 59 insertions(+) commit 01db93151d091c302ddb8be3b04a6b4c690aac7f Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Dec 10 23:57:20 2018 +0000 [Fuchsia] Export Vulkan loader service to the GPU process. Updated GPU sandbox policy for the GPU process to export the fuchsia.vulkan.loader service. With this change sandboxed GPU process can use Vulkan. Bug: 861853 Change-Id: Ifcb1fa0ac186ae63b7fb09bd8782bf690c2f4b55 Reviewed-on: https://chromium-review.googlesource.com/c/1368991 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615333} services/service_manager/sandbox/fuchsia/sandbox_policy_fuchsia.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 2ce10ecdabd79844e6c98271afcaba8692b4cca2 Author: Charlie Reis <creis@chromium.org> Date: Mon Dec 10 23:55:16 2018 +0000 Update histogram expiration for CORB ContentScripts metric. BUG=904569, 846346 Change-Id: I0911c9fca33feba1e3406346ffa6472c58b8a0dd Reviewed-on: https://chromium-review.googlesource.com/c/1367107 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615332} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5dec1b4aee9d6fc471fe4b542e45bcf46d7231f2 Author: Dan Beam <dbeam@chromium.org> Date: Mon Dec 10 23:52:34 2018 +0000 Re-add myself to various WATCHLISTS R=dpapad@chromium.org BUG=none Change-Id: I1746adaaad6944102fc553d5eb06a00e2d3935a6 Reviewed-on: https://chromium-review.googlesource.com/c/1370706 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#615331} WATCHLISTS | 37 ++++++++++++++++++++++++++----------- 1 file changed, 26 insertions(+), 11 deletions(-) commit e42a9dc939cf083d7e5a040eefeb94f0157cd626 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Dec 10 23:51:43 2018 +0000 service worker: Add UMAs for subresource response body read time This is a follow-up CL of https://crrev.com/c/1358100. Adds breakdown histograms for time taken reading subresource response body by its source. This CL also updates ServiceWorker.LoadTiming.Subresource.ResponseReceivedToCompleted. This was obsoleted and ResponseReceivedToCompleted2 was added in https://crrev.com/c/1350433 but I forgot to update histograms.xml. Change-Id: Ic9feb36ca1c10a341edb8bb73ca76afc968dbbcd Bug: 877972 Reviewed-on: https://chromium-review.googlesource.com/c/1363732 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615330} .../service_worker_subresource_loader.cc | 27 +++++++++++++ .../service_worker_subresource_loader.h | 1 + .../service_worker_subresource_loader_unittest.cc | 45 +++++++++++++++++----- tools/metrics/histograms/histograms.xml | 9 +++++ 4 files changed, 73 insertions(+), 9 deletions(-) commit 2d678a7a6bfb529101fb4de48b7c0862d349ad61 Author: Nodir Turakulov <nodir@google.com> Date: Mon Dec 10 23:50:53 2018 +0000 [buildbucket] Remove "luci.chromium." prefix. As announced earlier, "bar" is the canonical bucket name of former "luci.foo.bar". New APIs use the new, short form. Some systems (Milo, Monarch metrics) are not updated yet, though. This change is a noop. The server already chops off "luci.chromium." prefix on config ingestion. Change-Id: I45efd1065e20ef98ea37d58ead2789ca4074a86f Reviewed-on: https://chromium-review.googlesource.com/c/1371032 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#615329} infra/config/global/cr-buildbucket.cfg | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit e42d764aec4389504eda9e33749db74d7c947fa0 Author: Bruce Dawson <brucedawson@chromium.org> Date: Mon Dec 10 23:50:00 2018 +0000 Update build instructions for ARM64 Win32 Update the VS install instructions for those who want to try building Chromium for ARM64 Win32. This also updates the instructions regarding VS versions and Windows SDK versions. The results were tested with both https://dillinger.io/ and python tools/md_browser/md_browser.py docs\windows_build_instructions.md since neither one gives 100% correct results. In both cases the multi-line shell command options are copied as intended. Bug: 893460 Change-Id: Ib3e950c4e4a9ef87e32c89733e4636a8bf06ba54 Reviewed-on: https://chromium-review.googlesource.com/c/1369030 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615328} docs/windows_build_instructions.md | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) commit deba185250c1a680c462eb091d69135a6c7890af Author: sebsg <sebsg@chromium.org> Date: Mon Dec 10 23:48:38 2018 +0000 [AF] Record Wallet Sync Transport opt-in on upstream offer acceptance. Bug: 913125 Change-Id: I638007991590656b7374d3838c9b140f0d48e1f5 Reviewed-on: https://chromium-review.googlesource.com/c/1368953 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615327} .../core/browser/credit_card_save_manager.cc | 2 + .../browser/credit_card_save_manager_unittest.cc | 18 +++- .../autofill/core/browser/personal_data_manager.cc | 10 ++ .../autofill/core/browser/personal_data_manager.h | 3 + .../core/browser/personal_data_manager_unittest.cc | 103 +++++++++++++++++++++ 5 files changed, 135 insertions(+), 1 deletion(-) commit 05eef22b41776e01ee7f3fa4f121a92fe7c32546 Author: Tommy Martino <tmartino@chromium.org> Date: Mon Dec 10 23:46:07 2018 +0000 [Autofill Cleanup] Use NativeTheme Colors This CL addreses one of the post-launch cleanup items for the Autofill Views rewrite. Specifically, it replaces hardcoded colors with colors taken from the NativeTheme. The new colors are all defined in common_theme and, with one exception, are equal to the hardcoded ones they are replacing. The exception is kColorId_MenuSeparatorColor, which this CL updates from a neutral grey to the corresponding GoogleGrey value. This is consistent with the spec for Autofill, and I believewe should be using it Chrome-wide as well. This will also allow work to proceed on macOS Dark Mode implementation. Bug: 831603 Change-Id: I6755285cff9096daef3e468a407214dc5dd770bc Reviewed-on: https://chromium-review.googlesource.com/c/1367936 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#615326} .../ui/views/autofill/autofill_popup_base_view.cc | 36 +++++++++++++++------- .../ui/views/autofill/autofill_popup_base_view.h | 14 +++++---- .../autofill/autofill_popup_view_native_views.cc | 22 ++++++------- .../password_generation_popup_view_views.cc | 8 ++--- ui/native_theme/common_theme.cc | 2 +- 5 files changed, 49 insertions(+), 33 deletions(-) commit 3e68862593cae81b6f73340d812b40deaa72c12e Author: Jonathan Metzman <metzman@chromium.org> Date: Mon Dec 10 23:44:51 2018 +0000 [Afl] Make build config use static linking again is_component_build was causing many fuzzers to break on ClusterFuzz. Bug: 913631 Change-Id: If2acc712834839982f787a971d5a502b6fe5280a Reviewed-on: https://chromium-review.googlesource.com/c/1370370 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615325} tools/mb/mb_config.pyl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d39f72b6f02df9fe6607659073e2ee4bde720c58 Author: Dan Sanders <sandersd@chromium.org> Date: Mon Dec 10 23:43:48 2018 +0000 [media] Allow parameter set insertion at the end of a buffer. This case only comes up when there is no slice in an H.264 frame, so how it is handled isn't particularly important. I've chosen to allow insertion in this case to avoid changing the web-visible behavior. Bug: 911942 Change-Id: Ie1bba31663da144e922b0c19c519d986deb1a404 Reviewed-on: https://chromium-review.googlesource.com/c/1366878 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615324} media/formats/mp4/avc.cc | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) commit ab061a172c4452443e3471bc21d21d6a34412e18 Author: Jeremy Roman <jbroman@chromium.org> Date: Mon Dec 10 23:43:19 2018 +0000 Use base::AtomicFlag in CryptoResultCancel. This replaces the use of WTF atomics. As a bonus, we gain a DCHECK-only sequence checker for this use. Since this only has one implementation (and there is no reason to want an alternative implementation), it has also been devirtualized. Bug: 736037 Change-Id: I87b73e032b0de5bdc3e50a1ee849c3056355417e Reviewed-on: https://chromium-review.googlesource.com/c/1369722 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615323} third_party/blink/renderer/DEPS | 1 + .../blink/renderer/modules/crypto/crypto_result_impl.cc | 12 +----------- .../blink/renderer/modules/crypto/crypto_result_impl.h | 17 +---------------- third_party/blink/renderer/platform/crypto_result.h | 10 ++++++---- .../tools/blinkpy/presubmit/audit_non_blink_usage.py | 1 + 5 files changed, 10 insertions(+), 31 deletions(-) commit af4fb8016d89f7e877ac91fa1b603d8d75f8ad42 Author: Min Qin <qinmin@chromium.org> Date: Mon Dec 10 23:41:48 2018 +0000 Passing a list of features to check whether service manager should be started To make ServiceManager and network service separate finch experiments, we need to allow individual feature to separately check whether both of them are enabled. This CL allows client to pass a list of features to check before starting the service manager mode. BUG=912444 Change-Id: If1770189c669f8cb68fed1a6993369410e1efbb3 Reviewed-on: https://chromium-review.googlesource.com/c/1363839 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615322} .../chromium/chrome/browser/ChromeFeatureList.java | 2 +- .../browser/download/DownloadBroadcastManager.java | 9 +++++++-- .../browser/init/ServiceManagerStartupUtils.java | 21 +++++++++++++-------- chrome/browser/android/chrome_feature_list.cc | 2 ++ 4 files changed, 23 insertions(+), 11 deletions(-) commit fa1707bddb53168f64eb10fdeed53a33b8cad6f0 Author: Bin Wu <wub@chromium.org> Date: Mon Dec 10 23:38:38 2018 +0000 In QuicDispatcher, do not assume all blocked writers(i.e. connections + time wait list manager) share the same opinion about whether their packet writers are blocked. Protected by --quic_restart_flag_quic_check_blocked_writer_for_blockage. Merge internal change: 223038263 R=rch@chromium.org Change-Id: I711d06054f520aed2ab782bb725f97d9edf33427 Reviewed-on: https://chromium-review.googlesource.com/c/1361634 Commit-Queue: Bin Wu <wub@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#615321} net/quic/quic_flags_list.h | 6 + .../quic/core/quic_blocked_writer_interface.h | 2 + net/third_party/quic/core/quic_connection.cc | 4 + net/third_party/quic/core/quic_connection.h | 4 + net/third_party/quic/core/quic_dispatcher.cc | 56 ++++++++-- net/third_party/quic/core/quic_dispatcher.h | 4 + net/third_party/quic/core/quic_dispatcher_test.cc | 123 +++++++++++++++++++-- .../quic/core/quic_time_wait_list_manager.cc | 5 + .../quic/core/quic_time_wait_list_manager.h | 4 + 9 files changed, 193 insertions(+), 15 deletions(-) commit 7fade693f454c11b98126157a170a3de21859e6d Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Dec 10 23:37:39 2018 +0000 Chrome OS SyncConsentTest: verify language switching. This CL adds checks for SyncConsent screen in different languages to catch bugs like the one below. Bug: 910510 Change-Id: If09130926b77b0a515e439940c26e2be2a49f0a3 Reviewed-on: https://chromium-review.googlesource.com/c/1366283 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#615320} .../login/sync_consent_interactive_ui_test.cc | 158 +++++++++++++++------ ui/login/display_manager.js | 7 + 2 files changed, 122 insertions(+), 43 deletions(-) commit 9ce899c12891c2c5c1dc1378ed1418153fe5a3c3 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Mon Dec 10 23:36:58 2018 +0000 Remove deprecated service_manager_embedder_switches_export.h Use COMPONENT_EXPORT instead. Change-Id: Ifac5df085e2d77158ba3c2075fb7feeb79b6ac20 Reviewed-on: https://chromium-review.googlesource.com/c/1370930 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#615319} services/service_manager/embedder/BUILD.gn | 6 ++- .../service_manager_embedder_switches_export.h | 30 --------------- services/service_manager/embedder/switches.h | 43 ++++++++++++++-------- 3 files changed, 32 insertions(+), 47 deletions(-) commit b9924e9c41099fe6027708ec65597ad148becdeb Author: Clark DuVall <cduvall@chromium.org> Date: Mon Dec 10 23:36:33 2018 +0000 Run network service in separate thread when run in-process This is behind a flag that is enabled by default, so we can turn it off if necessary. All in-process tests are passing with this change. Change-Id: I03b9146bfc74b922c4b34d23fec80f85d1126ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1308593 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615318} .../net/network_quality_estimator_prefs_browsertest.cc | 10 ++++++---- .../browser/net/network_quality_tracker_browsertest.cc | 18 +++++++++++++----- content/browser/network_service_instance.cc | 9 +++++++++ .../browser/service_manager/service_manager_context.cc | 17 +++++++++++++++-- .../browser/service_manager/service_manager_context.h | 2 ++ content/public/browser/network_service_instance.h | 10 ++++++++++ 6 files changed, 55 insertions(+), 11 deletions(-) commit 8c19e83e31facff404deaf8f6e071a903d377fb6 Author: David Black <dmblack@google.com> Date: Mon Dec 10 23:35:10 2018 +0000 Create AssistantAlarmTimerController. Creates a sub-controller of AssistantController to handle alarm/timer state and alarm/timer APIs. This CL migrates existing timer code but does not introduce any new logic. The AssistantAlarmTimerController will own a model that tracks what alarms/timers exist and their current state. Observers will be able to observe events on those alarms/timers. This will allow Assistant UI to show in-Assistant notifications for timers (per the spec) or AssistantNotificationController to create system notifications when Assistant UI is not shown. Bug: b:119688929 Change-Id: Ieed6e2bee9463e20e7cad29c31f3c1b13cd376b8 Reviewed-on: https://chromium-review.googlesource.com/c/1340337 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#615317} ash/BUILD.gn | 2 + ash/ash_strings.grd | 19 +++++ ash/assistant/assistant_alarm_timer_controller.cc | 82 ++++++++++++++++++++++ ash/assistant/assistant_alarm_timer_controller.h | 41 +++++++++++ ash/assistant/assistant_controller.cc | 3 + ash/assistant/assistant_controller.h | 9 +++ ash/assistant/util/deep_link_util.cc | 5 ++ ash/assistant/util/deep_link_util.h | 3 + ash/assistant/util/deep_link_util_unittest.cc | 5 ++ ash/manifest.json | 1 + ash/mojo_interface_factory.cc | 11 +++ ash/public/interfaces/assistant_controller.mojom | 11 +++ chromeos/chromeos_strings.grd | 12 ---- .../assistant/assistant_manager_service_impl.cc | 50 +++++-------- chromeos/services/assistant/public/features.cc | 7 ++ chromeos/services/assistant/public/features.h | 5 ++ chromeos/services/assistant/service.cc | 7 ++ chromeos/services/assistant/service.h | 7 ++ 18 files changed, 235 insertions(+), 45 deletions(-) commit 0fdf2a2d7719c5672eb4377078cd72e2b80ad37f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 23:31:43 2018 +0000 Roll src/third_party/angle 153e0224da45..149eb33bb49f (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/153e0224da45..149eb33bb49f git log 153e0224da45..149eb33bb49f --date=short --no-merges --format='%ad %ae %s' 2018-12-10 syoussefi@chromium.org Vulkan: add possibility to build subset of shaders Created with: gclient setdep -r src/third_party/angle@149eb33bb49f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ie94984a7e62ff96b17ce53bd58c4ef766584a921 Reviewed-on: https://chromium-review.googlesource.com/c/1370567 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615316} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fbf379905ae51525552ddc195fffc8b8341f3533 Author: Nico Weber <thakis@chromium.org> Date: Mon Dec 10 23:30:13 2018 +0000 [Chrome OS]: Stop showing Blink revision on the detailed build info page. The Blink revision has been identical to the regular Chromium revision for a few years now. Bug: 546841,913435 Change-Id: I10736896c2b912454d4e2ddfe0479da49ea6a2f0 Reviewed-on: https://chromium-review.googlesource.com/c/1369629 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615315} chrome/browser/resources/settings/about_page/detailed_build_info.html | 4 ---- chrome/browser/ui/webui/settings/about_handler.cc | 2 -- 2 files changed, 6 deletions(-) commit 072b66acb2fed92be356878ad5fae4a7dda1247f Author: Quan Nguyen <qnnguyen@chromium.org> Date: Mon Dec 10 23:30:09 2018 +0000 Reland "cros: Move most event/widget handling logic out of LoginBubble" This reverts commit bb9ca465cac1a3ec4d0670844865b40efb003c11. Bug: 912658 Change-Id: I978c067d22486f58011e4025d9913100057c8a93 Reviewed-on: https://chromium-review.googlesource.com/c/1368645 Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#615314} ash/login/ui/login_base_bubble_view.cc | 196 +++++++++++++++++++++++++++- ash/login/ui/login_base_bubble_view.h | 25 +++- ash/login/ui/login_bubble.cc | 228 +++------------------------------ ash/login/ui/login_bubble.h | 48 +------ ash/login/ui/login_bubble_unittest.cc | 2 +- 5 files changed, 236 insertions(+), 263 deletions(-) commit 60017207d7299a43b61a91a180468a2985fa4420 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 23:29:06 2018 +0000 Roll Fuchsia SDK from cdb810be4406 to a227b06661c0 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie4910d50ea5dc92ff105cfc929741917d6d77017 Reviewed-on: https://chromium-review.googlesource.com/c/1370866 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615313} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f2df2933e7f31b8769d6b4d971d90047a09c4781 Author: Eugene But <eugenebut@chromium.org> Date: Mon Dec 10 23:28:36 2018 +0000 Allow using #import directive for C++ headers in ios/ directory. The following text was added to Chromium Objective-C and Objective-C++ style guide: all source code in ios/ directory. This differs from Google Objective-C Style Guide, which requires using #include directive for C++ headers. The usage of #include and #import is inconsistent for the same headers and cause a lot of frictions during the code reviews. The proposal to run PRESUBMIT script which fixes #include/#import usage was rejected due to performance reasosn, so relaxing style guide is the only option to simplify codereview process. Original attempt to add presubmit script was here: https://codereview.chromium.org/2598173002/patch/80001/90001 Bug: None Change-Id: I670f7318bcef60c89a3697787d1f5b4104a6ef76 Reviewed-on: https://chromium-review.googlesource.com/c/1340956 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#615312} styleguide/objective-c/objective-c.md | 5 +++++ 1 file changed, 5 insertions(+) commit 5d500ddae3b6f9997854f9234c4848ed34949884 Author: Erik Jensen <rkjnsn@chromium.org> Date: Mon Dec 10 23:27:53 2018 +0000 Migrate to FileOperations and remove FileProxyWrapper This updates FileTransferMessageHandler to use the new FileOperations interface. Windows is left unimplemented for now, as thas will require the forthcoming IpcFileOperations implementation. Bug: 679313 Change-Id: Ia6c31ed4ae5fbc4c2fda4d93cdecbdf11573d3fa Reviewed-on: https://chromium-review.googlesource.com/c/1357385 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#615311} remoting/host/BUILD.gn | 10 +- remoting/host/basic_desktop_environment.cc | 8 +- remoting/host/basic_desktop_environment.h | 2 +- remoting/host/client_session.cc | 7 +- remoting/host/desktop_environment.h | 4 +- remoting/host/fake_desktop_environment.cc | 5 +- remoting/host/fake_desktop_environment.h | 2 +- remoting/host/file_proxy_wrapper.cc | 13 - remoting/host/file_proxy_wrapper.h | 84 ---- remoting/host/file_proxy_wrapper_linux.cc | 515 --------------------- remoting/host/file_proxy_wrapper_linux_unittest.cc | 214 --------- remoting/host/file_proxy_wrapper_mac.cc | 17 - remoting/host/file_proxy_wrapper_win.cc | 16 - remoting/host/file_transfer/BUILD.gn | 3 + remoting/host/file_transfer/buffered_file_writer.h | 3 +- .../file_transfer/file_transfer_message_handler.cc | 188 ++++++++ .../file_transfer/file_transfer_message_handler.h | 65 +++ .../file_transfer_message_handler_unittest.cc | 334 +++++++++++++ .../host/file_transfer/local_file_operations.cc | 2 +- remoting/host/file_transfer_message_handler.cc | 153 ------ remoting/host/file_transfer_message_handler.h | 44 -- .../host/file_transfer_message_handler_unittest.cc | 271 ----------- remoting/host/host_mock_objects.cc | 7 +- remoting/host/host_mock_objects.h | 4 +- remoting/host/ipc_desktop_environment.cc | 8 +- remoting/host/ipc_desktop_environment.h | 2 +- remoting/protocol/file_transfer_helpers.cc | 11 + remoting/protocol/file_transfer_helpers.h | 3 + 28 files changed, 631 insertions(+), 1364 deletions(-) commit 05d8b86a3c01a0998a914009263a74d3a093c533 Author: Dominic Battre <battre@chromium.org> Date: Mon Dec 10 23:25:34 2018 +0000 Display reasons for failing to fill in password-manager-internals The PasswordAutofillAgent may be asked to fill credentials into a form but reject to do that for valid reasons (e.g. the form is in a cross-origin iframe, the username is prefilled, ...). This CL introduces logging in chrome://password-manager-internals to simplify debugging these cases. Bug: 913516 Change-Id: I87caf33e7f81face7dc478b78d35d78f33783e06 Reviewed-on: https://chromium-review.googlesource.com/c/1369802 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#615310} .../content/renderer/password_autofill_agent.cc | 26 +++++++++++++++++++--- .../core/common/save_password_progress_logger.cc | 10 +++++++++ .../core/common/save_password_progress_logger.h | 4 ++++ 3 files changed, 37 insertions(+), 3 deletions(-) commit 30c8761189e2eb0c376324576825aa77fcb44f97 Author: Etienne Pierre-Doray <etiennep@chromium.org> Date: Mon Dec 10 23:23:43 2018 +0000 [Task Scheduler]: Move BrowserScheduler variations params into features. This allows us to create finch config with multiple features+params. Change-Id: I3f400364c23f3cbd36c0ece76c997561b32fd3a2 Reviewed-on: https://chromium-review.googlesource.com/c/1366716 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#615309} components/task_scheduler_util/variations_util.cc | 44 +++++++------- components/task_scheduler_util/variations_util.h | 9 ++- .../variations_util_unittest.cc | 68 +++++++++++----------- 3 files changed, 65 insertions(+), 56 deletions(-) commit 74485beee0cb47708f8ffc7560b53139ab5278de Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Dec 10 23:21:21 2018 +0000 [DevTools] Fix area screenshot issues - Minimum size is set to 5x5 pixels. - Non-left button clicks reset the screenshot mode. Bug: 791139, 789962 Change-Id: I748ef50a8068617204e574d5e7fb1e3284cc09af Reviewed-on: https://chromium-review.googlesource.com/c/1368659 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#615308} third_party/blink/renderer/core/inspector/inspector_overlay_agent.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 5469f7b411686dbd3551dd98ec38018645734dea Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 23:13:51 2018 +0000 Roll src/third_party/depot_tools ec40d02c8a16..762a25693faf (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ec40d02c8a16..762a25693faf git log ec40d02c8a16..762a25693faf --date=short --no-merges --format='%ad %ae %s' 2018-12-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@762a25693faf The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I44853d9342a8ebbb5805318b8f462d20afd3d795 Reviewed-on: https://chromium-review.googlesource.com/c/1370565 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615307} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f6fe1b5abdfc83e611a4a682da364d46c2507907 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Dec 10 23:11:14 2018 +0000 Update V8 to version 7.3.80. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9062ade5..c2ee9340 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I44af2f3ffa210bc96754f5f77c54463f1883bed1 Reviewed-on: https://chromium-review.googlesource.com/c/1370704 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615306} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 64698710a10ab64143343f74616cdfffdbfbcd90 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Mon Dec 10 23:10:08 2018 +0000 [LayoutNG] Don't reuse inline items if they collapse a previous segment break In some cases, a text node may run segment break rules and completely remove a preceding run of collapsible whitespaces and segment breaks. This patch ensures that segment break rules are still run in this case by stopping inline items from being reused. Bug: 879088 Change-Id: If4ae3d53bb777c28421851b3ff22bcbaf209cc86 Reviewed-on: https://chromium-review.googlesource.com/c/1370647 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615305} .../layout/ng/inline/ng_inline_items_builder.cc | 12 ++++++++ .../core/layout/ng/inline/ng_inline_node_test.cc | 34 ++++++++++++++++++++++ 2 files changed, 46 insertions(+) commit 73d8deada12823ed921f1860a27ea0a2af383489 Author: Noel Gordon <noel@chromium.org> Date: Mon Dec 10 23:07:48 2018 +0000 Closure compile external_metadata_provider_unittest - remove external_metadata_provider_unittest.html - move the closure_compile BUILD.gn rule to the front - add BUILD rules to auto-generate and compile the unittest - fix Closure compile errors and auto-format the code No change in test behavior. Bug: 913670 Change-Id: Ib188e13cd5e143142006a00865a69547556a0a22 Reviewed-on: https://chromium-review.googlesource.com/c/1370149 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#615304} .../chromeos/file_manager/file_manager_jstest.cc | 4 +-- .../file_manager/foreground/js/metadata/BUILD.gn | 26 ++++++++++----- .../external_metadata_provider_unittest.html | 21 ------------ .../external_metadata_provider_unittest.js | 39 ++++++++++++++++------ 4 files changed, 48 insertions(+), 42 deletions(-) commit a22f10309f888b61e2e6b8398e2d90f133159c55 Author: Etienne Pierre-Doray <etiennep@chromium.org> Date: Mon Dec 10 23:07:33 2018 +0000 [TaskScheduler]: Migrate off of AssertBlockingAllowedDeprecated in /ios/chrome/browser/sessions base::AssertBlockingAllowedDeprecated is deprecated in favor of ScopedBlockingCall, which serves as a precise annotation of the scope that may/will block. Please make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). - Calls to blocking //base APIs don't need to be annotated with ScopedBlockingCall. All blocking //base APIs (e.g. base::ReadFileToString, base::File::Read, base::SysInfo::AmountOfFreeDiskSpace, base::WaitableEvent::Wait, etc.) have their own internal annotations. Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1338391 Please CQ if LGTY! This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 903957 Change-Id: Ia75e29de3e32ef186bfdaac36c8644c4c125e5f4 Reviewed-on: https://chromium-review.googlesource.com/c/1366016 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615303} ios/chrome/browser/sessions/session_service_ios.mm | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit dd9c10161af2dc6f3323061f6d8285d1cba9c378 Author: Kai Ninomiya <kainino@chromium.org> Date: Mon Dec 10 23:06:35 2018 +0000 WriteBitmap: convert pixels to N32 if they're not already Bug: 902837 Change-Id: I6d3a78ed9f107775f964d2a3cbc1d652eea4744f Reviewed-on: https://chromium-review.googlesource.com/c/1345809 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Fernando Serboncini <fserb@chromium.org> Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615302} skia/ext/skia_utils_base.cc | 26 ++++ skia/ext/skia_utils_base.h | 8 ++ skia/ext/skia_utils_mac.mm | 9 +- .../renderer/core/clipboard/system_clipboard.cc | 5 +- ui/base/clipboard/clipboard_aura.cc | 7 +- ui/base/clipboard/clipboard_mac.mm | 13 +- ui/base/clipboard/clipboard_test_template.h | 155 ++++++++++++++++----- ui/base/clipboard/clipboard_win.cc | 10 +- ui/base/mojo/clipboard_client.cc | 8 +- ui/base/test/test_clipboard.cc | 8 +- 10 files changed, 202 insertions(+), 47 deletions(-) commit 386cac96488a0d6d9aa45ab37f9e4f80571d4606 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Mon Dec 10 23:04:48 2018 +0000 [AR][IOS] AR Quick Look integration followup - Addresses feedback on crrev.com/c/1351980 posted after it landed: - Moves ARQuickLookTabHelper creation to AttachTabHelpers(). - Makes ARQuickLookCoordinator a WebStateList observer to install and uninstall itself as the ARQuickLookTabHelper. - Fixes a bug where QLPreviewController was not being presented any longer if it failed to be presented once, e.g., due to base view controller's view not being in the window hirerachy b/c incognito tab is not open. Bug: 908696 Change-Id: Id5f325f862db9cd398468b1833203b950a5b1060 Reviewed-on: https://chromium-review.googlesource.com/c/1364830 Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615301} .../browser/download/ar_quick_look_tab_helper.h | 12 +- .../browser/download/ar_quick_look_tab_helper.mm | 15 +-- .../download/ar_quick_look_tab_helper_unittest.mm | 3 +- .../download/browser_download_service_unittest.mm | 33 ++++- ios/chrome/browser/tabs/BUILD.gn | 1 + ios/chrome/browser/tabs/tab_helper_util.mm | 6 + .../ui/download/ar_quick_look_coordinator.h | 19 ++- .../ui/download/ar_quick_look_coordinator.mm | 142 +++++++++++++++++++-- .../download/ar_quick_look_coordinator_unittest.mm | 95 +++++++++++--- ios/chrome/browser/ui/main/browser_coordinator.mm | 28 ++-- 10 files changed, 285 insertions(+), 69 deletions(-) commit 360be5f2c3ebec59e3c7e9528a8b093a5216b9a4 Author: Lakshmi Kumar Dabbiru <dlkumar@google.com> Date: Mon Dec 10 23:04:19 2018 +0000 Autofill Android card name fix flow metrics Android credit card name fix flow metrics Bug: 848955 Change-Id: Ibc01b5685996d2564e99d54e0d6df47a0311026e Reviewed-on: https://chromium-review.googlesource.com/c/1361707 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#615300} .../autofill/card_name_fix_flow_view_android.cc | 2 ++ .../autofill/core/browser/autofill_metrics.cc | 14 +++++++++++ .../autofill/core/browser/autofill_metrics.h | 18 +++++++++++++++ .../autofill_save_card_infobar_delegate_mobile.cc | 5 ++-- .../ui/card_name_fix_flow_view_delegate_mobile.cc | 27 +++++++++++++++++++++- .../ui/card_name_fix_flow_view_delegate_mobile.h | 9 ++++++++ tools/metrics/histograms/enums.xml | 7 ++++++ tools/metrics/histograms/histograms.xml | 12 ++++++++++ 8 files changed, 91 insertions(+), 3 deletions(-) commit 05794760b5a9042755cd20fba7f7712967b1c206 Author: wutao <wutao@chromium.org> Date: Mon Dec 10 23:03:19 2018 +0000 app_list: Add one more test for Continue Reading This cl adds one more test for Continue Reading. Bug: 913250 Test: AppSearchProviderTest.FetchRecommendationsWithContinueReading Change-Id: I7734698282bb92ce9741924bd7de447db9be6786 Reviewed-on: https://chromium-review.googlesource.com/c/1370964 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615299} .../search/tests/app_search_provider_unittest.cc | 24 ++++++++++++++++++++++ 1 file changed, 24 insertions(+) commit d6bfb4722098d367279f20b6bde372c1c32d470d Author: Daniel Nicoara <dnicoara@chromium.org> Date: Mon Dec 10 23:02:33 2018 +0000 Add exo_unittests to "Cast Linux" bots Bug: 896710 Test: Ran exo_unittests locally to verify they work. Change-Id: I7d015adeaf762bc7c4b1b1a5f9955f93d2dea26c Reviewed-on: https://chromium-review.googlesource.com/c/1340902 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#615298} chromecast/BUILD.gn | 1 + testing/buildbot/chromium.linux.json | 6 ++++++ testing/buildbot/test_suites.pyl | 1 + 3 files changed, 8 insertions(+) commit 1c216f1e3237cd96af6f1720a8986c4647ccd2d4 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Dec 10 23:00:50 2018 +0000 Roll src-internal ee0eac216fb4..632d83f7f4d0 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee0eac216fb4..632d83f7f4d0 Created with: gclient setdep -r src-internal@632d83f7f4d0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie29057857363c7a979d60062ff6838d4fc049921 Reviewed-on: https://chromium-review.googlesource.com/c/1370568 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615297} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 92a3ff52e286131dd3203f5819dde9157958877f Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Mon Dec 10 22:55:50 2018 +0000 Remove CoreTabHelperDelegate. There were only 2 remaining functions in that class, and they can be called directly on the Browser. Change-Id: I4744387cbd9098fc0390734c68162694b0c80e13 Reviewed-on: https://chromium-review.googlesource.com/c/1351459 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615296} chrome/browser/android/tab_android.cc | 46 ++++++++++++++++------ chrome/browser/android/tab_android.h | 4 +- chrome/browser/dom_distiller/tab_utils.cc | 1 - chrome/browser/prerender/prerender_manager.cc | 7 ++-- .../render_view_context_menu.cc | 11 +++--- .../resource_coordinator/tab_load_tracker.h | 2 +- chrome/browser/ui/BUILD.gn | 2 - chrome/browser/ui/browser.cc | 20 ++++------ chrome/browser/ui/browser.h | 14 ++++--- chrome/browser/ui/tab_contents/core_tab_helper.cc | 1 - chrome/browser/ui/tab_contents/core_tab_helper.h | 8 ---- .../ui/tab_contents/core_tab_helper_delegate.cc | 20 ---------- .../ui/tab_contents/core_tab_helper_delegate.h | 34 ---------------- chrome/browser/ui/tabs/tab_strip_model.cc | 13 +++--- 14 files changed, 65 insertions(+), 118 deletions(-) commit acfba20e2719aa962c60332519a2e8080eab4e0b Author: Nico Weber <thakis@chromium.org> Date: Mon Dec 10 22:55:48 2018 +0000 Remove LASTCHANGE_STRING from chrome_version.h.in It appears unused. Bug: 872407 Change-Id: I791b0bf5e395a3b20c219160a3356269e84d1a7b Reviewed-on: https://chromium-review.googlesource.com/c/1370488 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615295} chrome/common/BUILD.gn | 2 -- chrome/common/chrome_version.h.in | 4 ---- 2 files changed, 6 deletions(-) commit f3caee16417dc39e55af87787de4dc6b472d8832 Author: Josh Karlin <jkarlin@chromium.org> Date: Mon Dec 10 22:54:27 2018 +0000 Create experiment to split cache by top frame origin This CL prefixes the disk cache's key with the top frame origin, like this: "[top frame url].[url]". This way the same resource loaded from two pages with different origins won't use the same cached entry. Changes: * Added a new experiment, SplitCacheByTopFrameOrigin. The experiment does *not* clear the caches on entry/exit from the experiment. If this proves to be problematic we can fix that later. * Added a top_frame_url member to HttpRequestInfo, copied from the URLRequest. * Changed the cache key generation function. * Added both unit and browser tests. Bug: 898855 Change-Id: I4a693e98af88de71d1ae6c4630c5df9fa042670b Reviewed-on: https://chromium-review.googlesource.com/c/1352344 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615294} .../web_contents/web_contents_impl_browsertest.cc | 225 +++++++++++++++++++++ net/base/features.cc | 3 + net/base/features.h | 3 + net/http/http_cache.cc | 19 +- net/http/http_cache_unittest.cc | 94 +++++++++ net/http/http_request_info.h | 5 + net/http/mock_http_cache.cc | 17 +- net/url_request/url_request_http_job.cc | 1 + net/url_request/url_request_unittest.cc | 21 ++ 9 files changed, 382 insertions(+), 6 deletions(-) commit a3f8b7314f548ab9e2b431cd6229ebb0e74ddf9c Author: Danyao Wang <danyao@chromium.org> Date: Mon Dec 10 22:53:42 2018 +0000 [Nav Experiment] Re-enable UserInitiatedHashChangeNavigation test. This CL doesn't yet fix the test for slim nav. It patches two known bugs with hash-only changes so that the test can be re-enabled to prevent other possible regressions. Bug: 851119 Change-Id: Ibf866d0c8cec0508632d9c2f66ca41763852f6f4 Reviewed-on: https://chromium-review.googlesource.com/c/1370884 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615293} ios/web/web_state/web_state_observer_inttest.mm | 32 +++++++++++++++++-------- 1 file changed, 22 insertions(+), 10 deletions(-) commit 6d2b7a1aa68f2341353d743cb51b00b73a22f1af Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 22:49:40 2018 +0000 Roll src/third_party/pdfium 99b9ffb79d92..844f8dec9606 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/99b9ffb79d92..844f8dec9606 git log 99b9ffb79d92..844f8dec9606 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 tsepez@chromium.org Wrap access to xfa_basic_data.cpp tables with functions. Created with: gclient setdep -r src/third_party/pdfium@844f8dec9606 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib503b8c1850e288f0f91dc865928fb821e1e0801 Reviewed-on: https://chromium-review.googlesource.com/c/1370566 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615292} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ec3682e3c9061c10f26ea9e5cdcf3c53f3f74387 Author: Daniel Rubery <drubery@chromium.org> Date: Mon Dec 10 22:47:32 2018 +0000 Extract the contents of RAR files and report hashes and signatures Bug: 909778 Change-Id: Id1f5cb828b8ad5cc13dcff571e026dd69b3fbc76 Reviewed-on: https://chromium-review.googlesource.com/c/1327238 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#615291} chrome/common/safe_browsing/BUILD.gn | 1 + chrome/common/safe_browsing/rar_analyzer.cc | 129 ++++++++++++++------- chrome/common/safe_browsing/rar_analyzer.h | 16 +-- chrome/services/file_util/DEPS | 1 + .../file_util/public/cpp/sandboxed_rar_analyzer.cc | 26 ++++- .../file_util/public/cpp/sandboxed_rar_analyzer.h | 5 +- .../public/cpp/sandboxed_rar_analyzer_unittest.cc | 59 +++++++++- .../public/mojom/safe_archive_analyzer.mojom | 6 +- chrome/services/file_util/safe_archive_analyzer.cc | 4 +- chrome/services/file_util/safe_archive_analyzer.h | 1 + components/safe_browsing/features.cc | 3 + components/safe_browsing/features.h | 4 + third_party/unrar/README.chromium | 2 + third_party/unrar/patches/5.6.8.patch | 118 +++++++++++++++---- third_party/unrar/src/archive.cpp | 9 ++ third_party/unrar/src/archive.hpp | 11 ++ third_party/unrar/src/extract.cpp | 5 + third_party/unrar/src/file.cpp | 6 + third_party/unrar/src/unrar_wrapper.h | 7 +- 19 files changed, 328 insertions(+), 85 deletions(-) commit 02939dd4e3b1944e4c02370fb6ce7d892bffc6fe Author: Darren Shen <shend@chromium.org> Date: Mon Dec 10 22:47:15 2018 +0000 [VK] Keep enable-virtual-keyboard flag indefinitely. Flags are going to expire in M74, so we need to keep the ones that we need indefinitely. enable-virtual-keyboard is useful for debugging the virtual keyboard on a non-tablet device, as it forces the virtual keyboard to show. Change-Id: I090e50fefe89c06fb79363e717f43b586f0015c6 Reviewed-on: https://chromium-review.googlesource.com/c/1368854 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#615290} chrome/browser/flag-metadata.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit b1afbb9ccbe6ae44bcefcfc03403ae028daa2981 Author: Piotr Bialecki <bialpio@chromium.org> Date: Mon Dec 10 22:43:55 2018 +0000 Add dependency on ARCore 1.5 from maven This change is in preparation for switching from ARCore 1.1 (current) to ARCore 1.5. We currently depend on ARCore header (pulled down from github) and the contents of .aar file distributed by ARCore team - this change adds ARCore as a dependency from maven. The .so and .jar files in //third-party/arcore-android-sdk will be removed once the build switches to use files added in this CL. Bug: 887669 Change-Id: I90ae3f30a41f832c2dc2c0ff36cfd5ec0b3a584c Reviewed-on: https://chromium-review.googlesource.com/c/1366267 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615289} DEPS | 11 ++ third_party/android_deps/BUILD.gn | 6 + .../android_deps/additional_readme_paths.json | 1 + .../android_deps/libs/com_google_ar_core/LICENSE | 179 +++++++++++++++++++++ .../android_deps/libs/com_google_ar_core/OWNERS | 1 + .../libs/com_google_ar_core/README.chromium | 13 ++ .../android_deps/libs/com_google_ar_core/cipd.yaml | 10 ++ .../com_google_ar_core/com_google_ar_core.info | 14 ++ tools/android/roll/android_deps/build.gradle | 4 + .../src/main/groovy/BuildConfigGenerator.groovy | 5 + .../src/main/groovy/ChromiumDepGraph.groovy | 4 + 11 files changed, 248 insertions(+) commit a2415cc71d7214e6af04ae194e05f2650f147e51 Author: Austin Eng <enga@chromium.org> Date: Mon Dec 10 22:38:16 2018 +0000 Add ALWAYS_INLINE to draw call validation and MultiDraw entrypoints This fixes a performance regresion introduced by factoring validation Bug: chromium:913151 Change-Id: I645f98e77fe3e5dccf6c2ab00e9ddde424dedf9c Reviewed-on: https://chromium-review.googlesource.com/c/1370467 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#615288} gpu/command_buffer/service/gles2_cmd_decoder.cc | 51 +++++++++++++------------ 1 file changed, 27 insertions(+), 24 deletions(-) commit b4b54662bdfc70499604ba43bd52cdb71406e15f Author: Darwin Huang <huangdarwin@chromium.org> Date: Mon Dec 10 22:37:12 2018 +0000 X Selection: Refactoring (range-based for loops, NULL to nullptr) - Only in ui/base/x/* - Updated X Selection code to use range-based for loops. - Updated uses of NULL to nullptr - `git cl format` also updated some formatting. Bug: 896479 Change-Id: I5fea75df87872341d726e2f7bbeb0d93c0a89b61 Reviewed-on: https://chromium-review.googlesource.com/c/1368944 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615287} ui/base/x/selection_owner.cc | 29 ++++++++++++---------------- ui/base/x/selection_requestor.cc | 32 ++++++++++++++----------------- ui/base/x/selection_requestor_unittest.cc | 4 ++-- ui/base/x/selection_utils.cc | 16 ++++++++-------- ui/base/x/x11_util.cc | 22 ++++++++++----------- 5 files changed, 47 insertions(+), 56 deletions(-) commit 349c67d574921365a6b8fce60479574240f61fbf Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Dec 10 22:37:09 2018 +0000 Add cr-fuchsia@ as OWNERS for //net/base/*_fuchsia* . Previously cr-fuchsia owned *_fuchsia.* in //net/base, which excluded *_fuchsia_unittests.cc, particularly network_change_notifier_fuchsia_unittest.cc . This CL updates //net/base/OWNERS to use *_fuchsia* (without '.'). Change-Id: Ic107e6f879b7b4cf39159aec92d3fabd95013b4c Reviewed-on: https://chromium-review.googlesource.com/c/1370928 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615286} net/base/OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 96194512880cbc7b31e928a7ae5007e60c86655b Author: Takumi Fujimoto <takumif@chromium.org> Date: Mon Dec 10 22:33:54 2018 +0000 Resolve a DCHECK failure in Views Cast dialog The DCHECK failure was being caused by having an unnecessary InkDrop / mask layer. Bug: 912687 Change-Id: Ie19d26aacb1118c8aa80b47baa7c10f1e1e296af Reviewed-on: https://chromium-review.googlesource.com/c/1368767 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#615285} chrome/browser/ui/views/media_router/cast_dialog_sink_button.cc | 3 +++ 1 file changed, 3 insertions(+) commit 65e8fe3fcc939e1b655f305e9c1a3f285e5d7186 Author: Daniel Murphy <dmurph@chromium.org> Date: Mon Dec 10 22:31:25 2018 +0000 [DOMStorage] Log success results of re-opening databases. R=mek@chromium.org Change-Id: I91d383cddd6b881867ba042b945129c5eabfd539 Reviewed-on: https://chromium-review.googlesource.com/c/1368639 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#615284} content/browser/dom_storage/local_storage_context_mojo.cc | 1 + content/browser/dom_storage/session_storage_context_mojo.cc | 1 + 2 files changed, 2 insertions(+) commit 1da379680795f71e62c63417194aaf453f37d89c Author: Kyle Horimoto <khorimoto@chromium.org> Date: Mon Dec 10 22:27:36 2018 +0000 [CrOS MultiDevice] Move CryptAuth proto definitions to DeviceSync. CryptAuth-related files should now be part of DeviceSync in the ongoing effort to remove the //components/cryptauth directory. Change-Id: I287f23a85a133f5317994755946e0dd445227599 Bug: 912743 Reviewed-on: https://chromium-review.googlesource.com/c/1364303 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#615283} chrome/browser/chromeos/BUILD.gn | 2 +- .../chromeos/cryptauth/chrome_cryptauth_service.cc | 2 +- .../chromeos/cryptauth/chrome_cryptauth_service.h | 2 +- .../chromeos/cryptauth/gcm_device_info_provider_impl.h | 2 +- .../login/easy_unlock/easy_unlock_challenge_wrapper.cc | 2 +- .../easy_unlock_challenge_wrapper_unittest.cc | 2 +- chromeos/components/multidevice/BUILD.gn | 8 ++++---- chromeos/components/multidevice/beacon_seed.h | 2 +- .../components/multidevice/mojom/multidevice.typemap | 2 +- chromeos/components/multidevice/software_feature.h | 2 +- .../components/proximity_auth/proximity_auth_client.h | 2 +- chromeos/components/proximity_auth/webui/BUILD.gn | 4 ++-- .../webui/proximity_auth_webui_handler.cc | 2 +- chromeos/components/tether/BUILD.gn | 2 +- chromeos/services/device_sync/device_sync_impl.cc | 2 +- .../services/device_sync}/proto/BUILD.gn | 2 +- .../services/device_sync}/proto/cryptauth_api.proto | 18 ++++++++++++------ .../services/device_sync}/proto/enum_util.cc | 2 +- .../services/device_sync}/proto/enum_util.h | 8 ++++---- .../services/device_sync}/proto/securemessage.proto | 0 chromeos/services/multidevice_setup/BUILD.gn | 2 +- .../services/multidevice_setup/device_reenroller.cc | 2 +- .../services/multidevice_setup/device_reenroller.h | 2 +- .../eligible_host_devices_provider_impl_unittest.cc | 1 + chromeos/services/secure_channel/ble_scanner_impl.cc | 2 +- .../secure_channel/public/mojom/secure_channel.mojom | 2 +- components/cryptauth/BUILD.gn | 8 ++++---- components/cryptauth/background_eid_generator.cc | 2 +- .../cryptauth/background_eid_generator_unittest.cc | 2 +- components/cryptauth/ble/BUILD.gn | 6 +++--- .../ble/ble_advertisement_generator_unittest.cc | 2 +- components/cryptauth/cryptauth_client.h | 2 +- components/cryptauth/cryptauth_client_impl.h | 2 +- components/cryptauth/cryptauth_client_impl_unittest.cc | 2 +- components/cryptauth/cryptauth_device_manager.h | 2 +- components/cryptauth/cryptauth_device_manager_impl.cc | 2 +- components/cryptauth/cryptauth_device_manager_impl.h | 2 +- .../cryptauth_device_manager_impl_unittest.cc | 2 +- components/cryptauth/cryptauth_enroller.h | 2 +- components/cryptauth/cryptauth_enroller_impl.h | 2 +- components/cryptauth/cryptauth_enrollment_manager.h | 2 +- .../cryptauth/cryptauth_enrollment_manager_impl.cc | 2 +- .../cryptauth/cryptauth_enrollment_manager_impl.h | 2 +- components/cryptauth/cryptauth_service.h | 2 +- components/cryptauth/device_classifier_util.h | 2 +- .../cryptauth/device_to_device_initiator_helper.cc | 2 +- .../cryptauth/device_to_device_initiator_helper.h | 2 +- .../cryptauth/device_to_device_responder_operations.cc | 4 ++-- .../cryptauth/device_to_device_secure_context.cc | 4 ++-- .../device_to_device_secure_context_unittest.cc | 4 ++-- components/cryptauth/fake_cryptauth_device_manager.h | 2 +- .../cryptauth/fake_cryptauth_enrollment_manager.h | 2 +- components/cryptauth/fake_cryptauth_service.h | 2 +- components/cryptauth/fake_gcm_device_info_provider.h | 2 +- components/cryptauth/foreground_eid_generator.cc | 2 +- .../cryptauth/foreground_eid_generator_unittest.cc | 2 +- components/cryptauth/gcm_device_info_provider.h | 2 +- components/cryptauth/mock_cryptauth_client.h | 2 +- components/cryptauth/pref_names.cc | 4 ++-- components/cryptauth/remote_device_loader.cc | 2 +- components/cryptauth/remote_device_loader.h | 2 +- components/cryptauth/remote_device_loader_unittest.cc | 2 +- .../cryptauth/remote_device_provider_impl_unittest.cc | 2 +- components/cryptauth/secure_message_delegate.h | 2 +- components/cryptauth/software_feature_manager_impl.cc | 4 ++-- components/cryptauth/software_feature_manager_impl.h | 2 +- .../software_feature_manager_impl_unittest.cc | 2 +- 67 files changed, 94 insertions(+), 87 deletions(-) commit 11906c511349e8e499fe62fa6d65bf91708ad6e3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 22:27:23 2018 +0000 Roll src/third_party/skia a72e8d3f4053..d1ca6726734f (4 commits) https://skia.googlesource.com/skia.git/+log/a72e8d3f4053..d1ca6726734f git log a72e8d3f4053..d1ca6726734f --date=short --no-merges --format='%ad %ae %s' 2018-12-10 reed@google.com use SkFont for blob TightBounds 2018-12-10 bsalomon@google.com Add SK_API to GrTexture. 2018-12-10 mtklein@google.com templatize SkBitmapProcState_matrixProcs 2018-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 19f2f9eb2503..153e0224da45 (1 commits) Created with: gclient setdep -r src/third_party/skia@d1ca6726734f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:911856 TBR=ethannicholas@chromium.org Change-Id: Id857970dd5aa7676d7e4cc4c37208d53f91e2d2a Reviewed-on: https://chromium-review.googlesource.com/c/1370784 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615282} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5ddfcc694a15be3c1f02a691d6f2ff34baa23a64 Author: Joel Hockey <joelhockey@chromium.org> Date: Mon Dec 10 22:24:53 2018 +0000 FilesApp crostini: allow android files in crostini Bug: 878324 Change-Id: I44c19ec3db72031588ea132f531aceb90e234603 Reviewed-on: https://chromium-review.googlesource.com/c/1367330 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#615281} chrome/browser/chromeos/crostini/crostini_share_path.cc | 11 +++++++++-- chrome/browser/chromeos/file_manager/path_util.cc | 10 ++++++---- chrome/browser/chromeos/file_manager/path_util_unittest.cc | 12 +++++++++++- tools/metrics/histograms/histograms.xml | 1 + ui/file_manager/file_manager/background/js/crostini.js | 1 + 5 files changed, 28 insertions(+), 7 deletions(-) commit 06d0e772ff0ba8ba86f2193f8c9f332478874ee9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 22:21:48 2018 +0000 Roll src/third_party/SPIRV-Tools/src e07dabc25f1f..248debf55ad6 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e07dabc25f1f..248debf55ad6 git log e07dabc25f1f..248debf55ad6 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 stevenperron@google.com Update CHANGES Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@248debf55ad6 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7542b103cca5ece280734495f8a5cf712d7eda1f Reviewed-on: https://chromium-review.googlesource.com/c/1370524 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615280} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 12b89733300bd268cff3b78fc76cb8f3a7cc44e5 Author: Elad Alon <eladalon@chromium.org> Date: Mon Dec 10 22:17:49 2018 +0000 Remove unused StartEventLog version Bug: 775415 Change-Id: I996f0bf0bb10e0f2495d86738fe5b38b32899130 Reviewed-on: https://chromium-review.googlesource.com/c/1358454 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#615279} .../renderer_host/render_process_host_impl.cc | 3 +-- .../media/peer_connection_tracker_messages.h | 5 +--- .../media/webrtc/peer_connection_tracker.cc | 31 +++------------------- .../media/webrtc/peer_connection_tracker.h | 11 ++------ .../media/webrtc/rtc_peer_connection_handler.cc | 11 -------- .../media/webrtc/rtc_peer_connection_handler.h | 5 ---- 6 files changed, 7 insertions(+), 59 deletions(-) commit 484ba59618f9f6ccd5080cd61ddc5c3b835e521c Author: khachatryan <khachatryan@chromium.org> Date: Mon Dec 10 22:16:20 2018 +0000 [ChromeDriver] ChromeDriver 2.45 release Change-Id: I6be65cbbbf606dceb11d579f17411572fdd4d6c6 Reviewed-on: https://chromium-review.googlesource.com/c/1370889 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615278} chrome/test/chromedriver/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 869255859135c13bf164e9d92d98ceea13aa0cc2 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 10 22:15:52 2018 +0000 Pausable Object cleanup - FontFaceSet FontFaceSet doesn't need to be a pausable object to avoid dispatching events when paused since: - workers don't pause objects - events queued in the kInternalDefault queue are already pausable. BUG=907125 Change-Id: I3dc4c392ecad42f2f008837298ed5e7f7afb274d Reviewed-on: https://chromium-review.googlesource.com/c/1368448 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615277} .../blink/renderer/core/css/font_face_set.cc | 30 ++++++++++------------ .../blink/renderer/core/css/font_face_set.h | 29 ++++++--------------- .../renderer/core/css/font_face_set_document.cc | 1 - .../renderer/core/css/font_face_set_worker.cc | 1 - .../http/tests/activedomobject/media-expected.txt | 8 +++--- .../http/tests/activedomobject/media.html | 8 +++--- 6 files changed, 30 insertions(+), 47 deletions(-) commit cac5471960be232fde2b84dce725ca78f322c4ee Author: Sergey Ulanov <sergeyu@chromium.org> Date: Mon Dec 10 22:11:51 2018 +0000 Roll Fuchsia SDK from 9d623aaaba71 to cdb810be4406 Also includes minor changes in //net to account for changes in fuchsia.netstack API. TBR=mattm@chromium.org Change-Id: Ic473819b6aa65c6876bff0cf4f4544a471297b29 Reviewed-on: https://chromium-review.googlesource.com/c/1370487 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615276} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- net/base/network_change_notifier_fuchsia.cc | 4 +- .../network_change_notifier_fuchsia_unittest.cc | 71 +++++++++++----------- net/base/network_interfaces_fuchsia.cc | 20 +++--- net/base/network_interfaces_fuchsia.h | 6 +- 6 files changed, 54 insertions(+), 51 deletions(-) commit 614b0149431fe8b0a8c09874d33c5393c0c76c37 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Dec 10 22:08:53 2018 +0000 [Extensions Cleanup] Make Event::DeepCopy return a std::unique_ptr Rather than returning a raw pointer with a comment saying "ownership is passed", return a std::unique_ptr. Bug: None Change-Id: Id415847c7ca478f36ff3f624bd572b2c4678ac41 Reviewed-on: https://chromium-review.googlesource.com/c/1370646 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615275} extensions/browser/event_router.cc | 4 ++-- extensions/browser/event_router.h | 6 ++---- extensions/browser/events/lazy_event_dispatcher.cc | 2 +- extensions/browser/test_event_router_observer.cc | 6 ++---- 4 files changed, 7 insertions(+), 11 deletions(-) commit 00c1b7ab0080db58436431b6dbe1956b2457abbc Author: ccameron <ccameron@chromium.org> Date: Mon Dec 10 22:02:27 2018 +0000 Revert "[Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness." This reverts commit 0c873bf2265189967d77b2cbccee70cfd14e9db9. Reason for revert: Fix for flake in crrev.com/615269 Original change's description: > [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness. > > Tbr: ccameron@chromium.org > Bug: 913490 > Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f > Reviewed-on: https://chromium-review.googlesource.com/c/1369721 > Commit-Queue: Samuel Huang <huangs@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615159} TBR=huangs@chromium.org,ccameron@chromium.org Change-Id: I1326fab24c9d4d85bbd66b8b48b60f8471b86593 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 913490 Reviewed-on: https://chromium-review.googlesource.com/c/1370571 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615274} chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8516b846cd6f074986e1067837182c1041720f18 Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Mon Dec 10 22:01:13 2018 +0000 [WebUI] Add <managed-footnote> component This Polymer component can be used on WebUI pages as a disclosure for managed users. It shows an enterprise icon and the text 'Your browser is managed by your organization'. It also has a hyperlink that points to a Help Center article. Bug: 893628 Change-Id: Id9e5e0b3552943c260ac251c3b643dd963b5809a Reviewed-on: https://chromium-review.googlesource.com/c/1352438 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#615273} chrome/app/generated_resources.grd | 7 +++ .../IDS_MANAGED_BY_ORG_WITH_HYPERLINK.png.sha1 | 1 + .../cr_components/cr_components_browsertest.js | 23 ++++++++ .../webui/cr_components/managed_footnote_test.js | 60 +++++++++++++++++++++ ui/webui/resources/cr_components/BUILD.gn | 1 + .../cr_components/cr_components_resources.grdp | 8 +++ .../cr_components/managed_footnote/BUILD.gn | 19 +++++++ .../managed_footnote/managed_footnote.html | 52 ++++++++++++++++++ .../managed_footnote/managed_footnote.js | 61 ++++++++++++++++++++++ ui/webui/resources/cr_elements/icons.html | 1 + 10 files changed, 233 insertions(+) commit f987a7707cf901912d8a54595da8c24c377cd044 Author: wutao <wutao@chromium.org> Date: Mon Dec 10 21:58:18 2018 +0000 app_list: add unittest for Continue Reading This cl adds unit tests for Continue Reading. Bug: 913250 Test: AppSearchProviderTest.FetchRecommendationsWithContinueReading Change-Id: I8754aabc5c637af4480aa316a02408747a04927c Reviewed-on: https://chromium-review.googlesource.com/c/1369226 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615272} .../app_list/internal_app/internal_app_metadata.cc | 10 +- .../app_list/internal_app/internal_app_metadata.h | 13 +- .../ui/app_list/search/app_search_provider.cc | 9 +- .../ui/app_list/search/app_search_provider.h | 14 ++ .../ui/app_list/search/internal_app_result.cc | 3 +- .../search/tests/app_search_provider_unittest.cc | 246 +++++++++++++++++++++ 6 files changed, 284 insertions(+), 11 deletions(-) commit 2a61a1c00343a6ac4e71de3f2ff59258db96130c Author: sebsg <sebsg@chromium.org> Date: Mon Dec 10 21:56:09 2018 +0000 [AF] Add UMA logging for the server card link in payment settings. This will help us figure out if users are more likely to go check their card in different sync situations. Bug: 908439 Change-Id: Idcbf6fee62bc2f364126d185d4a2f1f8a5ce431a Reviewed-on: https://chromium-review.googlesource.com/c/1367927 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615271} .../api/autofill_private/autofill_private_api.cc | 23 ++++++++++++++++++++++ .../api/autofill_private/autofill_private_api.h | 19 ++++++++++++++++++ .../settings/autofill_page/payments_section.js | 11 +++++++++++ chrome/common/extensions/api/autofill_private.idl | 3 +++ .../autofill/core/browser/autofill_metrics.cc | 6 ++++++ .../autofill/core/browser/autofill_metrics.h | 4 ++++ .../core/browser/autofill_metrics_unittest.cc | 19 ++++++++++++++++++ .../autofill/core/browser/personal_data_manager.cc | 4 ++++ .../autofill/core/browser/personal_data_manager.h | 4 ++++ components/autofill/core/browser/sync_utils.h | 2 ++ .../browser/extension_function_histogram_value.h | 1 + .../closure_compiler/externs/autofill_private.js | 5 +++++ tools/metrics/histograms/enums.xml | 8 ++++++++ tools/metrics/histograms/histograms.xml | 10 ++++++++++ 14 files changed, 119 insertions(+) commit e8c4978dcbaff3639b65b2c35a5e30a8d67a43cc Author: Robert Liao <robliao@chromium.org> Date: Mon Dec 10 21:51:52 2018 +0000 Chromium UI Docs Site Skeleton TBR=kylixrd@chromium.org Docs-only update. Change-Id: I8d73973ae14dba2b805c211682edeb4c68ed8da5 Reviewed-on: https://chromium-review.googlesource.com/c/1370885 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615270} docs/ui/aura/index.md | 7 +++++++ docs/ui/compositor/index.md | 3 +++ docs/ui/frontline_triage.md | 45 +++++++++++++++++++++++++++++++++++++++++++++ docs/ui/index.md | 7 +++++++ docs/ui/navbar.md | 9 +++++++++ 5 files changed, 71 insertions(+) commit 489b58517172cd4d17436e239b8e886f1467c47a Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Dec 10 21:38:44 2018 +0000 De-flake AppShimInteractiveTest.Launch This test depended on a synchronous quitting handshake. Now instead just ensure that the messages are queued before terminate. Bug: 913181 Change-Id: I15428a0fc263d16885a69486ef3f77faf74806cd Reviewed-on: https://chromium-review.googlesource.com/c/1369136 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#615269} .../app_shim/app_shim_interactive_uitest_mac.mm | 25 ++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) commit 580529891757508ee30404e36a2b187db2eedbfd Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Dec 10 21:38:08 2018 +0000 Omnibox Cross-platform UI: Fold QueryInOmnibox into LocationBarModel Now that QueryInOmnibox is stateless (since we are now using connection_info_initialized), it's logic is now small enough to fold into LocationBarModel. Previously, all the inputs of the function were sourced from LocationBarModel anyways, so it's a natural fit. Guide to reviewers: 1. Moves everything from query_in_omnibox.h/cc to location_bar_model_impl.h/cc. 2. Moves everything from query_in_omnibox_unittest.cc to location_bar_model_impl_unittest.cc. 3. Some end-to-end testing code in LocationBarLayoutTest for Query in Omnibox removed in favor of our native unit tests. There's now only one test that tests the integration between LocationBarModel and the Android View. 4. Everything else is mostly just plumbing. This CL removes ~380 SLOC and two classes. Bug: 874592, 912722 Change-Id: I1079d84a6b69a57410bc204ab8cedfdc5d27b3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1366816 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#615268} .../chrome/browser/omnibox/QueryInOmnibox.java | 34 ----- .../chrome/browser/toolbar/LocationBarModel.java | 24 +--- chrome/android/java_sources.gni | 1 - .../browser/omnibox/LocationBarLayoutTest.java | 123 ++-------------- chrome/browser/BUILD.gn | 2 - .../android/omnibox/query_in_omnibox_android.cc | 33 ----- chrome/browser/ui/BUILD.gn | 2 - .../android/toolbar/location_bar_model_android.cc | 10 +- .../android/toolbar/location_bar_model_android.h | 2 +- chrome/browser/ui/omnibox/chrome_omnibox_client.cc | 5 - chrome/browser/ui/omnibox/chrome_omnibox_client.h | 1 - .../browser/ui/omnibox/query_in_omnibox_factory.cc | 56 -------- .../browser/ui/omnibox/query_in_omnibox_factory.h | 45 ------ .../toolbar/chrome_location_bar_model_delegate.cc | 14 ++ .../toolbar/chrome_location_bar_model_delegate.h | 2 + .../browser/ui/views/omnibox/omnibox_view_views.cc | 6 +- .../views/omnibox/omnibox_view_views_unittest.cc | 5 +- components/omnibox/browser/BUILD.gn | 5 +- components/omnibox/browser/location_bar_model.h | 10 +- .../omnibox/browser/location_bar_model_delegate.cc | 8 ++ .../omnibox/browser/location_bar_model_delegate.h | 8 ++ .../omnibox/browser/location_bar_model_impl.cc | 67 ++++++++- .../omnibox/browser/location_bar_model_impl.h | 13 +- .../browser/location_bar_model_impl_unittest.cc | 155 +++++++++++++++++++-- components/omnibox/browser/omnibox_client.cc | 4 - components/omnibox/browser/omnibox_client.h | 2 - components/omnibox/browser/omnibox_edit_model.cc | 32 ++--- components/omnibox/browser/omnibox_edit_model.h | 4 - .../omnibox/browser/omnibox_edit_model_unittest.cc | 25 +--- components/omnibox/browser/omnibox_view.cc | 8 +- components/omnibox/browser/query_in_omnibox.cc | 85 ----------- components/omnibox/browser/query_in_omnibox.h | 69 --------- .../omnibox/browser/query_in_omnibox_unittest.cc | 120 ---------------- .../omnibox/browser/test_location_bar_model.cc | 8 +- .../omnibox/browser/test_location_bar_model.h | 6 +- components/omnibox/browser/test_omnibox_client.cc | 37 +---- components/omnibox/browser/test_omnibox_client.h | 7 - 37 files changed, 331 insertions(+), 707 deletions(-) commit 30a9458e826a1c73880e8a267a324392d2e74eaa Author: Robert Kaplow <rkaplow@chromium.org> Date: Mon Dec 10 21:37:31 2018 +0000 Add new OWNERS to histograms.xml. The idea is to get more teams quicker access to histogram reviews. These owners are intended to provide histogram reviews for their own teams/offices. Bug: 0 Change-Id: Ice320fe40c629c391a256c881a868a279e97dbc1 Reviewed-on: https://chromium-review.googlesource.com/c/1369723 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Alexandr Ilin <alexilin@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#615267} tools/metrics/histograms/OWNERS | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 3510c5b6a056f342a7302304fced3d5b8e5ee4c0 Author: chuanl <chuanl@google.com> Date: Mon Dec 10 21:37:02 2018 +0000 (RELAND) Add setTopBarHeight in ActivityHostImpl. This is guarded by the CCTModuleCustomHeader Finch feature. Bug: 882404 Change-Id: I17ebe63e8316d5fca905c7c14b02e54a79ee913d Reviewed-on: https://chromium-review.googlesource.com/c/1366320 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: John Lin <chuanl@google.com> Cr-Commit-Position: refs/heads/master@{#615266} .../browser/compositor/CompositorViewHolder.java | 9 +++ .../browser/customtabs/CustomTabActivity.java | 30 ++++++++-- .../customtabs/CustomTabTopBarDelegate.java | 19 +++++- .../customtabs/dynamicmodule/ActivityHostImpl.java | 5 ++ .../fullscreen/ChromeFullscreenManager.java | 20 ++++++- .../browser/customtabs/CustomTabActivityTest.java | 69 ++++++++++++++++++++++ 6 files changed, 146 insertions(+), 6 deletions(-) commit 35b82bc8409d987903dae8ff366ebebb9d526bf0 Author: Dan Sanders <sandersd@chromium.org> Date: Mon Dec 10 21:30:36 2018 +0000 [media] Fix race between ready and dismiss in VdaVideoDecoder. During the time between when VdaVideoDecoder posts PictureReady to the parent thread and when that task runs, it is possible for a VDA to dismiss the associated picture buffer. This CL adds a hop through the parent thread for DismissPictureBuffer(). Bug: 906623 Change-Id: I46db8aff8b7687e5ec7b00c70068002fe2f2983e Reviewed-on: https://chromium-review.googlesource.com/c/1362005 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615265} media/gpu/ipc/service/picture_buffer_manager.cc | 16 +++++++++++-- media/gpu/ipc/service/picture_buffer_manager.h | 5 +++-- media/gpu/ipc/service/vda_video_decoder.cc | 26 ++++++++++++++++++---- media/gpu/ipc/service/vda_video_decoder.h | 1 + .../gpu/ipc/service/vda_video_decoder_unittest.cc | 13 +++++++++-- 5 files changed, 51 insertions(+), 10 deletions(-) commit c164ad6966a450787f372a639a0c495a79ee0e20 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Mon Dec 10 21:28:48 2018 +0000 Adding OWNERS for md_downloads directory Since md_downloads directory is owned by the downloads team, it makes sense update its OWNERS file to add the downloads team. Adding the relevant owners in this CL. Change-Id: Ib0dbd62d52d30efb85890f39395b1faf0cf5e950 Reviewed-on: https://chromium-review.googlesource.com/c/1368146 Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615264} chrome/browser/ui/webui/md_downloads/OWNERS | 2 ++ 1 file changed, 2 insertions(+) commit b7b334cba6fc2dd69cbbfe16d912c4e7b1eb77c9 Author: Emircan Uysaler <emircan@chromium.org> Date: Mon Dec 10 21:28:18 2018 +0000 Add codec profile for munging SDP This was a blocker when landing VP9.2 as some the current tests that are designed for testing VP9.0 output were picking up profile 2 instead. The problem was because we only checked codec name when munging SDP. This CL adds an optional profile string check when munging sdp so that we can pick the intended codec from the browser tests. Bug: 908945,webrtc:7925 Change-Id: I10741944d180c0fdcb01c410fbd86b951413fb36 Reviewed-on: https://chromium-review.googlesource.com/c/1366898 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615263} .../media/webrtc/webrtc_browsertest_base.cc | 21 ++++-- .../browser/media/webrtc/webrtc_browsertest_base.h | 13 ++-- .../webrtc/webrtc_internals_perf_browsertest.cc | 18 ++--- .../media/webrtc/webrtc_stats_perf_browsertest.cc | 44 ++++++++----- chrome/test/data/webrtc/munge_sdp.js | 76 ++++++++++++++-------- chrome/test/data/webrtc/peerconnection.js | 16 +++-- 6 files changed, 122 insertions(+), 66 deletions(-) commit fabd6437de4ad6cfb1cc1047e2760228dfec6ddc Author: Eric Orth <ericorth@chromium.org> Date: Mon Dec 10 21:27:15 2018 +0000 Add ericorth to net/ and network/service OWNERS Have now been a committer for >3 months. Change-Id: Ide24d7c60796db5a9f10347b0c3ee83618d436a9 Reviewed-on: https://chromium-review.googlesource.com/c/1370395 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#615262} net/OWNERS | 1 + net/dns/OWNERS | 3 +-- services/network/OWNERS | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) commit 68fd9f0ca1c2084e32cc8f2f4742a64b337dd92a Author: Joe Mason <joenotcharles@google.com> Date: Mon Dec 10 21:25:11 2018 +0000 Remove uses of LASTCHANGE in chrome_cleaner. R=proberge Bug: 913585 Change-Id: I42297b168d776767c56c83442df6eb3bed222e88 Reviewed-on: https://chromium-review.googlesource.com/c/1370401 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615261} chrome/chrome_cleaner/constants/BUILD.gn | 1 - chrome/chrome_cleaner/constants/args.gni | 3 --- chrome/chrome_cleaner/constants/version.h.in | 4 ---- chrome/chrome_cleaner/logging/BUILD.gn | 1 - .../logging/interface_log_service.cc | 22 +++++++++------------- .../chrome_cleaner/logging/interface_log_service.h | 9 ++++++--- .../logging/interface_log_service_unittest.cc | 21 ++++++++++++--------- 7 files changed, 27 insertions(+), 34 deletions(-) commit 1b67a2dd5ee757cb5fbd7bae04dc03ef7e86d4c7 Author: David Dorwin <ddorwin@chromium.org> Date: Mon Dec 10 21:23:56 2018 +0000 Enable GamepadButton's touched attribute by default Per approval in https://groups.google.com/a/chromium.org/d/topic/blink-dev/pc5Jx9qcEJo/discussion Bug: 830140 Change-Id: Ib7e90aa7a5c6eb557c82c9d7389ea27f1a710286 Reviewed-on: https://chromium-review.googlesource.com/c/1003133 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by: Daniel Bratell <bratell@opera.com> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#615260} third_party/blink/renderer/modules/gamepad/gamepad_button.idl | 3 +-- .../webexposed/xr/webvr-gamepad-origin-trial-interfaces.html | 1 - .../webexposed/xr/webxr-gamepad-origin-trial-interfaces.html | 1 - .../virtual/stable/webexposed/global-interface-listing-expected.txt | 1 + 4 files changed, 2 insertions(+), 4 deletions(-) commit 2031ed79af66eeb4ecc1562059c65e51267a5c5a Author: Joe Mason <joenotcharles@google.com> Date: Mon Dec 10 21:23:35 2018 +0000 Revert "Load the Chrome Cleaner partner logo SVG with <embed>." This reverts commit 3d20a937aa2b6e7ae8bb06d4e55cdcfcf9fc5e3d. Reason for revert: Triggering the test failure in https://crbug.com/912618 Original change's description: > Load the Chrome Cleaner partner logo SVG with <embed>. > > The logo now has a title attr in it for screen readers. But when its > set as the background of a <span>, or as an <img> src, screen readers > don't look at the tags inside. For the screen reader to view the tag, > it seems the <svg> element must be part of the DOM tree, such as when > it's added with <embed>. > > Bug: 767130 > Change-Id: I5d28030fc90c269aa6a13a605f24c698915f6c5d > Reviewed-on: https://chromium-review.googlesource.com/c/1352822 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Joe Mason <joenotcharles@google.com> > Cr-Commit-Position: refs/heads/master@{#612409} TBR=hcarmona@chromium.org,joenotcharles@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 767130 Change-Id: I452435cbd4e21325d9ed8d93bc2a48bf084752c7 Reviewed-on: https://chromium-review.googlesource.com/c/1370201 Reviewed-by: Joe Mason <joenotcharles@google.com> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#615259} .../settings/chrome_cleanup_page/chrome_cleanup_page.html | 1 + .../webui/settings/md_settings_localized_strings_provider.cc | 10 +++------- chrome/browser/ui/webui/settings/md_settings_ui.cc | 6 ------ 3 files changed, 4 insertions(+), 13 deletions(-) commit 6f052d6549d7c1fc34811fee5c187555afe429fb Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Dec 10 21:22:36 2018 +0000 [Mfill Android] Bind wrapped accessory tab data to legacy views This CL binds the new accessory sheet tab model to the existing views. This enables two things: - Deprecation of the "Item" class - Adding a second view binder for modern views crrev/c/1367650 The underlying idea for this change is to keep the consistent model while allowing different view binders. This allows to change the appearance of the accessory sheet depending on flags. Details here: go/keyboard-accessory-v2#heading=h.zhlmmn68rx2p The user-visible changes? None. This CL only prepares for modern views (see crrev/c/1367650). (It used to happen all in this CL, but I decided to split it) Bug: 853772, 911084 Change-Id: Id1933a66fea7dfc211c747bc5ed1dd749871fdfd Reviewed-on: https://chromium-review.googlesource.com/c/1356547 Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615258} ...rd_accessory_sheet_tab_legacy_password_info.xml | 32 ++++ .../layout/password_accessory_sheet_divider.xml | 9 - .../res/layout/password_accessory_sheet_label.xml | 32 +++- .../password_accessory_sheet_legacy_option.xml | 33 ++++ .../res/layout/password_accessory_sheet_option.xml | 16 -- .../layout/password_accessory_sheet_suggestion.xml | 13 -- .../password_accessory_sheet_top_divider.xml | 8 - chrome/android/java/res/values/dimens.xml | 2 + .../AccessorySheetTabCoordinator.java | 54 ++++++ ...Properties.java => AccessorySheetTabModel.java} | 28 +-- .../AccessorySheetTabViewBinder.java | 45 +++++ .../keyboard_accessory/KeyboardAccessoryData.java | 163 +---------------- .../KeyboardAccessoryMetricsRecorder.java | 16 +- .../PasswordAccessorySheetCoordinator.java | 80 +++----- .../PasswordAccessorySheetMediator.java | 52 +----- .../PasswordAccessorySheetView.java | 7 - .../PasswordAccessorySheetViewBinder.java | 203 ++++++++------------- chrome/android/java_sources.gni | 4 +- .../keyboard_accessory/AccessorySheetViewTest.java | 7 +- .../PasswordAccessoryIntegrationTest.java | 4 - .../PasswordAccessorySheetViewTest.java | 93 +++++----- .../ManualFillingControllerTest.java | 6 +- .../PasswordAccessorySheetControllerTest.java | 77 +++----- 23 files changed, 405 insertions(+), 579 deletions(-) commit 43b260ae281011748f1eba6185abfe7b0d3d304c Author: Jason Guo <jiahuiguo@chromium.org> Date: Mon Dec 10 21:21:30 2018 +0000 Use feedback flag to guard credit card icon animation. Bug: 897998 Change-Id: Ifb6d6e8a2698e2b9065b0758101e58568a6ec478 Reviewed-on: https://chromium-review.googlesource.com/c/1367119 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615257} .../ui/autofill/local_card_migration_dialog_controller_impl.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 86a4de25ea0c3cfc78d93944d44882513bac715a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Dec 10 21:20:09 2018 +0000 Roll src-internal b12d02f6627f..ee0eac216fb4 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b12d02f6627f..ee0eac216fb4 Created with: gclient setdep -r src-internal@ee0eac216fb4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5850d60f47968402f66b894234cdf24a095c745a Reviewed-on: https://chromium-review.googlesource.com/c/1370324 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615256} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f520434084bd497bc5bf62c2927734735e89a35d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 21:19:38 2018 +0000 Roll src/third_party/perfetto 2efdf1d56ab2..f81bcea780c2 (11 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/2efdf1d56ab2..f81bcea780c2 git log 2efdf1d56ab2..f81bcea780c2 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 hjd@google.com Merge "protozero: Fix Chrome roll" 2018-12-10 fmayer@google.com fuzzing: Install build deps in build step. 2018-12-10 fmayer@google.com fuzzing: Remove .git repos of buildtools earlier. 2018-12-10 fmayer@google.com Merge "fuzzing: Fix travis." 2018-12-10 fmayer@google.com Merge "fuzzing: Remove .git of buildtools." 2018-12-10 lalitm@google.com Merge "trace_processor: improve handling of nulls on all columns" 2018-12-10 fmayer@google.com fuzzing: Read correct proto-table on OSS-Fuzz. 2018-12-10 fmayer@google.com Merge "Fix CPU Reader fuzzer." 2018-12-10 lalitm@google.com Merge "trace_processor: add test for computing RSS for various oom_adj_states" 2018-12-10 hjd@google.com Merge "protozero: Fix intX_t to varint where X < 64" 2018-12-10 lalitm@google.com Merge "trace_processor: remove all usages of uint64_t" Created with: gclient setdep -r src/third_party/perfetto@f81bcea780c2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:69150303 TBR=perfetto-bugs@google.com Change-Id: I8d7001270629d7ce4bf8a6af07309901bbf70418 Reviewed-on: https://chromium-review.googlesource.com/c/1370075 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615255} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4270514436c11b1e0aee0272ae05cbe692019011 Author: kokihoon <rhrlgns777@gmail.com> Date: Mon Dec 10 21:18:33 2018 +0000 Use ContainsValue() instead of std::find() in utility/ Bug: 561800 Change-Id: Ia6b428e08aafd2d587677046a8aa0e713cdac329 Reviewed-on: https://chromium-review.googlesource.com/c/1366455 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615254} chrome/utility/importer/ie_importer_win.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit 87a858ece115341231f5796c6ecf03352d282b00 Author: mrefaat <mrefaat@chromium.org> Date: Mon Dec 10 21:15:31 2018 +0000 Inline the usage of back/forward navigationManger methods in BVC methods: canGoForward, canGoBack, goForward, goBack can be directly used from NavigationManger which is accessible from the webstate Bug: 899598 Change-Id: Id9afd8b1d79e5f1c28d0423717c007cadddc4972 Reviewed-on: https://chromium-review.googlesource.com/c/1367873 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#615253} ios/chrome/browser/ui/browser_view_controller.mm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit c0c7d3c7215b22456d2ff559ccd509ca7b22efd4 Author: Dmitry Gozman <dgozman@chromium.org> Date: Mon Dec 10 21:09:20 2018 +0000 WebURLLoaderMock: do not call DidReceiveResponse on failures The real url loader does not notify about response if it failed before receiving first byte of the body data. Our current of calling DidReceiveResponse before DidFail without a single byte of data disagrees with navigation flow, which never sends a response if failed before receiving the body. This patch unblocks synchronous navigation commit from DidReceiveResponse, as opposite to DidReceiveData. Bug: 855189 Change-Id: I48691bc21a5886d3b24e14b5c1d3e2df6e36bb33 Reviewed-on: https://chromium-review.googlesource.com/c/1368653 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615252} .../blink/renderer/core/loader/threadable_loader_test.cc | 3 --- .../blink/renderer/platform/testing/weburl_loader_mock.cc | 10 +++++----- 2 files changed, 5 insertions(+), 8 deletions(-) commit 340b590451023790134cde96d82dfff9f64eb790 Author: mrefaat <mrefaat@chromium.org> Date: Mon Dec 10 21:08:35 2018 +0000 Stop Disabling Web Usage for browsing data clearing on iOS 12 This should fix that clear browsing data doesn't work on cold start for NTP & Reading list. Bug: 900176, 632772 Test: - Clear browsing data works as expected (cookie, visited links, etc..) Change-Id: I673bd354c1cbe46e7768ccfded1f858e3a19fad0 Reviewed-on: https://chromium-review.googlesource.com/c/1350883 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615251} ios/chrome/app/main_controller.mm | 19 ++++++++++++++++++- ios/chrome/browser/ui/browser_view_controller.h | 14 ++++++++++++++ ios/chrome/browser/ui/browser_view_controller.mm | 21 +++++++++++++++++++++ 3 files changed, 53 insertions(+), 1 deletion(-) commit a267525eb095936d2e3317fd41efef2baf7ee03f Author: Danyao Wang <danyao@chromium.org> Date: Mon Dec 10 21:06:36 2018 +0000 Reland "[Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation." This is a reland of a1b00bf181dd7ee4a636cc3e1f678e99223f5466 Original change's description: > [Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation. > > The test expectations added for RequestInfo were always broken, but it > was not discovered because slim-nav was not run on CQ. > > Bug: 851119 > Change-Id: Ia9949553d9a0b97cb16a8435b5f8c95084ab1880 > Reviewed-on: https://chromium-review.googlesource.com/c/1369004 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615131} Bug: 851119 Change-Id: I8bb26c31d4164e29dce171a0d118672975551946 Reviewed-on: https://chromium-review.googlesource.com/c/1370194 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615250} ios/web/web_state/web_state_observer_inttest.mm | 43 ++++++++++++++----------- 1 file changed, 25 insertions(+), 18 deletions(-) commit 0f6de13c9c04e5d38684183dbb7405e985c8b5f2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 21:05:55 2018 +0000 Roll src/third_party/pdfium 32660f54f795..99b9ffb79d92 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/32660f54f795..99b9ffb79d92 git log 32660f54f795..99b9ffb79d92 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 tsepez@chromium.org Rename xfa_basic_data_{enum,element_script}.cpp to match header file name Created with: gclient setdep -r src/third_party/pdfium@99b9ffb79d92 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I85580c73bef5cc53c55dd15b35fbe707685a0d6b Reviewed-on: https://chromium-review.googlesource.com/c/1370076 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615249} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0660e08731fd42076d7242068e9eaed1482b14d5 Author: Bettina <bdea@chromium.org> Date: Mon Dec 10 21:03:02 2018 +0000 Call CanCaptureVisiblePage in page capture API. Currently the pageCapture permission allows access to arbitrary local files and chrome:// pages which can be a security concern. In order to address this, the page capture API needs to be changed similar to the captureVisibleTab API. The API will now only allow extensions to capture otherwise-restricted URLs if the user has granted activeTab. In addition, file:// URLs are only capturable with the "Allow on file URLs" option enabled. Bug: 893087 Change-Id: I6d6225a3efb70fc033e2e1c031c633869afac624 Reviewed-on: https://chromium-review.googlesource.com/c/1330689 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615248} chrome/browser/extensions/active_tab_unittest.cc | 24 ++-- .../api/page_capture/page_capture_api.cc | 36 ++++- .../extensions/api/page_capture/page_capture_api.h | 4 + .../api/page_capture/page_capture_apitest.cc | 31 ++++ chrome/browser/extensions/api/tabs/tabs_api.cc | 3 +- chrome/browser/extensions/extension_apitest.cc | 7 + chrome/browser/extensions/extension_apitest.h | 7 + .../permissions/permissions_data_unittest.cc | 157 ++++++++++++++++----- .../data/extensions/api_test/page_capture/test.js | 97 +++++++++---- extensions/common/manifest_constants.cc | 1 + extensions/common/manifest_constants.h | 1 + extensions/common/permissions/permissions_data.cc | 73 ++++++---- extensions/common/permissions/permissions_data.h | 16 ++- 13 files changed, 355 insertions(+), 102 deletions(-) commit 1ad0791810d6bde1bac5faa11380836caddbc944 Author: Bill Budge <bbudge@chromium.org> Date: Mon Dec 10 21:02:00 2018 +0000 Update expiration data for SiteIsolatedCodeCache.WASM.Behaviour - Pushes out expiration date from 12/31/18 to 6/30/19. Bug: chromium:911293 Change-Id: Id19e12b0f65d0f8a7743e504afeabc4bc796fa7d Reviewed-on: https://chromium-review.googlesource.com/c/1359459 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#615247} tools/metrics/histograms/histograms.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit aec72e9e9c13bdc488f11e7b165c73270fd40b6f Author: John Budorick <jbudorick@chromium.org> Date: Mon Dec 10 20:57:40 2018 +0000 Use luci-notify for cr-fuchsia bot failure notifications. Bug: 911309 Change-Id: I06a50c902a7ce1b664a471b06f9d7abc6e4c87cc Reviewed-on: https://chromium-review.googlesource.com/c/1370584 Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615246} infra/config/global/luci-notify.cfg | 38 +++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) commit 9f82b04439fddcc9fc8cbd568efa85dcb639d82b Author: bsheedy <bsheedy@chromium.org> Date: Mon Dec 10 20:54:19 2018 +0000 Deflake VR browser fling scrolling test Makes the VR browser fling scrolling test less flaky by changing its testing approach. Before, we performed a fling scroll, recorded where the scroll position was after the input was finished, and asserted that we kept scrolling after that. This was prone to timing issues since it was possible to record the scroll position after the fling had already ended. Instead, we now perform a non-fling scroll at the same speed as the fling scroll, record how far it scrolled, and assert that a fling scroll scrolls further than that. Bug: 910549 Change-Id: I3afcfb68c915dc8ab13202da1db895eb9b398ade Reviewed-on: https://chromium-review.googlesource.com/c/1366697 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#615245} .../browser/vr/VrBrowserControllerInputTest.java | 58 ++++++++++++++++++---- .../chrome/browser/vr/util/NativeUiUtils.java | 28 +++++++++-- .../content/browser/RenderCoordinatesImpl.java | 10 ++-- .../content_public/browser/RenderCoordinates.java | 5 ++ 4 files changed, 84 insertions(+), 17 deletions(-) commit 71e957aaa499195b5ccb380c66b6a734596cc49d Author: Ken Rockot <rockot@google.com> Date: Mon Dec 10 20:49:53 2018 +0000 Fix assistant UI focus and ax behavior This corrects the behavior of UI focus (including Tab cycling) and accessibility interaction in the Chrome OS Assistant UI. This requires minimal changes to Assistant code to forward focus events to its NavigableContents. More substantial changes are made to Content Service, namely: - NavigableContents now supports forwarding simple focus events to its service-side WebContents impl - NavigableContents now receives updates about AX tree changes from the service-side WebContents impl, and forwards them to the UI subsystem within the client process. Bug: 910556 Change-Id: Ic7010b966b0a7c5304861780462b6c82685b0184 Reviewed-on: https://chromium-review.googlesource.com/c/1366757 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615244} ash/assistant/ui/assistant_container_view.cc | 7 +++++ .../assistant_container_view_focus_traversable.cc | 28 ++++++++----------- ash/assistant/ui/assistant_web_view.cc | 12 +++++++++ ash/assistant/ui/assistant_web_view.h | 2 ++ content/browser/content_service_delegate_impl.cc | 16 +++++++++++ services/content/navigable_contents_delegate.h | 8 ++++++ services/content/navigable_contents_impl.cc | 8 ++++++ services/content/navigable_contents_impl.h | 2 ++ services/content/public/cpp/BUILD.gn | 2 ++ services/content/public/cpp/DEPS | 1 + services/content/public/cpp/navigable_contents.cc | 18 +++++++++++-- services/content/public/cpp/navigable_contents.h | 15 +++++++++++ .../content/public/cpp/navigable_contents_view.cc | 31 +++++++++++++++++++--- .../content/public/cpp/navigable_contents_view.h | 7 ++++- .../public/cpp/test/fake_navigable_contents.cc | 4 +++ .../public/cpp/test/fake_navigable_contents.h | 2 ++ services/content/public/mojom/BUILD.gn | 1 + .../content/public/mojom/navigable_contents.mojom | 13 +++++++++ services/content/service_unittest.cc | 4 +++ 19 files changed, 158 insertions(+), 23 deletions(-) commit e23c6b9cd8e22c2ab099c135c5dd6d1aae0e084e Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Dec 10 20:49:12 2018 +0000 Disable ChromeKeyboardUITest with Window Service Bug: 912700 Change-Id: I0e0c82ea6344d92ba06e6e956663d788680a3d8f Reviewed-on: https://chromium-review.googlesource.com/c/1368029 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#615243} chrome/browser/ui/ash/keyboard/chrome_keyboard_ui_unittest.cc | 7 +++++++ .../filters/chromeos.single_process_mash.fyi.unit_tests.filter | 3 --- 2 files changed, 7 insertions(+), 3 deletions(-) commit cd56de26542bdaaaeba5e79bb3e9b7b4cd5364d5 Author: Xiaoqian Dai <xdai@chromium.org> Date: Mon Dec 10 20:45:50 2018 +0000 Small bug fixing for WindowPreviewView. Bug: None Change-Id: I698e5b5f07486854bab175991be05f4bd0914143 Reviewed-on: https://chromium-review.googlesource.com/c/1370321 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#615242} ash/wm/overview/scoped_transform_overview_window.cc | 10 +++++----- ash/wm/window_preview_view.cc | 8 +++++++- ash/wm/window_preview_view.h | 4 ++++ 3 files changed, 16 insertions(+), 6 deletions(-) commit 970b4e3fd0906a4f69b0e9c8c846b35f2bb5c088 Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Dec 10 20:45:35 2018 +0000 Fix missing affected histogram suffix for Sync.E2ELatency Follow-up to https://chromium-review.googlesource.com/c/1292567 where the metric was instrumented, and where the relation between the new histogram and the suffix was forgotten. Bug: 902343 Change-Id: I1a9de66f522ebcdc70ded3cb3449e1b1783a6a98 Reviewed-on: https://chromium-review.googlesource.com/c/1370165 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615241} tools/metrics/histograms/histograms.xml | 1 + 1 file changed, 1 insertion(+) commit aa9db4fee115ad4398d8cdfe34b597c94e33caa5 Author: Aran Gilman <gilmanmh@google.com> Date: Mon Dec 10 20:44:44 2018 +0000 Compute table-related ARIA attributes in Mac-specific code. This should make the Mac AXTree's output the same as in Blink for the impacted attributes, since the Blink formatter already computes them. Bug: 904896 Change-Id: I94dde0d392c6bebcb0bf7601165b09d17af5b9c9 Reviewed-on: https://chromium-review.googlesource.com/c/1366483 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615240} .../accessibility/browser_accessibility_cocoa.mm | 32 ++++++---------------- .../aria/table-column-hidden-expected-mac.txt | 8 +++--- 2 files changed, 12 insertions(+), 28 deletions(-) commit c5364c523d688371e28e5a57455ac3d945acaf9f Author: Mark Pearson <mpearson@chromium.org> Date: Mon Dec 10 20:44:27 2018 +0000 revive low-entropy source histogram Bug: 910773,881517 Change-Id: I0d8b6c4b6bbdff44407ce8a4a346660db01bf159 Reviewed-on: https://chromium-review.googlesource.com/c/1368524 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#615239} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9065668707ba95c68c263e2224ce7d81729e05de Author: Jason Guo <jiahuiguo@chromium.org> Date: Mon Dec 10 20:41:27 2018 +0000 [Paradise] Pass bool to controller on whether to show error or feedback Previously we used empty vector to do if to show error dialog, but in this way the dialog did not know how many cards user selected to upload, thus did not know what error message to show (This card vs These cards). Bug: 897998 Change-Id: If4d65e5330ab60f0645dd5d5a45d3d15c9a75ae1 Reviewed-on: https://chromium-review.googlesource.com/c/1366790 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Commit-Queue: Jason Guo <jiahuiguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615238} android_webview/browser/aw_autofill_client.cc | 1 + android_webview/browser/aw_autofill_client.h | 1 + chrome/browser/ui/autofill/chrome_autofill_client.cc | 4 +++- chrome/browser/ui/autofill/chrome_autofill_client.h | 1 + chrome/browser/ui/autofill/manage_migration_ui_controller.cc | 5 +++-- chrome/browser/ui/autofill/manage_migration_ui_controller.h | 1 + components/autofill/core/browser/autofill_client.h | 8 +++++--- components/autofill/core/browser/local_card_migration_manager.cc | 6 ++---- components/autofill/core/browser/test_autofill_client.cc | 1 + components/autofill/core/browser/test_autofill_client.h | 1 + ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.h | 1 + ios/chrome/browser/ui/autofill/chrome_autofill_client_ios.mm | 1 + ios/web_view/internal/autofill/web_view_autofill_client_ios.h | 1 + ios/web_view/internal/autofill/web_view_autofill_client_ios.mm | 1 + 14 files changed, 23 insertions(+), 10 deletions(-) commit 63907a118b2d1e09eff577c09e7c9ba1c99d84b3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 20:40:44 2018 +0000 Roll src/third_party/skia be5a09332e5d..a72e8d3f4053 (8 commits) https://skia.googlesource.com/skia.git/+log/be5a09332e5d..a72e8d3f4053 git log be5a09332e5d..a72e8d3f4053 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-12-10 scroggo@google.com SkWuffsCodec: swizzle only the dirty rect 2018-12-10 scroggo@google.com Fix decoding RAW images to 565 2018-12-10 michaelludwig@google.com End color analysis early when color becomes unknown 2018-12-10 brianosman@google.com Disable skiaserve target for Windows ARM64 2018-12-10 brianosman@google.com Disable Vulkan on Windows ARM64 2018-12-10 brianosman@google.com Add minimal documentation about Windows on ARM64 2018-12-10 michaelludwig@google.com Reland "Add clamp to border wrap mode to gpu" Created with: gclient setdep -r src/third_party/skia@a72e8d3f4053 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I60b6c10cafdf87635d1217c823b5bc481dcd9612 Reviewed-on: https://chromium-review.googlesource.com/c/1370344 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615237} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d3b25e1380984b2f1f23d0e8dc1a337743c6caaf Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Mon Dec 10 20:40:23 2018 +0000 [Extensions] Increase reload leniency for unpacked extensions Decrease reload interval for unpacked extensions to 1s and increase reload count to 30 before disabling the extension. This should make it easier for developers to test their unpacked extensions while still preventing browser deadlocks from extensions which reload too often. Bug: 733209 Change-Id: I75467a4e6910696e4c12f34304222f3d46a4e11f Reviewed-on: https://chromium-review.googlesource.com/c/1340272 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615236} .../api/runtime/chrome_runtime_api_delegate.cc | 31 +++++- .../chrome_runtime_api_delegate_unittest.cc | 113 +++++++++++++++++++++ 2 files changed, 141 insertions(+), 3 deletions(-) commit c5eeb99137c09f52587ad0134f25e5e790f4de74 Author: Alex Leung <alexleung@google.com> Date: Mon Dec 10 20:36:10 2018 +0000 Handle SecurityException in getFactoryLocaleList A security exception can occur during unit tests when permissions are missing. Bug: internal b/1366389 Test: Ran cast_l10n_internal_unittests Change-Id: I25b8cca7715c5127433cdf34450d79c9a3c414f4 Reviewed-on: https://chromium-review.googlesource.com/c/1368766 Commit-Queue: Alex Leung <alexleung@google.com> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#615235} .../src/org/chromium/chromecast/shell/CastSysInfoAndroidThings.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 54ab13b87d886318f8b443c5d675375587e2ab12 Author: Peter Wen <wnwen@chromium.org> Date: Mon Dec 10 20:35:37 2018 +0000 Android: Use d8's desugaring for debug Rather than using desugar.jar, simply fold desugaring into the dexing step. This works for debug and we may try it with release builds later, but since release builds take much longer anyways, it's not as urgent. Estimated savings: ~3.9s Change-Id: I34b968ff1080c5238e41fe88864de9f2c7452da3 Bug: 906803 Reviewed-on: https://chromium-review.googlesource.com/c/1362101 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#615234} build/android/gyp/dex.py | 20 +++++++++++++++++++- build/config/android/internal_rules.gni | 20 +++++++++++++++++++- 2 files changed, 38 insertions(+), 2 deletions(-) commit 0eb5f9cb8416ac531a6847a0c76d057fbc1ea993 Author: Sven Sauleau <ssauleau@igalia.com> Date: Mon Dec 10 20:33:27 2018 +0000 Mark Wasm's Memory and Table js-api as failing Fix and re-enable tests for WebAssembly's memory/constructor and table/constructor js-api. Bug: v8:8319 Change-Id: Ic821d897d04e79a5e5cb891e9a1b506e2c3e0cc5 Reviewed-on: https://chromium-review.googlesource.com/c/1369184 Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615233} third_party/blink/web_tests/TestExpectations | 5 +++++ 1 file changed, 5 insertions(+) commit fd73f72a241de11dd734b0fd0f3996781aa7d35d Author: Brian Salomon <bsalomon@google.com> Date: Mon Dec 10 20:33:15 2018 +0000 Provide glTexParameterf[v] to GrGLInterface Change-Id: I0cb5f33ea997ec0adbe846d94b654277ebe253f8 Reviewed-on: https://chromium-review.googlesource.com/c/1368996 Reviewed-by: Jonathan Backer <backer@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#615232} gpu/skia_bindings/gl_bindings_skia_cmd_buffer.cc | 4 ++++ ui/gl/init/create_gr_gl_interface.cc | 2 ++ 2 files changed, 6 insertions(+) commit 9a9ff5977f3d15bc7fb0e8d4ad2410c3280f1c49 Author: Eric Roman <eroman@chromium.org> Date: Mon Dec 10 20:30:45 2018 +0000 Use SetBoolean() in place of SetString(). Change-Id: I4fe0e835a30c46e55c50feb9aa4aab9040956ec2 Reviewed-on: https://chromium-review.googlesource.com/c/1368951 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615231} net/http/http_stream_factory_job.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit d587561ae75deb5e1f310cca81e59ab5970e7e3f Author: Joshua Peraza <jperaza@chromium.org> Date: Mon Dec 10 20:29:20 2018 +0000 android: Restore crash signal handlers for child processes The original tombstone producing signal handlers are still used by tests. This can be revisited later: https://bugs.chromium.org/p/chromium/issues/detail?id=912306 Bug: 911678, 912166, 912161 Change-Id: I55c0627bc431c6d61872a60d47423fd99567028f Reviewed-on: https://chromium-review.googlesource.com/c/1361597 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615230} components/crash/content/app/crashpad_linux.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 24af66b6ba675d93cf3375ead4b843d53fc08a94 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Dec 10 20:28:27 2018 +0000 Reduce chrome_public_test_apk to 0% experimental on arm64 CQ bot. The test load is too high currently: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel This'll help reduce the load while I investigate a more permanent fix. R=jbudorick NOTRY=true Change-Id: If09ffbc611c15ba8e151ce52fe9502371a574dee Reviewed-on: https://chromium-review.googlesource.com/c/1370470 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#615229} testing/buildbot/chromium.android.json | 2 +- testing/buildbot/test_suite_exceptions.pyl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 8ce446b79ad0d89a89d99320367762a862d3ff80 Author: Alexander Shah <zandershah@google.com> Date: Mon Dec 10 20:27:47 2018 +0000 viz: Fix rect manipulation bugs in hit-test visualizer. Matrices were being multiplied in the wrong order which causes the positioning to be incorrect when the transformations include stretches (e.g. mobile). Rectangles also have no guarantee to be at integer coordinates so enclosed rect is more correct. R=riajiang@chromium.org Change-Id: I17bbe585341b9a9c6690271180576de277714e78 Reviewed-on: https://chromium-review.googlesource.com/c/1370188 Reviewed-by: Ria Jiang <riajiang@chromium.org> Commit-Queue: Alexander Shah <zandershah@google.com> Cr-Commit-Position: refs/heads/master@{#615228} components/viz/service/hit_test/hit_test_aggregator.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit abb7dd4bca1aac4d2ff1afaaa439bafe9052966a Author: Stefan Zager <szager@chromium.org> Date: Mon Dec 10 20:25:59 2018 +0000 [Sheriff] Fix TextExpecations line for crashing test BUG=905827 TBR=eirage@chromium.org NOTRY=true Change-Id: Ib1ef7ef7d430e5142b751a7f0abed3f09d4856ab Reviewed-on: https://chromium-review.googlesource.com/c/1370645 Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#615227} third_party/blink/web_tests/TestExpectations | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6dfbe29d74eeed5d16e85d5db9d25b4e63dc4aed Author: Weiyong Yao <braveyao@chromium.org> Date: Mon Dec 10 20:25:32 2018 +0000 Handle changing source request during desktop sharing session This cl is part of the CLs for dynamic change of screenshare source. This cl is to handle the source change request when user clicks the proposed 'change source' button on the notification bar, by bringing up the screenshare picker again and processing the user selection. The UI change will be in the following CLs. Bug: 892201 Change-Id: Id4676a7d48487d0bfee136b021febbbaf1b947b8 Reviewed-on: https://chromium-review.googlesource.com/c/1354442 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615226} .../media/webrtc/desktop_capture_access_handler.cc | 210 +++++++++++++++++- .../media/webrtc/desktop_capture_access_handler.h | 53 ++++- .../desktop_capture_access_handler_unittest.cc | 247 +++++++++++++++++++++ .../webrtc/media_stream_devices_controller.cc | 4 + chrome/test/BUILD.gn | 1 + .../capture/desktop_capture_device_uma_types.h | 3 + .../media/media_stream_dispatcher_host.cc | 12 + .../media/media_stream_dispatcher_host.h | 3 + .../renderer_host/media/media_stream_manager.cc | 164 ++++++++++++-- .../renderer_host/media/media_stream_manager.h | 23 +- .../media/media_stream_manager_unittest.cc | 126 ++++++++++- content/public/common/media_stream_request.h | 1 + tools/metrics/histograms/enums.xml | 3 + tools/metrics/histograms/histograms.xml | 2 +- 14 files changed, 818 insertions(+), 34 deletions(-) commit e9e7a3e8b9070ac89cfc487175c8b8d4d1824fb2 Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Dec 10 20:22:50 2018 +0000 [ScrollTimeline] Upstream root scroller currentTime test to WPT This CL upstreams the root scroller currentTime test to WPT. The quirks mode test is left in fast/animation/scroll-animations as it is just a crash test for running in quirks mode, which is Chrome-specific and not upstreamable. There are no behavioral changes. Bug: 911254 Change-Id: Ia8270f11ede8746cbdecf7ba57aeca60eee6fb78 Reviewed-on: https://chromium-review.googlesource.com/c/1366367 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615225} .../scroll-animations/current-time-root-scroller.html} | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) commit cf2328b3957736fd3cfc249cb0195f6d5b44f6ae Author: Dana Fried <dfried@chromium.org> Date: Mon Dec 10 20:20:17 2018 +0000 Add accessible title for profile management drop-down. Bug: 867723 Change-Id: I2dd0dee4133a93648ee8b03cf237416b0be8928d Reviewed-on: https://chromium-review.googlesource.com/c/1368838 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#615224} chrome/app/profiles_strings.grdp | 3 +++ chrome/browser/ui/views/profiles/profile_chooser_view.cc | 5 +++++ chrome/browser/ui/views/profiles/profile_chooser_view.h | 1 + 3 files changed, 9 insertions(+) commit 5fac4ca37c3c511e9e92f6f28a4a39f66ca6a355 Author: Lei Zhang <thestig@chromium.org> Date: Mon Dec 10 20:19:32 2018 +0000 Fix nits in content::WebContentsDelegate. - Consistently inline empty virtual methods in the header. - No need for content:: prefix in namespace content. - Fix lint errors. Change-Id: If7b9f3d5edc2abfd26c9df82d4a83b3602e428c1 Reviewed-on: https://chromium-review.googlesource.com/c/1370306 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#615223} content/public/browser/web_contents_delegate.cc | 32 ++++++++----------------- content/public/browser/web_contents_delegate.h | 26 ++++++++++---------- 2 files changed, 23 insertions(+), 35 deletions(-) commit 6a10970531ebf944fa756e7246e777489a651e25 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Dec 10 20:14:03 2018 +0000 Instant Tethering: Rewrite the KeepAliveOperation test. * Updates test logic to use the new SecureChannel flow. * Removes references to BleConnectionManager. * Splits out specific test assertions into separate tests. R=khorimoto@chromium.org Bug: none Test: KeepAliveOperationTest.* Change-Id: Ia847747487903aabbf206133aaa40d2994c94fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1368459 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#615222} chromeos/components/tether/keep_alive_operation.h | 4 + .../tether/keep_alive_operation_unittest.cc | 201 +++++++++++---------- .../components/tether/message_transfer_operation.h | 1 + 3 files changed, 114 insertions(+), 92 deletions(-) commit d35a1698879c1fb44285b4d951189ec258886f64 Author: Aran Gilman <gilmanmh@google.com> Date: Mon Dec 10 20:12:05 2018 +0000 Refactor code for getting computed table attributes in the Blink formatter. Computed values are now returned even when the original node does not contain an explicitly set attribute. Restricting the computation of certain attributes to certain kinds of nodes easier is also now slightly easier to do. The intent of this change is to move some of the cleanup needed by https://crrev.com/c/1351500 into smaller, separate CLs. Bug: 832289 Change-Id: I91c1135b334ba020da3e5e825231533e912bfe02 Reviewed-on: https://chromium-review.googlesource.com/c/1361792 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615221} .../accessibility_tree_formatter_blink.cc | 118 ++++++++++----------- .../aria/table-column-hidden-expected-blink.txt | 2 +- 2 files changed, 60 insertions(+), 60 deletions(-) commit 7a4e9407c44da143c5cab0ebcd500c922db57a09 Author: Stephen Martinis <martiniss@chromium.org> Date: Mon Dec 10 20:11:49 2018 +0000 Add gtest hackathon bots # android-marshmallow-arm64-rel seems to be failing in TPU, which is # unrelated to this CL. NOTRY=true Bug: 912697 Change-Id: Ifb0f887ee2accae3a7e7993a33e254eb447d414e Reviewed-on: https://chromium-review.googlesource.com/c/1368954 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615220} infra/config/global/cr-buildbucket.cfg | 5 + infra/config/global/luci-milo.cfg | 4 + infra/config/global/luci-scheduler.cfg | 24 ++ testing/buildbot/chromium.fyi.json | 708 +++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 6 + tools/mb/mb_config.pyl | 1 + 6 files changed, 748 insertions(+) commit 6a8c549dd81e2932b9b103046b1121e2eaef9f30 Author: Evan Stade <estade@chromium.org> Date: Mon Dec 10 20:09:37 2018 +0000 Add filter for a flaky unit test in single process mash. Bug: 905430, 913577 Change-Id: I5625b7d5dfde7528ef0480046c27cd904804d7ed Reviewed-on: https://chromium-review.googlesource.com/c/1370386 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#615219} .../filters/chromeos.single_process_mash.fyi.unit_tests.filter | 3 +++ 1 file changed, 3 insertions(+) commit f9c457323cd20123df8ec1d0da28f8cb1fd16668 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Dec 10 20:08:41 2018 +0000 Update V8 to version 7.3.78. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7617c68..9062ade5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2636161a478d24fdf659e4c6cecdc827b609faa6 Reviewed-on: https://chromium-review.googlesource.com/c/1370190 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615218} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3c30b98acf5b782c34a3c048f3dfeaeb79f21351 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 20:07:53 2018 +0000 Roll src/third_party/catapult e09a3df387b3..60a61e85fed1 (1 commits) https://chromium.googlesource.com/catapult.git/+log/e09a3df387b3..60a61e85fed1 git log e09a3df387b3..60a61e85fed1 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 pasko@chromium.org Add telemetry.core.util.FindLatestApkOnHost() Created with: gclient setdep -r src/third_party/catapult@60a61e85fed1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:760498 TBR=sullivan@chromium.org Change-Id: Ic0d5dede30002cace3cf2b0facad86002d7f9d5a Reviewed-on: https://chromium-review.googlesource.com/c/1369837 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615217} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a6bb4f3e63a5936901f4af805f8e1786e8c0ecc4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 20:07:32 2018 +0000 Roll src/third_party/SPIRV-Tools/src aab6f4073f7e..e07dabc25f1f (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/aab6f4073f7e..e07dabc25f1f git log aab6f4073f7e..e07dabc25f1f --date=short --no-merges --format='%ad %ae %s' 2018-12-10 stevenperron@google.com Invalidate the decoration manager at the start of ADCE. (#2189) 2018-12-10 hevrard@users.noreply.github.com Add RemoveOpNameInstruction reduction pass (#2187) 2018-12-10 jbolz@nvidia.com Add PCH_FILE for upgrade_memory_model target. MSVC doesn't like building pass_utils.cpp twice in the same folder with different PCH settings. (#2186) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e07dabc25f1f The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8a1dd80d2f3904fc7d4dda46079d3686fdd50ea4 Reviewed-on: https://chromium-review.googlesource.com/c/1370073 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615216} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 32c5a11a4b7afba3eadf5e7c4b497d74ab30b40b Author: Fan Yang <fayang@chromium.org> Date: Mon Dec 10 20:06:33 2018 +0000 Landing recent QUIC changes until 8:47 PM, Nov 30, 2018 UTC-5 Flag changes: Enable FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2 Enable FLAGS_quic_reloadable_flag_quic_new_lru_cache Enable FLAGS_quic_reloadable_flag_quic_optimize_encryption_established Enable FLAGS_quic_restart_flag_quic_no_ephemeral_key_source Handle RST_STREAM frames received by PendingStream. Merge internal change: 223602833 https://chromium-review.googlesource.com/c/chromium/src/+/1365799 Add a method to QuartcStream to ask it for the current read offset. Merge internal change: 223580443 https://chromium-review.googlesource.com/c/chromium/src/+/1365798 First step towards variable length QUIC connection IDs. This CL introduces QuicConnectionIdFromUInt64() and QuicConnectionIdToUInt64() and uses it in all code that assumes connection IDs are uint64_t's. Once this is in, the next step will be to make QuicConnectionId a class that contains a uint64_t. Merge internal change: 223557525 https://chromium-review.googlesource.com/c/chromium/src/+/1365796 In QUIC v99, when stream is created, determine stream type solely by stream ID. Merge internal change: 223522570 https://chromium-review.googlesource.com/c/chromium/src/+/1363435 Add a new method to QuicSession for creating an incoming stream from a PendingStream. Implement this method in the various session subclasses which also requires add a PendingStream-based constructor to various QuicStream subclasses. Merge internal change: 222419285 https://chromium-review.googlesource.com/c/chromium/src/+/1363434 Pass a QuicPerPacketContext into QuicTimeWaitListManager::ProcessPacket and QuicTimeWaitListManager::SendVersionNegotiationPacket. The context is not used in this CL, so there is no behavior change. Merge internal change: 223407840 https://chromium-review.googlesource.com/c/chromium/src/+/1361636 Add a QUIC connection option to disable pacing offload. Merge internal change: 223405141 https://chromium-review.googlesource.com/c/chromium/src/+/1361635 Change QpackInstructionEncoder and Decoder varint type to uint64_t. Merge internal change: 223384725 https://chromium-review.googlesource.com/c/chromium/src/+/1361628 In QuicTimeWaitListManager, rename server_address to self_address, and client_address to peer_address. Merge internal change: 223338983 https://chromium-review.googlesource.com/c/chromium/src/+/1361626 When a QuicStream is constructed from a PendingStream, ensure that the moved sequencer points to the new QuicStream not the old PendingStream. Merge internal change: 223338371 https://chromium-review.googlesource.com/c/chromium/src/+/1361625 In QUIC, implement IETF style bidirectional and unidirectional stream IDs numbering in version 99. Merge internal change: 223337761 https://chromium-review.googlesource.com/c/chromium/src/+/1361624 Move quic::QuicDispatcher::PerPacketContext to quic_packets.h, and rename it to quic::QuicPerPacketContext. Merge internal change: 223234533 https://chromium-review.googlesource.com/c/chromium/src/+/1361329 Add GetNextUnreadRegion() API in QuicStreamSequencerBuffer. Merge internal change: 223233937 https://chromium-review.googlesource.com/c/chromium/src/+/1361328 Remove the limit on QUIC stream buffer length. Merge internal change: 223213240 https://chromium-review.googlesource.com/c/chromium/src/+/1361326 Change QuartcStream's max retransmission count to per-stream rather than number of frames. Merge internal change: 223014131 https://chromium-review.googlesource.com/c/chromium/src/+/1361323 R=rch@chromium.org Change-Id: I5f57f2c168cef9d0875bc6a516702110be47b070 Reviewed-on: https://chromium-review.googlesource.com/c/1366437 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#615215} net/BUILD.gn | 8 + .../http_proxy_client_socket_wrapper_unittest.cc | 7 +- .../http_stream_factory_job_controller_unittest.cc | 2 +- net/http/http_stream_factory_unittest.cc | 32 +- .../bidirectional_stream_quic_impl_unittest.cc | 46 +- net/quic/quic_chromium_client_session.cc | 60 +- net/quic/quic_chromium_client_session.h | 8 +- net/quic/quic_chromium_client_session_peer.cc | 2 +- net/quic/quic_chromium_client_session_test.cc | 218 +-- net/quic/quic_chromium_client_stream.cc | 21 +- net/quic/quic_chromium_client_stream.h | 6 + net/quic/quic_chromium_client_stream_test.cc | 96 +- net/quic/quic_flags_list.h | 8 +- net/quic/quic_http_stream_test.cc | 73 +- net/quic/quic_network_transaction_unittest.cc | 1686 +++++++++++--------- net/quic/quic_proxy_client_socket_unittest.cc | 4 +- net/quic/quic_stream_factory.cc | 3 +- net/quic/quic_stream_factory_test.cc | 657 ++++---- net/third_party/quic/core/chlo_extractor.cc | 2 +- net/third_party/quic/core/chlo_extractor_test.cc | 2 +- .../core/congestion_control/bbr_sender_test.cc | 8 +- .../core/congestion_control/send_algorithm_test.cc | 4 +- net/third_party/quic/core/crypto/crypto_protocol.h | 3 + .../quic/core/crypto/crypto_server_test.cc | 7 +- net/third_party/quic/core/crypto/crypto_utils.cc | 7 +- .../quic/core/crypto/quic_crypto_client_config.cc | 14 +- .../core/crypto/quic_crypto_client_config_test.cc | 33 +- .../quic/core/crypto/quic_crypto_server_config.cc | 17 +- .../core/frames/quic_new_connection_id_frame.cc | 2 +- net/third_party/quic/core/http/end_to_end_test.cc | 73 +- .../core/http/quic_client_promised_info_test.cc | 6 +- .../http/quic_client_push_promise_index_test.cc | 4 +- .../quic/core/http/quic_headers_stream_test.cc | 14 +- .../quic/core/http/quic_server_session_base.cc | 31 +- .../quic/core/http/quic_server_session_base.h | 3 +- .../core/http/quic_server_session_base_test.cc | 90 +- .../quic/core/http/quic_spdy_client_session.cc | 23 +- .../quic/core/http/quic_spdy_client_session.h | 4 +- .../quic/core/http/quic_spdy_client_session_base.h | 3 +- .../core/http/quic_spdy_client_session_test.cc | 41 +- .../quic/core/http/quic_spdy_client_stream.cc | 11 + .../quic/core/http/quic_spdy_client_stream.h | 3 + .../quic/core/http/quic_spdy_client_stream_test.cc | 3 +- .../quic/core/http/quic_spdy_server_stream_base.cc | 5 + .../quic/core/http/quic_spdy_server_stream_base.h | 3 + .../core/http/quic_spdy_server_stream_base_test.cc | 3 +- .../quic/core/http/quic_spdy_session.cc | 2 +- net/third_party/quic/core/http/quic_spdy_session.h | 11 +- .../quic/core/http/quic_spdy_session_test.cc | 189 ++- net/third_party/quic/core/http/quic_spdy_stream.cc | 17 + net/third_party/quic/core/http/quic_spdy_stream.h | 3 + .../quic/core/http/quic_spdy_stream_test.cc | 73 +- .../core/legacy_quic_stream_id_manager_test.cc | 5 +- .../core/qpack/qpack_encoder_stream_receiver.h | 1 - .../quic/core/qpack/qpack_instruction_decoder.h | 4 +- .../quic/core/qpack/qpack_instruction_encoder.h | 4 +- .../quic/core/quic_buffered_packet_store_test.cc | 92 +- net/third_party/quic/core/quic_connection.cc | 13 +- net/third_party/quic/core/quic_connection.h | 2 +- net/third_party/quic/core/quic_connection_id.cc | 30 + net/third_party/quic/core/quic_connection_id.h | 39 + .../quic/core/quic_connection_id_test.cc | 54 + net/third_party/quic/core/quic_connection_test.cc | 33 +- net/third_party/quic/core/quic_constants.h | 1 + .../quic/core/quic_crypto_client_stream_test.cc | 4 +- .../quic/core/quic_crypto_server_handshaker.cc | 2 +- .../quic/core/quic_crypto_server_stream_test.cc | 8 +- net/third_party/quic/core/quic_data_reader.cc | 1 + net/third_party/quic/core/quic_data_reader.h | 2 + net/third_party/quic/core/quic_data_writer.h | 1 + net/third_party/quic/core/quic_data_writer_test.cc | 1 + net/third_party/quic/core/quic_dispatcher.cc | 26 +- net/third_party/quic/core/quic_dispatcher.h | 9 +- net/third_party/quic/core/quic_dispatcher_test.cc | 474 +++--- net/third_party/quic/core/quic_framer.cc | 15 +- net/third_party/quic/core/quic_framer_test.cc | 28 +- net/third_party/quic/core/quic_ietf_framer_test.cc | 3 +- .../quic/core/quic_packet_creator_test.cc | 2 +- .../quic/core/quic_packet_generator_test.cc | 6 +- net/third_party/quic/core/quic_packets.cc | 8 +- net/third_party/quic/core/quic_packets.h | 5 + net/third_party/quic/core/quic_session.cc | 66 +- net/third_party/quic/core/quic_session.h | 39 +- net/third_party/quic/core/quic_session_test.cc | 411 +++-- net/third_party/quic/core/quic_stream.cc | 33 +- net/third_party/quic/core/quic_stream.h | 5 + .../quic/core/quic_stream_id_manager.cc | 71 +- net/third_party/quic/core/quic_stream_id_manager.h | 10 +- .../quic/core/quic_stream_id_manager_test.cc | 180 ++- net/third_party/quic/core/quic_stream_sequencer.cc | 5 + net/third_party/quic/core/quic_stream_sequencer.h | 6 + .../quic/core/quic_stream_sequencer_buffer.cc | 32 +- .../quic/core/quic_stream_sequencer_buffer.h | 15 +- .../quic/core/quic_stream_sequencer_buffer_test.cc | 121 ++ net/third_party/quic/core/quic_stream_test.cc | 57 +- .../quic/core/quic_time_wait_list_manager.cc | 88 +- .../quic/core/quic_time_wait_list_manager.h | 39 +- .../quic/core/quic_time_wait_list_manager_test.cc | 99 +- net/third_party/quic/core/quic_trace_visitor.cc | 5 +- .../quic/core/quic_trace_visitor_test.cc | 5 +- net/third_party/quic/core/quic_types.h | 6 +- net/third_party/quic/core/quic_utils.cc | 40 +- net/third_party/quic/core/quic_utils.h | 21 + net/third_party/quic/core/stateless_rejector.cc | 2 +- .../quic/core/stateless_rejector_test.cc | 5 +- .../quic/core/uber_quic_stream_id_manager.cc | 217 +++ .../quic/core/uber_quic_stream_id_manager.h | 102 ++ .../quic/core/uber_quic_stream_id_manager_test.cc | 321 ++++ net/third_party/quic/quartc/quartc_factory.cc | 7 +- .../quic/quartc/quartc_interval_counter.h | 122 ++ .../quic/quartc/quartc_interval_counter_test.cc | 110 ++ net/third_party/quic/quartc/quartc_session.cc | 45 +- net/third_party/quic/quartc/quartc_session.h | 7 + net/third_party/quic/quartc/quartc_session_test.cc | 6 +- net/third_party/quic/quartc/quartc_stream.cc | 57 +- net/third_party/quic/quartc/quartc_stream.h | 54 +- net/third_party/quic/quartc/quartc_stream_test.cc | 134 +- .../quic/test_tools/crypto_test_utils.cc | 10 +- .../quic/test_tools/crypto_test_utils_test.cc | 8 +- .../test_tools/mock_quic_time_wait_list_manager.h | 10 +- .../quic/test_tools/quic_connection_peer.cc | 5 + .../quic/test_tools/quic_connection_peer.h | 1 + .../quic/test_tools/quic_dispatcher_peer.cc | 16 +- .../quic/test_tools/quic_dispatcher_peer.h | 19 +- .../quic/test_tools/quic_session_peer.cc | 52 +- .../quic/test_tools/quic_session_peer.h | 13 +- .../quic/test_tools/quic_spdy_session_peer.cc | 35 +- .../quic/test_tools/quic_spdy_session_peer.h | 9 +- .../quic/test_tools/quic_test_client.cc | 12 +- net/third_party/quic/test_tools/quic_test_utils.cc | 43 +- net/third_party/quic/test_tools/quic_test_utils.h | 29 +- .../quic/test_tools/simulator/quic_endpoint.cc | 4 +- .../test_tools/simulator/quic_endpoint_test.cc | 36 +- net/third_party/quic/tools/quic_client_base.cc | 9 +- .../quic/tools/quic_simple_client_session.cc | 3 +- .../quic_simple_crypto_server_stream_helper.cc | 2 +- .../quic/tools/quic_simple_server_session.cc | 34 +- .../quic/tools/quic_simple_server_session.h | 1 + .../quic/tools/quic_simple_server_session_test.cc | 108 +- .../quic/tools/quic_simple_server_stream.cc | 9 + .../quic/tools/quic_simple_server_stream.h | 4 + .../quic/tools/quic_simple_server_stream_test.cc | 13 +- .../adapters/p2p_quic_stream_impl.cc | 11 + .../peerconnection/adapters/p2p_quic_stream_impl.h | 8 +- .../adapters/p2p_quic_transport_impl.cc | 25 +- .../adapters/p2p_quic_transport_impl.h | 2 + tools/traffic_annotation/summary/annotations.xml | 1 + 147 files changed, 5184 insertions(+), 2415 deletions(-) commit 53b5f7cdeb93908f6c7390affca308f884afa2e2 Author: Alex Leung <alexleung@google.com> Date: Mon Dec 10 20:06:27 2018 +0000 Disable CastAudioManagerTest.CanMakeAC3Stream on android things Bug: internal b/120675044 Test: Ran cast_audio_manager_unittest Change-Id: I36dac98b1874365f981b98ddfb555abdaa33eef9 Reviewed-on: https://chromium-review.googlesource.com/c/1368779 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#615214} chromecast/media/BUILD.gn | 1 + chromecast/media/audio/cast_audio_manager_unittest.cc | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) commit 2f043bc4cb1a331ffc90d67473c1b8716708b5bb Author: Clark DuVall <cduvall@chromium.org> Date: Mon Dec 10 20:04:49 2018 +0000 Revert "Add CHECKs to help debug NetworkServiceProxyDelegate crash" This reverts commit 1c28ec4741c84e1dce9e981e28d9fcac1c82db6a. Reason for revert: Bug has been fixed. Original change's description: > Add CHECKs to help debug NetworkServiceProxyDelegate crash > > These should never be null, add CHECKs to see if this is why we're > crashing. > > Bug: 912217 > Change-Id: Ie46b9cd263899a9a437da0976c2133b16d37c786 > Reviewed-on: https://chromium-review.googlesource.com/c/1363834 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#614195} TBR=jam@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 912217 Change-Id: I51314d347a703cb4741f082873888763f8543862 Reviewed-on: https://chromium-review.googlesource.com/c/1370315 Reviewed-by: Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#615213} services/network/network_service_proxy_delegate.cc | 4 ---- 1 file changed, 4 deletions(-) commit 0bc9cb6e1f95ee2845a3d094174383effcdf99cb Author: Ryan Hansberry <hansberry@chromium.org> Date: Mon Dec 10 20:02:45 2018 +0000 Smart Lock: Move Observer handling from impl to base ProximityMonitor. This makes test stubs and mocks use the common Observer logic. In a test context, this will catch mistakes where Observers are added multiple times or not removed (this would have caught crbug.com/910769). Bug: 910769 Change-Id: I053d0605b5d4ec2f4b2da117b735a31c7447e804 Reviewed-on: https://chromium-review.googlesource.com/c/1368685 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#615212} chromeos/components/proximity_auth/BUILD.gn | 1 + .../components/proximity_auth/proximity_monitor.cc | 26 ++++++++++++++++++++++ .../components/proximity_auth/proximity_monitor.h | 16 ++++++++----- .../proximity_auth/proximity_monitor_impl.cc | 18 +++------------ .../proximity_auth/proximity_monitor_impl.h | 9 +------- .../proximity_auth/unlock_manager_impl_unittest.cc | 2 -- 6 files changed, 42 insertions(+), 30 deletions(-) commit 4b835720869795a87baf4a16dfb78c25a6214808 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Mon Dec 10 20:02:09 2018 +0000 [Autofill Assistant] Remove the "Don't display again" checkbox. Bug: b/120648878 Change-Id: I97a7d166e9813ee03592d7c851b8078178d96b27 Reviewed-on: https://chromium-review.googlesource.com/c/1369849 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#615211} .../java/res_autofill_assistant/layout/init_screen.xml | 12 +----------- .../autofill_assistant/AutofillAssistantPreferencesUtil.java | 12 +++++++----- .../chrome/browser/autofill_assistant/FirstRunScreen.java | 5 +---- chrome/android/java/strings/android_chrome_strings.grd | 3 --- 4 files changed, 9 insertions(+), 23 deletions(-) commit cee86b1312c2a9df3f74eee193ac522c6282b729 Author: Jun Mukai <mukai@chromium.org> Date: Mon Dec 10 20:01:37 2018 +0000 Disable WebBluetoothTest.NavigateWithChooserCrossOrigin for SPM This test case is flaky on single_process_mash, failing multiple times in several days. Bug: 912213 Test: None Change-Id: If0daa1cd506c192b32bd363ffc2f1e4b711eb770 Reviewed-on: https://chromium-review.googlesource.com/c/1367911 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#615210} .../buildbot/filters/chromeos.single_process_mash.browser_tests.filter | 3 +++ 1 file changed, 3 insertions(+) commit 3327612042a3a8a5cdf3c43fde1969149671746f Author: Daniel Nicoara <dnicoara@chromium.org> Date: Mon Dec 10 20:00:59 2018 +0000 EXO: Use base::TestSuite on non-CrOS builds Allows running tests without ChromeOS dependencies (Ash). Changes: * Add ExoTestSuiteAura to initialize state that would otherwise be initialized by the AshTestSuite. * Initialize the test InputMethodFactory otherwise tests using input will DCHECK() when using ExoTestBaseAura. Bug: 896710 Test: Run exo_unittests from a Chromecast build Change-Id: I709bae42574442cd3d46e834b19f97f8a20a5505 Reviewed-on: https://chromium-review.googlesource.com/c/1345242 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#615209} components/exo/BUILD.gn | 5 +++++ components/exo/test/exo_test_base_aura.cc | 1 + components/exo/test/exo_test_suite_aura.cc | 28 ++++++++++++++++++++++++ components/exo/test/exo_test_suite_aura.h | 34 ++++++++++++++++++++++++++++++ components/exo/test/run_all_unittests.cc | 13 ++++++++++-- 5 files changed, 79 insertions(+), 2 deletions(-) commit 2468c53ca1e48b9230edc5c4774254d9e964de4d Author: Eric Roman <eroman@chromium.org> Date: Mon Dec 10 19:59:59 2018 +0000 Escape non-ASCII strings sent to NetLog from ElideSpdyHeaderBlockForNetLog(). Bug: 800282, 657115 Change-Id: I61ae689ad688aa5282ea0df2850aaf94894787e8 Reviewed-on: https://chromium-review.googlesource.com/c/1368646 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615208} net/spdy/spdy_log_util.cc | 4 ++-- net/spdy/spdy_log_util_unittest.cc | 20 ++++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) commit 9367b837898b8e6960a6c916436094d0d9977b9b Author: Dana Fried <dfried@chromium.org> Date: Mon Dec 10 19:59:23 2018 +0000 Base CL for new near-universal "flex layout". As per previously discussed design: https://docs.google.com/document/d/1sOcsB2smt4pBzPgwAAtlh5CM4kSSYDxW4IIjx1aO010 Has unit tests and example based on the existing BoxLayout example. Open questions: - Do we want to put the new layout stuff in its own namespace (views::layout)? Followup CLs in the pipe: - Use FlexLayout for toolbar layout, vastly simplifying toolbar_view.cc - Add concept of "overflow" child views that appear conditionally. - Use FlexLayout for tab handles, vastly simplifying tab.cc Future work: - Use layout manager for bookmarks bar instead of bespoke layout. - Replace existing uses of BoxLayout and GridLayout that lay out a single row or column with the new, unified layout manager. - Rename TOOLBAR_STANDARD_SPACING to something sensible. - Fix View::GetContentsBounds() to actually call GetInsets(). - Remove ToolbarButton::SetLayoutInsetDelta() and make logic around switching to/from touch UI sane. - Enhance Views properties system to allow for larger value types (insets, flex rules, etc.) without having to explicitly store pointers. Bug: 898632 Change-Id: I38698b01dc5afdd143ba350f2c53f1062baec3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1331040 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615207} ui/views/BUILD.gn | 6 + ui/views/examples/BUILD.gn | 2 + ui/views/examples/examples_window.cc | 2 + ui/views/examples/flex_layout_example.cc | 118 ++ ui/views/examples/flex_layout_example.h | 58 + ui/views/layout/flex_layout.cc | 1033 ++++++++++++++++ ui/views/layout/flex_layout.h | 174 +++ ui/views/layout/flex_layout_types.cc | 203 +++ ui/views/layout/flex_layout_types.h | 164 +++ ui/views/layout/flex_layout_types_internal.cc | 465 +++++++ ui/views/layout/flex_layout_types_internal.h | 367 ++++++ ui/views/layout/flex_layout_unittest.cc | 1629 +++++++++++++++++++++++++ ui/views/view_properties.cc | 1 + ui/views/view_properties.h | 12 + 14 files changed, 4234 insertions(+) commit 9284f3f8c9fd910349b5b27f3ad45616680afc48 Author: Theresa <twellington@chromium.org> Date: Mon Dec 10 19:57:40 2018 +0000 Disable flaky ContextualSuggestionsTest#testInProductHelp_RequireReverseScroll TBR=huayinz@chromium.org BUG=890947 Change-Id: Ic63c046eecf5e3cae9f7adfba6ff0d463d63aa92 Reviewed-on: https://chromium-review.googlesource.com/c/1370196 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#615206} .../chrome/browser/contextual_suggestions/ContextualSuggestionsTest.java | 1 + 1 file changed, 1 insertion(+) commit c4c1ad0a13df3812ff670821e4c7325f181e192b Author: Samuel Huang <huangs@chromium.org> Date: Mon Dec 10 19:53:45 2018 +0000 Revert "Refactor OOPIF scroll bubbling state and cancellation" This reverts commit b9e5ed2a6f6cacce39c19a36bb76a940244def99. Reason for revert: Suspected of webkit_layout_tests failure for virtual/user-activation-v2/fast/events/middleClickAutoscroll-event-fired.html in "WebKit Linux Trusty Leak". Original change's description: > Refactor OOPIF scroll bubbling state and cancellation > > Whether or not a child is bubbling scroll was being tracked in both > CrossProcessFrameConnector and RenderWidgetHostViewChildFrame. It's > simpler to just have it in RWHVCF. > > There are several cases where we generate fake scroll updates when > cancelling scroll bubbling. This is a relic from the non-scroll latching > code paths and has been removed. We also deduplicate the scroll bubbling > cancellation code. > > We were tracking the view from which scroll events are bubbled by keeping > a reference to that view's parent. We now just keep a reference to the > originating view directly. > > We also now properly cancel scroll bubbling when a child detaches. > > Bug: 828422, 897216 > Change-Id: Iee983bd9ea05b324d556c66320a1bc5e544de057 > Reviewed-on: https://chromium-review.googlesource.com/c/1357563 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Kevin McNee <mcnee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615184} TBR=kenrb@chromium.org,mcnee@chromium.org Change-Id: I7ac9817339a80408d3cf1849efef3c42be1973d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 828422, 897216 Reviewed-on: https://chromium-review.googlesource.com/c/1370466 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615205} .../frame_host/cross_process_frame_connector.cc | 17 +- .../frame_host/cross_process_frame_connector.h | 2 + .../render_widget_host_input_event_router.cc | 231 +++++++++------------ .../render_widget_host_input_event_router.h | 29 +-- .../render_widget_host_view_child_frame.cc | 33 +-- 5 files changed, 142 insertions(+), 170 deletions(-) commit e29d459ca52cba12ffe2026ea83cd50f06c869fc Author: Tony de Luna <tonydeluna@chromium.org> Date: Mon Dec 10 19:39:53 2018 +0000 Remove support for mobile data promos Removes logic for displaying mobile data promos. We haven't had mobile data promos since 2012. Refactors notification displaying logic, renames variables and method names to avoid the promo concept. I'll follow up with a cl that renames this class and all references to it. BUG=910767 Change-Id: I4deda2407b268729405af734241b8f36de2d2de9 Reviewed-on: https://chromium-review.googlesource.com/c/1359825 Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#615204} chrome/browser/chromeos/BUILD.gn | 3 - .../chromeos/login/ui/login_display_host_common.cc | 4 - chrome/browser/chromeos/mobile_config.cc | 369 --------------------- chrome/browser/chromeos/mobile_config.h | 205 ------------ chrome/browser/chromeos/mobile_config_unittest.cc | 249 -------------- chrome/browser/chromeos/preferences.cc | 6 +- chrome/browser/prefs/browser_prefs.cc | 6 +- .../ui/ash/network/data_promo_notification.cc | 207 ++++-------- .../ui/ash/network/data_promo_notification.h | 22 +- chrome/common/pref_names.cc | 6 +- chrome/common/pref_names.h | 2 +- 11 files changed, 85 insertions(+), 994 deletions(-) commit 7c69b5099532dcbf5269c3016d20bd3c43c607a4 Author: Becky Zhou <huayinz@chromium.org> Date: Mon Dec 10 19:37:57 2018 +0000 [Snowflake] Move presubmit checks to check XMLs on multiple directories Extend presubmit checks for Android XMLs to ui/, content/ and components/. Bug: 775198 Change-Id: I2828d02687364c7aadaecf8f6fdd3745c2932c9e Reviewed-on: https://chromium-review.googlesource.com/c/1364227 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615203} PRESUBMIT.py | 28 +++- .../layout/autofill_assistant_sheet.xml | 3 +- .../res_autofill_assistant/values-v17/styles.xml | 11 ++ tools/android/checkxmlstyle/PRESUBMIT.py | 24 +++ .../android/checkxmlstyle/checkxmlstyle.py | 51 +++---- .../android/checkxmlstyle/checkxmlstyle_test.py | 163 +++++++++++++-------- 6 files changed, 194 insertions(+), 86 deletions(-) commit 01e8130c0824918abd6fe95af68d6a5100535b07 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Dec 10 19:30:47 2018 +0000 Use ReentrantObserverList for aura::Window::observers_ BUG=812109 TEST=aura_unittests pass with "allow_reentrancy=false", which will be default in the future. Change-Id: I22cfc645bb15bfb7e9d6dc08c372124b216738a4 Reviewed-on: https://chromium-review.googlesource.com/c/1171372 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#615202} ui/aura/window.h | 2 +- ui/aura/window_port.cc | 2 +- ui/aura/window_port.h | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) commit 6e7452a18fd7d18fb8124a91dc2603e2e7d3c6ec Author: David 'Digit' Turner <digit@google.com> Date: Mon Dec 10 19:28:50 2018 +0000 android: Remove obsolete app_bundle_to_apks.py script. This script was added in [1] when adding support for Android app bundles to the Chromium build system, because, at the time, building the .apks archive during the build itself was throught to be a good thing. In practice it is not, and only serves to make the build slower than necessary. Instead, the APK Set is now created on-demand through the wrapper-script invokation for each bundle, e.g.: # Create the APK Set on demand for this bundle. out/Release/bin/chrome_bundle build-bundle-apks # Install a bundle, this will use 'build-bundle-apks' # Automatically if needed. out/Release/bin/chrome_bundle install This CL thus removes this obsolete script that is no longer caller from our build rules, as shown by the code search in [2] BUG=920459 R=benmason@chromium.org,agrieve@chromium.org,yfriedman@chromium.org [1] https://chromium-review.googlesource.com/c/chromium/src/+/1125932/ [2] https://cs.chromium.org/search/?q=app_bundle_to_apks.py&sq=package:chromium&type=cs Change-Id: Id1f043637c4917483b1f80e3c2b7f249c717c7a3 Reviewed-on: https://chromium-review.googlesource.com/c/1369927 Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#615201} PRESUBMIT.py | 1 - build/android/gyp/app_bundle_to_apks.py | 70 ----------------------------- build/android/gyp/app_bundle_to_apks.pydeps | 8 ---- 3 files changed, 79 deletions(-) commit 70e4cc800a1c28c6e55fb1ceead7afca5f3d1576 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Dec 10 19:27:26 2018 +0000 Clean up EnrollmentDialogView This eliminates the unused 'owning_window' case from the enrollment dialog, folds in the remaning call to SystemTrayClient::CreateUnownedDialogWidget, and uses ash_util instead of duplicating logic. It also moves GetDialogParentContainerId to browser_dialogs.h. Bug: 912998 Change-Id: I53bc9ddfe9034a40bfd64ce35a41a21c1639b16e Reviewed-on: https://chromium-review.googlesource.com/c/1368456 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#615200} .../browser/chromeos/login/ui/login_web_dialog.cc | 5 +-- chrome/browser/ui/ash/ash_util.cc | 8 ++++ chrome/browser/ui/ash/ash_util.h | 5 +++ .../ui/ash/network/enrollment_dialog_view.cc | 49 +++++++++------------- .../ui/ash/network/enrollment_dialog_view.h | 10 +---- .../network/network_connect_delegate_chromeos.cc | 3 +- chrome/browser/ui/ash/system_tray_client.cc | 36 ---------------- chrome/browser/ui/ash/system_tray_client.h | 15 ------- 8 files changed, 37 insertions(+), 94 deletions(-) commit 78521d8cd6ed96cbce883bbdce1e4c44a94ba5f8 Author: Christopher Cameron <ccameron@chromium.org> Date: Mon Dec 10 19:25:32 2018 +0000 RemoteMacViews: Simplify content accessibility The previous scheme that was being used for accessibility was to have a tree that looked like - NativeWidgetMacNSWindow in app shim process - BridgedContentView in app shim process - views::Views AX tree in the browser process - WebContentsViewCocoa in the app shim process - this was sort of hand-wavy and hadn't been completely implemented - RenderWidgetHostViewCocoa in the app shim process - content AX tree in the browser process This sandwiching of the app shim's WebContentsViewCocoa and RenderWidgetHostViewCocoa was unnecessarily complicated -- we should just use the NSViews that we have in the browser process. This patch simplifies things to just stay in the browser process once we get there. The one time that we need to jump back to the app shim process is when the content AX tree is asked about its window property. To accommodate this - Add a AccessibilityGetNativeViewAccessibleForWindow method that plumbs over to the RenderWidgetHostViewMac, and returns the NSAccessibilityRemoteUIElement in remote mode (and the NSWindow otherwise). - Add a mojo method to set the NSAccessibilityRemoteUIElement whenever the window is changed (we may need it before its previous "lazy" initialization in SyncConnectAccessibilityElements). - Remove setting the NSAccessibilityRemoteUIElement tokens from the SyncConnectAccessibilityElements method, and rename it to SyncGetRootAccessibilityElement (because it now connects nothing). Bug: 900846 Change-Id: I8a88ffc75a797eaad9445f66fbc4aa47539ec769 Reviewed-on: https://chromium-review.googlesource.com/c/1369134 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615199} .../accessibility/browser_accessibility_cocoa.mm | 19 +--------- .../accessibility/browser_accessibility_manager.h | 2 + .../browser_accessibility_manager_mac.h | 3 +- .../browser_accessibility_manager_mac.mm | 6 ++- .../browser_accessibility_manager_unittest.cc | 4 ++ .../browser/frame_host/render_frame_host_impl.cc | 9 +++++ .../browser/frame_host/render_frame_host_impl.h | 2 + content/browser/ns_view_bridge_factory_impl.mm | 15 +++----- .../render_widget_host_ns_view_client_helper.h | 3 ++ .../renderer_host/render_widget_host_view_base.cc | 5 +++ .../renderer_host/render_widget_host_view_base.h | 2 + .../renderer_host/render_widget_host_view_cocoa.mm | 3 ++ .../renderer_host/render_widget_host_view_mac.h | 16 ++++---- .../renderer_host/render_widget_host_view_mac.mm | 44 +++++++++++++--------- content/common/render_widget_host_ns_view.mojom | 12 +++--- 15 files changed, 85 insertions(+), 60 deletions(-) commit e5294c0fcdc112c461cf06c357db5ad3c0bbf27e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 19:22:21 2018 +0000 Roll src/third_party/pdfium 841c145e2eb1..32660f54f795 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/841c145e2eb1..32660f54f795 git log 841c145e2eb1..32660f54f795 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 tsepez@chromium.org Move XFA_RESOLVENODE_* flags to cfxjse_resolveprocessor.h Created with: gclient setdep -r src/third_party/pdfium@32660f54f795 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I67cf7e6f253e7566840129a0488f137b23175202 Reviewed-on: https://chromium-review.googlesource.com/c/1370071 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615198} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 082c8955b39ccc7e6f2fabefd0f893e33135fbd9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 19:20:29 2018 +0000 Roll src/third_party/angle 19f2f9eb2503..153e0224da45 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/19f2f9eb2503..153e0224da45 git log 19f2f9eb2503..153e0224da45 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 enga@chromium.org Add gl_DrawID emulation for ESSL3 with ANGLE_multi_draw Created with: gclient setdep -r src/third_party/angle@153e0224da45 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890539 TBR=jmadill@chromium.org Change-Id: I6fbce5f8b72ff794c1b944eafebb7d916410a6eb Reviewed-on: https://chromium-review.googlesource.com/c/1370200 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615197} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b1d7623d787f9e04fa9d3373ecd628c9d2f27c56 Author: Eugene But <eugenebut@google.com> Date: Mon Dec 10 19:16:36 2018 +0000 Add more MIME types to DownloadMimeTypeResult. More than 40% of downloads are still categorized as "Other Type" and it would be useful to limit that number to 20%. Large number of existing downloads are .zip, .exe, and .apk files, so added other popular Archive formats as well as MacOS installer types. The rest of files are just guesses of what the users can actually download on the internet. Bug: 913565 Change-Id: Ia4556fa5d3cfc84b1d0191a1f74a0ef51ac17dfb Reviewed-on: https://chromium-review.googlesource.com/c/1368654 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#615196} .../browser/download/browser_download_service.h | 22 +++++++++++++++- .../browser/download/browser_download_service.mm | 30 ++++++++++++++++++++++ tools/metrics/histograms/enums.xml | 22 ++++++++++++++++ 3 files changed, 73 insertions(+), 1 deletion(-) commit bc171a03b6bf9a7daa0bf60822ad0d0b703ee476 Author: David Lu <davidluphd@google.com> Date: Mon Dec 10 19:15:01 2018 +0000 Add unit test to local NTP doodle sharing. Local NTP Doodle sharing CL: https://chromium-review.googlesource.com/c/chromium/src/+/1324420 Bug: 896461 Change-Id: Id9b32062eb17edc296837e68d9c175d5e5d52996 Reviewed-on: https://chromium-review.googlesource.com/c/1368952 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: David Lu <davidluphd@google.com> Cr-Commit-Position: refs/heads/master@{#615195} .../google_logo_api_unittest.cc | 113 +++++++++++++++++++++ .../search_provider_logos/logo_cache_unittest.cc | 14 +++ 2 files changed, 127 insertions(+) commit 5dcb41634db73fa5c18354bc5f7eaa4a322467b8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 19:09:26 2018 +0000 Roll src/third_party/depot_tools 03ee2d619043..ec40d02c8a16 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03ee2d619043..ec40d02c8a16 git log 03ee2d619043..ec40d02c8a16 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 jbudorick@chromium.org buildbucket: add --response-json. Created with: gclient setdep -r src/third_party/depot_tools@ec40d02c8a16 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:912391 TBR=agable@chromium.org Change-Id: I6045a90496b7ab904a539c9abf54838b21d90357 Reviewed-on: https://chromium-review.googlesource.com/c/1369841 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615194} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a2a7d8beece0d148176aba38b3884fd02c823cad Author: Scott Violet <sky@chromium.org> Date: Mon Dec 10 19:06:48 2018 +0000 gpu: changes ws::Gpu to use the same mojom::GpuPtr for creating memory buffer Previously ws::Gpu created two requests for mojom::GpuPtr. This resulted in two distinct viz::GpuClients (on the server) and limited sharing. This uses a single mojom::GpuPtr. BUG=911240 TEST=none Change-Id: I9db9852d675c6cdc1b399887d211c233b3e6a1b1 Reviewed-on: https://chromium-review.googlesource.com/c/1368307 Reviewed-by: Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615193} .../cpp/gpu/client_gpu_memory_buffer_manager.cc | 8 ----- .../cpp/gpu/client_gpu_memory_buffer_manager.h | 3 -- services/ws/public/cpp/gpu/gpu.cc | 39 ++++++++-------------- services/ws/public/cpp/gpu/gpu.h | 4 +-- services/ws/public/cpp/tests/gpu_unittest.cc | 5 +-- 5 files changed, 15 insertions(+), 44 deletions(-) commit 826d89b9361e6c1dfea6a45293e1b7a88a59dba0 Author: Eric Karl <ericrk@chromium.org> Date: Mon Dec 10 19:03:17 2018 +0000 Ensure gpu::Buffer IDs are unique within a process Each of the various CommandBuffer implementations generates Buffer IDs in its own way, but then assumes these IDs are process unique for the purpose of memory tracing. Move all ID allocation to one place in buffer.h to ensure these IDs are actually process unique. Change-Id: I60ae891bf7c0dc0a4d8f65c68d2b30c3f391ce1d Reviewed-on: https://chromium-review.googlesource.com/c/1367092 Reviewed-by: Jonathan Backer <backer@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#615192} gpu/command_buffer/common/buffer.cc | 12 ++++++++++++ gpu/command_buffer/common/buffer.h | 4 ++++ gpu/command_buffer/service/command_buffer_service.cc | 3 +-- gpu/ipc/client/command_buffer_proxy_impl.cc | 2 +- gpu/ipc/client/gpu_channel_host.cc | 14 -------------- gpu/ipc/client/gpu_channel_host.h | 3 --- gpu/ipc/in_process_command_buffer.cc | 3 +-- 7 files changed, 19 insertions(+), 22 deletions(-) commit 5343a708b04b9f1d92328a1201e815f1a13dd05f Author: John Lee <johntlee@chromium.org> Date: Mon Dec 10 19:01:21 2018 +0000 WebUI: Add CSS variable for vertical-padding, move cr-link-row and the rest of the Extension details page to use padding Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=686905#c8 Bug: 686905 Change-Id: I48f756ca5ee1cbf3d4d581aeed7e6dd54b8cd1a1 Reviewed-on: https://chromium-review.googlesource.com/c/1358925 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615191} chrome/browser/resources/md_extensions/detail_view.html | 17 ++++++----------- .../resources/cr_elements/cr_link_row/cr_link_row.html | 7 ++----- ui/webui/resources/cr_elements/shared_vars_css.html | 1 + 3 files changed, 9 insertions(+), 16 deletions(-) commit a28a6097182e739c4a8c600b538fcc07681fc7a3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 18:55:42 2018 +0000 Roll src/third_party/webrtc 24d8ec3dbb2a..69540f44196e (2 commits) https://webrtc.googlesource.com/src.git/+log/24d8ec3dbb2a..69540f44196e git log 24d8ec3dbb2a..69540f44196e --date=short --no-merges --format='%ad %ae %s' 2018-12-10 artit@webrtc.org Use android Nullable instead of javax Nullable 2018-12-10 aleloi@webrtc.org Re-tuning of VAD in AGC2. Created with: gclient setdep -r src/third_party/webrtc@69540f44196e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:771683,chromium:913430 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I81441701fbdccb566d5422f9c6efafe66b9a1931 Reviewed-on: https://chromium-review.googlesource.com/c/1370284 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615190} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f9fb6596d0d197dcca19d0ce9fdfa675bdbf8895 Author: Eugene But <eugenebut@google.com> Date: Mon Dec 10 18:55:23 2018 +0000 s/NavigationItemCommitted/DidFinishNavigation in IOSChromeLocalSessionEventRouter. NavigationItemCommitted is deprecated in favour of DidStartNavigation. Bug: 781534 Change-Id: I72d0cc47606b9cb388adcc05cd62c8f0e34ec839 Reviewed-on: https://chromium-review.googlesource.com/c/1368834 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615189} .../browser/sync/sessions/ios_chrome_local_session_event_router.h | 5 ++--- .../browser/sync/sessions/ios_chrome_local_session_event_router.mm | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) commit ce030490dbec9d6015ee1d9c952ec2c44901ff97 Author: Eugene But <eugenebut@google.com> Date: Mon Dec 10 18:51:54 2018 +0000 Implement IOSChromeLocalSessionEventRouter::DidChangeBackForwardState. NavigationItemsPruned is not called when slim-navigation-manager is enabled. DidChangeBackForwardState is a superset of NavigationItemsPruned and is called for slim-navigation-manager. Overridden DidChangeBackForwardState has the same implementation as NavigationItemsPruned. Bug: 910894 Change-Id: Ib0aac6df22440745345eebb513d06ff52b3a309c Reviewed-on: https://chromium-review.googlesource.com/c/1368839 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615188} .../browser/sync/sessions/ios_chrome_local_session_event_router.h | 1 + .../browser/sync/sessions/ios_chrome_local_session_event_router.mm | 5 +++++ 2 files changed, 6 insertions(+) commit 22f5a0fa6ee7da4f0f71f4e49c3ae65df15d5268 Author: Yi Su <mrsuyi@chromium.org> Date: Mon Dec 10 18:43:07 2018 +0000 Set separatorInset in SettingsRootTableVC. ChromeTableViewController sets the UITableView.separatorInset with leading blank space for UITableViewCell with leading images. This CL sets it again in SettingsRootTableViewController without leading space since all TableVC in Settings do not have leading images in M72. Bug: 912377 Change-Id: I1bb6c15063bc6ebf05db7b332fb217785a316bc4 Reviewed-on: https://chromium-review.googlesource.com/c/1370170 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#615187} .../settings/settings_root_table_view_controller.mm | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) commit 4749da135f8f09803659d0e6a1b0828544c97a2f Author: Alex Clarke <alexclarke@chromium.org> Date: Mon Dec 10 18:42:37 2018 +0000 Rename SweepCancelledDelayedTasks to ReclaimMemory We now also call MaybeShrinkToFit on all queues. This should reduce immediate task related memory consumption after loading. Bug: 912541, 895930 Change-Id: Ia5b31efe8efc67bda52507a52aa87b6863302623 Reviewed-on: https://chromium-review.googlesource.com/c/1369775 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#615186} base/task/sequence_manager/sequence_manager.h | 5 +++-- .../task/sequence_manager/sequence_manager_impl.cc | 13 ++++++------ base/task/sequence_manager/sequence_manager_impl.h | 2 +- .../sequence_manager_impl_unittest.cc | 6 +++--- base/task/sequence_manager/task_queue_impl.cc | 8 +++++++- base/task/sequence_manager/task_queue_impl.h | 5 +++-- .../blink/renderer/platform/scheduler/BUILD.gn | 8 ++++---- ...ed_task_sweeper.cc => idle_memory_reclaimer.cc} | 19 +++++++++--------- ...ayed_task_sweeper.h => idle_memory_reclaimer.h} | 20 +++++++++---------- ...ittest.cc => idle_memory_reclaimer_unittest.cc} | 23 +++++++++++----------- .../platform/scheduler/common/scheduler_helper.cc | 4 ++-- .../platform/scheduler/common/scheduler_helper.h | 5 +++-- .../main_thread/main_thread_scheduler_impl.cc | 3 +-- .../main_thread/main_thread_scheduler_impl.h | 4 ++-- .../scheduler/worker/worker_thread_scheduler.cc | 3 +-- .../scheduler/worker/worker_thread_scheduler.h | 4 ++-- 16 files changed, 68 insertions(+), 64 deletions(-) commit 9827fd8ee983905295fc3ead5550f20165df1809 Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Dec 10 18:41:37 2018 +0000 cros: Temporarily disable system tray language toggle in demo mode Disable the feature in M72 because I overlooked the requirement for adding the visual indicator in status area. At this point, users have no easy way to know the language toggle is supported, unless they open the system tray themselves (something that customers in retail store rarely do). PM decides to disable the feature altogether. Bug: 877749 Change-Id: I7f619caaea18be43ebc2631d2fb1eefbf8d6a45f Reviewed-on: https://chromium-review.googlesource.com/c/1359858 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615185} chrome/browser/chromeos/login/demo_mode/demo_session.cc | 4 +++- chromeos/chromeos_switches.cc | 3 +++ chromeos/chromeos_switches.h | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) commit b9e5ed2a6f6cacce39c19a36bb76a940244def99 Author: Kevin McNee <mcnee@chromium.org> Date: Mon Dec 10 18:41:30 2018 +0000 Refactor OOPIF scroll bubbling state and cancellation Whether or not a child is bubbling scroll was being tracked in both CrossProcessFrameConnector and RenderWidgetHostViewChildFrame. It's simpler to just have it in RWHVCF. There are several cases where we generate fake scroll updates when cancelling scroll bubbling. This is a relic from the non-scroll latching code paths and has been removed. We also deduplicate the scroll bubbling cancellation code. We were tracking the view from which scroll events are bubbled by keeping a reference to that view's parent. We now just keep a reference to the originating view directly. We also now properly cancel scroll bubbling when a child detaches. Bug: 828422, 897216 Change-Id: Iee983bd9ea05b324d556c66320a1bc5e544de057 Reviewed-on: https://chromium-review.googlesource.com/c/1357563 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#615184} .../frame_host/cross_process_frame_connector.cc | 17 +- .../frame_host/cross_process_frame_connector.h | 2 - .../render_widget_host_input_event_router.cc | 231 ++++++++++++--------- .../render_widget_host_input_event_router.h | 29 ++- .../render_widget_host_view_child_frame.cc | 33 ++- 5 files changed, 170 insertions(+), 142 deletions(-) commit 0f1396ae106c2149b3c73557b2c2343d5f9c87ae Author: Adithya Srinivasan <adithyas@chromium.org> Date: Mon Dec 10 18:39:17 2018 +0000 Remove const method from ContentRendererClient Bug: 908139 Change-Id: Ic4924d7794603d8e7106775666506fe446bc6e02 Reviewed-on: https://chromium-review.googlesource.com/c/1370185 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615183} chrome/renderer/chrome_content_renderer_client.cc | 2 +- chrome/renderer/chrome_content_renderer_client.h | 2 +- content/public/renderer/content_renderer_client.cc | 2 +- content/public/renderer/content_renderer_client.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) commit 061816c5c3c86061fe4f61526b7be9756ebc4f31 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Dec 10 18:35:33 2018 +0000 SetTimeDialog: Use SystemWebDialogDelegate This makes the SetTimeDialog consistent with other system dialogs when opened from the system tray, and simplifies the class. This CL also: * Removes the unused |use_minimal_style| arg to SystemWebDialogDelegate::ShowSystemDialog() * Adds a |parent| argument to ShowSystemDialog() to allow the time dialog to be parented when opened from the Settings UI, instead of AlwaysOnTop or modal. Bug: 912998 Change-Id: I6f075773a04c862f58bd4be16e0878d7ea8f1d4f Reviewed-on: https://chromium-review.googlesource.com/c/1368281 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615182} chrome/browser/chromeos/set_time_dialog.cc | 70 +++------------------- chrome/browser/chromeos/set_time_dialog.h | 31 ++-------- chrome/browser/ui/ash/system_tray_client.cc | 2 +- .../webui/chromeos/system_web_dialog_delegate.cc | 16 +++-- .../ui/webui/chromeos/system_web_dialog_delegate.h | 9 +-- .../webui/settings/chromeos/date_time_handler.cc | 2 +- .../signin/inline_login_handler_dialog_chromeos.cc | 2 +- 7 files changed, 32 insertions(+), 100 deletions(-) commit 32984e4b36dfba44ee7c3f384a228e7524e23a70 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 18:34:14 2018 +0000 Roll src/third_party/skia a6e0c2b19c78..be5a09332e5d (9 commits) https://skia.googlesource.com/skia.git/+log/a6e0c2b19c78..be5a09332e5d git log a6e0c2b19c78..be5a09332e5d --date=short --no-merges --format='%ad %ae %s' 2018-12-10 bsalomon@google.com Consolidate details of lazy proxy creation for promise image textures. 2018-12-10 brianosman@google.com Disable OpenGL for Windows-on-ARM64 2018-12-10 brianosman@google.com Fix PATH and EXE quoting for Windows ARM64 builds 2018-12-10 mtklein@google.com roll clang_win 2018-12-10 egdaniel@google.com Remove unused GrSignalSemaphoreOp and forced flushed on semaphore insertion. 2018-12-10 michaelludwig@google.com Revert "Fix performance regresion on Mali, while preserving sk_FragCoord.w" 2018-12-10 caryclark@google.com fix bookmaker nightly 2018-12-10 michaelludwig@google.com Revert "Add clamp to border wrap mode to gpu" 2018-12-10 egdaniel@google.com In Vulkan don't submit CB after resolve call unless we are preparing image for I/O Created with: gclient setdep -r src/third_party/skia@be5a09332e5d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Idf8e0f684c0123253906926862e4d029803a9b7b Reviewed-on: https://chromium-review.googlesource.com/c/1370069 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615181} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3f7471d4dffb4bfdbd04e83ba5e93dd6fb4f1e3d Author: Doug Arnett <dougarnett@chromium.org> Date: Mon Dec 10 18:33:34 2018 +0000 Updates ResourceLoadingHints group name for variations testing. Updates Enabled group name to Enabled2 per name change when adding variation experiment id. This is in conjunction with Finch change in https://critique.corp.google.com/#review/224226877 Bug: 900705 Change-Id: I2c256fea685bb432a82f8e92234bff47d1b53d09 Reviewed-on: https://chromium-review.googlesource.com/c/1367874 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#615180} testing/variations/fieldtrial_testing_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 442dc9ee14658ff00505b3f4bf9e1a3ebb22ac7f Author: Xiaohui Chen <xiaohuic@google.com> Date: Mon Dec 10 18:32:33 2018 +0000 assistant: refactor assistant_settings_manager * move settings related logic from assistant_manager_service_impl to assistant_setting_manager. the main file is getting too big. * update the couple fake implementations to make libassistant free build work. Bug: None Test: locally build and run Change-Id: I7bdaac3ec36215fa3b4d824a2313ac4507e237ff Reviewed-on: https://chromium-review.googlesource.com/c/1368658 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#615179} chromeos/services/assistant/BUILD.gn | 2 + .../services/assistant/assistant_manager_service.h | 23 -- .../assistant/assistant_manager_service_impl.cc | 353 ++++----------------- .../assistant/assistant_manager_service_impl.h | 47 +-- .../assistant/assistant_settings_manager_impl.cc | 218 ++++++++++++- .../assistant/assistant_settings_manager_impl.h | 31 +- chromeos/services/assistant/constants.cc | 13 + chromeos/services/assistant/constants.h | 16 + .../fake_assistant_manager_service_impl.cc | 21 +- .../fake_assistant_manager_service_impl.h | 15 +- .../fake_assistant_settings_manager_impl.cc | 27 +- .../fake_assistant_settings_manager_impl.h | 10 + chromeos/services/assistant/service.cc | 8 +- chromeos/services/assistant/service.h | 6 +- chromeos/services/assistant/utils.h | 2 +- 15 files changed, 387 insertions(+), 405 deletions(-) commit 6c278e3a974d463bf89560ba9d3d3ebd5e1c9856 Author: manuk <manukh@chromium.org> Date: Mon Dec 10 18:30:55 2018 +0000 [chrome:omnibox] Join columns 'provider name' with 'type' and 'contents' with 'description'. This CL introduces support for multi-property columns. For now, we use it for the two simplest cases, but in future, more columns may display multiple columns, and some columns may display more than two properties.. Relevant minor changes also included in this CL: 1) In order to make styling multi-property cells easier, we introduce 'cell-*' CSS classes and rename the previous 'column-*' CSS classes, which referred to header cells, to 'header-*'. 2) To clarify naming, we renamed the type PresentationInfoRecord and the constant PROPERTY_OUTPUT_ORDER to Column and COLUMNS respectively. 3) To avoid post-processing the columns in order to append computed properties after first initializing them, we use a constructor instead of object literals. 4) To avoid relying on 'typeof' and reduce complexity, we declare each column's OutputProperty class (e.g. OutputBooleanProperty or OutputJsonProperty). Bug: 891303 Change-Id: I9bb15e22a9c07d42947111014213ddf3f924f9ab Reviewed-on: https://chromium-review.googlesource.com/c/1368028 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#615178} chrome/browser/resources/omnibox/omnibox.css | 29 +- .../resources/omnibox/omnibox_column_widths.css | 46 +- chrome/browser/resources/omnibox/omnibox_output.js | 462 ++++++++++----------- 3 files changed, 258 insertions(+), 279 deletions(-) commit 318899bf06319dedb69eca77fabadc6a6f578859 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 18:30:52 2018 +0000 Roll src/third_party/dawn c3ecb5a77c06..07df605a2bfb (1 commits) https://dawn.googlesource.com/dawn.git/+log/c3ecb5a77c06..07df605a2bfb git log c3ecb5a77c06..07df605a2bfb --date=short --no-merges --format='%ad %ae %s' 2018-12-10 cwallez@chromium.org BUILD.gn: Add temporary proxy groups for test targets Created with: gclient setdep -r src/third_party/dawn@07df605a2bfb The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:913171 TBR=cwallez@chromium.org Change-Id: I6c678837c03378fbf17e0deaab113b3813da67a9 Reviewed-on: https://chromium-review.googlesource.com/c/1370068 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615177} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 12c05cdb3d3390494ea2b916a612f12111f469ea Author: Jonathan Backer <backer@chromium.org> Date: Mon Dec 10 18:27:06 2018 +0000 Remove UseSkiaDeferredDisplayList feature flag We will only launch SkiaRenderer with SkDDL. This is in preparation for running on FYI bots and eventual SkiaRenderer field trial. This CL just removes the feature flag and plumbing. Future CLs can simplify SkiaRenderer code. Change-Id: I76176d773c72d8106969f26c87a0ba58c7da4ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1363861 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#615176} cc/test/pixel_test.cc | 14 +------ cc/test/pixel_test.h | 22 +--------- components/viz/common/display/renderer_settings.h | 1 - components/viz/common/features.cc | 10 ----- components/viz/common/features.h | 2 - components/viz/host/renderer_settings_creation.cc | 2 - .../viz/service/display/renderer_pixeltest.cc | 49 +++++----------------- .../display_embedder/gpu_display_provider.cc | 2 +- content/browser/gpu/compositor_util.cc | 7 ---- .../renderer_host/compositor_impl_android.cc | 2 - .../compositor_impl_android_browsertest.cc | 3 +- content/browser/resources/gpu/info_view.js | 12 +++--- gpu/ipc/in_process_command_buffer.cc | 4 +- gpu/ipc/service/gles2_command_buffer_stub.cc | 4 +- gpu/ipc/service/gpu_channel_manager.cc | 6 +-- .../interfaces/compositing/renderer_settings.mojom | 1 - .../compositing/renderer_settings_struct_traits.cc | 1 - .../compositing/renderer_settings_struct_traits.h | 5 --- 18 files changed, 27 insertions(+), 120 deletions(-) commit d48ae0d8b8cb7af9ab6a4aa9c7f955bb391dfd81 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 18:18:46 2018 +0000 Roll src/third_party/chromite c054e0f9d1d4..24c806768f57 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c054e0f9d1d4..24c806768f57 git log c054e0f9d1d4..24c806768f57 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 xixuan@google.com HWTestStage: Update the priority of skylab suite for branched builds. Created with: gclient setdep -r src/third_party/chromite@24c806768f57 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I58b44083973c3b81a8376e11804e4335c1c0a396 Reviewed-on: https://chromium-review.googlesource.com/c/1370067 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615175} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8c1c0330eee37b5ce8b4219a19463746fd14f507 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Dec 10 18:17:49 2018 +0000 Roll src-internal ea53736df1e2..b12d02f6627f (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea53736df1e2..b12d02f6627f Created with: gclient setdep -r src-internal@b12d02f6627f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If546fe03ef7722c9a0bb85dd555ce552ef313ad3 Reviewed-on: https://chromium-review.googlesource.com/c/1369838 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615174} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 44b83ca388a72ae5c172f52f0cb1c1c45fe3d5a4 Author: Samuel Huang <huangs@chromium.org> Date: Mon Dec 10 18:17:32 2018 +0000 Revert "[USB Enrollment] Add OOBE config key for enrollment token" This reverts commit c8e45dc550a919031aeda2f0b2c34928f641fa4b. Reason for revert: Likely causes OobeInteractiveUITestImpl/OobeInteractiveUITest.SimpleEndToEnd/1 failure on "Linux ChromiumOS MSan Tests". Original change's description: > [USB Enrollment] Add OOBE config key for enrollment token > > Added a code that would propagate enrollment token from OOBE config > to EnrollmentScreen and start corresponding flow in EnrollmentHelper. > > Updated policy_testserver to reflect that USB-based enrollment > uses attestation-based flow (although test server is not used in current > browser_tests, they mock process on EnrollmentHelper level) > > Also updated configuration_keys.cc to fail on mismatched type for values, > but only warn in case of extra keys in file. > > Bug: 854101 > Change-Id: I93be43dcb90c0b1b200549b3d4091f7d1194e694 > Reviewed-on: https://chromium-review.googlesource.com/c/1348891 > Commit-Queue: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615123} TBR=achuith@chromium.org,antrim@chromium.org,poromov@chromium.org Change-Id: Ifd0d9f28b5c55069783a62d1263278f3b5a1a5e8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854101 Reviewed-on: https://chromium-review.googlesource.com/c/1370311 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615173} .../browser/chromeos/login/configuration_keys.cc | 12 ++---- chrome/browser/chromeos/login/configuration_keys.h | 1 - .../chromeos/login/enrollment/enrollment_screen.cc | 9 +---- .../login/enterprise_enrollment_browsertest.cc | 43 ++++---------------- chrome/browser/chromeos/login/wizard_controller.cc | 12 ------ chrome/browser/chromeos/policy/enrollment_config.h | 3 -- chrome/browser/policy/test/policy_testserver.py | 47 +++++++++------------- .../chromeos/login/oobe_screen_oauth_enrollment.js | 3 +- .../oobe_configuration/TestEnrollUsingToken.json | 9 ----- 9 files changed, 33 insertions(+), 106 deletions(-) commit 7a1760fa9078626f62c18733b569bf298ccb871d Author: Ben Pastene <bpastene@chromium.org> Date: Mon Dec 10 18:07:58 2018 +0000 Strip symbols when deploying chrome to cros VMs during tast tests. It's looking like we don't have enough disk space in the VM for this. I'll look into increasing partition sizes before turning this back on. TBR=dpranke Bug: 913153 Change-Id: I7d0ac50ed45171f69d294596a0c35b3cd46e4a94 Reviewed-on: https://chromium-review.googlesource.com/c/1369036 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#615172} build/chromeos/run_vm_test.py | 1 - 1 file changed, 1 deletion(-) commit 9b2b72908eea49c91ae392764b7171e287667e4b Author: Scott Violet <sky@chromium.org> Date: Mon Dec 10 18:05:24 2018 +0000 aura: sets a name on the layer created by ClientSurfaceEmbedder This makes it easier when debugging. BUG=none TEST=none Change-Id: I57db3701620d38299ebd5509af98222746145655 Reviewed-on: https://chromium-review.googlesource.com/c/1369097 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#615171} ui/aura/mus/client_surface_embedder.cc | 1 + 1 file changed, 1 insertion(+) commit ddfbb23b27bc4448ce118a9f80eb31bf4a9dd20e Author: Scott Violet <sky@chromium.org> Date: Mon Dec 10 18:01:49 2018 +0000 chromeos: removes ContentRegionNotDrawnForClient test This test was written at a time when ash was a client of the window service and ran with an aura::Env::Mode of MUS. That's no longer the case, so this test doesn't make sense. BUG=902171 TEST=test only change Change-Id: I4eadb97b60a89b26c10dd1242d3e2f869e810969 Reviewed-on: https://chromium-review.googlesource.com/c/1370193 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615170} ash/wm/non_client_frame_controller_unittest.cc | 175 --------------------- ...romeos.single_process_mash.ash_unittests.filter | 3 - 2 files changed, 178 deletions(-) commit 264cb9cde1d16be7d257e4c16ca876759a4187da Author: Scott Violet <sky@chromium.org> Date: Mon Dec 10 17:57:44 2018 +0000 chromeos: reenable ExtensionWebRequestApiTest.WebRequestTypes I was unable to reproduce locally. Am going to reenable. If flakes more, will investigate. BUG=882631 TEST=test only change TBR=karandeepb@chromium.org Change-Id: I4bc07964ff30f6475f808c193f1c26db468d6775 Reviewed-on: https://chromium-review.googlesource.com/c/1370174 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615169} .../buildbot/filters/chromeos.single_process_mash.browser_tests.filter | 3 --- 1 file changed, 3 deletions(-) commit 4d25c185b96203ef6783438177035b7ab3810a89 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Mon Dec 10 17:57:40 2018 +0000 [Android FRE Refactor] Do not launch Chrome when user aborts FRE 3/5 This CL: - Changes the first run experience not to launch Chrome when the user aborts the first run experience - Copies the extras from the Chrome launch intent to the FirstRunActivity intent. This enables FirstRunActivity to locate the associated CustomTabsConnection and and trigger the custom tab FRE callback. - Renames FirstRunActivityBase#EXTRA_CHROME_LAUNCH_INTENT to make it clear that the PendingIntent should be run only when the user finishes the first run experience. BUG=901954 Change-Id: I7c58c8bf8882d8aecd099d3edf8237faef5762ae Reviewed-on: https://chromium-review.googlesource.com/c/1359867 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#615168} .../chrome/browser/firstrun/FirstRunActivity.java | 4 +- .../browser/firstrun/FirstRunActivityBase.java | 57 ++++++++++------- .../browser/firstrun/FirstRunFlowSequencer.java | 72 ++++++++++++---------- .../firstrun/LightweightFirstRunActivity.java | 4 +- 4 files changed, 78 insertions(+), 59 deletions(-) commit cd29bd4767adafbcad65d8a0c59272540aa7ebd5 Author: Sean Gilhuly <sgilhuly@chromium.org> Date: Mon Dec 10 17:56:04 2018 +0000 VizDevTools: Observe Surface hierarchy Implement SurfaceObserver methods in DOMAgentViz. Watch for Surfaces to be created, deleted, or referenced, and update the SurfaceElements accordingly. Bug: 816802 Change-Id: I9e24c0fa95c5d89a1f6c1309f2176fabec549011 Reviewed-on: https://chromium-review.googlesource.com/c/1359474 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#615167} components/ui_devtools/viz_views/dom_agent_viz.cc | 173 +++++++++++++++++++-- components/ui_devtools/viz_views/dom_agent_viz.h | 52 ++++++- .../ui_devtools/viz_views/surface_element.cc | 14 +- components/ui_devtools/viz_views/surface_element.h | 3 +- 4 files changed, 220 insertions(+), 22 deletions(-) commit 82bbc860a1b53b57149d61d76f4aa88478205cef Author: Fletcher Woodruff <fletcherw@chromium.org> Date: Mon Dec 10 17:48:12 2018 +0000 Add .WhileSuspended for temperature metrics Adds a sub-metric .WhileSuspended for Platform.Temperature.Sensor[0-2] and Platform.Thermal.Temperature.Cpu.0. This is used to report the temperature from those sensors when resuming from a suspend that is sufficiently long. Change-Id: Ia5799d572164533e961caca577a8484561737b1a Reviewed-on: https://chromium-review.googlesource.com/c/1366266 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Fletcher Woodruff <fletcherw@chromium.org> Cr-Commit-Position: refs/heads/master@{#615166} tools/metrics/histograms/histograms.xml | 44 +++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) commit f8bce21c3d446b81949d420cbbce895dacf61c9a Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 10 17:47:46 2018 +0000 [ios] Remove WKWebView default background color. Bug: 912151 Change-Id: Ibb7993986a94bd139443d555f48e2c95800074d5 Reviewed-on: https://chromium-review.googlesource.com/c/1368695 Reviewed-by: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615165} ios/web/web_state/ui/crw_web_controller.mm | 1 - 1 file changed, 1 deletion(-) commit ffb4d235d408e6e06f749e65406c2e652e9fa10c Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Dec 10 17:47:06 2018 +0000 SingleProcessMash: Fix browser window move with VK - Wire up RemoteTextInputClient::EnsureCaretNotInRect to forward the call to the actual TextInputClient; - Fix ime_util_chromeos to handle windows under MUS mode; - Change ChromeKeyboardBoundsObserver to use WidgetObserver to get bounds change of toplevel browser window under mash; Bug: 631527, 906888, 906859 Change-Id: I1570f8e3254e025106a120cf5ee538c20367c405 Reviewed-on: https://chromium-review.googlesource.com/c/1366879 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615164} .../keyboard/chrome_keyboard_bounds_observer.cc | 41 +++++++++++----------- .../ash/keyboard/chrome_keyboard_bounds_observer.h | 16 ++++----- .../input_method_bridge_chromeos_unittest.cc | 1 + .../views/ime_driver/remote_text_input_client.cc | 3 +- services/ws/ime/ime_unittest.cc | 1 + services/ws/public/mojom/ime/ime.mojom | 4 +++ ui/aura/mus/text_input_client_impl.cc | 4 +++ ui/aura/mus/text_input_client_impl.h | 1 + .../desktop_aura/desktop_screen_position_client.cc | 9 ++--- ui/wm/core/ime_util_chromeos.cc | 28 ++++++++------- 10 files changed, 60 insertions(+), 48 deletions(-) commit 1e0b2e8a2f8490de9515c73120b16670ba17b30f Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Dec 10 17:46:43 2018 +0000 Preconnect to the main frame origin Logic to preconnect to the main frame origin when app or tab is brought to the foreground. The preconnect action is behind a finch trial, and is disabled by default. Change-Id: I0fb183d75997c702585b294da59016131b254683 Bug: 908725 Reviewed-on: https://chromium-review.googlesource.com/c/1365076 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#615163} .../navigation_predictor/navigation_predictor.cc | 44 ++++++- .../navigation_predictor/navigation_predictor.h | 6 + .../navigation_predictor_browsertest.cc | 135 +++++++++++++++++++++ .../navigation_predictor_unittest.cc | 28 +++-- .../browser/predictors/loading_predictor_config.h | 2 +- 5 files changed, 198 insertions(+), 17 deletions(-) commit 421d7dfcf36a51d6687dc2c0b0b3ad6933964c8c Author: Ben Pastene <bpastene@chromium.org> Date: Mon Dec 10 17:41:53 2018 +0000 Add luci-notify configs for all of chromium.fuzz. This will email the configured groups when the builders on chromium.fuzz fail. This copies the current gatekeeper setup where all emails for the libfuzz bots that were on chromium.fyi go to chromesec-lkgr-failures@, while the emails for all the chromium.lkgr bots go to chrome-security-sheriff@ Bug: 903591 Change-Id: I4e016e9aaecfaa68557d5a3fd81f6ef55529fe65 Reviewed-on: https://chromium-review.googlesource.com/c/1368657 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Oliver Chang <ochang@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#615162} infra/config/global/luci-notify.cfg | 107 ++++++++++++++++++++++++++++++++++-- 1 file changed, 102 insertions(+), 5 deletions(-) commit 2c242ac9a61aeda8ff757b2649d01350cf17faaa Author: Scott Violet <sky@chromium.org> Date: Mon Dec 10 17:39:31 2018 +0000 ash: changes output when printing window hierarchy For proxy windows [proxy] is printed before the name. My rationale is that a window is a proxy is the most important thing, and should be first. This also makes it so that in single-process-mash mode we dump the client windows (and layers) too. BUG=none TEST=none Change-Id: Idd3289b6b35bc338c0b4fc74308fefff56cc38cc Reviewed-on: https://chromium-review.googlesource.com/c/1369186 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615161} ash/accelerators/debug_commands.cc | 39 +++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) commit a37027c5ec91f83aa022eec009665fdf014cc3b5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 17:31:17 2018 +0000 Roll src/third_party/webrtc b47ccc38e771..24d8ec3dbb2a (5 commits) https://webrtc.googlesource.com/src.git/+log/b47ccc38e771..24d8ec3dbb2a git log b47ccc38e771..24d8ec3dbb2a --date=short --no-merges --format='%ad %ae %s' 2018-12-10 andersc@webrtc.org Set @rpath in AppRTCMobile for macOS. 2018-12-10 nisse@webrtc.org Add SetKeyFrameRequestCallback to MediaTransportInterface 2018-12-10 eladalon@webrtc.org Remove redundant return-statement in VCMGenericEncoder::RequestFrame 2018-12-10 nisse@webrtc.org Convert NetEq tests to not use RegisterExternalDecoder. 2018-12-10 ssilkin@webrtc.org Activate/deactivate VP9 spatial layers. Created with: gclient setdep -r src/third_party/webrtc@24d8ec3dbb2a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6bd6085ece54af00165789626d515f7cce13b4d6 Reviewed-on: https://chromium-review.googlesource.com/c/1369836 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615160} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0c873bf2265189967d77b2cbccee70cfd14e9db9 Author: Samuel Huang <huangs@chromium.org> Date: Mon Dec 10 17:29:20 2018 +0000 [Sheriffing] Disable AppShimInteractiveTest.Launch (mac) due to flakiness. Tbr: ccameron@chromium.org Bug: 913490 Change-Id: I90fabcfe3bba129fbe2786738c3757526b423a6f Reviewed-on: https://chromium-review.googlesource.com/c/1369721 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615159} chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 900aca7bd92b9a7a8b83fcd554eaa79b7bd22746 Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Dec 10 17:28:00 2018 +0000 [iOS] Add Accessibility actions to omnibox popup row This CL adds accessibility custom actions (available when using the accessibility rotor) to the suggestions from the omnibox. Those actions allows the user to delete/append/switch to tab. Bug: 910124 Change-Id: I53711044596083030f948527862a55006d9960e0 Reviewed-on: https://chromium-review.googlesource.com/c/1358453 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615158} ios/chrome/app/strings/ios_strings.grd | 6 +++++ ios/chrome/browser/ui/omnibox/popup/BUILD.gn | 1 + .../browser/ui/omnibox/popup/omnibox_popup_row.h | 20 +++++++++++++++ .../browser/ui/omnibox/popup/omnibox_popup_row.mm | 4 +++ .../omnibox/popup/omnibox_popup_view_controller.mm | 29 ++++++++++++++++++++-- 5 files changed, 58 insertions(+), 2 deletions(-) commit fce879b44c0be70da8d2620c8ee49130c51c66c9 Author: Samuel Huang <huangs@chromium.org> Date: Mon Dec 10 17:26:50 2018 +0000 [Sheriff] Disable 3 tests from org.chromium.android_webview.test.AwDebugTest The following tests have been consistently failing on "Android CFI": org.chromium.android_webview.test.AwDebugTest#testDump org.chromium.android_webview.test.AwDebugTest#testDumpContainsWhitelistedKey org.chromium.android_webview.test.AwDebugTest#testDumpDoesNotContainNonWhitelistedKey Culprit is likely https://chromium-review.googlesource.com/c/chromium/src/+/1357941 but revert is likey painful, as seen in https://chromium-review.googlesource.com/c/chromium/src/+/1361286 This CL disables the test to denoise the system. Tbr: jperaza@chromium.org Bug: 913515 Change-Id: Ia62b796067294920164cfd37f662f40e467b2d07 Reviewed-on: https://chromium-review.googlesource.com/c/1370191 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615157} .../javatests/src/org/chromium/android_webview/test/AwDebugTest.java | 4 ++++ 1 file changed, 4 insertions(+) commit d8cf10ed9991886042c3ec60a29608e407fdcfe8 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Dec 10 17:23:16 2018 +0000 Display federation provider in a human-readable way in the password settings. Bug: 910681 Change-Id: I1fae5eb5382bdee7a0de4d241743cb5cc84e2a07 Reviewed-on: https://chromium-review.googlesource.com/c/1369801 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#615156} .../api/passwords_private/passwords_private_delegate_impl.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit ae5a5949d7298f65b47feb1fe51388fc75bb0c35 Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Mon Dec 10 17:21:58 2018 +0000 Tracing Service: simplify issuing clock markers There is no need to send mojo messages back and forth between the coordinator and agents just for issuing clock sync markers. Agents can issue those markers when they receive the StopAndFlush signal. Change-Id: I7973d2319e3f59728056707d9c13bbaddf14cd00 Reviewed-on: https://chromium-review.googlesource.com/c/1368276 Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615155} .../chromeos/arc/tracing/arc_tracing_bridge.cc | 1 - content/browser/tracing/cast_tracing_agent.cc | 1 - content/browser/tracing/cros_tracing_agent.cc | 1 - services/tracing/agent_registry.cc | 8 +--- services/tracing/agent_registry.h | 6 --- services/tracing/agent_registry_unittest.cc | 14 ++---- services/tracing/coordinator.cc | 52 +--------------------- services/tracing/coordinator.h | 9 ---- services/tracing/coordinator_unittest.cc | 6 +-- services/tracing/public/cpp/base_agent.cc | 11 +---- services/tracing/public/cpp/base_agent.h | 4 -- services/tracing/public/cpp/trace_event_agent.cc | 26 ++++------- services/tracing/public/cpp/trace_event_agent.h | 7 +-- services/tracing/public/mojom/tracing.mojom | 4 -- services/tracing/test_util.cc | 6 --- services/tracing/test_util.h | 2 - services/tracing/tracing_service_unittest.cc | 6 +-- 17 files changed, 25 insertions(+), 139 deletions(-) commit a1ce3a965c48bd2027c41537de7445a6b06224a9 Author: edchin <edchin@chromium.org> Date: Mon Dec 10 17:21:19 2018 +0000 Reland "[ios] [BVC refactor] Move -setActive: to coordinator" This reverts commit f382b6e79294af1830a8e3c72d33b839a4eced00. Reason for revert: The original CL had unittest failures in app_state_unittest.mm. This reland fixes the unittest failures. Original change's description: > Revert "[ios] [BVC refactor] Move -setActive: to coordinator" > > This reverts commit 5a6e3d0b90f8066a3216fe4df498e22aeea43306. > > Reason for revert: Causing ios-simulator to fail > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator/40000 > > Original change's description: > > [ios] [BVC refactor] Move -setActive: to coordinator > > > > This CL moves the method -setActive: to the coordinator layer since > > it deals with many child coordinators. > > > > Change-Id: I8e61ece1380169ffc10e9e00bccaa68dbde7d4d4 > > Reviewed-on: https://chromium-review.googlesource.com/c/1355924 > > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: edchin <edchin@chromium.org> > > Commit-Queue: edchin <edchin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#613219} > > TBR=rohitrao@chromium.org,edchin@chromium.org,gambard@chromium.org > > Change-Id: I11142de3a5ae09066c23e04c490fb701c241e414 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/1359833 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613445} TBR=rohitrao@chromium.org,calamity@chromium.org,edchin@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I906486630acb0d5407b230b57256d7226588625f Reviewed-on: https://chromium-review.googlesource.com/c/1366373 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615154} ios/chrome/app/application_delegate/app_state.mm | 4 +++- ios/chrome/app/application_delegate/app_state_unittest.mm | 8 +++++++- ios/chrome/app/main_controller.mm | 12 ++++++------ ios/chrome/browser/ui/main/browser_coordinator.h | 6 ++++++ ios/chrome/browser/ui/main/browser_coordinator.mm | 10 ++++++++++ 5 files changed, 32 insertions(+), 8 deletions(-) commit 94e5b0de9fa84eff91b8be53a0011002e897f880 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Mon Dec 10 17:17:41 2018 +0000 [AF] Add metrics to track dropdown suppressed This is a follow-up of crrev.com/c/1346734 to allow us measure how often suppression happens with the new dropdown. Bug: 911842 Change-Id: I7519a7867b6de99998df55acab5bbb0df00668e3 Reviewed-on: https://chromium-review.googlesource.com/c/1362292 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615153} .../ui/autofill/autofill_popup_controller_impl.cc | 1 + .../autofill/autofill_popup_controller_unittest.cc | 1 + .../core/browser/autofill_external_delegate.cc | 4 + .../core/browser/autofill_external_delegate.h | 1 + .../autofill/core/browser/autofill_manager.cc | 16 +++ .../autofill/core/browser/autofill_manager.h | 4 + .../core/browser/autofill_manager_unittest.cc | 37 +++++++ .../autofill/core/browser/autofill_metrics.cc | 11 ++ .../autofill/core/browser/autofill_metrics.h | 8 ++ .../core/browser/autofill_metrics_unittest.cc | 123 +++++++++++++++++++++ .../core/browser/autofill_popup_delegate.h | 2 + .../core/browser/password_autofill_manager.cc | 2 + .../core/browser/password_autofill_manager.h | 1 + tools/metrics/histograms/enums.xml | 2 + 14 files changed, 213 insertions(+) commit bbbed0b0dc7985d9b04de67fe48248477144d7ea Author: Mason Freed <masonfreed@chromium.org> Date: Mon Dec 10 17:16:15 2018 +0000 Adding Skip to the other backdrop-filter-with-filter test. TBR=masonfreed@chromium.org NOTRY=true Bug: 913114 Change-Id: I4b23a9d9b10af0d0b554962fa3c2f62be29bf360 Reviewed-on: https://chromium-review.googlesource.com/c/1370195 Reviewed-by: Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#615152} third_party/blink/web_tests/TestExpectations | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit d4a7f9c6b6843e98a3e7fe53a66c398e618bd46c Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Mon Dec 10 17:15:46 2018 +0000 Ignore non-deterministic test animation-001.html. StyleResolver::ApplyAnimatedStandardProperties does not guarantee that active interpolations are applied in any specific order. This means that animations involving both flow-relative properties and equivalent physical properties produce non-deterministic computed values. This was discovered when adding a new (entirely unrelated) CSS property, which generated a new entry in the CSSPropertyID enum, which ultimately resulted in a different value for PropertyHandle::GetHash for subsequent properties (enum-wise) properties, and a different iteration order for the map of active interpolations. Bug: 913458 Change-Id: I022e106664e2bcadf65a1d846ded477e0df54a85 Reviewed-on: https://chromium-review.googlesource.com/c/1370168 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#615151} third_party/blink/web_tests/TestExpectations | 3 +++ .../wpt/css/css-logical/animation-001-expected.txt | 27 ---------------------- 2 files changed, 3 insertions(+), 27 deletions(-) commit f4a3f14769d5e7e338d86116659cc8e440663671 Author: Michael Thiessen <mthiesse@chromium.org> Date: Mon Dec 10 17:11:37 2018 +0000 Fix typo in eclipse classpath TBR=jinsukkim@chromium.org Change-Id: Ifd79cbb75165d585e7f6788f06920b0fe6fc3f69 Reviewed-on: https://chromium-review.googlesource.com/c/1370192 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#615150} tools/android/eclipse/.classpath | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d27917cc986fc9f099c0e7312513dec93221099d Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Dec 10 17:02:01 2018 +0000 heap: Fix write barriers for WeakMember and MemberBase::Swap - WeakMembers are currently filtering out nullptr values by not adding a callback entry for processing in the atomic pause. This requires a write barrier to be fired as otherwise a later write could add an object that is missed during processing in the atomic pause. This will crash on the next GC or any access to the WeakMember after the GC. (Relying on this, a further optimization could filter out already marked values and not create a callback entry for the atomic pause for them.) - The second missed write barrier was for MemberBase::Swap. Bug: 913431 Change-Id: Ic64a90975864e1632cbd5fbedfcf178ca44ec13a Reviewed-on: https://chromium-review.googlesource.com/c/1369794 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615149} .../platform/heap/incremental_marking_test.cc | 63 ++++- third_party/blink/renderer/platform/heap/member.h | 262 ++++++++++----------- 2 files changed, 184 insertions(+), 141 deletions(-) commit 801d7bb6f954296b5c30537fd38be05e7fbbd9bb Author: Vincent Boisselle <vincb@chromium.org> Date: Mon Dec 10 16:56:07 2018 +0000 Added a check for the Autofill API url to make sure that calls are made to Google endpoints and added api key to legacy server requests. Bug: 913046 Change-Id: I4897aabe83c05e9b19760b689a9c8c23b2595ec7 Reviewed-on: https://chromium-review.googlesource.com/c/1368446 Commit-Queue: Vincent Boisselle <vincb@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#615148} .../core/browser/autofill_download_manager.cc | 11 +++++--- .../browser/autofill_download_manager_unittest.cc | 31 +++++++++++++++------- 2 files changed, 28 insertions(+), 14 deletions(-) commit 9379ea869b26e47929741d7f18eb27b5078a868f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 16:46:12 2018 +0000 Roll src/third_party/skia e1c2354d08ba..a6e0c2b19c78 (7 commits) https://skia.googlesource.com/skia.git/+log/e1c2354d08ba..a6e0c2b19c78 git log e1c2354d08ba..a6e0c2b19c78 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 mtklein@google.com use lld-link any time we have it 2018-12-10 bsalomon@google.com Add glTexParameterf[v] to GrGLInterface 2018-12-10 michaelludwig@google.com Add clamp to border wrap mode to gpu 2018-12-10 caryclark@skia.org fix bookmaker nightly 2018-12-10 brianosman@google.com Finish removing sample shading support 2018-12-10 mtklein@google.com roll up to "msvc != x86" 2018-12-10 bsalomon@google.com Link using lld-link when target_os="win" and host_os != "win" Created with: gclient setdep -r src/third_party/skia@a6e0c2b19c78 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I0690a5ff339db6a1432b14365f91ba0842ffadba Reviewed-on: https://chromium-review.googlesource.com/c/1369834 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615147} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bac7853f0c9d7a9e0c0dd5cb5185e99735f46c44 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Dec 10 16:44:29 2018 +0000 Roll src-internal 3831c1916774..ea53736df1e2 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3831c1916774..ea53736df1e2 Created with: gclient setdep -r src-internal@ea53736df1e2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0dd0e899d7d89d1ea8447c0db02e4e1259760c49 Reviewed-on: https://chromium-review.googlesource.com/c/1369835 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615146} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fde728b7db07b48557d77f7de34a8d165d728d22 Author: Harald Alvestrand <hta@chromium.org> Date: Mon Dec 10 16:36:08 2018 +0000 Add WPT tests for correct parsing of msid Bug: None Change-Id: Ib12aa3660a1b1d2c350d7fd81aaff810b3d979cc Reviewed-on: https://chromium-review.googlesource.com/c/1365443 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#615145} .../wpt/webrtc/protocol/msid-parse-expected.txt | 7 +++ .../external/wpt/webrtc/protocol/msid-parse.html | 69 ++++++++++++++++++++++ .../wpt/webrtc/protocol/msid-parse-expected.txt | 7 +++ 3 files changed, 83 insertions(+) commit 7ae8e13f9754bba95976bc332144d097d8afd536 Author: Leonard Grey <lgrey@chromium.org> Date: Mon Dec 10 16:34:28 2018 +0000 Mac: disable right click when move loop is active This is an attempt at a mergeable workaround to crbug.com/876493 While the only repro we have involves right clicking to spawn a context menu while dragging the tab, we're not sure that this is the only way to trigger the crash (though a few days with this on Canary should give us a better idea). Any real fix would change event handling in a way that's not contained enough for us to be comfortable merging. Bug: 876493 Change-Id: I214ac37dd01936e4a45b2878c904838841c865e7 Reviewed-on: https://chromium-review.googlesource.com/c/1369633 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#615144} ui/views_bridge_mac/bridged_content_view.h | 2 ++ ui/views_bridge_mac/bridged_content_view.mm | 6 ++++++ ui/views_bridge_mac/bridged_native_widget_impl.mm | 2 ++ 3 files changed, 10 insertions(+) commit df0477e9ca0423600017a6e6fb566ff5784c7667 Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Dec 10 16:31:24 2018 +0000 Pausable Object Cleanup - XMLHttpRequest The events dispatched by the XMLHttpRequestEventThrottle are attached to the kNetwork TaskQueue which is a pausable task queue. Verified progress events aren't received while an alert dialog is present. BUG=907125 Change-Id: I93d8bbf8151753c5ddfc14bbfdd067697f6fe01e Reviewed-on: https://chromium-review.googlesource.com/c/1368462 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#615143} .../core/xmlhttprequest/xml_http_request.cc | 32 ++++++---------------- .../core/xmlhttprequest/xml_http_request.h | 8 ++---- .../xml_http_request_progress_event_throttle.cc | 14 ---------- .../xml_http_request_progress_event_throttle.h | 3 -- 4 files changed, 12 insertions(+), 45 deletions(-) commit 28ea91210414c292fe00817ab03b01535a7c25da Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 10 16:30:26 2018 +0000 [ios] Clean up toolbar hiding logic when transitioning from the NTP. There are times when the NTP can be hidden but before the visibleURL changes. This can leave the BVC in a blank state where only the bottom toolbar is visible. Instead, if possible, use the NewTabPageTabHelper IsActive() value rather than checking -IsVisibleURLNewTabPage. Bug: 912151 Change-Id: I3bb9254ed6ecbb9184a9a75dfb14800444fc42b7 Reviewed-on: https://chromium-review.googlesource.com/c/1368693 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615142} ios/chrome/browser/ui/browser_view_controller.mm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) commit e6bcf2955ad656566c0160af26075c365e2988d7 Author: Yi Su <mrsuyi@chromium.org> Date: Mon Dec 10 16:25:30 2018 +0000 Add filter for <select> and <textarea> in FindInPage. This CL changes the HTML nodes type filter IGNORE_NODE_NAMES in find_in_page.js from Object to Set, and adds 2 more items because content inside <select> and <textarea> cannot be highlighted under current implementation. Bug: 912717 Change-Id: I72b4d0591eb9cf46c3017e2519ff43673cadd85a Reviewed-on: https://chromium-review.googlesource.com/c/1369797 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615141} ios/chrome/browser/find_in_page/resources/find_in_page.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) commit a399fc489488bfb1015aa67195def1d81652dd5d Author: Justin Cohen <justincohen@google.com> Date: Mon Dec 10 16:25:19 2018 +0000 [ios] Fix side swipe navigation card size for NTP. When the toolbar is hidden on the NTP extend the height of the side swipe view. Bug: 912151 Change-Id: Ic6560c522f954f8e544fc8a3fe75efcb310a41ee Reviewed-on: https://chromium-review.googlesource.com/c/1368691 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#615140} ios/chrome/browser/ui/browser_view_controller.mm | 5 +++++ 1 file changed, 5 insertions(+) commit 2280ac4585a4f9bef2da0f049f1de48273461f07 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Dec 10 16:23:51 2018 +0000 Update V8 to version 7.3.76.1 (cherry-pick). Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4bb7e4fa..d7617c68 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4705d94fc02b49be74e5739b605fb5bb87d14c57 Reviewed-on: https://chromium-review.googlesource.com/c/1369716 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615139} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b4fc383409e81c48285ef1de7c08a6fdc1311a4f Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Dec 10 16:23:05 2018 +0000 Reenable SingleClientSessionsSyncTest.CookieJarMismatch The test has been historically flaky but many things have changed since the last reported flakes (in particular, migration of SESSIONS to USS) so chances are that we no longer repro the flakes. We also do some related code cleanup. Bug: 789129 Change-Id: I7f70d8d0d1c96232ffe07197e8e1982759e8af02 Reviewed-on: https://chromium-review.googlesource.com/c/1369855 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#615138} .../single_client_sessions_sync_test.cc | 36 ++++++++-------------- 1 file changed, 12 insertions(+), 24 deletions(-) commit 2033984b17631d84ea4befb0fad905a965897655 Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Dec 10 16:22:28 2018 +0000 [ScrollTimeline] Upstream NaN currentTime tests to WPT This CL upstreams the NaN related currentTime tests to WPT. There are no behavioral changes. Bug: 911254 Change-Id: Ide27accae72cc55654890754ac404c7827889d09 Reviewed-on: https://chromium-review.googlesource.com/c/1366264 Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#615137} .../wpt/scroll-animations/current-time-nan.html} | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) commit 18d502790ac13e7fd6758086d8b02a3e82f3e8d8 Author: Joshua Pawlicki <waffles@chromium.org> Date: Mon Dec 10 16:21:59 2018 +0000 More CRX3 migration. This appears to be the last of the CRX files we need to migrate before landing a policy to control whether Chrome can load CRX2s or CRX3s. Bug: 740715 Change-Id: I41fae7acacc43c4843e3b809fe318f66d1202913 Reviewed-on: https://chromium-review.googlesource.com/c/1369717 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#615136} chrome/test/data/drive_first_run/app.crx | Bin 693 -> 720 bytes .../hcglmfcclpfgljeaiahehebeoaiicbko.crx | Bin 6002 -> 6835 bytes chrome/test/data/extensions/google_talk.crx | Bin 59128 -> 59936 bytes chrome/test/data/extensions/google_talk.pem | 52 +++++++++++++++++++++ chrome/test/data/extensions/kiosk/kiosk_only.crx | Bin 685 -> 712 bytes .../data/extensions/platform_apps/app_window_2.crx | Bin 1388 -> 1415 bytes .../test/data/extensions/show_managed_storage.crx | Bin 28643 -> 29380 bytes 7 files changed, 52 insertions(+) commit ddd36e3048f0b834ab6a07875e0596a3d54b6804 Author: Samuel Huang <huangs@chromium.org> Date: Mon Dec 10 16:21:20 2018 +0000 Revert "[Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation." This reverts commit a1b00bf181dd7ee4a636cc3e1f678e99223f5466. Reason for revert: Compile failure in ios-webview. Original change's description: > [Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation. > > The test expectations added for RequestInfo were always broken, but it > was not discovered because slim-nav was not run on CQ. > > Bug: 851119 > Change-Id: Ia9949553d9a0b97cb16a8435b5f8c95084ab1880 > Reviewed-on: https://chromium-review.googlesource.com/c/1369004 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615131} TBR=eugenebut@chromium.org,danyao@chromium.org Change-Id: I2ba72833afbdc5b1023ec2c0fabc58a432573b63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 851119 Reviewed-on: https://chromium-review.googlesource.com/c/1369800 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615135} ios/web/web_state/web_state_observer_inttest.mm | 39 ++++++++++--------------- 1 file changed, 16 insertions(+), 23 deletions(-) commit cef156a36f74d36a47cfc3e5744e8016028de313 Author: Christian Dullweber <dullweber@chromium.org> Date: Mon Dec 10 16:15:46 2018 +0000 Remove channel id from Clear-Site-Data Clear-Site-Data was still trying to delete channel ids, which lead to a failed DCHECK because channel ids were removed from FILERABLE_DATATYPES. Bug: 875053 Change-Id: I23db6a3f763b19523ca17206c546265247f7e35d Reviewed-on: https://chromium-review.googlesource.com/c/1370167 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#615134} content/browser/browsing_data/clear_site_data_handler_browsertest.cc | 1 - content/browser/browsing_data/clear_site_data_utils.cc | 1 - 2 files changed, 2 deletions(-) commit aa2b6de7a4195cacf26f6198f8e11c7ffb8a8b1c Author: David Jean <djean@google.com> Date: Mon Dec 10 16:14:08 2018 +0000 [ios] On large types, lay manual fallback fields on multiple lines Refactored manual_fill_cell_utils to make this easier. In address, John * E * Doe becomes John E Doe Bug: 912082 Change-Id: Ibe984f22be6b08cd8fd64917461edbcb27623ab1 Reviewed-on: https://chromium-review.googlesource.com/c/1366330 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#615133} .../browser/ui/autofill/manual_fill/action_cell.mm | 27 ++-- .../manual_fill/manual_fill_address_cell.mm | 140 ++++++++++----------- .../autofill/manual_fill/manual_fill_card_cell.mm | 29 +++-- .../autofill/manual_fill/manual_fill_cell_utils.h | 66 ++++++---- .../autofill/manual_fill/manual_fill_cell_utils.mm | 104 ++++++++------- .../manual_fill/manual_fill_password_cell.mm | 36 +++--- 6 files changed, 220 insertions(+), 182 deletions(-) commit c13969c0c6d9f314dfd04ffe226238366e93afe4 Author: Bence Béky <bnc@chromium.org> Date: Mon Dec 10 16:12:36 2018 +0000 Make QUIC_FLAG_COUNT* syntax platform-independent. Define QUIC_RELOADABLE_FLAG_COUNT_IMPL* and QUIC_RESTART_FLAG_COUNT_IMPL*. Move platform-specific prefixes to platform/impl. This is to remove differences from internal codebase. This lands server side change 224544179 by bnc. Change-Id: If0f78db226d0f584d251b5d621cf4bd5404a3ded Reviewed-on: https://chromium-review.googlesource.com/c/1367904 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#615132} .../quic/core/congestion_control/bbr_sender.cc | 20 +++++++++---------- .../congestion_control/general_loss_algorithm.cc | 10 +++++----- .../congestion_control/general_loss_algorithm.h | 10 +++++----- .../quic/core/congestion_control/pacing_sender.cc | 3 +-- .../quic/core/congestion_control/pacing_sender.h | 2 +- .../quic/core/crypto/quic_crypto_client_config.cc | 3 +-- .../quic/core/crypto/quic_crypto_server_config.cc | 8 ++++---- .../quic/core/http/quic_server_session_base.cc | 2 +- .../quic/core/http/quic_spdy_client_session.cc | 2 +- net/third_party/quic/core/http/quic_spdy_stream.cc | 2 +- net/third_party/quic/core/quic_connection.cc | 23 ++++++++++------------ net/third_party/quic/core/quic_connection.h | 7 +++---- .../quic/core/quic_control_frame_manager.cc | 3 +-- .../quic/core/quic_control_frame_manager.h | 5 ++--- .../quic/core/quic_crypto_client_handshaker.cc | 3 +-- net/third_party/quic/core/quic_data_reader.h | 4 ++-- net/third_party/quic/core/quic_data_writer.h | 4 ++-- net/third_party/quic/core/quic_dispatcher.cc | 6 +++--- net/third_party/quic/core/quic_dispatcher.h | 2 +- net/third_party/quic/core/quic_framer.cc | 6 ++---- net/third_party/quic/core/quic_framer.h | 5 ++--- net/third_party/quic/core/quic_lru_cache.h | 2 +- net/third_party/quic/core/quic_packet_reader.cc | 2 +- .../quic/core/quic_sent_packet_manager.cc | 12 +++++------ .../quic/core/quic_sent_packet_manager.h | 5 ++--- net/third_party/quic/core/quic_session.cc | 7 +++---- net/third_party/quic/core/quic_session.h | 2 +- net/third_party/quic/core/quic_stream_sequencer.cc | 3 +-- net/third_party/quic/core/quic_stream_sequencer.h | 3 +-- net/third_party/quic/core/quic_version_manager.h | 12 +++++------ .../quic/platform/api/quic_flag_utils.h | 7 +++++-- .../quic/platform/impl/quic_epoll_clock.cc | 2 +- .../quic/platform/impl/quic_flag_utils_impl.h | 12 ++++++++--- 33 files changed, 95 insertions(+), 104 deletions(-) commit a1b00bf181dd7ee4a636cc3e1f678e99223f5466 Author: Danyao Wang <danyao@chromium.org> Date: Mon Dec 10 15:59:48 2018 +0000 [Nav Experiment] Fix broken WebStateObserverTest.IframeNavigation. The test expectations added for RequestInfo were always broken, but it was not discovered because slim-nav was not run on CQ. Bug: 851119 Change-Id: Ia9949553d9a0b97cb16a8435b5f8c95084ab1880 Reviewed-on: https://chromium-review.googlesource.com/c/1369004 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#615131} ios/web/web_state/web_state_observer_inttest.mm | 39 +++++++++++++++---------- 1 file changed, 23 insertions(+), 16 deletions(-) commit 12ea37979d75aa70c8437eea568829714d88dc5f Author: Fredrik Söderquist <fs@opera.com> Date: Mon Dec 10 15:55:43 2018 +0000 Reduce type-impedance for LayoutImageResource::GetImage The container size will be converted to FloatSize in the end, so make the argument type a FloatSize too rather than a LayoutSize. Clean up callers, removing some conversions in SVGImagePainter, and add an IntSize overload (since it's common to call GetImage with an IntSize). Change-Id: I4f5c4389d21617ad60d18b258674999e9ef51f2c Reviewed-on: https://chromium-review.googlesource.com/c/1367651 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#615130} .../blink/renderer/core/layout/layout_image_resource.cc | 9 +++++++-- third_party/blink/renderer/core/layout/layout_image_resource.h | 3 ++- .../renderer/core/layout/layout_image_resource_style_image.cc | 4 ++-- .../renderer/core/layout/layout_image_resource_style_image.h | 2 +- third_party/blink/renderer/core/paint/image_painter.cc | 4 ++-- .../blink/renderer/core/paint/paint_property_tree_builder.cc | 4 ++-- third_party/blink/renderer/core/paint/svg_image_painter.cc | 10 +++------- 7 files changed, 19 insertions(+), 17 deletions(-) commit 04f4103842f32cee0b6206b96797a1b622642f60 Author: Matthew Cary <mattcary@chromium.org> Date: Mon Dec 10 15:55:27 2018 +0000 Android: enable clustering systemhealth orderfile. Changes the default for --system-health-orderfile in tools/cygprofile/orderfile_generator_backend.py. This enables the system health orderfile. See the bug for details, including recent performance information. Bug: 913436 Change-Id: Ib1c861000c1d2790aa6ce3e4817be38c7c190c4a Reviewed-on: https://chromium-review.googlesource.com/c/1369783 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#615129} tools/cygprofile/orderfile_generator_backend.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit fa3b8a1a2f60e1c2edb3189f57c12366a5374a28 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 15:52:06 2018 +0000 Roll src/third_party/webrtc 4348ce240aae..b47ccc38e771 (9 commits) https://webrtc.googlesource.com/src.git/+log/4348ce240aae..b47ccc38e771 git log 4348ce240aae..b47ccc38e771 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 kron@webrtc.org Add chroma siting to ColorSpace 2018-12-10 mirtad@webrtc.org Revert "Replace VideoEncoderFactory::QueryVideoEncoder with VideoEncoder::GetEncoderInfo" 2018-12-10 jonasolsson@webrtc.org Update connection states to match spec changes. 2018-12-07 zstein@webrtc.org Output plots for new DTLS events. 2018-12-07 solenberg@webrtc.org Remove unnecessary includes of common_types.h 2018-12-07 zstein@webrtc.org Reduce transaction ids independent of host byte order. 2018-12-07 benwright@webrtc.org Enable authentication of the header as an optional WebRTC trial. 2018-12-07 terelius@webrtc.org Only create ALR detector in PacedSender if deprecated functions are called. 2018-12-07 braveyao@webrtc.org desktopCapture: copy whole screen region when screen is zoomed on OSX Created with: gclient setdep -r src/third_party/webrtc@b47ccc38e771 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:911862 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9a9a8cbd3aceed0478efb254106e72415c12075b Reviewed-on: https://chromium-review.googlesource.com/c/1369830 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615128} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6be942365613e726a07925f91cf0811ef4a3a576 Author: Lan Wei <lanwei@chromium.org> Date: Mon Dec 10 15:38:26 2018 +0000 Update hover when scrolling over the options in dropdown list When we scroll over the options in dropdown list, we cannot update the hover effect by highlighting the option under mouse cursor blue. The reason is when we scroll, the mouse cursor does not really move, but we want to update the hover and send right mouse boundary events, we send a fake mouse move event, but we do not send to DOM. The option list has an default mouse move listener to update the hover in listPicker.js, but we do not send mouse move for this case. If we want to fix it, we should use a mouseover listener to update the hover instead. Then the blue selection highlight will appear wherever the mouse cursor is placed when the options are scrolled, but the mouse cursor does not move. Bug: 909580 Change-Id: Iec0603016a4f674c4420eac5eb01b36aaefccbf0 Reviewed-on: https://chromium-review.googlesource.com/c/1362241 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#615127} third_party/blink/renderer/core/html/forms/resources/listPicker.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 4aaccd137c09929f543b993907bfc2f42f45dd27 Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Dec 10 15:38:23 2018 +0000 [ScrollTimeline] Upstream writing-mode currentTime tests to WPT This CL upstreams the writing-mode related currentTime tests to WPT. There are a few mostly non-behavioral changes to the tests in this CL: * Some comments were edited for clarity. * For tests with more than one assert_equals(), descriptions were added to the asserts. This is to help locate failing assert_equal lines, as jsharness does not print out the line number of a failure. * In a few places we had more than one assert_equals for the same scenario (e.g. multiple cases where scroll was after the startScrollOffset point). These have been deduplicated. Bug: 911254 Change-Id: I5e814acea281e2587164de634da9a5415b53de2c Reviewed-on: https://chromium-review.googlesource.com/c/1366263 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615126} .../current-time-writing-modes.html} | 248 +++++++++++---------- .../wpt/scroll-animations/current-time.html | 2 + 2 files changed, 128 insertions(+), 122 deletions(-) commit cd01dfdfc73cd2f927ad177c48a77f1c07c760aa Author: Jeremy Roman <jbroman@chromium.org> Date: Mon Dec 10 15:34:26 2018 +0000 Move Database::opened to std::atomic_bool. Bug: 736037 Change-Id: I645ec8a5871e8ed90b620fe28903ddb54fe4cc5b Reviewed-on: https://chromium-review.googlesource.com/c/1368034 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#615125} third_party/blink/renderer/modules/webdatabase/database.cc | 14 +++++--------- third_party/blink/renderer/modules/webdatabase/database.h | 9 +++++++-- 2 files changed, 12 insertions(+), 11 deletions(-) commit 6f3bfd0ab9e5e120d5c3e79c8946d54893a5c674 Author: Jonathan Ross <jonross@chromium.org> Date: Mon Dec 10 15:27:07 2018 +0000 Even more debug info to LayerTreeHost::SetViewportSizeAndScale CHECK This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/1363952 We narrowed down the failure. However we need to confirm a second aspect of the crash. This adds a bit more debug info to the CHECK statement. Bug: 900948 Change-Id: I4752e5adb7cebbb0f0e0d9d7f3e9b4638cd45f81 Reviewed-on: https://chromium-review.googlesource.com/c/1366296 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#615124} cc/trees/layer_tree_host.cc | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) commit c8e45dc550a919031aeda2f0b2c34928f641fa4b Author: Denis Kuznetsov <antrim@google.com> Date: Mon Dec 10 15:24:21 2018 +0000 [USB Enrollment] Add OOBE config key for enrollment token Added a code that would propagate enrollment token from OOBE config to EnrollmentScreen and start corresponding flow in EnrollmentHelper. Updated policy_testserver to reflect that USB-based enrollment uses attestation-based flow (although test server is not used in current browser_tests, they mock process on EnrollmentHelper level) Also updated configuration_keys.cc to fail on mismatched type for values, but only warn in case of extra keys in file. Bug: 854101 Change-Id: I93be43dcb90c0b1b200549b3d4091f7d1194e694 Reviewed-on: https://chromium-review.googlesource.com/c/1348891 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615123} .../browser/chromeos/login/configuration_keys.cc | 12 ++++-- chrome/browser/chromeos/login/configuration_keys.h | 1 + .../chromeos/login/enrollment/enrollment_screen.cc | 9 ++++- .../login/enterprise_enrollment_browsertest.cc | 43 ++++++++++++++++---- chrome/browser/chromeos/login/wizard_controller.cc | 12 ++++++ chrome/browser/chromeos/policy/enrollment_config.h | 3 ++ chrome/browser/policy/test/policy_testserver.py | 47 +++++++++++++--------- .../chromeos/login/oobe_screen_oauth_enrollment.js | 3 +- .../oobe_configuration/TestEnrollUsingToken.json | 9 +++++ 9 files changed, 106 insertions(+), 33 deletions(-) commit 180e423fe60fe99b7d927476e5637117817ee7de Author: Marc Treib <treib@chromium.org> Date: Mon Dec 10 15:20:47 2018 +0000 UKM SyncDisableObserver: fix pre-UnifiedConsent purging logic SyncDisableObserver has a list of conditions which must be fulfilled for UKM to be enabled, e.g. history Sync being enabled, and the Sync engine being initialized. Previously, it would trigger a purge if *any* of those conditions switched from true to false, independent of the others. For example, if history Sync was already disabled, and then the engine got un-initialized, that would trigger a purge. In that situation, UKM would already be inactive, so the purge is harmless, but also unnecessary. If SyncStandaloneTransport is enabled, then this situation happens quite frequently. While the purges still don't do any actual harm, they do muddy up our metrics: We record a bunch of extra samples in the "true" bucket of "UKM.SyncDisable.Purge" (extra samples in the "false" bucket are expected simply because there are more Sync state changes). Bug: 856179, 906609 Change-Id: I6f7380961b8f343baad5ba7cdc6e25de452965d6 Reviewed-on: https://chromium-review.googlesource.com/c/1365438 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#615122} components/ukm/observers/sync_disable_observer.cc | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) commit 89c333da35fdb7faa95d807270a8e178b7ba0890 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Dec 10 15:17:52 2018 +0000 Worker: Update TestExpectations for external/wpt/workers/ These tests are no longer failing: - external/wpt/workers/semantics/reporting-errors/002.html - external/wpt/workers/interfaces/WorkerUtils/navigator/language.html Bug: 655458 Change-Id: I9c675508b686bd6fba227231ceac2da2a213caaa Tbr: nhiroki@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1369762 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#615121} third_party/blink/web_tests/TestExpectations | 4 ---- 1 file changed, 4 deletions(-) commit c9d9585eaa0e1664c000791ed6712f1521dd1dd8 Author: Clemens Hammacher <clemensh@chromium.org> Date: Mon Dec 10 15:14:39 2018 +0000 Rename WasmCompiledModule to WasmModuleObject This is the blink side of the renaming in v8: https://crrev.com/c/1362048. R=mlippautz@chromium.org CC=​titzer@chromium.org Bug: v8:8238, chromium:912031 Change-Id: I3877e3336c78bae456d53436a4d10c041bee92f9 Reviewed-on: https://chromium-review.googlesource.com/c/1369854 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#615120} .../bindings/core/v8/serialization/serialized_script_value.h | 2 +- .../bindings/core/v8/serialization/v8_script_value_deserializer.cc | 6 +++--- .../bindings/core/v8/serialization/v8_script_value_deserializer.h | 4 ++-- .../bindings/core/v8/serialization/v8_script_value_serializer.cc | 2 +- .../bindings/core/v8/serialization/v8_script_value_serializer.h | 2 +- third_party/blink/renderer/bindings/core/v8/v8_initializer.cc | 4 ++-- 6 files changed, 10 insertions(+), 10 deletions(-) commit 9b7be0476ae88da89ba58ebbe66495dde2b73e6a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Dec 10 15:05:45 2018 +0000 Roll src-internal 25560979954f..3831c1916774 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25560979954f..3831c1916774 Created with: gclient setdep -r src-internal@3831c1916774 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I069f3cd9eb2c81b8122ab7f6ac5fdab6f14ad607 Reviewed-on: https://chromium-review.googlesource.com/c/1369832 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615119} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c9097b27fb3a728473ce9e38e25bf9deeea2a444 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 15:04:48 2018 +0000 Roll src/third_party/skia 1a592c2a3dee..e1c2354d08ba (1 commits) https://skia.googlesource.com/skia.git/+log/1a592c2a3dee..e1c2354d08ba git log 1a592c2a3dee..e1c2354d08ba --date=short --no-merges --format='%ad %ae %s' 2018-12-10 iannucci@chromium.org [recipes] Manually roll recipes Created with: gclient setdep -r src/third_party/skia@e1c2354d08ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:913102 TBR=ethannicholas@chromium.org Change-Id: I8c5d768a03399f9f37ed9f00b7ca1966ed7983c7 Reviewed-on: https://chromium-review.googlesource.com/c/1369829 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615118} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 911c660e261e874f0b98f46e3966ff86a93713b5 Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Dec 10 15:04:33 2018 +0000 [Mac Context Menu] Add missing items to mac context menu (renderer) Due to bad refactoring in a previous change [1], some items like the Speech functionality was not being added properly. This is now fixed by allowing text_services_context_menu_.AppendToContextMenu(&menu_model_) to be called. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1045990/10/chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm See Bug for repro steps. Bug: 904339 Change-Id: I1794cd24c4b9b7f68ef892aa851a01affbb5cbdb Reviewed-on: https://chromium-review.googlesource.com/c/1366865 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#615117} .../ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) commit 7bda23a6a30fbc032054da4426cd93070907b290 Author: Yuki Shiino <yukishiino@chromium.org> Date: Mon Dec 10 15:03:28 2018 +0000 v8binding: Compile event handlers with currentTarget's scope https://crrev.com/c/1215512 mistakenly made content attribute's event handlers get compiled in the scope of event.target instead of the EventTarget where the event handler is registered. This patch fixes it so that event handlers correctly get compiled in the scope of the EventTarget where the event handler is registered, which is event->currentTarget() when dispatching an event. Bug: 913310, 891635 Change-Id: I6f1e5d6f3a44a10837acec572d82ed788f00af2c Reviewed-on: https://chromium-review.googlesource.com/c/1370144 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#615116} third_party/blink/renderer/bindings/core/v8/js_based_event_listener.cc | 2 +- third_party/blink/renderer/bindings/core/v8/js_event_handler.cc | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) commit 68c1d92a3636682a92cd7db078898fcdb4e2a191 Author: Samuel Huang <huangs@chromium.org> Date: Mon Dec 10 15:00:01 2018 +0000 Revert "Create RTCDtlsTransport objects in the blink layer" This reverts commit d7d59c5b7e4110ba0a7c1752387fb1b5ea0282cb. Reason for revert: virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCRtpSender-transport.https.html fails in "WebKit Linux Trusty MSAN". Original change's description: > Create RTCDtlsTransport objects in the blink layer > > This CL does on-demand creation of blink-layer transport > objects. It also introduces a way to get at the webrtc::PeerConnection > object from the WebPeerConnectionHandler API. > > Bug: chromium:907849 > Change-Id: Ic86a5a66289c31d1f939a47d58bc194c32471cbd > Reviewed-on: https://chromium-review.googlesource.com/c/1358060 > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615072} TBR=hta@chromium.org,haraken@chromium.org,hbos@chromium.org,guidou@chromium.org Change-Id: Ie9c8d2e3dc5f97fc94ca5bf43cc30a9407d9fa4c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:907849 Reviewed-on: https://chromium-review.googlesource.com/c/1369719 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615115} .../media/webrtc/mock_peer_connection_impl.h | 5 -- .../media/webrtc/rtc_peer_connection_handler.cc | 5 -- .../media/webrtc/rtc_peer_connection_handler.h | 1 - .../platform/web_rtc_peer_connection_handler.h | 3 - .../modules/peerconnection/rtc_dtls_transport.cc | 15 ++-- .../modules/peerconnection/rtc_dtls_transport.h | 13 +--- .../modules/peerconnection/rtc_peer_connection.cc | 50 +------------ .../modules/peerconnection/rtc_peer_connection.h | 8 --- .../modules/peerconnection/rtc_rtp_receiver.cc | 24 +------ .../modules/peerconnection/rtc_rtp_receiver.h | 11 +-- .../modules/peerconnection/rtc_rtp_receiver.idl | 2 - .../modules/peerconnection/rtc_rtp_sender.cc | 16 ----- .../modules/peerconnection/rtc_rtp_sender.h | 6 -- .../modules/peerconnection/rtc_rtp_sender.idl | 2 - .../modules/peerconnection/rtc_rtp_transceiver.cc | 2 - .../testing_platform_support_with_web_rtc.cc | 5 -- .../testing_platform_support_with_web_rtc.h | 1 - .../RTCRtpSender-transport.https-expected.txt | 8 --- .../wpt/webrtc/RTCRtpSender-transport.https.html | 84 ---------------------- .../webrtc/idlharness.https.window-expected.txt | 4 +- .../RTCRtpSender-transport.https-expected.txt | 8 --- .../webrtc/idlharness.https.window-expected.txt | 8 +-- .../global-interface-listing-expected.txt | 4 -- 23 files changed, 21 insertions(+), 264 deletions(-) commit 0817cc924940c3ad27588db82f34dde7bac07007 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 14:39:22 2018 +0000 Roll src/third_party/perfetto b961e4225263..2efdf1d56ab2 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/b961e4225263..2efdf1d56ab2 git log b961e4225263..2efdf1d56ab2 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 fmayer@google.com Fix incorrect copy path. Created with: gclient setdep -r src/third_party/perfetto@2efdf1d56ab2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I393896444a39faf4e8c15e93c5996c82017f56d6 Reviewed-on: https://chromium-review.googlesource.com/c/1369831 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615114} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 30fe563a6f62e4ae103572a0feaf952a583b3fe4 Author: Christopher Lam <calamity@chromium.org> Date: Mon Dec 10 14:28:37 2018 +0000 [WebUI] Cleanup ecmaVersion 2017 from .eslintrc.js files. This CL removes the ES2017 declaration from directory-specific .eslintrcs since src/.eslintrc.js now declares it. Bug: 905927 Change-Id: If800e42a07a7c36986c0c8220182147eeb73d217 Reviewed-on: https://chromium-review.googlesource.com/c/1369758 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615113} chrome/browser/resources/cryptotoken/.eslintrc.js | 8 -------- chrome/browser/resources/md_bookmarks/.eslintrc.js | 3 --- chrome/test/data/webui/md_bookmarks/.eslintrc.js | 3 --- chrome/test/data/webui/md_downloads/.eslintrc.js | 3 --- ui/file_manager/integration_tests/.eslintrc.js | 7 ------- 5 files changed, 24 deletions(-) commit 3f04290dc3a3434dc9f098f8603c3574a343851e Author: David Roger <droger@chromium.org> Date: Mon Dec 10 14:25:46 2018 +0000 [signin] Integration test for signin disallowed. The test checks that the Dice header is not added when browser signin is disallowed. Change-Id: I29524f6c07576fb36b9bfa5999412bda9285946f Reviewed-on: https://chromium-review.googlesource.com/c/1369931 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#615112} chrome/browser/signin/dice_browsertest.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 163cedad0195617a5d10625469f687e3a24d4837 Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Dec 10 14:09:10 2018 +0000 Add sync integration tests for history replaceState() Functionality has been around for some time but we haven't had integration tests that exercise the plumbing to the sync codebase and the actual expected outcome as observed on the server. Bug: 805090 Change-Id: Ie32311fb14183d1c90c2b17bf7a54fb157d6e9a6 Reviewed-on: https://chromium-review.googlesource.com/c/1363173 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#615111} .../sync/test/integration/sessions_helper.cc | 6 ++++ .../sync/test/integration/sessions_helper.h | 3 ++ .../single_client_sessions_sync_test.cc | 41 ++++++++++++++++++++++ chrome/test/data/sync/simple.html | 4 +++ 4 files changed, 54 insertions(+) commit 894db8aa562b40291fef1f00baa348f9843f5d29 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Mon Dec 10 14:02:17 2018 +0000 [tools/perf] Remove unused psutil module The "optionally" imported module is not being used at all. Bug: 776709 Change-Id: I08cf3cb7a109e737730bd13395021c34793b67eb Reviewed-on: https://chromium-review.googlesource.com/c/1366289 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#615110} tools/perf/core/results_dashboard.py | 4 ---- 1 file changed, 4 deletions(-) commit d8c92d61a1d196c3fcc41807e83ec64166fc398c Author: Florent Castelli <orphis@chromium.org> Date: Mon Dec 10 13:48:17 2018 +0000 Use EncoderSimulcastProxy instead of VP8EncoderSimulcastProxy The class is being renamed as it is generic and not VP8 specific. Bug: webrtc:10069 Change-Id: I7ec7812b26cb6d21897b7b48032b7874e895a24c Reviewed-on: https://chromium-review.googlesource.com/c/1367672 Reviewed-by: Florent Castelli <orphis@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615109} content/renderer/media/webrtc/video_codec_factory.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a3b72976938f9fdc1438b1e7543c767a539ee0c6 Author: Lowell Manners <lowell@chromium.org> Date: Mon Dec 10 13:47:26 2018 +0000 Update FakeGaiaCookieManagerService constructor to accept a TestUrlLoaderFactory FakeGaiaCookieManagerService's constructor takes in a boolean that allows the client to specify whether FakeGCMS should internally create a TestUrlLoaderFactory or implicitly use the one provided by SigninClient. This boolean defaults to the internal creation. This CL adds a constructor that takes in a TestUrlLoaderFactory*, which FakeGCMS will use. This replaces the case where true is (implicitly or explicitly) passed, with the difference that the caller is now responsible for owning the TestUrlLoaderFactory passed in. This CL also converts a few clients to show the pattern. This is step 1a of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: I6dc32bc71e292288cef5bf8ada868b9a55c821cd Reviewed-on: https://chromium-review.googlesource.com/c/1356944 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#615108} .../logo_service_impl_unittest.cc | 7 ++++-- .../core/browser/account_investigator_unittest.cc | 13 +++++------ .../browser/fake_gaia_cookie_manager_service.cc | 15 +++++++++++-- .../browser/fake_gaia_cookie_manager_service.h | 25 +++++++++++++++++++--- .../signin/core/browser/signin_manager_unittest.cc | 4 +++- .../signin/core/browser/signin_tracker_unittest.cc | 4 +++- 6 files changed, 53 insertions(+), 15 deletions(-) commit 5276c9bcb83aea7d4e63ee1339ede529b0e32905 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Dec 10 13:44:41 2018 +0000 Roll src-internal 75147590df7f..25560979954f (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/75147590df7f..25560979954f Created with: gclient setdep -r src-internal@25560979954f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idadff568fbf2b7c2ffac856450e7118e26194a9a Reviewed-on: https://chromium-review.googlesource.com/c/1370066 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615107} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e83dbb375025234a1ff532a5f078eaafc66eb0c3 Author: David Jean <djean@google.com> Date: Mon Dec 10 13:39:21 2018 +0000 [ios] Fixed search bar vertical centering for manual fallback passwords Applied fix from https://crrev.com/c/1219002 Before: https://drive.google.com/open?id=1AGNo9K6UaSiFfiUuwv66kWUaUjuO2EzZ After: https://drive.google.com/open?id=1HakPAtC3Kmsk97xAMhOqzlfmipWEGMg5 Bug: 912527 Change-Id: I0d006ce240afc9d3ac7c50bd25447a3a918f8f01 Reviewed-on: https://chromium-review.googlesource.com/c/1369777 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#615106} .../manual_fill/password_view_controller.mm | 36 ++++++++++++++++++++++ 1 file changed, 36 insertions(+) commit 71f8e9100df9a73586c09b2cb1ccd5fdbb00fc38 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Dec 10 13:23:43 2018 +0000 Roll src/third_party/perfetto 8563eaecd732..b961e4225263 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/8563eaecd732..b961e4225263 git log 8563eaecd732..b961e4225263 --date=short --no-merges --format='%ad %ae %s' 2018-12-10 fmayer@google.com Merge "fuzzing: Copy ftrace table." Created with: gclient setdep -r src/third_party/perfetto@b961e4225263 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I79a34057378fa90d5275758987ccdd1891fbe496 Reviewed-on: https://chromium-review.googlesource.com/c/1369828 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615105} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b8e1f9602afa7602824e9d04049b624d464dfcec Author: Henrik Boström <hbos@chromium.org> Date: Mon Dec 10 13:23:34 2018 +0000 Reenable "nomsid" test, expecting it to PASS. This was fixed by CL https://webrtc-review.googlesource.com/c/src/+/112900 which was rolled in to chromium by CL https://chromium-review.googlesource.com/c/1363234 TBR=guidou@chromium.org Bug: 907508 Change-Id: I1835b8ff73826aae4b7745dc82b17adb71c12901 Reviewed-on: https://chromium-review.googlesource.com/c/1369932 Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#615104} third_party/blink/web_tests/TestExpectations | 1 - 1 file changed, 1 deletion(-) commit 1f32f5d9f0394cbb22b0578150f12fb8fa8976bf Author: Eduardo Cordeiro <escordeiro@google.com> Date: Mon Dec 10 13:16:05 2018 +0000 Adding escordeiro and menegola as OWNERS for a few packages related to supervised users R=pam@chromium.org, treib@chromium.org Change-Id: I74633b1004fe25e148546e48e40a22664e08f037 Reviewed-on: https://chromium-review.googlesource.com/c/1369626 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Eduardo Cordeiro <escordeiro@chromium.org> Cr-Commit-Position: refs/heads/master@{#615103} chrome/browser/supervised_user/OWNERS | 2 ++ chrome/renderer/supervised_user/OWNERS | 1 + 2 files changed, 3 insertions(+) commit 1fc94f5a7f52bde4976609303631d97ab00a1bf3 Author: Boris Sazonov <bsazonov@chromium.org> Date: Mon Dec 10 13:07:04 2018 +0000 [Signin][Android] Synchronously seed accounts in SigninTestUtil This CL changes how SigninTestUtil seeds accounts into AccountTrackerService. Instead of calling invalidateAccountSeedStatus and hoping that accounts will be seeded at some point, new seedAccounts method synchronously seeds all accounts. Bug: 738533 Change-Id: I27346648d25bfa8ac3bf75ba1d926c3c741480ca Reviewed-on: https://chromium-review.googlesource.com/c/1368145 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#615102} .../chrome/test/util/browser/signin/SigninTestUtil.java | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) commit d228f1f2d4159959db125563d4caeaa82335bd19 Author: Morten Stenshorne <mstensho@chromium.org> Date: Mon Dec 10 13:01:26 2018 +0000 Typo in --no-manifest-update help. TBR=foolip@chromium.org Change-Id: I11842a6c018b234424890d86f3afdd167754a167 Reviewed-on: https://chromium-review.googlesource.com/c/1369852 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#615101} third_party/blink/tools/blinkpy/web_tests/run_webkit_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 65f7c38e0aac)