Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 34873 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8927137198085538672 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itCwHwnV/luci_context.810831944 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2229-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 41c7004723908611 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 36323f0591ce6cceb8749c5e7d9d876e4eb8eae7 app_list: Fix SearchResultView crash Xiyuan Xia, Fri Dec 14 19:25:01 2018 +0000 b90d813df13132022b06a6b51b77b03365e6f2d5 Used by reflection for test CCT dynamic module Sam Maier, Fri Dec 14 19:24:19 2018 +0000 a498573df6fc6cb114d2289bae29d8298500ecf4 WebUI: Add min-width to cr-action-menu John Lee, Fri Dec 14 19:17:54 2018 +0000 49d89d55ff609a1adc9511866e1b2e0358cd391f cros: Remove data saver extension notification Tony de Luna, Fri Dec 14 19:17:34 2018 +0000 29b53ad4641ba0dbbb518c0bd39b38c8cbc3fbc9 Reland "tracing: Port ARC tracing agent to perfetto" Eric Seckler, Fri Dec 14 19:12:02 2018 +0000 7a1319d0626d45603c40ea253b329fdbff4eae77 Disable interactive_ui_tests: SwitchAccessTest for Mash Steven Bennetts, Fri Dec 14 19:07:44 2018 +0000 5284c6b02f095b19bdfff254b502e4924e6ba17c Roll src/third_party/catapult afefc1c51fc4..a382be45b72a (1 commits) chromium-autoroll, Fri Dec 14 19:06:36 2018 +0000 5c8c3686998b162c2b5d33a6084920eb3bb360f6 Extract theme and page properties for StatusView Tomasz Wiszkowski, Fri Dec 14 19:05:50 2018 +0000 f12481667e5cd327ae64c06556ac1d7d0ed8e268 IndexedDB: Rename WebIDBNameAndVersion to IDBNameAndVersion Chase Phillips, Fri Dec 14 19:04:48 2018 +0000 0db12a5791138dff507e3868349c7b33df03d117 [iOS] Add coordinator for non-modal UIAlertController presentation. Kurt Horimoto, Fri Dec 14 19:03:34 2018 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 36323f0591ce6cceb8749c5e7d9d876e4eb8eae7 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Dec 14 19:25:01 2018 +0000 app_list: Fix SearchResultView crash Fix the crash introduced in http://crrev.com/c/1351714 that deletes the search-what-you-type result when showing the answer card. The change to SearchResults model does not go through regular search results update code path. Hence not handled properly. The CL fixes the issue by making SearchResultView handle OnResultDestroying so that its internal state is updated whenever underlying SearchResult goes away. Bug: 914891 Change-Id: Idc17516865333114e47b218d17d3629f50657f4a Reviewed-on: https://chromium-review.googlesource.com/c/1378487 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616782} ash/app_list/views/search_result_view.cc | 4 ++++ ash/app_list/views/search_result_view.h | 1 + 2 files changed, 5 insertions(+) commit b90d813df13132022b06a6b51b77b03365e6f2d5 Author: Sam Maier <smaier@chromium.org> Date: Fri Dec 14 19:24:19 2018 +0000 Used by reflection for test CCT dynamic module Also updated used by reflection to be more explicit. TBR=yfriedman Bug: 908988 Change-Id: I7a4b07fd60dd99afcf07239b9723d41cab575828 Reviewed-on: https://chromium-review.googlesource.com/c/1378240 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#616781} base/android/proguard/chromium_code.flags | 2 +- .../dynamicmodule/CustomTabsDynamicModuleTestUtils.java | 16 +++++++++------- 2 files changed, 10 insertions(+), 8 deletions(-) commit a498573df6fc6cb114d2289bae29d8298500ecf4 Author: John Lee <johntlee@chromium.org> Date: Fri Dec 14 19:17:54 2018 +0000 WebUI: Add min-width to cr-action-menu Bug: 619787 Change-Id: Ia998d22791573e4ae2cfb71039b15893165f32cb Reviewed-on: https://chromium-review.googlesource.com/c/1377311 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#616780} chrome/test/data/webui/cr_elements/cr_action_menu_test.js | 2 +- ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit 49d89d55ff609a1adc9511866e1b2e0358cd391f Author: Tony de Luna <tonydeluna@chromium.org> Date: Fri Dec 14 19:17:34 2018 +0000 cros: Remove data saver extension notification Stop showing chromeos users a notification prompting them to install a data saver extension the first time they connect with a cellular connection. Extension was recently removed. Remove flag 'enable-datasaver-prompt' and deprecate prefs::kDataSaverPromptsShown. Add more tests to validate that notifications are only shown once. Bug: 914470, 910767 Change-Id: I0c7799d9a57fcb207fcea946a4454b4edc466ef4 Reviewed-on: https://chromium-review.googlesource.com/c/1374581 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#616779} chrome/browser/about_flags.cc | 16 -- chrome/browser/flag_descriptions.cc | 7 - chrome/browser/flag_descriptions.h | 4 - chrome/browser/prefs/browser_prefs.cc | 3 + .../ui/ash/network/mobile_data_notifications.cc | 181 ++++----------------- .../ui/ash/network/mobile_data_notifications.h | 11 +- .../network/mobile_data_notifications_unittest.cc | 52 ++++-- chromeos/chromeos_switches.cc | 9 - chromeos/chromeos_switches.h | 3 - 9 files changed, 75 insertions(+), 211 deletions(-) commit 29b53ad4641ba0dbbb518c0bd39b38c8cbc3fbc9 Author: Eric Seckler <eseckler@chromium.org> Date: Fri Dec 14 19:12:02 2018 +0000 Reland "tracing: Port ARC tracing agent to perfetto" This is a reland of 624045587baefaab9fc7a601cacfc8488071381a with fixes to the state reset logic in ArcTracingBridge and ArcTracingDataSource. Original change's description: > tracing: Port ARC tracing agent to perfetto > > Adds a new DataSource for the ARC++ system tracing agent. > Each ArcTracingBridge registers with the data source and keeps track of > its state, so that the data source can coordinate tracing between all > the bridges. > > TBR=oysteine@google.com > > Test: Manually capture a trace with and without perfetto backend. > Bug: 900603 > Change-Id: Ieb29bcb65de9f4802965a30844e9f76af55db1f3 > Reviewed-on: https://chromium-review.googlesource.com/c/1360736 > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Yusuke Sato <yusukes@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615483} TBR=oysteine@google.com Bug: 900603 Change-Id: I018a9493e660fa9654ad31da734866b3835786a0 Reviewed-on: https://chromium-review.googlesource.com/c/1374982 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#616778} chrome/browser/chromeos/arc/tracing/DEPS | 4 + .../chromeos/arc/tracing/arc_tracing_bridge.cc | 371 ++++++++++++++++++--- .../chromeos/arc/tracing/arc_tracing_bridge.h | 82 +++-- services/tracing/BUILD.gn | 9 + services/tracing/perfetto/json_trace_exporter.cc | 12 + .../tracing/public/mojom/perfetto_service.mojom | 1 + 6 files changed, 398 insertions(+), 81 deletions(-) commit 7a1319d0626d45603c40ea253b329fdbff4eae77 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Dec 14 19:07:44 2018 +0000 Disable interactive_ui_tests: SwitchAccessTest for Mash This feature does not work in Mash yet. Bug: 897365 Change-Id: I1fe5bb6436a4df340ab093089f8eaf0139876da4 Reviewed-on: https://chromium-review.googlesource.com/c/1377377 Reviewed-by: Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#616777} testing/buildbot/filters/chromeos.mash.fyi.interactive_ui_tests.filter | 1 + 1 file changed, 1 insertion(+) commit 5284c6b02f095b19bdfff254b502e4924e6ba17c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 19:06:36 2018 +0000 Roll src/third_party/catapult afefc1c51fc4..a382be45b72a (1 commits) https://chromium.googlesource.com/catapult.git/+log/afefc1c51fc4..a382be45b72a git log afefc1c51fc4..a382be45b72a --date=short --no-merges --format='%ad %ae %s' 2018-12-14 mthiesse@chromium.org Allow the caller to specify tracing categories for adb_profile_chrome_startup Created with: gclient setdep -r src/third_party/catapult@a382be45b72a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I02c33e9188afc3baba59f56d426876516c7c8aa9 Reviewed-on: https://chromium-review.googlesource.com/c/1378446 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616776} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5c8c3686998b162c2b5d33a6084920eb3bb360f6 Author: Tomasz Wiszkowski <ender@google.com> Date: Fri Dec 14 19:05:50 2018 +0000 Extract theme and page properties for StatusView Change-Id: I1f1c090a22cdb366fc67ab09afd65c80add1e489 Bug: 871798 Reviewed-on: https://chromium-review.googlesource.com/c/1372708 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#616775} .../chrome/browser/omnibox/LocationBarLayout.java | 19 +++-- .../browser/omnibox/status/StatusMediator.java | 47 +++++++++++ .../browser/omnibox/status/StatusProperties.java | 35 +++++++++ .../chrome/browser/omnibox/status/StatusView.java | 39 ++++++++++ .../browser/omnibox/status/StatusViewBinder.java | 90 ++++++++++++++++++++++ .../omnibox/status/StatusViewCoordinator.java | 66 +++++----------- .../browser/toolbar/ToolbarDataProvider.java | 34 -------- chrome/android/java_sources.gni | 3 + 8 files changed, 246 insertions(+), 87 deletions(-) commit f12481667e5cd327ae64c06556ac1d7d0ed8e268 Author: Chase Phillips <cmp@chromium.org> Date: Fri Dec 14 19:04:48 2018 +0000 IndexedDB: Rename WebIDBNameAndVersion to IDBNameAndVersion Bug: 717812 Change-Id: Iad2535883687a6302ebd96a092329c4f1fe91efd Reviewed-on: https://chromium-review.googlesource.com/c/1364343 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#616774} .../blink/renderer/modules/indexeddb/BUILD.gn | 2 +- .../blink/renderer/modules/indexeddb/idb_factory.cc | 18 +++++++++--------- .../renderer/modules/indexeddb/idb_factory_test.cc | 17 ++++++++--------- .../modules/indexeddb/idb_name_and_version.h | 20 ++++++++++++++++++++ .../modules/indexeddb/indexed_db_blink.typemap | 2 +- .../modules/indexeddb/indexed_db_callbacks_impl.cc | 10 ++++------ .../modules/indexeddb/mock_web_idb_callbacks.h | 4 ++-- .../renderer/modules/indexeddb/web_idb_callbacks.h | 6 +++--- .../modules/indexeddb/web_idb_callbacks_impl.cc | 5 ++--- .../modules/indexeddb/web_idb_callbacks_impl.h | 3 +-- .../modules/indexeddb/web_idb_name_and_version.h | 20 -------------------- 11 files changed, 51 insertions(+), 56 deletions(-) commit 0db12a5791138dff507e3868349c7b33df03d117 Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Dec 14 19:03:34 2018 +0000 [iOS] Add coordinator for non-modal UIAlertController presentation. This coordinator disables fullscreen while started and creates a NonModalAlertPresentationController. The non-modal presentation is achieved by adding a mask to the presentation container view and forwarding touches that occur outside that mask to the BVC. Also in this CL: - Updates AlertCoordinator to define the lazy instantiation selector in the Subclassing category. - Updates some FullscreenUIElement selectors to be optional. Bug: 674649 Change-Id: Ie0df9a993871ebe1a88fda9578093abc38da57c3 Reviewed-on: https://chromium-review.googlesource.com/c/1360273 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#616773} .../ui/alert_coordinator/alert_coordinator.h | 6 +- .../ui/alert_coordinator/alert_coordinator.mm | 2 - ios/chrome/browser/ui/dialogs/BUILD.gn | 2 + ios/chrome/browser/ui/dialogs/non_modal/BUILD.gn | 55 ++++++++++ .../non_modal/non_modal_alert_coordinator.h | 22 ++++ .../non_modal/non_modal_alert_coordinator.mm | 93 ++++++++++++++++ .../non_modal_alert_presentation_updater.h | 52 +++++++++ .../non_modal_alert_presentation_updater.mm | 96 +++++++++++++++++ ...on_modal_alert_presentation_updater_unittest.mm | 118 +++++++++++++++++++++ .../non_modal/non_modal_alert_touch_forwarder.h | 39 +++++++ .../non_modal/non_modal_alert_touch_forwarder.mm | 59 +++++++++++ .../non_modal_alert_touch_forwarder_unittest.mm | 69 ++++++++++++ .../ui/fullscreen/fullscreen_controller_observer.h | 4 +- .../browser/ui/fullscreen/fullscreen_mediator.mm | 4 +- .../browser/ui/fullscreen/fullscreen_ui_element.h | 13 +++ .../browser/ui/fullscreen/fullscreen_ui_updater.h | 4 + .../browser/ui/fullscreen/fullscreen_ui_updater.mm | 20 +++- .../fullscreen/fullscreen_ui_updater_unittest.mm | 23 +++- .../test/test_fullscreen_controller_observer.h | 4 +- .../test/test_fullscreen_controller_observer.mm | 8 +- ios/chrome/test/BUILD.gn | 1 + 21 files changed, 680 insertions(+), 14 deletions(-) commit a724b7656ccf728f169826b74f1eebe7af393053 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Dec 14 19:02:42 2018 +0000 RemoteMacViews: Make certificate and file dialogs better The certificate and file selection dialogs have not been adapted to be able to run across processes using mojo. At present, these dialogs appear behind their expected window, and appear in the Chrome process. Make this situation better by making them appear in front of their window (and, in front of everything). Because some of these positioning decisions are made before the true window geometry has been communicated back to the browser process, more aggressively push geometry changes to the in-browser-process NSWindow. Bug: 913303 Change-Id: Ife2fbddcd758ee0b028743a916d12cf8ce0f41f3 Reviewed-on: https://chromium-review.googlesource.com/c/1378017 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#616772} .../ui/views/certificate_viewer_mac_views.mm | 17 +++++++- ui/base/BUILD.gn | 2 + ui/base/cocoa/remote_views_window.h | 25 ++++++++++++ ui/base/cocoa/remote_views_window.mm | 45 ++++++++++++++++++++++ ui/shell_dialogs/select_file_dialog_mac.mm | 9 +++++ ui/views/cocoa/bridged_native_widget_host_impl.h | 6 +++ ui/views/cocoa/bridged_native_widget_host_impl.mm | 19 ++++----- 7 files changed, 112 insertions(+), 11 deletions(-) commit 51d2955b1738b6b963f9b7478b3446b956413292 Author: Daniel McArdle <dmcardle@chromium.org> Date: Fri Dec 14 19:00:37 2018 +0000 Enforce maximum domain name length in DNS response parser Bug: 811618 Change-Id: I57dc54e56e3a857f05b34dffdefcec634719e0d6 Reviewed-on: https://chromium-review.googlesource.com/c/1369638 Reviewed-by: Eric Orth <ericorth@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#616771} net/dns/dns_record_fuzzer.cc | 15 +++++++ net/dns/dns_response.cc | 32 +++++++++++++-- net/dns/dns_response_unittest.cc | 87 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 130 insertions(+), 4 deletions(-) commit 5eb1773a439166fee05887db3375e0e809da27fe Author: Tommy Steimel <steimel@chromium.org> Date: Fri Dec 14 19:00:12 2018 +0000 Update MediaKeysListener API to set specific keys to listen to This CL updates the MediaKeysListener API to listen for a specific set of keys instead of listening to all media keys and depending on a response from the MediaKeysListener::Delegate to decide whether or not to propagate. The advantage of this change is that it allows the MediaKeysListener::Delegate::OnMediaKeysAccelerator callback to be called on the delegate's own thread for the Windows implementation. Before, since the Windows implementation depends on a keyboard hook which runs on a dedicated thread, it needed to immediately know the delegate's response so that it would know whether or not to propagate the key event. Now, the listener is already aware of which keys to propagate and can immediately propagate (or not) and post a task to the main thread to call delegate_->OnMediaKeysAccelerator asynchronously. Bug: 902379 Change-Id: Ib7cb27bd6bbcec382fb4a050166df19aa9131673 Reviewed-on: https://chromium-review.googlesource.com/c/1374832 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#616770} .../extensions/extension_keybinding_registry.cc | 39 +++------ .../extensions/extension_keybinding_registry.h | 6 +- .../extensions/global_shortcut_listener_mac.h | 6 +- .../extensions/global_shortcut_listener_mac.mm | 25 +----- chrome/common/extensions/command.cc | 11 +-- .../accelerators/global_media_keys_listener_win.cc | 94 ++++++++++++++++++---- .../accelerators/global_media_keys_listener_win.h | 32 +++++++- ...bal_media_keys_listener_win_interactive_test.cc | 70 +++++++++++----- ui/base/accelerators/media_keys_listener.cc | 6 ++ ui/base/accelerators/media_keys_listener.h | 33 +++----- ui/base/accelerators/media_keys_listener_mac.mm | 75 +++++++++-------- 11 files changed, 236 insertions(+), 161 deletions(-) commit 294f6c056b75bd521ef6377e2f40e20816d3610c Author: Yiming Zhou <uwyiming@google.com> Date: Fri Dec 14 18:57:01 2018 +0000 Adding new captured sites autofill tests. This cl stands up a subset of the tests first introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1150818. Bug: 847905 Change-Id: If64de9d457513a87e9ef2ba2bd37376a59ee4831 Reviewed-on: https://chromium-review.googlesource.com/c/1377504 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Yiming Zhou <uwyiming@google.com> Cr-Commit-Position: refs/heads/master@{#616769} .../data/autofill/captured_sites/abercrombie.sha1 | 1 + .../data/autofill/captured_sites/abercrombie.test | 279 +++++++++++++++ .../autofill/captured_sites/barnes_and_noble.sha1 | 1 + .../autofill/captured_sites/barnes_and_noble.test | 288 +++++++++++++++ .../captured_sites/bath_and_body_works.sha1 | 1 + .../captured_sites/bath_and_body_works.test | 352 +++++++++++++++++++ .../autofill/captured_sites/bed_bath_beyond.sha1 | 1 + .../autofill/captured_sites/bed_bath_beyond.test | 264 ++++++++++++++ .../data/autofill/captured_sites/bodybuilding.sha1 | 1 + .../data/autofill/captured_sites/bodybuilding.test | 335 ++++++++++++++++++ .../test/data/autofill/captured_sites/booking.sha1 | 1 + .../test/data/autofill/captured_sites/booking.test | 179 ++++++++++ .../autofill/captured_sites/crate_and_barrel.sha1 | 1 + .../autofill/captured_sites/crate_and_barrel.test | 339 ++++++++++++++++++ chrome/test/data/autofill/captured_sites/dell.sha1 | 1 + chrome/test/data/autofill/captured_sites/dell.test | 391 +++++++++++++++++++++ .../test/data/autofill/captured_sites/expedia.sha1 | 1 + .../test/data/autofill/captured_sites/expedia.test | 240 +++++++++++++ .../data/autofill/captured_sites/fanatics.sha1 | 1 + .../data/autofill/captured_sites/fanatics.test | 377 ++++++++++++++++++++ .../test/data/autofill/captured_sites/hotels.sha1 | 1 + .../test/data/autofill/captured_sites/hotels.test | 181 ++++++++++ .../data/autofill/captured_sites/just_fab.sha1 | 1 + .../data/autofill/captured_sites/just_fab.test | 245 +++++++++++++ .../test/data/autofill/captured_sites/kohls.sha1 | 1 + .../test/data/autofill/captured_sites/kohls.test | 368 +++++++++++++++++++ .../test/data/autofill/captured_sites/llbean.sha1 | 1 + .../test/data/autofill/captured_sites/llbean.test | 268 ++++++++++++++ .../test/data/autofill/captured_sites/lowes.sha1 | 1 + .../test/data/autofill/captured_sites/lowes.test | 229 ++++++++++++ .../data/autofill/captured_sites/nordstrom.sha1 | 1 + .../data/autofill/captured_sites/nordstrom.test | 351 ++++++++++++++++++ .../data/autofill/captured_sites/north_face.sha1 | 1 + .../data/autofill/captured_sites/north_face.test | 362 +++++++++++++++++++ .../data/autofill/captured_sites/overstock.sha1 | 1 + .../data/autofill/captured_sites/overstock.test | 312 ++++++++++++++++ .../test/data/autofill/captured_sites/talbots.sha1 | 1 + .../test/data/autofill/captured_sites/talbots.test | 246 +++++++++++++ .../autofill/captured_sites/ticket_master.sha1 | 1 + .../autofill/captured_sites/ticket_master.test | 226 ++++++++++++ .../data/autofill/captured_sites/timberland.sha1 | 1 + .../data/autofill/captured_sites/timberland.test | 308 ++++++++++++++++ .../autofill/captured_sites/victorias_secret.sha1 | 1 + .../autofill/captured_sites/victorias_secret.test | 381 ++++++++++++++++++++ .../data/autofill/captured_sites/walgreen.sha1 | 1 + .../data/autofill/captured_sites/walgreen.test | 327 +++++++++++++++++ 46 files changed, 6871 insertions(+) commit c98089352f6ab0c6d0e69341047b73028aabea4f Author: jonross <jonross@chromium.org> Date: Fri Dec 14 18:56:29 2018 +0000 Disable WebRtcGetUserMediaBrowserTest.ApplyConstraintsNonDevice/* on Win-ASAN With VizDisplayCompositor being set to on by default, this test has begun flaking on WIN-ASAN only. As we'd like to identify other potential flakes I'm electing to temporarily disble the test, rather than revert the feature flag. I'll begin looking at it locally. TBR=phoglund@chromium.org TEST=WebRtcGetUserMediaBrowserTest.ApplyConstraintsNonDevice/* Bug: 915135 Change-Id: I6435c556a6f6b23defa1da6976195e5d4d5bb521 Reviewed-on: https://chromium-review.googlesource.com/c/1377608 Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#616768} content/browser/webrtc/webrtc_getusermedia_browsertest.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit 1e8c60b16270abd0c884e4596b2a6d889b68b516 Author: Chris Palmer <palmer@chromium.org> Date: Fri Dec 14 18:54:44 2018 +0000 Remove palmer from OWNERS in SSL and security UX. I'm not working on SSL or security UX these days, and am not the best person to review CLs or own bugs in those areas. Change-Id: I428d3e89cb80d4a39fb80776d4a5c789a22a31c3 Reviewed-on: https://chromium-review.googlesource.com/c/1377211 Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Adrienne Porter Felt <felt@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#616767} components/url_formatter/OWNERS | 3 ++- content/browser/ssl/OWNERS | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) commit 39bf42e890c33a2e7f5c42f2d89d1b3b70c3382b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 18:53:50 2018 +0000 Roll src/third_party/pdfium caacc5ffb136..623e636edcd5 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/caacc5ffb136..623e636edcd5 git log caacc5ffb136..623e636edcd5 --date=short --no-merges --format='%ad %ae %s' 2018-12-14 thestig@chromium.org Call GetGlyphWidth() fewer times in LoadCompositeFont(). Created with: gclient setdep -r src/third_party/pdfium@623e636edcd5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906338 TBR=dsinclair@chromium.org Change-Id: I2d697717edf417ce048fea16fdeb833b7760ef35 Reviewed-on: https://chromium-review.googlesource.com/c/1378205 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616766} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 013237ed43f07fbe92453711ed1f9f5f333c3729 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Dec 14 18:53:38 2018 +0000 Update V8 to version 7.3.144. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1962a66f..36e5bdd6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieee0e3b520baacf6002f992c440630756f3ad03f Reviewed-on: https://chromium-review.googlesource.com/c/1378232 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616765} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ee274d38b82a8c3df9956d3318f98073ff198e0 Author: Kyle Milka <kmilka@chromium.org> Date: Fri Dec 14 18:52:43 2018 +0000 [NTP] Allow testing of interactive Doodles The Doodle team tests interactive doodles by running a local demo and supplying the --google-base-url to Chrome. Substitute 'https://www.google.com' in the interactive doodle url with the given url. Add the base url to the NTP's CSP child-src directive. Bug: 583290 Change-Id: Ib28bd6dd513ddcde073d516876c480e322367ad9 Reviewed-on: https://chromium-review.googlesource.com/c/1373886 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616764} chrome/browser/search/local_ntp_source.cc | 31 +++++++++++++--------- .../ui/search/local_ntp_doodle_browsertest.cc | 15 +++++------ 2 files changed, 24 insertions(+), 22 deletions(-) commit d1dd91e45e02d1c7e2bbf1fb91450a72f7d78a19 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Dec 14 18:50:13 2018 +0000 Reland "[vr] On-demand install VR DFM on N+" This is a reland of 3e6d27f2d89227b59b81f75cb3a396a01512595c with fix for x86 builders (which have VR disabled). Original change's description: > [vr] On-demand install VR DFM on N+ > > This requires handling the case when Chrome is started from VR before > the module is installed. For this, move code that is required to > identify VR intents and prevent 2D UI showing up in headset back to the > base module. Furthermore, request VR module install when entering Chrome > from VR and set up VR appropriately once the module install was > successful. If the module cannot be installed within a timeout (we need > a timeout so that Daydream does not kick us out of VR because we don't > active VR mode in time) close Chrome on smartphones or launch it in > 2D-in-VR mode on standalones. > > NOTE: The VR DFM is still not activated in Monochrome. So, this change > won't be active yet. > > Bug: 914494 > Change-Id: If37544f3a35b4d01ac924ee874618348d4b6004d > Reviewed-on: https://chromium-review.googlesource.com/c/1372227 > Reviewed-by: agrieve <agrieve@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616442} TBR=agrieve@chromium.org,mthiesse@chromium.org Bug: 914494 Change-Id: I4be696bf60e61e57d3d405e9a594838157244abd Reviewed-on: https://chromium-review.googlesource.com/c/1377427 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#616763} .../org/chromium/base/compat/ApiHelperForN.java | 9 + .../java/{res_vr => res}/anim/stay_hidden.xml | 0 .../org/chromium/chrome/browser/vr/VrDelegate.java | 185 ++++++++++++++++--- .../chrome/browser/vr/VrDelegateFallback.java | 130 +++++++++---- .../chromium/chrome/browser/vr/VrDelegateImpl.java | 33 +--- .../browser/vr/VrDelegateProviderFallback.java | 3 +- .../chrome/browser/vr/VrDelegateProviderImpl.java | 3 +- .../chrome/browser/vr/VrFirstRunActivity.java | 4 +- .../chrome/browser/vr/VrIntentDelegate.java | 82 ++++++++- .../browser/vr/VrIntentDelegateFallback.java | 31 ++++ .../chrome/browser/vr/VrIntentDelegateImpl.java | 38 ++++ .../chromium/chrome/browser/vr/VrIntentUtils.java | 125 ------------- .../chrome/browser/vr/VrModuleProvider.java | 28 ++- .../org/chromium/chrome/browser/vr/VrShell.java | 7 +- .../chrome/browser/vr/VrShellDelegate.java | 202 ++++++--------------- chrome/android/java_sources.gni | 1 + .../browser/vr/util/VrBrowserTransitionUtils.java | 7 +- .../chrome/browser/vr/util/VrTestRuleUtils.java | 4 +- chrome/browser/android/vr/BUILD.gn | 2 +- 19 files changed, 495 insertions(+), 399 deletions(-) commit e0006bcec361a8197eb9b16f6e4ec5911b47e95e Author: Tien Mai <tienmai@chromium.org> Date: Fri Dec 14 18:46:59 2018 +0000 Fix dependency error and re-land: Embed all localized strings into GCPW dll directly to allow localization. - Code that generates the strings to be embedded into an executable in chrome/installer/util was adapted so that it could be used generically anyone. - Used this common code to embed the strings into gaia1_0.dll and use them directly in code. Bug: 908451 Change-Id: Icc9b29c46afc93f2684cfe22370db12386907014 Reviewed-on: https://chromium-review.googlesource.com/c/1352576 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#616695} Reviewed-on: https://chromium-review.googlesource.com/c/1378247 Cr-Commit-Position: refs/heads/master@{#616762} base/BUILD.gn | 3 + .../win/embedded_i18n}/create_string_rc.py | 472 +++++++++++---------- base/win/embedded_i18n/generate_embedded_i18n.gni | 148 +++++++ base/win/embedded_i18n/language_selector.cc | 379 +++++++++++++++++ base/win/embedded_i18n/language_selector.h | 78 ++++ .../embedded_i18n/language_selector_unittest.cc | 238 +++++++++++ chrome/browser/chrome_browser_main_win.cc | 8 +- chrome/credential_provider/gaiacp/BUILD.gn | 95 ++--- chrome/credential_provider/gaiacp/dllmain.cc | 2 +- .../credential_provider/gaiacp/gaia_credential.h | 1 - .../gaiacp/gaia_credential_base.cc | 55 +-- .../gaiacp/gaia_credential_base.h | 1 - .../gaiacp/gaia_credential_provider.h | 2 +- .../gaiacp/gaia_credential_provider_module.cc | 1 + .../credential_provider/gaiacp/gaia_resources.grd | 71 +--- .../gaiacp/gaia_static_resources.grd | 19 + chrome/credential_provider/gaiacp/gcp_utils.cc | 45 +- chrome/credential_provider/gaiacp/gcp_utils.h | 5 +- .../gaiacp/strings/gaia_resources_en-US.xtb | 1 - .../gaiacp/strings/gaia_resources_fake-bidi.xtb | 1 - chrome/installer/util/BUILD.gn | 50 +-- chrome/installer/util/l10n_string_util.cc | 30 +- chrome/installer/util/language_selector.cc | 280 ------------ chrome/installer/util/language_selector.h | 59 --- .../installer/util/language_selector_unittest.cc | 171 -------- .../util/prebuild/create_installer_string_rc.py | 94 ++++ 26 files changed, 1369 insertions(+), 940 deletions(-) commit d25d640f7f2ce6bae0a0c7f5711e0af79e622791 Author: Yi Su <mrsuyi@chromium.org> Date: Fri Dec 14 18:44:08 2018 +0000 Fix a11y traits of TableViewTextHeaderFooterView. TableViewTextHeaderFooterView has UIAccessibilityTraits of UIAccessibilityTraitButton and UIAccessibilityTraitHeader, but it's never used as a button. This CL removes the UIAccessibilityTraitButton. Bug: 910258 Change-Id: Id04c72449e5e2cfa3ea85efe3b9ea2cd05c6e2b6 Reviewed-on: https://chromium-review.googlesource.com/c/1378131 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#616761} .../browser/ui/table_view/cells/table_view_text_header_footer_item.mm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 1caddf18637d3834d255fdd52d968de038c7b944 Author: Eric Karl <ericrk@chromium.org> Date: Fri Dec 14 18:42:30 2018 +0000 Revert "Disable failing WebXR tests" This reverts commit 4a2f6274a5b91d1bcba93db4ee5756c6e6de5255. Reason for revert: Reverted the CL causing failures, so re-enabling tests. Original change's description: > Disable failing WebXR tests > > Disables failing WebXR tests that are causing CQ issues. Will be > re-enabled once the root cause is found and fixed. > > TBR=billorr@chromium.org > > Bug: 913161 > Change-Id: If50af30cc9e24ce917989a0b0ac210254ce503bb > Reviewed-on: https://chromium-review.googlesource.com/c/1372540 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615670} TBR=bsheedy@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 913161 Change-Id: I309819ee2a135d8ec30cc424726daf4a4fa15a2f Reviewed-on: https://chromium-review.googlesource.com/c/1377489 Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#616760} .../src/org/chromium/chrome/browser/vr/WebXrVrInputTest.java | 5 ----- .../src/org/chromium/chrome/browser/vr/WebXrVrTransitionTest.java | 5 ----- 2 files changed, 10 deletions(-) commit c0505eda25d1bb5eaeb9f3d3f8900ce020704904 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Dec 14 18:38:13 2018 +0000 Roll src-internal b94aa37fe30c..82e510e0a578 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b94aa37fe30c..82e510e0a578 Created with: gclient setdep -r src-internal@82e510e0a578 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4b3901193d2b00c4b2bd2d03e329ac33c5e0147a Reviewed-on: https://chromium-review.googlesource.com/c/1378201 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616759} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e71108dbd98e09ab4a133f37c5b7448bdf1094a3 Author: Mike Dougherty <michaeldo@chromium.org> Date: Fri Dec 14 18:35:18 2018 +0000 Remove web::WaitUntilWindowIdInjected test util. WindowID is no longer injected so there is no need to wait for it. Bug: 905939 Change-Id: Id1896eeb4a2e00f2f79e7f713443cbc80ac95b33 Reviewed-on: https://chromium-review.googlesource.com/c/1377339 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#616758} ios/chrome/browser/translate/translate_egtest.mm | 2 -- ios/chrome/test/earl_grey/chrome_earl_grey.mm | 4 ---- ios/web/public/test/earl_grey/js_test_util.h | 5 ----- ios/web/public/test/earl_grey/js_test_util.mm | 28 ------------------------ ios/web/shell/test/earl_grey/shell_earl_grey.mm | 4 ---- 5 files changed, 43 deletions(-) commit 9c484a22d01e9482be2997dea811367505556a86 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Dec 14 18:34:33 2018 +0000 Revert "Find-in-page per block using FindBuffer" This reverts commit 71e551ac476ec9b247be8f19c6eb696632d90cf4. Reason for revert: broke MHTMLGenerationTest.ViewedMHTMLContainsNoStoreContentIfNoCacheControlPolicy on win7 tests dbg: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73554 [7424:304:1214/084019.035:FATAL:find_buffer.cc(27)] Check failed: start_position == PositionInFlatTree::FirstPositionInNode( *start_position.ComputeContainerNode()). Original change's description: > Find-in-page per block using FindBuffer > > This CL introduces FindBuffer, which Find-in-page will use to find > matches instead of using FindPlainText that uses TextIterator. > > Since find-in-page matches can't span multiple blocks, we are using > that fact to know where we can separate the text in the document. > FindBuffer collects text one block at a time, and then finds the match > in that block. We trigger FindBuffer text collection & finding many > times until it goes through everything. FindInPage uses TextSearcherICU > to find text, and uses flat-tree traversal, ComputedStyle, and > LayoutObject + NGOffsetMapping, whereas the previous way was to use > TextIterator. > > This CL also changes the way we handle newlines - newlines will be > saved as object replacement character/whitespaces for Find-in-page > purposes. Some tests that rely on newlines are deleted as a result. > Note: > This change is not user-visible because it is not possible to do a > Find-in-page from the UI with newlines. > > See doc for details: > https://docs.google.com/document/d/1D5q7ZMrLPfilXnIGI3SOL0mwdiQC7SQEtGWk-9ysbMg/edit?usp=sharing > > Bug: 868227 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Id5dd7e6c428f59442d02ec88ea0cec6eb4e64c22 > Reviewed-on: https://chromium-review.googlesource.com/c/1282425 > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616701} TBR=ellyjones@chromium.org,yosin@chromium.org,yoichio@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,rakina@chromium.org Change-Id: Ic06a33d1c630bb4423fc0963bc55b6af5e8ef865 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868227 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1378407 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616757} .../ui/find_bar/find_bar_host_browsertest.cc | 30 +- chrome/test/data/find_in_page/LongFind.txt | 2 +- third_party/blink/renderer/core/editing/BUILD.gn | 3 - .../renderer/core/editing/finder/find_buffer.cc | 314 --------------------- .../renderer/core/editing/finder/find_buffer.h | 156 ---------- .../core/editing/finder/find_buffer_test.cc | 280 ------------------ .../core/editing/finder/find_task_controller.cc | 62 ++-- 7 files changed, 59 insertions(+), 788 deletions(-) commit dacd59c9179d75f89a27be539dde8892984612bc Author: Sami Kyostila <skyostil@chromium.org> Date: Fri Dec 14 18:32:52 2018 +0000 base: Disable JSONPerfTest.StressTest Disable JSONPerfTest.StressTest as it is still timing out even after increasing the timeout. TBR=gab@chromium.org Bug: 906686 Change-Id: I67434e2405f86fd7f0fe9d82a901e618ac0b2b9e Reviewed-on: https://chromium-review.googlesource.com/c/1378144 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#616756} base/json/json_perftest.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit 85a7fd19e15c586fed1eef8c7521719fccaae4a7 Author: Geoff Lang <geofflang@chromium.org> Date: Fri Dec 14 18:31:15 2018 +0000 Remove webgl_conformance_gles_passthrough_tests from android-marshmallow-arm64-rel This test suite is still run on the GPU FYI waterfall and android_angle_rel_ng BUG=882580 Change-Id: Ifcfb5ff60b7cba84d09358206ab0fd4676a63394 Reviewed-on: https://chromium-review.googlesource.com/c/1378239 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#616755} testing/buildbot/chromium.gpu.json | 26 -------------------------- testing/buildbot/waterfalls.pyl | 2 +- 2 files changed, 1 insertion(+), 27 deletions(-) commit c0fd077dcd55a26ea05eedc16cad0d3693ac33cf Author: Frank Henigman <fjhenigman@chromium.org> Date: Fri Dec 14 18:30:30 2018 +0000 Tell shaderc where to find SPIRV-Cross. Set a variable in build_overrides that gives the location of shaderc's new SPIRV-Cross dependency. The variable will take a different value for a dawn stand-alone build. BUG=915096 Change-Id: Ied39c0b233de2c3e8ea29b576759c4c4eb8b0a61 Reviewed-on: https://chromium-review.googlesource.com/c/1378009 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Frank Henigman <fjhenigman@chromium.org> Cr-Commit-Position: refs/heads/master@{#616754} build_overrides/shaderc.gni | 1 + 1 file changed, 1 insertion(+) commit 23d1c9d2a27fffc154593eac1c695fd041f64465 Author: Min Chen <minch@google.com> Date: Fri Dec 14 18:30:11 2018 +0000 shelf: Adjust the order of GetShelfBackgroundType. Use SHELF_BACKGROUND_SPLIT_VIEW when both splitview and overview are active. The background of the shelf will also influence the radius corner of the shelf. Bug: 912409 Change-Id: I28643eface4a22422c24978686f7a50b01c7dba7 Reviewed-on: https://chromium-review.googlesource.com/c/1377431 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616753} ash/shelf/shelf_layout_manager.cc | 8 ++++---- ash/shelf/shelf_layout_manager_unittest.cc | 9 +++++++++ 2 files changed, 13 insertions(+), 4 deletions(-) commit 25848c1f22432dd10547536076589a6d93e3f96e Author: Scott Violet <sky@chromium.org> Date: Fri Dec 14 18:29:15 2018 +0000 window-service: rename ServerWindow to ProxyWindow And use the name 'proxy' in more places. BUG=none TEST=none Change-Id: I84309d4fd898b9571df8b78e756ae02f54dcbd8a Reviewed-on: https://chromium-review.googlesource.com/c/1377184 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#616752} ash/accelerators/debug_commands.cc | 2 +- ash/host/ash_window_tree_host_platform.cc | 2 +- ash/ime/ime_focus_handler.cc | 16 +- ash/laser/laser_pointer_controller_unittest.cc | 9 +- ash/shell.cc | 4 +- ash/shell.h | 7 +- ash/utility/screenshot_controller.cc | 2 +- ash/wm/window_finder.cc | 2 +- ash/ws/window_lookup.cc | 2 +- services/ws/BUILD.gn | 10 +- services/ws/client_root.cc | 82 ++++--- services/ws/client_root.h | 12 +- services/ws/client_root_test_helper.h | 2 +- services/ws/event_queue.cc | 2 +- services/ws/focus_handler.cc | 46 ++-- services/ws/focus_handler.h | 6 +- services/ws/{server_window.cc => proxy_window.cc} | 168 +++++++-------- services/ws/{server_window.h => proxy_window.h} | 50 ++--- services/ws/proxy_window_test_helper.cc | 20 ++ services/ws/proxy_window_test_helper.h | 31 +++ ...window_unittest.cc => proxy_window_unittest.cc} | 8 +- services/ws/server_window_test_helper.cc | 20 -- services/ws/server_window_test_helper.h | 31 --- services/ws/window_delegate_impl.cc | 30 +-- services/ws/window_service.cc | 57 +++-- services/ws/window_service.h | 12 +- services/ws/window_service_unittest.cc | 8 +- services/ws/window_tree.cc | 237 ++++++++++----------- services/ws/window_tree.h | 6 +- services/ws/window_tree_test_helper.cc | 4 +- services/ws/window_tree_test_helper.h | 2 +- services/ws/window_tree_unittest.cc | 46 ++-- 32 files changed, 464 insertions(+), 472 deletions(-) commit fd8ad21305da505a82ed7ab6dc3c49738eaa802e Author: Xiyuan Xia <xiyuan@chromium.org> Date: Fri Dec 14 18:27:28 2018 +0000 Reland "Reland "wm: Update nested activation handling"" This is a reland of 77fbe34018de545f5b733709a2afcb1391ef1364 with fix for the UAF. Original change's description: > Reland "wm: Update nested activation handling" > > This is a reland of ecde845099001740fee119a82d45664e622d0ade > > Original change's description: > > wm: Update nested activation handling > > > > - DCHECK() and no-op if the nested activation wants to change > > to a different active window other than the one being activated; > > - Allow focus shift in nested activations as long as they don't > > change the window to be activated > > > > Bug: 908524 > > Test: FocusControllerApiTest.ActivateWhileActivating > > Change-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642 > > Reviewed-on: https://chromium-review.googlesource.com/c/1357017 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org> > > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#616346} > > Bug: 908524, 914915 > Change-Id: Id0072941bfb0def54f093bcb771b2d8485c9b04e > Reviewed-on: https://chromium-review.googlesource.com/c/1376726 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#616496} Bug: 908524, 914915 Change-Id: Id3786796d109cfdb7c4caf1529243af93830da69 Reviewed-on: https://chromium-review.googlesource.com/c/1378236 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616751} ui/wm/core/focus_controller.cc | 40 ++++++----- ui/wm/core/focus_controller.h | 14 ++-- ui/wm/core/focus_controller_unittest.cc | 120 ++++++++++++++++++++++++++++++++ 3 files changed, 151 insertions(+), 23 deletions(-) commit f82a62ac5051a86d85b0bb20b149c6ab171838da Author: Jun Mukai <mukai@chromium.org> Date: Fri Dec 14 18:21:45 2018 +0000 Remove the reference of ash from webui_login_view.cc This file refers ash::Shell to register global accelerators, but I believe this is not necessary. This CL removes that code entirely. Bug: 854346 Test: none Change-Id: Ibd72da382d28e136daf571a7292fad7e875facfe Reviewed-on: https://chromium-review.googlesource.com/c/1375876 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#616750} chrome/browser/chromeos/login/ui/DEPS | 5 ----- chrome/browser/chromeos/login/ui/webui_login_view.cc | 19 ++----------------- 2 files changed, 2 insertions(+), 22 deletions(-) commit d1491a466a56a8c0579b9840fdee32513c696977 Author: sebsg <sebsg@chromium.org> Date: Fri Dec 14 18:21:43 2018 +0000 [AF] Add test for the Wallet Sync Transport opt-in pref serialization Bug: 914935 Change-Id: I52dde692e3f803cf5923090541371bec726667d5 Reviewed-on: https://chromium-review.googlesource.com/c/1378231 Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#616749} .../core/common/autofill_prefs_unittest.cc | 24 +++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) commit 95eb1281833d5f607c231e12787ec6a7bdf53afb Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Dec 14 18:20:42 2018 +0000 Allow extra tracing categories to be added to startup profiling Depends on https://chromium-review.googlesource.com/c/catapult/+/1378200 to function. Change-Id: Ie7056d2901cf88098de624a0e3bf6e3d061575d6 Reviewed-on: https://chromium-review.googlesource.com/c/1377345 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#616748} tools/android/tracing/README.md | 2 ++ tools/android/tracing/profile-chrome-startup.sh | 8 ++++++++ 2 files changed, 10 insertions(+) commit 9df045779f62cbbe3fbf56be9b0329302e9a0df7 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Fri Dec 14 18:20:36 2018 +0000 a11y: Include <memory> for std::unique_ptr in accessibility_alert_window.h IWYU. This fixes the libstdc++ build after commit 1ed701bc4 ("Remove fake alert AXObjWrapper object"): In file included from ../../ui/views/accessibility/accessibility_alert_window.cc:5: ../../ui/views/accessibility/accessibility_alert_window.h:34:8: error: ‘unique_ptr’ in namespace ‘std’ does not name a template type std::unique_ptr<aura::Window> alert_window_; ^~~~~~~~~~ ../../ui/views/accessibility/accessibility_alert_window.h:34:3: note: ‘std::unique_ptr’ is defined in header ‘<memory>’; did you forget to ‘#include <memory>’? Bug: 819294 Change-Id: I5e41e529fb5961ae2c93359328d437da40fa60fd Reviewed-on: https://chromium-review.googlesource.com/c/1375119 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#616747} ui/views/accessibility/accessibility_alert_window.h | 1 + 1 file changed, 1 insertion(+) commit 3b8f0fe87d929229689a6447f8ad2b9e0a239f7b Author: Aga Wronska <agawronska@chromium.org> Date: Fri Dec 14 18:17:17 2018 +0000 Add OAuth token as additional authentication for CloudPolicyClient OAuth token (if set on the client) is passed in policy fetch and status upload requests next to DMToken. Additional authentication will be used for child user. Bug: 839025 Test: CloudPolicyClientTest Change-Id: I7332fae6ba9b290143ba8d2a5301ba56ad9c1880 Reviewed-on: https://chromium-review.googlesource.com/c/1376352 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#616746} .../core/common/cloud/cloud_policy_client.cc | 9 ++ .../policy/core/common/cloud/cloud_policy_client.h | 13 +++ .../common/cloud/cloud_policy_client_unittest.cc | 106 +++++++++++++++++++++ 3 files changed, 128 insertions(+) commit 01529f01a2a085773355c0e38d826f22e28163ba Author: Matt Menke <mmenke@chromium.org> Date: Fri Dec 14 18:13:01 2018 +0000 Remove SSLSocketParams::ignore_certificate_errors As of https://chromium-review.googlesource.com/c/chromium/src/+/1343054, it's no longer respected. Bug: 347402 Change-Id: I3e964d5384a4adc20d121a56882b27197a85c49f Reviewed-on: https://chromium-review.googlesource.com/c/1378241 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#616745} net/http/http_proxy_client_socket_pool_unittest.cc | 2 +- .../http_proxy_client_socket_wrapper_unittest.cc | 12 ++++++------ net/http/http_stream_factory_unittest.cc | 6 +++--- net/socket/client_socket_pool_manager.cc | 6 ++---- net/socket/ssl_client_socket_pool.cc | 6 ++---- net/socket/ssl_client_socket_pool.h | 5 +---- net/socket/ssl_client_socket_pool_unittest.cc | 20 ++++++++++---------- net/spdy/spdy_test_util_common.cc | 2 +- .../websocket_basic_stream_adapters_test.cc | 14 +++++++------- 9 files changed, 33 insertions(+), 40 deletions(-) commit 2401ba3b8dfcfc2d940b0f84b97f625e377470a7 Author: David Bokan <bokan@chromium.org> Date: Fri Dec 14 18:12:10 2018 +0000 [BlinkGenPropertyTrees] Fix SitePerProcessHitTestBrowserTest This CL fixes the test: SitePerProcessHitTestBrowserTest.RootConsumesScrollDuringOverscrollGesture Turning on BlinkGenPropertyTrees changes how OOPIFs are clipped in non trivial clipping scenarios, such as border-radius. In this test, the OOPIF has a border-radius. Prior to BGPT, the OOPIF would not be masked correctly. The fix here is to simply remove the failing ASSERT. It's simply checking that events sent to the given point get routed to the iframe's RenderWidgetHostView. With BGPT, we correctly perform masking so the hit test realizes the result will be ambiguous and requires a hit test in the renderer. Additional details are in the bug. The ASSERT is unneeded as the InputEventAckWaiter will wait on the ACK in the child RWHV so if it gets mis-routed the waiter will never awaken. Bug: 912334 Change-Id: Iaf76181ed7e89971e445076905057ebde30abffb Reviewed-on: https://chromium-review.googlesource.com/c/1374467 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#616744} content/browser/site_per_process_hit_test_browsertest.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) commit bae0b5e9ba8af723aaffb213a3157ed3e160f77e Author: Peter Beverloo <peter@chromium.org> Date: Fri Dec 14 18:10:01 2018 +0000 Remove the GCMAppHandler on DeviceSyncBase destruction A use-after-free was observed in the GCMDriver's shutdown sequence on accessing this GCMAppHandler, following Ken's earlier CL: https://chromium.googlesource.com/chromium/src/+/ad3c758a491a0f08788acba07a859e66c42684b8 My hypothesis is that it caused the DeviceSyncBase to be destroyed prior to the GCM Driver (which is a Profile-bound KeyedService), whereas it would previously be destroyed after. This CL proposes a work-around by removing itself from the GCM Driver on destruction. This causes a new problem however - if Ken's CL were to be reverted, the situation changes and we'd now have a potential use-after-free here. The DeviceSync code needs to either stop using the GCMAppHandler for observing Profile shutdown time, which has unintentional side-effects anyway, or declare a dependency on the GCMProfileServiceFactory somewhere to make sure destruction happens in the right order. Bug: 914562 Change-Id: I0f1eb0c641936e188e3a93ce4f34b0f57ffc3125 Reviewed-on: https://chromium-review.googlesource.com/c/1378143 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#616743} chromeos/services/device_sync/device_sync_base.cc | 12 ++++++++---- chromeos/services/device_sync/device_sync_base.h | 2 ++ 2 files changed, 10 insertions(+), 4 deletions(-) commit 96fced3741c7b8833fb0d96eb9a0b5332ca47b85 Author: Tony de Luna <tonydeluna@chromium.org> Date: Fri Dec 14 18:08:09 2018 +0000 cros mobile settings: show spinner when scanning Change adds a spinner while scanning mobile networks to network details page. Bug: 804455 Change-Id: Ic0cf8cf79b510a039c3862fc8ee00d0137278345 Reviewed-on: https://chromium-review.googlesource.com/c/1375096 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#616742} .../resources/settings/internet_page/internet_detail_page.html | 9 +++++++++ .../resources/settings/internet_page/internet_detail_page.js | 9 +++++++++ 2 files changed, 18 insertions(+) commit bf42d9be7f0c053e1ab5464f57c1d7b01d38bff3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 18:06:02 2018 +0000 Roll src/native_client 14b228f23bb8..faaebac44b2e (1 commits) https://chromium.googlesource.com/native_client/src/native_client.git/+log/14b228f23bb8..faaebac44b2e git log 14b228f23bb8..faaebac44b2e --date=short --no-merges --format='%ad %ae %s' 2018-12-14 dschuff@chromium.org Update build_rev Created with: gclient setdep -r src/native_client@faaebac44b2e The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: I285f7b7e1f384be060514047b39f372d49c43ada Reviewed-on: https://chromium-review.googlesource.com/c/1378202 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616741} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0c2861bf501684f3838e6900625a41e7e3754851 Author: Nico Weber <thakis@chromium.org> Date: Fri Dec 14 18:05:16 2018 +0000 Re-enable browser_tests on a bunch of mac bots. We disabled browser_tests on all mac bots due to issue 828031. Now that that's resolved, undo that. In particular, re-enables browser_tests on Mac Asan. Bug: 828031 Change-Id: Ic832455a962bb748afb34eebcbf95f0c52e00aca Reviewed-on: https://chromium-review.googlesource.com/c/1377520 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#616740} testing/buildbot/chromium.clang.json | 23 +++++++++ testing/buildbot/chromium.fyi.json | 41 ++++++++++++++++ testing/buildbot/chromium.mac.json | 17 +++++++ testing/buildbot/chromium.memory.json | 12 +++++ testing/buildbot/test_suite_exceptions.pyl | 76 ++++++++++++++++++++++++------ 5 files changed, 154 insertions(+), 15 deletions(-) commit 85418ce98dfb8c303a43059ca166fb04211200c3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 18:04:55 2018 +0000 Roll src/third_party/perfetto 61804c04b375..4447823aa71d (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/61804c04b375..4447823aa71d git log 61804c04b375..4447823aa71d --date=short --no-merges --format='%ad %ae %s' 2018-12-14 hjd@google.com Merge "perfetto-ui: Hide empty details pane & fix time by cluster query" Created with: gclient setdep -r src/third_party/perfetto@4447823aa71d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifdc323ce331af75a003ac9f8724d4ae79481b402 Reviewed-on: https://chromium-review.googlesource.com/c/1378203 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616739} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f82a5d35e2cef6c5532ebd233de8e193b7c724a3 Author: Dave Tapuska <dtapuska@chromium.org> Date: Fri Dec 14 18:02:34 2018 +0000 Revert "Pausable Object Cleanup - XMLHttpRequest" This reverts commit df0477e9ca0423600017a6e6fb566ff5784c7667. Reason for revert: Workers don't support paused task queues Original change's description: > Pausable Object Cleanup - XMLHttpRequest > > The events dispatched by the XMLHttpRequestEventThrottle are attached > to the kNetwork TaskQueue which is a pausable task queue. > > Verified progress events aren't received while an alert dialog is present. > > BUG=907125 > > Change-Id: I93d8bbf8151753c5ddfc14bbfdd067697f6fe01e > Reviewed-on: https://chromium-review.googlesource.com/c/1368462 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#615143} TBR=haraken@chromium.org,dtapuska@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 907125 Change-Id: Idd2b19aa6d935a3c1e51bf1e03ebd34e0ae8dbd2 Reviewed-on: https://chromium-review.googlesource.com/c/1378198 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#616738} .../core/xmlhttprequest/xml_http_request.cc | 32 ++++++++++++++++------ .../core/xmlhttprequest/xml_http_request.h | 8 ++++-- .../xml_http_request_progress_event_throttle.cc | 14 ++++++++++ .../xml_http_request_progress_event_throttle.h | 3 ++ 4 files changed, 45 insertions(+), 12 deletions(-) commit 8b37cfd8b8824469d72633e908b9ff00dee89388 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Dec 14 17:58:10 2018 +0000 Roll src/third_party/skia f6206f91b3c1..af67819ee1d9 (1 commits) https://skia.googlesource.com/skia.git/+log/f6206f91b3c1..af67819ee1d9 git log f6206f91b3c1..af67819ee1d9 --date=short --no-merges --format='%ad %ae %s' 2018-12-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 828c59462fc1..dfaccbc08abb (1 commits) Created with: gclient setdep -r src/third_party/skia@af67819ee1d9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Ie7304f54615520a0e379333a886ddd3790057dfd Reviewed-on: https://chromium-review.googlesource.com/c/1378195 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#616737} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dadcf582438d2e0af4f697be4d68dac6b35e6e3f Author: Mike Dougherty <michaeldo@chromium.org> Date: Fri Dec 14 17:57:06 2018 +0000 [iOS] Add chrome://inspect webUI page. Remove the Debug only "Log JS" switch from the Settings page. Add a new chrome://inspect webUI page with a button to enable and disable JavaScript console logging. Messages are still logged in the same manner to the Xcode console, but will be moved to be displayed on the chrome://inspect page in a follow-up CL. The new UI of the chrome://inspect page can be seen here: https://drive.google.com/file/d/1IdEHPYCaEhgNyRZ82_cygJVQVbhT5rNL/view?usp=sharing Bug: 899851 Change-Id: I653c1e31f95cf15d5acfe453d92c56f5e5e0431e Reviewed-on: https://chromium-review.googlesource.com/c/1363632 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#616736} ios/chrome/app/resources/inspect/inspect.css | 14 ++ ios/chrome/app/resources/inspect/inspect.html | 30 ++++ ios/chrome/app/resources/inspect/inspect.js | 27 +++ ios/chrome/app/resources/ios_resources.grd | 2 + ios/chrome/app/strings/ios_strings.grd | 3 + .../IDS_IOS_INSPECT_UI_CONSOLE_NOTICE.png.sha1 | 1 + ios/chrome/browser/chrome_url_constants.cc | 3 + ios/chrome/browser/chrome_url_constants.h | 2 + .../settings_collection_view_controller.mm | 39 ----- ios/chrome/browser/ui/webui/BUILD.gn | 6 + .../webui/chrome_web_ui_ios_controller_factory.mm | 3 + ios/chrome/browser/ui/webui/inspect/inspect_ui.h | 22 +++ ios/chrome/browser/ui/webui/inspect/inspect_ui.mm | 194 +++++++++++++++++++++ .../browser/ui/webui/inspect/inspect_ui_egtest.mm | 53 ++++++ .../java_script_console_tab_helper.mm | 31 ++-- 15 files changed, 374 insertions(+), 56 deletions(-) commit e54a88276d13cfa5c9e257e0600728a2b4e4bd68 Author: Owen Min <zmin@chromium.org> Date: Fri Dec 14 17:57:03 2018 +0000 Add CloudManagementEnrollmentToken into policy template. Even though we don't read this policy value from Pref service, we still want to put it into policy_templates.json so that admin could find it in the ADM/ADMX template. Change-Id: I1fe1419f456256187e53bf360871f9b9a08bb2a8 Reviewed-on: https://chromium-review.googlesource.com/c/1374465 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616735} chrome/test/data/policy/policy_test_cases.json | 2 ++ components/policy/resources/policy_templates.json | 20 +++++++++++++++++++- tools/metrics/histograms/enums.xml | 1 + 3 files changed, 22 insertions(+), 1 deletion(-) commit c5454142857d5d2e166133d5dbaf3a803301f663 Author: Jun Mukai <mukai@chromium.org> Date: Fri Dec 14 17:53:21 2018 +0000 Do not invoke Drag() when neither mouse nor touch is pressed Bug: 914527 Test: the new test case covers Change-Id: Iab56b2aa9ec477542e22d7d684e24605f4934257 Reviewed-on: https://chromium-review.googlesource.com/c/1375110 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#616734} .../browser/ui/views/tabs/tab_drag_controller.cc | 10 ++++++- .../tabs/tab_drag_controller_interactive_uitest.cc | 34 ++++++++++++++++++++++ 2 files changed, 43 insertions(+), 1 deletion(-) commit 2e14c65ea3219173009dfd7a4c3ae3c73814d2d3 Author: Marc-André (MAD) Decoste <mad@chromium.org> Date: Fri Dec 14 17:52:48 2018 +0000 Renamed persistent tab restore service. In preparation for another CL which makes persitence dependent on a policy pref. Bug: 869580 Change-Id: I5fa64297c9c6dbddf121703686c41f1a52bae1d8 Reviewed-on: https://chromium-review.googlesource.com/c/1378229 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Marc-André Decoste <mad@chromium.org> Cr-Commit-Position: refs/heads/master@{#616733} ...rtest.cc => tab_restore_service_browsertest.cc} | 6 +- .../sessions/tab_restore_service_factory.cc | 4 +- ...unittest.cc => tab_restore_service_unittest.cc} | 163 ++++++++++--------- .../ui/cocoa/history_menu_bridge_unittest.mm | 6 +- .../toolbar/recent_tabs_sub_menu_model_unittest.cc | 4 +- chrome/test/BUILD.gn | 4 +- components/sessions/BUILD.gn | 4 +- components/sessions/content/content_live_tab.h | 4 +- .../sessions/core/tab_restore_service_helper.h | 9 +- ...tore_service.cc => tab_restore_service_impl.cc} | 177 ++++++++++----------- ...estore_service.h => tab_restore_service_impl.h} | 24 +-- .../ios_chrome_tab_restore_service_factory.cc | 4 +- 12 files changed, 206 insertions(+), 203 deletions(-) Updated tag 'tree_truth' (was b94ed2814e20)