Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 33711 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8924250400148584464 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/iteX7k5Q/luci_context.953314336 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: gce-trusty-e833d7b0-us-east1-b-7hh3 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 426b18b5f8bc2411 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 2aa2303669972f7f150b4eab9aafeaab11e3262d Revert "Rework RasterInterface::CopySubTexture" Jeremy Roman, Tue Jan 15 15:49:57 2019 +0000 69ab2e0d193611017b93b61e24366344d625c102 [base] Update RunUntilIdle() docs to discourage it further Gabriel Charette, Tue Jan 15 15:41:05 2019 +0000 d8a5954dc90e38523e0479b7d076c278ae335489 chrome_cleaner should use CHROME_CLEANER_VERSION constants since it doesn't use the same build numbers as chrome Joe Mason, Tue Jan 15 15:40:45 2019 +0000 4fa0a0a9514161f40ee6044a6eaa393c4d75fb15 [getCapabilities] Remove magic number in favour of media:: function. Armando Miraglia, Tue Jan 15 15:29:58 2019 +0000 2449cbd81698ee25bf5d0fce27b6d5c65bceb2e6 [s13n] Move CloudPolicyManagerTest away from using SigninManager Julie Jeongeun Kim, Tue Jan 15 15:29:04 2019 +0000 323b3bea2a9042d6b2ba37eff1713c82a43eb892 [ios] Removes the OCHamcrest dependency from chrome_matchers.mm. Rohit Rao, Tue Jan 15 15:24:00 2019 +0000 9e4bb50618215ce9e3b4ac4300e45422f52fefd6 Add the condition to check if XRRGetOutputInfo returns NULL. Julie Jeongeun Kim, Tue Jan 15 15:23:27 2019 +0000 d82f404065061deeee12e9ab3750f4178eda7c35 Register cct module lifecycle state in a synthetic field trial. Michael van Ouwerkerk, Tue Jan 15 15:22:14 2019 +0000 b0552857138392bd13415d9a1d42cecf143ac70f [tools/perf] Remove references to GetBuildbotValue Juan Antonio Navarro Perez, Tue Jan 15 15:19:28 2019 +0000 39e04f0ce0d8812a58afd112713f448cbe82e091 [signin] Untrusted signin dialog is moved earlier in the signin flow David Roger, Tue Jan 15 15:04:45 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 2aa2303669972f7f150b4eab9aafeaab11e3262d Author: Jeremy Roman <jbroman@chromium.org> Date: Tue Jan 15 15:49:57 2019 +0000 Revert "Rework RasterInterface::CopySubTexture" This reverts commit 0da668539c5a880a203609988404e27100bc4b55. Reason for revert: Speculative revert to fix Mac bots. Original change's description: > Rework RasterInterface::CopySubTexture > > Pass mailboxes directyl instead of requiring CreateAndConsumeTexture + > DeleteTextures. > Simplify CreateAndConsumeTexture and DeleteTextures that are now only > used for GPU Raster. > Remove tracking structures in RasterDecoder and RasterImplementation* > which become entirely unnecessary. > > Bug: 829435 > > Change-Id: I73c3155932fd417b4f95dd99e7fe8e3511685d61 > Reviewed-on: https://chromium-review.googlesource.com/c/1407259 > Reviewed-by: Jonathan Backer <backer@chromium.org> > Commit-Queue: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622636} TBR=backer@chromium.org,piman@chromium.org Change-Id: I044ecf68623faa5f6da4f2021f4f7440abd91ac0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829435,922025 Reviewed-on: https://chromium-review.googlesource.com/c/1412552 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#622869} cc/raster/gpu_raster_buffer_provider.cc | 6 +- cc/raster/one_copy_raster_buffer_provider.cc | 14 +- cc/raster/raster_buffer_provider_perftest.cc | 2 +- cc/test/test_in_process_context_provider.cc | 3 +- components/viz/test/test_context_provider.cc | 2 +- gpu/command_buffer/build_raster_cmd_buffer.py | 13 +- .../client/raster_cmd_helper_autogen.h | 45 +++--- gpu/command_buffer/client/raster_implementation.cc | 93 ++++++------ gpu/command_buffer/client/raster_implementation.h | 19 +-- .../client/raster_implementation_autogen.h | 16 ++ .../client/raster_implementation_gles.cc | 108 +++++++++---- .../client/raster_implementation_gles.h | 39 ++++- .../client/raster_implementation_gles_unittest.cc | 31 ++-- .../client/raster_implementation_impl_autogen.h | 48 ++++++ .../raster_implementation_unittest_autogen.h | 25 +++ gpu/command_buffer/client/raster_interface.h | 14 -- .../client/raster_interface_autogen.h | 13 ++ .../common/raster_cmd_format_autogen.h | 167 ++++++++++++--------- .../common/raster_cmd_format_test_autogen.h | 57 +++---- gpu/command_buffer/common/raster_cmd_ids_autogen.h | 42 +++--- gpu/command_buffer/raster_cmd_buffer_functions.txt | 7 +- gpu/command_buffer/service/raster_decoder.cc | 111 +++++++++++--- .../service/raster_decoder_autogen.h | 75 +++++---- .../service/raster_decoder_unittest.cc | 6 +- .../service/raster_decoder_unittest_1_autogen.h | 21 +++ .../service/raster_decoder_unittest_base.cc | 5 +- .../cpp/gpu/context_provider_command_buffer.cc | 2 +- ui/compositor/test/in_process_context_provider.cc | 3 +- 28 files changed, 653 insertions(+), 334 deletions(-) commit 69ab2e0d193611017b93b61e24366344d625c102 Author: Gabriel Charette <gab@chromium.org> Date: Tue Jan 15 15:41:05 2019 +0000 [base] Update RunUntilIdle() docs to discourage it further R=fdoray@chromium.org Change-Id: I62c82418b7e61770c6a1bb5735ff79e344d6de23 Reviewed-on: https://chromium-review.googlesource.com/c/1409460 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#622868} base/run_loop.h | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit d8a5954dc90e38523e0479b7d076c278ae335489 Author: Joe Mason <joenotcharles@google.com> Date: Tue Jan 15 15:40:45 2019 +0000 chrome_cleaner should use CHROME_CLEANER_VERSION constants since it doesn't use the same build numbers as chrome R=csharp Bug: 802092 Change-Id: I20832dcccbffabba2ce1bd44f370efcc2d235e99 Reviewed-on: https://chromium-review.googlesource.com/c/1388935 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#622867} chrome/chrome_cleaner/constants/version.h.in | 6 +++--- chrome/chrome_cleaner/logging/cleaner_logging_service.cc | 2 +- chrome/chrome_cleaner/logging/registry_logger.cc | 2 +- chrome/chrome_cleaner/logging/reporter_logging_service.cc | 2 +- chrome/chrome_cleaner/logging/scoped_logging.cc | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) commit 4fa0a0a9514161f40ee6044a6eaa393c4d75fb15 Author: Armando Miraglia <armax@chromium.org> Date: Tue Jan 15 15:29:58 2019 +0000 [getCapabilities] Remove magic number in favour of media:: function. As OnionSouping MediaStreams progresses, we can and should use media:: types directly in Blink. This CL gets rid of a magic number used in MediaDevices::getCapabilities() and replaces it with the proper media:: symbols. Due to the change in dependencies, the presubmit checks needed adjustments so that media::.+ can be accessed by the third_party/blink/renderer/modules/mediastream path. Further, DEPS have been added for the same purpose. BUG=731170 Change-Id: I0eea35f410e1808808caf9eef37687c40ddc0510 Reviewed-on: https://chromium-review.googlesource.com/c/1412014 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#622866} third_party/blink/renderer/modules/mediastream/DEPS | 1 + .../blink/renderer/modules/mediastream/input_device_info.cc | 10 +++++----- .../blink/tools/blinkpy/presubmit/audit_non_blink_usage.py | 8 ++++++++ 3 files changed, 14 insertions(+), 5 deletions(-) commit 2449cbd81698ee25bf5d0fce27b6d5c65bceb2e6 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Tue Jan 15 15:29:04 2019 +0000 [s13n] Move CloudPolicyManagerTest away from using SigninManager This CL makes CloudPolicyManagerTest use IdentityManager instead of SigninManager. SigninManager is going to be an implementation detail of IdentityManager. Bug: 920215 Change-Id: I9f379321fa02133349113c96f60bab5aa27fe7bb Reviewed-on: https://chromium-review.googlesource.com/c/1411195 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#622865} .../browser/policy/cloud/cloud_policy_manager_browsertest.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 323b3bea2a9042d6b2ba37eff1713c82a43eb892 Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Jan 15 15:24:00 2019 +0000 [ios] Removes the OCHamcrest dependency from chrome_matchers.mm. The single use of an OCHamcrest matcher has been replaced by a GREYElementMatcherBlock. BUG=None Change-Id: I2949935e9a8b046bf79dcc68928742ec4fe20ebe Reviewed-on: https://chromium-review.googlesource.com/c/1407037 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#622864} ios/chrome/test/earl_grey/chrome_matchers.h | 4 +++- ios/chrome/test/earl_grey/chrome_matchers.mm | 18 ++++++++++++++---- 2 files changed, 17 insertions(+), 5 deletions(-) commit 9e4bb50618215ce9e3b4ac4300e45422f52fefd6 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Tue Jan 15 15:23:27 2019 +0000 Add the condition to check if XRRGetOutputInfo returns NULL. This CL adds the condition to check if XRRGetOutputInfo returns NULL, as it has multiple code paths that return NULL. Bug: 921490 Change-Id: Ic72560c1d6e789077b9db7a6bda18ac8ca7b64dc Reviewed-on: https://chromium-review.googlesource.com/c/1411355 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#622863} ui/base/x/x11_display_util.cc | 4 ++++ 1 file changed, 4 insertions(+) commit d82f404065061deeee12e9ab3750f4178eda7c35 Author: Michael van Ouwerkerk <mvanouwerkerk@google.com> Date: Tue Jan 15 15:22:14 2019 +0000 Register cct module lifecycle state in a synthetic field trial. In the UMA dashboard we can use this to slice metrics like PrivateMemoryFootprint. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1405189 It has the following fixes between patch sets 1 and 2: * Ensure the browser process is initialized in the test so we don't get a segfault due to g_browser_process being null. * Run the module loading code on the UI thread. Bug: 882370 Change-Id: I080eb2ab1c9e3f2a4c5c6abc86caa49691b097f2 Reviewed-on: https://chromium-review.googlesource.com/c/1409508 Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#622862} .../customtabs/dynamicmodule/ModuleLoader.java | 5 ++ .../customtabs/dynamicmodule/ModuleMetrics.java | 28 +++++++ .../CustomTabsDynamicModuleLoaderTest.java | 94 +++++++++++----------- 3 files changed, 78 insertions(+), 49 deletions(-) commit b0552857138392bd13415d9a1d42cecf143ac70f Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Jan 15 15:19:28 2019 +0000 [tools/perf] Remove references to GetBuildbotValue The value.GetBuildbotValue() method is being removed. For a list_of_scalar_values, like all metrics here, one can directly access metric.values instead. Bug: 921616 Change-Id: I67255e11dd2f37eb836ccc3b952087c0c065a87e Reviewed-on: https://chromium-review.googlesource.com/c/1409504 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#622861} tools/perf/contrib/oilpan/oilpan_gc_times_unittest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 39e04f0ce0d8812a58afd112713f448cbe82e091 Author: David Roger <droger@chromium.org> Date: Tue Jan 15 15:04:45 2019 +0000 [signin] Untrusted signin dialog is moved earlier in the signin flow This CL moves the untrusted signin dialog from the sync starter to the inline login handler. This will allow removing the sync starter code in a followup. Bug: 915678 Change-Id: Id7422813e72ca31c2ec6ddc2b42deef33e363d1c Reviewed-on: https://chromium-review.googlesource.com/c/1401065 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#622860} .../ui/sync/one_click_signin_sync_starter.cc | 57 +++-------- .../ui/sync/one_click_signin_sync_starter.h | 24 ----- .../sync/one_click_signin_sync_starter_unittest.cc | 3 +- .../sync}/inline_login_ui_browsertest.cc | 110 ++++++++++++--------- .../ui/webui/signin/inline_login_handler_impl.cc | 105 +++++++++++++------- .../ui/webui/signin/inline_login_handler_impl.h | 13 +-- chrome/test/BUILD.gn | 4 +- 7 files changed, 156 insertions(+), 160 deletions(-) commit a10d6bd929f185800b84b07db012ab3dfe3a3757 Author: Joe Mason <joenotcharles@google.com> Date: Tue Jan 15 15:04:04 2019 +0000 Add size limit to chrome_cleaner zip archiver R=csharp Bug: 802092 Change-Id: Ia8fce5a3f8a7509bbe7ceeab934d7c1b8bab5330 Reviewed-on: https://chromium-review.googlesource.com/c/1388723 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#622859} chrome/chrome_cleaner/zip_archiver/target/BUILD.gn | 2 ++ .../zip_archiver/target/zip_archiver_impl.cc | 6 +++++- .../zip_archiver/target/zip_archiver_impl.h | 2 +- .../target/zip_archiver_impl_unittest.cc | 20 ++++++++++++++++++-- 4 files changed, 26 insertions(+), 4 deletions(-) commit 234e2dd1bd41b0efe21bb44e28f64bf7899d7c53 Author: manuk <manukh@chromium.org> Date: Tue Jan 15 15:03:23 2019 +0000 [omnibox chrome:omnibox] Connect the browser's omnibox, CL 2 of 2, UI Interacting with the real omnibox of any browser window while the debug page is open will update the debug page's output. Incognito window omnibox results will update only debug pages open in incognito windows. Likewise, normal window omnibox results will update only debug pages open in normal windows. This is the 2nd of 2 related CL's. The previous CL wired in the browser omnibox, whereas this CL adds the 'Connect with window omnibox' checkbox to disable and enable this feature. Bug: 891303 Change-Id: I4a366e83de22316008df384491f5af9c3f579c64 Reviewed-on: https://chromium-review.googlesource.com/c/1393526 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#622858} chrome/browser/resources/omnibox/omnibox.css | 1 + chrome/browser/resources/omnibox/omnibox.html | 9 ++++++ chrome/browser/resources/omnibox/omnibox.js | 37 ++++++++++++++++------- chrome/browser/resources/omnibox/omnibox_input.js | 5 +++ 4 files changed, 41 insertions(+), 11 deletions(-) commit fcf7047148f59c25709f63602e015077d2e7c559 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Tue Jan 15 15:02:43 2019 +0000 [s13n] Convert SyncConfirmationHandler to IdentityManager This CL only migrates SyncConfirmationHandler production code away from SigninManager. Bug: 920245 Change-Id: Ib65d9912c378ff91c8a3b00aacc3a926b6f97016 Reviewed-on: https://chromium-review.googlesource.com/c/1405953 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#622857} .../ui/webui/signin/sync_confirmation_handler.cc | 19 ++++++++----------- .../ui/webui/signin/sync_confirmation_handler.h | 6 ++++++ 2 files changed, 14 insertions(+), 11 deletions(-) commit df9e5cfddd192a7687f19626b35dfe25e843eb1c Author: David 'Digit' Turner <digit@google.com> Date: Tue Jan 15 14:59:15 2019 +0000 android: Dump localized strings without default configs. The dump_apk_resource_strings.py script crashes when it encounters a resources table that contains a localized string without a value for the default configuration. This is obviously a packaging bug (see below), but should not prevent the script from working. This fixes the issue by faking a value of <MISSING_STRING_<id>>. This makes checking for these use cases obvious in the output. BUG=921001 R=benmason@chromium.org TBR=agrieve@chromium.org Change-Id: I9d408e776d19334eed03a42ddd266895f7628b26 Reviewed-on: https://chromium-review.googlesource.com/c/1411777 Reviewed-by: David Turner <digit@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#622856} build/android/dump_apk_resource_strings.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 7566c93e098f8e57581bd9ae6fe04be1440d08b2 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Jan 15 14:56:49 2019 +0000 [TSan flakiness] Init feature lists in the fixture in wallet sync tests This CL fixes TSan flakiness for wallet sync_integration_tests. TSan reports a data race if ScopedFeatureList gets initialized in the body of the test. Bug: 915219 Change-Id: Ia3ea05c9aabf49de40281238991cf2c2caa2fb57 Reviewed-on: https://chromium-review.googlesource.com/c/1411914 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#622855} .../integration/single_client_wallet_sync_test.cc | 144 +++++++++++---------- .../integration/two_client_wallet_sync_test.cc | 34 +---- .../browser/sync/test/integration/wallet_helper.h | 7 +- 3 files changed, 87 insertions(+), 98 deletions(-) commit c9812b6d581d54ad6876f37d68702bd158e91b71 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Tue Jan 15 14:55:42 2019 +0000 TaskScheduler: Add lock annotations to SchedulerWorker Change-Id: I528951ba7f8cf117c6f96131d6a31011e311d6b9 Reviewed-on: https://chromium-review.googlesource.com/c/1409965 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#622854} base/task/task_scheduler/scheduler_worker.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 0a1219b1718fe9a9e154365e89a4d54c3343c406 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Jan 15 14:53:52 2019 +0000 Roll src/third_party/chromite 5587a0d79ff0..7fed3ca46cb4 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/5587a0d79ff0..7fed3ca46cb4 git log 5587a0d79ff0..7fed3ca46cb4 --date=short --no-merges --format='%ad %ae %s' 2019-01-15 achuith@chromium.org tree_status: Fix gardener email. Created with: gclient setdep -r src/third_party/chromite@7fed3ca46cb4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3b985fcfddba0ded3c59f22d0fb2bf45a623be53 Reviewed-on: https://chromium-review.googlesource.com/c/1412032 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622853} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2536c3002ddfb7d229585dda40dc1fe427469aa2 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Jan 15 14:50:24 2019 +0000 s13n: Eliminate signin_error_notifier_factory_ash.cc's include of profile_oauth2_token_service.h There is no use of ProfileOAuth2TokenService in signin_error_notifier_factory_ash.cc. We don't need to keep the include of profile_oauth2_token_service.h. Bug: 921612 Change-Id: Id8c857cc36e6e8c342f1ee559d91eb26f7d7d219 Reviewed-on: https://chromium-review.googlesource.com/c/1410833 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#622852} chrome/browser/signin/signin_error_notifier_factory_ash.cc | 1 - 1 file changed, 1 deletion(-) commit 7160a0338980bc4b460591ef93e196d20d50c4b9 Author: François Doray <fdoray@chromium.org> Date: Tue Jan 15 14:48:43 2019 +0000 Base: Adjust time tolerance in ProcessTest.CreationTimeOtherProcess. This test failed on bot Linux CFI with: [ RUN ] ProcessTest.CreationTimeOtherProcess ../../base/process/process_unittest.cc:159: Failure Expected: (before_creation - kTolerance) <= (creation), actual: 2019-01-08 12:59:12.953 UTC vs 2019-01-08 12:59:12.950 UTC The failure is due to clock imprecision, so it makes sense to increase the tolerance. On non-Linux platform, it makes sense to reduce the time tolerance. Change-Id: I0e37c84064f5af3067c503f788d8376f7d2a7e51 Reviewed-on: https://chromium-review.googlesource.com/c/1401230 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#622851} base/process/process_unittest.cc | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) commit 802f3e8a34634b5efc133df62883734c3a30c3b2 Author: Yuki Shiino <yukishiino@chromium.org> Date: Tue Jan 15 14:45:35 2019 +0000 v8binding: Collect timer's v8::Function in V8 Scavenger GC Makes it possible that V8 Scavenger GC collects the underlying V8 function of ScheduledAction. V8 Full GC can collect them anyway, but this patch makes it possible for V8 Scavenger GC, too, in order to mitigate the memory regression. Bug: 919474, 919475 Change-Id: Ifff6ae1d6698f8bced834e82a717557dba130b64 Reviewed-on: https://chromium-review.googlesource.com/c/1404900 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#622850} .../blink/renderer/bindings/core/v8/scheduled_action.cc | 13 ++++++++++++- .../renderer/platform/bindings/callback_function_base.h | 10 ++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) commit 93dcec8efd45173b0e2e43b29133354a6ee6ba0f Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Jan 15 14:41:25 2019 +0000 [AF Wallet] Fix flakiness in TwoClientWalletSyncTest.DeleteServer*Meta* This CL fixes flakiness in two integration tests for wallet data & metadata. The flakiness only occurs with the new wallet metadata USS implementation. The problem was that we checked the result too early, we did not leave enough time for the metadata changes to propagate. Bug: 921386 Change-Id: I2cf4a65c0b7011bdf454787d590dee4d234633a1 Reviewed-on: https://chromium-review.googlesource.com/c/1409557 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#622849} .../integration/two_client_wallet_sync_test.cc | 10 +++++ .../browser/sync/test/integration/wallet_helper.cc | 46 ++++++++++++++++++++++ .../browser/sync/test/integration/wallet_helper.h | 20 ++++++++++ 3 files changed, 76 insertions(+) commit d10bdf2a970493c51eb50244dad8bceb691116fe Author: Richard Townsend <richard.townsend@arm.com> Date: Tue Jan 15 14:40:18 2019 +0000 Stop SwiftShader building if enable_swiftshader=false Swiftshader doesn't build at this time for Windows on Arm, and all WoA devices are new enough not to need it at the moment. Change-Id: I5587ab1a324930aaac1b31301f39e3da8b7fabe6 Reviewed-on: https://chromium-review.googlesource.com/c/1409453 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#622848} ui/gl/BUILD.gn | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) commit 9e1de1b67f4c2f98c095138effdd36098105c4bd Author: Aaron Tagliaboschi <aarontag@chromium.org> Date: Tue Jan 15 14:40:06 2019 +0000 Decouple filtering when creating list of cookies. Small change, but super helpful later down the line when we need the full list of cookies (including ones have been filtered) Bug: 856777 Change-Id: I1934f1f086929b74522b5e0283a812abcda87b1e Reviewed-on: https://chromium-review.googlesource.com/c/1409909 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#622847} net/cookies/cookie_monster.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 34f89ab50eb5bddb112b970197af330bab434da1 Author: Joe Mason <joenotcharles@google.com> Date: Tue Jan 15 14:30:18 2019 +0000 Reland "Add shortcut parser to chrome_cleaner" This is a reland of c7a548f91c0159be6380fce48fcd9bb87952a113 Original change's description: > Add shortcut parser to chrome_cleaner > > R=csharp > > Bug: 802092 > Change-Id: I6d3cbf1181024c70af2d1cbe8aa7fd87b9d5a831 > Reviewed-on: https://chromium-review.googlesource.com/c/1388720 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Chris Sharp <csharp@chromium.org> > Commit-Queue: Joe Mason <joenotcharles@google.com> > Cr-Commit-Position: refs/heads/master@{#622527} Bug: 802092 Change-Id: Iaf1a832c69dcdc5c86f0286fe055772ba3bb4d4b Reviewed-on: https://chromium-review.googlesource.com/c/1409699 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by: Chris Sharp <csharp@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#622846} chrome/chrome_cleaner/BUILD.gn | 5 + .../interfaces/parser_interface.mojom | 21 ++ chrome/chrome_cleaner/parsers/broker/BUILD.gn | 5 + .../broker/lnk_parser_sandbox_setup_unittest.cc | 124 +++++++ .../chrome_cleaner/parsers/parser_utils/BUILD.gn | 27 ++ .../command_line_arguments_sanitizer.cc | 79 +++++ .../command_line_arguments_sanitizer.h | 21 ++ .../command_line_arguments_sanitizer_unittest.cc | 85 +++++ .../parsers/shortcut_parser/BUILD.gn | 17 + .../parsers/shortcut_parser/broker/BUILD.gn | 71 ++++ .../shortcut_parser/broker/fake_shortcut_parser.cc | 37 +++ .../shortcut_parser/broker/fake_shortcut_parser.h | 36 +++ .../broker/sandboxed_shortcut_parser.cc | 141 ++++++++ .../broker/sandboxed_shortcut_parser.h | 56 ++++ .../broker/sandboxed_shortcut_parser_unittest.cc | 259 +++++++++++++++ .../shortcut_parser/broker/shortcut_parser_api.cc | 14 + .../shortcut_parser/broker/shortcut_parser_api.h | 51 +++ .../sandboxed_lnk_parser_test_util.cc | 71 ++++ .../sandboxed_lnk_parser_test_util.h | 41 +++ .../parsers/shortcut_parser/target/BUILD.gn | 31 ++ .../parsers/shortcut_parser/target/lnk_parser.cc | 356 +++++++++++++++++++++ .../parsers/shortcut_parser/target/lnk_parser.h | 77 +++++ .../shortcut_parser/target/lnk_parser_unittest.cc | 345 ++++++++++++++++++++ chrome/chrome_cleaner/parsers/target/BUILD.gn | 4 + .../chrome_cleaner/parsers/target/parser_impl.cc | 37 +++ chrome/chrome_cleaner/parsers/target/parser_impl.h | 4 + .../parsers/target/parser_impl_unittest.cc | 70 +++- 27 files changed, 2084 insertions(+), 1 deletion(-) commit fa7ce7c8f2619e6c98f9e908b5f7fa17591c10a5 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Jan 15 14:17:22 2019 +0000 [iOS] Removing SSOWithWKWebView flag SSOWithWKWebView is now always on. Related to: crrev.com/i/769010 Change-Id: Idfc28b462837fa518488d99538941b9e90fceab9 Reviewed-on: https://chromium-review.googlesource.com/c/1396025 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#622845} ios/chrome/browser/about_flags.mm | 3 --- ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ---- ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 ---- ios/chrome/browser/signin/feature_flags.h | 6 ------ ios/chrome/browser/signin/feature_flags.mm | 11 ----------- 5 files changed, 28 deletions(-) commit db58de1936a96da4898f001a59d6f4fadd076039 Author: Morten Stenshorne <mstensho@chromium.org> Date: Tue Jan 15 14:07:42 2019 +0000 [LayoutNG] Support PaintTouchActionRects for line boxes. Since the code to determine whether or not to record hit test data is pretty much identical for any type of fragment, I placed the code at a common place in NGFragmentPainter. This fixes the remaining ScrollingCoordinatorTest unit test failures. Change-Id: I7c5bb6dc2ac5cb7b5593bc9a93790236002cfa16 Reviewed-on: https://chromium-review.googlesource.com/c/1404168 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#622844} .../core/paint/ng/ng_box_fragment_painter.cc | 37 +++++++++++++--------- .../core/paint/ng/ng_box_fragment_painter.h | 4 +++ .../renderer/core/paint/ng/ng_fragment_painter.cc | 23 ++++++++++++++ .../renderer/core/paint/ng/ng_fragment_painter.h | 4 +++ 4 files changed, 53 insertions(+), 15 deletions(-) commit b7ece1e208de3215928a8c91d971945b83ca1267 Author: Adam Rice <ricea@chromium.org> Date: Tue Jan 15 14:01:13 2019 +0000 Make blink::WritableStream a pure virtual class In preparation for adding the native implementation, rename the existing implementation to blink::WritableStreamWrapper and make blink::WritableStream be a virtual base class for it. When the native implementation is added, Create() methods and other places that need to work with the real type will check a runtime flag. BUG=902633 Change-Id: I97c6b4e5b1461b0b3b0092773db60644b3711b5f Reviewed-on: https://chromium-review.googlesource.com/c/1405954 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#622843} .../core/v8/custom/v8_writable_stream_custom.cc | 5 +- third_party/blink/renderer/core/streams/BUILD.gn | 2 + .../blink/renderer/core/streams/readable_stream.cc | 19 +- .../renderer/core/streams/transform_stream.cc | 4 +- .../blink/renderer/core/streams/writable_stream.cc | 211 +------------------ .../blink/renderer/core/streams/writable_stream.h | 57 +---- .../core/streams/writable_stream_wrapper.cc | 230 +++++++++++++++++++++ .../core/streams/writable_stream_wrapper.h | 88 ++++++++ 8 files changed, 359 insertions(+), 257 deletions(-) commit a82f115f1eb907a8ed70bd87f82a45951ec62d26 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Tue Jan 15 13:59:47 2019 +0000 Make DesktopNativeWidgetAura::Minimize clear root view event handlers. This fixes the issue with the root view holding onto a gesture handler on window minimize which sends the event to the previous gesture handler. Bug: 912514 Change-Id: I25775378197fb56cca6ad1c8232e792d83720ba8 Reviewed-on: https://chromium-review.googlesource.com/c/1388170 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#622842} .../desktop_aura/desktop_native_widget_aura.cc | 3 +++ ui/views/widget/root_view.cc | 16 ++++++++++------ ui/views/widget/root_view.h | 4 ++++ ui/views/widget/widget_interactive_uitest.cc | 21 +++++++++++++++++++++ 4 files changed, 38 insertions(+), 6 deletions(-) commit 94f7b1aa595cbf5cb83e9ffbf30727fe163259fa Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Jan 15 13:58:55 2019 +0000 Update V8 to version 7.3.401. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a47a630e..84625cac Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iab0bc215af1d777e54f2d7712c2b42fa8e026ae2 Reviewed-on: https://chromium-review.googlesource.com/c/1411738 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#622841} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 96d6689867a1b02bca04937c68805b014804fcb1 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jan 15 13:53:47 2019 +0000 Socket Pools Refector 3: Put WebSocketTransportConnectJob in a new file. As with TransportConnectJob, it will need to be possible to create one from other ConnectJob classes, at the bottom of the stack, once ConnectJobs have been decoupled from SocketPool classes. Bug: 472729 Change-Id: Ie273409c5de35d9f6bb46d490511b6ef3c03b544 Reviewed-on: https://chromium-review.googlesource.com/c/1407436 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#622840} net/BUILD.gn | 2 + .../websocket_transport_client_socket_pool.cc | 273 +------------------- .../websocket_transport_client_socket_pool.h | 104 +------- net/socket/websocket_transport_connect_job.cc | 283 +++++++++++++++++++++ net/socket/websocket_transport_connect_job.h | 131 ++++++++++ net/socket/websocket_transport_connect_sub_job.h | 2 +- 6 files changed, 422 insertions(+), 373 deletions(-) commit 5e5816d3c3331b289b5d1788756e1a6819625292 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Tue Jan 15 13:52:33 2019 +0000 Remove DeviceNativePrinters pref as it's not used anywhere. Bug: 807068 Change-Id: I400c64df6876e8c96a23059109cf3d7ad7e92775 Reviewed-on: https://chromium-review.googlesource.com/c/1406911 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#622839} chrome/browser/chromeos/settings/device_settings_provider.cc | 1 - chrome/test/data/policy/policy_test_cases.json | 6 +----- chromeos/settings/cros_settings_names.cc | 2 -- chromeos/settings/cros_settings_names.h | 1 - 4 files changed, 1 insertion(+), 9 deletions(-) commit 8c43e923981181fa506020964f25e673a504062b Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Tue Jan 15 13:41:57 2019 +0000 Read external printers from device settings. Bug: 807068 Change-Id: Ic423edfeefe662d35357323c36f6ace08dc4109f Reviewed-on: https://chromium-review.googlesource.com/c/1349970 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#622838} chrome/browser/chromeos/BUILD.gn | 8 ++ .../policy/browser_policy_connector_chromeos.cc | 7 ++ .../policy/browser_policy_connector_chromeos.h | 2 + .../policy/device_native_printers_handler.cc | 56 ++++++++++ .../policy/device_native_printers_handler.h | 40 +++++++ .../device_native_printers_handler_unittest.cc | 123 +++++++++++++++++++++ .../printing/device_external_printers_factory.cc | 41 +++++++ .../printing/device_external_printers_factory.h | 45 ++++++++ .../device_external_printers_settings_bridge.cc | 101 +++++++++++++++++ .../device_external_printers_settings_bridge.h | 47 ++++++++ .../chromeos/printing/external_printers_policies.h | 17 +++ .../printing/external_printers_pref_bridge.h | 8 +- .../chromeos/printing/synced_printers_manager.cc | 79 ++++++++++--- .../chromeos/settings/device_settings_provider.cc | 33 ++++++ 14 files changed, 585 insertions(+), 22 deletions(-) commit 62f90f278ae2afe6023c9ad37c89e37ed6def5c7 Author: Florin Malita <fmalita@chromium.org> Date: Tue Jan 15 13:41:42 2019 +0000 Remove font properties from PaintFlags Following Skia's SkPaint/SkFont fission, remove font-related properties from PaintFlags. There are only three remaining clients which use temporary PaintFlags for text: SkiaTextRenderer, HeadsUpDisplayLayerImpl and HarfbuzzFontSkia. Refactor these to use explicit SkFonts. Bug: skia:2664 Change-Id: I84563f04ed0dbf3247ac8ab4b1b191801a2c4bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1408310 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: enne <enne@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mike Reed <reed@google.com> Cr-Commit-Position: refs/heads/master@{#622837} cc/layers/heads_up_display_layer_impl.cc | 38 +++++++--------- cc/layers/heads_up_display_layer_impl.h | 4 +- cc/paint/paint_flags.cc | 30 +----------- cc/paint/paint_flags.h | 48 +------------------- cc/paint/paint_op_buffer_unittest.cc | 4 -- cc/paint/paint_op_helper_unittest.cc | 78 ++++++++++---------------------- cc/paint/paint_op_reader.cc | 1 - cc/paint/paint_op_writer.cc | 1 - cc/test/paint_op_helper.h | 26 ----------- ui/gfx/harfbuzz_font_skia.cc | 30 ++++++------ ui/gfx/render_text.cc | 56 +++++++++++++---------- ui/gfx/render_text.h | 6 ++- ui/gfx/render_text_test_api.h | 6 ++- ui/gfx/render_text_unittest.cc | 24 +++++----- 14 files changed, 113 insertions(+), 239 deletions(-) commit 0ca377611eb523aa3d06983162f9d4d4d1b19ab2 Author: Mario Sanchez Prada <mario@igalia.com> Date: Tue Jan 15 13:35:20 2019 +0000 Migrated AccountsMutator tests to the IdentityTestEnvironment Move away from ProfileOAuth2TokenService and AccountTrackerService and rely on the AccountsMutator returned by the IdentityManager provided by IdentityTestEnvironment instead. Bug: 920277 Change-Id: If25fc3efe80bc14a8a99b849c38d52802ba7b89f Reviewed-on: https://chromium-review.googlesource.com/c/1408973 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#622836} services/identity/BUILD.gn | 4 - services/identity/public/cpp/BUILD.gn | 1 + .../public/cpp/accounts_mutator_impl_unittest.cc | 355 --------------------- .../public/cpp/accounts_mutator_unittest.cc | 355 +++++++++++++++++++++ 4 files changed, 356 insertions(+), 359 deletions(-) Updated tag 'tree_truth' (was 317923340a7c)