Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 32828 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8922136717315700736 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itJB_5ab/luci_context.831763311 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2472-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 42e33ed7f5aeae11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 2502230cf3823bad098bcde3eb5058e2f1addd56 splitview: Fix animation not showing up when exiting overview. Sammie Quon, Fri Feb 8 00:00:23 2019 +0000 5beff6800372ee86b46ef69d040ab00cdfd5c843 [omnibox]: Show original text when reverting with a default keyword match. manuk, Thu Feb 7 23:59:23 2019 +0000 8b43cc42c58d9516891c9cbf0050d7df1a6a6cce Fix ProcessMemoryMetricsEmitterTest ssid, Thu Feb 7 23:59:06 2019 +0000 16f8608658ebae8d9f4ae1fae7bc52377cb02c51 Get rid of unused class SearchBuffer Yoshifumi Inoue, Thu Feb 7 23:57:43 2019 +0000 c713d509ed6bdbef90b00aff138a7b6a5d1c123d Add user visible flag for WebContentsOcclusion on Windows. David Bienvenu, Thu Feb 7 23:46:32 2019 +0000 169ec7e7619edff12b75b6cc658fb16f00f21f8f Add back direct composition InfoCollection test. Zhenyao Mo, Thu Feb 7 23:43:08 2019 +0000 36584543462641ddc56eea2d292a4a470612d99c //gpu: Convert base::(U)Int(64)ToString(16) to NumberToString(16) Raul Tambre, Thu Feb 7 23:42:08 2019 +0000 56c3f510b10f678da5cf446c3fc69fb4cd3469a3 Move font unique name lookup table construction to own singleton class Dominik Röttsches, Thu Feb 7 23:42:04 2019 +0000 ad1c576f5634bd106199a5354ac8a76008972770 [Unity][Android] Implement bottom button bar in SyncAndServicesPreferences Boris Sazonov, Thu Feb 7 23:41:03 2019 +0000 465e778ef1add91c025163b01bd3609acdafeae8 Port flag doc to markdown. Avi Drissman, Thu Feb 7 23:41:00 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 2502230cf3823bad098bcde3eb5058e2f1addd56 Author: Sammie Quon <sammiequon@google.com> Date: Fri Feb 8 00:00:23 2019 +0000 splitview: Fix animation not showing up when exiting overview. [1] changed overview to release overview session and then pass that object to its observers. Splitview was querying overview controller for overview session which would be null, so it wouldnt remove the snap window from overview list, which would cause its animation to be supressed. This cl change splitview to remove the window in OnOverviewEnded and use the overview session object before snapping. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1406169 Test: manual Bug: 929658 Change-Id: Iabab38034bea49cdafd1a3ad24310298ca8826de Reviewed-on: https://chromium-review.googlesource.com/c/1459066 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#630106} ash/wm/overview/overview_session.h | 2 + ash/wm/splitview/split_view_controller.cc | 6 +++ ash/wm/splitview/split_view_controller.h | 2 +- ash/wm/splitview/split_view_controller_unittest.cc | 46 ++++++++++++++++++++++ 4 files changed, 55 insertions(+), 1 deletion(-) commit 5beff6800372ee86b46ef69d040ab00cdfd5c843 Author: manuk <manukh@chromium.org> Date: Thu Feb 7 23:59:23 2019 +0000 [omnibox]: Show original text when reverting with a default keyword match. Previously, reverting the omnibox's selected match (e.g. by pressing escape) when the default match is in keyword mode resulted in incorrect behavior regarding the user text, autocomplete text, and text styling: (1) The user text has its first word removed for each time keyword mode was entered. If the results popup included a navigation result, pressing up/down to select the navigation result leaves keyword mode. Pressing up/down to select a search result or pressing escape to revert the omnibox text reenters keyword mode. Each time keyword mode is entered, the user text drops the first word. E.g. if the 2nd result is a navigation result, and the third result is a search result, pressing <down><down><up><escape> would enter keyword mode twice, and drop the first two words of the user text. (2) The user text would be styled as a URL (grey font color) if the result selected before reverting was a URL result. (3) The autocomplete text is not restored. This CL addresses (1) and (3). (2) is partially addressed as well; for cases where the default match has autocomplete text, restoring it correctly also restores the user text styling. The fix is 2 part: (1) Before, the first word of the user text was stripped upon entering keyword mode because we assumed the first word must be the keyword word. However, this assumption is only true when accepting a keyword (e.g. pressing <space> or <tab>), and not when entering keyword mode by reverting the omnibox's selected match (e.g. pressing <escape>). This CL moves the stripping call from OmniboxEditModel::OnPopupDataChanged, which is called in both cases, to OmniboxEditModel::OnCurrentMatchChanged, which is only called in the first case. (2) Before, the cursor was reset to the beginning of the user text when entering keyword mode while the default match was either already selected or becoming selected. The first occurs when (a) inserting a space between a keyword name and a search string, while the latter occurs when (b) reverting the omnibox's selected match. This was desired behavior in case (a), but undesired in case (b). We incorrectly assumed it was ok to do this in case (b) because we would be reverting the text anyways. However, the revert happens prior to this, resulting in incorrect autocomplete selection. This CL conditions the cursor reset on not having autocomplete text. Bug: 702867 Change-Id: Iac0bdae7e17c86b3e0feb3075dd916d85e5d7e39 Reviewed-on: https://chromium-review.googlesource.com/c/1458697 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#630105} components/omnibox/browser/omnibox_edit_model.cc | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) commit 8b43cc42c58d9516891c9cbf0050d7df1a6a6cce Author: ssid <ssid@chromium.org> Date: Thu Feb 7 23:59:06 2019 +0000 Fix ProcessMemoryMetricsEmitterTest Do not check for uptime to be less than 10. Process could be running longer in the test. This does not fix the failure due to missing uptime value. BUG=731466 Change-Id: I0b176da810dd8f3bc90ad4b94386bc46e68fa1e7 Reviewed-on: https://chromium-review.googlesource.com/c/1338954 Reviewed-by: Erik Chen <erikchen@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630104} chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 16f8608658ebae8d9f4ae1fae7bc52377cb02c51 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Thu Feb 7 23:57:43 2019 +0000 Get rid of unused class SearchBuffer This patch gets rid of unused class |SearchBuffer| and related files for improving code health. Since the CL[1], nobody use this class. [1] http://crrev.com/c/1451697: Make FindStringBetweenPositions use FindBuffer and activate invisible matches Change-Id: I36589acdc8e00d89f7fc2cc6d028a84e2389ea2f Reviewed-on: https://chromium-review.googlesource.com/c/1457702 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#630103} third_party/blink/renderer/core/editing/BUILD.gn | 3 - third_party/blink/renderer/core/editing/editor.cc | 1 - .../core/editing/iterators/search_buffer.cc | 401 --------------------- .../core/editing/iterators/search_buffer.h | 107 ------ .../core/editing/iterators/search_buffer_test.cc | 106 ------ 5 files changed, 618 deletions(-) commit c713d509ed6bdbef90b00aff138a7b6a5d1c123d Author: David Bienvenu <davidbienvenu@chromium.org> Date: Thu Feb 7 23:46:32 2019 +0000 Add user visible flag for WebContentsOcclusion on Windows. Bug: 813093 Change-Id: I8e4779551cb75d88f1f07c069cd7e5d7793da5b1 Reviewed-on: https://chromium-review.googlesource.com/c/1455094 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#630102} chrome/browser/about_flags.cc | 7 +++++++ chrome/browser/flag-metadata.json | 35 ++++++++++++++++++++--------------- chrome/browser/flag_descriptions.cc | 9 +++++++++ chrome/browser/flag_descriptions.h | 7 +++++++ tools/metrics/histograms/enums.xml | 2 ++ 5 files changed, 45 insertions(+), 15 deletions(-) commit 169ec7e7619edff12b75b6cc658fb16f00f21f8f Author: Zhenyao Mo <zmo@chromium.org> Date: Thu Feb 7 23:43:08 2019 +0000 Add back direct composition InfoCollection test. This test was commented out due to flakiness, but we found out the failures are limited to two bots only where overlay cap is DIRECT instead of SCALING. So we removed these two bots from swarming pool so we can add back this test. However, this time we split it into its own test. BUG=929469 TEST=Win/Intel GPU bots R=kbr@chromium.org Change-Id: Ibe0402996709fbdaceee6f9431b8b58d05f59d33 Reviewed-on: https://chromium-review.googlesource.com/c/1457664 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630101} content/test/gpu/gpu_tests/info_collection_test.py | 59 +++++++++++++--------- 1 file changed, 36 insertions(+), 23 deletions(-) Updated tag 'tree_truth' (was 365845434626)