Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 50782 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8921825439159652144 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itT1LjM1/luci_context.166475746 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm568-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 42f4f08887d66411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 83b9663e3814ef7e53af5009d10033b89955db44 Move datatype dependencies away from SyncClient Mikel Astiz, Mon Feb 11 10:25:17 2019 +0000 d983179ffc57406e0a700d870366a1474b23244a Ignore same-document navigation commit in pending deletion frame. arthursonzogni, Mon Feb 11 10:24:17 2019 +0000 7e4619a28048a050d68f4fdbbf3db3043374fd29 CSVTable should only understand CRLF and LF as EOL Vaclav Brozek, Mon Feb 11 10:15:31 2019 +0000 44827fbd572669eb59878beb9b208e12bafd7813 //components/supervised_user_error_page: Convert base::(U)Int(64)ToString(16) to NumberToString(16) Raul Tambre, Mon Feb 11 10:08:02 2019 +0000 3d037722e894145122ff7f07783e6a9382e38a44 [Mfill Android] Display title of open sheet in accessory bar Friedrich Horschig, Mon Feb 11 10:04:38 2019 +0000 6aa1608e02eef03a4642f7c3a54578fab47608d4 sync_ui_util: Only take a Profile* param, not other KeyedService*s Marc Treib, Mon Feb 11 09:41:37 2019 +0000 25117a7b92c42cb73856aa430897ba516fd4865c [Android Mfill] Reenable integration tests Friedrich Horschig, Mon Feb 11 09:35:54 2019 +0000 6c34bd1ad0a8e7a846536be57d042cbd14709b17 blink: Fix member names in comments. Victor Costan, Mon Feb 11 09:28:49 2019 +0000 2e6c3d90227b01b1fbc2a895e89e5dfd97886dd7 Add comment to NavigationBodyLoader::OnReceiveCachedMetadata() arthursonzogni, Mon Feb 11 09:27:22 2019 +0000 682082177036e1017a7e90971d2b77511defec3c Fix mojo mailing list Michael Giuffrida, Mon Feb 11 09:15:21 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 83b9663e3814ef7e53af5009d10033b89955db44 Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Feb 11 10:25:17 2019 +0000 Move datatype dependencies away from SyncClient We do this by introducing another layer, BrowserSyncClient, to minimize the code changes. Even in this humble form, the change substantially improves layering and already fixes some important issues like forward declarations being used to avoid build dependencies that would otherwise cause dependency cycles. The downside is that some extra boilerplate code is required to avoid dependencies selectively, as opposed to SyncClient being used as a big convenience bundle. This is arguably an improvement, though. In future patches, we should probably get rid of this new class altogether, but that requires more intrusive changes. Bug: 915154 Change-Id: Iaad6d54272bb1ccc00759ad039b313896acd4e34 Reviewed-on: https://chromium-review.googlesource.com/c/1458196 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630710} .../supervised_user_sync_model_type_controller.cc | 11 +- .../supervised_user_sync_model_type_controller.h | 8 +- chrome/browser/sync/chrome_sync_client.cc | 39 ++-- chrome/browser/sync/chrome_sync_client.h | 23 +-- .../browser/sync/profile_sync_service_factory.cc | 1 - chrome/browser/sync/profile_sync_test_util.cc | 17 +- chrome/browser/sync/profile_sync_test_util.h | 8 - .../sync/test/integration/bookmarks_helper.cc | 9 +- .../single_client_directory_sync_test.cc | 2 - .../integration/single_client_wallet_sync_test.cc | 1 + .../autofill_wallet_data_type_controller.cc | 5 +- .../browser/autofill_wallet_data_type_controller.h | 11 +- ...utofill_wallet_data_type_controller_unittest.cc | 50 +++-- .../autofill_profile_data_type_controller.cc | 9 +- .../autofill_profile_data_type_controller.h | 9 + components/browser_sync/BUILD.gn | 2 + .../abstract_profile_sync_service_test.cc | 2 +- components/browser_sync/browser_sync_client.cc | 19 ++ components/browser_sync/browser_sync_client.h | 70 +++++++ .../profile_sync_components_factory_impl.cc | 67 ++++--- .../profile_sync_components_factory_impl.h | 18 +- components/browser_sync/profile_sync_service.cc | 8 +- .../profile_sync_service_autofill_unittest.cc | 75 ++++---- .../profile_sync_service_bookmark_unittest.cc | 26 +-- .../profile_sync_service_startup_unittest.cc | 39 ++-- .../browser_sync/profile_sync_service_unittest.cc | 86 +++++---- components/browser_sync/profile_sync_test_util.cc | 208 ++------------------- components/browser_sync/profile_sync_test_util.h | 64 +------ ...tory_delete_directives_model_type_controller.cc | 3 +- ...story_delete_directives_model_type_controller.h | 2 + .../browser/sync/password_model_type_controller.cc | 12 +- .../browser/sync/password_model_type_controller.h | 8 +- ...syncable_service_based_model_type_controller.cc | 14 +- ..._syncable_service_based_model_type_controller.h | 7 +- .../search_engine_data_type_controller_unittest.cc | 22 +-- components/sync/BUILD.gn | 2 - .../async_directory_type_controller_unittest.cc | 11 +- components/sync/driver/fake_sync_client.cc | 108 ----------- components/sync/driver/fake_sync_client.h | 57 ------ components/sync/driver/shared_change_processor.cc | 3 +- .../driver/shared_change_processor_unittest.cc | 26 +-- .../sync/driver/sync_api_component_factory.h | 16 +- .../sync/driver/sync_api_component_factory_mock.h | 8 +- components/sync/driver/sync_client.h | 48 +---- components/sync/driver/sync_client_mock.h | 10 +- components/sync/engine_impl/model_type_registry.cc | 4 +- .../sync_bookmarks/bookmark_change_processor.cc | 38 ++-- .../sync_bookmarks/bookmark_change_processor.h | 25 +-- .../bookmark_data_type_controller.cc | 26 ++- .../sync_bookmarks/bookmark_data_type_controller.h | 15 +- .../bookmark_data_type_controller_unittest.cc | 58 ++---- .../sync_bookmarks/bookmark_model_associator.cc | 26 ++- .../sync_bookmarks/bookmark_model_associator.h | 25 ++- .../bookmark_model_type_processor_unittest.cc | 1 - .../sync/ios_chrome_profile_sync_test_util.cc | 6 +- .../sync/ios_chrome_profile_sync_test_util.h | 8 +- ios/chrome/browser/sync/ios_chrome_sync_client.h | 21 +-- ios/chrome/browser/sync/ios_chrome_sync_client.mm | 30 +-- .../passphrase_table_view_controller_test.mm | 2 +- ...nc_encryption_table_view_controller_unittest.mm | 2 +- ...sync_settings_table_view_controller_unittest.mm | 2 +- .../internal/sync/cwv_sync_controller_unittest.mm | 31 +-- ios/web_view/internal/sync/web_view_sync_client.h | 23 ++- ios/web_view/internal/sync/web_view_sync_client.mm | 6 +- 64 files changed, 585 insertions(+), 1008 deletions(-) commit d983179ffc57406e0a700d870366a1474b23244a Author: arthursonzogni <arthursonzogni@chromium.org> Date: Mon Feb 11 10:24:17 2019 +0000 Ignore same-document navigation commit in pending deletion frame. Similar to what is done with different-document navigations. If a same-document navigation commits into a pending deletion frame, it needs to be ignored. Regression tests added. Bug: 930132 Change-Id: Ib905197d30a754c3ac77b510d58741f40755a80f Reviewed-on: https://chromium-review.googlesource.com/c/1461023 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#630709} .../browser/frame_host/render_frame_host_impl.cc | 15 ++++---- content/browser/site_per_process_browsertest.cc | 45 ++++++++++++++++++++++ 2 files changed, 52 insertions(+), 8 deletions(-) commit 7e4619a28048a050d68f4fdbbf3db3043374fd29 Author: Vaclav Brozek <vabr@chromium.org> Date: Mon Feb 11 10:15:31 2019 +0000 CSVTable should only understand CRLF and LF as EOL So far, CSVTable understood any combination of CR and LF characters as the end of line. After a discussion linked to in https://crbug.com/923811, this CL changes that to explicitly only allowing CRLF and LF. Moreover, CRLF is no longer converted to LF inside quoted (escaped) strings. Performance impact, as measured with the benchmark from https://crrev.com/c/1459642: * Run time of the benchmark decreased from about 10s to about 9.5s * Peak memory consumption over 5 runs decreased from about 168700 kB to about 168350 kB Bug: 923811 Change-Id: I979d05e9f296f285db99dc22662bae29c907ea2a Reviewed-on: https://chromium-review.googlesource.com/c/1461042 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630708} .../core/browser/import/csv_reader.cc | 29 +++++++++++----------- .../core/browser/import/csv_reader.h | 3 +-- .../core/browser/import/csv_reader_unittest.cc | 18 ++++++++++---- 3 files changed, 28 insertions(+), 22 deletions(-) commit 44827fbd572669eb59878beb9b208e12bafd7813 Author: Raul Tambre <raul@tambre.ee> Date: Mon Feb 11 10:08:02 2019 +0000 //components/supervised_user_error_page: Convert base::(U)Int(64)ToString(16) to NumberToString(16) The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I19be29e50c0d268b4280a6b0e572acdb0ac67af3 Reviewed-on: https://chromium-review.googlesource.com/c/1461385 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#630707} components/supervised_user_error_page/supervised_user_error_page.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3d037722e894145122ff7f07783e6a9382e38a44 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Feb 11 10:04:38 2019 +0000 [Mfill Android] Display title of open sheet in accessory bar This CL removes the static title if suggestions are available. Margins between suggestions are adjusted (according to mocks). It also fixes a minor bug: the back arrow wasn't mirrored in RTL mode. Bug: TBA Change-Id: I8a6e12c75418ee5c90ed6bd326ed075e8033bc8d Reviewed-on: https://chromium-review.googlesource.com/c/1458856 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#630706} .../java/res/drawable/ic_arrow_back_24dp.xml | 1 + .../java/res/layout/keyboard_accessory_modern.xml | 10 ++++++ .../keyboard_accessory_sheet_tab_legacy_title.xml | 40 ++++++++++++++++++++++ .../keyboard_accessory_sheet_tab_password_info.xml | 8 ++--- .../layout/keyboard_accessory_sheet_tab_title.xml | 13 +------ chrome/android/java/res/values/dimens.xml | 1 + .../AccessorySheetTabCoordinator.java | 5 +-- .../AccessorySheetTabViewBinder.java | 7 +++- .../CreditCardAccessorySheetCoordinator.java | 5 +-- .../KeyboardAccessoryCoordinator.java | 3 +- .../keyboard_accessory/KeyboardAccessoryData.java | 20 ++++++++--- .../KeyboardAccessoryMediator.java | 8 ++++- .../KeyboardAccessoryMetricsRecorder.java | 1 + .../KeyboardAccessoryModernView.java | 8 +++++ .../KeyboardAccessoryModernViewBinder.java | 3 ++ .../KeyboardAccessoryProperties.java | 2 ++ .../KeyboardAccessoryViewBinder.java | 3 ++ .../PasswordAccessorySheetCoordinator.java | 3 +- .../PasswordAccessorySheetMediator.java | 10 +++++- .../PasswordAccessorySheetModernViewBinder.java | 6 ++-- .../AccessorySheetTabViewTest.java | 2 +- .../keyboard_accessory/AccessorySheetViewTest.java | 6 ++-- .../KeyboardAccessoryTabLayoutViewTest.java | 2 +- .../PasswordAccessorySheetModernViewTest.java | 5 +-- .../PasswordAccessorySheetViewTest.java | 5 ++- .../AccessorySheetControllerTest.java | 7 ++-- .../KeyboardAccessoryControllerTest.java | 26 +++++++++++--- .../KeyboardAccessoryTabLayoutControllerTest.java | 2 +- .../ManualFillingControllerTest.java | 16 ++++----- .../PasswordAccessorySheetControllerTest.java | 38 ++++++++++++++++++++ 30 files changed, 204 insertions(+), 62 deletions(-) Updated tag 'tree_truth' (was 6aa1608e02ee)