Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 39900 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8921565699718244000 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itZCIgt4/luci_context.434199902 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: gce-trusty-e833d7b0-us-west1-a-spj9 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4303b43f36764b11 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: ef54e40ee7c30eea1cf9315fddf9fdba5863784e Reland "Rename some blink-related build targets" Kent Tamura, Thu Feb 14 07:18:36 2019 +0000 29c088b2b5af9090590276b5c9ed0f4bf238a2cd SignedExchange: Close response body data pipe on integrity error Kunihiko Sakamoto, Thu Feb 14 07:14:42 2019 +0000 e6abe439b0e02f37be499c87abd791e00e91df77 Introduce probe::PrepareRequest Yutaka Hirano, Thu Feb 14 07:12:51 2019 +0000 da41081f41e8cf7177101b048bbf6958f107099e Import wpt@0db395ed1acb636ab0fa2686944a46d038d073d4 Chromium WPT Sync, Thu Feb 14 07:04:50 2019 +0000 8c3aeed29ee5998dc4c1f4bc3d0bb2b454e6b556 Fix some CSS presubmit warnings. Shik Chen, Thu Feb 14 06:59:59 2019 +0000 ad28299e6083b156bda90c3b9ec2b88d7bf9df6e StaticKCM: Enable sending layout name by default. Tetsui Ohkubo, Thu Feb 14 06:59:50 2019 +0000 af32970be02a1acb1f5580235f0bdb5102e2bcb4 media/gpu/test: Port the VDA thumbnail test to the new video decoder tests. David Staessens, Thu Feb 14 06:54:02 2019 +0000 31b126468f76d0170217fd35f323519a7d89d4da Revert "Ensure page visibility is consistent after load" Findit, Thu Feb 14 06:50:54 2019 +0000 cd7dc41289cbcea6439524fea547103cf11d0f79 media/gpu/test: Fix parameters of the new video decoder tests. David Staessens, Thu Feb 14 06:42:56 2019 +0000 aeca9afbbdcd891a13e85c89f926962ac43827b0 [Files app] Convert to background/ to arrow func Luciano Pacheco, Thu Feb 14 06:41:13 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit ef54e40ee7c30eea1cf9315fddf9fdba5863784e Author: Kent Tamura <tkent@chromium.org> Date: Thu Feb 14 07:18:36 2019 +0000 Reland "Rename some blink-related build targets" This is a reland of 2cd1482c05e27009ff6a22d7c26a79560977c59b Difference from the original CL: Keep "webkit_unit_tests" target as an alias of blink_unittests. Android internal builders depend on it. Original change's description: > Rename some blink-related build targets > > * webkit_unit_tests -> blink_unittests > * run_webkit_tests -> run_web_tests > * webkit_layout_tests -> blink_web_tests > * webkit_layout_tests_exparchive -> blink_web_tests_exparchive > * webkit_python_tests -> blink_python_tests > Rename testing/scripts/webkit_python_tests.py to > blink_python_tests.py > * webkit_lint -> blink_lint_expectations > Rename testing/scripts/webkit_lint.py to blink_lint_expectations.py > > NOTRY=true > > Bug: 914213 > Change-Id: I4dbb92a2593a36c5ae5ead1d38960ffdeb518010 > Reviewed-on: https://chromium-review.googlesource.com/c/1379626 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632083} NOTRY=true TBR=martiniss@chromium.org,kinuko@chromium.org,thakis@chromium.org Bug: 914213, 931992 Change-Id: I57ffa5a12d6a699357b571ac4e6db5a7c4d6dff2 Reviewed-on: https://chromium-review.googlesource.com/c/1472014 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#632119} BUILD.gn | 26 +- build/android/pylib/gtest/gtest_config.py | 2 +- build/config/compiler/BUILD.gn | 2 +- content/public/test/blink_test_environment.h | 2 +- testing/buildbot/chromium.android.fyi.json | 93 ++-- testing/buildbot/chromium.android.json | 608 +++++++++++---------- testing/buildbot/chromium.chromiumos.json | 26 +- testing/buildbot/chromium.clang.json | 571 ++++++++++--------- testing/buildbot/chromium.fyi.json | 264 ++++----- testing/buildbot/chromium.gpu.json | 4 +- testing/buildbot/chromium.linux.json | 162 +++--- testing/buildbot/chromium.mac.json | 219 ++++---- testing/buildbot/chromium.memory.json | 271 ++++----- testing/buildbot/chromium.webkit.json | 10 +- testing/buildbot/chromium.win.json | 159 +++--- testing/buildbot/gn_isolate_map.pyl | 66 +-- testing/buildbot/test_suites.pyl | 25 +- testing/buildbot/tryserver.chromium.android.json | 5 +- testing/buildbot/tryserver.chromium.linux.json | 17 +- testing/buildbot/tryserver.webrtc.json | 16 +- testing/buildbot/waterfalls.pyl | 8 +- .../{webkit_lint.py => blink_lint_expectations.py} | 0 ...ebkit_python_tests.py => blink_python_tests.py} | 0 third_party/blink/public/BUILD.gn | 2 +- third_party/blink/renderer/controller/BUILD.gn | 19 +- .../renderer/core/editing/inline_box_position.h | 2 +- .../blink/renderer/core/frame/local_frame_view.cc | 2 +- .../blink/renderer/core/html/custom/README.md | 4 +- .../blink/renderer/core/layout/ng/README.md | 4 +- third_party/blink/renderer/platform/BUILD.gn | 2 +- third_party/blink/renderer/platform/blob/BUILD.gn | 4 +- .../blink/renderer/platform/loader/BUILD.gn | 4 +- .../blink/renderer/platform/loader/README.md | 2 +- .../platform/testing/blink_fuzzer_test_support.h | 2 +- .../renderer/platform/testing/unit_test_helpers.h | 14 +- .../blink/renderer/platform/wtf/stack_util.cc | 2 +- tools/code_coverage/test_suite.txt | 2 +- .../determinism/deterministic_build_whitelist.pyl | 2 +- tools/mb/docs/design_spec.md | 24 +- .../auditor/tests/gn_list_positive.txt | 6 +- 40 files changed, 1370 insertions(+), 1283 deletions(-) commit 29c088b2b5af9090590276b5c9ed0f4bf238a2cd Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Thu Feb 14 07:14:42 2019 +0000 SignedExchange: Close response body data pipe on integrity error This fixes a bug where data pipe for response body was not closed when Signed Exchange has payload integrity error. SourceStreamToDataPipe::OnComplete() attempts to close the pipe by resetting |pending_write_|. But if |source_| is a FilterSourceStream, it still retains a reference to |pending_write_|. We should explicitly call |pending_write_->Complete(0)| to free the pipe on error cases too. Bug: 931955 Change-Id: I63b2470dbb92aa57016c5c71222bcdabe889fd34 Reviewed-on: https://chromium-review.googlesource.com/c/1470355 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#632118} .../browser/loader/source_stream_to_data_pipe.cc | 12 ++++------ .../resources/generate-test-sxgs.sh | 3 +++ .../resources/sxg/sxg-merkle-integrity-error.sxg | Bin 0 -> 999 bytes .../sxg-merkle-integrity-error.tentative.html | 24 +++++++++++++++++++ ...-prefetch-merkle-integrity-error.tentative.html | 26 +++++++++++++++++++++ 5 files changed, 57 insertions(+), 8 deletions(-) commit e6abe439b0e02f37be499c87abd791e00e91df77 Author: Yutaka Hirano <yhirano@chromium.org> Date: Thu Feb 14 07:12:51 2019 +0000 Introduce probe::PrepareRequest Split probe::PrepareRequest from probe::WillSendRequest. - probe::PrepareRequest is called from FetchContext::PrepareRequest. - probe::WillSendRequest does not modify the given request. - probe::WillSendRequest is called from FetchContext::DispatchWillSendRequest. There are some behavior changes. - The call site for FetchContext::PrepareRequest and FetchContext::DispatchWillSendRequest are somewhat distant. For example, now the "disable cache" option in devtools takes effect for MemoryCache as the modification is done in PrepareRequest which precedes ResourceFetcher::DetermineRevalidationPolicy. I updated http/tests/devtools/network/network-memory-cached-resource.js because it is affected by the "disable cache" behavior change. Bug: 924024, 914739, 632580 Change-Id: Ie25dc899b21a0588fac1a52209bd4f8e6ecae5aa Reviewed-on: https://chromium-review.googlesource.com/c/1426250 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#632117} .../core/inspector/inspector_emulation_agent.cc | 4 +- .../core/inspector/inspector_emulation_agent.h | 13 +++--- .../core/inspector/inspector_network_agent.cc | 17 ++++++-- .../core/inspector/inspector_network_agent.h | 7 ++- .../core/inspector/inspector_trace_events.cc | 2 +- .../core/inspector/inspector_trace_events.h | 2 +- .../renderer/core/loader/frame_fetch_context.cc | 9 +++- .../renderer/core/loader/frame_fetch_context.h | 6 ++- .../core/loader/frame_fetch_context_test.cc | 4 +- .../renderer/core/loader/worker_fetch_context.cc | 14 ++++-- .../renderer/core/loader/worker_fetch_context.h | 6 ++- .../blink/renderer/core/probe/core_probes.json5 | 3 +- .../blink/renderer/core/probe/core_probes.pidl | 3 +- .../platform/loader/fetch/fetch_context.cc | 6 ++- .../renderer/platform/loader/fetch/fetch_context.h | 9 ++-- .../platform/loader/fetch/resource_fetcher.cc | 5 ++- .../platform/loader/fetch/resource_loader.cc | 6 ++- .../platform/loader/testing/mock_fetch_context.h | 2 +- .../network-memory-cached-resource-expected.txt | 3 +- .../network/network-memory-cached-resource.js | 50 ++++++++++------------ .../network/resources/memory-cached-resource.html | 10 ++++- 21 files changed, 109 insertions(+), 72 deletions(-) commit da41081f41e8cf7177101b048bbf6958f107099e Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Feb 14 07:04:50 2019 +0000 Import wpt@0db395ed1acb636ab0fa2686944a46d038d073d4 Using wpt-import in Chromium 2cd1482c05e27009ff6a22d7c26a79560977c59b. With Chromium commits locally applied on WPT: 14c111075b "Implement `Sec-CH-Lang`" af3b056c72 "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0b2 "Don't skip past auto-height flexboxes in quirks mode." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ib904b2d5065a6c11713c882c83e9c2729d2b4408 Reviewed-on: https://chromium-review.googlesource.com/c/1472071 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632116} third_party/blink/web_tests/TestExpectations | 1 - .../web_tests/external/WPT_BASE_MANIFEST_5.json | 29 ++++++++++++++++++---- .../screen-orientation/onchange-event-expected.txt | 5 ++++ .../wpt/screen-orientation/onchange-event.html | 8 ++++++ 4 files changed, 37 insertions(+), 6 deletions(-) commit 8c3aeed29ee5998dc4c1f4bc3d0bb2b454e6b556 Author: Shik Chen <shik@chromium.org> Date: Thu Feb 14 06:59:59 2019 +0000 Fix some CSS presubmit warnings. This CL fixes the following warnings: * Pseudo-elements should use double colon (i.e. ::after). * Use "0" for zero-width lengths (i.e. 0px -> 0). * Use rgb() over #hex when not a shade of gray (like #333). There are still 2 warnings not fixed in this CL, which might need extra attention: * Classes use .dash-form. * Use -start/end instead of -left/right (https://goo.gl/gQYY7z, add /* csschecker-disable-line left-right */ to suppress) BUG=b:117810572 TEST=Open CCA and check the UI works. Change-Id: Iefe4f0203a3e8f5da0c103726db0f010a2287632 Reviewed-on: https://chromium-review.googlesource.com/c/1471850 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#632115} .../resources/chromeos/camera/src/css/main.css | 70 +++++++++++----------- 1 file changed, 36 insertions(+), 34 deletions(-) commit ad28299e6083b156bda90c3b9ec2b88d7bf9df6e Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Feb 14 06:59:50 2019 +0000 StaticKCM: Enable sending layout name by default. This CL enables ExoSendKeyboardLayoutName feature by default. By enabling this feature, ARC++ will use a keyboard layout name instead of XKB text configuration sent through wl_keyboard interface. Design doc: go/arc-static-kcm-converter TEST=manual BUG=b:122704772 Change-Id: I2d75ed0a817642ac76ab64592a83a910d3c57734 Reviewed-on: https://chromium-review.googlesource.com/c/1469808 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#632114} components/exo/wayland/zcr_keyboard_configuration.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af32970be02a1acb1f5580235f0bdb5102e2bcb4 Author: David Staessens <dstaessens@chromium.org> Date: Thu Feb 14 06:54:02 2019 +0000 media/gpu/test: Port the VDA thumbnail test to the new video decoder tests. This CL ports the VDA thumbnail tests to the new video decoder tests. The test is ported because some older platforms don't support the new video frame validator, which requires direct access to video frame memory. The test will be deprecated in the future. TEST=ran new VDA tests on nocturne BUG=879065 Change-Id: I3559c242c6576254a219e93df846e3f0ccfce1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1454114 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#632113} media/gpu/BUILD.gn | 1 + media/gpu/test/BUILD.gn | 17 + media/gpu/test/rendering_helper.cc | 65 ++-- media/gpu/test/rendering_helper.h | 25 +- media/gpu/test/video_player/frame_renderer.h | 10 + .../gpu/test/video_player/frame_renderer_dummy.cc | 8 + media/gpu/test/video_player/frame_renderer_dummy.h | 4 + .../test/video_player/frame_renderer_thumbnail.cc | 430 +++++++++++++++++++++ .../test/video_player/frame_renderer_thumbnail.h | 130 +++++++ media/gpu/test/video_player/video.cc | 4 + media/gpu/test/video_player/video.h | 2 + .../gpu/test/video_player/video_decoder_client.cc | 115 ++++-- media/gpu/test/video_player/video_decoder_client.h | 11 + media/gpu/test/video_player/video_player.cc | 15 +- media/gpu/test/video_player/video_player.h | 2 + media/gpu/video_decode_accelerator_tests.cc | 33 +- 16 files changed, 796 insertions(+), 76 deletions(-) commit 31b126468f76d0170217fd35f323519a7d89d4da Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Feb 14 06:50:54 2019 +0000 Revert "Ensure page visibility is consistent after load" This reverts commit 0ac187843169e776734a386e1c2dfb135b644ff5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 631972 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGFjMTg3ODQzMTY5ZTc3NjczNGEzODZlMWMyZGZiMTM1YjY0NGZmNQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/19636 Sample Failed Step: content_browsertests on Intel GPU on Mac on Mac-10.12.6 Sample Flaky Test: WebContentsImplBrowserTest.SetVisibilityBeforeLoad Original change's description: > Ensure page visibility is consistent after load > > Broken case is WebContents::WasHidden is called before the first load > then page visibility remains visible because nothing handles > PageMsg_WasHidden, and nothing rechecks the state after first load. > Note RenderView is invisible due to > EnsureRenderFrameHostVisibilityConsistent. > > A related bug is that in this case RenderView is created to be visible > and then marked visible after. Turns out fixing this will also > correctly set page visibility, so this CL fixes this bug instead. > > Bug: 929860 > Change-Id: I30e5e7d9488eb68299fbb524363d01a9b5b4e558 > Reviewed-on: https://chromium-review.googlesource.com/c/1467641 > Commit-Queue: Bo <boliu@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631972} Change-Id: I22a7639a2e3dd5566eb8532bd258e8e809839069 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 929860 Reviewed-on: https://chromium-review.googlesource.com/c/1472251 Cr-Commit-Position: refs/heads/master@{#632112} content/browser/renderer_host/render_view_host_impl.cc | 3 ++- content/browser/renderer_host/render_widget_host_delegate.h | 1 - .../browser/web_contents/web_contents_impl_browsertest.cc | 13 ------------- 3 files changed, 2 insertions(+), 15 deletions(-) commit cd7dc41289cbcea6439524fea547103cf11d0f79 Author: David Staessens <dstaessens@chromium.org> Date: Thu Feb 14 06:42:56 2019 +0000 media/gpu/test: Fix parameters of the new video decoder tests. The 'enable validator' and 'output frames' parameters have accidentialy been switched in a merge gone wrong. This CL swaps them again. TEST=ran new VDA tests on nocturne BUG=None Change-Id: Ia3cdcf1d951a10a6e5125d178ec0897166b6df07 Reviewed-on: https://chromium-review.googlesource.com/c/1471975 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#632111} media/gpu/video_decode_accelerator_tests.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit aeca9afbbdcd891a13e85c89f926962ac43827b0 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Feb 14 06:41:13 2019 +0000 [Files app] Convert to background/ to arrow func Command used: $ lebab --replace ui/file_manager/file_manager/background/ --transform arrow Bug: 778674 Change-Id: I3f2921761ec516129c345b448f50b26573ebd40e Reviewed-on: https://chromium-review.googlesource.com/c/1469760 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#632110} .../background/js/app_window_wrapper.js | 36 +-- .../file_manager/background/js/app_windows.js | 2 +- .../file_manager/background/js/background.js | 83 +++--- .../file_manager/background/js/background_base.js | 18 +- .../file_manager/background/js/device_handler.js | 64 ++-- .../background/js/device_handler_unittest.js | 36 +-- .../background/js/drive_sync_handler.js | 33 +-- .../file_manager/background/js/duplicate_finder.js | 81 +++-- .../background/js/duplicate_finder_unittest.js | 16 +- .../background/js/file_operation_handler.js | 6 +- .../background/js/file_operation_manager.js | 67 +++-- .../js/file_operation_manager_unittest.js | 113 ++++--- .../background/js/file_operation_util.js | 186 ++++++------ .../file_manager/background/js/import_history.js | 326 ++++++++++----------- .../background/js/import_history_unittest.js | 68 ++--- .../file_manager/background/js/launcher.js | 7 +- .../file_manager/background/js/launcher_search.js | 33 +-- .../background/js/media_import_handler.js | 133 ++++----- .../background/js/media_import_handler_unittest.js | 74 ++--- .../file_manager/background/js/media_scanner.js | 88 +++--- .../background/js/media_scanner_unittest.js | 62 ++-- .../file_manager/background/js/metadata_proxy.js | 6 +- .../background/js/mock_drive_sync_handler.js | 2 +- .../background/js/mock_file_operation_manager.js | 12 +- .../background/js/mock_media_scanner.js | 22 +- .../background/js/mock_progress_center.js | 6 +- .../background/js/mock_volume_manager.js | 21 +- .../file_manager/background/js/progress_center.js | 8 +- .../background/js/runtime_loaded_test_util.js | 82 +++--- .../file_manager/background/js/task_queue.js | 12 +- .../background/js/task_queue_unittest.js | 44 +-- .../background/js/test_import_history.js | 10 +- .../file_manager/background/js/test_util.js | 66 ++--- .../file_manager/background/js/test_util_base.js | 9 +- .../file_manager/background/js/volume_info_impl.js | 2 +- .../background/js/volume_manager_factory.js | 8 +- .../background/js/volume_manager_impl.js | 56 ++-- .../background/js/volume_manager_unittest.js | 26 +- .../background/js/volume_manager_util.js | 22 +- 39 files changed, 961 insertions(+), 985 deletions(-) commit daafea1b1cfbc157a0bb9aa397a6272f346ac40e Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Feb 14 06:29:02 2019 +0000 Close incognito window counter on second click. When incognito toolbar button is clicked for the second time, the incognito window counter dialog is closed. Bug: 931276, 896235 Change-Id: If12ae3885a4e25b068227c6a728f4d642fd804d1 Reviewed-on: https://chromium-review.googlesource.com/c/1469861 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#632109} .../ui/views/profiles/avatar_toolbar_button.cc | 10 +++++++--- .../ui/views/profiles/incognito_window_count_view.cc | 20 ++++++++++++++++++-- .../ui/views/profiles/incognito_window_count_view.h | 4 ++++ 3 files changed, 29 insertions(+), 5 deletions(-) commit ce15683c2816571039f6ae76947820c3379ab746 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Feb 14 06:11:59 2019 +0000 Roll src-internal b2e8aef39554..914e79e33197 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2e8aef39554..914e79e33197 Created with: gclient setdep -r src-internal@914e79e33197 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9e850add2ecf0e35be04c7ac6b6bab428c6cac85 Reviewed-on: https://chromium-review.googlesource.com/c/1471950 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632108} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 921f227d03d096ad160435de86c0435c29b30f10 Author: Alli Murray <alliemurray@google.com> Date: Thu Feb 14 06:07:10 2019 +0000 Add context menu for removable root entry list. - Context menu should appear when right-click on root label. - Command to unmount should be visible in context menu for removable roots and removable USBs. - Partitions in the directory tree should not have an unmount in the context menu. Bug: 918795 Change-Id: I025b1bb7a7cd15ce9610909e98b514f6ccab74e1 Reviewed-on: https://chromium-review.googlesource.com/c/1460201 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#632107} .../file_manager/file_manager_browsertest.cc | 5 +- .../foreground/js/ui/directory_tree.js | 26 ++++--- .../integration_tests/file_manager/context_menu.js | 82 ++++++++++++++++++++++ 3 files changed, 102 insertions(+), 11 deletions(-) commit c826fc153564aa133ee41a27cc221bb64592413a Author: Alexey Baskakov <loyso@chromium.org> Date: Thu Feb 14 06:03:57 2019 +0000 WebApp: Fix HostedAppPWAOnlyTest.InstallInstallableSite browser test. The order of events on Extenion installed: 1) ExtensionRegistryObserver::OnExtensionInstalled 2) CrxInstaller::NotifyCrxInstallComplete: NOTIFICATION_CRX_INSTALLER_DONE 3) CrxInstaller::set_installer_callback fires. 4) web_app::InstallManager::OnceInstallCallback fires. Previously the test used WaitForExtensionInstalled() which is a blocking wrapper for (1) plus flushing for all messages. The test waited for (1) while the real install completes after (2). It was working by accident: The extra message in a queue delayed the return from WaitForExtensionInstalled function. Solution: subscribe the test for the callback (4) and wait for the full completetion of the installation process. Stack traces: https://pastebin.com/wLi6RndL Bug: 915043 Change-Id: I879d5260546a7d762e12588cd76063357389c72d Reviewed-on: https://chromium-review.googlesource.com/c/1470352 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#632106} .../ui/extensions/hosted_app_browsertest.cc | 29 ++++++++++++++++++---- .../ui/web_applications/web_app_dialog_utils.cc | 19 +++++++++++++- .../ui/web_applications/web_app_dialog_utils.h | 9 +++++++ 3 files changed, 51 insertions(+), 6 deletions(-) commit 9dcccc3bd6f94207383a6d396eb0d43c30e244a7 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Feb 14 06:02:56 2019 +0000 [Files app] Fix background/ closure markup This are fixes required once functions are converted to arrow functions. After converting closure can infer the "this" and thus checks more types. Fix externs/file_manager_private.js that were failing by copying from the auto-generated externs. Remove @this {...} where closure compiler complained. Add some casts to comply with the signature of function being called. Bug: 778674 Change-Id: I2e230692249a3952e1c3c37d957dbced10c676d7 Reviewed-on: https://chromium-review.googlesource.com/c/1472010 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#632105} .../externs/file_manager_private.js | 7 ++++--- ui/file_manager/externs/app_window_common.js | 5 +++++ .../background/js/app_window_wrapper.js | 4 +++- .../file_manager/background/js/background.js | 2 +- .../file_manager/background/js/device_handler.js | 2 -- .../background/js/file_operation_util.js | 4 ++-- .../file_manager/background/js/import_history.js | 22 +++++----------------- .../background/js/media_import_handler.js | 7 ++----- .../file_manager/background/js/media_scanner.js | 9 ++------- .../background/js/runtime_loaded_test_util.js | 4 ++-- .../file_manager/background/js/task_queue.js | 2 +- .../background/js/volume_manager_impl.js | 4 +++- 12 files changed, 30 insertions(+), 42 deletions(-) commit 882c4cec83207b0577bf862d5b0949ed0b6d0e6c Author: Thomas Guilbert <tguilbert@chromium.org> Date: Thu Feb 14 05:55:45 2019 +0000 Remove MediaWebContentsObserverAndroid With the removal of MediaPlayerManager and MediaPlayerAndroid, SuspendAllMediaPlayers is the only method left in MediaWebContentsObserverAndroid. This CL moves the method into its parent class, and deletes MWCOA. Bug: 790766, 926595 Change-Id: I5c98509729afbdfe4c6a06a74f26046b6afc1eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1471306 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#632104} content/browser/BUILD.gn | 2 - .../android/media_web_contents_observer_android.cc | 43 --------------------- .../android/media_web_contents_observer_android.h | 45 ---------------------- .../browser/media/media_web_contents_observer.cc | 15 ++++++++ .../browser/media/media_web_contents_observer.h | 8 ++++ .../render_widget_host_view_android.cc | 1 - .../browser/web_contents/web_contents_android.cc | 5 +-- content/browser/web_contents/web_contents_impl.cc | 8 +--- 8 files changed, 27 insertions(+), 100 deletions(-) commit 9a6a755ce41c3f78857adb5a46f77276617ff0ca Author: Alexey Baskakov <loyso@chromium.org> Date: Thu Feb 14 05:55:05 2019 +0000 WebApp: SetLaunchType and SetBookmarkAppIsLocallyInstalled flags. This change copies the behavior from BookmarkAppHelper::FinishInstallation. This is covered in HostedAppPWAOnlyTest tests. BookmarkAppInstallFinalizer is disabled for now. The testing and launching plan is: When BookmarkAppInstallFinalizer becomes feature complete, convert all BookmarkAppHelper tests and do the switching CL. Bug: 915043 Change-Id: Ib3610a275f9cdb43d2efd25f1ac0545434e8a9bb Reviewed-on: https://chromium-review.googlesource.com/c/1466223 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#632103} .../extensions/bookmark_app_install_finalizer.cc | 46 ++++++++++++++++------ .../extensions/bookmark_app_install_finalizer.h | 7 ++-- 2 files changed, 38 insertions(+), 15 deletions(-) commit fb30d694ac3b70573250e5a020b08f45f4a9b1b2 Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Feb 14 05:53:12 2019 +0000 Update incognito window counter menu's icon color. The color of incognito window counter menu's icon is changed from theme provided NTP background to default NTP background. Bug: 896235 Change-Id: I3ca3f4cf4ef81c5dd54c42ca41f1435df9139f6c Reviewed-on: https://chromium-review.googlesource.com/c/1470152 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#632102} chrome/browser/ui/views/profiles/incognito_window_count_view.cc | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit 1119765dd86709dee8d32caaf7102b8c714560b3 Author: Tomas Popela <tomas.popela@gmail.com> Date: Thu Feb 14 05:49:30 2019 +0000 Remove a temporary CFI blacklist entry It's not needed anymore as the code was successfully moved to the linux folder. Bug: 682122 Change-Id: I0fcb73b960ae8fcd09af8ad2b4a42d6ded133c0c Reviewed-on: https://chromium-review.googlesource.com/c/1466403 Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#632101} tools/cfi/blacklist.txt | 3 --- 1 file changed, 3 deletions(-) commit 16d308d5a1c48842087592e53a631e2e5b3ce7cd Author: Tomas Popela <tomas.popela@gmail.com> Date: Thu Feb 14 05:43:49 2019 +0000 Add PipeWire to the CFI blacklist Add the WebRTC's PipeWire sources to the CFI blacklist as well as the SPA (PipeWire sublibrary) includes. Without these blacklist entries any call to the PipeWire will end with SIGILL crash similar to: /usr/include/spa/param/format-utils.h:50:17: runtime error: control flow integrity check for type 'unsigned int (struct spa_type_map *, const char *)' failed during indirect function call The cause is that the -fsanitize=cfi doesn't work when calling into functions of a dlopen'ed shared library file without using -fsanitize-cfi-cross-dso or adding the entries to the CFI blacklist. Bug: 926115 Change-Id: Ied4d489b3e5b1bee5dfd0374417ab8cd40dcdbd6 Reviewed-on: https://chromium-review.googlesource.com/c/1466402 Reviewed-by: Peter Collingbourne <pcc@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#632100} tools/cfi/blacklist.txt | 5 +++++ 1 file changed, 5 insertions(+) commit e3538d46b9a8b0f303574ff7947a2f7b74233244 Author: rbpotter <rbpotter@chromium.org> Date: Thu Feb 14 05:42:31 2019 +0000 Print Preview: Pages and scaling section behavior adjustments Per UX feedback making Scaling and Pages sections behave the same way: - scaling custom input is automatically focused when custom is selected - pages is automatically populated with the default "1-N" value, if the field is blurred while empty. Also addressing attached bug - if user clears a valid input and then selects "All" pages and then returns to "Custom", their previous valid input should not be restored. Bug: 931152 Change-Id: I137969b46f18eee33f5a95bedd82a0dbe61a12b4 Reviewed-on: https://chromium-review.googlesource.com/c/1469291 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#632099} .../resources/print_preview/new/pages_settings.js | 36 +++++++++++++---- .../print_preview/new/scaling_settings.html | 3 +- .../print_preview/new/scaling_settings.js | 7 ++++ .../webui/print_preview/pages_settings_test.js | 46 +++++++++++++++++----- 4 files changed, 74 insertions(+), 18 deletions(-) commit 6d39cbd3c5d0eea92e5d08709ff07ba59cc5605c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Feb 14 05:42:28 2019 +0000 Roll src/third_party/skia e77142e0d665..4037f7f5d8b4 (2 commits) https://skia.googlesource.com/skia.git/+log/e77142e0d665..4037f7f5d8b4 git log e77142e0d665..4037f7f5d8b4 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6fc22a13d45d..52047de4d41f (3 commits) 2019-02-14 reed@google.com remove unused variable Created with: gclient setdep -r src/third_party/skia@4037f7f5d8b4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I18f502e14d46d30a3df488c480d05b71af21bf53 Reviewed-on: https://chromium-review.googlesource.com/c/1471952 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632098} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd4e3badd65fb32b1a0e164d5a5e83114d2cec2e Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Feb 14 05:38:29 2019 +0000 Update V8 to version 7.4.166. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9c2fa40d..d34a141d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I20a05f3160b624435635b925ca52c1bde21907a3 Reviewed-on: https://chromium-review.googlesource.com/c/1471465 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632097} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9882cc185d0a78ae258b3ac39df15a2663da0df0 Author: Alli Murray <alliemurray@google.com> Date: Thu Feb 14 05:30:35 2019 +0000 Merge unmount command for removable roots and unpartitioned removable devices. The refactor removes the need to use two separate unmount commands, with no behavior changes. Change-Id: Ib4f80935e60fb012b43ccb60fa1aecbf2f0aa080 Reviewed-on: https://chromium-review.googlesource.com/c/1468853 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#632096} .../foreground/js/file_manager_commands.js | 113 ++++++++------------- .../foreground/js/ui/directory_tree.js | 11 +- ui/file_manager/file_manager/main.html | 2 - 3 files changed, 47 insertions(+), 79 deletions(-) commit a86d1d1dbed1134bc85a44f35bdf92a49d7ef926 Author: Lei Zhang <thestig@chromium.org> Date: Thu Feb 14 05:30:15 2019 +0000 Roll src/third_party/pdfium/ 83a2cd097..e6fcdfa5b (1 commit) https://pdfium.googlesource.com/pdfium.git/+log/83a2cd097544..e6fcdfa5bb6e Update caller to the modified public API. TBR=tsepez@chromium.org Change-Id: I214a7e5b605fb76fe07e40862ca7e3bd99ac896a Reviewed-on: https://chromium-review.googlesource.com/c/1472030 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#632095} DEPS | 2 +- pdf/pdfium/pdfium_engine.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit dad30a4f847a1fd00d0a13ce8f1aef12dfb0d651 Author: John Chen <johnchen@chromium.org> Date: Thu Feb 14 05:26:27 2019 +0000 Revert "Rename some blink-related build targets" This reverts commit 2cd1482c05e27009ff6a22d7c26a79560977c59b. Reason for revert: Causing all builds to fail on Builder android_arm64-builder-perf (https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android_arm64-builder-perf) Original change's description: > Rename some blink-related build targets > > * webkit_unit_tests -> blink_unittests > * run_webkit_tests -> run_web_tests > * webkit_layout_tests -> blink_web_tests > * webkit_layout_tests_exparchive -> blink_web_tests_exparchive > * webkit_python_tests -> blink_python_tests > Rename testing/scripts/webkit_python_tests.py to > blink_python_tests.py > * webkit_lint -> blink_lint_expectations > Rename testing/scripts/webkit_lint.py to blink_lint_expectations.py > > NOTRY=true > > Bug: 914213 > Change-Id: I4dbb92a2593a36c5ae5ead1d38960ffdeb518010 > Reviewed-on: https://chromium-review.googlesource.com/c/1379626 > Commit-Queue: Kent Tamura <tkent@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632083} TBR=kinuko@chromium.org,thakis@chromium.org,tkent@chromium.org,martiniss@chromium.org Change-Id: I9e20e183e6d589fda5be55c101997ddd3ff0eacc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914213, 931992 Reviewed-on: https://chromium-review.googlesource.com/c/1471636 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#632094} BUILD.gn | 26 +- build/android/pylib/gtest/gtest_config.py | 2 +- build/config/compiler/BUILD.gn | 2 +- content/public/test/blink_test_environment.h | 2 +- testing/buildbot/chromium.android.fyi.json | 93 ++-- testing/buildbot/chromium.android.json | 606 ++++++++++----------- testing/buildbot/chromium.chromiumos.json | 26 +- testing/buildbot/chromium.clang.json | 571 +++++++++---------- testing/buildbot/chromium.fyi.json | 264 +++++---- testing/buildbot/chromium.gpu.json | 4 +- testing/buildbot/chromium.linux.json | 162 +++--- testing/buildbot/chromium.mac.json | 219 ++++---- testing/buildbot/chromium.memory.json | 271 +++++---- testing/buildbot/chromium.webkit.json | 10 +- testing/buildbot/chromium.win.json | 159 +++--- testing/buildbot/gn_isolate_map.pyl | 66 +-- testing/buildbot/test_suites.pyl | 25 +- testing/buildbot/tryserver.chromium.android.json | 5 +- testing/buildbot/tryserver.chromium.linux.json | 17 +- testing/buildbot/tryserver.webrtc.json | 16 +- testing/buildbot/waterfalls.pyl | 8 +- .../{blink_lint_expectations.py => webkit_lint.py} | 0 ...link_python_tests.py => webkit_python_tests.py} | 0 third_party/blink/public/BUILD.gn | 2 +- third_party/blink/renderer/controller/BUILD.gn | 10 +- .../renderer/core/editing/inline_box_position.h | 2 +- .../blink/renderer/core/frame/local_frame_view.cc | 2 +- .../blink/renderer/core/html/custom/README.md | 4 +- .../blink/renderer/core/layout/ng/README.md | 4 +- third_party/blink/renderer/platform/BUILD.gn | 2 +- third_party/blink/renderer/platform/blob/BUILD.gn | 4 +- .../blink/renderer/platform/loader/BUILD.gn | 4 +- .../blink/renderer/platform/loader/README.md | 2 +- .../platform/testing/blink_fuzzer_test_support.h | 2 +- .../renderer/platform/testing/unit_test_helpers.h | 14 +- .../blink/renderer/platform/wtf/stack_util.cc | 2 +- tools/code_coverage/test_suite.txt | 2 +- .../determinism/deterministic_build_whitelist.pyl | 2 +- tools/mb/docs/design_spec.md | 24 +- .../auditor/tests/gn_list_positive.txt | 6 +- 40 files changed, 1282 insertions(+), 1360 deletions(-) commit 1ba5f9c85171195510096503453065a451d83d7c Author: kylechar <kylechar@chromium.org> Date: Thu Feb 14 05:18:06 2019 +0000 Modify GLOutputSurface for Chrome OS. 1. Add SwapWithBounds() to GLOutputSurface. This was missing and is only used with cast. 2. Tidy comments and TODOs. 3. Add GLOutputSurfaceOzon::eGetCompositorOverlayValidator(). No implementation yet but I needed somewhere to put a TODO. Bug: 930173 Change-Id: I78d6a9d497a25ad5dee01d344a165052b104d0ad Reviewed-on: https://chromium-review.googlesource.com/c/1471290 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#632093} components/viz/service/display_embedder/gl_output_surface.cc | 7 ++++++- .../service/display_embedder/gl_output_surface_buffer_queue.cc | 9 +++------ .../viz/service/display_embedder/gl_output_surface_ozone.cc | 8 +++++++- .../viz/service/display_embedder/gl_output_surface_ozone.h | 3 +++ 4 files changed, 19 insertions(+), 8 deletions(-) commit 49d224ac7aa8cd5218310bb6744c808c47e78a48 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Feb 14 05:16:10 2019 +0000 Roll src/third_party/dawn 1809ff74233d..b2207737abd3 (3 commits) https://dawn.googlesource.com/dawn.git/+log/1809ff74233d..b2207737abd3 git log 1809ff74233d..b2207737abd3 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 yunchao.he@intel.com Construct VertexAttributeDescriptor, in order to match web idl 2019-02-13 cwallez@chromium.org Fix extra semicolon in DAWN_UNUSED_FUNC 2019-02-13 enga@chromium.org Add Buffer Destroyed state and validation tests Created with: gclient setdep -r src/third_party/dawn@b2207737abd3 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5ec50a326afde1425b3d93135c05d06872cd8dcf Reviewed-on: https://chromium-review.googlesource.com/c/1471951 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632092} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2756b5d890e79bcfb604cc76b1ac45178373777a Author: git config --global <monufriienko@chromium.org> Date: Thu Feb 14 05:15:09 2019 +0000 Added extra logging in SimulatorTestRunner#tear_down and SimulatorParallelTestRunner#launch. It is not clear why tests that run for ~5-9 mins timed out. Seems that runner is hung after tests are done, maybe in tear_down method. Adder Timer-thread to kill test running process if no output happens during last 5 mins. Bug: 898549 Change-Id: Id93d9dd93fab93871aac17c0dd39bd6ecf6d13ca Reviewed-on: https://chromium-review.googlesource.com/c/1464334 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632091} ios/build/bots/scripts/test_runner.py | 7 +++++++ ios/build/bots/scripts/xcodebuild_runner.py | 31 ++++++++++++++++++++++++++++- 2 files changed, 37 insertions(+), 1 deletion(-) commit 61603999c0924c0357625fbdad6039696ad87e38 Author: Cecilia Ni <ceciliani@google.com> Date: Thu Feb 14 05:14:11 2019 +0000 [App Management] Add router test and fix router This CL fixes router so that the application directs to the right page when receiving a direct url input, and adds router test by testing the store responds to url change and the other way around. Bug: 906508 Change-Id: I66aa950be039faca2378ba48417db28be3ae2681 Reviewed-on: https://chromium-review.googlesource.com/c/1466165 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#632090} chrome/browser/resources/app_management/router.js | 6 ++ .../app_management/app_management_browsertest.js | 16 ++++ .../data/webui/app_management/main_view_test.js | 6 +- .../webui/app_management/metadata_view_test.js | 6 +- .../app_management/pwa_permission_view_test.js | 8 +- .../data/webui/app_management/reducers_test.js | 1 + .../test/data/webui/app_management/router_test.js | 87 ++++++++++++++++++++++ .../test/data/webui/app_management/test_store.js | 19 +++++ chrome/test/data/webui/app_management/test_util.js | 22 ++++++ 9 files changed, 158 insertions(+), 13 deletions(-) commit 94f51eb6721f6e31f8b313e016070e3c9be3a55d Author: Nigel Tao <nigeltao@chromium.org> Date: Thu Feb 14 05:07:31 2019 +0000 Add placeholder icons to the App Service See chrome/services/app_service/README.md for the rationale BUG=826982 Change-Id: I99b7ba88d4638739ff920a800d414ebab2f59c29 Reviewed-on: https://chromium-review.googlesource.com/c/1460595 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#632089} .../browser/apps/app_service/app_icon_factory.cc | 34 ++++++++++++----- chrome/browser/apps/app_service/app_icon_factory.h | 1 + chrome/browser/apps/app_service/app_icon_source.cc | 3 +- .../browser/apps/app_service/app_service_proxy.cc | 10 +++-- .../browser/apps/app_service/app_service_proxy.h | 1 + chrome/browser/apps/app_service/arc_apps.cc | 20 ++++++++-- chrome/browser/apps/app_service/arc_apps.h | 5 ++- .../apps/app_service/built_in_chromeos_apps.cc | 5 ++- .../apps/app_service/built_in_chromeos_apps.h | 4 +- chrome/browser/apps/app_service/crostini_apps.cc | 27 ++++++++++--- chrome/browser/apps/app_service/crostini_apps.h | 7 +++- chrome/browser/apps/app_service/extension_apps.cc | 4 +- chrome/browser/apps/app_service/extension_apps.h | 4 +- chrome/browser/ui/app_list/app_service_app_item.cc | 26 +++++++++---- chrome/browser/ui/app_list/app_service_app_item.h | 2 + .../ui/app_list/search/app_service_app_result.cc | 7 ++++ chrome/services/app_service/README.md | 44 +++++++++++++++++++--- chrome/services/app_service/app_service_impl.cc | 7 ++-- chrome/services/app_service/app_service_impl.h | 2 +- .../app_service/app_service_impl_unittest.cc | 26 +++++++------ .../app_service/public/mojom/app_service.mojom | 8 ++-- .../services/app_service/public/mojom/types.mojom | 1 + 22 files changed, 180 insertions(+), 68 deletions(-) commit 8b5320810c1ab133f856f3ac9d9dea3835f31322 Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Thu Feb 14 05:02:17 2019 +0000 [remoting] Remove unused GetDefaultOauthRedirectUrl() This removes unused code relating to a default redirect URI which is a TalkGadget URL. This changes OAuthTokenGetterImpl::GetOauthTokensFromAuthCode() to DCHECK if a redirect-URI is not provided by the caller. This code was only exercised if |intermediate_credentials_| is non-null (it is an OAuth one-time-use code). This parameter is provided in one of the OAuthTokenGetterImpl ctors. The only caller of this ctor is remoting/ios/facade/remoting_oauth_authentication.mm which does provide a redirect-URI. So the code-path being removed here is unused. Note that the start_host tool exchanges a one-time-use code for OAuth tokens, but it does not use OAuthTokenGetterImpl here - it uses GaiaOAuthClient: :GetTokensFromAuthCode() instead. Change-Id: Ie753b7aaebdc9417289a38ec80d24d41b0288926 Reviewed-on: https://chromium-review.googlesource.com/c/1471490 Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#632088} remoting/base/oauth_helper.cc | 5 ----- remoting/base/oauth_helper.h | 3 --- remoting/base/oauth_token_getter_impl.cc | 14 ++++---------- 3 files changed, 4 insertions(+), 18 deletions(-) commit 301f4f02273eb9bb0e127afe5731c605bdf29d29 Author: Simon Que <sque@google.com> Date: Thu Feb 14 04:59:30 2019 +0000 mb: Use minimal symbols bot for Windows Goma RBE Just like for existing Windows builders. This is to prevent the bot from hanging when trying to handle a large amount of symbol info when linking at the end of the compile stage. R=dpranke@chromium.org, jbudorick@chromium.org, shinyak@chromium.org, tikuta@chromium.org, ukai@chromium.org, yyanagisawa@chromium.org Bug: 922354 Change-Id: I2af3431ef990adbb0b9512141360aacf8c9c8871 Reviewed-on: https://chromium-review.googlesource.com/c/1468850 Auto-Submit: Simon Que <sque@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#632087} tools/mb/mb_config.pyl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 31edc4a16430851651e89bd070e26c7bef394d2b Author: Tanmoy Mollik <triploblastic@google.com> Date: Thu Feb 14 04:56:29 2019 +0000 Adding some nits that i forgot to add during last merge Bug: 918940 Change-Id: I8f4786cf3dda70ba47898b18085372fb64f4a053 Reviewed-on: https://chromium-review.googlesource.com/c/1470239 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#632086} .../platform/loader/fetch/source_keyed_cached_metadata_handler.cc | 1 - 1 file changed, 1 deletion(-) Updated tag 'tree_truth' (was f98a75c2e1ff)