Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/kitchen-workdir: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 46346 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: em1 INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LANG: en_US.UTF-8 LANGUAGE: en_US: LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8921479188732487744 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGICAL: em1 LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itw_fn8U/luci_context.548799938 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot METHOD: dhcp NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games PWD: /b/s/w/ir PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 2 SWARMING_BOT_ID: build3-b9 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43089f2484469311 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t UPSTART_EVENTS: local-filesystems net-device-up UPSTART_INSTANCE: UPSTART_JOB: swarming USER: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython XDG_RUNTIME_DIR: /run/user/1000 XDG_SESSION_ID: c1 _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 8153dbad507e254626a00297a9e094cdbb246833 Enable TestOpenPopupDoesNotCloseOtherPopups test. Sven Zheng, Fri Feb 15 05:40:04 2019 +0000 7dbb072e96f6e91a2133b852176c4c558a3447f1 Add EnableFilesystemInIncognito feature and flag. Ramin Halavati, Fri Feb 15 05:33:49 2019 +0000 2e1b66263856f045a7906796cadd4c1dcac98cca BlinkMemoryMgt: Apply the macros of Allocator into the classes of renderer/core/frame Gyuyoung Kim, Fri Feb 15 05:32:39 2019 +0000 60edb90b484e6597f61d70abbbac480a3bb47f01 SystenTray: Not update fake corners when invisible Tetsui Ohkubo, Fri Feb 15 05:29:29 2019 +0000 e376ea3bee3b7d4d7716df0afccf69dbffbd17fa Roll src/third_party/angle 4b6549824faa..559aaca5abd8 (1 commits) chromium-autoroll, Fri Feb 15 05:12:18 2019 +0000 2be103e56b1e36c4a2f4255f7f0470a5c83b61b0 Fix inconsistency between enums.xml and code for ActiveWindowShowType. Eliot Courtney, Fri Feb 15 05:08:18 2019 +0000 3cf9006bbe0bc4a7b548c60069a7b622224eb7b2 Use a per-frame task runner at SharedWorkerClientHolder's mojo binding Hajime Hoshi, Fri Feb 15 05:06:38 2019 +0000 e7cb40987180a2406a6cb483ac1bd2b5db0e7c08 Roll src/third_party/swiftshader de16f327d051..2bb0864b22e7 (1 commits) chromium-autoroll, Fri Feb 15 04:54:44 2019 +0000 0f8dadc571fb5f39b491eb59cbbd83cf037a36ea Roll src/native_client ff15c51d2078..908d9f47b1b2 (11 commits) chromium-autoroll, Fri Feb 15 04:41:20 2019 +0000 825c963b7d3b05ec082abf4f674b62462b253cb6 [App Management] Extracting common elements in main view and notification view to a new element. Cecilia Ni, Fri Feb 15 04:34:10 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 8153dbad507e254626a00297a9e094cdbb246833 Author: Sven Zheng <svenzheng@google.com> Date: Fri Feb 15 05:40:04 2019 +0000 Enable TestOpenPopupDoesNotCloseOtherPopups test. Tested locally and with trybot, the test is not flaky anymore(100/100 pass). Bug: 309749 Change-Id: I033afe2cf6ad517365728924ac84de8255de0a95 Reviewed-on: https://chromium-review.googlesource.com/c/1460100 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#632513} .../api/extension_action/browser_action_interactive_test.cc | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) commit 7dbb072e96f6e91a2133b852176c4c558a3447f1 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Feb 15 05:33:49 2019 +0000 Add EnableFilesystemInIncognito feature and flag. EnableFilesystemInIncognito feature and flag are added to control activation of in-memory filesystem api for incognito mode. Bug: 93417 Change-Id: I7002ff23afd0d1ceacf29be3b01ce6f2cd09410c Reviewed-on: https://chromium-review.googlesource.com/c/1472290 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#632512} chrome/browser/about_flags.cc | 6 ++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 4 ++++ chrome/browser/flag_descriptions.h | 3 +++ storage/browser/BUILD.gn | 2 ++ storage/browser/fileapi/file_system_features.cc | 16 ++++++++++++++++ storage/browser/fileapi/file_system_features.h | 22 ++++++++++++++++++++++ tools/metrics/histograms/enums.xml | 3 +++ 8 files changed, 61 insertions(+) commit 2e1b66263856f045a7906796cadd4c1dcac98cca Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Feb 15 05:32:39 2019 +0000 BlinkMemoryMgt: Apply the macros of Allocator into the classes of renderer/core/frame The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/core/frame have not yet been allocated with them so far. After some analyzes, it was concluded that for the case of LayerTreeViewFactory, it makes sense to use DISALLOW_NEW because it's used by another class as a member variable without any smart pointer type. In WebViewHelper, FullscreenController, and OpenedFrameTracker cases, they makes sense to use USING_FALST_MALLOC because they are used by other classes as a member variable with a smart pointer type. In DisallowLayoutInvalidationScope, ScopedUkmHierarchicalTimer cases, they makes sense to use STACK_ALLOCATED because they were only used by function inside. Bug: 919389 Change-Id: Ic7a3d5670eeefbc7b6dc5a2d1056084b804a1b31 Reviewed-on: https://chromium-review.googlesource.com/c/1475131 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#632511} third_party/blink/renderer/core/frame/frame_test_helpers.h | 5 +++++ third_party/blink/renderer/core/frame/fullscreen_controller.h | 3 +++ third_party/blink/renderer/core/frame/local_frame_ukm_aggregator.h | 3 +++ third_party/blink/renderer/core/frame/local_frame_view.h | 3 +++ third_party/blink/renderer/core/frame/opened_frame_tracker.h | 3 +++ 5 files changed, 17 insertions(+) commit 60edb90b484e6597f61d70abbbac480a3bb47f01 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Feb 15 05:29:29 2019 +0000 SystenTray: Not update fake corners when invisible After https://crrev.com/c/1457885, SystemTray started to show invalid white corners on lock screen (http://screen/gYQaw7o5GXF). This CL fixes that. Also it limits height of rect that is making fake corners, so that it doesn't break when the bubble is fading out. TEST=manual BUG=931602 Change-Id: Iaef245d91ea20bcba834d13eea1109b890c591ff Reviewed-on: https://chromium-review.googlesource.com/c/1469847 Reviewed-by: Manu Cornet <manucornet@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#632510} ash/system/message_center/unified_message_center_view.cc | 3 +++ ash/system/unified/unified_system_tray_view.cc | 1 + 2 files changed, 4 insertions(+) commit e376ea3bee3b7d4d7716df0afccf69dbffbd17fa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 05:12:18 2019 +0000 Roll src/third_party/angle 4b6549824faa..559aaca5abd8 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/4b6549824faa..559aaca5abd8 git log 4b6549824faa..559aaca5abd8 --date=short --no-merges --format='%ad %ae %s' 2019-02-15 ynovikov@chromium.org Fix texture and buffer data bugs in tests found by ASAN. Created with: gclient setdep -r src/third_party/angle@559aaca5abd8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I29530355bad3838b78ad2b3d41f7dc55a91235fe Reviewed-on: https://chromium-review.googlesource.com/c/1475167 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632509} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2be103e56b1e36c4a2f4255f7f0470a5c83b61b0 Author: Eliot Courtney <edcourtney@google.com> Date: Fri Feb 15 05:08:18 2019 +0000 Fix inconsistency between enums.xml and code for ActiveWindowShowType. Bug: 929531 Test: compiles Change-Id: I3ff08b7e72936493d6bf52a56ecf5d5a057975b7 Reviewed-on: https://chromium-review.googlesource.com/c/1457877 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#632508} tools/metrics/histograms/enums.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 3cf9006bbe0bc4a7b548c60069a7b622224eb7b2 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Feb 15 05:06:38 2019 +0000 Use a per-frame task runner at SharedWorkerClientHolder's mojo binding This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. The actual test that executes JavaScript on the task runner is: virtual/omt-worker-fetch/external/wpt/workers/semantics/run-a-worker/003.html Bug: 913912 Change-Id: Idd901cd95b80ace2fdf83631c148839ebf27116f Reviewed-on: https://chromium-review.googlesource.com/c/1449445 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#632507} .../blink/renderer/core/workers/shared_worker_client_holder.cc | 9 ++++++--- .../blink/renderer/core/workers/shared_worker_client_holder.h | 2 ++ 2 files changed, 8 insertions(+), 3 deletions(-) commit e7cb40987180a2406a6cb483ac1bd2b5db0e7c08 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 04:54:44 2019 +0000 Roll src/third_party/swiftshader de16f327d051..2bb0864b22e7 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/de16f327d051..2bb0864b22e7 git log de16f327d051..2bb0864b22e7 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 hliatis@google.com Allow creation of VkInstances that support Xlib surfaces Created with: gclient setdep -r src/third_party/swiftshader@2bb0864b22e7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/124265819 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie83a0c481fc61c65ed5fb6aeef59ccbfddbf6916 Reviewed-on: https://chromium-review.googlesource.com/c/1474554 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632506} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0f8dadc571fb5f39b491eb59cbbd83cf037a36ea Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 04:41:20 2019 +0000 Roll src/native_client ff15c51d2078..908d9f47b1b2 (11 commits) https://chromium.googlesource.com/native_client/src/native_client.git/+log/ff15c51d2078..908d9f47b1b2 git log ff15c51d2078..908d9f47b1b2 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 thakis@chromium.org Update revision for PNaCl 2019-02-14 thakis@chromium.org win toolchain build: Use mingw zip that doesn't include git. 2019-02-08 dschuff@chromium.org No-op commit to test recipe change 2019-01-24 thakis@chromium.org Update revision for PNaCl 2019-01-24 dschuff@chromium.org Whitespace change to command.py 2019-01-23 thakis@chromium.org comment change to trigger bots 2019-01-22 thakis@chromium.org Add even more debug logging. 2019-01-18 thakis@chromium.org Add some more logging. 2019-01-18 thakis@chromium.org Add some debug logging. 2019-01-18 dschuff@chromium.org Update CQ config to use only toolchain trybots when appropriate 2019-01-16 dschuff@chromium.org Update revision for PNaCl Created with: gclient setdep -r src/native_client@908d9f47b1b2 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:923062,chromium:923062,chromium:None,chromium:923062,chromium:None,chromium:923062,chromium:923062,chromium:923062,chromium:<none>,chromium:none TBR=mseaborn@chromium.org Change-Id: I9efc028e3b8b56ca2fd53d5f9c8ebb17f0f68ee4 Reviewed-on: https://chromium-review.googlesource.com/c/1475163 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632505} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 825c963b7d3b05ec082abf4f674b62462b253cb6 Author: Cecilia Ni <ceciliani@google.com> Date: Fri Feb 15 04:34:10 2019 +0000 [App Management] Extracting common elements in main view and notification view to a new element. This CL extracts the common elements in notification and main view, a expandable app list, to a new element called expandable_app_list. Bug: 906508 Change-Id: I28530b5c047f21dfa3910290d7804588d9f0360a Reviewed-on: https://chromium-review.googlesource.com/c/1447393 Commit-Queue: Cecilia Ni <ceciliani@google.com> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#632504} chrome/browser/browser_resources.grd | 2 + chrome/browser/resources/app_management/BUILD.gn | 8 ++ .../app_management/expandable_app_list.html | 85 +++++++++++++++++ .../app_management/expandable_app_list.js | 101 +++++++++++++++++++++ .../resources/app_management/main_view.html | 67 ++------------ .../browser/resources/app_management/main_view.js | 45 --------- .../app_management/notifications_view.html | 48 +--------- .../resources/app_management/notifications_view.js | 29 ------ .../resources/app_management/shared_style.html | 1 + .../ui/webui/app_management/app_management_ui.cc | 4 + .../data/webui/app_management/main_view_test.js | 26 ++++-- 11 files changed, 232 insertions(+), 184 deletions(-) commit d9f4acd4c214690dea5371715a762b094a473783 Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Feb 15 04:23:49 2019 +0000 DevTools: fix assorted binary protocol issues - pass binary flag to tracing handler and convert trace to binary format when binary protocol is used; - properly indicate bianry protocol in TargetHandler; - restore binary protocol flag in blink when navigating. BUG=929862 Change-Id: I1cb2d9ab14f259fdd95433b0d7b337050213fd0f Reviewed-on: https://chromium-review.googlesource.com/c/1475110 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#632503} .../devtools/browser_devtools_agent_host.cc | 4 +-- content/browser/devtools/devtools_session.cc | 4 +-- .../browser/devtools/protocol/target_handler.cc | 5 ++++ .../browser/devtools/protocol/tracing_handler.cc | 11 +++++-- .../browser/devtools/protocol/tracing_handler.h | 4 ++- .../devtools/protocol/tracing_handler_unittest.cc | 2 +- .../devtools/render_frame_devtools_agent_host.cc | 3 +- .../renderer/core/inspector/devtools_session.cc | 34 +++++++++++++--------- .../renderer/core/inspector/devtools_session.h | 2 +- 9 files changed, 46 insertions(+), 23 deletions(-) commit 6d81063630d5b9dbfde359321a39bdc223ef9790 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Fri Feb 15 04:18:48 2019 +0000 Make blink::Script pointers around execution non-const When V8 Code Cache is produced for a blink::ModuleScript, [1] will modify blink::ModuleScript to mark it as V8-code-cache-already-produced, to prevent duplicated code cache production. This CL marks blink::Script around script-execution-related methods non-const, to allow the modification. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1237715 Bug: 841466 Change-Id: I1e2fbf1bb2868141c0550aafa14f4a10b6334e7f Reviewed-on: https://chromium-review.googlesource.com/c/1475111 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#632502} third_party/blink/renderer/core/script/classic_script.cc | 2 +- third_party/blink/renderer/core/script/classic_script.h | 2 +- third_party/blink/renderer/core/script/dynamic_module_resolver_test.cc | 2 +- third_party/blink/renderer/core/script/modulator.h | 3 +-- third_party/blink/renderer/core/script/modulator_impl_base.cc | 2 +- third_party/blink/renderer/core/script/modulator_impl_base.h | 2 +- third_party/blink/renderer/core/script/module_script.cc | 2 +- third_party/blink/renderer/core/script/module_script.h | 2 +- third_party/blink/renderer/core/script/script.h | 2 +- third_party/blink/renderer/core/testing/dummy_modulator.cc | 3 +-- third_party/blink/renderer/core/testing/dummy_modulator.h | 2 +- 11 files changed, 11 insertions(+), 13 deletions(-) commit 67bc4955b594fc1ef82fd13d3b44304e200ee541 Author: Koji Ishii <kojii@chromium.org> Date: Fri Feb 15 04:17:47 2019 +0000 [LayoutNG] Avoid copying scoped_refptr in NGInlineItem::TextShapeResult Change-Id: I4e1e311fa8d6796e71d6969a59636c1f691a6e5a Bug: 636993 Reviewed-on: https://chromium-review.googlesource.com/c/1472310 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#632501} third_party/blink/renderer/core/layout/ng/inline/ng_inline_item.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 149fa85b99f2e204de558654351abf43c1ecf69d Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Fri Feb 15 04:14:15 2019 +0000 viz: Plumb vsync info to software output surface Add necessary plumbing to update the begin frame source from the software output device vsync provider. Instantiate a VSyncProviderWin in SoftwareOutputDeviceWin. This is the same vsync provider used with GPU rendering, but it only uses Win32 and DWM API and doesn't have any dependencies on D3D11, ANGLE, etc. Verified that the above change works correctly locally by changing monitor refresh rate to 25Hz and checking the interval in begin frames. Change UpdateSyncParametersCallback in VSyncProvider to a OnceCallback as a minor cleanup. Bug: 928020 Change-Id: Iae36f69f84891af2c2ca903272034991cf488fbb Reviewed-on: https://chromium-review.googlesource.com/c/1471451 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#632500} .../viz/common/frame_sinks/begin_frame_args.cc | 14 -------- .../viz/common/frame_sinks/begin_frame_args.h | 22 +++++++++---- .../display_embedder/gpu_display_provider.cc | 3 +- .../display_embedder/software_output_device_win.cc | 6 +++- .../display_embedder/software_output_surface.cc | 37 ++++++++++++++++------ .../display_embedder/software_output_surface.h | 16 ++++++++-- ...e_browser_compositor_output_surface_unittest.cc | 4 +-- ui/gfx/vsync_provider.cc | 5 ++- ui/gfx/vsync_provider.h | 8 ++--- ui/gl/gl_surface_glx.cc | 11 +++---- ui/gl/sync_control_vsync_provider.cc | 4 +-- ui/gl/sync_control_vsync_provider.h | 2 +- ui/gl/vsync_provider_win.cc | 4 +-- ui/gl/vsync_provider_win.h | 2 +- 14 files changed, 82 insertions(+), 56 deletions(-) commit 426ef6fb8a1ef01d7657ca44b1d9b545426d09a6 Author: Peter Collingbourne <pcc@chromium.org> Date: Fri Feb 15 04:13:45 2019 +0000 run-swarmed.py: Add Android support. Change-Id: I217b997b5724d089f9ee51554437005a2af04caa Reviewed-on: https://chromium-review.googlesource.com/c/1475087 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632499} tools/run-swarmed.py | 43 +++++++++++++++++++++++++++++++++++-------- 1 file changed, 35 insertions(+), 8 deletions(-) commit 11feac80f2c20b052085a29d90a08971b5f1a839 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Fri Feb 15 04:10:49 2019 +0000 Updating trunk VERSION from 3706.0 to 3707.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I49115eabcd7270cc901d2387173ed275fb101681 Reviewed-on: https://chromium-review.googlesource.com/c/1475191 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#632498} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 567cb508b25a768bb73fb5bc84c3e976a872b728 Author: Sergey Berezin <sergeyberezin@google.com> Date: Fri Feb 15 03:59:47 2019 +0000 [clang] Set Xcode path on Mac OS X to hermetic installation Bug: 861487 Change-Id: I8cea76c2993697834d78209efe65b5bab6ffda76 Reviewed-on: https://chromium-review.googlesource.com/c/1474842 Auto-Submit: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632497} tools/clang/scripts/update.py | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 899a011239fbc1eec59523aa1b041647257ad885 Author: Dan Beam <dbeam@chromium.org> Date: Fri Feb 15 03:57:05 2019 +0000 web_dev_style: fix overly-zealous element.$.localId check R=ortuno@chromium.org BUG=none Change-Id: Ib694cfb9b586bd3db4115ec658249e053cc766a5 Reviewed-on: https://chromium-review.googlesource.com/c/1475164 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#632496} tools/web_dev_style/js_checker.py | 2 +- tools/web_dev_style/js_checker_test.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit f8a08bc009431b6b700533d89dd26ad26df431cb Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Feb 15 03:53:29 2019 +0000 crostini export with notifications Exposes export and import functions which control File dialog chooser to select file for export/import and displays notification with progress. BUG=912638 Change-Id: I7b5ff8151bf76f81d2483ff199ed573e42277a2e Reviewed-on: https://chromium-review.googlesource.com/c/1462638 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#632495} chrome/app/chromeos_strings.grdp | 26 ++ .../IDS_CROSTINI_EXPORT_NOTIFICATION_DONE.png.sha1 | 1 + ...DS_CROSTINI_EXPORT_NOTIFICATION_FAILED.png.sha1 | 1 + ...OSTINI_EXPORT_NOTIFICATION_IN_PROGRESS.png.sha1 | 1 + .../IDS_CROSTINI_EXPORT_TITLE.png.sha1 | 1 + .../IDS_CROSTINI_IMPORT_NOTIFICATION_DONE.png.sha1 | 1 + ...DS_CROSTINI_IMPORT_NOTIFICATION_FAILED.png.sha1 | 1 + ...OSTINI_IMPORT_NOTIFICATION_IN_PROGRESS.png.sha1 | 1 + .../IDS_CROSTINI_IMPORT_TITLE.png.sha1 | 1 + chrome/browser/chromeos/BUILD.gn | 5 + .../chromeos/crostini/crostini_export_import.cc | 297 +++++++++++++++++++++ .../chromeos/crostini/crostini_export_import.h | 114 ++++++++ .../crostini_export_import_notification.cc | 119 +++++++++ .../crostini/crostini_export_import_notification.h | 68 +++++ .../crostini/crostini_export_import_unittest.cc | 227 ++++++++++++++++ .../browser/chromeos/crostini/crostini_manager.cc | 27 +- .../browser/chromeos/crostini/crostini_manager.h | 3 +- .../chromeos/crostini/crostini_manager_unittest.cc | 9 +- 18 files changed, 878 insertions(+), 25 deletions(-) commit 2961b634182c52e7785f9b87c203590b5e1f34b1 Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Feb 15 03:52:32 2019 +0000 Fix gn bootstrap build with --use-custom-libcxx The gn binary gets copied up one directory when bootstrapping. It was failing to run since it couldn't find libc++.so which wasn't copied. This CL copies libc++.so too and renames it to libc++.gn.so to not conflict with Chromium's libc++.so. Also rename README.md to README.chromium.md to not conflict with gn's README.md. BUG=807400 R=thakis Change-Id: Idce60c7df7e8aaf134357f39347ee4dafe2a851e Reviewed-on: https://chromium-review.googlesource.com/c/1474847 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632494} tools/gn/{README.md => README.chromium.md} | 0 tools/gn/bootstrap/bootstrap.py | 5 +++-- tools/gn/bootstrap/libc++.ninja | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) commit 7337bf3c5801b8a3698c1161121a529aa01b1ae6 Author: Stuart Langley <slangley@google.com> Date: Fri Feb 15 03:52:07 2019 +0000 Obsolete Drive.FilesListRequestRunner.* histograms. Moving to DriveFS makes these irrelevant. Bug: 931519 Change-Id: I324c3849151698926953517113b19601f1e3d1ab Reviewed-on: https://chromium-review.googlesource.com/c/1470354 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#632493} google_apis/drive/files_list_request_runner.cc | 4 ---- tools/metrics/histograms/histograms.xml | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-) commit 7e95382cc1a4afaa9db97f5107f4cfa7b94276aa Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Feb 15 03:51:27 2019 +0000 Roll src-internal 9b5028a4743a..6fafe494d854 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b5028a4743a..6fafe494d854 Created with: gclient setdep -r src-internal@6fafe494d854 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I73e79f835b11c3008a1985cf35aeff7f538f3e88 Reviewed-on: https://chromium-review.googlesource.com/c/1475158 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632492} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 79f1651a93666006b22570524395199adab60abd Author: Nico Weber <thakis@chromium.org> Date: Fri Feb 15 03:47:01 2019 +0000 blink: Remove semicolons after DEFINE_foo_TYPE_CASTS macros. Bug: 926235 Change-Id: I1d8cef2e56a05f8d6773a3854e550cdb91d168b9 Reviewed-on: https://chromium-review.googlesource.com/c/1474795 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632491} .../blink/renderer/core/animation/non_interpolable_value.h | 11 +++++------ third_party/blink/renderer/platform/loader/fetch/resource.h | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) commit 6c039e9f7b06de67bdcc29d4408c736184665b6a Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Feb 15 03:44:19 2019 +0000 service worker: Change unit tests to be more Mojo-based. This makes EmbeddedWorkerTestHelper more Mojo-based to make it easier for tests to customize the renderer-side behavior and to better match production code. For example, the production code doesn't use "embedded worker id" on the renderer, while the current test helper makes heavy use of it. This unblocks removing "embedded worker id" from the Mojo interface, so it doesn't need to be sent to the renderer. Bug: 927651 Change-Id: I25308f1406904958e684729587d704109f94d020 Reviewed-on: https://chromium-review.googlesource.com/c/1463240 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632490} .../cookie_store/cookie_store_manager_unittest.cc | 152 +++--- .../payments/payment_app_content_unittest_base.cc | 110 +++-- .../embedded_worker_instance_unittest.cc | 234 ++++----- .../service_worker/embedded_worker_test_helper.cc | 547 ++++----------------- .../service_worker/embedded_worker_test_helper.h | 213 ++++---- .../fake_embedded_worker_instance_client.cc | 8 +- .../browser/service_worker/fake_service_worker.cc | 3 +- .../service_worker_context_unittest.cc | 37 +- .../service_worker/service_worker_job_unittest.cc | 218 ++++---- .../service_worker_navigation_loader_unittest.cc | 114 +++-- .../service_worker_object_host_unittest.cc | 34 +- .../service_worker_registration_unittest.cc | 129 ++++- .../service_worker_url_request_job.h | 4 +- .../service_worker_url_request_job_unittest.cc | 219 ++++----- .../service_worker/service_worker_version.h | 34 +- .../service_worker_version_unittest.cc | 368 ++++---------- 16 files changed, 959 insertions(+), 1465 deletions(-) commit 1e46e11dd3d1b66d3a221cdb175706888bfe2852 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Feb 15 03:43:54 2019 +0000 BlinkMemoryMgt: Apply the macros of Allocator into the classes of renderer/core/editing The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/core/editing have not yet been allocated with them so far. After some analyzes, it was concluded that for the case of TextIteratorBehavior and TextSearcherICU, they makes sense to use DISALLOW_NEW because it's used by other classes as a member variable without any smart pointer type. In TextIteratorBehavior::Builder case, it makes sense to use STACK_ALLOCATED because they were only used by function inside. Bug: 919389 Change-Id: Ia2dc70d22286b8c982b95a0ec0abb562c155965f Reviewed-on: https://chromium-review.googlesource.com/c/1475012 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#632489} .../blink/renderer/core/editing/iterators/text_iterator_behavior.h | 5 +++++ .../blink/renderer/core/editing/iterators/text_searcher_icu.h | 3 +++ 2 files changed, 8 insertions(+) commit 0c34a07eb0a35c5ea4b310d6106d938536cffaa4 Author: Ian Vollick <vollick@chromium.org> Date: Fri Feb 15 03:40:27 2019 +0000 Add plumbing for focus ring parameters With this change, I've added plumbing to more easily permit the UA to change how the focus ring is drawn. Bug: None Change-Id: I8d7e0baeaf9747996a0dcf25ae4854ae6fc22373 Reviewed-on: https://chromium-review.googlesource.com/c/1437540 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632488} android_webview/browser/aw_settings.cc | 3 +- chrome/browser/renderer_preferences_util.cc | 3 +- content/browser/BUILD.gn | 2 + content/browser/android/android_ui_constants.cc | 27 ++++++++ content/browser/android/android_ui_constants.h | 22 ++++++ content/public/android/BUILD.gn | 2 + .../org/chromium/content/browser/UiConstants.java | 81 ++++++++++++++++++++++ content/public/browser/BUILD.gn | 2 + .../renderer_preferences_util.cc | 28 +++++++- .../renderer_preferences_util.h | 9 ++- content/public/common/BUILD.gn | 2 - content/public/common/common_param_traits_macros.h | 4 ++ content/renderer/render_view_impl.cc | 10 +++ fuchsia/engine/browser/frame_impl.cc | 2 +- .../blink/public/mojom/renderer_preferences.mojom | 5 +- third_party/blink/public/web/web_render_theme.h | 4 ++ .../renderer/core/exported/web_render_theme.cc | 8 +++ .../blink/renderer/core/layout/layout_theme.cc | 16 +++++ .../blink/renderer/core/layout/layout_theme.h | 6 ++ .../renderer/core/paint/object_painter_base.cc | 7 +- .../blink/renderer/core/style/computed_style.cc | 8 ++- .../renderer/core/style/computed_style_test.cc | 20 ++++++ .../renderer/platform/graphics/graphics_context.cc | 17 +++-- .../renderer/platform/graphics/graphics_context.h | 5 +- 24 files changed, 269 insertions(+), 24 deletions(-) commit 9318ca87879793af06174eb1ba94809601dde644 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 03:39:44 2019 +0000 Roll src/third_party/chromite 25ca3f40d18c..c752ed722716 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/25ca3f40d18c..c752ed722716 git log 25ca3f40d18c..c752ed722716 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 evanhernandez@chromium.org cros_branch_unittest: Stronger assertions. Created with: gclient setdep -r src/third_party/chromite@c752ed722716 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I479ee38080b5cf326725a6177848d33fec321190 Reviewed-on: https://chromium-review.googlesource.com/c/1475083 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632487} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ad94cfbefbbef953cbefd2b47337e61511cbfbdc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 03:38:50 2019 +0000 Roll src/third_party/catapult 778eee07409e..309c28a6328b (2 commits) https://chromium.googlesource.com/catapult.git/+log/778eee07409e..309c28a6328b git log 778eee07409e..309c28a6328b --date=short --no-merges --format='%ad %ae %s' 2019-02-15 ntfschr@google.com Reland "Devil: add --quiet option to logging_common"" 2019-02-15 rmhasan@google.com Fixes issue where expected failures were being retried in Typ Created with: gclient setdep -r src/third_party/catapult@309c28a6328b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:929892,chromium:931395 TBR=sullivan@chromium.org Change-Id: Ifeea1a97159624198ab86289d589c752aaf4f710 Reviewed-on: https://chromium-review.googlesource.com/c/1475080 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632486} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 91f82d6a973c6c848a7b6cab6fed6a2667c311c0 Author: Taiju Tsuiki <tzik@chromium.org> Date: Fri Feb 15 03:34:28 2019 +0000 Revert "Roll src/native_client ff15c51d2078..908d9f47b1b2 (11 commits)" This reverts commit af508ec60f2a4041b59283191c53765941bb171b. Reason for revert: This probably causes a bot failure by breaking the deterministic build. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux%20%28dbg%29/5099 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Deterministic%20Linux/20483 Note that there's a time gap between the roll itself and the breakage due to a cache contamination. Original change's description: > Roll src/native_client ff15c51d2078..908d9f47b1b2 (11 commits) > > https://chromium.googlesource.com/native_client/src/native_client.git/+log/ff15c51d2078..908d9f47b1b2 > > > git log ff15c51d2078..908d9f47b1b2 --date=short --no-merges --format='%ad %ae %s' > 2019-02-14 thakis@chromium.org Update revision for PNaCl > 2019-02-14 thakis@chromium.org win toolchain build: Use mingw zip that doesn't include git. > 2019-02-08 dschuff@chromium.org No-op commit to test recipe change > 2019-01-24 thakis@chromium.org Update revision for PNaCl > 2019-01-24 dschuff@chromium.org Whitespace change to command.py > 2019-01-23 thakis@chromium.org comment change to trigger bots > 2019-01-22 thakis@chromium.org Add even more debug logging. > 2019-01-18 thakis@chromium.org Add some more logging. > 2019-01-18 thakis@chromium.org Add some debug logging. > 2019-01-18 dschuff@chromium.org Update CQ config to use only toolchain trybots when appropriate > 2019-01-16 dschuff@chromium.org Update revision for PNaCl > > > Created with: > gclient setdep -r src/native_client@908d9f47b1b2 > > The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > > BUG=chromium:923062,chromium:923062,chromium:None,chromium:923062,chromium:None,chromium:923062,chromium:923062,chromium:923062,chromium:<none>,chromium:none > TBR=mseaborn@chromium.org > > Change-Id: I5a49b9c6125a54efb01ab6538c720b1cddad2b27 > Reviewed-on: https://chromium-review.googlesource.com/c/1474435 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#632443} TBR=mseaborn@chromium.org,chromium-autoroll@skia-public.iam.gserviceaccount.com Change-Id: I0dae5201a41ed661fe1b69be65f07ec2b2775cf9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:923062, chromium:None, chromium:<none>, chromium:none Reviewed-on: https://chromium-review.googlesource.com/c/1475132 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#632485} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e33f1a62c63ec50ff340367e02fed97393ef7114 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 03:28:11 2019 +0000 Roll src/third_party/pdfium 4679e62edbe5..333ac4ae60ac (2 commits) https://pdfium.googlesource.com/pdfium.git/+log/4679e62edbe5..333ac4ae60ac git log 4679e62edbe5..333ac4ae60ac --date=short --no-merges --format='%ad %ae %s' 2019-02-14 tsepez@chromium.org Remove some more redundant CJX_Object subclass methods. 2019-02-14 tsepez@chromium.org Add test to ensure Net.* remains unimplemented Created with: gclient setdep -r src/third_party/pdfium@333ac4ae60ac The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:853237 TBR=dsinclair@chromium.org Change-Id: Ibee8b74b658c7fa54418851ca941cc520afa8adb Reviewed-on: https://chromium-review.googlesource.com/c/1475085 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632484} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5d69a88ad359f3601c09cabd3b14f78cbf5220cb Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Feb 15 03:20:02 2019 +0000 MacPWAs: Fix race in NSRunningApplication isTerminated watching It is possible for the NSRunningApplication to terminate before our KVO is created. Handle this by adding NSKeyValueObservingOptionInitial to the addObserver call. With that change, termination can be observed within the addObserver call. To avoid calling removeObserve from within addObserver (which is not legal), post a task to call onTerminated, which will make the callback, remove the observer, and release the object. Bug: 929034 Change-Id: I9abba42c5b54ae31a98e6872d224b76aa1e56314 Reviewed-on: https://chromium-review.googlesource.com/c/1456347 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#632483} .../components/web_app_shortcut_mac.mm | 33 +++++++++++++++------- 1 file changed, 23 insertions(+), 10 deletions(-) commit d8cebb96ee96b3c49dd5227ded338a88f3f9c327 Author: Nasko Oskov <nasko@chromium.org> Date: Fri Feb 15 03:19:52 2019 +0000 Add temporary simplified process lock check in the renderer process. This CL adds a simplified version of process lock checks to allow us to capture renderer-side stack of when the process lock mismatches commit URLs. It will be useful to diagnose renderer process terminations resulting from checks added in r631496. The CL also adds some extra bits of information to the browser-side crash reports to help us undertand whether the process kills are caused by error pages or regular navigations. Bug: 931895 Change-Id: Ie616df4e2c73f36523460be611c570d5f7d05b5e Reviewed-on: https://chromium-review.googlesource.com/c/1474541 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632482} .../browser/frame_host/render_frame_host_impl.cc | 28 +++++++++++++++++++++ .../renderer_host/render_process_host_impl.cc | 2 +- .../service_worker/embedded_worker_test_helper.cc | 2 +- content/common/renderer.mojom | 5 +++- content/renderer/render_frame_impl.cc | 29 +++++++++++++++++++--- content/renderer/render_thread_impl.cc | 3 ++- content/renderer/render_thread_impl.h | 11 +++++++- 7 files changed, 72 insertions(+), 8 deletions(-) commit 499a46c274415cbae3dc022fd13d4ee6b2c6bddb Author: Alli Murray <alliemurray@google.com> Date: Fri Feb 15 03:16:24 2019 +0000 Change to default directory when removable entry list is unmounted. Fixes bug where file list and breadcrumbs don't updated after removable entry lists are unmounted. Added unmount for removable test volumes, to test an unmount event. Bug: 918795 Change-Id: I13ea71b6db9dff5ac2e59982eef7f6e34457fe31 Reviewed-on: https://chromium-review.googlesource.com/c/1465962 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#632481} .../file_manager/file_manager_browsertest.cc | 3 + .../file_manager/file_manager_browsertest_base.cc | 48 ++++---- .../file_manager/file_manager_browsertest_base.h | 1 - .../chromeos/file_manager/volume_manager.cc | 13 +++ .../browser/chromeos/file_manager/volume_manager.h | 8 ++ .../file_manager/foreground/js/directory_model.js | 7 +- .../integration_tests/file_manager/context_menu.js | 9 +- .../integration_tests/file_manager/file_display.js | 128 ++++++++++++++++++--- .../integration_tests/file_manager/quick_view.js | 4 +- 9 files changed, 176 insertions(+), 45 deletions(-) commit ac2d4e465d9b9864a6fe9992903c0b58a005b5f0 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Feb 15 03:08:46 2019 +0000 Update V8 to version 7.4.173. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3c4ae81e..131559db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If6a7ed24fa1b9fb76f96ad395bb4bf155a13b3f6 Reviewed-on: https://chromium-review.googlesource.com/c/1475030 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632480} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 42c196343f7e19321784219359df7616fc6744c0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 03:07:34 2019 +0000 Roll src/third_party/angle 366df2b26dd1..4b6549824faa (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/366df2b26dd1..4b6549824faa git log 366df2b26dd1..4b6549824faa --date=short --no-merges --format='%ad %ae %s' 2019-02-15 jdarpinian@chromium.org GL backend: Transform feedback driver bug workaround 2019-02-14 spang@chromium.org Fuchsia: Migrate ScenicWindow to ViewV2 Created with: gclient setdep -r src/third_party/angle@4b6549824faa The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:832238 TBR=jmadill@chromium.org Change-Id: I478864689e714012f960d04902e670a3ddf7b05c Reviewed-on: https://chromium-review.googlesource.com/c/1475078 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632479} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 40fd1c2c43e23b08292f2843c34b4a0cdccc625a Author: Thomas Guilbert <tguilbert@chromium.org> Date: Fri Feb 15 03:03:32 2019 +0000 Remove WebRemotePlaybackAvailability This CL cleans up some of the discoverability related code tied to the old RemotePlayback path. It also cleans up a few no-op methods that were missed in a previous CL. Discovering devices happens via the PresentationAvailabilityObserver instead. Bug: 517102, 570711, 790766, 927099, 927451 Change-Id: Iaa6933638e641df63a55ec55bf4340a8a2473b16 Reviewed-on: https://chromium-review.googlesource.com/c/1460108 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632478} .../media/stream/webmediaplayer_ms_unittest.cc | 6 -- media/blink/webmediaplayer_impl_unittest.cc | 6 -- third_party/blink/public/BUILD.gn | 2 - .../web_remote_playback_availability.h | 34 --------- .../remoteplayback/web_remote_playback_client.h | 10 --- .../public/platform/web_media_player_client.h | 8 --- .../renderer/core/html/media/html_media_element.cc | 61 ---------------- .../renderer/core/html/media/html_media_element.h | 10 --- .../core/html/media/remote_playback_controller.h | 4 ++ .../core/html/media/remote_playback_observer.h | 6 -- .../renderer/core/html/media/video_wake_lock.cc | 3 - .../renderer/core/html/media/video_wake_lock.h | 1 - .../blink/renderer/core/testing/internals.cc | 17 ++--- .../media_controls/media_controls_impl_test.cc | 5 +- .../modules/remoteplayback/remote_playback.cc | 82 +++++++++------------- .../modules/remoteplayback/remote_playback.h | 13 ++-- 16 files changed, 53 insertions(+), 215 deletions(-) commit d1f68eb66eb8d2c25e4b6c0ed4f948fb2a30e21d Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Feb 15 03:02:23 2019 +0000 Import wpt@ad219567030d1f99f7310f52a17546b57b70d29e Using wpt-import in Chromium c2a3758af7eccd4717947dc6b0ae0365800f762b. With Chromium commits locally applied on WPT: 14c111075b "Implement `Sec-CH-Lang`" af3b056c72 "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0b2 "Don't skip past auto-height flexboxes in quirks mode." 6cf9dcc6ec "Use testdriver Action API in WPT pointerevent touch tests" 5c3da78ee3 "Revert "Use testdriver Action API in WPT pointerevent touch tests"" c3f6928207 "New wpt tests for absolute position" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ice56628627bead8f201858828f86e9e889c9aea0 Reviewed-on: https://chromium-review.googlesource.com/c/1475074 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632477} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 32 ++++++++++++- .../external/wpt/css/css-values/rgba-011.html | 54 ++++++++++++++++++++++ .../external/wpt/payment-request/META.yml | 1 + 3 files changed, 86 insertions(+), 1 deletion(-) commit d9fc6009a56b7b03f0490d0faa06fef26823196e Author: Ella Ge <eirage@chromium.org> Date: Fri Feb 15 03:02:14 2019 +0000 Fix page to absolute position for touch points The page_pos is in zoomed coordinate space, but DocumentToFrame() is in unzoomed space. This causes absolute_location_ incorrect when there is scroll offsets. Bug: 931208 Change-Id: I5a26b6a41f193fb5912a5b505144d15d04c6bc19 Reviewed-on: https://chromium-review.googlesource.com/c/1474633 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632476} third_party/blink/renderer/core/input/touch.cc | 11 ++++----- .../core/input/touch_event_manager_test.cc | 28 ++++++++++++++++++++++ 2 files changed, 33 insertions(+), 6 deletions(-) commit 132da924579daa5305d320912a67513c96e6923e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Feb 15 02:57:31 2019 +0000 Roll src-internal b9b926ab8438..9b5028a4743a (7 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9b926ab8438..9b5028a4743a Created with: gclient setdep -r src-internal@9b5028a4743a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Icb7cd58a80f14f99ae01d057587f2525b45982e8 Reviewed-on: https://chromium-review.googlesource.com/c/1475079 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632475} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee5d0939c170d6509ee12f38c93b65afa82678c7 Author: Ben Kelly <wanderview@chromium.org> Date: Fri Feb 15 02:51:49 2019 +0000 CacheStorage: Validate BatchOperation list at mojo interface. The Batch() method and BatchOperation list imply that any combination of operations can be passed. In reality, however, the web exposed Cache API only permits a single kDelete operation or one-to-many kPut operations. We should verify compromised renderers are not trying to exercise poorly tested paths by using different configurations of operations. Bug: 927537 Change-Id: I79bb708a19e736a00c4e09fdc99f447db894b6f4 Reviewed-on: https://chromium-review.googlesource.com/c/1473191 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#632474} .../cache_storage/cache_storage_dispatcher_host.cc | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) commit 097b6c6fcb9ea58c9912264117eba28017a1b3f0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 02:51:30 2019 +0000 Roll src/third_party/dawn 1541c8ba7a7e..4dec7371a221 (2 commits) https://dawn.googlesource.com/dawn.git/+log/1541c8ba7a7e..4dec7371a221 git log 1541c8ba7a7e..4dec7371a221 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 yunchao.he@intel.com Construct VertexInputDescriptor, in order to match web idl 2019-02-14 jiawei.shao@intel.com Remove redundant RenderPass in Dawn unittests Created with: gclient setdep -r src/third_party/dawn@4dec7371a221 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I773e041ff83978b47ba62233ca2f04d9b1589a4a Reviewed-on: https://chromium-review.googlesource.com/c/1475073 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632473} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ebc5273392a38b5b5b94874d21bbd146b262774c Author: Victor Costan <pwnall@chromium.org> Date: Fri Feb 15 02:39:47 2019 +0000 test: Replace TYPED_TEST_CASE() with TYPED_TEST_SUITE(). Googletest is (at last) converging with industry-standard terminology [1]. We previously called test suites "test cases", which was rather confusing for folks coming from any other testing framework. Chrome now has a googletest version that supports TYPED_TEST_SUITE() macros instead of TYPED_TEST_CASE(), so this CL cleans up some of the outdated usage. [1] https://github.com/google/googletest/blob/master/googletest/docs/primer.md#beware-of-the-nomenclature TBR=blundell,jrummell,rockot,thakis Bug: 925652 Change-Id: I14930a3de8345e2c26b6420457b89dfc6a398820 Reviewed-on: https://chromium-review.googlesource.com/c/1475075 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632472} base/bind_unittest.cc | 4 ++-- base/file_version_info_win_unittest.cc | 2 +- base/memory/shared_memory_region_unittest.cc | 4 ++-- base/observer_list_perftest.cc | 2 +- base/observer_list_unittest.cc | 4 ++-- base/strings/string_piece_unittest.cc | 2 +- .../offline_page_request_handler_unittest.cc | 2 +- .../safe_browsing/mac/read_stream_unittest.cc | 2 +- .../prefetch_request_operation_response_unittest.cc | 2 +- components/viz/service/display/renderer_pixeltest.cc | 20 ++++++++++---------- ipc/ipc_channel_mojo_unittest.cc | 4 ++-- ipc/ipc_message_utils_unittest.cc | 2 +- media/filters/decoder_selector_unittest.cc | 2 +- .../cpp/bindings/tests/sync_method_unittest.cc | 4 ++-- .../renderer/platform/wtf/list_hash_set_test.cc | 10 +++++----- third_party/leveldatabase/env_chromium_unittest.cc | 4 ++-- ui/base/clipboard/clipboard_test_template.h | 6 +++--- ui/gfx/range/range_unittest.cc | 2 +- 18 files changed, 39 insertions(+), 39 deletions(-) commit b1ff1d55f6b4549a24914494e8b5a7ea07030545 Author: Nicholas Hollingum <hollingum@google.com> Date: Fri Feb 15 02:39:25 2019 +0000 Change model updater's delegate->observer Having multiple observers will allow us to register custom listeners that can react to Ash's callbacks. Currently only the sync service could do that, as only one delegate was allowed. This change is part of a larger change that enables system-managed folders that contain only 1 item. We will add an additional observer that listens for the creation of certain folders and sets their persistence. Bug: 925052 Change-Id: I7b590fa23db923bcfefe911d83a6d4fece16f725 Reviewed-on: https://chromium-review.googlesource.com/c/1468845 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632471} chrome/browser/ui/BUILD.gn | 2 +- .../browser/ui/app_list/app_list_model_updater.h | 5 +-- ...elegate.h => app_list_model_updater_observer.h} | 17 +++++----- .../ui/app_list/app_list_syncable_service.cc | 28 ++++++++-------- .../ui/app_list/app_list_syncable_service.h | 4 +-- .../ui/app_list/chrome_app_list_model_updater.cc | 39 +++++++++++++--------- .../ui/app_list/chrome_app_list_model_updater.h | 6 ++-- .../app_list/test/fake_app_list_model_updater.cc | 15 ++++++--- .../ui/app_list/test/fake_app_list_model_updater.h | 6 ++-- 9 files changed, 70 insertions(+), 52 deletions(-) commit e1683182c7bceff4af01db964ad63750365eab25 Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Feb 15 02:38:05 2019 +0000 Add constructor to XRRay, use XRRay in requestHitTest API Rename transform_matrix to matrix. Bug: 871824,922172 Change-Id: Iaea7441bad00977b8a48424b3cbd428b184d4b13 Reviewed-on: https://chromium-review.googlesource.com/c/1435217 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#632470} .../android/vr/arcore_device/arcore_device.cc | 3 + .../vr/arcore_device/arcore_device_provider.cc | 1 + .../browser/android/vr/arcore_device/arcore_gl.cc | 3 + .../android/vr/arcore_device/arcore_impl.cc | 22 +++- third_party/blink/renderer/modules/xr/xr_ray.cc | 128 ++++++++++++++++-- third_party/blink/renderer/modules/xr/xr_ray.h | 21 ++- third_party/blink/renderer/modules/xr/xr_ray.idl | 8 +- .../renderer/modules/xr/xr_rigid_transform.cc | 9 +- .../blink/renderer/modules/xr/xr_session.cc | 30 ++--- third_party/blink/renderer/modules/xr/xr_session.h | 4 +- .../blink/renderer/modules/xr/xr_session.idl | 2 +- third_party/blink/renderer/modules/xr/xr_utils.cc | 19 +++ third_party/blink/renderer/modules/xr/xr_utils.h | 5 + .../wpt/webxr/idlharness.https.window-expected.txt | 4 +- .../global-interface-listing-expected.txt | 2 +- third_party/blink/web_tests/xr/ar_hittest.html | 15 ++- .../blink/web_tests/xr/getInputPose_hand.html | 4 +- .../blink/web_tests/xr/getInputPose_ray.html | 4 +- .../blink/web_tests/xr/resources/test-constants.js | 7 +- .../web_tests/xr/resources/xr-test-asserts.js | 31 +++++ .../blink/web_tests/xr/xrRay_constructor.html | 145 +++++++++++++++++++++ third_party/blink/web_tests/xr/xrRay_matrix.html | 123 +++++++++++++++++ .../webxr-samples/input-tracking.html | 1 - .../webxr-samples/js/cottontail/src/core/node.js | 2 +- .../js/cottontail/src/nodes/input-renderer.js | 2 +- .../webxr-samples/js/webxr-polyfill.js | 10 +- .../webxr-samples/positional-audio.html | 4 +- .../webxr-samples/proposals/phone-ar-hit-test.html | 11 +- 28 files changed, 551 insertions(+), 69 deletions(-) commit 4da07dbc5b6ab52c409f18c00ff7cab4908b4e81 Author: Ben Kelly <wanderview@chromium.org> Date: Fri Feb 15 02:34:59 2019 +0000 CacheStorage: Replace callbacks methods with lambdas in CacheStorageDispatcherHost::CacheImpl. This brings CacheImpl in line with how CacheStorageImpl is implemented. Its easier to read these methods when all of the logic is defined in the same place. In addition, this allows us to remove the CacheImpl WeakFactory completely. Bug: 927537 Change-Id: Ib37c04cc5b65faf88e66ec53728fc79adb6ec73e Reviewed-on: https://chromium-review.googlesource.com/c/1471114 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#632469} .../cache_storage/cache_storage_dispatcher_host.cc | 122 ++++++++++----------- 1 file changed, 58 insertions(+), 64 deletions(-) commit 4703af69f5fac9a4f622730c6fb377e432f1f4fb Author: John Rummell <jrummell@chromium.org> Date: Fri Feb 15 02:31:00 2019 +0000 Add MediaDrmOriginIdManager to pre-provision origin IDs on Android To support encrypted media playback on Android when the Internet is not available (e.g. on a plane), we need to pre-provision some origin IDs so that provisioning is completed while connected. This adds a new MediaDrmOriginIdManager class that keeps track of the pre-provisioned origin IDs in a new preference "media.media_drm_origins". MediaDrmStorageFactory now uses the new class to get a pre-provisioned origin ID rather than generating a new origin ID that needs to be provisioned before it can be used. BUG=917527 TEST=new unit_tests pass Change-Id: If4a5af4ba50b0586d5ca6f6f7cb8ea9686f98fa9 Reviewed-on: https://chromium-review.googlesource.com/c/1416398 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632468} chrome/browser/BUILD.gn | 4 + .../android/cdm/media_drm_origin_id_manager.cc | 418 +++++++++++++++++++++ .../android/cdm/media_drm_origin_id_manager.h | 93 +++++ .../cdm/media_drm_origin_id_manager_factory.cc | 47 +++ .../cdm/media_drm_origin_id_manager_factory.h | 41 ++ .../cdm/media_drm_origin_id_manager_unittest.cc | 278 ++++++++++++++ .../media/android/cdm/media_drm_storage_factory.cc | 23 +- chrome/browser/prefs/browser_prefs.cc | 2 + chrome/test/BUILD.gn | 1 + components/cdm/browser/media_drm_storage_impl.cc | 8 +- components/cdm/browser/media_drm_storage_impl.h | 9 +- .../cdm/browser/media_drm_storage_impl_unittest.cc | 8 +- .../src/org/chromium/media/MediaDrmBridge.java | 28 ++ media/base/android/media_drm_bridge.cc | 26 ++ media/base/android/media_drm_bridge.h | 4 + 15 files changed, 973 insertions(+), 17 deletions(-) commit 0582192db036cd99c83b02b92c5d00c862625202 Author: Vladimir Levin <vmpstr@chromium.org> Date: Fri Feb 15 02:28:28 2019 +0000 [DL]: Rename isLocked to locked as per design principle. As https://w3ctag.github.io/design-principles/#api-surface suggests, boolean attributes should not have "is" at the beginning of their names. This patch fixes this for DisplayLockContext.isLocked R=chrishtr@chromium.org Bug: 882663, github.com/WICG/display-locking/issues/43 Change-Id: Ie5be4b4f6fd0ee8656fbb3c31aae0e7eb0fc3612 Reviewed-on: https://chromium-review.googlesource.com/c/1466155 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#632467} .../renderer/core/display_lock/display_lock_context.idl | 2 +- .../{is-locked-attribute.html => locked-attribute.html} | 16 ++++++++-------- .../{is-locked-attribute.html => locked-attribute.html} | 16 ++++++++-------- 3 files changed, 17 insertions(+), 17 deletions(-) commit a4ac9c70341c20be9aabc6dceb0714bc1e94a142 Author: Zhenyao Mo <zmo@chromium.org> Date: Fri Feb 15 02:28:02 2019 +0000 Fix underlay testing issue on video power measurement It fails on certain video sites, for example: http://crosvideo.appspot.com Also, this CL adds an option --bypass-ipg so that we can debug testing harness where Intel Power Gadget is not supported. BUG=868561 TEST=manual, GPU bots R=magchen@chromium.org Change-Id: I0e8a2882dab4a1fcf6d5989e65dc36d57cad165a Reviewed-on: https://chromium-review.googlesource.com/c/1471295 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#632466} content/test/gpu/gpu_tests/ipg_utils.py | 28 +++------ .../power_measurement_integration_test.py | 67 ++++++++++++++-------- 2 files changed, 53 insertions(+), 42 deletions(-) commit 74518a7f1756109b8f0f5862ae4b4bb3eee44526 Author: Jonathan Backer <backer@chromium.org> Date: Fri Feb 15 02:27:20 2019 +0000 Handle vertical flipping on display Skia typically handles the flipping of the display by the appropriate choice of SkSurface origin: kTopLeft_GrSurfaceOrigin or kBottomLeft_GrSurfaceOrigin. GLRendererCopier does not use Skia and needs to know if the SkSurface that it is reading from is flipped. SkiaOutputSurfaceImplTest.SubmitPaint reads from the root render pass. If using GL, we tell GLRendererCopier to flip based on the properties of the root. If using Vulkan, we don't change co-ordinates because Skia handles it on the current software readback pathway. I also made the SurfaceCharacterization consistent with the actual surface, but I don't believe this is necessary. Bug: 929790 Change-Id: Ie5b515e986b1d84ab77b1d600d219501df9860ed Reviewed-on: https://chromium-review.googlesource.com/c/1464924 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#632465} .../display_embedder/skia_output_surface_impl.cc | 2 +- .../skia_output_surface_impl_on_gpu.cc | 10 +++++---- .../skia_output_surface_impl_unittest.cc | 24 +++++++++++++++++----- 3 files changed, 26 insertions(+), 10 deletions(-) commit 90aa3c4bf3ace6fde0e17511b232020d50f9f173 Author: Nico Weber <thakis@chromium.org> Date: Fri Feb 15 02:25:20 2019 +0000 Remove unused IsPersistentReferenceType. In addition to being unused, this code also contained a superfluous semicolon. The call to IsPersistentReferenceType was removed in https://chromium-review.googlesource.com/c/chromium/src/+/888918 Bug: 926235,798464 Change-Id: I8bc21fb77caac52d2ccd8d12a8982229ce530491 Reviewed-on: https://chromium-review.googlesource.com/c/1474796 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#632464} third_party/blink/renderer/platform/heap/persistent.h | 10 ---------- third_party/blink/renderer/platform/wtf/type_traits.h | 16 ---------------- 2 files changed, 26 deletions(-) commit 4e4e5fcd8bdd0d427f00dbe9e1d4c5890e3626a3 Author: Anastasia Helfinstein <anastasi@google.com> Date: Fri Feb 15 02:19:35 2019 +0000 Update Switch Access menu panel communication setup Makes the process by which the Switch Access background page establishes a connection with the menu panel more precise and robust. Bug: None Change-Id: I13adde72b9f4e83226a5e03e4e594cfd8c9581bb Reviewed-on: https://chromium-review.googlesource.com/c/1471226 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#632463} .../resources/chromeos/switch_access/BUILD.gn | 18 +-- .../chromeos/switch_access/manifest.json.jinja2 | 1 - .../chromeos/switch_access/menu_manager.js | 107 +++++++++++----- .../resources/chromeos/switch_access/menu_panel.js | 137 +++++++++------------ .../chromeos/switch_access/menu_panel_interface.js | 35 ++++++ .../chromeos/switch_access/message_handler.js | 56 --------- .../chromeos/switch_access/navigation_manager.js | 9 ++ .../chromeos/switch_access/switch_access.js | 26 ++++ .../switch_access/switch_access_interface.js | 7 ++ 9 files changed, 225 insertions(+), 171 deletions(-) commit 3269cfdf932832d62511cf330402129d3c6564ec Author: khmel@chromium.org <khmel@chromium.org> Date: Fri Feb 15 02:16:58 2019 +0000 arc: autotest API, add getArcState. This function is required to determine silent OptIn flow and handle it accordingly. TEST=in context of crrev.com/c/1470784 BUG=b:124391451 Change-Id: Iaac6969e9202fd7e68591159a26fc19a171bc2e7 Reviewed-on: https://chromium-review.googlesource.com/c/1471371 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632462} .../autotest_private/autotest_private_api.cc | 21 ++++++++++ .../autotest_private/autotest_private_api.h | 11 +++++ .../autotest_private/autotest_private_apitest.cc | 2 + chrome/common/extensions/api/autotest_private.idl | 12 ++++++ .../extensions/api_test/autotest_private/test.js | 48 ++++++++++++++-------- .../browser/extension_function_histogram_value.h | 1 + tools/metrics/histograms/enums.xml | 1 + 7 files changed, 80 insertions(+), 16 deletions(-) commit e45c63fd849bcee4521c4f22460a4cf5990d415b Author: Daniel Ng <danielng@google.com> Date: Fri Feb 15 02:11:30 2019 +0000 Installation Dialog for Crostini App search CL updates crostini app search to incorporate a confirmation dialog when trying to install Crostini apps from the app launcher. Includes some browsertests for the dialog. This is being made separate to the existing dialog used for installing .deb/crostini-apps packages, as that dialog resides in the files system and operates within a files window, while this feature does not. Ideally these should be merged in the future so that they are consistent with each other. Bug: 921429 CQ-DEPEND=CL:1460244 Change-Id: I8c04345a304337042976d958cac995888859ebb2 Reviewed-on: https://chromium-review.googlesource.com/c/1466162 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#632461} chrome/app/chromeos_strings.grdp | 23 +++- chrome/browser/chromeos/crostini/crostini_util.h | 5 + chrome/browser/ui/BUILD.gn | 2 + .../crostini/crostini_repository_search_result.cc | 10 +- .../views/crostini/crostini_app_installer_view.cc | 121 +++++++++++++++++++++ .../views/crostini/crostini_app_installer_view.h | 41 +++++++ .../crostini_app_installer_view_browsertest.cc | 75 +++++++++++++ chrome/test/BUILD.gn | 1 + 8 files changed, 269 insertions(+), 9 deletions(-) commit 7fa60d14d688e7ec3b53336de556dab89a2bc67e Author: Raymond Toy <rtoy@chromium.org> Date: Fri Feb 15 02:09:38 2019 +0000 Rename DefaultAudioDestination to RealtimeAudioDestination Just a global search and replace to change the class name. No functional changes. Bug: 854229 Change-Id: I08f141f7e54d1c2ee7ebeeca5adbdc60c3726d89 Reviewed-on: https://chromium-review.googlesource.com/c/1470734 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#632460} .../blink/renderer/modules/webaudio/BUILD.gn | 4 +- .../renderer/modules/webaudio/audio_context.cc | 14 ++--- ..._node.cc => realtime_audio_destination_node.cc} | 62 +++++++++++----------- ...on_node.h => realtime_audio_destination_node.h} | 28 +++++----- .../modules/webaudio/script_processor_node.cc | 8 +-- 5 files changed, 58 insertions(+), 58 deletions(-) commit 36903eed8ea72bca570d965361406e1d9b2c610c Author: Kent Tamura <tkent@chromium.org> Date: Fri Feb 15 02:02:55 2019 +0000 XMLSerializer: Support element prefix rewriting. We need to change the prefix of an element if: - The element's namespace is same as the inherited default namespace, and the element prefix is not empty, - The prefix-namespace pair of an element is not declared, and there is another prefix associated to the namespace, or - The namespace of an element is not associated to any prefixes, and the element's prefix is declared for another namespace in the element. This CL implements Step 11, 12.1 to 12.5 of [1]. * Add capability to serialize prefix which is not element.prefix() to MarkupFormatter * MarkupAccumulator::AppendElement() returns a serialized prefix, and AppendEndTag() takes it as an argument. * MarkupAccumulator::AppendStartTagOpen() implements the steps, and returns a serialized prefix as well as 'ignore namespace definition attribute' flag. * MarkupAccumulator::RetrievePreferredPrefixString(): Remove the code for empty prefix for elements. Empty prefix is handled in the callsite. * MarkupAccumulator::ShouldAddNamespaceElement(): Removed. It's not used any longer. * dom/domparsing/xmlserializer-xml-namespace-expected.txt: The new behavior is expected. We successfully find 'xml' prefix. [1] https://w3c.github.io/DOM-Parsing/#xml-serializing-an-element-node Bug: 929035 Change-Id: Icf63cb40b120d29a4b8678104592739d773f3a48 Reviewed-on: https://chromium-review.googlesource.com/c/1473090 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#632459} .../core/editing/serializers/markup_accumulator.cc | 134 +++++++++++++-------- .../core/editing/serializers/markup_accumulator.h | 14 ++- .../core/editing/serializers/markup_formatter.cc | 25 +++- .../core/editing/serializers/markup_formatter.h | 7 ++ .../blink/renderer/core/frame/frame_serializer.cc | 9 +- .../xmlserializer-xml-namespace-expected.txt | 2 +- .../XMLSerializer-serializeToString-expected.txt | 4 + .../XMLSerializer-serializeToString.html | 28 +++++ 8 files changed, 163 insertions(+), 60 deletions(-) commit 525f8a08b19b1aad66f54a56e07531c2b75f9716 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Fri Feb 15 02:02:42 2019 +0000 Don't report renderer hangs if a windows debugger is attached to the process. Bug: 923092 Change-Id: I52b2edfeeb60ec6c4d03e208c4554f2f368a098c Reviewed-on: https://chromium-review.googlesource.com/c/1469285 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632458} content/browser/web_contents/web_contents_impl.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 069f43a12944cc6d0959c492a27ffcd4c359aba2 Author: Yun Liu <yliuyliu@google.com> Date: Fri Feb 15 02:01:39 2019 +0000 Use Settings.Global instead of Settings.System Settings.System.DEVICE_PROVISIONED is deprecated and should use Settings.Global.DEVICE_PROVISIONED instead. Bug: N/A Change-Id: I2a84c2d25ab12d0730a1b1388f2c58a018dbb251 Reviewed-on: https://chromium-review.googlesource.com/c/1474840 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#632457} .../content/browser/selection/SelectionPopupControllerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit e17573a25850f112d67c17100728fc663cf7e54d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 02:01:34 2019 +0000 Roll src/third_party/pdfium db71c92c63fd..4679e62edbe5 (2 commits) https://pdfium.googlesource.com/pdfium.git/+log/db71c92c63fd..4679e62edbe5 git log db71c92c63fd..4679e62edbe5 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 thestig@chromium.org Correctly handle decoders in CPDF_DIBBase::ContinueLoadDIBBase(). 2019-02-14 thestig@chromium.org Add a test case for bad SMask rendering. Created with: gclient setdep -r src/third_party/pdfium@4679e62edbe5 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I85afbfd2f46cf06b1337e12e8eb9d75c9984f61d Reviewed-on: https://chromium-review.googlesource.com/c/1474371 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632456} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ed8923f911338b95fc91a0a66fe08d82aa0068f5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 02:00:31 2019 +0000 Roll src/third_party/skia 10f3c40674e4..b00f7b34751b (17 commits) https://skia.googlesource.com/skia.git/+log/10f3c40674e4..b00f7b34751b git log 10f3c40674e4..b00f7b34751b --date=short --no-merges --format='%ad %ae %s' 2019-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader de16f327d051..2bb0864b22e7 (1 commits) 2019-02-14 bungeman@google.com Fix signed/unsigned mismatch in shaper assert. 2019-02-14 bungeman@google.com Fix assert in shaper. 2019-02-14 robertphillips@google.com Allow GrRecordingContext to create surfaceContexts 2019-02-14 bungeman@google.com Remove typeface from SkShaper constructor. 2019-02-14 herb@google.com Calculate strike in path case 2019-02-14 bungeman@google.com Add HarfBuzz callbacks. 2019-02-14 bungeman@google.com Fix calculating clusters from start of input. 2019-02-14 jvanverth@google.com Add MoltenVK support to Viewer. 2019-02-14 michaelludwig@google.com Clean up GrQuad ctors 2019-02-14 nigeltao@google.com Have Wuffs output to BGRA, not indexed color 2019-02-14 herb@google.com Use bulk interface for paths 2019-02-14 brianosman@google.com Various particle system improvements 2019-02-14 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-14 brianosman@google.com Particles/SkReflected: Generalize array reflection 2019-02-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 52047de4d41f..77874e2ca341 (1 commits) 2019-02-14 bsalomon@google.com Use destructors to free resources owned by lazy proxy callbacks Created with: gclient setdep -r src/third_party/skia@b00f7b34751b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I25773562c0a6308560315e12285d0ec5f1fa12d8 Reviewed-on: https://chromium-review.googlesource.com/c/1474436 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632455} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe37e8e0b6938172372670e4e71f06ef5277dcdd Author: Clark DuVall <cduvall@chromium.org> Date: Fri Feb 15 02:00:28 2019 +0000 Create NetworkChangeNotifier in network process on Android Previously, we were not creating a NetworkChangeNotifier in the network process on Android. This change syncs the events from the browser process to the network process using a similar mechanism to what ChromeOS uses. It is difficult to detect network changes directly in the network process because some of the java side code depends on being in the browser process. This includes dependencies on ApplicationStatus (which only works in browser process), and requiring a thread with a Looper, which would need to be created in the network process before initializing the NetworkChangeNotifier, which makes startup of the network process more complicated. Bug: 929909 Change-Id: I67923318b7a2f911d325584711a370305826d4a3 Reviewed-on: https://chromium-review.googlesource.com/c/1469063 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632454} .../chromeos/chrome_browser_main_chromeos.cc | 4 +- .../chromeos/network_change_manager_client.cc | 4 +- .../chromeos/network_change_manager_client.h | 8 +-- .../network_change_manager_client_unittest.cc | 4 +- .../network_context_configuration_browsertest.cc | 2 +- .../loader/navigation_url_loader_impl_unittest.cc | 2 + content/browser/network_service_browsertest.cc | 54 ++++++++++++++ content/browser/network_service_client.cc | 84 +++++++++++++++++++++- content/browser/network_service_client.h | 23 ++++++ .../test/network_connection_change_simulator.cc | 6 +- net/BUILD.gn | 14 +++- net/android/network_change_notifier_android.h | 4 +- net/base/network_change_notifier.cc | 4 +- ...hromeos.cc => network_change_notifier_posix.cc} | 56 +++++++++------ ..._chromeos.h => network_change_notifier_posix.h} | 26 ++++--- ...c => network_change_notifier_posix_unittest.cc} | 18 ++--- net/dns/BUILD.gn | 2 +- services/network/network_change_manager.cc | 8 +-- services/network/network_change_manager.h | 2 +- services/network/network_service.cc | 6 +- services/network/network_service_unittest.cc | 12 ---- services/network/public/mojom/BUILD.gn | 4 ++ .../public/mojom/network_change_manager.mojom | 2 +- 23 files changed, 260 insertions(+), 89 deletions(-) commit 643ad24a62b8f2bc1d566ae5b931e739ca36c077 Author: Katie D <katie@chromium.org> Date: Fri Feb 15 01:58:44 2019 +0000 Updates accessibility labels context menu to use submenu. Latest UX has once-only and always options in a submenu. Updates the code to match, with TODOs to complete implementation by sending the "just this once" selection to Accessibility for labels. Bug: 905419 Change-Id: If03ad9c8ac20d0484b2b6545dbd7dc3278eb110a Reviewed-on: https://chromium-review.googlesource.com/c/1471020 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#632453} chrome/app/chrome_command_ids.h | 9 +++- chrome/app/chromium_strings.grd | 5 +- ...NTEXT_ACCESSIBILITY_LABELS_BUBBLE_TEXT.png.sha1 | 2 +- ..._ACCESSIBILITY_LABELS_BUBBLE_TEXT_ONCE.png.sha1 | 1 + chrome/app/generated_resources.grd | 28 +++++++---- ...XT_ACCESSIBILITY_LABELS_BUBBLE_DISABLE.png.sha1 | 2 +- ...EXT_ACCESSIBILITY_LABELS_BUBBLE_ENABLE.png.sha1 | 2 +- ...NTEXT_ACCESSIBILITY_LABELS_MENU_OPTION.png.sha1 | 1 + ...TENT_CONTEXT_ACCESSIBILITY_LABELS_SEND.png.sha1 | 2 +- ...CONTEXT_ACCESSIBILITY_LABELS_SEND_ONCE.png.sha1 | 1 + chrome/app/google_chrome_strings.grd | 7 ++- ...NTEXT_ACCESSIBILITY_LABELS_BUBBLE_TEXT.png.sha1 | 2 +- ..._ACCESSIBILITY_LABELS_BUBBLE_TEXT_ONCE.png.sha1 | 1 + .../accessibility/accessibility_labels_service.cc | 9 ++++ .../accessibility/accessibility_labels_service.h | 2 + .../accessibility_labels_bubble_model.cc | 36 ++++++++++---- .../accessibility_labels_bubble_model.h | 4 +- .../accessibility_labels_menu_observer.cc | 55 +++++++++++++++------- .../accessibility_labels_menu_observer.h | 2 + ...cessibility_labels_menu_observer_browsertest.cc | 48 ++++++++----------- .../mock_render_view_context_menu.cc | 22 +++++++-- .../render_view_context_menu.cc | 40 +++++++++------- .../render_view_context_menu.h | 5 +- .../webui/settings/accessibility_main_handler.cc | 2 +- chrome/common/pref_names.cc | 5 ++ chrome/common/pref_names.h | 1 + 26 files changed, 196 insertions(+), 98 deletions(-) commit f3a09c20608d9e5277dd3dd61857f60d659d0ad9 Author: Pedro Amaral <amaralp@chromium.org> Date: Fri Feb 15 01:58:26 2019 +0000 [Duet] Remove the delete all tabs button Remove delete all tabs button by setting it to invisible. Bug: 927106 Change-Id: I5854feb57f05d8f9a61685890088653052a2979d Reviewed-on: https://chromium-review.googlesource.com/c/1469281 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#632452} .../browser/toolbar/bottom/TabSwitcherBottomToolbarCoordinator.java | 1 + 1 file changed, 1 insertion(+) commit 0b53cbb0555e715d06dd310a8380f36ffd485313 Author: Krishna Govind <govind@chromium.org> Date: Fri Feb 15 01:56:03 2019 +0000 Updating XTBs based on .GRDs from branch master R=kariah@chromium.org Change-Id: Ibbdb4fabb06afb058b854ed911f97e77e2a07623 Reviewed-on: https://chromium-review.googlesource.com/c/1473843 Reviewed-by: Krishna Govind <govind@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Ben Mason <benmason@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#632451} .../strings/ash_components_strings_el.xtb | 1 + .../strings/ash_components_strings_en-GB.xtb | 1 + ash/strings/ash_strings_am.xtb | 2 +- ash/strings/ash_strings_ar.xtb | 2 +- ash/strings/ash_strings_bg.xtb | 2 +- ash/strings/ash_strings_bn.xtb | 2 +- ash/strings/ash_strings_ca.xtb | 2 +- ash/strings/ash_strings_cs.xtb | 2 +- ash/strings/ash_strings_da.xtb | 2 +- ash/strings/ash_strings_de.xtb | 2 +- ash/strings/ash_strings_el.xtb | 5 +- ash/strings/ash_strings_en-GB.xtb | 5 +- ash/strings/ash_strings_es-419.xtb | 2 +- ash/strings/ash_strings_es.xtb | 2 +- ash/strings/ash_strings_et.xtb | 2 +- ash/strings/ash_strings_fa.xtb | 2 +- ash/strings/ash_strings_fi.xtb | 2 +- ash/strings/ash_strings_fil.xtb | 2 +- ash/strings/ash_strings_fr.xtb | 2 +- ash/strings/ash_strings_gu.xtb | 2 +- ash/strings/ash_strings_hi.xtb | 2 +- ash/strings/ash_strings_hr.xtb | 2 +- ash/strings/ash_strings_hu.xtb | 2 +- ash/strings/ash_strings_id.xtb | 2 +- ash/strings/ash_strings_it.xtb | 2 +- ash/strings/ash_strings_iw.xtb | 2 +- ash/strings/ash_strings_ja.xtb | 2 +- ash/strings/ash_strings_kn.xtb | 2 +- ash/strings/ash_strings_ko.xtb | 2 +- ash/strings/ash_strings_lt.xtb | 2 +- ash/strings/ash_strings_lv.xtb | 2 +- ash/strings/ash_strings_ml.xtb | 2 +- ash/strings/ash_strings_mr.xtb | 2 +- ash/strings/ash_strings_ms.xtb | 2 +- ash/strings/ash_strings_nl.xtb | 2 +- ash/strings/ash_strings_no.xtb | 2 +- ash/strings/ash_strings_pl.xtb | 2 +- ash/strings/ash_strings_pt-BR.xtb | 2 +- ash/strings/ash_strings_pt-PT.xtb | 2 +- ash/strings/ash_strings_ro.xtb | 2 +- ash/strings/ash_strings_ru.xtb | 2 +- ash/strings/ash_strings_sk.xtb | 2 +- ash/strings/ash_strings_sl.xtb | 2 +- ash/strings/ash_strings_sr.xtb | 2 +- ash/strings/ash_strings_sv.xtb | 2 +- ash/strings/ash_strings_sw.xtb | 2 +- ash/strings/ash_strings_ta.xtb | 2 +- ash/strings/ash_strings_te.xtb | 2 +- ash/strings/ash_strings_th.xtb | 2 +- ash/strings/ash_strings_tr.xtb | 2 +- ash/strings/ash_strings_uk.xtb | 2 +- ash/strings/ash_strings_vi.xtb | 2 +- ash/strings/ash_strings_zh-CN.xtb | 2 +- ash/strings/ash_strings_zh-TW.xtb | 2 +- .../translations/android_chrome_strings_am.xtb | 2 +- .../translations/android_chrome_strings_ar.xtb | 4 +- .../translations/android_chrome_strings_bg.xtb | 2 +- .../translations/android_chrome_strings_bn.xtb | 2 +- .../translations/android_chrome_strings_ca.xtb | 2 +- .../translations/android_chrome_strings_cs.xtb | 2 +- .../translations/android_chrome_strings_da.xtb | 2 +- .../translations/android_chrome_strings_de.xtb | 2 +- .../translations/android_chrome_strings_el.xtb | 9 +- .../translations/android_chrome_strings_en-GB.xtb | 9 +- .../translations/android_chrome_strings_es-419.xtb | 2 +- .../translations/android_chrome_strings_es.xtb | 2 +- .../translations/android_chrome_strings_et.xtb | 2 +- .../translations/android_chrome_strings_fa.xtb | 2 +- .../translations/android_chrome_strings_fi.xtb | 2 +- .../translations/android_chrome_strings_fil.xtb | 2 +- .../translations/android_chrome_strings_fr.xtb | 2 +- .../translations/android_chrome_strings_gu.xtb | 2 +- .../translations/android_chrome_strings_hi.xtb | 2 +- .../translations/android_chrome_strings_hr.xtb | 2 +- .../translations/android_chrome_strings_hu.xtb | 2 +- .../translations/android_chrome_strings_id.xtb | 2 +- .../translations/android_chrome_strings_it.xtb | 2 +- .../translations/android_chrome_strings_iw.xtb | 2 +- .../translations/android_chrome_strings_ja.xtb | 2 +- .../translations/android_chrome_strings_kn.xtb | 2 +- .../translations/android_chrome_strings_ko.xtb | 2 +- .../translations/android_chrome_strings_lt.xtb | 2 +- .../translations/android_chrome_strings_lv.xtb | 2 +- .../translations/android_chrome_strings_ml.xtb | 2 +- .../translations/android_chrome_strings_mr.xtb | 2 +- .../translations/android_chrome_strings_ms.xtb | 2 +- .../translations/android_chrome_strings_nl.xtb | 2 +- .../translations/android_chrome_strings_no.xtb | 2 +- .../translations/android_chrome_strings_pl.xtb | 2 +- .../translations/android_chrome_strings_pt-BR.xtb | 2 +- .../translations/android_chrome_strings_pt-PT.xtb | 2 +- .../translations/android_chrome_strings_ro.xtb | 2 +- .../translations/android_chrome_strings_ru.xtb | 4 +- .../translations/android_chrome_strings_sk.xtb | 2 +- .../translations/android_chrome_strings_sl.xtb | 2 +- .../translations/android_chrome_strings_sr.xtb | 2 +- .../translations/android_chrome_strings_sv.xtb | 2 +- .../translations/android_chrome_strings_sw.xtb | 2 +- .../translations/android_chrome_strings_ta.xtb | 2 +- .../translations/android_chrome_strings_te.xtb | 2 +- .../translations/android_chrome_strings_th.xtb | 2 +- .../translations/android_chrome_strings_tr.xtb | 2 +- .../translations/android_chrome_strings_uk.xtb | 2 +- .../translations/android_chrome_strings_vi.xtb | 2 +- .../translations/android_chrome_strings_zh-CN.xtb | 2 +- .../translations/android_chrome_strings_zh-TW.xtb | 2 +- chrome/app/resources/chromium_strings_el.xtb | 3 + chrome/app/resources/chromium_strings_en-GB.xtb | 3 + chrome/app/resources/generated_resources_am.xtb | 6 +- chrome/app/resources/generated_resources_ar.xtb | 6 +- chrome/app/resources/generated_resources_bg.xtb | 6 +- chrome/app/resources/generated_resources_bn.xtb | 6 +- chrome/app/resources/generated_resources_ca.xtb | 6 +- chrome/app/resources/generated_resources_cs.xtb | 6 +- chrome/app/resources/generated_resources_da.xtb | 6 +- chrome/app/resources/generated_resources_de.xtb | 6 +- chrome/app/resources/generated_resources_el.xtb | 31 ++++- chrome/app/resources/generated_resources_en-GB.xtb | 31 ++++- .../app/resources/generated_resources_es-419.xtb | 6 +- chrome/app/resources/generated_resources_es.xtb | 6 +- chrome/app/resources/generated_resources_et.xtb | 6 +- chrome/app/resources/generated_resources_fa.xtb | 6 +- chrome/app/resources/generated_resources_fi.xtb | 6 +- chrome/app/resources/generated_resources_fil.xtb | 6 +- chrome/app/resources/generated_resources_fr.xtb | 6 +- chrome/app/resources/generated_resources_gu.xtb | 6 +- chrome/app/resources/generated_resources_hi.xtb | 6 +- chrome/app/resources/generated_resources_hr.xtb | 6 +- chrome/app/resources/generated_resources_hu.xtb | 6 +- chrome/app/resources/generated_resources_id.xtb | 6 +- chrome/app/resources/generated_resources_it.xtb | 6 +- chrome/app/resources/generated_resources_iw.xtb | 6 +- chrome/app/resources/generated_resources_ja.xtb | 6 +- chrome/app/resources/generated_resources_kn.xtb | 6 +- chrome/app/resources/generated_resources_ko.xtb | 6 +- chrome/app/resources/generated_resources_lt.xtb | 6 +- chrome/app/resources/generated_resources_lv.xtb | 6 +- chrome/app/resources/generated_resources_ml.xtb | 6 +- chrome/app/resources/generated_resources_mr.xtb | 6 +- chrome/app/resources/generated_resources_ms.xtb | 6 +- chrome/app/resources/generated_resources_nl.xtb | 6 +- chrome/app/resources/generated_resources_no.xtb | 6 +- chrome/app/resources/generated_resources_pl.xtb | 6 +- chrome/app/resources/generated_resources_pt-BR.xtb | 6 +- chrome/app/resources/generated_resources_pt-PT.xtb | 6 +- chrome/app/resources/generated_resources_ro.xtb | 6 +- chrome/app/resources/generated_resources_ru.xtb | 6 +- chrome/app/resources/generated_resources_sk.xtb | 6 +- chrome/app/resources/generated_resources_sl.xtb | 6 +- chrome/app/resources/generated_resources_sr.xtb | 8 +- chrome/app/resources/generated_resources_sv.xtb | 8 +- chrome/app/resources/generated_resources_sw.xtb | 6 +- chrome/app/resources/generated_resources_ta.xtb | 6 +- chrome/app/resources/generated_resources_te.xtb | 6 +- chrome/app/resources/generated_resources_th.xtb | 6 +- chrome/app/resources/generated_resources_tr.xtb | 6 +- chrome/app/resources/generated_resources_uk.xtb | 6 +- chrome/app/resources/generated_resources_vi.xtb | 6 +- chrome/app/resources/generated_resources_zh-CN.xtb | 6 +- chrome/app/resources/generated_resources_zh-TW.xtb | 6 +- chrome/app/resources/google_chrome_strings_el.xtb | 3 + .../app/resources/google_chrome_strings_en-GB.xtb | 3 + .../policy/resources/policy_templates_am.xtb | 11 -- .../policy/resources/policy_templates_ar.xtb | 11 -- .../policy/resources/policy_templates_bg.xtb | 11 -- .../policy/resources/policy_templates_bn.xtb | 12 -- .../policy/resources/policy_templates_ca.xtb | 11 -- .../policy/resources/policy_templates_cs.xtb | 11 -- .../policy/resources/policy_templates_da.xtb | 11 -- .../policy/resources/policy_templates_de.xtb | 11 -- .../policy/resources/policy_templates_el.xtb | 55 ++++++-- .../policy/resources/policy_templates_en-GB.xtb | 55 ++++++-- .../policy/resources/policy_templates_es-419.xtb | 11 -- .../policy/resources/policy_templates_es.xtb | 11 -- .../policy/resources/policy_templates_et.xtb | 11 -- .../policy/resources/policy_templates_fa.xtb | 11 -- .../policy/resources/policy_templates_fi.xtb | 11 -- .../policy/resources/policy_templates_fil.xtb | 11 -- .../policy/resources/policy_templates_fr.xtb | 11 -- .../policy/resources/policy_templates_gu.xtb | 11 -- .../policy/resources/policy_templates_hi.xtb | 11 -- .../policy/resources/policy_templates_hr.xtb | 11 -- .../policy/resources/policy_templates_hu.xtb | 11 -- .../policy/resources/policy_templates_id.xtb | 11 -- .../policy/resources/policy_templates_it.xtb | 11 -- .../policy/resources/policy_templates_iw.xtb | 11 -- .../policy/resources/policy_templates_ja.xtb | 11 -- .../policy/resources/policy_templates_kn.xtb | 11 -- .../policy/resources/policy_templates_ko.xtb | 11 -- .../policy/resources/policy_templates_lt.xtb | 11 -- .../policy/resources/policy_templates_lv.xtb | 11 -- .../policy/resources/policy_templates_ml.xtb | 11 -- .../policy/resources/policy_templates_mr.xtb | 11 -- .../policy/resources/policy_templates_ms.xtb | 11 -- .../policy/resources/policy_templates_nl.xtb | 11 -- .../policy/resources/policy_templates_no.xtb | 11 -- .../policy/resources/policy_templates_pl.xtb | 11 -- .../policy/resources/policy_templates_pt-BR.xtb | 11 -- .../policy/resources/policy_templates_pt-PT.xtb | 11 -- .../policy/resources/policy_templates_ro.xtb | 11 -- .../policy/resources/policy_templates_ru.xtb | 11 -- .../policy/resources/policy_templates_sk.xtb | 11 -- .../policy/resources/policy_templates_sl.xtb | 11 -- .../policy/resources/policy_templates_sr.xtb | 11 -- .../policy/resources/policy_templates_sv.xtb | 11 -- .../policy/resources/policy_templates_sw.xtb | 11 -- .../policy/resources/policy_templates_ta.xtb | 11 -- .../policy/resources/policy_templates_te.xtb | 11 -- .../policy/resources/policy_templates_th.xtb | 11 -- .../policy/resources/policy_templates_tr.xtb | 11 -- .../policy/resources/policy_templates_uk.xtb | 11 -- .../policy/resources/policy_templates_vi.xtb | 11 -- .../policy/resources/policy_templates_zh-CN.xtb | 11 -- .../policy/resources/policy_templates_zh-TW.xtb | 11 -- components/strings/components_strings_am.xtb | 1 - components/strings/components_strings_ar.xtb | 1 - components/strings/components_strings_bg.xtb | 1 - components/strings/components_strings_bn.xtb | 1 - components/strings/components_strings_ca.xtb | 1 - components/strings/components_strings_cs.xtb | 1 - components/strings/components_strings_da.xtb | 1 - components/strings/components_strings_de.xtb | 1 - components/strings/components_strings_el.xtb | 153 ++++++++++++++++++++- components/strings/components_strings_en-GB.xtb | 142 ++++++++++++++++++- components/strings/components_strings_es-419.xtb | 1 - components/strings/components_strings_es.xtb | 1 - components/strings/components_strings_et.xtb | 1 - components/strings/components_strings_fa.xtb | 1 - components/strings/components_strings_fi.xtb | 1 - components/strings/components_strings_fil.xtb | 1 - components/strings/components_strings_fr.xtb | 1 - components/strings/components_strings_gu.xtb | 1 - components/strings/components_strings_hi.xtb | 1 - components/strings/components_strings_hr.xtb | 1 - components/strings/components_strings_hu.xtb | 1 - components/strings/components_strings_id.xtb | 1 - components/strings/components_strings_it.xtb | 1 - components/strings/components_strings_iw.xtb | 1 - components/strings/components_strings_ja.xtb | 1 - components/strings/components_strings_kn.xtb | 1 - components/strings/components_strings_ko.xtb | 1 - components/strings/components_strings_lt.xtb | 1 - components/strings/components_strings_lv.xtb | 1 - components/strings/components_strings_ml.xtb | 1 - components/strings/components_strings_mr.xtb | 1 - components/strings/components_strings_ms.xtb | 1 - components/strings/components_strings_nl.xtb | 1 - components/strings/components_strings_no.xtb | 1 - components/strings/components_strings_pl.xtb | 1 - components/strings/components_strings_pt-BR.xtb | 1 - components/strings/components_strings_pt-PT.xtb | 1 - components/strings/components_strings_ro.xtb | 1 - components/strings/components_strings_ru.xtb | 1 - components/strings/components_strings_sk.xtb | 1 - components/strings/components_strings_sl.xtb | 1 - components/strings/components_strings_sr.xtb | 1 - components/strings/components_strings_sv.xtb | 1 - components/strings/components_strings_sw.xtb | 1 - components/strings/components_strings_ta.xtb | 1 - components/strings/components_strings_te.xtb | 1 - components/strings/components_strings_th.xtb | 1 - components/strings/components_strings_tr.xtb | 1 - components/strings/components_strings_uk.xtb | 1 - components/strings/components_strings_vi.xtb | 1 - components/strings/components_strings_zh-CN.xtb | 1 - components/strings/components_strings_zh-TW.xtb | 1 - .../strings/translations/content_strings_el.xtb | 2 + .../strings/translations/content_strings_en-GB.xtb | 2 + .../app/strings/resources/ios_strings_ar.xtb | 2 +- .../app/strings/resources/ios_strings_el.xtb | 1 + .../app/strings/resources/ios_strings_en-GB.xtb | 1 + .../ios_search_widget_extension_strings_el.xtb | 4 + .../ios_search_widget_extension_strings_en-GB.xtb | 4 + ui/strings/translations/ui_strings_el.xtb | 10 ++ ui/strings/translations/ui_strings_en-GB.xtb | 10 ++ 275 files changed, 764 insertions(+), 890 deletions(-) commit 7c63835b7338f5396802282ad13949527ea5ed00 Author: Robert Ogden <robertogden@chromium.org> Date: Fri Feb 15 01:52:01 2019 +0000 Maybe trigger LitePageRedirect previews on every redirect Previously triggering was not being checked when the navigation's PreviewState didn't have LITE_PAGE_REDIRECT set at the start of the navigation. This CL fixes the bug by including the NavigationThrottle on every navigation and checking PreviewsState every time. Bug: 931939 Change-Id: Ia147e610500ce936a5327cc4004fbd118dfbd2c6 Reviewed-on: https://chromium-review.googlesource.com/c/1473394 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632450} .../previews/previews_lite_page_browsertest.cc | 6 ++++ .../browser/previews/previews_lite_page_decider.cc | 38 ++++++++-------------- .../previews_lite_page_navigation_throttle.cc | 16 ++++++--- .../previews_lite_page_navigation_throttle.h | 3 +- tools/metrics/histograms/enums.xml | 1 + 5 files changed, 34 insertions(+), 30 deletions(-) commit f310ca4b0fd7a5010c33ecf6324fb73572558ddf Author: Clark DuVall <cduvall@chromium.org> Date: Fri Feb 15 01:49:01 2019 +0000 Add tests for webRequest intercepting service worker requests ServiceWorkerFallback is a regression test for http://crbug.com/931588 Bug: 931588 Change-Id: Ifccb18fc33f895e3381cd1cb00770bea9b2bb6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1474682 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#632449} .../api/web_request/web_request_apitest.cc | 60 ++++++++++++++++++++++ 1 file changed, 60 insertions(+) commit bafce5893821300d55c2e6b017463b769a8f3a23 Author: Alli Murray <alliemurray@google.com> Date: Fri Feb 15 01:48:34 2019 +0000 Populate partitions of the removable root during setup. So that the UI reflects that the removable root has child partitions immediately after mounting. Bug: 918795 Change-Id: Ifb50c86c6a6ac169e489292693adc1b56c06b835 Reviewed-on: https://chromium-review.googlesource.com/c/1474870 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alli Murray <alliemurray@google.com> Cr-Commit-Position: refs/heads/master@{#632448} ui/file_manager/file_manager/foreground/js/ui/directory_tree.js | 3 +++ 1 file changed, 3 insertions(+) commit a11501145cc9f82c83df87b06d52cdb2c9073fb5 Author: Min Qin <qinmin@chromium.org> Date: Fri Feb 15 01:47:49 2019 +0000 Allow WebContentsImpl::FromRenderFrameHostId() to be called without UI thread In servicification mode, this could get called by NetworkServiceClient. An alternative change is to return nullptr in NetworkServiceClient if UI thread is not created, and we can also do a non-validity check on frame host Id BUG=930736 Change-Id: I9a3b85706fa5f283485e29ba5254a54341f57569 Reviewed-on: https://chromium-review.googlesource.com/c/1464351 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632447} content/browser/web_contents/web_contents_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 3dce8aeefd0e5c834a9aef3146f9a568bbf11c89 Author: Taiju Tsuiki <tzik@chromium.org> Date: Fri Feb 15 01:43:09 2019 +0000 Revert "Reland: Add vp9-alpha + canvas layout test." This reverts commit b2792e24ef97535b4f4201cfa1216cd3396e2772. Reason for revert: The test added by the original CL is failing on Mac bots. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/19660 https://test-results.appspot.com/data/layout_results/Mac10_12_Tests/19660/webkit_layout_tests/layout-test-results/results.html Original change's description: > Reland: Add vp9-alpha + canvas layout test. > > Simply moves the win7 expectation to win since they both use the > same one. Formats the HTML and adds a title too. > > --------------[ Original Description Below ]-------------- > > Apparently we don't have any vpx-alpha layout tests, hence macOS has > had broken support here for some time. > > BUG=919015 > TEST=fails without the macOS alpha fix. > TBR=dcastagna > > Change-Id: I9defe5b3750faeedd63ef0b62aaddb067a7fbc3f > Reviewed-on: https://chromium-review.googlesource.com/c/1471355 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632409} TBR=dalecurtis@chromium.org,dcastagna@chromium.org Change-Id: Ia62413749079498f0993e9e3f727a2ccf4834cfb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919015 Reviewed-on: https://chromium-review.googlesource.com/c/1474874 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#632446} .../media/alpha-video-playback-expected.png | Bin 3017 -> 0 bytes .../web_tests/media/alpha-video-playback.html | 37 --------------------- .../media/resources/white-square-vp9a.webm | Bin 17318 -> 0 bytes .../linux/media/alpha-video-playback-expected.png | Bin 3017 -> 0 bytes .../win/media/alpha-video-playback-expected.png | Bin 3104 -> 0 bytes 5 files changed, 37 deletions(-) commit 829632163d4d98ed89a067ab8791b74c6458aa20 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 01:42:47 2019 +0000 Roll src/third_party/chromite 43a449fd3566..25ca3f40d18c (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/43a449fd3566..25ca3f40d18c git log 43a449fd3566..25ca3f40d18c --date=short --no-merges --format='%ad %ae %s' 2019-02-14 jclinton@chromium.org Reland "default PreCQ: Remove betty-arcnext-pre-cq" 2019-02-14 gmeinke@chromium.org config: switch master-postsubmit to trigger Created with: gclient setdep -r src/third_party/chromite@25ca3f40d18c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifdb9b5242c7d04457b939cee9b165abb61b2e51f Reviewed-on: https://chromium-review.googlesource.com/c/1474432 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632445} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c5b35d29cd7ed534c1818e32cc1730c3608d6ee6 Author: Gabriel Marin <gmx@chromium.org> Date: Fri Feb 15 01:38:56 2019 +0000 tcmalloc: use 1MB chunk in MetaData allocator Using smaller chunks for these allocations prevents systems with always enabled transparent huge pages from mapping the memory to huge pages. The use of huge pages causes an increase in resident memory in Chromium. BUG=901951,b:119440521 Change-Id: I14dbf26f5358342900bf1faa074dc07fd4df0193 Reviewed-on: https://chromium-review.googlesource.com/c/1474808 Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#632444} third_party/tcmalloc/chromium/src/common.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit af508ec60f2a4041b59283191c53765941bb171b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 01:38:53 2019 +0000 Roll src/native_client ff15c51d2078..908d9f47b1b2 (11 commits) https://chromium.googlesource.com/native_client/src/native_client.git/+log/ff15c51d2078..908d9f47b1b2 git log ff15c51d2078..908d9f47b1b2 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 thakis@chromium.org Update revision for PNaCl 2019-02-14 thakis@chromium.org win toolchain build: Use mingw zip that doesn't include git. 2019-02-08 dschuff@chromium.org No-op commit to test recipe change 2019-01-24 thakis@chromium.org Update revision for PNaCl 2019-01-24 dschuff@chromium.org Whitespace change to command.py 2019-01-23 thakis@chromium.org comment change to trigger bots 2019-01-22 thakis@chromium.org Add even more debug logging. 2019-01-18 thakis@chromium.org Add some more logging. 2019-01-18 thakis@chromium.org Add some debug logging. 2019-01-18 dschuff@chromium.org Update CQ config to use only toolchain trybots when appropriate 2019-01-16 dschuff@chromium.org Update revision for PNaCl Created with: gclient setdep -r src/native_client@908d9f47b1b2 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:923062,chromium:923062,chromium:None,chromium:923062,chromium:None,chromium:923062,chromium:923062,chromium:923062,chromium:<none>,chromium:none TBR=mseaborn@chromium.org Change-Id: I5a49b9c6125a54efb01ab6538c720b1cddad2b27 Reviewed-on: https://chromium-review.googlesource.com/c/1474435 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632443} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a1c11b76a4e8fddcf0ea72834e26e5b6f317c045 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 01:37:51 2019 +0000 Roll src/third_party/catapult c79285cb0afd..778eee07409e (1 commits) https://chromium.googlesource.com/catapult.git/+log/c79285cb0afd..778eee07409e git log c79285cb0afd..778eee07409e --date=short --no-merges --format='%ad %ae %s' 2019-02-14 rmhasan@google.com Allows the expectations parser in Typ to store retry policies Created with: gclient setdep -r src/third_party/catapult@778eee07409e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902 TBR=sullivan@chromium.org Change-Id: I9707fbf1e33dec33757daf2a53790eeba6bddbe2 Reviewed-on: https://chromium-review.googlesource.com/c/1474387 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632442} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 77c840ab6da6aa0c1bfd1aaf0d94fd8c5a457ca9 Author: Nico Weber <thakis@chromium.org> Date: Fri Feb 15 01:37:48 2019 +0000 Remove semicolons in third_party/inspector_protocol. Bug: 926235 Change-Id: I3f54180e9301c70539cd11e29d406b298d3bf50e Reviewed-on: https://chromium-review.googlesource.com/c/1474790 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#632441} third_party/inspector_protocol/lib/CBOR_cpp.template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit ea61ddd7b83cb8797aba64fc6d495df2fb0f72a4 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Feb 15 01:36:48 2019 +0000 Roll src-internal dbffda048f2d..b9b926ab8438 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dbffda048f2d..b9b926ab8438 Created with: gclient setdep -r src-internal@b9b926ab8438 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:927262 TBR=mmoss@chromium.org Change-Id: Iae3fb312a060077a2740a6133181571dfec80f82 Reviewed-on: https://chromium-review.googlesource.com/c/1474310 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632440} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2464e932414ddfdef8e8f62127f2551cf871b49e Author: Caleb Rouleau <crouleau@chromium.org> Date: Fri Feb 15 01:36:45 2019 +0000 Re-add blink_perf.layout_ng benchmarks to FYI waterfall Bug: 913812 Change-Id: Iba94266d33cfb6b8166126a5a8d5ed4e6643d01a Reviewed-on: https://chromium-review.googlesource.com/c/1473837 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#632439} testing/buildbot/chromium.perf.fyi.json | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) commit 1106417e58d1f69ab49a2f21636f12a429313c25 Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Fri Feb 15 01:27:27 2019 +0000 Automated Commit: LKGM 11760.0.0 for chromeos. BUG=762641 TBR=tbarzic@google.com Change-Id: I061830b31e1865e6dd22404517ba7a15651d1c31 Reviewed-on: https://chromium-review.googlesource.com/c/1473590 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#632438} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e437a4688bfd0d31f371ffafa74f73353cbda074 Author: Miyoung Shin <myid.shin@igalia.com> Date: Fri Feb 15 01:25:42 2019 +0000 [s13n] Migrate SigninManagerAndroid's usage of O2TSDelegateAndroid::ValidateAccounts to IdentityManager This CL uses IdentityManager::LegacyReloadAccountsFromSystem that calls O2TSDelegateAndroid::ValidateAccounts internally. Bug: 905340 Change-Id: I7fc6f18ef59a88373a68ba0dee292e344a3af65e Reviewed-on: https://chromium-review.googlesource.com/c/1469813 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632437} chrome/browser/android/signin/signin_manager_android.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) commit b6994e2e7825d7fc6ef058ac432732de0bde26dc Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Feb 15 01:18:10 2019 +0000 Navi: Updated check icon direction and position to match RTL/LTR. Screenshot in bug. Bug: 932045 Change-Id: I135f3e63f5a62b4cbac30f5936678d5c8c764171 Reviewed-on: https://chromium-review.googlesource.com/c/1474830 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#632436} .../welcome/onboarding_welcome/shared/chooser_shared_css.html | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit fd68d09a9c4a0e46d60cbc4f7f41fd02312d283f Author: Robbie McElrath <rmcelrath@chromium.org> Date: Fri Feb 15 01:17:42 2019 +0000 Remove unused NetworkChangeNotifier in CrosUsbDetectorTest Bug: 911287 Change-Id: I2ff79eba3c4089d71eddc5602bf3f91e06efe4aa Reviewed-on: https://chromium-review.googlesource.com/c/1469367 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#632435} chrome/browser/chromeos/usb/cros_usb_detector_unittest.cc | 1 - 1 file changed, 1 deletion(-) commit f591b088d858e48666e32926cdb996315f24c142 Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Feb 15 01:17:02 2019 +0000 Fix for manifest generation not including ARCore entries in beta/stable Flag that controls inclusion of manifest entries related to ARCore is not set correctly on stable/beta channels. This is due to the fact that by default it's set to the value of `package_arcore`, which is ignored by other build rules when compiling bundles. The fix is to override the value of `include_arcore_manifest_flag` when building manifests for bundles. This will align the behaviors of those 2 flags when compiling bundles. Bug: 932193 Change-Id: I290664775c4349075a22b538f47a526a3d695693 Reviewed-on: https://chromium-review.googlesource.com/c/1473814 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#632434} chrome/android/BUILD.gn | 4 ++++ 1 file changed, 4 insertions(+) commit 33fba735d045ce521bdb4b6bb902d7330d6ce055 Author: Maggie Cai <mxcai@chromium.org> Date: Fri Feb 15 01:16:38 2019 +0000 Settings: Update the collapse child to be lazy rendering. Currently the origins under etld+1 entries are rendered on initial loading, however it is not necessary and can reduce the rendering performance. This CL makes the origin entries lazy rendered. BUG=835712 Change-Id: Id41ffc6eeafe6802d51f617cb1671d3d857144f2 Reviewed-on: https://chromium-review.googlesource.com/c/1469803 Reviewed-by: Patti <patricialor@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#632433} .../settings/site_settings/site_entry.html | 75 ++++++++++++---------- .../resources/settings/site_settings/site_entry.js | 5 +- .../test/data/webui/settings/site_entry_tests.js | 18 +++--- 3 files changed, 54 insertions(+), 44 deletions(-) commit c2a3758af7eccd4717947dc6b0ae0365800f762b Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Feb 15 01:10:35 2019 +0000 Import wpt@ce667da7c2cf7485f9d818deb67641613b0c5ef3 Using wpt-import in Chromium 603722e47a827067948b1864e4eea9ebdba11297. With Chromium commits locally applied on WPT: 14c111075b "Implement `Sec-CH-Lang`" af3b056c72 "[WPT] [wasm] Add JS-API tests for wasm threads" df760ab0b2 "Don't skip past auto-height flexboxes in quirks mode." 6cf9dcc6ec "Use testdriver Action API in WPT pointerevent touch tests" 5c3da78ee3 "Revert "Use testdriver Action API in WPT pointerevent touch tests"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I1a04b28b2eb68ce529ced11b12fe5f4ab5c38ca0 Reviewed-on: https://chromium-review.googlesource.com/c/1474676 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632432} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 176 ++++++++++----------- .../custom-elements/reactions/HTMLBaseElement.html | 21 +++ .../reactions/HTMLButtonElement.html | 46 +----- .../reactions/resources/reactions.js | 35 ++++ 4 files changed, 148 insertions(+), 130 deletions(-) commit 984c826e5e20f5a87f5aec21094ce6501f0718fe Author: Bence Béky <bnc@chromium.org> Date: Fri Feb 15 01:08:36 2019 +0000 Mock WriteHeaders on QuicSpdyStream instead of QuicSpdySession. In current Google QUIC, HEADERS are sent on a dedicated headers frame that is owned by QuicSpdySession. So QuicSpdyStream::WriteHeaders() calls QuicSpdySession::WriteHeaders(), which is virtual and is mocked in tests. However, in IETF QUIC, HEADERS will be sent on the request/response stream, so writing headers is more naturally done within QuicSpdyStream instead of QuicSpdySession. This CL does not move HEADERS to the request/response streams yet, but prepares tests for it by: * introducing virtual QuicSpdyStream::WriteHeadersImpl(), * mocking it for tests instead of mocking QuicSpdySession::WriteHeaders(), * renaming QuicSpdySession::WriteHeaders() to WriteHeadersOnHeadersStream(), * introducing QuicSpdySession::WriteHeadersOnHeadersStreamImpl(). In QuicSimpleServerSessionTests a test implementation of QuicSpdySession is used with regular QuicSpdyStreams. MockQuicSpdySession::WriteHeaders() used to prevent actual writes, but QuicSpdyStream::WriteHeadersImpl() is not overriden and writes do happen on the headers stream. gMock expectations are added accordingly. Testing for the stream id is lost in the process, but stream id is tested by QuicConnection::SendStreamData() expectations anyway. In other tests expectations are changed from the session object to the stream object. This CL lands server side changes 232878862 and 233946983 by bnc. Patch Set 1: server change 232878862. Patch Set 2: server change 233946983. Patch Set 3: Chromium changes. Change-Id: Id12c9691abc9a69d99c1dad854fcd929db8a6c3f Reviewed-on: https://chromium-review.googlesource.com/c/1473132 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#632431} net/quic/quic_chromium_client_session.cc | 11 ++-- net/quic/quic_chromium_client_session.h | 2 +- net/quic/quic_chromium_client_stream_test.cc | 8 +-- .../quic/core/http/quic_headers_stream_test.cc | 5 +- .../quic/core/http/quic_spdy_session.cc | 55 ++++++++-------- net/third_party/quic/core/http/quic_spdy_session.h | 9 +-- .../quic/core/http/quic_spdy_session_test.cc | 6 +- net/third_party/quic/core/http/quic_spdy_stream.cc | 15 +++-- net/third_party/quic/core/http/quic_spdy_stream.h | 5 ++ .../quic/core/http/quic_spdy_stream_test.cc | 73 ++++++++++++---------- .../quic/test_tools/quic_spdy_session_peer.cc | 11 ++-- .../quic/test_tools/quic_spdy_session_peer.h | 6 +- net/third_party/quic/test_tools/quic_test_utils.cc | 10 --- net/third_party/quic/test_tools/quic_test_utils.h | 18 ------ .../quic/tools/quic_simple_server_session_test.cc | 63 ++++++++----------- .../quic/tools/quic_simple_server_stream_test.cc | 69 +++++++++----------- 16 files changed, 167 insertions(+), 199 deletions(-) commit c404479f3ab8e055e3706781d686bd29bdcc0b39 Author: Jarryd <jarrydg@chromium.org> Date: Fri Feb 15 01:06:08 2019 +0000 Quota: Add SequenceChecker to QuotaDatabase Change-Id: I40db96e2558bacf3a000245ba8f29d27f0e36c91 Reviewed-on: https://chromium-review.googlesource.com/c/1460429 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#632430} storage/browser/quota/quota_database.cc | 29 +++++++++++++++++++++++++++++ storage/browser/quota/quota_database.h | 5 ++++- 2 files changed, 33 insertions(+), 1 deletion(-) commit 9535631d645e380f5de70ba796ff61273319e10a Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Feb 15 01:02:41 2019 +0000 BlinkMemoryMgt: Apply the macros of Allocator into the classes of renderer/core/dom The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, some of //blink/renderer/core/dom/ class have not yet been allocated with them so far. After some analyzes, they were concluded that for the case of PostponeTransitionScope, NamesMap, and Data, they make sense to use USING_FAST_MALLOC because they are used by other classes as a member variable with a smart pointer type. In the other classes case, it makes sense to use STATIC_ONLY because they only define static member functions. Bug: 919389 Change-Id: I2d827b3b4cef21a6e24ad92499d855af5fe2b79d Reviewed-on: https://chromium-review.googlesource.com/c/1473093 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#632429} third_party/blink/renderer/core/dom/child_node.h | 3 +++ third_party/blink/renderer/core/dom/document_lifecycle.h | 2 ++ third_party/blink/renderer/core/dom/document_or_shadow_root.h | 3 +++ third_party/blink/renderer/core/dom/document_statistics_collector.h | 3 +++ third_party/blink/renderer/core/dom/names_map.h | 3 +++ third_party/blink/renderer/core/dom/non_document_type_child_node.h | 3 +++ third_party/blink/renderer/core/dom/parent_node.h | 3 +++ third_party/blink/renderer/core/dom/space_split_string.h | 2 ++ 8 files changed, 22 insertions(+) commit e4527719044d22f412ce36f2c49dc9a9a65c25c6 Author: Eric Foo <efoo@chromium.org> Date: Fri Feb 15 01:01:03 2019 +0000 Remove ToTAndroidCFI Buildbot Bug: 861346 Change-Id: Icb700387cbf429b35199fe734bb2cd1caf8fae78 Reviewed-on: https://chromium-review.googlesource.com/c/1474777 Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#632428} infra/config/luci-milo.cfg | 1 - 1 file changed, 1 deletion(-) commit f5e609be61168248ef541971e4ec2805943ccf3d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 00:56:57 2019 +0000 Roll src/third_party/perfetto 4976b9f5f855..ee4db4b3e9e3 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/4976b9f5f855..ee4db4b3e9e3 git log 4976b9f5f855..ee4db4b3e9e3 --date=short --no-merges --format='%ad %ae %s' 2019-02-14 rsavitski@google.com Merge "pow2 fixup" Created with: gclient setdep -r src/third_party/perfetto@ee4db4b3e9e3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I31f424dc92e2a0eea1162c31d2aec601ef027fb5 Reviewed-on: https://chromium-review.googlesource.com/c/1474431 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632427} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bc4ba2e4032d25da85a94ce642731a249d753640 Author: Clark DuVall <cduvall@chromium.org> Date: Fri Feb 15 00:56:02 2019 +0000 Fix crash in ServiceWorkerNewScriptLoader::ResumeReadingBodyFromNet It looks like the network_loader_ gets reset in CommitCompleted(), but the binding may still send messages after that since this was bound with mojo::MakeStrongBinding. The class will only be deleted after the remote endpoint sees the connection closed, so it can send messages before that. Bug: 916098 Change-Id: I772ca9f03e4f9d5354278b8d36e73dff92195cda Reviewed-on: https://chromium-review.googlesource.com/c/1473402 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632426} .../browser/service_worker/service_worker_new_script_loader.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 6ac03a0046f1cd7988c808315734655c320d0640 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 15 00:55:30 2019 +0000 Roll Fuchsia SDK from 7f995e473d0d to 688f2ce0afdc The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I14e417469fe7b49073f60895b0a18898632402e0 Reviewed-on: https://chromium-review.googlesource.com/c/1474434 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#632425} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 05f16df251f27bf7290f722186c8e48b1690a93c Author: Stuart Langley <slangley@google.com> Date: Fri Feb 15 00:54:51 2019 +0000 Obsolete Drive UMA histograms that were added for crbug.com/229650 Obsoletes the following histograms: - Drive.DownloadFromDriveFileSize - Drive.TransferBlockedOnJobs - Drive.UploadToDriveFileSize Removes the code that was emitting the values. Bug: 931519 Change-Id: I32739944c3cfe5ef6dd0117fb2673ca3ddec5128 Reviewed-on: https://chromium-review.googlesource.com/c/1471971 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#632424} components/drive/job_scheduler.cc | 37 --------------------------------- tools/metrics/histograms/histograms.xml | 12 +++++++++++ 2 files changed, 12 insertions(+), 37 deletions(-) commit 5205acb304a240e28650a4fc890cac3a19a7c9a4 Author: Anastasia Helfinstein <anastasi@google.com> Date: Fri Feb 15 00:54:13 2019 +0000 Add a watchlist for Switch Access Bug: None Change-Id: I4465415fcf5b378aa0598684cf1ee84058483d44 Reviewed-on: https://chromium-review.googlesource.com/c/1474533 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#632423} WATCHLISTS | 4 ++++ 1 file changed, 4 insertions(+) commit e8850e49a67068e75c41165304cd7be5caa43c8b Author: Yann Dago <ydago@chromium.org> Date: Fri Feb 15 00:50:20 2019 +0000 Reload reporting info on policy and extensions changes Bug: 924632 Change-Id: I9ba550c5ccb54d06a41f7dfbef28b5a1ed3eecf4 Reviewed-on: https://chromium-review.googlesource.com/c/1440068 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#632422} chrome/browser/resources/management/BUILD.gn | 1 + .../resources/management/management_ui.html | 1 + .../browser/resources/management/management_ui.js | 9 ++ chrome/browser/ui/webui/management_ui_handler.cc | 100 ++++++++++++++++++++- chrome/browser/ui/webui/management_ui_handler.h | 39 ++++++++ 5 files changed, 148 insertions(+), 2 deletions(-) commit 922b91cda5d685850360651fd688e7547def15bb Author: Darwin Huang <huangdarwin@chromium.org> Date: Fri Feb 15 00:49:49 2019 +0000 Async Clipboard: Move repeated check into a function - no logic changes, just cleaning up code Change-Id: I3bb1943d3160a3e2007c86b9c6d0b1b5b05fc586 Reviewed-on: https://chromium-review.googlesource.com/c/1474290 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#632421} .../blink/renderer/modules/clipboard/clipboard_promise.cc | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) commit d7b316586cb4ba4579a4156207f88a475068f8d1 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Feb 15 00:49:00 2019 +0000 [CompositeAfterPaint] Create PaintOffsetTranslation for known to be composited This is to avoid full layer raster invalidation when the layer known to be composited changes paint offset. Bug: 921729 Change-Id: I3340c2104ac6a6187f082ce23c0ceff411eb8eda Reviewed-on: https://chromium-review.googlesource.com/c/1410165 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#632420} .../paint/compositing/compositing_reason_finder.cc | 26 +++ .../paint/compositing/compositing_reason_finder.h | 3 + .../core/paint/paint_property_tree_builder.cc | 174 +++++++++----------- .../core/paint/paint_property_tree_builder.h | 4 + .../core/paint/paint_property_tree_builder_test.cc | 29 +--- .../platform/graphics/compositing_reasons.h | 13 ++ .../enable-blink-features=CompositeAfterPaint | 153 ++++++++---------- ...for-fixed-position-under-transform-expected.txt | 2 + ...ositing-for-fixed-position-under-transform.html | 1 + ...s-ignores-hidden-dynamic-negzindex-expected.txt | 38 +++++ .../compositing/geometry/clip-expected.txt | 66 ++++++++ .../compositing/geometry/clip-inside-expected.txt | 67 ++++++++ .../geometry/clip-with-shadow-expected.txt | 64 ++++++++ .../geometry/preserve-3d-switching-expected.txt | 103 ++++++++++++ .../fixed-position-no-content-expected.txt | 16 ++ ...for-fixed-position-under-transform-expected.txt | 30 ++++ .../no-compositing-for-preserve-3d-expected.txt | 23 ++- .../overlap-child-layer-expected.txt | 36 +++++ .../layer-creation/overlap-clipping-expected.txt | 52 ++++++ .../layer-creation/rotate3d-overlap-expected.txt | 97 ++++++++++++ .../layer-creation/spanOverlapsCanvas-expected.txt | 18 +++ ...nto-ancestor-clipping-layer-change-expected.txt | 36 +++++ .../mask-with-small-content-rect-expected.png | Bin 7757 -> 0 bytes ...sive-clip-parent-if-parent-escaped-expected.txt | 15 +- .../compositing/overflow/rotate-clip-expected.txt | 13 +- ...rotate-then-clip-effect-interleave-expected.txt | 26 ++- .../overflow/rotate-then-clip-expected.txt | 13 +- .../squashing/opacity-squashed-owner-expected.txt | 34 ++++ .../repaint-child-of-squashed-expected.txt | 81 ++++++++++ .../will-change/composited-layers-expected.txt | 93 +++++++++-- ...osited-during-transition-layertree-expected.txt | 54 ++++++- ...-border-radius-force-backing-store-expected.txt | 35 ++++ ...layer-in-subpixel-composited-layer-expected.txt | 176 +++++++++++++++++++++ .../change-clip-composited-layer-expected.txt | 13 +- ...ited-float-under-composited-inline-expected.txt | 13 +- ...under-composited-inline-individual-expected.txt | 13 +- .../compositing/composited-layer-move-expected.txt | 29 ++++ ...omposited-layers-move-in-subpixels-expected.txt | 58 +++++++ ...-subpixel-offset-of-squashed-layer-expected.txt | 15 +- ...cked-float-under-composited-inline-expected.txt | 18 +++ .../composited-vertical-rl-overflow-expected.txt | 14 +- .../invalidation/position/fixed-scale-expected.txt | 57 +++++++ ...raster-under-invalidation-checking-expected.txt | 28 +++- .../repaint-overlay/layers-expected.txt | 23 ++- .../destroy-composited-scrollbar-expected.txt | 15 +- .../scroll/fixed-after-scroll-expected.txt | 37 +++++ .../composited-table-background-col-expected.txt | 16 +- ...table-background-col-initial-empty-expected.txt | 16 +- ...mposited-table-background-col-span-expected.txt | 30 +++- ...-background-col-span-initial-empty-expected.txt | 30 +++- ...mposited-table-background-colgroup-expected.txt | 16 +- ...-background-colgroup-initial-empty-expected.txt | 16 +- ...ed-table-background-composited-row-expected.txt | 16 +- ...round-composited-row-initial-empty-expected.txt | 16 +- .../table/composited-table-background-expected.txt | 16 +- ...ted-table-background-initial-empty-expected.txt | 16 +- ...-background-section-composited-row-expected.txt | 16 +- ...ction-composited-row-initial-empty-expected.txt | 16 +- ...omposited-table-background-section-expected.txt | 16 +- ...e-background-section-initial-empty-expected.txt | 16 +- 60 files changed, 1872 insertions(+), 304 deletions(-) commit e340fcaf756d69fe444d096a1c2124bcefeb6c5e Author: Matt Mueller <mattm@chromium.org> Date: Fri Feb 15 00:48:41 2019 +0000 Re-enable ClientCertStoreTest.CertAuthorityFiltering test. Add crypto::EnsureNSSInit to ClientCertStoreNSSTestDelegate, due to the use_byte_certs changes NSS will not have been initialized already. Bug: 716594,733922 Change-Id: I07f79cba8b482866ee9e2ea3e74355361393e5f8 Reviewed-on: https://chromium-review.googlesource.com/c/1474132 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#632419} net/ssl/client_cert_store_nss_unittest.cc | 2 ++ net/ssl/client_cert_store_unittest-inl.h | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) commit fb0e357e8c98325876c003fb909ddffcd01041ec Author: Alexander Timin <altimin@chromium.org> Date: Fri Feb 15 00:46:20 2019 +0000 [mojo] Add trace flow events to mojo tasks. This will allow us to connect a place which send the mojo message and the place which received it. R=rockot@google.com CC=dmurph@chromium.org BUG=932167 Change-Id: Iea1bb6f1645279d21ad329f983f4112469c138e0 Reviewed-on: https://chromium-review.googlesource.com/c/1473233 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#632418} mojo/public/cpp/bindings/BUILD.gn | 1 + mojo/public/cpp/bindings/lib/connector.cc | 4 +++ mojo/public/cpp/bindings/lib/message.cc | 39 +++++++++++++++++++++++-- mojo/public/cpp/bindings/lib/message_internal.h | 5 ++-- mojo/public/cpp/bindings/lib/tracing_helper.h | 20 +++++++++++++ 5 files changed, 64 insertions(+), 5 deletions(-) commit a98d07b33d3897a42090496f9c1421dafe6bea99 Author: Yao Xiao <yaoxia@chromium.org> Date: Fri Feb 15 00:42:49 2019 +0000 Support |allow-downloads-without-user-activation| flag It should be okay to support the flag without enabling the intervention feature (i.e. when a website adapts by adding the "allow-downloads-" token, we should no longer give deprecation warnings & should not give console errors "...invalid sandbox flag". Both would happen if we don't support the token.). Supporting the token will also change the result of IsSandboxed(kSandboxDownloads): previously it was always True; now it will be False if the "allow-downloads-" token is set. It will make the UseCounter DownloadInSandbox keep decreasing as more and more websites are adapting to the change. This also looks positive as it gives an idea of ongoing compatibility risk rather than the maximum risk. Bug: 539938 Change-Id: I002f1a556205344953dabf094849af7e1222dd9f Reviewed-on: https://chromium-review.googlesource.com/c/1471002 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#632417} .../ads_page_load_metrics_observer_browsertest.cc | 14 ++++---------- third_party/blink/renderer/core/frame/sandbox_flags.cc | 4 +--- .../renderer/core/html/html_iframe_element_sandbox.cc | 8 ++------ .../dom/HTMLIFrameElement/sandbox-feature-detection.html | 1 + 4 files changed, 8 insertions(+), 19 deletions(-) Updated tag 'tree_truth' (was b6671fc69729)