Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 35709 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: em1 INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LANG: en_US.UTF-8 LANGUAGE: en_US: LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8920781923361635392 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGICAL: em1 LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itruUt8l/luci_context.032697786 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot METHOD: dhcp NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 2 SWARMING_BOT_ID: build4-b9 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 433041afa57bdc11 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t UPSTART_EVENTS: local-filesystems net-device-up UPSTART_INSTANCE: UPSTART_JOB: swarming USER: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython XDG_RUNTIME_DIR: /run/user/1000 XDG_SESSION_ID: c1 _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 7fa8ccb5428e25f1ece3efe4d2560a1346c06512 Revert "Add the win::WMIRefresher class and use it in SystemMonitor" Kristi Park, Fri Feb 22 22:39:04 2019 +0000 f0a961b2fb8fcee156fa172b8ad00ce5e95c7a07 Roll src/third_party/pdfium 1aecf87b9620..36e541ccbf9f (2 commits) chromium-autoroll, Fri Feb 22 22:30:36 2019 +0000 f8416b631a227960504c62377309ad26efc83e68 Fix fieldtrial_testing_config studies for Autofill local card migration flow siyua, Fri Feb 22 22:30:31 2019 +0000 be4edfec18b7cd4314be973aee86e3faaf276424 Fix ErrorUtils.FormatErrorMessage_Death in official builds. Karandeep Bhatia, Fri Feb 22 22:28:58 2019 +0000 058e3d269e307b5176b9fd32dad9d44420063369 Allow Auto Picture-in-Picture for Chrome extensions François Beaufort, Fri Feb 22 22:27:58 2019 +0000 90ffaeaac0ad7a74c3e6c5f7f4b44214b70a562f Add the win::WMIRefresher class and use it in SystemMonitor Sebastien Marchand, Fri Feb 22 22:24:17 2019 +0000 6953dd17804df579ce545b9f31f1687948588cde Add BrowserSwitcherChrome{Path,Parameters} policies Nicolas, Fri Feb 22 22:19:12 2019 +0000 3efb6399ec27f7de9bc2db21656bf8a1ab761908 HTTPS Previews: Allow the DRP experiment to override Finch-provided one Robert Ogden, Fri Feb 22 22:13:58 2019 +0000 ff70c6a10592c0b87ed1dfa767d44be1dc01276f [Cros SR] Replace omnibox type in category ranker with specific subtypes. tby, Fri Feb 22 22:12:39 2019 +0000 906aab7c6bbe2ea4fd912d6f118c7b5543d2f1be Remove MediaRouterAction Takumi Fujimoto, Fri Feb 22 22:11:16 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 7fa8ccb5428e25f1ece3efe4d2560a1346c06512 Author: Kristi Park <kristipark@chromium.org> Date: Fri Feb 22 22:39:04 2019 +0000 Revert "Add the win::WMIRefresher class and use it in SystemMonitor" This reverts commit 90ffaeaac0ad7a74c3e6c5f7f4b44214b70a562f. Reason for revert: Breaks Win x64 Builder. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win%20x64%20Builder/63687 Original change's description: > Add the win::WMIRefresher class and use it in SystemMonitor > > This class will be used to retrieve the disk idle time on Windows (some > other performance counters will probably be added in the future). > > The metric will initially be used in the tracing infra to make it > easier to analyze the I/O activity in the slow reports we're getting > from the wild. > > The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373 > > Bug: 771478 > Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07 > Reviewed-on: https://chromium-review.googlesource.com/c/1349670 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634843} TBR=jwd@chromium.org,fdoray@chromium.org,oysteine@chromium.org,sebmarchand@chromium.org Change-Id: I857594acf56af3f050c1559a72269579f467a326 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 771478 Reviewed-on: https://chromium-review.googlesource.com/c/1484088 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634848} chrome/browser/BUILD.gn | 2 - .../metric_evaluator_helper_posix.cc | 5 - .../metric_evaluator_helper_posix.h | 1 - .../metric_evaluator_helper_win.cc | 25 +- .../metric_evaluator_helper_win.h | 32 --- .../metric_evaluator_helper_win_unittest.cc | 30 +-- .../browser/performance_monitor/system_monitor.cc | 14 +- .../browser/performance_monitor/system_monitor.h | 18 -- .../performance_monitor/system_monitor_unittest.cc | 55 ++-- .../browser/performance_monitor/wmi_refresher.cc | 279 --------------------- chrome/browser/performance_monitor/wmi_refresher.h | 101 -------- .../performance_monitor/wmi_refresher_unittest.cc | 59 ----- chrome/test/BUILD.gn | 1 - tools/metrics/histograms/enums.xml | 16 -- tools/metrics/histograms/histograms.xml | 26 -- 15 files changed, 19 insertions(+), 645 deletions(-) commit f0a961b2fb8fcee156fa172b8ad00ce5e95c7a07 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 22 22:30:36 2019 +0000 Roll src/third_party/pdfium 1aecf87b9620..36e541ccbf9f (2 commits) https://pdfium.googlesource.com/pdfium.git/+log/1aecf87b9620..36e541ccbf9f git log 1aecf87b9620..36e541ccbf9f --date=short --no-merges --format='%ad %ae %s' 2019-02-22 thestig@chromium.org Add more tests for AFPercent_Format(). 2019-02-22 thakis@chromium.org Another whitespace change to trigger bots. Created with: gclient setdep -r src/third_party/pdfium@36e541ccbf9f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934825 TBR=dsinclair@chromium.org Change-Id: Icf5b3dd16e4050c17706185fe0239a09dc11ae09 Reviewed-on: https://chromium-review.googlesource.com/c/1483826 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634847} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f8416b631a227960504c62377309ad26efc83e68 Author: siyua <siyua@chromium.org> Date: Fri Feb 22 22:30:31 2019 +0000 Fix fieldtrial_testing_config studies for Autofill local card migration flow Create two studies since the two features have two different chrome flags. Using one study would cause DCHECK failure (Feature has conflicting field trial overrides) in Chromium debug mode. Bug: 897998 Change-Id: Icf093329e30f660ce7697241f5fbcd0604a1f9ac Reviewed-on: https://chromium-review.googlesource.com/c/1474277 Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#634846} testing/variations/fieldtrial_testing_config.json | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) commit be4edfec18b7cd4314be973aee86e3faaf276424 Author: Karandeep Bhatia <karandeepb@chromium.org> Date: Fri Feb 22 22:28:58 2019 +0000 Fix ErrorUtils.FormatErrorMessage_Death in official builds. ErrorUtils.FormatErrorMessage_Death fails on official builds because failure messages aren't passed to CHECK in official builds. Modify the death regex for the test in official builds and fix the test. BUG=934831 Change-Id: I4b301410ce990e3ced014c5fa82c42d1fea98cce Reviewed-on: https://chromium-review.googlesource.com/c/1483938 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634845} extensions/common/error_utils_unittest.cc | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) commit 058e3d269e307b5176b9fd32dad9d44420063369 Author: François Beaufort <beaufort.francois@gmail.com> Date: Fri Feb 22 22:27:58 2019 +0000 Allow Auto Picture-in-Picture for Chrome extensions Change-Id: I81252edcac31490248001c59623b1da220136451 Reviewed-on: https://chromium-review.googlesource.com/c/1480455 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#634844} .../picture_in_picture_controller_impl.cc | 21 +++++++++++++++------ .../picture_in_picture_controller_impl.h | 5 +++++ 2 files changed, 20 insertions(+), 6 deletions(-) commit 90ffaeaac0ad7a74c3e6c5f7f4b44214b70a562f Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Fri Feb 22 22:24:17 2019 +0000 Add the win::WMIRefresher class and use it in SystemMonitor This class will be used to retrieve the disk idle time on Windows (some other performance counters will probably be added in the future). The metric will initially be used in the tracing infra to make it easier to analyze the I/O activity in the slow reports we're getting from the wild. The Windows specific code has been review by rogerta@ and forschaw@ in https://chromium-review.googlesource.com/c/chromium/src/+/1340373 Bug: 771478 Change-Id: Ie1988818f521097d6078ce67e597ec02115f4c07 Reviewed-on: https://chromium-review.googlesource.com/c/1349670 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#634843} chrome/browser/BUILD.gn | 2 + .../metric_evaluator_helper_posix.cc | 5 + .../metric_evaluator_helper_posix.h | 1 + .../metric_evaluator_helper_win.cc | 25 +- .../metric_evaluator_helper_win.h | 32 +++ .../metric_evaluator_helper_win_unittest.cc | 30 ++- .../browser/performance_monitor/system_monitor.cc | 14 +- .../browser/performance_monitor/system_monitor.h | 18 ++ .../performance_monitor/system_monitor_unittest.cc | 55 ++-- .../browser/performance_monitor/wmi_refresher.cc | 279 +++++++++++++++++++++ chrome/browser/performance_monitor/wmi_refresher.h | 101 ++++++++ .../performance_monitor/wmi_refresher_unittest.cc | 59 +++++ chrome/test/BUILD.gn | 1 + tools/metrics/histograms/enums.xml | 16 ++ tools/metrics/histograms/histograms.xml | 26 ++ 15 files changed, 645 insertions(+), 19 deletions(-) commit 6953dd17804df579ce545b9f31f1687948588cde Author: Nicolas <nicolaso@chromium.org> Date: Fri Feb 22 22:19:12 2019 +0000 Add BrowserSwitcherChrome{Path,Parameters} policies The value of these policies is written to cache.dat so IE knows how to open a URL in Chrome. Bug: 909878 Change-Id: I0410e9022b96f35354666946a19fa6492afc7963 Reviewed-on: https://chromium-review.googlesource.com/c/1476062 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#634842} .../browser_switcher/browser_switcher_prefs.cc | 63 ++++++++++++++++++---- .../browser_switcher/browser_switcher_prefs.h | 18 +++++++ .../browser_switcher_prefs_unittest.cc | 16 ++++++ .../browser_switcher_service_win.cc | 7 +-- .../configuration_policy_handler_list_factory.cc | 6 +++ chrome/test/data/policy/policy_test_cases.json | 17 ++++++ components/policy/resources/policy_templates.json | 61 ++++++++++++++++++++- tools/metrics/histograms/enums.xml | 2 + 8 files changed, 174 insertions(+), 16 deletions(-) commit 3efb6399ec27f7de9bc2db21656bf8a1ab761908 Author: Robert Ogden <robertogden@chromium.org> Date: Fri Feb 22 22:13:58 2019 +0000 HTTPS Previews: Allow the DRP experiment to override Finch-provided one This allows easier manual testing using chrome://flags Bug: 934376 Change-Id: Ic9bb78c8c8db20b5a8e6f0f8f5ce26d6897d7e52 Reviewed-on: https://chromium-review.googlesource.com/c/1483390 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#634841} .../previews_lite_page_navigation_throttle.cc | 10 +++++++ ...views_lite_page_navigation_throttle_unittest.cc | 34 +++++++++++++++++++--- 2 files changed, 40 insertions(+), 4 deletions(-) commit ff70c6a10592c0b87ed1dfa767d44be1dc01276f Author: tby <tby@chromium.org> Date: Fri Feb 22 22:12:39 2019 +0000 [Cros SR] Replace omnibox type in category ranker with specific subtypes. This CL makes a slightly expanded version of the Dolphin category ranking model that learns information on subtypes of omnibox results, eg. history results and bookmark results. This is guarded behind a Finch parameter. Bug: 931149 Change-Id: I01c9edef80aee9f7f386fe301ffcd44e0a18fc78 Reviewed-on: https://chromium-review.googlesource.com/c/1482095 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634840} chrome/browser/ui/app_list/search/mixer.cc | 13 ++-- .../search_result_ranker/ranking_item_util.cc | 54 ++++++++++++++++- .../search_result_ranker/ranking_item_util.h | 10 +++- .../ranking_item_util_unittest.cc | 69 ++++++++++++++++++++++ .../ui/app_list/search/tests/mixer_unittest.cc | 4 +- chrome/test/BUILD.gn | 1 + 6 files changed, 142 insertions(+), 9 deletions(-) commit 906aab7c6bbe2ea4fd912d6f118c7b5543d2f1be Author: Takumi Fujimoto <takumif@chromium.org> Date: Fri Feb 22 22:11:16 2019 +0000 Remove MediaRouterAction The new CastToolbarButton in the toolbar's trusted area is now enabled by default, so this CL removes the old Media Router toolbar action that was replaced by it. MediaRouterActionController is still used by the new icon, and will be renamed in a separate patch. Bug: 919185 Change-Id: I95842e657379f823bd483d0a3da00015f76d8255 Reviewed-on: https://chromium-review.googlesource.com/c/1395419 Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#634839} chrome/browser/policy/policy_browsertest.cc | 17 +- chrome/browser/ui/BUILD.gn | 2 - .../media_router_dialog_controller_impl_base.cc | 19 +- .../media_router_dialog_controller_impl_base.h | 16 - .../toolbar/component_toolbar_actions_factory.cc | 24 +- .../ui/toolbar/component_toolbar_actions_factory.h | 6 +- chrome/browser/ui/toolbar/media_router_action.cc | 332 --------------- chrome/browser/ui/toolbar/media_router_action.h | 156 -------- .../ui/toolbar/media_router_action_controller.cc | 35 +- .../ui/toolbar/media_router_action_controller.h | 34 +- .../media_router_action_controller_unittest.cc | 47 +-- .../ui/toolbar/media_router_action_unittest.cc | 348 ---------------- .../ui/toolbar/media_router_contextual_menu.cc | 55 +-- .../ui/toolbar/media_router_contextual_menu.h | 26 +- .../media_router_contextual_menu_unittest.cc | 53 +-- .../toolbar/mock_media_router_action_controller.cc | 6 +- .../ui/views/media_router/cast_toolbar_button.cc | 2 +- .../media_router/cast_toolbar_button_unittest.cc | 2 +- .../media_router_dialog_controller_views.cc | 1 - .../media_router/media_router_ui_browsertest.cc | 443 ++++++--------------- chrome/browser/ui/views/toolbar/toolbar_view.cc | 4 +- .../media_router_dialog_controller_webui_impl.cc | 2 - chrome/test/BUILD.gn | 1 - .../media_router_integration_browsertest.h | 1 - 24 files changed, 185 insertions(+), 1447 deletions(-) commit 6fc84d9077ceb07675bad29939ccebc0da988988 Author: Steven Valdez <svaldez@chromium.org> Date: Fri Feb 22 22:06:31 2019 +0000 Roll src/third_party/boringssl/src f109f2087..c18353d21 https://boringssl.googlesource.com/boringssl/+log/f109f2087349712d3ac717d15fab48e130618110..c18353d214c04da5349e97283d6d70b8176a96f8 The following commits have Chromium bugs associated: c18353d21 Add uint64_t support in CBS and CBB. TBR: davidben@chromium.org Bug: 634570 Change-Id: Id2c0d63f53bfd683ff20f9f2745f626201b78be4 Reviewed-on: https://chromium-review.googlesource.com/c/1483700 Reviewed-by: Steven Valdez <svaldez@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Auto-Submit: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#634838} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 612d357c2b8cacb6b2d80809b1167f22bbe3c774 Author: Alexis Hetu <sugoi@google.com> Date: Fri Feb 22 21:54:31 2019 +0000 Y and UV planes release mechanism fix The Y and UV planes weren't getting released properly because the local variables used in base::RetainBlock() are snapshots of their current values and do not get updated by subsequent code. In this case, y_surface and uv_surface would always be at their original value of EGL_NO_SURFACE and eglReleaseTexImage/eglDestroySurface would never get called. Using pointers to these values solves the issue, since the pointers do not get modified by subsequent code and the values can be checked properly by dereferencing the pointers. Bug: chromium:932986 chromium:929088 Change-Id: Id0b9fcc79af733b645eaf8fed12d905dd40e9fbc Reviewed-on: https://chromium-review.googlesource.com/c/1483690 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634837} ui/gl/gl_image_io_surface_egl.mm | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) commit 0cce9e79536830a404c869d39be37875b3520bfc Author: Dominik Röttsches <drott@chromium.org> Date: Fri Feb 22 21:53:38 2019 +0000 Fix emoji drawing coordinate in vertical text Due to issues we have with retrieving correct font metrics on Mac OS, due to [1, 2] when computing the vertical origin for Emoji Color Emoji we receive an incorrect vertical origin with a 0 y-value, which leads to an emoji glyph being placed too high. Fallback to retrieving the slightly inflated SkFont.getBounds when SkPath + getBounds() returns an empty rectangle, as it does for Apple Color Emoji. Added emoji-vertical-origin-visual.html test as part of own tests, but in the style of a WPT test. As far as I can tell, we cannot yet run pixel tests as part of WPT but I do not see a way to verify our rendering as a ref test. [1] https://bugs.chromium.org/p/skia/issues/detail?id=8779 [2] https://bugs.chromium.org/p/skia/issues/detail?id=5328 Test: fast/text/emoji-vertical-origin-visual.html Bug: 933264 Change-Id: I3487bf832b857764fb638a3f2df5803137d3fd66 Reviewed-on: https://chromium-review.googlesource.com/c/1480463 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#634836} .../platform/fonts/skia/skia_text_metrics.cc | 6 ++++++ .../fast/text/emoji-vertical-origin-visual.html | 19 +++++++++++++++++++ .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 13259 bytes .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 21426 bytes .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 21458 bytes .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 19214 bytes .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 18844 bytes .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 12156 bytes .../text/emoji-vertical-origin-visual-expected.png | Bin 0 -> 14573 bytes 9 files changed, 25 insertions(+) commit ccb112ce0223af8ea49a04c6672946d489ef8253 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Fri Feb 22 21:52:00 2019 +0000 [Windows installer]: Record lzma result in setup ArchivePatchHelper. This CL records value returned by UnPackArchive in a new histogram Setup.Install.LzmaUnPackResult This value contains result of GetLastError() if Unpack failed, or ERROR_SUCCESS. Following WinGetLastError are also added to handle WriteFile failure: INVALID_USER_BUFFER NOT_ENOUGH_QUOTA Bug: 933975 Change-Id: I6177bf738383a0212d054f3cf2ddd3ec6d0b9fda Reviewed-on: https://chromium-review.googlesource.com/c/1461083 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#634835} chrome/installer/setup/archive_patch_helper.cc | 2 +- chrome/installer/setup/setup_main.cc | 2 +- chrome/installer/setup/setup_util.cc | 22 ++++++++++++---------- chrome/installer/setup/setup_util.h | 4 +++- chrome/installer/setup/setup_util_unittest.cc | 10 ++++++++-- tools/metrics/histograms/enums.xml | 2 ++ tools/metrics/histograms/histograms.xml | 9 +++++++++ 7 files changed, 36 insertions(+), 15 deletions(-) commit 24ab3332c276b6208f2cbb96fbb69a3dbbd115b3 Author: Lily Chen <chlily@chromium.org> Date: Fri Feb 22 21:50:06 2019 +0000 Network Error Logging: Generate error reports on cancellation A network error should be reported if the resource fetch is aborted before it is complete: https://w3c.github.io/network-error-logging/#transmission-of-request-and-response-errors This CL adds NEL error generation (with report type ERR_ABORTED) for any HttpNetworkTransactions destructed without previously generating a success or error report. This guarantees that every HttpNetworkTransaction results in a NEL report. Successes are reported after receiving valid headers (if the response code is 4xx or 5xx, or if the body will not be read, or on a redirect), or after completely reading the body. Any other outcome is reported as an error. Bug: 934000 Change-Id: I8f71309c9cea0295546b23861fba6b131f72a3d7 Reviewed-on: https://chromium-review.googlesource.com/c/1480195 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634834} net/http/http_network_transaction.cc | 18 ++- net/http/http_network_transaction_unittest.cc | 113 ++++++++++++---- net/url_request/url_request_unittest.cc | 177 +++++++++++++++++++++++++- 3 files changed, 271 insertions(+), 37 deletions(-) commit 7ccae0e3d7cae0d642824a5875a3a95141c25ecb Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Feb 22 21:47:57 2019 +0000 Mark wpt/.../query-encoding/utf-16le.html also crash It almost always crash on CQ bot linux-rel. Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=query-encoding%2Futf-16le.html Bug: 930297 Change-Id: I456dddf952daffae77efdf023fe0790df4644d4a Reviewed-on: https://chromium-review.googlesource.com/c/1483684 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634833} third_party/blink/web_tests/TestExpectations | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit d7e861ce69c95aabd7246b77a3eb60ff4989732e Author: Tomasz Wiszkowski <ender@google.com> Date: Fri Feb 22 21:45:58 2019 +0000 Treat calculation Suggestions as answers. This change allows AnswerSuggestionProcessor to manage Calculation suggestions as well, ensuring all answers (including calculation) are uniformly processed when new answer layout is enabled. Bug: 920396 Change-Id: If233480827eb286131eae4a761b8cb9d210cdc3a Reviewed-on: https://chromium-review.googlesource.com/c/1481953 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#634832} .../omnibox/suggestions/AutocompleteMediator.java | 2 +- .../answer/AnswerSuggestionProcessor.java | 117 ++++++++++++--------- .../omnibox/suggestions/answer/AnswerText.java | 22 ++-- .../suggestions/answer/AnswerTextClassic.java | 33 ++++-- .../suggestions/answer/AnswerTextNewLayout.java | 33 ++++-- 5 files changed, 132 insertions(+), 75 deletions(-) commit 324eaf9e45353f865f6d40b1d071494c3877d7ea Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Feb 22 21:45:30 2019 +0000 Roll src/third_party/depot_tools 245337d62e22..151c3484da58 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/245337d62e22..151c3484da58 git log 245337d62e22..151c3484da58 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 sergiyb@chromium.org Replace post-process checks with ones that are not deprecated Created with: gclient setdep -r src/third_party/depot_tools@151c3484da58 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:899266 TBR=agable@chromium.org Change-Id: I8eda5926e8c32d8be88e9b5dcd5181a5fdf23230 Reviewed-on: https://chromium-review.googlesource.com/c/1483870 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634831} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 76232ef29fa556478a351e334a29eae71f362d25 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Feb 22 21:39:59 2019 +0000 cros: Add additional brand codes to kBrandCodeMap Bug: None Change-Id: Ibd0ba93f9b06aabe342f63b87443de46e8cf0023 Reviewed-on: https://chromium-review.googlesource.com/c/1483705 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#634830} .../google/google_brand_code_map_chromeos.cc | 79 +++++++++++++--------- 1 file changed, 47 insertions(+), 32 deletions(-) commit a3e4d14604cf4403caed57da074a863910643141 Author: Sidney San Martín <sdy@chromium.org> Date: Fri Feb 22 21:38:58 2019 +0000 Revert "[Vim/YCM] Fix missing system headers when YCM was built with its own libclang." This reverts commit 75a861f213f0a3156743b68b5b3a060849abcfa4. Reason for revert: It turns out this is an upstream issue. See: - https://chromium-review.googlesource.com/c/chromium/src/+/1482557 - https://github.com/Valloric/ycmd/pull/1193 Original change's description: > [Vim/YCM] Fix missing system headers when YCM was built with its own libclang. > > Bug: 932667 > Change-Id: I2eb9965da1eb3f9ad4a5ce103cf6e32d35019e48 > Reviewed-on: https://chromium-review.googlesource.com/c/1476105 > Auto-Submit: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Commit-Queue: Asanka Herath <asanka@chromium.org> > Reviewed-by: Asanka Herath <asanka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#632846} TBR=sdy@chromium.org,asanka@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 932667 Change-Id: I5a684c91723d28470e1d903cd74674ce145b421b Reviewed-on: https://chromium-review.googlesource.com/c/1483709 Reviewed-by: Sidney San Martín <sdy@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634829} tools/vim/chromium.ycm_extra_conf.py | 7 --- .../vim/tests/chromium.ycm_extra_conf_unittest.py | 70 ++++++++++------------ 2 files changed, 31 insertions(+), 46 deletions(-) commit f1e50fa576ec70370d614f08e04790b0e624c06b Author: bsheedy <bsheedy@chromium.org> Date: Fri Feb 22 21:35:06 2019 +0000 Automate VR manual test for suggestion hovering Automates a manual VR regression test that ensures that the hover state and hit testing of search suggestions in the VR browser function as expected. In order to prevent the test from flaking due to the blinking omnibox cursor, also adds the ability to crop images before comparing them in via the RenderTestRule. Bug: 887561 Change-Id: Ifddd18ff492b14bee08658251dc2191e7e481dcb Reviewed-on: https://chromium-review.googlesource.com/c/1479550 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#634828} .../chrome/browser/vr/VrBrowserNativeUiTest.java | 65 ++++++++++++++++++++++ .../chrome/browser/vr/util/RenderTestUtils.java | 39 ++++++++++++- ...suggestion_clicking_bottom.Pixel_XL-25.png.sha1 | 1 + ...suggestion_clicking_bottom.Pixel_XL-26.png.sha1 | 1 + ...t.suggestion_clicking_left.Pixel_XL-25.png.sha1 | 1 + ...t.suggestion_clicking_left.Pixel_XL-26.png.sha1 | 1 + ....suggestion_clicking_right.Pixel_XL-25.png.sha1 | 1 + ....suggestion_clicking_right.Pixel_XL-26.png.sha1 | 1 + ...st.suggestion_clicking_top.Pixel_XL-25.png.sha1 | 1 + ...st.suggestion_clicking_top.Pixel_XL-26.png.sha1 | 1 + ...suggestion_hovering_middle.Pixel_XL-25.png.sha1 | 1 + ...suggestion_hovering_middle.Pixel_XL-26.png.sha1 | 1 + ...st.suggestion_hovering_top.Pixel_XL-25.png.sha1 | 1 + ...st.suggestion_hovering_top.Pixel_XL-26.png.sha1 | 1 + 14 files changed, 113 insertions(+), 3 deletions(-) commit c49f8f01e85f10233d352a1d52eb478e31394f4a Author: Kristi Park <kristipark@chromium.org> Date: Fri Feb 22 21:29:21 2019 +0000 Disable failing PreviewsLitePageServerBrowserTest test The following tests fail on Linux trybots: URLLoaderImplementation/PreviewsLitePageServerBrowserTest.LitePagePreviewsTriggering/0 URLLoaderImplementation/PreviewsLitePageServerBrowserTest.ReloadingLitePagesDisablesLitePages/0 TBR=ryansturm@chromium.org Bug: 934955 Change-Id: I9701e912909d694fe4cdbd3f2a3f8dc3c5de6723 Reviewed-on: https://chromium-review.googlesource.com/c/1483674 Reviewed-by: Kristi Park <kristipark@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634827} chrome/browser/previews/previews_lite_page_browsertest.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) Updated tag 'tree_truth' (was 5b911be859f2)