Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 36967 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8920770680679596720 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itq4RRP2/luci_context.604203361 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: gce-trusty-e833d7b0-us-west1-a-n77b SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4330e54bf81fe611 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 49e7f1732857984237a878223d544b8fb030e677 [Feed] Synchronize has content between scheduler and Feed. Sky Malice, Sat Feb 23 00:43:42 2019 +0000 6e2f059263d9764613bcc365a0a330eb9fdb7ed0 Reland "Quota: Add SequenceChecker to QuotaManager" Jarryd, Sat Feb 23 00:43:17 2019 +0000 0417faad361d4301de2bdf159c987ce1e786dcab Revert "[Power ML] Change UserActivityPrediction flag to enabled" Kristi Park, Sat Feb 23 00:42:02 2019 +0000 079c096db386a17f7f0b058b5de82a3835f24d9f [AW NS] provide proper user_agent in onDownloadStart callback and add tests Tim Volodine, Sat Feb 23 00:31:56 2019 +0000 929f77d4173022a731ae91218ce6894d20f87f35 Cleanup media BitReader ReadBits() calls Chris Cunningham, Sat Feb 23 00:30:57 2019 +0000 6ccadefdb9ddaf33af1123bf454bbf36c2aac34e Revert "Move the known CT logs to the read-only data segment" Bruce Dawson, Sat Feb 23 00:30:04 2019 +0000 f66ab2619bc9d063d2a11ac50d8b153b73f00491 Fixed a crash in AutoResumptionHandler Shakti Sahu, Sat Feb 23 00:26:41 2019 +0000 1a6c92dfc78d18eb270bf7e071351da268cb0f80 NetLog: Rework ConnectJob logging. Matt Menke, Sat Feb 23 00:25:38 2019 +0000 047cb6b71b9f55363c1408b83099b3dac406ed64 Fix --force-fieldtrials= changing group of unrelated trials. Alexei Svitkine, Sat Feb 23 00:20:43 2019 +0000 5a2d490901b78a58633f0c633187bd06fe2085b3 Changes to include fast app reinstall in chrome://flags. Rob Schonberger, Sat Feb 23 00:18:46 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 49e7f1732857984237a878223d544b8fb030e677 Author: Sky Malice <skym@chromium.org> Date: Sat Feb 23 00:43:42 2019 +0000 [Feed] Synchronize has content between scheduler and Feed. Both the Feed and the host have redundant tracking of several fields. The scheduler is forced into this because it needs to know some of these outside of when ShouldSessionRequestData() is called. However, when this method is called, we get authoritative versions of them from the Feed library. This change adds synchronization logic to copy the Feed's version of has content to the scheduler. Additionally, the synchronization logic around outstanding requests is updated to go both ways. Previously it only copied the being set state over, and assumed the other direction wouldn't happen. This change was made because we're trying to reduce the number of assumptions we are making and measure things direction. Also added metrics around syncing these two values. Bug: 908963 Change-Id: I47303421d656e5c714e0a4e346e27ee8168bdfb8 Reviewed-on: https://chromium-review.googlesource.com/c/1480650 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#634893} components/feed/core/feed_scheduler_host.cc | 69 ++++++++++++++++++---- .../feed/core/feed_scheduler_host_unittest.cc | 28 ++++++++- tools/metrics/histograms/enums.xml | 7 +++ tools/metrics/histograms/histograms.xml | 27 +++++++++ 4 files changed, 117 insertions(+), 14 deletions(-) commit 6e2f059263d9764613bcc365a0a330eb9fdb7ed0 Author: Jarryd <jarrydg@chromium.org> Date: Sat Feb 23 00:43:17 2019 +0000 Reland "Quota: Add SequenceChecker to QuotaManager" This is a reland of d82ad3d0eee4f2b98d6f7be7fb2489c55713da69 In the original CL, QuotaManager was modified in two ways: 1. Added SequenceChecker 2. Remove custom deleter and inherit RefCountedDeleteOnSequence In the reland, I split out the latter into a separate CL and this CL only adds SequenceChecker to QuotaManager. This was done to minimize the impact of a potential revert. RefCountedDeleteOnSequence CL: https://crrev.com/c/1481591 Original change's description: > Quota: Add SequenceChecker to QuotaManager > > Change-Id: I7caa60bf82fdcd63469d58afa0e29f893795ae32 > Reviewed-on: https://chromium-review.googlesource.com/c/1457000 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Victor Costan <pwnall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#631891} Change-Id: Ia6076d9076e0e0f646b4286a8533ca0a964e3903 Reviewed-on: https://chromium-review.googlesource.com/c/1479302 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#634892} storage/browser/quota/quota_manager.cc | 63 ++++++++++++++++++++++++++++++++++ storage/browser/quota/quota_manager.h | 7 +++- 2 files changed, 69 insertions(+), 1 deletion(-) commit 0417faad361d4301de2bdf159c987ce1e786dcab Author: Kristi Park <kristipark@chromium.org> Date: Sat Feb 23 00:42:02 2019 +0000 Revert "[Power ML] Change UserActivityPrediction flag to enabled" This reverts commit 12c3b65c5985b37ae77fdb161e09cc21168dbf26. Reason for revert: Suspect for failing PowerPolicy browser_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20473 Original change's description: > [Power ML] Change UserActivityPrediction flag to enabled > > Bug: 862461 > Change-Id: I624d39293e50754629b3b30990828af73f57f0b3 > Reviewed-on: https://chromium-review.googlesource.com/c/1482281 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Jia Meng <jiameng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634856} TBR=derat@chromium.org,holte@chromium.org,jiameng@chromium.org Change-Id: Ic6cee677470af06e5ef5de8d362a2978a37291c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 862461, 935044 Reviewed-on: https://chromium-review.googlesource.com/c/1484821 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634891} .../chromeos/power/ml/smart_dim/model_impl.cc | 46 ++++++++---- .../chromeos/power/ml/smart_dim/model_impl.h | 3 +- .../chromeos/power/ml/smart_dim/model_unittest.cc | 19 +++++ .../power/ml/user_activity_manager_unittest.cc | 81 ---------------------- chromeos/constants/chromeos_features.cc | 2 +- tools/metrics/histograms/enums.xml | 4 -- 6 files changed, 53 insertions(+), 102 deletions(-) commit 079c096db386a17f7f0b058b5de82a3835f24d9f Author: Tim Volodine <timvolodine@chromium.org> Date: Sat Feb 23 00:31:56 2019 +0000 [AW NS] provide proper user_agent in onDownloadStart callback and add tests The user agent is not necessarily set in the request headers during InterceptDownload (e.g. because they are not initialized yet). In this patch: - make sure a user agent is set in the case of uninitialized headers. - make sure the user agent override is used when it is set by using WebSetting.setUserAgentString(). - add download related instrumentation tests for the user agent setting. Tests: - AwContentsTest.testDownload - AwContentsTest.testDownloaWithCustomUserAgent BUG=893568,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Ifc432fd93dd68ffb7416a25b6d6d1b5d1021e327 Reviewed-on: https://chromium-review.googlesource.com/c/1477606 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#634890} .../browser/aw_download_manager_delegate.cc | 17 +++++++++++----- .../browser/aw_download_manager_delegate.h | 6 ++++++ .../android_webview/test/AwContentsTest.java | 23 ++++++++++++++++++++++ 3 files changed, 41 insertions(+), 5 deletions(-) commit 929f77d4173022a731ae91218ce6894d20f87f35 Author: Chris Cunningham <chcunningham@chromium.org> Date: Sat Feb 23 00:30:57 2019 +0000 Cleanup media BitReader ReadBits() calls Initialize temporary values, check return values. Small tweaks to solution proposed by adtolbar@microsoft.com. Bug: 929962 Change-Id: Iaa7da7534174882d040ec7e4c353ba5cd0da5735 Reviewed-on: https://chromium-review.googlesource.com/c/1481085 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#634889} media/base/bit_reader_core.cc | 1 + media/base/bit_reader_core.h | 5 +++-- media/base/container_names.cc | 18 ++++++++++++++---- 3 files changed, 18 insertions(+), 6 deletions(-) commit 6ccadefdb9ddaf33af1123bf454bbf36c2aac34e Author: Bruce Dawson <brucedawson@chromium.org> Date: Sat Feb 23 00:30:04 2019 +0000 Revert "Move the known CT logs to the read-only data segment" This reverts commit 90aef9d95d98c323811bc8ac8ae86570954c6d8c now that we don't need to work around the VC++ bug. The structure definition move enough that git couldn't actually do the revert but the four remaining struct members had 'const' manually reapplied. Bug: 934323 Change-Id: I605de24decdf24aae4ccbe7af31a44013f21ae7e Reviewed-on: https://chromium-review.googlesource.com/c/1483949 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#634888} components/certificate_transparency/ct_known_logs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit f66ab2619bc9d063d2a11ac50d8b153b73f00491 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Sat Feb 23 00:26:41 2019 +0000 Fixed a crash in AutoResumptionHandler Bug: 931135 Change-Id: I0358a80dfd25ef009a93703663f6170160586e51 Reviewed-on: https://chromium-review.googlesource.com/c/1483359 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634887} chrome/browser/android/download/download_controller.cc | 3 ++- components/download/public/common/auto_resumption_handler.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) commit 1a6c92dfc78d18eb270bf7e071351da268cb0f80 Author: Matt Menke <mmenke@chromium.org> Date: Sat Feb 23 00:25:38 2019 +0000 NetLog: Rework ConnectJob logging. This CL makes it so that the events for nested ConnectJobs are nested within their parent ConnectJob. This both reduces the number of top level CONNECT_JOB events in logs, making navigation between top-level events easier, and makes it easier to see all information related to establishing a single connection at once. This didn't used to be possible because there was a socket pool between nested ConnectJob classes, which introduced a layer of late binding. However, most of those intermediary socket pools have been removed, so the events can now be nested directly, for the most part. Bug: 926899 Change-Id: I7d51ae9e164560fdb0396f21b0ac85370c4b7ae7 Reviewed-on: https://chromium-review.googlesource.com/c/1478259 Reviewed-by: Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#634886} net/http/http_proxy_client_socket_wrapper.cc | 5 ++- net/http/http_proxy_connect_job.cc | 17 ++++---- net/http/http_proxy_connect_job.h | 3 +- net/http/http_proxy_connect_job_unittest.cc | 2 +- net/log/net_log_event_type_list.h | 28 ++++++++++--- net/socket/client_socket_pool_base_unittest.cc | 40 +++++++++---------- net/socket/connect_job.cc | 40 ++++++++++++------- net/socket/connect_job.h | 19 +++++++-- net/socket/connect_job_unittest.cc | 54 +++++++++++++------------- net/socket/socks_connect_job.cc | 16 +++++--- net/socket/socks_connect_job.h | 3 +- net/socket/socks_connect_job_unittest.cc | 25 ++++++------ net/socket/ssl_connect_job.cc | 18 ++++++--- net/socket/ssl_connect_job.h | 3 +- net/socket/ssl_connect_job_unittest.cc | 2 +- net/socket/transport_client_socket_pool.cc | 8 ++-- net/socket/transport_connect_job.cc | 26 +++++++------ net/socket/transport_connect_job.h | 6 ++- net/socket/transport_connect_job_unittest.cc | 42 ++++++++++---------- net/socket/websocket_transport_connect_job.cc | 9 +++-- net/socket/websocket_transport_connect_job.h | 3 +- net/spdy/spdy_proxy_client_socket_unittest.cc | 3 +- 22 files changed, 218 insertions(+), 154 deletions(-) commit 047cb6b71b9f55363c1408b83099b3dac406ed64 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Sat Feb 23 00:20:43 2019 +0000 Fix --force-fieldtrials= changing group of unrelated trials. The command-line flag would turn off UMA, so as not to bias server- side data. But this had the consequence of changing how all field trials are randomized (causing the low entropy source to be used), which would cause unintended side-effects and in particular make it very hard to effectively debug trial behavior. This change updates the logic so that specifying that flag does not change the state of UMA consent, but instead changes the state of UMA reporting. This way, field trials are still randomized the same way, but UMA data is not reported. Includes a unit test. Bug: 932273 Change-Id: I4216bb23a9784d963f30d0e2516e1e4d31784ab7 Reviewed-on: https://chromium-review.googlesource.com/c/1479632 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634885} .../metrics/chrome_metrics_service_accessor.h | 2 + .../chrome_metrics_services_manager_client.cc | 42 ++++++++----- .../chrome_metrics_services_manager_client.h | 3 + ...ome_metrics_services_manager_client_unittest.cc | 69 ++++++++++++++++++++++ chrome/test/BUILD.gn | 1 + components/metrics/enabled_state_provider.cc | 10 +++- components/metrics/metrics_service_accessor.cc | 7 +-- 7 files changed, 112 insertions(+), 22 deletions(-) commit 5a2d490901b78a58633f0c633187bd06fe2085b3 Author: Rob Schonberger <robsc@chromium.org> Date: Sat Feb 23 00:18:46 2019 +0000 Changes to include fast app reinstall in chrome://flags. Bug: 911427 Change-Id: Ic33fd7507d36d0e847598722067ce64802718f9e Reviewed-on: https://chromium-review.googlesource.com/c/1484391 Reviewed-by: Jenny Zhang <jennyz@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#634884} chrome/browser/about_flags.cc | 4 ++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ 3 files changed, 13 insertions(+) commit 3a20255bcada0da18ad0b0d7f41fa4856e78371e Author: Tim Song <tengs@chromium.org> Date: Sat Feb 23 00:16:02 2019 +0000 ScrollView: Fix ScrollToPosition() to also update the ScrollBar position. Using ScrollToPosition() can cause the ScrollView and ScrollBar states to go out of sync, which causes strange scrolling UX behaviour. BUG=934013 Change-Id: I4b1518c49c87431baa9d32425f9bff7fc41b4608 Reviewed-on: https://chromium-review.googlesource.com/c/1480194 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#634883} .../unified_message_center_view_unittest.cc | 9 ++++--- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/scroll_view_unittest.cc | 28 ++++++++++++++++++++++ 3 files changed, 35 insertions(+), 4 deletions(-) commit d21e1ce95516fe76b86ea5be37c941741179a536 Author: Bruce Dawson <brucedawson@chromium.org> Date: Sat Feb 23 00:13:11 2019 +0000 Revert "Move some sniffer arrays to read-only data segment" This reverts commit 40b53de7f19c627cca389d0904916ba81af58924 now that we don't need to work around the VC++ bug. Bug: 934323 Change-Id: I7075d80778737666a906007b73b4a53d350fa772 Reviewed-on: https://chromium-review.googlesource.com/c/1484413 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#634882} net/base/mime_sniffer.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 8fc6db2431405777d4c300b5741e0540d5120e6d Author: Thanh Nguyen <thanhdng@chromium.org> Date: Sat Feb 23 00:10:43 2019 +0000 [Cros SR] Add training for Arc App Shorcuts See here for context: https://docs.google.com/document/d/1GTQ3vvrszK4I1pDzmTFb6krmUzAXox0V9ZIqIi_GH1E/edit?usp=sharing We are expanding Roselle to re-rank the results returned when the user enters a query. However, these results include Arc app shortcuts as well as apps themselves, so they need to be ranked. This CL adds the training support for Arc App Shortcuts and use Roselle score to update current relevance score. Bug: 931149 Change-Id: I979ebd500504681c9b0c0e59aa0412b4cbd47315 Reviewed-on: https://chromium-review.googlesource.com/c/1481176 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#634881} .../arc/arc_app_shortcuts_search_provider.cc | 29 +++++++++++++++------- .../search/arc/arc_app_shortcuts_search_provider.h | 4 +-- .../arc_app_shortcuts_search_provider_unittest.cc | 26 +++++++++++++++++++ 3 files changed, 48 insertions(+), 11 deletions(-) commit 60b9fd39fff42574fd976c391843dcb234a81a34 Author: Joone Hur <joone.hur@intel.com> Date: Sat Feb 23 00:10:26 2019 +0000 Let DisplayManager own DisplayConfigurator ui::DisplayManager can be the single interface for ozone-gbm clients by moving DisplayConfigurator under DisplayManager which can simplify the relationship between CrOS shell and ui/Display/Manager. In addition, this change will allow ui::DisplayManager to directly use ui::DisplayConfigurator without ash::WindowTreeHostManager. For more details, see the design document at http://bit.ly/2FBXL2c Bug: 922182 Change-Id: I0e1284024cf89b8369bd8c322473a61a9d9fe07e Reviewed-on: https://chromium-review.googlesource.com/c/1418315 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#634880} ash/display/display_manager_unittest.cc | 11 ++--- ash/display/window_tree_host_manager.cc | 4 -- ash/display/window_tree_host_manager.h | 1 - ash/shell.cc | 47 +++++++++++----------- ash/shell.h | 7 +--- .../night_light/night_light_controller_unittest.cc | 14 +++---- .../display/output_protection_controller_ash.cc | 1 + .../display/output_protection_controller_ash.h | 1 - components/arc/power/arc_power_bridge.cc | 1 + components/exo/wm_helper_chromeos.cc | 6 +-- ui/display/manager/display_change_observer.cc | 10 ++--- ui/display/manager/display_change_observer.h | 7 +--- ui/display/manager/display_manager.cc | 26 +++++++++++- ui/display/manager/display_manager.h | 19 ++++++--- 14 files changed, 80 insertions(+), 75 deletions(-) commit c07a8c6bd1d22f328cd6f52b2ac269633d1370af Author: Kevin Marshall <kmarshall@chromium.org> Date: Sat Feb 23 00:09:21 2019 +0000 [fuchsia] Modify runner scripts and build files to use new symbolizer. * Modify the stream-merging code to output to a pipe instead of a Python generator, so that the "symbolize" tool can read both app and kernel logs. * Rename "build_manifest.py" to "prepare_package_inputs.py" to better capture the broader scope of that script. * Add ids.txt generation logic to prepare_package_inputs.py. * Remove dead codepath for disabling symbolization. Symbolization has been forced-on by the build scripts with no issues so far, so having an opt-out is unnecessary. Bug: 772252 Change-Id: I4e01d0fc5ce96521efa6d0d394e629cb5c7985ff Reviewed-on: https://chromium-review.googlesource.com/c/1474032 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#634879} build/config/fuchsia/package.gni | 9 +- ...build_manifest.py => prepare_package_inputs.py} | 60 +++++- build/config/fuchsia/rules.gni | 3 +- build/fuchsia/common_args.py | 3 - build/fuchsia/create_runner_script.py | 3 - build/fuchsia/run_package.py | 109 +++++++--- build/fuchsia/symbolizer.py | 237 ++------------------- 7 files changed, 159 insertions(+), 265 deletions(-) commit fd656a83548779d3fd05c469a8cc6e81689780b8 Author: Kristi Park <kristipark@chromium.org> Date: Sat Feb 23 00:09:17 2019 +0000 Revert "Add flag for #omnibox-deduplicate-drive-urls" This reverts commit 703661c8155e5f1a0370fa56fa133f24c36de0d8. Reason for revert: Suspect for failing unit_tests, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20473 Original change's description: > Add flag for #omnibox-deduplicate-drive-urls > > Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde > Reviewed-on: https://chromium-review.googlesource.com/c/1481121 > Commit-Queue: Travis Skare <skare@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634850} TBR=jdonnelly@chromium.org,skare@chromium.org Change-Id: I2b663fc6154ef05e860913f3023e86fc3ed16ca4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1484578 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634878} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- 3 files changed, 13 deletions(-) commit 3bb6ace3c5c824cdee2b3bf335ceb05ded0e2d22 Author: Bruce Dawson <brucedawson@chromium.org> Date: Sat Feb 23 00:00:06 2019 +0000 Revert "Move seven small arrays to read-only data segment" This reverts commit aef5c1f5d4a23b24300e2bc3e2099c14e48ce21e now that we don't need to work around the VC++ bug. Only the removal of const to work around the VC++ bug was reverted. The additions of const to move data to the const data segment were retained. Bug: 934323 Change-Id: I833f62b4b832cdbb2d07436800bc28145c388f86 Reviewed-on: https://chromium-review.googlesource.com/c/1483948 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#634877} chrome/browser/themes/browser_theme_pack.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 7fb0508eb4b0e33eaffe72043bf66626479b7c73 Author: Marcin Wiącek <marcin@mwiacek.com> Date: Fri Feb 22 23:58:46 2019 +0000 Migrate Orientation to the @IntDef @IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing @Orientation interface in the form common with Chrome @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: I6e96496eedf82253687c287ea7a70b3c92f63ace Reviewed-on: https://chromium-review.googlesource.com/c/1480450 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#634876} .../org/chromium/chrome/browser/compositor/layouts/Layout.java | 10 ++++++---- .../chrome/browser/compositor/layouts/LayoutManager.java | 2 +- .../browser/compositor/layouts/phone/StackLayoutBase.java | 4 ++-- .../compositor/layouts/phone/stack/OverlappingStack.java | 2 +- .../chrome/browser/compositor/layouts/phone/stack/Stack.java | 6 +++--- .../browser/compositor/layouts/phone/stack/StackAnimation.java | 3 ++- .../browser/compositor/layouts/phone/stack/StackTab.java | 2 +- 7 files changed, 16 insertions(+), 13 deletions(-) commit 15d707e7b35a8242a4c5306da65b64b356cc40ff Author: Ahmed Fakhry <afakhry@chromium.org> Date: Fri Feb 22 23:54:21 2019 +0000 Add flag to list all modes of external displays This CL adds a flag that enables listing all display modes in the display settings for external displays, which can be very useful for debugging and development purposes. BUG=927848 TEST=Added tests, tested on device with 4k display Change-Id: I748f2c2b645071723b94a37f759528b6437558aa Reviewed-on: https://chromium-review.googlesource.com/c/1465682 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#634875} ash/display/cros_display_config.cc | 5 +- ash/display/display_manager_unittest.cc | 7 +- ash/display/display_prefs.cc | 18 ++- ash/display/display_prefs_unittest.cc | 4 +- ash/public/interfaces/cros_display_config.mojom | 2 + chrome/app/settings_strings.grdp | 3 + chrome/browser/about_flags.cc | 8 +- .../display_info_provider_chromeos.cc | 2 + chrome/browser/flag-metadata.json | 7 ++ chrome/browser/flag_descriptions.cc | 4 + chrome/browser/flag_descriptions.h | 3 + .../resources/settings/device_page/display.js | 30 ++++- .../md_settings_localized_strings_provider.cc | 6 + content/browser/browser_main_loop.cc | 4 +- extensions/common/api/system_display.idl | 3 + tools/metrics/histograms/enums.xml | 2 + ui/display/BUILD.gn | 2 + ui/display/display_features.cc | 32 +++++ ui/display/display_features.h | 27 +++++ ui/display/display_switches.cc | 15 --- ui/display/display_switches.h | 10 -- ui/display/manager/display_change_observer.cc | 115 ++++++++++++------ ui/display/manager/display_change_observer.h | 4 +- .../manager/display_change_observer_unittest.cc | 130 ++++++++++++++++----- ui/display/manager/display_configurator.cc | 51 +++++++- ui/display/manager/display_configurator.h | 8 +- .../manager/display_configurator_unittest.cc | 5 +- ui/display/manager/display_manager.cc | 49 +++++--- ui/display/manager/display_manager.h | 4 +- ui/display/manager/managed_display_info.cc | 18 +++ ui/display/manager/managed_display_info.h | 28 +++++ 31 files changed, 469 insertions(+), 137 deletions(-) commit 00ddedc7ddf58cf10e28c13b2eb6c65e83512050 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Feb 22 23:52:40 2019 +0000 Revert "Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled." This reverts commit 5b911be859f216fe70bad5c41cc91a8684d773f6. Reason for revert: broke linux_optional_gpu_tests_rel trybot per Issue 935033 Original change's description: > Enable -Wextra-semi in non-cros non-chromecast non-fuzzer linux builds that have DCHECKs enabled. > > Only enables the warning for chromium_code.n > > Also fix the last few -Wextra-semi instances in sanitizer and linux/ozone builds. > > Getting to this state required fixing > 3000 unique warnings in 15+ different > repositories. If this breaks some internal-only build somewhere, either consider > using no_chromium_code for your internal code, or fix the warnings -- it's > pretty easy. (Build with treat_warnings_as_errors=false, then open the error log > in vim, run `:%g/warning:/t$` to copy the warnings to the end of the buffer, > remove all but just those lines, run `:sort u` to get uniques, then save as > `tmp.txt` and run `:cf %` and then use something like `:map m :w<cr>:cn<cr>` > to go through them quickly.) > > TBR=rsesek > > Bug: 926235 > Change-Id: Ica629737523ff6bbd756edc44d182f35ff6cf8ac > Reviewed-on: https://chromium-review.googlesource.com/c/1483396 > Reviewed-by: Scott Violet <sky@chromium.org> > Auto-Submit: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634826} TBR=sky@chromium.org,thakis@chromium.org,rsesek@chromium.org Change-Id: I3fbcb763dbe448619b55f6dbb0cd1bf6d4eebc03 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 926235, 935033 Reviewed-on: https://chromium-review.googlesource.com/c/1484509 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#634874} build/config/compiler/BUILD.gn | 8 -------- services/service_manager/sandbox/linux/sandbox_linux.h | 2 +- ui/ozone/platform/wayland/xdg_popup_wrapper_v6.h | 1 + 3 files changed, 2 insertions(+), 9 deletions(-) commit ecdadde579edb137b7d19d828b9b625d50102e9a Author: Ryan Sturm <ryansturm@chromium.org> Date: Fri Feb 22 23:50:51 2019 +0000 Style fix In Previews code Change-Id: I433b70e353291c952c315e0ab2805298e27840dd Reviewed-on: https://chromium-review.googlesource.com/c/1483945 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#634873} chrome/browser/previews/previews_content_util.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4ad741e8757051e1c6844dfc847654b45bfd62d5 Author: Mike Wittman <wittman@chromium.org> Date: Fri Feb 22 23:48:21 2019 +0000 [Sampling profiler] Make ModuleCache::Module a reference type This is a reland of 8f219b08f98079a0fa18c760b97f13721fe7081e and 9de3faa3e56c402da4c2009c4a277bcff56ea795 merged into a single change, with test fixes. * Changes ModuleCache::Module from a value type to a reference type, with ModuleCache maintaining ownership of the Module. ModuleCache needs to own its Modules to properly support Windows, which reference counts its modules. ModuleCache is retained as a struct to minimize the size of this change, but will be changed to a class in a later CL. * Moves the parallel module caching implementation for Windows into ModuleCache. This is required to ensure the referenced modules outlive the references to them. The parallel implementation will be merged with the existing module caching implementation over the course of later refactoring CLs. Bug: 931418 Change-Id: Ic58afbf4f7bd48a91d0191a37b623b63501c8fa7 Reviewed-on: https://chromium-review.googlesource.com/c/1483393 Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634872} base/profiler/native_stack_sampler_mac.cc | 15 +- base/profiler/native_stack_sampler_win.cc | 31 +--- base/profiler/stack_sampling_profiler.cc | 4 +- base/profiler/stack_sampling_profiler.h | 4 +- base/profiler/stack_sampling_profiler_unittest.cc | 178 ++++++++++++--------- base/sampling_heap_profiler/module_cache.cc | 20 +-- base/sampling_heap_profiler/module_cache.h | 20 ++- base/sampling_heap_profiler/module_cache_mac.cc | 10 +- base/sampling_heap_profiler/module_cache_posix.cc | 5 +- .../module_cache_unittest.cc | 24 +-- base/sampling_heap_profiler/module_cache_win.cc | 41 ++++- chrome/common/heap_profiler_controller.cc | 2 +- components/metrics/call_stack_profile_builder.cc | 17 +- components/metrics/call_stack_profile_builder.h | 6 +- .../metrics/call_stack_profile_builder_unittest.cc | 34 ++-- .../tracing/common/native_stack_sampler_android.cc | 5 +- .../tracing/common/tracing_sampler_profiler.cc | 6 +- 17 files changed, 238 insertions(+), 184 deletions(-) commit 31e43994fb1aef91b7e0c3198ebc733625a162dc Author: Evan Stade <estade@chromium.org> Date: Fri Feb 22 23:46:18 2019 +0000 Chrome OS: Fix DCHECK when signing out from secondary display The secondary display's shelf is not visible. Bug: 934990 Change-Id: Ida72e29d3be57f0408bc3d0928bb934762bc3476 Reviewed-on: https://chromium-review.googlesource.com/c/1483939 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#634871} ash/shelf/shelf_window_targeter.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit cac93ee01d2b13bd2a0f42247d4ad2e62965308c Author: Yusuf Ozuysal <yusufo@google.com> Date: Fri Feb 22 23:43:37 2019 +0000 Make the GridTabSwitcher appear back This was a recent regression due to the view not being attach to the parent anymore. This is for a feature behind a flag and disabled by default. TBR=tedchoc@chromium.org Change-Id: I3091765cb7a254fc489240e7b60779e5ccfa32cf Reviewed-on: https://chromium-review.googlesource.com/c/1484511 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634870} .../chrome/browser/tasks/tab_list_ui/BottomTabGridCoordinator.java | 2 +- .../browser/tasks/tab_list_ui/GridTabSwitcherCoordinator.java | 2 +- .../chrome/browser/tasks/tab_list_ui/TabListCoordinator.java | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) commit 94ad0b64c73ffd0a00bcc7bb487781e865068d11 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Feb 22 23:42:03 2019 +0000 Add WidgetObserver methods for drag start/end. These will be used by test code to trigger events based on dragging. Tests can't reliably e.g. "queue event to trigger a drag and then call a particular callback" due to the nested, filtered message loop on Windows. Using drag observer methods is reliable, and clearer as well. Bug: 923188 Change-Id: Id24b8150d04dc878dce543fe469994aba29694e4 Reviewed-on: https://chromium-review.googlesource.com/c/1483931 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#634869} ui/views/widget/widget.cc | 6 ++++++ ui/views/widget/widget_observer.h | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) commit 1130351d7d477c88fc931ebfafb82ee6ffd1091e Author: Erik Chen <erikchen@chromium.org> Date: Fri Feb 22 23:41:06 2019 +0000 Store test placeholders in a set rather than a vector. Previously, test placeholders were extracted from test_locations_, a std::map, which implicitly deduplicated the keys. After creating test_placeholders_, I stored them in a vector. Unfortunately, this causes duplicate entries to occur when iterations > 1. Storing them in a set returns the previous behavior. Bug: 934996 Change-Id: I81825b1f95064ac59594b3531cfd8409c631e8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1484074 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#634868} base/test/launcher/test_results_tracker.cc | 2 +- base/test/launcher/test_results_tracker.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 97f29e1d224cc3d10d46e02fbf9f931161713bab Author: Robbie McElrath <rmcelrath@chromium.org> Date: Fri Feb 22 23:38:15 2019 +0000 Reland "Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService" This is a reland of 8af854748f226a99ddcd3b09e55e42414ec02eef The original author is rmcelrath@chromium.org, yhirano replaced DISABLE_ with DISABLED_. Original change's description: > Disable NetworkChangeManagerClientBrowserTest.ReconnectToNetworkService > > This test is flaky on ChromeOS when the network service is enabled. > > Bug: 934583 > Change-Id: Ib0a37e995a69555b5a5381bdef24f92fd19c12d9 > Reviewed-on: https://chromium-review.googlesource.com/c/1482005 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634467} Bug: 934583 Tbr: jam@chromium.org Change-Id: I87dc76c9e36f25d78279105b03ea9b3340e47718 Reviewed-on: https://chromium-review.googlesource.com/c/1482278 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#634867} chrome/browser/chromeos/network_change_manager_client_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 1ee41cd4c23eb7548aca8ffaa42b5cfdbf6c2f1c Author: Khushal <khushalsagar@chromium.org> Date: Fri Feb 22 23:37:31 2019 +0000 cc/paint: Ensure MergePaintFilter serialization is bitness agnostic. Always use uint64_t to serialize size_t since serialization and deserialization can occur in processes with different bitness on android webview. TBR=enne@chromium.org Bug: 924042 Change-Id: I54945b0eb1a60910cb9c92e25b6d57388c4aaa85 Reviewed-on: https://chromium-review.googlesource.com/c/1475047 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#634866} cc/paint/paint_op_reader.cc | 2 +- cc/paint/paint_op_writer.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e0c5fea052987fde5f2d9bfe06bc87eacf32a05d Author: wutao <wutao@chromium.org> Date: Fri Feb 22 23:26:27 2019 +0000 app_list: Do not show answer card in experiment We do not show the answer card when we are showing the embedded Assistant UI. Bug: 924624 Test: manual Change-Id: I08fe6bcfd9e3d4e6bee2fb5236a7246405ecb53f Reviewed-on: https://chromium-review.googlesource.com/c/1481994 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634865} ash/public/cpp/app_list/app_list_features.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Updated tag 'tree_truth' (was f14a92f737c9)