Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 45835 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919925820865073296 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itjEZsKs/luci_context.683111728 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2228-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4360ebaf107ccb11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 79feb7754d2cd8346e0a34beea6254eef9427655 [Sync::USS] Adding the flag to enable USS Passwords on iOS Mohamed Amir Yosef, Mon Mar 4 09:49:37 2019 +0000 dc69a90d2b199b5aa177d590c74203ea72530b40 [iOS] Removing preload feature from Sync and Google services Jérôme Lebel, Mon Mar 4 09:40:35 2019 +0000 212ebb07a6b4051bbb09405bc0efdcb95b7ca428 [Mfill Android] Add white scrolling shadows to accessory bar Friedrich Horschig, Mon Mar 4 09:34:11 2019 +0000 6bdb263ca522ba42fdbd910769dcd869050d3d75 [Android WebAPK] Make WebappDirectoryManager work with new-style WebAPKs Peter Kotwicz, Mon Mar 4 09:28:30 2019 +0000 f2509ce5d44141edd66ff8197139c00992596aeb Roll src/third_party/depot_tools da4dbf85f950..8f418985f120 (1 commits) chromium-autoroll, Mon Mar 4 09:27:27 2019 +0000 cb1282e798e656b1b25860a1eaa267f073966870 [ios] Ignore NTP omnibox progress updates when the NTP isn't visible. Justin Cohen, Mon Mar 4 09:27:22 2019 +0000 6b16f53c3b368d4b20c3b3feeafa98dabaff5d72 Add hotkeys to launch dev-tool for Chrome Camera App Wei Lee, Mon Mar 4 09:22:37 2019 +0000 59dc76bd60741f5b0e78a1affc90e7a72a337111 [Android][Tests] Move autofill integration test to keyboard_accessory/ Friedrich Horschig, Mon Mar 4 09:15:08 2019 +0000 4332b16d45964df5d003d76d5dcd7ac2c29c62b4 service worker: Remove kServiceWorkerServicification feature. Matt Falkenhagen, Mon Mar 4 08:58:52 2019 +0000 6593d92993dc7412966436589409a542d8bfb75d service worker: Removed unused weak ptr for EmbeddedWorkerTestHelper. Matt Falkenhagen, Mon Mar 4 08:58:02 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 79feb7754d2cd8346e0a34beea6254eef9427655 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Mar 4 09:49:37 2019 +0000 [Sync::USS] Adding the flag to enable USS Passwords on iOS Bug: 902349 Change-Id: I442448227c0129438c6a3a1ef840080531a9f014 Reviewed-on: https://chromium-review.googlesource.com/c/1498871 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#637239} ios/chrome/browser/about_flags.mm | 4 ++++ ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ++++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 3 +++ 3 files changed, 11 insertions(+) commit dc69a90d2b199b5aa177d590c74203ea72530b40 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Mar 4 09:40:35 2019 +0000 [iOS] Removing preload feature from Sync and Google services Since Unity doesn't turn on anymore preload pages feature when the user signs in, and since it is not related to Google services, preload pages feature should not be part of Sync and Google services screen. Bug: 925885 Change-Id: I815d4f59682a446e0574b61c60c23c59a4390e11 Reviewed-on: https://chromium-review.googlesource.com/c/1497951 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637238} ios/chrome/app/strings/ios_strings.grd | 6 ---- .../google_services_settings_egtest.mm | 4 --- .../google_services_settings_mediator.mm | 36 +--------------------- .../ui/settings/settings_table_view_controller.mm | 8 ++--- 4 files changed, 3 insertions(+), 51 deletions(-) commit 212ebb07a6b4051bbb09405bc0efdcb95b7ca428 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Mar 4 09:34:11 2019 +0000 [Mfill Android] Add white scrolling shadows to accessory bar This CL introduces scrolling shadows that indicate if additional items are available left or right of the current scroll position. Screenshot: https://photos.app.goo.gl/rG8vpdakFWad4vrJ9 (more in the bug) Bug: 934824 Change-Id: Ie7c9c2c3c1e35ca9770d07f06d828853fc40baf0 Reviewed-on: https://chromium-review.googlesource.com/c/1481293 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637237} .../android/java/res/layout/keyboard_accessory_modern.xml | 8 +++++--- .../java/res/layout/keyboard_accessory_suggestion.xml | 1 - chrome/android/java/res/values/dimens.xml | 1 + .../keyboard_accessory/KeyboardAccessoryCoordinator.java | 15 +-------------- .../keyboard_accessory/KeyboardAccessoryModernView.java | 11 +++++++---- .../keyboard_accessory/KeyboardAccessoryProperties.java | 10 ++++++++++ .../keyboard_accessory/KeyboardAccessoryViewBinder.java | 9 ++------- .../keyboard_accessory/KeyboardAccessoryViewTest.java | 11 +---------- 8 files changed, 27 insertions(+), 39 deletions(-) commit 6bdb263ca522ba42fdbd910769dcd869050d3d75 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Mon Mar 4 09:28:30 2019 +0000 [Android WebAPK] Make WebappDirectoryManager work with new-style WebAPKs For new-style WebAPKs, the WebAPK-provided splash screen is at the root of the activity, not WebApkActivity. This causes new-style WebAPK tasks not to show up in the ActivityManager#getAppTasks() call. This CL prevents webapp directories from being deleted if they belong to an installed WebAPK. BUG=894610 TEST=WebappDirectoryManagerTest#testDeletesDirectoriesForUninstalledWebApks() Change-Id: Iaa2168101d91ac670fd27ed7c868a74deb9e2798 Reviewed-on: https://chromium-review.googlesource.com/c/1485498 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637236} .../browser/webapps/WebappDirectoryManager.java | 27 ++++++++++++++++++++-- .../webapps/WebappDirectoryManagerTest.java | 27 +++++++++++++--------- 2 files changed, 41 insertions(+), 13 deletions(-) commit f2509ce5d44141edd66ff8197139c00992596aeb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 09:27:27 2019 +0000 Roll src/third_party/depot_tools da4dbf85f950..8f418985f120 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da4dbf85f950..8f418985f120 git log da4dbf85f950..8f418985f120 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8f418985f120 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I023517937791a3a2160bc8b8cc21fe544a0e42f7 Reviewed-on: https://chromium-review.googlesource.com/c/1498852 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637235} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cb1282e798e656b1b25860a1eaa267f073966870 Author: Justin Cohen <justincohen@google.com> Date: Mon Mar 4 09:27:22 2019 +0000 [ios] Ignore NTP omnibox progress updates when the NTP isn't visible. If two tabs are quickly opened one after another, an NTP and a web page, the NTP may make some delegate calls after it's been hidden and the web page made visible. Ignore these delegate calls. Bug: 934296 Change-Id: Idb75e240a86e09c31011d53dabdd67e99d9f7128 Reviewed-on: https://chromium-review.googlesource.com/c/1496311 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#637234} ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm | 4 ++++ 1 file changed, 4 insertions(+) commit 6b16f53c3b368d4b20c3b3feeafa98dabaff5d72 Author: Wei Lee <wtlee@google.com> Date: Mon Mar 4 09:22:37 2019 +0000 Add hotkeys to launch dev-tool for Chrome Camera App This CL adds hotkeys to launch dev-tool by methods provided by FileManager Private API. Test: Tested on CCA and the hotkeys work. Change-Id: I1169215f7040f450731ab44bf789652c904a8443 Reviewed-on: https://chromium-review.googlesource.com/c/1491292 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637233} .../resources/chromeos/camera/src/js/nav.js | 29 ++++++++++++++++------ 1 file changed, 21 insertions(+), 8 deletions(-) commit 59dc76bd60741f5b0e78a1affc90e7a72a337111 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Mar 4 09:15:08 2019 +0000 [Android][Tests] Move autofill integration test to keyboard_accessory/ This CL moves the test covering the integration of autofill suggestions into the keyboard accessory into the subfolder keyboard_accessory. This has two reasons: - fhorschig@ is OWNER of these tests - consistent location amongst all accessory integration tests Bug: None Change-Id: Ia0a1d8b8ac6dbfc491e737a020f124f2f558351a Reviewed-on: https://chromium-review.googlesource.com/c/1477683 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637232} chrome/android/java_sources.gni | 2 +- .../AutofillKeyboardAccessoryIntegrationTest.java | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) commit 4332b16d45964df5d003d76d5dcd7ac2c29c62b4 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 08:58:52 2019 +0000 service worker: Remove kServiceWorkerServicification feature. The non-servicified code path is no longer supported. This CL also removes parameterized tests on network service only, since we have bots that provide that test coverage. Bug: 926114 Change-Id: I0165692985e7ae0740c1d03578474f3c0b6f10fc Reviewed-on: https://chromium-review.googlesource.com/c/1498799 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637231} .../browser/chrome_service_worker_browsertest.cc | 36 ++--------------- .../loader/cors_origin_access_list_browsertest.cc | 7 +--- .../browser/frame_host/render_frame_host_impl.cc | 7 +--- .../browser/loader/cors_file_origin_browsertest.cc | 6 +-- .../browser/loader/prefetch_url_loader_service.cc | 4 -- .../loader/resource_dispatcher_host_unittest.cc | 16 ++------ .../embedded_worker_instance_unittest.cc | 13 +------ .../service_worker_file_upload_browsertest.cc | 36 ++++------------- .../service_worker_provider_host_unittest.cc | 18 --------- ...ervice_worker_script_loader_factory_unittest.cc | 5 --- .../service_worker_tls_browsertest.cc | 41 ++------------------ content/browser/worker_host/shared_worker_host.cc | 14 +------ content/public/test/url_loader_interceptor.cc | 45 +++++++++------------- third_party/blink/common/features.cc | 5 --- third_party/blink/public/common/features.h | 1 - 15 files changed, 42 insertions(+), 212 deletions(-) commit 6593d92993dc7412966436589409a542d8bfb75d Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 08:58:02 2019 +0000 service worker: Removed unused weak ptr for EmbeddedWorkerTestHelper. Trivial cleanup. Bug: 937731 Change-Id: I08e77724aa51faf2f54ff490f3733335d753c447 Reviewed-on: https://chromium-review.googlesource.com/c/1498796 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637230} content/browser/service_worker/embedded_worker_test_helper.cc | 3 +-- content/browser/service_worker/embedded_worker_test_helper.h | 9 +-------- 2 files changed, 2 insertions(+), 10 deletions(-) commit f2b1b1af4670a9078ea8b2d27caabad2acc00188 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Mar 4 08:48:11 2019 +0000 Make '/' focus search bar in History, Bookmarks, Downloads and Settings This CL adds '/' as a keyboard shortcut for focusing the search bar similar to ctrl+f in WebUI. This CL also adds an isTextInputElement() helper function. Bug: 934615 Change-Id: I20056d31475dd8ae94d0f1f9c5f59120a78232c9 Reviewed-on: https://chromium-review.googlesource.com/c/1496396 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637229} chrome/browser/resources/bookmarks/dnd_manager.js | 4 ++-- .../webui/find_shortcut_behavior_browsertest.js | 7 +++++-- .../test/data/webui/find_shortcut_behavior_test.js | 22 ++++++++++++++++++---- ui/webui/resources/js/find_shortcut_behavior.js | 13 +++++++++---- ui/webui/resources/js/util.js | 8 ++++++++ 5 files changed, 42 insertions(+), 12 deletions(-) commit 1fe69aa1c7ee817bf7d1018c5c48914f2f66f837 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Mar 4 08:42:39 2019 +0000 Implement MemoryFileStreamReader. To continue implementation of in memory file system for incognito mode, MemoryFileStreamReader is implemented to use ObfuscatedFileUtilMemoryDelegate for reading from an in-memory file. Bug: 93417 Change-Id: I3bc460344adf66aaf3644e8ce82b98f14ee8ff31 Reviewed-on: https://chromium-review.googlesource.com/c/1488920 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#637228} storage/browser/BUILD.gn | 3 + .../fileapi/file_stream_reader_test_utils.cc | 41 ++++ .../fileapi/file_stream_reader_test_utils.h | 24 ++ .../file_system_file_stream_reader_unittest.cc | 25 +-- .../fileapi/local_file_stream_reader_unittest.cc | 24 +- .../browser/fileapi/memory_file_stream_reader.cc | 57 +++-- .../browser/fileapi/memory_file_stream_reader.h | 4 + .../fileapi/memory_file_stream_reader_unittest.cc | 250 +++++++++++++++++++++ .../obfuscated_file_util_memory_delegate.cc | 39 ++++ .../fileapi/obfuscated_file_util_memory_delegate.h | 12 + 10 files changed, 417 insertions(+), 62 deletions(-) commit dcfa8d6f60cf9bc3d2857e7661972367135a5b7e Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 08:41:45 2019 +0000 service worker: Return true in IsServicificationEnabled(). The non-servicified code path is no longer supported. This is the next step toward removing it. This CL also removes some tests that only worked when kServiceWorkerServicification was disabled. That code path can no longer be taken, so the tests would fail. The Signed Exchange tests were testing the combinations of of ServiceWorkerServicification + NetworkService; this can be removed now that we only need to test NetworkService on or off, and there are dedicated bots on the CQ for that. Bug: 926114 Change-Id: I5691139d045615dc463a8bf09f48186c5c6cd270 Reviewed-on: https://chromium-review.googlesource.com/c/1496268 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637227} ...vice_worker_context_request_handler_unittest.cc | 499 ------- ...e_worker_controllee_request_handler_unittest.cc | 161 +-- .../service_worker_url_request_job_unittest.cc | 1418 -------------------- .../signed_exchange_request_handler_browsertest.cc | 105 +- content/test/BUILD.gn | 2 - .../common/service_worker/service_worker_utils.cc | 5 +- .../common/service_worker/service_worker_utils.h | 4 +- 7 files changed, 27 insertions(+), 2167 deletions(-) commit 97211c4baf455114533b6d6de662fe946b293bce Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 08:40:06 2019 +0000 Cleanup dependencies and includes in ProfileSyncServiceFactory Bug: none Change-Id: I926ca4d9cec0ed6705d5e7c3fac408be09a3d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1482973 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637226} .../browser/sync/profile_sync_service_factory.cc | 24 ++++++---------------- 1 file changed, 6 insertions(+), 18 deletions(-) commit e3e59957ecec69e65ab13e5f8425d33156dabef7 Author: wutao <wutao@chromium.org> Date: Mon Mar 4 08:39:04 2019 +0000 app_list: Assistant page to peeking when clicking scrim When tapping on scrim from half launcher it minimizes to peeking from the Assistant page view, which makes it behave like search page view. Bug: 924624 Test: manual Change-Id: I659b63b54af17be1743dfd7f980d3aa2aa47f735 Reviewed-on: https://chromium-review.googlesource.com/c/1496756 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637225} ash/app_list/views/app_list_view.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) commit a6af5038e9ab92abf032ea54c856345ed096613c Author: wutao <wutao@chromium.org> Date: Mon Mar 4 08:38:59 2019 +0000 app_list: Start Assistant in half or full state This patch fixes a bug to start Assistant view page with full launcher. If we are already in full launcher, do not need to set to half launcher. Bug: 924624 Test: manual Change-Id: I1827fa73ea850d374a4b114b137bad4a3c91a3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1497176 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637224} ash/app_list/app_list_controller_impl.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit dde920ad5694f73f5b1e0f352ab0dba76bcd055b Author: Kent Tamura <tkent@chromium.org> Date: Mon Mar 4 08:36:51 2019 +0000 Remove unnecessary blink:: in renderer/core/editing We have bunch of "Trace(blink::Visitor*" in Blink though their classes are also in blink namespace. This CL removes a part of such unnecessary blink::. This CL has no behavior changes. This CL was produced by the following command on zsh: % for i in **/*.{h,cc}; sed -i "" -e "s/Trace(blink::/Trace(/g" $i Change-Id: I6e65139e738afb939b70d23a845221b9fa0f7300 Reviewed-on: https://chromium-review.googlesource.com/c/1498801 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637223} .../renderer/core/editing/commands/append_node_command.cc | 2 +- .../renderer/core/editing/commands/append_node_command.h | 2 +- .../renderer/core/editing/commands/apply_style_command.cc | 4 ++-- .../renderer/core/editing/commands/apply_style_command.h | 2 +- .../renderer/core/editing/commands/composite_edit_command.cc | 2 +- .../renderer/core/editing/commands/composite_edit_command.h | 2 +- .../core/editing/commands/delete_from_text_node_command.cc | 2 +- .../core/editing/commands/delete_from_text_node_command.h | 2 +- .../core/editing/commands/delete_selection_command.cc | 2 +- .../core/editing/commands/delete_selection_command.h | 2 +- .../blink/renderer/core/editing/commands/edit_command.cc | 2 +- .../blink/renderer/core/editing/commands/edit_command.h | 2 +- .../core/editing/commands/insert_into_text_node_command.cc | 2 +- .../core/editing/commands/insert_into_text_node_command.h | 2 +- .../renderer/core/editing/commands/insert_list_command.cc | 2 +- .../renderer/core/editing/commands/insert_list_command.h | 2 +- .../core/editing/commands/insert_node_before_command.cc | 2 +- .../core/editing/commands/insert_node_before_command.h | 2 +- .../editing/commands/insert_paragraph_separator_command.cc | 2 +- .../editing/commands/insert_paragraph_separator_command.h | 2 +- .../editing/commands/merge_identical_elements_command.cc | 2 +- .../core/editing/commands/merge_identical_elements_command.h | 2 +- .../core/editing/commands/remove_css_property_command.cc | 2 +- .../core/editing/commands/remove_css_property_command.h | 2 +- .../renderer/core/editing/commands/remove_node_command.cc | 2 +- .../renderer/core/editing/commands/remove_node_command.h | 2 +- .../commands/remove_node_preserving_children_command.cc | 2 +- .../commands/remove_node_preserving_children_command.h | 2 +- .../core/editing/commands/replace_node_with_span_command.cc | 2 +- .../core/editing/commands/replace_node_with_span_command.h | 2 +- .../core/editing/commands/replace_selection_command.cc | 2 +- .../core/editing/commands/replace_selection_command.h | 2 +- .../core/editing/commands/selection_for_undo_step.cc | 4 ++-- .../renderer/core/editing/commands/selection_for_undo_step.h | 4 ++-- .../core/editing/commands/set_character_data_command.cc | 2 +- .../core/editing/commands/set_character_data_command.h | 2 +- .../core/editing/commands/set_node_attribute_command.cc | 2 +- .../core/editing/commands/set_node_attribute_command.h | 2 +- .../core/editing/commands/simplify_markup_command.cc | 2 +- .../renderer/core/editing/commands/simplify_markup_command.h | 2 +- .../renderer/core/editing/commands/split_element_command.cc | 2 +- .../renderer/core/editing/commands/split_element_command.h | 2 +- .../core/editing/commands/split_text_node_command.cc | 2 +- .../renderer/core/editing/commands/split_text_node_command.h | 2 +- .../commands/split_text_node_containing_element_command.cc | 2 +- .../commands/split_text_node_containing_element_command.h | 2 +- .../blink/renderer/core/editing/commands/undo_stack.cc | 2 +- .../blink/renderer/core/editing/commands/undo_stack.h | 2 +- .../blink/renderer/core/editing/commands/undo_step.cc | 2 +- third_party/blink/renderer/core/editing/commands/undo_step.h | 2 +- .../editing/commands/wrap_contents_in_dummy_span_command.cc | 2 +- .../editing/commands/wrap_contents_in_dummy_span_command.h | 2 +- third_party/blink/renderer/core/editing/dom_selection.cc | 2 +- third_party/blink/renderer/core/editing/dom_selection.h | 2 +- third_party/blink/renderer/core/editing/drag_caret.cc | 2 +- third_party/blink/renderer/core/editing/drag_caret.h | 2 +- third_party/blink/renderer/core/editing/editing_style.cc | 12 +++++------- third_party/blink/renderer/core/editing/editing_style.h | 2 +- third_party/blink/renderer/core/editing/editor.cc | 2 +- third_party/blink/renderer/core/editing/editor.h | 2 +- .../blink/renderer/core/editing/finder/text_finder.cc | 4 ++-- third_party/blink/renderer/core/editing/finder/text_finder.h | 4 ++-- third_party/blink/renderer/core/editing/frame_caret.cc | 2 +- third_party/blink/renderer/core/editing/frame_caret.h | 2 +- third_party/blink/renderer/core/editing/frame_selection.cc | 2 +- third_party/blink/renderer/core/editing/frame_selection.h | 2 +- .../renderer/core/editing/ime/input_method_controller.cc | 2 +- .../renderer/core/editing/ime/input_method_controller.h | 2 +- third_party/blink/renderer/core/editing/layout_selection.cc | 2 +- third_party/blink/renderer/core/editing/layout_selection.h | 2 +- .../editing/markers/active_suggestion_marker_list_impl.cc | 2 +- .../editing/markers/active_suggestion_marker_list_impl.h | 2 +- .../core/editing/markers/composition_marker_list_impl.cc | 2 +- .../core/editing/markers/composition_marker_list_impl.h | 2 +- .../blink/renderer/core/editing/markers/document_marker.h | 2 +- .../core/editing/markers/document_marker_controller.cc | 2 +- .../core/editing/markers/document_marker_controller.h | 2 +- .../renderer/core/editing/markers/document_marker_list.h | 2 +- .../core/editing/markers/spell_check_marker_list_impl.cc | 2 +- .../core/editing/markers/spell_check_marker_list_impl.h | 2 +- .../core/editing/markers/suggestion_marker_list_impl.cc | 2 +- .../core/editing/markers/suggestion_marker_list_impl.h | 2 +- .../core/editing/markers/text_match_marker_list_impl.cc | 2 +- .../core/editing/markers/text_match_marker_list_impl.h | 2 +- third_party/blink/renderer/core/editing/position.cc | 2 +- third_party/blink/renderer/core/editing/position.h | 2 +- .../blink/renderer/core/editing/position_with_affinity.cc | 2 +- .../blink/renderer/core/editing/position_with_affinity.h | 2 +- .../blink/renderer/core/editing/reveal_selection_scope.cc | 2 +- .../blink/renderer/core/editing/reveal_selection_scope.h | 2 +- .../blink/renderer/core/editing/selection_controller.cc | 2 +- .../blink/renderer/core/editing/selection_controller.h | 2 +- third_party/blink/renderer/core/editing/selection_editor.cc | 2 +- third_party/blink/renderer/core/editing/selection_editor.h | 2 +- .../blink/renderer/core/editing/selection_template.cc | 2 +- third_party/blink/renderer/core/editing/selection_template.h | 4 ++-- .../blink/renderer/core/editing/serializers/serialization.cc | 2 +- .../editing/spellcheck/cold_mode_spell_check_requester.cc | 2 +- .../editing/spellcheck/cold_mode_spell_check_requester.h | 2 +- .../core/editing/spellcheck/idle_spell_check_controller.cc | 4 ++-- .../core/editing/spellcheck/idle_spell_check_controller.h | 2 +- .../core/editing/spellcheck/spell_check_requester.cc | 4 ++-- .../renderer/core/editing/spellcheck/spell_check_requester.h | 4 ++-- .../blink/renderer/core/editing/spellcheck/spell_checker.cc | 2 +- .../blink/renderer/core/editing/spellcheck/spell_checker.h | 2 +- .../core/editing/suggestion/text_suggestion_controller.cc | 2 +- .../core/editing/suggestion/text_suggestion_controller.h | 2 +- third_party/blink/renderer/core/editing/visible_position.cc | 2 +- third_party/blink/renderer/core/editing/visible_position.h | 2 +- third_party/blink/renderer/core/editing/visible_selection.cc | 2 +- third_party/blink/renderer/core/editing/visible_selection.h | 2 +- 111 files changed, 124 insertions(+), 126 deletions(-) commit 3897026e3f23b958feb4b523dbea296edbdeb10e Author: Kenneth Russell <kbr@chromium.org> Date: Mon Mar 4 08:15:45 2019 +0000 Print the actual GL error (in hex) with --generate-dchecks. This makes the error messages much more useful. Bug: 930479 Change-Id: I2066fd0de00f75ac3c50f8abbe3579403ff1bfe0 Reviewed-on: https://chromium-review.googlesource.com/c/1498729 Auto-Submit: Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#637222} ui/gl/generate_bindings.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit d41d396307fcfdf0df3c60495a447228b90be947 Author: Kenneth Russell <kbr@chromium.org> Date: Mon Mar 4 08:15:25 2019 +0000 Bind a clean vertex array object in YUVToRGBConverter. This class and the GLHelper underneath it save and restore a minimal amount of context state. Application code may have changed much vertex attribute state, including vertex attribute divisors on other vertex attributes, which can cause GL_INVALID_OPERATION during the DrawArrays this class performs. Avoid interference by saving and restoring the bound vertex array object. Bug: 930479 Change-Id: I5f21335aefe321c8faf87a968c7caeba7060f66a Reviewed-on: https://chromium-review.googlesource.com/c/1498728 Auto-Submit: Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#637221} ui/gl/yuv_to_rgb_converter.cc | 20 ++++++++++++++++++++ ui/gl/yuv_to_rgb_converter.h | 1 + 2 files changed, 21 insertions(+) commit d2500f5f2f248428da11c262642593ae73fa5718 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 08:01:32 2019 +0000 Roll src-internal cbe8756f8a6d..246fc71a449d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbe8756f8a6d..246fc71a449d Created with: gclient setdep -r src-internal@246fc71a449d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie976caf72c66750ab698e7b0a990e0d31762fa59 Reviewed-on: https://chromium-review.googlesource.com/c/1498730 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637220} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 654f1f19fd508e94b471feddcc335111f7da2a54 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Mar 4 07:19:03 2019 +0000 Update V8 to version 7.4.270. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c7724d93..e21801e6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I079d1f026fd35263d310ca0d6c1112d3bda46e41 Reviewed-on: https://chromium-review.googlesource.com/c/1498725 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637219} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 978babf67e5d36e36124a713d7ab763f2eb225d7 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Mar 4 07:05:12 2019 +0000 Implement ObfuscatedFileUtilMemoryDelegate. ObfuscatedFileUtilMemoryDelegate is implemented to creates an in-memory support for files and directories creation, access, modification, and removal. Bug: 93417 Change-Id: I1b9c391efa8b2ca17c3605ec093de2467462e1d0 Reviewed-on: https://chromium-review.googlesource.com/c/1459550 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#637218} storage/browser/BUILD.gn | 1 + storage/browser/fileapi/obfuscated_file_util.cc | 3 +- .../obfuscated_file_util_memory_delegate.cc | 392 ++++++++++-- .../fileapi/obfuscated_file_util_memory_delegate.h | 48 +- ...bfuscated_file_util_memory_delegate_unittest.cc | 656 +++++++++++++++++++++ 5 files changed, 1045 insertions(+), 55 deletions(-) commit a8d8af6326bbf3e782a2f2fab2f1eab2dd1585ff Author: Kent Tamura <tkent@chromium.org> Date: Mon Mar 4 07:02:12 2019 +0000 Deprecate unimplemented -webkit-appearance keywords This CL deprecate the following keywords: * button-bevel * caret * listitem * media-controls-background * media-controls-fullscreen-background * media-current-time-display * media-enter-fullscreen-button * media-exit-fullscreen-button * media-mute-button * media-overlay-play-button * media-play-button * media-time-remaining-display * media-toggle-closed-captions-button * media-volume-slider-container * menulist-textfield * menulist-text * progress-bar-value Because they have no special painting code. We show deprecation messages for them on CSS parsing time, not painting time because unused style rules might be used in the future. * legacyMediaControls.css Change deprecated keywords to 'none'. Because the deprecated keywords don't have painting code, 'none' doesn't change behavior. * outdent-collapse-table-crash.html Change a deprecated keyword to a live one. * video-webkit-appearance.html It was created when we had special painting code for media-play-button. It doesn't make sense now. Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ldH_uIfk_QE Bug: 936301 Change-Id: Ic4136e8374cb9a03329cdef2aac248534881a3ee Reviewed-on: https://chromium-review.googlesource.com/c/1496120 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637217} .../public/mojom/web_feature/web_feature.mojom | 16 +++++++++ .../core/css/parser/css_property_parser_helpers.cc | 41 ++++++++++++++++++++++ .../blink/renderer/core/frame/deprecation.cc | 35 ++++++++++++++++++ .../resources/legacyMediaControls.css | 6 ++-- .../execCommand/outdent-collapse-table-crash.html | 2 +- .../media/video-webkit-appearance-expected.html | 14 -------- .../web_tests/media/video-webkit-appearance.html | 19 ---------- tools/metrics/histograms/enums.xml | 17 +++++++++ 8 files changed, 113 insertions(+), 37 deletions(-) commit 375b08bdc8b63b243dc4a6e06ae5fac7753be0a8 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 06:59:52 2019 +0000 Roll src-internal 50cfd59a72c7..cbe8756f8a6d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50cfd59a72c7..cbe8756f8a6d Created with: gclient setdep -r src-internal@cbe8756f8a6d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I007fe87afd94ae25e9810b938396c0b5b7e01118 Reviewed-on: https://chromium-review.googlesource.com/c/1498726 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637216} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 99110588c46a54fa14ce4bb4f3f303c0b19a9d84 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Mar 4 06:04:06 2019 +0000 bindings: Remove Web Agent This was an experimental project but there is no active developer on this project anymore. Bug: N/A Change-Id: If399583e0a008312727386121602f49ce11bb1fe Reviewed-on: https://chromium-review.googlesource.com/c/1498737 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637215} .../renderer/bindings/IDLExtendedAttributes.md | 1 - .../renderer/bindings/IDLExtendedAttributes.txt | 1 - .../scripts/code_generator_web_agent_api.py | 294 ----------------- .../scripts/code_generator_web_agent_api_test.py | 337 ------------------- .../blink/renderer/bindings/scripts/scripts.gni | 1 - .../renderer/bindings/templates/templates.gni | 2 - .../templates/web_agent_api_interface.cc.tmpl | 51 --- .../templates/web_agent_api_interface.h.tmpl | 45 --- .../bindings/tests/idls/core/test_interface_3.idl | 56 ---- .../tests/results/core/test_interface_3.cc | 45 --- .../bindings/tests/results/core/test_interface_3.h | 40 --- .../tests/results/core/v8_test_interface_3.cc | 363 --------------------- .../tests/results/core/v8_test_interface_3.h | 92 ------ .../blink/tools/blinkpy/bindings/bindings_tests.py | 6 - 14 files changed, 1334 deletions(-) commit 43c33ab40b9d4126e7bcb4e303d80a32c1d4490d Author: Alex Danilo <adanilo@chromium.org> Date: Mon Mar 4 06:00:06 2019 +0000 Add sub-menu arrow for sub-menu host items. The sub-menu pattern used in FilesApp had no indicator of the presence of a sub-menu. This change adds the indicator arrow to any menu item that has a child sub-menu. Also cleaned up some stale -webkit prefixed properties that were causing presubmit warnings. Bug: 934192 Change-Id: I0ad78e32a9bc56cac2354a72ac2b0ef163708134 Reviewed-on: https://chromium-review.googlesource.com/c/1498739 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#637214} ui/file_manager/file_manager/foreground/css/menu.css | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) commit 380dd85cabd8a25156747b0b3f634da78d38eccb Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Mon Mar 4 05:58:28 2019 +0000 Generate 'platform_probe' sources to follow Blink coding style. This CL generates 'platform_probe' sources to follow Blink coding style for function and argument names. Bug: 936684 Change-Id: Ic833ac8980afa20186c03b74749ff49b1b2def07 Reviewed-on: https://chromium-review.googlesource.com/c/1496130 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637213} third_party/blink/renderer/platform/probe/platform_probes.pidl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ffdac3856ccd99665bc05b873c977179d0f90046 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 05:45:59 2019 +0000 Documentation: service worker performance Bug: 795989 Change-Id: Ie4c03c9efcb1a67e7a0f5e69ad363dd8fd9c7e3c Reviewed-on: https://chromium-review.googlesource.com/c/1496413 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637212} content/browser/service_worker/README.md | 75 ++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) commit 8982dddaf386af4e964badec7c1b103c5fbf3d52 Author: dpapad <dpapad@chromium.org> Date: Mon Mar 4 05:44:59 2019 +0000 WebUI cleanup: Remove dead code cr.LinkController. Bug: None Change-Id: I4237e71fc9f5436f04f82c344380909c43838143 Reviewed-on: https://chromium-review.googlesource.com/c/1497540 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#637211} chrome/test/data/webui/link_controller_test.html | 292 --------------------- .../test/data/webui/webui_resource_browsertest.cc | 6 - ui/webui/resources/js/cr/link_controller.js | 151 ----------- ui/webui/resources/webui_resources.grd | 3 - 4 files changed, 452 deletions(-) commit e505e0a01da4ffb7e43e7b7edaeb91b8d06b3bdc Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 05:33:24 2019 +0000 Roll src-internal 85fe2405c4e4..50cfd59a72c7 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/85fe2405c4e4..50cfd59a72c7 Created with: gclient setdep -r src-internal@50cfd59a72c7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iba4643861e5e99e5985e8f725cfdefd23c32c07d Reviewed-on: https://chromium-review.googlesource.com/c/1498723 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637210} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c3a1823ad2ca0cac35bbd853b38eb54989bef041 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Mar 4 05:25:16 2019 +0000 [Files app] Convert ui/file_manager/integration_tests/ to arrow function Bug: 778674 Change-Id: I0b7f0070e75bc1b11af2ce638d30d97d09e5b17b Reviewed-on: https://chromium-review.googlesource.com/c/1498738 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#637209} .../integration_tests/file_manager/background.js | 14 ++-- .../integration_tests/file_manager/context_menu.js | 84 +++++++++++----------- .../file_manager/copy_between_windows.js | 12 ++-- .../file_manager/create_new_folder.js | 8 +-- .../integration_tests/file_manager/crostini.js | 4 +- .../integration_tests/file_manager/delete.js | 4 +- .../file_manager/directory_tree_context_menu.js | 34 ++++----- .../file_manager/drive_specific.js | 30 ++++---- .../integration_tests/file_manager/file_dialog.js | 34 ++++----- .../integration_tests/file_manager/file_display.js | 46 ++++++------ .../file_manager/files_tooltip.js | 2 +- .../file_manager/folder_shortcuts.js | 6 +- .../integration_tests/file_manager/gear_menu.js | 18 ++--- .../integration_tests/file_manager/grid_view.js | 4 +- .../file_manager/install_linux_package_dialog.js | 2 +- .../file_manager/keyboard_operations.js | 26 +++---- .../file_manager/launcher_search.js | 8 +-- .../integration_tests/file_manager/metadata.js | 10 +-- .../integration_tests/file_manager/my_files.js | 12 ++-- .../file_manager/open_audio_files.js | 24 +++---- .../file_manager/open_image_files.js | 10 +-- .../file_manager/open_video_files.js | 6 +- .../integration_tests/file_manager/providers.js | 12 ++-- .../integration_tests/file_manager/quick_view.js | 46 ++++++------ .../integration_tests/file_manager/recents.js | 8 +-- .../file_manager/restore_geometry.js | 8 +-- .../file_manager/restore_prefs.js | 4 +- .../file_manager/share_and_manage_dialog.js | 28 ++++---- .../integration_tests/file_manager/sort_columns.js | 2 +- .../file_manager/suggest_app_dialog.js | 2 +- .../integration_tests/file_manager/tab_index.js | 18 ++--- .../integration_tests/file_manager/tasks.js | 14 ++-- .../integration_tests/file_manager/transfer.js | 30 ++++---- .../integration_tests/file_manager/traverse.js | 4 +- .../integration_tests/file_manager/zip_files.js | 26 +++---- 35 files changed, 300 insertions(+), 300 deletions(-) commit 0fe43fee85f714c6f2239b467853d2f8fd190d6b Author: Koji Ishii <kojii@chromium.org> Date: Mon Mar 4 05:13:42 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 15873 15889 15901 15908 15916 15928 15930 15933 15941 15946 15961 15967 15971 15976 15979 15981 15992 16007 16015 16022 16023 16024 16025 16042 16043 16047 16051 16059 4 lines were removed and 7 lines were deflaked by consecutive results since 15992. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I15e6952a7ddda4d892b812c0ea0303e934b07a47 Reviewed-on: https://chromium-review.googlesource.com/c/1491732 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637208} .../enable-blink-features=LayoutNG | 25 +++++++++++----------- 1 file changed, 13 insertions(+), 12 deletions(-) commit d1e399747978a680454de373506993c14627f0d4 Author: dstockwell <dstockwell@google.com> Date: Mon Mar 4 05:13:26 2019 +0000 pdf: Ensure annotation mode and rotation do not overlap As rotation is not yet supported by Ink we disable annotation mode if the document is rotated, and disable rotation if the document is in annotation mode. Bug: 902646 Change-Id: I6afcac7e8e472ebfb24806277b8410c976e15cc8 Reviewed-on: https://chromium-review.googlesource.com/c/1482436 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#637207} .../viewer-pdf-toolbar/viewer-pdf-toolbar.html | 2 + .../viewer-pdf-toolbar/viewer-pdf-toolbar.js | 15 +++++++- chrome/browser/resources/pdf/pdf_viewer.js | 44 ++++++++++++++++------ 3 files changed, 49 insertions(+), 12 deletions(-) commit f0ddddeb05fc81e6387f66bbc69244e7467bd06e Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Mon Mar 4 05:01:59 2019 +0000 Generate 'core/probe' sources to follow Blink coding style. This CL generates 'core/probe' sources to follow Blink coding style for argument names. Bug: 936684 Change-Id: If1dd12c01b9f21915f83338a3bda6e5fead0e9f9 Reviewed-on: https://chromium-review.googlesource.com/c/1496128 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637206} .../renderer/core/frame/performance_monitor.cc | 2 +- .../core/inspector/inspector_dom_debugger_agent.cc | 8 ++-- .../blink/renderer/core/probe/core_probes.pidl | 44 +++++++++++----------- 3 files changed, 27 insertions(+), 27 deletions(-) commit 529c35106dedd775472539629b94e7462aa20027 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 04:50:16 2019 +0000 Roll src/third_party/depot_tools e9e89e3aa538..da4dbf85f950 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e9e89e3aa538..da4dbf85f950 git log e9e89e3aa538..da4dbf85f950 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 tikuta@chromium.org autoninja: limit j value for mac Created with: gclient setdep -r src/third_party/depot_tools@da4dbf85f950 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:936864 TBR=agable@chromium.org Change-Id: I7cb645a501a8b49b79beebbd6ada9ceaa1c21512 Reviewed-on: https://chromium-review.googlesource.com/c/1498719 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637205} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b32ae43ec080625156769457e0dd705d3a54c7b8 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 04:41:40 2019 +0000 service worker: Bind Mojo interfaces using the WorkerThread's task runner. Attempted fix for the linked bugs. Based on crash reports, it appears some Mojo calls are happening on the wrong thread or on the service worker thread after it's started being destructed/terminated. To try to fix this, explicitly bind the interfaces using the WorkerThread's task runner, which seems to have guarantees about safely dropping tasks when the worker thread starts being destructed/terminated. Bug: 927149, 907311, 934622 Change-Id: I4d8e59ada9cd28aa22039fbbb77f5aa0d149ff28 Reviewed-on: https://chromium-review.googlesource.com/c/1496264 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637204} .../controller_service_worker_impl.cc | 13 ++++++--- .../controller_service_worker_impl.h | 9 +++++- .../service_worker_context_client.cc | 32 +++++++++++++++------- .../service_worker/service_worker_context_client.h | 9 +++--- .../service_worker_context_client_unittest.cc | 7 ++++- .../web_service_worker_context_client.h | 13 ++++++++- .../service_worker_global_scope_proxy.cc | 9 +++++- .../web_embedded_worker_impl_test.cc | 3 +- 8 files changed, 72 insertions(+), 23 deletions(-) commit e590d4e0ae6d3cbdabee199ea6fabe152a3eea83 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 04:25:01 2019 +0000 Roll src-internal 8a2215122b55..85fe2405c4e4 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a2215122b55..85fe2405c4e4 Created with: gclient setdep -r src-internal@85fe2405c4e4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3c694cc3638c180e3c1ed29fd5f025b0baffcef1 Reviewed-on: https://chromium-review.googlesource.com/c/1498718 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637203} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 22197fee419ca0f694e39722c2ad73464dd60ca8 Author: Jay Harris <harrisjay@chromium.org> Date: Mon Mar 4 04:16:20 2019 +0000 Parses file handling information from the manifest. Explainer: https://github.com/WICG/file-handling/blob/master/explainer.md This also renames ShareTargetFile to FileFilter, as it is now used in FileHandling as well as ShareTarget. It's still unclear whether this form will be final for FileHandlers (related discussion: https://github.com/WICG/file-handling/issues/7), so the spec for ShareTargetFiles hasn't been updated. Bug: 829689 Change-Id: I7d1a872f44d1b0c07a8c761cdfc3f1d25c238f1e Reviewed-on: https://chromium-review.googlesource.com/c/1454336 Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#637202} chrome/browser/android/shortcut_info.cc | 2 +- content/renderer/manifest/manifest_parser.cc | 64 ++++++---- content/renderer/manifest/manifest_parser.h | 33 +++--- .../renderer/manifest/manifest_parser_unittest.cc | 130 +++++++++++++++++++-- .../blink/common/manifest/manifest_mojom_traits.cc | 14 ++- .../blink/public/common/manifest/manifest.h | 13 ++- .../public/common/manifest/manifest_mojom_traits.h | 21 ++-- .../blink/public/mojom/manifest/manifest.mojom | 10 +- 8 files changed, 224 insertions(+), 63 deletions(-) commit c757efb60ca4d3862b06d696ae0b5b9a7d35472b Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Mon Mar 4 04:10:59 2019 +0000 Updating trunk VERSION from 3724.0 to 3725.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ie646c48bdc032809225428b07d0d985e3b2a8e34 Reviewed-on: https://chromium-review.googlesource.com/c/1498773 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#637201} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e65d7afd910ef9d8d2d7390681596563f2e99692 Author: Min Qin <qinmin@chromium.org> Date: Mon Mar 4 03:45:38 2019 +0000 Fix a crash when resolving download display names display_names could be null, need to do a null check BUG=937707 TBR=dtrainor@chromium.org Change-Id: I51e95ee323e81fe1a1e678cb1f6f9cf73f0bc2e4 Reviewed-on: https://chromium-review.googlesource.com/c/1498717 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637200} .../download/internal/common/in_progress_download_manager.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit c30e5d88d42abe4dc7d926271b4750113815b9b4 Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Mar 4 03:35:28 2019 +0000 [Files app] Convert ui/file_manager/integration_tests/ to let/const Bug: 778674 Change-Id: I63b902d626f5e3499c60b56adbbbb3c65070dcf8 Reviewed-on: https://chromium-review.googlesource.com/c/1496410 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#637199} .../integration_tests/file_manager/background.js | 52 +++++++++++----------- .../file_manager/copy_between_windows.js | 2 +- .../integration_tests/file_manager/delete.js | 4 +- .../file_manager/directory_tree_context_menu.js | 4 +- .../file_manager/drive_specific.js | 20 ++++----- .../integration_tests/file_manager/file_display.js | 2 +- .../integration_tests/file_manager/my_files.js | 2 +- .../file_manager/open_video_files.js | 2 +- .../integration_tests/file_manager/providers.js | 6 +-- .../file_manager/restore_geometry.js | 2 +- .../file_manager/restore_prefs.js | 2 +- .../integration_tests/file_manager/sort_columns.js | 16 +++---- .../file_manager/suggest_app_dialog.js | 2 +- .../integration_tests/file_manager/tasks.js | 14 +++--- .../integration_tests/file_manager/transfer.js | 6 +-- 15 files changed, 68 insertions(+), 68 deletions(-) commit 77ab40245c0435e2bc22ff7cb227fb06bcc472ac Author: Alex Danilo <adanilo@chromium.org> Date: Mon Mar 4 03:28:48 2019 +0000 Adding keyboard nav between menu and sub menu. The sub-menu implementation needs the ability to navigate between the top level menu and any sub-menus using the keyboard to improve accessibility. This change implements keyboard navigation between menus. Bug: 929549 Tests: Added unit tests to cover the navigation. Change-Id: I8ae3b3bde5b8f77eb4c7be2ff22084b24bdcbf83 Reviewed-on: https://chromium-review.googlesource.com/c/1496262 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#637198} .../file_manager/foreground/js/ui/multi_menu.js | 101 ++++++++++++++++++++- .../foreground/js/ui/multi_menu_unittest.js | 90 +++++++++++++++++- 2 files changed, 183 insertions(+), 8 deletions(-) commit ccce3ab82f35dc04a45ad6c22bb02738da589314 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 03:14:33 2019 +0000 Roll src-internal 9d54d4e02689..8a2215122b55 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9d54d4e02689..8a2215122b55 Created with: gclient setdep -r src-internal@8a2215122b55 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I64af463c12fd81e618358a3edd70e50a11c1e204 Reviewed-on: https://chromium-review.googlesource.com/c/1498714 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637197} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 161ea7c85ee02596ef9520057c732bfc36c8b1e2 Author: Wenzhao Zang <wzang@chromium.org> Date: Mon Mar 4 03:04:13 2019 +0000 cros: Do not show palette welcome bubble in public sessions Also fixed an existing error: PaletteWelcomeBubbleGuestModeTest will pass even if the Guest check is removed, because |active_user_pref_service_| is null: the welcome bubble has to be created before adding the user session, and it should also switch the user to active. Bug: 916429 Change-Id: I033bc2f55808f16a77e6e333d12719a76b9cb1a0 Reviewed-on: https://chromium-review.googlesource.com/c/1497380 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637196} ash/system/palette/palette_welcome_bubble.cc | 4 ++- .../palette/palette_welcome_bubble_unittest.cc | 33 ++++++++++++---------- 2 files changed, 21 insertions(+), 16 deletions(-) commit 4ecc26a154d4773d5c19ba021b4f5c55cc94326f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 02:45:42 2019 +0000 Roll src/third_party/dawn 1c92c159adf9..a8ce0a434e12 (1 commits) https://dawn.googlesource.com/dawn.git/+log/1c92c159adf9..a8ce0a434e12 git log 1c92c159adf9..a8ce0a434e12 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 jiawei.shao@intel.com Add validation on the creation of 4x Multisampled textures Created with: gclient setdep -r src/third_party/dawn@a8ce0a434e12 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I4370add9734dd9976d940821303ccf5dafafdaac Reviewed-on: https://chromium-review.googlesource.com/c/1498713 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637195} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 813eab9829b5549f430fef3a0a7ba699cc8eb6a0 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 02:04:18 2019 +0000 Roll src-internal adaf99005d75..9d54d4e02689 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/adaf99005d75..9d54d4e02689 Created with: gclient setdep -r src-internal@9d54d4e02689 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id367f50eae4bab69d87b47de271d4520777881a5 Reviewed-on: https://chromium-review.googlesource.com/c/1498712 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637194} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 556e7283b39dcbe1d0edb22aaa9932dde20013ee Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 00:39:13 2019 +0000 Roll src-internal 8518d46bdc51..adaf99005d75 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8518d46bdc51..adaf99005d75 Created with: gclient setdep -r src-internal@adaf99005d75 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I18ae03141dffb619b4f0592ab9bb685a944bb697 Reviewed-on: https://chromium-review.googlesource.com/c/1498711 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637193} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2a411543ce9bc9f19a4f3ed3e45232a4fce843d1 Author: Jia <jiameng@chromium.org> Date: Mon Mar 4 00:30:52 2019 +0000 [On-device adaptive brightness] Implement a ModelConfigLoader. This ModelConfigLoader will be responsible for all model-customization related configs, which includes loading device-specific configs from the disk and override them from experiment flags. In the next cls, individual components using model configs will receive params from this ModelConfigLoader. Bug: 881215 Change-Id: I4133d9e2bed4fe1cc52011417a392dece002bb75 Reviewed-on: https://chromium-review.googlesource.com/c/1496115 Reviewed-by: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#637192} chrome/browser/chromeos/BUILD.gn | 6 + .../power/auto_screen_brightness/model_config.cc | 43 +++ .../power/auto_screen_brightness/model_config.h | 34 +++ .../auto_screen_brightness/model_config_loader.h | 49 ++++ .../model_config_loader_impl.cc | 264 +++++++++++++++++ .../model_config_loader_impl.h | 83 ++++++ .../model_config_loader_impl_unittest.cc | 319 +++++++++++++++++++++ 7 files changed, 798 insertions(+) commit ff30b7dfe271ed5ac84fd16850c4ba53a535fbba Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 00:05:24 2019 +0000 service worker: Remove unused code in EmbeddedWorkerTestHelper. Cleanup since most functionality was moved to FakeServiceWorker and FakeEmbeddedWorkerInstanceClient. Bug: 934665 Change-Id: I65075c8153950565d9b0266f6d391358937be5e4 Reviewed-on: https://chromium-review.googlesource.com/c/1496129 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637191} .../service_worker/embedded_worker_test_helper.cc | 22 +--------- .../service_worker/embedded_worker_test_helper.h | 48 +--------------------- .../service_worker_registration_unittest.cc | 33 +-------------- 3 files changed, 5 insertions(+), 98 deletions(-) commit b2ceb9cc5df08f234961ead71a641c4b20000683 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 00:04:06 2019 +0000 Roll src/third_party/skia c1a9feb6f06e..5800f2e8a920 (2 commits) https://skia.googlesource.com/skia.git/+log/c1a9feb6f06e..5800f2e8a920 git log c1a9feb6f06e..5800f2e8a920 --date=short --no-merges --format='%ad %ae %s' 2019-03-03 reed@google.com Reland "use colorspace steps to determine legacy blits" 2019-03-03 reed@google.com Reland "bring back lowp bilerp_clamp_8888" Created with: gclient setdep -r src/third_party/skia@5800f2e8a920 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I39c18e2070a647aa319a24e307f3ad269d34f940 Reviewed-on: https://chromium-review.googlesource.com/c/1498691 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637190} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5aeae2d17a348e9a1d7f33e3e32302518fe5bf56 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 23:42:44 2019 +0000 Roll src-internal 086b87279975..8518d46bdc51 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/086b87279975..8518d46bdc51 Created with: gclient setdep -r src-internal@8518d46bdc51 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I424f287a8c10fecf988e64f9386879420740d893 Reviewed-on: https://chromium-review.googlesource.com/c/1497790 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637189} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 438c190df166a60544433d39cc75ae2b6f0c385e Author: Dana Fried <dfried@chromium.org> Date: Sun Mar 3 23:27:34 2019 +0000 Disable actions bar resize when it cannot be resized. When the positioning or space avaialble to the browser actions bar in the toolbar changes, it needs to determine whether the resize handle should be active or not. If there is not enough space to show at least one action/extension icon, the handle should be inactive. Bug: 916209 Change-Id: Id2a325c2ff9362c41ba0674b17e4397cc6a9eb59 Reviewed-on: https://chromium-review.googlesource.com/c/1496294 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637188} .../ui/views/toolbar/browser_actions_container.cc | 29 ++- .../ui/views/toolbar/browser_actions_container.h | 7 + .../browser_actions_container_browsertest.cc | 225 +++++++++++++++++++++ 3 files changed, 256 insertions(+), 5 deletions(-) commit 9150f1e8869669af6f179680b0913031c961a9b8 Author: Jonathan Metzman <metzman@chromium.org> Date: Sun Mar 3 23:24:33 2019 +0000 [libFuzzer][Windows] Assert is_asan is true Do this so that no one tries and fails to build a fuzzer without ASAN on Win. Instead they will fail with an explanation that this doesn't work. Bug: 927808 Change-Id: I32b19350b98dcf4cdce746b2c9dbb48fdc4c881d Reviewed-on: https://chromium-review.googlesource.com/c/1497339 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637187} build/config/sanitizers/sanitizers.gni | 5 +++++ 1 file changed, 5 insertions(+) commit a4b87e2faaf09634af50632767fda98d734c4bc3 Author: Joel Hockey <joelhockey@chromium.org> Date: Sun Mar 3 23:02:53 2019 +0000 Fix login_utils_browsertest for renaming Contained Shell to Kiosk Next Shell Some renamings that were missed in crosreview.com/1489272 I can't figure how the bots missed this. Possibly a race condition with crosreview.com/1477821 Tbr: oshima@chromium.org Bug: 933530 Change-Id: I4317877cca05ab111ed08ba57d75347236941b33 Reviewed-on: https://chromium-review.googlesource.com/c/1496409 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637186} chrome/browser/chromeos/login/login_utils_browsertest.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 270813e6e1eeb0edb427f4b720319837994cc7e0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 22:51:13 2019 +0000 Roll src/third_party/skia 14f03d515823..c1a9feb6f06e (1 commits) https://skia.googlesource.com/skia.git/+log/14f03d515823..c1a9feb6f06e git log 14f03d515823..c1a9feb6f06e --date=short --no-merges --format='%ad %ae %s' 2019-03-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 7761d0dc32ad..aae499d4d09d (42 commits) Created with: gclient setdep -r src/third_party/skia@c1a9feb6f06e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: If8e72d5d05d8aa81d5de2e8cd894f305c905e309 Reviewed-on: https://chromium-review.googlesource.com/c/1497917 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637185} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9c1f824caa8bc967f89bb9fcb982415489b34d47 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 22:42:57 2019 +0000 Roll src-internal ab0b469d2c84..086b87279975 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ab0b469d2c84..086b87279975 Created with: gclient setdep -r src-internal@086b87279975 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iea1f77810c3f1aa5b5d602ab0cc808b465cace25 Reviewed-on: https://chromium-review.googlesource.com/c/1497916 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637184} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a6026eaee5e8fda47d49ca16dae488833ca2dbbd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 22:41:13 2019 +0000 Roll src/third_party/perfetto 00da64ab2e55..82b33f4ea601 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/00da64ab2e55..82b33f4ea601 git log 00da64ab2e55..82b33f4ea601 --date=short --no-merges --format='%ad %ae %s' 2019-03-03 oysteine@google.com Merge "Add a comparison operator and .clear_X() to proto_to_cpp" Created with: gclient setdep -r src/third_party/perfetto@82b33f4ea601 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7b863b46ed8acf426d76639bdf47d30cc8f47848 Reviewed-on: https://chromium-review.googlesource.com/c/1497915 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637183} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c195e55d0dc82e0e8e801139fa3d2d07ff237604 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 21:40:39 2019 +0000 Roll src/third_party/skia c6671be0ea75..14f03d515823 (1 commits) https://skia.googlesource.com/skia.git/+log/c6671be0ea75..14f03d515823 git log c6671be0ea75..14f03d515823 --date=short --no-merges --format='%ad %ae %s' 2019-03-03 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@14f03d515823 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I4a8658b1c50a2d852f92e9dc0d1b23fb616a487f Reviewed-on: https://chromium-review.googlesource.com/c/1498591 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637182} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e66ad54afaa06ff81e0d7c615d043174d24a1282 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 21:04:39 2019 +0000 Roll src-internal 2e1cc15680e6..ab0b469d2c84 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2e1cc15680e6..ab0b469d2c84 Created with: gclient setdep -r src-internal@ab0b469d2c84 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I54a641234be1e2cf004feedf1fea222efd414e28 Reviewed-on: https://chromium-review.googlesource.com/c/1498592 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637181} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9980dbe99aa967366d65595b0c7322519ba0359b Author: Yusuf Ozuysal <yusufo@google.com> Date: Sun Mar 3 20:37:15 2019 +0000 Add unit tests for TabListMediator BUG=937678 Change-Id: Ib6149b4c91f9be8afa683906614c33814513b87e Reviewed-on: https://chromium-review.googlesource.com/c/1497307 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#637180} .../tasks/tab_list_ui/TabListCoordinator.java | 5 +- .../browser/tasks/tab_list_ui/TabListMediator.java | 14 +- chrome/android/java_sources.gni | 1 + .../tasks/tab_list_ui/TabListMediatorUnitTest.java | 293 +++++++++++++++++++++ 4 files changed, 307 insertions(+), 6 deletions(-) commit d295afe67353ce059fe03323d1d47d1c299f691c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 20:13:04 2019 +0000 Roll src/third_party/depot_tools 71bae22f623e..e9e89e3aa538 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/71bae22f623e..e9e89e3aa538 git log 71bae22f623e..e9e89e3aa538 --date=short --no-merges --format='%ad %ae %s' 2019-03-03 whesse@google.com Improve error message for missing gerrit credentials in git-cl. Created with: gclient setdep -r src/third_party/depot_tools@e9e89e3aa538 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I6e9b4a37c748e22310e8c96db23badd33b1d073d Reviewed-on: https://chromium-review.googlesource.com/c/1498290 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637179} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 464ef2477687501c905db7582089fec162c22afd Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 19:33:31 2019 +0000 Roll src-internal b3d3ddb6af8a..2e1cc15680e6 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b3d3ddb6af8a..2e1cc15680e6 Created with: gclient setdep -r src-internal@2e1cc15680e6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I23de455d841f27189e712582027ab5c1be38d4ec Reviewed-on: https://chromium-review.googlesource.com/c/1498289 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637178} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aae499d4d09dc18a1dda8db00b1c56b7682a77f6 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 18:12:51 2019 +0000 Roll src-internal 00d8177c5012..b3d3ddb6af8a (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/00d8177c5012..b3d3ddb6af8a Created with: gclient setdep -r src-internal@b3d3ddb6af8a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0770f85b96715d65811bf0fcc321699a1dbd6a76 Reviewed-on: https://chromium-review.googlesource.com/c/1498288 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637177} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a1b5db89304a9d15d438eecb912f17385b83fba7 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 16:54:17 2019 +0000 Roll src-internal f49bb82e3b83..00d8177c5012 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f49bb82e3b83..00d8177c5012 Created with: gclient setdep -r src-internal@00d8177c5012 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7bedefdf437d884753b2a48b94dcd4b638d218ec Reviewed-on: https://chromium-review.googlesource.com/c/1498286 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637176} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b0c084338a56d74782ad447204af76c739ff1ae0 Author: Martin Robinson <mrobinson@igalia.com> Date: Sun Mar 3 15:35:16 2019 +0000 Have AXPlatforNodeBase::GetText return base::string16 It turns out that we always need to convert this value to base::string16 due to the fact that line and word breaks from blink are stored in base::string16 offsets. We can avoid converting and converting back by simply returning base::string16 here. This change also allows AtkText API to work in terms of UTF-16 encoded strings. We add more tests to ensure that this does not regress proper behavior with strings containing non-BMP characters. Bug: 866337 Change-Id: I85f740334073661dd20f74709de9536fb69cae0a Reviewed-on: https://chromium-review.googlesource.com/c/1482730 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637175} .../accessibility/browser_accessibility_com_win.cc | 36 +++++----- .../accessibility/browser_accessibility_win.cc | 2 +- .../platform/ax_platform_node_auralinux.cc | 84 +++++++++++++--------- .../platform/ax_platform_node_auralinux.h | 3 +- .../ax_platform_node_auralinux_unittest.cc | 69 +++++++++++++----- ui/accessibility/platform/ax_platform_node_base.cc | 10 +-- ui/accessibility/platform/ax_platform_node_base.h | 4 +- ui/accessibility/platform/ax_platform_node_mac.mm | 5 +- ui/accessibility/platform/ax_platform_node_win.cc | 19 +++-- ui/accessibility/platform/ax_platform_node_win.h | 6 +- 10 files changed, 143 insertions(+), 95 deletions(-) commit c3b788281c2922098713efdcffee2fac6f8d981e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 14:45:55 2019 +0000 Roll src-internal 44870a8bb9ad..f49bb82e3b83 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/44870a8bb9ad..f49bb82e3b83 Created with: gclient setdep -r src-internal@f49bb82e3b83 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I683cf999965f4415e17b04a1e558658a368010eb Reviewed-on: https://chromium-review.googlesource.com/c/1498283 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637174} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 429ae0373160adb41e80ffac1488281be7bd3079 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 14:16:17 2019 +0000 Roll src/third_party/skia 1b9f889628e0..c6671be0ea75 (1 commits) https://skia.googlesource.com/skia.git/+log/1b9f889628e0..c6671be0ea75 git log 1b9f889628e0..c6671be0ea75 --date=short --no-merges --format='%ad %ae %s' 2019-03-03 reed@google.com Revert "bring back lowp bilerp_clamp_8888" Created with: gclient setdep -r src/third_party/skia@c6671be0ea75 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I581f2bd60f5599f2bff9ad4b3258acc107dd086b Reviewed-on: https://chromium-review.googlesource.com/c/1498285 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637173} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7561ca0b294372e82cea812445a10ee21e7fbf40 Author: Miyoung Shin <myid.shin@igalia.com> Date: Sun Mar 3 14:14:15 2019 +0000 Refactor: unsigned short/unsigned int -> uint16_t in components/webcrypto & third_party/blink/*/web_crypto* - unsigned short / unsigned int -> uint16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929986 Change-Id: Ib286550c8e2e88f5caa4776c92c3c4451605e0bc Reviewed-on: https://chromium-review.googlesource.com/c/1491054 Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637172} components/webcrypto/algorithms/aes.cc | 2 +- components/webcrypto/algorithms/aes_cbc_unittest.cc | 6 +++--- components/webcrypto/algorithms/aes_gcm_unittest.cc | 4 ++-- components/webcrypto/algorithms/aes_kw_unittest.cc | 5 ++--- components/webcrypto/algorithms/ecdh_unittest.cc | 3 +-- components/webcrypto/algorithms/test_helpers.cc | 2 +- components/webcrypto/algorithms/test_helpers.h | 2 +- .../blink/public/platform/web_crypto_algorithm_params.h | 12 ++++++------ third_party/blink/public/platform/web_crypto_key_algorithm.h | 2 +- .../v8_script_value_deserializer_for_modules.cc | 2 +- .../renderer/platform/exported/web_crypto_key_algorithm.cc | 2 +- 11 files changed, 20 insertions(+), 22 deletions(-) commit 9adaa9cf5c0293acf4aea581d73a7cd6009a738b Author: Egor Pasko <pasko@chromium.org> Date: Sun Mar 3 12:33:10 2019 +0000 Add stacktrace scripts to telemetry isolate Add the crashpad stack walking scripts to the isolate that runs performance tests with Telemetry. There are multiple places where the python scripts can be inserted as 'data' dependencies. In the end choosing the place closest to where the native third_party/breakpad tools are pulled in. I checked that after the change the isolate 'performance_test_suite' (defined in testing/buildbot/gn_isolate_map.pyl) actually contains the new files. I used this command: shell> python tools/mb/mb.py isolate out/Release performance_test_suite Bug: 935979 Change-Id: Id6ecafc9510ef84762ce21efa537ed643f2ea251 Reviewed-on: https://chromium-review.googlesource.com/c/1497076 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#637171} tools/perf/chrome_telemetry_build/BUILD.gn | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) commit d3fb877bcead35620ce9fa958653caeaa8c47bc8 Author: Nasko Oskov <nasko@chromium.org> Date: Sun Mar 3 12:00:27 2019 +0000 Remove steps between RenderProcessHost exit observers and IPC listeners. RenderProcessHostImpl::ProcessDied uses two mechanisms to notify observers and IPC::Listeners about the process going away. The two notifications should be identical, however there is code that executes between the two. The goal of this CL is to enure that the notifications are sequential without any extra code executing between them. Bug: 566116 Change-Id: I795fd966efd196dc079fa611eedd461202d2c5d8 Reviewed-on: https://chromium-review.googlesource.com/c/1495927 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#637170} content/browser/renderer_host/render_process_host_impl.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 9d63d3384b5aaf196d2e9ff730d6401256f1901e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 11:46:52 2019 +0000 Roll src-internal 3d2820ae0098..44870a8bb9ad (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3d2820ae0098..44870a8bb9ad Created with: gclient setdep -r src-internal@44870a8bb9ad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3a0480822ceb278181a8541170c4587fe9bfe76f Reviewed-on: https://chromium-review.googlesource.com/c/1498282 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637169} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7c6228e3693d777a20c0de7122566379818a64b3 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 10:47:19 2019 +0000 Roll src-internal cf451d9bf2b2..3d2820ae0098 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf451d9bf2b2..3d2820ae0098 Created with: gclient setdep -r src-internal@3d2820ae0098 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7bad4c765c6cbee14dbbafc3a0f3823582df4b6a Reviewed-on: https://chromium-review.googlesource.com/c/1498281 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637168} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit de336c814625b87f11afaefaf5885aa6e78af6a5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 10:10:17 2019 +0000 Roll src/third_party/skia c97b0672a73f..1b9f889628e0 (1 commits) https://skia.googlesource.com/skia.git/+log/c97b0672a73f..1b9f889628e0 git log c97b0672a73f..1b9f889628e0 --date=short --no-merges --format='%ad %ae %s' 2019-03-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@1b9f889628e0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1f615cdb28c046bff836fceb2dedd06c853129ba Reviewed-on: https://chromium-review.googlesource.com/c/1498279 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637167} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 314240e242ea96bb8ea9a0bae3ce2fdf1f42478d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 09:39:17 2019 +0000 Roll src-internal e79f3276771a..cf451d9bf2b2 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e79f3276771a..cf451d9bf2b2 Created with: gclient setdep -r src-internal@cf451d9bf2b2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I356267302bbe67730e5ac9202504ec12f3d0d9b3 Reviewed-on: https://chromium-review.googlesource.com/c/1498278 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637166} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 094970038c90f70efe7d77c9c6a4c675d2e291fa Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 08:15:40 2019 +0000 Roll src-internal 7992ba06807f..e79f3276771a (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7992ba06807f..e79f3276771a Created with: gclient setdep -r src-internal@e79f3276771a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I582bbb39b5e368726060cbb1ede0bc7906053b96 Reviewed-on: https://chromium-review.googlesource.com/c/1498277 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637165} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 76e14ad2e7d9b2c4cb44d18d8c230c25a6346bbe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 07:55:45 2019 +0000 Roll src/third_party/skia 58a75383a70b..c97b0672a73f (1 commits) https://skia.googlesource.com/skia.git/+log/58a75383a70b..c97b0672a73f git log 58a75383a70b..c97b0672a73f --date=short --no-merges --format='%ad %ae %s' 2019-03-03 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@c97b0672a73f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I19802eb6e1f81ade7fbccd561d8f5261cc0a1edc Reviewed-on: https://chromium-review.googlesource.com/c/1498276 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637164} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d9c5efb26ed709d7ed2840f65e13644dec9f025e Author: Yi Gu <yigu@chromium.org> Date: Sun Mar 3 06:45:37 2019 +0000 Mark external/wpt/import-maps/fallback-disallowed.sub.tentative.html as timeout crrev.com/c/1491057 didn't mark the test as timeout which is incorrect. See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=external%2Fwpt%2Fimport-maps%2Ffallback-disallowed.sub.tentative.html TBR=hiroshige@chromium.org Bug: 936279 Change-Id: I90c40a7607118e9c3b2e2b54768cc33f65cbc7b1 Reviewed-on: https://chromium-review.googlesource.com/c/1498341 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637163} third_party/blink/web_tests/TestExpectations | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b96fb7dbfc3be202d4065da9080a0b1d23673262 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sun Mar 3 06:43:17 2019 +0000 Update V8 to version 7.4.269. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/26573c52..c7724d93 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibc8305752870517797ce65bc65029973fc4b4259 Reviewed-on: https://chromium-review.googlesource.com/c/1498336 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637162} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8293eeb6976e8921b343e231e0f31c6ecc48e01a Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Sun Mar 3 06:43:07 2019 +0000 OnionSoup: Clean up all uses of UseCounter::Count(const LocalFrame*) in blink/renderer/core As the plan to replace UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document& or ExecutionContext* or DocumentLoader*), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document&). Additionally, this CL replaces it in NavigatorServiceWorker of blink/renderer/modules. Bug: 936187 Change-Id: I437e34726a71294c4e21f4285a58d194f98969a1 Reviewed-on: https://chromium-review.googlesource.com/c/1496133 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637161} .../blink/renderer/core/editing/dom_selection.cc | 21 ++++++++++++++------- .../blink/renderer/core/events/touch_event.cc | 2 +- .../renderer/core/input/pointer_event_manager.cc | 8 +++++--- .../blink/renderer/core/loader/document_loader.cc | 2 +- .../renderer/core/page/autoscroll_controller.cc | 3 ++- .../blink/renderer/core/page/chrome_client.cc | 3 ++- third_party/blink/renderer/core/page/frame_tree.cc | 2 +- .../renderer/core/timing/window_performance.cc | 10 ++++++---- .../service_worker/navigator_service_worker.cc | 6 ++++-- 9 files changed, 36 insertions(+), 21 deletions(-) commit 5f15c6460cb1989c0743bfa108b1cb9156e02a87 Author: Yi Gu <yigu@chromium.org> Date: Sun Mar 3 06:38:48 2019 +0000 Disable flaky telemetry_perf_unittest The test CLIHelpersTest.testAskWithInvalidDefaultAnswer is really flaky on android and chromeos. See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_perf_unittests&tests=core.cli_helpers_unittest.CLIHelpersTest.testAskWithInvalidDefaultAnswer TBR=sergiyb@chromium.org Bug: 937654 Change-Id: I99aab6c47d7971bc1fcf183cd5318b3eccf7da88 Reviewed-on: https://chromium-review.googlesource.com/c/1498340 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637160} tools/perf/core/cli_helpers_unittest.py | 3 +++ 1 file changed, 3 insertions(+) commit 4d3c96685a5aff139a02b612cf9c4a91e23de3ea Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 06:23:34 2019 +0000 Roll src-internal 77bf2b56dbad..7992ba06807f (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77bf2b56dbad..7992ba06807f Created with: gclient setdep -r src-internal@7992ba06807f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib213439255e9276234258b3fb309006670761a46 Reviewed-on: https://chromium-review.googlesource.com/c/1498275 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637159} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3d4285e69d2700bb37b0cdc7fdaa9b597f77b7c8 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 05:16:43 2019 +0000 Roll src-internal 1bd704a6689c..77bf2b56dbad (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1bd704a6689c..77bf2b56dbad Created with: gclient setdep -r src-internal@77bf2b56dbad The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id4bb40334ca3dca213cfdebb934eeb6a16880af6 Reviewed-on: https://chromium-review.googlesource.com/c/1498274 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637158} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2da17d5c943af5d3eea4a18d0d3fdcd1638a246d Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Sun Mar 3 04:11:09 2019 +0000 Updating trunk VERSION from 3723.0 to 3724.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Iac3acc49351ff38461fb371afe84848a4d2bc3cf Reviewed-on: https://chromium-review.googlesource.com/c/1496286 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#637157} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 632ea11d26ff8416c0e21373f517924c85316402 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 04:00:51 2019 +0000 Roll src-internal 572e1eb0b1c7..1bd704a6689c (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/572e1eb0b1c7..1bd704a6689c Created with: gclient setdep -r src-internal@1bd704a6689c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1d66ff00bdf9b7a90c4712e2b6b0bb0f4ede8789 Reviewed-on: https://chromium-review.googlesource.com/c/1498272 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637156} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d5d31d1840df51d6473df57adbf83deebac09190 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 3 02:51:21 2019 +0000 Roll src/third_party/skia 0d7012a80c17..58a75383a70b (1 commits) https://skia.googlesource.com/skia.git/+log/0d7012a80c17..58a75383a70b git log 0d7012a80c17..58a75383a70b --date=short --no-merges --format='%ad %ae %s' 2019-03-03 reed@google.com change particleslide to use Resources Created with: gclient setdep -r src/third_party/skia@58a75383a70b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ib1be9fa3196d4bde86c41c03e2ba3247e1c1faa7 Reviewed-on: https://chromium-review.googlesource.com/c/1498271 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637155} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 755159f74f807dfe46033e2f933505422b89faf1 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 02:29:10 2019 +0000 Roll src-internal 21e23bf63aa5..572e1eb0b1c7 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/21e23bf63aa5..572e1eb0b1c7 Created with: gclient setdep -r src-internal@572e1eb0b1c7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide4e89378aabc7082b49d2c35b5cd33f0ca39f97 Reviewed-on: https://chromium-review.googlesource.com/c/1498213 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637154} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2f2e4fdc7539705d857041da5edd4c81ba9694d2 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Sun Mar 3 01:34:28 2019 +0000 flags: augment unowned-flags tool This tool can now: --expired-by <mstone>, to find flags that have expired at that mstone --never-expires, to list all the -1 expiry flags --verbose, to print details about the flags it finds Bug: 897809 Change-Id: Ia538d628fcb25f5d5022a5849a06c7502183956b Reviewed-on: https://chromium-review.googlesource.com/c/1488032 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#637153} tools/flags/list-flags.py | 109 ++++++++++++++++++++++++++++++++++++++++------ 1 file changed, 95 insertions(+), 14 deletions(-) commit d7cc9f08754a075e438469d0c430716b4f02f5da Author: Yi Gu <yigu@chromium.org> Date: Sun Mar 3 01:10:06 2019 +0000 Disable flaky WebApkUpdateManagerUnitTests testPendingUpdateFileDeletedAfterUpdateCompletion and testFileDeletedIfStoreWebApkUpdateRequestToFileFails are flaky. Patch crrev.com/c/1495971 didn't disable them correctly. TBR=pkotwicz@chromium.org Bug: 937109 Change-Id: Id6c2014dfc5d84bae1e74b1eb5b365e18dac7e09 Reviewed-on: https://chromium-review.googlesource.com/c/1498211 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637152} .../chrome/browser/webapps/WebApkUpdateManagerUnitTest.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 50309bd3842d55c4f1bf54f0f93af86eb2b6c16c Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Sun Mar 3 01:06:06 2019 +0000 Android: Move createBringTabToFrontIntent from Tab to IntentUtils. IntentUtils now provides the utility methods to others. Also helps Tab avoid various dependencies added to handle the intent creation. Bug: 925242 Change-Id: I9edd1dacbeb612c2f03db393c6916765fee8ca36 Reviewed-on: https://chromium-review.googlesource.com/c/1490363 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#637151} .../router/caf/CafNotificationController.java | 6 ++-- .../browseractions/BrowserActionsService.java | 2 +- .../chrome/browser/document/DocumentActivity.java | 5 +++- .../chrome/browser/download/DownloadUtils.java | 2 +- .../media/MediaCaptureNotificationService.java | 3 +- .../browser/media/ui/MediaSessionTabHelper.java | 3 +- .../src/org/chromium/chrome/browser/tab/Tab.java | 26 ----------------- .../browser/tab/TabWebContentsDelegateAndroid.java | 3 +- .../chromium/chrome/browser/util/IntentUtils.java | 34 +++++++++++++++++++++- .../chrome/browser/webapps/WebappModeTest.java | 4 +-- 10 files changed, 50 insertions(+), 38 deletions(-) commit c3ddc673cb45e01c7778a87dad3519600d9864bf Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 3 00:45:26 2019 +0000 Roll src-internal c5515150536d..21e23bf63aa5 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5515150536d..21e23bf63aa5 Created with: gclient setdep -r src-internal@21e23bf63aa5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If8a4a921d979653ab28af2f134778b736c69c5bc Reviewed-on: https://chromium-review.googlesource.com/c/1498027 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637150} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8d69b9ce217c0afa10642f574ed9b3a45f200746 Author: Yi Gu <yigu@chromium.org> Date: Sat Mar 2 23:48:14 2019 +0000 Mark external/wpt/html/browsers/browsing-the-web/read-media/pageload-image-in-popup.html as flaky on Linux Debug Suspecting crrev.com/c/1399447. Given the patch has been landed for 24 hours, marking the test as flaky. TBR=dgozman@chromium.org NOTRY=true Bug: 937639 Change-Id: I05ac16f7948b69a4712d2994e06ef6a3df9b3dfb Reviewed-on: https://chromium-review.googlesource.com/c/1498029 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637149} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit dd4753b05200a8ac278bcce14d0899a42a726fd1 Author: Yi Gu <yigu@chromium.org> Date: Sat Mar 2 23:47:34 2019 +0000 Disable test DrmGpuDisplayManagerTest.GetDisplays on ChromeOS Findit found the culprit crrev.com/c/1373138 with 90% confidence. Given that the patch has been landed more than 24 hours, disabling the test instead of reverting the culprit. TBR=andrewxu@chromium.org Bug: 937638 Change-Id: I34ada963a6c8210548c96288654d515a34bb4ce8 Reviewed-on: https://chromium-review.googlesource.com/c/1498025 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637148} ui/ozone/platform/drm/gpu/drm_gpu_display_manager_unittest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 59215d258f42fc6de66c77fa7671d300a44df70a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 23:37:14 2019 +0000 Roll src-internal e7c392b9f74b..c5515150536d (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e7c392b9f74b..c5515150536d Created with: gclient setdep -r src-internal@c5515150536d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I91437cce753e47549f63f5e11d42ff562f6959e2 Reviewed-on: https://chromium-review.googlesource.com/c/1498034 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637147} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d280c9801c0c0aa391180984400c1ffbad43bcb5 Author: dpapad <dpapad@chromium.org> Date: Sat Mar 2 23:26:34 2019 +0000 WebUI cleanup: Remove third_party/bidichecker and leftovers. It's essentially dead code, and there are no plans to reinstate those tests. Also note that after this CL lands, planning to delete the obsolete documentation at [1] as well. [1] https://sites.google.com/a/chromium.org/dev/developers/testing/bidichecker Bug: None Change-Id: I34277583aa1abb4aa49035805a49399c849825d5 Reviewed-on: https://chromium-review.googlesource.com/c/1495853 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#637146} .gn | 1 - DEPS | 3 - chrome/test/data/webui/bidichecker_tests.js | 128 -------------------------- ios/web/webui/url_data_manager_ios_backend.mm | 3 +- third_party/.gitignore | 1 - tools/licenses.py | 3 - 6 files changed, 1 insertion(+), 138 deletions(-) commit 16853a606c62a908d625039c02304776a76c7a0a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 23:10:04 2019 +0000 Roll src/third_party/chromite e931c51da4d9..d6a2367b5587 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/e931c51da4d9..d6a2367b5587 git log e931c51da4d9..d6a2367b5587 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 dtor@chromium.org usergroup_baseline: add entry for pluginvm group Created with: gclient setdep -r src/third_party/chromite@d6a2367b5587 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6e4df841d4067e6d88a11d8ad095b1e3f65fd918 Reviewed-on: https://chromium-review.googlesource.com/c/1498033 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637145} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4a7c31f3d3cba90c3f8fc1b9174dd34bcc243cbc Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 22:12:13 2019 +0000 Roll src-internal 7a5b434ecd06..e7c392b9f74b (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7a5b434ecd06..e7c392b9f74b Created with: gclient setdep -r src-internal@e7c392b9f74b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9378db7d05d640d797a31ce1026819c9c1f07d8e Reviewed-on: https://chromium-review.googlesource.com/c/1497894 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637144} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2a1b8ba7380968169f3d6c5dc407307e207bcdbf Author: Scott Violet <sky@chromium.org> Date: Sat Mar 2 21:43:23 2019 +0000 ui/cc minor doc updates Updates ui::Layer::SetMasksToBounds() to indicate masking also applies to this layer. Updates how_to reference in cc/README.md to point to the updated place. BUG=none TEST=none Change-Id: I0f94a91afc3d8260723afde62a51de6561c245c7 Reviewed-on: https://chromium-review.googlesource.com/c/1497634 Auto-Submit: Scott Violet <sky@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637143} cc/README.md | 2 +- ui/compositor/layer.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) commit bc992bb8e2eb1cb18decaec346aae27c70675dd4 Author: Peng Huang <penghuang@chromium.org> Date: Sat Mar 2 21:35:17 2019 +0000 Add a lock in SharedImageManager to make it thread safe. SharedImageManager will be used cross threads for WebView. So we need make it thread safe. Bug: 937060 Change-Id: I81aa19a07204df6a13eaead1f1b9eacc86bf9bd6 Reviewed-on: https://chromium-review.googlesource.com/c/1495969 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#637142} gpu/command_buffer/service/shared_image_manager.cc | 67 ++++++++++++++++++++-- gpu/command_buffer/service/shared_image_manager.h | 13 ++++- gpu/ipc/in_process_gpu_thread_holder.cc | 1 + 3 files changed, 75 insertions(+), 6 deletions(-) commit 030ca2f1a9492388cb713779a8134856ffcfa2a0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 20:50:37 2019 +0000 Roll src/third_party/skia c945f0e31a53..0d7012a80c17 (1 commits) https://skia.googlesource.com/skia.git/+log/c945f0e31a53..0d7012a80c17 git log c945f0e31a53..0d7012a80c17 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src cddf8925a8d8..7761d0dc32ad (267 commits) Created with: gclient setdep -r src/third_party/skia@0d7012a80c17 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I901eac4af7095f91910bd5daedff3ec2d23d2415 Reviewed-on: https://chromium-review.googlesource.com/c/1497893 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637141} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 693b07c25e764c774099ee702ac85ff3d9bb96f3 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 20:38:47 2019 +0000 Roll src-internal 84459ccc0af3..7a5b434ecd06 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84459ccc0af3..7a5b434ecd06 Created with: gclient setdep -r src-internal@7a5b434ecd06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I9e0ddf5acea9a670963af4af92894dcf3d1a8349 Reviewed-on: https://chromium-review.googlesource.com/c/1498072 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637140} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 523f7fcdbbe0ff85549f13f4e13d4ea63ea9c398 Author: Evan Stade <estade@chromium.org> Date: Sat Mar 2 19:20:51 2019 +0000 Extract PowerManagerClient from DBusThreadManager Tests can now use [Fake]PowerManagerClient::Get() instead of creating their own FakePowerManagerClient. The presence or absence of the system bus is used to determine whether to make FakePowerManagerClient or PowerManagerClientImpl. Many tests are updated. Most of the more substantive-looking changes are just refactoring code to do more setup/teardown in SetUp and TearDown instead of in ctor/dtor, which is necessary since we're enforcing that PowerManagerClient is a singleton. Bug: 647367,644348 Change-Id: I42da97755ae839d7c98bcae2e5d02c7341c38580 Reviewed-on: https://chromium-review.googlesource.com/c/1484852 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637139} ash/accelerators/accelerator_controller.cc | 2 +- .../accessibility_controller_unittest.cc | 36 +-- ash/ash_service.cc | 4 +- ash/detachable_base/detachable_base_handler.cc | 2 +- .../detachable_base_handler_unittest.cc | 41 ++- ...chable_base_notification_controller_unittest.cc | 14 +- ash/display/projecting_observer.cc | 7 +- ash/display/projecting_observer.h | 12 - ash/display/projecting_observer_unittest.cc | 60 ++-- ...k_screen_note_display_state_handler_unittest.cc | 83 +++-- ash/login/ui/lock_contents_view.cc | 6 +- ash/login/ui/lock_contents_view_unittest.cc | 19 +- ash/login/ui/login_auth_user_view.cc | 3 +- ash/login/ui/login_auth_user_view_unittest.cc | 11 +- ash/shell.cc | 10 +- ash/shell.h | 3 + .../content/client/shell_browser_main_parts.cc | 2 +- ash/shutdown_controller.cc | 4 +- ash/system/audio/display_speaker_controller.cc | 5 +- .../brightness/brightness_controller_chromeos.cc | 17 +- .../keyboard_brightness_controller.cc | 8 +- ash/system/night_light/night_light_controller.cc | 6 +- ash/system/power/backlights_forced_off_setter.cc | 29 +- .../power/backlights_forced_off_setter_unittest.cc | 47 ++- ash/system/power/notification_reporter.cc | 22 +- ash/system/power/notification_reporter.h | 8 +- ash/system/power/notification_reporter_unittest.cc | 89 +++--- ash/system/power/peripheral_battery_notifier.cc | 6 +- ash/system/power/power_button_controller.cc | 5 +- .../power/power_button_controller_unittest.cc | 144 ++++----- .../power/power_button_display_controller.cc | 6 +- .../power_button_screenshot_controller_unittest.cc | 16 +- ash/system/power/power_button_test_base.cc | 2 - ash/system/power/power_button_test_base.h | 2 - ash/system/power/power_event_observer.cc | 12 +- ash/system/power/power_event_observer_unittest.cc | 30 +- ash/system/power/power_prefs_unittest.cc | 18 +- ash/system/power/power_status.cc | 14 +- ash/system/power/power_status_unittest.cc | 6 +- ash/system/power/video_activity_notifier.cc | 6 +- .../power/video_activity_notifier_unittest.cc | 2 +- ash/system/unified/unified_system_tray_model.cc | 6 +- ash/test/ash_test_base.cc | 5 + ash/test/ash_test_base.h | 7 + ash/test/ash_test_helper.cc | 6 +- ash/test/ash_test_helper.h | 4 +- ash/wm/lock_state_controller_unittest.cc | 2 +- ash/wm/tablet_mode/tablet_mode_controller.cc | 10 +- .../tablet_mode/tablet_mode_controller_unittest.cc | 6 +- .../browser/apps/platform_apps/app_browsertest.cc | 13 +- chrome/browser/chromeos/app_mode/app_session.cc | 2 +- .../kiosk_mode_idle_app_name_notification.cc | 14 +- .../arc/arc_migration_guide_notification.cc | 4 +- .../arc_migration_guide_notification_unittest.cc | 10 +- .../chromeos/arc/arc_session_manager_unittest.cc | 6 +- .../enrollment_policy_observer_unittest.cc | 19 +- .../event_based_status_reporting_service.cc | 4 +- ...vent_based_status_reporting_service_unittest.cc | 11 +- .../child_accounts/usage_time_state_notifier.cc | 4 +- .../usage_time_state_notifier_unittest.cc | 10 +- .../chromeos/chrome_browser_main_chromeos.cc | 6 +- chrome/browser/chromeos/dbus/dbus_helper.cc | 3 + .../extensions/file_manager/event_router.cc | 6 +- .../file_manager/volume_manager_factory.cc | 4 +- .../file_manager/volume_manager_unittest.cc | 12 +- .../chromeos/lock_screen_apps/state_controller.cc | 3 +- .../lock_screen_apps/state_controller_unittest.cc | 14 +- .../login/easy_unlock/easy_unlock_service.cc | 6 +- .../easy_unlock_service_unittest_chromeos.cc | 16 +- .../chromeos/login/enable_debugging_browsertest.cc | 15 +- chrome/browser/chromeos/login/reset_browsertest.cc | 41 ++- .../browser/chromeos/login/screens/error_screen.cc | 2 +- .../browser/chromeos/login/screens/reset_screen.cc | 4 +- .../chromeos/network_change_manager_client.cc | 4 +- .../network_change_manager_client_unittest.cc | 21 +- .../owner_settings_service_chromeos_unittest.cc | 36 ++- .../policy/app_install_event_log_collector.cc | 6 +- .../app_install_event_log_collector_unittest.cc | 15 +- .../policy/app_install_event_logger_unittest.cc | 5 +- ...cloud_external_data_policy_observer_unittest.cc | 16 +- ...evice_cloud_policy_manager_chromeos_unittest.cc | 66 ++-- .../device_cloud_policy_store_chromeos_unittest.cc | 111 +++---- ...device_local_account_policy_service_unittest.cc | 66 ++-- .../chromeos/policy/device_status_collector.cc | 3 +- .../policy/device_status_collector_browsertest.cc | 20 +- .../off_hours/device_off_hours_controller.cc | 34 +- .../device_off_hours_controller_unittest.cc | 73 ++--- .../chromeos/policy/power_policy_browsertest.cc | 55 ++-- .../device_commands_factory_chromeos.cc | 4 +- .../chromeos/policy/status_uploader_unittest.cc | 3 + .../auto_screen_brightness/adapter_unittest.cc | 27 +- .../brightness_monitor_impl_unittest.cc | 29 +- .../power/auto_screen_brightness/controller.cc | 2 +- .../metrics_reporter_unittest.cc | 14 +- .../chromeos/power/extension_event_observer.cc | 10 +- .../power/extension_event_observer_unittest.cc | 114 ++++--- .../chromeos/power/idle_action_warning_observer.cc | 4 +- .../power/ml/adaptive_screen_brightness_manager.cc | 2 +- .../adaptive_screen_brightness_manager_unittest.cc | 46 +-- .../power/ml/idle_event_notifier_unittest.cc | 18 +- .../chromeos/power/ml/user_activity_controller.cc | 2 +- .../power/ml/user_activity_manager_unittest.cc | 43 ++- .../browser/chromeos/power/power_data_collector.cc | 14 +- .../power/power_data_collector_unittest.cc | 13 +- .../power/power_metrics_reporter_unittest.cc | 34 +- chrome/browser/chromeos/power/renderer_freezer.cc | 6 +- .../chromeos/power/renderer_freezer_unittest.cc | 35 +-- .../settings/device_settings_provider_unittest.cc | 84 ++--- .../settings/device_settings_service_unittest.cc | 349 +++++++++++---------- .../settings/device_settings_test_helper.cc | 50 ++- .../settings/device_settings_test_helper.h | 13 +- .../chromeos/system/automatic_reboot_manager.cc | 12 +- .../system/automatic_reboot_manager_unittest.cc | 47 ++- .../chromeos/tether/tether_service_factory.cc | 5 +- .../chromeos/tether/tether_service_unittest.cc | 13 +- .../api/runtime/chrome_runtime_api_delegate.cc | 2 +- chrome/browser/lifetime/application_lifetime.cc | 2 +- .../chrome_metrics_service_client_unittest.cc | 16 +- .../metrics/chromeos_metrics_provider_unittest.cc | 15 +- .../metrics/perf/profile_provider_chromeos.cc | 6 +- .../perf/profile_provider_chromeos_unittest.cc | 14 +- chrome/browser/ui/ash/assistant/device_actions.cc | 11 +- .../test/view_event_test_platform_part_chromeos.cc | 3 +- .../emulator/device_emulator_message_handler.cc | 3 +- .../login/enable_debugging_screen_handler.cc | 2 +- .../login/encryption_migration_screen_handler.cc | 14 +- ...encryption_migration_screen_handler_unittest.cc | 7 +- .../webui/chromeos/login/signin_screen_handler.cc | 8 +- .../settings/chromeos/device_power_handler.cc | 19 +- .../chromeos/device_power_handler_browsertest.cc | 16 +- .../proximity_auth/unlock_manager_impl.cc | 7 +- .../proximity_auth/unlock_manager_impl_unittest.cc | 31 +- chromeos/dbus/BUILD.gn | 1 + chromeos/dbus/dbus_clients_common.cc | 5 - chromeos/dbus/dbus_clients_common.h | 2 - chromeos/dbus/dbus_thread_manager.cc | 11 - chromeos/dbus/dbus_thread_manager.h | 3 - chromeos/dbus/dbus_thread_manager_unittest.cc | 3 - chromeos/dbus/fake_power_manager_client.cc | 20 +- chromeos/dbus/fake_power_manager_client.h | 5 +- chromeos/dbus/native_timer.cc | 10 +- chromeos/dbus/native_timer_unittest.cc | 19 +- chromeos/dbus/power_manager_client.cc | 143 +++++---- chromeos/dbus/power_manager_client.h | 25 +- chromeos/dbus/power_manager_client_unittest.cc | 44 +-- chromeos/dbus/power_policy_controller_unittest.cc | 156 ++++----- chromeos/disks/disk_mount_manager.cc | 6 +- chromeos/disks/disk_mount_manager_unittest.cc | 18 +- chromeos/disks/suspend_unmount_manager.cc | 13 +- chromeos/disks/suspend_unmount_manager.h | 4 +- chromeos/disks/suspend_unmount_manager_unittest.cc | 2 +- chromeos/network/network_handler.cc | 3 - chromeos/services/assistant/service.cc | 2 +- chromeos/services/assistant/service_unittest.cc | 14 +- chromeos/system/dark_resume_controller.cc | 12 +- chromeos/system/dark_resume_controller_unittest.cc | 43 +-- components/arc/metrics/arc_metrics_service.cc | 6 +- .../arc/metrics/arc_metrics_service_unittest.cc | 6 +- components/arc/power/arc_power_bridge.cc | 24 +- components/arc/power/arc_power_bridge_unittest.cc | 47 +-- components/arc/timer/arc_timer_bridge.cc | 7 +- components/arc/timer/arc_timer_bridge_unittest.cc | 5 +- .../net/network_metrics_provider_unittest.cc | 14 +- .../system_power_source/system_power_source_api.cc | 14 +- .../system_power_source_api_unittest.cc | 40 +-- .../system_power_source_apitest.cc | 47 +-- .../api/runtime/shell_runtime_api_delegate.cc | 6 +- .../shell/browser/shell_browser_main_parts.cc | 4 + .../shell/browser/shell_desktop_controller_aura.cc | 14 +- .../shell_desktop_controller_aura_unittest.cc | 44 +-- .../video_capture_device_chromeos_halv3.cc | 9 +- .../capture/video/video_capture_device_unittest.cc | 9 +- .../battery/battery_status_manager_chromeos.cc | 5 +- .../user_activity_power_manager_notifier.cc | 4 +- 174 files changed, 1751 insertions(+), 1912 deletions(-) commit 7cdfe3acfe05dc858c5b150a5d53fe46cda0d753 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 19:20:31 2019 +0000 Roll src-internal a205c81b19c5..84459ccc0af3 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a205c81b19c5..84459ccc0af3 Created with: gclient setdep -r src-internal@84459ccc0af3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie7281da922ffad4e9a256904b5611c880bd5b103 Reviewed-on: https://chromium-review.googlesource.com/c/1497788 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637138} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 92a1fe307a40ec7a1954d6566a06a03020d324c3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 19:00:48 2019 +0000 Roll src/third_party/catapult ccde41b4c52b..b3bee2e7d9f1 (1 commits) https://chromium.googlesource.com/catapult.git/+log/ccde41b4c52b..b3bee2e7d9f1 git log ccde41b4c52b..b3bee2e7d9f1 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 sadrul@chromium.org expectations/benchmark: Add list of supported platforms. Created with: gclient setdep -r src/third_party/catapult@b3bee2e7d9f1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:935757,chromium:932409 TBR=sullivan@chromium.org Change-Id: Ib6d2203eb1241b6c829f9647ae33d7daeaaa5f08 Reviewed-on: https://chromium-review.googlesource.com/c/1497787 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637137} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d914a0df01b62c8d166fa8608b063af6f8fc612b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 18:56:48 2019 +0000 Roll src/third_party/skia 9159c8ef83b2..c945f0e31a53 (1 commits) https://skia.googlesource.com/skia.git/+log/9159c8ef83b2..c945f0e31a53 git log 9159c8ef83b2..c945f0e31a53 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 reed@google.com Revert "use colorspace steps to determine legacy blits" Created with: gclient setdep -r src/third_party/skia@c945f0e31a53 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I72c37bc90adf6ea6da48c9c8bfe689d0b32d0575 Reviewed-on: https://chromium-review.googlesource.com/c/1498071 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637136} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7761d0dc32ad45d830ca51a3eff8aab0ca1b593b Author: Khushal <khushalsagar@chromium.org> Date: Sat Mar 2 17:49:06 2019 +0000 cc: Mark decode as used in transfer cache uploads. R=ericrk@chromium.org Change-Id: I77232ee0300a7e4b49c5a7e2bcc561099a868405 Reviewed-on: https://chromium-review.googlesource.com/c/1497853 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#637135} cc/tiles/gpu_image_decode_cache.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3833dbc5a67dcb00f88840b72a72e41a71477ebe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 17:26:14 2019 +0000 Roll src/third_party/perfetto 640200f64d14..00da64ab2e55 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/640200f64d14..00da64ab2e55 git log 640200f64d14..00da64ab2e55 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 primiano@google.com Add git version to trace processor Created with: gclient setdep -r src/third_party/perfetto@00da64ab2e55 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I12a94f1f4eb7bd9c100a0775416959abfad90cf6 Reviewed-on: https://chromium-review.googlesource.com/c/1497786 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637134} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 12df78f81713eba7e978d348cd5ca76b7d4e2c46 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 17:11:11 2019 +0000 Roll src-internal c1aae30db14d..a205c81b19c5 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c1aae30db14d..a205c81b19c5 Created with: gclient setdep -r src-internal@a205c81b19c5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I344638f9f341a30b4bb9465c83d7474363aea7b0 Reviewed-on: https://chromium-review.googlesource.com/c/1497785 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637133} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1481951b3756101d5fdf8e0cf9ca423a502c7b3d Author: Matt Menke <mmenke@chromium.org> Date: Sat Mar 2 16:59:58 2019 +0000 Remove respect_limits from ConnectJob layer. With flat socket pools, ConnectJobs are all below the socket pool layer, so no longer need to know about socket pool limits. Bug: 927100 Change-Id: I27990b43974560f6b638f7979657a78d8e8f1aa5 Reviewed-on: https://chromium-review.googlesource.com/c/1495363 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637132} net/http/http_proxy_client_socket_wrapper.cc | 5 ----- net/http/http_proxy_client_socket_wrapper_unittest.cc | 2 -- net/http/http_proxy_connect_job_unittest.cc | 5 ++--- net/socket/client_socket_pool_base.cc | 15 ++------------- net/socket/client_socket_pool_base_unittest.cc | 2 -- net/socket/connect_job.cc | 5 ----- net/socket/connect_job.h | 9 --------- net/socket/connect_job_unittest.cc | 1 - net/socket/socks_connect_job_unittest.cc | 6 +++--- net/socket/ssl_connect_job_unittest.cc | 9 ++++----- net/socket/transport_client_socket_pool.cc | 1 - net/socket/transport_client_socket_pool_unittest.cc | 9 ++++----- net/socket/transport_connect_job_unittest.cc | 6 +++--- net/socket/websocket_transport_client_socket_pool.cc | 1 - net/spdy/spdy_proxy_client_socket_unittest.cc | 5 ++--- 15 files changed, 20 insertions(+), 61 deletions(-) commit df1aafa964c2ad1b8342d691828dea643a201d53 Author: Michael Spang <spang@chromium.org> Date: Sat Mar 2 16:09:43 2019 +0000 Opt into base::ThreadPriority::DISPLAY for all ozone builds Some ozone builds (e.g. Chromecast) are not prioritizing latency sensitive graphics work properly due to narrowly scoped #ifdefs. Expand them to apply to all ozone builds. This changes the portion of wall time the UI thread spends waiting to run from ~19% to ~7% in a simple fling benchmark on Google Home Hub. Bug: 937462 Change-Id: I59555bcad610e6b95d916f129dbd6db497d55970 Reviewed-on: https://chromium-review.googlesource.com/c/1497297 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637131} components/viz/service/main/viz_compositor_thread_runner.cc | 2 +- components/viz/service/main/viz_main_impl.cc | 2 +- content/browser/browser_main_loop.cc | 2 +- content/browser/browser_process_sub_thread.cc | 2 +- content/browser/gpu/gpu_process_host.cc | 2 +- content/gpu/gpu_main.cc | 4 ++-- third_party/blink/renderer/platform/scheduler/common/thread.cc | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) commit 81c2d6d9f9bce9727270bb9707b2bff6fa90b76d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 15:49:44 2019 +0000 Roll src-internal 1ad40a34b2b8..c1aae30db14d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ad40a34b2b8..c1aae30db14d Created with: gclient setdep -r src-internal@c1aae30db14d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ieb532118c282cffb1da4f4859430d398878d49d1 Reviewed-on: https://chromium-review.googlesource.com/c/1497784 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637130} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 82121ad399ca5a14faef1aff94c724ffd0ba8a08 Author: Marina Ciocea <marinaciocea@chromium.org> Date: Sat Mar 2 15:25:24 2019 +0000 Onion Soup DataChannel. Merge the DataChannel implementation from content/ into blink/. Remove content::RtcDataChannelHandler and the interfaces between content/ and blink/, WebRTCDataChannelHandler and WebRTCDataChannelHandlerClient. Move content::RtcDataChannelHandler::Observer into blink::RTCDataChannel::Observer. Have blink::RTCDataChannel register an webrtc::DataChannel observer instead of content::RtcDataChannelHandler. When creating data channels in peer connection implementation, pass on the webrtc::DataChannelInterface to blink::RTCDataChannel instead of creating a content::RtcDataChannelHandler. Design doc: http://doc/18SC6XjEoe236DGkxtVLuojZ4lqb8i8soCsrJixOEiR8 Bug: 931698 Change-Id: I5eb773fe183ac2a4490eea6c7a9b911d210b363a Reviewed-on: https://chromium-review.googlesource.com/c/1475468 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#637129} content/renderer/BUILD.gn | 2 - .../mock_web_rtc_peer_connection_handler_client.h | 5 +- .../media/webrtc/rtc_data_channel_handler.cc | 369 ---------------- .../media/webrtc/rtc_data_channel_handler.h | 112 ----- .../webrtc/rtc_data_channel_handler_unittest.cc | 85 ---- .../media/webrtc/rtc_peer_connection_handler.cc | 24 +- .../media/webrtc/rtc_peer_connection_handler.h | 6 +- .../webrtc/rtc_peer_connection_handler_unittest.cc | 8 +- content/test/BUILD.gn | 1 - third_party/blink/public/BUILD.gn | 2 - .../public/platform/web_rtc_data_channel_handler.h | 62 --- .../platform/web_rtc_data_channel_handler_client.h | 55 --- .../platform/web_rtc_peer_connection_handler.h | 3 +- .../web_rtc_peer_connection_handler_client.h | 5 +- .../blink/renderer/modules/peerconnection/DEPS | 6 + .../modules/peerconnection/rtc_data_channel.cc | 471 +++++++++++++++------ .../modules/peerconnection/rtc_data_channel.h | 94 ++-- .../peerconnection/rtc_data_channel_test.cc | 398 ++++++++++++----- .../modules/peerconnection/rtc_peer_connection.cc | 69 ++- .../modules/peerconnection/rtc_peer_connection.h | 3 +- .../testing_platform_support_with_web_rtc.cc | 3 +- .../testing_platform_support_with_web_rtc.h | 2 +- 22 files changed, 760 insertions(+), 1025 deletions(-) commit 920f139741c57c224f2f8c0f98dd13fb23b437ff Author: Daniele Castagna <dcastagna@chromium.org> Date: Sat Mar 2 15:19:04 2019 +0000 ui: Cache ShelfWidget render pass ShelfWidget creates a renderpass for the rounded corners background that is currently composited for each frame, even when it does not change. This patch requests to the layer to cache that renderpass. Change-Id: If1234e3523bb97f0f8c93855cd22e837644dc4d6 Reviewed-on: https://chromium-review.googlesource.com/c/1496922 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Manu Cornet <manucornet@chromium.org> Reviewed-by: Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#637128} ash/shelf/shelf_widget.cc | 3 +++ 1 file changed, 3 insertions(+) commit 948226e36f410bb8e280913effc87094d069be3b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 14:41:16 2019 +0000 Roll src/third_party/skia 705e67347962..9159c8ef83b2 (1 commits) https://skia.googlesource.com/skia.git/+log/705e67347962..9159c8ef83b2 git log 705e67347962..9159c8ef83b2 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6f1a852fce0b..4d153383bd3a (1 commits) Created with: gclient setdep -r src/third_party/skia@9159c8ef83b2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I420f7a7bd8afa700c064ea06564e819993720587 Reviewed-on: https://chromium-review.googlesource.com/c/1497781 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637127} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dc78c90507c806c8a5b9e6de682b2206f108da95 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 14:41:12 2019 +0000 Roll src-internal f0a1b048927d..1ad40a34b2b8 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f0a1b048927d..1ad40a34b2b8 Created with: gclient setdep -r src-internal@1ad40a34b2b8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6677e1e1c30201cae887fda1bf7447d79d008a18 Reviewed-on: https://chromium-review.googlesource.com/c/1497783 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637126} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 37487b6e882243425b2366bb824596ba39bb2508 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 14:22:32 2019 +0000 Roll src/third_party/webrtc 1916cbc6c5c8..4a42742dc6e4 (1 commits) https://webrtc.googlesource.com/src.git/+log/1916cbc6c5c8..4a42742dc6e4 git log 1916cbc6c5c8..4a42742dc6e4 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 mbonadei@webrtc.org Make rtc_base/fake_mdns_responder.h self contained. Created with: gclient setdep -r src/third_party/webrtc@4a42742dc6e4 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5b4690bcefd5f516893dd1f97a2cd4e39c218b1f Reviewed-on: https://chromium-review.googlesource.com/c/1497782 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637125} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb8c6a12c6f47b362923aae4ae4cd82aa2545de4 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Sat Mar 2 13:55:20 2019 +0000 OnionSoup: Remove all uses of UseCounter::Count(const LocalFrame*) in blink/renderer/modules According to the plan to replace |const LocalFrame*| arguement with |const Document&|, |ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document&) in frame directory. Bug: 936187 Change-Id: I9a0be87470790f2e1dfc4607ad7bfa280ee65734 Reviewed-on: https://chromium-review.googlesource.com/c/1496273 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637124} .../renderer/modules/app_banner/before_install_prompt_event.cc | 2 +- third_party/blink/renderer/modules/battery/navigator_battery.cc | 2 +- .../device_orientation/device_orientation_absolute_controller.cc | 2 +- .../modules/device_orientation/device_orientation_controller.cc | 3 ++- third_party/blink/renderer/modules/storage/storage_area.cc | 6 ++++-- third_party/blink/renderer/modules/vibration/navigator_vibration.cc | 5 +++-- 6 files changed, 12 insertions(+), 8 deletions(-) commit aade58102a4ffc39c6f147ac3fa9ebe8ea4c54ef Author: Matt Menke <mmenke@chromium.org> Date: Sat Mar 2 13:38:00 2019 +0000 Socket Pools Refactor 30: Finish flattening the socket pools. This CL merges the SSL socket pool that sits on top of the HTTP proxy socket pool into that socket pool. SSLConnectJobs that are layered on top of HttpProxyConnectJobs now directly create those nested jobs, instead of going through another socket pool. While this is the final CL needed to fully flatten the socket pools (though H2 sessions are still layered on top of them), there are a number of related cleanups that will need to follow this CL. This is part of an effort to flatten the socket pools. https://docs.google.com/document/d/1g0EA4iDqaDhNXA_mq-YK3SlSX-xRkoKvZetAQqdRrxM/edit Bug: 472729 Change-Id: I98aee1ac0235440902deed1e3d66479efae3af40 Reviewed-on: https://chromium-review.googlesource.com/c/1489428 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#637123} net/http/http_network_session.cc | 7 - net/http/http_network_session.h | 3 - net/http/http_network_transaction_unittest.cc | 13 +- net/http/http_proxy_client_socket_wrapper.cc | 3 +- net/http/http_stream_factory_job.cc | 16 +- net/http/http_stream_factory_unittest.cc | 72 +------- net/socket/client_socket_handle.cc | 24 ++- net/socket/client_socket_handle.h | 11 +- net/socket/client_socket_pool_manager.cc | 2 +- net/socket/client_socket_pool_manager.h | 2 - net/socket/client_socket_pool_manager_impl.cc | 50 ------ net/socket/client_socket_pool_manager_impl.h | 4 - net/socket/mock_client_socket_pool_manager.cc | 16 -- net/socket/mock_client_socket_pool_manager.h | 6 - net/socket/ssl_client_socket_pool_unittest.cc | 28 +-- net/socket/ssl_connect_job.cc | 114 +++++------- net/socket/ssl_connect_job.h | 10 +- net/socket/ssl_connect_job_unittest.cc | 200 ++++++++++++++++++++- net/socket/transport_client_socket_pool.cc | 37 ++-- net/socket/transport_client_socket_pool.h | 22 +-- .../websocket_transport_client_socket_pool.cc | 3 +- net/spdy/spdy_proxy_client_socket_unittest.cc | 3 +- 22 files changed, 301 insertions(+), 345 deletions(-) commit c804cc74fcacadfa22f4330bf6d052fbd5454d5d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 13:29:10 2019 +0000 Roll src-internal 0f0ee26c3f59..f0a1b048927d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0f0ee26c3f59..f0a1b048927d Created with: gclient setdep -r src-internal@f0a1b048927d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iad40ce214d061088144119a02d13606d3a7c34c2 Reviewed-on: https://chromium-review.googlesource.com/c/1497780 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637122} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5cb95a9a8b60ff104d8c0d41ce7d9c3420c49dde Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 13:08:00 2019 +0000 Roll src/third_party/webrtc c9ea5451bf6b..1916cbc6c5c8 (1 commits) https://webrtc.googlesource.com/src.git/+log/c9ea5451bf6b..1916cbc6c5c8 git log c9ea5451bf6b..1916cbc6c5c8 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 mbonadei@webrtc.org Fix -Winconsistent-missing-override in fake_network.h. Created with: gclient setdep -r src/third_party/webrtc@1916cbc6c5c8 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iebfaf9faf63536efb57d7a54623344438b5304d7 Reviewed-on: https://chromium-review.googlesource.com/c/1497779 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637121} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 03b1b76b39ccdc3e8e288dd74276c765aba3ecae Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 12:00:50 2019 +0000 Roll src-internal 7c4802a4aee5..0f0ee26c3f59 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7c4802a4aee5..0f0ee26c3f59 Created with: gclient setdep -r src-internal@0f0ee26c3f59 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5b92b533830739c4b7938349756e9adead449cff Reviewed-on: https://chromium-review.googlesource.com/c/1497778 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637120} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 72114c1bab6d39a2854f0cb51aeae40fc68e90f2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 10:59:44 2019 +0000 Roll src/third_party/skia a726918932ce..705e67347962 (1 commits) https://skia.googlesource.com/skia.git/+log/a726918932ce..705e67347962 git log a726918932ce..705e67347962 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@705e67347962 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I38597a0d10c5423b874c602f10b3331248c845d1 Reviewed-on: https://chromium-review.googlesource.com/c/1497773 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637119} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d4b67ee5ca97f305ff4c3788f88b5796cac62ba0 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Sat Mar 2 10:53:20 2019 +0000 Reland "Hook up running extension SW information to ProcessManager" This is a reland of 7466707780d996e09adff361f84c0ae0add4602c The only change is to wait for "activate" SW event in tests instead of "install" event. This fixes the previous test flakiness locally. Original change's description: > Hook up running extension SW information to ProcessManager > > When service worker context initializes, add the corresponding > entry to ProcessManager and remove it when the context stops. > > Introduce IPC for worker initialization > (DidInitializeServiceWorkerContext) and modify worker > stop IPC (DidStopServiceWorkerContext) as necessary. > > Note that we cannot use loadstop > (DidStartServiceWorkerContext) for PM entry addition because it > can be too late as extension API calls might arrive in browser > process before this. > > Also add SW information cleanup on render process termination as > termination doesn't trigger stop worker messages (where the > regular cleanup in PM happens). > > This CL will enable extension messaging in future CLs. > > Add tests for shutdown and termination behavior. > > Bug: 925918 > Change-Id: I9442bac9a1e9acf01063084a1e6ef2fac3279e09 > Reviewed-on: https://chromium-review.googlesource.com/c/1455267 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636929} TBR=rdevlin.cronin@chromium.org,dominickn@chromium.org Bug: 925918 Change-Id: I148fe7ddce1b66b934eec20536172cbb94b27540 Reviewed-on: https://chromium-review.googlesource.com/c/1497862 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#637118} .../browser/extensions/service_worker_apitest.cc | 84 ++++++++++++++++++++++ .../process_manager/manifest.json | 7 ++ .../process_manager/service_worker_background.js | 11 +++ .../extension_service_worker_message_filter.cc | 22 +++++- .../extension_service_worker_message_filter.h | 3 + extensions/browser/process_manager.cc | 45 ++++++++++++ extensions/browser/process_manager.h | 20 +++++- extensions/browser/service_worker/worker_id_set.cc | 4 ++ extensions/browser/service_worker/worker_id_set.h | 1 + extensions/browser/service_worker_task_queue.cc | 15 ++++ extensions/browser/service_worker_task_queue.h | 6 ++ extensions/common/extension_messages.h | 7 ++ extensions/renderer/dispatcher.cc | 2 + extensions/renderer/worker_thread_dispatcher.cc | 10 +++ extensions/renderer/worker_thread_dispatcher.h | 3 + 15 files changed, 236 insertions(+), 4 deletions(-) commit 6068ff6ab6a068977052cc59629c10bbae4492f3 Author: Jérôme Lebel <jlebel@chromium.org> Date: Sat Mar 2 10:53:14 2019 +0000 [iOS][Unity] Adding wallet toggle in Manage sync settings Adding "Payment Methods and Addresses Using Google Pay" in Manage sync settings. Screenshot: https://drive.google.com/open?id=1a5BV3iALFCqRszA73Nn4s4dGMiWtx4dj Bug: 936460 Change-Id: Ia70d4202b00f5778384d3ef5980c5a8c4bcb4302 Reviewed-on: https://chromium-review.googlesource.com/c/1495534 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#637117} .../browser/ui/settings/google_services/BUILD.gn | 1 + .../manage_sync_settings_coordinator.mm | 6 +- .../manage_sync_settings_mediator.h | 2 + .../manage_sync_settings_mediator.mm | 128 +++++++++++++++++---- 4 files changed, 115 insertions(+), 22 deletions(-) commit 634e60c303f4e32d55ec7210eebd604ffabf1abc Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 10:26:05 2019 +0000 Roll src-internal 99d0127062b0..7c4802a4aee5 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99d0127062b0..7c4802a4aee5 Created with: gclient setdep -r src-internal@7c4802a4aee5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I08c59888cd4e6c9cbcdf1d1e66c47534d7d00a2a Reviewed-on: https://chromium-review.googlesource.com/c/1497777 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637116} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 669840a41dab8310ffe39495bc29c4377ac8b53e Author: Alex Clarke <alexclarke@chromium.org> Date: Sat Mar 2 10:18:18 2019 +0000 Reland "SequenceManager to perform periodic housekeeping (sweep canceled tasks)" This reverts commit 23cd26b84ec8ea9d5d6ea54a8e903c5bade93346. The fix (https://chromium-review.googlesource.com/c/chromium/src/+/1495541) has landed so it should be safe to reland. Original change's description: > Revert "SequenceManager to perform periodic housekeeping (sweep canceled tasks)" > > This reverts commit 606087eb105f4586e9c1af653f8005960cc664dd. > > This is crashing and the speculative fix was ineffective. > > Original change's description: > > SequenceManager to perform periodic housekeeping (sweep canceled tasks) > > > > Long delay canceled tasks can really pile up if we don't activly remove > > them. We already do that in the renderer but we need to bring this > > technology to other SequenceMangers. > > > > Bug: 863341 > > Change-Id: Ie16674043028090f94c184c02acbef6efcf3471b > > Reviewed-on: https://chromium-review.googlesource.com/c/1483076 > > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > Reviewed-by: Alexander Timin <altimin@chromium.org> > > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#635497} > > TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org,carlscab@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 863341, 936734 > Change-Id: Ie948d9519dee14326137ad04aa88e53207db6eed > Reviewed-on: https://chromium-review.googlesource.com/c/1495976 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636765} TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org,carlscab@google.com Change-Id: I63ec7c7620171c4ee499d78f47dad4bc6cb1218a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 863341, 936734 Reviewed-on: https://chromium-review.googlesource.com/c/1496856 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637115} base/task/sequence_manager/lazy_now.h | 2 + .../task/sequence_manager/sequence_manager_impl.cc | 33 +++++- base/task/sequence_manager/sequence_manager_impl.h | 14 +++ .../sequence_manager_impl_unittest.cc | 99 +++++++++++++++- base/task/sequence_manager/time_domain.cc | 4 + base/task/sequence_manager/time_domain.h | 3 + base/task/sequence_manager/time_domain_unittest.cc | 6 + base/task/sequence_manager/work_queue.cc | 3 +- .../blink/renderer/platform/scheduler/BUILD.gn | 3 - .../scheduler/common/idle_memory_reclaimer.cc | 39 ------ .../scheduler/common/idle_memory_reclaimer.h | 38 ------ .../common/idle_memory_reclaimer_unittest.cc | 132 --------------------- .../main_thread/main_thread_scheduler_impl.cc | 1 - .../main_thread/main_thread_scheduler_impl.h | 2 - .../scheduler/worker/worker_thread_scheduler.cc | 1 - .../scheduler/worker/worker_thread_scheduler.h | 2 - 16 files changed, 158 insertions(+), 224 deletions(-) commit ad67385b9e0825baca59c9a4bbb08b1591eab173 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 09:45:34 2019 +0000 Roll src/third_party/webrtc 7e215c65d411..c9ea5451bf6b (1 commits) https://webrtc.googlesource.com/src.git/+log/7e215c65d411..c9ea5451bf6b git log 7e215c65d411..c9ea5451bf6b --date=short --no-merges --format='%ad %ae %s' 2019-03-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1951ee5099..b3ef4b21cb (636995:637096) Created with: gclient setdep -r src/third_party/webrtc@c9ea5451bf6b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If3bc336af7e9e2c9db31f0a4a85a7054b0b695a4 Reviewed-on: https://chromium-review.googlesource.com/c/1496326 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637114} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 97484def29775777d42f14eb5ad7de23163dc336 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 09:13:13 2019 +0000 Roll src-internal 97ba813d953b..99d0127062b0 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/97ba813d953b..99d0127062b0 Created with: gclient setdep -r src-internal@99d0127062b0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0ee986011edca5786ee2c6e2d2693e4239b844fa Reviewed-on: https://chromium-review.googlesource.com/c/1497775 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637113} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit baaed7242c7b50388e048bc561561e5a24c9904a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 09:09:03 2019 +0000 Roll src/third_party/chromite 51701df4ab00..e931c51da4d9 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/51701df4ab00..e931c51da4d9 git log 51701df4ab00..e931c51da4d9 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 dhanyaganesh@chromium.org git.py: lint update 2019-03-02 saklein@chromium.org setup_board: Fix skip_board_pkg_init flag. Created with: gclient setdep -r src/third_party/chromite@e931c51da4d9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ifafa57ecc5759c43f091f61718213cc6cd801ab0 Reviewed-on: https://chromium-review.googlesource.com/c/1497774 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637112} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7080ba4cecafb01d0d49a387e0327e9a6f1c9957 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 08:52:43 2019 +0000 Roll AFDO from 74.0.3721.0_rc-r1-merged to 74.0.3722.0_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iaa821248947a5557cfdd0a842d0835b0535bd159 Reviewed-on: https://chromium-review.googlesource.com/c/1497776 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637111} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fac04abf6133ab2da2846a8fbd0e97690722699 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 08:06:03 2019 +0000 Roll src-internal 55e858330914..97ba813d953b (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55e858330914..97ba813d953b Created with: gclient setdep -r src-internal@97ba813d953b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If295db42c9db4a65dd0ba2ec2a51a00e28f9a061 Reviewed-on: https://chromium-review.googlesource.com/c/1497892 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637110} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 90f658e448d87b7af21f4d313d87598c40a64723 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 07:48:29 2019 +0000 Roll src/third_party/chromite 0b2d9ee474e1..51701df4ab00 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/0b2d9ee474e1..51701df4ab00 git log 0b2d9ee474e1..51701df4ab00 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@51701df4ab00 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ida7db7ab418ecb49ad68976ae28c4f35ad177976 Reviewed-on: https://chromium-review.googlesource.com/c/1497449 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637109} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 52f5c88224e8908ab74be5c0397ef74663ee25c9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 07:41:09 2019 +0000 Roll src/third_party/skia a232cd4482a0..a726918932ce (1 commits) https://skia.googlesource.com/skia.git/+log/a232cd4482a0..a726918932ce git log a232cd4482a0..a726918932ce --date=short --no-merges --format='%ad %ae %s' 2019-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a2f5fd826031..823ca85404fb (1 commits) Created with: gclient setdep -r src/third_party/skia@a726918932ce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I140239cade5d4651c02bbc6d8c1e71976024fd42 Reviewed-on: https://chromium-review.googlesource.com/c/1497912 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637108} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ea0e4a362c987d7174b932e37eeff16e9380803a Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 2 07:36:49 2019 +0000 Update V8 to version 7.4.268. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ce59d6e..26573c52 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I758c4225a8a74171e674f19e151f840d622c9671 Reviewed-on: https://chromium-review.googlesource.com/c/1497854 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637107} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fccf215949a733ebe672712b806519313af4fb91 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 07:30:09 2019 +0000 Roll src/third_party/depot_tools c903198758bd..71bae22f623e (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c903198758bd..71bae22f623e git log c903198758bd..71bae22f623e --date=short --no-merges --format='%ad %ae %s' 2019-03-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@71bae22f623e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia3d166eb40b5fdb3ebc3c5694fc6c871418f03e7 Reviewed-on: https://chromium-review.googlesource.com/c/1497911 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637106} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 47fb0213b46585391cb5786659aa6fef98c76c42 Author: Bill Orr <billorr@chromium.org> Date: Sat Mar 2 07:25:09 2019 +0000 Revert "Add trace events for measuring WebXR perf on Desktop" This reverts commit 73c1c6256d28510dba6f3e5052c443f744f38cde. Reason for revert: Took an unintentional dependency on newer SDK version. Will either reland without new dependency or explicitly decide to take new dependency. Original change's description: > Add trace events for measuring WebXR perf on Desktop > > This change exposes the same trace events as used on Android for VR to > Windows. This will help to unblock perf tests and start to help basic > perf investigation from chrome://tracing. > > Bug: 865084 > Change-Id: If4f8cf0b3b435d70416c93436437f658843d6cc0 > Reviewed-on: https://chromium-review.googlesource.com/c/1479858 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#635364} TBR=bsheedy@chromium.org,klausw@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 865084 Change-Id: Ia79d163d6dfae25f2173e7c1e79fc54369f218fb Reviewed-on: https://chromium-review.googlesource.com/c/1497856 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#637105} .../browser/android/vr/arcore_device/arcore_gl.h | 4 ++-- chrome/browser/android/vr/gvr_graphics_delegate.h | 8 ++++--- chrome/browser/android/vr/gvr_scheduler_delegate.h | 10 ++++---- chrome/browser/vr/BUILD.gn | 8 +++++++ chrome/browser/vr/DEPS | 3 +-- chrome/browser/vr/base_scheduler_delegate.h | 4 ++-- chrome/browser/vr/browser_renderer.h | 6 ++--- {device/vr/util => chrome/browser/vr}/fps_meter.cc | 6 ++--- {device/vr/util => chrome/browser/vr}/fps_meter.h | 16 ++++++------- .../browser/vr}/fps_meter_unittest.cc | 13 ++++------- .../vr/util => chrome/browser/vr}/sample_queue.cc | 6 ++--- .../vr/util => chrome/browser/vr}/sample_queue.h | 13 +++++------ .../util => chrome/browser/vr}/sliding_average.cc | 6 ++--- .../util => chrome/browser/vr}/sliding_average.h | 18 +++++++-------- .../browser/vr}/sliding_average_unittest.cc | 6 ++--- device/BUILD.gn | 2 -- device/vr/BUILD.gn | 6 ----- device/vr/windows/compositor_base.cc | 27 ---------------------- device/vr/windows/compositor_base.h | 11 --------- .../mixed_reality_renderloop.cc | 20 ++-------------- 20 files changed, 68 insertions(+), 125 deletions(-) commit 1e88e7f05a5cef8a9d17e2cd826da03b4784549a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 07:02:28 2019 +0000 Roll src-internal 18eeaa27090c..55e858330914 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/18eeaa27090c..55e858330914 Created with: gclient setdep -r src-internal@55e858330914 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If04321b68cb7b2de19e159accb946413a7e78b96 Reviewed-on: https://chromium-review.googlesource.com/c/1497448 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637104} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ebc504527ad161f3ae7e8d9905d5580cf6db2a85 Author: Guido Urdaneta <guidou@chromium.org> Date: Sat Mar 2 06:46:21 2019 +0000 Mark MediaDevices-related interfaces as SecureContext This CL marks the following as SecureContext: * mediaDevices field of the Navigator interface * getUserMedia method of the Navigator interface (including prefixed version) * MediaDevices interface * MediaDeviceInfo interface This effectively makes getUserMedia(), getDisplayMedia() and enumerateDevices() available only on secure contexts. Intent to Remove thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/SGWYHfR5CyY Bug: 927230 Change-Id: I6f5672dcaae22a1744ade2b913aae29e75ddcc9b Reviewed-on: https://chromium-review.googlesource.com/c/1495527 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#637103} .../api_test/tab_capture/offscreen_evil_tests.js | 11 ------ .../modules/mediastream/media_device_info.idl | 1 + .../renderer/modules/mediastream/media_devices.idl | 3 +- .../modules/mediastream/navigator_media_stream.idl | 2 + .../modules/mediastream/navigator_user_media.idl | 2 +- .../wpt/audio-output/setSinkId-expected.txt | 6 --- .../external/wpt/audio-output/setSinkId.html | 44 ---------------------- ...ture-MediaTrackSupportedConstraints.https.html} | 0 .../MediaDevices-SecureContext-expected.txt | 4 -- ...ediaDevices-getSupportedConstraints.https.html} | 0 ...-expected.txt => historical.https-expected.txt} | 0 .../{historical.html => historical.https.html} | 0 ...arness.window.js => idlharness.https.window.js} | 0 ...indow-after-frame-removed-and-gced-expected.txt | 1 - ...-cached-window-after-frame-removed-expected.txt | 1 - ...werful-features-on-insecure-origin-expected.txt | 4 +- .../old-powerful-features-on-insecure-origin.html | 19 +++------- 17 files changed, 12 insertions(+), 86 deletions(-) commit 051283547c56d96be6f3c7ad84c69424defeadd7 Author: Zinovy Nis <zynis@yandex-team.ru> Date: Sat Mar 2 06:44:51 2019 +0000 [clang-tidy] Fix std::move not working - DictonaryValue::SetString has no move-overloads. This CL workarounds it. - Minor cosmetic fixes. Change-Id: I3ba2226b3062ba6adb83abb9ad78301902b0a6dc Reviewed-on: https://chromium-review.googlesource.com/c/1497004 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#637102} components/bookmarks/browser/bookmark_codec.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 820a09fbec25cdcdbabf90bd130f7c43b5aaa2b2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 06:37:16 2019 +0000 Roll src/third_party/skia e842e326a448..a232cd4482a0 (9 commits) https://skia.googlesource.com/skia.git/+log/e842e326a448..a232cd4482a0 git log e842e326a448..a232cd4482a0 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 37c024a6a7fd..a2f5fd826031 (2 commits) 2019-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd1e37e31d68..37c024a6a7fd (1 commits) 2019-03-02 bungeman@google.com Adjust luminance gamma for Mac. 2019-03-02 mtklein@google.com bring back lowp bilerp_clamp_8888 2019-03-02 reed@google.com use colorspace steps to determine legacy blits 2019-03-02 jvanverth@google.com Fix memory leak in Metal. 2019-03-02 jvanverth@google.com Restore old Viewer setup order. 2019-03-02 egdaniel@google.com Add flush call to take access type, flags, and semaphore. Created with: gclient setdep -r src/third_party/skia@a232cd4482a0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:933137 TBR=scroggo@chromium.org Change-Id: I3609cd190b929fb6d7615cceecb9b9319b9da0bd Reviewed-on: https://chromium-review.googlesource.com/c/1497447 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637101} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bbe0eb903fdc30a017299537dbfcbde7b49298ef Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Sat Mar 2 06:22:49 2019 +0000 Add GWP-ASan macOS field trial Bug: 912286 Change-Id: I3338795b1ca4a5c65775c2c522475d3a6615c69e Reviewed-on: https://chromium-review.googlesource.com/c/1493151 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637100} testing/variations/fieldtrial_testing_config.json | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) commit 002daa9db84249b2ecd999163544abbc0defd3b8 Author: Aidan Wolter <awolter@chromium.org> Date: Sat Mar 2 06:21:39 2019 +0000 Enable NetworkChangeNotifier for fuchsia Now that NetworkChangeNotifierFuchsia exists, we want to use it in NetworkService. Bug: 777973 Test: CQ Change-Id: I60b4ba1d9750d95aa91307794e7e4f6295e0d40e Reviewed-on: https://chromium-review.googlesource.com/c/1496524 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#637099} net/base/network_change_notifier_fuchsia.cc | 6 +++++- services/network/network_service.cc | 6 +++--- 2 files changed, 8 insertions(+), 4 deletions(-) commit a040e5b4ede6a602a928ab51be2e4789704ef32a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 06:04:18 2019 +0000 Roll src/third_party/swiftshader a2f5fd826031..823ca85404fb (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/a2f5fd826031..823ca85404fb git log a2f5fd826031..823ca85404fb --date=short --no-merges --format='%ad %ae %s' 2019-03-02 chrisforbes@google.com Allow all vkBeginCommandBuffer flags Created with: gclient setdep -r src/third_party/swiftshader@823ca85404fb The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118619338 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id5c871ee12323a86f9dd37ea986e48103f8d2f15 Reviewed-on: https://chromium-review.googlesource.com/c/1497445 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637098} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e19930a1863a3da6f9149d1819b44694c9ada0cc Author: Guido Urdaneta <guidou@chromium.org> Date: Sat Mar 2 06:02:08 2019 +0000 Remove content::MediaStreamRegistryInterface This interface is useless and not needed. The only method it defines is never called. MockMediaStreamRegistry is updated to not inherit from MediaStreamRegistryInterface. The stored URL field is removed. Tests that use MockMediaStreamRegistry do not use the operations in MediaStreamRegistryInterface. Bug: 928779 Change-Id: I952931882769ec5a6026f643143c516ad1142520 Reviewed-on: https://chromium-review.googlesource.com/c/1454901 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#637097} content/renderer/BUILD.gn | 1 - .../media/stream/media_stream_registry_interface.h | 25 ---------------------- .../media/stream/mock_media_stream_registry.cc | 8 +------ .../media/stream/mock_media_stream_registry.h | 8 +++---- .../media_stream_video_webrtc_sink_unittest.cc | 4 ++-- .../media_recorder_handler_unittest.cc | 3 +-- 6 files changed, 7 insertions(+), 42 deletions(-) commit b3ef4b21cb43c31e7893c1c2bb3a9eb51fc9b007 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 05:58:18 2019 +0000 Roll src/third_party/chromite 22379a19cb4b..0b2d9ee474e1 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/22379a19cb4b..0b2d9ee474e1 git log 22379a19cb4b..0b2d9ee474e1 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 vapier@chromium.org cros_sdk: drop --workspace option 2019-03-02 nednguyen@google.com cbuildbot: switch RecordPackagesUnderTest to use GetBuildDependencyGraph proto service Created with: gclient setdep -r src/third_party/chromite@0b2d9ee474e1 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ie387846fae39b4ce26a07067c0297ff879ada154 Reviewed-on: https://chromium-review.googlesource.com/c/1497441 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637096} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9bc9ba951c68072b8510eb07f5a96886aefd6b78 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 05:53:48 2019 +0000 Roll src-internal 27b49c79a076..18eeaa27090c (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/27b49c79a076..18eeaa27090c Created with: gclient setdep -r src-internal@18eeaa27090c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4a373ac0d9c3d41aaaa16177d09263d33f0c303b Reviewed-on: https://chromium-review.googlesource.com/c/1497442 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637095} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8e1e7d55a1bb8cef5d6175a3abc5c1065a1c9d92 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 05:34:48 2019 +0000 Roll src/third_party/skia 436d47d5bde9..e842e326a448 (2 commits) https://skia.googlesource.com/skia.git/+log/436d47d5bde9..e842e326a448 git log 436d47d5bde9..e842e326a448 --date=short --no-merges --format='%ad %ae %s' 2019-03-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 1581ff030b9c..6f1a852fce0b (3 commits) 2019-03-02 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e842e326a448 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I26483b24310b1861249c53cfb80aa6833c9ae44a Reviewed-on: https://chromium-review.googlesource.com/c/1497440 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637094} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b0f9f4342486071c6015fb3bc7f355bfdc2bcc2 Author: Wez <wez@chromium.org> Date: Sat Mar 2 05:20:42 2019 +0000 Revert "[Fuchsia] Add build rules and CIPD recipes for symbol data archives." This reverts commit da0dacbb832dc2b887850632e13b45dda286d0f2. Reason for revert: Official builder needs the artifacts path updating. Reverting for now to get builds rolling again. Original change's description: > [Fuchsia] Add build rules and CIPD recipes for symbol data archives. > > * Add a script for building symbol tarballs from ids.txt files. > * Create symbol tarballs for all packages currently deployed to CIPD. > * Adds a CIPD recipe for archiving symbol tarballs to CIPD. > > Bug: 772252 > Change-Id: I71fc222570ba61b832ce5c7a9a08777c8d71e120 > Reviewed-on: https://chromium-review.googlesource.com/c/1478171 > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636191} TBR=wez@chromium.org,jamesr@chromium.org,kmarshall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 772252, 937254 Change-Id: Ie2389c56b76c3c41f166fad03bb26cc08536a73a Reviewed-on: https://chromium-review.googlesource.com/c/1497430 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#637093} build/config/fuchsia/build_symbol_archive.py | 66 ---------------------------- build/config/fuchsia/package.gni | 7 --- build/config/fuchsia/symbol_archive.gni | 39 ---------------- fuchsia/BUILD.gn | 42 ++++-------------- fuchsia/cipd/debug_symbols.yaml | 29 ------------ fuchsia/engine/BUILD.gn | 10 ----- fuchsia/http/BUILD.gn | 9 ---- fuchsia/runners/BUILD.gn | 19 -------- 8 files changed, 8 insertions(+), 213 deletions(-) commit 1fd3589c5ffb1762fd8a6cf9c3929362e5a9ab13 Author: khmel@chromium.org <khmel@chromium.org> Date: Sat Mar 2 05:19:56 2019 +0000 arc: Add switch to disable Play Store auto-update. Required for autotests to eliminate races caused by app auto-update and chain of other app restarts and kills. Besides third-part app auto-update this affects GMS Core and Play Store self-update. BUG=b:124203723 TEST=Running autotests with custom build Change-Id: Id0794cd293a1e236713285d5f7efa3dc0a31da30 Reviewed-on: https://chromium-review.googlesource.com/c/1484070 Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637092} chromeos/constants/chromeos_switches.cc | 5 +++++ chromeos/constants/chromeos_switches.h | 1 + components/arc/arc_session_impl.cc | 24 ++++++++++++++++++++++++ 3 files changed, 30 insertions(+) commit 6be0337440ca3dd86b7ad7472ed2ccad7677b600 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 2 05:19:35 2019 +0000 Update V8 to version 7.4.267. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/552c6e85..6ce59d6e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifcf2d5b9dc5be8b7d474ad8eeaea84f737b4b199 Reviewed-on: https://chromium-review.googlesource.com/c/1497795 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637091} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80f98fa16e01156414da00a29367b5df3bf68315 Author: Dan Beam <dbeam@chromium.org> Date: Sat Mar 2 05:15:30 2019 +0000 WebUI Dark Mode, Extensions: fix install warnings dialog Screenshot: https://imgur.com/a/rH0rbfi BUG=936524 R=hcarmona@chromium.org Change-Id: If96357c63c54b5f2f6e05336e7a6b0fee5c933aa Reviewed-on: https://chromium-review.googlesource.com/c/1497771 Commit-Queue: Dan Beam <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#637090} chrome/browser/resources/md_extensions/install_warnings_dialog.html | 6 ++++++ 1 file changed, 6 insertions(+) commit f00952ed89be82561a277fe5c12b023501313e39 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 2 05:05:39 2019 +0000 Roll src/third_party/angle 6f1a852fce0b..4d153383bd3a (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/6f1a852fce0b..4d153383bd3a git log 6f1a852fce0b..4d153383bd3a --date=short --no-merges --format='%ad %ae %s' 2019-03-02 syoussefi@chromium.org Reland "Vulkan: Implement debug markers" Created with: gclient setdep -r src/third_party/angle@4d153383bd3a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Idd030848814319c5e44b65c623f61492959dcb52 Reviewed-on: https://chromium-review.googlesource.com/c/1497439 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637089} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3a2e71717be96d1a997541f49b2f8554f6427638 Author: Siye Liu <siliu@microsoft.com> Date: Sat Mar 2 04:39:22 2019 +0000 Add full support for Text Services Framework on Windows This change adds full support for TSF1 in Chromium. The change enables Windows Input Services to be aware of context of focused edit control. The change also enables editing features such as soft keyboard suggestions replacement, re-conversion feature for Korean IME and javascript keydown/keyup event during composition. For more details, see the design document at https://github.com/siliu1/TSF1/blob/master/DesignDocument.md Bug: 657623 Change-Id: I916cefceb5dfb6179d0efbe57530feb71be9bcdc Reviewed-on: https://chromium-review.googlesource.com/c/1475084 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#637088} .../renderer_host/render_widget_host_view_aura.cc | 13 + .../renderer_host/render_widget_host_view_aura.h | 7 + ui/base/ime/dummy_text_input_client.cc | 11 + ui/base/ime/dummy_text_input_client.h | 8 + ui/base/ime/input_method_win_tsf.cc | 3 + ui/base/ime/text_input_client.h | 14 + ui/base/ime/win/mock_tsf_bridge.cc | 9 + ui/base/ime/win/mock_tsf_bridge.h | 4 + ui/base/ime/win/tsf_bridge.cc | 78 +- ui/base/ime/win/tsf_bridge.h | 7 + ui/base/ime/win/tsf_text_store.cc | 529 +++++++++--- ui/base/ime/win/tsf_text_store.h | 145 +++- ui/base/ime/win/tsf_text_store_unittest.cc | 947 ++++++++++++++++++--- ui/views/controls/prefix_selector.cc | 11 + ui/views/controls/prefix_selector.h | 12 + ui/views/controls/textfield/textfield.cc | 12 + ui/views/controls/textfield/textfield.h | 11 + 17 files changed, 1578 insertions(+), 243 deletions(-) commit 78799cacec2019699e60c438e58c228c54a58ed0 Author: khmel@chromium.org <khmel@chromium.org> Date: Sat Mar 2 04:39:05 2019 +0000 Roll src/third_party/cros_system_api/ e415e09bd..de1a4c92e (4 commits) https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/e415e09bd20a..de1a4c92ee70 $ git log e415e09bd..de1a4c92e --date=short --no-merges --format='%ad %ae %s' 2019-02-26 alexlau system_api: Add libvda constants. 2019-02-07 igorcov system_api: Constants to allow LockToSingleUserMountUntilReboot to be done by service 2018-09-13 akhouderchah shill: Add new service error types 2019-02-27 khmel arc: Pass Play Store auto-update mode to container boot. Created with: roll-dep src/third_party/cros_system_api Change-Id: Ia739829a3c47c3025950aeefd258fb73917a1f5a Reviewed-on: https://chromium-review.googlesource.com/c/1497331 Auto-Submit: Yury Khmel <khmel@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637087} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 79de922ac279bcba699af67ba125d58988597523 Author: dpapad <dpapad@chromium.org> Date: Sat Mar 2 04:37:03 2019 +0000 WebUI cleanup: Move various grd files under a more targeted folder. This is part of an effort to clean up chrome/browser/resources folder, such that most (if not all) files are under a subfolder dedicated to to the WebUI page that uses them. Bug: None Change-Id: Icf2db60ac5b05f18f2e67c6963a9aa639c474dd5 Reviewed-on: https://chromium-review.googlesource.com/c/1497039 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637086} chrome/browser/resources/BUILD.gn | 13 +++---- chrome/browser/resources/OWNERS | 2 -- chrome/browser/resources/local_ntp/OWNERS | 2 ++ .../resources/local_ntp/local_ntp_resources.grd | 41 ++++++++++++++++++++++ chrome/browser/resources/local_ntp_resources.grd | 41 ---------------------- .../net_internals_resources.grd | 4 +-- .../quota_internals_resources.grd | 6 ++-- .../resources/sync_file_system_internals/OWNERS | 2 ++ .../sync_file_system_internals_resources.grd | 14 ++++---- .../translate_internals_resources.grd | 4 +-- .../{ => webapks}/webapks_ui_resources.grd | 6 ++-- tools/gritsettings/resource_ids | 12 +++---- 12 files changed, 75 insertions(+), 72 deletions(-) commit 6e5b4f33fe68cac113f2604e08212e8fe25fb73c Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Sat Mar 2 04:18:50 2019 +0000 Change AttachToOuterWebContents to AttachInnerWebContents instead. This CL changes the the semantic of attaching an inner WebContents from being called on the inner WebContents to being called on the outer WebContents instead. Since the attachment process takes ownership of the WebContents, this CL cleans up the API, so instead of the inner WebContents getting a unique_ptr<> of itself and passing it to the outer WebContents, it makes it explicit that the outer WebContents is the one taking ownership of the inner WebContents. Change-Id: Ieb31a3cb03e372d36edc8af46924f47d82fc19e0 Reviewed-on: https://chromium-review.googlesource.com/c/1492653 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637085} components/guest_view/browser/guest_view_base.cc | 2 +- content/browser/portal/portal.cc | 4 +- content/browser/web_contents/web_contents_impl.cc | 104 ++++++++++++---------- content/browser/web_contents/web_contents_impl.h | 16 ++-- content/public/browser/web_contents.h | 17 ++-- content/public/test/test_utils.cc | 3 +- 6 files changed, 73 insertions(+), 73 deletions(-) commit 601f612ca38626043a7d93fe55db569a4406c5e6 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Sat Mar 2 04:11:44 2019 +0000 Updating trunk VERSION from 3722.0 to 3723.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I3ea6351b9706a3e2e810673480641fccfca478ed Reviewed-on: https://chromium-review.googlesource.com/c/1497344 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#637084} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7efb36607374fab4076d89d820f96e03ba7d1165 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Sat Mar 2 04:10:57 2019 +0000 gpu: Ignore DXGI_STATUS_OCCLUDED status returned by swap chain Present Ignore DXGI_STATUS_OCCLUDED since that's not an error but only indicates that the window is occluded and we can stop rendering. According to UMA it's the only error code returned by decode swap chain PresentBuffer. According to documentation it can also be returned for other swap chain Present calls. https://docs.microsoft.com/en-us/windows/desktop/api/dxgi/nf-dxgi-idxgiswapchain-present#return-value Bug: 848093 Change-Id: Icfa0218a8c44ac57a0e65853d9ce2f546ad01032 Reviewed-on: https://chromium-review.googlesource.com/c/1497803 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#637083} gpu/ipc/service/direct_composition_child_surface_win.cc | 4 +++- gpu/ipc/service/direct_composition_surface_win.cc | 12 +++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) commit d532d008c9e6e5b32f1d44284a9ed8eee7e8f3a5 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 2 03:59:25 2019 +0000 Roll src-internal f6e48be13b14..27b49c79a076 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6e48be13b14..27b49c79a076 Created with: gclient setdep -r src-internal@27b49c79a076 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: If147cad335131e84f1a33e9cb3037372ac8514fe Reviewed-on: https://chromium-review.googlesource.com/c/1497437 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637082} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 19671359ae25)