Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 34589 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919901416845844480 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itO9sHu6/luci_context.766198207 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2227-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43624ec414e49611 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 5afa5224471a9fdfdaff59d81bbf8195400a3e2c Remove VPN Disconnect button if VpnConfigAllowed is false phweiss, Mon Mar 4 16:11:29 2019 +0000 004561e00b1009d5edbfc214ce51b14917140296 [iOS] Updating "Change Accounts" string in the sign-in promo Jérôme Lebel, Mon Mar 4 16:08:14 2019 +0000 69a2e0bc8daffb2dd8a57a388b7e5fda3eb5b880 [css-grid] Always consider baseline shim for the minimum contribution Oriol Brufau, Mon Mar 4 16:02:39 2019 +0000 5c96199cc8d09599fcf9da143a8b6969d03363cd [SkiaRenderer] Remove usage of legacy promise image param and typename. Brian Salomon, Mon Mar 4 15:59:49 2019 +0000 48e97b141d4a6dc6ecd1133cee956c75d1cd16d6 Add Android to the list of platforms for UnifiedConsent. Boris Sazonov, Mon Mar 4 15:56:33 2019 +0000 0feeacb8dd240f98d919f69d1b977825436dadde Remove variable shadowing in blink/input Daniel Bratell, Mon Mar 4 15:40:47 2019 +0000 c5604de950ff01de7a8078cefba14cc0a94a63ca [Bundles] Add Bundle support to Trichrome Chrome Samuel Huang, Mon Mar 4 15:38:00 2019 +0000 92573b154cacfde79a2ce1f81999d91bb9e8a06e Build RasterDecoder fuzzer with passthrough Jonathan Backer, Mon Mar 4 15:33:09 2019 +0000 0b26209d474eef8a85711d7f6c629190064d5aae Fix ControllerTest.Stop fails on android-marshmallow-arm64-rel Stephane Zermatten, Mon Mar 4 15:31:07 2019 +0000 31601309d465b10141909eb148dd878cfce9eff5 Roll src-internal 2978aa5db94c..794439738e8e (1 commits) chromium-internal-autoroll, Mon Mar 4 15:20:47 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 5afa5224471a9fdfdaff59d81bbf8195400a3e2c Author: phweiss <phweiss@google.com> Date: Mon Mar 4 16:11:29 2019 +0000 Remove VPN Disconnect button if VpnConfigAllowed is false If the pref kVpnConfigAllowed is set to false (via the policy by the same name), we don't want to show the "Disconnect" button in the Uber tray. For this, the pref needs to be moved into ash, so that it can be used in ash/system/network, and in chrome/browser/resources (where it is already used for the settings page). BUG=916747 TEST=manual Change-Id: Id419fc91450fd858dcff01224e20436edc68571b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1414896 Commit-Queue: Philipp Weiß <phweiss@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#637301} ash/public/cpp/ash_pref_names.cc | 3 ++ ash/public/cpp/ash_pref_names.h | 2 ++ ash/shell.cc | 4 ++- ash/system/network/vpn_list_view.cc | 32 ++++++++++++++++++++-- ash/system/network/vpn_list_view.h | 5 ++++ chrome/browser/chromeos/preferences.cc | 1 - .../extensions/api/settings_private/prefs_util.cc | 2 +- .../configuration_policy_handler_list_factory.cc | 2 +- chrome/common/pref_names.cc | 3 -- chrome/common/pref_names.h | 1 - 10 files changed, 44 insertions(+), 11 deletions(-) commit 004561e00b1009d5edbfc214ce51b14917140296 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Mar 4 16:08:14 2019 +0000 [iOS] Updating "Change Accounts" string in the sign-in promo For Unity, the secondary button needs to be upated from "Change Accounts" to "Choose another account". https://drive.google.com/open?id=1t3J7kTtOrtQwyK3B3Gz8T64BJpbbzqvb Bug: 937103 Change-Id: Ic7e9bba6d52e3a0669fbddb5fc95f7491b70610e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498474 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637300} ios/chrome/app/strings/ios_strings.grd | 2 +- .../ios_strings_grd/IDS_IOS_SIGNIN_PROMO_CHANGE_ACCOUNT.png.sha1 | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) commit 69a2e0bc8daffb2dd8a57a388b7e5fda3eb5b880 Author: Oriol Brufau <obrufau@igalia.com> Date: Mon Mar 4 16:02:39 2019 +0000 [css-grid] Always consider baseline shim for the minimum contribution Before this patch, the shim used for baseline alignment is not taken into consideration when calculating the minimum contribution of a grid item if its preferred size is auto, its minimum size is auto, and the max track sizing function is a fixed small value. In this case, the auto minimum size can produce a smaller track than if it was 0. The specification needs to clarify how baseline shims interact with minimum contributions (https://github.com/w3c/csswg-drafts/issues/3660), but the above doesn't make sense. BUG=934535 TEST=external/wpt/css/css-grid/layout-algorithm/grid-minimum-contribution-baseline-shim.html Change-Id: Iafd194ab7e5656b5018e0e36b915ba183bdedd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481512 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by: Manuel Rego <rego@igalia.com> Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#637299} .../core/layout/grid_track_sizing_algorithm.cc | 16 ++-- ...mum-contribution-baseline-shim-vertical-lr.html | 96 ++++++++++++++++++++++ ...mum-contribution-baseline-shim-vertical-rl.html | 96 ++++++++++++++++++++++ .../grid-minimum-contribution-baseline-shim.html | 93 +++++++++++++++++++++ 4 files changed, 294 insertions(+), 7 deletions(-) commit 5c96199cc8d09599fcf9da143a8b6969d03363cd Author: Brian Salomon <bsalomon@google.com> Date: Mon Mar 4 15:59:49 2019 +0000 [SkiaRenderer] Remove usage of legacy promise image param and typename. No functional change. Bug: skia:8800 Change-Id: I35970f8430e99b4c91e558e9bf6454353f9144d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498785 Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637298} .../viz/service/display_embedder/skia_output_surface_impl.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 48e97b141d4a6dc6ecd1133cee956c75d1cd16d6 Author: Boris Sazonov <bsazonov@chromium.org> Date: Mon Mar 4 15:56:33 2019 +0000 Add Android to the list of platforms for UnifiedConsent. We plan to enabled UnifiedConsent study on Android for Canary channel very soon. This CL enables this study on Android for the tests and fixes UkmTest broken by enabling UnifiedConsent. Bug: None Change-Id: Ic69f89f2251cdc0429bdeebafc7a3f9996c9ade5 Reviewed-on: https://chromium-review.googlesource.com/c/1495516 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#637297} .../browser/ntp/snippets/ArticleSnippetsTest.java | 6 ++++++ .../chromium/chrome/browser/sync/SyncTestRule.java | 13 +++++++---- .../org/chromium/chrome/browser/sync/UkmTest.java | 25 +++++++++++++++------- testing/variations/fieldtrial_testing_config.json | 1 + 4 files changed, 33 insertions(+), 12 deletions(-) commit 0feeacb8dd240f98d919f69d1b977825436dadde Author: Daniel Bratell <bratell@opera.com> Date: Mon Mar 4 15:40:47 2019 +0000 Remove variable shadowing in blink/input In an effort to reduce or even ban variable shadowing, this renames some variables to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warning this avoids is: third_party/blink/renderer/core/input/event_handler.cc:757:20: error: declaration shadows a local variable [-Werror,-Wshadow] HitTestRequest request(HitTestRequest::kReadOnly | HitTestRequest::kActive); ^ third_party/blink/renderer/core/input/event_handler.cc:636:18: note: previous declaration is here HitTestRequest request(HitTestRequest::kActive); ^ third_party/blink/renderer/core/input/event_handler.cc:772:22: error: declaration shadows a local variable [-Werror,-Wshadow] HitTestRequest request(HitTestRequest::kReadOnly | ^ third_party/blink/renderer/core/input/event_handler.cc:636:18: note: previous declaration is here HitTestRequest request(HitTestRequest::kActive); ^ third_party/blink/renderer/core/input/scroll_manager.cc:254:11: error: declaration shadows a local variable [-Werror,-Wshadow] Node* node = DOMNodeIds::NodeForId(scroll_chain.back()); ^ third_party/blink/renderer/core/input/scroll_manager.cc:228:9: note: previous declaration is here Node* node = start_node; ^ Bug: 923510 Change-Id: I2bfd6993232654574a11dbfe7ded2b27555d931a Reviewed-on: https://chromium-review.googlesource.com/c/1494877 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#637296} .../blink/renderer/core/input/event_handler.cc | 22 +++++++++++----------- .../blink/renderer/core/input/scroll_manager.cc | 6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) commit c5604de950ff01de7a8078cefba14cc0a94a63ca Author: Samuel Huang <huangs@chromium.org> Date: Mon Mar 4 15:38:00 2019 +0000 [Bundles] Add Bundle support to Trichrome Chrome This CL adds the trichrome_chrome_bundle target. A caveat is that in order to make Trichrome Chrome use the same ARM bitness as Trichrome Library, we need to inject "native_lib_placeholders" files (e.g., "libdummy.so") to the Trichrome base module. Implementation: * For monochrome_public_bundle_tmpl -> android_app_bundle: Pass |add_native_lib_placeholders_for_base_module| flag for Trichrome. * The above flag causes android_app_bundle to pass placeholder params to create_android_app_bundle_module, which then adds the proper flags to apkbuilder.py call. Change-Id: I8d7355bd052166b51aa9b8336f9436d975661a28 Reviewed-on: https://chromium-review.googlesource.com/c/1487837 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#637295} build/config/android/internal_rules.gni | 14 ++++++++++++++ build/config/android/rules.gni | 30 +++++++++++++++++++++++++++--- chrome/android/BUILD.gn | 32 ++++++++++++++++++++++++++++---- 3 files changed, 69 insertions(+), 7 deletions(-) commit 92573b154cacfde79a2ce1f81999d91bb9e8a06e Author: Jonathan Backer <backer@chromium.org> Date: Mon Mar 4 15:33:09 2019 +0000 Build RasterDecoder fuzzer with passthrough Bug: 936016 Change-Id: Ib9311671fe3fc3c3e90e9ba464919ac028e23c7e Reviewed-on: https://chromium-review.googlesource.com/c/1495743 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637294} gpu/BUILD.gn | 24 ++++++++++++++++++++++++ gpu/command_buffer/tests/fuzzer_main.cc | 3 ++- 2 files changed, 26 insertions(+), 1 deletion(-) commit 0b26209d474eef8a85711d7f6c629190064d5aae Author: Stephane Zermatten <szermatt@chromium.org> Date: Mon Mar 4 15:31:07 2019 +0000 Fix ControllerTest.Stop fails on android-marshmallow-arm64-rel This change cleans the way ControllerTest.Stop works. It makes it go through the external interface instead of calling the private method Controller::ExecuteScript. This avoid hitting some unsupported state. Bug: 937830 Change-Id: I4e451db92853058a65ba5af193177e8381611947 Reviewed-on: https://chromium-review.googlesource.com/c/1499533 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637293} .../browser/controller_unittest.cc | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) commit 31601309d465b10141909eb148dd878cfce9eff5 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 15:20:47 2019 +0000 Roll src-internal 2978aa5db94c..794439738e8e (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2978aa5db94c..794439738e8e Created with: gclient setdep -r src-internal@794439738e8e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1b969ddc0f1046330b2bf60ff868e822c724e4bb Reviewed-on: https://chromium-review.googlesource.com/c/1498860 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637292} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6cd94449752dfa8bac3e6ae0fcef9b6a2f8e39e5 Author: Maya Lekova <mslekova@chromium.org> Date: Mon Mar 4 15:10:30 2019 +0000 flags: assign harmony-await-optimization R=ellyjones@chromium.org Bug: None Change-Id: I13736f22255892556b6ff649c2dd504c2384866f Reviewed-on: https://chromium-review.googlesource.com/c/1496877 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#637291} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 74f8164418f3efccc066a858d068aacca54028ce Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Mar 4 15:03:57 2019 +0000 [Sync::USS] Use correct the order in DCHECK_LE in PasswordSyncBridge Recent crashes were interpreted as an issue in the underlying password store. However, it turns out to be that the wrong DCHECKs have been used actually. The order of the parameters to the DCHECK was switched. This CL is fixing that and revert the code added to debug that issue which was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1494878 Bug: 936823 Change-Id: I5de11889963a5eea59a0d72a19dc6d891d7ae27f Reviewed-on: https://chromium-review.googlesource.com/c/1497136 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#637290} .../core/browser/sync/password_sync_bridge.cc | 26 ++-------------------- 1 file changed, 2 insertions(+), 24 deletions(-) commit 3469670053de243f548f568680218cefd6371521 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Mar 4 15:03:38 2019 +0000 Update Background service proto with new schema. The new schema reduces the per-feature flexibility to allow for a simpler DevTools protocol / UI. Also fixes the `IsRecording` check and adds a test. Bug: 927726 Change-Id: I62454b221805d875d0478c6baa2ea2486199d029 Reviewed-on: https://chromium-review.googlesource.com/c/1489671 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637289} .../devtools/devtools_background_services.proto | 23 ++++---- .../devtools_background_services_context.cc | 65 ++++++++++------------ .../devtools_background_services_context.h | 27 ++++----- ...evtools_background_services_context_unittest.cc | 48 ++++++++++++---- 4 files changed, 89 insertions(+), 74 deletions(-) commit 1c3948d821344ed5e34f8714d84af13c4ae2afa8 Author: Richard Knoll <knollr@chromium.org> Date: Mon Mar 4 15:01:03 2019 +0000 Run pending tasks in ~TestBrowserThreadBundle. This makes sure we run all remaining tasks in tests. This should be the case even for ExecutionMode::QUEUED as documented here: https://cs.chromium.org/chromium/src/base/test/scoped_task_environment.h?l=42 Also lift the restriction to only flush tasks in !MOCK_TIME && !QUEUED modes which is unnecessary now that TestBrowserThreadBundle is-a ScopedTaskEnvironment (http://crrev.com/616622). Bug: 708584 Change-Id: I52773e27d3875bd246bb1cd7eea92c9e11fc70bf Reviewed-on: https://chromium-review.googlesource.com/c/1480460 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#637288} content/public/test/test_browser_thread_bundle.cc | 43 ++++++++++------------- 1 file changed, 19 insertions(+), 24 deletions(-) commit 31ad82ae99ed2a328d95fa6f73360a7c13561436 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Mar 4 14:58:46 2019 +0000 Create a protocol + handler for Background Service recording. - Create protocol for starting/stopping/querying recording mode - Add handler which talks to the DevTools context - Add a SDK model that the view communicates with - flat_map -> array to avoid multi-thread access issues Bug: 927726 Change-Id: I11e55a747c7c5c60465508485d6b869b976d40dd Reviewed-on: https://chromium-review.googlesource.com/c/1477851 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#637287} content/browser/BUILD.gn | 4 + content/browser/devtools/BUILD.gn | 2 + .../devtools/devtools_background_services.proto | 2 + .../devtools_background_services_context.cc | 32 ++----- .../devtools_background_services_context.h | 8 +- .../protocol/background_service_handler.cc | 105 +++++++++++++++++++++ .../devtools/protocol/background_service_handler.h | 50 ++++++++++ content/browser/devtools/protocol_config.json | 3 + .../devtools/render_frame_devtools_agent_host.cc | 55 +++++------ .../renderer/core/inspector/browser_protocol.pdl | 30 ++++++ third_party/blink/renderer/devtools/BUILD.gn | 1 + .../blink/renderer/devtools/front_end/main/Main.js | 2 +- .../front_end/resources/ApplicationPanelSidebar.js | 53 +++++++++-- .../front_end/resources/BackgroundServiceModel.js | 54 +++++++++++ .../front_end/resources/BackgroundServiceView.js | 44 +++++++-- .../devtools/front_end/resources/module.json | 1 + .../http/tests/devtools/agents-enable-disable.js | 3 +- 17 files changed, 378 insertions(+), 71 deletions(-) commit e348558ff2666194977acfb0ccb6c2fe264bf639 Author: Jeremy Roman <jbroman@chromium.org> Date: Mon Mar 4 14:54:37 2019 +0000 Don't leak the device serial number in BrowserDMTokenStorageMac. being called (i.e., it leaks 1 retain count), analogous to unique_ptr::release. ScopedCFTypeRef: :release doesn't call CFRelease; it prevents CFRelease from Change-Id: I48b41162b49583f892b16a7c715e1713ae226704 Reviewed-on: https://chromium-review.googlesource.com/c/1497222 Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637286} chrome/browser/policy/browser_dm_token_storage_mac.mm | 1 - 1 file changed, 1 deletion(-) commit 15eacd9a2a3fcead24309e9f3759516ac4fd7493 Author: Jonathan Backer <backer@chromium.org> Date: Mon Mar 4 14:53:48 2019 +0000 Run video pixels tests with SkiaRenderer DISABLED some tests that currently fail. Will follow up with CLs to fix them. Bug: 908957 Change-Id: I0839c32e944ec179118c14fe6592d2c62ef073cd Reviewed-on: https://chromium-review.googlesource.com/c/1494716 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637285} .../viz/service/display/renderer_pixeltest.cc | 194 +++++++++++++-------- 1 file changed, 121 insertions(+), 73 deletions(-) commit 197b989219cf2f7575b8db162c54b1456ff55b63 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Mon Mar 4 14:52:56 2019 +0000 [Autofill] Renamed files with shorter, more descriptive names. I used $ git mv path/old_file.cc path/new_file.cc. I am unsure why it thinks that name_phone_and_email_disclosure_label_formatter.cc was deleted and why contact_form_label_formatter.cc was created. I took a screenshot. The terminal at least recognized the renaming. https://screenshot.googleplex.com/r3WUBYa7YOC Change-Id: Icd154a7a989925bb7de976d70c0da6991eae2f58 Reviewed-on: https://chromium-review.googlesource.com/c/1498613 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#637284} components/autofill/core/browser/BUILD.gn | 14 +++++++------- ...bel_formatter.cc => address_form_label_formatter.cc} | 9 ++++----- ...label_formatter.h => address_form_label_formatter.h} | 17 ++++++++--------- ...bel_formatter.cc => contact_form_label_formatter.cc} | 17 +++++++---------- ...label_formatter.h => contact_form_label_formatter.h} | 17 ++++++++--------- ...el_formatter_creator.cc => label_formatter_utils.cc} | 11 ++++++----- ...abel_formatter_creator.h => label_formatter_utils.h} | 6 +++--- ...or_unittest.cc => label_formatter_utils_unittest.cc} | 14 +++++++------- 8 files changed, 50 insertions(+), 55 deletions(-) commit 3d9e6478f7549ce58c86f5a5809ccfdbce728745 Author: jonross <jonross@chromium.org> Date: Mon Mar 4 14:52:04 2019 +0000 Add Vulkan Integration Test on GPU FYI Bots This creates a variant of content_browsertests called vulkan_content_browsertests. The goal is to have these tests fail if the GPU process fails. So that we can catch regressions in our Vulkan code. This first pass only adds them to the Linux GPU FYI bots. The tests are also limited to a subset of AuraWindowVideoCaptureDeviceBrowserTest to start. These are sufficient to catch regressions we saw last week. TEST=vulkan_content_browsertests Change-Id: Ic9489fd56f0c935c589c1c4f42fd5ea293d51368 Reviewed-on: https://chromium-review.googlesource.com/c/1460860 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#637283} .../browser/gpu/gpu_data_manager_impl_private.cc | 8 +- content/public/common/content_switches.cc | 5 + content/public/common/content_switches.h | 1 + testing/buildbot/chromium.gpu.fyi.json | 298 +++++++++++++++++++++ testing/buildbot/filters/BUILD.gn | 1 + .../filters/vulkan.content_browsertests.filter | 5 + testing/buildbot/test_suites.pyl | 24 ++ 7 files changed, 341 insertions(+), 1 deletion(-) commit 84f2c6f63e2319e4b67a7ea147c6b77f06657012 Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 14:48:11 2019 +0000 Remove dead code from SyncTest Bug: none Change-Id: I342972fe88bcd22d77db9fe1c57533ce1773d92d Reviewed-on: https://chromium-review.googlesource.com/c/1487031 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637282} chrome/browser/sync/test/integration/sync_test.cc | 79 +---------------------- chrome/browser/sync/test/integration/sync_test.h | 66 ++++--------------- 2 files changed, 13 insertions(+), 132 deletions(-) commit 081531d5a5984715ee44d6d4949f76f93e427334 Author: Lowell Manners <lowell@chromium.org> Date: Mon Mar 4 14:45:51 2019 +0000 Make IdentityAccessorImplTest a friend of IdentityTestEnvironment. This allows us to use a private constructor of IdentityTestEnvironment while doing a gradual conversion to IdentityManager. Change-Id: Ifc6d57bfd39a76c4faef3726f8b49f38041509af Bug: 933109 Reviewed-on: https://chromium-review.googlesource.com/c/1498475 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637281} .../identity/identity_accessor_impl_unittest.cc | 2 -- .../public/cpp/identity_test_environment.h | 39 +++++++++++++--------- 2 files changed, 23 insertions(+), 18 deletions(-) commit 5a65ee8394e57689c4b399babaa23d4948d42eeb Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Mar 4 14:42:00 2019 +0000 Generate <out>/gen/.../core/css/properties/css_property.cc|h using downcast helpers R=haraken@chromium.org CC=​blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I124d1febc98e7186e01ec1d32c29022e26886b79 Reviewed-on: https://chromium-review.googlesource.com/c/1496058 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#637280} .../core/css/properties/templates/css_property.cc.tmpl | 6 +++--- .../core/css/properties/templates/css_property.h.tmpl | 12 +++++++----- 2 files changed, 10 insertions(+), 8 deletions(-) commit f66e281273fada19d1f3794ea71423046414bab7 Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 14:39:17 2019 +0000 Mark http/tests/security/xss-DENIED-cross-origin-stack-overflow.html non flaky The test doesn't seem to be flaky anymore. See dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fsecurity%2Fxss-DENIED-cross-origin-stack-overflow.html TBR=tsepez@chromium.org NOTRY=true Bug: 937546 Change-Id: Id9970a7b788538173d26b55e1586806bba09e37e Reviewed-on: https://chromium-review.googlesource.com/c/1498387 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637279} third_party/blink/web_tests/TestExpectations | 1 - 1 file changed, 1 deletion(-) commit 0667fb0536055fa5875b6fe288ba2b64882d5d8b Author: Stepan Khapugin <stkhapugin@chromium.org> Date: Mon Mar 4 14:36:55 2019 +0000 Remove pre-UI Refresh code in Location Bar, Omnibox, Popup. Removes obsolete code. Change-Id: Id767f121eaf6f0835ccbc1589d05be54d87139ce Reviewed-on: https://chromium-review.googlesource.com/c/1496997 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637278} .../ui/omnibox/autocomplete_match_formatter.mm | 83 ++-------- .../browser/ui/omnibox/autocomplete_suggestion.h | 3 - .../browser/ui/omnibox/omnibox_text_field_ios.h | 8 +- .../browser/ui/omnibox/omnibox_text_field_ios.mm | 183 +-------------------- ios/chrome/browser/ui/omnibox/omnibox_view_ios.h | 15 +- ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm | 178 -------------------- .../browser/ui/omnibox/popup/omnibox_popup_row.mm | 21 +-- .../omnibox/popup/omnibox_popup_view_controller.mm | 14 -- .../browser/ui/toolbar/adaptive_toolbar_egtest.mm | 14 -- ios/chrome/browser/ui/toolbar/toolbar_egtest.mm | 19 --- ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm | 3 - 11 files changed, 23 insertions(+), 518 deletions(-) commit 454ff31ed3bdfa17ea8811d4d1c00e979d21cf4a Author: Takuto Ikuta <tikuta@chromium.org> Date: Mon Mar 4 14:34:05 2019 +0000 [web_applications] remove unused deps web_app.proto does not use anything in //components/sync/protocol Bug: 937723 Change-Id: I9426ff08dcde617d969a3ad6f6c8aba0d0bb8ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1498748 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#637277} chrome/browser/web_applications/proto/BUILD.gn | 3 --- 1 file changed, 3 deletions(-) commit ce3595b93b9f700d8f05281310ad63684a1fdcd1 Author: Josh Karlin <jkarlin@chromium.org> Date: Mon Mar 4 14:30:17 2019 +0000 [NetInfo] Fix a broken browsertest This test only worked because the bots happen to be running on ethernet connections. Change the test to use a mock NCN and change the network type to verify that the mock is being used. Bug: 934976 Change-Id: Icca2c84b13807a1d9b18adb7d899f9200da5b824 Reviewed-on: https://chromium-review.googlesource.com/c/1486676 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637276} build/sanitizers/tsan_suppressions.cc | 4 ++++ content/browser/net_info_browsertest.cc | 25 +++++++++++++++++++++---- 2 files changed, 25 insertions(+), 4 deletions(-) commit 39f6b955d1a4432025f556722a5b9be0a43707af Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Mon Mar 4 14:25:45 2019 +0000 BlinkMemoryMgt: Annotate Blink's platform/graphics with the macros of Allocator As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/font with the macros of Allocator. After some analyzes, it was concluded that for the case of BoxReflection, CanvasColorParams, ColorSchemeSet, FakeScrollClient, CompositingReason, SharedGpuContext, HighContrastImageClassifier, Translation2DOrMatrix classes, they make sense to use DISALLOW_NEW because they have been used as a member variable with a reference type. In MockDestructible, GpuMemoryBufferImageCopy, Gradient, CombinedImageDecodeCache, and PaintArtifact classes, they make sense to use USING_FAST_MALLOC because they're used with new or smart pointers. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED or STATIC_ONLY. Bug: 919389 Change-Id: I368a1d902d16f40585e2ca3a573f48fafb95ec65 Reviewed-on: https://chromium-review.googlesource.com/c/1498743 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#637275} third_party/blink/renderer/platform/graphics/box_reflection.h | 3 +++ third_party/blink/renderer/platform/graphics/canvas_color_params.h | 3 +++ .../blink/renderer/platform/graphics/color_correction_test_utils.h | 3 +++ third_party/blink/renderer/platform/graphics/color_scheme.h | 4 ++++ .../platform/graphics/compositing/paint_artifact_compositor_test.cc | 3 +++ .../platform/graphics/compositing/paint_chunks_to_cc_layer.cc | 3 +++ .../renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.h | 3 +++ third_party/blink/renderer/platform/graphics/compositing_reasons.h | 3 +++ .../blink/renderer/platform/graphics/contiguous_container_test.cc | 3 +++ third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.h | 3 +++ .../blink/renderer/platform/graphics/gpu/shared_gpu_context_test.cc | 3 +++ .../blink/renderer/platform/graphics/gpu_memory_buffer_image_copy.h | 3 +++ third_party/blink/renderer/platform/graphics/gradient.h | 3 +++ .../blink/renderer/platform/graphics/high_contrast_image_classifier.h | 3 +++ third_party/blink/renderer/platform/graphics/image.cc | 3 +++ third_party/blink/renderer/platform/graphics/image_decoder_wrapper.h | 3 +++ third_party/blink/renderer/platform/graphics/image_frame_generator.h | 2 ++ .../blink/renderer/platform/graphics/offscreen_canvas_placeholder.h | 3 +++ .../platform/graphics/paint/display_item_raster_invalidator.h | 3 +++ third_party/blink/renderer/platform/graphics/paint/geometry_mapper.h | 3 +++ third_party/blink/renderer/platform/graphics/paint/paint_artifact.h | 2 ++ .../blink/renderer/platform/graphics/paint/paint_chunk_subset.h | 2 ++ 22 files changed, 64 insertions(+) commit 42587ed4d4aa84a740afe52bbdffe5049c0fb85d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 4 14:23:31 2019 +0000 flags: remove enable-gamepad-vibration from metadata TBR=avi@chromium.org Bug: 933443 Change-Id: I357979b08466dd9bc49d93c0b6e8dd6584595055 Reviewed-on: https://chromium-review.googlesource.com/c/1498781 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#637274} chrome/browser/flag-metadata.json | 5 ----- 1 file changed, 5 deletions(-) commit 584968e9776d3833573b69bd5f8dc049b3718334 Author: Chinglin Yu <chinglinyu@chromium.org> Date: Mon Mar 4 14:18:33 2019 +0000 Suppress memory pressure notifications when tab discarder is in action. This temporarily suppresses further memory pressure notifications to the tab discarder when it's already handling the memory pressure. This avoids tabs/apps killed in a burst inadvertently if the tab discarder takes a long time to handle a heavy memory pressure. TabManager.RegisterMemoryPressureListener Bug: chromium:729335 TEST: Manual test on DUT, new browser_test:TabManagerTest.TabDiscardDoneCallback, Change-Id: I9948b27b22dc72438a6dd20c08967c8d7d56f2b5 Reviewed-on: https://chromium-review.googlesource.com/c/1288178 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#637273} base/memory/memory_pressure_listener.cc | 5 +- .../chromeos/arc/process/arc_process_service.cc | 29 +++-- .../chromeos/arc/process/arc_process_service.h | 33 +++-- chrome/browser/resource_coordinator/tab_manager.cc | 56 +++++++-- chrome/browser/resource_coordinator/tab_manager.h | 22 +++- .../tab_manager_browsertest.cc | 139 +++++++++++++++++++++ .../tab_manager_delegate_chromeos.cc | 57 +++++---- .../tab_manager_delegate_chromeos.h | 13 +- .../tab_manager_delegate_chromeos_unittest.cc | 19 ++- .../providers/arc/arc_process_task_provider.cc | 19 ++- .../providers/arc/arc_process_task_provider.h | 7 +- 11 files changed, 320 insertions(+), 79 deletions(-) commit 811c5c3f20ca1e3d62bb41731bb8d7477b6c60f7 Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 14:12:49 2019 +0000 Mark elements-panel-shadow-selection-on-refresh-[2,3].js flaky on Win and Linux TBR=pfeldman@chromium.org Bug: 937811 Change-Id: Ie339813baf31303f700f2284427a886222c95af2 Reviewed-on: https://chromium-review.googlesource.com/c/1496369 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637272} third_party/blink/web_tests/TestExpectations | 5 +++++ 1 file changed, 5 insertions(+) commit b0ace1224213d265ddca895397f8c0071ea03ff2 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 14:10:08 2019 +0000 Roll src-internal 8d29f4238a2c..2978aa5db94c (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8d29f4238a2c..2978aa5db94c Created with: gclient setdep -r src-internal@2978aa5db94c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idefbc0da10afbb63d3cf6b1567644f793b3c6811 Reviewed-on: https://chromium-review.googlesource.com/c/1498858 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637271} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 78bf996b9be6ba40cb3e13ec039e8ace5dc5a411 Author: Rayan Kanso <rayankans@chromium.org> Date: Mon Mar 4 13:56:51 2019 +0000 [Background Fetch] Remove cache migration DB task. The task was part of the previous milestone and is no longer needed. Bug: 871174 Change-Id: Ie7d171b0b8174599478171b00fa0b92fc647dcfd Reviewed-on: https://chromium-review.googlesource.com/c/1478792 Reviewed-by: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#637270} .../background_fetch_data_manager_unittest.cc | 68 --------- .../storage/get_initialization_data_task.cc | 166 --------------------- 2 files changed, 234 deletions(-) commit fb3cb75ead46b9979ac934f69ef05cad06fd11b1 Author: Eric Robinson <ericrobinson@google.com> Date: Mon Mar 4 13:55:50 2019 +0000 Add a cpu task duration pipe for PageLoadMetricsObserver. See also go/chromecputhrottling. This implements the first part of: https://chromium-review.googlesource.com/c/chromium/src/+/1382710 Create a data flow from MainThreadSchedulerImpl::OnTaskCompleted in blink to the PageLoadMetricsObserver to report (wall) time spent doing tasks for a frame. Since a frame may run many tasks, task completion messages are aggregated at two layers: 1. In the FrameScheduler, the task times are tallied until a threshold of 100ms is reached. 2. In the PageMetricsSender, sends are scheduled along with the PageLoadTiming data, which occurs at most once a second. Overview of the call chain: MainThreadSchedulerImpl::OnTaskCompleted calls FrameScheduler::AddTaskTime calls * Delays until 100ms of tasks have been accumulated) FrameScheduler::delegate::AddTaskTime calls * Implemented by LocalFrame::AddTaskTime LocalFrameClient::DidChangeCpuTiming (OR by LocalFrameClientImpl) calls WebLocalFrameClient::DidChangeCpuTiming (OR by RenderFrameImpl) calls RenderFrameObserver::DidChangeCpuTiming (OR by MetricsRenderFrameObserver) calls PageTimingMetricsSender::UpdateCpuLoadTiming calls PageTimingMetricsSender::SendNow calls * Joined with PageLoadTiming call chain * (Delays and sends on 1 second timer) PageTimingSender::SendTiming calls PageLoadMetrics::UpdateTiming calls * (mojom interface, implemented by MetricsWebContentObserver) MetricsWebContentsObserver::OnTimingUpdated calls PageLoadMetricsUpdateDispatcher::UpdateMetrics calls * Split from PageLoadTiming call chain PageLoadMetricsUpdateDispatcher::UpdateFrameCpuTiming calls PageLoadMetricsUpdateDispatcher::Client::OnFrameCpuTimingChanged calls * Implemented by PageLoadTracker::OnFrameCpuTimingChanged PageLoadMetricsObserver::OnCpuTimingUpdate (OR by CpuLoadMetricsObserver) Change-Id: Ifeb3c273a38569893b067ebcbfd78a68bba1f02e Bug: 937298 Reviewed-on: https://chromium-review.googlesource.com/c/1470594 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#637269} .../metrics_web_contents_observer.cc | 12 ++-- .../metrics_web_contents_observer.h | 6 +- .../metrics_web_contents_observer_unittest.cc | 74 ++++++++++++++++++++-- .../ads_page_load_metrics_observer_unittest.cc | 3 +- .../observers/page_load_metrics_observer_tester.cc | 29 +++++---- .../observers/page_load_metrics_observer_tester.h | 1 + .../page_load_metrics/page_load_metrics_observer.h | 6 ++ .../page_load_metrics_update_dispatcher.cc | 23 ++++++- .../page_load_metrics_update_dispatcher.h | 7 +- .../browser/page_load_metrics/page_load_tracker.cc | 7 ++ .../browser/page_load_metrics/page_load_tracker.h | 2 + .../page_load_metrics/page_load_metrics.mojom | 9 ++- .../page_load_metrics/fake_page_timing_sender.cc | 29 ++++++++- .../page_load_metrics/fake_page_timing_sender.h | 16 ++++- .../metrics_render_frame_observer.cc | 17 +++-- .../metrics_render_frame_observer.h | 1 + .../metrics_render_frame_observer_unittest.cc | 26 ++++++++ .../page_timing_metrics_sender.cc | 9 ++- .../page_load_metrics/page_timing_metrics_sender.h | 6 ++ .../page_load_metrics/page_timing_sender.h | 3 +- content/public/renderer/render_frame_observer.h | 4 ++ content/renderer/render_frame_impl.cc | 5 ++ content/renderer/render_frame_impl.h | 1 + .../blink/public/web/web_local_frame_client.h | 4 ++ .../core/exported/local_frame_client_impl.cc | 5 ++ .../core/exported/local_frame_client_impl.h | 1 + .../blink/renderer/core/frame/local_frame.cc | 4 ++ .../blink/renderer/core/frame/local_frame.h | 1 + .../blink/renderer/core/frame/local_frame_client.h | 3 + .../scheduler/main_thread/frame_scheduler_impl.cc | 14 ++++ .../scheduler/main_thread/frame_scheduler_impl.h | 8 +++ .../main_thread/frame_scheduler_impl_unittest.cc | 56 +++++++++++++++- .../main_thread/main_thread_scheduler_impl.cc | 2 + .../platform/scheduler/public/frame_scheduler.h | 2 + .../worker/worker_thread_scheduler_unittest.cc | 2 + 35 files changed, 358 insertions(+), 40 deletions(-) commit 7fad6eb2a47361d24de7637de2ee854638864e99 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Mon Mar 4 13:51:08 2019 +0000 [iOS][MF] Pass only the needed origin. Bug: 936413, 932089 Change-Id: Ic05baf81a0344be15e8092c5fc08f892e5dced06 Reviewed-on: https://chromium-review.googlesource.com/c/1495540 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#637268} .../autofill/manual_fill/passwords_fetcher.h | 2 +- .../autofill/manual_fill/passwords_fetcher.mm | 8 +++---- .../manual_fill/passwords_fetcher_unittest.mm | 16 +++++++------- .../autofill/form_input_accessory_coordinator.mm | 7 +++++- .../ui/autofill/form_input_accessory_mediator.mm | 2 +- .../ui/autofill/manual_fill/password_coordinator.h | 10 ++++----- .../autofill/manual_fill/password_coordinator.mm | 25 +++++++++------------- .../ui/autofill/manual_fill/password_mediator.h | 2 +- .../ui/autofill/manual_fill/password_mediator.mm | 4 ++-- 9 files changed, 38 insertions(+), 38 deletions(-) commit 9d42b140aab35c300ff8ba09c472588674850c2a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 13:48:23 2019 +0000 Roll src/third_party/webrtc 4a42742dc6e4..87e05b5df58c (2 commits) https://webrtc.googlesource.com/src.git/+log/4a42742dc6e4..87e05b5df58c git log 4a42742dc6e4..87e05b5df58c --date=short --no-merges --format='%ad %ae %s' 2019-03-04 henrik.lundin@webrtc.org NetEq fuzzer: lower the maximum fuzzer input size 2019-03-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b3ef4b21cb..e65d7afd91 (637096:637200) Created with: gclient setdep -r src/third_party/webrtc@87e05b5df58c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:935089,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I444c029c8b57df9dd4d0f8278922330eda35fc2d Reviewed-on: https://chromium-review.googlesource.com/c/1498853 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637267} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 040874144b0c42a11ac013ef2dcd3ce8058b1433 Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Mar 4 13:38:50 2019 +0000 Add VirtualURL to OpenURLCommand Use it when loading offline page in RLCoordinator Bug: 929492 Change-Id: Icfe12d5de0f67e9980f7b361e360cfa3eb058bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1488924 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#637266} ios/chrome/app/main_controller.mm | 2 +- .../browser/ui/commands/open_new_tab_command.h | 10 ++++++++++ .../browser/ui/commands/open_new_tab_command.mm | 20 ++++++++++++++++++++ .../ui/reading_list/reading_list_coordinator.mm | 1 + .../browser/url_loading/url_loading_service.mm | 10 +++++++--- 5 files changed, 39 insertions(+), 4 deletions(-) commit ba4a1f4c22b696bf2ef1afcab81864ed1278997e Author: Lowell Manners <lowell@chromium.org> Date: Mon Mar 4 13:28:56 2019 +0000 Update IdentityManagerImpl to use IdentityManager::Observer. Step 1 in converting IdentityManagerImpl to be solely backed by IdentityManager. Bug: 933109 Change-Id: I5725bc354c554973b24a61afdb51163503fb2b28 Reviewed-on: https://chromium-review.googlesource.com/c/1494660 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637265} chrome/browser/profiles/profile_impl.cc | 1 + .../browser/signin/identity_service_creator.cc | 6 +++- services/identity/BUILD.gn | 2 +- services/identity/DEPS | 1 + services/identity/identity_accessor_impl.cc | 25 ++++++++-------- services/identity/identity_accessor_impl.h | 18 +++++++----- .../identity/identity_accessor_impl_unittest.cc | 34 ++++++++++++++++++++++ services/identity/identity_service.cc | 12 ++++++-- services/identity/identity_service.h | 5 +++- 9 files changed, 79 insertions(+), 25 deletions(-) commit 603be26520b685cb0da2cc441dabf89327646f88 Author: Yoav Weiss <yoavweiss@chromium.org> Date: Mon Mar 4 13:14:57 2019 +0000 [Client hints] Move navigation CH logic to content This change refactors the Client-Hints creation logic for navigation requests and moves it from //chrome to //content, in order to make it WPT testable on the bots. Change-Id: I071743db7004a775171b92b9c857ab0595ed8b7b Reviewed-on: https://chromium-review.googlesource.com/c/1450127 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#637264} chrome/browser/client_hints/client_hints.cc | 437 ++----------------- chrome/browser/client_hints/client_hints.h | 36 +- .../browser/client_hints/client_hints_unittest.cc | 188 -------- chrome/test/BUILD.gn | 1 - content/browser/BUILD.gn | 2 + content/browser/DEPS | 1 + content/browser/client_hints/client_hints.cc | 476 +++++++++++++++++++++ content/browser/client_hints/client_hints.h | 39 ++ .../browser/client_hints/client_hints_unittest.cc | 168 ++++++++ content/browser/frame_host/navigation_request.cc | 21 +- .../browser/client_hints_controller_delegate.h | 28 +- content/test/BUILD.gn | 1 + .../renderer/core/loader/frame_fetch_context.h | 2 - 13 files changed, 761 insertions(+), 639 deletions(-) commit 1ccdf8f7bae04f3d421b0677fd404dda6c303ada Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 13:07:33 2019 +0000 Roll src/third_party/dawn a8ce0a434e12..081d5c2f6480 (1 commits) https://dawn.googlesource.com/dawn.git/+log/a8ce0a434e12..081d5c2f6480 git log a8ce0a434e12..081d5c2f6480 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 jiawei.shao@intel.com Add validations on texture sample counts in B2T and T2B copies Created with: gclient setdep -r src/third_party/dawn@081d5c2f6480 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iff3f6b3bf84564353c55ec1db4ef06882adb9ef2 Reviewed-on: https://chromium-review.googlesource.com/c/1498856 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637263} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af1a27ec9bfae6f907ccd19a05372505e6b7359a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 13:04:23 2019 +0000 Roll src-internal 672eb32910a9..8d29f4238a2c (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/672eb32910a9..8d29f4238a2c Created with: gclient setdep -r src-internal@8d29f4238a2c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie2bee80d2c4ac1f60379c196f28136f5dbe82596 Reviewed-on: https://chromium-review.googlesource.com/c/1498854 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637262} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1da59ecdefeab449a032ed9adb16f4f4f5ea24c2 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Mar 4 12:53:43 2019 +0000 Remove LegacyMergeSigninCredentialIntoCookieJar() Replace the call to LegacyMergeSigninCredentialIntoCookieJar() in InlineSigninHelper by AccountsCookieMutator::AddAccountToCookie(). This correspond to inlining the implementation of SigninManager's MergeSigninCredentialIntoCookieJar method and is possible because InlineSigninHelper is only used on desktop (so not Android, iOS or ChromeOS) which does not support mirror (thus there is no need to check for consistency state). Also remove the methods from SigninManager and IdentityManager. Bug: 936870 Change-Id: I55606f71d7b98faaab5ed5f729778e4a7b83bbd0 Reviewed-on: https://chromium-review.googlesource.com/c/1494661 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637261} chrome/browser/ui/webui/signin/inline_login_handler_impl.cc | 8 ++++++-- components/signin/core/browser/signin_manager.cc | 12 ------------ components/signin/core/browser/signin_manager.h | 3 --- services/identity/public/cpp/primary_account_mutator.h | 8 -------- services/identity/public/cpp/primary_account_mutator_impl.cc | 4 ---- services/identity/public/cpp/primary_account_mutator_impl.h | 1 - 6 files changed, 6 insertions(+), 30 deletions(-) commit a2bcecddbd673048f650bd2a62d18e259f41c147 Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 12:45:05 2019 +0000 Revert "Add end-to-end browser tests for PluginVm setup flow" This reverts commit 102725907a7b20dbf76a069730be2c01a6997ce0. Reason for revert: Breaks non_single_process_mash_browser_tests on linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel Original change's description: > Add end-to-end browser tests for PluginVm setup flow > > Adds end-to-end setup flow browser tests. > This CL also adds DCHECKs that check that UI related calls made in the > UI thread. > > Test: browser_tests --gtest_filter="PluginVm*" > Bug: 920988 > Change-Id: Ia3ae225f44f05cde4468b72f49a7ecbaa250c42c > Reviewed-on: https://chromium-review.googlesource.com/c/1494881 > Commit-Queue: Olya Kalitova <okalitova@chromium.org> > Reviewed-by: Igor <igorcov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637253} TBR=igorcov@chromium.org,okalitova@chromium.org Change-Id: I58d866b13fd31879448ab251f112e49e139c6c2e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920988 Reviewed-on: https://chromium-review.googlesource.com/c/1498535 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637260} .../ui/views/plugin_vm/plugin_vm_launcher_view.cc | 58 +++---- .../ui/views/plugin_vm/plugin_vm_launcher_view.h | 25 +-- .../plugin_vm_launcher_view_browsertest.cc | 179 +++++---------------- 3 files changed, 83 insertions(+), 179 deletions(-) commit 973343efe52df7f84c70d90769ba6491291a880f Author: Takuto Ikuta <tikuta@chromium.org> Date: Mon Mar 4 12:42:13 2019 +0000 [deterministic] update whitelist I couldn't find the reason of this non-determinism so let me have targets in whitelist. Bug: 937268 Change-Id: Id6fea7ff52051046c5d571f0fc3071dba21b77aa Reviewed-on: https://chromium-review.googlesource.com/c/1498750 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637259} tools/determinism/deterministic_build_whitelist.pyl | 4 ++++ 1 file changed, 4 insertions(+) commit 0abed30c77dc8904a452bebfd1982d9691ad0175 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Mon Mar 4 12:18:20 2019 +0000 OnionSoup: Move app_banner.mojom in public/platform to public/mojom This CL moves app_banner.mojom in public/platform/modules to public/mojom/app_banner and updates paths for app_banner.mojom. Bug: 919393 Change-Id: I4999b238924c6aae5885e19eb0d25f4fd47669d4 Reviewed-on: https://chromium-review.googlesource.com/c/1496124 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#637258} chrome/browser/DEPS | 1 - chrome/browser/banners/app_banner_manager.h | 2 +- content/shell/renderer/web_test/blink_test_runner.cc | 2 +- content/shell/test_runner/app_banner_service.h | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 1 + third_party/blink/public/{platform/modules => mojom}/app_banner/OWNERS | 0 .../public/{platform/modules => mojom}/app_banner/app_banner.mojom | 0 third_party/blink/renderer/modules/app_banner/app_banner_controller.h | 2 +- .../blink/renderer/modules/app_banner/before_install_prompt_event.h | 2 +- 10 files changed, 6 insertions(+), 7 deletions(-) commit 62381a50d67e599ff3001910824bf77880543c2e Author: Lowell Manners <lowell@chromium.org> Date: Mon Mar 4 12:18:11 2019 +0000 Revert "Eliminate IdentityTestEnvironment's public complex constructor" Temporarily bringing back this constructor, so we can gradually convert IdentityService to use IdentityManager. This reverts commit 315f254a62c3756c818da0d8d71614b5a3452869. Bug: 933109 Change-Id: I55b28ea996d44fd490a6ffbe707a6db493a93615 Reviewed-on: https://chromium-review.googlesource.com/c/1495542 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#637257} .../identity/public/cpp/identity_test_environment.cc | 18 ++++++++++++++++++ .../identity/public/cpp/identity_test_environment.h | 16 ++++++++++++++++ 2 files changed, 34 insertions(+) commit fd935ba18df81aed48b916ffbd7ffe103a1acc98 Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 12:11:55 2019 +0000 Mark VideoPathTraceTest_DirectComposition_ComplexOverlays flaky on Win10 TBR=magchen@chromium.org Bug: 937545 Change-Id: I70fa49f468ae3bbad52e28f80087f3b5726c3b6a Reviewed-on: https://chromium-review.googlesource.com/c/1498534 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637256} content/test/gpu/gpu_tests/trace_test_expectations.py | 4 ++++ 1 file changed, 4 insertions(+) commit 836216b5bb21042860bc7cbecfd10d1deae70611 Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 11:46:19 2019 +0000 Revert "DocumentLoader: commit navigation synchronously" This reverts commit b3191b4ffaa9e4056e39658e843421663a12d53d. Reason for revert: Seems to have broken multiple tests, see crbug.com/936805 and crbug.com/836242 Original change's description: > DocumentLoader: commit navigation synchronously > > We used to commit navigation after receiving the first byte of > document response. This CL moves commit earlier, synchronously done > from CommitNavigation call. The change should not be web-observable, > but some internal assumptions may have been affected. > > Test changes: > - ReplacingDocumentLoaderFiresLoadEvent was testing the old behavior, > which is not applicable anymore. > - MultiChunkWithReentrancy now uses a different method to trigger > reentrancy (pdf plugin), since we no longer commit after first byte. > - backdrop-object.html and anchor-change-href.svg relied on test finishing > late enough, now they wait for onload to eliminate a race. > - use-property-synchronization-crash.html now reports an error message > synchronously and therefore has JS stack and a line number. > - setting-allowpaymentrequest-timing.https.sub.html has a race as > explained here [1], and now fails even without site isolation. > > This corresponds to the step 8.b from the doc linked to the bug. > > [1] https://bugs.chromium.org/p/chromium/issues/detail?id=819800#c6 > > Bug: 855189 > > Change-Id: I0bdb32b9ac5245ddb81c2f77b41ea762d58ce526 > Reviewed-on: https://chromium-review.googlesource.com/c/1399447 > Commit-Queue: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636994} TBR=dgozman@chromium.org,dcheng@chromium.org,clamy@chromium.org,arthursonzogni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855189, 936805, 836242 Change-Id: Ic658b5262521bcb3d2691388476d3f713a923dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1498533 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637255} content/browser/navigation_browsertest.cc | 13 ++--- .../blink/renderer/core/loader/document_loader.cc | 41 +++++---------- .../renderer/core/loader/document_loader_test.cc | 60 ++++++++++++++-------- third_party/blink/web_tests/VirtualTestSuites | 5 ++ .../fullscreen/rendering/backdrop-object.html | 4 +- .../blink/web_tests/svg/css/anchor-change-href.svg | 42 ++++++++------- ...use-property-synchronization-crash-expected.txt | 2 +- 7 files changed, 82 insertions(+), 85 deletions(-) commit 2c3912e20691c2367e2f68f50885bf05d186b524 Author: Miyoung Shin <myid.shin@igalia.com> Date: Mon Mar 4 11:30:28 2019 +0000 Change short to int16_t/int32_t in third_party/blink/renderer/core/css - short -> int16_t/int32_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I072de8145ffc590464483e8c157f00a50d13aba4 Reviewed-on: https://chromium-review.googlesource.com/c/1498263 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637254} .../blink/renderer/core/animation/number_property_functions.cc | 2 +- third_party/blink/renderer/core/css/css_primitive_value.cc | 4 ++-- third_party/blink/renderer/core/css/css_primitive_value.h | 3 ++- third_party/blink/renderer/core/css/css_primitive_value_mappings.h | 4 ++-- .../blink/renderer/core/css/properties/computed_style_utils.cc | 2 +- third_party/blink/renderer/core/style/computed_style.h | 4 ++-- 6 files changed, 10 insertions(+), 9 deletions(-) commit 102725907a7b20dbf76a069730be2c01a6997ce0 Author: Olya Kalitova <okalitova@chromium.org> Date: Mon Mar 4 11:11:46 2019 +0000 Add end-to-end browser tests for PluginVm setup flow Adds end-to-end setup flow browser tests. This CL also adds DCHECKs that check that UI related calls made in the UI thread. Test: browser_tests --gtest_filter="PluginVm*" Bug: 920988 Change-Id: Ia3ae225f44f05cde4468b72f49a7ecbaa250c42c Reviewed-on: https://chromium-review.googlesource.com/c/1494881 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#637253} .../ui/views/plugin_vm/plugin_vm_launcher_view.cc | 58 ++++--- .../ui/views/plugin_vm/plugin_vm_launcher_view.h | 25 ++- .../plugin_vm_launcher_view_browsertest.cc | 179 ++++++++++++++++----- 3 files changed, 179 insertions(+), 83 deletions(-) commit 2d35d2f1cccd622e956e1828a9f323afe04700dd Author: Daniel Bratell <bratell@opera.com> Date: Mon Mar 4 11:01:57 2019 +0000 Remove variable shadowing in blink/html In an effort to reduce or even ban variable shadowing, this renames a variable to avoid such shadowing. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this avoids are: In file included from ./../../third_party/blink/renderer/core/html/forms/base_temporal_input_type.cc:31: In file included from ../../third_party/blink/renderer/core/html/forms/base_temporal_input_type.h:34: In file included from ../../third_party/blink/renderer/core/html/forms/date_time_edit_element.h:31: third_party/blink/renderer/core/html/forms/date_time_field_element.h:43:5: error: declaration shadows a variable in namespace 'blink' [-Werror,-Wshadow] kDispatchNoEvent, ^ third_party/blink/renderer/core/html/forms/text_control_element.h:46:3: note: previous declaration is here kDispatchNoEvent, ^ third_party/blink/renderer/core/html/forms/date_time_numeric_field_element.cc:98:9: error: declaration shadows a local variable [-Werror,-Wshadow] int value = TypeAheadValue(); ^ third_party/blink/renderer/core/html/forms/date_time_numeric_field_element.cc:95:51: note: previous declaration is here void DateTimeNumericFieldElement::SetFocused(bool value, ^ third_party/blink/renderer/core/html/forms/html_option_element.cc:348:15: error: declaration shadows a local variable [-Werror,-Wshadow] if (auto* select = ToHTMLSelectElementOrNull(insertion_point.parentNode())) ^ third_party/blink/renderer/core/html/forms/html_option_element.cc:344:13: note: previous declaration is here if (auto* select = ToHTMLSelectElementOrNull(insertion_point)) { ^ third_party/blink/renderer/core/html/html_hr_element.cc:138:15: error: declaration shadows a local variable [-Werror,-Wshadow] if (auto* select = ToHTMLSelectElementOrNull(parent)) ^ third_party/blink/renderer/core/html/html_hr_element.cc:133:13: note: previous declaration is here if (auto* select = ToHTMLSelectElementOrNull(insertion_point)) { ^ third_party/blink/renderer/core/html/html_slot_element.cc:125:17: error: declaration shadows a local variable [-Werror,-Wshadow] if (auto* slot = ToHTMLSlotElementIfSupportsAssignmentOrNull(child)) ^ third_party/blink/renderer/core/html/html_slot_element.cc:115:28: note: previous declaration is here const HTMLSlotElement& slot) { ^ third_party/blink/renderer/core/html/html_slot_element.cc:133:17: error: declaration shadows a local variable [-Werror,-Wshadow] if (auto* slot = ToHTMLSlotElementIfSupportsAssignmentOrNull(*node)) ^ third_party/blink/renderer/core/html/html_slot_element.cc:115:28: note: previous declaration is here const HTMLSlotElement& slot) { ^ third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc:770:14: error: declaration shadows a local variable [-Werror,-Wshadow] double current_timestamp; ^ third_party/blink/renderer/core/html/track/vtt/vtt_cue.cc:764:10: note: previous declaration is here double current_timestamp = startTime(); ^ third_party/blink/renderer/core/html/parser/html_tree_builder.cc:1464:14: error: declaration shadows a local variable [-Werror,-Wshadow] for (int i = 0; i < kInnerIterationLimit; ++i) { ^ third_party/blink/renderer/core/html/parser/html_tree_builder.cc:1415:12: note: previous declaration is here for (int i = 0; i < kOuterIterationLimit; ++i) { ^ third_party/blink/renderer/core/html/parser/text_resource_decoder.cc:332:9: error: declaration shadows a local variable [-Werror,-Wshadow] int len = 0; ^ third_party/blink/renderer/core/html/parser/text_resource_decoder.cc:297:57: note: previous declaration is here wtf_size_t len, Change-Id: I5ab4a7b99bb5f55cf2f0a97a2691c7aa3c6fd88d Reviewed-on: https://chromium-review.googlesource.com/c/1478898 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637252} .../core/exported/web_form_control_element.cc | 10 +++++--- .../renderer/core/exported/web_input_element.cc | 5 ++-- .../core/html/forms/checkbox_input_type.cc | 3 ++- .../forms/chooser_only_temporal_input_type_view.cc | 16 ++++++++----- .../html/forms/date_time_numeric_field_element.cc | 6 ++--- .../renderer/core/html/forms/html_input_element.cc | 5 ++-- .../renderer/core/html/forms/html_input_element.h | 27 +++++++++++++--------- .../core/html/forms/html_option_element.cc | 3 ++- .../core/html/forms/html_text_area_element.cc | 15 ++++++------ .../core/html/forms/html_text_area_element.h | 9 ++++---- .../blink/renderer/core/html/forms/input_type.cc | 20 +++++++++------- .../multiple_fields_temporal_input_type_view.cc | 19 +++++++++------ .../renderer/core/html/forms/radio_input_type.cc | 2 +- .../renderer/core/html/forms/range_input_type.cc | 3 ++- .../core/html/forms/text_control_element.cc | 3 ++- .../core/html/forms/text_control_element.h | 4 ++-- .../core/html/forms/text_field_input_type.cc | 8 +++---- .../blink/renderer/core/html/html_hr_element.cc | 3 ++- .../blink/renderer/core/html/html_slot_element.cc | 9 ++++---- .../renderer/core/html/parser/html_tree_builder.cc | 2 +- .../core/html/parser/text_resource_decoder.cc | 12 ++++++---- .../blink/renderer/core/html/track/vtt/vtt_cue.cc | 1 - .../blink/renderer/core/testing/internals.cc | 2 +- .../modules/accessibility/ax_layout_object.cc | 4 ++-- .../renderer/modules/accessibility/ax_slider.cc | 2 +- 25 files changed, 113 insertions(+), 80 deletions(-) commit 00e85f1bd0a1b4b7b48d47acf2f9ad11ff5ed124 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 11:00:16 2019 +0000 Roll src-internal 246fc71a449d..672eb32910a9 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/246fc71a449d..672eb32910a9 Created with: gclient setdep -r src-internal@672eb32910a9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc96e7f23e44db4623a557f454bcc4876140c829 Reviewed-on: https://chromium-review.googlesource.com/c/1498851 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637251} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8b5baf82d7a017fe90b2b38c0057d0c8ba19743a Author: Yi Su <mrsuyi@chromium.org> Date: Mon Mar 4 10:54:52 2019 +0000 Add test asserts for WebClient in plugin_placeholder_inttest. plugin_placeholder_inttest should also test that WebClient::GetPluginNotSupportedText is called and injected into web pages that contain unsupported plugins. Bug: 930859 Change-Id: Iab07fef5ad46b277dfa391f65b7e1f31066a2922 Reviewed-on: https://chromium-review.googlesource.com/c/1495553 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#637250} ios/web/plugin_placeholder_inttest.mm | 30 +++++++++++++++++++++++ ios/web/public/test/fakes/test_web_client.h | 11 +++++++++ ios/web/public/test/fakes/test_web_client.mm | 8 ++++++ ios/web/public/test/web_view_content_test_util.h | 8 ++++++ ios/web/public/test/web_view_content_test_util.mm | 9 +++++++ 5 files changed, 66 insertions(+) commit 65effbfafe348cdc4c14809befa796129c1491e6 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Mar 4 10:53:52 2019 +0000 [iOS] Moving the sync status from the account to Google services cell The Sync and Google services should display the sync status. The icon issue is tracked with crbug.com/889470 Sync is on: https://drive.google.com/open?id=1frODodgKMX-DDyAPKtTVPcmq84qA0bOG Sync is off: https://drive.google.com/open?id=1sWM0swx7DtpdoSJbFBe-SxFmlDVX-Q0R Sync error: https://drive.google.com/open?id=1O74am5izeFNWgTfNDNyOjYWk0DTla8YJ Setup in progress: https://drive.google.com/open?id=1B4QxvM6CmCrGkXHZC0vCuiB-xWZiL3WS Bug: 937326 Change-Id: I519b51de99ef28ba34351ac560d61d6a793f833b Reviewed-on: https://chromium-review.googlesource.com/c/1497003 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#637249} ios/chrome/app/strings/ios_strings.grd | 3 + ..._IOS_SIGN_IN_TO_CHROME_SETTING_SYNC_ON.png.sha1 | 1 + .../ui/settings/settings_table_view_controller.mm | 67 ++++++++++++++++++++-- 3 files changed, 65 insertions(+), 6 deletions(-) commit 091319dbcca5c32827b24e8f5ae1936191f765bd Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Mar 4 10:45:34 2019 +0000 Offline page without native page content This CL change the way offline pages are loaded in the webState. It uses the new WebState::LoadData to replace the current DOM with an offline version of the page without triggering a new navigation. The URL of the navigation is the online version of the page. This allow the online version to be loaded when reloading the page. Current known limitations: chrome:// url is visible (shortly) when loading an offline page (cl/1488924) Restoring an offline page shows a white page. (crbug.com/937304) Loading an offline page in place of a pending navigation is not handled correctly (crbug.com/936773). Bug: 929492 Change-Id: I6c9eb1513b6aa6b03a365e0d063af7e04ccaa15e Reviewed-on: https://chromium-review.googlesource.com/c/1421103 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#637248} ios/chrome/browser/BUILD.gn | 1 + ios/chrome/browser/about_flags.mm | 6 + ios/chrome/browser/ios_chrome_flag_descriptions.cc | 5 + ios/chrome/browser/ios_chrome_flag_descriptions.h | 5 + ios/chrome/browser/reading_list/BUILD.gn | 27 ++ .../browser/reading_list/data/distilled.html | 6 + ios/chrome/browser/reading_list/features.cc | 18 ++ ios/chrome/browser/reading_list/features.h | 20 ++ .../browser/reading_list/offline_page_tab_helper.h | 132 +++++++++ .../reading_list/offline_page_tab_helper.mm | 305 +++++++++++++++++++++ .../offline_page_tab_helper_unittest.mm | 175 ++++++++++++ ios/chrome/browser/tabs/tab_helper_util.mm | 9 +- ios/chrome/browser/ui/browser_view_controller.mm | 14 +- ios/chrome/browser/ui/location_bar/BUILD.gn | 1 + .../location_bar_model_delegate_ios.mm | 6 + ios/chrome/browser/ui/main/BUILD.gn | 1 + .../ui/page_info/page_info_legacy_coordinator.mm | 17 +- ios/chrome/browser/ui/page_info/page_info_model.cc | 26 +- ios/chrome/browser/ui/page_info/page_info_model.h | 4 +- .../ui/reading_list/reading_list_coordinator.mm | 5 +- .../browser/ui/reading_list/reading_list_egtest.mm | 51 +++- ios/chrome/browser/web/BUILD.gn | 1 + ios/chrome/browser/web/chrome_web_client.mm | 16 ++ .../browser/web/chrome_web_client_unittest.mm | 13 +- ios/web/public/test/fakes/test_web_state.h | 4 +- ios/web/public/test/fakes/test_web_state.mm | 19 +- 26 files changed, 854 insertions(+), 33 deletions(-) commit e3503c8fab53242f9a08adfa9fcac0974936702b Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Mar 4 10:38:16 2019 +0000 Revert "Fix HeadlessProtocolBrowserTest.VirtualTimeFetchStream" This reverts commit 08fba499563de61734514dae18d9ccd81bb66feb. Reason for revert: I misunderstood the test intention. See https://chromium-review.googlesource.com/c/chromium/src/+/1460577/16/headless/test/data/protocol/emulation/virtual-time-fetch-stream.js#33. Original change's description: > Fix HeadlessProtocolBrowserTest.VirtualTimeFetchStream > > The test calls 'fetch()' and waits for a request to finish. Strictly > speaking, the request may not complete unless you read the response > body. I'm going to land a change that makes the behavior more explicit, > so this CL fixes the test beforehand. > > Bug: 894819 > Change-Id: Id8edd93bcad47df2a1907892f231be094f789e02 > Reviewed-on: https://chromium-review.googlesource.com/c/1478325 > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634585} TBR=yhirano@chromium.org,caseq@chromium.org,skyostil@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894819 Change-Id: I749f97f4a3d335f002d47a784dce4826ef149c82 Reviewed-on: https://chromium-review.googlesource.com/c/1498265 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#637247} headless/test/data/protocol/emulation/virtual-time-fetch-stream.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f9de3103ef8ecfdba64c79b1141f355204e2089f Author: Leon Han <leon.han@intel.com> Date: Mon Mar 4 10:30:13 2019 +0000 [ServiceWorker] Apply provider hosts precreate/complete logic in tests Previously many tests are using SWProviderHost::Create() to prepare their provider hosts for navigations, which is inconsistent with production code logic now. After https://crrev.com/c/1480639, production code does not go the way of SWProviderHost::Create() for navigations, but always precreates a SW provider host then completes it on success of the navigation. This CL refactors all those tests to apply this precreate/complete logic, making it easier for testing work in https://crrev.com/c/1490770. BUG=931092,723502 Change-Id: I158d9af772a11150a3638969ee2027b6027d08b5 Reviewed-on: https://chromium-review.googlesource.com/c/1498697 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637246} .../service_worker/service_worker_browsertest.cc | 9 +-- .../service_worker_context_unittest.cc | 55 ++++++++-------- ...e_worker_controllee_request_handler_unittest.cc | 14 ++-- .../service_worker/service_worker_job_unittest.cc | 9 +-- .../service_worker_navigation_loader_unittest.cc | 9 ++- .../service_worker_object_host_unittest.cc | 26 ++++---- .../service_worker_provider_host_unittest.cc | 13 ++-- .../service_worker_registration_unittest.cc | 74 ++++++++-------------- .../service_worker_request_handler_unittest.cc | 16 ++--- .../service_worker_storage_unittest.cc | 25 ++++---- .../service_worker/service_worker_test_utils.cc | 13 ++-- .../service_worker/service_worker_test_utils.h | 3 +- .../service_worker_version_unittest.cc | 38 ++++++----- 13 files changed, 128 insertions(+), 176 deletions(-) commit 84a14c2a7cf540b23914247720763a0454a1cd7e Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Mon Mar 4 10:24:15 2019 +0000 Mark the Always Open PDFs externally to be a syncable pref. This will allow users to carry their settings choice between synced instances. BUG=935941 Change-Id: Iefc0aa1572138c9a40521d1f045dd2a534e01fc4 Reviewed-on: https://chromium-review.googlesource.com/c/1491313 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637245} chrome/browser/plugins/plugin_prefs_factory.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 475b7905fc4ec3baf28f108a42b4106c6e3dff85 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Mar 4 10:23:30 2019 +0000 Remove dead code from ProfileChooserView. Mirror and Account Management view are removed from desktop. All code dependent on it are removed from ProfileChooserView and supporting files. Bug: 934689 Change-Id: Id0071ee842077a4e3730c2cf55b33a8231521968 Reviewed-on: https://chromium-review.googlesource.com/c/1494885 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#637244} chrome/app/profiles_strings.grdp | 12 - chrome/browser/profiles/profile_window.cc | 3 - chrome/browser/signin/chrome_signin_helper.cc | 14 +- chrome/browser/ui/profile_chooser_constants.h | 4 - .../ui/views/profiles/profile_chooser_view.cc | 460 +-------------------- .../ui/views/profiles/profile_chooser_view.h | 33 -- 6 files changed, 14 insertions(+), 512 deletions(-) commit 680a38e672c04da7806d1b6f9450671fa924fe11 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Mar 4 10:23:10 2019 +0000 Update V8 to version 7.4.271. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e21801e6..d8b0d88d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia59c8b472b885e5b8a9a080d6b6a46e1ceb01a1f Reviewed-on: https://chromium-review.googlesource.com/c/1498696 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637243} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bade8660ed83112af91387f349565b4ea1922700 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Mon Mar 4 10:19:28 2019 +0000 fixup! OnionSoup: Move web_feature.mojom in public/platform to public/mojom It fixes OWNERS file for web_feature.mojom with removing SECURITY_OWNERS as it should get a review from blink/renderer/core/OWNERS. NOTRY=true Bug: 919393 Change-Id: I5612a069c615c4aaaad7208726a875a47deac501 Reviewed-on: https://chromium-review.googlesource.com/c/1498731 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#637242} third_party/blink/public/mojom/web_feature/OWNERS | 3 --- 1 file changed, 3 deletions(-) commit a6da33144f5efee3fa505ac06688eba5708c824a Author: Miyoung Shin <myid.shin@igalia.com> Date: Mon Mar 4 10:01:14 2019 +0000 Change short/uint16_t to int16_t in third_party/blink/core/events/mouse_event.h and the related codes - short -> int16_t for |button| getter/setter. - uint16_t -> int16_t in navigation_policy.cc in order to make a consistence - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I781e41e781a33368b4675d3b30c4bc0a39686c68 Reviewed-on: https://chromium-review.googlesource.com/c/1498262 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637241} third_party/blink/renderer/core/dom/node.cc | 6 +++--- .../blink/renderer/core/events/mouse_event.cc | 6 +++--- third_party/blink/renderer/core/events/mouse_event.h | 10 +++++----- .../blink/renderer/core/events/pointer_event.h | 2 +- .../renderer/core/events/pointer_event_factory.cc | 2 +- .../core/events/web_input_event_conversion.cc | 20 ++++++++++---------- .../blink/renderer/core/events/wheel_event.cc | 2 +- .../renderer/core/html/forms/html_input_element.cc | 4 ++-- .../renderer/core/html/forms/html_select_element.cc | 8 ++++---- .../renderer/core/html/forms/range_input_type.cc | 2 +- .../renderer/core/html/forms/slider_thumb_element.cc | 5 +++-- .../renderer/core/html/forms/spin_button_element.cc | 4 ++-- .../core/html/forms/text_control_inner_elements.cc | 2 +- .../blink/renderer/core/html/html_anchor_element.cc | 7 ++++--- .../blink/renderer/core/input/mouse_event_manager.cc | 2 +- .../blink/renderer/core/layout/layout_frame_set.cc | 6 +++--- .../blink/renderer/core/loader/navigation_policy.cc | 4 ++-- .../elements/media_control_timeline_element.cc | 2 +- 18 files changed, 48 insertions(+), 46 deletions(-) commit 88ae8f79b8c71836948cc32c079adf1e261d9196 Author: Miyoung Shin <myid.shin@igalia.com> Date: Mon Mar 4 09:58:16 2019 +0000 Change short to int16_t in third_party/blink/renderer/platform/wtf/typed_arrays/int16_array.h - short -> int16_t. - No logic changes. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929985 Change-Id: I1d5881f42f274770f1bd58c71ee7d09e2ca859f7 Reviewed-on: https://chromium-review.googlesource.com/c/1498802 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637240} .../platform/wtf/typed_arrays/int16_array.h | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 79feb7754d2cd8346e0a34beea6254eef9427655 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Mar 4 09:49:37 2019 +0000 [Sync::USS] Adding the flag to enable USS Passwords on iOS Bug: 902349 Change-Id: I442448227c0129438c6a3a1ef840080531a9f014 Reviewed-on: https://chromium-review.googlesource.com/c/1498871 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#637239} ios/chrome/browser/about_flags.mm | 4 ++++ ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ++++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 3 +++ 3 files changed, 11 insertions(+) commit dc69a90d2b199b5aa177d590c74203ea72530b40 Author: Jérôme Lebel <jlebel@chromium.org> Date: Mon Mar 4 09:40:35 2019 +0000 [iOS] Removing preload feature from Sync and Google services Since Unity doesn't turn on anymore preload pages feature when the user signs in, and since it is not related to Google services, preload pages feature should not be part of Sync and Google services screen. Bug: 925885 Change-Id: I815d4f59682a446e0574b61c60c23c59a4390e11 Reviewed-on: https://chromium-review.googlesource.com/c/1497951 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637238} ios/chrome/app/strings/ios_strings.grd | 6 ---- .../google_services_settings_egtest.mm | 4 --- .../google_services_settings_mediator.mm | 36 +--------------------- .../ui/settings/settings_table_view_controller.mm | 8 ++--- 4 files changed, 3 insertions(+), 51 deletions(-) commit 212ebb07a6b4051bbb09405bc0efdcb95b7ca428 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Mar 4 09:34:11 2019 +0000 [Mfill Android] Add white scrolling shadows to accessory bar This CL introduces scrolling shadows that indicate if additional items are available left or right of the current scroll position. Screenshot: https://photos.app.goo.gl/rG8vpdakFWad4vrJ9 (more in the bug) Bug: 934824 Change-Id: Ie7c9c2c3c1e35ca9770d07f06d828853fc40baf0 Reviewed-on: https://chromium-review.googlesource.com/c/1481293 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637237} .../android/java/res/layout/keyboard_accessory_modern.xml | 8 +++++--- .../java/res/layout/keyboard_accessory_suggestion.xml | 1 - chrome/android/java/res/values/dimens.xml | 1 + .../keyboard_accessory/KeyboardAccessoryCoordinator.java | 15 +-------------- .../keyboard_accessory/KeyboardAccessoryModernView.java | 11 +++++++---- .../keyboard_accessory/KeyboardAccessoryProperties.java | 10 ++++++++++ .../keyboard_accessory/KeyboardAccessoryViewBinder.java | 9 ++------- .../keyboard_accessory/KeyboardAccessoryViewTest.java | 11 +---------- 8 files changed, 27 insertions(+), 39 deletions(-) commit 6bdb263ca522ba42fdbd910769dcd869050d3d75 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Mon Mar 4 09:28:30 2019 +0000 [Android WebAPK] Make WebappDirectoryManager work with new-style WebAPKs For new-style WebAPKs, the WebAPK-provided splash screen is at the root of the activity, not WebApkActivity. This causes new-style WebAPK tasks not to show up in the ActivityManager#getAppTasks() call. This CL prevents webapp directories from being deleted if they belong to an installed WebAPK. BUG=894610 TEST=WebappDirectoryManagerTest#testDeletesDirectoriesForUninstalledWebApks() Change-Id: Iaa2168101d91ac670fd27ed7c868a74deb9e2798 Reviewed-on: https://chromium-review.googlesource.com/c/1485498 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637236} .../browser/webapps/WebappDirectoryManager.java | 27 ++++++++++++++++++++-- .../webapps/WebappDirectoryManagerTest.java | 27 +++++++++++++--------- 2 files changed, 41 insertions(+), 13 deletions(-) commit f2509ce5d44141edd66ff8197139c00992596aeb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 09:27:27 2019 +0000 Roll src/third_party/depot_tools da4dbf85f950..8f418985f120 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/da4dbf85f950..8f418985f120 git log da4dbf85f950..8f418985f120 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@8f418985f120 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I023517937791a3a2160bc8b8cc21fe544a0e42f7 Reviewed-on: https://chromium-review.googlesource.com/c/1498852 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637235} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cb1282e798e656b1b25860a1eaa267f073966870 Author: Justin Cohen <justincohen@google.com> Date: Mon Mar 4 09:27:22 2019 +0000 [ios] Ignore NTP omnibox progress updates when the NTP isn't visible. If two tabs are quickly opened one after another, an NTP and a web page, the NTP may make some delegate calls after it's been hidden and the web page made visible. Ignore these delegate calls. Bug: 934296 Change-Id: Idb75e240a86e09c31011d53dabdd67e99d9f7128 Reviewed-on: https://chromium-review.googlesource.com/c/1496311 Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#637234} ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm | 4 ++++ 1 file changed, 4 insertions(+) commit 6b16f53c3b368d4b20c3b3feeafa98dabaff5d72 Author: Wei Lee <wtlee@google.com> Date: Mon Mar 4 09:22:37 2019 +0000 Add hotkeys to launch dev-tool for Chrome Camera App This CL adds hotkeys to launch dev-tool by methods provided by FileManager Private API. Test: Tested on CCA and the hotkeys work. Change-Id: I1169215f7040f450731ab44bf789652c904a8443 Reviewed-on: https://chromium-review.googlesource.com/c/1491292 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637233} .../resources/chromeos/camera/src/js/nav.js | 29 ++++++++++++++++------ 1 file changed, 21 insertions(+), 8 deletions(-) commit 59dc76bd60741f5b0e78a1affc90e7a72a337111 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Mar 4 09:15:08 2019 +0000 [Android][Tests] Move autofill integration test to keyboard_accessory/ This CL moves the test covering the integration of autofill suggestions into the keyboard accessory into the subfolder keyboard_accessory. This has two reasons: - fhorschig@ is OWNER of these tests - consistent location amongst all accessory integration tests Bug: None Change-Id: Ia0a1d8b8ac6dbfc491e737a020f124f2f558351a Reviewed-on: https://chromium-review.googlesource.com/c/1477683 Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637232} chrome/android/java_sources.gni | 2 +- .../AutofillKeyboardAccessoryIntegrationTest.java | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) commit 4332b16d45964df5d003d76d5dcd7ac2c29c62b4 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 08:58:52 2019 +0000 service worker: Remove kServiceWorkerServicification feature. The non-servicified code path is no longer supported. This CL also removes parameterized tests on network service only, since we have bots that provide that test coverage. Bug: 926114 Change-Id: I0165692985e7ae0740c1d03578474f3c0b6f10fc Reviewed-on: https://chromium-review.googlesource.com/c/1498799 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637231} .../browser/chrome_service_worker_browsertest.cc | 36 ++--------------- .../loader/cors_origin_access_list_browsertest.cc | 7 +--- .../browser/frame_host/render_frame_host_impl.cc | 7 +--- .../browser/loader/cors_file_origin_browsertest.cc | 6 +-- .../browser/loader/prefetch_url_loader_service.cc | 4 -- .../loader/resource_dispatcher_host_unittest.cc | 16 ++------ .../embedded_worker_instance_unittest.cc | 13 +------ .../service_worker_file_upload_browsertest.cc | 36 ++++------------- .../service_worker_provider_host_unittest.cc | 18 --------- ...ervice_worker_script_loader_factory_unittest.cc | 5 --- .../service_worker_tls_browsertest.cc | 41 ++------------------ content/browser/worker_host/shared_worker_host.cc | 14 +------ content/public/test/url_loader_interceptor.cc | 45 +++++++++------------- third_party/blink/common/features.cc | 5 --- third_party/blink/public/common/features.h | 1 - 15 files changed, 42 insertions(+), 212 deletions(-) commit 6593d92993dc7412966436589409a542d8bfb75d Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 08:58:02 2019 +0000 service worker: Removed unused weak ptr for EmbeddedWorkerTestHelper. Trivial cleanup. Bug: 937731 Change-Id: I08e77724aa51faf2f54ff490f3733335d753c447 Reviewed-on: https://chromium-review.googlesource.com/c/1498796 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637230} content/browser/service_worker/embedded_worker_test_helper.cc | 3 +-- content/browser/service_worker/embedded_worker_test_helper.h | 9 +-------- 2 files changed, 2 insertions(+), 10 deletions(-) commit f2b1b1af4670a9078ea8b2d27caabad2acc00188 Author: Alan Cutter <alancutter@chromium.org> Date: Mon Mar 4 08:48:11 2019 +0000 Make '/' focus search bar in History, Bookmarks, Downloads and Settings This CL adds '/' as a keyboard shortcut for focusing the search bar similar to ctrl+f in WebUI. This CL also adds an isTextInputElement() helper function. Bug: 934615 Change-Id: I20056d31475dd8ae94d0f1f9c5f59120a78232c9 Reviewed-on: https://chromium-review.googlesource.com/c/1496396 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#637229} chrome/browser/resources/bookmarks/dnd_manager.js | 4 ++-- .../webui/find_shortcut_behavior_browsertest.js | 7 +++++-- .../test/data/webui/find_shortcut_behavior_test.js | 22 ++++++++++++++++++---- ui/webui/resources/js/find_shortcut_behavior.js | 13 +++++++++---- ui/webui/resources/js/util.js | 8 ++++++++ 5 files changed, 42 insertions(+), 12 deletions(-) commit 1fe69aa1c7ee817bf7d1018c5c48914f2f66f837 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Mar 4 08:42:39 2019 +0000 Implement MemoryFileStreamReader. To continue implementation of in memory file system for incognito mode, MemoryFileStreamReader is implemented to use ObfuscatedFileUtilMemoryDelegate for reading from an in-memory file. Bug: 93417 Change-Id: I3bc460344adf66aaf3644e8ce82b98f14ee8ff31 Reviewed-on: https://chromium-review.googlesource.com/c/1488920 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#637228} storage/browser/BUILD.gn | 3 + .../fileapi/file_stream_reader_test_utils.cc | 41 ++++ .../fileapi/file_stream_reader_test_utils.h | 24 ++ .../file_system_file_stream_reader_unittest.cc | 25 +-- .../fileapi/local_file_stream_reader_unittest.cc | 24 +- .../browser/fileapi/memory_file_stream_reader.cc | 57 +++-- .../browser/fileapi/memory_file_stream_reader.h | 4 + .../fileapi/memory_file_stream_reader_unittest.cc | 250 +++++++++++++++++++++ .../obfuscated_file_util_memory_delegate.cc | 39 ++++ .../fileapi/obfuscated_file_util_memory_delegate.h | 12 + 10 files changed, 417 insertions(+), 62 deletions(-) commit dcfa8d6f60cf9bc3d2857e7661972367135a5b7e Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 4 08:41:45 2019 +0000 service worker: Return true in IsServicificationEnabled(). The non-servicified code path is no longer supported. This is the next step toward removing it. This CL also removes some tests that only worked when kServiceWorkerServicification was disabled. That code path can no longer be taken, so the tests would fail. The Signed Exchange tests were testing the combinations of of ServiceWorkerServicification + NetworkService; this can be removed now that we only need to test NetworkService on or off, and there are dedicated bots on the CQ for that. Bug: 926114 Change-Id: I5691139d045615dc463a8bf09f48186c5c6cd270 Reviewed-on: https://chromium-review.googlesource.com/c/1496268 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#637227} ...vice_worker_context_request_handler_unittest.cc | 499 ------- ...e_worker_controllee_request_handler_unittest.cc | 161 +-- .../service_worker_url_request_job_unittest.cc | 1418 -------------------- .../signed_exchange_request_handler_browsertest.cc | 105 +- content/test/BUILD.gn | 2 - .../common/service_worker/service_worker_utils.cc | 5 +- .../common/service_worker/service_worker_utils.h | 4 +- 7 files changed, 27 insertions(+), 2167 deletions(-) commit 97211c4baf455114533b6d6de662fe946b293bce Author: Marc Treib <treib@chromium.org> Date: Mon Mar 4 08:40:06 2019 +0000 Cleanup dependencies and includes in ProfileSyncServiceFactory Bug: none Change-Id: I926ca4d9cec0ed6705d5e7c3fac408be09a3d1a8 Reviewed-on: https://chromium-review.googlesource.com/c/1482973 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637226} .../browser/sync/profile_sync_service_factory.cc | 24 ++++++---------------- 1 file changed, 6 insertions(+), 18 deletions(-) commit e3e59957ecec69e65ab13e5f8425d33156dabef7 Author: wutao <wutao@chromium.org> Date: Mon Mar 4 08:39:04 2019 +0000 app_list: Assistant page to peeking when clicking scrim When tapping on scrim from half launcher it minimizes to peeking from the Assistant page view, which makes it behave like search page view. Bug: 924624 Test: manual Change-Id: I659b63b54af17be1743dfd7f980d3aa2aa47f735 Reviewed-on: https://chromium-review.googlesource.com/c/1496756 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637225} ash/app_list/views/app_list_view.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) commit a6af5038e9ab92abf032ea54c856345ed096613c Author: wutao <wutao@chromium.org> Date: Mon Mar 4 08:38:59 2019 +0000 app_list: Start Assistant in half or full state This patch fixes a bug to start Assistant view page with full launcher. If we are already in full launcher, do not need to set to half launcher. Bug: 924624 Test: manual Change-Id: I1827fa73ea850d374a4b114b137bad4a3c91a3e1 Reviewed-on: https://chromium-review.googlesource.com/c/1497176 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637224} ash/app_list/app_list_controller_impl.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit dde920ad5694f73f5b1e0f352ab0dba76bcd055b Author: Kent Tamura <tkent@chromium.org> Date: Mon Mar 4 08:36:51 2019 +0000 Remove unnecessary blink:: in renderer/core/editing We have bunch of "Trace(blink::Visitor*" in Blink though their classes are also in blink namespace. This CL removes a part of such unnecessary blink::. This CL has no behavior changes. This CL was produced by the following command on zsh: % for i in **/*.{h,cc}; sed -i "" -e "s/Trace(blink::/Trace(/g" $i Change-Id: I6e65139e738afb939b70d23a845221b9fa0f7300 Reviewed-on: https://chromium-review.googlesource.com/c/1498801 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#637223} .../renderer/core/editing/commands/append_node_command.cc | 2 +- .../renderer/core/editing/commands/append_node_command.h | 2 +- .../renderer/core/editing/commands/apply_style_command.cc | 4 ++-- .../renderer/core/editing/commands/apply_style_command.h | 2 +- .../renderer/core/editing/commands/composite_edit_command.cc | 2 +- .../renderer/core/editing/commands/composite_edit_command.h | 2 +- .../core/editing/commands/delete_from_text_node_command.cc | 2 +- .../core/editing/commands/delete_from_text_node_command.h | 2 +- .../core/editing/commands/delete_selection_command.cc | 2 +- .../core/editing/commands/delete_selection_command.h | 2 +- .../blink/renderer/core/editing/commands/edit_command.cc | 2 +- .../blink/renderer/core/editing/commands/edit_command.h | 2 +- .../core/editing/commands/insert_into_text_node_command.cc | 2 +- .../core/editing/commands/insert_into_text_node_command.h | 2 +- .../renderer/core/editing/commands/insert_list_command.cc | 2 +- .../renderer/core/editing/commands/insert_list_command.h | 2 +- .../core/editing/commands/insert_node_before_command.cc | 2 +- .../core/editing/commands/insert_node_before_command.h | 2 +- .../editing/commands/insert_paragraph_separator_command.cc | 2 +- .../editing/commands/insert_paragraph_separator_command.h | 2 +- .../editing/commands/merge_identical_elements_command.cc | 2 +- .../core/editing/commands/merge_identical_elements_command.h | 2 +- .../core/editing/commands/remove_css_property_command.cc | 2 +- .../core/editing/commands/remove_css_property_command.h | 2 +- .../renderer/core/editing/commands/remove_node_command.cc | 2 +- .../renderer/core/editing/commands/remove_node_command.h | 2 +- .../commands/remove_node_preserving_children_command.cc | 2 +- .../commands/remove_node_preserving_children_command.h | 2 +- .../core/editing/commands/replace_node_with_span_command.cc | 2 +- .../core/editing/commands/replace_node_with_span_command.h | 2 +- .../core/editing/commands/replace_selection_command.cc | 2 +- .../core/editing/commands/replace_selection_command.h | 2 +- .../core/editing/commands/selection_for_undo_step.cc | 4 ++-- .../renderer/core/editing/commands/selection_for_undo_step.h | 4 ++-- .../core/editing/commands/set_character_data_command.cc | 2 +- .../core/editing/commands/set_character_data_command.h | 2 +- .../core/editing/commands/set_node_attribute_command.cc | 2 +- .../core/editing/commands/set_node_attribute_command.h | 2 +- .../core/editing/commands/simplify_markup_command.cc | 2 +- .../renderer/core/editing/commands/simplify_markup_command.h | 2 +- .../renderer/core/editing/commands/split_element_command.cc | 2 +- .../renderer/core/editing/commands/split_element_command.h | 2 +- .../core/editing/commands/split_text_node_command.cc | 2 +- .../renderer/core/editing/commands/split_text_node_command.h | 2 +- .../commands/split_text_node_containing_element_command.cc | 2 +- .../commands/split_text_node_containing_element_command.h | 2 +- .../blink/renderer/core/editing/commands/undo_stack.cc | 2 +- .../blink/renderer/core/editing/commands/undo_stack.h | 2 +- .../blink/renderer/core/editing/commands/undo_step.cc | 2 +- third_party/blink/renderer/core/editing/commands/undo_step.h | 2 +- .../editing/commands/wrap_contents_in_dummy_span_command.cc | 2 +- .../editing/commands/wrap_contents_in_dummy_span_command.h | 2 +- third_party/blink/renderer/core/editing/dom_selection.cc | 2 +- third_party/blink/renderer/core/editing/dom_selection.h | 2 +- third_party/blink/renderer/core/editing/drag_caret.cc | 2 +- third_party/blink/renderer/core/editing/drag_caret.h | 2 +- third_party/blink/renderer/core/editing/editing_style.cc | 12 +++++------- third_party/blink/renderer/core/editing/editing_style.h | 2 +- third_party/blink/renderer/core/editing/editor.cc | 2 +- third_party/blink/renderer/core/editing/editor.h | 2 +- .../blink/renderer/core/editing/finder/text_finder.cc | 4 ++-- third_party/blink/renderer/core/editing/finder/text_finder.h | 4 ++-- third_party/blink/renderer/core/editing/frame_caret.cc | 2 +- third_party/blink/renderer/core/editing/frame_caret.h | 2 +- third_party/blink/renderer/core/editing/frame_selection.cc | 2 +- third_party/blink/renderer/core/editing/frame_selection.h | 2 +- .../renderer/core/editing/ime/input_method_controller.cc | 2 +- .../renderer/core/editing/ime/input_method_controller.h | 2 +- third_party/blink/renderer/core/editing/layout_selection.cc | 2 +- third_party/blink/renderer/core/editing/layout_selection.h | 2 +- .../editing/markers/active_suggestion_marker_list_impl.cc | 2 +- .../editing/markers/active_suggestion_marker_list_impl.h | 2 +- .../core/editing/markers/composition_marker_list_impl.cc | 2 +- .../core/editing/markers/composition_marker_list_impl.h | 2 +- .../blink/renderer/core/editing/markers/document_marker.h | 2 +- .../core/editing/markers/document_marker_controller.cc | 2 +- .../core/editing/markers/document_marker_controller.h | 2 +- .../renderer/core/editing/markers/document_marker_list.h | 2 +- .../core/editing/markers/spell_check_marker_list_impl.cc | 2 +- .../core/editing/markers/spell_check_marker_list_impl.h | 2 +- .../core/editing/markers/suggestion_marker_list_impl.cc | 2 +- .../core/editing/markers/suggestion_marker_list_impl.h | 2 +- .../core/editing/markers/text_match_marker_list_impl.cc | 2 +- .../core/editing/markers/text_match_marker_list_impl.h | 2 +- third_party/blink/renderer/core/editing/position.cc | 2 +- third_party/blink/renderer/core/editing/position.h | 2 +- .../blink/renderer/core/editing/position_with_affinity.cc | 2 +- .../blink/renderer/core/editing/position_with_affinity.h | 2 +- .../blink/renderer/core/editing/reveal_selection_scope.cc | 2 +- .../blink/renderer/core/editing/reveal_selection_scope.h | 2 +- .../blink/renderer/core/editing/selection_controller.cc | 2 +- .../blink/renderer/core/editing/selection_controller.h | 2 +- third_party/blink/renderer/core/editing/selection_editor.cc | 2 +- third_party/blink/renderer/core/editing/selection_editor.h | 2 +- .../blink/renderer/core/editing/selection_template.cc | 2 +- third_party/blink/renderer/core/editing/selection_template.h | 4 ++-- .../blink/renderer/core/editing/serializers/serialization.cc | 2 +- .../editing/spellcheck/cold_mode_spell_check_requester.cc | 2 +- .../editing/spellcheck/cold_mode_spell_check_requester.h | 2 +- .../core/editing/spellcheck/idle_spell_check_controller.cc | 4 ++-- .../core/editing/spellcheck/idle_spell_check_controller.h | 2 +- .../core/editing/spellcheck/spell_check_requester.cc | 4 ++-- .../renderer/core/editing/spellcheck/spell_check_requester.h | 4 ++-- .../blink/renderer/core/editing/spellcheck/spell_checker.cc | 2 +- .../blink/renderer/core/editing/spellcheck/spell_checker.h | 2 +- .../core/editing/suggestion/text_suggestion_controller.cc | 2 +- .../core/editing/suggestion/text_suggestion_controller.h | 2 +- third_party/blink/renderer/core/editing/visible_position.cc | 2 +- third_party/blink/renderer/core/editing/visible_position.h | 2 +- third_party/blink/renderer/core/editing/visible_selection.cc | 2 +- third_party/blink/renderer/core/editing/visible_selection.h | 2 +- 111 files changed, 124 insertions(+), 126 deletions(-) commit 3897026e3f23b958feb4b523dbea296edbdeb10e Author: Kenneth Russell <kbr@chromium.org> Date: Mon Mar 4 08:15:45 2019 +0000 Print the actual GL error (in hex) with --generate-dchecks. This makes the error messages much more useful. Bug: 930479 Change-Id: I2066fd0de00f75ac3c50f8abbe3579403ff1bfe0 Reviewed-on: https://chromium-review.googlesource.com/c/1498729 Auto-Submit: Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#637222} ui/gl/generate_bindings.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit d41d396307fcfdf0df3c60495a447228b90be947 Author: Kenneth Russell <kbr@chromium.org> Date: Mon Mar 4 08:15:25 2019 +0000 Bind a clean vertex array object in YUVToRGBConverter. This class and the GLHelper underneath it save and restore a minimal amount of context state. Application code may have changed much vertex attribute state, including vertex attribute divisors on other vertex attributes, which can cause GL_INVALID_OPERATION during the DrawArrays this class performs. Avoid interference by saving and restoring the bound vertex array object. Bug: 930479 Change-Id: I5f21335aefe321c8faf87a968c7caeba7060f66a Reviewed-on: https://chromium-review.googlesource.com/c/1498728 Auto-Submit: Kenneth Russell <kbr@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#637221} ui/gl/yuv_to_rgb_converter.cc | 20 ++++++++++++++++++++ ui/gl/yuv_to_rgb_converter.h | 1 + 2 files changed, 21 insertions(+) commit d2500f5f2f248428da11c262642593ae73fa5718 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 08:01:32 2019 +0000 Roll src-internal cbe8756f8a6d..246fc71a449d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cbe8756f8a6d..246fc71a449d Created with: gclient setdep -r src-internal@246fc71a449d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie976caf72c66750ab698e7b0a990e0d31762fa59 Reviewed-on: https://chromium-review.googlesource.com/c/1498730 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637220} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 654f1f19fd508e94b471feddcc335111f7da2a54 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Mar 4 07:19:03 2019 +0000 Update V8 to version 7.4.270. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c7724d93..e21801e6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I079d1f026fd35263d310ca0d6c1112d3bda46e41 Reviewed-on: https://chromium-review.googlesource.com/c/1498725 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637219} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 978babf67e5d36e36124a713d7ab763f2eb225d7 Author: Ramin Halavati <rhalavati@chromium.org> Date: Mon Mar 4 07:05:12 2019 +0000 Implement ObfuscatedFileUtilMemoryDelegate. ObfuscatedFileUtilMemoryDelegate is implemented to creates an in-memory support for files and directories creation, access, modification, and removal. Bug: 93417 Change-Id: I1b9c391efa8b2ca17c3605ec093de2467462e1d0 Reviewed-on: https://chromium-review.googlesource.com/c/1459550 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#637218} storage/browser/BUILD.gn | 1 + storage/browser/fileapi/obfuscated_file_util.cc | 3 +- .../obfuscated_file_util_memory_delegate.cc | 392 ++++++++++-- .../fileapi/obfuscated_file_util_memory_delegate.h | 48 +- ...bfuscated_file_util_memory_delegate_unittest.cc | 656 +++++++++++++++++++++ 5 files changed, 1045 insertions(+), 55 deletions(-) commit a8d8af6326bbf3e782a2f2fab2f1eab2dd1585ff Author: Kent Tamura <tkent@chromium.org> Date: Mon Mar 4 07:02:12 2019 +0000 Deprecate unimplemented -webkit-appearance keywords This CL deprecate the following keywords: * button-bevel * caret * listitem * media-controls-background * media-controls-fullscreen-background * media-current-time-display * media-enter-fullscreen-button * media-exit-fullscreen-button * media-mute-button * media-overlay-play-button * media-play-button * media-time-remaining-display * media-toggle-closed-captions-button * media-volume-slider-container * menulist-textfield * menulist-text * progress-bar-value Because they have no special painting code. We show deprecation messages for them on CSS parsing time, not painting time because unused style rules might be used in the future. * legacyMediaControls.css Change deprecated keywords to 'none'. Because the deprecated keywords don't have painting code, 'none' doesn't change behavior. * outdent-collapse-table-crash.html Change a deprecated keyword to a live one. * video-webkit-appearance.html It was created when we had special painting code for media-play-button. It doesn't make sense now. Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ldH_uIfk_QE Bug: 936301 Change-Id: Ic4136e8374cb9a03329cdef2aac248534881a3ee Reviewed-on: https://chromium-review.googlesource.com/c/1496120 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637217} .../public/mojom/web_feature/web_feature.mojom | 16 +++++++++ .../core/css/parser/css_property_parser_helpers.cc | 41 ++++++++++++++++++++++ .../blink/renderer/core/frame/deprecation.cc | 35 ++++++++++++++++++ .../resources/legacyMediaControls.css | 6 ++-- .../execCommand/outdent-collapse-table-crash.html | 2 +- .../media/video-webkit-appearance-expected.html | 14 -------- .../web_tests/media/video-webkit-appearance.html | 19 ---------- tools/metrics/histograms/enums.xml | 17 +++++++++ 8 files changed, 113 insertions(+), 37 deletions(-) commit 375b08bdc8b63b243dc4a6e06ae5fac7753be0a8 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 06:59:52 2019 +0000 Roll src-internal 50cfd59a72c7..cbe8756f8a6d (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/50cfd59a72c7..cbe8756f8a6d Created with: gclient setdep -r src-internal@cbe8756f8a6d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I007fe87afd94ae25e9810b938396c0b5b7e01118 Reviewed-on: https://chromium-review.googlesource.com/c/1498726 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637216} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 99110588c46a)