Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 43037 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919879430357573920 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itUo0o20/luci_context.159999196 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2227-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43638eb56d7df111 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 4229a4b64d6aefedf3754f0fa25813b408e82e29 Roll src/third_party/angle 0e1ce2e55387..d838178daa49 (1 commits) chromium-autoroll, Mon Mar 4 22:01:22 2019 +0000 5f4da20233e57a523484d35c985cdd554fa6f0bb Extend expiry of Autofill.HadUser...ServerCards histogram to M75. sebsg, Mon Mar 4 22:01:10 2019 +0000 c4832d9af1bc3eac9b79e73b1dc95e96ebf138d5 Mark http/tests/devtools/cache-storage/cache-data.js as flaky on win7 rel Yi Gu, Mon Mar 4 21:59:31 2019 +0000 9b0e864f2201ad7cff444c501ca0085105b47471 Roll src/third_party/glslang/src d90d548161bc..9390154c557e (1 commits) chromium-autoroll, Mon Mar 4 21:52:28 2019 +0000 95bd98e0414c8d6fbddedb09ad40dcd6db3dc306 Avoid an early start up crash in base::win::OSInfo. Lei Zhang, Mon Mar 4 21:41:38 2019 +0000 a35ca854f381f05628588f5e231a50588b02bcff [Cronet] Add lock annotations to Cronet_EngineImpl. Caleb Raitto, Mon Mar 4 21:40:09 2019 +0000 6480f2d375c7ce1a55d326a0bdfe8243a6d5538e Fix asymmetric key proofs in CryptAuth v2 Enrollment Josh Nohle, Mon Mar 4 21:34:16 2019 +0000 b6f050cf85645a9c5a2db2c22dc422da4aca94ed some of skiped tests are re-enabled behdad, Mon Mar 4 21:33:37 2019 +0000 e2778c7e695fcde4c82290a63452c3fb416e31e3 Remove usage of iterators during fork() or in signal handlers Tom Anderson, Mon Mar 4 21:32:43 2019 +0000 bcfbe77f97fecb9fcb48736e2fba6034c42ffbd8 Android: Move media_router directories Peter Wen, Mon Mar 4 21:30:20 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 4229a4b64d6aefedf3754f0fa25813b408e82e29 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 22:01:22 2019 +0000 Roll src/third_party/angle 0e1ce2e55387..d838178daa49 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/0e1ce2e55387..d838178daa49 git log 0e1ce2e55387..d838178daa49 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 syoussefi@chromium.org Vulkan: Rename vk::Shared* to vk::RefCounted* Created with: gclient setdep -r src/third_party/angle@d838178daa49 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie9e318128050a452fed584e10cce45bfb6f0a404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499918 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637436} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5f4da20233e57a523484d35c985cdd554fa6f0bb Author: sebsg <sebsg@chromium.org> Date: Mon Mar 4 22:01:10 2019 +0000 Extend expiry of Autofill.HadUser...ServerCards histogram to M75. We are currently experimenting with it, but extending just in case we need it for one more version. Bug: 930911 Change-Id: I6f3d3ec5bbb7fdac66cd9b388dc4ab5c82805b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499957 Auto-Submit: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637435} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c4832d9af1bc3eac9b79e73b1dc95e96ebf138d5 Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 21:59:31 2019 +0000 Mark http/tests/devtools/cache-storage/cache-data.js as flaky on win7 rel This test has been flaky for a while: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXgsSBUZsYWtlIlNjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBodHRwL3Rlc3RzL2RldnRvb2xzL2NhY2hlLXN0b3JhZ2UvY2FjaGUtZGF0YS5qcww Here is the dashboard for reference: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Fcache-storage%2Fcache-data.js TBR=hhli@chromium.org NOTRY=true Bug: 937991 Change-Id: Ic45d807546ae182557e44c271d99db55c6d782d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500601 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637434} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 9b0e864f2201ad7cff444c501ca0085105b47471 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 21:52:28 2019 +0000 Roll src/third_party/glslang/src d90d548161bc..9390154c557e (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/d90d548161bc..9390154c557e git log d90d548161bc..9390154c557e --date=short --no-merges --format='%ad %ae %s' 2019-03-04 johnkslang@users.noreply.github.com Merge pull request #1699 from jeffbolznv/buffer_reference_fold Created with: gclient setdep -r src/third_party/glslang/src@9390154c557e The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic6715a5e57435825a230ed53b056fa26d4d8d588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500313 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637433} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 95bd98e0414c8d6fbddedb09ad40dcd6db3dc306 Author: Lei Zhang <thestig@chromium.org> Date: Mon Mar 4 21:41:38 2019 +0000 Avoid an early start up crash in base::win::OSInfo. r633961 tries to get the system architecture in Crashpad code. This gets called very early during process start up and relies on base::win::OSInfo. base::win::OSInfo gathers many different pieces of information about the OS, but crashes as used from Crashpad, possibly because of Windows registry access in a sandboxed process. Avoid this issue by splitting base::win::OSInfo::architecture() out into a static GetArchitecture() method. GetArchitecture() does the minimal amount of work necessary to get the system architecture. BUG=937840 Change-Id: I174ef78494dcf804f8f4bb1e3a7a25d9c0e37c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499730 Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637432} base/system/sys_info_win.cc | 3 +-- base/win/windows_version.cc | 36 +++++++++++++++++++++++------------- base/win/windows_version.h | 16 ++++++++++------ 3 files changed, 34 insertions(+), 21 deletions(-) commit a35ca854f381f05628588f5e231a50588b02bcff Author: Caleb Raitto <caraitto@chromium.org> Date: Mon Mar 4 21:40:09 2019 +0000 [Cronet] Add lock annotations to Cronet_EngineImpl. Change-Id: I95de00d498aca200c06495c648b8f8e454344aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495867 Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#637431} components/cronet/native/engine.cc | 12 +++++++----- components/cronet/native/engine.h | 15 +++++++++------ 2 files changed, 16 insertions(+), 11 deletions(-) commit 6480f2d375c7ce1a55d326a0bdfe8243a6d5538e Author: Josh Nohle <nohle@google.com> Date: Mon Mar 4 21:34:16 2019 +0000 Fix asymmetric key proofs in CryptAuth v2 Enrollment CryptAuth expects standard ECDSA signatures as key proofs for new asymmetric keys. The previous version of CryptAuthKeyProofComputerImpl assumed that the proof should be a signed, unencrypted, and serialized SecureMessage proto. This was incorrect, and EnrollKeys requests failed due to invalid-key-proof exceptions being thrown by the CryptAuth server. We verified that invalid-key-proof exceptions were not thrown with the new implementation in this CL. Because the new asymmetric and existing symmetric key proof implementations only rely on standard crypto operations that are available as synchronous functions in Chromium, we do not use the SecureMessage delegate anymore. As a result, the key proof computer class is now synchronous. CryptAuthV2Enroller and FakeCryptAuthKeyComputer were updated accordingly. Bug: 899080 Change-Id: Id008b7c08c2f98c42809438b2f6f3ff44968dd13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498273 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#637430} .../device_sync/cryptauth_enrollment_result.cc | 6 +- .../device_sync/cryptauth_enrollment_result.h | 4 +- .../device_sync/cryptauth_key_proof_computer.h | 59 ++--- .../cryptauth_key_proof_computer_impl.cc | 141 +++++----- .../cryptauth_key_proof_computer_impl.h | 45 ++-- .../cryptauth_key_proof_computer_impl_unittest.cc | 290 +++++++++++---------- .../device_sync/cryptauth_v2_enroller_impl.cc | 85 +++--- .../device_sync/cryptauth_v2_enroller_impl.h | 17 +- .../cryptauth_v2_enroller_impl_unittest.cc | 104 ++++---- .../fake_cryptauth_key_proof_computer.cc | 25 +- .../fake_cryptauth_key_proof_computer.h | 25 +- 11 files changed, 375 insertions(+), 426 deletions(-) commit b6f050cf85645a9c5a2db2c22dc422da4aca94ed Author: behdad <behdadb@chromium.org> Date: Mon Mar 4 21:33:37 2019 +0000 some of skiped tests are re-enabled Bug: chromium:936166 Change-Id: I47f75063003f8651e0a45fe84385f1a6fe6366b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490219 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637429} tools/perf/expectations.config | 7 ------- 1 file changed, 7 deletions(-) commit e2778c7e695fcde4c82290a63452c3fb416e31e3 Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Mar 4 21:32:43 2019 +0000 Remove usage of iterators during fork() or in signal handlers When using libc++ debug iterators (_LIBCPP_DEBUG=1), iterators grab a lock, so cannot be used in certain contexts. This CL removes usage of iterators in some cases. base/process/launch_posix.cc used to take care to support debug iterators, but this was bulldozed by clang-tidy modernize-loop-convert in [1], so this CL also adds NOLINTNEXTLINE(modernize-loop-convert). [1] https://chromium.googlesource.com/chromium/src/+/6c6229357b371e0617bd9fcdaa0b17c92cc992f4%5E%21/#F15 BUG=923166 R=thakis Change-Id: Ic62ad08878fc2f21cff9cb6d7ed25b30f7385a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500032 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637428} base/debug/stack_trace_posix.cc | 8 ++++---- base/process/launch_posix.cc | 5 ++++- 2 files changed, 8 insertions(+), 5 deletions(-) commit bcfbe77f97fecb9fcb48736e2fba6034c42ffbd8 Author: Peter Wen <wnwen@chromium.org> Date: Mon Mar 4 21:30:20 2019 +0000 Android: Move media_router directories This standardizes resource, string, and source code directory structures across features and the top level chrome_java target. The reason we went with java/res and java/strings is because there may be additional resources and strings that are for test only. i.e. javatests/res, javatests/strings. Thus it makes sense to have a java/src folder to contain the actual source code. This is also the existing directory structure under ui/android and chrome/android. Bug: 846440 Change-Id: I6e6fdbb654cb844406bd91f16a7a5a1b20038be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500029 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637427} chrome/android/BUILD.gn | 8 +- chrome/android/features/media_router/BUILD.gn | 127 ++++++++++----------- .../res/drawable-hdpi/cast_playing_square.png | Bin .../res/drawable-hdpi/ic_cast_dark_off.png | Bin .../res/drawable-hdpi/ic_cast_dark_on.png | Bin .../drawable-hdpi/ic_notification_media_route.png | Bin .../res/drawable-mdpi/cast_playing_square.png | Bin .../res/drawable-mdpi/ic_cast_dark_off.png | Bin .../res/drawable-mdpi/ic_cast_dark_on.png | Bin .../drawable-mdpi/ic_notification_media_route.png | Bin .../res/drawable-xhdpi/cast_playing_square.png | Bin .../res/drawable-xhdpi/ic_cast_dark_off.png | Bin .../res/drawable-xhdpi/ic_cast_dark_on.png | Bin .../drawable-xhdpi/ic_notification_media_route.png | Bin .../res/drawable-xxhdpi/cast_playing_square.png | Bin .../res/drawable-xxhdpi/ic_cast_dark_off.png | Bin .../res/drawable-xxhdpi/ic_cast_dark_on.png | Bin .../ic_notification_media_route.png | Bin .../res/drawable-xxxhdpi/cast_playing_square.png | Bin .../ic_notification_media_route.png | Bin .../res/drawable/ic_cast_dark_chrome.xml | 0 .../layout/caf_controller_media_route_button.xml | 0 .../res/layout/expanded_cast_controller.xml | 0 .../{ => java}/res/values-v17/styles.xml | 0 .../media/router/BaseMediaRouteDialogManager.java | 0 .../media/router/CastRequestIdGenerator.java | 0 .../browser/media/router/CastSessionUtil.java | 0 .../browser/media/router/ChromeMediaRouter.java | 0 .../router/ChromeMediaRouterDialogController.java | 0 .../chrome/browser/media/router/ClientRecord.java | 0 .../browser/media/router/DiscoveryCallback.java | 0 .../browser/media/router/DiscoveryDelegate.java | 0 .../browser/media/router/FlingingController.java | 0 .../media/router/FlingingControllerBridge.java | 0 .../browser/media/router/MediaController.java | 0 .../chrome/browser/media/router/MediaRoute.java | 0 .../router/MediaRouteChooserDialogManager.java | 0 .../router/MediaRouteControllerDialogManager.java | 0 .../media/router/MediaRouteDialogDelegate.java | 0 .../media/router/MediaRouteDialogManager.java | 0 .../browser/media/router/MediaRouteManager.java | 0 .../browser/media/router/MediaRouteProvider.java | 0 .../chrome/browser/media/router/MediaSink.java | 0 .../chrome/browser/media/router/MediaSource.java | 0 .../browser/media/router/MediaStatusBridge.java | 0 .../browser/media/router/MediaStatusObserver.java | 0 .../router/caf/BaseNotificationController.java | 0 .../media/router/caf/BaseSessionController.java | 0 .../router/caf/CafBaseMediaRouteProvider.java | 0 .../media/router/caf/CafMediaRouteProvider.java | 0 .../media/router/caf/CafMessageHandler.java | 0 .../router/caf/CafNotificationController.java | 0 .../browser/media/router/caf/CastMediaSource.java | 0 .../media/router/caf/CastOptionsProvider.java | 0 .../media/router/caf/CastSessionController.java | 0 .../chrome/browser/media/router/caf/CastUtils.java | 0 .../media/router/caf/CreateRouteRequestInfo.java | 0 .../remoting/CafExpandedControllerActivity.java | 0 .../remoting/CafRemotingMediaRouteProvider.java | 0 .../caf/remoting/FlingingControllerAdapter.java | 0 .../router/caf/remoting/RemotingMediaSource.java | 0 .../remoting/RemotingNotificationController.java | 0 .../caf/remoting/RemotingSessionController.java | 0 .../caf/remoting/StreamPositionExtrapolator.java | 0 .../android_chrome_media_router_strings.grd | 0 .../android_chrome_media_router_strings_am.xtb | 0 .../android_chrome_media_router_strings_ar.xtb | 0 .../android_chrome_media_router_strings_bg.xtb | 0 .../android_chrome_media_router_strings_bn.xtb | 0 .../android_chrome_media_router_strings_ca.xtb | 0 .../android_chrome_media_router_strings_cs.xtb | 0 .../android_chrome_media_router_strings_da.xtb | 0 .../android_chrome_media_router_strings_de.xtb | 0 .../android_chrome_media_router_strings_el.xtb | 0 .../android_chrome_media_router_strings_en-GB.xtb | 0 .../android_chrome_media_router_strings_es-419.xtb | 0 .../android_chrome_media_router_strings_es.xtb | 0 .../android_chrome_media_router_strings_et.xtb | 0 .../android_chrome_media_router_strings_fa.xtb | 0 .../android_chrome_media_router_strings_fi.xtb | 0 .../android_chrome_media_router_strings_fil.xtb | 0 .../android_chrome_media_router_strings_fr.xtb | 0 .../android_chrome_media_router_strings_gu.xtb | 0 .../android_chrome_media_router_strings_hi.xtb | 0 .../android_chrome_media_router_strings_hr.xtb | 0 .../android_chrome_media_router_strings_hu.xtb | 0 .../android_chrome_media_router_strings_id.xtb | 0 .../android_chrome_media_router_strings_it.xtb | 0 .../android_chrome_media_router_strings_iw.xtb | 0 .../android_chrome_media_router_strings_ja.xtb | 0 .../android_chrome_media_router_strings_kn.xtb | 0 .../android_chrome_media_router_strings_ko.xtb | 0 .../android_chrome_media_router_strings_lt.xtb | 0 .../android_chrome_media_router_strings_lv.xtb | 0 .../android_chrome_media_router_strings_ml.xtb | 0 .../android_chrome_media_router_strings_mr.xtb | 0 .../android_chrome_media_router_strings_ms.xtb | 0 .../android_chrome_media_router_strings_nl.xtb | 0 .../android_chrome_media_router_strings_no.xtb | 0 .../android_chrome_media_router_strings_pl.xtb | 0 .../android_chrome_media_router_strings_pt-BR.xtb | 0 .../android_chrome_media_router_strings_pt-PT.xtb | 0 .../android_chrome_media_router_strings_ro.xtb | 0 .../android_chrome_media_router_strings_ru.xtb | 0 .../android_chrome_media_router_strings_sk.xtb | 0 .../android_chrome_media_router_strings_sl.xtb | 0 .../android_chrome_media_router_strings_sr.xtb | 0 .../android_chrome_media_router_strings_sv.xtb | 0 .../android_chrome_media_router_strings_sw.xtb | 0 .../android_chrome_media_router_strings_ta.xtb | 0 .../android_chrome_media_router_strings_te.xtb | 0 .../android_chrome_media_router_strings_th.xtb | 0 .../android_chrome_media_router_strings_tr.xtb | 0 .../android_chrome_media_router_strings_uk.xtb | 0 .../android_chrome_media_router_strings_vi.xtb | 0 .../android_chrome_media_router_strings_zh-CN.xtb | 0 .../android_chrome_media_router_strings_zh-TW.xtb | 0 .../media/router/MediaRouterIntegrationTest.java | 0 .../media/router/MockMediaRouteProvider.java | 0 .../media/router/ChromeMediaRouterRouteTest.java | 0 .../ChromeMediaRouterSinkObservationTest.java | 0 .../media/router/ChromeMediaRouterTestBase.java | 0 .../media/router/DiscoveryCallbackTest.java | 0 .../chrome/browser/media/router/JSONTestUtils.java | 0 .../chromium/chrome/browser/media/router/OWNERS | 0 .../chrome/browser/media/router/TestUtils.java | 0 .../router/caf/BaseSessionControllerTest.java | 0 .../router/caf/CafBaseMediaRouteProviderTest.java | 0 .../router/caf/CafMediaRouteProviderTest.java | 0 .../media/router/caf/CafMessageHandlerTest.java | 0 .../router/caf/CastSessionControllerTest.java | 0 .../media/router/caf/MediaRouterTestHelper.java | 0 .../media/router/caf/ShadowCastContext.java | 0 .../media/router/caf/ShadowCastMediaSource.java | 0 .../media/router/caf/ShadowMediaRouter.java | 0 135 files changed, 67 insertions(+), 68 deletions(-) commit df00f5d9f6d7f654789d1988634db1295fd0004b Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Mon Mar 4 21:25:22 2019 +0000 Turn off error return code in check_gn_headers Script build/check_gn_headers.py has always been returning non-zero on error. However, recently ToTLinux bot failed because of this. Temporarily turn off error return code before the root cause is fixed. Bug: 937847, 733500 Change-Id: I2ca40e3de5cf76cf693acd46493e2f405f90995b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499717 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#637426} build/check_gn_headers.py | 4 ++++ 1 file changed, 4 insertions(+) commit 6cb0181b9748a38a590995307b0c1a710b676fc9 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Mar 4 21:24:53 2019 +0000 Add mb configs for an internal simplechrome bot. Since the cros-chrome sdk controls the actual GN args, the entry here is pretty dumb. There's a flag ("--internal") in the sdk that causes internal args to be added. That will be set via recipes for this bot (since that's where we enter the sdk). ... maybe in a few quarters this will all go away and we fully specify the args for a simplechrome bot in this file. One can hope. Bug: 936957 Change-Id: I6f25f0b120729fbc594643ec79f5bbf54949c591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497751 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#637425} tools/mb/mb_config.pyl | 9 +++++++++ 1 file changed, 9 insertions(+) commit cfc091ccbde0d2d3d56628f8577c2ec4ad0ceaa6 Author: Patrick Noland <pnoland@chromium.org> Date: Mon Mar 4 21:23:21 2019 +0000 [Feed] Import feed@0ac884dad3d640ac4a31ba80c7f0d25be623ab52 ******************************Resource Sizes Diff****************************** Specifics: +58,472 bytes main lib size +436,132 bytes main dex size +162,968 bytes secondary dex size +942,928 bytes normalized apk size InstallSize: +345,750 bytes APK size +1,046,697 bytes Estimated installed size (Android Go) +2,766,114 bytes Estimated installed size InstallBreakdown (+2,764,288 bytes): +2,715 bytes Native resources (no l10n) size +2,406 bytes unwind_cfi (dev and canary only) size +2,210 bytes Non-compiled Android resources size +58,472 bytes Native code size +611 bytes Package metadata size +2,681,090 bytes Java code size +16,784 bytes Compiled Android resources size Dex: +3,166 entries fields +4,892 entries methods +1,613 entries types +3,334 entries strings Change-Id: I7b3c66b16c4f260a86e32a2e8b024de6f82e27b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499931 Commit-Queue: Patrick Noland <pnoland@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#637424} DEPS | 2 +- third_party/feed/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit d979f1ea119be1f1e0fd13473655dc74ee267059 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 4 21:22:02 2019 +0000 flags: remove slide-top-chrome-with-page-scrolls This change: 1) Removes the named flag 2) Removes the feature underlying it 3) Removes a layer of indirection made necessary largely by that feature Bug: None Change-Id: I773e07750021bc2c3ec146d09add3b80e97429f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499956 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#637423} chrome/browser/about_flags.cc | 7 ------- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- chrome/browser/ui/BUILD.gn | 1 - chrome/browser/ui/views/frame/browser_view.cc | 6 +++++- .../ui/views/frame/top_controls_slide_controller.cc | 21 --------------------- .../ui/views/frame/top_controls_slide_controller.h | 7 ------- ...ontrols_slide_controller_chromeos_browsertest.cc | 9 --------- chrome/common/chrome_features.cc | 5 ----- chrome/common/chrome_features.h | 3 --- 10 files changed, 5 insertions(+), 63 deletions(-) commit bddf73a6d5b25666aaea41269b74110d32df3556 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 21:21:51 2019 +0000 Roll src/third_party/swiftshader 823ca85404fb..bb305299f4de (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/823ca85404fb..bb305299f4de git log 823ca85404fb..bb305299f4de --date=short --no-merges --format='%ad %ae %s' 2019-03-04 chrisforbes@google.com Fix culling to match Vulkan convention Created with: gclient setdep -r src/third_party/swiftshader@bb305299f4de The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I8674ac97a1b47f3dc676dbc209f0f4ca0f741e7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499913 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637422} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 27f2aa6fe2cfebdc009728bac400ad05751c344a Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 4 21:18:48 2019 +0000 flags: assign ui-disable-partial-swap Bug: None Change-Id: I3c09886f7b68bace1a654e55948045d0bd314eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500201 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#637421} chrome/browser/flag-metadata.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 2c9cbaa076531648bb16a2b20bd5539087c35c22 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Mar 4 21:15:44 2019 +0000 SPM: Update display id on primary display changes When the primary display is changed to an existing display, it is done by swapping the display ids the two relevant WindowTreeHosts. There is no bounds change or window hierarchy change. Hence the client of Window Service is not aware that the underlying display id is changed. This causes WindowEventDispatcher to not finding correct root for touch events. The CL fixes the issue by updating WS client with the changed display ids. Bug: 936984, b/125458515 Change-Id: Ib6b46903fced804ac8ad2a506cc9a12f0ad003e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497475 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#637420} ash/display/window_tree_host_manager.cc | 23 +++++++++--- ash/display/window_tree_host_manager_unittest.cc | 47 ++++++++++++++++++++++++ services/ws/client_root.cc | 10 +++-- services/ws/client_root.h | 3 ++ services/ws/test_change_tracker.cc | 2 + services/ws/test_change_tracker.h | 1 + services/ws/test_window_tree_client.cc | 2 +- services/ws/window_service.cc | 9 +++++ services/ws/window_service.h | 7 ++++ services/ws/window_tree.cc | 13 +++++++ services/ws/window_tree.h | 6 +++ services/ws/window_tree_client_unittest.cc | 2 +- 12 files changed, 114 insertions(+), 11 deletions(-) commit b77de8d77002ccb3d1f6113f9364ccdf53570a1a Author: Jacob Dufault <jdufault@google.com> Date: Mon Mar 4 21:14:43 2019 +0000 cros: Remove ScreenContext for WelcomeScreen Context keys are a bit magical; let's eliminate the magic. Bug: 926511 Change-Id: Ib729d4908f5c7e8c75c0c2259a80cd4948595faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1436852 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#637419} .../chromeos/login/screens/mock_welcome_screen.h | 4 + .../chromeos/login/screens/welcome_screen.cc | 93 ++++++++++------------ .../chromeos/login/screens/welcome_screen.h | 6 +- .../browser/chromeos/login/screens/welcome_view.h | 8 ++ .../chromeos/login/oobe_screen_welcome.js | 33 ++++---- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 3 +- .../webui/chromeos/login/welcome_screen_handler.cc | 34 ++++++++ .../webui/chromeos/login/welcome_screen_handler.h | 9 +++ 8 files changed, 116 insertions(+), 74 deletions(-) commit 2c5ea3c8b6ad90acfed883c33e73423774fc67bf Author: Leonard Grey <lgrey@chromium.org> Date: Mon Mar 4 21:10:27 2019 +0000 Increase tab separator contrast ratio to 3 Bug: 929866 Change-Id: I8a8cd08fc3c86a678eb3af5aa109fc329136a51e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499777 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#637418} chrome/browser/ui/views/tabs/tab_strip.cc | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit b4e0d5df8efb03e36b27701377187bd12d58fef6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 21:06:59 2019 +0000 Roll src/third_party/pdfium ac0f524bb103..e8f5721133ad (10 commits) https://pdfium.googlesource.com/pdfium.git/+log/ac0f524bb103..e8f5721133ad git log ac0f524bb103..e8f5721133ad --date=short --no-merges --format='%ad %ae %s' 2019-03-04 thestig@chromium.org Fix a nullptr crash in CXFA_Node::GetLocaleName(). 2019-03-04 thestig@chromium.org Assert CPDF_AnnotContext always has a valid dictionary and page. 2019-03-04 thestig@chromium.org Make FPDFPage_GetAnnot() return nullptr for bad entries. 2019-03-04 thestig@chromium.org Add a test for FPDFPage_GetAnnotIndex() when there is a bad annot entry. 2019-03-04 thestig@chromium.org Fix 2 XFA nullptr crashes. 2019-03-04 thestig@chromium.org Remove unused CFXJSE_Value::SetObjectProperty(). 2019-03-02 thestig@chromium.org Tidy CPDF_ImageCacheEntry. 2019-03-01 thestig@chromium.org Rename "bool iFoo" variables to "bool bFoo". 2019-02-27 thestig@chromium.org Rename some UnsupportedInfo code. 2019-02-27 thestig@chromium.org Remove GetQuadPointsFromDictionary(). Created with: gclient setdep -r src/third_party/pdfium@e8f5721133ad The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8473f82e08b81597b3c22802b27f5e9b1673adc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499928 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637417} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 43b7b5ae88e39f84ed9adca7da2d6410a93c8713 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 21:06:55 2019 +0000 Roll src-internal 93bee44895a6..0dbc324dbe30 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/93bee44895a6..0dbc324dbe30 Created with: gclient setdep -r src-internal@0dbc324dbe30 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=yigu@chromium.org,peria@chromium.org,dgrogan@chromium.org,treib@chromium.org Change-Id: I2599842b5ea77cfd384d79a5188ef6c1440dfbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499923 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637416} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 12159c37b5c8efdc96ae33c1a05e1bbf5140478b Author: May Lippert <maybelle@google.com> Date: Mon Mar 4 21:02:54 2019 +0000 Add hsuregan, jordynass, maybelle to setting watchlist BUG=None Change-Id: I051c229edea685d79bdf7f6ddd74fdc1bce420e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500031 Auto-Submit: May Lippert <maybelle@chromium.org> Reviewed-by: Jordy Greenblatt <jordynass@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#637415} WATCHLISTS | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 7ffa9cfc01059606994fca22fb69516e99258d54 Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 21:02:50 2019 +0000 Revert "Add pause action to touch scroll action in WPT pointerevent touch tests" This reverts commit ad1c497727f24a73a2fe25f9187a7d1956f607b9. Reason for revert: Findit found this patch causing leaks on Linux. See https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/WebKit%20Linux%20Trusty%20Leak/builds/30910 Original change's description: > Add pause action to touch scroll action in WPT pointerevent touch tests > > In order to run the web-platform-tests automatically, we will use > testdriver Action API in all the wpt to simulate inputs. Here we are > changing some pointerevent touch input tests which are doing scrolling. > > Bug: 606367 > Change-Id: Id869ce8d516a82373732ca92a1af257cd8a2f50b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474773 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637392} TBR=lanwei@chromium.org,nzolghadr@chromium.org Change-Id: I6d370650a1666c7b7384f8569098e9250564552d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 606367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499710 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637414} ...e-touch-action-onpointerdown_touch-manual.html} | 6 ---- ...> pointerevent_pointercancel_touch-manual.html} | 6 ---- ...terleave_after_pointercancel_touch-manual.html} | 6 ---- ...interout_after_pointercancel_touch-manual.html} | 6 ---- ...intercapture_onpointercancel_touch-manual.html} | 6 ---- .../wpt/pointerevents/pointerevent_support.js | 33 ---------------------- ...revent_touch-action-auto-css_touch-manual.html} | 7 ----- ...-inherit_highest-parent-none_touch-manual.html} | 7 ----- ...ent_touch-action-pan-x-pan-y_touch-manual.html} | 7 ----- ...action-onpointerdown_touch-manual-automation.js | 6 ++++ ...revent_pointercancel_touch-manual-automation.js | 7 +++++ ..._after_pointercancel_touch-manual-automation.js | 7 +++++ ..._after_pointercancel_touch-manual-automation.js | 6 ++++ ...ture_onpointercancel_touch-manual-automation.js | 6 ++++ ...ouch-action-auto-css_touch-manual-automation.js | 8 ++++++ ..._highest-parent-none_touch-manual-automation.js | 7 +++++ ...h-action-pan-x-pan-y_touch-manual-automation.js | 7 +++++ 17 files changed, 54 insertions(+), 84 deletions(-) commit fc9e3b3970a30920e3a914ce92451547df2df253 Author: Lei Zhang <thestig@chromium.org> Date: Mon Mar 4 21:00:13 2019 +0000 Remove redundant checks in PrintMsg_Print_Params_IsValid(). Fix some nits in the same file as well. Change-Id: I6ce8f7b29fd49e4401783589291776fcd4b2de79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496323 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637413} components/printing/renderer/print_render_frame_helper.cc | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) commit 14362b23549b72631770fc72fcaf3343b7f5face Author: Ken MacKay <kmackay@chromium.org> Date: Mon Mar 4 20:58:07 2019 +0000 [Chromecast] Mojo broker for external services for use within cast_shell This allows Mojo services in other processes (ie, not built into cast_shell) to access Mojo services within cast_shell, and vice versa. It also acts as a broker which allows different external services to communicate with each other. Note that the manifests for the external services need to be specified correctly in cast_shell (by calling external_mojo::AddExternalServiceManifest) in order for this to work correctly. Manifests are not required for external services to communicate with each other though. Bug: internal b/126257793 Test: on device Change-Id: I498f7ff1efad1a8d7b709e99389c5130f19f4831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493712 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#637412} chromecast/BUILD.gn | 4 + chromecast/browser/BUILD.gn | 4 + chromecast/browser/DEPS | 1 + chromecast/browser/cast_content_browser_client.cc | 32 +- chromecast/browser/cast_content_browser_client.h | 1 + chromecast/browser/cast_overlay_manifests.cc | 8 + chromecast/chromecast.gni | 5 + chromecast/external_mojo/DEPS | 5 + chromecast/external_mojo/OWNERS | 1 + chromecast/external_mojo/README.md | 17 ++ chromecast/external_mojo/broker_service/BUILD.gn | 16 + .../external_mojo/broker_service/broker_service.cc | 103 +++++++ .../external_mojo/broker_service/broker_service.h | 64 ++++ .../external_service_support/BUILD.gn | 71 +++++ .../external_mojo/external_service_support/DEPS | 3 + .../external_service_support/README.md | 21 ++ .../external_service_support/chromium_service.cc | 87 ++++++ .../external_service_support/chromium_service.h | 68 +++++ .../external_service_support/external_connector.cc | 142 +++++++++ .../external_service_support/external_connector.h | 97 +++++++ .../external_service_support/external_service.cc | 51 ++++ .../external_service_support/external_service.h | 107 +++++++ .../external_service_support/process_setup.cc | 34 +++ .../external_service_support/process_setup.h | 20 ++ .../external_service_support/service_process.h | 28 ++ .../standalone_mojo_broker.cc | 39 +++ .../standalone_service_main.cc | 58 ++++ chromecast/external_mojo/public/cpp/BUILD.gn | 30 ++ chromecast/external_mojo/public/cpp/common.cc | 35 +++ chromecast/external_mojo/public/cpp/common.h | 20 ++ .../public/cpp/external_mojo_broker.cc | 321 +++++++++++++++++++++ .../public/cpp/external_mojo_broker.h | 49 ++++ chromecast/external_mojo/public/mojom/BUILD.gn | 11 + chromecast/external_mojo/public/mojom/OWNERS | 2 + .../external_mojo/public/mojom/connector.mojom | 39 +++ 35 files changed, 1591 insertions(+), 3 deletions(-) commit 54f8105b2a3e4823cc352ac1225cf8d1b0da301b Author: Bo Liu <boliu@chromium.org> Date: Mon Mar 4 20:50:29 2019 +0000 android: Fix interleaving popup calls TabWebContentsDelegateAndroid currently assumes that webContentsCreated must be matched with an addNewContents before another webContentsCreated is called. This assumption holds only by accident and doesn't hold anymore when OOPIF is enabled. Fix TabWebContentsDelegateAndroid to use a map instead of a single pair. Bug: 758186 Change-Id: I3c4913980a8d4907331afc9ddb6d7f3c0418d8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500154 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637411} .../browser/tab/TabWebContentsDelegateAndroid.java | 23 ++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) commit 5a7d4abb1f6307e50259daad440f1021129ae941 Author: Chase Phillips <cmp@chromium.org> Date: Mon Mar 4 20:49:19 2019 +0000 IndexedDB: Fix WPT bindings-inject-key to clean up Object.prototype Add a new cleanup for the 'prototype chain' test to fix a crash that happens when the test is run under chromedriver. Update the other tests to use t.add_cleanup() so they follow our test best practices. The underlying chromedriver issue is tracked upstream at https://crbug.com/chromedriver/2555. Bug: 934844 Change-Id: Id1b4ab2a908bfbc001e2a2d045eeec3ef01c24d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497613 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#637410} .../external/wpt/IndexedDB/bindings-inject-key.html | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit 1608acd387498a47fa42d06f5bf5fd1dd2015cc1 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Mon Mar 4 20:44:28 2019 +0000 Cleanup dead code in flags_state.cc Change-Id: I5c82f7be1ef33049c91a5eba2d425bf67e5a38b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500093 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637409} components/flags_ui/flags_state.cc | 2 -- 1 file changed, 2 deletions(-) commit 391ebb0e693f1dd8a97bb8c4d9c01cb4ec987f2e Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Mar 4 20:42:12 2019 +0000 Reland "[vr] Move Java and resources to //chrome/android/features/vr" This is a reland of ff22e974e751210c5989484975805df51932f229 with a fix for x86 builds. Original change's description: > [vr] Move Java and resources to //chrome/android/features/vr > > Bug: 870056 > Change-Id: I6e1dbf041d0b57a9457eb421cf7a4cc2a9cc7ebc > Reviewed-on: https://chromium-review.googlesource.com/c/1494721 > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636818} TBR=yfriedman@chromium.org,agrieve@chromium.org,wnwen@chromium.org Bug: 870056 Change-Id: I053e60256c9ffc238136b82cc8e6e850d21cb477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497122 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637408} chrome/android/BUILD.gn | 13 +- chrome/android/chrome_public_apk_tmpl.gni | 2 +- chrome/android/features/vr/BUILD.gn | 141 +++++++++++++++++++++ chrome/android/features/vr/DEPS | 4 + .../features/vr/{ => java}/AndroidManifest.xml | 0 .../vr/java/res}/drawable-hdpi/vr_services.png | Bin .../vr/java/res}/drawable-mdpi/vr_services.png | Bin .../vr/java/res}/drawable-xhdpi/vr_services.png | Bin .../vr/java/res}/drawable-xxhdpi/vr_services.png | Bin .../vr/java/res}/drawable-xxxhdpi/vr_services.png | Bin .../chrome/browser/vr/AndroidUiGestureTarget.java | 0 .../chrome/browser/vr/AndroidVSyncHelper.java | 0 .../browser/vr/EmptySniffingVrViewContainer.java | 0 .../org/chromium/chrome/browser/vr/NoopCanvas.java | 0 .../browser/vr/OnDispatchTouchEventCallback.java | 0 .../chrome/browser/vr/OnExitVrRequestListener.java | 0 .../chromium/chrome/browser/vr/VrAlertDialog.java | 4 +- .../browser/vr/VrCancelAnimationActivity.java | 0 .../browser/vr/VrCompositorSurfaceManager.java | 0 .../org/chromium/chrome/browser/vr/VrCoreInfo.java | 2 +- .../chrome/browser/vr/VrCoreVersionChecker.java | 0 .../chromium/chrome/browser/vr/VrDaydreamApi.java | 0 .../org/chromium/chrome/browser/vr/VrDelegate.java | 0 .../chrome/browser/vr/VrDelegateFallback.java | 0 .../chromium/chrome/browser/vr/VrDelegateImpl.java | 0 .../chrome/browser/vr/VrDelegateProvider.java | 0 .../browser/vr/VrDelegateProviderFallback.java | 0 .../chrome/browser/vr/VrDelegateProviderImpl.java | 0 .../org/chromium/chrome/browser/vr/VrDialog.java | 0 .../chrome/browser/vr/VrDialogManager.java | 0 .../chrome/browser/vr/VrFallbackUtils.java | 0 .../chrome/browser/vr/VrFeedbackStatus.java | 0 .../chrome/browser/vr/VrFirstRunActivity.java | 0 .../chrome/browser/vr/VrInputConnection.java | 0 .../chrome/browser/vr/VrIntentDelegate.java | 0 .../browser/vr/VrIntentDelegateFallback.java | 0 .../chrome/browser/vr/VrIntentDelegateImpl.java | 0 .../chrome/browser/vr/VrModalPresenter.java | 0 .../chromium/chrome/browser/vr/VrModeObserver.java | 0 .../chrome/browser/vr/VrModuleProvider.java | 0 .../chromium/chrome/browser/vr/VrPopupWindow.java | 0 .../org/chromium/chrome/browser/vr/VrShell.java | 0 .../chrome/browser/vr/VrShellDelegate.java | 13 +- .../org/chromium/chrome/browser/vr/VrToast.java | 0 .../chromium/chrome/browser/vr/VrToastManager.java | 0 .../chrome/browser/vr/VrUiWidgetFactory.java | 0 .../chrome/browser/vr/VrViewContainer.java | 0 .../chrome/browser/vr/VrWindowAndroid.java | 0 .../chrome/browser/vr/keyboard/BuildConstants.java | 0 .../vr/keyboard/GvrKeyboardLoaderClient.java | 0 .../chrome/browser/vr/keyboard/TextEditAction.java | 0 .../vr/keyboard/VrInputMethodManagerWrapper.java | 0 .../vr}/java/strings/android_chrome_vr_strings.grd | 104 +++++++-------- .../translations}/android_chrome_vr_strings_am.xtb | 0 .../translations}/android_chrome_vr_strings_ar.xtb | 0 .../translations}/android_chrome_vr_strings_bg.xtb | 0 .../translations}/android_chrome_vr_strings_bn.xtb | 0 .../translations}/android_chrome_vr_strings_ca.xtb | 0 .../translations}/android_chrome_vr_strings_cs.xtb | 0 .../translations}/android_chrome_vr_strings_da.xtb | 0 .../translations}/android_chrome_vr_strings_de.xtb | 0 .../translations}/android_chrome_vr_strings_el.xtb | 0 .../android_chrome_vr_strings_en-GB.xtb | 0 .../android_chrome_vr_strings_es-419.xtb | 0 .../translations}/android_chrome_vr_strings_es.xtb | 0 .../translations}/android_chrome_vr_strings_et.xtb | 0 .../translations}/android_chrome_vr_strings_fa.xtb | 0 .../translations}/android_chrome_vr_strings_fi.xtb | 0 .../android_chrome_vr_strings_fil.xtb | 0 .../translations}/android_chrome_vr_strings_fr.xtb | 0 .../translations}/android_chrome_vr_strings_gu.xtb | 0 .../translations}/android_chrome_vr_strings_hi.xtb | 0 .../translations}/android_chrome_vr_strings_hr.xtb | 0 .../translations}/android_chrome_vr_strings_hu.xtb | 0 .../translations}/android_chrome_vr_strings_id.xtb | 0 .../translations}/android_chrome_vr_strings_it.xtb | 0 .../translations}/android_chrome_vr_strings_iw.xtb | 0 .../translations}/android_chrome_vr_strings_ja.xtb | 0 .../translations}/android_chrome_vr_strings_kn.xtb | 0 .../translations}/android_chrome_vr_strings_ko.xtb | 0 .../translations}/android_chrome_vr_strings_lt.xtb | 0 .../translations}/android_chrome_vr_strings_lv.xtb | 0 .../translations}/android_chrome_vr_strings_ml.xtb | 0 .../translations}/android_chrome_vr_strings_mr.xtb | 0 .../translations}/android_chrome_vr_strings_ms.xtb | 0 .../translations}/android_chrome_vr_strings_nl.xtb | 0 .../translations}/android_chrome_vr_strings_no.xtb | 0 .../translations}/android_chrome_vr_strings_pl.xtb | 0 .../android_chrome_vr_strings_pt-BR.xtb | 0 .../android_chrome_vr_strings_pt-PT.xtb | 0 .../translations}/android_chrome_vr_strings_ro.xtb | 0 .../translations}/android_chrome_vr_strings_ru.xtb | 0 .../translations}/android_chrome_vr_strings_sk.xtb | 0 .../translations}/android_chrome_vr_strings_sl.xtb | 0 .../translations}/android_chrome_vr_strings_sr.xtb | 0 .../translations}/android_chrome_vr_strings_sv.xtb | 0 .../translations}/android_chrome_vr_strings_sw.xtb | 0 .../translations}/android_chrome_vr_strings_ta.xtb | 0 .../translations}/android_chrome_vr_strings_te.xtb | 0 .../translations}/android_chrome_vr_strings_th.xtb | 0 .../translations}/android_chrome_vr_strings_tr.xtb | 0 .../translations}/android_chrome_vr_strings_uk.xtb | 0 .../translations}/android_chrome_vr_strings_vi.xtb | 0 .../android_chrome_vr_strings_zh-CN.xtb | 0 .../android_chrome_vr_strings_zh-TW.xtb | 0 .../android/features/vr/public_vr_java_sources.gni | 16 +++ chrome/android/features/vr/vr_module_tmpl.gni | 4 +- .../chrome/browser/vr/SilenceLintErrors.java | 18 --- chrome/android/java_sources.gni | 15 +-- chrome/browser/android/vr/BUILD.gn | 136 +------------------- tools/gritsettings/translation_expectations.pyl | 2 +- 111 files changed, 238 insertions(+), 236 deletions(-) commit 657722a59ba1a757eb5fc63b4ff292b8c2a6194b Author: Esmael El-Moslimany <aee@chromium.org> Date: Mon Mar 4 20:37:07 2019 +0000 WebUI: cr-radio-group, update aria-disabled for group and buttons Bug: 932482 Change-Id: Ib02e4ece0265da2383fb3162c2a647b57fd9e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474996 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#637407} .../data/webui/cr_elements/cr_radio_group_test.js | 25 ++++++++++++++++++++++ .../cr_elements/cr_radio_group/cr_radio_group.js | 13 +++++------ 2 files changed, 32 insertions(+), 6 deletions(-) commit 795a75fc02001744bb6ed849c8ad3711d3d9a3b5 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Mar 4 20:35:31 2019 +0000 Switch ToLonghand to use downcast helpers R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I365764a69eebca8eca7cf3fb61ad2ce307012b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500153 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#637406} .../properties/templates/style_builder_functions.tmpl | 2 +- .../core/css/parser/css_property_parser_helpers.cc | 2 +- .../renderer/core/css/properties/css_parsing_utils.cc | 2 +- .../blink/renderer/core/css/properties/longhand.h | 12 +++++++----- .../css/properties/shorthands/border_image_custom.cc | 19 +++++++++++-------- .../core/css/properties/shorthands/offset_custom.cc | 4 ++-- .../css/properties/shorthands/place_content_custom.cc | 4 ++-- .../css/properties/shorthands/place_items_custom.cc | 4 ++-- .../css/properties/shorthands/place_self_custom.cc | 4 ++-- .../blink/renderer/core/css/resolver/style_builder.cc | 6 +++--- .../blink/renderer/core/style/computed_style.cc | 4 ++-- 11 files changed, 34 insertions(+), 29 deletions(-) commit 86e7aa883c95d551a450f71dc346fca4e31ea672 Author: Christian Fremerey <chfremer@chromium.org> Date: Mon Mar 4 20:34:27 2019 +0000 [Video Capture] Switch usage in Chromium Browser process to the new multi-client API The video capture service offers a new API for opening capture devices in a way that allows them to be shared by multiple clients. This CL switches one such client, i.e. the Chromium Browser process, over to that new API. This enables other clients to share access to capture devices with the Chromium Browser process. Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing Test: content_browsertests --gtest_filter=WebRtcVideoCaptureSharedDeviceBrowserTest.* Bug: 783442 Change-Id: I9c236f03e315cdafdc07429f3213fa4d11b43b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1399454 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637405} content/browser/BUILD.gn | 4 +- ...ory.cc => ref_counted_video_source_provider.cc} | 20 +- ...ctory.h => ref_counted_video_source_provider.h} | 35 ++- .../media/service_launched_video_capture_device.cc | 45 ++- .../media/service_launched_video_capture_device.h | 13 +- .../media/service_video_capture_device_launcher.cc | 122 +++++---- .../media/service_video_capture_device_launcher.h | 22 +- ...rvice_video_capture_device_launcher_unittest.cc | 301 ++++++++++++--------- .../media/service_video_capture_provider.cc | 44 +-- .../media/service_video_capture_provider.h | 18 +- .../service_video_capture_provider_unittest.cc | 111 +++++--- ...irtual_video_capture_devices_changed_observer.h | 1 + ...ideo_capture_service_enumeration_browsertest.cc | 1 + ...brtc_video_capture_shared_device_browsertest.cc | 174 ++++++++++++ content/test/BUILD.gn | 2 + services/video_capture/broadcasting_receiver.cc | 6 +- .../device_factory_media_to_mojo_adapter.h | 1 + .../video_capture/device_factory_provider_impl.cc | 3 +- .../video_capture/public/cpp/mock_device_factory.h | 1 + .../public/cpp/mock_video_source_provider.h | 6 + services/video_capture/public/mojom/BUILD.gn | 1 + .../public/mojom/device_factory.mojom | 5 +- .../public/mojom/devices_changed_observer.mojom | 11 + .../public/mojom/video_source_provider.mojom | 9 + .../test/mock_devices_changed_observer.h | 1 + .../video_capture/video_source_provider_impl.cc | 7 + .../video_capture/video_source_provider_impl.h | 3 + .../virtual_device_enabled_device_factory.h | 1 + 28 files changed, 646 insertions(+), 322 deletions(-) commit dd3e44cc62a0cb83a470f71749ac0f05f3c24838 Author: Bruce Dawson <brucedawson@chromium.org> Date: Mon Mar 4 20:29:28 2019 +0000 Fix copy_cdb outputs for ARM64 Win32 builds On ARM64 Win32 builds the UCRT is not a redistributable and therefore must be omitted from the list of outputs. Otherwise the copy_cdb_to_output will never be clean. This was tested before and after with this pair of commands: ninja.exe -C out\arm64 copy_cdb_to_output ninja.exe -d explain -C out\arm64 copy_cdb_to_output Before the build step was always dirty. After it is always clean. Bug: 937083 Change-Id: Ica53b1b172441925dcbb27f6033774d49b1df9af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497491 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637404} build/win/BUILD.gn | 89 ++++++++++++++++++++++++++++-------------------------- 1 file changed, 47 insertions(+), 42 deletions(-) commit 6cb8d3f9181a1d124e537b7ec954e32ba5652baa Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Mar 4 20:28:45 2019 +0000 Remove ScopedBlockingCall constructor without location This is the last step for migrating scoped blocking calls to the new constructor with locations. This CL is changing the documentation and removing the deprecated constructor. Bug: 934302 Change-Id: I1546d6f99e39d2c462176fae7a75302c14251d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496560 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#637403} base/threading/scoped_blocking_call.cc | 3 --- base/threading/scoped_blocking_call.h | 16 ++++++++++------ 2 files changed, 10 insertions(+), 9 deletions(-) commit f32727e1b8b6920fb8bb3a53932890c884ff134b Author: Samuel Attard <samuel.r.attard@gmail.com> Date: Mon Mar 4 20:27:25 2019 +0000 Expose MouseWheelPhaseHandler for use by embedders Ported from Electron, originally added in https://github.com/electron/libchromiumcontent/pull/649 Also implemented in CEF: https://bitbucket.org/chromiumembedded/cef/commits/fad6aec5d0f02853ff6b8af403c5b75d4764e3cb Change-Id: Id7952a5a6dcd6234304eb6e2dff0e86c0f22da24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494822 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Cr-Commit-Position: refs/heads/master@{#637402} AUTHORS | 1 + content/browser/renderer_host/input/mouse_wheel_phase_handler.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) commit 5d2c987aea46cb7378e21fb0641ad030aebcd808 Author: Sahel Sharify <sahel@chromium.org> Date: Mon Mar 4 20:25:52 2019 +0000 WPT test for touchmove event listener passive by default intervention. This cl adds WPT for touchmove event listener and modifies the existing wpt test for the wheel event listener intervention. These tests pass only when threaded compositing is enabled and that's why I have marked them as Skip in test expectations, until --enable-threaded-compositing is enabled for WPT tests by default (see issue 770028) I wrote the equivalent versions of the tests using gpubenchmarking in fast/scrolling so that they run in virtual/threaded test suite. Bug: 936891, 626196 Change-Id: I9e96736b9fbe7394d2c8157d2120457976a1d812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495437 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#637401} third_party/blink/web_tests/TestExpectations | 13 +++- ...ouchmove-event-listener-passive-by-default.html | 73 ++++++++++++++++++++++ ...l-event-listener-passive-by-default-manual.html | 39 +++++++++--- ...istener-passive-by-default-manual-automation.js | 9 ++- ...ouchmove-event-listener-passive-by-default.html | 42 +++++++++++++ ...el-wheel-event-listener-passive-by-default.html | 42 +++++++++++++ 6 files changed, 206 insertions(+), 12 deletions(-) commit 3f9a68fc621dd061efaa5708dabfe54329c4c7ee Author: Sean Gilhuly <sgilhuly@chromium.org> Date: Mon Mar 4 20:18:36 2019 +0000 Clean up DrawMode::GL in SkiaRenderer DrawMode::GL is deprecated is SkiaRenderer, so remove it. Bug: 934259 Change-Id: I963b8b64187753c8ad907da8359212aa9cd78293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499714 Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637400} components/viz/service/display/display.cc | 8 +- components/viz/service/display/skia_renderer.cc | 115 +----------------------- components/viz/service/display/skia_renderer.h | 13 +-- 3 files changed, 12 insertions(+), 124 deletions(-) commit 152f2be41a9c8e2ac0cd074717bd9e6261b9720f Author: Karan Bhatia <karandeepb@chromium.org> Date: Mon Mar 4 20:17:27 2019 +0000 DNR: Introduce RulesetInfo helper class. Introduce a helper class called RulesetInfo to simplify the ruleset loading code in rules_monitor_service.cc. Also rename LoadRulesetInfo to LoadRulesetRequest. This also introduces a small behavior change: we no longer raise a warning for a failed ruleset load if the extension is disabled. BUG=930961 Change-Id: I210d223c9afe2489c38a457878c838d1903f5ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496097 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#637399} .../rules_monitor_service.cc | 254 ++++++++++++--------- .../rules_monitor_service.h | 9 +- 2 files changed, 149 insertions(+), 114 deletions(-) commit b7695af3d1c02c738840260b947ad512446cbf3a Author: Frank Poole <frpoole@microsoft.com> Date: Mon Mar 4 20:13:02 2019 +0000 UIA_FrameworkIdPropertyId Implementation This change implements UIA_FrameworkIdPropertyId for IRawElementProviderSimple::GetPropertyValue with unit test coverage. The value "Chrome" is chosen for the UIA framework ID in order to be consistent with related preexisting APIs such as IA2's IAccessibleApplication::appName and IAccessibleApplication::toolkitName APIs. Bug: 844149 Change-Id: If9d79cf3ef0e4cf0db28b6d4cbb2fdd893b33f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497473 Commit-Queue: Frank Poole <frpoole@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637398} .../browser/accessibility/browser_accessibility_com_win.cc | 5 +---- ui/accessibility/platform/ax_platform_node_win.cc | 3 ++- ui/accessibility/platform/ax_platform_node_win.h | 5 +++++ ui/accessibility/platform/ax_platform_node_win_unittest.cc | 12 ++++++++++++ 4 files changed, 20 insertions(+), 5 deletions(-) commit 97c62e5d27f5c3fd7777eea4c55614ef7ee91cb9 Author: Bailey Berro <baileyberro@chromium.org> Date: Mon Mar 4 20:11:59 2019 +0000 printing_page: Allow editing of USB printers Currently, USB printers cannot be edited. This change updates the verification method used to enable the "Save" button on the edit dialog so that USB printers can be edited and saved. This change introduces a test suite for the Edit Dialog which was previously untested. Bug: 931983 Test: browser_tests --gtest_filter=CrSettingsPrinting* Change-Id: I6b66bd50c9442b2dbbe137c825cc6496d89f4e7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481721 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637397} .../printing_page/cups_add_printer_dialog.html | 3 +- .../printing_page/cups_add_printer_dialog.js | 6 +- .../printing_page/cups_add_printer_dialog_util.js | 26 +++- .../printing_page/cups_edit_printer_dialog.js | 8 +- .../cups_set_manufacturer_model_behavior.js | 2 +- .../data/webui/settings/cups_printer_page_tests.js | 143 ++++++++++++++++++--- 6 files changed, 155 insertions(+), 33 deletions(-) commit f06d59555b6f4fad16da415984531e00a24a8dc8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 20:11:55 2019 +0000 Roll src/third_party/catapult b3bee2e7d9f1..7ad2d7992c7e (1 commits) https://chromium.googlesource.com/catapult.git/+log/b3bee2e7d9f1..7ad2d7992c7e git log b3bee2e7d9f1..7ad2d7992c7e --date=short --no-merges --format='%ad %ae %s' 2019-03-04 simonhatch@chromium.org Pinpoint - Delete expired isolates from datastore. Created with: gclient setdep -r src/third_party/catapult@7ad2d7992c7e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:916877 TBR=sullivan@chromium.org Change-Id: I4530f74f6959217e0f26cb18d8b3b21cf890de5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499922 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637396} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eecc151a9d2dc2f292d504eb30ab3a34913b8605 Author: Mike Wittman <wittman@chromium.org> Date: Mon Mar 4 20:07:52 2019 +0000 [Sampling profiler] Make ModuleCache::Module an interface Changes Module to be an interface and creates separate implementations for Mac and Windows. The implementation are currently the same but will diverge to support managing the module reference count on Windows. R=charliea@chromium.org Bug: 931418 Change-Id: I49f882e2254c061eed04ef6c371e45d9c365daa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478251 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#637395} base/sampling_heap_profiler/module_cache.cc | 27 ------- base/sampling_heap_profiler/module_cache.h | 21 ++---- base/sampling_heap_profiler/module_cache_mac.cc | 29 ++++++- base/sampling_heap_profiler/module_cache_win.cc | 29 ++++++- .../metrics/call_stack_profile_builder_unittest.cc | 88 ++++++++++------------ .../common/tracing_sampler_profiler_unittest.cc | 23 ++++-- 6 files changed, 117 insertions(+), 100 deletions(-) commit 8e3cddfd5a433f618b0233e0f4405b139f9a8e1c Author: Yusuf Ozuysal <yusufo@google.com> Date: Mon Mar 4 20:06:33 2019 +0000 Add junit and DummyUIActivity tests for GridTabSwitcher Adds View/ViewBinder tests for TabListRecyclerView. Adds unit tests for GridTabSwitcherMediator. Also addressed an issue with closing tabs breaking selection in the grid tab switcher. BUG=937678 Change-Id: I3fa482c0928de55880051e7653a38272db73d093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498638 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637394} .../tab_list_ui/GridTabSwitcherCoordinator.java | 6 +- .../tasks/tab_list_ui/GridTabSwitcherMediator.java | 49 ++- .../tasks/tab_list_ui/TabListRecyclerView.java | 10 +- chrome/android/java_sources.gni | 2 + .../TabGridContainerViewBinderTest.java | 251 ++++++++++++++ .../GridTabSwitcherMediatorUnitTest.java | 363 +++++++++++++++++++++ 6 files changed, 647 insertions(+), 34 deletions(-) commit 76603adb87de6811fd7bd1d5de695a112c41e23d Author: Xiaohui Chen <xiaohuic@google.com> Date: Mon Mar 4 19:53:35 2019 +0000 assistant: http connection header response A simple implementation for http header resposne for libassistant api. This implementation is not very efficient. We could improve with |OnPause| and |OnResume| implementation to stream the result including headers. Bug: b:126591511 Test: locally run and play news Change-Id: I092b139dd0d64dff1906f4750ec17e580ab232ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500053 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637393} .../services/assistant/chromium_http_connection.cc | 25 ++++++++++++++++++++-- .../services/assistant/chromium_http_connection.h | 3 +++ 2 files changed, 26 insertions(+), 2 deletions(-) commit ad1c497727f24a73a2fe25f9187a7d1956f607b9 Author: Lan Wei <lanwei@chromium.org> Date: Mon Mar 4 19:52:53 2019 +0000 Add pause action to touch scroll action in WPT pointerevent touch tests In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some pointerevent touch input tests which are doing scrolling. Bug: 606367 Change-Id: Id869ce8d516a82373732ca92a1af257cd8a2f50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474773 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#637392} ...t_change-touch-action-onpointerdown_touch.html} | 6 ++++ ....html => pointerevent_pointercancel_touch.html} | 6 ++++ ...nt_pointerleave_after_pointercancel_touch.html} | 6 ++++ ...vent_pointerout_after_pointercancel_touch.html} | 6 ++++ ...leasepointercapture_onpointercancel_touch.html} | 6 ++++ .../wpt/pointerevents/pointerevent_support.js | 33 ++++++++++++++++++++++ ... pointerevent_touch-action-auto-css_touch.html} | 7 +++++ ...-action-inherit_highest-parent-none_touch.html} | 7 +++++ ...interevent_touch-action-pan-x-pan-y_touch.html} | 7 +++++ ...action-onpointerdown_touch-manual-automation.js | 6 ---- ...revent_pointercancel_touch-manual-automation.js | 7 ----- ..._after_pointercancel_touch-manual-automation.js | 7 ----- ..._after_pointercancel_touch-manual-automation.js | 6 ---- ...ture_onpointercancel_touch-manual-automation.js | 6 ---- ...ouch-action-auto-css_touch-manual-automation.js | 8 ------ ..._highest-parent-none_touch-manual-automation.js | 7 ----- ...h-action-pan-x-pan-y_touch-manual-automation.js | 7 ----- 17 files changed, 84 insertions(+), 54 deletions(-) commit 36a99a3612aaebcda7c3b9c94299f51d1504d1c9 Author: Lei Zhang <thestig@chromium.org> Date: Mon Mar 4 19:52:20 2019 +0000 Remove unneeded base/debug/stack_trace.h includes. Or move them out of header files. TBR=aleventhal@chromium.org,blundell@chromium.org,ericorth@chromium.org,palmer@chromium.org,piman@chromium.org,tguilbert@chromium.org Change-Id: I8e4a9940e07d4814e29f9a8f1ede5de2bcfee526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496301 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637391} ash/sticky_keys/sticky_keys_controller.cc | 1 - chrome/browser/net/chrome_network_delegate.cc | 1 - chrome/test/media_router/media_router_integration_browsertest.h | 1 - components/crash/core/common/crash_key.cc | 1 + components/crash/core/common/crash_key.h | 7 ++++++- components/gwp_asan/client/guarded_page_allocator.cc | 1 + .../contextual/reporting/contextual_suggestions_reporter.cc | 3 +-- content/browser/dom_storage/session_storage_context_mojo.cc | 1 - content/browser/media/audio_stream_monitor_unittest.cc | 1 - content/renderer/input/frame_input_handler_impl.cc | 1 - content/renderer/loader/resource_dispatcher.cc | 1 - content/test/content_test_launcher.cc | 1 - content/test/test_render_frame.cc | 1 - gpu/command_buffer/service/buffer_manager.h | 1 - media/renderers/video_renderer_impl_unittest.cc | 1 - net/dns/host_resolver_impl.cc | 1 - net/http/http_network_session.cc | 1 - .../cpp/service_executable/service_executable_environment.cc | 1 - services/service_manager/sandbox/linux/sandbox_linux.cc | 1 - services/ws/public/cpp/gpu/gpu.cc | 1 - third_party/blink/renderer/core/page/page.cc | 1 + third_party/blink/renderer/core/paint/fragment_data.cc | 2 -- .../platform/scheduler/main_thread/main_thread_scheduler_impl.cc | 1 - ui/android/delegated_frame_host_android.cc | 1 - ui/views/corewm/tooltip_win.cc | 1 - ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc | 1 - 26 files changed, 10 insertions(+), 25 deletions(-) commit a4cb8667469c1caff4a31db9ee2e643b669ad73e Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Mon Mar 4 19:48:35 2019 +0000 Improve logic determining the accessible role of non-scoped th elements When there were multiple, non-scoped cells in a row, we looked at the previous cell. If the previous cell existed and was a th, then the current cell was assigned the column header accessibility role. But if the previous cell was a td, then the current cell was instead assigned the row header accessibility role. The problem with this logic is that empty non-header cells can appear in the upper left corner of the table as well any place where the author didn't need a column header, such as in an empty column. For instance, the first column header in a table which also has row headers was mistakenly being given the wrong role if the author used td rather than th for the cell at row 0, column 0. Tweak the logic as follows: * If this header is the only cell in its row, it is a column header. * It is also a column header if it has a header on either side of it. * If it has a non-empty td element next to it, it is a row header. * If we cannot make a definitive decision based on the current header: - If the first or last cell is a non-empty td, it is a row header. - Also check the second and second-to-last cells for the same. * If we still do not have a definitive decision, assume column header. This logic produces the desired results for typical/in-the-wild th elements which lack a scope attribute. Lastly, update the edge-case table and associated results in two webkit layout tests to reflect the new behavior. Bug: 916491 Change-Id: I5764629f7079046ed20cebb0d207eea56c8ad5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494666 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637390} .../dump_accessibility_tree_browsertest.cc | 13 +++ ...ble-headers-empty-first-cell-expected-blink.txt | 98 ++++++++++++++++++++++ .../html/table-headers-empty-first-cell.html | 52 ++++++++++++ .../table-headers-on-all-sides-expected-blink.txt | 46 ++++++++++ .../html/table-headers-on-all-sides.html | 33 ++++++++ ...tiple-row-and-column-headers-expected-blink.txt | 93 ++++++++++++++++++++ .../table-multiple-row-and-column-headers.html | 51 +++++++++++ .../modules/accessibility/ax_layout_object.cc | 82 ++++++++++++------ .../table-header-column-row-expected.txt | 22 ++--- .../accessibility/table-header-column-row.html | 6 +- .../accessibility/table-headers-expected.txt | 14 +--- .../web_tests/accessibility/table-headers.html | 16 ++-- 12 files changed, 465 insertions(+), 61 deletions(-) commit 3a0367d77de3f9aaac05e52bce7f6830937c381f Author: Xiaohui Chen <xiaohuic@google.com> Date: Mon Mar 4 19:45:29 2019 +0000 assistant: pin audio device * pin audio input device to internal mic or headphones. * output audio is still default output device, we may change to pinned if we discover the default heuristics isn't good enough. * also pin hotword device to actual device that has hotword support. Bug: b:123996817 Bug: b:123596719 Bug: 931137 Test: locally build and run on caroline and eve with and without dsp flag Change-Id: Ic6bf83054cfb49078f139fdfc7d63b9c67c86883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497469 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637389} chromeos/services/assistant/BUILD.gn | 4 + .../assistant/platform/audio_device_owner.cc | 223 +++++++++++++++ .../assistant/platform/audio_device_owner.h | 85 ++++++ .../assistant/platform/audio_input_impl.cc | 76 ++++- .../services/assistant/platform/audio_input_impl.h | 22 +- .../platform/audio_input_provider_impl.cc | 14 +- .../assistant/platform/audio_input_provider_impl.h | 10 +- .../platform/audio_output_provider_impl.cc | 312 +-------------------- .../platform/audio_output_provider_impl.h | 108 +------ .../assistant/platform/volume_control_impl.cc | 108 +++++++ .../assistant/platform/volume_control_impl.h | 62 ++++ chromeos/services/assistant/platform_api_impl.cc | 57 +++- chromeos/services/assistant/platform_api_impl.h | 7 +- 13 files changed, 661 insertions(+), 427 deletions(-) commit 742f6523ccae46db33bc154e009bc67d413abbee Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Mar 4 19:44:23 2019 +0000 ProtoDatabaseTest Flush thread on lock release Lock releasing is done on a background thread. It is necessary to wait until the lock is released. The test is very flaky on iOS devices. Change-Id: Ie8fe6106c21461bd8f78438650c53587099adfcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497053 Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637388} components/leveldb_proto/internal/proto_database_impl_unittest.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 1454e5225b430c94aeb9c7914d8fad4da4171112 Author: Collin Baker <collinbaker@chromium.org> Date: Mon Mar 4 19:34:14 2019 +0000 Fix IPH menu button animation for non-unit scale factors This is a workaround for a layer mask invalidation bug. Bug: 909755, 935808 Change-Id: Ib634ab20b731bafc658487ddcaf4de98167cbe6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487142 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#637387} .../ui/views/toolbar/browser_app_menu_button.cc | 20 ++++++++++++++++---- ui/views/controls/button/label_button.h | 2 +- 2 files changed, 17 insertions(+), 5 deletions(-) commit 5be178683fd0112813f23a94449df64afb0eb628 Author: sczs <sczs@chromium.org> Date: Mon Mar 4 19:33:32 2019 +0000 [ios] Displays InfobarBadge when an Infobar is presented. LocationBar - Sets the LocationBarMediator as a InfobarBadgeTabHelper delegate. - Adds a LocationBarConsumer method to communicate the badge displaying from the Mediator to the ViewController. Infobar - Moves self.delegate->RemoveInfoBar(); from stop to deatachView to prevent the Infobar to be destroyed when switching WebStates. This way the badge will persist when returning to a WebState that was previously displaying a badge. - Adds InfobarBadgeDisplaying() to InfobarBadgeTabHelper so the Delegate knows if the newWebState should display a badge or not. Bug: 911864 Change-Id: I3da2898e1597900da79b83b17e75c210c420516a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493388 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#637386} .../browser/infobars/infobar_badge_tab_helper.h | 7 ++++-- .../browser/infobars/infobar_badge_tab_helper.mm | 10 +++++--- ios/chrome/browser/tabs/BUILD.gn | 2 ++ ios/chrome/browser/tabs/tab_helper_util.mm | 5 ++++ .../coordinators/infobar_confirm_coordinator.mm | 6 ++--- .../coordinators/infobar_password_coordinator.mm | 6 ++--- .../browser/ui/infobars/infobar_ui_delegate.h | 6 ++--- ios/chrome/browser/ui/location_bar/BUILD.gn | 1 + .../ui/location_bar/location_bar_consumer.h | 5 ++++ .../ui/location_bar/location_bar_coordinator.mm | 4 +++ .../ui/location_bar/location_bar_mediator.mm | 29 ++++++++++++++++++++-- .../ui/location_bar/location_bar_view_controller.h | 4 +++ .../location_bar/location_bar_view_controller.mm | 6 +++++ 13 files changed, 73 insertions(+), 18 deletions(-) commit a61a23e32308016f75d3d8b34948b21d3ca19e67 Author: Ben Pastene <bpastene@chromium.org> Date: Mon Mar 4 19:32:13 2019 +0000 Swtich android_compile_x(86|64)_dbg trybots to luci in CQ config. Bug: 731982, 731976 Change-Id: I2878dc8f7db32a7da9c9c7493bf7838fe87bcc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500019 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#637385} docs/infra/cq_builders.md | 16 ++++++++++++++++ infra/config/commit-queue.cfg | 28 ++++++++++++++-------------- 2 files changed, 30 insertions(+), 14 deletions(-) commit b2614b32e4c90e0693dd39a4d94c9241c0608671 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Mon Mar 4 19:31:09 2019 +0000 Inline MinimumValueForLength for better performance Change-Id: Ie65a0730435a6f773d2e70d70e8b30896bde8162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496562 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#637384} .../blink/renderer/platform/geometry/length_functions.cc | 7 +++---- .../blink/renderer/platform/geometry/length_functions.h | 15 +++++++++++++-- 2 files changed, 16 insertions(+), 6 deletions(-) commit cc8dd4342920e5ff32953a3f2ed70eeeb3987b85 Author: Akihiro Ota <akihiroota@chromium.org> Date: Mon Mar 4 19:24:44 2019 +0000 Change how rich text attributes are reported within editable text To reduce verbosity, do not indicate the start or end of attributes when moving through editable text by character. Simply report the attribute when it changes; start and end ranges can be inferred. This change also updates test cases to expect new behavior. Bug: 934962 Change-Id: I11f8833b53bd5705d702176654c1b809c569fab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488013 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#637383} .../chromeos/chromevox/cvox2/background/editing.js | 107 +++++++++++++-------- .../chromevox/cvox2/background/editing_test.extjs | 77 +++++++++------ .../chromevox/strings/chromevox_strings.grd | 82 ++++++---------- 3 files changed, 145 insertions(+), 121 deletions(-) commit bd22e55dd068a77b5cf00d2a0dd73cd0101859e4 Author: Ria Jiang <riajiang@chromium.org> Date: Mon Mar 4 19:23:50 2019 +0000 Delete event-source in all transform request calls. Relative transform for an embedded surface should be the same for all event-sources (e.g. mouse, touch). This CL deletes the event-source param in all transform request calls and the check in HitTestQuery implementations. Bug: none Change-Id: Id575ebe8a3429689feb1d94122a7cd6fc8a8c984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493078 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637382} components/viz/host/hit_test/hit_test_query.cc | 15 +++------------ components/viz/host/hit_test/hit_test_query.h | 2 -- .../viz/host/hit_test/hit_test_query_fuzzer.cc | 3 +-- .../viz/host/hit_test/hit_test_query_unittest.cc | 22 +++++++++++----------- .../frame_host/cross_process_frame_connector.cc | 7 +++---- .../frame_host/cross_process_frame_connector.h | 3 +-- content/browser/pointer_lock_browsertest.cc | 6 ++---- .../renderer_host/frame_connector_delegate.cc | 3 +-- .../renderer_host/frame_connector_delegate.h | 3 +-- .../render_widget_host_input_event_router.cc | 15 +++++---------- ...nder_widget_host_input_event_router_unittest.cc | 3 +-- .../render_widget_host_view_android.cc | 7 +++---- .../render_widget_host_view_android.h | 3 +-- .../renderer_host/render_widget_host_view_aura.cc | 5 ++--- .../renderer_host/render_widget_host_view_aura.h | 3 +-- .../renderer_host/render_widget_host_view_base.cc | 21 ++++++++------------- .../renderer_host/render_widget_host_view_base.h | 17 ++++++----------- .../render_widget_host_view_child_frame.cc | 5 ++--- .../render_widget_host_view_child_frame.h | 3 +-- .../renderer_host/render_widget_host_view_mac.h | 3 +-- .../renderer_host/render_widget_host_view_mac.mm | 5 ++--- .../site_per_process_hit_test_browsertest.cc | 2 +- 22 files changed, 57 insertions(+), 99 deletions(-) commit 03c1a6eab4ec0f019960a79d049ffb0996c50d5a Author: Danan S <danan@chromium.org> Date: Mon Mar 4 19:20:36 2019 +0000 Enable hiding of supervised users for M74 Bug: 937084 Change-Id: I4001ed5a601ee131c338724e3764a258f206f790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496248 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637381} .../login/users/remove_supervised_users_browsertest.cc | 10 ++++++---- components/user_manager/user_manager_base.cc | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) commit 53a6fca05788048287f5f48ab90477a90da258b7 Author: Johannes Henkel <johannes@chromium.org> Date: Mon Mar 4 19:18:19 2019 +0000 [DevTools] Roll of inspector protocol ... ... to b13e24ccee66d7e0590ce1266db9c906e3648561 to support UTF16 strings with binary protocol (cr). Original review here: Easier to review there: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1493312 Change-Id: I5f75c8a312fb6ed3d00357a651ffe7768d778df0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493152 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#637380} .../renderer/core/inspector/v8_inspector_string.cc | 5 + .../renderer/core/inspector/v8_inspector_string.h | 13 +- third_party/inspector_protocol/README.chromium | 2 +- third_party/inspector_protocol/encoding/cbor.cc | 67 ++++++--- third_party/inspector_protocol/encoding/cbor.h | 14 +- .../inspector_protocol/encoding/cbor_test.cc | 153 ++++++++++++++------- .../inspector_protocol/encoding/json_parser.cc | 7 +- .../encoding/json_parser_handler.h | 6 +- .../encoding/json_parser_test.cc | 69 ++++++---- .../encoding/json_std_string_writer.cc | 93 ++++++++++++- .../encoding/json_std_string_writer_test.cc | 34 +++-- .../inspector_protocol/lib/CBOR_cpp.template | 62 ++++++--- third_party/inspector_protocol/lib/CBOR_h.template | 19 ++- .../inspector_protocol/lib/Values_cpp.template | 51 +++++-- .../lib/base_string_adapter_cc.template | 7 + .../lib/base_string_adapter_h.template | 19 ++- 16 files changed, 463 insertions(+), 158 deletions(-) commit 88b6d136b2e8136feb07aba276ad4bfd8d9db272 Author: Kevin Ellis <kevers@chromium.org> Date: Mon Mar 4 19:17:25 2019 +0000 Implement 2D matrix decomposition in ui/gfx. Implemented for blink::TransformationMatrix here: https://chromium-review.googlesource.com/c/chromium/src/+/1332253 This CL ports support for 2D matrix decomposition to ui/gfx. Rather than maintaining separate 2D and 3D decomposition data structures, the generalized 3D decomposition structure is used in ui/gfx. This subtle change avoids breaking caching of matrix decompositions and works even in the case where 2D and 3D transformations are being blended. The goal is to eventually consolidate the 2 (blink and gfx) implementations (crbug/937296). This change is a step towards consolidation as it removes an obstacle to having blink::TransformationMatrix use the gfx implementation of matrix decomposition. Bug: 647554 Change-Id: I87afdc97e3e0ec1dfdbba971e918c82915dd1286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497381 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#637379} ui/gfx/transform_util.cc | 111 ++++++++++++++++++++++++++++++++++++++ ui/gfx/transform_util_unittest.cc | 95 +++++++++++++++++++++++++------- 2 files changed, 187 insertions(+), 19 deletions(-) commit f985f0a822794a4585f4ead8177d016fbc7efa85 Author: Lindsay Pasricha <lindsayw@google.com> Date: Mon Mar 4 19:15:19 2019 +0000 [ios] Rolls EG2 to ad70b511da47793e27e77c1a69c7895e8403be45. Several files were moved from Appframework to CommonLib and from TestLib to Appframework. Change-Id: I762089f78745b8d99c9da1b9ea8014d3affcbcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498780 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637378} DEPS | 2 +- ios/third_party/earl_grey2/BUILD.gn | 21 ++++++++++++--------- 2 files changed, 13 insertions(+), 10 deletions(-) commit ccb2f1cdce19a68d14ed0dd780bd5ea874cc1000 Author: Toni Barzic <tbarzic@chromium.org> Date: Mon Mar 4 19:13:58 2019 +0000 webui login: Remove lock screen app focus handling BUG=929466 Change-Id: I203ad78bef662ad8e9c189577acd74e513501452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498026 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#637377} .../browser/chromeos/login/ui/webui_login_view.cc | 43 ---------------------- .../browser/chromeos/login/ui/webui_login_view.h | 25 ------------- 2 files changed, 68 deletions(-) commit 173c60031f375a377a29bb17c4670238ea05ca1a Author: Chris Harrelson <chrishtr@chromium.org> Date: Mon Mar 4 19:07:28 2019 +0000 [PE] Remove RunPostLayoutTasks enum. There was only two callsites that called it with a non-default argument. Instead, modify the callsites to call the extra code implied by the non-default argument. Change-Id: I2c1cf00cc01ec42805edbd00f8e6794f2ff3b9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497755 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#637376} third_party/blink/renderer/core/dom/document.cc | 15 ++++----------- third_party/blink/renderer/core/dom/document.h | 6 ++---- .../blink/renderer/core/html/html_plugin_element.cc | 5 +++-- third_party/blink/renderer/core/testing/internals.cc | 4 ++-- 4 files changed, 11 insertions(+), 19 deletions(-) commit 83417ece333169a3b82173418ee7d2c5ddcd4b28 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 19:06:00 2019 +0000 Roll src-internal a72882291163..93bee44895a6 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a72882291163..93bee44895a6 Created with: gclient setdep -r src-internal@93bee44895a6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1854c72aa3d5eb3a923876213eb1ec5a0fb38cf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499656 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637375} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 449b0ebbd98f49e8952feb320024f95f8987b38d Author: wutao <wutao@chromium.org> Date: Mon Mar 4 19:04:26 2019 +0000 app_list: Remove back button in dialog plate Per UX feedback, we remove the back button in the dialog plate. Bug: 924624 Test: manual Change-Id: I19f7f0495fb57e80319f4138119545325d358b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492396 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#637374} ash/app_list/views/assistant/dialog_plate.cc | 31 +++------------------------- ash/app_list/views/assistant/dialog_plate.h | 4 +--- ash/ash_strings.grd | 3 --- ash/assistant/assistant_ui_controller.cc | 5 ----- ash/assistant/model/assistant_ui_model.h | 4 ++-- 5 files changed, 6 insertions(+), 41 deletions(-) commit 9bc14ac72841534ccf6ef1f340159750fe7867eb Author: Luke Zielinski <lpz@chromium.org> Date: Mon Mar 4 19:02:16 2019 +0000 Begin importing WPT runner codebase into Chromium. This code is used to run WPT tests in the public upstream repository, and is being integrated into Chromium CI. This change begins the automatic import of this code, as well as adding several lint and presubmit check exclusions. Bug: 937369 Change-Id: Ie9409e671b0c06a10bb509a53946687c0b7a3f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495372 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637373} PRESUBMIT.py | 2 +- third_party/blink/PRESUBMIT.py | 3 ++- third_party/blink/web_tests/W3CImportExpectations | 26 +++++++++++++++++++---- tools/checkperms/checkperms.py | 1 + 4 files changed, 26 insertions(+), 6 deletions(-) commit d76980d2a5c23dcad04da6c5cad55746fc4576ec Author: David Black <dmblack@google.com> Date: Mon Mar 4 19:00:16 2019 +0000 Moves more view delegation to AssistantViewDelegate. This CL moves the following delegation into AssistantViewDelegate: - Mini view event delegation. - Opt in view event delegation. - Suggestion chip container event delegation. Bug: b:126761217 Change-Id: I4e8de3804edb543ad5e4be5b9cb6fde9d78c55ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497211 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#637372} ash/assistant/assistant_interaction_controller.h | 4 +-- ash/assistant/assistant_setup_controller.cc | 8 ++++++ ash/assistant/assistant_setup_controller.h | 8 +++--- ash/assistant/assistant_ui_controller.cc | 22 ++++++++-------- ash/assistant/assistant_ui_controller.h | 7 +---- ash/assistant/assistant_view_delegate_impl.cc | 22 ++++++++-------- ash/assistant/assistant_view_delegate_impl.h | 4 +-- ash/assistant/ui/assistant_container_view.cc | 2 -- ash/assistant/ui/assistant_mini_view.cc | 3 +-- ash/assistant/ui/assistant_mini_view.h | 19 -------------- ash/assistant/ui/assistant_view_delegate.h | 23 ++++++++++++----- .../ui/main_stage/assistant_opt_in_view.cc | 30 ++++++++++------------ .../ui/main_stage/assistant_opt_in_view.h | 11 -------- .../ui/main_stage/suggestion_container_view.cc | 1 - 14 files changed, 72 insertions(+), 92 deletions(-) commit d975c4238c0ad3ed67842e8511e3757105cc6180 Author: Sam Maier <smaier@chromium.org> Date: Mon Mar 4 19:00:06 2019 +0000 Android: ensuring onDestroy called between tests This is a changed version where we ignore exceptions if the exception times out. We ran into a framework bug, so we can't expect all Activities to be destroyed (bug here: crbug.com/937306). Bug: 908174 Change-Id: I25c1bdf0239d78af47e58642db7d4d00083aadd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495972 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#637371} base/BUILD.gn | 1 + .../src/org/chromium/base/ApplicationStatus.java | 2 +- .../chromium/base/test/BaseJUnit4ClassRunner.java | 2 +- .../chromium/base/test/DestroyActivitiesRule.java | 81 ++++++++++++++++++++++ .../DelayedInvalidationsControllerTest.java | 6 ++ .../browser/tabmodel/TabWindowManagerTest.java | 33 +++++++-- .../chrome/test/ChromeActivityTestRule.java | 4 -- 7 files changed, 117 insertions(+), 12 deletions(-) commit 1ae7f80b73bf5247f4b98ac8bab7af0d9b90f657 Author: Fredrik Söderquist <fs@opera.com> Date: Mon Mar 4 18:55:49 2019 +0000 Remove TODO in svg_fe_convolve_matrix_element.idl It was resolved in https://github.com/w3c/fxtf-drafts/issues/114 to keep this attribute. Bug: 695977 Change-Id: I77a2cea341483d6ce337b314cd6597ec089c07eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499565 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#637370} .../blink/renderer/core/svg/svg_fe_convolve_matrix_element.idl | 4 ---- 1 file changed, 4 deletions(-) commit 6a84889c61b58f1655603671470c8f34e11363df Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 4 18:51:29 2019 +0000 flags: remove windows10-custom-titlebar No longer needed per email discussion. Functionality retained behind --enable-features=Windows10CustomTitlebar. Bug: None Change-Id: I2ba5afc63f89a5052611c116ae087dd7f1ca2743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499954 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#637369} chrome/browser/about_flags.cc | 7 ------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- 4 files changed, 20 deletions(-) commit 7d87915574fba5c4c432bd5a75079195de4d6064 Author: Joe Mason <joenotcharles@google.com> Date: Mon Mar 4 18:50:44 2019 +0000 Add RESULT_CODE_TEST_ENGINE_SANDBOX_DISCONNECTED_TOO_SOON R=proberge@chromium.org Bug: 802092 Change-Id: Ia18dc4278740e0b5e2a51ec8d00626fe1d781150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499837 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#637368} components/chrome_cleaner/public/constants/result_codes.h | 4 ++++ 1 file changed, 4 insertions(+) commit 20bfd44d658b6734d4ccb5cd83dea3e290d80df0 Author: Sam Dallstream <sadallst@microsoft.com> Date: Mon Mar 4 18:49:15 2019 +0000 Fixed bug where calling speak immediately after cancel would fail. The problem was that the windows speech API expects a NULL argument when only clearing the queue, otherwise it will try to speak the word given after flushing the queue, even if the word is an empty string. Bug: 924503 Change-Id: I55629f7868cd23ec7f6318a32c97a7b8d60648be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495863 Commit-Queue: Samuel Dallstream <sadallst@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637367} content/browser/speech/tts_win.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 212d3ea2a761e06c1aafc4113cbdb69bef31016c Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Mar 4 18:44:12 2019 +0000 Disable failing tests in google_services_settings_egtests Tbr: jlebel Change-Id: I6a4d73c18b6078adf62ea7c6f41278874a3ff8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499558 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637366} .../ui/settings/google_services/google_services_settings_egtest.mm | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit b69cd66e3ce82d826e12a6c1494220929830c87d Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Mar 4 18:42:43 2019 +0000 [Extensions] Update updater owners mxnguyen@ is no longer on the team; update OWNERS files appropriately (adding sorin@ and waffles@). Bug: None Change-Id: I3888d97deed7898cd71f5d5f1d89c632a9d49145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497614 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637365} chrome/browser/extensions/updater/OWNERS | 1 - extensions/browser/updater/OWNERS | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) commit fc038a991c3e3a44509b9e2a6d1259c0988d07b2 Author: Xida Chen <xidachen@chromium.org> Date: Mon Mar 4 18:41:29 2019 +0000 [Code health] Remove an un-necessary lines in TestExpectations This one particular test is no longer flaky according to the dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=AnimationEffect-getComputedTiming.tentative.html Bug: 875622 Change-Id: I1162d18df28947531341eba5b046a6878264fcbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499719 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637364} third_party/blink/web_tests/TestExpectations | 1 - 1 file changed, 1 deletion(-) commit 93bedebc24efecf439e7a0bd37f5c29289ec34c2 Author: Manu Cornet <manucornet@chromium.org> Date: Mon Mar 4 18:39:34 2019 +0000 CrOS Shelf: Replace some test API calls with existing public APIs Bug: 891080 Change-Id: I5a5ed7a70da2a0d1a2a0314157369a58b955f12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497219 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637363} ash/shelf/shelf_unittest.cc | 11 +- ash/shelf/shelf_view_test_api.cc | 20 -- ash/shelf/shelf_view_test_api.h | 16 -- ash/shelf/shelf_view_unittest.cc | 259 +++++++++++---------- .../chrome_launcher_controller_browsertest.cc | 10 +- 5 files changed, 148 insertions(+), 168 deletions(-) commit 1a3bea0a7f45bb6e397b123f4b08b4d4446b48dd Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Mar 4 18:38:27 2019 +0000 NetworkStateHandler: Only scan when technology is enabled Bug: 922853 Change-Id: I159a507e29d652f1b25c1193ecad06963039fe79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495675 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637362} chromeos/network/network_state_handler.cc | 16 +++++++++++----- chromeos/network/network_state_handler_unittest.cc | 9 +++++++++ 2 files changed, 20 insertions(+), 5 deletions(-) commit 9402d47ab12bf13bb44e8193411336568fc2ac70 Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 18:38:06 2019 +0000 [BlinkGenPropertyTrees] Mark compositing/overflow/overflow-scroll-with-local-background.html as flaky on Linux Debug TBR=wangxianzhu@chromium.org NOTRY=true Bug: 937902 Change-Id: I0db31c15d4122463320f7e469a335c2673b32508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499731 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637361} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit c15181db4b276d60bfb7b47fca2b61fe725515a9 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Mar 4 18:37:10 2019 +0000 [Extensions Cleanup] Fix a couple typos TBR=karandeepb@chromium.org Bug: None Change-Id: If70e3afe9934b5c0b6d91bd7271b97063886f30a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497390 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637360} .../browser/api/lock_screen_data/lock_screen_item_storage_unittest.cc | 2 +- extensions/common/extension_set.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit bb7721e76c5d96e37e2018a47a81db53668a73f2 Author: Lei Zhang <thestig@chromium.org> Date: Mon Mar 4 18:33:55 2019 +0000 Fix various nits in print_browsertest.cc. Change-Id: I40d039f516966faf3ca96efa461bd0da61d1e69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496284 Reviewed-by: Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#637359} chrome/browser/printing/print_browsertest.cc | 34 +++++++++++++--------------- 1 file changed, 16 insertions(+), 18 deletions(-) commit 45f9f8c5dcfb9be45c55d786d0e8c9794038b7d3 Author: Orin Jaworski <orinj@chromium.org> Date: Mon Mar 4 18:33:51 2019 +0000 [omnibox] Remove flag omnibox::kEnableClipboardProvider This flag is no longer used and is being removed. Logic using it is replaced with precompiler conditions to keep the default behavior (enabled on mobile, disabled on desktop). Bug: 936854 Change-Id: I47610addd182a7f7d3bd289d68689ad0f10b4cc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496418 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637358} chrome/browser/about_flags.cc | 7 ------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- components/omnibox/browser/autocomplete_classifier.cc | 5 ++--- components/omnibox/browser/omnibox_field_trial.cc | 11 ----------- components/omnibox/browser/omnibox_field_trial.h | 1 - 7 files changed, 2 insertions(+), 36 deletions(-) commit 7a68a3e25b019a172bd175857d0b3bdd9e715524 Author: manuk <manukh@chromium.org> Date: Mon Mar 4 18:31:52 2019 +0000 [omnibox chrome:omnibox]: Remove 'Copy as text' button. Removed 'Copy as text' button as we're no longer supporting selecting and copying partial outputs. Bug: 937321 Change-Id: I4eef02ebbb85c7af4e447ff9fc329b2d12c00dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496481 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#637357} chrome/browser/resources/omnibox/omnibox.html | 5 ----- chrome/browser/resources/omnibox/omnibox.js | 11 ----------- chrome/browser/resources/omnibox/omnibox_input.js | 7 ------- chrome/browser/resources/omnibox/omnibox_output.js | 13 ------------- 4 files changed, 36 deletions(-) commit 1e44babe68ad6dc6180c34de0e37889ecb8d4286 Author: Erik Chen <erikchen@chromium.org> Date: Mon Mar 4 18:31:43 2019 +0000 Remove broken priority adjustment code. Code was added here: https://chromium-review.googlesource.com/c/chromium/src/+/1097600 The code has never had any effect. It tried to use the 'priority_adjustment' config, which only takes 'higher', 'normal' and 'lower' arguments. This mechanism is hard to reason about, prone to unexpected/incorrect priorities, and is otherwise unused. I removed 'priority_adjustment' here: https://chromium-review.googlesource.com/c/chromium/src/+/1097600 Bug: 851115, 937151 Change-Id: I70844bcc5303f17f72c3f7b17f07632e75ae79c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496488 Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#637356} testing/buildbot/chromium.fyi.json | 4 ---- testing/buildbot/waterfalls.pyl | 12 ------------ 2 files changed, 16 deletions(-) commit 1d367503cfbf3b1483d79f9340cbd7a8850e26c1 Author: Katie D <katie@chromium.org> Date: Mon Mar 4 18:27:54 2019 +0000 Mark all images dirty when the user requests image annotations once. This will ensure the annotator gets notified of all page images. Bug: 905419 Change-Id: I6634797ff8e00288977240b43c081838683d9a5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495805 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637355} .../accessibility/render_accessibility_impl.cc | 24 +++++++++++++++++++++- .../accessibility/render_accessibility_impl.h | 3 +++ 2 files changed, 26 insertions(+), 1 deletion(-) commit 347c29dfe2c343d0a54d68a64a192e823e11ff80 Author: manuk <manukh@chromium.org> Date: Mon Mar 4 18:23:13 2019 +0000 [omnibox chrome:omnibox]: Add classifications for contents & description The autocomplete providers classify the contents and description of matches as a combination of URL, MATCH, and DIM; e.g. the first 5 chars of contents may be a URL while the remaining chars may be both a URL and a MATCH. The omnibox styles the matches according to their classifications. This CL mimics the behavior in the debug page by applying blue font to URLs, bold font to MATCHes, and light gray backgrounds to DIMs. Additionally, this CL inserts a dash, '-', between the contents and description. Before this CL, the contents were styled blue to differentiate them from the description, but are now blue, since blue now indicates a URL classification. Bug: 936863 Change-Id: I437bdd24506c89e17b484f7d1c7c2788df017e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491904 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#637354} .../browser/resources/omnibox/omnibox_element.js | 5 +- chrome/browser/resources/omnibox/omnibox_output.js | 93 +++++++++++++++++----- .../resources/omnibox/output_results_group.css | 26 ++++-- chrome/browser/ui/webui/omnibox/omnibox.mojom | 7 ++ .../ui/webui/omnibox/omnibox_page_handler.cc | 27 +++++-- 5 files changed, 121 insertions(+), 37 deletions(-) commit 209465daa59c409bb3196806009ad035bb1f4823 Author: Tarun Bansal <tbansal@chromium.org> Date: Mon Mar 4 18:21:55 2019 +0000 Resource Scheduler: Add metrics to record gap between non-delayable requests Change-Id: If2df199cac0efd9f3293427aee5557f78e99a2e2 Bug: 935703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491133 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#637353} services/network/resource_scheduler.cc | 68 ++++++++++--- services/network/resource_scheduler_unittest.cc | 121 ++++++++++++++++++++---- tools/metrics/histograms/histograms.xml | 47 ++++++++- 3 files changed, 204 insertions(+), 32 deletions(-) commit c97b7626521a637a8240f7f9faf4c1d6bd185074 Author: David Tseng <dtseng@chromium.org> Date: Mon Mar 4 18:21:30 2019 +0000 Add support for virtual accessibility hierarchies in Chrome OS using wrappers. Bug: 811277 Test: manually on Chrome OS task manager (shift+esc). Arrowing around reads the correct focused cell. Change-Id: I8e652f99ae05eba42c3d3f13f3cf0a81c4467e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490433 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#637352} ui/views/BUILD.gn | 2 + ui/views/accessibility/ax_aura_obj_cache.cc | 9 +++- ui/views/accessibility/ax_tree_source_views.cc | 10 ++++- ui/views/accessibility/ax_view_obj_wrapper.cc | 9 +++- ui/views/accessibility/ax_virtual_view.cc | 51 +++++++++++++++++++++++ ui/views/accessibility/ax_virtual_view.h | 21 ++++++++-- ui/views/accessibility/ax_virtual_view_wrapper.cc | 51 +++++++++++++++++++++++ ui/views/accessibility/ax_virtual_view_wrapper.h | 39 +++++++++++++++++ 8 files changed, 185 insertions(+), 7 deletions(-) commit 3d13531186dc25d7c2527bdee519f23161587833 Author: Charlie Harrison <csharrison@chromium.org> Date: Mon Mar 4 18:20:39 2019 +0000 Remove experiment_percentage for flatbuffers_unittests It's been a few days and there are no failures on the flake dashboard. Bug: 934080 Change-Id: I88e93903dd862b2498d4a4e602467d8caf712441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497342 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#637351} testing/buildbot/chromium.clang.json | 1 - testing/buildbot/chromium.fyi.json | 4 ---- testing/buildbot/chromium.linux.json | 4 ---- testing/buildbot/chromium.mac.json | 5 ----- testing/buildbot/chromium.win.json | 4 ---- testing/buildbot/test_suites.pyl | 4 +--- 6 files changed, 1 insertion(+), 21 deletions(-) commit 6f2e8c75f6fac08fb8f40dbdfb92d145ef665c97 Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Mar 4 18:18:26 2019 +0000 Register OfflinePageTabHelper as ReadingListModelObserver. This is only used if the model is destroyed before the last tab. Bug: 929492 Change-Id: I0aa67b5ff2931440bcf512714b1ecbab7579eb4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499460 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637350} ios/chrome/browser/reading_list/offline_page_tab_helper.mm | 1 + 1 file changed, 1 insertion(+) commit 3aa00d16731e50103279dc3c73ceccf553640c4e Author: Alex Newcomer <newcomer@chromium.org> Date: Mon Mar 4 18:17:21 2019 +0000 Remove touchable app context menu flags Bug: 925877 Change-Id: I1e72ab7a24c8ac202e531c3840ad51c863744b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497389 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#637349} ui/base/ui_base_switches.cc | 4 ---- ui/base/ui_base_switches.h | 1 - ui/base/ui_base_switches_util.cc | 5 ----- ui/base/ui_base_switches_util.h | 4 ---- 4 files changed, 14 deletions(-) commit 0b9e260ee40c36a779df587d4aeea7152f7c7b3d Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 18:14:12 2019 +0000 Revert "Disable flaky test AccessibilityWinBrowserTest.TestIScrollProvider" This reverts commit bee247e1fba3d216896e7e4462aef84635ad7cab. Reason for revert: <INSERT REASONING HERE> Original change's description: > Disable flaky test AccessibilityWinBrowserTest.TestIScrollProvider > > Test was added by janewman@microsoft.com. Given that the linked bug > requires restricted permission, add the CL reviewer to TBR too. > > Log: > accessibility_win_browsertest.cc(3234): error: The difference between > expected.size_horizontal and size_horizontal is 0.1705128205128208, > which exceeds error, where expected.size_horizontal evaluates to 12.65, > size_horizontal evaluates to 12.820512820512821, and error evaluates to > 0.0099999997764825821. > > accessibility_win_browsertest.cc(3274): error: The difference between > expected.size_vertical and size_vertical is 0.84176470588235119, which > exceeds error, where expected.size_vertical evaluates to 28.57, > size_vertical evaluates to 29.411764705882351, and error evaluates to > 0.0099999997764825821. > > TBR=dmazzoni@chromium.org, janewman@microsoft.com > > Bug: 936440 > Change-Id: I60a62582fcfda1006a6e87661a0bdc649954e6d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499725 > Commit-Queue: Yi Gu <yigu@chromium.org> > Reviewed-by: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637347} TBR=dmazzoni@chromium.org,yigu@chromium.org,janewman@microsoft.com Change-Id: I8c74a20f5e0ab5142b2d3c9d67ac34dc712cd337 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499727 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637348} content/browser/accessibility/accessibility_win_browsertest.cc | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) commit bee247e1fba3d216896e7e4462aef84635ad7cab Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 18:09:46 2019 +0000 Disable flaky test AccessibilityWinBrowserTest.TestIScrollProvider Test was added by janewman@microsoft.com. Given that the linked bug requires restricted permission, add the CL reviewer to TBR too. Log: accessibility_win_browsertest.cc(3234): error: The difference between expected.size_horizontal and size_horizontal is 0.1705128205128208, which exceeds error, where expected.size_horizontal evaluates to 12.65, size_horizontal evaluates to 12.820512820512821, and error evaluates to 0.0099999997764825821. accessibility_win_browsertest.cc(3274): error: The difference between expected.size_vertical and size_vertical is 0.84176470588235119, which exceeds error, where expected.size_vertical evaluates to 28.57, size_vertical evaluates to 29.411764705882351, and error evaluates to 0.0099999997764825821. TBR=dmazzoni@chromium.org, janewman@microsoft.com Bug: 936440 Change-Id: I60a62582fcfda1006a6e87661a0bdc649954e6d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499725 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637347} content/browser/accessibility/accessibility_win_browsertest.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit ec348379e9ff6fb656aed59c1dabf769ee1b7f7c Author: Ahmed Fakhry <afakhry@chromium.org> Date: Mon Mar 4 18:09:27 2019 +0000 Virtual Desks 2.1: Desks mini views behavior. This CL adds the desks mini views (a.k.a. thumbnails) to the desks bar: - Desks and their mini_views creation and removal. - New desk button enabled state behavior. - Close button visibility state changes on mini_views hovers. This CL does not implement the mini_views animations. Will be done in a follow-up CL. Demo: https://bugs.chromium.org/p/chromium/issues/detail?id=866622#c7 BUG=866622 TEST=Added new tests. Change-Id: I78ba388bae02610da631648fc939da24a3b0c32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475159 Reviewed-by: Mitsuru Oshima (OOO til 3/4) <oshima@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#637346} ash/BUILD.gn | 7 + ash/ash_strings.grd | 12 ++ .../IDS_ASH_DESKS_DESK_1_MINI_VIEW_TITLE.png.sha1 | 1 + .../IDS_ASH_DESKS_DESK_2_MINI_VIEW_TITLE.png.sha1 | 1 + .../IDS_ASH_DESKS_DESK_3_MINI_VIEW_TITLE.png.sha1 | 1 + .../IDS_ASH_DESKS_DESK_4_MINI_VIEW_TITLE.png.sha1 | 1 + ash/resources/vector_icons/BUILD.gn | 3 +- .../vector_icons/desks_close_desk_button.icon | 18 ++ ...desk_button.icon => desks_new_desk_button.icon} | 0 ash/wm/desks/close_desk_button.cc | 88 ++++++++++ ash/wm/desks/close_desk_button.h | 38 ++++ ash/wm/desks/desk.cc | 12 ++ ash/wm/desks/desk.h | 26 +++ ash/wm/desks/desk_mini_view.cc | 192 +++++++++++++++++++++ ash/wm/desks/desk_mini_view.h | 74 ++++++++ ash/wm/desks/desks_bar_view.cc | 143 ++++++++++++++- ash/wm/desks/desks_bar_view.h | 57 +++++- ash/wm/desks/desks_controller.cc | 56 +++++- ash/wm/desks/desks_controller.h | 48 +++++- ash/wm/desks/desks_unittests.cc | 178 +++++++++++++++++++ ash/wm/desks/new_desk_button.cc | 4 +- ash/wm/desks/new_desk_button.h | 3 +- ash/wm/overview/overview_grid.cc | 38 +++- ash/wm/overview/overview_grid.h | 9 + 24 files changed, 981 insertions(+), 29 deletions(-) commit a50d614e609a52650bfe0a9bbb807a9c1f798cf4 Author: mrefaat <mrefaat@chromium.org> Date: Mon Mar 4 18:04:14 2019 +0000 Reland "Reduce the use of tabModel & Tab inside SideSwipeController" This reverts commit 1adce0d68381f64b3c4d797f83be278fb85e4c78. Reason for revert: crash was fixed in CL: https://chromium-review.googlesource.com/c/chromium/src/+/1489097 Original change's description: > Revert "Reduce the use of tabModel & Tab inside SideSwipeController" > > This reverts commit 51252b4e6003fb9c7033792254d1da2aa2754ab3. > > Reason for revert: suspect causing following failures: > Failure ios_chrome_integration_egtests (iPhone 6s iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 0 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 1 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 2 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 3 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 4 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 5 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone 6s iOS 11.4) shard 6 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.4) shard 0 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.4) shard 1 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPad Air 2 iOS 11.4) shard 2 on Mac-10.13.6 > Failure ios_chrome_manual_fill_egtests (iPad Air 2 iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_web_egtests (iPad Air 2 iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_settings_egtests (iPad Air 2 iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_reading_list_egtests (iPad Air 2 iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPad Air 2 iOS 12.1) shard 0 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPad Air 2 iOS 12.1) shard 1 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPad Air 2 iOS 12.1) shard 2 on Mac-10.13.6 > Failure ios_chrome_manual_fill_egtests (iPad Air 2 iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_web_egtests (iPad Air 2 iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_settings_egtests (iPad Air 2 iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_reading_list_egtests (iPad Air 2 iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPhone X iOS 11.4) shard 0 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPhone X iOS 11.4) shard 1 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPhone X iOS 11.4) shard 2 on Mac-10.13.6 > Failure ios_chrome_manual_fill_egtests (iPhone X iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_web_egtests (iPhone X iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_settings_egtests (iPhone X iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_reading_list_egtests (iPhone X iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPhone X iOS 12.1) shard 0 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPhone X iOS 12.1) shard 1 on Mac-10.13.6 > Failure ios_chrome_bookmarks_egtests (iPhone X iOS 12.1) shard 2 on Mac-10.13.6 > Failure ios_chrome_manual_fill_egtests (iPhone X iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_web_egtests (iPhone X iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_settings_egtests (iPhone X iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_reading_list_egtests (iPhone X iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_integration_egtests (iPhone X iOS 11.4) on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 0 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 1 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 2 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 3 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 4 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 5 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 11.4) shard 6 on Mac-10.13.6 > Failure ios_chrome_integration_egtests (iPhone X iOS 12.1) on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 0 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 1 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 2 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 3 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 4 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 5 on Mac-10.13.6 > Failure ios_chrome_ui_egtests (iPhone X iOS 12.1) shard 6 on Mac-10.13.6 > E.g. > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-slimnav/2663 > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8920655452558829376/+/steps/ios_chrome_integration_egtests__iPhone_6s_iOS_11.4__on_Mac-10.13.6/0/logs/crash_report__2019-02-24-004004_/0 > --- > [12:39:57:INFO] Signal caught: Segmentation fault: 11 > [12:39:57:INFO] 0 EarlGrey 0x0000000118432321 grey_signalHandler + 225 > [12:39:57:INFO] 1 libsystem_platform.dylib 0x000000011e6e1f5a _sigtramp + 26 > [12:39:57:INFO] 2 ??? 0x00007ffeef3c5f08 0x0 + 140732912131848 > [12:39:57:INFO] 3 ios_chrome_integration_egtests 0x0000000101e3d1c9 -[SideSwipeController webStateList:didChangeActiveWebState:oldWebState:atIndex:reason:] + 121 > [12:39:57:INFO] 4 ios_chrome_integration_egtests 0x00000001017fdec6 _ZN26WebStateListObserverBridge19WebStateActivatedAtEP12WebStateListPN3web8WebStateES4_ii + 246 > [12:39:57:INFO] 5 ios_chrome_integration_egtests 0x00000001017f79f9 _ZN12WebStateList29NotifyIfActiveWebStateChangedEPN3web8WebStateEi + 329 > [12:39:57:INFO] 6 ios_chrome_integration_egtests 0x00000001017f81ec _ZN12WebStateList16DetachWebStateAtEi + 1964 > [12:39:57:INFO] 7 ios_chrome_integration_egtests 0x00000001017f831f _ZN12WebStateList15CloseWebStateAtEii + 79 > [12:39:57:INFO] 8 ios_chrome_integration_egtests 0x00000001017f4bb9 _ZN12WebStateList17CloseAllWebStatesEi + 73 > --- > > Original change's description: > > Reduce the use of tabModel & Tab inside SideSwipeController > > > > Tab and tab model are heavily used inside this class. Use > > WebStateListObserver instead of tabModel observer for ActiveTabChange. > > > > Bug: 930816, 931852 > > Change-Id: Ib8cd6ded93077986439030631e42bea0590a4aec > > Reviewed-on: https://chromium-review.googlesource.com/c/1480826 > > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#634992} > > TBR=rohitrao@chromium.org,mrefaat@chromium.org > > Change-Id: Ica1cbb060ba1758cf06dfc5e8e409cde18fdfb22 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 930816, 931852 > Reviewed-on: https://chromium-review.googlesource.com/c/1484888 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#635014} TBR=rohitrao@chromium.org,tasak@google.com,mrefaat@chromium.org Bug: 930816, 931852 Change-Id: Idd8b6489386acc78ffff126b71ec4c78f1ba2102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492479 Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#637345} ios/chrome/browser/ui/side_swipe/BUILD.gn | 1 + .../browser/ui/side_swipe/side_swipe_controller.mm | 64 +++++++++++++--------- .../side_swipe/side_swipe_controller_unittest.mm | 37 ++++++++++++- 3 files changed, 76 insertions(+), 26 deletions(-) commit d1ab6a845d5f1421df25711e31ec314458c3670f Author: Katie D <katie@chromium.org> Date: Mon Mar 4 18:03:02 2019 +0000 Updates autoclick ring widget size from movement threshold. This is only changed if the user has enabled experimental autoclick features using the feature flag. In the autoclick design, the ring widget will express to the user how much movement tolerance is available with the size. The animation will progress radially rather than shrinking. Bug: 894907 Change-Id: Id6e71771d4d2acc5d2ac866544d3d62b3d781a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497593 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#637344} ash/accessibility/accessibility_controller.cc | 2 +- ash/autoclick/autoclick_controller.cc | 17 ++++++++++ ash/autoclick/autoclick_controller.h | 11 +++--- ash/autoclick/autoclick_ring_handler.cc | 49 ++++++++++++++++++++------- ash/autoclick/autoclick_ring_handler.h | 4 +++ ash/autoclick/autoclick_unittest.cc | 4 +-- 6 files changed, 65 insertions(+), 22 deletions(-) commit 60969fedfc8c34834f0ae77abe7993f631776fc5 Author: Shahbaz Youssefi <syoussefi@chromium.org> Date: Mon Mar 4 18:02:56 2019 +0000 Enable EXT_sRGB webgl tests on ANGLE Bug: angleproject:2900 Tbr: zmo@chromium.org Tbr: geofflang@chromium.org Change-Id: I36af24cc9855263f719833b1e6301120ba0a368c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488716 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#637343} content/test/gpu/gpu_tests/webgl_conformance_expectations.py | 2 -- 1 file changed, 2 deletions(-) commit f2e3b0b65f418cbe60dcf3e7692ecfe2ffc95ef8 Author: Jonathan Backer <backer@chromium.org> Date: Mon Mar 4 18:01:52 2019 +0000 Seed the GPU fuzzers with SharedImages GLES2Decoder and RasterDecoder have APIs that take a mailbox to a SharedImage as input. Currently those APIs exit early on an invalid mailbox when called by the fuzzer. By seeding shared_image_manager_ with some SharedImages, we should get better code coverage. Bug: 936016 Change-Id: I5654041996deac877fa7395de130bb95a343f5a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499599 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637342} gpu/command_buffer/tests/fuzzer_main.cc | 34 ++++++++++++++++++++++++++++----- 1 file changed, 29 insertions(+), 5 deletions(-) commit a20dce4d30b71b1ab544b4654733229e7e74bc16 Author: Carlos IL <carlosil@chromium.org> Date: Mon Mar 4 18:01:29 2019 +0000 Call HandleSSLError without posting from nav throttle. Race conditions were likely the cause of a crash in HandleSSLErorr if a web contents was destroyed after a call to HandleSSLError was posted, but before it ran. As a candidate fix a PostTask was removed, and the call is now done syncrhonously. This also required adding a post task when SSLErrorHandler calls ShowInterstitial in order to give the throttle time to defer the navigation. Bug: 931714 Change-Id: I2ada8fb861c4c5927f0482ab7738367e0c8decf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497595 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#637341} chrome/browser/ssl/ssl_error_handler.cc | 7 ++++--- chrome/browser/ssl/ssl_error_handler.h | 2 ++ .../browser/ssl/ssl_error_navigation_throttle.cc | 23 ++++++++++------------ 3 files changed, 16 insertions(+), 16 deletions(-) commit 5a7555320840dfe81e7fcae23fd8a8309204c563 Author: Egor Pasko <pasko@chromium.org> Date: Mon Mar 4 17:58:45 2019 +0000 Revert "Add stacktrace scripts to telemetry isolate" This reverts commit 9adaa9cf5c0293acf4aea581d73a7cd6009a738b. Reason for revert: crbug.com/937796 (perf-go-webview-phone failing power.typical_10_mobile) Original change's description: > Add stacktrace scripts to telemetry isolate > > Add the crashpad stack walking scripts to the isolate that runs > performance tests with Telemetry. > > There are multiple places where the python scripts can be inserted as > 'data' dependencies. In the end choosing the place closest to where the > native third_party/breakpad tools are pulled in. > > I checked that after the change the isolate 'performance_test_suite' > (defined in testing/buildbot/gn_isolate_map.pyl) actually contains the > new files. I used this command: > > shell> python tools/mb/mb.py isolate out/Release performance_test_suite > > Bug: 935979 > Change-Id: Id6ecafc9510ef84762ce21efa537ed643f2ea251 > Reviewed-on: https://chromium-review.googlesource.com/c/1497076 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637171} TBR=pasko@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 935979 Change-Id: I70707eb2c4c29c405f989f137b8f01a081967334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496370 Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#637340} tools/perf/chrome_telemetry_build/BUILD.gn | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) commit 3bbfb84df44e164ffb132e9735e602ceba0c0c5f Author: Daniel Bratell <bratell@opera.com> Date: Mon Mar 4 17:57:14 2019 +0000 Drop crash workaround for scrollbar clicking An unrelated code change made bokan notice an old crash fix workaround from 2007[1] that should not be needed anymore. Save some code complexity by removing that workaround. [1] https://chromium.googlesource.com/chromium/src/+/eeca720ce09f9b6b22f23041b332a46ab42030a1 Change-Id: Ie6de426e8c0c13c7ce6b90fa3554f4fbf7c03366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497142 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#637339} third_party/blink/renderer/core/input/event_handler.cc | 14 -------------- 1 file changed, 14 deletions(-) commit e3aedc430f6098cdacccbb342638ae3f43d5ac86 Author: Amit Hilbuch <amithi@chromium.org> Date: Mon Mar 4 17:52:29 2019 +0000 Exposing RID attribute in RTCRtpCodingParameters. The RID attribute needs to be supplied when setting up simulcast using addTransceiver() and when updating the encoding parameters on the sender when simulcast is used (getParameters(), setParameters()). This change exposes the RIDs and validates that they cannot be modified when changing parameters on the sender. Bug: webrtc:10299 Bug: chromium:857034 Change-Id: I8b4bfa2b362ab5851a95c6fb90cc385daa4f651f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483352 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637338} .../peerconnection/rtc_rtp_coding_parameters.idl | 4 +-- .../modules/peerconnection/rtc_rtp_sender.cc | 18 ++++++++++-- .../webrtc/RTCRtpParameters-encodings-expected.txt | 2 +- .../wpt/webrtc/RTCRtpParameters-encodings.html | 4 +-- .../external/wpt/webrtc/protocol/README.txt | 2 ++ .../wpt/webrtc/protocol/simulcast-offer.html | 33 ++++++++++++++++++++++ .../peerconnection/RTCRtpSender-getParameters.html | 2 +- .../RTCRtpSender-setParameters-expected.txt | 4 +-- .../webrtc/protocol/simulcast-offer-expected.txt | 4 +++ 9 files changed, 62 insertions(+), 11 deletions(-) commit a19c5537d50944f1b7248fcfc8099aeaf8548793 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 4 17:51:36 2019 +0000 flags: remove enable-background-blur The backing feature is still used on a per-platform basis: https://chromium.googlesource.com/chromiumos/platform2/+/refs/heads/master/login_manager/chrome_setup.cc#434 Bug: 765292 Change-Id: I100801466d09ee76ea4e4102d68574773a3cb286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487883 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637337} chrome/browser/about_flags.cc | 7 ------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 4 ---- chrome/browser/flag_descriptions.h | 3 --- 4 files changed, 19 deletions(-) commit 43a6dd26e3655ae4988f243fce2761fecafadedf Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Mar 4 17:51:03 2019 +0000 Convert away from method JSONReader::ReadDeprecated Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value>. Bug: 925165 Change-Id: I771fd8ac7ff8ef6a3d3cf77b9f27b1051e39fcb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496980 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#637336} ios/web/web_state/web_frame_impl_unittest.mm | 65 ++++++++++++++-------------- 1 file changed, 32 insertions(+), 33 deletions(-) commit 89f5ffd8775960fbe9ccf88e5ff186af9129058f Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Mon Mar 4 17:46:42 2019 +0000 Android: Fix NPE accessing Tab https://crrev.com/c/1480352 left out a null check against Tab, therefore caused the reported the crash. This CL fixes the bug. Bug: 937705 Change-Id: I1d38f4ea50f6d53c15dd25ece6b31d826d2e4bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498261 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#637335} .../java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 09acfbed2e16a2a047114eb5a29e176271d6b4c2 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Mon Mar 4 17:43:31 2019 +0000 [vr] Fix GVR JNI calls GVR Java code couldn't resolve JNI calls on Monochrome. To fix this, link the native JNI functions into the monochrome build. Bug: 936785 Binary-Size: Adding functions inadvertently removed in crrev/c/1479586 Change-Id: I1058f6965906b5b7517ac518e64011f8888591c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497383 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#637334} chrome/app/android/chrome_jni_onload.h | 2 -- chrome/browser/android/vr/BUILD.gn | 2 ++ chrome/browser/android/vr/register_gvr_jni.cc | 36 +++++++++++++++++++++++++++ chrome/browser/android/vr/register_gvr_jni.h | 16 ++++++++++++ chrome/browser/android/vr/register_jni.cc | 32 ++++++------------------ 5 files changed, 62 insertions(+), 26 deletions(-) commit 8c34a4a01df8c143aab79b1164a7618c4bf3d82e Author: Jenny Zhang <jennyz@chromium.org> Date: Mon Mar 4 17:43:12 2019 +0000 Fix the vk flashing issue when closing remove query dialog. The code removed in AppListPresenterImpl::OnWindowFocused causes vk to close when removal dialog closes and give focus back to launcher search box; and the original issue it intends to fix does not need this code either. Therefore, remove the code now. Bug: 937052 Change-Id: Iad3f395183f4c568ac8e08079f8212a6803243d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497757 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637333} ash/app_list/presenter/BUILD.gn | 1 - ash/app_list/presenter/app_list_presenter_impl.cc | 7 ------- 2 files changed, 8 deletions(-) commit 574d520f539ae9efceb6fc52ec8d69dcce9c5c58 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 17:41:41 2019 +0000 Roll src-internal c51a3ddd3012..a72882291163 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c51a3ddd3012..a72882291163 Created with: gclient setdep -r src-internal@a72882291163 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I59e1e59f330b4428a7b2528c5102f58273183637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499654 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637332} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 950bc1a85df9d7407e7751990ff9397df02091dd Author: Ayu Ishii <ayui@chromium.org> Date: Mon Mar 4 17:41:36 2019 +0000 Replace deprecated RunLoop::QuitCurrentWhenIdleClosureDeprecated() with Quit[WhenIdle]Closure() This change replaces base::RunLoop::QuitCurrentWhenIdleClosureDeprecated() call with a call to loop.QuitWhenIdleClosure() call on a local RunLoop instance. Bug: 922118 Change-Id: I2b4f5af4af3faebf06d5bae9715f026f9e769a82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496440 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#637331} chrome/test/base/browser_with_test_window_test.cc | 7 ++++--- chrome/test/base/interactive_test_utils_views.cc | 9 +++++---- 2 files changed, 9 insertions(+), 7 deletions(-) commit 01027f90b512d3276368a1c2b56082dcd43c5902 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 17:38:07 2019 +0000 Roll src/third_party/angle 4d153383bd3a..0e1ce2e55387 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/4d153383bd3a..0e1ce2e55387 git log 4d153383bd3a..0e1ce2e55387 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 jmadill@chromium.org Vulkan: Update code hash after roll. Created with: gclient setdep -r src/third_party/angle@0e1ce2e55387 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I5c5d198d5941f4d491bee715ec9803c87aad0711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499653 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637330} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 76c0fce42f994f030ce4d40da545e0c3dfce988e Author: Daniel Bratell <bratell@opera.com> Date: Mon Mar 4 17:37:17 2019 +0000 Remove variable shadowing in blink/animation In an effort to reduce or even ban variable shadowing, this renames and removes some variable. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warning this this avoids is: third_party/blink/renderer/core/animation/css/css_animations.cc:385:25: error: declaration shadows a local variable [-Werror,-Wshadow] for (wtf_size_t i = 0; i < css_animations->running_animations_.size(); ^ third_party/blink/renderer/core/animation/css/css_animations.cc:354:21: note: previous declaration is here for (wtf_size_t i = 0; i < name_list.size(); ++i) { ^ third_party/blink/renderer/core/animation/effect_input.cc:548:11: error: declaration shadows a local variable [-Werror,-Wshadow] auto* keyframe = keyframes.at(keys[i]); ^ third_party/blink/renderer/core/animation/effect_input.cc:429:69: note: previous declaration is here const v8::Local<v8::Object>& keyframe, ^ third_party/blink/renderer/core/animation/list_interpolation_functions.cc:142:26: error: declaration shadows a local variable [-Werror,-Wshadow] InterpolationValue start( ^ third_party/blink/renderer/core/animation/list_interpolation_functions.cc:82:26: note: previous declaration is here InterpolationValue&& start, ^ third_party/blink/renderer/core/animation/list_interpolation_functions.cc:145:26: error: declaration shadows a local variable [-Werror,-Wshadow] InterpolationValue end(end_interpolable_list.Get(i % end_length)->Clone(), ^ third_party/blink/renderer/core/animation/list_interpolation_functions.cc:83:26: note: previous declaration is here InterpolationValue&& end, ^ third_party/blink/renderer/core/animation/list_interpolation_functions.cc:147:34: error: declaration shadows a local variable [-Werror,-Wshadow] PairwiseInterpolationValue result = ^ third_party/blink/renderer/core/animation/list_interpolation_functions.cc:138:32: note: previous declaration is here PairwiseInterpolationValue result = nullptr; ^ Bug: 923510 Change-Id: I6c7180f8ff481cee78045ae9aa24bd4dd9631d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495544 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#637329} .../blink/renderer/core/animation/css/css_animations.cc | 8 ++++---- third_party/blink/renderer/core/animation/effect_input.cc | 8 ++++---- .../renderer/core/animation/list_interpolation_functions.cc | 12 ++++++------ 3 files changed, 14 insertions(+), 14 deletions(-) commit b9481b2d32cd3a6036ab2456df5608ccdf0b6eab Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Mar 4 17:35:39 2019 +0000 Remove GetAvatarIconForMenu() Bug: 937834 Change-Id: Id1263e42b94178b66aa6ba6c5c488702796c0288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499563 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#637328} chrome/browser/profiles/profile_avatar_icon_util.cc | 6 ------ chrome/browser/profiles/profile_avatar_icon_util.h | 4 ---- .../profiles/profile_avatar_icon_util_unittest.cc | 17 ----------------- 3 files changed, 27 deletions(-) commit 0cf1837553865da8d0a66e19084375e718630d99 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Mar 4 17:34:18 2019 +0000 unified-heap: Move all snapshot logic into cc file This is in preparation for integrating unified heap into snapshots. Move all logic into the cc file as there are no external dependencies. Bug: 936797 Change-Id: I6ad9418edbf0a6965cacd72057686e2c4e15fadc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499458 Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#637327} .../bindings/core/v8/v8_embedder_graph_builder.cc | 290 +++++++++++++++++---- .../bindings/core/v8/v8_embedder_graph_builder.h | 146 +---------- .../renderer/bindings/core/v8/v8_initializer.cc | 2 +- 3 files changed, 239 insertions(+), 199 deletions(-) commit 655563556988d2472bc940c16d811582c29146df Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Mar 4 17:27:58 2019 +0000 Move fonts related trace events in 'fonts' category This CL is doing the first batch of trace events migration to the new fonts category. R=gab@chromium.org,oysteine@chromium.org TBR=drott@chromium.org Bug: 937389 Change-Id: I297b028d0a28241be539efdb143d17aaf6463ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497183 Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637326} base/trace_event/builtin_categories.h | 3 +-- components/services/font/public/cpp/font_loader.cc | 12 ++++++------ .../dwrite_font_lookup_table_builder_win.cc | 11 ++++++----- .../renderer_host/dwrite_font_proxy_impl_win.cc | 10 +++++----- .../child/dwrite_font_proxy/dwrite_font_proxy_win.cc | 18 +++++++++--------- content/child/dwrite_font_proxy/font_fallback_win.cc | 4 ++-- 6 files changed, 29 insertions(+), 29 deletions(-) commit de4aa5cd97089590b1570677b7df6ad3f6defe49 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Mon Mar 4 17:25:53 2019 +0000 [Sync::USS] Merge local and remote passwords with the most recent When enabling sync for the first time, the local and remote passwords are merged to reach a unified view of passwords locally and on the sync server. Before this CL: if the same password exists both locally and remotely, the server version is used instead of the local one. This was similar to other data types. After this CL: if the same password exists both locally and remotely, the most recently created one is chosen and propagated to the server if necessary. This is similar to the directory implementation of password sync merge [1]. In addition this CL adds the corresponding integration test that covers this use case. [1]https://cs.chromium.org/chromium/src/components/password_manager/core/browser/sync/password_syncable_service.cc?g=0&l=399 Bug: 935989 Change-Id: I31da998fd803d96bacc52c57a577571640523886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496992 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#637325} .../integration/two_client_passwords_sync_test.cc | 53 +++++++ .../core/browser/sync/password_sync_bridge.cc | 156 +++++++++++++++++---- .../browser/sync/password_sync_bridge_unittest.cc | 89 ++++++++++-- 3 files changed, 256 insertions(+), 42 deletions(-) commit 4774820c7629bc4a38aa0eff619cf8341f72714a Author: Lan Wei <lanwei@chromium.org> Date: Mon Mar 4 17:23:11 2019 +0000 Set ui::Event's coordinates correctly in SyntheticGestureTargetAura In ConvertLocationToTarget function, the offset added to the event location is not scaled, so we should apply the screen scale factor to the event location after it has been transformed to the target. Then we can find the right target to send the event using the correct coordinates. Bug: 606367 Change-Id: Ic9f3f8ec769e669ed4c506231edb15f495a8544a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496594 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#637324} .../input/synthetic_gesture_target_aura.cc | 54 +++++++++++++--------- .../synthetic-events/tap-on-scaled-screen.html | 24 ++++++++-- 2 files changed, 51 insertions(+), 27 deletions(-) commit cc0308cea417360c8701c0bf5bfcf3d22aac40fa Author: David 'Digit' Turner <digit@google.com> Date: Mon Mar 4 17:21:47 2019 +0000 android: crazy_linker: Fix search path handling. This CL gets rid of the context-specific search path and Java VM instance in the crazy linker, and moves these to global variables only. This ensures that wrapped dlopen() operations use the same search paths / VM information as the loading operations that are performed through a crazy_context_t. Doing otherwise could lead to surprising results (e.g. a dlopen() call failing because it could not find a library at the right location, or failing to call JNI_OnLoad() as required). It is hoped that this fixes some issues when loading native libraries from bundle DFMs. crazy_context_t is now a simple holder for an error message and a load address, but it is simpler to keep it as is than trying to refactor the rest of the crazy linker API. + Fix the crazy_linker_test_jni_hooks test program and its associated native library, and ensure they are run properly when calling run_android_crazy_linker_tests. BUG=936001 R=pasko@chromium.org, cjgrant@chromium.org, tiborg@chromium.org, benmason@chromium.org Change-Id: I222913a83547f9107dde0b568a9a1ba840ecee7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499535 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: David Turner <digit@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#637323} base/android/linker/linker_jni.cc | 13 ++-- third_party/android_crazy_linker/BUILD.gn | 19 ++++++ .../src/include/crazy_linker.h | 58 +++++++---------- third_party/android_crazy_linker/src/run_tests.sh | 2 + .../src/src/crazy_linker_api.cpp | 75 ++++++++-------------- .../src/src/crazy_linker_globals.h | 18 ++++++ .../src/src/crazy_linker_library_list.cpp | 35 ++++++---- .../src/src/crazy_linker_shared_library.cpp | 10 +-- .../src/src/crazy_linker_shared_library.h | 5 +- .../src/tests/bench_load_library.cpp | 3 +- .../android_crazy_linker/src/tests/jni_lib.cpp | 1 + .../src/tests/test_jni_hooks.cpp | 10 +-- .../src/tests/test_search_path_list.cpp | 10 +-- .../src/tests/test_two_shared_relros.cpp | 2 +- 14 files changed, 139 insertions(+), 122 deletions(-) commit b7bbcd9a253cc265ccbe94e3b5f9ed5f26a1879a Author: David Bokan <bokan@chromium.org> Date: Mon Mar 4 17:21:35 2019 +0000 Fix doubletap-to-jump-forwards.html In https://chromium-review.googlesource.com/c/chromium/src/+/1496244 I modified media/controls/modern/doubletap-to-jump-forwards.html to wait until the gesture is completed before finishing the test. I accidentally moved the assertion to happen after the gesture was completed to, resulting in a changed value in slow builds. Bug: 937215 Change-Id: I364769ec0cc70685a6d743bff2894a1ea5fb38dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497112 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#637322} third_party/blink/web_tests/TestExpectations | 2 -- .../media/controls/modern/doubletap-to-jump-forwards.html | 7 +++---- 2 files changed, 3 insertions(+), 6 deletions(-) commit 88d19d4adba4356b7c2e5dc76424dbe8a54ba0da Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 4 17:19:04 2019 +0000 flags: remove enable-content-suggestions-new-favicon-server Bug: None Change-Id: I1092f3cedd6195c5d732fe981c9a338e94b5c41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489572 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#637321} .../java/src/org/chromium/chrome/browser/ChromeFeatureList.java | 2 -- .../org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java | 5 ----- chrome/browser/about_flags.cc | 5 ----- chrome/browser/android/chrome_feature_list.cc | 1 - chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- components/ntp_snippets/features.cc | 5 ----- components/ntp_snippets/features.h | 3 --- 9 files changed, 35 deletions(-) commit df69de004afb944b056ef7a0ba5a48724337f581 Author: Emil A Eklund <eae@chromium.org> Date: Mon Mar 4 17:18:30 2019 +0000 [LayoutNG] Handle empty runs in LineLeftBounds Handle empty runs in ShapeResult::LineLeftBounds and LineRightBounds as unmatched/stand-alone combining mark characters may produce empty runs. Bug: 923962 Test: fast/text/international/standalone_virama_mark.html Change-Id: I40d131c68c3eb9f8e9d60a70c1a66501514ab1a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497119 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637320} .../blink/renderer/platform/fonts/shaping/shape_result.cc | 7 ++++--- .../text/international/standalone_virama_mark-expected.txt | 3 +++ .../fast/text/international/standalone_virama_mark.html | 14 ++++++++++++++ 3 files changed, 21 insertions(+), 3 deletions(-) commit 350a015b407ddf8b39d9844a26e9ce39d0e3fe6a Author: Leonard Grey <lgrey@chromium.org> Date: Mon Mar 4 17:10:50 2019 +0000 Dark mode: update profile badge colors Bug: 933939 Change-Id: Ica06fc5539238fbaa03243ae9cefd1130d07f97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497354 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#637319} .../ui/views/profiles/badged_profile_photo.cc | 26 ++++++++++++++++------ 1 file changed, 19 insertions(+), 7 deletions(-) commit a598b0f661ace9c2729accf9312df9712ab4efe6 Author: Ria Jiang <riajiang@chromium.org> Date: Mon Mar 4 17:10:19 2019 +0000 Include hit-test data for pointer-events:none regions and set Ignore. Right now we skip regions with pointer-events:none when preparing hit-test data to avoid sending events to them, which breaks transforming requests to those regions. This CL updates it to always send hit-test data for pointer-events:none regions and set kHitTestIgnore flag and only ignores them when doing targeting in HitTestQuery. PointerEventsNoneOOPIF/1 SitePerProcessHitTestBrowserTest. SurfaceHitTestPointerEventsNoneChanged/1 Bug: 934007 Test: SitePerProcessHitTestDataGenerationBrowserTest. Change-Id: If82cfd71d6504badd0a74d64fbfd9a1f214ef23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487850 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#637318} .../viz/common/hit_test/hit_test_data_builder.cc | 15 ++++--- components/viz/host/hit_test/hit_test_query.cc | 6 ++- .../site_per_process_hit_test_browsertest.cc | 52 ++++++++++++++++------ 3 files changed, 50 insertions(+), 23 deletions(-) commit 877d48ae4144c653d5488288e53761c5230b4df2 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Mon Mar 4 17:05:11 2019 +0000 [tools/perf] Disable failing load_accessibility:media:wikipedia:2018 Test is consistently causing Chrome to crash in Linux Tests (dbg). NOTRY=true TBR=crouleau@chromium.org Bug: 934885 Change-Id: Ic33a4cc1d4e35aeddff89b1a9b70cf1828b29e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499564 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#637317} tools/perf/expectations.config | 1 + 1 file changed, 1 insertion(+) commit 1ae0bc499f4aa1387a99dcad7f6bb28020895f36 Author: Brian Osman <brianosman@google.com> Date: Mon Mar 4 17:01:42 2019 +0000 Use Skia drawing when doing conversion operations that may need dither Skia plans to remove the automatic dithering during readPixels/writePixels. This change retains dithering (and thus image quality) on low-end devices. Bug: chromium:720105 skia:8787 Change-Id: I8c593f0f72953bcfbed5b5107db262beb4a60ad4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495208 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#637316} cc/raster/raster_buffer_provider.cc | 8 ++++++-- .../renderer/platform/graphics/decoding_image_generator.cc | 13 +++++++++++-- 2 files changed, 17 insertions(+), 4 deletions(-) commit 291c3775e0c5ca8057d1ce9c35136d8b8bb95ecc Author: Takuto Ikuta <tikuta@chromium.org> Date: Mon Mar 4 16:52:02 2019 +0000 [zip_analyzer] remove unused include Bug: 242216 Change-Id: Ie4999f14f3d918f04d9ba201e7ca6ca92d7fe41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498972 Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#637315} chrome/common/safe_browsing/zip_analyzer.h | 1 - 1 file changed, 1 deletion(-) commit b3639feeca1b61b94ea3c2cc4e41ee5335f452a5 Author: kylechar <kylechar@chromium.org> Date: Mon Mar 4 16:51:25 2019 +0000 Use base::BindOnce for Post[Delayed]TaskWithTraits callbacks. Post[Delayed]TaskWithTraits() takes a OnceCallback. Replace usage of base::Bind(), which produces a RepeatingCallback, with base::BindOnce() when the callback is created as a temporary inside of PostTask(). The following regex was used to find instances that could be replaced: (Post(?:Delayed)?TaskWithTraits)\((?:\n\s*)?FROM_HERE,\n?\s*(\{.*?\n?.*?\}),(?:\n)?\s*base::Bind\( Also replace any usage of base::Passed(&var) with std::move(var) for variables passed to base::BindOnce(). base::Passed() isn't needed for move-only types with OnceCallbacks. This CL was uploaded by git cl split. R=rohitrao@chromium.org Bug: 714018 Change-Id: I619d9e143a5c477b5846b1c2c30dcc5917f1e976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486671 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#637314} .../app/application_delegate/app_state_unittest.mm | 2 +- .../app/application_delegate/metrics_mediator.mm | 2 +- .../chrome_browser_state_impl_io_data.mm | 2 +- .../browser_state/chrome_browser_state_io_data.mm | 7 +++--- .../chrome_browser_state_manager_impl.cc | 2 +- ios/chrome/browser/omaha/omaha_service.mm | 15 +++++++------ ios/chrome/browser/sync/glue/sync_start_util.cc | 2 +- .../browser/sync/profile_sync_service_factory.cc | 4 ++-- ios/components/io_thread/ios_io_thread.mm | 4 ++-- ios/web/app/web_main_loop.mm | 4 ++-- ios/web/net/cookie_notification_bridge.mm | 2 +- ios/web/net/request_tracker_impl.mm | 26 +++++++++++----------- ios/web/webui/url_data_manager_ios.cc | 9 ++++---- ios/web/webui/url_data_manager_ios_backend.mm | 4 ++-- ios/web/webui/url_data_source_ios_impl.cc | 4 ++-- 15 files changed, 46 insertions(+), 43 deletions(-) commit 1b8eda64349a550d71c8d88b3a9e879744ccc39a Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Mar 4 16:50:21 2019 +0000 Mark StylePropertyMapReadOnly methods const Bug: None Change-Id: I5ce4eed8267b42893d694810c1a28cc1d778cb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497217 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#637313} .../core/css/cssom/computed_style_property_map.cc | 10 +++++----- .../core/css/cssom/computed_style_property_map.h | 10 +++++----- .../core/css/cssom/declared_style_property_map.cc | 8 ++++---- .../core/css/cssom/declared_style_property_map.h | 8 ++++---- .../core/css/cssom/inline_style_property_map.cc | 9 +++++---- .../core/css/cssom/inline_style_property_map.h | 8 ++++---- .../renderer/core/css/cssom/paint_worklet_input.h | 4 +++- .../core/css/cssom/paint_worklet_style_property_map.cc | 8 ++++---- .../core/css/cssom/paint_worklet_style_property_map.h | 12 ++++++------ .../css/cssom/paint_worklet_style_property_map_test.cc | 10 +++++----- .../cssom/prepopulated_computed_style_property_map.cc | 8 ++++---- .../cssom/prepopulated_computed_style_property_map.h | 8 ++++---- .../core/css/cssom/style_property_map_read_only.h | 8 ++++---- .../cssom/style_property_map_read_only_main_thread.cc | 10 +++++----- .../cssom/style_property_map_read_only_main_thread.h | 18 +++++++++--------- 15 files changed, 71 insertions(+), 68 deletions(-) commit ecada475c4d69477d45e02a73b0e303ffe4e2164 Author: Stephane Zermatten <szermatt@chromium.org> Date: Mon Mar 4 16:47:46 2019 +0000 [Autofill Assistant] Allow scripts to specify Cancel or Close actions. This change allows scripting Close and Cancel buttons, with an UNDO snackbar. It also allows scripting the show details confirmation dialog, which closes the CCT. This change adds a new chip_type field to the scripts and choices of the prompt action to point out that a chip is: - a suggestion - a normal action, with a hairline button - a highlighted action, with a blue button - a cancel action, with a hairline button. A snackbar is shown before executing the action. - a close action, with a hairline button. If either a cancel or a close action is present on the list of actions, the UI does not add an implicit cancel button. The Stop action can now optionally close the CCT, to allow scripting the "Go Back" button of the show details action. Bug: b/125245527 Change-Id: I84c0da5bef78aec8d4ddc01d08a1d904d64ec5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491657 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#637312} .../AutofillAssistantUiController.java | 125 +++++++++--------- .../autofill_assistant/carousel/AssistantChip.java | 17 ++- .../carousel/AssistantChipViewHolder.java | 6 +- .../AutofillAssistantUiTest.java | 5 +- .../autofill_assistant/ui_controller_android.cc | 142 ++++++++++++++------- .../autofill_assistant/ui_controller_android.h | 8 +- components/autofill_assistant/browser/BUILD.gn | 1 - .../browser/actions/prompt_action.cc | 19 +-- .../browser/actions/show_details_action.cc | 56 +------- .../browser/actions/show_details_action.h | 6 - .../browser/actions/stop_action.cc | 6 +- components/autofill_assistant/browser/chip.cc | 19 ++- components/autofill_assistant/browser/chip.h | 20 +-- .../autofill_assistant/browser/controller.cc | 16 +-- .../autofill_assistant/browser/protocol_utils.cc | 2 +- components/autofill_assistant/browser/script.h | 3 +- .../autofill_assistant/browser/script_tracker.cc | 2 +- .../autofill_assistant/browser/service.proto | 56 ++++++-- 18 files changed, 284 insertions(+), 225 deletions(-) commit e9aa20fd6702db58135773a650bc4cbd1c542350 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Mon Mar 4 16:45:27 2019 +0000 Fix caret rendering when at the end of a block after an ineditable inline AdjustBlockFlowPositionToInline() has an early-reject branch that avoids infinite recursion, introduced in crrev.com/664b6437. However, the early reject condition is too aggressive that, it also rejects some positions that don't enter an infinite recursion, like the one used in the new unit test added in this CL. As now AdjustBlockFlowPositionToInline() has a hard limit on recursion depth, this CL safely removes the over-aggressive reject condition, so that caret can be correctly rendered for more positions. Note: Unit test InlineBoxPositionTest.ComputeInlineBoxPositionMixedEditable uses another position that doesn't enter the infinite loop but is falsely rejected by the condition. This patch allows caret rendering also for that position, and therefore changes its test expectation. Bug: 936988 Change-Id: Idef91ffaa412e67cddd5fcf0dd61f54055de7189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497466 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#637311} .../blink/renderer/core/editing/inline_box_position.cc | 3 +-- .../renderer/core/editing/inline_box_position_test.cc | 7 +++++-- .../renderer/core/editing/local_caret_rect_test.cc | 17 +++++++++++++++++ 3 files changed, 23 insertions(+), 4 deletions(-) commit b1dae0f105bbcd2911bb37debaa75ad2de9f0a73 Author: Thomas Tangl <tangltom@chromium.org> Date: Mon Mar 4 16:43:34 2019 +0000 Refactor GetRandomAvatarIconIndex - GetRandomAvatarIconIndex() is moved to profile_avatar_icon_util.h. - The method is refactored. - Code related to ChromeOS and Android is removed, because it is not used. Bug: 937834 Change-Id: I1b77212182b135adb99fd4566df1f985dcbe317f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499473 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#637310} .../browser/profiles/profile_attributes_storage.cc | 43 +--------------------- .../browser/profiles/profile_attributes_storage.h | 1 - .../profile_attributes_storage_unittest.cc | 7 ---- .../browser/profiles/profile_avatar_icon_util.cc | 14 +++++++ chrome/browser/profiles/profile_avatar_icon_util.h | 6 +++ 5 files changed, 22 insertions(+), 49 deletions(-) commit 251e00b194b9eaa5a61929f86406b4432cf7711e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 4 16:38:50 2019 +0000 Roll src-internal 794439738e8e..c51a3ddd3012 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/794439738e8e..c51a3ddd3012 Created with: gclient setdep -r src-internal@c51a3ddd3012 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I1daa42ebccc3405efe15d45c6f5605d5427bdd54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498862 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637309} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1b7072cf8f6a373f7e71f882ef164f480bd52b58 Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 16:38:44 2019 +0000 Mark external/wpt/ambient-light/AmbientLightSensor.https.html flaky on debug bots TBR=reillyg@chromium.org NOTRY=true Bug: 937858 Change-Id: I4f616249c3e1ca1aa04bfe4546ef6c2c376047b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499715 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637308} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit bce39515ca8c2d2f28f6edb649d06e45f4172784 Author: Takuto Ikuta <tikuta@chromium.org> Date: Mon Mar 4 16:32:15 2019 +0000 [reading_list] remove unused deps reading_list.proto does not use anything in //components/sync/protocol Bug: 937723 Change-Id: Id5b7ed13a6e72c484b693d757e7913d81a3aff0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498749 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637307} components/reading_list/core/proto/BUILD.gn | 3 --- 1 file changed, 3 deletions(-) commit 74a8ba0daa4aa37f9fd81639c9c2423480ff29f2 Author: Monica Salama <msalama@google.com> Date: Mon Mar 4 16:30:48 2019 +0000 Android: Fix orderfile clankium bot failure. The orderfile generator expects the bot to have only 1 device connected which is not the case as a consequence we get an assertion error. Instead, a check is added that at least one device is connected. In case of many devices connected, favor the first device running arm64 if it exists otherwise use the first device on the list of devices. Bug: 937800 Bug: 931699 Change-Id: Iaae33ee9bc659069b0c124ce0946ba1b02daf5ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499534 Reviewed-by: Benoit L <lizeb@chromium.org> Commit-Queue: Monica Salama <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#637306} tools/cygprofile/profile_android_startup.py | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) commit 11cfe5e07eff6145aba656b51363096c336bde13 Author: Josh Karlin <jkarlin@chromium.org> Date: Mon Mar 4 16:29:44 2019 +0000 [NetInfo] Fix memory leak RenderProcessHosts::AllHostsIterator is returning hosts that don't have a mojo client on the other end. And we kept sending messages on that channel which got buffered in memory each time the network changed. Temporary hack solution: Don't send the mojo message if the render client is dead or uninitialized. This is a hacky fix in line with others in https://crbug.com/813045. Bug: 813045 Change-Id: Ibaffd1bf0f62eb78335d0927cc11b97a3ebfa132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483936 Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637305} content/browser/net/browser_online_state_observer.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 5f9ec8d41e94444025254afbf68cb68c569d72af Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 4 16:28:43 2019 +0000 Roll src/third_party/webrtc 87e05b5df58c..b678940d3a44 (7 commits) https://webrtc.googlesource.com/src.git/+log/87e05b5df58c..b678940d3a44 git log 87e05b5df58c..b678940d3a44 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 srte@webrtc.org Using send time instead of system clock in quality scaler. 2019-03-04 srte@webrtc.org Replacing Clock in ScreenshareLayers. 2019-03-04 kwiberg@webrtc.org Add ability to unwind stack for the current thread 2019-03-04 sprang@webrtc.org Add full stack test with weak 3g-like properties 2019-03-04 hta@webrtc.org Revert "Another mock for GetSctpTransport" 2019-03-04 danilchap@webrtc.org Move rtc::NewClosure into own build target as ToQueuedTask 2019-03-04 hta@webrtc.org Another mock for GetSctpTransport Created with: gclient setdep -r src/third_party/webrtc@b678940d3a44 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:818643,chromium:818643 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I58e6565055ababddff596710e5e1f6b1e0f69912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498859 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637304} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cbe28129e579909f15f65388dac7e75fea4b25b9 Author: Yi Gu <yigu@chromium.org> Date: Mon Mar 4 16:20:52 2019 +0000 Mark external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/counter-styles-3/symbols-function.html as flaky Lots of mozilla imported tests started to be flaky recently. See linked bug for details. TBR=e...@chromium.org NOTRY=true Bug: 935689 Change-Id: Ibaa9c0dfe5ab6e0b2e1914303ac03bbe1a4bd644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499713 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#637303} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 4b69f93d616b4d1a40c35ff162233f89a436ddd8 Author: Matt Menke <mmenke@chromium.org> Date: Mon Mar 4 16:20:01 2019 +0000 Fix crash in ClientSocketPoolBaseHelper::GetLoadState. https://chromium-review.googlesource.com/c/chromium/src/+/14819 introduced a bug in the case the load state of request was being looked up when all requests in a group were bound to ConnectJobs - instead of looking at the state of the corresponding bound ConnectJob, it was looking at the state of the first unbound ConnectJob, and since there were no such ConnectJobs, it would crash. Bug: 937807, 472729 Change-Id: Iaefbb9cf0f337ae2ce901adf8962b486c030fbe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498782 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637302} net/socket/client_socket_pool_base.cc | 17 +++---- net/socket/client_socket_pool_base.h | 6 ++- net/socket/client_socket_pool_base_unittest.cc | 68 ++++++++++++++------------ 3 files changed, 49 insertions(+), 42 deletions(-) Updated tag 'tree_truth' (was 5afa5224471a)