Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 46423 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919798042567208288 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/ittZevWC/luci_context.880422798 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: gce-trusty-16-145e5bab-us-west1-c-nbdz SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43682f11d7d04c11 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 79d7f822d09d101a0ed5ae719b2d62f750c4cad2 [Sheriff]Disable network-blocked-reason.js Owen Min, Tue Mar 5 19:38:38 2019 +0000 63f406e87568af35c6c57b580d87cc541c2ad42a Bind MDNS sockets to the wildcard address on MAC OS X. Qingsi Wang, Tue Mar 5 19:36:28 2019 +0000 5b6dd5db1673273ba0b9403cef4be353a667c750 [vr] refactor UI drawing code. no-op Suman Kancherla, Tue Mar 5 19:34:41 2019 +0000 d39b1f10598e891a9533e5c17d9196ac079d91ec [PM] Retire kIsLoading property. Chris Hamilton, Tue Mar 5 19:34:28 2019 +0000 f2651134b7cc7b6da473e74ba020e8780d0ee1b4 [Duet] Browsing mode adaptive toolbar Pedro Amaral, Tue Mar 5 19:33:04 2019 +0000 31967edb598d37b6d2c4122164b8693e038d130f Roll src/third_party/angle 2f1c1d7eeebb..f094bac94992 (1 commits) chromium-autoroll, Tue Mar 5 19:25:29 2019 +0000 5c2534aaaad50a117d8764f0a94928177bcb3369 [Fuchsia] Don't call setsockopt(IP_MULTICAST_IF) Sergey Ulanov, Tue Mar 5 19:23:31 2019 +0000 ee86e1f5c556a24dddc3fe7306017e330bfe64ed Roll src/third_party/SPIRV-Tools/src 5fb83a97087d..86f6ac086c8b (1 commits) chromium-autoroll, Tue Mar 5 19:20:27 2019 +0000 1f9afb7d1514b845c6b323bddde5dda6b4eeb496 [GCPW] Allow customizing GLS application used for GCPW. Tien Mai, Tue Mar 5 19:19:24 2019 +0000 5fc84fd01f25cc932825c23768b100b8426cd576 perfetto: Manually roll to 30c1365e30b17cffc4fdc7fc56c27aee488226ec Eric Seckler, Tue Mar 5 19:19:19 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 79d7f822d09d101a0ed5ae719b2d62f750c4cad2 Author: Owen Min <zmin@chromium.org> Date: Tue Mar 5 19:38:38 2019 +0000 [Sheriff]Disable network-blocked-reason.js Disable flaky test Bug: 938200 TBR: petewil@chromium.org Change-Id: Iecbe1a710e39771cf3001f42e8f5e053c9fe6700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503999 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637770} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit 63f406e87568af35c6c57b580d87cc541c2ad42a Author: Qingsi Wang <qingsi@chromium.org> Date: Tue Mar 5 19:36:28 2019 +0000 Bind MDNS sockets to the wildcard address on MAC OS X. Bug: 899310, 931916 Change-Id: Iae166ec6ac0814ab761cf55365cc17768ecaa9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500782 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#637769} net/dns/public/util.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit 5b6dd5db1673273ba0b9403cef4be353a667c750 Author: Suman Kancherla <sumankancherla@chromium.org> Date: Tue Mar 5 19:34:41 2019 +0000 [vr] refactor UI drawing code. no-op This refactoring separates the responsibilities of VRBrowserRendererThreadWin and VrUiHost for drawing UI. Existing code requires two calls to show/hide UI. That has been reduced to one. That way, VrUiHost can just call appropriate setters and expect the UI to drawn appropriately. In the future, this can be extended to displaying toasts etc. Bug: 913502 Change-Id: I129e885603b8898461ec0de012007b852ea89268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500415 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#637768} chrome/browser/vr/ui_host/vr_ui_host_impl.cc | 32 +++++++----- chrome/browser/vr/ui_host/vr_ui_host_impl.h | 1 + .../vr/win/vr_browser_renderer_thread_win.cc | 57 ++++++++++------------ .../vr/win/vr_browser_renderer_thread_win.h | 15 ++++-- 4 files changed, 56 insertions(+), 49 deletions(-) commit d39b1f10598e891a9533e5c17d9196ac079d91ec Author: Chris Hamilton <chrisha@chromium.org> Date: Tue Mar 5 19:34:28 2019 +0000 [PM] Retire kIsLoading property. This retires the kIsLoading property from the page node as part of the refactor that aims to get rid of the "bag of properties" from node impls. BUG=910288 Change-Id: I6ca90dcfb4096a2b399f243a0da6e40c78fe21af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497340 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#637767} .../decorators/page_almost_idle_decorator.cc | 22 ++++++---------------- .../decorators/page_almost_idle_decorator.h | 6 +----- .../page_almost_idle_decorator_test_utils.cc | 4 ++-- .../page_almost_idle_decorator_unittest.cc | 12 ++++-------- .../performance_manager/graph/page_node_impl.cc | 7 +++++-- .../performance_manager/graph/page_node_impl.h | 5 +++++ .../graph/page_node_impl_unittest.cc | 20 ++++++-------------- .../observers/coordination_unit_graph_observer.h | 3 +++ .../public/mojom/signals.mojom | 2 -- 9 files changed, 32 insertions(+), 49 deletions(-) commit f2651134b7cc7b6da473e74ba020e8780d0ee1b4 Author: Pedro Amaral <amaralp@chromium.org> Date: Tue Mar 5 19:33:04 2019 +0000 [Duet] Browsing mode adaptive toolbar This CL hides/shows the bottom bar when the phone orientation changes from portrait to landscape. The bottom bar has two parts: an Android View and a composited toolbar. This CL hides the Android View by setting it to GONE and hides the composited view by setting the bottom control height to 0. The bottom bar code was modified to make the composited view's visibility be tied to the browser controls height. Native pages previously did not support changing the bottom controls height so this CL also adds that functionality to native pages. ToolbarSwipeLayout previously did not track the visibility of the bottom bar so this CL adds that ability. The other part of this CL is showing the top toolbar buttons when the bottom bar is hidden. This was done by setting them to GONE and tracking their visibility state with |ToolbarPhone#mHidingToolbarButtons|. Bug: 929164 Change-Id: Ide09baf7521a8986abeec6b03b952baf8d91925a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482002 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#637766} .../chromium/chrome/browser/ChromeActivity.java | 2 +- .../chrome/browser/ChromeTabbedActivity.java | 13 +++- .../browser/appmenu/AppMenuPropertiesDelegate.java | 6 +- .../compositor/layouts/ToolbarSwipeLayout.java | 34 ++++++-- .../browser/native_page/BasicNativePage.java | 50 +++++++----- .../chromium/chrome/browser/ntp/NewTabPage.java | 54 +++++++++---- .../chrome/browser/ntp/NewTabPageLayout.java | 7 -- .../chrome/browser/ntp/RecentTabsPage.java | 33 +++++--- .../preferences/ChromePreferenceManager.java | 6 ++ .../chrome/browser/toolbar/ToolbarManager.java | 40 ++++++---- .../toolbar/bottom/BottomToolbarCoordinator.java | 25 ++++-- .../BrowsingModeBottomToolbarCoordinator.java | 7 ++ .../bottom/BrowsingModeBottomToolbarMediator.java | 35 +++++---- .../BrowsingModeBottomToolbarViewBinder.java | 13 +++- .../chrome/browser/toolbar/top/ToolbarLayout.java | 5 ++ .../chrome/browser/toolbar/top/ToolbarPhone.java | 91 +++++++++++++--------- .../browser/toolbar/top/TopToolbarCoordinator.java | 8 ++ .../chrome/browser/util/FeatureUtilities.java | 25 ++++++ 18 files changed, 313 insertions(+), 141 deletions(-) commit 31967edb598d37b6d2c4122164b8693e038d130f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 5 19:25:29 2019 +0000 Roll src/third_party/angle 2f1c1d7eeebb..f094bac94992 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/2f1c1d7eeebb..f094bac94992 git log 2f1c1d7eeebb..f094bac94992 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 courtneygo@google.com Allow enabling trace annotations Created with: gclient setdep -r src/third_party/angle@f094bac94992 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I00bb260f30845cb0a77da25dc39300b68cd0803f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503958 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637765} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5c2534aaaad50a117d8764f0a94928177bcb3369 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Mar 5 19:23:31 2019 +0000 [Fuchsia] Don't call setsockopt(IP_MULTICAST_IF) IP_MULTICAST_IF is currently broken on Fuchsia. Disable it temporarily until the issue is fixed. Bug: 938101 Change-Id: I5d8af571f069eff573fa5ab8ac06010c869984ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503911 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#637764} net/socket/udp_socket_posix.cc | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) commit ee86e1f5c556a24dddc3fe7306017e330bfe64ed Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 5 19:20:27 2019 +0000 Roll src/third_party/SPIRV-Tools/src 5fb83a97087d..86f6ac086c8b (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/5fb83a97087d..86f6ac086c8b git log 5fb83a97087d..86f6ac086c8b --date=short --no-merges --format='%ad %ae %s' 2019-03-05 33432579+alan-baker@users.noreply.github.com Add a test for two back-edges in a continue (#2418) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@86f6ac086c8b The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1080693cb980c87ea13a6c37146ef553bb0bd9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503853 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637763} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1f9afb7d1514b845c6b323bddde5dda6b4eeb496 Author: Tien Mai <tienmai@chromium.org> Date: Tue Mar 5 19:19:24 2019 +0000 [GCPW] Allow customizing GLS application used for GCPW. Added a registry key that can be used to override the default GLS. Bug: 938488 Change-Id: I7cd91ce32765e721921c8c35ac151c7c52d04dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503623 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#637762} .../gaiacp/gaia_credential_base.cc | 22 +++++++++++++++++++--- 1 file changed, 19 insertions(+), 3 deletions(-) commit 5fc84fd01f25cc932825c23768b100b8426cd576 Author: Eric Seckler <eseckler@chromium.org> Date: Tue Mar 5 19:19:19 2019 +0000 perfetto: Manually roll to 30c1365e30b17cffc4fdc7fc56c27aee488226ec Includes changes to TrackEventThreadLocalEventSink due to changed proto field names. TBR: skyostil@chromium.org Change-Id: I00549d8fadea9fc6245bd2bb9d64a3fc01b5c96c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503379 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#637761} DEPS | 2 +- .../public/cpp/perfetto/trace_event_data_source_unittest.cc | 10 +++++----- .../public/cpp/perfetto/track_event_thread_local_event_sink.cc | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) commit 503953d4a4270fe66eb6889cb8cb510ad6b14a90 Author: Owen Min <zmin@chromium.org> Date: Tue Mar 5 19:12:08 2019 +0000 Revert "Run pending tasks in ~TestBrowserThreadBundle." This reverts commit 1c3948d821344ed5e34f8714d84af13c4ae2afa8. Reason for revert: The patch caused multiple content_unittest flaky. https://bugs.chromium.org/p/chromium/issues/detail?id=938126 This CL could be relanded once these flaky tests are fixed or disabled. Original change's description: > Run pending tasks in ~TestBrowserThreadBundle. > > This makes sure we run all remaining tasks in tests. This should be the > case even for ExecutionMode::QUEUED as documented here: > https://cs.chromium.org/chromium/src/base/test/scoped_task_environment.h?l=42 > > Also lift the restriction to only flush tasks in !MOCK_TIME && !QUEUED modes > which is unnecessary now that TestBrowserThreadBundle is-a > ScopedTaskEnvironment (http://crrev.com/616622). > > Bug: 708584 > Change-Id: I52773e27d3875bd246bb1cd7eea92c9e11fc70bf > Reviewed-on: https://chromium-review.googlesource.com/c/1480460 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637288} TBR=gab@chromium.org,knollr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 708584 Bug: 938126 Change-Id: I8b43a5c90b8f28eee2817a94cd556b2742e2f58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503993 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#637760} content/public/test/test_browser_thread_bundle.cc | 43 +++++++++++++---------- 1 file changed, 24 insertions(+), 19 deletions(-) commit 3811c16dd7b179c881aa840700f67168aa0128dc Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Mar 5 19:06:28 2019 +0000 [AF Wallet Metadata] Add tests for remote changes This CL adds tests for remote changes for autofill wallet metadata. It uses parametrized tests because the same behaviour and conflict resolution should trigger for initial sync additions, non-initial additions as well as for non-initial updated. Bug: 936013 Change-Id: Ia06ce99dbf9f3da0c2e2130d0bcb0dc4caa80b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491312 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#637759} .../webdata/autofill_sync_bridge_test_util.cc | 2 +- ...utofill_wallet_metadata_sync_bridge_unittest.cc | 803 +++++++++++++++++++-- 2 files changed, 755 insertions(+), 50 deletions(-) commit 007309080691fbd0a668c1815a18ed3a9c7a5d14 Author: Nicolas <nicolaso@chromium.org> Date: Tue Mar 5 19:03:11 2019 +0000 [BrowserSwitcher] Add test coverage for cache files New tests check that BrowserSwitcherService writes "cache.dat" and "sitelistcache.dat" files in AppData\Local (on Windows). They also verify the file contents. Change-Id: I3ee197c2013c9c7c616c46655b552f629d32a6c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500973 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#637758} .../browser_switcher_service_browsertest.cc | 176 +++++++++++++++++++-- 1 file changed, 161 insertions(+), 15 deletions(-) commit c47cdd2f57bd2339cafab8606bce0f582580b434 Author: Leonard Grey <lgrey@chromium.org> Date: Tue Mar 5 19:00:21 2019 +0000 Don't use favicon resource in ui/base Motivation: https://chromium-review.googlesource.com/c/chromium/src/+/1492047 Change-Id: I89d2fc98569ddcd948e1eeb7e27faac3c5afc587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503629 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#637757} ui/base/cocoa/menu_controller_unittest.mm | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit 99453a4326a2d09990877c4516a343028bf89f29 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Mar 5 18:59:21 2019 +0000 mac: use local dsymutil The Xcode 9.3 dsymutil dies with "IO Error" when handling objects larger than 2**32 bytes; the upstream llvm one seems not to have this problem. Bug: 780980 Change-Id: I6846383329bd28a65516c0ef3ad177e1a78d08f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500198 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#637756} build/toolchain/mac/BUILD.gn | 6 ++++++ build/toolchain/mac/linker_driver.py | 28 +++++++++++++++++++++++++++- tools/mac/dump-static-initializers.py | 3 ++- 3 files changed, 35 insertions(+), 2 deletions(-) commit d1ca2fa05aaab1ebf88209d8c08ffc6457cbe664 Author: Etienne Bergeron <etienneb@chromium.org> Date: Tue Mar 5 18:59:16 2019 +0000 Rename font_service and font_loader to fonts category The two font caterogies got merge into a single one named 'fonts'. see: https://chromium-review.googlesource.com/c/chromium/src/+/1497183 https://bugs.chromium.org/p/chromium/issues/detail?id=937389 This CL is changing the slow-reports categories to reflect that change. R=oysteine@chromium.org TBR=drott@chromium.org Bug: 937389 Change-Id: I3554b13015a46fc48a45906d357abf24ad57a740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503620 Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#637755} content/browser/tracing/background_tracing_manager_impl.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 37c01ccd2933550ed0da5bf82da45488feb395c8 Author: Koji Ishii <kojii@chromium.org> Date: Tue Mar 5 18:57:48 2019 +0000 [LayoutNG] Make nowrap in NGLineBreaker simpler This patch changes NGLineBreaker not to call ShapingLineBreaker when nowrap or pre. The start and end of nowrap is not needed to reshape, and it improves nowrap blink_perf tests by 2-3%. loading.desktop seems to improve by 1-3% (it's a bit noisy.) In doing so, this patch adds a few DCHECK, which discovered a few issues. This patch also fixes them. 1. Fixes where lines may wrap after leading spaces in nowrap. 2. Fixes where |Rewind()| fails to update the |current_style_| and its derived members such as |auto_wrap_|. Bug: 636993 Change-Id: I19bdf1af1287aaebaa30ef00fe4b5d98189650ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501233 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#637754} .../core/layout/ng/inline/ng_line_breaker.cc | 66 ++++++++++++++++++---- .../core/layout/ng/inline/ng_line_breaker.h | 2 + 2 files changed, 58 insertions(+), 10 deletions(-) commit 5845e3041f028f5ca90e79d5e730a11fefbcd18c Author: Chris Cunningham <chcunningham@chromium.org> Date: Tue Mar 5 18:49:46 2019 +0000 Check codec support before making FFmpegDemuxerStreams We previously relied on the *DecoderConfig to be "invalid" for unsupported codecs. But this is fragile and hard to document and we already have utilities to answer what codecs are supported. Bug: 911823 Change-Id: I5cd87b79385dff3eabf74fdc24fdfc9452445ea4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1362466 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#637753} media/base/BUILD.gn | 1 + media/base/media_types.cc | 76 +++++++++++++++++++++++++ media/base/media_types.h | 15 ++++- media/base/mock_filters.cc | 4 ++ media/base/mock_filters.h | 20 +++++++ media/base/supported_types.cc | 8 ++- media/base/supported_types_unittest.cc | 13 ++++- media/filters/ffmpeg_demuxer.cc | 27 +++++---- media/filters/ffmpeg_demuxer_unittest.cc | 52 +++++++++++++++-- media/renderers/audio_renderer_impl_unittest.cc | 18 +----- 10 files changed, 196 insertions(+), 38 deletions(-) commit 8f1b6700dd3449b0c008cee3e3cbf8e8be8f3fab Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 5 18:46:49 2019 +0000 Roll src/third_party/skia c2949ec67b92..a1810551f219 (4 commits) https://skia.googlesource.com/skia.git/+log/c2949ec67b92..a1810551f219 git log c2949ec67b92..a1810551f219 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 benjaminwagner@google.com Add fetch-gn to canvaskit and cmake compile scripts 2019-03-05 ethannicholas@google.com Add support for runtime color filters written in SkSL. 2019-03-05 reed@google.com add sample for retained vertices 2019-03-05 fmalita@chromium.org Reland "SkMixerColorFilter GPU impl" Created with: gclient setdep -r src/third_party/skia@a1810551f219 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Id3fbdf6326f05a263ec6fb106a1eabf6259439e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503656 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#637752} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d4c3468722e5671aa25a8a88e5d27b24da32c5d1 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Mar 5 18:44:53 2019 +0000 Merge tree updates before unserializing Sometimes a large number of node updates may come as separate AXTreeUpdates, which can be inefficient to unserialize. Add a function to merge multiple tree updates into one, in the common case where each one just serializes some nodes. Skip this optimization when the tree update contains new tree data, contains a new root, or clears a subtree. Only one test needed to be rebaselined, because changes when moving from one option to the next in a listbox became more atomic rather than sequential. I think it's actually an improvement, as all of the events fired represent the true final state rather than some of them representing an transient intermediate state. Bug: 921789 Change-Id: I1fe11bed8ea405c0db523e26ce57e3699273af3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485497 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#637751} .../accessibility/browser_accessibility_manager.cc | 50 +++++++++++++++- .../browser_accessibility_manager_unittest.cc | 69 ++++++++++++++++++++++ .../event/listbox-next-expected-win.txt | 6 +- ui/accessibility/ax_tree_update.h | 20 +++++++ 4 files changed, 140 insertions(+), 5 deletions(-) commit 64541c585a1fe11be1ab62572ab0ebaba269264a Author: Emil A Eklund <eae@chromium.org> Date: Tue Mar 5 18:43:23 2019 +0000 [LayoutNG] Add null check to CollectInlinesInternal Speculative fix calling SetFirstInlineFragment on nullptr layout object. GetLayoutObjectForParentNode can return nullptr and lacked needed guard. Bug: 938504 Change-Id: I03e08edac684943c55a910aa93a087f94b61b90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503630 Commit-Queue: Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Emil A Eklund <eae@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#637750} third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e3ce5bc1b7f1308170e3755992e736f2e7679619 Author: Jarryd <jarrydg@chromium.org> Date: Tue Mar 5 18:36:56 2019 +0000 Quota: Use SequenceChecker in UsageTracker This change adds a SequenceChecker to the UsageTracker class so that we can more easily reason about it's thread-safety. Change-Id: Ie1b1390330e951a1eca132c350d975712904ea5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497594 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#637749} storage/browser/quota/usage_tracker.cc | 19 ++++++++++++++++++- storage/browser/quota/usage_tracker.h | 9 ++++++++- 2 files changed, 26 insertions(+), 2 deletions(-) commit 751f4da7f3a19c079d7a6e3e72faa457a1aad444 Author: Rob Schonberger <robsc@chromium.org> Date: Tue Mar 5 18:36:07 2019 +0000 Add Load/Save to arc_app_reinstall_search_provider, and add testing. Save a number of states, but not yet impressions, to disk. Move a member in extension_service_test_base to protected so that unit test sub classes can block until a thread is completed. Bug: 911427 Change-Id: I34e83595da3ec511b4f81c2d898d24ff4f85df15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480301 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#637748} chrome/browser/prefs/browser_prefs.cc | 2 + .../search/arc/arc_app_reinstall_app_result.cc | 17 +- .../search/arc/arc_app_reinstall_app_result.h | 21 +- .../arc/arc_app_reinstall_search_provider.cc | 368 ++++++++++++++++++--- .../search/arc/arc_app_reinstall_search_provider.h | 21 +- .../arc_app_reinstall_search_provider_unittest.cc | 55 ++- 6 files changed, 433 insertions(+), 51 deletions(-) commit b611149c2fd1181b0e2a62b7f154dd01da738769 Author: Florin Malita <fmalita@chromium.org> Date: Tue Mar 5 18:34:24 2019 +0000 Rebaseline Skia suppressions TBR=reed Bug: 630695 Change-Id: Ia0a06da02e7d3abfaf289bbd0981590938c7f9d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503621 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#637747} third_party/blink/web_tests/TestExpectations | 7 ------- .../images/cross-fade-overflow-position-expected.png | Bin 5047 -> 5041 bytes .../web_tests/images/drag-svg-image-expected.png | Bin 2787 -> 2735 bytes .../images/cross-fade-overflow-position-expected.png | Bin 5740 -> 5506 bytes 4 files changed, 7 deletions(-) commit 8608ac8d51ddd4d253418f7420fc4aa1b7768980 Author: Tim Volodine <timvolodine@chromium.org> Date: Tue Mar 5 18:33:09 2019 +0000 [media_browsertests] Fix MediaColorTests ifdefs test name Fix ifdefs in test and use correct name for the test BUG=938320 NOTRY=true TBR=hubbe@chromium.org,hanxi@chromium.org,chcunningham@chromium.org Change-Id: I80685379f31e1646ec5fc2030933e6fab2c55d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504012 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#637746} content/browser/media/media_color_browsertest.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Updated tag 'tree_truth' (was b2578ccd089e)