Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 45277 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919616704715448592 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itSYGsk9/luci_context.181008894 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2229-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43727ddecfa84c11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 98ac778ed1f81448049e5b56921e7c199dc11daf flags: assign smart-text-selection Elly Fong-Jones, Thu Mar 7 19:39:38 2019 +0000 172275e51f63486e85d03f73d1cd24f72c65a2a4 flags: assign disallow-unsafe-http-downloads Elly Fong-Jones, Thu Mar 7 19:39:17 2019 +0000 af2d551811f6e2f948c7e89d73383825127b6e1f Roll src-internal fff41430adb0..cb039b04e175 (3 commits) chromium-internal-autoroll, Thu Mar 7 19:33:56 2019 +0000 294678e4630daf786c91565ab368d8779a8d59a1 Fix container overflow in CryptAuthKeyCreatorImpl Josh Nohle, Thu Mar 7 19:31:38 2019 +0000 8421f880fa8fb1f0136150752f206d49d83a307a aw: Clear presentation feedback Bo Liu, Thu Mar 7 19:31:13 2019 +0000 fbcb168d3555f7449aa099a3c56feaa68d1aa0c4 Cleanup CreateRenderer(HostedRendererType) Thomas Guilbert, Thu Mar 7 19:30:32 2019 +0000 c7400d35b2f0ecfb1989e626bd1bfc334c907873 [Chromecast] Add the ability to modify which streams redirection applies to Ken MacKay, Thu Mar 7 19:28:32 2019 +0000 a57f4dbb5f6269529d71d21f08bfc288d6251a94 Fix flakiness in CrosDisplayConfigTest Evan Stade, Thu Mar 7 19:28:00 2019 +0000 9c429b6cb4877dbd86d13392eca4c29d5f7cc1cd Roll src/third_party/catapult ccc29087522a..699655f07b93 (1 commits) chromium-autoroll, Thu Mar 7 19:26:31 2019 +0000 563f475d6a7d8fee66daca04337e64a5500c4f20 Remove left-over DEFINE_TYPE_CASTS use from css_unsupported_style_value.h Antonio Gomes, Thu Mar 7 19:25:30 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 98ac778ed1f81448049e5b56921e7c199dc11daf Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 19:39:38 2019 +0000 flags: assign smart-text-selection Bug: None Change-Id: Ia33fbcb45db07ff825df129abcd8a5e23c1eda08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509234 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638697} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 172275e51f63486e85d03f73d1cd24f72c65a2a4 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 19:39:17 2019 +0000 flags: assign disallow-unsafe-http-downloads Bug: 839986 Change-Id: Ib7d6a38a6b62d467b299d5f06b840d308fcb6ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508787 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638696} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af2d551811f6e2f948c7e89d73383825127b6e1f Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 19:33:56 2019 +0000 Roll src-internal fff41430adb0..cb039b04e175 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fff41430adb0..cb039b04e175 Created with: gclient setdep -r src-internal@cb039b04e175 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I1721de6ed48dace03583dd2d7d9850091a62259e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508992 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638695} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 294678e4630daf786c91565ab368d8779a8d59a1 Author: Josh Nohle <nohle@google.com> Date: Thu Mar 7 19:31:38 2019 +0000 Fix container overflow in CryptAuthKeyCreatorImpl In CryptAuthKeyCreatorImpl, elements of a flat_map were being erased while the flat_map was still being iterated through. This caused a container overflow ASAN error in http://crrev.com/c/1504121. Verified locally that this CL fixes the ASAN error seen in http://crrev.com/c/1504121, using the same gn args as the linux_chromium_chromeos_asan_rel_ng builder. Bug: 899080 Change-Id: I6f25d795545548ed108e95e2e1ec70f6de20941b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507314 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#638694} .../services/device_sync/cryptauth_key_creator_impl.cc | 15 ++++++++------- .../services/device_sync/cryptauth_key_creator_impl.h | 1 + 2 files changed, 9 insertions(+), 7 deletions(-) commit 8421f880fa8fb1f0136150752f206d49d83a307a Author: Bo Liu <boliu@chromium.org> Date: Thu Mar 7 19:31:13 2019 +0000 aw: Clear presentation feedback Presentation is not yet hooked up for android webview. Currently it is leaking a little bit of memory for every new compositor frame submitted. Just clear that map for now. Bug: 939381 Change-Id: I992835d4b2e68ea97ae8baaf435e29298ec2dc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508892 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638693} android_webview/browser/gfx/hardware_renderer.cc | 3 +++ .../viz/service/frame_sinks/compositor_frame_sink_support.cc | 7 +++++++ .../viz/service/frame_sinks/compositor_frame_sink_support.h | 9 ++++++--- 3 files changed, 16 insertions(+), 3 deletions(-) commit fbcb168d3555f7449aa099a3c56feaa68d1aa0c4 Author: Thomas Guilbert <tguilbert@chromium.org> Date: Thu Mar 7 19:30:32 2019 +0000 Cleanup CreateRenderer(HostedRendererType) CreateRenderer(HostedRendererType) was left in after Create*Renderer was added, in order to prevent breaking the internal ChromeCast build. This CL cleans up the leftovers and should be submitted after Chromecast interal code switches to CreateCastRenderer() Bug: 936528 Change-Id: I29ee8104099485ed32a22aec9ccd6cff5cd63771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493082 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#638692} content/browser/media/media_interface_proxy.cc | 9 --------- content/browser/media/media_interface_proxy.h | 4 ---- content/browser/media/video_decoder_proxy.cc | 5 ----- content/browser/media/video_decoder_proxy.h | 4 ---- content/renderer/media/media_interface_factory.cc | 9 --------- content/renderer/media/media_interface_factory.h | 4 ---- media/mojo/interfaces/interface_factory.mojom | 24 ----------------------- media/mojo/services/interface_factory_impl.cc | 9 --------- media/mojo/services/interface_factory_impl.h | 4 ---- 9 files changed, 72 deletions(-) commit c7400d35b2f0ecfb1989e626bd1bfc334c907873 Author: Ken MacKay <kmackay@chromium.org> Date: Thu Mar 7 19:28:32 2019 +0000 [Chromecast] Add the ability to modify which streams redirection applies to Allow updating the patterns that the redirector matches to mixer streams without removing and re-adding the redirector. Bug: internal b/123626919 Test: cast_audio_backend_unittests Change-Id: I4f79d9d1c1c95ba213bc1396d9d708fd8bb037bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506670 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#638691} .../media/cma/backend/audio_output_redirector.cc | 46 +++++++++++++++- .../media/cma/backend/audio_output_redirector.h | 10 +++- chromecast/media/cma/backend/stream_mixer.cc | 18 ++++++ chromecast/media/cma/backend/stream_mixer.h | 9 +++ .../media/cma/backend/stream_mixer_unittest.cc | 64 +++++++++++++++++++++- chromecast/public/cast_media_shlib.h | 8 +++ chromecast/public/media/redirected_audio_output.h | 2 +- 7 files changed, 152 insertions(+), 5 deletions(-) commit a57f4dbb5f6269529d71d21f08bfc288d6251a94 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 19:28:00 2019 +0000 Fix flakiness in CrosDisplayConfigTest Clear touch screen devices after each test so that touch screen configuration doesn't interfere with the next test's setup. Specifically, having a touch screen device causes the virtual keyboard to be enabled before Shell is done initializing. Bug: 939177 Change-Id: I8e24cc9ab2f425cdc8d9a3b4d11b0a4e1fd6d9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507250 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638690} .../virtual_keyboard_controller_unittest.cc | 99 ++++++++++------------ ash/test/ash_test_base.cc | 6 ++ 2 files changed, 49 insertions(+), 56 deletions(-) commit 9c429b6cb4877dbd86d13392eca4c29d5f7cc1cd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 19:26:31 2019 +0000 Roll src/third_party/catapult ccc29087522a..699655f07b93 (1 commits) https://chromium.googlesource.com/catapult.git/+log/ccc29087522a..699655f07b93 git log ccc29087522a..699655f07b93 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 benjhayden@chromium.org Fix spa tests. Created with: gclient setdep -r src/third_party/catapult@699655f07b93 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I9e9fb60c0c27e63225659cb611a6c13a972d4239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508912 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638689} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 563f475d6a7d8fee66daca04337e64a5500c4f20 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Mar 7 19:25:30 2019 +0000 Remove left-over DEFINE_TYPE_CASTS use from css_unsupported_style_value.h This is a follow up of https://crrev.com/c/1496217 TBR=jbroman@chromium.org BUG=891908 Change-Id: Ib3a86b00c39ee0c0cc7081fbd87038d3a03c8cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509192 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#638688} .../blink/renderer/core/css/cssom/css_unsupported_style_value.h | 8 -------- 1 file changed, 8 deletions(-) commit e8a2f088a9e4298790537ee45c75d37b4df317e4 Author: John Chen <johnchen@chromium.org> Date: Thu Mar 7 19:25:25 2019 +0000 [ChromeDriver] Remove waterfall related code Clean up code that has become obsolete due to decomission of ChromeDriver waterfall. Change-Id: Ifbdb43872111ec3e575ec6e4aa1b28b76b663756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509095 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#638687} chrome/test/chromedriver/README.txt | 43 ++- chrome/test/chromedriver/archive.py | 152 ----------- chrome/test/chromedriver/run_buildbot_steps.py | 302 --------------------- chrome/test/chromedriver/test/run_all_tests.py | 204 -------------- chrome/test/chromedriver/test/run_java_tests.py | 8 +- .../test/waterfall_builder_config_sample.json | 32 --- .../chromedriver/test/waterfall_builder_monitor.py | 226 --------------- .../chromedriver/third_party/googlecode/LICENSE | 204 -------------- .../third_party/googlecode/README.chromium | 18 -- .../third_party/googlecode/googlecode_upload.py | 240 ---------------- 10 files changed, 22 insertions(+), 1407 deletions(-) commit f1181050339b6f88e89bb4e9d7f1b894878318fd Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 19:24:12 2019 +0000 Check quota for scheduled notifications. This makes sure that we only allow up to 30 scheduled notifications and handles the case when we update an existing notification with a scheduled one. Bug: 891339 Change-Id: Ifb884367d71f9156abf303d8330364f671e3afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505503 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638686} content/browser/BUILD.gn | 1 + .../notifications/notification_trigger_constants.h | 15 ++++++ .../platform_notification_context_impl.cc | 38 ++++++++++++++ .../platform_notification_context_impl.h | 4 ++ ...atform_notification_context_trigger_unittest.cc | 59 +++++++++++++++++++++- .../platform_notification_service_proxy.cc | 12 +++++ .../platform_notification_service_proxy.h | 3 ++ 7 files changed, 130 insertions(+), 2 deletions(-) commit b77db01adbd9e5ba147e2259c7a9a8fc4bbdd6eb Author: Reid Kleckner <rnk@chromium.org> Date: Thu Mar 7 19:22:45 2019 +0000 Revert "Add tests that lookalike interstitial decisions are shared with incognito." This reverts commit 281e80c30694a97f69f9c4b5f627483376972199. Reason for revert: New test fails in official builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/104341 https://ci.chromium.org/p/chrome/builders/ci/ToTWin64/3351 Original change's description: > Add tests that lookalike interstitial decisions are shared with incognito. > > This CL adds tests to verify that a decision to bypass the lookalike > interstitial made in the main profile does not affect incognito and vice > versa. > > Bug: 927924 > Change-Id: I238e2e263db42c1434b9190de007aa775129417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638329} TBR=meacer@chromium.org,jdeblasio@chromium.org Change-Id: I68dbe18b841f4022ae0b533402d1f7fe1fa377b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509333 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638685} ...ookalike_url_navigation_throttle_browsertest.cc | 58 ++++------------------ 1 file changed, 11 insertions(+), 47 deletions(-) commit ae32c22fbb953cee47fc4edc089cd00d57f4dcf5 Author: Charlie Harrison <csharrison@chromium.org> Date: Thu Mar 7 19:17:01 2019 +0000 Re-land: Fix flatbuffers failures-mode This re-lands this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1503614 Which was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1504597 There's one additional change, which is to ensure that windows runtime_libs are available as data_deps. This omission was causing failures on win_chromium_dbg_ng. Bug: 938020 Change-Id: Id0196d86097f938d046c7936e619d1c7cf8174c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506124 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638684} testing/scripts/run_flatbuffers_unittests.py | 7 ++++--- third_party/flatbuffers/BUILD.gn | 4 ++++ 2 files changed, 8 insertions(+), 3 deletions(-) commit 21a23281166534f8cffd11cd36aa159dd9db3dfa Author: Lily Chen <chlily@chromium.org> Date: Thu Mar 7 19:15:43 2019 +0000 Network Error Logging: Evict expired and/or least recently used policies Previously we accumulated NEL policies forever until they were wiped out by a browser restart. This CL introduces a maximum policy limit, beyond which eviction of expired and/or least recently used policies is triggered. A last_used field is added to the policies in order to find the stalest policy to evict. Bug: 930301 Change-Id: Ifebfc64c19a4228e8830f62c52e83bc06790cba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474530 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#638683} .../network_error_logging_service.cc | 93 ++++++++++++++---- .../network_error_logging_service.h | 3 + .../network_error_logging_service_unittest.cc | 109 +++++++++++++++++++++ 3 files changed, 186 insertions(+), 19 deletions(-) commit 69fcf2dc8a532ebf897f32efca3094e8eab9dc02 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Thu Mar 7 19:14:37 2019 +0000 [Autofill] Added utils for creating LabelFormatters. Making a new branch and CL to resolve issues with git and try jobs. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1498614 The utils for making various LabelFormatters sometimes favor std::set over std::vector so that poorly formed forms, e.g. forms with duplicate fields, do not interfere with processing later on. Sets allow us to safely assume that there is just one of a particular ServerFieldType or FieldTypeGroup. It is worth noting that ContactFormLabelFormatters store their FieldTypeGroups while AddressFormLabelFormatters do not. This is because address forms are guaranteed to have ADDRESS_HOME and NAME; however, contact forms could have NAME and PHONE_HOME, EMAIL, or both PHONE_HOME and EMAIL. It is useful for a ContactFormLabelFormatter to know which subset of FieldTypeGroups correspond to its fields. Change-Id: I6164081759848b263c3d9dd5cfcda190388a3d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506116 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#638682} components/autofill/core/browser/BUILD.gn | 1 + .../core/browser/address_form_label_formatter.cc | 10 +-- .../core/browser/address_form_label_formatter.h | 28 ++----- .../core/browser/contact_form_label_formatter.cc | 16 ++-- .../core/browser/contact_form_label_formatter.h | 37 +++++---- .../autofill/core/browser/label_formatter.cc | 17 +++++ components/autofill/core/browser/label_formatter.h | 26 ++++++- .../autofill/core/browser/label_formatter_utils.cc | 88 +++++++++++++++------- .../autofill/core/browser/label_formatter_utils.h | 28 ++++--- .../core/browser/label_formatter_utils_unittest.cc | 36 +++++++-- 10 files changed, 189 insertions(+), 98 deletions(-) commit dfa8971f3f7bb9b3dfb37d61e2d97f66c6586c33 Author: Majid Valipour <majidvp@chromium.org> Date: Thu Mar 7 19:14:21 2019 +0000 [cc] Add majidvp@ as reviewer for scroll snap I can review changes for anything scroll snap related. 🧐 Change-Id: Ia6c794e6bc6b91588cfe7fb8c133c253e2a04c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497388 Reviewed-by: enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638681} cc/OWNERS | 3 +++ 1 file changed, 3 insertions(+) commit 0b9d7cdc0d8cc410444580a93acc3911e9eaf5b6 Author: Nicolás Peña Moreno <npm@chromium.org> Date: Thu Mar 7 19:13:01 2019 +0000 Add a test that quantizes MemoryInfo's largest bucket Bug: 939100 Change-Id: Ia8b7bd430ece375a14569d86482b38c9ad461fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506877 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638680} third_party/blink/renderer/core/timing/memory_info_test.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 7943dd68255962d9daa990554af6e9faeca059bc Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Mar 7 19:12:42 2019 +0000 Add main thread enforcing DCHECK in Dispatcher's messaging IPC handler. Dispatcher is expected to receive messaging IPCs for main thread and not worker threads. Add the check to Dispatcher::OnDeliverMesage, similar to what existed for other messages, e.g. Dispatcher::OnDispatchOnDisconnect. Bug: None Test: No visible changes expected. Change-Id: I0c11b302b9d9610b1f8792ebf2a385e0aec9fb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508601 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638679} extensions/renderer/dispatcher.cc | 1 + 1 file changed, 1 insertion(+) commit 4d66a60c4794853be09fc946be68ff6cb184de0c Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Mar 7 19:11:42 2019 +0000 MessageService: Remove an unused param to SWTQ::AddPendingTask's callback. The render process id param became obolete and unused at some point, remove it. Bug: None Test: No expected change, internal cleanup only. Change-Id: I422242473c0118692e010909c8380971f01812cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508600 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638678} extensions/browser/api/messaging/message_service.cc | 8 +++----- extensions/browser/api/messaging/message_service.h | 1 - 2 files changed, 3 insertions(+), 6 deletions(-) commit 0434709da39ec1ef5fa384eb867d7c7c3edef4de Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 7 19:11:32 2019 +0000 Suppress external/wpt/html/browsers/windows/embedded-opener-remove-frame.html BUG=939406 TBR=robertma@chromium.org Change-Id: I49024a8fad4b64cce2bf31d963b1ba1d80b32670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508581 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638677} third_party/blink/web_tests/TestExpectations | 2 ++ 1 file changed, 2 insertions(+) commit ec8c36d43efa39b35bd6beb4698460c85f01481f Author: Scott Violet <sky@chromium.org> Date: Thu Mar 7 19:08:28 2019 +0000 aura: cleanup function/member name in WindowTreeHostMus Renames in_set_bounds_from_server to is_server_setting_bounds, which is hopefully a bit easier to understand. BUG=none TEST=none Change-Id: Ic972be85123dc234fa98baee4d2d602bbcc84a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507324 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638676} ui/aura/mus/window_tree_host_mus.cc | 4 ++-- ui/aura/mus/window_tree_host_mus.h | 4 ++-- ui/views/mus/desktop_window_tree_host_mus.cc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) commit 6bec17316ceb8b572a44c5f2f264a80a220b8a95 Author: Greg Kerr <kerrnel@chromium.org> Date: Thu Mar 7 19:04:07 2019 +0000 macOS V2 Sandbox: Expand the V2 GPU sandbox. This adds additional resource access to the V2 GPU sandbox to address crashes. Bug: 915934 Change-Id: Icf346f03e32523549e5cb9c0806dce1a51794da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506390 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#638675} services/service_manager/sandbox/mac/common.sb | 16 ++++++++++++---- services/service_manager/sandbox/mac/gpu_v2.sb | 22 +++++++++++++++++++++- 2 files changed, 33 insertions(+), 5 deletions(-) commit e6d380281bd6b1c595f47f901e0214bb1eb1e00f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 19:04:03 2019 +0000 Roll src/third_party/swiftshader 45faa0849352..ec255730a818 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/45faa0849352..ec255730a818 git log 45faa0849352..ec255730a818 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Reactor: Add address-of operator on reference types. Created with: gclient setdep -r src/third_party/swiftshader@ec255730a818 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126330097 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1304317d6ebd954f85b3fccede912dffe6539326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508833 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638674} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0e4cf6d8bdb3e763819976265f61c8f09a9ff852 Author: Bruno Santos <brunoad@chromium.org> Date: Thu Mar 7 18:59:35 2019 +0000 Bump expiration milestone for Arc.Supervision.Transition.Result histogram. Bug: 930922 Change-Id: I86eaed2c769f16ac21bcb7d4ee1f96dd01243f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506876 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638673} tools/metrics/histograms/histograms.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit d68cf0eb89f8848d6ddfee17a0051d5741615661 Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Mar 7 18:57:30 2019 +0000 PWAs: Don't re-parent shortcuts that aren't open-in-window Bug: 938256 Change-Id: I622f1ab4c489fbedb3a72fabbb1e61705d5ae255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507121 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638672} chrome/browser/extensions/bookmark_app_extension_util.cc | 13 ++++++++++++- chrome/browser/extensions/bookmark_app_extension_util.h | 4 +++- chrome/browser/extensions/bookmark_app_helper.cc | 6 ++++-- .../browser/web_applications/components/install_finalizer.h | 3 ++- .../extensions/bookmark_app_install_finalizer.cc | 6 ++++-- .../extensions/bookmark_app_install_finalizer.h | 3 ++- .../browser/web_applications/test/test_install_finalizer.cc | 3 ++- .../browser/web_applications/test/test_install_finalizer.h | 3 ++- .../browser/web_applications/web_app_install_finalizer.cc | 3 ++- chrome/browser/web_applications/web_app_install_finalizer.h | 3 ++- chrome/browser/web_applications/web_app_install_manager.cc | 2 +- 11 files changed, 36 insertions(+), 13 deletions(-) commit 8060b03097c3d78a4a1932d3a0cc874e9594d6cd Author: Livvie Lin <livvielin@chromium.org> Date: Thu Mar 7 18:56:29 2019 +0000 Change name of IDS_EDITED_NONSECURE_SUMMARY Since the override summary is used in some cases even when a form was not edited, i.e. kMarkHttpAsParameterDangerous, a different name would be more descriptive. Also add checks in the browser test that this summary is present. Change-Id: I294c68b0e57d2a87b501960185b7c91b2a3e0ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507319 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638671} chrome/browser/ssl/security_state_tab_helper_browsertest.cc | 8 ++++++++ components/security_state/content/content_utils.cc | 2 +- components/security_state_strings.grdp | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) commit 04bc471aa6ab987851eeeeef49f38e0d16072283 Author: Sky Malice <skym@chromium.org> Date: Thu Mar 7 18:56:19 2019 +0000 [Feed] Add metrics impl for request events. Bug: 924739 Change-Id: I40f649645349d7671b76bd9f480ff4207b89c430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487709 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638670} .../chrome/browser/feed/FeedLoggingBridge.java | 28 +++++-- chrome/browser/android/feed/feed_logging_bridge.cc | 48 ++++++++++++ chrome/browser/android/feed/feed_logging_bridge.h | 29 +++++++ components/feed/core/feed_logging_metrics.cc | 68 ++++++++++++++++ components/feed/core/feed_logging_metrics.h | 12 +++ tools/metrics/histograms/enums.xml | 30 +++++++ tools/metrics/histograms/histograms.xml | 91 +++++++++++++++++++++- 7 files changed, 299 insertions(+), 7 deletions(-) commit b212a18e617f22d67d0366eee74f3d992887b466 Author: bsheedy <bsheedy@chromium.org> Date: Thu Mar 7 18:55:08 2019 +0000 Fix VR Iframe JS Threading Fixes JavaScript run in iframes during VR instrumentation tests not being run on the UI thread, which was hitting a recently added DCHECK. TBR=billorr@chromium.org Bug: 939410 Change-Id: I5d3eba0e8075306cff0182c7d10c4c81204afc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508582 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638669} .../src/org/chromium/chrome/browser/vr/XrTestFramework.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit c41b2aac023c4cd3bfb6c97ba56dddb9f9583fc0 Author: Jarryd <jarrydg@chromium.org> Date: Thu Mar 7 18:54:20 2019 +0000 Quota: Obsolete expired origin count histograms. This change will remove UMA logging and related logic for expired origin count metrics that live in QuotaManager. Change-Id: I117d93b23a140e6e59aac0fe3f2adef3cd078f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506562 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638668} storage/browser/quota/quota_manager.cc | 52 --------------------------------- tools/metrics/histograms/histograms.xml | 36 +++++++++++++++-------- 2 files changed, 24 insertions(+), 64 deletions(-) commit f9dd030c419ed2c40e776ccbd45070e5a92e2c75 Author: Min Qin <qinmin@chromium.org> Date: Thu Mar 7 18:54:00 2019 +0000 Dump crash stack when renderer hangs on Android Android currently doesn't report crash stack when renderer hangs. This CL will ask the renderer process to dump the stack to crash report page, without crashing it. Maybe i can do this for OOP network process alone for the crbug, but I think in general, we should have the stack for non-responding renderers. BUG=934317 Change-Id: I5d039c3c6d026e4b608a4f39da4b71933b19c566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498415 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638667} base/android/child_process_service.cc | 5 +++++ .../base/process_launcher/ChildProcessConnection.java | 13 +++++++++++++ .../base/process_launcher/ChildProcessService.java | 18 ++++++++++++++++++ .../base/process_launcher/IChildProcessService.aidl | 3 +++ .../android/tab_web_contents_delegate_android.cc | 10 ++++++++-- content/browser/child_process_launcher.cc | 9 +++++++++ content/browser/child_process_launcher.h | 4 ++++ content/browser/child_process_launcher_helper.h | 3 +++ .../browser/child_process_launcher_helper_android.cc | 8 ++++++++ .../browser/renderer_host/render_process_host_impl.cc | 5 +++++ .../browser/renderer_host/render_process_host_impl.h | 1 + .../browser/ChildProcessLauncherHelperImpl.java | 14 ++++++++++++++ content/public/browser/render_process_host.h | 3 +++ content/public/test/mock_render_process_host.cc | 2 ++ content/public/test/mock_render_process_host.h | 1 + 15 files changed, 97 insertions(+), 2 deletions(-) commit 57bab70618898fc2e8b87abe2ee5dacdfccad632 Author: bsheedy <bsheedy@chromium.org> Date: Thu Mar 7 18:52:08 2019 +0000 Make VR navigation test cover more Makes VrBrowserNavigationTest#testNavigationButtons cover more of the manual test requirements. Specifically, ensures that the buttons are properly greyed out when they're disabled and that clicking on the back button can't cause the browser to go to a different tab. Bug: 887510 Change-Id: Ie4a09c2286d58f6a7a9d0539995bc226132213a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497471 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638666} .../chrome/browser/vr/VrBrowserNavigationTest.java | 66 +++++++++++++++++++--- ...ation_buttons_back_enabled.Pixel_XL-25.png.sha1 | 1 + ...ation_buttons_back_enabled.Pixel_XL-26.png.sha1 | 1 + ...tion_buttons_both_disabled.Pixel_XL-25.png.sha1 | 1 + ...tion_buttons_both_disabled.Pixel_XL-26.png.sha1 | 1 + ...on_buttons_forward_enabled.Pixel_XL-25.png.sha1 | 1 + ...on_buttons_forward_enabled.Pixel_XL-26.png.sha1 | 1 + 7 files changed, 63 insertions(+), 9 deletions(-) commit 25864ef8492da5345b825b4d38d3e7f45d579486 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 7 18:51:19 2019 +0000 Revert "Create golden file loader for the time limit consistency tests." This reverts commit 33fbc186b508a8018a196abeec1dc60eff9dd2a6. Reason for revert: Suspected in a bunch of proto crashes here: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11240 Original change's description: > Create golden file loader for the time limit consistency tests. > > Bug: 935711 > Change-Id: Id4f5c77ab7e8d783507b2bdb0000ce5fcb2b417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487473 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: G. Silva <gfaus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638569} TBR=pkasting@chromium.org,michaelpg@chromium.org,hgrandinetti@chromium.org,gfaus@chromium.org Change-Id: If5471f6687bac6a7fcbaa62f6e67bf4abb93b5ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508583 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638665} chrome/browser/chromeos/BUILD.gn | 34 ------- .../consistency_golden_loader.cc | 71 -------------- .../consistency_golden_loader.h | 41 -------- .../consistency_golden_loader_unittest.cc | 47 --------- .../goldens/consistency_golden.proto | 108 --------------------- .../time_limit_consistency_test/proto_matcher.h | 43 -------- .../test_goldens/test_golden.textproto | 6 -- .../test_goldens/test_golden_unsupported.textproto | 6 -- third_party/protobuf/BUILD.gn | 4 - 9 files changed, 360 deletions(-) commit ab972f74fa41db59c916081e333ea8f3866ca3c2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:48:45 2019 +0000 Roll src/third_party/depot_tools ffb1ffb82284..db5c5ade84ad (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffb1ffb82284..db5c5ade84ad git log ffb1ffb82284..db5c5ade84ad --date=short --no-merges --format='%ad %ae %s' 2019-03-07 ehmaldonado@chromium.org gclient: Fetch refs/{branch-heads,tags}/* if needed. Created with: gclient setdep -r src/third_party/depot_tools@db5c5ade84ad The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938160 TBR=agable@chromium.org Change-Id: Icbdd5562aeb5408f3e67d0f9bcc0a221b4b12131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508835 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638664} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8e8e3ee3726b4471b9d8aa2be0eeeb9527741c00 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Thu Mar 7 18:46:21 2019 +0000 Updating trunk VERSION from 3728.0 to 3729.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7eb7a82223577ece936bed46e2c515377ff05a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509233 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638663} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 980663c9167022c6f5738f9a41571ddee57e5783 Author: Daniel Bratell <bratell@opera.com> Date: Thu Mar 7 18:46:15 2019 +0000 Remove some variable shadowing in blink/core In an effort to reduce or even ban variable shadowing, this renames some variables. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this prevents is: third_party/blink/renderer/core/fileapi/file_reader_loader.cc:358:16: error: declaration shadows a local variable [-Werror,-Wshadow] MojoResult result = consumer_handle_->BeginReadData( ^ third_party/blink/renderer/core/fileapi/file_reader_loader.cc:346:54: note: previous declaration is here void FileReaderLoader::OnDataPipeReadable(MojoResult result) { ^ third_party/blink/renderer/core/aom/accessible_node.cc:288:16: error: declaration shadows a local variable [-Werror,-Wshadow] Element* element = accessible_node->element(); ^ third_party/blink/renderer/core/aom/accessible_node.cc:278:43: note: previous declaration is here bool AccessibleNode::GetProperty(Element* element, ^ third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:43:16: error: declaration shadows a local variable [-Werror,-Wshadow] for (Node& node : FlatTreeTraversal::AncestorsOf(node)) { ^ third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:40:14: note: previous declaration is here for (Node& node : range.Nodes()) { ^ third_party/blink/renderer/core/loader/frame_loader.cc:892:10: error: declaration shadows a local variable [-Werror,-Wshadow] auto request = mojo::MakeRequest(&navigation_initiator); ^ third_party/blink/renderer/core/loader/frame_loader.cc:798:20: note: previous declaration is here FrameLoadRequest request(passed_request); ^ third_party/blink/renderer/core/script/modulator.cc:52:20: error: declaration shadows a local variable [-Werror,-Wshadow] } else if (auto* scope = DynamicTo<WorkerGlobalScope>(execution_context)) { ^ third_party/blink/renderer/core/script/modulator.cc:45:20: note: previous declaration is here } else if (auto* scope = DynamicTo<WorkletGlobalScope>(execution_context)) { ^ Bug: 923510 Change-Id: I82659c403eb15b4f676d24b97414bfbbced9d701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508517 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#638662} third_party/blink/renderer/core/aom/accessible_node.cc | 5 ++--- .../blink/renderer/core/fileapi/file_reader_loader.cc | 13 +++++++------ .../blink/renderer/core/invisible_dom/invisible_dom.cc | 6 +++--- third_party/blink/renderer/core/loader/frame_loader.cc | 4 ++-- third_party/blink/renderer/core/script/modulator.cc | 10 ++++++---- 5 files changed, 20 insertions(+), 18 deletions(-) commit d8cc4739db01e629d525b681ec3ab1f08dcb139f Author: Leonard Grey <lgrey@chromium.org> Date: Thu Mar 7 18:43:45 2019 +0000 Mac: update first run dialogue for dark mode Bug: 939251 Change-Id: Ifbb8384ce97adaf68a32264aa575883886114e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508573 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638661} chrome/browser/ui/cocoa/first_run_dialog_controller.mm | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit e63169edf1976e54997cb913f6e668613047cdd6 Author: Eric Stevenson <estevenson@chromium.org> Date: Thu Mar 7 18:43:36 2019 +0000 Android: Update manifest expectations instructions. The monochrome_public_apk__merge_manifests produced the expectations file and takes a fraction of the time to build. Also added a note about making sure your branch is updated. Change-Id: I3abea3a082ec348c79e92c60c43515829e5dc320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509014 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638660} chrome/android/java/README.md | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) commit b2fe4f8558dd9b6e6cd6e4e21609097e43c64b16 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Mar 7 18:42:37 2019 +0000 GWP-ASan: Rename metadata member variables The slots_ member was always misnamed, as it is really an array of metadata _about_ slots, not the slots (pages) themselves. The slot_metadata member variable would be clearer as 'metadata_addr' to denote that it's an address. These renames are in anticipation of an upcoming change that will make slots/metadata more distinct (no 1:1 mapping.) Bug: 939142 Change-Id: I58e5f8035ea571fe7c0b0a4fb6bb0114580984e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507217 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#638659} .../gwp_asan/client/guarded_page_allocator.cc | 47 +++++++++++----------- .../gwp_asan/client/guarded_page_allocator.h | 2 +- components/gwp_asan/common/allocator_state.cc | 4 +- components/gwp_asan/common/allocator_state.h | 2 +- .../gwp_asan/common/allocator_state_unittest.cc | 2 +- 5 files changed, 29 insertions(+), 28 deletions(-) commit 7a61389f70a94479f5ec23266b5941737956f347 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:42:24 2019 +0000 Roll src/third_party/chromite a6918d7b72a9..2f722bfc7ccb (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a6918d7b72a9..2f722bfc7ccb git log a6918d7b72a9..2f722bfc7ccb --date=short --no-merges --format='%ad %ae %s' 2019-03-07 pprabhu@chromium.org config: Migrate 4 paladins to Skylab Created with: gclient setdep -r src/third_party/chromite@2f722bfc7ccb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0ad5dd0c03e23a65889a32e5b056ed6a73f950a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509032 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638658} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd13225a70402e548c5feacde91f0acbfd7f927f Author: Yann Dago <ydago@chromium.org> Date: Thu Mar 7 18:39:05 2019 +0000 Management WebUI: Put link to chrome://management behind a feature flag When clicking on the 'Managed by your organization' message in the settings page and menu, open chrome://management if the "link-management-page" flag is set to true. Bug: 938991 Change-Id: If2f14a3818a00fc4dd82c46d704d0452415c6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506497 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#638657} chrome/browser/about_flags.cc | 6 ++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ chrome/browser/ui/browser_command_controller.cc | 12 +++++++++--- chrome/browser/ui/webui/managed_ui_handler.cc | 11 ++++++++++- chrome/common/chrome_features.cc | 4 ++++ chrome/common/chrome_features.h | 2 ++ chrome/common/url_constants.cc | 3 +-- tools/metrics/histograms/enums.xml | 4 ++++ 10 files changed, 50 insertions(+), 6 deletions(-) commit bf7381e79453b20111c2295974845f1c45cb5502 Author: David Roger <droger@chromium.org> Date: Thu Mar 7 18:39:00 2019 +0000 [signin][Mice] Do not call FireRefreshTokensLoaded too early This was causing a crash on startup if an account was removed from the device while Chrome was not running. Bug: 936953 Change-Id: I45662ace9c498b6db8b719251e8f7f461dc5531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505447 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#638656} .../signin/core/browser/oauth2_token_service_delegate_android.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit b669b5c78eba7789727dc34b8fe108f02dfcd775 Author: Patrick Noland <pnoland@chromium.org> Date: Thu Mar 7 18:37:57 2019 +0000 [Chromeshine] Add example for fqdn in translation Bug: 939015 Change-Id: If4fbd01fd671b67114dc9f37055f845c4fdc2a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506654 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Auto-Submit: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#638655} chrome/android/java/strings/android_chrome_strings.grd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 576056afa6ce369d4c9eeb3e4276f458eb60aade Author: Michael Crouse <mcrouse@chromium.org> Date: Thu Mar 7 18:37:50 2019 +0000 Adding feature flag for enabling OnePlatform API hints and created a Top Site Provider for querying SiteEngagementService Implemented a feature flag controlled by IsOnePlatformHintsEnabled() for enabling OnePlatform API and requests. Implemented the Top Site Provider inference and implementation for querying the Site Engagement Service to provide the list of top hosts for the OnePlatform to perform the Hints Request to the Cacao server. Updated the unittests for Previews Optimization Guide and Previews Decider Impl to include the TopSiteProvider being passed. Wrote a PreviewsOnePlatformHintBrowserTest for confirming the feature flag and code path is executed safely. Bug: 932707 Change-Id: I2d1a048a86e8c8b33c98c07312cc77bafa9b52dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478362 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#638654} chrome/browser/BUILD.gn | 2 + .../previews_oneplatform_hints_browsertest.cc | 173 +++++++++++++++++++++ chrome/browser/previews/previews_service.cc | 8 +- chrome/browser/previews/previews_service.h | 8 + .../previews/previews_top_host_provider_impl.cc | 50 ++++++ .../previews/previews_top_host_provider_impl.h | 43 +++++ chrome/test/BUILD.gn | 1 + components/optimization_guide/proto/hints.proto | 97 ++++++++++++ components/previews/content/BUILD.gn | 1 + .../content/previews_decider_impl_unittest.cc | 21 ++- .../content/previews_optimization_guide.cc | 42 ++++- .../previews/content/previews_optimization_guide.h | 18 ++- .../previews_optimization_guide_unittest.cc | 17 +- .../previews/content/previews_top_host_provider.h | 27 ++++ components/previews/core/previews_experiments.cc | 9 ++ components/previews/core/previews_experiments.h | 8 + components/previews/core/previews_features.cc | 4 + components/previews/core/previews_features.h | 1 + 18 files changed, 521 insertions(+), 9 deletions(-) commit 1198ba3a7f962d567ba108f7f2449e6a5e1e98a1 Author: Tim Volodine <timvolodine@chromium.org> Date: Thu Mar 7 18:35:48 2019 +0000 [AW NS] Add flaky tests to the instrumentation test filter Add some flaky tests that are failing on android_mojo and android_mojo_rel bots. Because we use android_mojo bot for CQ these tests currently block patches that are trying to land. BUG=936757,939355,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I21052efd28af0f8b693e53df59705db15496e6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508461 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Auto-Submit: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#638653} .../mojo.fyi.network_webview_instrumentation_test_apk.filter | 8 ++++++++ 1 file changed, 8 insertions(+) commit 41719f18ac92526bae07771456c1c74c116cc3ee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:26:05 2019 +0000 Roll Fuchsia SDK from bccf58830632 to 9216f29f7750 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I29bba4682051ec93ff2bb75547a3e7de213f25c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508913 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638652} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 02c51f44994e18c048cdc36e2af49f519392995e Author: Aran Gilman <gilmanmh@google.com> Date: Thu Mar 7 18:22:22 2019 +0000 Re-enable WebpageAccessibility test and update role expectation. The test was originally disabled due to https://crbug.com/101984. The flakiness occurred for Vista builds only, and the bug has not had a significant update since 2012. Bug: 101984 Change-Id: Ifadf55ae2d867e816db2795c9a7eaed0377cc276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497128 Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#638651} .../accessibility/cross_platform_accessibility_browsertest.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 2c77ed71f62e4a8a322476fc7a305699fe174fb1 Author: David Benjamin <davidben@chromium.org> Date: Thu Mar 7 18:21:11 2019 +0000 Fix typo in URL. The go/ link doesn't have an 's' at the end. Change-Id: Iae22758ebcc448ac8b86c02c735ba9f5a4ca5719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506761 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#638650} components/component_updater/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 065117e4e6b9e04bc7ad7ba4f66f3d1b3d8ef2f4 Author: Nicolás Peña Moreno <npm@chromium.org> Date: Thu Mar 7 18:13:58 2019 +0000 [ElementTiming] Add a test to prevent leak in ImageElementTiming Currently we need to notify ImageElementTiming whenever an element will be destroyed, so that it can be removed from the HashSet of images that have been seen by ImageElementTiming. This CL adds unittests for this behavior. Bug: 879270 Change-Id: I7719b9c2bfc594cbf4070b1fe66c9e5325a3a552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506660 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638649} .../renderer/core/paint/image_element_timing.h | 2 +- .../core/paint/image_element_timing_test.cc | 53 ++++++++++++++++++++-- 2 files changed, 50 insertions(+), 5 deletions(-) commit 5277ec60c16878618c81d7b1e2356315abc5ae35 Author: Katie D <katie@chromium.org> Date: Thu Mar 7 18:12:27 2019 +0000 Re-enable autoclick tests since ScopedTaskEnvironment bug is fixed. ScopedTaskEnvironment::NextScheduledRunTime was returning Now() (aka now_ticks_) because sequence_manager is idle, but then ScopedTaskEnvironment::MaybeFastForwardToNextTask DCHECKS that now_ticks_ is strictly < run_time, which was causing test failures. Now that ScopedTaskEnviornment is fixed we can re-enable these tests. Bug: 935651 Change-Id: I5a0cb2967001995a54f2245bac4e5f9022514001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500018 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#638648} ash/autoclick/autoclick_unittest.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 3331cac220174c33c86d631329c4b9bf98c72548 Author: Bo Liu <boliu@chromium.org> Date: Thu Mar 7 18:08:48 2019 +0000 aw: Stop relying on is_layer We use View.getGlobalVisibleRect, and the transform and viewport from functor to compute info for the viewport: * the tile memory budget, which ideally is computed from the size of the visible portion of webview * the viewport and transform used to raster the right tiles at the right scale We usually use getGlobalVisibleRect and transform from functor together if is_layer is false, making the assumption that they both transform between the window space and view space. This turns out not to be true. Instead, use getGlobalVisibleRect to compute the tile budget. And always use the viewport and transform from functor together for tile raster, since they are guaranteed to work together. Change-Id: I4d1346501dab14dbb7b7ca160e0c88fee64aa3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506759 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638647} .../browser/gfx/browser_view_renderer.cc | 37 ++++++++-------------- .../browser/gfx/browser_view_renderer.h | 1 - .../browser/gfx/browser_view_renderer_unittest.cc | 13 +++----- android_webview/browser/gfx/child_frame.cc | 11 +++---- android_webview/browser/gfx/child_frame.h | 9 +++--- android_webview/browser/gfx/hardware_renderer.cc | 3 +- .../gfx/parent_compositor_draw_constraints.cc | 28 ++++------------ .../gfx/parent_compositor_draw_constraints.h | 9 +++--- 8 files changed, 39 insertions(+), 72 deletions(-) commit bd863dd33b16fa4ca6cb6f641f97c96cf6dda0c8 Author: Robert Ogden <robertogden@chromium.org> Date: Thu Mar 7 18:07:48 2019 +0000 Add UMA for HTTP Request Timing on DataReductionProxy's Client Config This CL adds TCP and HTTP timing UMA on every successful request to the client config service. This UMA will be used server side to compare with other metrics for evaluating network quality. Bug: 939121 Change-Id: I84d7867d03f16a57e4131e0043fbc922d50ff187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506442 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#638646} .../data_reduction_proxy_config_service_client.cc | 17 +++++++++++++++++ ...eduction_proxy_config_service_client_unittest.cc | 6 ++++++ tools/metrics/histograms/histograms.xml | 21 +++++++++++++++++++++ 3 files changed, 44 insertions(+) commit 1523294d57d8de58bce10163a6fee075b3dd56a5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:07:44 2019 +0000 Roll src/third_party/perfetto 2d4d2a3cf7b9..356474278798 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/2d4d2a3cf7b9..356474278798 git log 2d4d2a3cf7b9..356474278798 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 fmayer@google.com Improve error message if perfetto invocation fails. 2019-03-07 fmayer@google.com Read from socket to prevent clear notification to service. Created with: gclient setdep -r src/third_party/perfetto@356474278798 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I496e166cba1724b1d47675e842f891db54d5cb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508914 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638645} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 09c211aefb1f8ef9c9cae7ba878ec9076b76aa91 Author: Emircan Uysaler <emircan@chromium.org> Date: Thu Mar 7 18:01:03 2019 +0000 Reset VDA for HDR Color space changes VDA implementations require config.container_color_space and config.target_color_space information to be set to provide correct output. For WebRTC frames that carry this information for VP9.2, we can reinitialize VDA with this info for the correct colors. Bug: 939387 Change-Id: Ib2ef4c7fdfbeef5e6f25a887e32a5c9c4c2e170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476065 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#638644} .../browser_gpu_video_accelerator_factories.cc | 3 +- .../browser_gpu_video_accelerator_factories.h | 3 +- .../gpu/gpu_video_accelerator_factories_impl.cc | 7 +- .../gpu/gpu_video_accelerator_factories_impl.h | 3 +- .../media/webrtc/rtc_video_decoder_adapter.cc | 106 ++++++++++++++++--- .../media/webrtc/rtc_video_decoder_adapter.h | 11 +- .../webrtc/rtc_video_decoder_adapter_unittest.cc | 116 +++++++++++++++++++-- media/base/video_decoder_config.cc | 5 + media/base/video_decoder_config.h | 1 + media/gpu/ipc/service/vda_video_decoder.cc | 8 +- media/video/gpu_video_accelerator_factories.h | 3 +- media/video/mock_gpu_video_accelerator_factories.h | 8 +- 12 files changed, 234 insertions(+), 40 deletions(-) commit df8868a0295530d0bf8b5ff0bbcbd0b6f83adf39 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Thu Mar 7 17:53:53 2019 +0000 Disable SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost. SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost is flaky on all platorms. TBR=boliu@chromium.org Bug: 939338 Change-Id: I21f13d8651b52647f61a0bb8f92d943ff96e7def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508894 Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#638643} content/browser/security_exploit_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit c5594892572821d8e2fee571b7d4687f5bf39a27 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 17:53:11 2019 +0000 flags: assign enable-notification-indicator Bug: 859172 Change-Id: I94d6400a9b0ef983ace670c3adfad68b71c75819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506752 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638642} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 1948770352245fbc218850de8c49813bd575ad3d Author: Shivani Sharma <shivanisha@chromium.org> Date: Thu Mar 7 17:52:47 2019 +0000 History intervention: Reset skippable bit if user gesture after pushState If a navigation entry was marked as skippable because it added an entry using pushState, then a user gesture on the page should reset the skippable bit. If the pushState was done after the user gesture, then the entry would not have been marked as skippable to begin with. This change will make the behavior independent of the ordering between user gesture and pushState. content_browsertests --gtest_filter= NavigationControllerHistoryInterventionBrowserTest. OnUserGestureResetSameDocumentEntriesSkipFlag content_browsertests --gtest_filter= NavigationControllerHistoryInterventionBrowserTest. OnUserGestureDoNotResetDifferentDocumentEntrySkipFlag Test: Bug: 937423 Change-Id: Ie1e55815163ca84950ed7e04fbfa55c06f86c2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499834 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638641} content/browser/frame_host/frame_tree_node.cc | 4 + .../frame_host/navigation_controller_impl.cc | 55 +++++++ .../frame_host/navigation_controller_impl.h | 4 + .../navigation_controller_impl_browsertest.cc | 160 +++++++++++++++++++++ 4 files changed, 223 insertions(+) commit 8106c5b068a2d6bdbf4c0dc689891b98ceaa04ae Author: Dan Harrington <harringtond@chromium.org> Date: Thu Mar 7 17:51:49 2019 +0000 Add original_url to DeletedPageInfo This adds the original_url to the information returned when a page is removed from the offline page model. See bug for motivation. Bug: 884291 Change-Id: I25d11e58347379e06c4a0de8a1cb5b1830cdf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473830 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#638640} .../offline_pages/offline_page_request_handler.cc | 2 +- .../offline_page_request_handler_unittest.cc | 2 +- .../offline_internals_ui_message_handler.cc | 3 +- components/feed/content/feed_offline_host.cc | 8 +-- .../feed/content/feed_offline_host_unittest.cc | 4 +- .../remote/prefetched_pages_tracker_impl.cc | 8 +-- .../prefetched_pages_tracker_impl_unittest.cc | 11 ++-- .../core/downloads/download_ui_adapter_unittest.cc | 2 +- .../core/downloads/offline_item_conversions.cc | 2 +- .../downloads/offline_item_conversions_unittest.cc | 2 +- .../offline_pages/core/model/add_page_task.cc | 2 +- .../core/model/add_page_task_unittest.cc | 2 +- .../offline_pages/core/model/delete_page_task.cc | 72 +++++++++++++--------- .../core/model/delete_page_task_unittest.cc | 34 ++++++++++ .../offline_pages/core/model/get_pages_task.cc | 6 +- .../core/model/offline_page_item_generator.cc | 2 +- .../core/model/offline_page_model_taskified.cc | 2 +- .../model/offline_page_model_taskified_unittest.cc | 6 +- components/offline_pages/core/offline_page_item.cc | 3 +- components/offline_pages/core/offline_page_item.h | 7 ++- .../core/offline_page_metadata_store_unittest.cc | 10 +-- components/offline_pages/core/offline_page_model.h | 9 +++ .../core/prefetch/prefetch_importer_impl.cc | 2 +- .../prefetch/prefetch_importer_impl_unittest.cc | 3 +- 24 files changed, 130 insertions(+), 74 deletions(-) commit 9f0c9622373be29bfda0dd16c8fb93388e22de29 Author: sangseok.jang <sangseok.jang@navercorp.com> Date: Thu Mar 7 17:51:40 2019 +0000 Clean up ThemeProperties::COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT ThemeProperties::COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT is no longer in use, because BookmarkBarInstructionView is removed. However, it still remains, so it is cleaned up. Bug: NONE Change-Id: I7ce14646fafaf07fc426aa96d1b4dab073b51ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506679 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#638639} chrome/browser/themes/theme_properties.cc | 4 ---- chrome/browser/themes/theme_properties.h | 3 --- chrome/browser/themes/theme_service.cc | 4 ---- chrome/browser/ui/libgtkui/gtk_ui.cc | 2 -- 4 files changed, 13 deletions(-) commit d1f761a675fa245ddfc2f94e398a6a32c773e6b5 Author: Kyle Milka <kmilka@chromium.org> Date: Thu Mar 7 17:50:45 2019 +0000 Revert "[NTP] Initiate server-side resource requests earlier" This reverts commit ed15ce53b6ae967580046cb16af6ad71e01fdca7. Previous change prevented promos and search suggestions from appearing properly. Required manual resolution for merge conflicts. Bug: 770640 Change-Id: I37add613a23567d57912623c02441cdb68d261e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507249 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#638638} chrome/browser/resources/local_ntp/local_ntp.js | 70 +++--- chrome/browser/search/local_ntp_source.cc | 278 +++++++++++------------- chrome/browser/search/local_ntp_source.h | 59 ++--- 3 files changed, 191 insertions(+), 216 deletions(-) commit 30381c3084c3d95ca1b5219f98310cb95cefd5c8 Author: Eugene But <eugenebut@chromium.org> Date: Thu Mar 7 17:49:47 2019 +0000 Fix GetPendingItemIndex() for new navigations. Before this CL, GetPendingItemIndex() used to return last committed item index for the new navigations (none-reload, none-back-forward). Presumably this was done before CRWSessionController implemented pendingItemIndex support, when CRWSessionController immediately changed committed item during back-forward navigations. pendingItemIndex support design doc: https://docs.google.com/document/d/1GvsaoNtMO7d87FzoysOW5GqH6XErI5g2cinKhkPk7bQ/edit This CL returns -1 for new navigations, which matches //content. There are 3 places where GetPendingItemIndex is used outside of ios/web: - IOSLiveTab::GetPendingEntryIndex (new implementation matches content, which is the right approach) - GetPossiblyPendingItemAtIndex (new implementation should have no effect because index should be in [0;size] bounds, but this is just an assumption and it's actually unclear if GetPossiblyPendingItemAtIndex relied on undocumented and incorrect behavior). - ReadingListWebStateObserver::LoadOfflineReadingListEntry (new implementation should make the whole block of code obsolete, but it should be fine to leave it as it is because ReadingListWebStateObserver is going to be removed soon). Bug: 665189, 899827 Change-Id: I9538b693c924790620140b37d6c4fea6cce26fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504231 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638637} ios/web/navigation/legacy_navigation_manager_impl.mm | 12 ++---------- ios/web/navigation/navigation_manager_impl_unittest.mm | 16 ++++++++++++++-- ios/web/navigation/wk_based_navigation_manager_impl.mm | 12 +++--------- 3 files changed, 19 insertions(+), 21 deletions(-) commit a5c54e0e8b33b6de0cff8d7cc6d5670d0f315de7 Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Mar 7 17:48:28 2019 +0000 Mac OOP-R crashes: glFlush at every glBindFramebuffer in Skia Bug: 906453 Change-Id: Ice07136126ce35d128054276e86ac641aba2c882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507235 Reviewed-by: enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#638636} ui/gl/init/create_gr_gl_interface.cc | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit 159fbccaeb2b186863ade01df5ad6b9d5144c994 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Thu Mar 7 17:47:01 2019 +0000 Update comments in tab_list_ui/ Bug: None Change-Id: I37c84f9367743b3d2f758eaf9bf0d1094b65aad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507201 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638635} .../browser/tasks/tab_list_ui/TabGridContainerViewBinder.java | 3 +++ .../chrome/browser/tasks/tab_list_ui/TabGridViewHolder.java | 6 +++--- .../tasks/tab_list_ui/TabStripBottomToolbarCoordinator.java | 10 +++++----- .../tasks/tab_list_ui/TabStripBottomToolbarMediator.java | 4 ++-- .../chrome/browser/tasks/tab_list_ui/TabStripViewBinder.java | 2 +- .../chrome/browser/tasks/tab_list_ui/TabStripViewHolder.java | 6 +++--- 6 files changed, 17 insertions(+), 14 deletions(-) commit c1d232108530ae44d3a8f592764c701253a565c9 Author: Anne Lim <annelim@google.com> Date: Thu Mar 7 17:46:08 2019 +0000 [Autofill] Prevent upload save on unsupported cards Gets a new parameter (supported_card_bin_ranges) from the GetDetailsForSaveCardResponse proto, which contains a list of pair of numbers representing ranges of supported card bins. If a card doesn't fall under any of the ranges, the card won't be offered upload save and will be saved locally instead. Change-Id: I17a8742f0d20788131ffb2af29d8a6bcb21c09f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496251 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#638634} chrome/browser/about_flags.cc | 7 +++ chrome/browser/flag-metadata.json | 5 ++ chrome/browser/flag_descriptions.cc | 6 +++ chrome/browser/flag_descriptions.h | 3 ++ .../autofill/core/browser/autofill_metrics.h | 4 +- .../core/browser/credit_card_save_manager.cc | 42 ++++++++++++++-- .../core/browser/credit_card_save_manager.h | 22 +++++++-- .../browser/credit_card_save_manager_unittest.cc | 57 ++++++++++++++++++++++ .../core/browser/local_card_migration_manager.cc | 3 +- .../core/browser/local_card_migration_manager.h | 4 +- .../core/browser/payments/payments_client.cc | 23 +++++++-- .../core/browser/payments/payments_client.h | 5 +- .../browser/payments/payments_client_unittest.cc | 10 ++-- .../core/browser/payments/test_payments_client.cc | 18 ++++--- .../core/browser/payments/test_payments_client.h | 7 ++- .../browser/test_local_card_migration_manager.cc | 6 ++- .../browser/test_local_card_migration_manager.h | 6 ++- .../autofill/core/common/autofill_features.cc | 4 ++ .../autofill/core/common/autofill_features.h | 1 + tools/metrics/histograms/enums.xml | 4 ++ 20 files changed, 209 insertions(+), 28 deletions(-) commit 9a082d5ad0951998ea43eaeefe28b01e310812e9 Author: Mugdha Lakhani <nator@chromium.org> Date: Thu Mar 7 17:45:16 2019 +0000 [Background Fetch] Update Webview expectations. Bug: 766077 Change-Id: Ie52fc2eea6e96580bb064ac3b9c877a0ef96ff2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508466 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#638633} .../test/data/webexposed/not-webview-exposed.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit ce50e1d53ef866f895c86f7d59efe027bc2c1fa8 Author: Matt Menke <mmenke@chromium.org> Date: Thu Mar 7 17:43:47 2019 +0000 Remove group name from ConnectJob layer. ConnectJobs no longer care about group names, so having them store the name is a bit of a layering violation. ConnectJob group names were used for a NetLog event and by the socket pools to locate the group a ConnectJob belonged to. To resolve the first issue, group names are now logged by a NetLog event by the socket pools before starting each ConnectJob (which will require an update in the net log viewer code). To resolve the second issue, Groups are now ConnectJob::Delegates for all the ConnectJobs associated with the group. Beyond fixing the layering violation, this CL serves two purposes: It will make it easier to change group_name from a string to a struct, and it will make it easier to make CommonConnectJobParameters a per-pool object. Bug: 927100, 533571 Change-Id: Ife570e1277ef18b4d916eb6d3ab91a9fccf2bed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506567 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638632} net/http/http_proxy_connect_job_unittest.cc | 4 +- net/log/net_log_event_type_list.h | 10 +- net/socket/client_socket_pool_base.cc | 348 ++++++++++++--------- net/socket/client_socket_pool_base.h | 54 ++-- net/socket/client_socket_pool_base_unittest.cc | 7 +- net/socket/connect_job.cc | 16 +- net/socket/connect_job.h | 9 - net/socket/connect_job_unittest.cc | 1 - net/socket/socks_connect_job_unittest.cc | 2 +- net/socket/ssl_connect_job_unittest.cc | 3 +- net/socket/transport_client_socket_pool.cc | 7 +- net/socket/transport_client_socket_pool.h | 1 - net/socket/transport_connect_job_unittest.cc | 4 +- .../websocket_transport_client_socket_pool.cc | 6 +- net/spdy/spdy_proxy_client_socket_unittest.cc | 2 +- 15 files changed, 250 insertions(+), 224 deletions(-) commit 7e72794c4f13a0d0c987f58715af72f81271b62d Author: Yao Xiao <yaoxia@chromium.org> Date: Thu Mar 7 17:43:01 2019 +0000 Add UseCounter for ad click that results in navigation Record for each window.open(), href link activation, and location=xxx. Those calls should be mutually exclusive. For this metric to be accurate, it has to assume that "the navigation was initiated in a frame with transient gesture" == "the navigation was caused by this gesture", which can be wrong. But it may just work in practice and it seems to be a general assumption we have been making throughout Chrome. Bug: 864147 Change-Id: If7f75bd8d17e1d2ea572607e6f8f4149c78222fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488111 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638631} .../observers/use_counter/ukm_features.cc | 1 + .../page_load_metrics_test_waiter.cc | 5 ++ .../page_load_metrics_test_waiter.h | 3 + .../subresource_filter/ad_tagging_browsertest.cc | 91 ++++++++++++++++++++++ .../public/mojom/web_feature/web_feature.mojom | 1 + .../blink/renderer/core/frame/local_frame.cc | 5 ++ .../blink/renderer/core/frame/local_frame.h | 9 +++ third_party/blink/renderer/core/frame/location.cc | 2 + .../renderer/core/html/html_anchor_element.cc | 2 + .../blink/renderer/core/page/create_window.cc | 1 + tools/metrics/histograms/enums.xml | 1 + 11 files changed, 121 insertions(+) commit f2c92e299042720f90a3464ded962fb2ded40b99 Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Mar 7 17:39:56 2019 +0000 Wrap ARC_PACKAGE in pseudo-USS codepath The sync datatype is the last leftover that hasn't been wrapped in the USS architecture, and could end up in the critical path to future dismantling efforts. The new controller has been simplified by instead introducing the notion of model-readiness in SyncableService, which the USS codepath honors. This makes the new controller a lot simpler, and is aligned with our plans to avoid the notion of model readiness in controllers, and narrow down the scope of DataTypeController::ReadyForStart() to non-transient business logic (i.e. is a datatype allowed to start). Sync integration tests are now parameterized to exercise both codepaths in case the feature toggle must be used in the future as kill switch. Bug: 870624,939329 Change-Id: I9d415eba7bd53f0fd9cf7bbfa00db98b7e916e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507657 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638630} chrome/browser/sync/chrome_sync_client.cc | 13 ++++- .../single_client_arc_package_sync_test.cc | 16 ++++-- .../two_client_arc_package_sync_test.cc | 30 +++++++---- chrome/browser/ui/BUILD.gn | 2 + .../arc/arc_package_sync_model_type_controller.cc | 53 ++++++++++++++++++++ .../arc/arc_package_sync_model_type_controller.h | 46 +++++++++++++++++ .../app_list/arc/arc_package_syncable_service.cc | 16 ++++++ .../ui/app_list/arc/arc_package_syncable_service.h | 3 ++ components/sync/driver/data_type_manager_impl.cc | 58 +++++++++++++--------- components/sync/driver/data_type_manager_impl.h | 5 ++ components/sync/driver/sync_driver_switches.cc | 2 + components/sync/driver/sync_driver_switches.h | 1 + components/sync/model/syncable_service.cc | 6 +++ components/sync/model/syncable_service.h | 6 +++ .../model_impl/syncable_service_based_bridge.cc | 16 ++++-- .../model_impl/syncable_service_based_bridge.h | 1 + .../syncable_service_based_bridge_unittest.cc | 47 ++++++++++++++++-- 17 files changed, 274 insertions(+), 47 deletions(-) commit 60b52be58823da433a0ab17f9365054d32f7b7cc Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Mar 7 17:37:59 2019 +0000 [Media Engagement] Add checks in UpdateScoreDict UpdateScoreDict is causing a crash when we are getting keys and this could be caused by old data that does not have all the keys. This hardens the checks when loading the data. BUG=934165 Change-Id: I35eafc9b2a232ff8cc79fd48b48de9cc09cfc65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508596 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#638629} chrome/browser/media/media_engagement_score.cc | 90 +++++++++++++++++--------- 1 file changed, 60 insertions(+), 30 deletions(-) commit 1ba12aeea5abfa5ae1cf87b91ff29b04229cf795 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 17:33:42 2019 +0000 Schedule a timer to show notifications with a trigger. This is the platform independent version of the notification trigger which simply starts a timer. This requires Chrome to be running at the time the notification should be displayed. If Chrome is not running, the notification will be shown at the next startup. A follow-up CL will override this behaviour for Android and use the BackgroundTaskScheduler to wake up Chrome. Bug: 891339 Change-Id: I679df47d725371aa481c30bcaa742f4760106e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477840 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638628} content/browser/BUILD.gn | 2 + .../blink_notification_service_impl.cc | 18 +- .../blink_notification_service_impl_unittest.cc | 29 +++ .../platform_notification_context_impl.cc | 139 +++++++++++++-- .../platform_notification_context_impl.h | 27 ++- ...atform_notification_context_trigger_unittest.cc | 197 +++++++++++++++++++++ .../platform_notification_service_proxy.cc | 88 +++++++++ .../platform_notification_service_proxy.h | 74 ++++++++ content/test/BUILD.gn | 1 + 9 files changed, 559 insertions(+), 16 deletions(-) commit e3378cb792dbd9f5b55dc3b6653dda438808907f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Mar 7 17:32:40 2019 +0000 Preparation to convert GetPrimaryAccount to return CoreAccountInfo Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: Ic7e29b114fd39ee0c55cafb1a0e526eb1aa78244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499559 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638627} .../google_services/accounts_table_view_controller.mm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 507870b87eb80610752d8e54055ffcdb5c03a79a Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Thu Mar 7 17:32:33 2019 +0000 [LayoutNG] Fix a typo in NGOffsetMapping::GetPositionWithAffinity When the input caret position is "AfterCharacter", the function should look backwards for the result position in DOM. Hence, it should call GetFirstPosition() instead of GetLastPosition(). Bug: 894651 Change-Id: If2c9e8346c38859d0b8674dd56f49fbc71aa3ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506768 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638626} third_party/blink/renderer/core/layout/ng/inline/ng_offset_mapping.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e43501168d7abb1935ec78786152141aae6f53b3 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Mar 7 17:26:37 2019 +0000 Update public API of ModelListAdapter to be more generic This patch is largely removing the use of 'suggestion' from a generic MVC class. Change-Id: I20e5932d0638da0489ed002ffa8555874bd10eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506206 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638625} .../browser/ntp/cards/SuggestionsSection.java | 12 +++----- .../suggestions/SuggestionListViewBinder.java | 2 +- .../browser/ntp/cards/SuggestionsSectionTest.java | 2 +- .../chromium/ui/modelutil/ModelListAdapter.java | 36 +++++++++++----------- 4 files changed, 25 insertions(+), 27 deletions(-) commit 9dbd723e682b19eee3519f925fbcc1356baaf01b Author: Tomasz Wiszkowski <ender@google.com> Date: Thu Mar 7 17:21:47 2019 +0000 Supply accessibility description for refine button. This change adds accessibility content description for refine button Bug: 939014 Change-Id: Ief2f5d1e5aa14498d03eda7827788dfd0d752ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506557 Commit-Queue: Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638624} chrome/android/java/res/layout/omnibox_answer_suggestion.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d926e1bf38e2b16e631f33cf988bc3d226b27653 Author: Oystein Eftevaag <oysteine@chromium.org> Date: Thu Mar 7 17:19:14 2019 +0000 Perfetto: Use the Consumer::ChangeTraceConfig API to add new PIDs to trace Needs https://android-review.googlesource.com/c/platform/external/perfetto/+/910574 to land and roll into Chrome before this can land. R=ssid@chromium.org Bug: 839084 Change-Id: I945eca9387c562a144af30dfee9f7759a23e3f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500134 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#638623} .../perfetto/perfetto_tracing_coordinator.cc | 101 +++++++++++++++------ 1 file changed, 71 insertions(+), 30 deletions(-) commit a3a2a6e54ee42ec87a74a1396b1907867a411233 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 17:18:24 2019 +0000 SPM: Reduce the number of pixels sent to Ash for window icons. There are two icon properties, kAppIcon and kWindowIcon. For the purposes of Ash, these are used interchangeably (kAppIcon is preferred and kWindowIcon is a fallback). Thus we can skip sending kWindowIcon. This should cut down on memory usage by half. Further, the only place that the icon is used for single process mash is in overview mode, which displays the icon at 24dip. We can downscale the icon before sending it over. For tabbed browser windows, that's 24dip*24dip instead of 192px * 192px. Since the icons are set on the content window as well as the root window, they are each copied to the window service twice. We do need to transport the icons that are set on the root window, but not on the content window. PropertyConverter doesn't distinguish on the window type, so new keys are introduced for the root window: kAppIconSmallKey and kAppIconLargeKey. These are the only ones that are sent to the WS. They are only used in Mash. kAppIconKey and kWindowIconKey are retained for use in the browser, e.g. by AppWindowLauncherItemController. kAppIconLargeKey is only set by the task manager and used by ShelfWindowWatcher for the shelf icon. The net effect is that every browser window goes from allocating 192x192px four times, to 24x24dip once. According to chrome://tracing this lops about 4MiB off malloc'd memory in the browser process when there are 10 browser windows open. Bug: 938105 Change-Id: I7bc04784ff3fb1d0857219eae2184542b1f14fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504164 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638622} ash/mus_property_mirror_ash_unittest.cc | 12 ------------ ash/public/cpp/mus_property_mirror_ash.cc | 5 ----- ash/shelf/shelf_window_watcher.cc | 4 +++- ash/wm/overview/caption_container_view.cc | 6 +++++- chrome/browser/ui/views/task_manager_view.cc | 24 ++++++++++++++++++++---- chrome/browser/ui/views/task_manager_view.h | 1 + services/ws/public/mojom/window_manager.mojom | 10 +++++----- ui/aura/client/aura_constants.cc | 2 ++ ui/aura/client/aura_constants.h | 11 +++++++++++ ui/aura/mus/property_converter.cc | 8 ++++---- ui/views/mus/desktop_window_tree_host_mus.cc | 16 +++++++++++++++- ui/views/mus/mus_client.cc | 16 ---------------- 12 files changed, 66 insertions(+), 49 deletions(-) commit 4f4caf15549366b27eee3ce699bec69188500920 Author: Thomas Tangl <tangltom@chromium.org> Date: Thu Mar 7 17:17:13 2019 +0000 Provide new profile avatar icons - New profile avatar icons are added to Chrome. - The avatar selector is refreshed: - Only the new avatars are available for selection. - The icons are made round and bigger. - Existing profiles will keep their current avatars, i.e. they don't need to be migrated. Screenshots: https://drive.google.com/file/d/1m5tDHR9k-2Z9ZkQfza-l7D3oZIsTgftu/view?usp=sharing https://drive.google.com/file/d/11lzTzZJR_qBT4qziY_Z5lbgPgyrBHVBa/view?usp=sharing Bug: 937834 Change-Id: Iffe141de2aa9d176690cc1caaed05afd76adccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505942 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#638621} chrome/app/profiles_strings.grdp | 33 +++ .../common/origami/avatar_cat.png | Bin 0 -> 27691 bytes .../common/origami/avatar_corgi.png | Bin 0 -> 17599 bytes .../common/origami/avatar_dragon.png | Bin 0 -> 32468 bytes .../common/origami/avatar_elephant.png | Bin 0 -> 16601 bytes .../common/origami/avatar_fox.png | Bin 0 -> 16649 bytes .../common/origami/avatar_monkey.png | Bin 0 -> 16607 bytes .../common/origami/avatar_panda.png | Bin 0 -> 15043 bytes .../common/origami/avatar_penguin.png | Bin 0 -> 12119 bytes .../common/origami/avatar_pinkbutterfly.png | Bin 0 -> 25408 bytes .../common/origami/avatar_rabbit.png | Bin 0 -> 12726 bytes .../common/origami/avatar_unicorn.png | Bin 0 -> 36152 bytes chrome/app/theme/theme_resources.grd | 13 ++ .../android/profiles/profile_downloader_android.cc | 4 +- .../browser/profiles/profile_attributes_storage.cc | 4 +- .../browser/profiles/profile_avatar_icon_util.cc | 235 +++++++++++---------- chrome/browser/profiles/profile_avatar_icon_util.h | 16 +- .../profiles/profile_avatar_icon_util_unittest.cc | 2 +- chrome/browser/profiles/profile_metrics.cc | 11 +- .../profiles/profile_shortcut_manager_win.cc | 24 ++- .../ui/cocoa/profiles/profile_menu_controller.mm | 6 +- .../settings/settings_manage_profile_handler.cc | 16 +- .../settings/settings_manage_profile_handler.h | 2 + .../settings_manage_profile_handler_unittest.cc | 31 ++- .../ui/webui/signin/user_manager_screen_handler.cc | 4 +- .../cr_profile_avatar_selector.html | 8 +- 26 files changed, 255 insertions(+), 154 deletions(-) commit ffdeffe8fb9f85e59dcc58a8163ca9a5eae1a6b0 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Mar 7 17:16:17 2019 +0000 Use PrefService directly in DownloadArchiveManager instead of Profile. Bug: 937007 Change-Id: Ibe088bf8b76446098520284a50ac84ec5140ce0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495801 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638620} .../offline_pages/android/offline_page_model_factory.cc | 2 +- .../browser/offline_pages/download_archive_manager.cc | 9 ++++----- chrome/browser/offline_pages/download_archive_manager.h | 6 +++--- .../offline_pages/download_archive_manager_unittest.cc | 17 +++++++++-------- 4 files changed, 17 insertions(+), 17 deletions(-) commit aca01cb1c0bd97c1536ad51ab99ef2476b7b3694 Author: Ella Ge <eirage@chromium.org> Date: Thu Mar 7 17:16:09 2019 +0000 Make captured mouse pointer event route correctly on oopif Before this change, we do not capture mouse events to widget when set/release pointer capture. It causes a bug that when mouse down on main frame and set pointer capture, mouse still not capture to the main frame widget because we neither set widget capture on main frame mouse down nor set widget capture on pointer capture set. This CL makes PEM::SetPointerCapture and ReleasePointerCapture returns a boolean to shows whether pointer capture is changed, and we change widget capture accordingly. Change-Id: I1d571659237c81f8575d4556d725c22c8c2b862f Bug: 936190, 919908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1446500 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638619} .../site_per_process_hit_test_browsertest.cc | 119 +++++++++++++++++++++ .../blink/renderer/core/input/event_handler.cc | 8 +- .../renderer/core/input/pointer_event_manager.cc | 11 +- .../renderer/core/input/pointer_event_manager.h | 4 +- 4 files changed, 135 insertions(+), 7 deletions(-) commit d9fda17dcbb5d48982f11a349a2cb98b2c402ba3 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Mar 7 17:12:07 2019 +0000 Automation API should include image labeling AXMode We recently introduced a new AXMode that turns on image labeling for a WebContents, and it's integrated into BrowserAccessibilityState, the mechanism used to set the global AXMode on most platforms. On Chrome OS the mechanism is slightly different, using the automation API, and we missed one place. Fix it by merging the AXMode set for the automation API with the image labeling flag if needed, and add a test for it. Bug: 938637, 905419 Change-Id: I273b35e3ef2457207f8a5ff4482cfeae4178027d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504695 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638618} .../accessibility/accessibility_labels_service.cc | 3 +- .../api/automation/automation_apitest.cc | 40 +++++++++++++++++ content/browser/web_contents/web_contents_impl.cc | 15 +++++-- ui/accessibility/BUILD.gn | 1 + ui/accessibility/PRESUBMIT.py | 6 ++- ui/accessibility/ax_mode.cc | 50 ++++++++++++++++++++++ ui/accessibility/ax_mode.h | 20 ++++++++- 7 files changed, 128 insertions(+), 7 deletions(-) commit a4f1a1ed56911611b684b6e259c501bcc07d189e Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Thu Mar 7 17:10:57 2019 +0000 [Payment Request][Android] Attach UI right before blocking interactions Before this patch, if PaymentRequest.show() was called in a CCT, then user opened the CCT page in Chrome, and a skip-UI payment app was slow to respond to the `canmakepayment` event, then the activity to which Chrome attached the payment UI would be gone by the time the payment UI needs to be shown, which would cause a crash. The skip-UI bit is important, because in this flow Chrome blocks UI interactions only after launching the payment app (after the response to `canmakepayment` event). This patch waits to attach the payment UI to the current Chrome activity via buildUI(chromeActivity) until immediately before blocking UI interactions via mUI.show() or mUI.dimBackground(). After this patch, Chrome does not crash when PaymentRequest.show() was called in a CCT for skip-UI flow and the user opened the CCT page in Chrome before the payment app responded to the `canmakepayment` event. Bug: 817073 Change-Id: I5ce50d000c2f64a60c62955d9e3e8f080498238d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506494 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638617} .../browser/payments/PaymentRequestImpl.java | 91 ++++++++++++---------- 1 file changed, 50 insertions(+), 41 deletions(-) commit 6b22924a6df58af33a6c21e7d88857395be848ff Author: Maksim Sisov <msisov@igalia.com> Date: Thu Mar 7 17:10:32 2019 +0000 [ozone/wayland] Let Wayland compositor decide how to place menu windows This patch fixes disposition/misplacement of menu windows and let the Wayland compositor decide how to place the windows if their pixels cannot be shown on one display or if they are partly going to be hidden because of being shown too close to some edges of a display. First of all, Chromium positions windows using screen coordinates. As long as Wayland does not provide global coordinates, the client does not know the position of windows in screen coordinates and always assumes that they are located on 0,0. What's left for us to do is to translate bounds from screen coordinates to relative to parent coordinates, which is easy to do. Secondly, WaylandWindow re-positions nested menus back to the right side of parent menus (if the size of a top level window is close or equal to the work area of a display) and let Wayland compositor decide how to position them based on calculated anchor rect, anchor and gravity. The exception for this is based on the maximized state of a top level window. If it's maximized, then the nested windows are not re positioned and left on the left side of the parent menu windows. Also, WaylandWindow must be able to recalculate origin back from relative to parent to be relative to top level window aka on screen location. The unittests exercises all those mentioned cases and make sure WaylandWindow is able to calculated bounds correctly (the values are taken by manual usage of the Chromium browser and logs). PS XdgVersionV5Test/WaylandWindowTest.AdjustPopupBounds/0 is skipped as long as it does not support xdg positioner. Test: XdgVersionV6Test/WaylandWindowTest.AdjustPopupBounds/0 Bug: 927280 Change-Id: I30573620562e7bc5dfd3a69487326bcda49fc6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474654 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#638616} ui/ozone/platform/wayland/test/mock_surface.h | 10 + ui/ozone/platform/wayland/test/mock_xdg_popup.cc | 5 +- ui/ozone/platform/wayland/test/mock_xdg_popup.h | 20 +- ui/ozone/platform/wayland/test/mock_xdg_shell.cc | 10 +- ui/ozone/platform/wayland/test/mock_xdg_surface.cc | 15 +- ui/ozone/platform/wayland/test/mock_xdg_surface.h | 11 + ui/ozone/platform/wayland/test/test_positioner.cc | 21 +- ui/ozone/platform/wayland/test/test_positioner.h | 34 ++- ui/ozone/platform/wayland/wayland_window.cc | 108 +++++++- ui/ozone/platform/wayland/wayland_window.h | 6 + .../platform/wayland/wayland_window_unittest.cc | 300 +++++++++++++++++++++ ui/ozone/platform/wayland/xdg_popup_wrapper_v5.cc | 4 + ui/ozone/platform/wayland/xdg_popup_wrapper_v6.cc | 209 +++++++++++++- ui/ozone/platform/wayland/xdg_popup_wrapper_v6.h | 1 + 14 files changed, 709 insertions(+), 45 deletions(-) commit 89f296b34f4f33e048848c06da08fc9271b30bc9 Author: Sebastien Lalancette <seblalancette@chromium.org> Date: Thu Mar 7 17:09:51 2019 +0000 [AF] Prevent Logging Password Values to Console Before sending over to be logged by DevTools, filter out DOM nodes that have a type attribute equal to "password", and that are not empty. Bug: 934609 Change-Id: I147ad0c2bad13cc50394f4b5ff2f4bfb7293114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506498 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638615} .../content/renderer/page_form_analyser_logger.cc | 30 +++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) Updated tag 'tree_truth' (was 70bf80622015)