Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 40403 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919614837103986512 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it4RvFLK/luci_context.259172227 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2227-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4372991af9538411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: bad4466270baf3384a0d330a514913d467bea90e make widget stay visible when root window is minimized David Bienvenu, Thu Mar 7 20:08:37 2019 +0000 91d93e8fcd250fb13609b87ae84877aada821a28 Disable QuartcEndpointTest.VersionNegotiationWithDisjointVersions Reid Kleckner, Thu Mar 7 20:07:50 2019 +0000 7200f77562dcd11cf3fefbd360448c69f1d9d854 Reland "pdf: Switch to the threaded version of ink" dstockwell, Thu Mar 7 20:05:19 2019 +0000 a3416d2c120b44124e29d0ce2a59a0258eea00df Add 'Devices' tab to chrome://usb-internals Nancy Li, Thu Mar 7 20:01:59 2019 +0000 821c5a89bd0a540e2d54177a7ec625c1934ed855 [Background Fetch] Ship it! Mugdha Lakhani, Thu Mar 7 20:01:21 2019 +0000 26bd514dc68b4f0b71fe47ac8b25092e9076b9d3 Roll src/third_party/perfetto 356474278798..3cfa438106ff (1 commits) chromium-autoroll, Thu Mar 7 20:00:34 2019 +0000 bb0c1fdee519b0e5ac89da6e2c524b75821bf9dd Fix client area calculation Jun Mukai, Thu Mar 7 19:59:46 2019 +0000 c7021cb349850cf8e68731738b9e66b55096c7a3 Revert "AudioService: Fixes for loopback underruns/timing issues." Robert Liao, Thu Mar 7 19:59:26 2019 +0000 3f8b2db51f3935a39ac56c111448b58cc8c8c09c Reconcile code differences between google3 and Chromium QUIC code Victor Vasiliev, Thu Mar 7 19:57:46 2019 +0000 0a942fb1b37132032e9e26f76338df802307193c Disable BlinkGenPropertyTrees by default Philip Rogers, Thu Mar 7 19:57:15 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit bad4466270baf3384a0d330a514913d467bea90e Author: David Bienvenu <davidbienvenu@chromium.org> Date: Thu Mar 7 20:08:37 2019 +0000 make widget stay visible when root window is minimized This was a regression caused by crrev.com/c/1326621, which showed/hid the root window on Restore/Minimize. In turn this caused DesktopNativeWidgetAura::IsVisible() to return false for minimized widgets, because |content_window_| was not visible. Fix is to use TargetVisibility() instead of IsVisible(). Bug: 813093, 927489 Change-Id: I7cb97ccae6452320ee4a906875535f618e1ab013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1406069 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638715} .../desktop_aura/desktop_native_widget_aura.cc | 4 +-- ui/views/widget/widget_interactive_uitest.cc | 34 +++++++++------------- 2 files changed, 16 insertions(+), 22 deletions(-) commit 91d93e8fcd250fb13609b87ae84877aada821a28 Author: Reid Kleckner <rnk@google.com> Date: Thu Mar 7 20:07:50 2019 +0000 Disable QuartcEndpointTest.VersionNegotiationWithDisjointVersions It fails in Windows component builds from what I can tell. It fails this CHECK: FATAL:simulator.cc(45)] Check failed: emplace_times_result.second. This suggests to me that some initializer is running more than once because it gets linked into multiple DLLs, and the code can't cope with that. TBR=rch@chromium.org, shend@chromium.org, vasilvv@chromium.org NOTRY=true Bug: 938773 Change-Id: Id8b2b270bc9df0a957003af0677654c8a0989086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509105 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638714} net/third_party/quic/quartc/quartc_endpoint_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7200f77562dcd11cf3fefbd360448c69f1d9d854 Author: dstockwell <dstockwell@google.com> Date: Thu Mar 7 20:05:19 2019 +0000 Reland "pdf: Switch to the threaded version of ink" This is a reland of 99d553b36101f7d2ab0c6a02433a39114f7cbf7c This was reverted due to timeouts waiting for the Web Assembly module to load on debug builds. The test has now been disabled for that configuration. Original change's description: > pdf: Switch to the threaded version of ink > > Updates the resource manager to not require a mime type when loading > a bundled resource. This is the same as the behavior in [1]. > > [1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340 > > Bug: 902646 > Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194 > Commit-Queue: dstockwell <dstockwell@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638324} Bug: 902646 Change-Id: I9fa70cad6892a24185e12b7cd72f46773a98a8a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508433 Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638713} .../extensions/chrome_component_extension_resource_manager.cc | 2 ++ chrome/browser/extensions/chrome_url_request_util.cc | 4 ---- third_party/ink/ink_resources.grd | 6 ++++-- 3 files changed, 6 insertions(+), 6 deletions(-) commit a3416d2c120b44124e29d0ce2a59a0258eea00df Author: Nancy Li <nancyly@google.com> Date: Thu Mar 7 20:01:59 2019 +0000 Add 'Devices' tab to chrome://usb-internals This change added 'Device' tab to the chrome://usb-internals page, and can display all the real devices that connected to the machine. Bug: 928923 Change-Id: Ie1f3c2dcea69dabdfb43ea5dbe1ae516573cd694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473710 Commit-Queue: Nancy Li <nancyly@google.com> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638712} chrome/browser/browser_resources.grd | 9 ++- chrome/browser/resources/usb_internals/BUILD.gn | 9 +-- .../resources/usb_internals/devices_page.js | 65 ++++++++++++++++++++++ .../resources/usb_internals/usb_internals.html | 54 ++++++++++++++++-- .../resources/usb_internals/usb_internals.js | 35 ++++++++---- chrome/browser/ui/webui/usb_internals/BUILD.gn | 1 + .../ui/webui/usb_internals/usb_internals.mojom | 4 ++ .../usb_internals/usb_internals_page_handler.cc | 8 +++ .../usb_internals/usb_internals_page_handler.h | 5 +- .../ui/webui/usb_internals/usb_internals_ui.cc | 22 +++++--- device/usb/public/mojom/BUILD.gn | 1 + 11 files changed, 182 insertions(+), 31 deletions(-) commit 821c5a89bd0a540e2d54177a7ec625c1934ed855 Author: Mugdha Lakhani <nator@chromium.org> Date: Thu Mar 7 20:01:21 2019 +0000 [Background Fetch] Ship it! This removes all checks for feature flags, removes the feature flags themselves, and updates any affected tests. Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-iAATJCpcNY Bug: 704729 Change-Id: I69bfd29787ad5d3299991cfa1b77f33c597a8e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508092 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638711} android_webview/browser/aw_browser_context.cc | 2 - .../background_fetch_browsertest.cc | 7 ---- .../background_fetch/background_fetch_event.idl | 2 +- .../background_fetch/background_fetch_manager.idl | 2 +- .../background_fetch/background_fetch_record.idl | 2 +- .../background_fetch_registration.idl | 2 +- .../background_fetch_update_ui_event.idl | 2 +- ...ervice_worker_global_scope_background_fetch.idl | 2 +- ...ervice_worker_registration_background_fetch.idl | 2 +- .../renderer/modules/permissions/permissions.cc | 5 --- .../platform/runtime_enabled_features.json5 | 3 +- .../backgroundfetch-origin-trial-interfaces.html | 36 ------------------ ...igin-trial-interfaces-serviceworker-disabled.js | 12 ------ ...igin-trial-interfaces-serviceworker-enabled.php | 32 ---------------- ...ckgroundfetch-origin-trial-interfaces-worker.js | 16 -------- ...l-interface-listing-service-worker-expected.txt | 44 ++++++++++++++++++++++ ...interface-listing-dedicated-worker-expected.txt | 28 ++++++++++++++ .../global-interface-listing-expected.txt | 28 ++++++++++++++ ...al-interface-listing-shared-worker-expected.txt | 28 ++++++++++++++ 19 files changed, 136 insertions(+), 119 deletions(-) commit 26bd514dc68b4f0b71fe47ac8b25092e9076b9d3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 20:00:34 2019 +0000 Roll src/third_party/perfetto 356474278798..3cfa438106ff (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/356474278798..3cfa438106ff git log 356474278798..3cfa438106ff --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cferris@google.com Update for new function malloc_init. Created with: gclient setdep -r src/third_party/perfetto@3cfa438106ff The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4fd6e5089a3b43ce1ee44291e416efc5522c864b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509133 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638710} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bb0c1fdee519b0e5ac89da6e2c524b75821bf9dd Author: Jun Mukai <mukai@chromium.org> Date: Thu Mar 7 19:59:46 2019 +0000 Fix client area calculation When the draggable_regions->getBounds() has smaller width than the widget's width, the inset decreases the top regions of the widget but inversion is computed against draggable_regions width, so it misses some additional client areas asides the draggable regions. Instead, the inversion needs to be computed against the areas decreased by the inset. Bug: 939094 Test: manually Change-Id: Ia1b509b6ec5cf1ba10b44919b1da73eb03942608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509097 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638709} .../ui/views/apps/chrome_native_app_window_views_aura_ash.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit c7021cb349850cf8e68731738b9e66b55096c7a3 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 7 19:59:26 2019 +0000 Revert "AudioService: Fixes for loopback underruns/timing issues." This reverts commit 4f9a19f16e84020024cb768e34b695ca240fa69d. Reason for revert: Suspected in causing webkit_layout_test failures https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/9784 * media/video-played-collapse.html * virtual/video-surface-layer/media/video-played-collapse.html Original change's description: > AudioService: Fixes for loopback underruns/timing issues. > > Fixes a "choppy audio" issue on platforms with certain audio timing > parameters/scenarios. Investigation on crbug.com/934770 led to the > realization that three related problems needed to be addressed: > > 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH > directions, not just one direction; and on both the input and output > flows. This accounts for the case where a device-switch in > audio::OutputController results in a sudden drastic shift in the delay > timestamps. > > 2. Add automatically-increasing capture delay logic to > audio::LoopbackStream to ensure the reads from all nodes' delay buffer > will never result in underrun. > > 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) > addressing a subtle source of error in task scheduling delay math due to > integer truncation; b) exposing timestamps to worker callbacks that > allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| > that behaves just like a real AudioOutputStream. This "lessens the blow" > of a device-switch to SnooperNode. > > Bug: 934770 > Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Max Morin <maxmorin@chromium.org> > Reviewed-by: Oskar Sundbom <ossu@chromium.org> > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638427} TBR=dalecurtis@chromium.org,miu@chromium.org,braveyao@chromium.org,maxmorin@chromium.org,ossu@chromium.org Change-Id: I845f547c60481ebde0ae24d1a83d59f2f750f7e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509365 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638708} .../media/capture/web_contents_audio_muter.cc | 18 ++--- media/audio/fake_audio_input_stream.cc | 21 ++---- media/audio/fake_audio_input_stream.h | 2 +- media/audio/fake_audio_output_stream.cc | 15 ++--- media/audio/fake_audio_output_stream.h | 7 +- media/audio/null_audio_sink.cc | 16 ++--- media/audio/null_audio_sink.h | 3 +- media/audio/virtual_audio_input_stream.cc | 9 ++- media/audio/virtual_audio_input_stream.h | 2 +- media/base/fake_audio_worker.cc | 77 +++++++--------------- media/base/fake_audio_worker.h | 12 +--- media/base/fake_audio_worker_unittest.cc | 8 +-- media/base/silent_sink_suspender.cc | 15 ++--- services/audio/loopback_stream.cc | 40 +++-------- services/audio/loopback_stream.h | 15 ++--- services/audio/snooper_node.cc | 72 ++------------------ services/audio/snooper_node.h | 13 ---- services/audio/stream_factory.cc | 13 ++-- 18 files changed, 91 insertions(+), 267 deletions(-) commit 3f8b2db51f3935a39ac56c111448b58cc8c8c09c Author: Victor Vasiliev <vasilvv@chromium.org> Date: Thu Mar 7 19:57:46 2019 +0000 Reconcile code differences between google3 and Chromium QUIC code Merge internal change: 237089889 R=rch@chromium.org Change-Id: I8051e8cb9260833d678884a0affcb272ada8cd12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507194 Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638707} net/BUILD.gn | 6 +- .../quic/core/crypto/common_cert_set.cc | 11 +- net/third_party/quic/core/crypto/quic_random.cc | 19 +- .../quic/core/quic_epoll_alarm_factory.cc | 10 +- .../quic/core/quic_epoll_connection_helper.h | 5 +- net/third_party/quic/core/quic_packet_reader.cc | 4 +- net/third_party/quic/core/quic_packet_reader.h | 2 - net/third_party/quic/core/quic_version_manager.h | 5 +- net/third_party/quic/core/tls_handshaker.cc | 6 +- .../platform/api/quic_default_buffer_allocator.h | 16 ++ .../quic/platform/api/quic_system_event_loop.h | 2 + .../impl/quic_default_buffer_allocator_impl.h | 13 + .../quic/platform/impl/quic_epoll_clock_test.cc | 2 +- .../platform/impl/quic_epoll_test_tools_impl.h | 2 +- .../quic/platform/impl/quic_socket_address_impl.cc | 7 +- .../quic/platform/impl/quic_socket_utils.h | 3 + .../platform/impl/quic_system_event_loop_impl.h | 12 + .../quic/quartc/quartc_endpoint_test.cc | 6 +- net/third_party/quic/tools/quic_client_bin.cc | 318 ++++++++++----------- .../quic/tools/quic_packet_printer_bin.cc | 62 ++-- .../quic/tools/quic_reject_reason_decoder_bin.cc | 17 +- .../epoll_server}/fake_epoll_server.cc | 2 +- .../epoll_server}/fake_epoll_server.h | 6 +- 23 files changed, 270 insertions(+), 266 deletions(-) commit 0a942fb1b37132032e9e26f76338df802307193c Author: Philip Rogers <pdr@chromium.org> Date: Thu Mar 7 19:57:15 2019 +0000 Disable BlinkGenPropertyTrees by default Due to existing regressions, this patch disables BlinkGenPropertyTrees. For completeness (to prevent another http://crbug.com/935195), tested: +------------------------------------------------+-----------+------------+ | flag | pre-patch | post-patch | +------------------------------------------------+-----------+------------+ | no flag | BGPT on | BGPT on* | | --enable-features=BlinkGenPropertyTrees | BGPT on | BGPT on | | --disable-features=BlinkGenPropertyTrees | BGPT off | BGPT off | | --enable-blink-features=BlinkGenPropertyTrees | BGPT on | BPGT on | | --disable-blink-features=BlinkGenPropertyTrees | BGPT off | BGPT off | +------------------------------------------------+-----------+------------+ * This is due to the finch field trial testing config. content/child/runtime_features.cc now checks for experimental web platform features because the BlinkGenPropertyTrees flag is fully controlled by the feature default in third_party/blink/common/features.cc and would be disabled in web tests (formerly layout tests) without this check. Bug: 836884 Change-Id: I590e1b7c697c7c70cf3c4c5121483b2dd76c74df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505836 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638706} content/child/runtime_features.cc | 3 ++- third_party/blink/common/features.cc | 2 +- third_party/blink/renderer/platform/runtime_enabled_features.json5 | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) commit 08e03db9302e1f7768a1acfd51027e54f6595a5e Author: John Delaney <johnidel@chromium.org> Date: Thu Mar 7 19:53:50 2019 +0000 Fix subresource filter mojom deps These deps(introduced by https://crrev.com/74efc1ddfa7c8) are causing some builds to flake because the mojom headers are being exported before the mojom c++ sources are generated. Moving the mojom dep to public deps will prevent this from occuring. See bug for more info. Bug: 939044 Change-Id: I9f0c6d2a5bf0f1c7f7d016b1170e8c2c5d2d02c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506765 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638705} components/subresource_filter/content/browser/BUILD.gn | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 12970ea5d13264c0031f61fa29315f84a038d43c Author: Dmitry Titov <dimich@chromium.org> Date: Thu Mar 7 19:53:29 2019 +0000 Fix the reporting timeout for ExploreSites.MonthlyHostCount. Writing timestamp before the actual reporting may actually result in skipping the reporting and waiting another week before the next opportunity. Move the timestamp writing to the after the reporting was actually done. Bug: 939213 Change-Id: I540d1780ed95c361959732655796270e95787dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507393 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638704} chrome/browser/android/explore_sites/history_statistics_reporter.cc | 3 ++- .../android/explore_sites/history_statistics_reporter_unittest.cc | 6 ++---- 2 files changed, 4 insertions(+), 5 deletions(-) commit 75fdde1a37d8ff616838942fa7f94d4b5ea3733b Author: Marco Paniconi <marpan@google.com> Date: Thu Mar 7 19:52:28 2019 +0000 Roll src/third_party/libvpx/source/libvpx/ d64e32862..8256c8b29 (3 commits) https://chromium.googlesource.com/webm/libvpx.git/+log/d64e328624e0..8256c8b297c8 $ git log d64e32862..8256c8b29 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 marpan vp9-rtc: Improve mode check on flat blocks in screen mode 2019-03-06 marpan vp9-denoiser: Bias to last for golden long term 2019-03-04 johannkoenig add -Wmissing-prototypes Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I4e4b198174b59f023a7e1e399785adeed12d58dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508602 Reviewed-by: Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#638703} DEPS | 2 +- third_party/libvpx/README.chromium | 4 +-- third_party/libvpx/libvpx_srcs.gni | 35 +++++++++++++++++--------- third_party/libvpx/source/config/vpx_version.h | 6 ++--- 4 files changed, 29 insertions(+), 18 deletions(-) commit 0d117ba14965e16989bcc8942ab9c7525853d591 Author: Donn Denman <donnd@chromium.org> Date: Thu Mar 7 19:52:21 2019 +0000 [TTS] Update Coca requests to support Definitions. Updates the requests that we send to the server to use the next higher API level for Coca, when enabled by the Definitions Feature. We will use this to activate contextual definitions. This API level supports returning the full search URLs from the server, so we don't need to build them from scratch on the client. These new search URLs get passed through the system, and is the only thing touching most of the files in this CL. We also update our Field Trial support for Contextual Search to allow a Feature-param on the Definitions Feature to specify the Coca integration level so we can have multiple finch-controlled experiment arms that control server-functionality. We plan to use this for different triggering levels for Definition cards. BUG=936695 Change-Id: I0666d07000447a9cfb4be5a2344d29c24c47f4a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501759 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638702} .../contextualsearch/ContextualSearchManager.java | 19 +++--- .../ContextualSearchNetworkCommunicator.java | 5 +- .../contextualsearch/ContextualSearchRequest.java | 59 +++++++++++++---- .../ContextualSearchFakeServer.java | 73 ++++++++++++++-------- .../ContextualSearchManagerTest.java | 25 +++++--- .../ContextualSearchRequestTest.java | 29 ++++++++- .../ContextualSearchTapEventTest.java | 2 +- .../contextualsearch/contextual_search_delegate.cc | 26 +++++++- .../contextualsearch/contextual_search_delegate.h | 4 +- .../contextual_search_delegate_unittest.cc | 15 ++++- .../contextual_search_field_trial.cc | 8 +++ .../contextualsearch/contextual_search_manager.cc | 9 ++- .../contextualsearch/resolved_search_term.cc | 12 +++- .../contextualsearch/resolved_search_term.h | 6 +- 14 files changed, 222 insertions(+), 70 deletions(-) commit e154412785e3ea47a001f05cc27e862a176909bb Author: Tien Mai <tienmai@chromium.org> Date: Thu Mar 7 19:51:18 2019 +0000 [GCPW] Add Windows version information in some log messages Bug: 939353 Change-Id: I8e4486cc471164b0586076361b2155b8bdc7bc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508772 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#638701} .../gaiacp/gaia_credential_provider_module.cc | 5 ++++- chrome/credential_provider/gaiacp/gcp_utils.cc | 14 +++++++++++++- chrome/credential_provider/gaiacp/gcp_utils.h | 5 +++++ chrome/credential_provider/setup/setup.cc | 4 +++- 4 files changed, 25 insertions(+), 3 deletions(-) commit 1eca54dd8a65153e3c68d1630c6bf4b5d1a7e143 Author: Natalie Chouinard <chouinard@chromium.org> Date: Thu Mar 7 19:48:55 2019 +0000 [Feed Internals] Add current content This internals page is used to surface debugging information useful to developers of the NTP Interest Feed. This CL surfaces the current Feed content, including suggestion titles, URLs and other metadata. https://screenshot.googleplex.com/gGGcX0BZkYM Bug: 913126 Change-Id: I48dd63698229f43bb1671a0035e7c0b6cf34559a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506539 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638700} .../resources/feed_internals/feed_internals.css | 6 +++ .../resources/feed_internals/feed_internals.html | 31 +++++++++++++++ .../resources/feed_internals/feed_internals.js | 44 ++++++++++++++++++++++ .../ui/webui/feed_internals/feed_internals.mojom | 21 +++++++++++ .../feed_internals/feed_internals_page_handler.cc | 32 +++++++++++++++- .../feed_internals/feed_internals_page_handler.h | 16 ++++++++ components/feed/core/feed_scheduler_host.h | 2 +- 7 files changed, 150 insertions(+), 2 deletions(-) commit 168598eaf6ed9dc66ac3cebcd2ea7c13d34b9168 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 19:42:16 2019 +0000 flags: assign {,ui-show-}composited-layer-borders Bug: None Change-Id: I47934cdb696aca8e697f7c461495fb67edf4a894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508784 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#638699} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2fcff9f38e426b5ca2c448f721e8d0d7d86d47cc Author: Drew Davenport <ddavenport@chromium.org> Date: Thu Mar 7 19:42:12 2019 +0000 gpu: Set exit_on_context_loss for AMD chromebooks Before https://crrev.com/c/1363676, a logic bug ensured that all Chrome OS devices would exit the gpu process on context loss. It turns out that this workaround was necessary for AMD chromebooks to pass the dEQP-EGL.functional.robustness.reset_context.shaders.infinite_loop.* tests. BUG=b:123606754 TEST=pass dEQP-EGL on grunt Change-Id: I34f2d601cc0643cdae568955830e56ac3164f851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504304 Commit-Queue: Drew Davenport <ddavenport@chromium.org> Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Auto-Submit: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#638698} gpu/config/gpu_driver_bug_list.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 98ac778ed1f81448049e5b56921e7c199dc11daf Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 19:39:38 2019 +0000 flags: assign smart-text-selection Bug: None Change-Id: Ia33fbcb45db07ff825df129abcd8a5e23c1eda08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509234 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638697} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 172275e51f63486e85d03f73d1cd24f72c65a2a4 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 19:39:17 2019 +0000 flags: assign disallow-unsafe-http-downloads Bug: 839986 Change-Id: Ib7d6a38a6b62d467b299d5f06b840d308fcb6ab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508787 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638696} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af2d551811f6e2f948c7e89d73383825127b6e1f Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 19:33:56 2019 +0000 Roll src-internal fff41430adb0..cb039b04e175 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fff41430adb0..cb039b04e175 Created with: gclient setdep -r src-internal@cb039b04e175 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I1721de6ed48dace03583dd2d7d9850091a62259e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508992 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638695} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 294678e4630daf786c91565ab368d8779a8d59a1 Author: Josh Nohle <nohle@google.com> Date: Thu Mar 7 19:31:38 2019 +0000 Fix container overflow in CryptAuthKeyCreatorImpl In CryptAuthKeyCreatorImpl, elements of a flat_map were being erased while the flat_map was still being iterated through. This caused a container overflow ASAN error in http://crrev.com/c/1504121. Verified locally that this CL fixes the ASAN error seen in http://crrev.com/c/1504121, using the same gn args as the linux_chromium_chromeos_asan_rel_ng builder. Bug: 899080 Change-Id: I6f25d795545548ed108e95e2e1ec70f6de20941b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507314 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#638694} .../services/device_sync/cryptauth_key_creator_impl.cc | 15 ++++++++------- .../services/device_sync/cryptauth_key_creator_impl.h | 1 + 2 files changed, 9 insertions(+), 7 deletions(-) commit 8421f880fa8fb1f0136150752f206d49d83a307a Author: Bo Liu <boliu@chromium.org> Date: Thu Mar 7 19:31:13 2019 +0000 aw: Clear presentation feedback Presentation is not yet hooked up for android webview. Currently it is leaking a little bit of memory for every new compositor frame submitted. Just clear that map for now. Bug: 939381 Change-Id: I992835d4b2e68ea97ae8baaf435e29298ec2dc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508892 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638693} android_webview/browser/gfx/hardware_renderer.cc | 3 +++ .../viz/service/frame_sinks/compositor_frame_sink_support.cc | 7 +++++++ .../viz/service/frame_sinks/compositor_frame_sink_support.h | 9 ++++++--- 3 files changed, 16 insertions(+), 3 deletions(-) commit fbcb168d3555f7449aa099a3c56feaa68d1aa0c4 Author: Thomas Guilbert <tguilbert@chromium.org> Date: Thu Mar 7 19:30:32 2019 +0000 Cleanup CreateRenderer(HostedRendererType) CreateRenderer(HostedRendererType) was left in after Create*Renderer was added, in order to prevent breaking the internal ChromeCast build. This CL cleans up the leftovers and should be submitted after Chromecast interal code switches to CreateCastRenderer() Bug: 936528 Change-Id: I29ee8104099485ed32a22aec9ccd6cff5cd63771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493082 Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#638692} content/browser/media/media_interface_proxy.cc | 9 --------- content/browser/media/media_interface_proxy.h | 4 ---- content/browser/media/video_decoder_proxy.cc | 5 ----- content/browser/media/video_decoder_proxy.h | 4 ---- content/renderer/media/media_interface_factory.cc | 9 --------- content/renderer/media/media_interface_factory.h | 4 ---- media/mojo/interfaces/interface_factory.mojom | 24 ----------------------- media/mojo/services/interface_factory_impl.cc | 9 --------- media/mojo/services/interface_factory_impl.h | 4 ---- 9 files changed, 72 deletions(-) commit c7400d35b2f0ecfb1989e626bd1bfc334c907873 Author: Ken MacKay <kmackay@chromium.org> Date: Thu Mar 7 19:28:32 2019 +0000 [Chromecast] Add the ability to modify which streams redirection applies to Allow updating the patterns that the redirector matches to mixer streams without removing and re-adding the redirector. Bug: internal b/123626919 Test: cast_audio_backend_unittests Change-Id: I4f79d9d1c1c95ba213bc1396d9d708fd8bb037bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506670 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#638691} .../media/cma/backend/audio_output_redirector.cc | 46 +++++++++++++++- .../media/cma/backend/audio_output_redirector.h | 10 +++- chromecast/media/cma/backend/stream_mixer.cc | 18 ++++++ chromecast/media/cma/backend/stream_mixer.h | 9 +++ .../media/cma/backend/stream_mixer_unittest.cc | 64 +++++++++++++++++++++- chromecast/public/cast_media_shlib.h | 8 +++ chromecast/public/media/redirected_audio_output.h | 2 +- 7 files changed, 152 insertions(+), 5 deletions(-) commit a57f4dbb5f6269529d71d21f08bfc288d6251a94 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 19:28:00 2019 +0000 Fix flakiness in CrosDisplayConfigTest Clear touch screen devices after each test so that touch screen configuration doesn't interfere with the next test's setup. Specifically, having a touch screen device causes the virtual keyboard to be enabled before Shell is done initializing. Bug: 939177 Change-Id: I8e24cc9ab2f425cdc8d9a3b4d11b0a4e1fd6d9f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507250 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638690} .../virtual_keyboard_controller_unittest.cc | 99 ++++++++++------------ ash/test/ash_test_base.cc | 6 ++ 2 files changed, 49 insertions(+), 56 deletions(-) commit 9c429b6cb4877dbd86d13392eca4c29d5f7cc1cd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 19:26:31 2019 +0000 Roll src/third_party/catapult ccc29087522a..699655f07b93 (1 commits) https://chromium.googlesource.com/catapult.git/+log/ccc29087522a..699655f07b93 git log ccc29087522a..699655f07b93 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 benjhayden@chromium.org Fix spa tests. Created with: gclient setdep -r src/third_party/catapult@699655f07b93 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: I9e9fb60c0c27e63225659cb611a6c13a972d4239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508912 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638689} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 563f475d6a7d8fee66daca04337e64a5500c4f20 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Mar 7 19:25:30 2019 +0000 Remove left-over DEFINE_TYPE_CASTS use from css_unsupported_style_value.h This is a follow up of https://crrev.com/c/1496217 TBR=jbroman@chromium.org BUG=891908 Change-Id: Ib3a86b00c39ee0c0cc7081fbd87038d3a03c8cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509192 Reviewed-by: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#638688} .../blink/renderer/core/css/cssom/css_unsupported_style_value.h | 8 -------- 1 file changed, 8 deletions(-) commit e8a2f088a9e4298790537ee45c75d37b4df317e4 Author: John Chen <johnchen@chromium.org> Date: Thu Mar 7 19:25:25 2019 +0000 [ChromeDriver] Remove waterfall related code Clean up code that has become obsolete due to decomission of ChromeDriver waterfall. Change-Id: Ifbdb43872111ec3e575ec6e4aa1b28b76b663756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509095 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#638687} chrome/test/chromedriver/README.txt | 43 ++- chrome/test/chromedriver/archive.py | 152 ----------- chrome/test/chromedriver/run_buildbot_steps.py | 302 --------------------- chrome/test/chromedriver/test/run_all_tests.py | 204 -------------- chrome/test/chromedriver/test/run_java_tests.py | 8 +- .../test/waterfall_builder_config_sample.json | 32 --- .../chromedriver/test/waterfall_builder_monitor.py | 226 --------------- .../chromedriver/third_party/googlecode/LICENSE | 204 -------------- .../third_party/googlecode/README.chromium | 18 -- .../third_party/googlecode/googlecode_upload.py | 240 ---------------- 10 files changed, 22 insertions(+), 1407 deletions(-) commit f1181050339b6f88e89bb4e9d7f1b894878318fd Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 19:24:12 2019 +0000 Check quota for scheduled notifications. This makes sure that we only allow up to 30 scheduled notifications and handles the case when we update an existing notification with a scheduled one. Bug: 891339 Change-Id: Ifb884367d71f9156abf303d8330364f671e3afb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505503 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638686} content/browser/BUILD.gn | 1 + .../notifications/notification_trigger_constants.h | 15 ++++++ .../platform_notification_context_impl.cc | 38 ++++++++++++++ .../platform_notification_context_impl.h | 4 ++ ...atform_notification_context_trigger_unittest.cc | 59 +++++++++++++++++++++- .../platform_notification_service_proxy.cc | 12 +++++ .../platform_notification_service_proxy.h | 3 ++ 7 files changed, 130 insertions(+), 2 deletions(-) commit b77db01adbd9e5ba147e2259c7a9a8fc4bbdd6eb Author: Reid Kleckner <rnk@chromium.org> Date: Thu Mar 7 19:22:45 2019 +0000 Revert "Add tests that lookalike interstitial decisions are shared with incognito." This reverts commit 281e80c30694a97f69f9c4b5f627483376972199. Reason for revert: New test fails in official builds: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/104341 https://ci.chromium.org/p/chrome/builders/ci/ToTWin64/3351 Original change's description: > Add tests that lookalike interstitial decisions are shared with incognito. > > This CL adds tests to verify that a decision to bypass the lookalike > interstitial made in the main profile does not affect incognito and vice > versa. > > Bug: 927924 > Change-Id: I238e2e263db42c1434b9190de007aa775129417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638329} TBR=meacer@chromium.org,jdeblasio@chromium.org Change-Id: I68dbe18b841f4022ae0b533402d1f7fe1fa377b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 927924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509333 Reviewed-by: Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638685} ...ookalike_url_navigation_throttle_browsertest.cc | 58 ++++------------------ 1 file changed, 11 insertions(+), 47 deletions(-) commit ae32c22fbb953cee47fc4edc089cd00d57f4dcf5 Author: Charlie Harrison <csharrison@chromium.org> Date: Thu Mar 7 19:17:01 2019 +0000 Re-land: Fix flatbuffers failures-mode This re-lands this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1503614 Which was reverted here: https://chromium-review.googlesource.com/c/chromium/src/+/1504597 There's one additional change, which is to ensure that windows runtime_libs are available as data_deps. This omission was causing failures on win_chromium_dbg_ng. Bug: 938020 Change-Id: Id0196d86097f938d046c7936e619d1c7cf8174c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506124 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638684} testing/scripts/run_flatbuffers_unittests.py | 7 ++++--- third_party/flatbuffers/BUILD.gn | 4 ++++ 2 files changed, 8 insertions(+), 3 deletions(-) commit 21a23281166534f8cffd11cd36aa159dd9db3dfa Author: Lily Chen <chlily@chromium.org> Date: Thu Mar 7 19:15:43 2019 +0000 Network Error Logging: Evict expired and/or least recently used policies Previously we accumulated NEL policies forever until they were wiped out by a browser restart. This CL introduces a maximum policy limit, beyond which eviction of expired and/or least recently used policies is triggered. A last_used field is added to the policies in order to find the stalest policy to evict. Bug: 930301 Change-Id: Ifebfc64c19a4228e8830f62c52e83bc06790cba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474530 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#638683} .../network_error_logging_service.cc | 93 ++++++++++++++---- .../network_error_logging_service.h | 3 + .../network_error_logging_service_unittest.cc | 109 +++++++++++++++++++++ 3 files changed, 186 insertions(+), 19 deletions(-) commit 69fcf2dc8a532ebf897f32efca3094e8eab9dc02 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Thu Mar 7 19:14:37 2019 +0000 [Autofill] Added utils for creating LabelFormatters. Making a new branch and CL to resolve issues with git and try jobs. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1498614 The utils for making various LabelFormatters sometimes favor std::set over std::vector so that poorly formed forms, e.g. forms with duplicate fields, do not interfere with processing later on. Sets allow us to safely assume that there is just one of a particular ServerFieldType or FieldTypeGroup. It is worth noting that ContactFormLabelFormatters store their FieldTypeGroups while AddressFormLabelFormatters do not. This is because address forms are guaranteed to have ADDRESS_HOME and NAME; however, contact forms could have NAME and PHONE_HOME, EMAIL, or both PHONE_HOME and EMAIL. It is useful for a ContactFormLabelFormatter to know which subset of FieldTypeGroups correspond to its fields. Change-Id: I6164081759848b263c3d9dd5cfcda190388a3d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506116 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#638682} components/autofill/core/browser/BUILD.gn | 1 + .../core/browser/address_form_label_formatter.cc | 10 +-- .../core/browser/address_form_label_formatter.h | 28 ++----- .../core/browser/contact_form_label_formatter.cc | 16 ++-- .../core/browser/contact_form_label_formatter.h | 37 +++++---- .../autofill/core/browser/label_formatter.cc | 17 +++++ components/autofill/core/browser/label_formatter.h | 26 ++++++- .../autofill/core/browser/label_formatter_utils.cc | 88 +++++++++++++++------- .../autofill/core/browser/label_formatter_utils.h | 28 ++++--- .../core/browser/label_formatter_utils_unittest.cc | 36 +++++++-- 10 files changed, 189 insertions(+), 98 deletions(-) commit dfa8971f3f7bb9b3dfb37d61e2d97f66c6586c33 Author: Majid Valipour <majidvp@chromium.org> Date: Thu Mar 7 19:14:21 2019 +0000 [cc] Add majidvp@ as reviewer for scroll snap I can review changes for anything scroll snap related. 🧐 Change-Id: Ia6c794e6bc6b91588cfe7fb8c133c253e2a04c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497388 Reviewed-by: enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638681} cc/OWNERS | 3 +++ 1 file changed, 3 insertions(+) commit 0b9d7cdc0d8cc410444580a93acc3911e9eaf5b6 Author: Nicolás Peña Moreno <npm@chromium.org> Date: Thu Mar 7 19:13:01 2019 +0000 Add a test that quantizes MemoryInfo's largest bucket Bug: 939100 Change-Id: Ia8b7bd430ece375a14569d86482b38c9ad461fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506877 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638680} third_party/blink/renderer/core/timing/memory_info_test.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 7943dd68255962d9daa990554af6e9faeca059bc Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Mar 7 19:12:42 2019 +0000 Add main thread enforcing DCHECK in Dispatcher's messaging IPC handler. Dispatcher is expected to receive messaging IPCs for main thread and not worker threads. Add the check to Dispatcher::OnDeliverMesage, similar to what existed for other messages, e.g. Dispatcher::OnDispatchOnDisconnect. Bug: None Test: No visible changes expected. Change-Id: I0c11b302b9d9610b1f8792ebf2a385e0aec9fb77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508601 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638679} extensions/renderer/dispatcher.cc | 1 + 1 file changed, 1 insertion(+) commit 4d66a60c4794853be09fc946be68ff6cb184de0c Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Thu Mar 7 19:11:42 2019 +0000 MessageService: Remove an unused param to SWTQ::AddPendingTask's callback. The render process id param became obolete and unused at some point, remove it. Bug: None Test: No expected change, internal cleanup only. Change-Id: I422242473c0118692e010909c8380971f01812cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508600 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638678} extensions/browser/api/messaging/message_service.cc | 8 +++----- extensions/browser/api/messaging/message_service.h | 1 - 2 files changed, 3 insertions(+), 6 deletions(-) commit 0434709da39ec1ef5fa384eb867d7c7c3edef4de Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 7 19:11:32 2019 +0000 Suppress external/wpt/html/browsers/windows/embedded-opener-remove-frame.html BUG=939406 TBR=robertma@chromium.org Change-Id: I49024a8fad4b64cce2bf31d963b1ba1d80b32670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508581 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638677} third_party/blink/web_tests/TestExpectations | 2 ++ 1 file changed, 2 insertions(+) commit ec8c36d43efa39b35bd6beb4698460c85f01481f Author: Scott Violet <sky@chromium.org> Date: Thu Mar 7 19:08:28 2019 +0000 aura: cleanup function/member name in WindowTreeHostMus Renames in_set_bounds_from_server to is_server_setting_bounds, which is hopefully a bit easier to understand. BUG=none TEST=none Change-Id: Ic972be85123dc234fa98baee4d2d602bbcc84a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507324 Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638676} ui/aura/mus/window_tree_host_mus.cc | 4 ++-- ui/aura/mus/window_tree_host_mus.h | 4 ++-- ui/views/mus/desktop_window_tree_host_mus.cc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) commit 6bec17316ceb8b572a44c5f2f264a80a220b8a95 Author: Greg Kerr <kerrnel@chromium.org> Date: Thu Mar 7 19:04:07 2019 +0000 macOS V2 Sandbox: Expand the V2 GPU sandbox. This adds additional resource access to the V2 GPU sandbox to address crashes. Bug: 915934 Change-Id: Icf346f03e32523549e5cb9c0806dce1a51794da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506390 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#638675} services/service_manager/sandbox/mac/common.sb | 16 ++++++++++++---- services/service_manager/sandbox/mac/gpu_v2.sb | 22 +++++++++++++++++++++- 2 files changed, 33 insertions(+), 5 deletions(-) commit e6d380281bd6b1c595f47f901e0214bb1eb1e00f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 19:04:03 2019 +0000 Roll src/third_party/swiftshader 45faa0849352..ec255730a818 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/45faa0849352..ec255730a818 git log 45faa0849352..ec255730a818 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Reactor: Add address-of operator on reference types. Created with: gclient setdep -r src/third_party/swiftshader@ec255730a818 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126330097 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I1304317d6ebd954f85b3fccede912dffe6539326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508833 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638674} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0e4cf6d8bdb3e763819976265f61c8f09a9ff852 Author: Bruno Santos <brunoad@chromium.org> Date: Thu Mar 7 18:59:35 2019 +0000 Bump expiration milestone for Arc.Supervision.Transition.Result histogram. Bug: 930922 Change-Id: I86eaed2c769f16ac21bcb7d4ee1f96dd01243f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506876 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638673} tools/metrics/histograms/histograms.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit d68cf0eb89f8848d6ddfee17a0051d5741615661 Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Mar 7 18:57:30 2019 +0000 PWAs: Don't re-parent shortcuts that aren't open-in-window Bug: 938256 Change-Id: I622f1ab4c489fbedb3a72fabbb1e61705d5ae255 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507121 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638672} chrome/browser/extensions/bookmark_app_extension_util.cc | 13 ++++++++++++- chrome/browser/extensions/bookmark_app_extension_util.h | 4 +++- chrome/browser/extensions/bookmark_app_helper.cc | 6 ++++-- .../browser/web_applications/components/install_finalizer.h | 3 ++- .../extensions/bookmark_app_install_finalizer.cc | 6 ++++-- .../extensions/bookmark_app_install_finalizer.h | 3 ++- .../browser/web_applications/test/test_install_finalizer.cc | 3 ++- .../browser/web_applications/test/test_install_finalizer.h | 3 ++- .../browser/web_applications/web_app_install_finalizer.cc | 3 ++- chrome/browser/web_applications/web_app_install_finalizer.h | 3 ++- chrome/browser/web_applications/web_app_install_manager.cc | 2 +- 11 files changed, 36 insertions(+), 13 deletions(-) commit 8060b03097c3d78a4a1932d3a0cc874e9594d6cd Author: Livvie Lin <livvielin@chromium.org> Date: Thu Mar 7 18:56:29 2019 +0000 Change name of IDS_EDITED_NONSECURE_SUMMARY Since the override summary is used in some cases even when a form was not edited, i.e. kMarkHttpAsParameterDangerous, a different name would be more descriptive. Also add checks in the browser test that this summary is present. Change-Id: I294c68b0e57d2a87b501960185b7c91b2a3e0ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507319 Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638671} chrome/browser/ssl/security_state_tab_helper_browsertest.cc | 8 ++++++++ components/security_state/content/content_utils.cc | 2 +- components/security_state_strings.grdp | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) commit 04bc471aa6ab987851eeeeef49f38e0d16072283 Author: Sky Malice <skym@chromium.org> Date: Thu Mar 7 18:56:19 2019 +0000 [Feed] Add metrics impl for request events. Bug: 924739 Change-Id: I40f649645349d7671b76bd9f480ff4207b89c430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487709 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638670} .../chrome/browser/feed/FeedLoggingBridge.java | 28 +++++-- chrome/browser/android/feed/feed_logging_bridge.cc | 48 ++++++++++++ chrome/browser/android/feed/feed_logging_bridge.h | 29 +++++++ components/feed/core/feed_logging_metrics.cc | 68 ++++++++++++++++ components/feed/core/feed_logging_metrics.h | 12 +++ tools/metrics/histograms/enums.xml | 30 +++++++ tools/metrics/histograms/histograms.xml | 91 +++++++++++++++++++++- 7 files changed, 299 insertions(+), 7 deletions(-) commit b212a18e617f22d67d0366eee74f3d992887b466 Author: bsheedy <bsheedy@chromium.org> Date: Thu Mar 7 18:55:08 2019 +0000 Fix VR Iframe JS Threading Fixes JavaScript run in iframes during VR instrumentation tests not being run on the UI thread, which was hitting a recently added DCHECK. TBR=billorr@chromium.org Bug: 939410 Change-Id: I5d3eba0e8075306cff0182c7d10c4c81204afc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508582 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638669} .../src/org/chromium/chrome/browser/vr/XrTestFramework.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit c41b2aac023c4cd3bfb6c97ba56dddb9f9583fc0 Author: Jarryd <jarrydg@chromium.org> Date: Thu Mar 7 18:54:20 2019 +0000 Quota: Obsolete expired origin count histograms. This change will remove UMA logging and related logic for expired origin count metrics that live in QuotaManager. Change-Id: I117d93b23a140e6e59aac0fe3f2adef3cd078f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506562 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638668} storage/browser/quota/quota_manager.cc | 52 --------------------------------- tools/metrics/histograms/histograms.xml | 36 +++++++++++++++-------- 2 files changed, 24 insertions(+), 64 deletions(-) commit f9dd030c419ed2c40e776ccbd45070e5a92e2c75 Author: Min Qin <qinmin@chromium.org> Date: Thu Mar 7 18:54:00 2019 +0000 Dump crash stack when renderer hangs on Android Android currently doesn't report crash stack when renderer hangs. This CL will ask the renderer process to dump the stack to crash report page, without crashing it. Maybe i can do this for OOP network process alone for the crbug, but I think in general, we should have the stack for non-responding renderers. BUG=934317 Change-Id: I5d039c3c6d026e4b608a4f39da4b71933b19c566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498415 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638667} base/android/child_process_service.cc | 5 +++++ .../base/process_launcher/ChildProcessConnection.java | 13 +++++++++++++ .../base/process_launcher/ChildProcessService.java | 18 ++++++++++++++++++ .../base/process_launcher/IChildProcessService.aidl | 3 +++ .../android/tab_web_contents_delegate_android.cc | 10 ++++++++-- content/browser/child_process_launcher.cc | 9 +++++++++ content/browser/child_process_launcher.h | 4 ++++ content/browser/child_process_launcher_helper.h | 3 +++ .../browser/child_process_launcher_helper_android.cc | 8 ++++++++ .../browser/renderer_host/render_process_host_impl.cc | 5 +++++ .../browser/renderer_host/render_process_host_impl.h | 1 + .../browser/ChildProcessLauncherHelperImpl.java | 14 ++++++++++++++ content/public/browser/render_process_host.h | 3 +++ content/public/test/mock_render_process_host.cc | 2 ++ content/public/test/mock_render_process_host.h | 1 + 15 files changed, 97 insertions(+), 2 deletions(-) commit 57bab70618898fc2e8b87abe2ee5dacdfccad632 Author: bsheedy <bsheedy@chromium.org> Date: Thu Mar 7 18:52:08 2019 +0000 Make VR navigation test cover more Makes VrBrowserNavigationTest#testNavigationButtons cover more of the manual test requirements. Specifically, ensures that the buttons are properly greyed out when they're disabled and that clicking on the back button can't cause the browser to go to a different tab. Bug: 887510 Change-Id: Ie4a09c2286d58f6a7a9d0539995bc226132213a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497471 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638666} .../chrome/browser/vr/VrBrowserNavigationTest.java | 66 +++++++++++++++++++--- ...ation_buttons_back_enabled.Pixel_XL-25.png.sha1 | 1 + ...ation_buttons_back_enabled.Pixel_XL-26.png.sha1 | 1 + ...tion_buttons_both_disabled.Pixel_XL-25.png.sha1 | 1 + ...tion_buttons_both_disabled.Pixel_XL-26.png.sha1 | 1 + ...on_buttons_forward_enabled.Pixel_XL-25.png.sha1 | 1 + ...on_buttons_forward_enabled.Pixel_XL-26.png.sha1 | 1 + 7 files changed, 63 insertions(+), 9 deletions(-) commit 25864ef8492da5345b825b4d38d3e7f45d579486 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 7 18:51:19 2019 +0000 Revert "Create golden file loader for the time limit consistency tests." This reverts commit 33fbc186b508a8018a196abeec1dc60eff9dd2a6. Reason for revert: Suspected in a bunch of proto crashes here: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11240 Original change's description: > Create golden file loader for the time limit consistency tests. > > Bug: 935711 > Change-Id: Id4f5c77ab7e8d783507b2bdb0000ce5fcb2b417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487473 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: G. Silva <gfaus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638569} TBR=pkasting@chromium.org,michaelpg@chromium.org,hgrandinetti@chromium.org,gfaus@chromium.org Change-Id: If5471f6687bac6a7fcbaa62f6e67bf4abb93b5ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508583 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638665} chrome/browser/chromeos/BUILD.gn | 34 ------- .../consistency_golden_loader.cc | 71 -------------- .../consistency_golden_loader.h | 41 -------- .../consistency_golden_loader_unittest.cc | 47 --------- .../goldens/consistency_golden.proto | 108 --------------------- .../time_limit_consistency_test/proto_matcher.h | 43 -------- .../test_goldens/test_golden.textproto | 6 -- .../test_goldens/test_golden_unsupported.textproto | 6 -- third_party/protobuf/BUILD.gn | 4 - 9 files changed, 360 deletions(-) commit ab972f74fa41db59c916081e333ea8f3866ca3c2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:48:45 2019 +0000 Roll src/third_party/depot_tools ffb1ffb82284..db5c5ade84ad (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ffb1ffb82284..db5c5ade84ad git log ffb1ffb82284..db5c5ade84ad --date=short --no-merges --format='%ad %ae %s' 2019-03-07 ehmaldonado@chromium.org gclient: Fetch refs/{branch-heads,tags}/* if needed. Created with: gclient setdep -r src/third_party/depot_tools@db5c5ade84ad The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938160 TBR=agable@chromium.org Change-Id: Icbdd5562aeb5408f3e67d0f9bcc0a221b4b12131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508835 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638664} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8e8e3ee3726b4471b9d8aa2be0eeeb9527741c00 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Thu Mar 7 18:46:21 2019 +0000 Updating trunk VERSION from 3728.0 to 3729.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I7eb7a82223577ece936bed46e2c515377ff05a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509233 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638663} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 980663c9167022c6f5738f9a41571ddee57e5783 Author: Daniel Bratell <bratell@opera.com> Date: Thu Mar 7 18:46:15 2019 +0000 Remove some variable shadowing in blink/core In an effort to reduce or even ban variable shadowing, this renames some variables. I'm interested in prohibiting shadowing because I think it might prevent potential jumbo problems. The exact warnings this prevents is: third_party/blink/renderer/core/fileapi/file_reader_loader.cc:358:16: error: declaration shadows a local variable [-Werror,-Wshadow] MojoResult result = consumer_handle_->BeginReadData( ^ third_party/blink/renderer/core/fileapi/file_reader_loader.cc:346:54: note: previous declaration is here void FileReaderLoader::OnDataPipeReadable(MojoResult result) { ^ third_party/blink/renderer/core/aom/accessible_node.cc:288:16: error: declaration shadows a local variable [-Werror,-Wshadow] Element* element = accessible_node->element(); ^ third_party/blink/renderer/core/aom/accessible_node.cc:278:43: note: previous declaration is here bool AccessibleNode::GetProperty(Element* element, ^ third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:43:16: error: declaration shadows a local variable [-Werror,-Wshadow] for (Node& node : FlatTreeTraversal::AncestorsOf(node)) { ^ third_party/blink/renderer/core/invisible_dom/invisible_dom.cc:40:14: note: previous declaration is here for (Node& node : range.Nodes()) { ^ third_party/blink/renderer/core/loader/frame_loader.cc:892:10: error: declaration shadows a local variable [-Werror,-Wshadow] auto request = mojo::MakeRequest(&navigation_initiator); ^ third_party/blink/renderer/core/loader/frame_loader.cc:798:20: note: previous declaration is here FrameLoadRequest request(passed_request); ^ third_party/blink/renderer/core/script/modulator.cc:52:20: error: declaration shadows a local variable [-Werror,-Wshadow] } else if (auto* scope = DynamicTo<WorkerGlobalScope>(execution_context)) { ^ third_party/blink/renderer/core/script/modulator.cc:45:20: note: previous declaration is here } else if (auto* scope = DynamicTo<WorkletGlobalScope>(execution_context)) { ^ Bug: 923510 Change-Id: I82659c403eb15b4f676d24b97414bfbbced9d701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508517 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#638662} third_party/blink/renderer/core/aom/accessible_node.cc | 5 ++--- .../blink/renderer/core/fileapi/file_reader_loader.cc | 13 +++++++------ .../blink/renderer/core/invisible_dom/invisible_dom.cc | 6 +++--- third_party/blink/renderer/core/loader/frame_loader.cc | 4 ++-- third_party/blink/renderer/core/script/modulator.cc | 10 ++++++---- 5 files changed, 20 insertions(+), 18 deletions(-) commit d8cc4739db01e629d525b681ec3ab1f08dcb139f Author: Leonard Grey <lgrey@chromium.org> Date: Thu Mar 7 18:43:45 2019 +0000 Mac: update first run dialogue for dark mode Bug: 939251 Change-Id: Ifbb8384ce97adaf68a32264aa575883886114e7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508573 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638661} chrome/browser/ui/cocoa/first_run_dialog_controller.mm | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit e63169edf1976e54997cb913f6e668613047cdd6 Author: Eric Stevenson <estevenson@chromium.org> Date: Thu Mar 7 18:43:36 2019 +0000 Android: Update manifest expectations instructions. The monochrome_public_apk__merge_manifests produced the expectations file and takes a fraction of the time to build. Also added a note about making sure your branch is updated. Change-Id: I3abea3a082ec348c79e92c60c43515829e5dc320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509014 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638660} chrome/android/java/README.md | 30 ++++++++++++++++++++++-------- 1 file changed, 22 insertions(+), 8 deletions(-) commit b2fe4f8558dd9b6e6cd6e4e21609097e43c64b16 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Mar 7 18:42:37 2019 +0000 GWP-ASan: Rename metadata member variables The slots_ member was always misnamed, as it is really an array of metadata _about_ slots, not the slots (pages) themselves. The slot_metadata member variable would be clearer as 'metadata_addr' to denote that it's an address. These renames are in anticipation of an upcoming change that will make slots/metadata more distinct (no 1:1 mapping.) Bug: 939142 Change-Id: I58e5f8035ea571fe7c0b0a4fb6bb0114580984e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507217 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#638659} .../gwp_asan/client/guarded_page_allocator.cc | 47 +++++++++++----------- .../gwp_asan/client/guarded_page_allocator.h | 2 +- components/gwp_asan/common/allocator_state.cc | 4 +- components/gwp_asan/common/allocator_state.h | 2 +- .../gwp_asan/common/allocator_state_unittest.cc | 2 +- 5 files changed, 29 insertions(+), 28 deletions(-) commit 7a61389f70a94479f5ec23266b5941737956f347 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:42:24 2019 +0000 Roll src/third_party/chromite a6918d7b72a9..2f722bfc7ccb (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/a6918d7b72a9..2f722bfc7ccb git log a6918d7b72a9..2f722bfc7ccb --date=short --no-merges --format='%ad %ae %s' 2019-03-07 pprabhu@chromium.org config: Migrate 4 paladins to Skylab Created with: gclient setdep -r src/third_party/chromite@2f722bfc7ccb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0ad5dd0c03e23a65889a32e5b056ed6a73f950a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509032 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638658} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd13225a70402e548c5feacde91f0acbfd7f927f Author: Yann Dago <ydago@chromium.org> Date: Thu Mar 7 18:39:05 2019 +0000 Management WebUI: Put link to chrome://management behind a feature flag When clicking on the 'Managed by your organization' message in the settings page and menu, open chrome://management if the "link-management-page" flag is set to true. Bug: 938991 Change-Id: If2f14a3818a00fc4dd82c46d704d0452415c6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506497 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#638657} chrome/browser/about_flags.cc | 6 ++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ chrome/browser/ui/browser_command_controller.cc | 12 +++++++++--- chrome/browser/ui/webui/managed_ui_handler.cc | 11 ++++++++++- chrome/common/chrome_features.cc | 4 ++++ chrome/common/chrome_features.h | 2 ++ chrome/common/url_constants.cc | 3 +-- tools/metrics/histograms/enums.xml | 4 ++++ 10 files changed, 50 insertions(+), 6 deletions(-) commit bf7381e79453b20111c2295974845f1c45cb5502 Author: David Roger <droger@chromium.org> Date: Thu Mar 7 18:39:00 2019 +0000 [signin][Mice] Do not call FireRefreshTokensLoaded too early This was causing a crash on startup if an account was removed from the device while Chrome was not running. Bug: 936953 Change-Id: I45662ace9c498b6db8b719251e8f7f461dc5531f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505447 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#638656} .../signin/core/browser/oauth2_token_service_delegate_android.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit b669b5c78eba7789727dc34b8fe108f02dfcd775 Author: Patrick Noland <pnoland@chromium.org> Date: Thu Mar 7 18:37:57 2019 +0000 [Chromeshine] Add example for fqdn in translation Bug: 939015 Change-Id: If4fbd01fd671b67114dc9f37055f845c4fdc2a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506654 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Auto-Submit: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#638655} chrome/android/java/strings/android_chrome_strings.grd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 576056afa6ce369d4c9eeb3e4276f458eb60aade Author: Michael Crouse <mcrouse@chromium.org> Date: Thu Mar 7 18:37:50 2019 +0000 Adding feature flag for enabling OnePlatform API hints and created a Top Site Provider for querying SiteEngagementService Implemented a feature flag controlled by IsOnePlatformHintsEnabled() for enabling OnePlatform API and requests. Implemented the Top Site Provider inference and implementation for querying the Site Engagement Service to provide the list of top hosts for the OnePlatform to perform the Hints Request to the Cacao server. Updated the unittests for Previews Optimization Guide and Previews Decider Impl to include the TopSiteProvider being passed. Wrote a PreviewsOnePlatformHintBrowserTest for confirming the feature flag and code path is executed safely. Bug: 932707 Change-Id: I2d1a048a86e8c8b33c98c07312cc77bafa9b52dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478362 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#638654} chrome/browser/BUILD.gn | 2 + .../previews_oneplatform_hints_browsertest.cc | 173 +++++++++++++++++++++ chrome/browser/previews/previews_service.cc | 8 +- chrome/browser/previews/previews_service.h | 8 + .../previews/previews_top_host_provider_impl.cc | 50 ++++++ .../previews/previews_top_host_provider_impl.h | 43 +++++ chrome/test/BUILD.gn | 1 + components/optimization_guide/proto/hints.proto | 97 ++++++++++++ components/previews/content/BUILD.gn | 1 + .../content/previews_decider_impl_unittest.cc | 21 ++- .../content/previews_optimization_guide.cc | 42 ++++- .../previews/content/previews_optimization_guide.h | 18 ++- .../previews_optimization_guide_unittest.cc | 17 +- .../previews/content/previews_top_host_provider.h | 27 ++++ components/previews/core/previews_experiments.cc | 9 ++ components/previews/core/previews_experiments.h | 8 + components/previews/core/previews_features.cc | 4 + components/previews/core/previews_features.h | 1 + 18 files changed, 521 insertions(+), 9 deletions(-) commit 1198ba3a7f962d567ba108f7f2449e6a5e1e98a1 Author: Tim Volodine <timvolodine@chromium.org> Date: Thu Mar 7 18:35:48 2019 +0000 [AW NS] Add flaky tests to the instrumentation test filter Add some flaky tests that are failing on android_mojo and android_mojo_rel bots. Because we use android_mojo bot for CQ these tests currently block patches that are trying to land. BUG=936757,939355,841556 Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: I21052efd28af0f8b693e53df59705db15496e6e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508461 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Auto-Submit: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#638653} .../mojo.fyi.network_webview_instrumentation_test_apk.filter | 8 ++++++++ 1 file changed, 8 insertions(+) commit 41719f18ac92526bae07771456c1c74c116cc3ee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:26:05 2019 +0000 Roll Fuchsia SDK from bccf58830632 to 9216f29f7750 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I29bba4682051ec93ff2bb75547a3e7de213f25c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508913 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638652} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 02c51f44994e18c048cdc36e2af49f519392995e Author: Aran Gilman <gilmanmh@google.com> Date: Thu Mar 7 18:22:22 2019 +0000 Re-enable WebpageAccessibility test and update role expectation. The test was originally disabled due to https://crbug.com/101984. The flakiness occurred for Vista builds only, and the bug has not had a significant update since 2012. Bug: 101984 Change-Id: Ifadf55ae2d867e816db2795c9a7eaed0377cc276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497128 Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#638651} .../accessibility/cross_platform_accessibility_browsertest.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 2c77ed71f62e4a8a322476fc7a305699fe174fb1 Author: David Benjamin <davidben@chromium.org> Date: Thu Mar 7 18:21:11 2019 +0000 Fix typo in URL. The go/ link doesn't have an 's' at the end. Change-Id: Iae22758ebcc448ac8b86c02c735ba9f5a4ca5719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506761 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#638650} components/component_updater/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 065117e4e6b9e04bc7ad7ba4f66f3d1b3d8ef2f4 Author: Nicolás Peña Moreno <npm@chromium.org> Date: Thu Mar 7 18:13:58 2019 +0000 [ElementTiming] Add a test to prevent leak in ImageElementTiming Currently we need to notify ImageElementTiming whenever an element will be destroyed, so that it can be removed from the HashSet of images that have been seen by ImageElementTiming. This CL adds unittests for this behavior. Bug: 879270 Change-Id: I7719b9c2bfc594cbf4070b1fe66c9e5325a3a552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506660 Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#638649} .../renderer/core/paint/image_element_timing.h | 2 +- .../core/paint/image_element_timing_test.cc | 53 ++++++++++++++++++++-- 2 files changed, 50 insertions(+), 5 deletions(-) commit 5277ec60c16878618c81d7b1e2356315abc5ae35 Author: Katie D <katie@chromium.org> Date: Thu Mar 7 18:12:27 2019 +0000 Re-enable autoclick tests since ScopedTaskEnvironment bug is fixed. ScopedTaskEnvironment::NextScheduledRunTime was returning Now() (aka now_ticks_) because sequence_manager is idle, but then ScopedTaskEnvironment::MaybeFastForwardToNextTask DCHECKS that now_ticks_ is strictly < run_time, which was causing test failures. Now that ScopedTaskEnviornment is fixed we can re-enable these tests. Bug: 935651 Change-Id: I5a0cb2967001995a54f2245bac4e5f9022514001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500018 Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#638648} ash/autoclick/autoclick_unittest.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 3331cac220174c33c86d631329c4b9bf98c72548 Author: Bo Liu <boliu@chromium.org> Date: Thu Mar 7 18:08:48 2019 +0000 aw: Stop relying on is_layer We use View.getGlobalVisibleRect, and the transform and viewport from functor to compute info for the viewport: * the tile memory budget, which ideally is computed from the size of the visible portion of webview * the viewport and transform used to raster the right tiles at the right scale We usually use getGlobalVisibleRect and transform from functor together if is_layer is false, making the assumption that they both transform between the window space and view space. This turns out not to be true. Instead, use getGlobalVisibleRect to compute the tile budget. And always use the viewport and transform from functor together for tile raster, since they are guaranteed to work together. Change-Id: I4d1346501dab14dbb7b7ca160e0c88fee64aa3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506759 Auto-Submit: Bo <boliu@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638647} .../browser/gfx/browser_view_renderer.cc | 37 ++++++++-------------- .../browser/gfx/browser_view_renderer.h | 1 - .../browser/gfx/browser_view_renderer_unittest.cc | 13 +++----- android_webview/browser/gfx/child_frame.cc | 11 +++---- android_webview/browser/gfx/child_frame.h | 9 +++--- android_webview/browser/gfx/hardware_renderer.cc | 3 +- .../gfx/parent_compositor_draw_constraints.cc | 28 ++++------------ .../gfx/parent_compositor_draw_constraints.h | 9 +++--- 8 files changed, 39 insertions(+), 72 deletions(-) commit bd863dd33b16fa4ca6cb6f641f97c96cf6dda0c8 Author: Robert Ogden <robertogden@chromium.org> Date: Thu Mar 7 18:07:48 2019 +0000 Add UMA for HTTP Request Timing on DataReductionProxy's Client Config This CL adds TCP and HTTP timing UMA on every successful request to the client config service. This UMA will be used server side to compare with other metrics for evaluating network quality. Bug: 939121 Change-Id: I84d7867d03f16a57e4131e0043fbc922d50ff187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506442 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#638646} .../data_reduction_proxy_config_service_client.cc | 17 +++++++++++++++++ ...eduction_proxy_config_service_client_unittest.cc | 6 ++++++ tools/metrics/histograms/histograms.xml | 21 +++++++++++++++++++++ 3 files changed, 44 insertions(+) commit 1523294d57d8de58bce10163a6fee075b3dd56a5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 18:07:44 2019 +0000 Roll src/third_party/perfetto 2d4d2a3cf7b9..356474278798 (2 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/2d4d2a3cf7b9..356474278798 git log 2d4d2a3cf7b9..356474278798 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 fmayer@google.com Improve error message if perfetto invocation fails. 2019-03-07 fmayer@google.com Read from socket to prevent clear notification to service. Created with: gclient setdep -r src/third_party/perfetto@356474278798 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I496e166cba1724b1d47675e842f891db54d5cb71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508914 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638645} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 09c211aefb1f8ef9c9cae7ba878ec9076b76aa91 Author: Emircan Uysaler <emircan@chromium.org> Date: Thu Mar 7 18:01:03 2019 +0000 Reset VDA for HDR Color space changes VDA implementations require config.container_color_space and config.target_color_space information to be set to provide correct output. For WebRTC frames that carry this information for VP9.2, we can reinitialize VDA with this info for the correct colors. Bug: 939387 Change-Id: Ib2ef4c7fdfbeef5e6f25a887e32a5c9c4c2e170e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476065 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#638644} .../browser_gpu_video_accelerator_factories.cc | 3 +- .../browser_gpu_video_accelerator_factories.h | 3 +- .../gpu/gpu_video_accelerator_factories_impl.cc | 7 +- .../gpu/gpu_video_accelerator_factories_impl.h | 3 +- .../media/webrtc/rtc_video_decoder_adapter.cc | 106 ++++++++++++++++--- .../media/webrtc/rtc_video_decoder_adapter.h | 11 +- .../webrtc/rtc_video_decoder_adapter_unittest.cc | 116 +++++++++++++++++++-- media/base/video_decoder_config.cc | 5 + media/base/video_decoder_config.h | 1 + media/gpu/ipc/service/vda_video_decoder.cc | 8 +- media/video/gpu_video_accelerator_factories.h | 3 +- media/video/mock_gpu_video_accelerator_factories.h | 8 +- 12 files changed, 234 insertions(+), 40 deletions(-) commit df8868a0295530d0bf8b5ff0bbcbd0b6f83adf39 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Thu Mar 7 17:53:53 2019 +0000 Disable SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost. SecurityExploitBrowserTest.AttemptDuplicateRenderWidgetHost is flaky on all platorms. TBR=boliu@chromium.org Bug: 939338 Change-Id: I21f13d8651b52647f61a0bb8f92d943ff96e7def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508894 Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#638643} content/browser/security_exploit_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit c5594892572821d8e2fee571b7d4687f5bf39a27 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 17:53:11 2019 +0000 flags: assign enable-notification-indicator Bug: 859172 Change-Id: I94d6400a9b0ef983ace670c3adfad68b71c75819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506752 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638642} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 1948770352245fbc218850de8c49813bd575ad3d Author: Shivani Sharma <shivanisha@chromium.org> Date: Thu Mar 7 17:52:47 2019 +0000 History intervention: Reset skippable bit if user gesture after pushState If a navigation entry was marked as skippable because it added an entry using pushState, then a user gesture on the page should reset the skippable bit. If the pushState was done after the user gesture, then the entry would not have been marked as skippable to begin with. This change will make the behavior independent of the ordering between user gesture and pushState. content_browsertests --gtest_filter= NavigationControllerHistoryInterventionBrowserTest. OnUserGestureResetSameDocumentEntriesSkipFlag content_browsertests --gtest_filter= NavigationControllerHistoryInterventionBrowserTest. OnUserGestureDoNotResetDifferentDocumentEntrySkipFlag Test: Bug: 937423 Change-Id: Ie1e55815163ca84950ed7e04fbfa55c06f86c2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499834 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638641} content/browser/frame_host/frame_tree_node.cc | 4 + .../frame_host/navigation_controller_impl.cc | 55 +++++++ .../frame_host/navigation_controller_impl.h | 4 + .../navigation_controller_impl_browsertest.cc | 160 +++++++++++++++++++++ 4 files changed, 223 insertions(+) commit 8106c5b068a2d6bdbf4c0dc689891b98ceaa04ae Author: Dan Harrington <harringtond@chromium.org> Date: Thu Mar 7 17:51:49 2019 +0000 Add original_url to DeletedPageInfo This adds the original_url to the information returned when a page is removed from the offline page model. See bug for motivation. Bug: 884291 Change-Id: I25d11e58347379e06c4a0de8a1cb5b1830cdf279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473830 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#638640} .../offline_pages/offline_page_request_handler.cc | 2 +- .../offline_page_request_handler_unittest.cc | 2 +- .../offline_internals_ui_message_handler.cc | 3 +- components/feed/content/feed_offline_host.cc | 8 +-- .../feed/content/feed_offline_host_unittest.cc | 4 +- .../remote/prefetched_pages_tracker_impl.cc | 8 +-- .../prefetched_pages_tracker_impl_unittest.cc | 11 ++-- .../core/downloads/download_ui_adapter_unittest.cc | 2 +- .../core/downloads/offline_item_conversions.cc | 2 +- .../downloads/offline_item_conversions_unittest.cc | 2 +- .../offline_pages/core/model/add_page_task.cc | 2 +- .../core/model/add_page_task_unittest.cc | 2 +- .../offline_pages/core/model/delete_page_task.cc | 72 +++++++++++++--------- .../core/model/delete_page_task_unittest.cc | 34 ++++++++++ .../offline_pages/core/model/get_pages_task.cc | 6 +- .../core/model/offline_page_item_generator.cc | 2 +- .../core/model/offline_page_model_taskified.cc | 2 +- .../model/offline_page_model_taskified_unittest.cc | 6 +- components/offline_pages/core/offline_page_item.cc | 3 +- components/offline_pages/core/offline_page_item.h | 7 ++- .../core/offline_page_metadata_store_unittest.cc | 10 +-- components/offline_pages/core/offline_page_model.h | 9 +++ .../core/prefetch/prefetch_importer_impl.cc | 2 +- .../prefetch/prefetch_importer_impl_unittest.cc | 3 +- 24 files changed, 130 insertions(+), 74 deletions(-) commit 9f0c9622373be29bfda0dd16c8fb93388e22de29 Author: sangseok.jang <sangseok.jang@navercorp.com> Date: Thu Mar 7 17:51:40 2019 +0000 Clean up ThemeProperties::COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT ThemeProperties::COLOR_BOOKMARK_BAR_INSTRUCTIONS_TEXT is no longer in use, because BookmarkBarInstructionView is removed. However, it still remains, so it is cleaned up. Bug: NONE Change-Id: I7ce14646fafaf07fc426aa96d1b4dab073b51ca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506679 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#638639} chrome/browser/themes/theme_properties.cc | 4 ---- chrome/browser/themes/theme_properties.h | 3 --- chrome/browser/themes/theme_service.cc | 4 ---- chrome/browser/ui/libgtkui/gtk_ui.cc | 2 -- 4 files changed, 13 deletions(-) commit d1f761a675fa245ddfc2f94e398a6a32c773e6b5 Author: Kyle Milka <kmilka@chromium.org> Date: Thu Mar 7 17:50:45 2019 +0000 Revert "[NTP] Initiate server-side resource requests earlier" This reverts commit ed15ce53b6ae967580046cb16af6ad71e01fdca7. Previous change prevented promos and search suggestions from appearing properly. Required manual resolution for merge conflicts. Bug: 770640 Change-Id: I37add613a23567d57912623c02441cdb68d261e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507249 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#638638} chrome/browser/resources/local_ntp/local_ntp.js | 70 +++--- chrome/browser/search/local_ntp_source.cc | 278 +++++++++++------------- chrome/browser/search/local_ntp_source.h | 59 ++--- 3 files changed, 191 insertions(+), 216 deletions(-) commit 30381c3084c3d95ca1b5219f98310cb95cefd5c8 Author: Eugene But <eugenebut@chromium.org> Date: Thu Mar 7 17:49:47 2019 +0000 Fix GetPendingItemIndex() for new navigations. Before this CL, GetPendingItemIndex() used to return last committed item index for the new navigations (none-reload, none-back-forward). Presumably this was done before CRWSessionController implemented pendingItemIndex support, when CRWSessionController immediately changed committed item during back-forward navigations. pendingItemIndex support design doc: https://docs.google.com/document/d/1GvsaoNtMO7d87FzoysOW5GqH6XErI5g2cinKhkPk7bQ/edit This CL returns -1 for new navigations, which matches //content. There are 3 places where GetPendingItemIndex is used outside of ios/web: - IOSLiveTab::GetPendingEntryIndex (new implementation matches content, which is the right approach) - GetPossiblyPendingItemAtIndex (new implementation should have no effect because index should be in [0;size] bounds, but this is just an assumption and it's actually unclear if GetPossiblyPendingItemAtIndex relied on undocumented and incorrect behavior). - ReadingListWebStateObserver::LoadOfflineReadingListEntry (new implementation should make the whole block of code obsolete, but it should be fine to leave it as it is because ReadingListWebStateObserver is going to be removed soon). Bug: 665189, 899827 Change-Id: I9538b693c924790620140b37d6c4fea6cce26fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504231 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638637} ios/web/navigation/legacy_navigation_manager_impl.mm | 12 ++---------- ios/web/navigation/navigation_manager_impl_unittest.mm | 16 ++++++++++++++-- ios/web/navigation/wk_based_navigation_manager_impl.mm | 12 +++--------- 3 files changed, 19 insertions(+), 21 deletions(-) commit a5c54e0e8b33b6de0cff8d7cc6d5670d0f315de7 Author: Christopher Cameron <ccameron@chromium.org> Date: Thu Mar 7 17:48:28 2019 +0000 Mac OOP-R crashes: glFlush at every glBindFramebuffer in Skia Bug: 906453 Change-Id: Ice07136126ce35d128054276e86ac641aba2c882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507235 Reviewed-by: enne <enne@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#638636} ui/gl/init/create_gr_gl_interface.cc | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) commit 159fbccaeb2b186863ade01df5ad6b9d5144c994 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Thu Mar 7 17:47:01 2019 +0000 Update comments in tab_list_ui/ Bug: None Change-Id: I37c84f9367743b3d2f758eaf9bf0d1094b65aad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507201 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638635} .../browser/tasks/tab_list_ui/TabGridContainerViewBinder.java | 3 +++ .../chrome/browser/tasks/tab_list_ui/TabGridViewHolder.java | 6 +++--- .../tasks/tab_list_ui/TabStripBottomToolbarCoordinator.java | 10 +++++----- .../tasks/tab_list_ui/TabStripBottomToolbarMediator.java | 4 ++-- .../chrome/browser/tasks/tab_list_ui/TabStripViewBinder.java | 2 +- .../chrome/browser/tasks/tab_list_ui/TabStripViewHolder.java | 6 +++--- 6 files changed, 17 insertions(+), 14 deletions(-) commit c1d232108530ae44d3a8f592764c701253a565c9 Author: Anne Lim <annelim@google.com> Date: Thu Mar 7 17:46:08 2019 +0000 [Autofill] Prevent upload save on unsupported cards Gets a new parameter (supported_card_bin_ranges) from the GetDetailsForSaveCardResponse proto, which contains a list of pair of numbers representing ranges of supported card bins. If a card doesn't fall under any of the ranges, the card won't be offered upload save and will be saved locally instead. Change-Id: I17a8742f0d20788131ffb2af29d8a6bcb21c09f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496251 Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#638634} chrome/browser/about_flags.cc | 7 +++ chrome/browser/flag-metadata.json | 5 ++ chrome/browser/flag_descriptions.cc | 6 +++ chrome/browser/flag_descriptions.h | 3 ++ .../autofill/core/browser/autofill_metrics.h | 4 +- .../core/browser/credit_card_save_manager.cc | 42 ++++++++++++++-- .../core/browser/credit_card_save_manager.h | 22 +++++++-- .../browser/credit_card_save_manager_unittest.cc | 57 ++++++++++++++++++++++ .../core/browser/local_card_migration_manager.cc | 3 +- .../core/browser/local_card_migration_manager.h | 4 +- .../core/browser/payments/payments_client.cc | 23 +++++++-- .../core/browser/payments/payments_client.h | 5 +- .../browser/payments/payments_client_unittest.cc | 10 ++-- .../core/browser/payments/test_payments_client.cc | 18 ++++--- .../core/browser/payments/test_payments_client.h | 7 ++- .../browser/test_local_card_migration_manager.cc | 6 ++- .../browser/test_local_card_migration_manager.h | 6 ++- .../autofill/core/common/autofill_features.cc | 4 ++ .../autofill/core/common/autofill_features.h | 1 + tools/metrics/histograms/enums.xml | 4 ++ 20 files changed, 209 insertions(+), 28 deletions(-) commit 9a082d5ad0951998ea43eaeefe28b01e310812e9 Author: Mugdha Lakhani <nator@chromium.org> Date: Thu Mar 7 17:45:16 2019 +0000 [Background Fetch] Update Webview expectations. Bug: 766077 Change-Id: Ie52fc2eea6e96580bb064ac3b9c877a0ef96ff2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508466 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#638633} .../test/data/webexposed/not-webview-exposed.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) commit ce50e1d53ef866f895c86f7d59efe027bc2c1fa8 Author: Matt Menke <mmenke@chromium.org> Date: Thu Mar 7 17:43:47 2019 +0000 Remove group name from ConnectJob layer. ConnectJobs no longer care about group names, so having them store the name is a bit of a layering violation. ConnectJob group names were used for a NetLog event and by the socket pools to locate the group a ConnectJob belonged to. To resolve the first issue, group names are now logged by a NetLog event by the socket pools before starting each ConnectJob (which will require an update in the net log viewer code). To resolve the second issue, Groups are now ConnectJob::Delegates for all the ConnectJobs associated with the group. Beyond fixing the layering violation, this CL serves two purposes: It will make it easier to change group_name from a string to a struct, and it will make it easier to make CommonConnectJobParameters a per-pool object. Bug: 927100, 533571 Change-Id: Ife570e1277ef18b4d916eb6d3ab91a9fccf2bed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506567 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638632} net/http/http_proxy_connect_job_unittest.cc | 4 +- net/log/net_log_event_type_list.h | 10 +- net/socket/client_socket_pool_base.cc | 348 ++++++++++++--------- net/socket/client_socket_pool_base.h | 54 ++-- net/socket/client_socket_pool_base_unittest.cc | 7 +- net/socket/connect_job.cc | 16 +- net/socket/connect_job.h | 9 - net/socket/connect_job_unittest.cc | 1 - net/socket/socks_connect_job_unittest.cc | 2 +- net/socket/ssl_connect_job_unittest.cc | 3 +- net/socket/transport_client_socket_pool.cc | 7 +- net/socket/transport_client_socket_pool.h | 1 - net/socket/transport_connect_job_unittest.cc | 4 +- .../websocket_transport_client_socket_pool.cc | 6 +- net/spdy/spdy_proxy_client_socket_unittest.cc | 2 +- 15 files changed, 250 insertions(+), 224 deletions(-) commit 7e72794c4f13a0d0c987f58715af72f81271b62d Author: Yao Xiao <yaoxia@chromium.org> Date: Thu Mar 7 17:43:01 2019 +0000 Add UseCounter for ad click that results in navigation Record for each window.open(), href link activation, and location=xxx. Those calls should be mutually exclusive. For this metric to be accurate, it has to assume that "the navigation was initiated in a frame with transient gesture" == "the navigation was caused by this gesture", which can be wrong. But it may just work in practice and it seems to be a general assumption we have been making throughout Chrome. Bug: 864147 Change-Id: If7f75bd8d17e1d2ea572607e6f8f4149c78222fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488111 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638631} .../observers/use_counter/ukm_features.cc | 1 + .../page_load_metrics_test_waiter.cc | 5 ++ .../page_load_metrics_test_waiter.h | 3 + .../subresource_filter/ad_tagging_browsertest.cc | 91 ++++++++++++++++++++++ .../public/mojom/web_feature/web_feature.mojom | 1 + .../blink/renderer/core/frame/local_frame.cc | 5 ++ .../blink/renderer/core/frame/local_frame.h | 9 +++ third_party/blink/renderer/core/frame/location.cc | 2 + .../renderer/core/html/html_anchor_element.cc | 2 + .../blink/renderer/core/page/create_window.cc | 1 + tools/metrics/histograms/enums.xml | 1 + 11 files changed, 121 insertions(+) commit f2c92e299042720f90a3464ded962fb2ded40b99 Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Mar 7 17:39:56 2019 +0000 Wrap ARC_PACKAGE in pseudo-USS codepath The sync datatype is the last leftover that hasn't been wrapped in the USS architecture, and could end up in the critical path to future dismantling efforts. The new controller has been simplified by instead introducing the notion of model-readiness in SyncableService, which the USS codepath honors. This makes the new controller a lot simpler, and is aligned with our plans to avoid the notion of model readiness in controllers, and narrow down the scope of DataTypeController::ReadyForStart() to non-transient business logic (i.e. is a datatype allowed to start). Sync integration tests are now parameterized to exercise both codepaths in case the feature toggle must be used in the future as kill switch. Bug: 870624,939329 Change-Id: I9d415eba7bd53f0fd9cf7bbfa00db98b7e916e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507657 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638630} chrome/browser/sync/chrome_sync_client.cc | 13 ++++- .../single_client_arc_package_sync_test.cc | 16 ++++-- .../two_client_arc_package_sync_test.cc | 30 +++++++---- chrome/browser/ui/BUILD.gn | 2 + .../arc/arc_package_sync_model_type_controller.cc | 53 ++++++++++++++++++++ .../arc/arc_package_sync_model_type_controller.h | 46 +++++++++++++++++ .../app_list/arc/arc_package_syncable_service.cc | 16 ++++++ .../ui/app_list/arc/arc_package_syncable_service.h | 3 ++ components/sync/driver/data_type_manager_impl.cc | 58 +++++++++++++--------- components/sync/driver/data_type_manager_impl.h | 5 ++ components/sync/driver/sync_driver_switches.cc | 2 + components/sync/driver/sync_driver_switches.h | 1 + components/sync/model/syncable_service.cc | 6 +++ components/sync/model/syncable_service.h | 6 +++ .../model_impl/syncable_service_based_bridge.cc | 16 ++++-- .../model_impl/syncable_service_based_bridge.h | 1 + .../syncable_service_based_bridge_unittest.cc | 47 ++++++++++++++++-- 17 files changed, 274 insertions(+), 47 deletions(-) commit 60b52be58823da433a0ab17f9365054d32f7b7cc Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Mar 7 17:37:59 2019 +0000 [Media Engagement] Add checks in UpdateScoreDict UpdateScoreDict is causing a crash when we are getting keys and this could be caused by old data that does not have all the keys. This hardens the checks when loading the data. BUG=934165 Change-Id: I35eafc9b2a232ff8cc79fd48b48de9cc09cfc65d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508596 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#638629} chrome/browser/media/media_engagement_score.cc | 90 +++++++++++++++++--------- 1 file changed, 60 insertions(+), 30 deletions(-) commit 1ba12aeea5abfa5ae1cf87b91ff29b04229cf795 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 17:33:42 2019 +0000 Schedule a timer to show notifications with a trigger. This is the platform independent version of the notification trigger which simply starts a timer. This requires Chrome to be running at the time the notification should be displayed. If Chrome is not running, the notification will be shown at the next startup. A follow-up CL will override this behaviour for Android and use the BackgroundTaskScheduler to wake up Chrome. Bug: 891339 Change-Id: I679df47d725371aa481c30bcaa742f4760106e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477840 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638628} content/browser/BUILD.gn | 2 + .../blink_notification_service_impl.cc | 18 +- .../blink_notification_service_impl_unittest.cc | 29 +++ .../platform_notification_context_impl.cc | 139 +++++++++++++-- .../platform_notification_context_impl.h | 27 ++- ...atform_notification_context_trigger_unittest.cc | 197 +++++++++++++++++++++ .../platform_notification_service_proxy.cc | 88 +++++++++ .../platform_notification_service_proxy.h | 74 ++++++++ content/test/BUILD.gn | 1 + 9 files changed, 559 insertions(+), 16 deletions(-) commit e3378cb792dbd9f5b55dc3b6653dda438808907f Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Mar 7 17:32:40 2019 +0000 Preparation to convert GetPrimaryAccount to return CoreAccountInfo Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: Ic7e29b114fd39ee0c55cafb1a0e526eb1aa78244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499559 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638627} .../google_services/accounts_table_view_controller.mm | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 507870b87eb80610752d8e54055ffcdb5c03a79a Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Thu Mar 7 17:32:33 2019 +0000 [LayoutNG] Fix a typo in NGOffsetMapping::GetPositionWithAffinity When the input caret position is "AfterCharacter", the function should look backwards for the result position in DOM. Hence, it should call GetFirstPosition() instead of GetLastPosition(). Bug: 894651 Change-Id: If2c9e8346c38859d0b8674dd56f49fbc71aa3ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506768 Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638626} third_party/blink/renderer/core/layout/ng/inline/ng_offset_mapping.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e43501168d7abb1935ec78786152141aae6f53b3 Author: Matthew Jones <mdjones@chromium.org> Date: Thu Mar 7 17:26:37 2019 +0000 Update public API of ModelListAdapter to be more generic This patch is largely removing the use of 'suggestion' from a generic MVC class. Change-Id: I20e5932d0638da0489ed002ffa8555874bd10eba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506206 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638625} .../browser/ntp/cards/SuggestionsSection.java | 12 +++----- .../suggestions/SuggestionListViewBinder.java | 2 +- .../browser/ntp/cards/SuggestionsSectionTest.java | 2 +- .../chromium/ui/modelutil/ModelListAdapter.java | 36 +++++++++++----------- 4 files changed, 25 insertions(+), 27 deletions(-) commit 9dbd723e682b19eee3519f925fbcc1356baaf01b Author: Tomasz Wiszkowski <ender@google.com> Date: Thu Mar 7 17:21:47 2019 +0000 Supply accessibility description for refine button. This change adds accessibility content description for refine button Bug: 939014 Change-Id: Ief2f5d1e5aa14498d03eda7827788dfd0d752ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506557 Commit-Queue: Ender <ender@google.com> Auto-Submit: Ender <ender@google.com> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638624} chrome/android/java/res/layout/omnibox_answer_suggestion.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d926e1bf38e2b16e631f33cf988bc3d226b27653 Author: Oystein Eftevaag <oysteine@chromium.org> Date: Thu Mar 7 17:19:14 2019 +0000 Perfetto: Use the Consumer::ChangeTraceConfig API to add new PIDs to trace Needs https://android-review.googlesource.com/c/platform/external/perfetto/+/910574 to land and roll into Chrome before this can land. R=ssid@chromium.org Bug: 839084 Change-Id: I945eca9387c562a144af30dfee9f7759a23e3f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500134 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#638623} .../perfetto/perfetto_tracing_coordinator.cc | 101 +++++++++++++++------ 1 file changed, 71 insertions(+), 30 deletions(-) commit a3a2a6e54ee42ec87a74a1396b1907867a411233 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 17:18:24 2019 +0000 SPM: Reduce the number of pixels sent to Ash for window icons. There are two icon properties, kAppIcon and kWindowIcon. For the purposes of Ash, these are used interchangeably (kAppIcon is preferred and kWindowIcon is a fallback). Thus we can skip sending kWindowIcon. This should cut down on memory usage by half. Further, the only place that the icon is used for single process mash is in overview mode, which displays the icon at 24dip. We can downscale the icon before sending it over. For tabbed browser windows, that's 24dip*24dip instead of 192px * 192px. Since the icons are set on the content window as well as the root window, they are each copied to the window service twice. We do need to transport the icons that are set on the root window, but not on the content window. PropertyConverter doesn't distinguish on the window type, so new keys are introduced for the root window: kAppIconSmallKey and kAppIconLargeKey. These are the only ones that are sent to the WS. They are only used in Mash. kAppIconKey and kWindowIconKey are retained for use in the browser, e.g. by AppWindowLauncherItemController. kAppIconLargeKey is only set by the task manager and used by ShelfWindowWatcher for the shelf icon. The net effect is that every browser window goes from allocating 192x192px four times, to 24x24dip once. According to chrome://tracing this lops about 4MiB off malloc'd memory in the browser process when there are 10 browser windows open. Bug: 938105 Change-Id: I7bc04784ff3fb1d0857219eae2184542b1f14fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504164 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638622} ash/mus_property_mirror_ash_unittest.cc | 12 ------------ ash/public/cpp/mus_property_mirror_ash.cc | 5 ----- ash/shelf/shelf_window_watcher.cc | 4 +++- ash/wm/overview/caption_container_view.cc | 6 +++++- chrome/browser/ui/views/task_manager_view.cc | 24 ++++++++++++++++++++---- chrome/browser/ui/views/task_manager_view.h | 1 + services/ws/public/mojom/window_manager.mojom | 10 +++++----- ui/aura/client/aura_constants.cc | 2 ++ ui/aura/client/aura_constants.h | 11 +++++++++++ ui/aura/mus/property_converter.cc | 8 ++++---- ui/views/mus/desktop_window_tree_host_mus.cc | 16 +++++++++++++++- ui/views/mus/mus_client.cc | 16 ---------------- 12 files changed, 66 insertions(+), 49 deletions(-) commit 4f4caf15549366b27eee3ce699bec69188500920 Author: Thomas Tangl <tangltom@chromium.org> Date: Thu Mar 7 17:17:13 2019 +0000 Provide new profile avatar icons - New profile avatar icons are added to Chrome. - The avatar selector is refreshed: - Only the new avatars are available for selection. - The icons are made round and bigger. - Existing profiles will keep their current avatars, i.e. they don't need to be migrated. Screenshots: https://drive.google.com/file/d/1m5tDHR9k-2Z9ZkQfza-l7D3oZIsTgftu/view?usp=sharing https://drive.google.com/file/d/11lzTzZJR_qBT4qziY_Z5lbgPgyrBHVBa/view?usp=sharing Bug: 937834 Change-Id: Iffe141de2aa9d176690cc1caaed05afd76adccff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505942 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#638621} chrome/app/profiles_strings.grdp | 33 +++ .../common/origami/avatar_cat.png | Bin 0 -> 27691 bytes .../common/origami/avatar_corgi.png | Bin 0 -> 17599 bytes .../common/origami/avatar_dragon.png | Bin 0 -> 32468 bytes .../common/origami/avatar_elephant.png | Bin 0 -> 16601 bytes .../common/origami/avatar_fox.png | Bin 0 -> 16649 bytes .../common/origami/avatar_monkey.png | Bin 0 -> 16607 bytes .../common/origami/avatar_panda.png | Bin 0 -> 15043 bytes .../common/origami/avatar_penguin.png | Bin 0 -> 12119 bytes .../common/origami/avatar_pinkbutterfly.png | Bin 0 -> 25408 bytes .../common/origami/avatar_rabbit.png | Bin 0 -> 12726 bytes .../common/origami/avatar_unicorn.png | Bin 0 -> 36152 bytes chrome/app/theme/theme_resources.grd | 13 ++ .../android/profiles/profile_downloader_android.cc | 4 +- .../browser/profiles/profile_attributes_storage.cc | 4 +- .../browser/profiles/profile_avatar_icon_util.cc | 235 +++++++++++---------- chrome/browser/profiles/profile_avatar_icon_util.h | 16 +- .../profiles/profile_avatar_icon_util_unittest.cc | 2 +- chrome/browser/profiles/profile_metrics.cc | 11 +- .../profiles/profile_shortcut_manager_win.cc | 24 ++- .../ui/cocoa/profiles/profile_menu_controller.mm | 6 +- .../settings/settings_manage_profile_handler.cc | 16 +- .../settings/settings_manage_profile_handler.h | 2 + .../settings_manage_profile_handler_unittest.cc | 31 ++- .../ui/webui/signin/user_manager_screen_handler.cc | 4 +- .../cr_profile_avatar_selector.html | 8 +- 26 files changed, 255 insertions(+), 154 deletions(-) commit ffdeffe8fb9f85e59dcc58a8163ca9a5eae1a6b0 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Thu Mar 7 17:16:17 2019 +0000 Use PrefService directly in DownloadArchiveManager instead of Profile. Bug: 937007 Change-Id: Ibe088bf8b76446098520284a50ac84ec5140ce0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495801 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638620} .../offline_pages/android/offline_page_model_factory.cc | 2 +- .../browser/offline_pages/download_archive_manager.cc | 9 ++++----- chrome/browser/offline_pages/download_archive_manager.h | 6 +++--- .../offline_pages/download_archive_manager_unittest.cc | 17 +++++++++-------- 4 files changed, 17 insertions(+), 17 deletions(-) commit aca01cb1c0bd97c1536ad51ab99ef2476b7b3694 Author: Ella Ge <eirage@chromium.org> Date: Thu Mar 7 17:16:09 2019 +0000 Make captured mouse pointer event route correctly on oopif Before this change, we do not capture mouse events to widget when set/release pointer capture. It causes a bug that when mouse down on main frame and set pointer capture, mouse still not capture to the main frame widget because we neither set widget capture on main frame mouse down nor set widget capture on pointer capture set. This CL makes PEM::SetPointerCapture and ReleasePointerCapture returns a boolean to shows whether pointer capture is changed, and we change widget capture accordingly. Change-Id: I1d571659237c81f8575d4556d725c22c8c2b862f Bug: 936190, 919908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1446500 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638619} .../site_per_process_hit_test_browsertest.cc | 119 +++++++++++++++++++++ .../blink/renderer/core/input/event_handler.cc | 8 +- .../renderer/core/input/pointer_event_manager.cc | 11 +- .../renderer/core/input/pointer_event_manager.h | 4 +- 4 files changed, 135 insertions(+), 7 deletions(-) commit d9fda17dcbb5d48982f11a349a2cb98b2c402ba3 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Mar 7 17:12:07 2019 +0000 Automation API should include image labeling AXMode We recently introduced a new AXMode that turns on image labeling for a WebContents, and it's integrated into BrowserAccessibilityState, the mechanism used to set the global AXMode on most platforms. On Chrome OS the mechanism is slightly different, using the automation API, and we missed one place. Fix it by merging the AXMode set for the automation API with the image labeling flag if needed, and add a test for it. Bug: 938637, 905419 Change-Id: I273b35e3ef2457207f8a5ff4482cfeae4178027d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504695 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638618} .../accessibility/accessibility_labels_service.cc | 3 +- .../api/automation/automation_apitest.cc | 40 +++++++++++++++++ content/browser/web_contents/web_contents_impl.cc | 15 +++++-- ui/accessibility/BUILD.gn | 1 + ui/accessibility/PRESUBMIT.py | 6 ++- ui/accessibility/ax_mode.cc | 50 ++++++++++++++++++++++ ui/accessibility/ax_mode.h | 20 ++++++++- 7 files changed, 128 insertions(+), 7 deletions(-) commit a4f1a1ed56911611b684b6e259c501bcc07d189e Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Thu Mar 7 17:10:57 2019 +0000 [Payment Request][Android] Attach UI right before blocking interactions Before this patch, if PaymentRequest.show() was called in a CCT, then user opened the CCT page in Chrome, and a skip-UI payment app was slow to respond to the `canmakepayment` event, then the activity to which Chrome attached the payment UI would be gone by the time the payment UI needs to be shown, which would cause a crash. The skip-UI bit is important, because in this flow Chrome blocks UI interactions only after launching the payment app (after the response to `canmakepayment` event). This patch waits to attach the payment UI to the current Chrome activity via buildUI(chromeActivity) until immediately before blocking UI interactions via mUI.show() or mUI.dimBackground(). After this patch, Chrome does not crash when PaymentRequest.show() was called in a CCT for skip-UI flow and the user opened the CCT page in Chrome before the payment app responded to the `canmakepayment` event. Bug: 817073 Change-Id: I5ce50d000c2f64a60c62955d9e3e8f080498238d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506494 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638617} .../browser/payments/PaymentRequestImpl.java | 91 ++++++++++++---------- 1 file changed, 50 insertions(+), 41 deletions(-) commit 6b22924a6df58af33a6c21e7d88857395be848ff Author: Maksim Sisov <msisov@igalia.com> Date: Thu Mar 7 17:10:32 2019 +0000 [ozone/wayland] Let Wayland compositor decide how to place menu windows This patch fixes disposition/misplacement of menu windows and let the Wayland compositor decide how to place the windows if their pixels cannot be shown on one display or if they are partly going to be hidden because of being shown too close to some edges of a display. First of all, Chromium positions windows using screen coordinates. As long as Wayland does not provide global coordinates, the client does not know the position of windows in screen coordinates and always assumes that they are located on 0,0. What's left for us to do is to translate bounds from screen coordinates to relative to parent coordinates, which is easy to do. Secondly, WaylandWindow re-positions nested menus back to the right side of parent menus (if the size of a top level window is close or equal to the work area of a display) and let Wayland compositor decide how to position them based on calculated anchor rect, anchor and gravity. The exception for this is based on the maximized state of a top level window. If it's maximized, then the nested windows are not re positioned and left on the left side of the parent menu windows. Also, WaylandWindow must be able to recalculate origin back from relative to parent to be relative to top level window aka on screen location. The unittests exercises all those mentioned cases and make sure WaylandWindow is able to calculated bounds correctly (the values are taken by manual usage of the Chromium browser and logs). PS XdgVersionV5Test/WaylandWindowTest.AdjustPopupBounds/0 is skipped as long as it does not support xdg positioner. Test: XdgVersionV6Test/WaylandWindowTest.AdjustPopupBounds/0 Bug: 927280 Change-Id: I30573620562e7bc5dfd3a69487326bcda49fc6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474654 Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#638616} ui/ozone/platform/wayland/test/mock_surface.h | 10 + ui/ozone/platform/wayland/test/mock_xdg_popup.cc | 5 +- ui/ozone/platform/wayland/test/mock_xdg_popup.h | 20 +- ui/ozone/platform/wayland/test/mock_xdg_shell.cc | 10 +- ui/ozone/platform/wayland/test/mock_xdg_surface.cc | 15 +- ui/ozone/platform/wayland/test/mock_xdg_surface.h | 11 + ui/ozone/platform/wayland/test/test_positioner.cc | 21 +- ui/ozone/platform/wayland/test/test_positioner.h | 34 ++- ui/ozone/platform/wayland/wayland_window.cc | 108 +++++++- ui/ozone/platform/wayland/wayland_window.h | 6 + .../platform/wayland/wayland_window_unittest.cc | 300 +++++++++++++++++++++ ui/ozone/platform/wayland/xdg_popup_wrapper_v5.cc | 4 + ui/ozone/platform/wayland/xdg_popup_wrapper_v6.cc | 209 +++++++++++++- ui/ozone/platform/wayland/xdg_popup_wrapper_v6.h | 1 + 14 files changed, 709 insertions(+), 45 deletions(-) commit 89f296b34f4f33e048848c06da08fc9271b30bc9 Author: Sebastien Lalancette <seblalancette@chromium.org> Date: Thu Mar 7 17:09:51 2019 +0000 [AF] Prevent Logging Password Values to Console Before sending over to be logged by DevTools, filter out DOM nodes that have a type attribute equal to "password", and that are not empty. Bug: 934609 Change-Id: I147ad0c2bad13cc50394f4b5ff2f4bfb7293114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506498 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638615} .../content/renderer/page_form_analyser_logger.cc | 30 +++++++++++++++++++--- 1 file changed, 27 insertions(+), 3 deletions(-) commit 70bf8062201527323c58530fc2071131203b4665 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 17:04:49 2019 +0000 Fix L10nUtilTest flakiness by shutting down StatisticsProvider Bug: 939160 Change-Id: I9371553975c56bb19450aed1ac12296708c0e412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507233 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638614} chrome/browser/ui/webui/chromeos/login/l10n_util_unittest.cc | 1 + 1 file changed, 1 insertion(+) commit 5bf2ecddee8554a205a65844445f8c3ae10e8934 Author: Sebastien Lalancette <seblalancette@chromium.org> Date: Thu Mar 7 17:04:14 2019 +0000 [AF] Adding Fieldtrial Config For Autocomplete Retention Policy Change-Id: Ide05b93e62e29bcf34e813022b1214f37af1c0be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498783 Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#638613} testing/variations/fieldtrial_testing_config.json | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) commit d4a42b6aa603a138d53ecf835c0ca89e17700b4d Author: Sam Maier <smaier@chromium.org> Date: Thu Mar 7 17:03:30 2019 +0000 Blacklisting unfinished Activities in tests from blocking on finish Bug: 939148 Change-Id: If82c99bfdf0834589a818591502928212ad35e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508694 Commit-Queue: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Sam Maier <smaier@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#638612} .../chromium/base/test/DestroyActivitiesRule.java | 29 +++++++++++++++++----- 1 file changed, 23 insertions(+), 6 deletions(-) commit 6312e2226c1576aa45d34638912a490d513a77ad Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 17:02:23 2019 +0000 Roll src-internal 5b257f91fc81..fff41430adb0 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b257f91fc81..fff41430adb0 Created with: gclient setdep -r src-internal@fff41430adb0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: Iff68f0840621d962d57111f3518f089c10c3b932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508832 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638611} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8b13dccaf5e113df7184101d5594dfa746fa672e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 17:01:59 2019 +0000 Roll src/third_party/perfetto c0eace27e740..2d4d2a3cf7b9 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/c0eace27e740..2d4d2a3cf7b9 git log c0eace27e740..2d4d2a3cf7b9 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 treehugger-gerrit@google.com Merge "Fix build." Created with: gclient setdep -r src/third_party/perfetto@2d4d2a3cf7b9 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I8fa07e1ec24322b3e41158eedc19af82f3ad01ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508554 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638610} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4585f0d262c66f50db3430bd4b14757499da7b24 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Mar 7 17:01:18 2019 +0000 Use concrete classes instead of AsyncFileSystemCallbacks when possible Bug 933878 is phasing out the use of AsyncFileSystemCallbacks in favor of concrete callback classes. This CL is a follow up of [1] replaces a left over usage and removes a unneeded include. [1] crrev.com/c/1499873 R=jbroman@chromium.org CC=​​blink-reviews-vendor@chromium.org BUG=933878 Change-Id: Ia46cdc035da04c9c2c8d9c968d9d0163320b0c59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508612 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#638609} .../blink/renderer/modules/filesystem/data_transfer_item_file_system.cc | 1 - third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) commit 4fd90639292a51c4b43f8964c67697cbb2dd9228 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 17:00:55 2019 +0000 Restore correct env mode in AshServiceTest Bug: 939191 Change-Id: I0fecec51bb541e3557790b2502df15346d0c5f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507275 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638608} ash/ash_service_unittest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit c71bb6f5f1a9ff948c6cf8465f01d3871a4c1674 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Thu Mar 7 16:57:54 2019 +0000 Cleanup web_test test_runner slightly. * Make tryToSetTopLevelFrame() and tryToClearTopLevelFrame() to return void instead. Nobody was using the returned value anyway. * Remove topLoadingFrame(). I was not used externally. No behavior changes here. Bug: 936696 Change-Id: I21c4266140dba897a89f4ae558c2a30dbb44615b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492339 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638607} content/shell/test_runner/test_runner.cc | 24 +++++++++--------------- content/shell/test_runner/test_runner.h | 19 +++++++++---------- 2 files changed, 18 insertions(+), 25 deletions(-) commit 787570a29879e2275f8d8c7817ab005b0ee253d0 Author: Peter Beverloo <peter@chromium.org> Date: Thu Mar 7 16:57:30 2019 +0000 Add an experiment for the A2HS infobar text Through Finch configuration, the add to homescreen banner can now have one of three values (the first being the default option): - Add <site> to Home screen - Install <site> - Install <site> (no download required) Bug: 937871 Change-Id: Ie519d5e80f345c9ebdfff490659632f8842bddf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499566 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#638606} chrome/app/generated_resources.grd | 6 ++++++ .../installable_ambient_badge_infobar_delegate.cc | 18 ++++++++++++++++-- chrome/common/chrome_features.cc | 5 +++++ chrome/common/chrome_features.h | 5 +++++ 4 files changed, 32 insertions(+), 2 deletions(-) commit f820bc6e73a7b796d58d1d14a4181c9a861bdbe0 Author: G. Silva <gfaus@chromium.org> Date: Thu Mar 7 16:56:38 2019 +0000 Add converter utility for the time limits processor consistency test. It will be used by the test engine later on to convert goldens to and from the processor-specific structures. Bug: 935711 Change-Id: I84d2ea9f8eb742b1d7f1a062eeea88dfb7f30d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492091 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#638605} chrome/browser/chromeos/BUILD.gn | 2 + .../consistency_golden_converter.cc | 110 +++++++++++++++++++++ .../consistency_golden_converter.h | 36 +++++++ .../consistency_golden_converter_unittest.cc | 106 ++++++++++++++++++++ 4 files changed, 254 insertions(+) commit 5b65da182c4c9a21458ae83eebb76a03ea282742 Author: Roger Tawa <rogerta@chromium.org> Date: Thu Mar 7 16:56:00 2019 +0000 Remove error messages from credential provider logs that are not actual errors. Bug: 938974 Change-Id: I9fa64579b8dcaf5e0434383c6068ff83a607ef65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506393 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#638604} chrome/credential_provider/gaiacp/gcp_crash_reporting_utils.cc | 6 ++++-- chrome/credential_provider/gaiacp/os_user_manager.cc | 4 ---- chrome/credential_provider/gaiacp/scoped_lsa_policy.cc | 7 ++----- 3 files changed, 6 insertions(+), 11 deletions(-) commit a1fc98e99312f693c2dc8f2d812dc05cec586672 Author: Peter Kotwicz <pkotwicz@chromium.org> Date: Thu Mar 7 16:52:35 2019 +0000 Skip DownloadMediaParserTest#testParseVideoH264() on tablets This CL switches DownloadMediaParserTest from using BaseJUnit4ClassRunner to using ChromeJUnit4ClassRunner. because ChromeJUnit4ClassRunner knows about UiRestriction.RESTRICTION_TYPE_PHONE BUG=939218 Change-Id: Iea95b4c088d9447664e569d1cee616b2c4d89038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507396 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638603} .../org/chromium/chrome/browser/download/DownloadMediaParserTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit fbdfd22bd5385f5fc0d6a568d3fb4a45f756320c Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Mar 7 16:50:15 2019 +0000 Preparation to convert GetPrimaryAccount to return CoreAccountInfo Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. This CL was uploaded by git cl split. Bug: 926204 Change-Id: I7ed54720bb93c83df6802f83034138f71bb8e479 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499515 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638602} chrome/browser/ui/webui/settings/people_handler.cc | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit ee3dfe728c71ffd9ec2b711918d75f97be86b686 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Mar 7 16:42:56 2019 +0000 [non-BGPT] Fix animation DCHECK and add virtual/disable-blink-gen-property-trees/animations - Fix DCHECK: is_running_xxx_animation_on_compositor should not be set in non-BGPT mode. The DCHECK is to check if the flag is set, we must have CompositingReason::kActiveXXXAnimation in direct_compositing_reasons (which is not set in non-BGPT). - Add virtual/disable-blink-gen-property-trees/animations to avoid regressions in non-BGPT mode when we make animation changes. The virtual suite is run with --enable-threaded-compositing which is closer to real world. Bug: 836884 Change-Id: I2f88db3423a9938cb55ce91244735b3881d31a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507044 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638601} .../renderer/core/paint/paint_property_tree_builder.cc | 16 ++++++++-------- third_party/blink/web_tests/SlowTests | 1 + third_party/blink/web_tests/TestExpectations | 9 +++++++++ third_party/blink/web_tests/VirtualTestSuites | 7 +++++++ .../animations/README.txt | 2 ++ .../animations/rotate-transform-equivalent-expected.png | Bin 0 -> 8093 bytes 6 files changed, 27 insertions(+), 8 deletions(-) commit fb9f9710988d0b3f2ca040268af07f5267761c84 Author: Stephane Zermatten <szermatt@chromium.org> Date: Thu Mar 7 16:41:48 2019 +0000 [Autofill Assistant] Disable tab-switching unless it's necessary. This change disallows tab-switching unless the experiment AutofillAssistantChromeEntry is enabled, as Autofill Assistant normally doesn't need it. Before this change, it was possible to take Autofill Assistant out of the Chrome Custom tab by choosing "Open in Chrome". It was possible to have more than one tab open on Chrome Custom Tab without breaking Autofill Assistant. With this change, Autofill Assistant turns itself off when choosing "Open in Chrome" and enters an error when a new tab is opened in Chrome Custom Tab, like M73 does. Bug: 925947, b/125738726 Change-Id: I39fc8aecf4479183d6c115c775b13bb218590f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507658 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#638600} .../AutofillAssistantUiController.java | 44 +++++++++------------- .../autofill_assistant/ui_controller_android.cc | 6 ++- 2 files changed, 22 insertions(+), 28 deletions(-) commit bd44bbc19a4d749a1c8a8657fba4213759245b3b Author: Brian White <bcwhite@chromium.org> Date: Thu Mar 7 16:40:56 2019 +0000 Extended documentation on UKM enum configuration. Change-Id: Ibc22fe9f59e7a5cd79b2e4a3a3de08f445c15812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489179 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#638599} services/metrics/ukm_api.md | 42 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 4 deletions(-) commit 58e16db296d0ed881e37346fcf8efeeafad57102 Author: kylechar <kylechar@chromium.org> Date: Thu Mar 7 16:39:01 2019 +0000 Pass vector<OverlayStrategy> instead of string. CompositorOverlayCandidateValidatorOzone took a string that was really a comma separated list of overlay strategies. The string was parsed into a list of callbacks that were later used to create the appropriate strategy objects. This CL changes CompositorOverlayCandidateValidatorOzone to take a list of OverlayStrategy enums instead. The enum already existed for UMA and it contains an entry for each overlay strategy. Use the list of enum values to directly instantiate the strategy objects, saving a layer indirection. Move the enum to //components/viz/common so it can be used with IPC later. Also move the code to parse a string containing a comma separated list of strategies, as this is used by the --enable-hardware-overlays flag. Bug: 930173 Change-Id: Ie5d6d501e3117cf4be0fcf29ac8bdf29744041da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505839 Reviewed-by: danakj <danakj@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#638598} components/viz/common/BUILD.gn | 3 + components/viz/common/display/overlay_strategy.cc | 34 +++++++++++ components/viz/common/display/overlay_strategy.h | 34 +++++++++++ .../common/display/overlay_strategy_unittest.cc | 43 ++++++++++++++ .../viz/service/display/overlay_processor.cc | 6 +- components/viz/service/display/overlay_processor.h | 15 +---- .../service/display/overlay_strategy_fullscreen.cc | 4 +- .../service/display/overlay_strategy_fullscreen.h | 2 +- .../display/overlay_strategy_single_on_top.cc | 4 +- .../display/overlay_strategy_single_on_top.h | 2 +- .../service/display/overlay_strategy_underlay.cc | 4 +- .../service/display/overlay_strategy_underlay.h | 2 +- .../display/overlay_strategy_underlay_cast.cc | 4 +- .../display/overlay_strategy_underlay_cast.h | 2 +- ...compositor_overlay_candidate_validator_ozone.cc | 68 ++++++++-------------- .../compositor_overlay_candidate_validator_ozone.h | 15 ++--- .../compositor/gpu_process_transport_factory.cc | 3 +- .../browser/compositor/reflector_impl_unittest.cc | 9 ++- 18 files changed, 167 insertions(+), 87 deletions(-) commit 9665c2e2e55dba3639a9cfaabbcc137cde2985e0 Author: Brian White <bcwhite@chromium.org> Date: Thu Mar 7 16:37:18 2019 +0000 Another round of owner changes for histograms.xml. Bug: 923083 Change-Id: I62679448e96ea016d73b2e7c4d955b3a514d2be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496312 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Brian White <bcwhite@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#638597} tools/metrics/histograms/histograms.xml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 666e6630b5d3c15313ce5ff385eac85459c65623 Author: Bruce Dawson <brucedawson@chromium.org> Date: Thu Mar 7 16:36:43 2019 +0000 Revert "Switch to full 17763 SDK, including new d3dcompiler_47.dll" This reverts commit d17a7e3cc86ff480e081854b0c9a358ddf3112ac. Reason for revert: Increase in heap corruption (and other?) crashes in the d3dcompiler code path, such as crbug.com/932359. We have run out of time to investigate before branching. Original change's description: > Switch to full 17763 SDK, including new d3dcompiler_47.dll > > The new (10.0.17763.0) version of d3dcompiler_47.dll contains various > bug fixes which we want to ship. We initially avoided upgrading it with > the rest of the SDK because it depends on the universal Windows 10 CRT > (UCRT) which some Windows 7 machines lack. This caused test failures on > some bots and would cause failures on some customer machines. > > This change updates how we package isolates so that they always include > the UCRT, to avoid test failures. It also ships api-ms-win-*.dll and > ucrtbase*.dll in mini_installer.exe so that the UCRT will be shipped to > customers. The size increase to mini_installer.exe for this is about > 400,000 bytes. > > This change also deletes an unused function (_read_configuration_from_gn) > from create_installer_archive.py that sent me down an incorrect path > while investigating fixes. > > The toolchain package is the same as the one used when landing > crrev.com/c/1401403 except that the 17763 version of d3dcompiler_47.dll > was retained. See that CL for full instructions on creating the > toolchain package. > > Bug: 920704 > Change-Id: I9cb7a7ed5cb75d04962fc64869d26b12617c0463 > Reviewed-on: https://chromium-review.googlesource.com/c/1450414 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629193} TBR=brucedawson@chromium.org,grt@chromium.org Bug: 920704 Change-Id: Ia986017541e5e80a3cc5f1d96494e0e12a841ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507040 Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#638596} build/vs_toolchain.py | 5 +- build/win/BUILD.gn | 97 +++++++++++++------------- chrome/installer/mini_installer/chrome.release | 2 - 3 files changed, 51 insertions(+), 53 deletions(-) commit 32da2220bffb4ede3199bd02dad006adc066c1de Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 16:31:45 2019 +0000 flags: remove sound-content-setting This change removes the sound-content-setting flag, the backing SoundContentSetting feature, and all logic referencing it. Bug: 896400 Change-Id: I80344ade50309df7c667d86477801106adfd3768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503619 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638595} .../chromium/chrome/browser/ChromeFeatureList.java | 1 - .../website/SiteSettingsPreferences.java | 7 +-- chrome/browser/about_flags.cc | 4 -- chrome/browser/android/chrome_feature_list.cc | 1 - chrome/browser/flag-metadata.json | 5 --- chrome/browser/flag_descriptions.cc | 4 -- chrome/browser/flag_descriptions.h | 3 -- .../settings/privacy_page/privacy_page.html | 51 ++++++++++------------ .../settings/privacy_page/privacy_page.js | 8 ---- .../site_settings/site_settings_behavior.js | 2 - .../site_settings_page/site_settings_page.html | 16 +++---- .../site_settings_page/site_settings_page.js | 8 ---- .../page_info/page_info_controller_android.cc | 3 +- chrome/browser/ui/browser_commands.cc | 7 +-- chrome/browser/ui/page_info/page_info.cc | 3 -- chrome/browser/ui/tab_helpers.cc | 3 +- chrome/browser/ui/tabs/tab_menu_model.cc | 26 +++-------- chrome/browser/ui/tabs/tab_strip_model.cc | 20 --------- chrome/browser/ui/tabs/tab_strip_model.h | 5 --- chrome/browser/ui/tabs/tab_utils.cc | 9 ---- chrome/browser/ui/tabs/tab_utils.h | 4 -- chrome/browser/ui/views/frame/browser_frame_mac.mm | 5 +-- .../md_settings_localized_strings_provider.cc | 4 -- .../test/data/webui/settings/privacy_page_test.js | 1 - .../test/data/webui/settings/site_details_tests.js | 4 -- 25 files changed, 44 insertions(+), 160 deletions(-) commit c484549d49b450cf2c10ec9c47945a04d0bf3666 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Thu Mar 7 16:31:16 2019 +0000 [LayoutNG] Implement EmitsSpaceForNbsp behavior for TextIterator Our NG TextIterator didn't implement the EmitsSpaceForNbsp behavior. This patch implements it. Change-Id: I76e7531ee013494566c15417658042b012462690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506972 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638594} .../blink/renderer/core/editing/iterators/text_iterator_test.cc | 9 +++++++++ .../core/editing/iterators/text_iterator_text_node_handler.cc | 4 ++-- 2 files changed, 11 insertions(+), 2 deletions(-) commit f6f19f092e77ff796c2fb353aa2c4cf40e7f1dbb Author: Dan Elphick <delphick@chromium.org> Date: Thu Mar 7 16:30:36 2019 +0000 [api] Fix use of deprecated Date API Replace deprecatiod Date::DateTimeConfigurationChangeNotification function with Isolate::DateTimeConfigurationChangeNotification. Bug: v8:8834 Change-Id: Iba2008d017d66d2ab27f952fe04b98597c2f86dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507873 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638593} .../renderer/modules/time_zone_monitor/time_zone_monitor_client.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 53a3979678521fc663beb26c026c30a955a35538 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 7 16:29:45 2019 +0000 [Extensions] Use SetLazyDataProperty on GinPort Rather than using ObjectTemplateBuilder::SetProperty() on GinPort, use ObjectTemplateBuilder::SetLazyDataProperty(). This allows author script to reset the properties to be something else, which is more inline with the majority of JS objects exposed to scripts. Add tests for the same. Bug: 927887 Change-Id: I8f983918014d69941992423eece5fd1eed9c58e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506771 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638592} .../bindings/invalidate_context/background.js | 42 +++++++++++++++------ extensions/renderer/gin_port.cc | 12 ++++-- extensions/renderer/gin_port.h | 8 +++- extensions/renderer/gin_port_unittest.cc | 44 +++++++++++++++++----- 4 files changed, 80 insertions(+), 26 deletions(-) commit b26068fdb265258e388fe78acc81e5e689819116 Author: Daniel McArdle <dmcardle@chromium.org> Date: Thu Mar 7 16:29:32 2019 +0000 Add clang_tidy_tool.py to fetch, build, and invoke clang-tidy Bug: 936989 Change-Id: I283cbb9f87e912c8094872a70c6abc193659cbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497198 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#638591} docs/clang_static_analyzer.md | 4 + docs/clang_tidy.md | 13 ++- tools/clang/scripts/clang_tidy_tool.py | 186 +++++++++++++++++++++++++++++++++ 3 files changed, 202 insertions(+), 1 deletion(-) commit 028009ef3d43f4ef7837ae5aa2d5aa11a5ee2820 Author: Aaron Tagliaboschi <aarontag@chromium.org> Date: Thu Mar 7 16:28:06 2019 +0000 Add a callback for setting cookies in URLRequestHttpJob Eventually that callback will have a call to send the blocked cookies to DevTools. For now, it just calls NotifiyHeadersComplete on the last call. I've also created a couple new private variables, including |cs_status_list_| so we can actually use the cookie strings and list when we want to without too much fuss. Bug: 856777 Change-Id: Ic71b1523ea244e4fbfd9cb16c07f716ba14448bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479299 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Cr-Commit-Position: refs/heads/master@{#638590} net/cookies/canonical_cookie.cc | 7 + net/cookies/canonical_cookie.h | 12 +- net/test/embedded_test_server/default_handlers.cc | 3 + net/url_request/url_request_http_job.cc | 99 +++++++++--- net/url_request/url_request_http_job.h | 7 + net/url_request/url_request_unittest.cc | 182 ++++++++++++++++++++++ 6 files changed, 288 insertions(+), 22 deletions(-) commit 1b511f68246f27af7063be9a134689d6385493c4 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 16:26:10 2019 +0000 Add feature flag for notification triggers. This adds a disabled by default flag for the notification trigger feature. It will be used by crrev.com/c/1477840 to guard the implementation. Bug: 891339 Change-Id: I7a11549b49bfcb56bafd5591de06d301de5c5b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505460 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638589} content/public/common/content_features.cc | 4 ++++ content/public/common/content_features.h | 1 + 2 files changed, 5 insertions(+) commit f38eadb87eb58a1a46f171cb64e043d796f7e780 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Mar 7 16:25:29 2019 +0000 Revert "[Files app] Fix MyFiles expanding when isn't selected" This reverts commit f451f9eaf1b6d67b62bdffa1868168146fef0b0b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 638461 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjQ1MWY5ZWFmMWI2ZDY3YjYyYmRmZmExODY4MTY4MTQ2ZmVmMGIwYgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/11234 Sample Failed Step: browser_tests Sample Flaky Test: MyFiles/FilesAppBrowserTest.Test/myFilesExpandWhenSelected_MyFilesVolume Original change's description: > [Files app] Fix MyFiles expanding when isn't selected > > Fix My files expanding when selecting or expanding entries in other > roots. > > Change-Id: I5c87f371ef500608100b6e07ae118f84e71f0311 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505744 > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Auto-Submit: Luciano Pacheco <lucmult@chromium.org> > Reviewed-by: Alex Danilo <adanilo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638461} Change-Id: I7458e4afb3b695c42df45fc0dd3a1aa8e214eb1e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508697 Cr-Commit-Position: refs/heads/master@{#638588} .../file_manager/file_manager_browsertest.cc | 3 +- .../foreground/js/ui/directory_tree.js | 2 +- .../integration_tests/file_manager/metadata.js | 7 ++-- .../integration_tests/file_manager/my_files.js | 37 ---------------------- 4 files changed, 5 insertions(+), 44 deletions(-) commit 20eb9bf1ab3a31f4a80d1524e447989275106f8b Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Mar 7 16:21:03 2019 +0000 Revert "Reland "Adding an exclusion list to the coverage wrapper script."" This reverts commit cdc92f96b8b0e231e1e6c9cc173c9c473d10e908. Reason for revert: Since the other one was reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1508457 Original change's description: > Reland "Adding an exclusion list to the coverage wrapper script." > > This is a reland of 6b7213a45382f01ac0a2efec1015545bd051da89 > > Original change's description: > > Adding an exclusion list to the coverage wrapper script. > > > > The script now assumes GN adds coverage flags to the cflags for each > > source file. The script removes the flag if the file is in an exclusion > > list, or if `--files-to-instrument` is set it will also remove flags if > > the file is not listed in that argument. > > > > The script supports multiple exclusion lists that can be selected with > > the `--target-os` flag. > > > > It's expected that GN will set these flags correctly and invoke the > > script in all coverage builds. http://crrev.com/c/1496002 does that. > > > > > > Bug: 918215 > > Change-Id: I4454f67067a083581f31a22cfef85368825789f9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994 > > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > > Reviewed-by: Max Moroz <mmoroz@chromium.org> > > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637892} > > Bug: 918215 > Change-Id: I1254d288ff263ff94c46b46e6be99738e31b9574 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506974 > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Cr-Commit-Position: refs/heads/master@{#638362} TBR=stgao@chromium.org,robertocn@chromium.org,mmoroz@chromium.org,liaoyuke@chromium.org,sajjadm@google.com Change-Id: I43834e520ccadd680217e80fc6ca40a210684b3c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508597 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638587} build/toolchain/clang_code_coverage_wrapper.py | 79 ++++---------------------- 1 file changed, 10 insertions(+), 69 deletions(-) commit 4555d7d4f75c25f0df008f9655a12e9b1d220eb2 Author: Dave Tapuska <dtapuska@chromium.org> Date: Thu Mar 7 16:13:27 2019 +0000 Add tests for stale while revalidate handling with service workers. Chrome currently fails these tests and it will be enabled in a followup patch. The intent of this change is to add the wpt tests and bring the code closer to the proposed specification. BUG=348877 Change-Id: Ie9894c588b2cfe040be97905617b05c5b49fc4f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479576 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638586} .../platform/loader/fetch/resource_fetcher.cc | 6 ++- third_party/blink/web_tests/TestExpectations | 6 +++ .../fetch-sw.https.tentative.html | 63 ++++++++++++++++++++++ .../stale-while-revalidate/fetch.tentative.html | 20 ++++++- .../wpt/fetch/stale-while-revalidate/stale-css.py | 2 + .../fetch/stale-while-revalidate/stale-image.py | 2 + .../fetch/stale-while-revalidate/stale-script.py | 2 + .../fetch/stale-while-revalidate/sw-intercept.js | 14 +++++ 8 files changed, 111 insertions(+), 4 deletions(-) commit 111b3dadad699b317e1deb5a2d140a9acce6616e Author: Tanja Gornak <melandory@chromium.org> Date: Thu Mar 7 16:10:15 2019 +0000 [Tango->FCM] Separate status enum for the subscription channel. Currently fcm channel and subscription to topics use same enum in order to track their state. This Cl introduces separate enum for the Subscription channel state tracking. Bug: 801985, 878446 Change-Id: If5a4781fdd2e12b8d94245375a1480e237248321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505441 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#638585} components/invalidation/impl/channels_states.cc | 13 +++++++++++ components/invalidation/impl/channels_states.h | 11 ++++++++++ .../invalidation/impl/fcm_invalidation_listener.cc | 24 ++++++++++----------- .../invalidation/impl/fcm_invalidation_listener.h | 5 +++-- .../impl/per_user_topic_registration_manager.cc | 25 ++++++++++++---------- .../impl/per_user_topic_registration_manager.h | 9 +++++--- ...per_user_topic_registration_manager_unittest.cc | 21 ++++++++++-------- 7 files changed, 70 insertions(+), 38 deletions(-) commit 631c9b11acc75a777c4b074f0bd308c6f2313462 Author: behdad <behdadb@chromium.org> Date: Thu Mar 7 16:06:50 2019 +0000 Linkedin login updated Bug: chromium:938514 Change-Id: I85231184360c8040f5bd78d0775aa634452de25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504044 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#638584} tools/perf/page_sets/data/rendering_desktop.json | 2 +- .../page_sets/data/rendering_desktop_6eb5e5be2a.wprgo.sha1 | 1 + tools/perf/page_sets/data/rendering_mobile.json | 8 ++++---- .../page_sets/data/rendering_mobile_d5f51fba2e.wprgo.sha1 | 1 + .../page_sets/data/rendering_mobile_fae11cb2b3.wprgo.sha1 | 1 + tools/perf/page_sets/login_helpers/linkedin_login.py | 14 +++++++++----- 6 files changed, 17 insertions(+), 10 deletions(-) commit f099bbfcbac681b397641afc0ae42881e23ee97e Author: Monica Salama <msalama@google.com> Date: Thu Mar 7 16:06:38 2019 +0000 Android: Log native code's resident pages. Log native code's resident pages. Use the data for visualization and analysis. This work will help in assessing code ordering and will give insight on how to improve it. Bug: 933377 Change-Id: If93f7c07f74111e5a5bb50567453cc9b202219df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482976 Commit-Queue: Monica Salama <msalama@google.com> Reviewed-by: Hector Dearman <hjd@chromium.org> Reviewed-by: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638583} .../queued_request_dispatcher.cc | 30 +++++ .../native_lib_memory/extract_resident_pages.py | 131 +++++++++++++++++++++ .../extract_resident_pages_unittest.py | 39 ++++++ tools/android/native_lib_memory/extract_symbols.py | 16 +-- tools/android/native_lib_memory/visualize.js | 22 ++-- 5 files changed, 223 insertions(+), 15 deletions(-) commit 07e692fdc82e0fc39b62a17c02b0ed95e8aa4641 Author: Marc Treib <treib@chromium.org> Date: Thu Mar 7 16:05:41 2019 +0000 sync_ui_util: De-dupe auth error handling Previously, the auth error handling logic existed twice, depending on whether the initial setup was finished or not. This CL deduplicates the code. This causes two small behavior differences: 1) Before, a TWO_FACTOR auth error was treated as "okay" if first-time setup was incomplete, but treated as an error otherwise. That just seems like an oversight. 2) Before, if there was an auth error while we were also missing the Sync confirmation, we'd show a "missing confirmation" message. Now we'll show "auth error" instead. This CL also relaxes the nullable-restrictions on output params: |status_label|, |link_label| and |action_type| can now all independently be null or not. Bug: 911153 Change-Id: Ic2e5174c2596114725f6816d4f385ebf5c50ece6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507872 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#638582} chrome/browser/sync/sync_ui_util.cc | 127 +++++++++++++++++++----------------- chrome/browser/sync/sync_ui_util.h | 3 +- 2 files changed, 69 insertions(+), 61 deletions(-) commit 4897b675229515658aa8b74ec586716fb203292b Author: Ben Kelly <wanderview@chromium.org> Date: Thu Mar 7 16:01:18 2019 +0000 CacheStorage: Set the Response mime type based on stored content-header. Previously the Response mime type was never set when reading from a Cache. This resulted in empty string blob.type values and could also prevent code cache from being generated if a script Response was put back into a Cache. This CL makes us at least generate a mime type from the current content-type header. This is a partial solution since the mime type should technically be frozen at initial Response construction time even if the content-type header is later changed. To support that we will need to explicitly store a mime type on disk in the cache. This will be done later in crbug.com/938939. Bug: 937963,938939 Change-Id: Iabfe3909ff35957501ef33132af2a0c1f70c5c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506213 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#638581} third_party/blink/renderer/core/fetch/response.cc | 8 +++ .../cache-storage/script-tests/cache-match.js | 58 ++++++++++++++++++++++ .../serviceworker/cache-match.https-expected.txt | 28 +++++++++++ .../window/cache-match.https-expected.txt | 27 ++++++++++ .../worker/cache-match.https-expected.txt | 27 ++++++++++ 5 files changed, 148 insertions(+) commit 72958b291a5cfe41c3a37d041f1b45d03a53f039 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 15:52:17 2019 +0000 Roll src-internal 141e92bdd2cc..5b257f91fc81 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/141e92bdd2cc..5b257f91fc81 Created with: gclient setdep -r src-internal@5b257f91fc81 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:939049 TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: Iecfb3aaee8590497b26d22ddfce778b75dcab986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508556 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638580} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 171f31cbb454b704f53da813f883ced4f5d1aadd Author: Anna Malova <amalova@chromium.org> Date: Thu Mar 7 15:46:57 2019 +0000 Dynamic Module: Separate creating of ClassLoader and module loading. When loading a dynamic module from dex we need to create ClassLoader in advance as part of warmup without loading a module. See also: http://crrev.com/c/1479331 Bug: 924118 Change-Id: Ib7e7250eec8fe9c7f2ce27abe1c031f6dec8d270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506513 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638579} .../customtabs/dynamicmodule/ModuleLoader.java | 91 +++++++++++++++------- .../CustomTabsDynamicModuleLoaderTest.java | 9 +-- .../CustomTabsDynamicModuleTestUtils.java | 4 +- 3 files changed, 70 insertions(+), 34 deletions(-) commit 91640e565aa922da148392d24b1c588cee0c8a9a Author: Tamer Tas <tmrts@chromium.org> Date: Thu Mar 7 15:38:47 2019 +0000 [v8] src side configuration for a new generation layout test builder This CL creates the src side configuration for a V8 waterfall bot. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: 883629 Change-Id: Ia3afccfd8aff1035d0ac0c5ac425d951f0f20c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508514 Commit-Queue: Tamer Tas <tmrts@chromium.org> Auto-Submit: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#638578} testing/buildbot/client.v8.fyi.json | 46 +++++++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 14 +++++++++++ 2 files changed, 60 insertions(+) commit d23978a965960a39dc296c93da803858e75c109f Author: Marc Treib <treib@chromium.org> Date: Thu Mar 7 15:36:31 2019 +0000 Improve comments on Sync's ModelType enum This adds a bit more detail on most model types, and removes comments for deprecated types. Bug: none Change-Id: Ia5434dc89e91a9572a25793ccc9bf8e905723463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506075 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638577} components/sync/base/model_type.h | 43 ++++++++++++++++++--------------------- 1 file changed, 20 insertions(+), 23 deletions(-) commit 3cd77467976bfe6ac663f7187eae3e6a34bdbf2b Author: Lowell Manners <lowell@chromium.org> Date: Thu Mar 7 15:34:31 2019 +0000 Delete OnRequestCompleted method from IdentityAccessorImpl. This CL merges OnRequestCompleted's logic into OnTokenRequestCompleted. There wasn't enough logic to warrant a separate method. Bug: 933109 Change-Id: I2074518187f6078ae2d5c22935aa8a4e911837fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505498 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638576} services/identity/identity_accessor_impl.cc | 13 +++---------- services/identity/identity_accessor_impl.h | 6 +----- 2 files changed, 4 insertions(+), 15 deletions(-) commit 7efd9afd70fccecd6381cb99901c7fa4f3be4215 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Thu Mar 7 15:21:55 2019 +0000 PM: Only enable instrumentation under the chrome embedder. As of https://chromium-review.googlesource.com/c/1425042, content/ no longer provides forwarding for the ResourceCoordinator instrumentation interfaces. This was a step in a larger refactoring, but had the effect of orphaning the instrumentation in all but the chrome/browser embedder. This in turn led to a memory regression in the Android WebView. This CL makes the initialization and the usage of the instrumentation interfaces conditional on a runtime flag, which is only set by the ChromeContentRendererClient. This is still an intermediate state in the refactoring, as the interfaces in question will be moved and simplified. Bug: 926426 Change-Id: Ia640f544b536bf86d53e853de6178aeaf9c9b6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496303 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#638575} chrome/renderer/chrome_content_renderer_client.cc | 4 ++++ .../blink/public/platform/web_runtime_features.h | 2 ++ .../controller/bloated_renderer_detector.cc | 3 ++- .../blink/renderer/core/frame/local_frame.cc | 2 +- .../blink/renderer/platform/exported/platform.cc | 2 +- .../platform/exported/web_runtime_features.cc | 4 ++++ .../instrumentation/resource_coordinator/DEPS | 3 ++- .../frame_resource_coordinator.cc | 8 +++++++- .../frame_resource_coordinator.h | 5 ++++- .../renderer_resource_coordinator.cc | 11 +++++++---- .../renderer_resource_coordinator.h | 5 +++-- .../platform/runtime_enabled_features.json5 | 3 +++ .../main_thread/main_thread_metrics_helper.cc | 21 ++++++++++++--------- .../main_thread/main_thread_scheduler_impl.cc | 7 +++++-- 14 files changed, 57 insertions(+), 23 deletions(-) commit a9fc6c03df9a9f24a51127e97d8e291b966c50bc Author: dstockwell <dstockwell@google.com> Date: Thu Mar 7 15:11:38 2019 +0000 pdf: Implement UX spec for icon states * Adjusts size/location of icons and focus/hover/active states. * Makes viewer-toolbar-dropdown use a single paper-button to avoid overlapping focus/ripple. * Removes focus when a dropdown is cancelled by pointer events. Spec: go/pdf-icon-states-spec Impl: go/pdf-icon-states-impl Bug: 902646 Change-Id: If3bee9f86c8fa9f50537c8ff3cc4e3a9011172eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508014 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638574} .../viewer-pdf-toolbar/viewer-pdf-toolbar.html | 54 +++++++++++++++------- .../viewer-toolbar-dropdown.html | 45 ++++++++++++------ .../viewer-toolbar-dropdown.js | 1 + chrome/test/data/pdf/basic_test.js | 4 +- chrome/test/data/pdf/material_elements_test.js | 4 +- 5 files changed, 74 insertions(+), 34 deletions(-) commit 842ff4603f639fa399afd94380dae702b2f0b08d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 7 15:10:58 2019 +0000 flags: assign debug-packed-apps This flag (& the code it guards) will be dead by the end of 2020, so around M88. Bug: None Change-Id: Icece1bf07e1d4c7976f68054a156cc0daf50b50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505993 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638573} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 6a3c00d53c28bee27ede724e6da25a85424e2486 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Mar 7 15:07:13 2019 +0000 Fix FindExtendedAccountInfoForAccount The method should return an AccountInfo even if some of the information is missing (i.e. has not been fetched by AccountFetcherService yet) as the tests usually do not set extended information on AccountInfo. Bug: 926204 Change-Id: Iba9fafa25914618eefd09310cf91739159373895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503456 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638572} services/identity/public/cpp/identity_manager.cc | 5 ----- .../public/cpp/identity_manager_unittest.cc | 21 +-------------------- 2 files changed, 1 insertion(+), 25 deletions(-) commit 57f4a31dd6c9b1a34f28ddc49cb1d9f776f87c2c Author: Rune Lillesveen <futhark@chromium.org> Date: Thu Mar 7 14:59:47 2019 +0000 Don't stop text-decoration propagation at non-UA shadow boundaries. There is no spec saying this should happen. Neither Gecko nor WebKit does this, and it breaks devtools UX. We still need to stop propagation into UA shadow trees to avoid text-decoration applying to media controls, for instance. Bug: 938193 Change-Id: I21895cb36b0d0bf2b39b42c000d3cf5ceb4255f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508097 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#638571} .../renderer/core/css/resolver/style_adjuster.cc | 17 +++++++++++++---- .../reference/text-decoration-underline-ref.html | 2 ++ .../text-decoration-propagation-shadow.html | 16 ++++++++++++++++ .../shadow-trees/text-decoration-001-ref.html | 13 ------------- .../shadow-trees/text-decoration-001.html | 22 ---------------------- 5 files changed, 31 insertions(+), 39 deletions(-) commit 4434fd2cd3dfa64267569646d4ff87d3cffb9eef Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Thu Mar 7 14:58:14 2019 +0000 [Sync::USS] Fix for PasswordSyncBridge crashes when AddLoginSync() PasswordSyncBridge works under the assumption that it knows all entries in the LoginDatabase, therefore any AddLoginSync() should return exactly one change. This doesn't look to be the case. This CL is relaxing that assumptionfor now till the underlying issue is discovered. Bug: 939302 Change-Id: Ic0f6a11c439f29314149a39cbbd91288e1d909a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508093 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638570} .../core/browser/sync/password_sync_bridge.cc | 44 ++++++++++++++++++---- 1 file changed, 37 insertions(+), 7 deletions(-) commit 33fbc186b508a8018a196abeec1dc60eff9dd2a6 Author: G. Silva <gfaus@chromium.org> Date: Thu Mar 7 14:58:04 2019 +0000 Create golden file loader for the time limit consistency tests. Bug: 935711 Change-Id: Id4f5c77ab7e8d783507b2bdb0000ce5fcb2b417e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487473 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: G. Silva <gfaus@chromium.org> Cr-Commit-Position: refs/heads/master@{#638569} chrome/browser/chromeos/BUILD.gn | 33 +++++++ .../consistency_golden_loader.cc | 71 ++++++++++++++ .../consistency_golden_loader.h | 41 ++++++++ .../consistency_golden_loader_unittest.cc | 47 +++++++++ .../goldens/consistency_golden.proto | 108 +++++++++++++++++++++ .../time_limit_consistency_test/proto_matcher.h | 43 ++++++++ .../test_goldens/test_golden.textproto | 6 ++ .../test_goldens/test_golden_unsupported.textproto | 6 ++ third_party/protobuf/BUILD.gn | 4 + 9 files changed, 359 insertions(+) commit 39e6228eb470803e46b8742f3139c6aab8e5cf1f Author: Matthew Cary <mattcary@chromium.org> Date: Thu Mar 7 14:56:08 2019 +0000 Android: add manifest dump to apk_operations.py. This is needed by automated tools like third_party/catapult/devil to examine the application details of a bundle. Bug: 931269 Change-Id: I000bd53d444390778657e12a4d64ca0e06f38aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477022 Reviewed-by: Egor Pasko <pasko@chromium.org> Reviewed-by: David Turner <digit@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638568} build/android/apk_operations.py | 12 ++++++++++++ build/android/docs/android_app_bundles.md | 7 +++++++ 2 files changed, 19 insertions(+) commit e245bc2f0faa44402bc316f38d39db7bd9ec254c Author: Bryan McQuade <bmcquade@chromium.org> Date: Thu Mar 7 14:55:38 2019 +0000 Record UKM metrics for AMP subframe documents. Change-Id: I81602ca1ddae82456fecc5a14e98f844093405bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506001 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#638567} .../observers/amp_page_load_metrics_observer.cc | 31 +++- .../observers/amp_page_load_metrics_observer.h | 2 + .../amp_page_load_metrics_observer_unittest.cc | 193 ++++++++++++++++++--- tools/metrics/ukm/ukm.xml | 33 ++++ 4 files changed, 235 insertions(+), 24 deletions(-) commit fdf1b941573dc6d4074b2f5b36b99364cfaeb5ae Author: Ulan Degenbaev <ulan@chromium.org> Date: Thu Mar 7 14:53:31 2019 +0000 Remove memory.long_running_idle_gmail* benchmarks Bug: 938937 Change-Id: I7326f03b28d50a826552c8b1335989daa7ed0f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506078 Reviewed-by: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638566} tools/perf/benchmark.csv | 2 - tools/perf/benchmarks/memory.py | 59 ---------------------- .../core/shard_maps/android-nexus5x-perf_map.json | 2 - .../core/shard_maps/android-pixel2-perf_map.json | 2 - .../android-pixel2_webview-perf_map.json | 2 - .../core/shard_maps/android_nexus5_perf_map.json | 4 +- .../android_nexus5x_webview_perf_map.json | 2 - .../android_nexus6_webview_perf_map.json | 2 - .../core/shard_maps/android_one_16_shard_map.json | 2 - tools/perf/core/shard_maps/linux-perf_map.json | 2 - .../mac-10_12_laptop_low_end-perf_map.json | 2 - .../mac-10_13_laptop_high_end-perf_map.json | 2 - tools/perf/core/shard_maps/win-10-perf_map.json | 4 +- .../core/shard_maps/win10_highdpi_shard_map.json | 2 - .../core/shard_maps/win_7_nvidia_gpu_perf_map.json | 2 - tools/perf/core/shard_maps/win_7_perf_map.json | 4 +- tools/perf/core/undocumented_benchmarks.py | 2 - tools/perf/expectations.config | 10 ---- .../page_sets/long_running_idle_google_cases.py | 50 ------------------ 19 files changed, 3 insertions(+), 154 deletions(-) commit b71455c28b26dac6b371c8750f09fb465ed77601 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 14:53:17 2019 +0000 Roll src/third_party/dawn 579cf621f3dc..aa9d6ad09d0d (1 commits) https://dawn.googlesource.com/dawn.git/+log/579cf621f3dc..aa9d6ad09d0d git log 579cf621f3dc..aa9d6ad09d0d --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cwallez@chromium.org Only build "common" on supported systems Created with: gclient setdep -r src/third_party/dawn@aa9d6ad09d0d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ifac156af40540ae6df026c3ff1f47c7ba6f3500d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508552 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638565} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0a2ada08883a2f091767f5dad11ec12d65e7f584 Author: Alexandre Frechette <frechette@chromium.org> Date: Thu Mar 7 14:50:50 2019 +0000 Moving some translate utils to language utils. Bug: 902354, 872096 Change-Id: I34307383106d14fa123a9a93063869e1a7fc734d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500433 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638564} chrome/browser/BUILD.gn | 1 + .../android/preferences/pref_service_bridge.cc | 10 +- .../language_settings_private_api.cc | 6 +- components/language/core/common/BUILD.gn | 3 + components/language/core/common/language_util.cc | 118 +++++++++++++++++++++ components/language/core/common/language_util.h | 24 +++++ .../language/core/common/language_util_unittest.cc | 65 ++++++++++++ .../core/browser/translate_accept_languages.cc | 6 +- .../translate/core/browser/translate_manager.cc | 6 +- .../translate/core/browser/translate_prefs.cc | 14 +-- components/translate/core/common/translate_util.cc | 104 ------------------ components/translate/core/common/translate_util.h | 9 -- .../core/common/translate_util_unittest.cc | 56 ---------- .../translate/core/language_detection/BUILD.gn | 1 + .../language_detection/language_detection_util.cc | 6 +- 15 files changed, 236 insertions(+), 193 deletions(-) commit 8171030dac71b02e72f09c8b0f6ce16a96b3c759 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 14:46:04 2019 +0000 Roll src-internal 310f45e6d446..141e92bdd2cc (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/310f45e6d446..141e92bdd2cc Created with: gclient setdep -r src-internal@141e92bdd2cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I5936100165e618e04300c4875aaddf1a1530e700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508493 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638563} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6a4c97a4615d319e1fbbbbce58cdfff74ceeab02 Author: dstockwell <dstockwell@google.com> Date: Thu Mar 7 14:43:11 2019 +0000 pdf: Disable annotations test under debug builds Time taken to load Web Assembly module causes the test to timeout. Bug: 920684 Change-Id: I6d16428cf8716e8d4203523a55dcd2b2fbfe50b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508015 Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638562} chrome/browser/pdf/pdf_extension_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a3a48425d72da578ca09184e89ef898b405550c5 Author: Hans Wennborg <hans@chromium.org> Date: Thu Mar 7 14:34:38 2019 +0000 Revert "Use the wrapper script in all coverage builds." This reverts commit 78d6b9950b4bd9462c226b2cc2ac1f74ad84ad6a. Reason for revert: This broke the coverage builds, see e.g. https://ci.chromium.org/p/chromium/builders/ci/ToTLinuxCoverage/6258 which fails with: "/bin/sh: 1: ../../build/toolchain/clang_code_coverage_wrapper.py--target-os=linux: not found" I guess there's a missing space before --target-os. Could this have been found in testing? Original change's description: > Use the wrapper script in all coverage builds. > > Previously the wrapper script would only be used for coverage builds > that required selective instrumentation of specific files. Now it > will also be used for any coverage builds. > > Since the script's job is to remove flags from files that shouldn't > have them the default_coverage config now adds to cflags even in a > CQ build. > > Bug: 918215 > Change-Id: I012c5732d46bf5cff9eaf8f50615739bb781cc29 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496002 > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638321} TBR=stgao@chromium.org,dpranke@chromium.org,robertocn@chromium.org,mmoroz@chromium.org,liaoyuke@chromium.org,sajjadm@google.com Change-Id: I8a945239dadc84d5e1c55a94ee84e34f413e54d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508457 Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#638561} build/config/coverage/BUILD.gn | 29 +++++++++++++++----------- build/toolchain/gcc_toolchain.gni | 43 +++++++++------------------------------ 2 files changed, 27 insertions(+), 45 deletions(-) commit 2bb22cc0ca95612fd4c04d927848c62c13b95b13 Author: Michael Hablich <hablich@chromium.org> Date: Thu Mar 7 14:29:00 2019 +0000 Update the V8 version for Chromium branch 74. This is a roll-back to V8 7.4.288. This is the most stable candidate out of the latest Canaries. If this commit results in failures in Blink please contact the Blink sheriff. They may need to make changes to Blink because of the roll-back. When in doubt please try to contact the committer and reviewers of this CL before reverting it. TBR=machenbach@chromium.org Change-Id: Ia8f8d42dbdeb270b72ffa21399257552628b062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508095 Reviewed-by: Michael Hablich <hablich@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638560} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7264e7a4645b2de9267aa4796d2c1216c4e4a32f Author: Mohamed Abdelhalim <zetamoo@chromium.org> Date: Thu Mar 7 14:14:52 2019 +0000 Navigation: Remove unused includes and members. Remove unused includes and members from NavigationHandleImpl. Change-Id: I8aca71e2d8044623ca88c9c166616d31172e357c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505436 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Cr-Commit-Position: refs/heads/master@{#638559} .../browser/frame_host/navigation_handle_impl.cc | 21 --------------------- content/browser/frame_host/navigation_handle_impl.h | 6 ------ 2 files changed, 27 deletions(-) commit 94d5d735357396c7b1fa90e2d6711426bf76193f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 14:09:35 2019 +0000 Roll src/third_party/perfetto cc1308550f58..c0eace27e740 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/cc1308550f58..c0eace27e740 git log cc1308550f58..c0eace27e740 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 taylori@google.com perfetto-ui: Show time with units Created with: gclient setdep -r src/third_party/perfetto@c0eace27e740 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iacf960e98218dbb88e76ffbbf9ee90756938d296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508492 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638558} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5935bce7437ecb2715760bceb49cb37e2dcfae24 Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Mar 7 14:03:23 2019 +0000 [flatbuffer] fix deps type in flatbuffer.gni Header generating action needs to be in public_deps Bug: 931596 Change-Id: Ie69a72a1ab22d839f337e9a3cb7cf105fec43163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508472 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#638557} third_party/flatbuffers/flatbuffer.gni | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit bdd37e9889e6a8140d026c0ed5bedd5ff6b10d29 Author: Anna Malova <amalova@chromium.org> Date: Thu Mar 7 14:02:18 2019 +0000 Using an asset instead of resource to load CCT dynamic module from the dex. Bug: 924118 Change-Id: I4a2420ba610a7e47cc4ca3ec90eef825081a0ae1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479331 Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#638556} .../customtabs/CustomTabIntentDataProvider.java | 19 +++++----- .../browser/customtabs/CustomTabsConnection.java | 26 +++++++++----- .../dynamicmodule/DynamicModuleCoordinator.java | 4 +-- .../customtabs/dynamicmodule/ModuleLoader.java | 41 ++++++++++++---------- .../CustomTabsDynamicModuleLoaderTest.java | 3 +- .../CustomTabsDynamicModuleTestUtils.java | 10 +++--- 6 files changed, 60 insertions(+), 43 deletions(-) commit f4d2979c5f7cf50e1a1bdf66dc0100fb49747a43 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 7 13:54:55 2019 +0000 Import wpt@405751fab6fec48b30c28bfa0f6b86fe056ee425 Using wpt-import in Chromium 689d7721bbafcda6e390fba50781283a08b0ad50. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 682affef9b "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" ab40da96c1 "Isolation: Remove isolation if we have non-svg replaced content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib6bf6d90b468c369584d691af024594fd9066ba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508033 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638555} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 29 ++- .../external/wpt/acid/acid2/px-reference.html | 272 +++++++++++++++++++++ .../web_tests/external/wpt/acid/acid2/reftest.html | 14 +- ...frameEffect-getKeyframes.tentative-expected.txt | 2 +- .../KeyframeEffect-getKeyframes.tentative.html | 4 +- .../css-transforms/parsing/transform-valid.html | 2 +- .../windows/embedded-opener-remove-frame.html | 76 +++--- .../web_tests/external/wpt/interfaces/web-nfc.idl | 1 + .../external/wpt/tools/manifest/manifest.py | 3 +- .../wpt/tools/wptrunner/wptrunner/metadata.py | 2 +- .../embedded-opener-remove-frame-expected.txt | 5 + .../embedded-opener-remove-frame-expected.txt | 5 + .../embedded-opener-remove-frame-expected.txt | 5 + 13 files changed, 373 insertions(+), 47 deletions(-) commit ccae107adb0c05d2dece5a887edee7855e67acbe Author: Caio Lima <caiol@google.com> Date: Thu Mar 7 13:46:54 2019 +0000 Separate URLChecker synchronous and asynchronous logic. Create interface URLCheckerClient to request server and check URL. Create SafeSearchURLCheckerClient to check url using safesearch. Leave only the synchronous logic in URLChecker. BUG=934444 Change-Id: I53106ead0a478227960b49faa27a5d5c9d5c982e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479971 Commit-Queue: Caio Lima <caiol@google.com> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638554} chrome/browser/BUILD.gn | 1 + .../supervised_user/supervised_user_url_filter.cc | 4 +- components/policy/content/BUILD.gn | 2 + .../policy/content/policy_blacklist_service.cc | 10 +- components/safe_search_api/BUILD.gn | 23 +++ .../safe_search_api/fake_url_checker_client.cc | 28 ++++ .../safe_search_api/fake_url_checker_client.h | 39 +++++ .../safe_search/safe_search_url_checker_client.cc | 160 +++++++++++++++++++++ .../safe_search/safe_search_url_checker_client.h | 65 +++++++++ .../safe_search_url_checker_client_unittest.cc | 136 ++++++++++++++++++ components/safe_search_api/stub_url_checker.cc | 10 +- components/safe_search_api/url_checker.cc | 157 ++++---------------- components/safe_search_api/url_checker.h | 50 +++---- components/safe_search_api/url_checker_client.h | 38 +++++ components/safe_search_api/url_checker_unittest.cc | 83 ++++++----- 15 files changed, 589 insertions(+), 217 deletions(-) commit 9d9114047e6e54a39cfac51c6e2f39877227bb50 Author: Leszek Swirski <leszeks@chromium.org> Date: Thu Mar 7 13:46:42 2019 +0000 Reland "[blink] Remove old script streamer thread" This is a reland of 96c748b0b0e61d207ef1d3bd70238b3443179b77 Robustified the flaky test by using TestingPlatformSupportWithMockScheduler to run the scheduler until exhaustion (fun fact, seems that the live version of the script streaming wasn't being tested by this unit test :/ ) Original change's description: > [blink] Remove old script streamer thread > > The script streamer thread has now been replaced with posting tasks to > the scheduler, so remove the flag picking between the two options and > the dedicated streaming thread itself. > > Also, remove the streaming task re-posting now that the blocking/ > non-blocking worker pools are merged. > > Bug: 874080 > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638031} TBR=mlippautz@chromium.org,holte@chromium.org,haraken@chromium.org,kinuko@chromium.org Bug: 874080 Change-Id: I5be59d64fc2d6074094ce57cf884bcd0bdffd3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507874 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#638553} content/child/runtime_features.cc | 3 - content/public/common/content_features.cc | 4 - content/public/common/content_features.h | 1 - testing/variations/fieldtrial_testing_config.json | 19 ----- .../blink/public/platform/web_runtime_features.h | 1 - .../blink/public/platform/web_thread_type.h | 2 +- third_party/blink/renderer/bindings/bindings.gni | 2 - .../renderer/bindings/core/v8/script_streamer.cc | 88 +++------------------ .../renderer/bindings/core/v8/script_streamer.h | 9 +-- .../bindings/core/v8/script_streamer_test.cc | 18 ++--- .../bindings/core/v8/script_streamer_thread.cc | 90 ---------------------- .../bindings/core/v8/script_streamer_thread.h | 60 --------------- .../blink/renderer/core/core_initializer.cc | 2 - .../platform/exported/web_runtime_features.cc | 4 - .../platform/runtime_enabled_features.json5 | 3 - .../platform/scheduler/common/metrics_helper.cc | 1 - .../blink/renderer/platform/web_thread_type.cc | 2 - tools/metrics/histograms/enums.xml | 2 +- 18 files changed, 19 insertions(+), 292 deletions(-) commit e3a40471cf7d3247c44297dbcaeeb3b12810c569 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Thu Mar 7 13:39:03 2019 +0000 [Password Generation] Button titles should be crowdsourced only if AutofillFieldMetadata experiment is enabled. Bug: 910546 Change-Id: If09ec89ded92f21a733b4f22b9e456f8e3365109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508252 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Auto-Submit: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#638552} components/autofill/content/renderer/form_autofill_util.cc | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) commit da96e6ab65c029e04bbf95f7fa120d4cbb40bbfe Author: Colin Blundell <blundell@chromium.org> Date: Thu Mar 7 13:29:30 2019 +0000 Eliminate FakeAccountFetcherService This CL eliminates FakeAccountFetcherService, which provides no functionality over AccountFetcherService following recent changes. The TestImageDecoder class that was contained in fake_account_fetcher_service.* is retained, as it has usage in the codebase. It looks like that usage could potentially be replaced by usage of FakeImageDecoder, but that project is orthogonal to the project of eliminating FakeAccountFetcherService. TBR=droger@chromium.org Bug: 935998 Change-Id: I4eed6e8f4b3a9474076eeed27e7641cd88b25458 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503331 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638551} .../identity_test_environment_profile_adaptor.cc | 25 ++++------------------ components/signin/core/browser/BUILD.gn | 4 ++-- .../browser/account_tracker_service_unittest.cc | 2 +- .../signin/core/browser/signin_manager_unittest.cc | 6 +++--- ...nt_fetcher_service.cc => test_image_decoder.cc} | 4 +--- ...ount_fetcher_service.h => test_image_decoder.h} | 19 +++------------- ...est_environment_chrome_browser_state_adaptor.cc | 21 ++---------------- services/identity/DEPS | 2 +- .../identity/identity_accessor_impl_unittest.cc | 4 ++-- services/identity/public/cpp/DEPS | 2 +- .../public/cpp/identity_manager_unittest.cc | 6 +++--- .../public/cpp/identity_test_environment.cc | 14 ++++++------ .../public/cpp/identity_test_environment.h | 10 ++++----- 13 files changed, 35 insertions(+), 84 deletions(-) commit f97721af06229a670eab5208cad0573d783632a0 Author: Christopher Lam <calamity@chromium.org> Date: Thu Mar 7 13:26:22 2019 +0000 Remove unused bookmarkManagerPrivate APIs. Bug: 938695 Change-Id: I7c67ffb827e483a253d92ad98d90e7e02a5c1d63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507295 Auto-Submit: calamity <calamity@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#638550} .../bookmark_manager_private_api.cc | 250 --------------------- .../bookmark_manager_private_api.h | 122 ---------- .../extensions/api/bookmark_manager_private.json | 197 ---------------- .../bookmark_manager/edit_disabled/test.js | 12 - .../api_test/bookmark_manager/standard/test.js | 106 --------- .../externs/bookmark_manager_private.js | 86 ------- 6 files changed, 773 deletions(-) commit 9a5a4279da37506ab0e99372615254aa0aa32a58 Author: Morten Stenshorne <mstensho@chromium.org> Date: Thu Mar 7 13:19:23 2019 +0000 [LayoutNG] Rebaseline, SK_SUPPORT_LEGACY_CHOOSERASTERPIPELINE removal https://chromium-review.googlesource.com/c/chromium/src/+/1496304 made a skia change and rebaselined most test expectations, but not those specific to LayoutNG. TBR=kojii@chromium.org,reed@google.com Bug: skia:8793 Change-Id: I675bb9449be7e8793c692ce7fb132b61b42fafed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508099 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#638549} .../editing/selection/4402375-expected.png | Bin 36876 -> 36877 bytes .../transformed-selection-rects-expected.png | Bin 28864 -> 28865 bytes .../misc/slow-loading-image-in-pattern-expected.png | Bin 24319 -> 24319 bytes ...s-ltr-text-in-ltr-flow-with-markers-expected.png | Bin 16257 -> 16255 bytes ...s-ltr-text-in-rtl-flow-with-markers-expected.png | Bin 16192 -> 16187 bytes ...mixed-text-in-ltr-flow-with-markers-expected.png | Bin 18661 -> 18662 bytes ...mixed-text-in-rtl-flow-with-markers-expected.png | Bin 18997 -> 18997 bytes ...s-rtl-text-in-ltr-flow-with-markers-expected.png | Bin 18268 -> 18263 bytes ...s-rtl-text-in-rtl-flow-with-markers-expected.png | Bin 17229 -> 17229 bytes .../markers/inline_spelling_markers-expected.png | Bin 15581 -> 15593 bytes .../paint/markers/vertical-lr-expected.png | Bin 6109 -> 6111 bytes .../paint/markers/vertical-rl-expected.png | Bin 6098 -> 6103 bytes .../foreignObject-text-clipping-bug-expected.png | Bin 13929 -> 13929 bytes ...ith-pattern-inside-transformed-html-expected.png | Bin 76986 -> 77006 bytes 14 files changed, 0 insertions(+), 0 deletions(-) commit e2c105980cea71abe6fdd8b23b57e59c888d4eeb Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Mar 7 13:17:40 2019 +0000 [iOS][web] Group NativeContent methods This CL groups the methods related to NativeContent in CRWWebControler. Bug: 938255 Change-Id: I4d375f6c156e0ef39a135542c17f542c5d37d6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506072 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638548} ios/web/web_state/ui/crw_web_controller.mm | 216 ++++++++++++++--------------- 1 file changed, 106 insertions(+), 110 deletions(-) commit 4e55113303c339786806cc2f60d6c6cc60453f51 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 13:14:56 2019 +0000 Roll src-internal dcb547de1a5c..310f45e6d446 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dcb547de1a5c..310f45e6d446 Created with: gclient setdep -r src-internal@310f45e6d446 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: Ia33f26eff636df5b76b71f0618dddeffcb113faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508192 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638547} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4985b226382a88c62a9d921dacab11e393f91c79 Author: Fredrik Söderquist <fs@opera.com> Date: Thu Mar 7 13:11:55 2019 +0000 Improve tainting for filter primitives This makes tainting for many filter primitives less pessimistic, by implementing the "Tainted Filter Primitives" section [1] from the specification. For feFlood/feDropShadow: A value of 'currentcolor' for 'flood-color' taints. For feSpecularLighting/feDiffuseLighting: A value of 'currentcolor' for 'lighting-color' taints. For the other primitives (which currently lack any specific logic), i.e: feBlend, feComponentTransfer, feComposite, feConvolveMatrix, feDisplacementMap, feGaussianBlur, feMorphology, feOffset and feTile no local tainting is performed (the TaintsOrigin() override is returning false). The signature/convention of the TaintsOrigin() is changed by removing the |inputs_taint_origin| argument, and always taint the primitive if it (the flag returned by FilterEffect::InputsTaintOrigin) is true. This saves each primitive to have to relate to this flag. (For primitives that have no inputs this flag would always be false regardless.) This means that TaintsOrigin() for each primitive is now essentially computing the "local" tainting state. [1] https://drafts.fxtf.org/filter-effects/#tainted-filter-primitives Bug: 792518 Change-Id: Ie2d45eeb1ae8478009b88b8b87b3c4c325ede306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503257 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638546} .../svg/layout_svg_resource_filter_primitive.cc | 28 ++++++-- .../svg/graphics/filters/svg_filter_builder.cc | 2 +- .../blink/renderer/core/svg/svg_fe_blend_element.h | 1 + .../core/svg/svg_fe_color_matrix_element.cc | 4 -- .../core/svg/svg_fe_color_matrix_element.h | 2 +- .../core/svg/svg_fe_component_transfer_element.h | 1 + .../renderer/core/svg/svg_fe_composite_element.h | 1 + .../core/svg/svg_fe_convolve_matrix_element.h | 1 + .../core/svg/svg_fe_diffuse_lighting_element.cc | 8 +++ .../core/svg/svg_fe_diffuse_lighting_element.h | 1 + .../core/svg/svg_fe_displacement_map_element.h | 1 + .../core/svg/svg_fe_drop_shadow_element.cc | 8 +++ .../renderer/core/svg/svg_fe_drop_shadow_element.h | 1 + .../renderer/core/svg/svg_fe_flood_element.cc | 8 +++ .../blink/renderer/core/svg/svg_fe_flood_element.h | 1 + .../core/svg/svg_fe_gaussian_blur_element.h | 1 + .../renderer/core/svg/svg_fe_image_element.cc | 7 +- .../blink/renderer/core/svg/svg_fe_image_element.h | 2 +- .../renderer/core/svg/svg_fe_merge_element.cc | 4 -- .../blink/renderer/core/svg/svg_fe_merge_element.h | 2 +- .../renderer/core/svg/svg_fe_morphology_element.h | 1 + .../renderer/core/svg/svg_fe_offset_element.h | 1 + .../core/svg/svg_fe_specular_lighting_element.cc | 8 +++ .../core/svg/svg_fe_specular_lighting_element.h | 1 + .../blink/renderer/core/svg/svg_fe_tile_element.h | 1 + .../renderer/core/svg/svg_fe_turbulence_element.h | 2 +- .../svg/svg_filter_primitive_standard_attributes.h | 2 +- ...rence-displacement-negative-scale-expected.html | 2 +- .../reference/green-blue-stripe-100x100.html | 2 + .../css/filter-effects/tainting-feblend-001.html | 24 +++++++ .../css/filter-effects/tainting-feblend-002.html | 18 +++++ .../tainting-fecomponenttransfer-001.html | 24 +++++++ .../tainting-fecomponenttransfer-002.html | 18 +++++ .../filter-effects/tainting-fecomposite-001.html | 24 +++++++ .../filter-effects/tainting-fecomposite-002.html | 18 +++++ .../tainting-feconvolvematrix-001.html | 24 +++++++ .../tainting-feconvolvematrix-002.html | 18 +++++ .../tainting-fediffuselighting-001.html | 25 +++++++ .../tainting-fediffuselighting-002.html | 21 ++++++ .../tainting-fediffuselighting-003.html | 20 ++++++ .../tainting-fediffuselighting-dynamic.html | 30 ++++++++ .../tainting-fedisplacementmap-001.html | 25 +++++++ .../tainting-fedisplacementmap-002.html | 19 +++++ .../filter-effects/tainting-fedropshadow-001.html | 25 +++++++ .../filter-effects/tainting-fedropshadow-002.html | 20 ++++++ .../filter-effects/tainting-fedropshadow-003.html | 21 ++++++ .../css/filter-effects/tainting-feflood-001.html | 21 ++++++ .../css/filter-effects/tainting-feflood-002.html | 16 +++++ .../filter-effects/tainting-feflood-dynamic.html | 25 +++++++ .../tainting-fegaussianblur-001.html | 24 +++++++ .../tainting-fegaussianblur-002.html | 18 +++++ .../filter-effects/tainting-femorphology-001.html | 24 +++++++ .../filter-effects/tainting-femorphology-002.html | 18 +++++ .../css/filter-effects/tainting-feoffset-001.html | 24 +++++++ .../css/filter-effects/tainting-feoffset-002.html | 18 +++++ .../tainting-fespecularlighting-001.html | 26 +++++++ .../tainting-fespecularlighting-002.html | 21 ++++++ .../tainting-fespecularlighting-003.html | 20 ++++++ .../css/filter-effects/tainting-fetile-001.html | 24 +++++++ .../css/filter-effects/tainting-fetile-002.html | 18 +++++ .../fast/canvas/canvas-filter-origin-clean.html | 79 ++++++++++----------- ...ect-reference-repaint-displacement-expected.txt | 2 +- ...ect-reference-repaint-displacement-expected.txt | 2 +- .../feDisplacementMap-filterUnits-expected.png | Bin 3352 -> 0 bytes .../feDisplacementMap-filterUnits-expected.svg | 9 +++ .../feDisplacementMap-negative-scale-expected.html | 2 +- 66 files changed, 799 insertions(+), 70 deletions(-) commit 468b222b5108c5abf64b093676084da7e9356bd3 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Thu Mar 7 12:57:48 2019 +0000 Contacts Picker: Show the origin (that will receive the contacts) in bold. Bug: 860467 Change-Id: Ifced401ce4b0fa34f3d3da6b69370fdb6952f4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506076 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638545} .../src/org/chromium/chrome/browser/contacts_picker/TopView.java | 8 ++++++-- chrome/android/java/strings/android_chrome_strings.grd | 2 +- .../chrome/browser/contacts_picker/ContactsPickerDialogTest.java | 2 +- 3 files changed, 8 insertions(+), 4 deletions(-) commit e1512ccca2a79b326a246787684c94262ff88d97 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 12:47:31 2019 +0000 Roll src/third_party/swiftshader 952d27384a7e..45faa0849352 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/952d27384a7e..45faa0849352 git log 952d27384a7e..45faa0849352 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com VKPipeline: Log any errors produced by the SPIR-V optimizer Created with: gclient setdep -r src/third_party/swiftshader@45faa0849352 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/127454276 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie9118f68c42152d1e26d5fc0e3b11c8ec2048158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507812 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638544} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dd20ec5572effa7fb28d2b6e68f370d3efeb13a9 Author: Stephen McGruer <smcgruer@chromium.org> Date: Thu Mar 7 12:41:54 2019 +0000 [Cleanup] Move PaintWorkletStylePropertyMap construction outside PaintWorkletInput PaintWorkletInput should not need to know how PaintWorkletStylePropertyMap is created. Bug: None Change-Id: I44cfe3819bcd305ca0ec077f6bd00e376eb59609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506653 Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638543} .../blink/renderer/core/css/cssom/paint_worklet_input.cc | 13 ++----------- .../blink/renderer/core/css/cssom/paint_worklet_input.h | 6 +----- .../core/css/cssom/paint_worklet_style_property_map_test.cc | 9 ++++++--- 3 files changed, 9 insertions(+), 19 deletions(-) commit 09204ccc1eaec4ff681ef946e44914c5eef40aee Author: Per Åhgren <peah@chromium.org> Date: Thu Mar 7 12:40:11 2019 +0000 Remove AEC2 usage and ensure that AEC3 is always run as WebRTC AEC AEC3 has now been launched to 100% via Finch and has fully replaced the legacy AEC. To make the launch complete this CL -Removes the finch experimentation code for controlling AEC3. -Removes the chrome flag for controlling AEC3. -Defaults all cases of Browser AEC (AEC2/AEC3 in the code) to use AEC3. What this CL does not do is to remove all the code that distinguishes between AEC3 and AEC2. That is intended for an upcoming CL and requires many more changes. An example of such a CL is available at https://chromium-review.googlesource.com/c/chromium/src/+/1495518 Bug: chromium:696930 Change-Id: Ia6a92a4e759d2319d2fa2d0f08936788645ab2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495528 Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Oskar Sundbom <ossu@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#638542} chrome/browser/about_flags.cc | 3 - chrome/browser/flag-metadata.json | 5 -- chrome/browser/flag_descriptions.cc | 4 -- chrome/browser/flag_descriptions.h | 3 - .../renderer_host/render_process_host_impl.cc | 1 - content/browser/utility_process_host.cc | 1 - content/public/common/content_features.cc | 6 -- content/public/common/content_features.h | 1 - .../media/stream/media_stream_audio_processor.cc | 34 +---------- .../media/stream/media_stream_audio_processor.h | 5 -- media/webrtc/BUILD.gn | 2 - media/webrtc/audio_processor.cc | 30 +++------- media/webrtc/audio_processor.h | 5 -- media/webrtc/echo_information.cc | 66 ---------------------- media/webrtc/echo_information.h | 48 ---------------- media/webrtc/webrtc_switches.cc | 8 --- media/webrtc/webrtc_switches.h | 1 - services/audio/input_controller.cc | 1 - testing/variations/fieldtrial_testing_config.json | 18 ------ 19 files changed, 10 insertions(+), 232 deletions(-) commit 9f0902de401cd0d3a255c3fcef20202b01b46f6a Author: Mario Sanchez Prada <mario@igalia.com> Date: Thu Mar 7 12:36:13 2019 +0000 Keep trailing newline for inline methods in headers for longhands CSS properties Don't use Jinja's trim_blocks feature right before the closing brace for the bodies of inline functions in generated header files for CSS properties, so that the closing braces for those functions' bodies are always placed in a new lines, in order to prevent build failures with empty bodies that are filled with one-line C++ comments. Bug: 937861, 919875 Change-Id: I156d6d0eed6413c3db6e5fc12ecca7fdaca14805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499516 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#638541} .../core/css/properties/templates/style_builder_functions.tmpl | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) commit 01639d66999a18e36711821d80b1f8cf5bf4e00c Author: Roman Sorokin <rsorokin@chromium.org> Date: Thu Mar 7 12:35:13 2019 +0000 Add placeholders for AuthNegotiateDelegateByKdcPolicy description Bug: 930019 Change-Id: I9c52bdfa4b458a1cee553d90518de880a72e4954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507632 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638540} components/policy/resources/policy_templates.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 01a1a3babebab5b66e1d7fb6737002a8d28206d1 Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Thu Mar 7 12:35:09 2019 +0000 Add a policy to the 'BrowserSwitcher' group The policy was not included in that group by mistake, which would make it harder to find in the ADMX templates. Change-Id: I6852208b73d812a9ea3c548f900625d0df323df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505995 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638539} components/policy/resources/policy_templates.json | 1 + 1 file changed, 1 insertion(+) commit ce420253498d82784ef13eeac68f24cb70e91757 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 12:32:16 2019 +0000 Roll src/third_party/skia 8e9850cc9584..4c1ea43a79b5 (1 commits) https://skia.googlesource.com/skia.git/+log/8e9850cc9584..4c1ea43a79b5 git log 8e9850cc9584..4c1ea43a79b5 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 952d27384a7e..45faa0849352 (1 commits) Created with: gclient setdep -r src/third_party/skia@4c1ea43a79b5 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I348e9abdba7b6c80be9dc93e68f23f2f3c7f8d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507934 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638538} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e62294ca103c400aa91c834eb9a952ad12841b49 Author: Peter Beverloo <peter@chromium.org> Date: Thu Mar 7 12:31:18 2019 +0000 Support color schemes in Chrome's custom tabs implementation This implements COLOR_SCHEME_LIGHT and COLOR_SCHEME_DARK support for custom tabs. Support for COLOR_SCHEME_SYSTEM, which will fall back to system settings, will be implemented in a follow-up CL. Bug: 937259 Change-Id: I7f7599eca596f3cd5323d73ed71981778587b88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499537 Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638537} DEPS | 2 +- .../chromium/chrome/browser/ChromeFeatureList.java | 1 + .../browser/customtabs/CustomTabActivity.java | 2 +- .../CustomTabNightModeStateController.java | 51 +++++++++++++++++----- .../preferences/ChromePreferenceManager.java | 6 +++ .../chrome/browser/util/FeatureUtilities.java | 34 +++++++++++++++ .../browser/customtabs/CustomTabActivityTest.java | 41 +++++++++++++++++ chrome/browser/android/chrome_feature_list.cc | 4 ++ chrome/browser/android/chrome_feature_list.h | 1 + 9 files changed, 129 insertions(+), 13 deletions(-) commit 05ab390afdfd3aa77f28e34ce406e487f4ba10fd Author: Roman Sorokin <rsorokin@chromium.org> Date: Thu Mar 7 12:26:38 2019 +0000 cros: Introduce LocalPolicyTestServerMixin Used to setup and work with LocalPolicyTestServer. Chrome OS tests are migrated. TBD: Enable disabled migrated tests Migrate Chrome tests when mixins are Chrome-wide Bug: 934224, 912704 Change-Id: I5fef3d20e3ec8dd23f6307139fab1fbc1517d3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495532 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#638536} .../arc/arc_session_manager_browsertest.cc | 25 +++----- .../chromeos/login/saml/saml_browsertest.cc | 27 +-------- .../login/test/local_policy_test_server_mixin.cc | 66 ++++++++++++++++++++++ .../login/test/local_policy_test_server_mixin.h | 44 +++++++++++++++ .../chromeos/login/webview_login_browsertest.cc | 20 +------ .../policy/device_cloud_policy_browsertest.cc | 50 ++++------------ .../policy/device_local_account_browsertest.cc | 35 +++--------- .../policy/device_policy_cros_browser_test.cc | 3 +- .../policy/device_policy_cros_browser_test.h | 6 +- ...rk_configuration_updater_factory_browsertest.cc | 25 +------- chrome/test/BUILD.gn | 2 + 11 files changed, 152 insertions(+), 151 deletions(-) commit ce9a71e20d5f01a3889646dc0043667841e6e6b2 Author: Alexander Hendrich <hendrich@chromium.org> Date: Thu Mar 7 12:24:45 2019 +0000 [ProtoSync] DMServer -> Client Syncing changes from CL https://critique.corp.google.com/#review/236764935 to the client. Reference: go/customer-logo-policy-one-pager Bug: none Change-Id: I31b1c06f6c8e7a7a780b5aa8216061ddb93afb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505509 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638535} components/policy/proto/device_management_backend.proto | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 0fab4f5fcfda3f46de40204b031b7b4850d5473f Author: Kent Tamura <tkent@chromium.org> Date: Thu Mar 7 12:22:58 2019 +0000 Fix a crash in IsMenulistInput(). Bug: 938867 Change-Id: I8c146af675d085d0784d5ff7c54670d0f6597c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507912 Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#638534} third_party/blink/renderer/core/paint/theme_painter.cc | 2 +- .../fast/forms/select/appearance-menulist-crash.html | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit 2929de501087a0739aec5bbbb3291de281f35ba1 Author: Stephane Zermatten <szermatt@chromium.org> Date: Thu Mar 7 12:22:36 2019 +0000 [Autofill Assistant] Fix to avoid overlay drawing on top of top bar. With this change, TouchEventFilterView sets a clip rectangle that avoids the top and bottom bars when drawing. This avoids ever drawing on top of either bars and is also more efficient than the previous implementation, which would draw then clear out some section. Additionally, it uses the top visible offset for drawing, instead of the top content offset. There's a difference of a few pixel, which is visible now because of the presence of the blue border. This change also address the CanvasSize lint warning and stops using canvas.getWidth(), as recommended. Bug: b/125245127 Change-Id: I0ced7df06f1ace285525f9b7328204cc79bbad3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505944 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#638533} .../overlay/TouchEventFilterView.java | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) commit 0db91fa222094e585a91d8a0c063a90866ae2b4e Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Thu Mar 7 12:19:19 2019 +0000 [Import Maps] implement "Packages" via trailing slashes This CL also implements "most-specific wins" rule. https://github.com/WICG/import-maps/issues/102 Bug: 928149 Change-Id: I484266086bbe244de8b43ceeddacc8552307b7f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475049 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#638532} .../blink/renderer/core/script/import_map.cc | 76 +++++++++++++++++++--- .../blink/renderer/core/script/import_map.h | 5 ++ .../import-maps/resolving.tentative-expected.txt | 3 +- .../wpt/import-maps/resources/resolving.js | 24 +++++++ 4 files changed, 98 insertions(+), 10 deletions(-) commit 85aee6c6d40a126a291f497289fe1c91c775d9c5 Author: Michael Hablich <hablich@chromium.org> Date: Thu Mar 7 12:19:13 2019 +0000 Revert "Adopt to new MicrotasksCompletedCallback signature" This reverts commit 1bda93b7333e2b623f66537b84b902432057a89d. Reason for revert: Blocks roll of V8 https://chromium-review.googlesource.com/c/chromium/src/+/1508095/1 Original change's description: > Adopt to new MicrotasksCompletedCallback signature > > V8 updated the signature of MicrotasksCompletedCallback to take a void > pointer user data, and is deprecating the old signature. > This CL updates its user to use the new one. > > Change-Id: I24990f68b2964fa80554689947746636958f59cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504660 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638471} TBR=peria@chromium.org,haraken@chromium.org,tzik@chromium.org Change-Id: I7a5134b417be5c8b2e189e30a488ce09929d5e6e No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507875 Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638531} third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b15eec0673fa4be1f495e2339d4e7c799d8c181b Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Mar 7 12:17:43 2019 +0000 [iOS][web] Group helpers for WebView This CL groups the helpers methods for WKNavigationDelegate and WebView. Bug: 938255 Change-Id: Ie8b2142ca16a0d3b07b0eb42bfe6d7046d914150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505507 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638530} ios/web/web_state/ui/crw_web_controller.mm | 3685 ++++++++++++++-------------- 1 file changed, 1810 insertions(+), 1875 deletions(-) commit 76939e5a856f2566ffdcaec3703abe3ceb6947c7 Author: Roman Aleksandrov <raleksandrov@google.com> Date: Thu Mar 7 12:13:46 2019 +0000 Hide Managed Guest Session notification Hide feature using feature flag. Bug: 927331 Change-Id: I76edb713c491c75d89484c345b763615c22133b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505948 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638529} chrome/browser/chromeos/login/existing_user_controller.cc | 5 ++++- chrome/common/chrome_features.cc | 9 +++++++++ chrome/common/chrome_features.h | 5 +++++ 3 files changed, 18 insertions(+), 1 deletion(-) commit 72fa81e73ce900fa0e140bfe7b30ce0f2706f0d0 Author: Gauthier Ambard <gambard@chromium.org> Date: Thu Mar 7 12:12:12 2019 +0000 [iOS][web] Merge CRWWebController methods This CL merge the -setWebView: method to its readonly property. It moves loadHTML: close to its public declaration as it is only here for testing purpose. It also remove +webControllerCanShow, putting its code in its call site. Bug: 938255 Change-Id: If8970a58a5eb99b8be5e67eb1006b088d0dd05d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505444 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638528} ios/web/web_state/ui/crw_web_controller.mm | 232 ++++++++++++++--------------- 1 file changed, 115 insertions(+), 117 deletions(-) commit b00d2a1b38e96eabf1841b6623cbe00b06002e34 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 12:06:09 2019 +0000 Roll src/third_party/perfetto df42f3b1d646..cc1308550f58 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/df42f3b1d646..cc1308550f58 git log df42f3b1d646..cc1308550f58 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 fmayer@google.com Merge "Use the SharedRingBuffer for sending payload from client to service." Created with: gclient setdep -r src/third_party/perfetto@cc1308550f58 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ifcf2991cd2029a304c91e7e010e9619a692b49f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507932 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638527} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 170a4a480a80b763d6cacd6631c6b7b764a9a2de Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 12:05:47 2019 +0000 Roll src-internal 8b3e27ce9a43..dcb547de1a5c (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b3e27ce9a43..dcb547de1a5c Created with: gclient setdep -r src-internal@dcb547de1a5c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I799aff9eb20a524fb27c6bcd74a719fb1304f70f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507933 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638526} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5ef0832ac1636bc764f8f33332e655d944246d83 Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Mar 7 11:56:47 2019 +0000 [iOS] Update case for "Sync is on"/"Sync is off" https://drive.google.com/open?id=1942lUZ9_kpjOzIvlrk0I9OBfYpa-pO8A https://drive.google.com/open?id=1atZHLclvCjd3xajAuJW7GCF5N4gtaTVX Bug: 939056 Change-Id: If9480112f5b1174ffa11de35e63f9c719d8fcd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506772 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#638525} ios/chrome/app/strings/ios_strings.grd | 4 ++-- .../IDS_IOS_SIGN_IN_TO_CHROME_SETTING_SYNC_OFF.png.sha1 | 1 + .../IDS_IOS_SIGN_IN_TO_CHROME_SETTING_SYNC_ON.png.sha1 | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) commit 7ec3f1488361f1095046fd5568b50cff7daa2321 Author: Jia <jiameng@chromium.org> Date: Thu Mar 7 11:56:21 2019 +0000 [On-device adaptive brightness] Remove the need of VerifyAlsConfig from AlsReaderImpl AlsReaderImpl previously checked number of ALS config steps to determine if a device should be supported. We now use ModelConfigLoader to load model config that will tell us if a device is supported, hence this cl removes config verification from AlsReaderImpl. Bug: 881215 Change-Id: I273a1b1b518970ae49632622acb25a8cfd69c5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505747 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638524} .../auto_screen_brightness/als_reader_impl.cc | 41 ---------------------- .../power/auto_screen_brightness/als_reader_impl.h | 3 -- .../als_reader_impl_unittest.cc | 7 ++-- 3 files changed, 2 insertions(+), 49 deletions(-) commit 6318b470f65573be71a1bae3550564e2716de90b Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Mar 7 11:39:33 2019 +0000 [iOS] Updating icons for Google sync services item Few last minute upates on the icon. Signed out: https://drive.google.com/open?id=1aZ0zKE8j04pqDtj7fHKOR_IRT421GXZg Sync error: https://drive.google.com/open?id=10ugnfgeh5wBT2mKweRSVA0UQ-z-_mdx_ Bug: 889470 Change-Id: Ie22e8af005729841a78517e733b55e4acedbe14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505451 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638523} ios/chrome/browser/ui/settings/resources/BUILD.gn | 1 - .../sync_and_google_services.imageset/Contents.json | 5 ----- .../sync_and_google_services.png | Bin 1127 -> 0 bytes .../sync_and_google_services@2x.png | Bin 2196 -> 1869 bytes .../sync_and_google_services@3x.png | Bin 3467 -> 2904 bytes .../sync_and_google_services_sync_error@2x.png | Bin 1793 -> 1869 bytes .../sync_and_google_services_sync_error@3x.png | Bin 2805 -> 2777 bytes 7 files changed, 6 deletions(-) commit 689d7721bbafcda6e390fba50781283a08b0ad50 Author: Arthur Hemery <ahemery@chromium.org> Date: Thu Mar 7 11:15:49 2019 +0000 Navigation: Making NavigationClient work with fallback content. A corner case was not supported yet with the NavigationClient, only running interface callbacks with FrameNavigationControl, which caused a connection DCHECK. Bug: 784904 Change-Id: I9dbec944b47584c737c14d4e604d999ca19d50c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503735 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638522} content/renderer/render_frame_impl.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 81881913348f434992e82d0c4d4e705b65e9a455 Author: Alexander Dunaev <adunaev@igalia.com> Date: Thu Mar 7 11:04:44 2019 +0000 [ozone/wayland] Fixed buffer handling in the WaylandCursor class. The visual shape of a pointer cursor is rendered at a surface attached to the wl_pointer object and backed by a wl_buffer. The WaylandCursor class tried to reuse the buffer regardless of whether the compositor released it, which resulted in that the cursor shape didn't change when a new bitmap had been submitted. This CL simplifies the process: a new buffer is created and attached each time the new bitmap is submitted, and the old ones are held until the compositor releases them. R=msisov@igalia.com Bug: 928260 Change-Id: I54cf679568276eddbd5c8042d05fe05de25f61d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503374 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#638521} ui/ozone/platform/wayland/BUILD.gn | 4 +- ui/ozone/platform/wayland/test/mock_pointer.cc | 32 +++++++++ ui/ozone/platform/wayland/test/mock_pointer.h | 36 ++++++++++ ui/ozone/platform/wayland/test/test_pointer.cc | 18 ----- ui/ozone/platform/wayland/test/test_pointer.h | 30 -------- ui/ozone/platform/wayland/test/test_seat.cc | 8 +-- ui/ozone/platform/wayland/test/test_seat.h | 8 +-- ui/ozone/platform/wayland/wayland_cursor.cc | 83 ++++++++++------------ ui/ozone/platform/wayland/wayland_cursor.h | 30 +++++--- ui/ozone/platform/wayland/wayland_pointer.cc | 3 +- ui/ozone/platform/wayland/wayland_pointer.h | 4 ++ .../platform/wayland/wayland_pointer_unittest.cc | 27 ++++++- .../platform/wayland/wayland_screen_unittest.cc | 4 +- .../platform/wayland/wayland_window_unittest.cc | 4 +- 14 files changed, 169 insertions(+), 122 deletions(-) commit 9797662f21ddf62bea7a240552265a884191167d Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 7 11:01:20 2019 +0000 Import wpt@553786e79703fe5bad735aefa5894ec26ccdf3c9 Using wpt-import in Chromium c71ea170bf230413b2e5bb0695ccba165c9e69b8. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 682affef9b "Implemented setPlaybackRate for scroll-linked Worklet Animations." 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" ab40da96c1 "Isolation: Remove isolation if we have non-svg replaced content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I8c9249b62d687e0aa8040e3fd65af9b65431ad75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507208 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638520} third_party/blink/web_tests/TestExpectations | 2 + .../web_tests/external/WPT_BASE_MANIFEST_5.json | 320 ++++++++++++----- .../external/wpt/2dcontext/tools/tests.yaml | 6 +- .../cross-origin-objects/cross-origin-objects.html | 392 +++++++++++++-------- .../cross-origin-objects/frame-with-then.html | 5 + .../origin/cross-origin-objects/frame.html | 4 + .../size.attributes.parse.whitespace.html | 8 +- .../size.attributes.setAttribute.whitespace.html | 8 +- .../web_tests/external/wpt/interfaces/webxr.idl | 1 + .../wpt/screen-orientation/onchange-event.html | 2 + .../external/wpt/tools/manifest/manifest.py | 3 +- .../web_tests/external/wpt/tools/manifest/vcs.py | 19 +- .../wpt/tools/wptrunner/wptrunner/metadata.py | 3 +- .../external/wpt/web-nfc/NFCReader-expected.txt | 6 + .../web-nfc/NFCReader-manual.https-expected.txt | 8 + .../wpt/web-nfc/NFCReader-manual.https.html | 64 ++++ .../web_tests/external/wpt/web-nfc/NFCReader.html | 39 ++ .../wpt/web-nfc/NFCWriter_push.https-expected.txt | 15 + ...c_push.https.html => NFCWriter_push.https.html} | 81 +++-- .../external/wpt/web-nfc/nfc_watch.https.html | 73 ---- 20 files changed, 705 insertions(+), 354 deletions(-) commit caa3d477103517e27f9110034afac5392b2c177d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 11:00:53 2019 +0000 Roll Fuchsia SDK from bb61479483bd to bccf58830632 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4499d87dd57a9c6f379328e5dd4246e5abfcb198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507695 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638519} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 65e2a49baf0f7c851b501132194961e7d8a6378b Author: Lowell Manners <lowell@chromium.org> Date: Thu Mar 7 10:53:51 2019 +0000 Update IdentityAccessorImplTest to use IdentityTestEnvironment more. This is part of a multi-step refactor to remove IndentityAccessor's dependencies on identity internals, replacing them with IdentityManager. Change-Id: Iaaf0e865a220e58f15e09167138b12a21ff2eec7 Bug: 933109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503580 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638518} .../identity/identity_accessor_impl_unittest.cc | 133 +++++++++------------ 1 file changed, 57 insertions(+), 76 deletions(-) commit ac43d1b76fb2e4d2c8557106df69918e13b8528b Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 10:47:29 2019 +0000 Roll src-internal 45209e43f286..8b3e27ce9a43 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/45209e43f286..8b3e27ce9a43 Created with: gclient setdep -r src-internal@8b3e27ce9a43 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=hkamila@chromium.org,robliao@chromium.org,etiennep@chromium.org Change-Id: I2cf34cf6afbef606e6e252c0f1bfb44a48f51424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506838 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638517} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8f21359921b146dedd92e054f9ac8aeff035a92f Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 7 10:44:46 2019 +0000 Update V8 to version 7.4.299. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a7a6252..aa2533a5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie56feb956f0de72af962b3349bf9e44ba1cb69b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507553 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638516} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b034d5b119abea01a9c18a0b628ab843b6fe3b3c Author: Marc Treib <treib@chromium.org> Date: Thu Mar 7 10:42:32 2019 +0000 Disable StopSyncInPausedState by default It turns out that this needs some more thought, see linked bugs. This also reverts SyncAuthTest.SyncPausedState back to its state from before https://crrev.com/c/1478878. Bug: 906995, 938819 Change-Id: I681c8568b4d31f83ca347b9d45bdd9ff40ed49f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507652 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638515} chrome/browser/sync/test/integration/sync_auth_test.cc | 14 ++++++-------- components/browser_sync/browser_sync_switches.cc | 3 +-- 2 files changed, 7 insertions(+), 10 deletions(-) commit b543c5d82e5254d870144ef859f3feaed4122de0 Author: Miyoung Shin <myid.shin@igalia.com> Date: Thu Mar 7 10:29:23 2019 +0000 Change [unsigned] long long to uint64_t in third_party/blink/ related blob - unsigned long long -> uint64_t - long long -> uint64_t for making the code consistency with the type of BlobDataHandle::size(). - Use std::numeric_limits instead of -1 - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: Icf66ee7d8a4199fe5ceaa5f9f776bfe315ce0bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506914 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638514} third_party/blink/public/platform/web_blob_info.h | 19 +++++++++++-------- third_party/blink/public/web/web_blob.h | 4 ++-- third_party/blink/renderer/core/exported/web_blob.cc | 4 ++-- .../renderer/core/fetch/blob_bytes_consumer_test.cc | 6 ++++-- .../renderer/core/fetch/bytes_consumer_tee_test.cc | 4 ++-- third_party/blink/renderer/core/fileapi/blob.cc | 8 ++++---- third_party/blink/renderer/core/fileapi/blob.h | 2 +- third_party/blink/renderer/core/fileapi/file.cc | 16 ++++++++-------- third_party/blink/renderer/core/fileapi/file.h | 2 +- third_party/blink/renderer/core/loader/ping_loader.cc | 14 +++++--------- .../blink/renderer/modules/filesystem/metadata.h | 4 ++-- .../renderer/modules/mediarecorder/media_recorder.cc | 2 +- .../modules/push_messaging/push_message_data.cc | 2 +- .../renderer/modules/websockets/dom_websocket.cc | 2 +- third_party/blink/renderer/platform/blob/blob_data.h | 2 +- .../blink/renderer/platform/exported/web_blob_info.cc | 13 +++++++------ .../renderer/platform/network/encoded_form_data.cc | 2 +- .../renderer/platform/network/encoded_form_data.h | 2 +- 18 files changed, 55 insertions(+), 53 deletions(-) commit c4ff2c2184bab1e7c3e9d032f4c41025eea06783 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 10:26:53 2019 +0000 Roll src/third_party/skia 52e620ffd0bd..8e9850cc9584 (1 commits) https://skia.googlesource.com/skia.git/+log/52e620ffd0bd..8e9850cc9584 git log 52e620ffd0bd..8e9850cc9584 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2995dc2a67c7..952d27384a7e (1 commits) Created with: gclient setdep -r src/third_party/skia@8e9850cc9584 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I69508603ee3c302d6ab235390f2e06902665429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507692 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638513} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2b40cf253074ad353eed6dd90820ec6e3a654230 Author: John Budorick <jbudorick@chromium.org> Date: Thu Mar 7 10:25:04 2019 +0000 Disable each CLIHelpersUnittest individually. Bug: 938487 No-Try: true Change-Id: I887735faee58cfe04e74359107ed4ab8d15a8ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507196 Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#638512} tools/perf/core/cli_helpers_unittest.py | 32 ++++++++++++++++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-) commit 704e476bcdcea4ced855036977226a6c06c1f02a Author: Leo Zhang <googleo@chromium.org> Date: Thu Mar 7 10:24:42 2019 +0000 Definde the interfaces between IME shared library and its caller. These interfaces is used to load shared library and base classes dynamically into the IME Mojo service at runtime. Bug: 837156 Change-Id: I6da2aba6227ecb0ac91c552783ddf0c6c56e25c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478651 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Leo Zhang <googleo@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638511} chromeos/services/ime/BUILD.gn | 1 + .../services/ime/public/cpp/shared_lib/BUILD.gn | 9 ++ .../ime/public/cpp/shared_lib/interfaces.h | 162 +++++++++++++++++++++ 3 files changed, 172 insertions(+) commit d0c6c215f0bf039db72e5b626199da58ded70c13 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 10:21:41 2019 +0000 Roll src/third_party/swiftshader 2995dc2a67c7..952d27384a7e (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/2995dc2a67c7..952d27384a7e git log 2995dc2a67c7..952d27384a7e --date=short --no-merges --format='%ad %ae %s' 2019-03-07 bclayton@google.com Fix windows build Created with: gclient setdep -r src/third_party/swiftshader@952d27384a7e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ic130cdd215a1cbdb3c42eaefe788318b7ca166c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506644 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638510} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6a5c2a13600edb69e4e841f19e32f4fbf799a903 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Thu Mar 7 10:12:37 2019 +0000 [Layered API] Add UseCounters for each individual modules Bug: 829084 Change-Id: I699e5e8ac655f1b305fff5985a107d29f2200fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506825 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#638509} .../public/mojom/web_feature/web_feature.mojom | 2 ++ .../blink/renderer/core/script/layered_api.cc | 21 ++++++++++++++------- third_party/blink/renderer/core/script/modulator.h | 1 + .../renderer/core/script/modulator_impl_base.cc | 18 ++++++++++++++++++ .../renderer/core/script/modulator_impl_base.h | 1 + .../blink/renderer/core/testing/dummy_modulator.cc | 2 ++ .../blink/renderer/core/testing/dummy_modulator.h | 1 + tools/metrics/histograms/enums.xml | 2 ++ 8 files changed, 41 insertions(+), 7 deletions(-) commit 252946430b3ce9b9aed71630cd7b65a8d010131a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Mar 7 10:05:57 2019 +0000 Remove reference to fixed bug Bug: 936211 Change-Id: If7bef8b0cd9256c961102773478a4afd6da7887c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505510 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638508} build/config/compiler/BUILD.gn | 1 - 1 file changed, 1 deletion(-) commit 1ae73afd05d9393c2e5de17ebc12c2219227a182 Author: Anton Permyakov <tonynasta@yandex-team.ru> Date: Thu Mar 7 10:05:43 2019 +0000 Fixes accelerator shortcut text for unknown keys For unknown key codes presenting in an accelerator 0 is added to the shortcut text. This results in unprintable character to be used on extensions shortcuts settings page. Bug: 936812 Change-Id: I5301660d8110defd908146862a230666af09a07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497072 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#638507} ui/base/accelerators/accelerator.cc | 5 ++++- ui/base/accelerators/accelerator_unittest.cc | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) commit d11651f18ad1fb5bb36a30c53346f073b0e1d704 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 10:04:28 2019 +0000 Roll src/third_party/glslang/src 79d25ea0ce18..40c16ec0b3ad (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/79d25ea0ce18..40c16ec0b3ad git log 79d25ea0ce18..40c16ec0b3ad --date=short --no-merges --format='%ad %ae %s' 2019-03-07 johnkslang@users.noreply.github.com Merge pull request #1717 from jeffbolznv/getBufferReferenceAlignment 2019-03-07 johnkslang@users.noreply.github.com Merge pull request #1716 from jeffbolznv/buffer_reference_fold2 Created with: gclient setdep -r src/third_party/glslang/src@40c16ec0b3ad The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ibc2f1c00445188fe66ed46e4cf259dc9853ce850 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506666 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638506} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4205483be61bb944388a3467aca01158db18f922 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Thu Mar 7 09:59:45 2019 +0000 BlinkMemoryMgt: Annotate Blink's platform/weborigin with the macros of Allocator As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/weborigin with the macros of Allocator. After some analyzes, it was concluded that for the case of ReportingServiceProxyPtrHolder, URLSchemesRegistry, and SecurityOrigin classes, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. Bug: 919389 Change-Id: Ibff778b830c479908df8ba454e289f8d604b365a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506057 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#638505} .../renderer/platform/weborigin/reporting_service_proxy_ptr_holder.h | 3 +++ third_party/blink/renderer/platform/weborigin/scheme_registry.cc | 3 +++ third_party/blink/renderer/platform/weborigin/security_origin.h | 3 +++ 3 files changed, 9 insertions(+) commit 38912888447f8cb8b1ed37e2348bc411783ded4c Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Mar 7 09:57:12 2019 +0000 Convert away from method JSONReader::ReadAndReturnErrorDeprecated Replace usage to instead use JSONReader::ReadAndReturnValueWithError that returns a base::JSONReader::ValueWithError. Bug: 925165 Change-Id: Ifdcc83a2612e4baed32d8c133dbb2f2b2c8640e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505632 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638504} ios/web/navigation/wk_navigation_util_unittest.mm | 61 ++++++++++++----------- 1 file changed, 31 insertions(+), 30 deletions(-) commit 7a2193ec6040fdbad3b5de413730a7d316a85f60 Author: Ioana Pandele <ioanap@chromium.org> Date: Thu Mar 7 09:56:22 2019 +0000 [GPWM Android]Move Google Password Manager feature check This ensures that the feature check is performed only if all prerequisites for the feature are met. Bug: 903249 Change-Id: I0af5bbecff66e2c660b4d6b89cf64dc92fc8d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499517 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#638503} .../org/chromium/chrome/browser/preferences/PreferencesLauncher.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b07f26ba6abfa8dd6f9d7379a5efd4d2442a2205 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 09:55:33 2019 +0000 Synchronize displayed notifications. This properly implements notification sync with the currently displayed notifications if supported by the platform. Bug: 891339 Change-Id: I467931abb54af94dc53f3981492487e5818a45f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505633 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638502} .../browser/notifications/notification_database.cc | 25 +++++++++- .../browser/notifications/notification_database.h | 19 +++++-- .../platform_notification_context_impl.cc | 58 +++++++++++++--------- .../platform_notification_context_impl.h | 14 ++++-- .../platform_notification_context_unittest.cc | 8 +-- 5 files changed, 90 insertions(+), 34 deletions(-) commit 5ae4f55ffadb88f6d6128c2dad6f3cbb04ecc07f Author: Kazuki Takise <takise@chromium.org> Date: Thu Mar 7 09:50:54 2019 +0000 Activate PIP window after it is expanded Android tells Chrome to activate windows through onTaskMovedToFront, which is called by ActivityStack#moveTaskToFront. For PIP tasks, we reparent them with reparent() and the function inserts them on top without using moveTaskToFront, so we seem to activate them explicitly. confirmed the browser was properly activated. Bug: b/123259430 Test: Exited PIP, pressed the shelf icon of the browser, and Test: atest android.server.am.ActivityManagerPinnedStackTests Change-Id: I7532e4b2c66a28b83168abcf3207266961c9a3a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485625 Commit-Queue: Kazuki Takise <takise@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#638501} components/exo/client_controlled_shell_surface.cc | 9 +++++++++ 1 file changed, 9 insertions(+) commit 2e136efb6a947b83ba6f753fd893d766d2556c49 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 7 09:45:11 2019 +0000 Store Trigger and NotificationResources in NotificationDatabase. This is required for the first version of Notification Triggers until we support scheduling notifications and storing the data in a more general way. Bug: 891339 Change-Id: I614c7279a3a065d6c261ea96d12b6d866f2db6a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472695 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638500} content/browser/BUILD.gn | 4 +- content/browser/notifications/BUILD.gn | 1 + .../blink_notification_service_impl.cc | 36 ++++- .../blink_notification_service_impl_unittest.cc | 147 +++++++++++++++++++++ .../browser/notifications/notification_database.cc | 96 ++++++++++++-- .../browser/notifications/notification_database.h | 12 ++ ...ons.cc => notification_database_conversions.cc} | 132 +++++++++++++++++- .../notification_database_conversions.h | 47 +++++++ ... notification_database_conversions_unittest.cc} | 134 ++++++++++++++++++- .../notifications/notification_database_data.proto | 10 +- .../notification_database_data_conversions.h | 30 ----- .../notification_database_resources.proto | 21 +++ .../notification_database_unittest.cc | 119 +++++++++++++++++ .../browser/notifications/notification_storage.cc | 2 +- .../platform_notification_context_impl.cc | 50 +++++++ .../platform_notification_context_impl.h | 11 ++ .../public/browser/notification_database_data.h | 9 ++ .../public/browser/platform_notification_context.h | 16 +++ content/test/BUILD.gn | 2 +- .../instrumentation-service-worker.js | 17 ++- .../serviceworker-notification-properties.html | 34 ++++- ...tration-service-worker-get-filter-triggers.html | 113 ++++++++++++++++ 22 files changed, 970 insertions(+), 73 deletions(-) commit 0546998c290ea65c50475c25589d7176da84a009 Author: Jia <jiameng@chromium.org> Date: Thu Mar 7 09:43:51 2019 +0000 [On-device adaptive brightness] Integrate ModelConfigLoader with Adapter This cl contains the following changes 1. Use ModelConfigLoader to provide Adapter with some params. 2. Simplify params used by Adapter. The major changes are (i). We now change brightness as soon as average ambient light changes by more than a threshold. (ii). The ambient threshold is now an absolute value and not a ratio. It is also measured in the log space. 3. Log metrics explicitly for Atlas and Eve Bug: 881215 Change-Id: I45486e4e2cb12083c763a2f0db8b0efd077695af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501895 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#638499} .../power/auto_screen_brightness/adapter.cc | 211 ++++-------- .../power/auto_screen_brightness/adapter.h | 106 +++--- .../auto_screen_brightness/adapter_unittest.cc | 382 ++++++++++----------- .../power/auto_screen_brightness/controller.cc | 3 +- .../auto_screen_brightness/metrics_reporter.cc | 26 +- .../auto_screen_brightness/metrics_reporter.h | 13 +- .../metrics_reporter_unittest.cc | 41 ++- chrome/common/pref_names.cc | 4 + chrome/common/pref_names.h | 2 + tools/metrics/histograms/histograms.xml | 29 ++ 10 files changed, 407 insertions(+), 410 deletions(-) commit 1f45ded8cc31680d35df13e9a7e1566996264f91 Author: Andrew MacPherson <andrew.macpherson@soundtrap.com> Date: Thu Mar 7 09:32:05 2019 +0000 Add support for AudioContextOptions sampleRate Optional sampleRate parameter to AudioContextOptions, if provided then the AudioContext will run at this sampleRate, otherwise it will run at the hardware rate. Running the AudioContext at a lower sample rate can allow running a heavier graph on low-end devices, for example if a given device is able to run with X nodes at a sample rate of 48k, it can support roughly 2X nodes at 24k or 4X nodes at 12k. Bug: 432248 Change-Id: I835f28b4625763bd6a6ddbee9b89636ef8a8a066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482957 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Andrew MacPherson <andrew.macpherson@soundtrap.com> Cr-Commit-Position: refs/heads/master@{#638498} .../renderer/modules/webaudio/audio_context.cc | 15 ++- .../renderer/modules/webaudio/audio_context.h | 4 +- .../modules/webaudio/audio_context_options.idl | 1 + .../webaudio/realtime_audio_destination_node.cc | 32 +++--- .../webaudio/realtime_audio_destination_node.h | 17 +++- third_party/blink/renderer/platform/BUILD.gn | 3 + third_party/blink/renderer/platform/audio/DEPS | 2 + .../renderer/platform/audio/audio_destination.cc | 68 +++++++++---- .../renderer/platform/audio/audio_destination.h | 26 ++++- .../platform/audio/audio_destination_test.cc | 109 +++++++++++++++++++++ .../audio/media_multi_channel_resampler.cc | 44 +++++++++ .../platform/audio/media_multi_channel_resampler.h | 65 ++++++++++++ .../audiocontextoptions.html | 39 ++++++++ 13 files changed, 380 insertions(+), 45 deletions(-) commit 895b326577270e7fd3d82e42e90e066bc865288f Author: danakj <danakj@chromium.org> Date: Thu Mar 7 09:31:26 2019 +0000 Set the WebViewPlugin::WebViewHelper as the WebWidgetClient. WebViewHelper is a WebWidgetClient even though WebViewPlugin's WebView is not composited. So set it up as the WebWidgetClient after attaching the main frame. R=dcheng@chromium.org, tommycli@chromium.org Bug: 920952, 912193 Change-Id: I8391bde1d0452cf78d23a8b855a45497bac02d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504142 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#638497} components/plugins/renderer/webview_plugin.cc | 5 +++++ third_party/blink/public/web/web_view.h | 8 ++++---- third_party/blink/renderer/core/exported/web_view_impl.cc | 7 ++++--- 3 files changed, 13 insertions(+), 7 deletions(-) commit db5d56fedb6496bdb1f6bc09bfd21f7c6e32f29f Author: Andrew Moylan <amoylan@chromium.org> Date: Thu Mar 7 09:26:51 2019 +0000 Add new values to SmartDimModelResult enum These were added in http://crrev.com/c/1352824 (model_impl.h) but we didn't add them to enum.xml yet. Bug: 933200 Change-Id: If18be5107be2124797f72f0f290c0666e61a3c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496122 Reviewed-by: Jia Meng <jiameng@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638496} tools/metrics/histograms/enums.xml | 7 +++++++ 1 file changed, 7 insertions(+) commit 2def4cc965a76cb8ee5bc85496d96f6c5a103095 Author: vitaliii <vitaliii@chromium.org> Date: Thu Mar 7 09:24:47 2019 +0000 [Sync::Scrypt] Enable Scrypt encryption by default. Enable using Scrypt to derive the key when encrypting data with a new custom passphrase in Chrome Sync (starting from M74). I manually tested the functionality locally. We have a kill switch, which we can use if we decide not to launch in M73/M74. Bug: 875901 Change-Id: I37dee9a66e0f519e963a6b3a13887c3bf8b2e049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497141 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#638495} components/sync/engine/sync_engine_switches.cc | 2 +- .../sync_encryption_handler_impl_unittest.cc | 26 ++++++++++++---------- 2 files changed, 15 insertions(+), 13 deletions(-) commit dd873dcc1f224dafd8fd5a332280a196725969ba Author: Miyoung Shin <myid.shin@igalia.com> Date: Thu Mar 7 09:23:59 2019 +0000 Change [unsigned] long long to uint64_t in third_party/blink/renderer/core/timing - unsigned long long / long long -> uint64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I24e97b5d2c3068e092d2f40a45920991468a06bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507294 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638494} .../blink/renderer/core/exported/web_frame_test.cc | 2 +- .../renderer/core/exported/web_performance.cc | 2 +- .../core/timing/performance_navigation_timing.cc | 6 +- .../core/timing/performance_navigation_timing.h | 6 +- .../core/timing/performance_resource_timing.cc | 12 +-- .../core/timing/performance_resource_timing.h | 18 ++-- .../renderer/core/timing/performance_timing.cc | 100 ++++++++++----------- .../renderer/core/timing/performance_timing.h | 93 ++++++++++--------- .../renderer/core/timing/performance_user_timing.h | 3 +- .../renderer/modules/service_worker/fetch_event.cc | 3 +- .../platform/loader/fetch/resource_fetcher_test.cc | 4 +- .../platform/loader/fetch/resource_timing_info.h | 6 +- 12 files changed, 126 insertions(+), 129 deletions(-) commit 8f39f6d98d4f3b223736b05aef7ae1b86d8b41a3 Author: Kamila Hasanbega <hkamila@chromium.org> Date: Thu Mar 7 09:20:31 2019 +0000 Revert "pdf: Switch to the threaded version of ink" This reverts commit 99d553b36101f7d2ab0c6a02433a39114f7cbf7c. Reason for revert: This has likely caused failing tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11228 Original change's description: > pdf: Switch to the threaded version of ink > > Updates the resource manager to not require a mime type when loading > a bundled resource. This is the same as the behavior in [1]. > > [1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340 > > Bug: 902646 > Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194 > Commit-Queue: dstockwell <dstockwell@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638324} TBR=thestig@chromium.org,dstockwell@chromium.org,rdevlin.cronin@chromium.org Change-Id: I9ed4732eb289e9f8e0d1712ea7e03e46dbba032b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507712 Reviewed-by: Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#638493} .../extensions/chrome_component_extension_resource_manager.cc | 2 -- chrome/browser/extensions/chrome_url_request_util.cc | 4 ++++ third_party/ink/ink_resources.grd | 6 ++---- 3 files changed, 6 insertions(+), 6 deletions(-) commit 8b6633693ee341ccfd1ca01c6a5f6c0555d32e5d Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Thu Mar 7 09:20:01 2019 +0000 [Sync:USS] Fix flaky MC_MergeSimpleBMHierarchyEqualSetsUnderBMBar Enable Sync on clients one at a time in order to avoid race conditions. Bug: 919877 Change-Id: Ic8820cf33c9deb9cae3fbf24df0d2e1846d36cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506083 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638492} .../integration/two_client_bookmarks_sync_test.cc | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) commit 25e941ab9378b6e560156c675f793d28790aad41 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Thu Mar 7 09:17:27 2019 +0000 Remove TouchEventDispatchResultType. TouchEventDispatchResultType is unused, remove it. Change-Id: I9f3e49d5d9599dd5448bc54c2b9c71602b1cc325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506917 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#638491} third_party/blink/renderer/core/input/touch_event_manager.cc | 6 ------ 1 file changed, 6 deletions(-) commit 5fde1fc290b93fa02dd051164b934f448231cee5 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Thu Mar 7 09:16:36 2019 +0000 BlinkMemoryMgt: Annotate Blink's platform/text with the macros of Allocator As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/text with the macros of Allocator. After some analyzes, it was concluded that for the case of LayoutLocale class, it makes sense to use USING_FAST_MALLOC because it has been used as a member variable with new() or smart pointers. In WebEntities class, it makes sense to use DISALLOW_NEW because it's used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: Icf692c5541746e1b3d93662cdc951070d092b4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506677 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#638490} third_party/blink/renderer/platform/text/layout_locale.h | 3 +++ third_party/blink/renderer/platform/text/web_entities.h | 3 +++ third_party/blink/renderer/platform/text/writing_mode_utils_test.cc | 5 +++++ 3 files changed, 11 insertions(+) commit b0992a68fe52b0ffda0b23c905be164a74c662f2 Author: Haojian Wu <hokein.wu@gmail.com> Date: Thu Mar 7 09:16:01 2019 +0000 Stop writing json compilation databaase to one line. The CDB for chromium is huge (~200MB), emitting into one line will make editors freezing when opening it. Change-Id: I85a09485104fd7c9c6c1b426178d9823bdfba543 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505508 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Haojian Wu <hokein.wu@gmail.com> Cr-Commit-Position: refs/heads/master@{#638489} tools/clang/scripts/generate_compdb.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 4cc0aa67881ad05a755f2280d0c5eee25f412127 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 09:15:31 2019 +0000 Roll src/third_party/skia 692122e3ef23..52e620ffd0bd (1 commits) https://skia.googlesource.com/skia.git/+log/692122e3ef23..52e620ffd0bd git log 692122e3ef23..52e620ffd0bd --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@52e620ffd0bd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I1e30b7b627af860b205dde01cb9b28746c773b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506645 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638488} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ae3e5b3e9931dc48fb5072c971a9df66bc5fe0ca Author: Colin Blundell <blundell@chromium.org> Date: Thu Mar 7 09:14:53 2019 +0000 Eliminate FakePO2TS usage in SigninManager unittest The SigninManager unittest is the one test that uses FakeProfileOAuth2TokenService outside of either IdentityTestEnvironment or IdentityManager and friends. However, it doesn't need to, as it doesn't use any of the heavy functionality that FakePO2TS exposes. This CL changes it to use ProfileOAuth2TokenService, clarifying the actual usage of FakePO2TS in the codebase. Bug: 938823 Change-Id: I2fdea1b4c073be2488a9aae10fb7c2fb5b773766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505452 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638487} .../signin/core/browser/fake_profile_oauth2_token_service.cc | 6 ------ components/signin/core/browser/fake_profile_oauth2_token_service.h | 4 ---- components/signin/core/browser/profile_oauth2_token_service.h | 6 ++++++ components/signin/core/browser/signin_manager_unittest.cc | 7 ++++--- 4 files changed, 10 insertions(+), 13 deletions(-) commit 3fb995dbe28c8127d2db96bcab88c94077cee306 Author: Kazuki Takise <takise@chromium.org> Date: Thu Mar 7 09:08:15 2019 +0000 Don't allow backdrop container to be reparented. Currently, the backdrop window in AlwaysOnTopContainer is not set as always on top, which causes the window to be reparented to DefaultContainer when SetFullscreen is called for it (as OnPreWindowStateTypeChange is added to AOTController in [1].) This is causing the crash of the browser process when a window exits PIP. To prevent this, this CL sets a new property to backdrop windows so that they won't be reparented to another window. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1447991 Bug: b/124699190 Test: Confirmed exiting PIP didn't cause crash Change-Id: I4f2729e949bfcfd7bcb1b5e2ca623109ad5d7501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482100 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Kazuki Takise <takise@chromium.org> Cr-Commit-Position: refs/heads/master@{#638486} ash/wm/always_on_top_controller.cc | 9 ++++++- ash/wm/always_on_top_controller.h | 2 ++ ash/wm/workspace/backdrop_controller.cc | 4 +++ .../workspace/workspace_layout_manager_unittest.cc | 30 ++++++++++++++++++++++ 4 files changed, 44 insertions(+), 1 deletion(-) commit abe5c756f349fbc977526b699df3e020bfe9e541 Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Mar 7 09:06:44 2019 +0000 sqlite: Backport bugfixes for clusterfuzz security bugs - security bugs were for integer overflow and heap-buffer overflow. Bug: 925656, 932353, 925381 Change-Id: Ibda5a20302153b7ede3a5b89a7bcea622fded869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504333 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638485} third_party/sqlite/amalgamation/sqlite3.c | 20 +++++++---- ...Modify-default-VFS-to-support-WebDatabase.patch | 4 +-- ...le-supporting-recovery-of-corrupted-datab.patch | 5 +-- ...ell.c-helpers-to-load-Chromium-s-ICU-data.patch | 4 +-- ...0004-fts3-Disable-fts3_tokenizer-and-fts4.patch | 4 +-- ...5-fuchsia-Use-dot-file-locking-for-sqlite.patch | 4 +-- ...x-compilation-with-SQLITE_OMIT_WINDOWFUNC.patch | 4 +-- ...x-dbfuzz2.c-compilation-errors-on-Windows.patch | 4 +-- ...p-buffer-overflow-in-vdbeRecordCompareInt.patch | 28 +++++++++++++++ ...9-fix-heap-buffer-overflow-in-cellsizeptr.patch | 36 +++++++++++++++++++ .../0010-fix-integer-overflow-in-checkList.patch | 41 ++++++++++++++++++++++ third_party/sqlite/src/src/btree.c | 8 ++--- third_party/sqlite/src/src/pager.c | 10 ++++-- 13 files changed, 145 insertions(+), 27 deletions(-) commit 852588a572375eff5ffbb25d1bbd739a56835078 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Mar 7 09:04:42 2019 +0000 Remove bad DCHECK. I was hitting this every time an image had an error. TBR=nektar@chromium.org Bug: 905419 Change-Id: Iabcb0eff62369972c07aef952fa6345422b761ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507256 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638484} content/renderer/accessibility/ax_image_annotator.h | 1 - 1 file changed, 1 deletion(-) commit 2a95c96b5878b2ea53dfe6aee90f37cbdce25751 Author: Yuichiro Hanada <yhanada@google.com> Date: Thu Mar 7 09:03:50 2019 +0000 Consolidate login keyboard layouts information into input_methods.txt. kLoginLayoutWhitelist has a list of xkb layout ids that are allowed to be used on login screen. However, the same information is already in //chromeos/ime/input_methods.txt. This CL removes the array and use the infomation in input_methods.txt instead. There is a slight diff between kLoginLayoutWhitelist and input_methods.txt. - 'fr' is only in kLoginLayoutWhitelist and xkb_manifest.json uses it. I updated xkb_manifest.json to use 'fr(oss)'. - 'ro(std)' and 'ga' is specified as login layouts in input_methods.txt, but not in kLoginLayoutWhitelist. They are considered as login layout after this CL. Bug: None Change-Id: Ic88846555310e3c534e64dd195bd47aa80befa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490986 Reviewed-by: Shu Chen <shuchen@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#638483} .../chromeos/input_method/xkb_manifest.json | 2 +- ui/base/ime/BUILD.gn | 1 + .../chromeos/component_extension_ime_manager.cc | 56 ++-------------------- 3 files changed, 6 insertions(+), 53 deletions(-) commit f50a50a7e6c719735ab52e123fc898309b16e971 Author: Marc Treib <treib@chromium.org> Date: Thu Mar 7 09:03:05 2019 +0000 Remove SyncService::TransportState::WAITING_FOR_START_REQUEST After https://crrev.com/c/1430089, this state is not meaningful anymore. Yay, one less! Semi-relatedly, this CL also moves some NotifyObservers() calls, to avoid notifying while we're in an intermediate (and thus potentially invalid) state. Bug: 839834, 935908 Change-Id: I6093ba3bd44452990ba9b0b8926b3c6e308c90ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481418 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638482} chrome/browser/ui/webui/settings/people_handler_unittest.cc | 4 ++-- components/browser_sync/profile_sync_service.cc | 13 ++++++++----- .../browser_sync/profile_sync_service_startup_unittest.cc | 6 ++---- components/sync/driver/about_sync_util.cc | 2 -- components/sync/driver/sync_service.cc | 2 -- components/sync/driver/sync_service.h | 9 --------- components/sync/driver/sync_service_utils.cc | 1 - components/sync/driver/sync_service_utils_unittest.cc | 4 ++-- 8 files changed, 14 insertions(+), 27 deletions(-) commit 82c0cea0fa920c7ad288b9abb2e39252ad7ed2b7 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Mar 7 09:02:24 2019 +0000 Remove non-servicified service worker path from NavigationURLLoaderImpl. The non-servicified path is no longer supported. Bug: 926114 Change-Id: I0fa7058c73fb185f15bc00ff62d494cefb7ece45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506064 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638481} .../browser/loader/navigation_url_loader_impl.cc | 73 +++------------------- 1 file changed, 8 insertions(+), 65 deletions(-) commit daa9bba62a07f49d619f054943ccf569eaf3d281 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 08:45:33 2019 +0000 Roll src/third_party/depot_tools 48f640f5365e..ffb1ffb82284 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/48f640f5365e..ffb1ffb82284 git log 48f640f5365e..ffb1ffb82284 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@ffb1ffb82284 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ic67fa50d7eb1c449dc5769cf94d27b181e432568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506207 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638480} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c71ea170bf230413b2e5bb0695ccba165c9e69b8 Author: Zinovy Nis <zynis@yandex-team.ru> Date: Thu Mar 7 08:43:16 2019 +0000 [clang-tidy] Make DecodedDrawImage moveable to utilize std::move in ImageProvider. cc/paint/image_provider.cc:14:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(image)) {} ^~~~~~~~~~ ~ cc/paint/image_provider.cc:18:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(image)), destruction_callback_(std::move(callback)) {} ^~~~~~~~~~ ~ cc/paint/image_provider.cc:27:14: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] : image_(std::move(other.image_)), ^~~~~~~~~~ ~ cc/paint/image_provider.cc:37:12: warning: passing result of std::move() as a const reference argument; no move will actually happen [hicpp-move-const-arg] image_ = std::move(other.image_); ^~~~~~~~~~ ~ Change-Id: I2c3d49f7833ea117ef1b6aec4cf9037d19cb7c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489751 Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#638479} cc/paint/decoded_draw_image.cc | 6 +++++- cc/paint/decoded_draw_image.h | 4 ++++ cc/tiles/gpu_image_decode_cache_unittest.cc | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) commit 6e5c42985b3d00864950e45b8869d5bf952f4ef5 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Mar 7 08:41:36 2019 +0000 Remove interceptor disabled path from NavigationURLLoaderImpl. ServiceWorkerServicification is always enabled now, so loader interceptors are always enabled. Bug: 926114 Change-Id: I77855393a475da5636c7c855d6456b6819cd3e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506062 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638478} .../browser/loader/navigation_url_loader_impl.cc | 80 ++++++++-------------- 1 file changed, 28 insertions(+), 52 deletions(-) commit 08377ef050c6a5b8185f5deef9001edd5c1aaf6f Author: Yann Dago <ydago@chromium.org> Date: Thu Mar 7 08:39:18 2019 +0000 Management WebUI: Apply card like style to each section Each section of the chrome://management page should look like each section of the settings page Visual of management page: http://screen/CQ335FkdT5a ChromeOS: http://screen/tZofcxLpJ6B Visual of settings page: http://screen/pYsjEZuRsVr Bug: 938995 Change-Id: I50f150081b1ca24d02be9aea2b2ee668965f53fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506499 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#638477} .../resources/management/management_ui.html | 168 ++++++++++----------- .../settings/internet_page/internet_subpage.html | 3 +- .../internet_page/tether_connection_dialog.html | 9 +- .../settings/settings_page/settings_section.html | 13 +- .../resources/settings/settings_vars_css.html | 2 - .../resources/cr_elements/shared_vars_css.html | 13 +- 6 files changed, 100 insertions(+), 108 deletions(-) commit 35ad74f16ea2aae850138d9354fd939355ac50a7 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Thu Mar 7 08:38:05 2019 +0000 Mojofy RenderFrameImpl::JavaScriptExecuteRequest* This CL refactors FrameMsg_JavaScriptExecuteRequest* and FrameHostMsg_JavaScriptExecuteResponse from being a legacy IPC message into a method on mojom::Frame and mojom::FrameHost. This is necessary for bfcache where JavaScript must not be executed on per-thread task runners. While legacy IPC processes messages on a per-thread (default) task runner, Mojo can dispatch on a per-frame task runner. Bug: 870606 Change-Id: Ie655dc6f594568f70efd3f030e9d49257c64cc2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488405 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638476} .../chrome/browser/JavaScriptEvalChromeTest.java | 13 +++-- content/browser/devtools/devtools_stream_blob.cc | 2 +- .../browser/frame_host/render_frame_host_impl.cc | 52 ++++++++---------- .../browser/frame_host/render_frame_host_impl.h | 6 +-- content/common/frame.mojom | 38 ++++++++++++++ content/common/frame_messages.h | 39 -------------- .../browser/webcontents/WebContentsImpl.java | 2 + content/renderer/render_frame_impl.cc | 61 +++++++++------------- content/renderer/render_frame_impl.h | 25 +++++---- content/test/test_render_frame.cc | 2 + 10 files changed, 110 insertions(+), 130 deletions(-) commit 8d48028736c8fca676443b6ceb877108fe188436 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 08:27:25 2019 +0000 Roll src-internal b9c4c2512141..45209e43f286 (17 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9c4c2512141..45209e43f286 Created with: gclient setdep -r src-internal@45209e43f286 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:934623,chromium:790705 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I8eac98e38a3350282c1334764876a6a8fb4fab78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506643 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638475} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1230640cf925e08115f98820f1d316e463fb7191 Author: Maggie Cai <mxcai@chromium.org> Date: Thu Mar 7 08:22:48 2019 +0000 Settings: Show and allow delete cookies on the site details page. Currently we are not showing cookies in the site details page. It is confusing when we enter the site details page from the All Sites page, which shows the cookies for the origin. This CL shows the cookies in the site details page and also allow the user to clear the cookies from the site details page. In addition, if there are cookies on the etld+1 level and we only have one origin, we will show them as a grouped entry instead of collapsed to the top level entry. This is because otherwise the collapsed entry will look weird if we enter the site details page, which only shows the cookies number from the origin, not the etld+1. BUG=835712,935269 Change-Id: Id145657099f9d12fb9efd0200cb57c8e3ba8bb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493691 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Patti <patricialor@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638474} chrome/app/settings_strings.grdp | 6 +++--- chrome/browser/browsing_data/cookies_tree_model.cc | 8 +++----- chrome/browser/browsing_data/cookies_tree_model.h | 4 +--- .../settings/site_settings/site_details.html | 21 ++++++++++++++----- .../settings/site_settings/site_details.js | 23 +++++++++++++++++++-- .../resources/settings/site_settings/site_entry.js | 8 ++++++-- .../site_settings/website_usage_private_api.js | 11 +++++++++- .../ui/webui/settings/site_settings_handler.cc | 24 ++++++++++++++-------- .../ui/webui/settings/site_settings_handler.h | 2 +- .../settings/site_settings_handler_unittest.cc | 2 +- 10 files changed, 77 insertions(+), 32 deletions(-) commit bfbb431d2db0ac2e1685fb6dd265cd9b0007cfee Author: Karandeep Bhatia <karandeepb@chromium.org> Date: Thu Mar 7 08:18:40 2019 +0000 WebRequest: Fix extraHeaders event listeners for webviews in NS path. This CL fixes extraHeaders event listeners for webviews in network-service path. r611357 began requiring the 'extraHeaders' specifier for event listeners which wanted to intercept certain headers. However this doesn't work for webviews in the network service path. ExtensionWebRequestEventRouter::HasAnyExtraHeadersListenerImpl doesn't correctly handle web view event names, causing the WebRequestProxyingURLLoaderFactory to enter into an inconsitent state. Fix this by changing how HasAnyExtraHeadersListenerImpl is implemented. BUG=938095 Change-Id: I8ceb830fd16a2ec671d3b7f49f891ae4c30cb6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504817 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638473} extensions/browser/api/web_request/web_request_api.cc | 19 +++++++++++-------- extensions/browser/api/web_request/web_request_api.h | 7 +++++++ .../browser/guest_view/web_view/web_view_apitest.cc | 5 ----- 3 files changed, 18 insertions(+), 13 deletions(-) commit 7aaa122322512bdc3eba29356bbcdecc3ce515cf Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Mar 7 08:17:43 2019 +0000 service worker: Remove EmbeddedWorkerRegistry. No longer needed after mojofication. Bug: 931084 Change-Id: I3fe93ee2e7c9899ef9f76b2a8a42a548fc03267d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504665 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638472} content/browser/BUILD.gn | 2 - .../service_worker/embedded_worker_instance.cc | 13 ++-- .../service_worker/embedded_worker_instance.h | 13 +--- .../embedded_worker_instance_unittest.cc | 60 ++++++------------ .../service_worker/embedded_worker_registry.cc | 60 ------------------ .../service_worker/embedded_worker_registry.h | 74 ---------------------- .../service_worker/service_worker_browsertest.cc | 1 - .../service_worker/service_worker_context_core.cc | 10 +-- .../service_worker/service_worker_context_core.h | 9 ++- .../service_worker_context_unittest.cc | 1 - .../service_worker_dispatcher_host_unittest.cc | 1 - .../service_worker/service_worker_job_unittest.cc | 1 - .../service_worker_object_host_unittest.cc | 1 - .../service_worker/service_worker_version.cc | 5 +- .../service_worker_version_unittest.cc | 1 - 15 files changed, 35 insertions(+), 217 deletions(-) commit 1bda93b7333e2b623f66537b84b902432057a89d Author: tzik <tzik@chromium.org> Date: Thu Mar 7 08:17:28 2019 +0000 Adopt to new MicrotasksCompletedCallback signature V8 updated the signature of MicrotasksCompletedCallback to take a void pointer user data, and is deprecating the old signature. This CL updates its user to use the new one. Change-Id: I24990f68b2964fa80554689947746636958f59cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504660 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#638471} third_party/blink/renderer/platform/bindings/v8_per_isolate_data.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dcd3885ad22aea9eca7acc47b03f7cc7a319805e Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Mar 7 08:08:25 2019 +0000 desktop-pwas: Set the scope based on the app associated with the window Before, we were retrieving the scope for the app associated with the current URL. This approach had a couple of problems: 1. If WebKit prefs were recomputed while out-of-scope we would set the scope based on the wrong URL 2. Sometimes WebKit prefs are recomputed before the navigation has finished, so there would be no URL that we could use to get the app. This CL fixes these issues by retrieving the app associated with the app window. This association is set when the app window is created and it never changes. Additionally, it adds a GetScopeUrlForApp and HasScopeUrl to AppRegistrar. Bug: 934171 Change-Id: I0f0d78d97f85f6e6a7de3fa4266828bb852b0716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504592 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638470} chrome/browser/chrome_content_browser_client.cc | 33 +++++++++++---------- .../web_applications/components/app_registrar.h | 14 +++++++++ .../extensions/bookmark_app_registrar.cc | 34 ++++++++++++++++++++-- .../extensions/bookmark_app_registrar.h | 6 ++++ .../web_applications/test/test_app_registrar.cc | 11 +++++++ .../web_applications/test/test_app_registrar.h | 2 ++ chrome/browser/web_applications/web_app_provider.h | 2 ++ .../browser/web_applications/web_app_registrar.cc | 10 +++++++ .../browser/web_applications/web_app_registrar.h | 2 ++ 9 files changed, 96 insertions(+), 18 deletions(-) commit 1631115e8c0a75602816fce8731c6b1b4a4566d7 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 7 08:05:03 2019 +0000 Update V8 to version 7.4.297. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4c5c3fce..0a7a6252 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia4f92d7c0115bae7fc8b5ed1750e1941c3c44b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507038 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638469} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ccb7e26a0c3b7183c89179aec6a5e15f46f25853 Author: Kuo Jen Wei <inker@google.com> Date: Thu Mar 7 07:45:32 2019 +0000 Separate shutter/stop buttons for different modes. BUG=None TEST=Video recording and photo taking function normally with/without timer tick. Timer tick can be canceled from stop shutter button. Change-Id: I62feaec286513b3eca7933a85f7f070c63cf74d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486791 Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#638468} .../resources/chromeos/camera/src/css/main.css | 32 ++-- .../resources/chromeos/camera/src/js/sound.js | 2 +- .../chromeos/camera/src/js/views/camera.js | 178 +++++++++------------ .../camera/src/js/views/camera/timertick.js | 2 +- .../resources/chromeos/camera/src/views/main.html | 8 +- 5 files changed, 109 insertions(+), 113 deletions(-) commit 397a94c2200c1ddb969d53c65d5512a3236d0fa8 Author: Rakina Zata Amni <rakina@chromium.org> Date: Thu Mar 7 07:44:49 2019 +0000 [Display Locking]: Unlock active find-in-page match Activatable-locked subtrees are counted in total find-in-page matches, but we currently still skip over them for active match navigation (the specially-highlighted match). This CL makes us unlock/commit relevant locked elements needed to show the active match (the ancestors of the nodes in the active match range). This includes sending the "beforeactivate" event to those elements. Bug: 882663 Change-Id: I743faf1391ff0157fdca12a1cbba51fd29a680c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491069 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#638467} third_party/blink/renderer/core/BUILD.gn | 1 + .../blink/renderer/core/display_lock/BUILD.gn | 2 + .../core/display_lock/display_lock_context_test.cc | 197 ++++++++++++++++++++- .../core/display_lock/display_lock_utilities.cc | 63 +++++++ .../core/display_lock/display_lock_utilities.h | 35 ++++ .../display_lock/display_lock_utilities_test.cc | 154 ++++++++++++++++ .../renderer/core/editing/finder/text_finder.cc | 11 +- 7 files changed, 458 insertions(+), 5 deletions(-) commit fad80abf5a434ea723263d679a890b02e30b45c4 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Mar 7 07:42:15 2019 +0000 [Files app] Add keyboard operations tests for file list Follow up of CL:1475315. Change-Id: Ia6d4e8ab329fb93826182025f6f6c221d4471266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506922 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#638466} .../foreground/js/ui/file_table_list_unittest.js | 89 +++++++++++++++++++++- 1 file changed, 86 insertions(+), 3 deletions(-) commit 7ea5df4c9f6affdf719ad025dc2bd094add90d8e Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Mar 7 07:36:38 2019 +0000 [BlinkGenPropertyTrees] Create render surface for composited effect animations Previously we created render surface only based on the current value of opacity, filter and backface-filter, but the compositor may change the values without informing blink, causing incorrect rendering due to missing render surfaces. Also change the condition checking composited animation from HasActiveXXXAnimation() to IsRunningXXXAnimationOnCompositor() which has been available since crrev.com/c/1498030 and is more accurate. Bug: 836884 Change-Id: I4b14a56c93c9baeb7c0d59da43e3be314f9f9c2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498022 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Mason Freed <masonfreed@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638465} .../compositing/paint_artifact_compositor.cc | 4 +- .../compositing/paint_artifact_compositor_test.cc | 239 +++++++++++++++++++-- .../graphics/compositing/property_tree_manager.cc | 12 +- .../graphics/paint/effect_paint_property_node.h | 5 + .../graphics/paint/transform_paint_property_node.h | 5 + .../platform/testing/paint_property_test_helpers.h | 14 ++ .../skew-notsequential-compositor-expected.png | Bin 4347 -> 4596 bytes 7 files changed, 255 insertions(+), 24 deletions(-) commit 3e797f2ffc5e9acc9d24be40092ef55db57bfe7b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 07:36:13 2019 +0000 Roll src/third_party/perfetto 5abc126b0795..df42f3b1d646 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/5abc126b0795..df42f3b1d646 git log 5abc126b0795..df42f3b1d646 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 oysteine@google.com Merge "Add API to enable additional producer_name_filter entries in a session" Created with: gclient setdep -r src/third_party/perfetto@df42f3b1d646 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I75cc4350660a84ac80e6cb804aadef7fb9021b41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507252 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638464} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 76506a5a7af449d6fff1d642bba44f03211d7315 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Thu Mar 7 07:32:52 2019 +0000 BlinkMemoryMgt: Annotate Blink's platform/testing with the macros of Allocator As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/testing with the macros of Allocator. After some analyzes, it was concluded that for the case of HistogramTester, LayerTreeHostEmbedder, ScopedMainThreadOverrider, ScopedSchedulerOverrider classes, they make sense to use USING_FAST_MALLOC because they have been used as a member variable with new() or smart pointers. In FuzzedDataProvider classes, it makes sense to use DISALLOW_NEW because it's used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I1599e8879f39952d9699218a906ec8e7e193b5fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506675 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#638463} .../blink/renderer/platform/testing/blink_fuzzer_test_support.h | 4 ++++ third_party/blink/renderer/platform/testing/fuzzed_data_provider.h | 3 +++ third_party/blink/renderer/platform/testing/histogram_tester.h | 3 +++ .../blink/renderer/platform/testing/layer_tree_host_embedder.h | 3 +++ .../blink/renderer/platform/testing/scoped_main_thread_overrider.h | 3 +++ third_party/blink/renderer/platform/testing/scoped_mocked_url.h | 3 +++ .../blink/renderer/platform/testing/scoped_scheduler_overrider.h | 3 +++ third_party/blink/renderer/platform/testing/wtf/scoped_mock_clock.h | 3 +++ 8 files changed, 25 insertions(+) commit 13b62afb92834f0941749cd34ca064bc60c03ad1 Author: Miyoung Shin <myid.shin@igalia.com> Date: Thu Mar 7 07:16:23 2019 +0000 Add the precise-width integer check for short type in cpp.py Add a PRESUBMIT check to ensure new |short| use don't come in. Bug: 929985 Change-Id: Ifae1e6ba1af4d6c6ee0b0b8dffe608e0e710b291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503174 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638462} third_party/blink/tools/blinkpy/style/checkers/cpp.py | 4 ++-- .../blink/tools/blinkpy/style/checkers/cpp_unittest.py | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) commit f451f9eaf1b6d67b62bdffa1868168146fef0b0b Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Mar 7 07:15:26 2019 +0000 [Files app] Fix MyFiles expanding when isn't selected Fix My files expanding when selecting or expanding entries in other roots. Change-Id: I5c87f371ef500608100b6e07ae118f84e71f0311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505744 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638461} .../file_manager/file_manager_browsertest.cc | 3 +- .../foreground/js/ui/directory_tree.js | 2 +- .../integration_tests/file_manager/metadata.js | 7 ++-- .../integration_tests/file_manager/my_files.js | 37 ++++++++++++++++++++++ 4 files changed, 44 insertions(+), 5 deletions(-) commit b975f61ffe7bb42540fbec617e14ce3243c2003a Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Mar 7 07:13:32 2019 +0000 OMT service worker fetch: Disable interfaces-sw.https.html on MSAN bot The test is already disabled for non-OMT fetch cases. Disable the test for OMT fetch case too. Bug: 937048 Change-Id: I4397c954cace41d4e1553e929c00c74d32da3deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506059 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638460} third_party/blink/web_tests/MSANExpectations | 1 + third_party/blink/web_tests/TestExpectations | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) commit 19b4ba109099a9b343ca391c9e6ce2ac476e8fc0 Author: Bruno Santos <brunoad@chromium.org> Date: Thu Mar 7 07:13:18 2019 +0000 Rename Contained Home to Kiosk Next Home. Renaming to KioskNextHome to reflect the refactoring work and ultimate goal. Also considered MojoKiosk, but Mojo team prefers to keep the Mojo name referring specifically to the Mojo library, not uses of the library. Bug: 933530 Change-Id: I3113fa6f2a8e95843a9bd82bfcf8a2c75b32bcfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491832 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638459} chrome/browser/browser_resources.grd | 2 +- .../chromeos/login/login_utils_browsertest.cc | 8 ++--- .../component_extensions_whitelist/whitelist.cc | 2 +- chrome/browser/extensions/component_loader.cc | 4 +-- chrome/browser/resources/chromeos/BUILD.gn | 2 +- .../contained_home/contained_home_resources.grdp | 9 ----- .../{contained_home => kiosk_next_home}/BUILD.gn | 4 +-- .../{contained_home => kiosk_next_home}/api.js | 38 ++++++++++----------- .../api_impl.js | 22 ++++++------ .../{contained_home => kiosk_next_home}/bg.js | 0 .../kiosk_next_home/kiosk_next_resources.grdp | 9 +++++ .../kiosk_next_resources_internal.grdp} | 0 .../{contained_home => kiosk_next_home}/main.html | 0 .../manifest.json | 4 +-- .../static/icon192.png | Bin .../resources/component_extension_resources.grd | 4 +-- chrome/browser/ui/ash/kiosk_next_shell_client.cc | 2 +- chrome/common/extensions/extension_constants.cc | 2 +- chrome/common/extensions/extension_constants.h | 4 +-- 19 files changed, 58 insertions(+), 58 deletions(-) commit a07603f008f6fc714f7ec7e8603b7cd2b1ebe079 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Thu Mar 7 07:10:10 2019 +0000 service worker: registration-mime-types.https.html could be slow Add a meta tag to have long timeout for the test. This should deflake the test. Bug: 937544 Change-Id: I87e0dda7647371e1082639037090264240a5bd06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506058 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638458} third_party/blink/web_tests/SlowTests | 2 -- third_party/blink/web_tests/TestExpectations | 1 - .../service-workers/service-worker/registration-mime-types.https.html | 1 + 3 files changed, 1 insertion(+), 3 deletions(-) commit 04b7f02704b1e857f99b88efb9e81f168a31e771 Author: Maggie Chen <magchen@chromium.org> Date: Thu Mar 7 07:06:31 2019 +0000 Add a DCHECK when swap chain present or commit fails Add a DCHECK in swap chain so we will know if this is the cause of the overlay complex test failure. If swap chain fails, there won't be any video frame available. This is only a temporary change to pin-point the cause of a flaky test on the bot. Bug: 937545 Change-Id: Ibec91a4408d7a9500738b69fc407085a0f696033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507280 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638457} gpu/ipc/service/direct_composition_surface_win.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 9769b3c4e692b57fe9ca6b4f40a36c6be81003b7 Author: Sammie Quon <sammiequon@chromium.org> Date: Thu Mar 7 07:05:54 2019 +0000 Revert "Launch Android Intent for media playback." This reverts commit fb0e628497c513215b458fc2236406f7ab7eafb0. Reason for revert: crbug.com/939241. Breaking chrome informationals. Original change's description: > Launch Android Intent for media playback. > > Bug: b:124796759 > Test: Manual > Change-Id: I197f984578e9f80096ada1701e0399058bf9e848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Li Lin <llin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638359} TBR=dcheng@chromium.org,xiaohuic@chromium.org,updowndota@chromium.org,llin@chromium.org Change-Id: If851181e745e76170383e3355f231dda2fe1285e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:124796759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507255 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638456} chrome/browser/ui/ash/assistant/device_actions.cc | 3 -- .../assistant/assistant_manager_service_impl.cc | 49 +++------------------- .../assistant/assistant_manager_service_impl.h | 4 -- .../assistant/public/mojom/assistant.mojom | 12 ------ 4 files changed, 5 insertions(+), 63 deletions(-) commit 3c42a1e5e4489b9fcb5f3740614998c40bed0e18 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 07:04:03 2019 +0000 Roll src/third_party/skia e62d14c1d9ba..692122e3ef23 (1 commits) https://skia.googlesource.com/skia.git/+log/e62d14c1d9ba..692122e3ef23 git log e62d14c1d9ba..692122e3ef23 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 herb@google.com Don't apply the view matrix twice for complicated fallback Created with: gclient setdep -r src/third_party/skia@692122e3ef23 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ie27616697f6e5357ae90ebc5ec7e6399dc43040d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506668 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638455} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit df82b113569b1bdf7f19d1ceec3146e633ee7885 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Mar 7 07:03:25 2019 +0000 [Files app] Fix USB grouping USB grouping wasn't updating the group when new partitions were added or removed after the initial grouping. This was causing devices with more than 2 partitions to only display 2 partitions if device was plugged when Files app was already open, because each partition is mounted individually so files app updates for every partition. Change-Id: I27c62051774b9a73b20005967c09d48a1d2a3c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506680 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#638454} .../common/js/files_app_entry_types.js | 32 +++++++++++++++ .../common/js/files_app_entry_types_unittest.js | 16 +++++++- .../foreground/js/navigation_list_model.js | 29 +++++++++---- .../js/navigation_list_model_unittest.js | 48 ++++++++++++++++++++++ 4 files changed, 115 insertions(+), 10 deletions(-) commit e4dbb81a29c630c9e0871bdf814d4c550c0d66a6 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Mar 7 07:02:59 2019 +0000 Remove diamond key support from chromium. This CL removes support for Diamond key. The feature was supported by --has-chromeos-diamond-key Chromium flag. Chrome OS side change: https://crrev.com/c/1474861 TEST=manual BUG=929027 Change-Id: I0f338ca1776af59409068bd963c636fbc6ee3658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478571 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#638453} .../chromeos/events/event_rewriter_unittest.cc | 206 --------------------- .../chromeos/login/chrome_restart_request.cc | 1 - chrome/browser/chromeos/preferences.cc | 5 - .../extensions/api/settings_private/prefs_util.cc | 2 - .../resources/settings/device_page/keyboard.html | 9 - .../resources/settings/device_page/keyboard.js | 4 - .../settings/chromeos/device_keyboard_handler.cc | 4 - .../chromeos/device_keyboard_handler_unittest.cc | 46 +---- .../test/data/webui/settings/device_page_tests.js | 14 +- chromeos/constants/chromeos_switches.cc | 3 - chromeos/constants/chromeos_switches.h | 1 - ui/chromeos/events/event_rewriter_chromeos.cc | 31 +--- ui/chromeos/events/pref_names.cc | 2 - ui/chromeos/events/pref_names.h | 1 - 14 files changed, 8 insertions(+), 321 deletions(-) commit 81ca6a9c23f7ca8ab8cd90d77cf311f62d5433f7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 07:00:48 2019 +0000 Roll src/third_party/chromite 4ad364d5cbb9..a6918d7b72a9 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ad364d5cbb9..a6918d7b72a9 git log 4ad364d5cbb9..a6918d7b72a9 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 zamorzaev@chromium.org cbuildbot: Add Skylab support for *-android-pfq Created with: gclient setdep -r src/third_party/chromite@a6918d7b72a9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I2f5005ce6e4f3e894b4249c875b51c2c378b3eb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506210 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638452} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 01ae94afba01e9c054b7076367d25b712c728200 Author: mrefaat <mrefaat@chromium.org> Date: Thu Mar 7 06:58:31 2019 +0000 Remove public browserState API from Tab It's only used now by unit tests. I'm keeping it as a private member of tab for now until i move the overscrollController out of Tab. Bug: 902044 Change-Id: Ic326796a71e0c27f62c4e4b3198a01ad7098c085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504836 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638451} ios/chrome/browser/tabs/tab.h | 8 -------- ios/chrome/browser/tabs/tab.mm | 4 ++-- ios/chrome/browser/tabs/tab_unittest.mm | 4 ++-- .../ui/activity_services/share_to_data_builder_unittest.mm | 4 ---- 4 files changed, 4 insertions(+), 16 deletions(-) commit a817b264ab3f05774c5cbb80b4d659188ff8b6ea Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 06:56:07 2019 +0000 Remove ImeWindowView::GetWindowAppIcon() The implementation matches the default, i.e. WidgetDelegate::GetWindowAppIcon(). Bug: none Change-Id: I8c0980cbc676dd835105c551df9039cd2fca666e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506695 Reviewed-by: Shu Chen <shuchen@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638450} chrome/browser/ui/views/ime/ime_window_view.cc | 4 ---- chrome/browser/ui/views/ime/ime_window_view.h | 1 - 2 files changed, 5 deletions(-) commit 4446d55037714c34e5d69403da2c350924a9a4e1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 06:53:22 2019 +0000 Roll src/third_party/dawn 1cc386687cde..579cf621f3dc (2 commits) https://dawn.googlesource.com/dawn.git/+log/1cc386687cde..579cf621f3dc git log 1cc386687cde..579cf621f3dc --date=short --no-merges --format='%ad %ae %s' 2019-03-07 cwallez@chromium.org Split off common and libdawn / dawn_headers from BUILD.gn 2019-03-06 cwallez@chromium.org BUILD.gn: Split dawn_component/generator in their own files Created with: gclient setdep -r src/third_party/dawn@579cf621f3dc The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If135e279f6fdd9818334f334b45267eb3293b98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506669 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638449} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a5b5e8cc2724429f27d554a504332837a02ea92d Author: Karandeep Bhatia <karandeepb@chromium.org> Date: Thu Mar 7 06:51:56 2019 +0000 WebRequest: Fix extraHeaders modification for webviews in non-NS path. This CL fixes extraHeaders modification for webviews in non-network-service path. r611357 began requiring the 'extraHeaders' specifier for event listeners which wanted to intercept certain headers. However ExtensionWebRequestEventRouter::OnEventHandled doesn't handle webview listeners while computing the extraInfoSpec. Fix this by sending the webViewInstanceId to the browser process as part of the webRequestInternal.eventHandled function. This allows us to accurately determine the listener which called the function. Also, add a regression test. The network service path will be fixed in a follow-up. BUG=938095 Change-Id: I89a5383c6ba1eac67efc8c3fe25a7714a54e2605 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504961 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638448} .../api/web_request/web_request_api_unittest.cc | 5 +- .../browser/api/web_request/web_request_api.cc | 68 +++++++++++++--------- .../browser/api/web_request/web_request_api.h | 4 ++ .../guest_view/web_view/web_view_apitest.cc | 15 +++++ extensions/common/api/web_request_internal.json | 1 + extensions/renderer/resources/web_request_event.js | 8 ++- extensions/test/data/web_view/apitest/main.js | 62 ++++++++++++++++++++ 7 files changed, 129 insertions(+), 34 deletions(-) commit 1c143fac8106c73fd963550f4ea25fa0f63d1f88 Author: Yuichiro Hanada <yhanada@google.com> Date: Thu Mar 7 06:51:08 2019 +0000 Make ArcInputMethodManagerService observe the active app's IME instance. There could be multiple ui::InputMethod instances in SPM. This CL makes ArcInputMethodManagerService observe ui::InputMethod changes. Bug: 937769 Test: manual - Android IMEs show up when tapping on a text field. Change-Id: Ie507d6ef612ce4ef60b93e6391353d485f7c5258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504669 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#638447} .../arc_input_method_manager_service.cc | 64 ++++++++++++++++------ .../arc_input_method_manager_service.h | 17 ++++-- 2 files changed, 58 insertions(+), 23 deletions(-) commit 7c2940555d39f5117359f2d0cd455b9602e112f6 Author: Michael Martis <martis@chromium.org> Date: Thu Mar 7 06:50:46 2019 +0000 Image annotation service: added metrics. This CL tracks metrics about: - The core operation of the service (e.g. client communication, cache hit rates, etc.) - The performance (e.g. amount of data transferred to/from, latency) of the image annotation server - The distribution of metadata (e.g. confidence values, empty results) returned by the server Also fixes two bugs found during metrics testing: - We no longer attempt to parse an engine result if we receive a non-OK status. The counterexample to this behavior is an OCR engine failure, which returns an empty OCR result (which is otherwise successfully parsable) along with a non-OK status code. - We were sometimes accidentally populating the cache with failure results (we should only cache successful results). Bug: 916420 Change-Id: I996cebf644865d0135efb73c57785745e5cb7585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498747 Commit-Queue: Michael Martis <martis@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638446} services/image_annotation/BUILD.gn | 6 +- services/image_annotation/annotator.cc | 171 ++++++++++++++---- services/image_annotation/annotator.h | 2 +- services/image_annotation/annotator_unittest.cc | 146 +++++++++++++++- .../image_annotation/image_annotation_metrics.cc | 127 ++++++++++++++ .../image_annotation/image_annotation_metrics.h | 124 +++++++++++++ .../image_annotation/image_annotation_utils.cc | 26 +++ services/image_annotation/image_annotation_utils.h | 29 ++++ services/image_annotation/public/cpp/BUILD.gn | 2 + .../image_annotation/public/cpp/image_processor.cc | 7 + .../public/cpp/image_processor_unittest.cc | 15 ++ .../public/mojom/image_annotation.mojom | 8 +- tools/metrics/histograms/enums.xml | 48 ++++++ tools/metrics/histograms/histograms.xml | 192 +++++++++++++++++++++ 14 files changed, 857 insertions(+), 46 deletions(-) commit 0a4cb0342e631b3581cb14e41fee8aef52f9b5b3 Author: Toni Barzic <tbarzic@chromium.org> Date: Thu Mar 7 06:50:00 2019 +0000 oobe: Delete ScreenExitCode enum All usages have been removed in favour of per-screen exit codes. BUG=930267 Change-Id: I0f5b0164f3c74cf3fdf3f0c45743f0df71b30852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506564 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#638445} chrome/browser/chromeos/BUILD.gn | 2 - .../login/demo_mode/demo_setup_browsertest.cc | 1 - .../login/screens/arc_terms_of_service_screen.cc | 1 - .../browser/chromeos/login/screens/base_screen.cc | 4 - .../browser/chromeos/login/screens/base_screen.h | 4 - .../chromeos/login/screens/base_screen_delegate.h | 5 - .../login/screens/demo_preferences_screen.cc | 1 - .../login/screens/mock_base_screen_delegate.h | 1 - .../chromeos/login/screens/network_screen.cc | 1 - .../chromeos/login/screens/screen_exit_code.cc | 106 --------------------- .../chromeos/login/screens/screen_exit_code.h | 80 ---------------- .../chromeos/login/screens/welcome_screen.cc | 1 - chrome/browser/chromeos/login/wizard_controller.cc | 3 - chrome/browser/chromeos/login/wizard_controller.h | 1 - .../login/wizard_controller_browsertest.cc | 11 --- 15 files changed, 222 deletions(-) commit 18cdcca4f9c45ca92980a0ca7dfbc20e09535e9e Author: Paul Irish <paulirish@chromium.org> Date: Thu Mar 7 06:45:22 2019 +0000 DevTools: Roll Lighthouse to 4.2.0 Changelog: https://github.com/googlechrome/lighthouse/compare/v4.1.0...v4.2.0 Bug: 772558 Change-Id: I12f8cf514afb7fff2503f2b4ca797803f804c4a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507206 Commit-Queue: Paul Irish <paulirish@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Auto-Submit: Paul Irish <paulirish@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#638444} .../lighthouse/renderer/category-renderer.js | 8 +- .../lighthouse/renderer/crc-details-renderer.js | 12 +- .../lighthouse/renderer/details-renderer.js | 394 +- .../renderer/performance-category-renderer.js | 10 +- .../front_end/audits2/lighthouse/renderer/psi.js | 2 +- .../audits2/lighthouse/renderer/report-renderer.js | 1 - .../lighthouse/renderer/report-ui-features.js | 1 - .../front_end/audits2/lighthouse/renderer/util.js | 47 + .../front_end/audits2/lighthouse/report-styles.css | 4 + .../front_end/audits2/lighthouse/templates.html | 140 + .../lighthouse/lighthouse-dt-bundle.js | 10501 ++++++++++++------- .../audits2/audits2-limited-run-expected.txt | 5 + .../audits2/audits2-successful-run-expected.txt | 39 +- 13 files changed, 6986 insertions(+), 4178 deletions(-) commit fd75edb3a82e2b7e370fdc41a7f995f733550d8f Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Mar 7 06:44:27 2019 +0000 Update profile menu trigger for guest mode. ShowAvatarMenu is updated to open correct menu in Guest mode. Bug: 938600, 896235 Change-Id: I2407c1c6065afd698d2b571c4f86ad0020b1dca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505612 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#638443} chrome/browser/ui/browser_commands.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 571c52c65d0ecbe856683a887e7b25f3c19f4b09 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Mar 7 06:38:54 2019 +0000 GWP-ASan: Another Slot->Metadata rename Here we are recording allocation metadata for a slot, but not *in* a slot. This is in anticipation of an upcoming change that will make slots/metadata not have a 1:1 mapping so poor wording like this is particulary noticable. Bug: 939142 Change-Id: I55deae7b9290334329e1cc48759859c68ccab11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507312 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#638442} components/gwp_asan/client/guarded_page_allocator.cc | 14 +++++++------- components/gwp_asan/client/guarded_page_allocator.h | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) commit 49b6245ddd1bb35051520a7da1471c6f53a2bc05 Author: Nigel Tao <nigeltao@chromium.org> Date: Thu Mar 7 06:38:14 2019 +0000 Refactor App Service's icon effects Previously, such effects were only applied to Extension apps. This commit lets other app publishers apply the same effects. A follow-up commit will do so for ARC++ apps. BUG=826982 Change-Id: I063cabf7a44efb111638e42565a5792b24c38eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505743 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#638441} .../browser/apps/app_service/app_icon_factory.cc | 130 ++++++++++++--------- chrome/browser/apps/app_service/app_icon_factory.h | 19 +++ chrome/browser/apps/app_service/arc_apps.cc | 13 ++- chrome/browser/apps/app_service/arc_apps.h | 3 + .../apps/app_service/built_in_chromeos_apps.cc | 8 +- chrome/browser/apps/app_service/crostini_apps.cc | 13 ++- chrome/browser/apps/app_service/crostini_apps.h | 2 + chrome/browser/apps/app_service/extension_apps.cc | 26 +++-- chrome/services/app_service/README.md | 24 +++- 9 files changed, 154 insertions(+), 84 deletions(-) commit f77d74efa283b5bce3573eb971ca6feea7d86241 Author: Chris Harrelson <chrishtr@chromium.org> Date: Thu Mar 7 06:35:17 2019 +0000 [BGPT] Don't omit solid color transparent draw quads with blend mode. There is an optimization to omit solid-color transparent draw quads, since they don't do anything. However, this optimization is incorrect if the draw quad has a blend mode other than kSrcIn. Also add support for non-kSrcOver blend mode for SolidColorLayerImpl. Bug: 937258,939168 Change-Id: Id779b9bbe06d2ff5c6e9c34a18026b500f5791a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506383 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638440} cc/layers/layer_impl.cc | 5 +- cc/layers/layer_impl.h | 2 +- cc/layers/picture_layer_impl.cc | 5 +- cc/layers/solid_color_layer_impl.cc | 26 ++- cc/layers/solid_color_layer_impl.h | 1 + cc/trees/layer_tree_host_pixeltest_masks.cc | 209 +++++++++++++++++++++ components/viz/service/display/gl_renderer.cc | 15 +- .../data/solid_color_empty_mask_with_effect.png | Bin 0 -> 302 bytes .../compositing/masks/broken-mask-expected.html | 2 + .../web_tests/compositing/masks/broken-mask.html | 12 ++ 10 files changed, 262 insertions(+), 15 deletions(-) commit 7d2881122387aca8c3ab9e85853632ee0ce5a5ff Author: dstockwell <dstockwell@google.com> Date: Thu Mar 7 06:34:56 2019 +0000 third_party/ink: Roll to 236852834 Bug: 902646 Change-Id: Idd2e85b2b5b1e228639120858c9defe9ec207d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506919 Commit-Queue: dstockwell <dstockwell@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#638439} third_party/ink/README.chromium | 2 +- third_party/ink/build/wasm-threads/glcore_base.js.mem.sha1 | 2 +- third_party/ink/build/wasm-threads/glcore_base.wasm.sha1 | 2 +- third_party/ink/build/wasm/glcore_base.wasm.sha1 | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) commit 404fc74a33b2be933c8498e894bad9bc934a265b Author: Collin Baker <collinbaker@chromium.org> Date: Thu Mar 7 06:24:48 2019 +0000 Add new in-product help highlight colors for dark mode and themes Bug: 920027 Change-Id: I6af75af13d85f44ed55bd175dc169836b2a83716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504149 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#638438} .../ui/views/profiles/avatar_toolbar_button.cc | 43 ++++------------------ .../ui/views/profiles/avatar_toolbar_button.h | 12 ------ .../profiles/avatar_toolbar_button_unittest.cc | 5 ++- .../ui/views/toolbar/browser_app_menu_button.cc | 24 +++++++++--- .../ui/views/toolbar/browser_app_menu_button.h | 5 +++ chrome/browser/ui/views/toolbar/toolbar_button.cc | 33 +++++++++++++++++ chrome/browser/ui/views/toolbar/toolbar_button.h | 15 ++++++++ ui/native_theme/common_theme.cc | 4 ++ 8 files changed, 85 insertions(+), 56 deletions(-) commit 50c7a5d4eb659fde6f5537826589309dc49b52b4 Author: Bruce Dawson <brucedawson@chromium.org> Date: Thu Mar 7 06:23:50 2019 +0000 Request -j 150 instead of -j 80 The ARM64 Win32 builders still run a bit slow (30 - 160 minutes) due to the large number of build steps (cross compilation) and the use of -j 80 when many other builders use -j 150. This changes to -j 150 by using the appropriate mixin. Builder is here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win32-arm64-rel Bug: 938085 Change-Id: I6c7b7cb8d6fb81c5ed3969cd5d31368f09b009ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506949 Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#638437} infra/config/cr-buildbucket.cfg | 1 + 1 file changed, 1 insertion(+) commit 11858f764a8b416bac3e9598e7d57a33932ba3c9 Author: Rob Schonberger <robsc@chromium.org> Date: Thu Mar 7 06:17:41 2019 +0000 When users open AppReinstall, how many times did we show result. When a user interacts with a fast app reinstall result, how many times did we show it before they clicked. Change-Id: I29cf36c2511a8ab3025d24ebb3c5432f699ed599 Bug: 911427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503180 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638436} .../app_list/search/arc/arc_app_reinstall_search_provider.cc | 6 ++++++ tools/metrics/histograms/histograms.xml | 11 +++++++++++ 2 files changed, 17 insertions(+) commit 98892ebf4831b3e4063605d00edf22b7c1debf9e Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Thu Mar 7 05:48:48 2019 +0000 Make probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl case style consistent The primary motivation is that the function names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL renamed functions to follow proper case style. Bug: 936684 Change-Id: I06903ede66a09c133978f4ff940c7b505d1123f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503276 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#638435} .../scripts/templates/instrumenting_probes_impl.cc.tmpl | 16 ++++++++-------- .../renderer/build/scripts/templates/probe_sink.h.tmpl | 6 +++--- third_party/blink/renderer/core/frame/ad_tracker.cc | 4 ++-- third_party/blink/renderer/core/frame/local_frame.cc | 4 ++-- .../blink/renderer/core/frame/performance_monitor.cc | 4 ++-- .../blink/renderer/core/inspector/devtools_session.cc | 4 ++-- .../renderer/core/inspector/inspector_animation_agent.cc | 4 ++-- .../core/inspector/inspector_application_cache_agent.cc | 4 ++-- .../blink/renderer/core/inspector/inspector_css_agent.cc | 4 ++-- .../blink/renderer/core/inspector/inspector_dom_agent.cc | 4 ++-- .../core/inspector/inspector_dom_debugger_agent.cc | 6 +++--- .../core/inspector/inspector_dom_snapshot_agent.cc | 4 ++-- .../renderer/core/inspector/inspector_emulation_agent.cc | 4 ++-- .../core/inspector/inspector_layer_tree_agent.cc | 4 ++-- .../blink/renderer/core/inspector/inspector_log_agent.cc | 4 ++-- .../renderer/core/inspector/inspector_network_agent.cc | 4 ++-- .../renderer/core/inspector/inspector_page_agent.cc | 4 ++-- .../core/inspector/inspector_performance_agent.cc | 4 ++-- .../core/inspector/worker_inspector_controller.cc | 2 +- .../renderer/platform/loader/fetch/fetch_context.cc | 2 +- 20 files changed, 46 insertions(+), 46 deletions(-) commit 8debd334f3b23e80d41f0c33fcdc04ef94567252 Author: Matt Reynolds <mattreynolds@google.com> Date: Thu Mar 7 05:36:38 2019 +0000 Add skeleton for WebHID API feature This CL adds initial IDL for the navigator.hid object which is enabled under the experimental web platform features flag. (chrome://flags/#enable-experimental-web-platform-features) A FeaturePolicyFeature is also added to control access to HID within the renderer. BUG=890096 Change-Id: If75aefdd7dcaaad06ae56cff8d898d0bea0f83a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441992 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638434} .../blink/common/feature_policy/feature_policy.cc | 3 ++ .../mojom/feature_policy/feature_policy.mojom | 2 + .../renderer/core/feature_policy/feature_policy.cc | 3 ++ third_party/blink/renderer/modules/BUILD.gn | 1 + .../modules/event_target_modules_names.json5 | 1 + third_party/blink/renderer/modules/hid/BUILD.gn | 14 +++++++ third_party/blink/renderer/modules/hid/DEPS | 3 ++ third_party/blink/renderer/modules/hid/OWNERS | 5 +++ third_party/blink/renderer/modules/hid/hid.cc | 34 ++++++++++++++++ third_party/blink/renderer/modules/hid/hid.h | 35 ++++++++++++++++ third_party/blink/renderer/modules/hid/hid.idl | 12 ++++++ .../blink/renderer/modules/hid/navigator_hid.cc | 46 ++++++++++++++++++++++ .../blink/renderer/modules/hid/navigator_hid.h | 41 +++++++++++++++++++ .../blink/renderer/modules/hid/navigator_hid.idl | 15 +++++++ .../blink/renderer/modules/modules_idl_files.gni | 2 + .../platform/runtime_enabled_features.json5 | 4 ++ .../feature-policy-features-expected.txt | 1 + .../global-interface-listing-expected.txt | 4 ++ tools/metrics/histograms/enums.xml | 1 + 19 files changed, 227 insertions(+) commit 354a8059e1d3984fc4e35caa2893a0cec5bc8061 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Mar 7 05:33:36 2019 +0000 [code coverage] Increase timeouts of browser_tests for coverage build The coverage build is about 10x slower than regular build when running browser_tests, and this CL increases the timeouts accordingly. Bug: 937521 Change-Id: I5939648142f29fbd9fe36625d661cc70ff6019e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504153 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638433} base/test/BUILD.gn | 1 + base/test/test_timeouts.cc | 4 ++++ content/browser/browser_process_sub_thread.cc | 7 +++++++ 3 files changed, 12 insertions(+) commit 861b89541841e36a936ade98869a31218bac3e79 Author: Tommy Nyquist <nyquist@chromium.org> Date: Thu Mar 7 05:28:05 2019 +0000 Clean up Jelly Bean API compatibility code. This CL removes the special cases for Jelly Bean in the ApiCompatibilityUtils in //base. After that it turned out that all the APIs could be inlined. One API had to be special cased, since it was more than a single line, namely the isDeviceProvisioned(Context) method. It had null-checks for the Context and ContentResolver, and they were kept to ensure this CL has no functional changes. Some API callers were using the result of !inlineMethod(...), and the method itself was checking == against something, and for those the == was flipped to != and the negation of the call was removed after inlining. The method getUriForImageCaptureFile(File) had some documentation, and that was moved to the only method it ended up calling, since that was lacking documentation. Bug: 893231,923477 Change-Id: I43420a38f6fe191b2c489f2f1bec99160bbcc718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496522 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#638432} .../org/chromium/base/ApiCompatibilityUtils.java | 177 +-------------------- .../src/org/chromium/base/ContentUriUtils.java | 7 + .../org/chromium/chrome/browser/IntentHandler.java | 13 +- .../chromium/chrome/browser/appmenu/AppMenu.java | 2 +- .../keyboard_accessory/AccessorySheetView.java | 6 +- .../keyboard_accessory/KeyboardAccessoryView.java | 8 +- .../PasswordAccessorySheetViewBinder.java | 3 +- .../AutofillAssistantFacade.java | 3 +- .../browser/infobar/InfoBarControlLayout.java | 2 +- .../chrome/browser/infobar/InfoBarLayout.java | 3 +- .../infobar/translate/TranslateMenuHelper.java | 3 +- .../infobar/translate/TranslateTabLayout.java | 5 +- .../chrome/browser/omnibox/LocationBarTablet.java | 3 +- .../chromium/chrome/browser/omnibox/UrlBar.java | 10 +- .../omnibox/suggestions/basic/SuggestionView.java | 12 +- .../basic/SuggestionViewViewBinder.java | 4 +- .../browser/page_info/CertificateViewer.java | 8 +- .../password_manager/AccountChooserDialog.java | 6 +- .../payments/ui/PaymentRequestBottomBar.java | 5 +- .../browser/payments/ui/PaymentRequestHeader.java | 3 +- .../browser/payments/ui/PaymentRequestSection.java | 4 +- .../languages/LanguageListPreference.java | 3 +- .../chromium/chrome/browser/share/ShareHelper.java | 5 +- .../browser/suggestions/SuggestionsBinder.java | 3 +- .../chrome/browser/suggestions/TileGridLayout.java | 3 +- .../chrome/browser/toolbar/top/ToolbarPhone.java | 27 ++-- .../widget/CompatibilityTextInputLayout.java | 4 +- .../chrome/browser/widget/DualControlLayout.java | 2 +- .../chrome/browser/widget/ListMenuButton.java | 5 +- .../widget/TextViewWithCompoundDrawables.java | 9 +- .../selection/SelectionPopupControllerImpl.java | 11 +- .../org/chromium/ui/DropdownPopupWindowImpl.java | 4 +- .../chromium/ui/DropdownPopupWindowJellyBean.java | 5 +- .../org/chromium/ui/base/LocalizationUtils.java | 5 +- .../src/org/chromium/ui/base/SelectFileDialog.java | 4 +- .../org/chromium/ui/base/ViewAndroidDelegate.java | 3 +- .../org/chromium/ui/widget/ViewRectProvider.java | 4 +- 37 files changed, 103 insertions(+), 281 deletions(-) commit 03e39d1cc9e99710bd0e24fc966ba0254860b5c4 Author: Hiroshi Ichikawa <ichikawa@chromium.org> Date: Thu Mar 7 05:12:55 2019 +0000 Fix a bug that -[CWVDownloadTask cancel] causes an assertion failure. The issue was that this condition is true even when the task is cancelled (state kCancelled): https://cs.chromium.org/chromium/src/ios/web_view/internal/cwv_download_task.mm?l=135&rcl=584d37cf04ac09d05ecacdf946edf11bdeeb0198 So it unintentionally tries to call DisownFile(), which fails. Also introduce CWVDownloadErrorFailed and CWVDownloadErrorAborted because clients probably want to distinguish failure and cancel. Change-Id: I1637aabf8843685ccee01cf272a5f5acee85e005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504486 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by: John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#638431} ios/web_view/internal/cwv_download_task.mm | 49 +++++++++++++++------- .../internal/cwv_download_task_unittest.mm | 20 ++++++++- ios/web_view/public/cwv_download_task.h | 20 ++++++--- ios/web_view/shell/shell_view_controller.m | 7 ++++ 4 files changed, 72 insertions(+), 24 deletions(-) commit 24cb88006abfb733ab4cce4fd23513e93f0d8b32 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 05:10:30 2019 +0000 Roll src/third_party/skia 3c957d575c58..e62d14c1d9ba (5 commits) https://skia.googlesource.com/skia.git/+log/3c957d575c58..e62d14c1d9ba git log 3c957d575c58..e62d14c1d9ba --date=short --no-merges --format='%ad %ae %s' 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bf943f67daa4..2995dc2a67c7 (2 commits) 2019-03-07 bungeman@google.com Correct argument order for blobs in viewer. 2019-03-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 76e9bc066b28..bf943f67daa4 (2 commits) 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 e397949ec2db..14126505b237 (4 commits) 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@e62d14c1d9ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I218aad36e61d4d7b9bbf157a3ff850e37e64c5a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507253 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638430} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee1f21074c5d5fc03ad7487a8aae577209fdeefc Author: Ramin Halavati <rhalavati@chromium.org> Date: Thu Mar 7 05:09:34 2019 +0000 Update incognito window counter's insets. Incognito window counter's insets are updated to unify with other profile-chooser dialogs. Bug: 931320, 934689 Change-Id: I433f0678a245768be226e26274c9fd663c822b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505172 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#638429} chrome/browser/ui/views/profiles/profile_chooser_view.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 31f7fae71c5c90c51281a29590dabbd7e33064a5 Author: Toni Barzic <tbarzic@chromium.org> Date: Thu Mar 7 05:09:25 2019 +0000 oobe: Deprecate remaining ScreenExitCode values Stops using remaining ScreenExitCode enum values (for reporing oobe screen results. Instead, defines screen result enums per screen when needed (i.e. if the screen may report multiple values). Updates how screens relay the exit code to WizardController - instead of using BaseScreenDelegate::OnExit (indirectly though BaseScreen::Finish), the screens now take a callback that is run when the screen exits. Affected screens: * AppDownloadingScreen * ArcTermsOfServiceScreen * AssistantOptInScreen * DemoPreferencesScreen * DemoSetupScreen * DiscoverScreen * EnableDebuggingScreen * FingerprintSetupScreen * HIDDetectionScreen * KioskAutolaunchScreen * KioskEnableScreen * MarketingOptInScreen * MultideviceSetupScreen * RecommendAppsScreen * ResetScreen * SupervisionTransitionScreen * SyncConsentScreen * TermsOfServiceScreen * WelcomeScreen * WrongHWIDScreen BUG=930267 Change-Id: Ie53a748b24a9bf8d03bc0e8e467d94d1f38e5898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506492 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#638428} .../login/screens/app_downloading_screen.cc | 8 +- .../login/screens/app_downloading_screen.h | 5 +- .../login/screens/arc_terms_of_service_screen.cc | 12 +- .../login/screens/arc_terms_of_service_screen.h | 11 +- .../login/screens/assistant_optin_flow_screen.cc | 10 +- .../login/screens/assistant_optin_flow_screen.h | 5 +- .../login/screens/demo_preferences_screen.cc | 10 +- .../login/screens/demo_preferences_screen.h | 11 +- .../chromeos/login/screens/demo_setup_screen.cc | 8 +- .../chromeos/login/screens/demo_setup_screen.h | 11 +- .../chromeos/login/screens/discover_screen.cc | 10 +- .../chromeos/login/screens/discover_screen.h | 5 +- .../login/screens/enable_debugging_screen.cc | 12 +- .../login/screens/enable_debugging_screen.h | 8 +- .../login/screens/fingerprint_setup_screen.cc | 10 +- .../login/screens/fingerprint_setup_screen.h | 5 +- .../chromeos/login/screens/hid_detection_screen.cc | 9 +- .../chromeos/login/screens/hid_detection_screen.h | 4 +- .../login/screens/kiosk_autolaunch_screen.cc | 9 +- .../login/screens/kiosk_autolaunch_screen.h | 8 +- .../chromeos/login/screens/kiosk_enable_screen.cc | 11 +- .../chromeos/login/screens/kiosk_enable_screen.h | 5 +- .../login/screens/marketing_opt_in_screen.cc | 10 +- .../login/screens/marketing_opt_in_screen.h | 5 +- .../screens/mock_arc_terms_of_service_screen.cc | 9 +- .../screens/mock_arc_terms_of_service_screen.h | 5 +- .../login/screens/mock_demo_preferences_screen.cc | 9 +- .../login/screens/mock_demo_preferences_screen.h | 5 +- .../login/screens/mock_demo_setup_screen.cc | 9 +- .../login/screens/mock_demo_setup_screen.h | 5 +- .../login/screens/mock_enable_debugging_screen.cc | 9 +- .../login/screens/mock_enable_debugging_screen.h | 5 +- .../screens/mock_supervision_transition_screen.cc | 9 +- .../screens/mock_supervision_transition_screen.h | 5 +- .../chromeos/login/screens/mock_welcome_screen.cc | 14 +- .../chromeos/login/screens/mock_welcome_screen.h | 5 +- .../login/screens/mock_wrong_hwid_screen.cc | 5 +- .../login/screens/mock_wrong_hwid_screen.h | 3 +- .../login/screens/multidevice_setup_screen.cc | 8 +- .../login/screens/multidevice_setup_screen.h | 5 +- .../screens/multidevice_setup_screen_unittest.cc | 4 +- .../login/screens/recommend_apps_screen.cc | 10 +- .../chromeos/login/screens/recommend_apps_screen.h | 8 +- .../browser/chromeos/login/screens/reset_screen.cc | 13 +- .../browser/chromeos/login/screens/reset_screen.h | 8 +- .../chromeos/login/screens/screen_exit_code.cc | 56 +-- .../chromeos/login/screens/screen_exit_code.h | 56 +-- .../login/screens/supervision_transition_screen.cc | 8 +- .../login/screens/supervision_transition_screen.h | 8 +- .../chromeos/login/screens/sync_consent_screen.cc | 21 +- .../chromeos/login/screens/sync_consent_screen.h | 4 +- .../login/screens/terms_of_service_screen.cc | 10 +- .../login/screens/terms_of_service_screen.h | 8 +- .../chromeos/login/screens/welcome_screen.cc | 6 +- .../chromeos/login/screens/welcome_screen.h | 10 +- .../chromeos/login/screens/wrong_hwid_screen.cc | 8 +- .../chromeos/login/screens/wrong_hwid_screen.h | 5 +- chrome/browser/chromeos/login/wizard_controller.cc | 437 +++++++++++---------- chrome/browser/chromeos/login/wizard_controller.h | 50 ++- .../login/wizard_controller_browsertest.cc | 139 ++++--- 60 files changed, 727 insertions(+), 454 deletions(-) commit 4f9a19f16e84020024cb768e34b695ca240fa69d Author: Yuri Wiitala <miu@chromium.org> Date: Thu Mar 7 05:05:25 2019 +0000 AudioService: Fixes for loopback underruns/timing issues. Fixes a "choppy audio" issue on platforms with certain audio timing parameters/scenarios. Investigation on crbug.com/934770 led to the realization that three related problems needed to be addressed: 1. Fix the "gap" detection in audio::SnooperNode to check in BOTH directions, not just one direction; and on both the input and output flows. This accounts for the case where a device-switch in audio::OutputController results in a sudden drastic shift in the delay timestamps. 2. Add automatically-increasing capture delay logic to audio::LoopbackStream to ensure the reads from all nodes' delay buffer will never result in underrun. 3. Increased the accuracy of media::FakeAudioWorker/OutputStream by: a) addressing a subtle source of error in task scheduling delay math due to integer truncation; b) exposing timestamps to worker callbacks that allow FakeAudioOutputStream to provide a |delay| and |delay_timestamp| that behaves just like a real AudioOutputStream. This "lessens the blow" of a device-switch to SnooperNode. Bug: 934770 Change-Id: Ia75f18b2be3ad905f27d6ad882df9632764bb81c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504981 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Reviewed-by: Oskar Sundbom <ossu@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638427} .../media/capture/web_contents_audio_muter.cc | 18 +++-- media/audio/fake_audio_input_stream.cc | 21 ++++-- media/audio/fake_audio_input_stream.h | 2 +- media/audio/fake_audio_output_stream.cc | 15 +++-- media/audio/fake_audio_output_stream.h | 7 +- media/audio/null_audio_sink.cc | 16 +++-- media/audio/null_audio_sink.h | 3 +- media/audio/virtual_audio_input_stream.cc | 9 +-- media/audio/virtual_audio_input_stream.h | 2 +- media/base/fake_audio_worker.cc | 77 +++++++++++++++------- media/base/fake_audio_worker.h | 12 +++- media/base/fake_audio_worker_unittest.cc | 8 ++- media/base/silent_sink_suspender.cc | 15 +++-- services/audio/loopback_stream.cc | 40 ++++++++--- services/audio/loopback_stream.h | 15 +++-- services/audio/snooper_node.cc | 72 ++++++++++++++++++-- services/audio/snooper_node.h | 13 ++++ services/audio/stream_factory.cc | 13 ++-- 18 files changed, 267 insertions(+), 91 deletions(-) commit 7eb019ac080a80ebf567fbcdccd66058ade03559 Author: Takuto Ikuta <tikuta@chromium.org> Date: Thu Mar 7 05:03:26 2019 +0000 [quick_trace] use proto_deps I will deprecate deps in proto_library for improved build throughput. And we can use proto_deps here instead. Bug: 938011 Change-Id: I406ef84c220536058e3f9e18ccd9ce3e4cb2e45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504602 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638426} third_party/quic_trace/BUILD.gn | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit c3f65b18e8968ecfc8c8afab5f87530a64ccb96e Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Mar 7 05:01:36 2019 +0000 Android: Use TabBuilder for Tab creation This CL consolidates various ways to create Tab instances into a single one using TabBuilder. Saves us from passing unannotated params |null| to the constructor, so makes the intention clearer. Bug: 925242 Change-Id: I7440eb501a5ef7a6f456ee60e1c1000932af85b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1485611 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#638425} .../chrome/browser/touchless/NoTouchActivity.java | 9 +- .../chromium/chrome/browser/SingleTabActivity.java | 7 +- .../BrowserActionsTabCreatorManager.java | 13 +- .../chrome/browser/customtabs/HiddenTabHolder.java | 35 ++++- .../content/CustomTabActivityTabFactory.java | 10 +- .../browser/searchwidget/SearchActivity.java | 9 +- .../src/org/chromium/chrome/browser/tab/Tab.java | 136 ++++--------------- .../chromium/chrome/browser/tab/TabBuilder.java | 144 +++++++++++++++++++++ .../chrome/browser/tabmodel/ChromeTabCreator.java | 43 ++++-- .../tabmodel/document/DocumentTabModelImpl.java | 4 +- .../browser/tabmodel/document/TabDelegate.java | 7 +- .../chrome/browser/webapps/WebappActivity.java | 9 +- chrome/android/java_sources.gni | 2 + .../compositor/layouts/LayoutManagerTest.java | 3 +- .../CustomTabTabPersistencePolicyTest.java | 3 +- .../LocationBarVoiceRecognitionHandlerTest.java | 3 +- .../browser/share/ShareMenuActionHandlerTest.java | 10 +- .../org/chromium/chrome/browser/tab/MockTab.java | 18 +++ .../chromium/chrome/browser/tab/TabUmaTest.java | 30 +++-- .../browser/tabmodel/DocumentModeAssassinTest.java | 3 +- .../tabmodel/TabModelSelectorTabObserverTest.java | 6 +- .../browser/tabmodel/TabPersistentStoreTest.java | 14 +- .../browser/tabmodel/TabWindowManagerTest.java | 5 +- .../browser/toolbar/LocationBarModelTest.java | 3 +- .../test/util/browser/tabmodel/MockTabModel.java | 5 +- 25 files changed, 349 insertions(+), 182 deletions(-) commit 578a6077610d52f4165d4c4b9025d8381162e617 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Thu Mar 7 04:44:12 2019 +0000 Clear a leftover VisiblePosition variable from SelectionController This VisiblePosition-typed variable should have been cleared in crrev.com/1501035 but was left over. This CL clears it. Bug: 657237 Change-Id: Idec9cb0e6a4709bece76e6ed36da325d7ab7fba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507134 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638424} .../blink/renderer/core/editing/selection_controller.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) commit 0503893b780a758404899f893cd6b408c2f6cf87 Author: Mei Liang <meiliang@chromium.org> Date: Thu Mar 7 04:44:04 2019 +0000 Add accessibility strings for tab groups feature IPHs This CL adds accessibility strings for tab group feature IPHs and updates tab groups related strings description according to the spec. Bug: 938522 Change-Id: I7efec5e3eeedb76135975ceb30dc3077d70a9439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504162 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638423} .../java/res/layout/bottom_tab_grid_toolbar.xml | 2 +- .../java/res/layout/bottom_tab_strip_toolbar.xml | 2 +- .../browser/tasks/tab_groups/TabGroupUtils.java | 10 ++++++++-- .../tasks/tab_list_ui/TabStripViewBinder.java | 5 +++++ .../android/java/strings/android_chrome_strings.grd | 20 ++++++++++++++++---- 5 files changed, 31 insertions(+), 8 deletions(-) commit 2c9819fd046498acf1400b088877341ae8ee3618 Author: wutao <wutao@chromium.org> Date: Thu Mar 7 04:37:16 2019 +0000 app_list: Add unit tests for embedded Assistant UI This patch adds unit tests for emebedded Assistant UI to test the basic UI visibility and app list states. Bug: 924624 Test: AppListView*Test:*EmbeddedAssistantUI* Change-Id: I588ffb174d5f4e6ec2a1e0c80d139648740a01fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501514 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#638422} ash/app_list/BUILD.gn | 1 + ash/app_list/DEPS | 1 + ash/app_list/test/app_list_test_view_delegate.cc | 5 + ash/app_list/test/app_list_test_view_delegate.h | 2 + ash/app_list/views/app_list_view_unittest.cc | 157 +++++++++++++++++++++ .../views/assistant/assistant_page_view.cc | 11 +- 6 files changed, 174 insertions(+), 3 deletions(-) commit 63e07e35ad93774e5515813c9b56bbab01855fc0 Author: Dan Beam <dbeam@chromium.org> Date: Thu Mar 7 04:32:10 2019 +0000 WebUI Dark Mode: remove inapplicable CSS As far as I can tell, this CSS doesn't work. Removing it instead of attempting to update it for dark mode. R=dpapad@chromium.org BUG=926658 Change-Id: I34213a54828c2becc3b59cfcdd60f8de72bdad2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506389 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638421} .../settings/site_settings/category_setting_exceptions.html | 10 ---------- 1 file changed, 10 deletions(-) commit bb8bb4ec442c2a4ba4170c498798e9b0b82348f6 Author: Eugene But <eugenebut@chromium.org> Date: Thu Mar 7 04:30:37 2019 +0000 Remove google_toolbox_unittest.mm as unnecessary. The test was calling gtm_dictionaryWithHttpArgumentsString method to verify that method exists. Chrome does not call this method, so there is no need to test method existence. Bug: 933827 Change-Id: I86200d3d8bbb9096f12277b7e951422b07672d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500628 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638420} ios/chrome/test/BUILD.gn | 14 -------------- ios/chrome/test/google_toolbox_unittest.mm | 29 ----------------------------- 2 files changed, 43 deletions(-) commit d2688e663c6339c86b0b5f46056ceb15b5ef56ba Author: Kayce Basques <kayce@google.com> Date: Thu Mar 7 04:15:05 2019 +0000 DevTools: Update WNDT for m74 Bug: 939147 Change-Id: Ic3a208e37a863b695da91af04d0485efe738d118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506305 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Auto-Submit: Kayce Basques <kayce@google.com> Cr-Commit-Position: refs/heads/master@{#638419} .../devtools/front_end/Images/whatsnew.png | Bin 12074 -> 11902 bytes .../devtools/front_end/help/ReleaseNoteText.js | 38 +++++++++++++++++++++ 2 files changed, 38 insertions(+) commit 0bc420c70f1c4e682e621e757b68d12b6c44bd4a Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Thu Mar 7 04:12:26 2019 +0000 Updating trunk VERSION from 3727.0 to 3728.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I57c94f248bf2db118e94903f6861c81289b07f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507013 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#638418} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d52badd3289c665c2a096c1815f1e92536006129 Author: Stefan Zager <szager@chromium.org> Date: Thu Mar 7 04:11:59 2019 +0000 Speculative fix for DCHECK failure The root cause for the failure is most likely a change in when the flags controlling frame throttling are updated. That changed when the IntersectionObserver steps were moved to run in a post-lifecycle step. It's possible that a frame was marked as throttled at the time that UpdateAllLifecyclePhases ran, so it was skipped for update; but the throttled flag was flipped to unthrottled before the code path where the crash occurs, so that the call to ShouldThrottleRendering() does not reflect the state of throttling when the lifecycle ran. BUG=938651 R=schenney@chromium.org Change-Id: Ifb7e50d40f096e333e45e5e8610ef7ab7671bee7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506757 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#638417} third_party/blink/renderer/core/layout/layout_embedded_content.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit c78f6f42b6e74769666f43f7b8953a1c682606a2 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Thu Mar 7 03:57:52 2019 +0000 Add triggering for IPH_TabGroupsQuicklyComparePages Enable triggering of IPH_TabGroupsQuicklyComparePages when tab groups feature is enabled. Bug: 930970 Change-Id: I9182bb3ebe40c00d9dd03f7eb234bde4f1d800c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497638 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638416} .../browser/tasks/tab_list_ui/BottomTabGridCoordinator.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit dd00f9f49eee7ef2659da7a4a2722c2814d878fc Author: dpapad <dpapad@chromium.org> Date: Thu Mar 7 03:54:14 2019 +0000 WebUI cleanup: Remove dead code connection_manager.js This file is only referenced by a test HTML file, which in turn is not referenced anywhere. Deleting both. Bug: None Change-Id: I2f872560da6aec7c7b98bdeb57501a9f2cd2a021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507236 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638415} chrome/browser/resources/connection_manager.js | 25 ----------- chrome/test/data/chromeos/mobile_activation.html | 55 ------------------------ 2 files changed, 80 deletions(-) commit f08b00523586e176527d982f968476a8a3ff993a Author: Justin Cohen <justincohen@google.com> Date: Thu Mar 7 03:43:34 2019 +0000 Reland "Enable -Wextra-semi in iOS builds." This reverts commit b89cc6179f7f2946d57bc6d028878234d1392d51. Bug: 936211, 926235 Change-Id: Ia62f48168f41302582a607b2695cb1b379529945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506880 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638414} build/config/compiler/BUILD.gn | 2 +- ios/chrome/browser/ui/omnibox/omnibox_view_ios.h | 4 ++-- ios/web/public/test/fakes/test_web_client.mm | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) commit 271e639f91927217a7625010ac85eaa13b3294bd Author: Matthew Dempsky <mdempsky@google.com> Date: Thu Mar 7 03:38:36 2019 +0000 [base] Set MAP_JIT when allocating V8 pages on Fuchsia The V8 JIT requires the ability to re-map heap pages as executable, but Fuchsia only allows this with pages allocated with MAP_JIT. Bug: 927411 Change-Id: I589981de14e0a8646ed3e245d237f10b92b26118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504507 Reviewed-by: Chris Palmer <palmer@chromium.org> Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Matthew Dempsky <mdempsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638413} .../partition_allocator/page_allocator_internals_posix.h | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit d8c60acc435cce505d16c056fc7c7e9531eee8b2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 03:37:17 2019 +0000 Roll Fuchsia SDK from 30c5e3c76330 to bb61479483bd The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I6c1dc894e745547c7a083b7219cab3c63cd33085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506209 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638412} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit c50e5ea61456f3683cfa86806444451404d7fa16 Author: shrekshao <shrekshao@google.com> Date: Thu Mar 7 03:34:30 2019 +0000 bit operation optimization for check float32 color attachment, fix for draw buffer enabled Bug: chromium:930993 Change-Id: I4cda4f4dfd7802cbce46b81048e3676d7469a861 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496098 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#638411} .../gpu_tests/webgl2_conformance_expectations.py | 2 -- gpu/command_buffer/common/gles2_cmd_utils.cc | 13 +++++++++++++ gpu/command_buffer/common/gles2_cmd_utils.h | 1 + gpu/command_buffer/service/framebuffer_manager.cc | 21 +++++++++------------ gpu/command_buffer/service/framebuffer_manager.h | 5 ++++- gpu/command_buffer/service/gles2_cmd_decoder.cc | 2 +- 6 files changed, 28 insertions(+), 16 deletions(-) commit 3cd82093e5165ece8df009be82df260a30ca2c7c Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Mar 7 03:30:37 2019 +0000 Android: Make TabFullscreenHandler Tab's UserData This CL makes TabFullscreenHandler Tab's UserData so that Tab doesn't have to manage |mFullscreenHandler|. Bug: 924242 Change-Id: I5a3ea1fc15a8e5d09ab0b1a5ac048feaa2471a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496272 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#638410} .../src/org/chromium/chrome/browser/tab/Tab.java | 5 +--- .../chrome/browser/tab/TabFullscreenHandler.java | 31 +++++++++++++++++++++- 2 files changed, 31 insertions(+), 5 deletions(-) commit 27309f38c3d3ce5f83b682b13cf98980ec8d9210 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Thu Mar 7 03:16:58 2019 +0000 [Payment Request][Android] Block payment UI from background tab Before this patch, a background tab could show the payment sheet. This patch aborts payment if the web contents of the currently active tab are not the same as the web contents that invoked the PaymentRequest API. After this patch, Chrome rejects the PaymentRequest.show() with "AbortError: Request cancelled" if it was called from a tab that is not currently shown to the user. Bug: 939162 Change-Id: Ia4e3eba7b882b5361185536e5b2b96edc80f5a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507125 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638409} .../chromium/chrome/browser/payments/PaymentRequestImpl.java | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 5c8bd34ba33e815d4a4ae0b1b872926b0f8b5c74 Author: John Lee <johntlee@chromium.org> Date: Thu Mar 7 03:14:29 2019 +0000 Navi: Align NTP background module's buttons with other modules' buttons Bug: 938945 Change-Id: I6fb499405dcf511545cd5c71f93cb7d569b18cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506386 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#638408} .../ntp_background/nux_ntp_background.html | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) commit 8760a095a4a0509d521a064a79a8aec1895d5a51 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Thu Mar 7 03:13:12 2019 +0000 [TaskScheduler]: Distribute waking-up workers. This CL distributes waking-up workers to avoid having 1 thread waking-up many workers. This implies: - Cap num_workers_to_wakeup to 2 in EnsureEnoughWorkersLockRequired. - Call EnsureEnoughWorkersLockRequired from GetWork(), so it can wakeup more workers (which will, in turn wakeup other workers). This is ground work for supporting TaskSource with concurrency > 1 and shouldn't have a big impact currently since it's rare for EnsureEnoughWorkersLockRequired() to wakeup many workers. RepeatedWillBlockDoesNotCreateTooManyWorkers had to be adapted; The test didn't take into account the idle thread, and it seems there was no code path maintaining the idle thread in this situation. This CL changes this and an idle thread is now created, which the test need to take into account. TBR=fdoray@chromium.org Change-Id: If2479b703ff6d85a0f11e73908ff1e09ed249c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474462 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#638407} base/synchronization/lock.h | 40 +--------- base/synchronization/lock_impl.h | 45 +++++++++++ base/task/task_scheduler/scheduler_lock.h | 19 +---- .../task_scheduler/scheduler_worker_pool_impl.cc | 88 ++++++++++++++-------- .../task_scheduler/scheduler_worker_pool_impl.h | 2 +- .../scheduler_worker_pool_impl_unittest.cc | 30 ++++++-- 6 files changed, 133 insertions(+), 91 deletions(-) commit 7568f3959c7250f78f8684b673e68c9ac3024816 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Mar 7 03:03:07 2019 +0000 [Files app] Fix context menu for MyFiles and Downloads. Downloads special case from shouldShowMenuItemsForEntry so it doesn't hide copy, zip-selection and paste-into-folder, change special case for destructing commands cut, delete and rename. This affects directory tree and file list context menus. Change EntryListItem to use non-root context menu to display #new-folder command for MyFiles, but continue to use root context menu for removable (USB/SDCard). This only affects diretory tree context menus. Bug: 925516, 932772 Change-Id: I00c17c5f5144b0be96055fc107857b055d07732d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498733 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#638406} .../foreground/js/file_manager_commands.js | 62 ++++++++++++++----- .../foreground/js/file_transfer_controller.js | 43 ++++++++++++-- .../foreground/js/ui/directory_tree.js | 17 +++--- .../integration_tests/file_manager/context_menu.js | 69 ++++++++++++++++++---- .../file_manager/directory_tree_context_menu.js | 7 ++- 5 files changed, 162 insertions(+), 36 deletions(-) commit 943666d65de7d814d8c001fd2ae582c85b2092b6 Author: Andrew Xu <andrewxu@chromium.org> Date: Thu Mar 7 02:58:48 2019 +0000 Fix alloc-dealloc-mismatch drmModeConnectorPtr and drmModeCrtc are destructed by "free". So their memory should be allocated by "malloc" instead of "new". Bug: 937638 Change-Id: I34737a692963735a8e88c8e1a0012ad6b09666fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501996 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#638405} .../platform/drm/gpu/drm_gpu_display_manager_unittest.cc | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) commit 877606c94f9539ed74cb6286dbbb22887f8bdce8 Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 02:56:58 2019 +0000 Fix flakiness in ProfileProviderTest by shutting down LoginState Bug: 939160 Change-Id: Ib7dd41dc550ffa712720cc633aa7585e4f4d6d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506451 Reviewed-by: Gabriel Marin <gmx@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638404} chrome/browser/metrics/perf/profile_provider_chromeos_unittest.cc | 1 + 1 file changed, 1 insertion(+) commit 6cf760c73c30f3873b9af2acd95fb02ef7664536 Author: CJ DiMeglio <lethalantidote@chromium.org> Date: Thu Mar 7 02:56:22 2019 +0000 Changes anti-duplication stratgey from controlling focus to using aria. Previously with screenreaders we were seeing duplication of information, due to a container being selectable/aria-readable. The initial solution was to make this container unselectable, but this caused the menu to be unusable. This new solution instead makes the containter aria-hidden, and sets the information previously obtained from its children on the parent label. Bug: 919446 Change-Id: I6b5a057b24ccc43c9f7deebe7805ee8f2a6a3821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1401454 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#638403} .../elements/media_control_input_element.cc | 31 +++++++++++++++------- .../elements/media_control_input_element.h | 9 +++++++ 2 files changed, 31 insertions(+), 9 deletions(-) commit 621af44e5ff301a35802576994e1011a1826794a Author: Evan Stade <estade@chromium.org> Date: Thu Mar 7 02:54:23 2019 +0000 Fix flakiness in EventBasedStatusReportingServiceTest by shutting down SystemClockClient as appropriate. Bug: 939160 Change-Id: I145b2b96e602b412340e56858172a66e9dd8dca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507216 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638402} .../child_accounts/event_based_status_reporting_service_unittest.cc | 1 + 1 file changed, 1 insertion(+) commit a4f0d39448ab72a481bdabb2d5c2fce5e20e90c4 Author: Jun Mukai <mukai@chromium.org> Date: Thu Mar 7 02:53:34 2019 +0000 Synchronize ClientSurfaceEmbedder visibility with its window Bug: 936603 Test: manually Change-Id: I2b83069342dc094c097a5d26b6a63cd9ac5364ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506662 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638401} ui/aura/mus/client_surface_embedder.cc | 27 ++++++++++++++++++++++++++- ui/aura/mus/client_surface_embedder.h | 11 ++++++++--- 2 files changed, 34 insertions(+), 4 deletions(-) commit 6eced5f2dc442bba5ccccf311f3c67733f3200c1 Author: Simon La Macchia <smacchia@amazon.com> Date: Thu Mar 7 02:48:49 2019 +0000 Add Bluetooth keyboard support to Protected media content site setting Problem: The Protected media content Site Setting does not support Bluetooth keyboard navigation. The three radio buttons are treated as one clickable target, making the individual radio buttons unselectable. Solution: Make radio buttons selectable and clickable to support navigation with a Bluetooth keyboard. This behavior matches existsing Chrome settings support for Bluetooth keyboard navigation. This change does not affect navigate by touch and will work the same as before. R=twellington@chromium.org Bug: 936143 Change-Id: Ib14c4515d5a70fa0cb8344727b367e2c9260c36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490016 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Simon La Macchia <smacchia@amazon.com> Cr-Commit-Position: refs/heads/master@{#638400} chrome/android/java/res/layout/confirm_import_sync_data.xml | 2 ++ chrome/android/java/res/layout/radio_button_with_description.xml | 3 +++ .../java/res/layout/tri_state_site_settings_preference.xml | 8 +++++++- .../preferences/website/TriStateSiteSettingsPreference.java | 5 +++++ .../chrome/browser/widget/RadioButtonWithDescription.java | 8 +++++++- 5 files changed, 24 insertions(+), 2 deletions(-) commit 00ca4c98e71d260b30e700fa2312c8ce7bdfbf88 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 02:46:03 2019 +0000 Roll src/third_party/swiftshader 2c25b14c34c1..2995dc2a67c7 (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/2c25b14c34c1..2995dc2a67c7 git log 2c25b14c34c1..2995dc2a67c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-07 chrisforbes@google.com Wire up depth and stencil attachments to pipeline 2019-03-06 bclayton@google.com Split regres test lists into full and CI lists. 2019-03-06 bclayton@google.com SpirvShader: Implement OpSelect 2019-03-06 bclayton@google.com SpirvShader: Add relational ops for ordered and unordered floats 2019-03-06 headlessclayton@gmail.com Plumb PipelineLayouts down to SpirvRoutine Created with: gclient setdep -r src/third_party/swiftshader@2995dc2a67c7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118619338,chromium:b/127664487,chromium:b/126873455,chromium:b/127282157,chromium:b/126330097 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib56a0bdeae8091e34222176c6e6b5ee0189829b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506575 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638399} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 518d025c85b2004025019e1a5ac29305d2b95b1f Author: Siddhartha S <ssid@chromium.org> Date: Thu Mar 7 02:44:46 2019 +0000 Move Chrome trace argument filter to services/tracing This CL is split from: https://chromium-review.googlesource.com/c/chromium/src/+/1491032 This does not move the webview whitelists into services/tracing. The argument filter is set by chrome delegate in each process. But, tracing service runs as a sandboxed process, where the filter is not set. In Perfetto backend json convertor filters arguments for all events in the service process. So, move the filter to services/ and ensure it is always used. In short term, webview will continue using the filter as it is till we agree on how to properly serialize the filter for Perfetto bcakend. BUG=925148 TBR=avi@chromium.org Change-Id: Ifaa491cbaf215f718a534063d39cbd771261cb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506659 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#638398} .../tracing/aw_trace_event_args_whitelist.cc | 4 ++ .../tracing/aw_trace_event_args_whitelist.h | 6 +++ android_webview/lib/aw_main_delegate.cc | 2 + base/trace_event/trace_event_impl.h | 12 +++-- base/trace_event/trace_log.cc | 15 +++++- base/trace_event/trace_log.h | 5 ++ chrome/app/chrome_main_delegate.cc | 4 -- chrome/browser/tracing/chrome_tracing_delegate.cc | 6 --- chrome/browser/tracing/chrome_tracing_delegate.h | 2 - chrome/common/BUILD.gn | 2 - chrome/common/OWNERS | 5 -- .../background_tracing_manager_browsertest.cc | 38 +++----------- .../tracing/tracing_controller_browsertest.cc | 35 +------------ content/browser/tracing/tracing_controller_impl.cc | 12 ++--- content/public/browser/tracing_delegate.cc | 4 -- content/public/browser/tracing_delegate.h | 5 -- .../perfetto/chrome_event_bundle_json_exporter.cc | 5 +- .../perfetto/chrome_event_bundle_json_exporter.h | 5 +- .../chrome_event_bundle_json_exporter_unittest.cc | 44 ++++------------ services/tracing/perfetto/json_trace_exporter.cc | 32 ++++++------ services/tracing/perfetto/json_trace_exporter.h | 37 +++++--------- .../perfetto/json_trace_exporter_unittest.cc | 59 ++++++++-------------- .../perfetto/perfetto_tracing_coordinator.cc | 6 +-- services/tracing/public/cpp/BUILD.gn | 2 + services/tracing/public/cpp/trace_event_agent.cc | 12 +++++ .../public/cpp}/trace_event_args_whitelist.cc | 22 +++++--- .../public/cpp}/trace_event_args_whitelist.h | 21 ++++++-- 27 files changed, 160 insertions(+), 242 deletions(-) commit b646284c9f9530a4be918d11e70cc8a00a608939 Author: Burton <burton@typewritten.net> Date: Thu Mar 7 02:43:36 2019 +0000 Modified the HSTS list and AUTHORS Removals -------- 1. Removed NCSCCS HPKP code as it is deprecated. 2. Removed the sirburton.com domain as it is deprecated. 3. Removed the 0.me.uk domain as it is deprecated. 4. Removed the themathematician.uk domain as it is deprecated. 5. Removed the ncsccs.com domain as it is deprecated. Changes ------- 1. Moved the calculates.org domain to manual section. 2. Moved the codebreaking.org domain to manual section. 3. Moved the typewritten.net domain next to my other domains. Addition -------- 1. Added the comment above these domains in the HSTS list: - Burton domains (contact: burton at typewritten.net). - In case you need contact me in regard to the domains. 2. Added the name "Burton <burton@typewritten.net>" - I don't include firstname anymore. Burton R=nharper@chromium.org Change-Id: Iba0784cf582b4e800c1c48e238a580d5ebb0a3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506392 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#638397} AUTHORS | 1 + net/http/transport_security_state_static.json | 38 ++---------------- net/http/transport_security_state_static.pins | 56 --------------------------- 3 files changed, 5 insertions(+), 90 deletions(-) commit 53fd8d0b7368ba111402f937aa4b9163954485cd Author: Ian Swett <ianswett@chromium.org> Date: Thu Mar 7 02:42:37 2019 +0000 Add QUIC connection close details to the netlog. R=rch@chromium.org Change-Id: Ic8cbf358f796827f4570a8cb285a5438060ab953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506000 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638396} net/log/net_log_event_type_list.h | 4 +++- net/quic/quic_connection_logger.cc | 8 +++++--- 2 files changed, 8 insertions(+), 4 deletions(-) commit 9685b6a1503093f0669c224649a262768e4e8895 Author: Ryan Hamilton <rch@chromium.org> Date: Thu Mar 7 02:37:13 2019 +0000 Add a new histograms.xml entry for Net.QuicDroppedPacketReason, which records the reason a QUIC packet could not be processed, logged for each dropped packet. (And adds the associated enums.xml entry) The histogram was added in https://chromium-review.googlesource.com/c/chromium/src/+/1498774/2/net/third_party/quic/core/quic_framer.cc#444 Change-Id: I0ba6bf960b9f6260edab4cf517c1f4038b0874f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506102 Commit-Queue: Ryan Hamilton <rch@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#638395} tools/metrics/histograms/enums.xml | 10 ++++++++++ tools/metrics/histograms/histograms.xml | 8 ++++++++ 2 files changed, 18 insertions(+) commit 0a60a7a5119845da26e2211dfe511ebad2fa8df1 Author: Amit Hilbuch <amithi@chromium.org> Date: Thu Mar 7 02:25:18 2019 +0000 Adding histograms for measuring usage of Simulcast. This adds the histograms that are used to measure usage of simulcast. Histograms are added for: 1. Counting the number of send encodings in calls to AddTransceiver. 2. Counting the number of times that simulcast was disabled because remote party did not negotiate it back. 3. Counting how simulcast was indicated in calls to ApplyLocalDescription and ApplyRemoteDescription. Specifically counting no simulcast, legacy simulcast and spec-compliant. Bug: webrtc:10372 Change-Id: I95ef97bde88b36f0ce9c057363811417a5e1c9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497325 Reviewed-by: Steve Anton <steveanton@chromium.org> Reviewed-by: Seth Hampson <shampson@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638394} tools/metrics/histograms/enums.xml | 6 ++++++ tools/metrics/histograms/histograms.xml | 32 ++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) commit fab5ba9e8b24f90439e2dbbf07ac37310b026f85 Author: Josh Nohle <nohle@chromium.org> Date: Thu Mar 7 02:24:57 2019 +0000 Revert "Use existing kUserKeyPair keys during key creation, if possible." This reverts commit 657a8c539a653fdd91dacd7a78a9fe88f6f706c9. Reason for revert: ASAN errors; container overflow Original change's description: > Use existing kUserKeyPair keys during key creation, if possible. > > In CyptAuth v2 Enrollment, the user key pair--also known as > CryptAuthKeyBundle::Name::kUserKeyPair or "PublicKey"--has special > standing in order to 1) accommodate any existing key from v1 Enrollment > and 2) enforce that the key is not rotated. Only one user key pair > should exist in its key bundle, and it should be an active, P-256 key > with handle "device_key". > > It is possible that CryptAuth could request the creation of a new user > key pair even if the client sends information about an existing key in > the SyncKeysRequest. If this happens, the client should re-use the > existing user key pair key material when creating a new key. At the end > of the enrollment flow, the existing key will be replaced with this new > key that has the same public/private keys, but possibly with a new key > directive. > > It might seem more efficient to simply ignore the key-creation request, > but the method outlined above natually fits into the enrollment flow, > the key directive will be updated, and the client will be able to > provide CryptAuth with an EnrollKeys request, which it might be > expected. > > Bug: 899080 > Change-Id: I3a4a63aa902090698ecb619bc7af78ff1e790c23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504121 > Commit-Queue: Josh Nohle <nohle@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638327} TBR=khorimoto@chromium.org,nohle@chromium.org Change-Id: Ida02d62899eecc6a391e05b34bf576ff12e9541f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507279 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#638393} .../device_sync/cryptauth_enrollment_result.cc | 6 +- .../device_sync/cryptauth_enrollment_result.h | 3 - .../services/device_sync/cryptauth_key_creator.cc | 16 -- .../services/device_sync/cryptauth_key_creator.h | 15 -- .../device_sync/cryptauth_key_creator_impl.cc | 50 ++-- .../device_sync/cryptauth_key_creator_impl.h | 3 +- .../cryptauth_key_creator_impl_unittest.cc | 203 +++++---------- .../device_sync/cryptauth_v2_enroller_impl.cc | 118 +++------ .../device_sync/cryptauth_v2_enroller_impl.h | 11 - .../cryptauth_v2_enroller_impl_unittest.cc | 278 +++++++-------------- 10 files changed, 199 insertions(+), 504 deletions(-) commit c99f13fc63ba399ce3bb56d18225dd804d09b49f Author: mrefaat <mrefaat@chromium.org> Date: Thu Mar 7 02:24:13 2019 +0000 Remove the usage of Tab from AppLauncherTabHelper tab.browserState used to get the ReadingListModel, So instead use webState to get ChromeBrowserState which can be used to get ReadingListModel Bug: 902044 Change-Id: I66d84993e9d74f301b872e53c2b09dd75a106463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504496 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638392} ios/chrome/browser/app_launcher/BUILD.gn | 3 +-- ios/chrome/browser/app_launcher/app_launcher_tab_helper.mm | 10 +++++----- .../browser/app_launcher/app_launcher_tab_helper_unittest.mm | 3 --- 3 files changed, 6 insertions(+), 10 deletions(-) commit 8a62ae785255ef149086f6a5ee93ffa437027153 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 02:23:19 2019 +0000 Roll src/third_party/chromite c3ec692344cb..4ad364d5cbb9 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c3ec692344cb..4ad364d5cbb9 git log c3ec692344cb..4ad364d5cbb9 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 vapier@chromium.org cbuildbot: run ctest out of crostestutils Created with: gclient setdep -r src/third_party/chromite@4ad364d5cbb9 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I52f53a5cabd3b57eb79e5ba4a3932908ec2034fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507133 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638391} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 23e75473e540ac4d516f467f151e5b7546702be4 Author: Josh Nohle <nohle@chromium.org> Date: Thu Mar 7 02:21:42 2019 +0000 Revert "Use key bundle name instead of key handle for HKDF "info" parameter" This reverts commit c439e081a77327dca2ca4580c08e183b76aca374. Reason for revert: <INSERT REASONING HERE> Original change's description: > Use key bundle name instead of key handle for HKDF "info" parameter > > In the CryptAuth v2 Enrollment flow, a key derivation function (HKDF) is > needed for symmetric key generation and symmetric key proof computation. > The v2 Enrollment protocol specifies that the "info" input parameter to > HKDF should be the key bundle name, e.g. "PublicKey" or "authzen"; > however, we were previously using the key handle. > > We verified this through manual testing. > > Bug: 899080 > Change-Id: I31e6d5d4aba819f17b960744bd70f80c07ea9867 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504310 > Commit-Queue: Josh Nohle <nohle@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638378} TBR=khorimoto@chromium.org,nohle@chromium.org Change-Id: Ic53495e0755ed26a6ec121bac81dad7ee92ed341 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507278 Reviewed-by: James Hawkins <jhawkins@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#638390} .../services/device_sync/cryptauth_key_creator.h | 2 +- .../device_sync/cryptauth_key_creator_impl.cc | 32 ++++++++++++++++------ .../device_sync/cryptauth_key_creator_impl.h | 3 +- .../cryptauth_key_creator_impl_unittest.cc | 2 +- .../device_sync/cryptauth_key_proof_computer.h | 18 ++++-------- .../cryptauth_key_proof_computer_impl.cc | 19 ++++++------- .../cryptauth_key_proof_computer_impl.h | 12 +++----- .../cryptauth_key_proof_computer_impl_unittest.cc | 21 ++++++-------- .../device_sync/cryptauth_v2_enroller_impl.cc | 8 ++---- .../cryptauth_v2_enroller_impl_unittest.cc | 8 ++---- .../fake_cryptauth_key_proof_computer.cc | 7 ++--- .../fake_cryptauth_key_proof_computer.h | 12 +++----- 12 files changed, 68 insertions(+), 76 deletions(-) commit 8784a0af522a9233c0fcc1b06579ade09d87e780 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Thu Mar 7 02:15:58 2019 +0000 desktop-pwas: Introduce TestAppRegistrar in PendingBookmarkAppManager unit tests Now that PendingBookmarkAppManager doesn't access ExtensionRegistry and ExtensionPrefs directly for installations, we can avoid faking some cases in tests. PendingBookmarkAppManager still uses ExtensionRegistry for uninstallations so we still need to fake some calls to it. Once we abstract uninstallation, we can remove all usage of ExtensionRegistry from tests. Bug: 916381 Change-Id: Ied92df67f8cb6ab7d07ffa5ea64b487e5d50d6e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502258 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#638389} chrome/browser/web_applications/BUILD.gn | 2 ++ .../web_applications/components/app_registrar.h | 1 + .../pending_bookmark_app_manager_unittest.cc | 24 ++++++++----- .../web_applications/test/test_app_registrar.cc | 41 ++++++++++++++++++++++ .../web_applications/test/test_app_registrar.h | 41 ++++++++++++++++++++++ 5 files changed, 100 insertions(+), 9 deletions(-) commit a4f460ab89ff6388714f2dc194d9dc3365c00ec1 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Mar 7 02:15:08 2019 +0000 Fix warn_unused_result attribute failure On some libcs posix_memalign is defined with warn_unused_result. Check its return value and handle it appropriately in this test. Change-Id: Iaa7151fe101b0dfc04192229a9a8751e1f92507f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507037 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#638388} components/gwp_asan/client/sampling_allocator_shims_unittest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 629b06d5fdaeffe1e219b7c567faa9e420354c7a Author: Yusuf Ozuysal <yusufo@google.com> Date: Thu Mar 7 02:14:50 2019 +0000 UI and lifecycle Polish on TabStripBottomToolbar components - Set the buttons to be bottomToolbar buttons to get modern selection animations - Handles a crash on construction that calls the Mediator while being constructed - Adds ViewHolder class to BottomTabGridSheet to handle top margin - The TabStripBottomToolbarCoordinator now takes a parentView which will own the coordinator, so ActivityScope is removed BUG=930900 Change-Id: I3966e9d6b576a92505fb79aae511a37bd7d27dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506469 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638387} .../java/res/layout/bottom_tab_grid_toolbar.xml | 20 +++----- .../java/res/layout/bottom_tab_strip_toolbar.xml | 27 ++++------- chrome/android/java/res/values/dimens.xml | 1 - .../tab_list_ui/BottomTabGridCoordinator.java | 4 +- .../tasks/tab_list_ui/BottomTabGridMediator.java | 31 ++++++++----- .../tab_list_ui/BottomTabGridSheetContent.java | 21 +++++---- ...ties.java => BottomTabGridSheetProperties.java} | 8 ++-- .../BottomTabGridSheetToolbarCoordinator.java | 11 +++-- .../BottomTabGridSheetToolbarViewBinder.java | 34 -------------- .../tab_list_ui/BottomTabGridSheetViewBinder.java | 54 ++++++++++++++++++++++ .../tab_list_ui/BottomTabListToolbarView.java | 6 +-- .../TabStripBottomToolbarCoordinator.java | 43 +++-------------- .../tab_list_ui/TabStripBottomToolbarMediator.java | 22 +-------- chrome/android/java_sources.gni | 4 +- 14 files changed, 126 insertions(+), 160 deletions(-) commit bb1a58cf6775ae7289014c04d311837223d88699 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 02:12:18 2019 +0000 Roll src/third_party/skia 93c47cc8e359..3c957d575c58 (6 commits) https://skia.googlesource.com/skia.git/+log/93c47cc8e359..3c957d575c58 git log 93c47cc8e359..3c957d575c58 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2f034a6e32fc..ca7eff86b174 (489 commits) 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 2c25b14c34c1..76e9bc066b28 (1 commits) 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-06 fmalita@chromium.org Make SkCubicMap immutable 2019-03-06 brianosman@google.com Particle cleanup: IWYU 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9584fe43a9c2..2c25b14c34c1 (1 commits) Created with: gclient setdep -r src/third_party/skia@3c957d575c58 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: Ifcc8925beac65031c0985b5816cfd132ab10913a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507132 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638386} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f5afc224d8a5f9d8c7a2cc8cf86f5b8ba44f29ca Author: John Lee <johntlee@chromium.org> Date: Thu Mar 7 02:10:14 2019 +0000 Navi A11y: Remove aria-pressed attribute on NTP background buttons Bug: 938090 Change-Id: I0d4ef918d5eaf32b75f4122204fc0ffb208cae10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506655 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#638385} .../onboarding_welcome/ntp_background/nux_ntp_background.html | 2 -- .../onboarding_welcome/ntp_background/nux_ntp_background.js | 8 -------- chrome/test/data/webui/welcome/nux_ntp_background_test.js | 3 --- 3 files changed, 13 deletions(-) commit e6516e1538c030b82f775cb3cdd758a64a6ce1b4 Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Mar 7 02:09:30 2019 +0000 Fix network service crash on shutdown if it's not initialized. Bug: 937803 Change-Id: I68cc01cf8c2a6f5bd5232f2c3f4296352ef181d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507193 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#638384} services/network/network_service.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 6946c0cda65025858ccf8f80beb1aa36a76d2e03 Author: Scott Violet <sky@chromium.org> Date: Thu Mar 7 02:03:57 2019 +0000 chromeos: adds histogram for interactive window resize The histogram is logged any time the user resizes a window via mouse/touch. The delta is the time between when the resize started, and when the next frame was presented (pixels painted on screen). This doesn't cover some cases (such as tablet-mode resizing) but is a good start. BUG=none TEST=covered by tests Change-Id: I509a34203f76c198f3135a8cb386a0b11e20c90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495377 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638383} ash/components/shortcut_viewer/BUILD.gn | 1 + ash/components/shortcut_viewer/DEPS | 1 + .../views/keyboard_shortcut_view_unittest.cc | 8 ++--- ash/wm/default_window_resizer.cc | 2 +- ash/wm/default_window_resizer_unittest.cc | 39 ++++++++++++++++++++++ ash/wm/pip/pip_window_resizer.cc | 2 +- ash/wm/window_resizer.cc | 38 ++++++++++++++++++++- ash/wm/window_resizer.h | 4 +++ ash/wm/workspace/workspace_window_resizer.cc | 2 +- .../workspace/workspace_window_resizer_unittest.cc | 21 ++++++++++++ tools/metrics/histograms/histograms.xml | 10 ++++++ ui/aura/window_tree_host_platform.cc | 3 +- ui/compositor/test/test_utils.cc | 12 +++++++ ui/compositor/test/test_utils.h | 5 +++ 14 files changed, 137 insertions(+), 11 deletions(-) commit d1a89a795854e6608588d8d7bcf2277fd31b2d87 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Mar 7 01:53:40 2019 +0000 Fix improper usage of std::vector in UDPSocketPosixSender The issue is that |msg_iov| and |msgvec| use std::vector as the underlying container, but the usage of the container is something like: msg_iov.reserve(kWriteAsyncMaxBuffersThreshold + 1); msg_iov[0].field = ...; // Access an element that doesn't yet exist. This CL changes the usage to msg_iov->push_back(...) so that the underlying vector updates its size and operator[] will work. This is necessary to fix the build with _LIBCPP_DEBUG=0. Otherwise we get errors of the form: buildtools/third_party/libc++/trunk/include/vector:1542: _LIBCPP_ASSERT '__n < size()' failed. vector[] index out of bounds BUG=923166 R=davidben Change-Id: I364be618011c4c0e65627e530dde9e6dc3f7375f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506384 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#638382} net/socket/udp_socket_posix.cc | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) commit 262e63b1f84f29bd1e90f3fad1645cff2a46a213 Author: Robert Ma <robertma@chromium.org> Date: Thu Mar 7 01:53:34 2019 +0000 Add expectations to unblock wpt-import Mostly about a cross-origin test. See the linked bug for details. TBR=foolip No-Try: True Bug: 939181 Change-Id: Id970e97379073fe878dc19d1eb0200479fded894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507246 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#638381} third_party/blink/web_tests/TestExpectations | 5 ++-- .../cross-origin-objects-expected.txt | 31 ---------------------- .../cross-origin-objects-expected.txt | 31 ---------------------- 3 files changed, 3 insertions(+), 64 deletions(-) commit 582c6a260b006e7119d7fafcd822fe32478eed59 Author: Hayato Ito <hayato@chromium.org> Date: Thu Mar 7 01:41:12 2019 +0000 Remove TreeScopeEventContext::Create Remove TreeScopeEventContext::Create and use MakeGarbageCollected at caller side. Change-Id: I7ea353ab29dfb28e1b274a534eea567de8e782a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504487 Auto-Submit: Hayato Ito <hayato@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#638380} third_party/blink/renderer/core/dom/events/event_path.cc | 3 ++- .../blink/renderer/core/dom/events/tree_scope_event_context.cc | 4 ---- third_party/blink/renderer/core/dom/events/tree_scope_event_context.h | 4 +--- 3 files changed, 3 insertions(+), 8 deletions(-) commit e6a7935ed967f945e6df144d71fa49bd9650205d Author: Alex Danilo <adanilo@chromium.org> Date: Thu Mar 7 01:27:21 2019 +0000 Simplify intgration test for recents folder. Change https://chromium-review.googlesource.com/c/chromium/src/+/1491736 adds a test that uses the gear menu to select files in the main FilesApp list view. This change simplifies the unit test to use Ctrl-A to select which is simpler and decouples the test from behavior of the gear menu. Bug: 935345 Tests: Changed integration test and checked it still works. Change-Id: I5e52209d2d9e7ae383b6b5bcb87266f2f2459fba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504595 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#638379} .../integration_tests/file_manager/recents.js | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) commit c439e081a77327dca2ca4580c08e183b76aca374 Author: Josh Nohle <nohle@google.com> Date: Thu Mar 7 01:17:36 2019 +0000 Use key bundle name instead of key handle for HKDF "info" parameter In the CryptAuth v2 Enrollment flow, a key derivation function (HKDF) is needed for symmetric key generation and symmetric key proof computation. The v2 Enrollment protocol specifies that the "info" input parameter to HKDF should be the key bundle name, e.g. "PublicKey" or "authzen"; however, we were previously using the key handle. We verified this through manual testing. Bug: 899080 Change-Id: I31e6d5d4aba819f17b960744bd70f80c07ea9867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504310 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#638378} .../services/device_sync/cryptauth_key_creator.h | 2 +- .../device_sync/cryptauth_key_creator_impl.cc | 32 ++++++---------------- .../device_sync/cryptauth_key_creator_impl.h | 3 +- .../cryptauth_key_creator_impl_unittest.cc | 2 +- .../device_sync/cryptauth_key_proof_computer.h | 18 ++++++++---- .../cryptauth_key_proof_computer_impl.cc | 19 +++++++------ .../cryptauth_key_proof_computer_impl.h | 12 +++++--- .../cryptauth_key_proof_computer_impl_unittest.cc | 21 ++++++++------ .../device_sync/cryptauth_v2_enroller_impl.cc | 8 ++++-- .../cryptauth_v2_enroller_impl_unittest.cc | 8 ++++-- .../fake_cryptauth_key_proof_computer.cc | 7 +++-- .../fake_cryptauth_key_proof_computer.h | 12 +++++--- 12 files changed, 76 insertions(+), 68 deletions(-) commit 45f18e23798148dda8930325a088c41103717d34 Author: Nektarios Paisios <nektar@chromium.org> Date: Thu Mar 7 01:14:52 2019 +0000 Sets the image annotation status when the service request has failed, cancelled, or is adult Also ensures that an empty annotation will set the appropriate status Bug: 905419 TBR: nasko@chromium.org Change-Id: I09eb4ddc6489f015ff137564c89cbc88328e80cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506373 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638377} .../renderer/accessibility/ax_image_annotator.cc | 72 ++++++++++++++++++++-- .../renderer/accessibility/ax_image_annotator.h | 11 ++++ .../renderer/accessibility/blink_ax_tree_source.cc | 4 +- ui/accessibility/ax_enums.mojom | 6 +- 4 files changed, 83 insertions(+), 10 deletions(-) commit c96b0b82026f828523b7b63b5fc8ee4295473b17 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 01:13:07 2019 +0000 Roll src/third_party/depot_tools 61a1b5f31059..48f640f5365e (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61a1b5f31059..48f640f5365e git log 61a1b5f31059..48f640f5365e --date=short --no-merges --format='%ad %ae %s' 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@48f640f5365e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia75a46bd678e86bd089f0b572085de4820c045c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506609 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638376} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a87a38cbfdfd973f516bee8eeabf62f16381aaaa Author: Scott Violet <sky@chromium.org> Date: Thu Mar 7 01:10:52 2019 +0000 chromeos: makes bounds changes from server ignore min/max If the server changes the bounds, we should not consult the delegate to enforce the min/max size. To do othewise means the server and client are not in sync with the bounds. In classic mode, bounds changes done directly to the aura::Window don't flow through the min/max either. This effectively gives that behavior. BUG=938548 TEST=covered by test Change-Id: I8d898365fc9e949e4d68758575d0337deff339a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506879 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#638375} ui/aura/mus/window_tree_host_mus.h | 3 +++ ui/views/mus/desktop_window_tree_host_mus.cc | 7 +++++-- .../mus/desktop_window_tree_host_mus_unittest.cc | 20 ++++++++++++++++++++ 3 files changed, 28 insertions(+), 2 deletions(-) commit f45604fa753cf5beb648c098542ba694176ecb6f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 01:09:31 2019 +0000 Roll src/third_party/dawn b47470daa737..1cc386687cde (1 commits) https://dawn.googlesource.com/dawn.git/+log/b47470daa737..1cc386687cde git log b47470daa737..1cc386687cde --date=short --no-merges --format='%ad %ae %s' 2019-03-06 enga@chromium.org Move CreateFence from Device to Queue Created with: gclient setdep -r src/third_party/dawn@1cc386687cde The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I06be864d30adc32e7fb93f5cf64f14d29c855ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506608 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638374} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 87b225a0dd8c529630cffbe7ee877aad67443479 Author: Oksana Zhuravlova <oksamyt@chromium.org> Date: Thu Mar 7 01:08:03 2019 +0000 [mojo][doc] Update links between pages This change adds a link to 'Receiving responses' section in C++ reference and updates the link to the IPC to Mojo conversion page. Change-Id: I91316b16d9ca2ed51518ebe9671849b4c13ce8f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506610 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638373} docs/mojo_ipc_conversion.md | 2 ++ mojo/public/cpp/bindings/README.md | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) commit be3c1659c5a2748aacad2a4706e969e0f3c3446a Author: Pedro Amaral <amaralp@chromium.org> Date: Thu Mar 7 01:05:58 2019 +0000 Introducing Bottom Controls Component Introduces a new root MVC component for bottom controls UI. This component has a composited component to allow the bottom controls to be scrolled offscreen. Currently only the split toolbar lives in the bottom controls component but soon tab groups bottom toobar will also live there. Change-Id: I2070301da2faf6a2182dacf0a75b66b2bd97e61a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496599 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638372} .../java/res/layout/bottom_control_container.xml | 43 +++++ chrome/android/java/res/layout/bottom_toolbar.xml | 4 +- .../java/res/layout/bottom_toolbar_browsing.xml | 101 +++++------ .../res/layout/bottom_toolbar_tab_switcher.xml | 9 - chrome/android/java/res/layout/main.xml | 6 +- .../chrome/browser/toolbar/ToolbarManager.java | 55 +++--- .../toolbar/bottom/BottomControlsCoordinator.java | 159 +++++++++++++++++ .../toolbar/bottom/BottomControlsMediator.java | 190 +++++++++++++++++++++ .../toolbar/bottom/BottomControlsProperties.java | 46 +++++ .../toolbar/bottom/BottomControlsViewBinder.java | 74 ++++++++ .../toolbar/bottom/BottomToolbarCoordinator.java | 83 +++------ .../BrowsingModeBottomToolbarCoordinator.java | 81 ++------- .../bottom/BrowsingModeBottomToolbarMediator.java | 173 +------------------ .../bottom/BrowsingModeBottomToolbarModel.java | 41 +---- .../BrowsingModeBottomToolbarViewBinder.java | 78 +-------- .../ScrollingBottomViewResourceFrameLayout.java | 11 +- .../TabSwitcherBottomToolbarCoordinator.java | 11 +- .../bottom/TabSwitcherBottomToolbarViewBinder.java | 4 +- chrome/android/java_sources.gni | 4 + 19 files changed, 650 insertions(+), 523 deletions(-) commit d191cd9498bfd1d70e2c3852f0fbd2d5693f2b5f Author: Dan Beam <dbeam@chromium.org> Date: Thu Mar 7 01:05:17 2019 +0000 WebUI Dark Mode: update passwords export dialog progress colors Screenshot: https://imgur.com/a/REuT5VD R=hcarmona@chromium.org BUG=926658 Change-Id: I7ec299554e136a7fd7a948bbeadba73b0af829d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506479 Commit-Queue: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#638371} .../settings/autofill_page/passwords_export_dialog.html | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) commit ca0f969a97d61cce9d40a2f69446d1783778b7f0 Author: Greg Kerr <kerrnel@chromium.org> Date: Thu Mar 7 00:58:19 2019 +0000 cryptohome: Call UnmountEx instead of deprecated Unmount. This calls the modern UnmountEx method in cryptohome instead of the deprecated Unmount method. Bug: 811551 Change-Id: I262b3b29eaf2dba969c95f9d0a7cfc70468f4f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464453 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638370} .../login/auth/cryptohome_authenticator_unittest.cc | 19 +++++++++++++++++-- .../chromeos/policy/pre_signin_policy_fetcher.cc | 12 +++++++----- .../chromeos/policy/pre_signin_policy_fetcher.h | 2 +- chromeos/dbus/cryptohome_client.cc | 13 ++++++++++--- chromeos/dbus/cryptohome_client.h | 8 ++++++-- chromeos/dbus/fake_cryptohome_client.cc | 7 ++++--- chromeos/dbus/fake_cryptohome_client.h | 3 ++- chromeos/login/auth/cryptohome_authenticator.cc | 21 +++++++++++---------- chromeos/login/auth/cryptohome_authenticator.h | 7 +++++++ 9 files changed, 65 insertions(+), 27 deletions(-) commit a66bc8466ae52282747a0314bcc7e21440708530 Author: Aga Wronska <agawronska@chromium.org> Date: Thu Mar 7 00:58:06 2019 +0000 Pass parent access code overrides to UsageTimeLimitProccessor. Instead of enabling lock screen authentication, store info about local overrides in a pref and pass it to UsageTimeLimitProccessor to calculate state. That way local override is preserved in-between the sessions and works consistently with remote overrides. Bug: 911326 Test: UsageTimeLimitProcessorTest Change-Id: I8135a2093f805188dd75b48d10c5c1a8aac1c711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497611 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638369} .../child_accounts/screen_time_controller.cc | 38 +- .../child_accounts/time_limit_test_utils.cc | 1 + .../child_accounts/usage_time_limit_processor.cc | 41 +- .../child_accounts/usage_time_limit_processor.h | 19 + .../usage_time_limit_processor_unittest.cc | 523 +++++++++++++++------ chrome/common/pref_names.cc | 4 + chrome/common/pref_names.h | 1 + 7 files changed, 472 insertions(+), 155 deletions(-) commit 55726f8bdeb1626d7ec18013e2d83cc6a74e4830 Author: Pete Williamson <petewil@chromium.org> Date: Thu Mar 7 00:57:12 2019 +0000 Change flaky test to pass on timeout for slow platforms. Bug: 939037 Change-Id: I41ba9332d7a52921cd61d49bda105d66dda52f1d TBR: rockot@chromium.org Change-Id: I41ba9332d7a52921cd61d49bda105d66dda52f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506878 Commit-Queue: Peter Williamson <petewil@chromium.org> Reviewed-by: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638368} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit d3b31738f0d670790c90d1a0dac29ec8f1edfd7a Author: Becky Zhou <huayinz@chromium.org> Date: Thu Mar 7 00:54:02 2019 +0000 Fix font scale on overriding configuration on Tab Bug: 936983 Change-Id: Iea620167cd0885da55b36ccd0a74e6405c7565bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506106 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638367} chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java | 3 +++ 1 file changed, 3 insertions(+) commit 5348a2ac7bde8050c8677df8d4b02c9f9df75cdf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 00:53:06 2019 +0000 Roll src/third_party/SPIRV-Tools/src 07f80c4df1b0..a2ef7be242bc (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07f80c4df1b0..a2ef7be242bc git log 07f80c4df1b0..a2ef7be242bc --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fjhenigman@users.noreply.github.com Add Linux ASAN bot configs. (#2427) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@a2ef7be242bc The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iffffd9b79247600577b3656afb6d1c3f644d46bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505902 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638366} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 39608404e19be1ab478df7a5af6b0e70941ae386 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 00:37:50 2019 +0000 Roll src/third_party/angle f094bac94992..14126505b237 (9 commits) https://chromium.googlesource.com/angle/angle.git/+log/f094bac94992..14126505b237 git log f094bac94992..14126505b237 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 jmadill@chromium.org Revert "Use a constexpr array for es3 copy conversion table." 2019-03-06 cwallez@chromium.org Revert "Allow enabling trace annotations" 2019-03-06 jmadill@chromium.org Disable non-conformant configs on official builds. 2019-03-06 syoussefi@chromium.org Vulkan: Decouple EGLSync from renderer serial 2019-03-06 syoussefi@chromium.org Vulkan: shave off 60 bytes from AttachmentOpsArray 2019-03-05 courtneygo@google.com Fix scoped trace events 2019-03-05 syoussefi@chromium.org Add Orientation and Starter-Projects docs 2019-03-05 jmadill@chromium.org Use a constexpr array for es3 copy conversion table. 2019-03-05 jmadill@chromium.org Add glmark2 to build. Created with: gclient setdep -r src/third_party/angle@14126505b237 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ic68a7f10cd056ea6d1659ee4e9fa9087bf2ec3a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505900 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638365} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d575fa3d0bbca254f4d5c12e3abb0fd9b32754ab Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Thu Mar 7 00:36:56 2019 +0000 [tools/perf] Copy over catapult/experimental perf tools Graduating these out of experimental folder in catapult. Bug: 922030 Change-Id: I3ac3679f865aa4f409c96608348cf65d6941f82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494880 Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#638364} chrome/test/BUILD.gn | 3 - tools/perf/cli_tools/pinpoint_cli/__init__.py | 3 + tools/perf/cli_tools/pinpoint_cli/commands.py | 62 ++++++ tools/perf/cli_tools/pinpoint_cli/histograms_df.py | 56 +++++ .../cli_tools/pinpoint_cli/histograms_df_test.py | 90 ++++++++ tools/perf/cli_tools/pinpoint_cli/job_results.py | 44 ++++ .../cli_tools/pinpoint_cli/job_results_test.py | 99 +++++++++ tools/perf/cli_tools/soundwave/__init__.py | 3 + tools/perf/cli_tools/soundwave/commands.py | 157 +++++++++++++ tools/perf/cli_tools/soundwave/pandas_sqlite.py | 84 +++++++ .../perf/cli_tools/soundwave/pandas_sqlite_test.py | 73 ++++++ tools/perf/cli_tools/soundwave/studies/__init__.py | 36 +++ .../cli_tools/soundwave/studies/health_study.py | 45 ++++ tools/perf/cli_tools/soundwave/studies/v8_study.py | 48 ++++ tools/perf/cli_tools/soundwave/tables/__init__.py | 44 ++++ tools/perf/cli_tools/soundwave/tables/alerts.py | 71 ++++++ .../perf/cli_tools/soundwave/tables/alerts_test.py | 101 +++++++++ tools/perf/cli_tools/soundwave/tables/bugs.py | 60 +++++ tools/perf/cli_tools/soundwave/tables/bugs_test.py | 46 ++++ .../perf/cli_tools/soundwave/tables/timeseries.py | 175 +++++++++++++++ .../cli_tools/soundwave/tables/timeseries_test.py | 247 +++++++++++++++++++++ tools/perf/cli_tools/soundwave/worker_pool.py | 82 +++++++ tools/perf/cli_tools/soundwave/worker_pool_test.py | 50 +++++ tools/perf/cli_tools/update_wpr/update_wpr.py | 9 +- .../cli_tools/update_wpr/update_wpr_unittest.py | 12 +- tools/perf/core/cli_utils.py | 34 +++ tools/perf/core/gsutil.py | 33 +++ tools/perf/core/path_util.py | 13 -- tools/perf/core/services/__init__.py | 3 + tools/perf/core/services/buildbucket_service.py | 66 ++++++ .../perf/core/services/buildbucket_service_test.py | 69 ++++++ tools/perf/core/services/dashboard_service.py | 140 ++++++++++++ tools/perf/core/services/dashboard_service_test.py | 115 ++++++++++ tools/perf/core/services/isolate_service.py | 67 ++++++ tools/perf/core/services/isolate_service_test.py | 77 +++++++ tools/perf/core/services/luci_auth.py | 48 ++++ tools/perf/core/services/luci_auth_test.py | 59 +++++ tools/perf/core/services/pinpoint_service.py | 38 ++++ tools/perf/core/services/pinpoint_service_test.py | 48 ++++ tools/perf/core/services/request.py | 152 +++++++++++++ tools/perf/core/services/request_test.py | 126 +++++++++++ tools/perf/examples/pinpoint_cli/bisect_job.json | 16 ++ tools/perf/examples/pinpoint_cli/try_job.json | 11 + .../examples/soundwave/startup_timeseries.json | 8 + tools/perf/export_csv | 57 +++++ tools/perf/pinpoint_cli | 72 ++++++ tools/perf/soundwave | 100 +++++++++ tools/perf/update_wpr | 3 + 48 files changed, 3026 insertions(+), 29 deletions(-) commit 30645e2f17efd8cfaf09c6f332cdf333282d2ef7 Author: Peter Williamson <petewil@chromium.org> Date: Thu Mar 7 00:32:40 2019 +0000 Revert "Refactor SSLCertificateErrorPageController" This reverts commit 08c128cd49af9bfb4ded6298441e158b41849061. Reason for revert: Reverterd on suspicion of causing build failures on Mac 10.11 TBR: carlosil@chromium.org failures: SSLClientSocketReadTest.Read/1 SSLClientSocketReadTest.Read/0 HTTPSEVCRLSetTest.FreshCRLSetNotCovered WebSocketEndToEndTest.BasicSmokeTest SSLClientSocketReadTest.DumpMemoryStats/0 SSLClientSocketReadTest.DumpMemoryStats/1 URLRequestTestFTP.FTPCheckWrongUser WebSocketEndToEndTest.TruncatedResponse WebSocketEndToEndTest.HstsWebSocketToWebSocket WebSocketEndToEndTest.TrailingWhitespace HTTPSOCSPTest.IntermediateResponseTooOld URLRequestTestFTP.FTPCheckWrongUserRestart URLRequestTestFTP.FTPCheckWrongPasswordRestart HTTPSOCSPTest.Revoked HTTPSFallbackTest.TLSv1_1NoFallback HTTPSFallbackTest.TLSv1_3Interference URLRequestTestFTP.FTPCheckWrongPassword WebSocketEndToEndTest.HeaderContinuations HTTPSCRLSetTest.ExpiredCRLSetAndRevoked HTTPSEVCRLSetTest.FreshCRLSetCovered SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/1 SSLClientSocketReadTest.Read_DeleteWhilePendingFullDuplex/0 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/18 HTTPSOCSPTest.Valid HTTPSEVCRLSetTest.ExpiredCRLSet OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/12 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/13 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/10 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/11 OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/16 … 70 more (100 total) … Original change's description: > Refactor SSLCertificateErrorPageController > > SSLCertificateErrorPageController is no longer only used on SSL errors, > renamed it to SecurityInterstitialErrorPageController, and removed the > net::Error code passed to EnablePageHelperFunctions since it's no > longer used. > > Bug: 910794 > Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Carlos IL <carlosil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638232} TBR=sky@chromium.org,mmenke@chromium.org,carlosil@chromium.org Change-Id: I39489effa3e0029b5ff65f5bc9cbd991aef1ddea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 910794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507039 Reviewed-by: Peter Williamson <petewil@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638363} chrome/renderer/BUILD.gn | 4 +- chrome/renderer/net/net_error_helper.cc | 13 ++-- chrome/renderer/net/net_error_helper.h | 12 ++-- chrome/renderer/net/net_error_helper_core.cc | 3 +- chrome/renderer/net/net_error_helper_core.h | 2 +- .../renderer/net/net_error_helper_core_unittest.cc | 2 +- .../renderer/{security_interstitials => ssl}/DEPS | 0 .../{security_interstitials => ssl}/OWNERS | 0 .../ssl_certificate_error_page_controller.cc} | 76 +++++++++++----------- .../ssl_certificate_error_page_controller.h} | 16 ++--- 10 files changed, 63 insertions(+), 65 deletions(-) commit cdc92f96b8b0e231e1e6c9cc173c9c473d10e908 Author: Sajjad Mirza <sajjadm@google.com> Date: Thu Mar 7 00:29:10 2019 +0000 Reland "Adding an exclusion list to the coverage wrapper script." This is a reland of 6b7213a45382f01ac0a2efec1015545bd051da89 Original change's description: > Adding an exclusion list to the coverage wrapper script. > > The script now assumes GN adds coverage flags to the cflags for each > source file. The script removes the flag if the file is in an exclusion > list, or if `--files-to-instrument` is set it will also remove flags if > the file is not listed in that argument. > > The script supports multiple exclusion lists that can be selected with > the `--target-os` flag. > > It's expected that GN will set these flags correctly and invoke the > script in all coverage builds. http://crrev.com/c/1496002 does that. > > > Bug: 918215 > Change-Id: I4454f67067a083581f31a22cfef85368825789f9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495994 > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Reviewed-by: Max Moroz <mmoroz@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637892} Bug: 918215 Change-Id: I1254d288ff263ff94c46b46e6be99738e31b9574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506974 Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Sajjad Mirza <sajjadm@google.com> Cr-Commit-Position: refs/heads/master@{#638362} build/toolchain/clang_code_coverage_wrapper.py | 79 ++++++++++++++++++++++---- 1 file changed, 69 insertions(+), 10 deletions(-) commit d46bb150e4e7eccdd864a7bc8dec094e3ee32c06 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 7 00:28:00 2019 +0000 Roll src-internal 0ab64c504cf5..b9c4c2512141 (8 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ab64c504cf5..b9c4c2512141 Created with: gclient setdep -r src-internal@b9c4c2512141 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:936957 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: Ifab15f85eb4ff18ae228a0f4ade6c945a042ad20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505899 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638361} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 99b795424810a992b24931fc1198d79186b6d594 Author: Alex Moshchuk <alexmos@chromium.org> Date: Thu Mar 7 00:27:32 2019 +0000 Implement per-profile isolated origins. Previously, isolated origins would apply globally for all profiles in the entire browser. This CL introduces support for associating isolated origins with specific BrowserContexts (i.e., profiles): 1. The API for adding new isolated origins, ChildProcessSecurityPolicyImpl::AddIsolatedOrigins(), can now take a BrowserContext in which the origin should apply. 2. Entries in the map of isolated origins are extended to optionally contain the BrowserContext to which they apply. If this is not specified, the corresponding isolated origin still applies globally to all profiles. To facilitate checks on the IO thread, the ResourceContext (BrowserContext's representation on the IO thread) is also stored in the entry. 3. IsolationContext now also carries profile information (as BrowserOrResourceContext), and GetMatchingIsolatedOrigin() consults it to see if the profiles match when looking for matching isolated origins. Various tests are updated to pass a proper BrowserContext to the IsolationContexts they construct. Bug: 905513 Change-Id: Iad1fd2ca4ea701f9e088d30fa1b8582de9fbed67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497794 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#638360} content/browser/browser_context.cc | 9 + content/browser/browsing_instance.cc | 3 +- .../browser/child_process_security_policy_impl.cc | 120 +++++++-- .../browser/child_process_security_policy_impl.h | 112 +++++++-- .../child_process_security_policy_unittest.cc | 277 ++++++++++++++++++--- ...session_storage_namespace_impl_mojo_unittest.cc | 6 +- .../frame_host/webui_navigation_browsertest.cc | 4 +- content/browser/isolated_origin_browsertest.cc | 93 +++++-- content/browser/isolation_context.cc | 19 +- content/browser/isolation_context.h | 31 ++- .../cross_site_document_blocking_browsertest.cc | 3 +- .../web_database_host_impl_unittest.cc | 10 +- content/browser/site_instance_impl.cc | 3 +- content/browser/site_instance_impl.h | 4 + content/browser/site_instance_impl_unittest.cc | 153 ++++++------ 15 files changed, 650 insertions(+), 197 deletions(-) commit fb0e628497c513215b458fc2236406f7ab7eafb0 Author: Li Lin <llin@chromium.org> Date: Thu Mar 7 00:26:04 2019 +0000 Launch Android Intent for media playback. Bug: b:124796759 Test: Manual Change-Id: I197f984578e9f80096ada1701e0399058bf9e848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638359} chrome/browser/ui/ash/assistant/device_actions.cc | 3 ++ .../assistant/assistant_manager_service_impl.cc | 49 +++++++++++++++++++--- .../assistant/assistant_manager_service_impl.h | 4 ++ .../assistant/public/mojom/assistant.mojom | 12 ++++++ 4 files changed, 63 insertions(+), 5 deletions(-) commit bb3f881dc117c86b3ac896b5ed45ee5c8906d6f0 Author: Nigel Tao <nigeltao@chromium.org> Date: Thu Mar 7 00:25:18 2019 +0000 Add an IconKey.icon_effects field Previously, the plan was to re-use the low bits of the IconKey.u_key to represent icon post-processing effects such as desaturation to gray. On further thought, we would also like to apply such effects to IconKeys that already use the u_key to represent a resource ID, and do not use an IncrementingIconKeyFactory. It is therefore clearer to have an explicit field for icon effects. In this commit, this new field is always zero. A follow-up commit will use non-zero values. BUG=826982 Change-Id: I6453a648ed2608a2af59d0d01e1fe9bf4af5c90f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505741 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#638358} chrome/browser/apps/app_service/arc_apps.cc | 10 ++++++---- chrome/browser/apps/app_service/built_in_chromeos_apps.cc | 2 +- chrome/browser/apps/app_service/crostini_apps.cc | 8 ++++++-- chrome/browser/apps/app_service/extension_apps.cc | 4 +++- chrome/browser/apps/app_service/icon_key_util.cc | 8 ++------ chrome/browser/apps/app_service/icon_key_util.h | 6 +----- chrome/services/app_service/app_service_impl_unittest.cc | 2 +- chrome/services/app_service/public/cpp/app_update_unittest.cc | 4 ++-- chrome/services/app_service/public/mojom/types.mojom | 3 +++ 9 files changed, 25 insertions(+), 22 deletions(-) commit 22b5144060f40e96f2e7faba8d5c15a288f6d0f7 Author: Peter Wen <wnwen@chromium.org> Date: Thu Mar 7 00:24:10 2019 +0000 Android: Split out autofill_assistant - This is the first step in converting autofill_assistant to a DFM. - Create a new //chrome/android/features/autofill_assistant:java target that includes almost all files that used to be under org.chromium.chrome.browser.autofill_assistant.*. - Create separate strings and resources targets. - Split out instrumentation test code. - Add the resulting target to chrome_all_java. - Due to a dependency from CustomTabs, this move excludes: - AutofillAssistantClient.java - AutofillAssistantFacade.java - AutofillAssistantMetrics.java - AutofillAssistantPreferencesUtil.java Tbr: Just moving existing DEPS into a new DEPS file Bug: 846440,922053 Change-Id: I0ee13a75f5f0ce59496e924bcc8e54ef6e960957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499720 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638357} build/android/lint/suppressions.xml | 2 +- chrome/android/BUILD.gn | 31 ++--- .../android/features/autofill_assistant/BUILD.gn | 143 ++++++++++++++++++++ .../browser => features}/autofill_assistant/OWNERS | 0 .../android/features/autofill_assistant/java/DEPS | 3 + .../autofill_assistant_bottombar_bg.9.png | Bin .../res}/drawable-hdpi/ic_feedback_black_24dp.png | Bin .../autofill_assistant_bottombar_bg.9.png | Bin .../res}/drawable-mdpi/ic_feedback_black_24dp.png | Bin .../res}/drawable-mdpi/onboarding_background.png | Bin .../autofill_assistant_bottombar_bg.9.png | Bin .../res}/drawable-xhdpi/ic_feedback_black_24dp.png | Bin .../autofill_assistant_bottombar_bg.9.png | Bin .../drawable-xxhdpi/ic_feedback_black_24dp.png | Bin .../res}/drawable-xxhdpi/onboarding_background.png | Bin .../autofill_assistant_bottombar_bg.9.png | Bin .../drawable-xxxhdpi/ic_feedback_black_24dp.png | Bin .../autofill_assistant_bottombar_spacer.xml | 0 .../autofill_assistant_button_hairline_bg.xml | 0 ...utofill_assistant_button_hairline_bg_normal.xml | 0 ...tofill_assistant_button_hairline_bg_pressed.xml | 0 .../autofill_assistant_chip_assistive_bg.xml | 0 ...autofill_assistant_chip_assistive_bg_normal.xml | 0 ...utofill_assistant_chip_assistive_bg_pressed.xml | 0 .../autofill_assistant_default_details.xml | 0 .../drawable/autofill_assistant_details_bg.xml | 0 .../autofill_assistant_lightblue_rect_bg.xml | 0 .../autofill_assistant_swipe_indicator.xml | 0 .../res}/drawable/ic_autofill_assistant_24dp.xml | 0 .../layout/autofill_assistant_button_filled.xml | 0 .../layout/autofill_assistant_button_hairline.xml | 0 .../layout/autofill_assistant_chip_assistive.xml | 0 .../res}/layout/autofill_assistant_details.xml | 0 .../java/res}/layout/autofill_assistant_header.xml | 0 .../res}/layout/autofill_assistant_onboarding.xml | 0 .../layout/autofill_assistant_payment_request.xml | 0 ...tofill_assistant_payment_request_bottom_bar.xml | 0 .../java/res}/layout/autofill_assistant_sheet.xml | 0 .../java/res}/values-v17/colors.xml | 0 .../java/res}/values-v17/dimens.xml | 3 +- .../java/res}/values-v17/styles.xml | 0 .../AssistantBottomBarCoordinator.java | 0 .../autofill_assistant/AssistantCoordinator.java | 0 .../AssistantKeyboardCoordinator.java | 0 .../browser/autofill_assistant/AssistantModel.java | 0 .../AssistantOnboardingCoordinator.java | 0 .../autofill_assistant/AssistantSnackbar.java | 0 .../AutofillAssistantUiController.java | 0 .../browser/autofill_assistant/EditDistance.java | 0 .../autofill_assistant/FeedbackContext.java | 0 .../carousel/AssistantCarouselCoordinator.java | 0 .../carousel/AssistantCarouselModel.java | 0 .../autofill_assistant/carousel/AssistantChip.java | 0 .../carousel/AssistantChipViewHolder.java | 0 .../details/AssistantDetails.java | 0 .../details/AssistantDetailsCoordinator.java | 0 .../details/AssistantDetailsModel.java | 0 .../details/AssistantDetailsViewBinder.java | 0 .../header/AnimatedProgressBar.java | 0 .../header/AssistantHeaderCoordinator.java | 0 .../header/AssistantHeaderDelegate.java | 0 .../header/AssistantHeaderModel.java | 0 .../header/AssistantHeaderViewBinder.java | 0 .../overlay/AssistantOverlayCoordinator.java | 0 .../overlay/AssistantOverlayDelegate.java | 0 .../overlay/AssistantOverlayModel.java | 0 .../overlay/TouchEventFilterView.java | 0 .../AssistantPaymentRequestCoordinator.java | 0 .../payment/AssistantPaymentRequestDelegate.java | 0 .../payment/AssistantPaymentRequestModel.java | 0 .../payment/AssistantPaymentRequestOptions.java | 0 .../payment/AutofillAssistantPaymentRequest.java | 2 +- .../AutofillAssistantPaymentRequestSection.java | 0 .../payment/PaymentRequestBottomBar.java | 0 .../payment/PaymentRequestUI.java | 0 .../android_chrome_autofill_assistant_strings.grd | 146 +++++++++++++++++++++ ...ndroid_chrome_autofill_assistant_strings_am.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ar.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_bg.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_bn.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ca.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_cs.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_da.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_de.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_el.xtb | 4 + ...oid_chrome_autofill_assistant_strings_en-GB.xtb | 4 + ...id_chrome_autofill_assistant_strings_es-419.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_es.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_et.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_fa.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_fi.xtb | 4 + ...droid_chrome_autofill_assistant_strings_fil.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_fr.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_gu.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_hi.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_hr.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_hu.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_id.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_it.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_iw.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ja.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_kn.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ko.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_lt.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_lv.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ml.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_mr.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ms.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_nl.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_no.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_pl.xtb | 4 + ...oid_chrome_autofill_assistant_strings_pt-BR.xtb | 4 + ...oid_chrome_autofill_assistant_strings_pt-PT.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ro.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ru.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_sk.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_sl.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_sr.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_sv.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_sw.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_ta.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_te.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_th.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_tr.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_uk.xtb | 4 + ...ndroid_chrome_autofill_assistant_strings_vi.xtb | 4 + ...oid_chrome_autofill_assistant_strings_zh-CN.xtb | 4 + ...oid_chrome_autofill_assistant_strings_zh-TW.xtb | 4 + .../AutofillAssistantUiTest.java | 0 .../autofill_assistant/EditDistanceTest.java | 0 chrome/android/java/res/values/dimens.xml | 3 - .../java/strings/android_chrome_strings.grd | 25 ---- chrome/android/java_sources.gni | 36 ----- components/autofill_assistant_strings.grdp | 13 +- tools/gritsettings/translation_expectations.pyl | 1 + 135 files changed, 520 insertions(+), 96 deletions(-) commit 8c9881f99aca8352ba3347c27006f59abb4f13da Author: Siye Liu <siliu@microsoft.com> Date: Thu Mar 7 00:22:16 2019 +0000 Fix several issues in TSF support on Windows. This CL fixes two issues with the TSF support on windows. 1. Add TS_SS_TRANSITORY flag to the return value of TsfTextStore::GetStatus. By adding the flag, Korean reconversion feature is disabled. User can only do conversion during composition. Editing frameworks may not support Korean reconversion by design. 2. Fix Japanese IME implicit commit on draft.js framework. Editing frameworks like draft.js may manage their own selection during composition. We should not set selection after inserting composition text during composition. Bug: 657623 Change-Id: Ic9fb3d9187b2a1228807b15132e20e3227bf1de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504035 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#638356} ui/base/ime/win/tsf_text_store.cc | 4 ++-- ui/base/ime/win/tsf_text_store_unittest.cc | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) commit 19646b4da5405c4cdc110254f29186c54303c948 Author: Owen Min <zmin@chromium.org> Date: Thu Mar 7 00:19:35 2019 +0000 Component cloud policies can overrides platform ones with policy. With policy enabled, component cloud policies use POLICY_SOURCE_PRIORITY_CLOUD instead to override platform policies that have same scope. Bug: 749530 Change-Id: I7d53034073ebd24034fb3c0dfe7034229d683089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489902 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638355} .../policy/device_cloud_policy_manager_chromeos.cc | 4 +- .../policy/device_local_account_policy_service.cc | 6 +- .../policy/user_cloud_policy_manager_chromeos.cc | 2 +- .../core/common/cloud/cloud_policy_manager.cc | 3 +- .../core/common/cloud/cloud_policy_manager.h | 2 + .../common/cloud/component_cloud_policy_service.cc | 11 ++- .../common/cloud/component_cloud_policy_service.h | 7 ++ .../cloud/component_cloud_policy_service_stub.cc | 1 + .../component_cloud_policy_service_unittest.cc | 5 +- .../common/cloud/component_cloud_policy_store.cc | 11 ++- .../common/cloud/component_cloud_policy_store.h | 10 ++- .../cloud/component_cloud_policy_store_unittest.cc | 92 +++++++++++++++++----- .../component_cloud_policy_updater_unittest.cc | 3 +- .../machine_level_user_cloud_policy_manager.cc | 7 +- .../core/common/cloud/user_cloud_policy_manager.cc | 10 ++- 15 files changed, 134 insertions(+), 40 deletions(-) commit 28580fd02961aa4e589f3ed006f97347e81b35a9 Author: Ken Rockot <rockot@google.com> Date: Thu Mar 7 00:18:15 2019 +0000 Don't use nested enum definition in SerializedHandle This type is an internal dependency of Mojo bindings and nested enum definitions are currently broken in JS lite bindings. Work around that by pulling this enum out of SerializedHandle. Bug: 939078 Change-Id: I9be1737a6271201d9b56a1cb69d6018e26514b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506767 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638354} ipc/ipc_channel_mojo.cc | 2 +- ipc/native_handle_type_converters.cc | 32 +++++++++++----------- ipc/native_handle_type_converters.h | 8 +++--- .../bindings/lib/native_struct_serialization.cc | 4 +-- .../public/interfaces/bindings/native_struct.mojom | 19 ++++++------- 5 files changed, 32 insertions(+), 33 deletions(-) commit 9dc6970eac23d5e1bf56f8c1f7fda862d741303a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 00:17:13 2019 +0000 Roll src/third_party/pdfium 3df5c7cf7b58..a07afc58f2d7 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/3df5c7cf7b58..a07afc58f2d7 git log 3df5c7cf7b58..a07afc58f2d7 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tsepez@chromium.org Fix lookahead check in CFGAS_FormatString::GetNumericFormat(). Created with: gclient setdep -r src/third_party/pdfium@a07afc58f2d7 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938626 TBR=dsinclair@chromium.org Change-Id: Ib5903f320f3cb33ac354420058f13300527f562b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506607 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638353} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af3e9c30d10a2a578c83765c2ec4b0d31bb2f475 Author: Jérôme Lebel <jlebel@chromium.org> Date: Thu Mar 7 00:17:09 2019 +0000 [iOS] Renaming TableViewImageCell.titleLabel to TableViewImageCell.textLabel Some of the code were using TableViewImageCell.textLabel, without compiler errors, since UITableView.textLabel exists. To avoid any errors, titleLabel is renamed into textLabel. Bug introduced: crrev.com/c/1478795 Change-Id: I5c07d31565d7c23a212a44103371a311ef327e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503575 Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638352} .../ui/table_view/cells/table_view_image_item.h | 9 +++++---- .../ui/table_view/cells/table_view_image_item.mm | 23 +++++++++++----------- .../cells/table_view_image_item_unittest.mm | 2 +- 3 files changed, 18 insertions(+), 16 deletions(-) commit e6cf69a4723c7252ffd22a7141e59f2cb8a17bb8 Author: Varun Khaneja <vakh@chromium.org> Date: Thu Mar 7 00:13:59 2019 +0000 AndroidTelemetryService: Check incognito mode based on profile Functionally, this is a NO-OP but it does simplify the code and eliminates the NOT_SENT_MISSING_WEB_CONTENTS scenario. R=drubery Bug: 938559,907280 Change-Id: Ifd3e27b865df97aa07d5a1b7653cd0f01910454a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504958 Reviewed-by: Daniel Rubery <drubery@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638351} .../telemetry/android/android_telemetry_service.cc | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) commit 7797b8c8b6a322bb820452b554279e8c24a6982b Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Mar 7 00:08:44 2019 +0000 Reland "[IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager" This is a reland of 1bc0f67478ce43813422fc180b5a8a1106887163 Original change's description: > [IndexedDB] Moving IDBDatabase's PendingConnection to use ScopesLockManager > > This allows scopes to be used in the DeleteDatabase call, and cleans up > some code in the IndexedDBDatabase class. > > The last part of the codebase that doesn't have locks before being used > is the IndexedDBBackingStore::Initialize call. Since this happens on the > opening of the database, this can probably use just the raw database + > a WriteBatch. > > Bug: 862456 > Change-Id: I89c79ec89a4450e21f1ee700b007ec867b3a4f48 > Reviewed-on: https://chromium-review.googlesource.com/c/1478391 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Chase Phillips <cmp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634358} Bug: 862456 Change-Id: I821c28b93fde903678737d49eaeb44c1b7369e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506552 Reviewed-by: Chase Phillips <cmp@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638350} content/browser/indexed_db/indexed_db_database.cc | 76 ++++++++++++++++------ content/browser/indexed_db/indexed_db_database.h | 8 ++- .../browser/indexed_db/indexed_db_transaction.cc | 8 ++- 3 files changed, 66 insertions(+), 26 deletions(-) commit 04c92af83c5b91aba7ee19adb5907f9f64259ba1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 7 00:05:57 2019 +0000 Roll src/third_party/swiftshader 9584fe43a9c2..2c25b14c34c1 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/9584fe43a9c2..2c25b14c34c1 git log 9584fe43a9c2..2c25b14c34c1 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 chrisforbes@google.com Implement GetPhysicalDeviceSparseImageFormatProperties Created with: gclient setdep -r src/third_party/swiftshader@2c25b14c34c1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118429780 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ice50ccffd1bc0d3cb54e1d8d1659183aa6785d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506692 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638349} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 685c1001bbaef5f82e261e72b0dbc793564e2a5a Author: Yulun Wu <yulunwu@chromium.org> Date: Thu Mar 7 00:02:24 2019 +0000 Add Ekko and Bard assets for fingerprint UI. No translation required. Improper use of GetLsbReleaseBoard() is tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=938738 Bug: b:120050686 Change-Id: I386fff94be6350ce9ae80e4891251e92d31fb92a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501760 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#638348} .../chromeos/login/quick_unlock/quick_unlock_utils.cc | 16 ++++++++++++++++ .../chromeos/login/quick_unlock/quick_unlock_utils.h | 6 ++++++ .../resources/chromeos/login/fingerprint_setup.css | 4 ++-- .../settings/people_page/setup_fingerprint_dialog.html | 12 +++++++++++- .../settings/people_page/setup_fingerprint_dialog.js | 12 ++++++++++++ chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 14 ++++++++++++++ chrome/browser/ui/webui/settings/md_settings_ui.cc | 13 ++++++++++--- .../fingerprint/fingerprint_scanner_laptop.png | Bin 0 -> 7803 bytes .../fingerprint/fingerprint_scanner_laptop.png | Bin 0 -> 16063 bytes ui/chromeos/resources/ui_chromeos_resources.grd | 3 ++- 10 files changed, 73 insertions(+), 7 deletions(-) commit 95fbeff54a9bb41773ae700bb78117dec14f0a37 Author: Mei Liang <meiliang@chromium.org> Date: Wed Mar 6 23:57:29 2019 +0000 Cache TabGroupsAndroid feature flag The CL only caches the TabGroupAndroid feature flag for devices that are eligible for tab group. Bug: 934557 Change-Id: I200bd417e60897c39675eb80b37abbe610e957df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501912 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638347} .../preferences/ChromePreferenceManager.java | 6 ++++ .../chrome/browser/util/FeatureUtilities.java | 32 ++++++++++++++++++---- 2 files changed, 33 insertions(+), 5 deletions(-) commit 1daccaee3765ca5e87a00202d6f9d143362ef6dc Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Wed Mar 6 23:57:06 2019 +0000 Android: Delete Tab's TitleRtl property The RTL property can be obtained dynamically from Tab's title. This CL updates a single callsite so that Tab doesn't have to manage the property. Bug: 925242 Change-Id: Ia9e55818b1f07e320337da4c7991a344c88b1b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501894 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#638346} .../chrome/browser/compositor/LayerTitleCache.java | 6 +++++- .../src/org/chromium/chrome/browser/tab/Tab.java | 21 +-------------------- 2 files changed, 6 insertions(+), 21 deletions(-) commit 338530396cd57c7688d2238ed4f1e9d7ea5a0719 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Mar 6 23:52:59 2019 +0000 Roll libc++ to 22d3f6dd Change necessary to fix Windows build: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/417a7dee1c4653bd3a4753710a84c8fd356ba7d9 Change necessary to fix _LIBCPP_DEBUG=1 build: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+/9ae8fb4a3c5fef4e9d41e97bbd9397a412932ab0 Full changelist: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/22d3f6dd25e5efc59124ba1c00b8f98b14be4201..9ae8fb4a3c5fef4e9d41e97bbd9397a412932ab0 BUG=801780,923166 R=thakis Change-Id: Ib4d81c9a756d84fb2e7b0d5912c3cea493728608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506566 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#638345} DEPS | 2 +- buildtools/DEPS | 2 +- buildtools/deps_revisions.gni | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) commit 5df885c4db25a7dd7c277762681dbb8e00bef036 Author: Brandon Jones <bajones@chromium.org> Date: Wed Mar 6 23:52:26 2019 +0000 Changed XRHandedness enum to 'none' from empty string (reland) Previous CL got reverted after a separate commit moved a script that the new test was relying on. Bug: 933411 Change-Id: I6ba8bce0ef72da44480bfc7b8464720e616a2111 TBR: klausw@chromium.org, bsheedy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506816 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638344} .../blink/renderer/modules/xr/xr_input_source.cc | 5 +- .../blink/renderer/modules/xr/xr_input_source.h | 9 +- .../blink/renderer/modules/xr/xr_input_source.idl | 1 + .../web_tests/xr/getInputPose_handedness.html | 102 +++++++++++++++++++++ .../web_tests/xr/xrInputSource_add_remove.html | 4 +- 5 files changed, 116 insertions(+), 5 deletions(-) commit cf22b4b57a92c242a2c4ec8e06d3659e871f341c Author: Matthew Mourgos <mmourgos@chromium.org> Date: Wed Mar 6 23:46:39 2019 +0000 cros: Add Icon Ghosting to apps_grid_view. -Add a ghost while dragging an item in an apps_grid_view. -Location of the ghost will be the reorder_placeholder_. -This ghosting is disabled by default for now behind the flag "enable-app-grid-ghost". -GhostImageViews are kept track of by two pointers within apps_grid_view. The GhostImageView pointers are deleted when the view is done hiding or once the pointer is needed to initialize a newer GhostImageView. Bug: 914094 Change-Id: Iee850d0b8b109b6cb0b024d2ee53b45bafc1a4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1467721 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638343} ash/app_list/BUILD.gn | 2 + ash/app_list/views/apps_grid_view.cc | 82 +++++++++++++++++ ash/app_list/views/apps_grid_view.h | 13 +++ ash/app_list/views/ghost_image_view.cc | 127 +++++++++++++++++++++++++++ ash/app_list/views/ghost_image_view.h | 79 +++++++++++++++++ ash/public/cpp/app_list/app_list_config.cc | 4 +- ash/public/cpp/app_list/app_list_config.h | 6 +- ash/public/cpp/app_list/app_list_features.cc | 6 ++ ash/public/cpp/app_list/app_list_features.h | 4 + chrome/browser/about_flags.cc | 4 + chrome/browser/flag-metadata.json | 5 ++ chrome/browser/flag_descriptions.cc | 4 + chrome/browser/flag_descriptions.h | 3 + tools/metrics/histograms/enums.xml | 2 + 14 files changed, 336 insertions(+), 5 deletions(-) commit f27fe49491b1468b9f9d205ada7c45bc2fe80460 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Mar 6 23:43:24 2019 +0000 [Mpris] Move MPRIS into ui/base This CL removes MPRIS from components and moves it into ui/base. Bug: 935624 Change-Id: Ie0bbf358a4df00e5e1b8905576c3e85ed7b29eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506465 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638342} components/BUILD.gn | 5 ----- ui/base/BUILD.gn | 5 +++++ {components => ui/base}/mpris/BUILD.gn | 2 +- {components => ui/base}/mpris/DEPS | 0 {components => ui/base}/mpris/OWNERS | 0 {components => ui/base}/mpris/features.gni | 0 {components => ui/base}/mpris/mpris_service.cc | 4 ++-- {components => ui/base}/mpris/mpris_service.h | 6 +++--- {components => ui/base}/mpris/mpris_service_observer.h | 6 +++--- {components => ui/base}/mpris/mpris_service_unittest.cc | 4 ++-- 10 files changed, 16 insertions(+), 16 deletions(-) commit 0ef31de1f0a5fa434c059bae922b986a06444431 Author: Daniel Rubery <drubery@chromium.org> Date: Wed Mar 6 23:41:36 2019 +0000 Update base::Callback usages in chrome/renderer/safe_browsing Replace a few usages of base::Callback with base::OnceCallback, and update the corresponding base::Binds with base::BindOnce. TEST=Triggered a ping twice for the same page, one with and one without this change. The generated features were the same. Bug: 933537 Change-Id: Ib9e5454be2e67342868b00af83a58b16cde6c163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489423 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638341} .../renderer/safe_browsing/phishing_classifier.cc | 22 ++++++++++------------ .../renderer/safe_browsing/phishing_classifier.h | 4 ++-- .../phishing_classifier_browsertest.cc | 5 +++-- .../safe_browsing/phishing_classifier_delegate.cc | 4 ++-- .../phishing_classifier_delegate_browsertest.cc | 3 +-- .../phishing_dom_feature_extractor.cc | 13 +++++++------ .../safe_browsing/phishing_dom_feature_extractor.h | 4 ++-- .../phishing_dom_feature_extractor_browsertest.cc | 8 ++++---- .../phishing_term_feature_extractor.cc | 7 +++---- .../phishing_term_feature_extractor.h | 4 ++-- .../phishing_term_feature_extractor_unittest.cc | 16 ++++++---------- 11 files changed, 42 insertions(+), 48 deletions(-) commit 6abe75acb11e610976da409672d39d0b6c4f1642 Author: Ryan Hamilton <rch@chromium.org> Date: Wed Mar 6 23:41:02 2019 +0000 Roll src/net/third_party/quiche/src/ c5db41e3e..b6880f79b (1 commit) https://quiche.googlesource.com/quiche.git/+log/c5db41e3e5d0..b6880f79b56f $ git log c5db41e3e..b6880f79b --date=short --no-merges --format='%ad %ae %s' 2019-03-06 rch hpack_whole_entry_buffer_test: Include http2_test_helpers.h Created with: roll-dep src/net/third_party/quiche/src Change-Id: Ia235444ce03fbda3d39923bca26a0140849b2c74 Bug: 937886 Change-Id: Ia235444ce03fbda3d39923bca26a0140849b2c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506664 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638340} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d85ba5c5e3812e6293d1c98eff1f284c3eaace6d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 6 23:37:13 2019 +0000 Update V8 to version 7.4.295. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/359fddbf..4c5c3fce Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I353da1f13ae7390aa4e39529944a35b35bfcb32c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506594 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638339} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d4093ae00c04adde933274892ada8f8d62a2bb0a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 23:37:02 2019 +0000 Roll src/third_party/skia cb4eb612f02f..93c47cc8e359 (17 commits) https://skia.googlesource.com/skia.git/+log/cb4eb612f02f..93c47cc8e359 git log cb4eb612f02f..93c47cc8e359 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 brianosman@google.com SkReflected - avoid double registration, auto register base types, etc. 2019-03-06 fmalita@chromium.org Make SkCubicMap public 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 4c84dbdce271..9584fe43a9c2 (1 commits) 2019-03-06 jvanverth@google.com Another stab at MTLRenderCommandEncoder memory leak. 2019-03-06 mtklein@google.com encode F16Norm as rec2020 2019-03-06 reed@google.com change gradients4f to use srgb 2019-03-06 herb@google.com Fix: set SDFT if there is only fallback 2019-03-06 brianosman@google.com Add glf16norm config to DM 2019-03-06 nifong@google.com Interface for passing skp file from JS to WASM 2019-03-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 10736f2da359..5e67e5c19fd3 (1 commits) 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-06 brianosman@google.com Particles: Cleanup and better UI 2019-03-06 mtklein@google.com rework colorImage testing 2019-03-06 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-03-06 herb@google.com Move process* closures into the GrTextBlob 2019-03-06 halcanary@google.com SkPDF: Add experimental Harfbuzz font subsetter 2019-03-06 mtklein@google.com also tag DM results with color and alpha type Created with: gclient setdep -r src/third_party/skia@93c47cc8e359 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:931719 TBR=reed@chromium.org Change-Id: Ib0ef742bdd3eb7a574dfc4304cfa236a35387138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506693 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638338} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d0adde8cdf28b001587ff5d3f5a89e5fff7c2569 Author: Aran Gilman <gilmanmh@google.com> Date: Wed Mar 6 23:35:48 2019 +0000 Replace high-contrast-mode with dark-mode in Blink's web tests. This is a follow-up to https://crrev.com/c/1500255. Bug: 938511 Change-Id: If3a4f8a3488557808551da8180ff858522f23052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506872 Commit-Queue: Aran Gilman <gilmanmh@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Auto-Submit: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638337} third_party/blink/web_tests/VirtualTestSuites | 12 ++++++------ .../image-filter-all/gradient-invert-expected.png | Bin .../image-filter-all/gradient-invert-expected.txt | 0 .../image-filter-all/gradient-invert.html | 0 .../image-filter-all/image-invert-expected.png | Bin .../image-filter-all/image-invert-expected.txt | 0 .../image-filter-all/image-invert.html | 0 .../image-filter-all/text-on-backgrounds-expected.png | Bin .../image-filter-all/text-on-backgrounds-expected.txt | 0 .../image-filter-all/text-on-backgrounds.html | 0 .../image-filter-none/gradient-noinvert-expected.png | Bin .../image-filter-none/gradient-noinvert-expected.txt | 0 .../image-filter-none/gradient-noinvert.html | 0 .../image-filter-none/image-noinvert-expected.png | Bin .../image-filter-none/image-noinvert-expected.txt | 0 .../image-filter-none/image-noinvert.html | 0 .../paint/dark-mode}/image-filter-all/README.txt | 2 +- .../image-filter-all/gradient-invert-expected.png | Bin .../image-filter-all/gradient-invert-expected.txt | 0 .../dark-mode}/image-filter-all/image-invert-expected.png | Bin .../dark-mode}/image-filter-all/image-invert-expected.txt | 0 .../image-filter-all/text-on-backgrounds-expected.png | Bin .../image-filter-all/text-on-backgrounds-expected.txt | 0 .../paint/dark-mode}/image-filter-none/README.txt | 2 +- .../image-filter-none/gradient-noinvert-expected.png | Bin .../image-filter-none/gradient-noinvert-expected.txt | 0 .../image-filter-none/image-noinvert-expected.png | Bin .../image-filter-none/image-noinvert-expected.txt | 0 .../paint/dark-mode}/image-filter-smart/README.txt | 2 +- .../image-filter-smart/gradient-noinvert-expected.png | Bin .../image-filter-smart/gradient-noinvert-expected.txt | 0 .../dark-mode}/image-filter-smart/image-invert-expected.png | Bin .../dark-mode}/image-filter-smart/image-invert-expected.txt | 0 33 files changed, 9 insertions(+), 9 deletions(-) commit 6fb111ebc81a0d299ba8763166c11731db51b9ed Author: siyua <siyua@chromium.org> Date: Wed Mar 6 23:31:22 2019 +0000 [AF][Paradise] Enable migration flow for non-sync users Also removed the EnableAutofillCreditCardLocalCardMigrationExperiment() in unittests since as we add more experiment flags, this function does not help. Set a helper function in TestPersonalDataManager to change the sync state, which can help us in case of such need in the future. Bug: 897998 Change-Id: Id212077092d80738b8495f4b50bd7034e9f1ead6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501754 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#638336} .../core/browser/local_card_migration_manager.cc | 16 ++- .../local_card_migration_manager_unittest.cc | 148 ++++++++++++++------- .../autofill/core/browser/personal_data_manager.h | 2 +- .../browser/test_local_card_migration_manager.cc | 22 ++- .../browser/test_local_card_migration_manager.h | 11 +- .../core/browser/test_personal_data_manager.cc | 4 + .../core/browser/test_personal_data_manager.h | 7 + .../autofill/core/common/autofill_features.cc | 6 + .../autofill/core/common/autofill_features.h | 1 + 9 files changed, 159 insertions(+), 58 deletions(-) commit a909223e1c27985167007aa36789209e443eac29 Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 6 23:30:30 2019 +0000 Change unsigned long long to uint64_t in third_party/blink/* related to loader - unsigned long long -> uint64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I6eaddcae79f2b22cde719df027f9fce95664db6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504485 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638335} content/renderer/loader/web_url_loader_impl_unittest.cc | 3 +-- content/renderer/pepper/pepper_url_loader_host.cc | 7 +++---- content/renderer/pepper/pepper_url_loader_host.h | 6 +++--- media/blink/resource_multibuffer_data_provider.cc | 7 +++---- media/blink/resource_multibuffer_data_provider.h | 5 ++--- third_party/blink/public/platform/web_url_loader_client.h | 4 ++-- .../blink/public/web/web_associated_url_loader_client.h | 6 +++--- third_party/blink/public/web/web_plugin_container.h | 4 ++-- .../core/exported/web_associated_url_loader_impl.cc | 12 ++++++------ .../core/exported/web_associated_url_loader_impl_test.cc | 6 +++--- .../renderer/core/exported/web_plugin_container_impl.cc | 4 ++-- .../renderer/core/exported/web_plugin_container_impl.h | 4 ++-- .../blink/renderer/core/loader/threadable_loader.cc | 6 +++--- .../blink/renderer/core/loader/threadable_loader.h | 6 +++--- .../blink/renderer/core/loader/threadable_loader_client.h | 6 +++--- .../blink/renderer/core/loader/threadable_loader_test.cc | 4 ++-- .../renderer/core/xmlhttprequest/xml_http_request.cc | 15 +++++++-------- .../blink/renderer/core/xmlhttprequest/xml_http_request.h | 6 +++--- .../xml_http_request_progress_event_throttle.cc | 8 ++++---- .../xml_http_request_progress_event_throttle.h | 12 +++++------- .../core/xmlhttprequest/xml_http_request_upload.cc | 13 ++++++------- .../core/xmlhttprequest/xml_http_request_upload.h | 11 ++++------- .../blink/renderer/platform/loader/fetch/raw_resource.cc | 6 +++--- .../blink/renderer/platform/loader/fetch/raw_resource.h | 12 ++++++------ .../blink/renderer/platform/loader/fetch/resource.h | 6 +++--- .../platform/loader/fetch/resource_fetcher_test.cc | 8 ++------ .../renderer/platform/loader/fetch/resource_loader.cc | 4 ++-- .../renderer/platform/loader/fetch/resource_loader.h | 4 ++-- 28 files changed, 90 insertions(+), 105 deletions(-) commit 001ac7f68418e9957f2d74a545866cd6546300b2 Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Mar 6 23:30:18 2019 +0000 Revert "[DOMStorageS13N] Making bind calls sync and adding crash info" This reverts commit c8bd036278f5f465fd54cbb28df17bd7127b94d1. Reason for revert: The crashes have stopped, so these debugging CLs are being reverted. Original change's description: > [DOMStorageS13N] Making bind calls sync and adding crash info > > There are renderer hangs on the GetAll call, and it is unclear why. This > change adds crash metadata to know what kind of dom storage is hanging, > and make the 'bind' calls also sync. This will help narrow down what > exactly is hanging (or being dropped) so that the GetAll call never > completes. > > This change is meant to be reverted after the culprit is found. > > TBR: jam@chromium.org > Bug: 927534 > Change-Id: I3c9727f007cddae93b7b274a72f0a6313343ae29 > Reviewed-on: https://chromium-review.googlesource.com/c/1449160 > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629630} TBR=dmurph@chromium.org,jam@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927534 Change-Id: I1d864a6a085c8cd8546bd575f06a4be2d12145d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506533 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638334} .../dom_storage/dom_storage_context_wrapper.cc | 23 +- .../dom_storage/dom_storage_context_wrapper.h | 6 +- .../dom_storage_context_wrapper_unittest.cc | 3 +- .../dom_storage/local_storage_context_mojo.cc | 9 +- .../dom_storage/local_storage_context_mojo.h | 6 +- .../local_storage_context_mojo_unittest.cc | 94 ++++---- .../dom_storage/session_storage_context_mojo.cc | 7 +- .../dom_storage/session_storage_context_mojo.h | 3 +- .../session_storage_context_mojo_unittest.cc | 246 ++++++++++----------- content/browser/isolated_origin_browsertest.cc | 7 +- content/browser/storage_partition_impl.cc | 15 +- content/browser/storage_partition_impl.h | 9 +- .../dom_storage/local_storage_cached_area.cc | 2 +- .../dom_storage/local_storage_cached_areas.cc | 6 +- .../renderer/dom_storage/mock_leveldb_wrapper.cc | 8 +- .../renderer/dom_storage/mock_leveldb_wrapper.h | 9 +- .../dom_storage/storage_partition_service.mojom | 11 +- .../modules/storage/cached_storage_area.cc | 8 - .../modules/storage/storage_controller_test.cc | 12 +- .../modules/storage/storage_namespace_test.cc | 13 +- 20 files changed, 217 insertions(+), 280 deletions(-) commit d3a306e93790a1d863da1c58e4b92769d27815a2 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Mar 6 23:27:00 2019 +0000 [iOS][Translate] Moves legacy translate infobar EG tests to a new target Moves the EG tests related to the legacy translate infobar to a new target as the new infobar EG tests rely on the CompactTranslateInfobarIOS feature to be enabled via command line which will break the legacy infobar tests. - This CL does not make any changes to the tests logic. - The new target is the previous translate_egtest target which runs on downstream bots. Bug: 910994 Change-Id: I9ea34207e20a5fb72e257ec5f0c8d9a43f05a440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506571 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#638333} ios/chrome/browser/translate/BUILD.gn | 29 ++ ios/chrome/browser/translate/DEPS | 5 +- .../translate/legacy_translate_infobar_egtest.mm | 522 +++++++++++++++++++++ ios/chrome/browser/translate/translate_egtest.mm | 265 ----------- ios/chrome/test/earl_grey/BUILD.gn | 7 + 5 files changed, 562 insertions(+), 266 deletions(-) commit bcf5e8f8d550e91a4ad7f5f8ebd260962a69ce19 Author: Anastasia Helfinstein <anastasi@google.com> Date: Wed Mar 6 23:26:55 2019 +0000 Update Focus Ring interface for accessibility extensions. This does not change the behavior of any existing extension or focus ring. It only changes the interface by which the extensions set the focus rings, and adds additional parameters to allow for multiple focus rings with different visual styles from a single extension. No new parameters have been plumbed through to the accessibility_focus_ring_controller at this time, that will happen in a follow-up change. This change does support multiple focus rings from the same extension simultaneously. There are no whitelisted extensions using accessibilityPrivate.setFocusRing (ChromeVox classic is not supported on Chrome OS, and this function is only supported on Chrome OS). All existing calls to setFocusRing within Chrome have been updated. Bug: 925103 Change-Id: Ic85abef978ce969ff76db38308a1c234fe746a4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489972 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#638332} .../accessibility/accessibility_extension_api.cc | 62 +++++++-------- .../accessibility/accessibility_extension_api.h | 6 +- .../accessibility/accessibility_manager.cc | 90 +++++++++++++++------- .../chromeos/accessibility/accessibility_manager.h | 17 ++++ .../accessibility/select_to_speak_browsertest.cc | 10 ++- .../chromevox/cvox2/background/background.js | 12 ++- .../chromevox/cvox2/background/constants.js | 7 ++ .../chromeos/chromevox/cvox2/background/output.js | 6 +- .../chromeos/select_to_speak/select_to_speak.js | 25 ++++-- .../chromeos/switch_access/navigation_manager.js | 14 +++- .../switch_access/switch_access_constants.js | 16 ++++ .../extensions/api/accessibility_private.json | 51 +++++++++--- .../externs/accessibility_private.js | 33 ++++++-- 13 files changed, 257 insertions(+), 92 deletions(-) commit 91d0a2f7063d5e23e42ea66f2cf09c0cb678e3e7 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Wed Mar 6 23:20:14 2019 +0000 Revert change that causes performance regression in Slack Bug: 936944 Change-Id: I3eed83b7c69b804f577ba6ea9097a6be205fc898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506758 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638331} .../blink/renderer/modules/accessibility/ax_object_cache_impl.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 0013260b0dec8462a753168f708076ac0c227f83 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Wed Mar 6 23:19:34 2019 +0000 OnionSoup: Remove all uses of UseCounter(LocalFrame*) and the method According to the plan to replace |const LocalFrame*| arguement with |const Document&|, |ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with other UseCounter::Count(...) in frame directory. Finally, this CL removes UseCounter::Count(const LocalFrame*, WebFeature) in Blink. Bug: 936187 Change-Id: I8beff53c6a3899737de7dbc37c2f6fbe6602e977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498794 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#638330} third_party/blink/renderer/core/events/touch_event.cc | 2 +- third_party/blink/renderer/core/exported/web_view_impl.cc | 12 ++++++++---- third_party/blink/renderer/core/frame/dom_window.cc | 2 +- third_party/blink/renderer/core/frame/local_dom_window.cc | 2 +- third_party/blink/renderer/core/frame/use_counter.cc | 12 +----------- third_party/blink/renderer/core/frame/use_counter.h | 4 ---- .../blink/renderer/core/html/canvas/html_canvas_element.cc | 3 +-- .../blink/renderer/core/html/forms/html_form_element.cc | 6 ++---- .../blink/renderer/core/input/pointer_event_manager.cc | 4 ++-- third_party/blink/renderer/core/layout/layout_image.cc | 3 +-- .../blink/renderer/core/page/autoscroll_controller.cc | 2 +- third_party/blink/renderer/core/page/create_window.cc | 3 ++- third_party/blink/renderer/core/page/frame_tree.cc | 3 ++- .../renderer/core/page/scrolling/root_scroller_controller.cc | 3 +-- third_party/blink/renderer/core/script/pending_script.cc | 3 ++- third_party/blink/renderer/core/timing/window_performance.cc | 6 +++--- .../core/workers/main_thread_worklet_reporting_proxy.cc | 4 ++-- 17 files changed, 31 insertions(+), 43 deletions(-) commit 281e80c30694a97f69f9c4b5f627483376972199 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Wed Mar 6 23:18:13 2019 +0000 Add tests that lookalike interstitial decisions are shared with incognito. This CL adds tests to verify that a decision to bypass the lookalike interstitial made in the main profile does not affect incognito and vice versa. Bug: 927924 Change-Id: I238e2e263db42c1434b9190de007aa775129417e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638329} ...ookalike_url_navigation_throttle_browsertest.cc | 58 ++++++++++++++++++---- 1 file changed, 47 insertions(+), 11 deletions(-) commit 14dcbf1e17000b186e381a848b05fe28f5625757 Author: Carlos IL <carlosil@chromium.org> Date: Wed Mar 6 23:15:06 2019 +0000 Disable auto-reload on net::ERR_BLOCKED_BY_CLIENT If a request was blocked by Chrome, a reload is unlikely to help and auto reloads cause issues with some types of errors (e.g. Safe Browsing committed interstitials). Bug: 910794 Change-Id: I94e6d040216cee92b9dd1ad4ee89f1cd25a52e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504033 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638328} chrome/renderer/net/net_error_helper_core.cc | 2 ++ 1 file changed, 2 insertions(+) commit 657a8c539a653fdd91dacd7a78a9fe88f6f706c9 Author: Josh Nohle <nohle@google.com> Date: Wed Mar 6 23:14:12 2019 +0000 Use existing kUserKeyPair keys during key creation, if possible. In CyptAuth v2 Enrollment, the user key pair--also known as CryptAuthKeyBundle::Name::kUserKeyPair or "PublicKey"--has special standing in order to 1) accommodate any existing key from v1 Enrollment and 2) enforce that the key is not rotated. Only one user key pair should exist in its key bundle, and it should be an active, P-256 key with handle "device_key". It is possible that CryptAuth could request the creation of a new user key pair even if the client sends information about an existing key in the SyncKeysRequest. If this happens, the client should re-use the existing user key pair key material when creating a new key. At the end of the enrollment flow, the existing key will be replaced with this new key that has the same public/private keys, but possibly with a new key directive. It might seem more efficient to simply ignore the key-creation request, but the method outlined above natually fits into the enrollment flow, the key directive will be updated, and the client will be able to provide CryptAuth with an EnrollKeys request, which it might be expected. Bug: 899080 Change-Id: I3a4a63aa902090698ecb619bc7af78ff1e790c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504121 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#638327} .../device_sync/cryptauth_enrollment_result.cc | 6 +- .../device_sync/cryptauth_enrollment_result.h | 3 + .../services/device_sync/cryptauth_key_creator.cc | 16 ++ .../services/device_sync/cryptauth_key_creator.h | 15 ++ .../device_sync/cryptauth_key_creator_impl.cc | 50 ++-- .../device_sync/cryptauth_key_creator_impl.h | 3 +- .../cryptauth_key_creator_impl_unittest.cc | 203 ++++++++++----- .../device_sync/cryptauth_v2_enroller_impl.cc | 118 ++++++--- .../device_sync/cryptauth_v2_enroller_impl.h | 11 + .../cryptauth_v2_enroller_impl_unittest.cc | 278 ++++++++++++++------- 10 files changed, 504 insertions(+), 199 deletions(-) commit 61d9c1b62cf4117cf5a500e08f4e492e71d66f13 Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Mar 6 23:08:19 2019 +0000 Extract HammerdClient from DbusThreadManager Bug: 938717 Change-Id: Ied6a40e873849bdd91d499fe1a9093752d144763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504500 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#638326} ash/DEPS | 1 + ash/ash_service.cc | 18 ++++++++---- ash/detachable_base/detachable_base_handler.cc | 3 +- ash/detachable_base/detachable_base_handler.h | 2 +- .../detachable_base_handler_unittest.cc | 14 +++------ ash/test/ash_test_helper.cc | 4 +++ chrome/browser/chromeos/dbus/dbus_helper.cc | 17 +++++++++-- chromeos/dbus/BUILD.gn | 8 ++--- chromeos/dbus/dbus_clients_common.cc | 9 ------ chromeos/dbus/dbus_clients_common.h | 2 -- chromeos/dbus/dbus_thread_manager.cc | 11 ------- chromeos/dbus/dbus_thread_manager.h | 3 -- chromeos/dbus/{ => hammerd}/fake_hammerd_client.cc | 22 +++++++++++--- chromeos/dbus/{ => hammerd}/fake_hammerd_client.h | 12 ++++---- chromeos/dbus/{ => hammerd}/hammerd_client.cc | 34 +++++++++++++++++++--- chromeos/dbus/{ => hammerd}/hammerd_client.h | 19 +++++++----- 16 files changed, 110 insertions(+), 69 deletions(-) commit 1af146a0f6e966c592df96182b6e203b55b437ce Author: David Black <dmblack@google.com> Date: Wed Mar 6 22:58:14 2019 +0000 Fixed horizontal alignment in Dialog Plate. Previously, the animated voice input toggle was slightly off center: https://screenshot.googleplex.com/tODAXyEw64F Bug: 924624 Change-Id: I30b230a22afa152a4081aa9f25347a696a002179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506381 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Tao Wu <wutao@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#638325} ash/app_list/views/assistant/dialog_plate.cc | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) commit 99d553b36101f7d2ab0c6a02433a39114f7cbf7c Author: dstockwell <dstockwell@google.com> Date: Wed Mar 6 22:57:54 2019 +0000 pdf: Switch to the threaded version of ink Updates the resource manager to not require a mime type when loading a bundled resource. This is the same as the behavior in [1]. [1] https://cs.chromium.org/chromium/src/extensions/browser/extension_protocols.cc?q=extension_protocols.cc&sq=package:chromium&dr&l=340 Bug: 902646 Change-Id: Ib65eafd6fc900351a9270317a711c9d3ab092f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501194 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638324} .../extensions/chrome_component_extension_resource_manager.cc | 2 ++ chrome/browser/extensions/chrome_url_request_util.cc | 4 ---- third_party/ink/ink_resources.grd | 6 ++++-- 3 files changed, 6 insertions(+), 6 deletions(-) commit 6189619bb99a0cf82ba75b3d13bf12db47d02526 Author: dstockwell <dstockwell@google.com> Date: Wed Mar 6 22:56:24 2019 +0000 pdf: Work around a web-animations bug in viewer-pen-options Bug: 902646,938857 Change-Id: I8a6165fc0de258b634733b77ac166c184882318a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505733 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638323} .../elements/viewer-pen-options/viewer-pen-options.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) commit e001b097521713d835c2d03623d6183bb3f0ba63 Author: Jerome Jiang <jianj@google.com> Date: Wed Mar 6 22:55:41 2019 +0000 Roll src/third_party/libvpx/source/libvpx/ 503cb8e63..d64e32862 (8 commits) https://chromium.googlesource.com/webm/libvpx.git/+log/503cb8e63a06..d64e328624e0 $ git log 503cb8e63..d64e32862 --date=short --no-merges --format='%ad %ae %s' 2019-03-05 jianj vp9 svc example: use CONFIG_VP9_DECODER guarding decoding. 2019-02-12 angiebird Add rd_diff_arr to store future blocks' rd diff 2019-03-04 angiebird Fix compile error when DUMP_TPL_STATS is 1 2019-03-04 marpan vp9-rtc: Speed feature changes to speed 9 2019-03-01 marpan vp9-rtc: Adjust force split logic for screen mode 2019-03-01 marpan vp9-rtc: Fix for scroll motion for rtc 2018-12-07 paulwilkins Strengthened film grain setting. 2019-02-26 paulwilkins Fix RD multiplier bug impacting AQ1. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I8619ec2af03d0f24d3e243fd9c647c4db39c3ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506459 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#638322} DEPS | 2 +- third_party/libvpx/README.chromium | 4 ++-- third_party/libvpx/source/config/vpx_version.h | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) commit 78d6b9950b4bd9462c226b2cc2ac1f74ad84ad6a Author: Sajjad Mirza <sajjadm@google.com> Date: Wed Mar 6 22:55:16 2019 +0000 Use the wrapper script in all coverage builds. Previously the wrapper script would only be used for coverage builds that required selective instrumentation of specific files. Now it will also be used for any coverage builds. Since the script's job is to remove flags from files that shouldn't have them the default_coverage config now adds to cflags even in a CQ build. Bug: 918215 Change-Id: I012c5732d46bf5cff9eaf8f50615739bb781cc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496002 Commit-Queue: Sajjad Mirza <sajjadm@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638321} build/config/coverage/BUILD.gn | 29 +++++++++++--------------- build/toolchain/gcc_toolchain.gni | 43 ++++++++++++++++++++++++++++++--------- 2 files changed, 45 insertions(+), 27 deletions(-) commit 599457eb67133814e730136d838df28495138f7d Author: Joshua Peraza <jperaza@chromium.org> Date: Wed Mar 6 22:51:00 2019 +0000 Don't sample reports with --enable-crash-reporter-for-testing Bug: 923475 Change-Id: I83a67e5053bf50ce6299523eb0cadff68b8169d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506656 Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#638320} .../common/crash_reporter/aw_crash_reporter_client.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit c79836f63fb108d2e819b79f913d52588f6a3a60 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Mar 6 22:49:39 2019 +0000 Enable sync pseudo-USS codepath by default The feature toggles are on track to be launched in M73 via server-side variations, so let's enable them all by default for M74. Bug: 902704 Change-Id: I0763b2ecb8a572d975cd6da56892e74e3da59a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503572 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#638319} chrome/browser/sync/chrome_sync_client.cc | 15 ++++++++++----- components/sync/driver/sync_driver_switches.cc | 26 +++++++++++++------------- 2 files changed, 23 insertions(+), 18 deletions(-) commit 37e0badf11c0ede44c74e3cd437ba776066525a5 Author: Jarryd <jarrydg@chromium.org> Date: Wed Mar 6 22:44:24 2019 +0000 Quota: Remove virtual qualifier from ~QutaTemporaryStorageEvictor The class has no superclasses or subclasses, so it is confusing for the reader to see the virtual qualifier here. This change clarifies for the readers how this class is used. Change-Id: I22fc58f88a0dd7091c530ce55357ed783d4b46c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506377 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#638318} storage/browser/quota/quota_temporary_storage_evictor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8d909aee36c5b10fa4897b227cf880d2ab4f4ba3 Author: Demetrios Papadopoulos <dpapad@chromium.org> Date: Wed Mar 6 22:42:16 2019 +0000 Revert "Settings cleanup: Remove obsolete setTimeout() work-around." This reverts commit 3194759c52cfd74359470e6a4b371cf3617b8e07. Reason for revert: Caused https://crbug.com/938839. Seems that the workaround is still needed even without animations. Original change's description: > Settings cleanup: Remove obsolete setTimeout() work-around. > > This workaround refers to 859794 which is obsolete after removal of > page/subpage animations. > > Bug: 859794 > Change-Id: I688ec714117f90a797db1b1baacc6eb9d2138751 > Reviewed-on: https://chromium-review.googlesource.com/c/1490436 > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: calamity <calamity@chromium.org> > Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636347} TBR=calamity@chromium.org,dpapad@chromium.org,hcarmona@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859794,938839 Change-Id: Id83ed5c68320815b75c49acb06b21afbb7ed9007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506464 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638317} .../settings/global_scroll_target_behavior.js | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) commit 1862faa915045eeaba77ef0e9ef6eff72d126df2 Author: Rahul Singh <rahsin@microsoft.com> Date: Wed Mar 6 22:41:43 2019 +0000 webvtt: Add support for Windows system styling for captions This change: 1) Adds 4 new properties to CaptionStyle. 2) Adds caption_style_win.cc that contains a Windows implementation for CaptionStyle::FromSystemSettings(). 3) Adds a new feature flag to enable Windows system styling. 4) Follows the same pattern as the earlier change here: https://chromium-review.googlesource.com/c/chromium/src/+/1418399 Next steps: Add support for background opacity, window opacity, and window color Bug: 897730 Change-Id: Iefb0092c32b4fdb3d4d6412a2e21b9bdf018887f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482140 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Rahul Singh <rahsin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#638316} chrome/browser/chrome_content_browser_client.cc | 4 + content/public/common/common_param_traits_macros.h | 4 + content/public/common/web_preferences.h | 9 + content/renderer/render_view_impl.cc | 8 + ui/base/ui_base_features.cc | 4 + ui/base/ui_base_features.h | 2 + ui/native_theme/BUILD.gn | 5 + ui/native_theme/caption_style.cc | 8 +- ui/native_theme/caption_style.h | 10 +- ui/native_theme/caption_style_win.cc | 233 +++++++++++++++++++++ ui/native_theme/caption_style_win_unittest.cc | 33 +++ ui/native_theme/native_theme.cc | 13 +- 12 files changed, 326 insertions(+), 7 deletions(-) commit 73ff9e189ebceb486d4b5b2f069f9424b0cbfeb9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 22:41:03 2019 +0000 Roll src/third_party/depot_tools 0668403dfdd6..61a1b5f31059 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0668403dfdd6..61a1b5f31059 git log 0668403dfdd6..61a1b5f31059 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 spang@chromium.org Avoid unnecessary invocations of "git fetch" Created with: gclient setdep -r src/third_party/depot_tools@61a1b5f31059 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938627 TBR=agable@chromium.org Change-Id: I06964df9cebf7fa67eb148d0477220f3fe9259ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506475 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638315} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1e3686d36a52a6a50ba38c059ed49363591a225f Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Wed Mar 6 22:40:37 2019 +0000 Extension Messaging: Implement reply to content script from SW. This CL adds support to send ExtensionHostMsg_PostMessage IPC from worker threads. This allows reply to work targeting a Service Worker. Bug: 925927 Test: chrome.runtime.sendMessage can use reply callback. Change-Id: I2c64992847f0f8746a455941a58841e5f1fea8c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506009 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638314} .../extensions/service_worker_messaging_apitest.cc | 23 ++++++++++++++++++++++ .../send_message_tab_to_worker/content_script.js | 11 +++++++++++ .../send_message_tab_to_worker/manifest.json | 11 +++++++++++ .../service_worker_background.js | 13 ++++++++++++ extensions/renderer/extension_port.cc | 17 ++++++++-------- extensions/renderer/ipc_message_sender.cc | 2 +- 6 files changed, 68 insertions(+), 9 deletions(-) commit fa2ab1c1183e3da78525d8767e8a986c2d9c85b6 Author: Krishna Govind <govind@chromium.org> Date: Wed Mar 6 22:39:46 2019 +0000 Updating XTBs based on .GRDs from branch master R=benmason@chromium.org Change-Id: Ie53cce111fb1cbc2024050efd70bf3874ccef459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506471 Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#638313} ash/strings/ash_strings_am.xtb | 2 +- ash/strings/ash_strings_ar.xtb | 2 +- ash/strings/ash_strings_bg.xtb | 6 +- ash/strings/ash_strings_bn.xtb | 2 +- ash/strings/ash_strings_ca.xtb | 2 +- ash/strings/ash_strings_cs.xtb | 6 +- ash/strings/ash_strings_da.xtb | 2 +- ash/strings/ash_strings_de.xtb | 2 +- ash/strings/ash_strings_el.xtb | 2 +- ash/strings/ash_strings_en-GB.xtb | 2 +- ash/strings/ash_strings_es-419.xtb | 6 +- ash/strings/ash_strings_es.xtb | 2 +- ash/strings/ash_strings_et.xtb | 2 +- ash/strings/ash_strings_fa.xtb | 6 +- ash/strings/ash_strings_fi.xtb | 6 +- ash/strings/ash_strings_fil.xtb | 2 +- ash/strings/ash_strings_fr.xtb | 2 +- ash/strings/ash_strings_gu.xtb | 2 +- ash/strings/ash_strings_hi.xtb | 2 +- ash/strings/ash_strings_hr.xtb | 2 +- ash/strings/ash_strings_hu.xtb | 2 +- ash/strings/ash_strings_id.xtb | 2 +- ash/strings/ash_strings_it.xtb | 2 +- ash/strings/ash_strings_iw.xtb | 2 +- ash/strings/ash_strings_ja.xtb | 2 +- ash/strings/ash_strings_kn.xtb | 2 +- ash/strings/ash_strings_ko.xtb | 6 +- ash/strings/ash_strings_lt.xtb | 2 +- ash/strings/ash_strings_lv.xtb | 2 +- ash/strings/ash_strings_ml.xtb | 2 +- ash/strings/ash_strings_mr.xtb | 2 +- ash/strings/ash_strings_ms.xtb | 2 +- ash/strings/ash_strings_nl.xtb | 2 +- ash/strings/ash_strings_no.xtb | 2 +- ash/strings/ash_strings_pl.xtb | 2 +- ash/strings/ash_strings_pt-BR.xtb | 2 +- ash/strings/ash_strings_pt-PT.xtb | 2 +- ash/strings/ash_strings_ro.xtb | 2 +- ash/strings/ash_strings_ru.xtb | 2 +- ash/strings/ash_strings_sk.xtb | 2 +- ash/strings/ash_strings_sl.xtb | 6 +- ash/strings/ash_strings_sr.xtb | 2 +- ash/strings/ash_strings_sv.xtb | 2 +- ash/strings/ash_strings_sw.xtb | 2 +- ash/strings/ash_strings_ta.xtb | 2 +- ash/strings/ash_strings_te.xtb | 2 +- ash/strings/ash_strings_th.xtb | 6 +- ash/strings/ash_strings_tr.xtb | 6 +- ash/strings/ash_strings_uk.xtb | 6 +- ash/strings/ash_strings_vi.xtb | 2 +- ash/strings/ash_strings_zh-CN.xtb | 6 +- ash/strings/ash_strings_zh-TW.xtb | 6 +- .../translations/android_chrome_strings_am.xtb | 3 +- .../translations/android_chrome_strings_ar.xtb | 1 - .../translations/android_chrome_strings_bg.xtb | 19 ++++++ .../translations/android_chrome_strings_ca.xtb | 1 - .../translations/android_chrome_strings_cs.xtb | 19 ++++++ .../translations/android_chrome_strings_da.xtb | 1 - .../translations/android_chrome_strings_de.xtb | 1 - .../translations/android_chrome_strings_el.xtb | 1 - .../translations/android_chrome_strings_en-GB.xtb | 1 - .../translations/android_chrome_strings_es-419.xtb | 19 ++++++ .../translations/android_chrome_strings_es.xtb | 1 - .../translations/android_chrome_strings_et.xtb | 1 - .../translations/android_chrome_strings_fa.xtb | 19 ++++++ .../translations/android_chrome_strings_fi.xtb | 19 ++++++ .../translations/android_chrome_strings_fil.xtb | 1 - .../translations/android_chrome_strings_fr.xtb | 1 - .../translations/android_chrome_strings_gu.xtb | 1 - .../translations/android_chrome_strings_hr.xtb | 1 - .../translations/android_chrome_strings_hu.xtb | 1 - .../translations/android_chrome_strings_id.xtb | 1 - .../translations/android_chrome_strings_it.xtb | 1 - .../translations/android_chrome_strings_iw.xtb | 3 +- .../translations/android_chrome_strings_kn.xtb | 1 - .../translations/android_chrome_strings_ko.xtb | 19 ++++++ .../translations/android_chrome_strings_lt.xtb | 1 - .../translations/android_chrome_strings_lv.xtb | 1 - .../translations/android_chrome_strings_ml.xtb | 1 - .../translations/android_chrome_strings_mr.xtb | 1 - .../translations/android_chrome_strings_ms.xtb | 1 - .../translations/android_chrome_strings_nl.xtb | 3 +- .../translations/android_chrome_strings_no.xtb | 1 - .../translations/android_chrome_strings_pl.xtb | 1 - .../translations/android_chrome_strings_pt-BR.xtb | 1 - .../translations/android_chrome_strings_pt-PT.xtb | 1 - .../translations/android_chrome_strings_ro.xtb | 1 - .../translations/android_chrome_strings_ru.xtb | 1 - .../translations/android_chrome_strings_sk.xtb | 1 - .../translations/android_chrome_strings_sl.xtb | 19 ++++++ .../translations/android_chrome_strings_sr.xtb | 1 - .../translations/android_chrome_strings_sv.xtb | 1 - .../translations/android_chrome_strings_sw.xtb | 1 - .../translations/android_chrome_strings_ta.xtb | 1 - .../translations/android_chrome_strings_te.xtb | 1 - .../translations/android_chrome_strings_th.xtb | 19 ++++++ .../translations/android_chrome_strings_tr.xtb | 19 ++++++ .../translations/android_chrome_strings_uk.xtb | 19 ++++++ .../translations/android_chrome_strings_vi.xtb | 1 - .../translations/android_chrome_strings_zh-CN.xtb | 19 ++++++ .../translations/android_chrome_strings_zh-TW.xtb | 19 ++++++ chrome/app/resources/generated_resources_am.xtb | 15 +---- chrome/app/resources/generated_resources_ar.xtb | 13 ---- chrome/app/resources/generated_resources_bg.xtb | 39 +++++++---- chrome/app/resources/generated_resources_bn.xtb | 13 ---- chrome/app/resources/generated_resources_ca.xtb | 13 ---- chrome/app/resources/generated_resources_cs.xtb | 39 +++++++---- chrome/app/resources/generated_resources_da.xtb | 14 +--- chrome/app/resources/generated_resources_de.xtb | 13 ---- chrome/app/resources/generated_resources_el.xtb | 13 ---- chrome/app/resources/generated_resources_en-GB.xtb | 13 ---- .../app/resources/generated_resources_es-419.xtb | 39 +++++++---- chrome/app/resources/generated_resources_es.xtb | 13 ---- chrome/app/resources/generated_resources_et.xtb | 13 ---- chrome/app/resources/generated_resources_fa.xtb | 39 +++++++---- chrome/app/resources/generated_resources_fi.xtb | 39 +++++++---- chrome/app/resources/generated_resources_fil.xtb | 13 ---- chrome/app/resources/generated_resources_fr.xtb | 13 ---- chrome/app/resources/generated_resources_gu.xtb | 13 ---- chrome/app/resources/generated_resources_hi.xtb | 13 ---- chrome/app/resources/generated_resources_hr.xtb | 13 ---- chrome/app/resources/generated_resources_hu.xtb | 13 ---- chrome/app/resources/generated_resources_id.xtb | 13 ---- chrome/app/resources/generated_resources_it.xtb | 13 ---- chrome/app/resources/generated_resources_iw.xtb | 14 +--- chrome/app/resources/generated_resources_ja.xtb | 13 ---- chrome/app/resources/generated_resources_kn.xtb | 13 ---- chrome/app/resources/generated_resources_ko.xtb | 39 +++++++---- chrome/app/resources/generated_resources_lt.xtb | 13 ---- chrome/app/resources/generated_resources_lv.xtb | 15 +---- chrome/app/resources/generated_resources_ml.xtb | 13 ---- chrome/app/resources/generated_resources_mr.xtb | 13 ---- chrome/app/resources/generated_resources_ms.xtb | 13 ---- chrome/app/resources/generated_resources_nl.xtb | 17 +---- chrome/app/resources/generated_resources_no.xtb | 15 +---- chrome/app/resources/generated_resources_pl.xtb | 13 ---- chrome/app/resources/generated_resources_pt-BR.xtb | 13 ---- chrome/app/resources/generated_resources_pt-PT.xtb | 13 ---- chrome/app/resources/generated_resources_ro.xtb | 13 ---- chrome/app/resources/generated_resources_ru.xtb | 13 ---- chrome/app/resources/generated_resources_sk.xtb | 13 ---- chrome/app/resources/generated_resources_sl.xtb | 39 +++++++---- chrome/app/resources/generated_resources_sr.xtb | 13 ---- chrome/app/resources/generated_resources_sv.xtb | 13 ---- chrome/app/resources/generated_resources_sw.xtb | 13 ---- chrome/app/resources/generated_resources_ta.xtb | 13 ---- chrome/app/resources/generated_resources_te.xtb | 13 ---- chrome/app/resources/generated_resources_th.xtb | 39 +++++++---- chrome/app/resources/generated_resources_tr.xtb | 39 +++++++---- chrome/app/resources/generated_resources_uk.xtb | 39 +++++++---- chrome/app/resources/generated_resources_vi.xtb | 13 ---- chrome/app/resources/generated_resources_zh-CN.xtb | 39 +++++++---- chrome/app/resources/generated_resources_zh-TW.xtb | 40 ++++++++---- .../chromevox/strings/chromevox_strings_am.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ar.xtb | 20 ------ .../chromevox/strings/chromevox_strings_bg.xtb | 20 ------ .../chromevox/strings/chromevox_strings_bn.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ca.xtb | 28 ++------ .../chromevox/strings/chromevox_strings_cs.xtb | 22 +------ .../chromevox/strings/chromevox_strings_da.xtb | 20 ------ .../chromevox/strings/chromevox_strings_de.xtb | 20 ------ .../chromevox/strings/chromevox_strings_el.xtb | 20 ------ .../chromevox/strings/chromevox_strings_en-GB.xtb | 20 ------ .../chromevox/strings/chromevox_strings_es-419.xtb | 20 ------ .../chromevox/strings/chromevox_strings_es.xtb | 20 ------ .../chromevox/strings/chromevox_strings_et.xtb | 20 ------ .../chromevox/strings/chromevox_strings_fa.xtb | 20 ------ .../chromevox/strings/chromevox_strings_fi.xtb | 20 ------ .../chromevox/strings/chromevox_strings_fil.xtb | 20 ------ .../chromevox/strings/chromevox_strings_fr.xtb | 20 ------ .../chromevox/strings/chromevox_strings_gu.xtb | 20 ------ .../chromevox/strings/chromevox_strings_hi.xtb | 20 ------ .../chromevox/strings/chromevox_strings_hr.xtb | 20 ------ .../chromevox/strings/chromevox_strings_hu.xtb | 20 ------ .../chromevox/strings/chromevox_strings_id.xtb | 20 ------ .../chromevox/strings/chromevox_strings_it.xtb | 20 ------ .../chromevox/strings/chromevox_strings_iw.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ja.xtb | 20 ------ .../chromevox/strings/chromevox_strings_kn.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ko.xtb | 20 ------ .../chromevox/strings/chromevox_strings_lt.xtb | 20 ------ .../chromevox/strings/chromevox_strings_lv.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ml.xtb | 20 ------ .../chromevox/strings/chromevox_strings_mr.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ms.xtb | 20 ------ .../chromevox/strings/chromevox_strings_nl.xtb | 20 ------ .../chromevox/strings/chromevox_strings_no.xtb | 20 ------ .../chromevox/strings/chromevox_strings_pl.xtb | 20 ------ .../chromevox/strings/chromevox_strings_pt-BR.xtb | 20 ------ .../chromevox/strings/chromevox_strings_pt-PT.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ro.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ru.xtb | 26 +------- .../chromevox/strings/chromevox_strings_sk.xtb | 20 ------ .../chromevox/strings/chromevox_strings_sl.xtb | 20 ------ .../chromevox/strings/chromevox_strings_sr.xtb | 20 ------ .../chromevox/strings/chromevox_strings_sv.xtb | 20 ------ .../chromevox/strings/chromevox_strings_sw.xtb | 20 ------ .../chromevox/strings/chromevox_strings_ta.xtb | 20 ------ .../chromevox/strings/chromevox_strings_te.xtb | 20 ------ .../chromevox/strings/chromevox_strings_th.xtb | 20 ------ .../chromevox/strings/chromevox_strings_tr.xtb | 20 ------ .../chromevox/strings/chromevox_strings_uk.xtb | 20 ------ .../chromevox/strings/chromevox_strings_vi.xtb | 20 ------ .../chromevox/strings/chromevox_strings_zh-CN.xtb | 20 ------ .../chromevox/strings/chromevox_strings_zh-TW.xtb | 20 ------ .../gaiacp/strings/gaia_resources_am.xtb | 2 +- .../gaiacp/strings/gaia_resources_bg.xtb | 2 + .../gaiacp/strings/gaia_resources_cs.xtb | 2 + .../gaiacp/strings/gaia_resources_es-419.xtb | 2 + .../gaiacp/strings/gaia_resources_fa.xtb | 2 + .../gaiacp/strings/gaia_resources_fi.xtb | 2 + .../gaiacp/strings/gaia_resources_ko.xtb | 2 + .../gaiacp/strings/gaia_resources_sl.xtb | 2 + .../gaiacp/strings/gaia_resources_th.xtb | 2 + .../gaiacp/strings/gaia_resources_tr.xtb | 2 + .../gaiacp/strings/gaia_resources_uk.xtb | 2 + .../gaiacp/strings/gaia_resources_zh-CN.xtb | 2 + .../gaiacp/strings/gaia_resources_zh-TW.xtb | 2 + .../policy/resources/policy_templates_am.xtb | 24 +++---- .../policy/resources/policy_templates_ar.xtb | 18 ++--- .../policy/resources/policy_templates_bg.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_bn.xtb | 5 ++ .../policy/resources/policy_templates_ca.xtb | 18 ++--- .../policy/resources/policy_templates_cs.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_da.xtb | 18 ++--- .../policy/resources/policy_templates_de.xtb | 18 ++--- .../policy/resources/policy_templates_el.xtb | 18 ++--- .../policy/resources/policy_templates_en-GB.xtb | 18 ++--- .../policy/resources/policy_templates_es-419.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_es.xtb | 18 ++--- .../policy/resources/policy_templates_et.xtb | 18 ++--- .../policy/resources/policy_templates_fa.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_fi.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_fil.xtb | 18 ++--- .../policy/resources/policy_templates_fr.xtb | 18 ++--- .../policy/resources/policy_templates_gu.xtb | 18 ++--- .../policy/resources/policy_templates_hi.xtb | 5 ++ .../policy/resources/policy_templates_hr.xtb | 18 ++--- .../policy/resources/policy_templates_hu.xtb | 18 ++--- .../policy/resources/policy_templates_id.xtb | 18 ++--- .../policy/resources/policy_templates_it.xtb | 18 ++--- .../policy/resources/policy_templates_iw.xtb | 18 ++--- .../policy/resources/policy_templates_ja.xtb | 5 ++ .../policy/resources/policy_templates_kn.xtb | 18 ++--- .../policy/resources/policy_templates_ko.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_lt.xtb | 18 ++--- .../policy/resources/policy_templates_lv.xtb | 26 +++----- .../policy/resources/policy_templates_ml.xtb | 18 ++--- .../policy/resources/policy_templates_mr.xtb | 18 ++--- .../policy/resources/policy_templates_ms.xtb | 18 ++--- .../policy/resources/policy_templates_nl.xtb | 30 ++++----- .../policy/resources/policy_templates_no.xtb | 21 ++---- .../policy/resources/policy_templates_pl.xtb | 18 ++--- .../policy/resources/policy_templates_pt-BR.xtb | 18 ++--- .../policy/resources/policy_templates_pt-PT.xtb | 18 ++--- .../policy/resources/policy_templates_ro.xtb | 18 ++--- .../policy/resources/policy_templates_ru.xtb | 20 ++---- .../policy/resources/policy_templates_sk.xtb | 18 ++--- .../policy/resources/policy_templates_sl.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_sr.xtb | 18 ++--- .../policy/resources/policy_templates_sv.xtb | 26 +++----- .../policy/resources/policy_templates_sw.xtb | 18 ++--- .../policy/resources/policy_templates_ta.xtb | 18 ++--- .../policy/resources/policy_templates_te.xtb | 18 ++--- .../policy/resources/policy_templates_th.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_tr.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_uk.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_vi.xtb | 18 ++--- .../policy/resources/policy_templates_zh-CN.xtb | 76 ++++++++++++++++++++++ .../policy/resources/policy_templates_zh-TW.xtb | 76 ++++++++++++++++++++++ components/strings/components_strings_am.xtb | 16 +++-- components/strings/components_strings_ar.xtb | 6 +- components/strings/components_strings_bg.xtb | 34 +++++++++- components/strings/components_strings_bn.xtb | 5 +- components/strings/components_strings_ca.xtb | 6 +- components/strings/components_strings_cs.xtb | 36 +++++++++- components/strings/components_strings_da.xtb | 6 +- components/strings/components_strings_de.xtb | 6 +- components/strings/components_strings_el.xtb | 6 +- components/strings/components_strings_en-GB.xtb | 6 +- components/strings/components_strings_es-419.xtb | 34 +++++++++- components/strings/components_strings_es.xtb | 6 +- components/strings/components_strings_et.xtb | 6 +- components/strings/components_strings_fa.xtb | 34 +++++++++- components/strings/components_strings_fi.xtb | 34 +++++++++- components/strings/components_strings_fil.xtb | 6 +- components/strings/components_strings_fr.xtb | 6 +- components/strings/components_strings_gu.xtb | 6 +- components/strings/components_strings_hi.xtb | 5 +- components/strings/components_strings_hr.xtb | 6 +- components/strings/components_strings_hu.xtb | 6 +- components/strings/components_strings_id.xtb | 6 +- components/strings/components_strings_it.xtb | 6 +- components/strings/components_strings_iw.xtb | 6 +- components/strings/components_strings_ja.xtb | 5 +- components/strings/components_strings_kn.xtb | 6 +- components/strings/components_strings_ko.xtb | 34 +++++++++- components/strings/components_strings_lt.xtb | 6 +- components/strings/components_strings_lv.xtb | 8 ++- components/strings/components_strings_ml.xtb | 6 +- components/strings/components_strings_mr.xtb | 6 +- components/strings/components_strings_ms.xtb | 6 +- components/strings/components_strings_nl.xtb | 12 ++-- components/strings/components_strings_no.xtb | 6 +- components/strings/components_strings_pl.xtb | 6 +- components/strings/components_strings_pt-BR.xtb | 6 +- components/strings/components_strings_pt-PT.xtb | 6 +- components/strings/components_strings_ro.xtb | 6 +- components/strings/components_strings_ru.xtb | 6 +- components/strings/components_strings_sk.xtb | 6 +- components/strings/components_strings_sl.xtb | 34 +++++++++- components/strings/components_strings_sr.xtb | 6 +- components/strings/components_strings_sv.xtb | 6 +- components/strings/components_strings_sw.xtb | 6 +- components/strings/components_strings_ta.xtb | 6 +- components/strings/components_strings_te.xtb | 6 +- components/strings/components_strings_th.xtb | 34 +++++++++- components/strings/components_strings_tr.xtb | 34 +++++++++- components/strings/components_strings_uk.xtb | 34 +++++++++- components/strings/components_strings_vi.xtb | 6 +- components/strings/components_strings_zh-CN.xtb | 34 +++++++++- components/strings/components_strings_zh-TW.xtb | 34 +++++++++- .../strings/translations/content_strings_bg.xtb | 4 ++ .../strings/translations/content_strings_cs.xtb | 4 ++ .../strings/translations/content_strings_el.xtb | 2 +- .../translations/content_strings_es-419.xtb | 4 ++ .../strings/translations/content_strings_fa.xtb | 4 ++ .../strings/translations/content_strings_fi.xtb | 4 ++ .../strings/translations/content_strings_ko.xtb | 4 ++ .../strings/translations/content_strings_sl.xtb | 4 ++ .../strings/translations/content_strings_th.xtb | 4 ++ .../strings/translations/content_strings_tr.xtb | 4 ++ .../strings/translations/content_strings_uk.xtb | 4 ++ .../strings/translations/content_strings_zh-CN.xtb | 4 ++ .../strings/translations/content_strings_zh-TW.xtb | 4 ++ .../strings/resources/ios_chromium_strings_bg.xtb | 1 + .../strings/resources/ios_chromium_strings_cs.xtb | 1 + .../resources/ios_chromium_strings_es-419.xtb | 1 + .../strings/resources/ios_chromium_strings_fa.xtb | 1 + .../strings/resources/ios_chromium_strings_fi.xtb | 1 + .../strings/resources/ios_chromium_strings_ko.xtb | 1 + .../strings/resources/ios_chromium_strings_sl.xtb | 1 + .../strings/resources/ios_chromium_strings_th.xtb | 1 + .../strings/resources/ios_chromium_strings_tr.xtb | 1 + .../strings/resources/ios_chromium_strings_uk.xtb | 1 + .../resources/ios_chromium_strings_zh-CN.xtb | 1 + .../resources/ios_chromium_strings_zh-TW.xtb | 1 + .../app/strings/resources/ios_strings_am.xtb | 1 - .../app/strings/resources/ios_strings_ar.xtb | 1 - .../app/strings/resources/ios_strings_bg.xtb | 4 +- .../app/strings/resources/ios_strings_bn.xtb | 1 - .../app/strings/resources/ios_strings_ca.xtb | 1 - .../app/strings/resources/ios_strings_cs.xtb | 4 +- .../app/strings/resources/ios_strings_da.xtb | 1 - .../app/strings/resources/ios_strings_de.xtb | 1 - .../app/strings/resources/ios_strings_el.xtb | 1 - .../app/strings/resources/ios_strings_en-GB.xtb | 1 - .../app/strings/resources/ios_strings_es-419.xtb | 4 +- .../app/strings/resources/ios_strings_es.xtb | 1 - .../app/strings/resources/ios_strings_et.xtb | 1 - .../app/strings/resources/ios_strings_fa.xtb | 4 +- .../app/strings/resources/ios_strings_fi.xtb | 4 +- .../app/strings/resources/ios_strings_fil.xtb | 1 - .../app/strings/resources/ios_strings_fr.xtb | 1 - .../app/strings/resources/ios_strings_gu.xtb | 1 - .../app/strings/resources/ios_strings_hi.xtb | 1 - .../app/strings/resources/ios_strings_hr.xtb | 1 - .../app/strings/resources/ios_strings_hu.xtb | 1 - .../app/strings/resources/ios_strings_id.xtb | 1 - .../app/strings/resources/ios_strings_it.xtb | 1 - .../app/strings/resources/ios_strings_iw.xtb | 3 +- .../app/strings/resources/ios_strings_ja.xtb | 1 - .../app/strings/resources/ios_strings_kn.xtb | 1 - .../app/strings/resources/ios_strings_ko.xtb | 4 +- .../app/strings/resources/ios_strings_lt.xtb | 1 - .../app/strings/resources/ios_strings_lv.xtb | 1 - .../app/strings/resources/ios_strings_ml.xtb | 1 - .../app/strings/resources/ios_strings_mr.xtb | 1 - .../app/strings/resources/ios_strings_ms.xtb | 1 - .../app/strings/resources/ios_strings_nl.xtb | 1 - .../app/strings/resources/ios_strings_no.xtb | 3 +- .../app/strings/resources/ios_strings_pl.xtb | 1 - .../app/strings/resources/ios_strings_pt-BR.xtb | 1 - .../app/strings/resources/ios_strings_pt-PT.xtb | 1 - .../app/strings/resources/ios_strings_ro.xtb | 1 - .../app/strings/resources/ios_strings_ru.xtb | 5 +- .../app/strings/resources/ios_strings_sk.xtb | 1 - .../app/strings/resources/ios_strings_sl.xtb | 4 +- .../app/strings/resources/ios_strings_sr.xtb | 1 - .../app/strings/resources/ios_strings_sv.xtb | 1 - .../app/strings/resources/ios_strings_sw.xtb | 1 - .../app/strings/resources/ios_strings_ta.xtb | 1 - .../app/strings/resources/ios_strings_te.xtb | 1 - .../app/strings/resources/ios_strings_th.xtb | 4 +- .../app/strings/resources/ios_strings_tr.xtb | 4 +- .../app/strings/resources/ios_strings_uk.xtb | 4 +- .../app/strings/resources/ios_strings_vi.xtb | 1 - .../app/strings/resources/ios_strings_zh-CN.xtb | 4 +- .../app/strings/resources/ios_strings_zh-TW.xtb | 4 +- .../ios_search_widget_extension_strings_bg.xtb | 3 + .../ios_search_widget_extension_strings_cs.xtb | 3 + .../ios_search_widget_extension_strings_es-419.xtb | 3 + .../ios_search_widget_extension_strings_fa.xtb | 3 + .../ios_search_widget_extension_strings_fi.xtb | 3 + .../ios_search_widget_extension_strings_ko.xtb | 3 + .../ios_search_widget_extension_strings_nl.xtb | 6 +- .../ios_search_widget_extension_strings_sl.xtb | 3 + .../ios_search_widget_extension_strings_th.xtb | 3 + .../ios_search_widget_extension_strings_tr.xtb | 3 + .../ios_search_widget_extension_strings_uk.xtb | 3 + .../ios_search_widget_extension_strings_zh-CN.xtb | 3 + .../ios_search_widget_extension_strings_zh-TW.xtb | 3 + ui/strings/translations/ui_strings_bg.xtb | 1 + ui/strings/translations/ui_strings_cs.xtb | 1 + ui/strings/translations/ui_strings_es-419.xtb | 1 + ui/strings/translations/ui_strings_fa.xtb | 1 + ui/strings/translations/ui_strings_fi.xtb | 1 + ui/strings/translations/ui_strings_ko.xtb | 1 + ui/strings/translations/ui_strings_sl.xtb | 1 + ui/strings/translations/ui_strings_th.xtb | 1 + ui/strings/translations/ui_strings_tr.xtb | 1 + ui/strings/translations/ui_strings_uk.xtb | 1 + ui/strings/translations/ui_strings_zh-CN.xtb | 1 + ui/strings/translations/ui_strings_zh-TW.xtb | 1 + 424 files changed, 2534 insertions(+), 2481 deletions(-) commit ad01f9204784dfbcec056b9eae1d5da8e7008ba2 Author: Dan Harrington <harringtond@chromium.org> Date: Wed Mar 6 22:38:35 2019 +0000 Use the final URL in the intent to open an auto-fetch page This prevents a bug which can occurr for URLs that redirect. The bug is a bit subtle, so see the crbug.com/937581 for more details. We're almost guaranteed that Chrome hasn't seen a redirect for the final URL, so this will fix the problem of redirecting before hitting the offline url loader request interceptor. We will intercept requests for either the original URL or the final URL. Note that because we're using a different URL in the intent, when a URL is a redirect, we will always open the page in a new tab. This is not ideal, but is preferable to failing to open the page. Bug: 937581 Change-Id: I04f02556e93eba1ca0b2380313f1052c7f8f7cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505895 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#638312} .../chrome/browser/offlinepages/AutoFetchNotifier.java | 15 +++++++++------ .../browser/offline_pages/android/auto_fetch_notifier.cc | 4 ++-- .../browser/offline_pages/android/auto_fetch_notifier.h | 4 ++-- .../android/offline_page_auto_fetcher_service.cc | 5 +---- 4 files changed, 14 insertions(+), 14 deletions(-) commit 917c098e8f90eeb6ac73f7d585978ace2191e601 Author: Aran Gilman <gilmanmh@google.com> Date: Wed Mar 6 22:37:49 2019 +0000 Check darkModePagePolicy flag before inverting site colors. Bug: 925949 Change-Id: I55a9d8280be7cbe435f7c84629b79e919fdff016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499955 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#638311} .../renderer/core/accessibility/apply_dark_mode.cc | 17 +++++++++++++++-- third_party/blink/renderer/core/frame/settings.json5 | 6 ++++++ 2 files changed, 21 insertions(+), 2 deletions(-) commit a6be98b125e21283cbf1b766cc6dc28981936b73 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Mar 6 22:37:23 2019 +0000 Fire name changed events when image annotations change. We introduced two new accessibility attributes for image annotations. When these attributes change, it's exposed to assistive technology as part of the accessible name, so we need to fire name changed events to guarantee that AT is updated. Bug: 905419 Change-Id: I63d64b895ccbfc3265f037de3227be3da4dc41dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504705 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#638310} ui/accessibility/ax_event_generator.cc | 9 ++- ui/accessibility/ax_event_generator_unittest.cc | 93 ++++++++++++++++--------- 2 files changed, 70 insertions(+), 32 deletions(-) commit ca7eff86b17492979fb90d4c0d467fcbd8ca10d3 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Mar 6 22:34:01 2019 +0000 [LayoutNG] Remove a stale TODO Tbr: eae@chromium.org NoTry: True Change-Id: I8811ef4a85c350663e280543f76a950abae858a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505901 Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638309} .../blink/renderer/core/layout/ng/inline/ng_offset_mapping_builder.h | 1 - 1 file changed, 1 deletion(-) commit 591bdd0de0c820a715eaa18f93b8090da3a8af9f Author: James Cook <jamescook@chromium.org> Date: Wed Mar 6 22:33:04 2019 +0000 Fix text caret visibility after screen rotation on SingleProcessMash There can be a race between the browser receiving window bounds updates and the IME ensuring the text caret is visible. * Repeat the text caret visibility request after virtual keyboard occluded bounds update. This is a no-op if the caret is already visible. * Fix double-conversion of local bounds to screen bounds in chrome's receipt of occluded bounds from ash. * Clarify variable names with coordinate system. Bug: 937722 Change-Id: I0f49413ca63582469cf0a4b61cde69733c1841ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504150 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#638308} ash/keyboard/ash_keyboard_controller.cc | 22 +++------- ash/keyboard/ash_keyboard_controller.h | 8 ++-- .../keyboard/chrome_keyboard_bounds_observer.cc | 50 +++++++++++++++------- .../ash/keyboard/chrome_keyboard_bounds_observer.h | 6 +-- .../keyboard/chrome_keyboard_controller_client.cc | 5 +-- .../keyboard/chrome_keyboard_controller_client.h | 6 +-- .../browser/ui/ash/keyboard/chrome_keyboard_ui.h | 1 + .../ui/views/ime_driver/remote_text_input_client.h | 2 + ui/keyboard/keyboard_controller.cc | 5 ++- ui/keyboard/keyboard_controller.h | 3 +- ui/keyboard/keyboard_controller_observer.h | 8 ++-- 11 files changed, 65 insertions(+), 51 deletions(-) commit f1092ff4c5a57d39196c4821a623d12df03b80d4 Author: Alexei Filippov <alph@chromium.org> Date: Wed Mar 6 22:30:42 2019 +0000 DevTools: Make line level profile support memory annotations. BUG=937880 Change-Id: Ib222ad6cddf23b0f28863e75f1bc729e638c6ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504460 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638307} .../devtools/front_end/perf_ui/LineLevelProfile.js | 205 ++++++++++++++------- .../devtools/front_end/perf_ui/module.json | 5 + .../devtools/front_end/profiler/CPUProfileView.js | 2 +- .../devtools/front_end/sdk/HeapProfilerModel.js | 7 +- .../devtools/front_end/source_frame/SourceFrame.js | 3 +- .../front_end/sources/UISourceCodeFrame.js | 20 +- .../devtools/front_end/text_editor/cmdevtools.css | 15 +- .../devtools/front_end/timeline/TimelinePanel.js | 6 +- .../timeline-js-line-level-profile-expected.txt | 14 +- .../timeline-js/timeline-js-line-level-profile.js | 2 +- 10 files changed, 185 insertions(+), 94 deletions(-) commit b604a31e3a9abba542acccd2f872a1c2aed14bb6 Author: Raymond Toy <rtoy@chromium.org> Date: Wed Mar 6 22:29:33 2019 +0000 Add pending activity to keep Webaudio media nodes alive MediaStreamSourceNode and related nodes should report they have activity whenever the context is running, because they actually do. This prevents the nodes from getting prematurely collected. Unfortunately, this also means nodes will not be collected until the context is suspended or stopped. Bug: 937231 Change-Id: I4cd93fe757d8f34fbbc0c68aeaace4727c77be14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496541 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638306} .../renderer/modules/webaudio/media_stream_audio_source_node.cc | 5 +++++ .../renderer/modules/webaudio/media_stream_audio_source_node.h | 8 ++++++-- .../renderer/modules/webaudio/media_stream_audio_source_node.idl | 3 ++- 3 files changed, 13 insertions(+), 3 deletions(-) commit 315120d5b0e484ab678508a2fd95fcb4d64b5030 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 22:26:15 2019 +0000 Roll src/third_party/chromite 767948b07604..c3ec692344cb (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/767948b07604..c3ec692344cb git log 767948b07604..c3ec692344cb --date=short --no-merges --format='%ad %ae %s' 2019-03-06 dgarrett@google.com workspace_stages: Add SyncChrome timeout. Created with: gclient setdep -r src/third_party/chromite@c3ec692344cb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I58f7b56c9a2251c891eda19d3884929a6987e9ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506477 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638305} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 87854753705c4aa0c5b05944228b17f90d8e0b32 Author: Robert Ogden <robertogden@chromium.org> Date: Wed Mar 6 22:25:20 2019 +0000 Return IsBlacklisted = true by default if hints aren't loaded This also moves the ignore blacklist flag one call level higher for use in browser tests, instead of having to load hints for every test. Bug: 938621 Change-Id: Ie13f87463dccb9e2a3d57a0cda9b89a80fdb9f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504256 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#638304} .../previews/previews_lite_page_browsertest.cc | 4 +++ components/previews/content/previews_hints.cc | 12 ++++----- .../previews/content/previews_hints_unittest.cc | 29 ++++++++-------------- .../content/previews_optimization_guide.cc | 17 ++++++++++--- .../previews_optimization_guide_unittest.cc | 22 +++++++++++++--- 5 files changed, 53 insertions(+), 31 deletions(-) commit 5d251dfe307d807285fe8b63aaa87559f645b8c5 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Wed Mar 6 22:23:24 2019 +0000 Add a test that ensures that pointer events are not routed to portals. Bug: 933515 Change-Id: I2c4f239144d3ed060d5bace974b5646b086ca9db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479422 Commit-Queue: Lucas Gadani <lfg@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#638303} content/browser/portal/portal_browsertest.cc | 66 ++++++++++++++++++++++ .../site_per_process_hit_test_browsertest.cc | 30 ---------- content/public/test/browser_test_utils.cc | 22 ++++++++ content/public/test/browser_test_utils.h | 28 +++++++++ 4 files changed, 116 insertions(+), 30 deletions(-) commit 49fb7b6bfcef4950f38d355289b0b03a429a9ea1 Author: Jérôme Lebel <jlebel@chromium.org> Date: Wed Mar 6 22:21:19 2019 +0000 [iOS] Reenable unity tests Updating +[ChromeMatchers googleServicesSettingsButton], to find the "Sync and Google services" cell. This cell cannot be found with its accessibility text since the sync status (detail text of the cell) can vary. The issue was created with: crrev.com/c/1497003 Bug: 937855 Change-Id: Ia8ab1f90a3c8476f2710b48cdcacb1278aa292e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503414 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638302} .../google_services/google_services_settings_egtest.mm | 6 ++---- ios/chrome/test/earl_grey/chrome_matchers.mm | 10 ++++++++-- 2 files changed, 10 insertions(+), 6 deletions(-) commit 0cb1be90fb4c818386d047aaac61346aad97bc83 Author: Sajjad Mirza <sajjadm@google.com> Date: Wed Mar 6 22:20:11 2019 +0000 Exclude mojo for Android from a Chrome on Chrome OS coverage build. There are missing clang runtime libraries that are needed to successfully link libmojo in a coverage configuration. This workaround lets us get coverage data for the rest of Chrome on Chrome OS. This patch was authored by Noel Gordon, who initially reported this issue. Bug: 865376 Change-Id: I88b309760836639b80dfa0f7b67e4bb5c2b55d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493471 Commit-Queue: Sajjad Mirza <sajjadm@google.com> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#638301} chrome/BUILD.gn | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit f244166c744aedc3e1fda6077485d85f329c9786 Author: Avery Musbach <amusbach@chromium.org> Date: Wed Mar 6 22:15:36 2019 +0000 splitview: Fix animation parameters for fading out the preview area. According to the specification, when you drag a window to snap it, the preview area (referred to as "Indicator") should fade out over 67 ms, fast out, linear in: https://mccanny.users.x20web.corp.google.com/www/splitscreen-motion/index.html#window-drop Currently, it fades out over 250 ms, fast out, slow in. BEFORE: https://photos.app.goo.gl/MQa3rZ4jKX4hZLba7 AFTER: https://photos.app.goo.gl/iLFHyvqxFZsfreEC6 Test: manual Bug: 934977 Change-Id: I27d3e4d758097f2a87207880b2bc5ca9622dad7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504037 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#638300} ash/wm/splitview/split_view_drag_indicators.cc | 6 ++-- ash/wm/splitview/split_view_highlight_view.cc | 40 ++++++++++++++++++++------ ash/wm/splitview/split_view_highlight_view.h | 6 ++-- ash/wm/splitview/split_view_utils.cc | 7 +++++ ash/wm/splitview/split_view_utils.h | 5 ++-- 5 files changed, 50 insertions(+), 14 deletions(-) commit 786a2312336c1987d3a54473ecd9db6dd0852f2f Author: Lindsay Pasricha <lindsayw@google.com> Date: Wed Mar 6 22:14:36 2019 +0000 Decomm ios-webview, repurpose for ios13-beta-simulator, create ios12-beta tybot infra cl: https://chrome-internal-review.googlesource.com/c/infradata/config/+/914125 Bug: 936908 Change-Id: I15d82cdf4ca0edb78a7258b6477deaaa0941c6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496656 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638299} infra/config/cr-buildbucket.cfg | 5 +- infra/config/luci-milo.cfg | 44 +++++----- infra/config/luci-scheduler.cfg | 14 ++-- .../bots/chromium.fyi/ios13-beta-simulator.json | 18 +++++ ios/build/bots/chromium.mac/ios-webview.json | 94 ---------------------- 5 files changed, 54 insertions(+), 121 deletions(-) commit b9f360a1846a9be12b3c46e0935a8d0c81666f2c Author: Paul Irish <paulirish@chromium.org> Date: Wed Mar 6 22:14:23 2019 +0000 DevTools: Roll Lighthouse to 4.1.0 Changelog: https://github.com/googlechrome/lighthouse/compare/v4.0.0...v4.1.0 Change-Id: Ief76c7c2d0fb4b44e9332b91c2a6bb99f46a9d2e Bug: 772558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506382 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Auto-Submit: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#638298} .../audits2/lighthouse/renderer/report-renderer.js | 2 +- .../lighthouse/renderer/report-ui-features.js | 6 +- .../lighthouse/lighthouse-dt-bundle.js | 1294 ++++++++++++-------- .../audits2/audits2-successful-run-expected.txt | 23 +- 4 files changed, 785 insertions(+), 540 deletions(-) commit 648ae960ac6f03d676d63ef641586aaf0320fe43 Author: manuk <manukh@chromium.org> Date: Wed Mar 6 22:10:43 2019 +0000 [omnibox chrome:omnibox]: Remove hidden text for boolean fields. Previously, boolean fields such as the "Can be default" which display a green check-mark or red x-mark would additionally contain invisible (CSS font-size 0) text "true" or "false" in order to allow selecting and copying them. This CL removes this hidden text as we're no longer supporting selecting and copying partial outputs. Bug: 937321 Change-Id: Ic347c3f99d645463c59bc2c15d95aaf9148b2f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496923 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638297} chrome/browser/resources/omnibox/omnibox_output.js | 1 - chrome/browser/resources/omnibox/output_results_group.css | 1 - 2 files changed, 2 deletions(-) commit 4710b2338a43d879b95d9875c3ef8e66b022cc86 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 6 22:09:15 2019 +0000 Roll src-internal a2179093ac06..0ab64c504cf5 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a2179093ac06..0ab64c504cf5 Created with: gclient setdep -r src-internal@0ab64c504cf5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:937987 TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I2f2f1b098b44f2404bf4d9fee5dc52c364a536e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506364 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638296} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5a93a1b8b4d24166b7d1509a5b9760e7f9bead57 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Wed Mar 6 22:06:43 2019 +0000 Each Profile owns its own SimpleFactoryKey. Bug: 933784 Change-Id: I3bc03760dea254fa33f8c660689739db65a1ce9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492791 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638295} .../cached_image_fetcher_bridge.cc | 2 +- .../offline_pages/android/prefetch_test_bridge.cc | 3 +- .../prefetch/prefetch_service_factory.cc | 3 +- .../profiles/off_the_record_profile_impl.cc | 18 ++++++------ .../browser/profiles/off_the_record_profile_impl.h | 10 ++++--- chrome/browser/profiles/profile.cc | 7 ----- chrome/browser/profiles/profile.h | 12 ++------ chrome/browser/profiles/profile_impl.cc | 23 ++++++--------- chrome/browser/profiles/profile_impl.h | 12 ++++---- chrome/test/base/testing_profile.cc | 34 ++++++++-------------- chrome/test/base/testing_profile.h | 16 ++++------ 11 files changed, 53 insertions(+), 87 deletions(-) commit 8b2dca4291d5c1a0be86c7ac2ad6b22d31d4f498 Author: rajendrant <rajendrant@chromium.org> Date: Wed Mar 6 22:03:21 2019 +0000 LazyLoad: Change attribute from lazyload to load The attribute values change from on/off/auto to lazy/eager/auto Bug: 936572 Change-Id: I014891934cde248c1ea0a969d89b3b0d75eec2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500017 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#638294} .../renderer/core/html/html_attribute_names.json5 | 2 +- .../renderer/core/html/html_frame_owner_element.cc | 12 ++--- .../renderer/core/html/html_iframe_element.idl | 2 +- .../blink/renderer/core/html/html_image_element.cc | 4 +- .../renderer/core/html/html_image_element.idl | 2 +- .../core/html/lazy_load_frame_observer_test.cc | 32 ++++++------ .../core/html/parser/html_preload_scanner.cc | 5 +- .../blink/renderer/core/loader/image_loader.cc | 2 +- .../lazyload-enabled-image-tentative.sub.html | 4 +- .../lazyload/lazyload-enabled-tentative.sub.html | 18 +++---- .../web_tests/http/tests/lazyload/attribute.html | 58 +++++++++++----------- 11 files changed, 70 insertions(+), 71 deletions(-) commit 44ea54e8b01109114d62bdb045a5b7b0af628b7e Author: Fredrik Söderquist <fs@opera.com> Date: Wed Mar 6 22:00:26 2019 +0000 Fix hit-testing of nested clip-paths with objectBoundingBox units A nested clip-path should resolve against the original elements reference box, but it would instead resolve against the referencing <clipPath>. Pass the appropriate reference box to SVGLayoutSupport::IntersectsClipPath. Took the opportunity to export some related tests to WPT. Bug: 938913 Change-Id: I6d6ad88f0a97028b21b1f1a488afbdd42a96264b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505949 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#638293} .../core/layout/svg/layout_svg_container.cc | 3 +- .../renderer/core/layout/svg/layout_svg_image.cc | 3 +- .../core/layout/svg/layout_svg_resource_clipper.cc | 3 +- .../renderer/core/layout/svg/layout_svg_shape.cc | 3 +- .../renderer/core/layout/svg/layout_svg_text.cc | 3 +- .../renderer/core/layout/svg/svg_layout_support.cc | 2 +- .../renderer/core/layout/svg/svg_layout_support.h | 9 ++++- .../clip-path-element-objectboundingbox-001.html} | 11 +++--- .../clip-path-element-objectboundingbox-002.html | 44 ++++++++++++++++++++++ .../clip-path-element-userspaceonuse-001.html} | 16 ++++---- .../clip-path-shape-polygon-and-box-shadow.html} | 16 ++++---- 11 files changed, 84 insertions(+), 29 deletions(-) commit b36fdbaf338d893ea4ead668a8bc01f46ac60945 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Mar 6 21:54:33 2019 +0000 Entry point button should have a focus ring on keypress after mouse click. Bug: 937218 Change-Id: I66a30f2f095731957055cf082e39657a5c551b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497415 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#638292} chrome/browser/resources/local_ntp/custom_backgrounds.css | 3 +-- chrome/browser/resources/local_ntp/custom_backgrounds.js | 6 ------ chrome/browser/resources/local_ntp/local_ntp.css | 4 ---- chrome/browser/resources/local_ntp/local_ntp.js | 2 +- chrome/browser/resources/local_ntp/local_ntp_common.css | 5 +++++ chrome/browser/resources/local_ntp/utils.js | 10 ++++++---- 6 files changed, 13 insertions(+), 17 deletions(-) commit f650c896e9f94fa43e90c0f6b4445e45b1ad7845 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 21:50:00 2019 +0000 Roll src/third_party/pdfium 9ba187ae4751..3df5c7cf7b58 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/9ba187ae4751..3df5c7cf7b58 git log 9ba187ae4751..3df5c7cf7b58 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 tsepez@chromium.org Fix temporary going out of scope too early in XFA_LoadImageData() Created with: gclient setdep -r src/third_party/pdfium@3df5c7cf7b58 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:937199 TBR=dsinclair@chromium.org Change-Id: I89e3c61b3e366e54de2f5ef32bc6b18d1d339ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506476 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638291} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d63a471f66130229b84b4f7967d9afce531884a Author: Scott Violet <sky@chromium.org> Date: Wed Mar 6 21:48:18 2019 +0000 cc: avoid friending test And instead make function public. I did not move the definition, because, as far as I can tell, the declarations/definitions are rather out of sync for this file. BUG=none TEST=none Change-Id: Ie0b21ffdf14513e1e67c4d1d0dce70703745387f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505838 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Scott Violet <sky@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#638290} cc/layers/layer_impl.h | 14 ++++++-------- cc/layers/surface_layer_impl_unittest.cc | 4 +--- 2 files changed, 7 insertions(+), 11 deletions(-) commit 5dd9513f5c3838274dc7a5aa91cc163302883228 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Wed Mar 6 21:46:50 2019 +0000 [Layered API] Implement origin trials: BuiltInModuleKvStorage This CL adds origin_trial_feature_name to - "BuiltInModuleInfra" - "BuiltInModuleKvStorage" While "BuiltInModuleInfra" origin trial is not needed for end users, this is needed in terms of implementation, because "BuiltInModuleInfra" should be enabled if "BuiltInModuleKvStorage" is enabled, and thus "BuiltInModuleInfra" flag should also depend on origin trials. By adding origin_trial_feature_name to "BuiltInModuleInfra", origin_trials::BuiltInModuleInfraEnabled() takes care of the dependency. As origin trials requires ExecutionContext, this CL associates built-in module feature control with Modulator, by introducing - Modulator::BuiltInModuleInfraEnabled() - Modulator::BuiltInModuleEnabled() This CL plumbs Modulator via ModuleScriptFetcher::Fetch() and ImportMap, to plumb Modulator::BuiltInModule*Enabled() to layered_api.cc. It seems a little confusing that ModuleScriptFetcher takes both Modulator and ResourceFetcher that refer module map settings object and fetch client settings object, respectively. This is actually consistent, because built-in modules are associated with module map settings object and the current implementation of import maps is also associated with Modulator (crbug/928435), while fetching should refer to fetch client settings object. This apparent inconsistency should be resolved by - Fixing Issue 928435, or - Enabling Built-in modules by default (which will remove dependencies to ExecutionContext/Modulator again), or - Refactoring ModuleScriptFetcher. This CL implements individual control over built-in modules in ModulatorImplBase::BuiltInModuleEnabled(). After this CL, - "BuiltInModuleKvStorage" enables "kv-storage" and "blank" only, and - "BuiltInModuleInfra" flag enables "blank" only, while they enabled all built-in modules before this CL. Bug: 829084, 928435 Change-Id: I0ee2838c0981192e9a993cb784bc39d866682836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497468 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#638289} .../modulescript/document_module_script_fetcher.cc | 11 +++-- .../modulescript/document_module_script_fetcher.h | 4 +- ...stalled_service_worker_module_script_fetcher.cc | 1 + ...nstalled_service_worker_module_script_fetcher.h | 1 + .../loader/modulescript/module_script_fetcher.h | 7 +++ .../loader/modulescript/module_script_loader.cc | 2 +- .../core/loader/modulescript/module_tree_linker.cc | 5 +-- .../modulescript/worker_module_script_fetcher.cc | 1 + .../modulescript/worker_module_script_fetcher.h | 1 + .../modulescript/worklet_module_script_fetcher.cc | 1 + .../modulescript/worklet_module_script_fetcher.h | 1 + .../blink/renderer/core/script/import_map.cc | 29 +++++++++--- .../blink/renderer/core/script/import_map.h | 10 +++-- .../blink/renderer/core/script/layered_api.cc | 18 ++++---- .../blink/renderer/core/script/layered_api.h | 15 ++++++- .../blink/renderer/core/script/layered_api_test.cc | 51 +++++++++++++++++----- third_party/blink/renderer/core/script/modulator.h | 4 ++ .../renderer/core/script/modulator_impl_base.cc | 24 +++++++++- .../renderer/core/script/modulator_impl_base.h | 3 ++ .../blink/renderer/core/script/module_map_test.cc | 1 + .../blink/renderer/core/script/script_loader.cc | 6 +-- .../blink/renderer/core/testing/dummy_modulator.cc | 8 ++++ .../blink/renderer/core/testing/dummy_modulator.h | 3 ++ .../workers/worklet_module_responses_map_test.cc | 1 + .../platform/runtime_enabled_features.json5 | 2 + 25 files changed, 164 insertions(+), 46 deletions(-) commit 999fbba8c74b7b9ab3518194d5a63a71f4b79af9 Author: Jian Li <jianli@chromium.org> Date: Wed Mar 6 21:46:10 2019 +0000 Intercept page download as offline page This works for network service both enabled and disabled. Bug: 938696 Change-Id: I2210f44861976b14508c1eff8401bc12958dc87c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504692 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by: Dmitry Titov <dimich@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638288} .../download/chrome_download_manager_delegate.cc | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) commit 0101b70e0115a7d77d86f9803328c47e50595a2e Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Wed Mar 6 21:41:41 2019 +0000 [Payment Request][Android] Cancel payment in tab overview mode. Before this patch, a payment app that was slow to respond to `canmakepayment` event would leave a window of time when the user could enter the tab overview mode in Android, which did not cancel the ongoing payment, even though the merchant page was no longer in focus. The tab overview mode displays a list of user tabs and is used for tab switching. Chrome already listened to tab switch events, so selecting a different tab does cancel the ongoing payment. This patch cancels the ongoing payment when Chrome enters into the overview mode. After this patch, Chrome cancels the ongoing payment if the user enters the tab overview mode, which can happen when the payment app is slow to respond to `canmakepayment` event. Bug: 817073 Change-Id: I852d8467bb4e349bcc9afb322d973a9bccca0910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506374 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638287} .../browser/payments/PaymentRequestImpl.java | 31 ++++++++++++++++++++++ 1 file changed, 31 insertions(+) commit bfa0a0c554a4dfa356cd56545ab5fd0f4bbc05b7 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Wed Mar 6 21:32:45 2019 +0000 Cleanup Lookalike interstitial browser tests. This is a cleanup CL to add a few missing, and simplify existing, interstitial tests. It also includes a few unaddressed nits from earlier CLs. Bug: 927924 Change-Id: Iaa177d8dfc69d127b6ba2af5c8f508d5e5d8db83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497756 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638286} ...ookalike_url_navigation_throttle_browsertest.cc | 434 ++++++++------------- .../ui/omnibox/alternate_nav_infobar_delegate.cc | 1 + 2 files changed, 160 insertions(+), 275 deletions(-) commit 0c5d294c30f813142cef8e7598d89115b060a869 Author: Sammie Quon <sammiequon@google.com> Date: Wed Mar 6 21:30:00 2019 +0000 overview: Partial revert of dimming the wallpaper. Partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1481899. It turns out that that change did not remove a full screen blit, so it was a lateral change at best. But that cl does fix another wallpaper bug and left some framework for the next change, which confirm to remove a fullscreen blit, but will not make it in time for m74. TBR=xiyuan@chromium.org Test: none Bug: 774690 Change-Id: I3a42d9a2dfdc81b848998858ea4fad0218c7f7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506372 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#638285} ash/wallpaper/wallpaper_controller.cc | 5 +-- ash/wallpaper/wallpaper_view.h | 4 +- ash/wallpaper/wallpaper_widget_controller.cc | 7 ---- ash/wallpaper/wallpaper_widget_controller.h | 8 ---- ash/wm/overview/overview_controller.cc | 28 ------------- ash/wm/overview/overview_grid.cc | 46 ++++++++++++++++++++++ ash/wm/overview/overview_grid.h | 3 ++ .../tablet_mode_browser_window_drag_delegate.cc | 32 +-------------- 8 files changed, 55 insertions(+), 78 deletions(-) commit 9fbbb56b59808597edf3d46a5ffa20a9c929d95a Author: James Cook <jamescook@chromium.org> Date: Wed Mar 6 21:28:44 2019 +0000 Eliminate a parameter from ash::NonClientFrameController The |window_type| is always ws::mojom::WindowType::WINDOW, so it doesn't need to be a parameter. Bug: none Change-Id: Id0ec9146d64e9653983f12945a1436083371633c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506110 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#638284} ash/wm/non_client_frame_controller.cc | 10 ++-------- ash/wm/non_client_frame_controller.h | 4 ---- ash/wm/top_level_window_factory.cc | 4 ++-- 3 files changed, 4 insertions(+), 14 deletions(-) commit 84fe619b56fc01f12c582272eb849df88372fc5b Author: btolsch <btolsch@chromium.org> Date: Wed Mar 6 21:28:40 2019 +0000 Remove UI thread WeakPtrFactory from DialService A previous change to use the network service introduced two WeakPtrFactory members to DialServiceImpl. Although this gets around the advice to only use WeakPtrs from one factory on a single sequence, it doesn't actually solve the problem: ~DialServiceImpl still runs on the IO thread, which may cause some UI thread WeakPtrs to be invalidated, resulting in a DCHECK (or a race). The UI thread doesn't actually need any of DialServiceImpl's data though, so this change just makes the functions previously using it into free functions which then call back onto the IO thread with a proper WeakPtr. Bug: 934611, 936531 Change-Id: Iee1612cd9934bef109bbfa79d497685dbd275d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504980 Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638283} .../media/router/discovery/dial/dial_service.cc | 122 ++++++++++++--------- .../media/router/discovery/dial/dial_service.h | 22 ++-- 2 files changed, 77 insertions(+), 67 deletions(-) commit 901ef74cdf0bdda573a4e705827264b6a2d65ab4 Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Date: Wed Mar 6 21:26:30 2019 +0000 flags: remove enable-image-capture-api. ImageCapture API has been stable from M59. We can retire this flag now. Bug: 518807 Change-Id: I78efd9694b9f2f34fb20fe1f760066b98e371708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506073 Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#638282} chrome/browser/about_flags.cc | 3 --- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- content/browser/image_capture/image_capture_impl.cc | 3 --- content/public/common/content_features.cc | 4 ---- content/public/common/content_features.h | 1 - 7 files changed, 24 deletions(-) commit 4a96841d48ba27d69bd570e390d3f1dd32a1aa87 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Mar 6 21:23:01 2019 +0000 Change blink::FileSystemDispatcher to take real subclasses ... for different operations instead of AsyncFileSystemCallbacks. The only noticiable missing operation that still refers to AsyncFileSystemCallbacks (instead of a more speciallized class) is CreateSnapshotFile. This is because blink::DOMFileSystemSync::CreateFile uses its own AsyncFileSystemCallbacks derived class to perform CreateSnapshotFile operations (namely CreateFileHelper). BUG=933878 Change-Id: I977911f1d97557d4da308337720436556c622f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499873 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#638281} .../renderer/modules/filesystem/dom_file_system.cc | 5 +- .../modules/filesystem/dom_file_system_base.cc | 16 ++-- .../modules/filesystem/dom_file_system_sync.cc | 7 +- .../modules/filesystem/file_system_callbacks.cc | 14 ++-- .../modules/filesystem/file_system_callbacks.h | 50 ++++++------- .../modules/filesystem/file_system_dispatcher.cc | 87 ++++++++++------------ .../modules/filesystem/file_system_dispatcher.h | 55 +++++++------- .../modules/filesystem/local_file_system.cc | 20 ++--- .../modules/filesystem/local_file_system.h | 30 ++++---- .../filesystem/worker_global_scope_file_system.cc | 9 +-- 10 files changed, 141 insertions(+), 152 deletions(-) commit c50a3d59ca8df3f2f730810e68b78a7d7e173476 Author: btolsch <btolsch@chromium.org> Date: Wed Mar 6 21:22:42 2019 +0000 Add third_party/openscreen/src to DEPS This change adds the Open Screen Protocol library to DEPS so that our team can begin working on Chromium integration and testing ahead of its completion. Change-Id: I52ebca0b3eb890b4be2529b4cbb99a944e5133eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480703 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Brandon Tolsch <btolsch@chromium.org> Cr-Commit-Position: refs/heads/master@{#638280} DEPS | 4 ++++ third_party/.gitignore | 1 + third_party/openscreen/OWNERS | 3 +++ third_party/openscreen/README.chromium | 15 +++++++++++++++ 4 files changed, 23 insertions(+) commit 4fff66e2884cf0ced8711af4de9acb94f6607aa6 Author: Owen Min <zmin@chromium.org> Date: Wed Mar 6 21:19:58 2019 +0000 Revert "Changed XRHandedness enum to 'none' from empty string" This reverts commit c92b0f22f6d33955ec9e42acdd7d91d3577883b6. Reason for revert: Causing https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/31011 Original change's description: > Changed XRHandedness enum to 'none' from empty string > > Bug: 933411 > Change-Id: I7e698846e7c733c15a82bd9079855df1e2d5abf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504223 > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Commit-Queue: Brandon Jones <bajones@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638243} TBR=bajones@chromium.org,bsheedy@chromium.org,klausw@chromium.org Change-Id: I09a7db9d04fb9d51a07e3600a593ec20c1d398bf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506568 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638279} .../blink/renderer/modules/xr/xr_input_source.cc | 5 +- .../blink/renderer/modules/xr/xr_input_source.h | 9 +- .../blink/renderer/modules/xr/xr_input_source.idl | 1 - .../web_tests/xr/getInputPose_handedness.html | 102 --------------------- .../web_tests/xr/xrInputSource_add_remove.html | 4 +- 5 files changed, 5 insertions(+), 116 deletions(-) commit 7973f37c161d3cbd847bd140ef3446a0c6ceca3b Author: Peng Huang <penghuang@chromium.org> Date: Wed Mar 6 21:18:53 2019 +0000 SkiaRenderer: Use the correct texture target to create promise image Change-Id: I421e266c8b9be2839f3c106ce0a7935b7f030706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506467 Reviewed-by: vikas soni <vikassoni@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#638278} components/viz/service/display_embedder/skia_output_surface_impl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee72f4957506d942970bbdc7be2fcd65ecf7fae2 Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Wed Mar 6 21:18:36 2019 +0000 Implement tab (content script) to Service Worker extension messaging. This is the first step towards implementation of Extension messaging in Extension Service Workers. The CL implements chrome.test.sendMessage from a tab (content script) to a Service Worker running as extension background. Replying to the message through callback isn't implemented in this CL. The basic changes in this CL are: - Make the messaging bindings available in the service workers' script context: runtime.sendMessage and runtime.onMessage. - Handle IPCs to open/close a port for workers as well. - Handle these IPCs in the browser process in the existing MessagingService class, expand ExtensionMessagePort to support workers along with RenderFrames/tabs. - Both JS and native bindings work. - Future CLs can expand on this base CL to support other messaging source and destinations as the implementation is meant to move the code towards generic support of messaging endpoints (worker or RenderFrame). Some more detailed implementation notes: - ExtensionMessagePort can track and target workers along with existing RenderFrames/tabs support. Handle the IPCs sent by it on worker thread (WorkerThreadDispatcher), these IPCs are: * ExtensionMsg_ValidateMessagePort * ExtnesionMsg_DispatchOnConnect * ExtensionMsg_DippatchOnDisconnect * ExtensionMsg_DeliverMessage - MessageService can now work with Service Workers, similar to how they used to work with event pages. - Introduce a generic ScriptContextSetIterator class in the renderer to apply IPCs to a set of ScriptContexts. Expand that to cover WorkerScriptContextSets as well as non-worker ScriptContextSets. Messaging IPCs targeted to workers now get dispatched to WorkerScriptContextSets. An unfortunate consequence of generalizing this to worker is Dispatcher provides a non-const ptr getter to ScriptContextSets (script_context_set_iterator) as worker script context sets require tls lookup. Add an end-to-end test for the feature. Bug: 925927 Change-Id: I8f77e6d63318925b85dc5707f9367e904bde634c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1441274 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638277} .../extensions/service_worker_messaging_apitest.cc | 91 +++++++ .../chrome_extensions_renderer_client.cc | 2 +- .../extension_hooks_delegate_unittest.cc | 5 +- chrome/test/BUILD.gn | 1 + .../content_script.js | 5 + .../manifest.json | 11 + .../service_worker_background.js | 10 + .../api/messaging/extension_message_port.cc | 279 +++++++++++++++++---- .../browser/api/messaging/extension_message_port.h | 61 ++++- extensions/browser/api/messaging/message_port.cc | 6 +- extensions/browser/api/messaging/message_port.h | 9 +- .../browser/api/messaging/message_service.cc | 90 ++++--- extensions/browser/api/messaging/message_service.h | 42 ++-- extensions/browser/extension_message_filter.cc | 9 +- extensions/common/api/_api_features.json | 6 +- extensions/renderer/BUILD.gn | 2 + extensions/renderer/dispatcher.cc | 18 +- extensions/renderer/dispatcher.h | 10 + extensions/renderer/extension_frame_helper.cc | 16 +- extensions/renderer/extension_port.cc | 32 ++- extensions/renderer/ipc_message_sender.cc | 49 +++- .../native_renderer_messaging_service_unittest.cc | 22 +- extensions/renderer/renderer_messaging_service.cc | 18 +- extensions/renderer/renderer_messaging_service.h | 10 +- extensions/renderer/script_context_set.cc | 7 +- extensions/renderer/script_context_set.h | 29 +-- extensions/renderer/script_context_set_iterable.cc | 21 ++ extensions/renderer/script_context_set_iterable.h | 46 ++++ extensions/renderer/worker_script_context_set.cc | 16 ++ extensions/renderer/worker_script_context_set.h | 10 +- extensions/renderer/worker_thread_dispatcher.cc | 62 ++++- extensions/renderer/worker_thread_dispatcher.h | 21 ++ 32 files changed, 808 insertions(+), 208 deletions(-) commit 05d66a56b339e56c1be8dbeba5988afb1ddab6db Author: Anthony Vallee-Dubois <anthonyvd@chromium.org> Date: Wed Mar 6 21:13:00 2019 +0000 Add some enum entries to InitiationStatus The recent refactor to TranslateManager made it so that some cases that didn't trigger translations were misreported in the wrong buckets for InitiationStatus. This CL adds buckets for those cases. Bug: 924980 Change-Id: I6a00b523842ea4fb665e27e8791b399964c7f66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504253 Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638276} .../core/browser/translate_browser_metrics.h | 4 +++- .../translate/core/browser/translate_manager.cc | 25 +++++++++++++++++----- tools/metrics/histograms/enums.xml | 2 ++ 3 files changed, 25 insertions(+), 6 deletions(-) commit de1732cfddb849f133905776c15a985f8345dc3e Author: Nick Harper <nharper@chromium.org> Date: Wed Mar 6 21:12:52 2019 +0000 Add .gov domains to HSTS preload list as requested by dotgov Change-Id: Icabee8c59a5c776d1d56322621db1862a13322f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506553 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#638275} net/http/transport_security_state_static.json | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit ad2731d88c4fe7a5b1150f2f187cf296547a0fbc Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 6 21:10:14 2019 +0000 [Blink] Retroactive nit fixes Fix last nits from https://chromium-review.googlesource.com/c/chromium/src/+/1501497 Bug: None Change-Id: I845ee28bce4f9558254eb2680f976bf024f404a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506118 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638274} third_party/blink/renderer/core/exported/web_console_message.cc | 7 ++++++- third_party/blink/renderer/core/inspector/console_message.h | 5 ++--- 2 files changed, 8 insertions(+), 4 deletions(-) commit 924b8d1110cb0fc2379d84161eb22777781bc83f Author: Piotr Bialecki <bialpio@chromium.org> Date: Wed Mar 6 21:07:51 2019 +0000 Fix phone-ar.html WebXR sample Change-Id: I9b9e2291b56981fe11a5b3ed3033aefbdd2c1779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506461 Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638273} .../webxr-samples/proposals/phone-ar.html | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) commit 78c271f9e7a8329037dddc7b3f9c81d37b62e04d Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Wed Mar 6 21:03:13 2019 +0000 Barcode detection Mac: Reenable using Vision framework This CL reenables using the Vision framework for Barcode detection on Mac (this was broken in previous 10.14 OS updates and as expected is now fixed). It also takes the chance to fill in |corner_points| in DetectedBarcode. Tested by local compilation and running it via: ./out/gn/Chromium.app/Contents/MacOS/Chromium https://yellowdoge.github.io/shapedetection-polyfill/demo.bundle.html --enable-experimental-web-platform-features and verifying the QR (and other) codes, including slanted ones (!). Bug: 921968 Change-Id: Ic485a41305d0290e8a35751a0de703bd674493fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506011 Commit-Queue: Robert Sesek <rsesek@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#638272} base/mac/sdk_forward_declarations.h | 4 ++++ .../shape_detection/barcode_detection_impl_mac_vision.mm | 15 +++++++++++++++ .../shape_detection/barcode_detection_provider_mac.mm | 11 ++--------- 3 files changed, 21 insertions(+), 9 deletions(-) commit ab40da96c12f9c9a09688e0cffc2c1de55bafaf3 Author: Vladimir Levin <vmpstr@chromium.org> Date: Wed Mar 6 21:02:24 2019 +0000 Isolation: Remove isolation if we have non-svg replaced content. This patch ensures that we don't put isolation nodes in place if we have replaced content transform in an non-svg. The reason for this is twofold: 1. Typically, isolation wouldn't buy us anything, since we're likely looking at an image, which has no subtree to isolate. 2. When we get the chain of transforms, we need to decide whether we're returning a replaced content or an isolation transform since they are both leafs of a chain, but not a part of the same chain. Currently we return the isolation node first. We could fix this by returning the replaced content first, but then we specifically bypass transform isolation which may cause other bugs down the line. R=pdr@chromium.org Bug: 937571 Change-Id: I39f51a2e7810f058bfdf49c28c8f2e3857565ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506572 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#638271} .../core/paint/paint_property_tree_builder.cc | 12 ++++++++++++ .../core/paint/paint_property_tree_builder_test.cc | 22 ++++++++++++++++++++++ .../img-with-containment-and-size-ref.html | 8 ++++++++ .../img-with-containment-and-size.html | 22 ++++++++++++++++++++++ 4 files changed, 64 insertions(+) commit 13ad69c94740b703d96eaf4bfb13e9e2208ea970 Author: Travis Skare <skare@chromium.org> Date: Wed Mar 6 21:01:02 2019 +0000 Reland "Add flag for #omnibox-deduplicate-drive-urls" This is a reland of 703661c8155e5f1a0370fa56fa133f24c36de0d8 Original change's description: > Add flag for #omnibox-deduplicate-drive-urls > > Change-Id: I48b82707892caa2ed85ab776b6cae73274382fde > Reviewed-on: https://chromium-review.googlesource.com/c/1481121 > Commit-Queue: Travis Skare <skare@chromium.org> > Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634850} Change-Id: I3551f9b6216795713d7435d534d8b6cebbb9370b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484857 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#638270} chrome/browser/about_flags.cc | 4 ++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ 4 files changed, 18 insertions(+) commit 26cd6c7a671c5c059891b3a426ccc66fa3e458b8 Author: Owen Min <zmin@chromium.org> Date: Wed Mar 6 21:00:00 2019 +0000 Revert "Reland "[blink] Remove old script streamer thread"" This reverts commit 5027aad002604f4008e8f6b4d0804f519f4c1fae. Reason for revert: it's still suspect the test flaky. Flaky tracing issue: Bugs: 939054 Original change's description: > Reland "[blink] Remove old script streamer thread" > > This reverts commit 50b4e18615b57365d245f3f9993faca743a398eb. > > Reason for revert: It was incorrect suspicion, bot became green w/o this revert > > Original change's description: > > Revert "[blink] Remove old script streamer thread" > > > > This reverts commit 96c748b0b0e61d207ef1d3bd70238b3443179b77. > > > > Reason for revert: it's suspect in failures > > https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/88931 > > > > Original change's description: > > > [blink] Remove old script streamer thread > > > > > > The script streamer thread has now been replaced with posting tasks to > > > the scheduler, so remove the flag picking between the two options and > > > the dedicated streaming thread itself. > > > > > > Also, remove the streaming task re-posting now that the blocking/ > > > non-blocking worker pools are merged. > > > > > > Bug: 874080 > > > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > > Reviewed-by: Steven Holte <holte@chromium.org> > > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#638031} > > > > TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,mlippautz@chromium.org,leszeks@chromium.org > > > > Change-Id: Ia67f3fcfbff3155f9da4b53f371115f3dfd0089c > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 874080 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505412 > > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638055} > > TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,dvadym@chromium.org,mlippautz@chromium.org,leszeks@chromium.org > > Change-Id: Ic4eb793dacdaa7565e92ba1b908162f5d3e02e15 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 874080 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505552 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638059} TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,dvadym@chromium.org,mlippautz@chromium.org,leszeks@chromium.org Change-Id: I01a8e948c4b971bedcd8dd27c08d49e7c959c4d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 874080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506756 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638269} content/child/runtime_features.cc | 3 + content/public/common/content_features.cc | 4 + content/public/common/content_features.h | 1 + testing/variations/fieldtrial_testing_config.json | 19 +++++ .../blink/public/platform/web_runtime_features.h | 1 + .../blink/public/platform/web_thread_type.h | 2 +- third_party/blink/renderer/bindings/bindings.gni | 2 + .../renderer/bindings/core/v8/script_streamer.cc | 88 ++++++++++++++++++--- .../renderer/bindings/core/v8/script_streamer.h | 9 ++- .../bindings/core/v8/script_streamer_test.cc | 8 ++ .../bindings/core/v8/script_streamer_thread.cc | 90 ++++++++++++++++++++++ .../bindings/core/v8/script_streamer_thread.h | 60 +++++++++++++++ .../blink/renderer/core/core_initializer.cc | 2 + .../platform/exported/web_runtime_features.cc | 4 + .../platform/runtime_enabled_features.json5 | 3 + .../platform/scheduler/common/metrics_helper.cc | 1 + .../blink/renderer/platform/web_thread_type.cc | 2 + tools/metrics/histograms/enums.xml | 2 +- 18 files changed, 288 insertions(+), 13 deletions(-) commit 4f032dd85cd161cad33c6ac321a39c5be3d9e4d7 Author: Chase Phillips <cmp@chromium.org> Date: Wed Mar 6 20:59:55 2019 +0000 IndexedDB: Convert bindings-inject-key.html to promise-based Update bindings-inject-key.html from an async test to promise-based. This allows the test to run so that each subtest is run serially. Patch by Joshua Bell <jsbell@chromium.org>. Bug: 934844 Change-Id: If9834a35fcb964a6fe15776e3e091d326f3f8a0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504458 Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638268} .../wpt/IndexedDB/bindings-inject-key.html | 155 +++++++++------------ 1 file changed, 63 insertions(+), 92 deletions(-) commit 4e6251e48d0a3717abe65c8ee46454342f032615 Author: Aga Wronska <agawronska@chromium.org> Date: Wed Mar 6 20:55:20 2019 +0000 Extract TimeLimitOverride from usage_time_limit::internal. This change is needed, so TimeLimitOverride can be used outside of TimeLimitsProcessor for local override with parent access code. Refactoring done while moving the class: * Replace constructor that exits early and leaves object in inconsistent state with factory methods * Make class members private and add accessors to comply with style guide * Remove the need for storing second copy of dictionary keys used for serialization in test code * Add serialization to the dictionary Bug: 911326 Test: usage_time_limits_processor_unittest.cc Change-Id: I68ac5a6f17c41e28d3d4905abdfc96901694316b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493154 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#638267} chrome/browser/chromeos/BUILD.gn | 2 + .../screen_time_controller_browsertest.cc | 9 +- .../chromeos/child_accounts/time_limit_override.cc | 141 +++++++++++++++++ .../chromeos/child_accounts/time_limit_override.h | 81 ++++++++++ .../child_accounts/time_limit_test_utils.cc | 52 ++----- .../child_accounts/time_limit_test_utils.h | 9 +- .../child_accounts/usage_time_limit_processor.cc | 172 ++++++--------------- .../child_accounts/usage_time_limit_processor.h | 25 +-- .../usage_time_limit_processor_unittest.cc | 88 +++++++---- 9 files changed, 353 insertions(+), 226 deletions(-) commit 6d296e5a6f29382e514c218bb5ab378350bead33 Author: Klaus Weidner <klausw@chromium.org> Date: Wed Mar 6 20:51:12 2019 +0000 Make laser longer, only show cursor on intersection The combination of a 1m length laser and showing a cursor at 1m distance is visually very confusing when trying to hit objects, especially when doing quick tests on a mirror display without wearing the headset. Instead, use a long laser beam, and only show a cursor when there's a valid intersection with the scene. Change-Id: Id4178b1ba72994c9148d53c8bc58f041fb42520d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506463 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#638266} .../js/cottontail/src/nodes/input-renderer.js | 2 +- .../webxr-samples/js/cottontail/src/scenes/scene.js | 17 ----------------- 2 files changed, 1 insertion(+), 18 deletions(-) commit 6da6e7e79c8c80d995d29af4701baf43c68c6c40 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 20:49:07 2019 +0000 Roll src/third_party/SPIRV-Tools/src 86f6ac086c8b..07f80c4df1b0 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/86f6ac086c8b..07f80c4df1b0 git log 86f6ac086c8b..07f80c4df1b0 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 stevenperron@google.com Fix python scripts to work with python3 (#2426) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@07f80c4df1b0 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5bed70327a7b1df928572f0b1c0ab2a99f956786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506363 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638265} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c87cc708112b4b80f530bc1ecd8730f472bc3c1f Author: Erik Jensen <rkjnsn@chromium.org> Date: Wed Mar 6 20:48:06 2019 +0000 remoting: Add file-transfer policy, enabled by default. File transfer may be undesirable in some enterprise environments, so this adds a policy to allow disabling it. Bug: 679313 Change-Id: Ided7fcb5cb5789851022c61605fb762fcf96705e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501853 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#638264} chrome/test/data/policy/policy_test_cases.json | 3 +++ components/policy/resources/policy_templates.json | 20 ++++++++++++++++- remoting/host/policy_watcher.cc | 3 +++ remoting/host/policy_watcher_unittest.cc | 3 +++ remoting/host/remoting_me2me_host.cc | 27 ++++++++++++++++++----- tools/metrics/histograms/enums.xml | 1 + 6 files changed, 51 insertions(+), 6 deletions(-) commit c72a79b08bfe78e6f85493f96195fcdc4d5521f2 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Wed Mar 6 20:47:46 2019 +0000 Fix placement of Feedback UI Cancel/Send Buttons This fixes the placement of the Cancel and Send buttons in the feedback UI when the available screen area is smaller than the height of the feedback dialog. Previously, in that case the buttons would be pinned to the bottom of the viewport and the content in the dialog would scroll underneath the buttons. This separates them out into a separate div and removes their absolute positioning so that they no longer overlap. Some other margin were changed as well in order to prevent it from having 60px of gap between the privacy notice and the buttons. on current builds or another bug prevents this from being scrollable at all Bug: 866931 Test: Verified w/ and w/out magnifier on, SPM also needs to be disabled Change-Id: Ic58ee0cd3e7251ae3a37fc623f8928e9522066b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504232 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#638263} chrome/browser/resources/feedback/css/feedback.css | 16 ++++++++++++++-- chrome/browser/resources/feedback/html/default.html | 6 ++++-- 2 files changed, 18 insertions(+), 4 deletions(-) commit f597f833b4840a19e9f44ec9a93b2093a68e5d68 Author: Zhenyao Mo <zmo@chromium.org> Date: Wed Mar 6 20:41:06 2019 +0000 Fix two bugs in split_variations_cmd.py 1) A bug introduced during addressing review feedbacks so now the split files can't be split further because they are wrong. 2) The script doesn't work if one if the four switches are missing. This is problematic because we could easily split into a state where certain switches no longer have values. Added unit tests to make sure the above two issues are covered. BUG=932197 TEST=unittests R=askitkine@chromium.org Change-Id: Ic961f609f0a0d00ebf213206a70b4fb76b83aac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497797 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#638262} tools/variations/split_variations_cmd.py | 83 +++++++++++++---------- tools/variations/split_variations_cmd_unittest.py | 41 +++++++++-- 2 files changed, 82 insertions(+), 42 deletions(-) commit 112cfd12127e3484b569a3ce440ae58facefebfc Author: Patrick Noland <pnoland@chromium.org> Date: Wed Mar 6 20:38:14 2019 +0000 [Chromeshine] Rework consent flow and wording This updates the consent flow to 1) Enable revocation via the consent activity 2) Only present the privacy preference when the user has consented 3) Have the privacy preference launch the consent activity for revocation instead of being a checkbox Bug:902490 Change-Id: I34fdc210ee03db100ab9c310ab5fe3d9cda15d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481739 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638261} .../android/java/res/xml/privacy_preferences.xml | 3 +- .../preferences/privacy/PrivacyPreferences.java | 21 ++-- .../usage_stats/UsageStatsConsentActivity.java | 57 ++--------- .../usage_stats/UsageStatsConsentDialog.java | 107 +++++++++++++++++++++ .../java/strings/android_chrome_strings.grd | 17 +++- .../android_chrome_strings_grd/IDS_SHOW.png.sha1 | 1 + .../IDS_USAGE_STATS_CONSENT_PROMPT.png.sha1 | 2 +- .../IDS_USAGE_STATS_CONSENT_TITLE.png.sha1 | 2 +- ...IDS_USAGE_STATS_REVOCATION_EXPLANATION.png.sha1 | 1 + .../IDS_USAGE_STATS_REVOCATION_PROMPT.png.sha1 | 1 + .../IDS_USAGE_STATS_SETTING_TITLE.png.sha1 | 2 +- chrome/android/java_sources.gni | 1 + 12 files changed, 147 insertions(+), 68 deletions(-) commit fc735f1b74f586c5baafa51b68f1488f8ba47475 Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Mar 6 20:29:07 2019 +0000 [IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB IndexedDBFactoryImpl isn't scoped per origin and so can be used by multiple origins. The original code assumed that it was scoped per origin, so when in actuality it was used by multiple origins, when a single origin requested a lock this could interrupt other origins in certain cases. https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.6cqn78xajqmp R=cmp@chromium.org Bug: 934790 Change-Id: I10f3e7c1b43ad7310d8824648575d940568b534d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1487369 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#638260} .../indexed_db_active_blob_registry_unittest.cc | 2 + .../browser/indexed_db/indexed_db_backing_store.h | 6 +++ .../browser/indexed_db/indexed_db_factory_impl.cc | 17 ++++---- .../browser/indexed_db/indexed_db_factory_impl.h | 2 - .../wpt/IndexedDB/idbfactory-origin-isolation.html | 41 ++++++++++++++++++ .../idbfactory-origin-isolation-iframe.html | 50 ++++++++++++++++++++++ 6 files changed, 107 insertions(+), 11 deletions(-) commit d24f2533d45489592b55136e60075f63de6a7996 Author: Tony de Luna <tonydeluna@chromium.org> Date: Wed Mar 6 20:25:42 2019 +0000 OOBE shelf: Only update session state if showing account picker. During OOBE enrollment flow we fetch the list of policies and this may contain users such as a public session user. 1.If the list of users fetched is not empty we show the account picker screen. 2 If the list of users is empty we show the GAIA login screen. We should only update session state to LOGIN_PRIMARY if we show the account picker screen. Session state should remain OOBE if we show the GAIA login screen. Setting the value of session state controls the colors of the buttons and icons in the shelf and setting it incorrectly causes visual bugs. Bug: 937367 Change-Id: Iaa8f5913a36936f0959da8a517ddfb21ea5d5971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500632 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#638259} chrome/browser/chromeos/login/wizard_controller.cc | 4 ---- chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc | 6 ++++++ 2 files changed, 6 insertions(+), 4 deletions(-) commit b0440e2e60cf9c25282bbcaeba2de6b99e1f87b6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 20:23:33 2019 +0000 Roll src/third_party/swiftshader 4c84dbdce271..9584fe43a9c2 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/4c84dbdce271..9584fe43a9c2 git log 4c84dbdce271..9584fe43a9c2 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 chrisforbes@google.com Disable creation of multisample images until they work Created with: gclient setdep -r src/third_party/swiftshader@9584fe43a9c2 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I0f7b5407bf2aed533b383ff67a49d005601d5a6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506474 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638258} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e37d7184a143da103deb648a320fea27223a51a5 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Wed Mar 6 20:22:53 2019 +0000 Hoist VisibleSelection creation from SelectionController::SetNonDirectionalSelectionIfNeeded() to callers This patch hoists the creation of VisibleSelection |new_selection| from the function to its callers, so that the elimination of VisibleSelection canonicalization is easier. Bug: 657237 Change-Id: Ic1c25d9474f1ade210c4389862bafc87e8e8d7b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502152 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638257} .../blink/renderer/core/editing/selection_controller.cc | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) commit 3ec708ec26c773d2b790612d4fa08a0398f827d0 Author: Luna Lu <loonybear@chromium.org> Date: Wed Mar 6 20:22:45 2019 +0000 Update comments for parameterized feature policy In content/public/browser/render_frame_host.h to make it clear how feature values are compared. TBR: kinuko, iclelland Change-Id: Iaee687abe3f49e4c2274fe158fd5ce4fd6151d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504295 Auto-Submit: Luna Lu <loonybear@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#638256} content/public/browser/render_frame_host.h | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit 370527cd789a010114cc5ab3f98bfe303e843b8f Author: Maks Orlovich <morlovich@chromium.org> Date: Wed Mar 6 20:22:29 2019 +0000 AW: CookieManager: Remove redundant scheme check. SetCanonicalCookieAsync has just been fixed to do the check properly, so there is no need for android_webview::CookieManager do duplicate it. Also remove some logging normal devs can't see. Change-Id: If9b6472a9a11c74fab83afcd9e55dca75c0f03fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1486879 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#638255} android_webview/browser/cookie_manager.cc | 36 +------------------------------ android_webview/browser/cookie_manager.h | 3 --- 2 files changed, 1 insertion(+), 38 deletions(-) commit 8070803908de4317006679fe006447fcfd538aa3 Author: Chris Palmer <palmer@chromium.org> Date: Wed Mar 6 20:21:28 2019 +0000 Answer more of people's questions about the Rule Of 2. Or, try to. Also give more examples. Bug: None Change-Id: If7d57944aa61e017bb4b6a7d144ded3b51b04318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497366 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638254} docs/security/rule-of-2.md | 110 ++++++++++++++++++++++++++++++++++++--------- 1 file changed, 90 insertions(+), 20 deletions(-) commit 9e508a68b43c5639d497f0acc5514c1addb49c45 Author: Adrienne Walker <enne@chromium.org> Date: Wed Mar 6 20:21:25 2019 +0000 Remove colorspace from BeginRasterCHROMIUM Now that shared images have a color space in them, we don't need to explicitly pass a color space. Color space transfer cache entries can be removed in a followup. Bug: 933901 Change-Id: I2c95aa14ee79da70a907ff3ce90d38550397ea8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495574 Commit-Queue: enne <enne@chromium.org> Reviewed-by: enne <enne@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638253} cc/layers/heads_up_display_layer_impl.cc | 6 ++---- cc/paint/oop_pixeltest.cc | 6 ++---- cc/paint/paint_op_buffer.cc | 5 +++-- cc/paint/paint_op_buffer.h | 6 +++--- cc/paint/paint_op_buffer_serializer.cc | 10 +++++---- cc/paint/paint_op_buffer_serializer.h | 6 +++--- cc/paint/paint_op_buffer_unittest.cc | 21 ++++--------------- cc/paint/paint_op_reader.cc | 12 +++++------ cc/paint/shader_transfer_cache_entry.cc | 2 -- cc/paint/shader_transfer_cache_entry.h | 3 --- cc/raster/gpu_raster_buffer_provider.cc | 6 ++---- cc/test/test_options_provider.cc | 2 +- cc/test/test_options_provider.h | 2 +- .../client/raster_cmd_helper_autogen.h | 4 +--- gpu/command_buffer/client/raster_implementation.cc | 24 +++++----------------- gpu/command_buffer/client/raster_implementation.h | 2 +- .../client/raster_implementation_gles.cc | 2 +- .../client/raster_implementation_gles.h | 2 +- gpu/command_buffer/client/raster_interface.h | 12 +++++------ .../common/raster_cmd_format_autogen.h | 17 ++++----------- .../common/raster_cmd_format_test_autogen.h | 3 +-- gpu/command_buffer/raster_cmd_buffer_functions.txt | 2 +- ...gles2_cmd_decoder_passthrough_doer_prototypes.h | 3 +-- .../service/gles2_cmd_decoder_passthrough_doers.cc | 3 +-- gpu/command_buffer/service/raster_decoder.cc | 18 ---------------- .../service/raster_decoder_autogen.h | 5 +---- gpu/ipc/client/raster_in_process_context_tests.cc | 5 ++--- 27 files changed, 57 insertions(+), 132 deletions(-) commit 1ec1977c05e588bb8a4f5a12657bfc08f2becd9b Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Mar 6 20:20:22 2019 +0000 Revert "[SessionStorage] Resolve OpenSessionStorage at bind site" This reverts commit 6fc31bcf9d825f705642be0ac7b66af191921848. Reason for revert: The crashes have stopped, so these debugging CLs are being reverted. Original change's description: > [SessionStorage] Resolve OpenSessionStorage at bind site > > R=​mek@chromium.org > > Bug: 927534 > Change-Id: Ic50cb227f34127ed69cbd9e8edf13ca5824238d6 > Reviewed-on: https://chromium-review.googlesource.com/c/1479274 > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Daniel Murphy <dmurph@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633881} TBR=dmurph@chromium.org,mek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 927534 Change-Id: I0a02e62a4b5b6a3a6f6a5ff35ef43326c106a8f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506460 Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638252} .../dom_storage/session_storage_context_mojo.cc | 3 ++- .../session_storage_namespace_impl_mojo.cc | 10 +++----- .../session_storage_namespace_impl_mojo.h | 3 +-- ...session_storage_namespace_impl_mojo_unittest.cc | 30 +++++++++------------- 4 files changed, 19 insertions(+), 27 deletions(-) commit 17dcf3fcff472954f38f0baab321f009573f79d0 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Wed Mar 6 20:20:19 2019 +0000 [iOS][MF] Add more spacing on iPads The space was modifidied in order to match Apple's next and previous arrows below them. Bug: 912551 Change-Id: I41955034a9b9af396ef710dbb494d5a97bbc799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505946 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638251} .../manual_fill_accessory_view_controller.mm | 26 ++++++++++++++++------ 1 file changed, 19 insertions(+), 7 deletions(-) commit f3b329b8d6a93635608fcde9da580cb6c8af08e8 Author: Ken Rockot <rockot@chromium.org> Date: Wed Mar 6 20:19:14 2019 +0000 Add an IPC to force renderer crash from IO thread Amends an existing IO-thread-bound interface in child processes to obey a new Crash() message when received. This is to help debug child process hangs on platforms where we don't get hang crash reports yet. The message is used by the renderer hang monitor if it detects a hung renderer and the user agrees to kill it. Crashes resulting from this change should provide some insight into why renderers are hanging on Chrome OS. Bug: 938647 Change-Id: Ifb5dc8c2f755c4a25f3f712145e4ddb9e32a584a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505832 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#638250} chrome/browser/ui/views/hung_renderer_view.cc | 6 ++++++ content/browser/renderer_host/render_process_host_impl.cc | 4 ++++ content/browser/renderer_host/render_process_host_impl.h | 1 + content/common/child.mojom | 6 +++++- content/common/service_manager/child_connection.cc | 13 +++++++++++++ content/common/service_manager/child_connection.h | 3 +++ .../service_manager/service_manager_connection_impl.cc | 3 +++ content/public/browser/render_process_host.h | 3 +++ 8 files changed, 38 insertions(+), 1 deletion(-) commit deea28a2d403ee20fff62bb3f2c1cbb8c5125609 Author: Dan Beam <dbeam@chromium.org> Date: Wed Mar 6 20:19:11 2019 +0000 WebUI Dark Mode, Settings: update language page error/explanation colors Screenshot: https://imgur.com/a/Zo7p0MI R=dpapad@chromium.org BUG=926658 Change-Id: I0631c213ad3ef7e5808af1ab9922f00791c60a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505116 Auto-Submit: Dan Beam (slow; perfing) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#638249} .../resources/settings/languages_page/languages_page.html | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 5ada368037e4459a9ce593249464996dcf38eb5f Author: manuk <manukh@chromium.org> Date: Wed Mar 6 20:05:26 2019 +0000 [omnibox chrome:omnibox]: Add a "copy" button to export to clipboard as JSON. This button compliments the previously named 'Import clipboard' button. With this CL, we have 4 buttons to export to or import from the clipboard or a file. Additionally, this CL renames the buttons and modifies accesskeys for clarity: - Copy (alt+c) - Paste (alt+v) - Download (alt+n) - Upload (alt+m) The 'Lock cursor position to end of input' checkbox also has its accesskey changed from alt+c to alt+x. Bug: 937321 Change-Id: Ieada086afd7e2d35e7b164679e1087245050ef91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497117 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#638248} chrome/browser/resources/omnibox/omnibox.html | 57 +++++++++++++--------- chrome/browser/resources/omnibox/omnibox.js | 28 +++++++---- chrome/browser/resources/omnibox/omnibox_input.css | 9 ++++ chrome/browser/resources/omnibox/omnibox_input.js | 48 ++++++++++-------- 4 files changed, 89 insertions(+), 53 deletions(-) commit 50fa499171be569760874098e7f3924b6ec47a10 Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Wed Mar 6 20:04:28 2019 +0000 [LayoutNG] Fix ScrollbarAppearanceTest.NativeScrollbarChangeToMobileByEmulator As above. This iterates over all the scrollable areas, and marks their respective layout objects as requiring layout. This is required as LayoutNG has caches more items than in the existing LayoutNG, and nothing marks the layout_box with the scrollbar as needing layout. This is similar to the kPaintChange, which invalidates paint all of paint when something like high-contrast mode is enabled. Bug: 922456 Change-Id: Ie65b14872a832b73b197247c06ce77727d8e6aec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476811 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#638247} .../blink/renderer/core/frame/settings.json5 | 1 + .../blink/renderer/core/frame/settings_delegate.h | 1 + .../blink/renderer/core/layout/scrollbars_test.cc | 4 ---- third_party/blink/renderer/core/page/page.cc | 25 +++++++++++++++++++++- 4 files changed, 26 insertions(+), 5 deletions(-) commit 463e524275d06be58f63c5c142ac2c34c8437585 Author: Nick Harper <nharper@chromium.org> Date: Wed Mar 6 20:01:48 2019 +0000 Add gov.uk without subdomains to HSTS Preload list Bug: 700280 Change-Id: Icf24e2f8c1b4c96c198039561fbf8c2d97cd2b82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500138 Reviewed-by: Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#638246} net/http/transport_security_state_static.json | 1 + 1 file changed, 1 insertion(+) commit c881b0840d190e0c40e569fe4f3accd66f4d7c37 Author: Piotr Bialecki <bialpio@chromium.org> Date: Wed Mar 6 20:00:10 2019 +0000 Move non-chrome-specific web tests to external/wpt Bug: 935025 Change-Id: Iab1b70463d9d6fe5a5104520160b392f5f17e9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504000 Reviewed-by: Brandon Jones <bajones@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#638245} third_party/blink/web_tests/README | 8 ++++++++ .../wpt/webxr/resources/webxr_test_asserts.js} | 0 .../wpt/webxr/resources/webxr_test_constants.js} | 0 .../wpt/webxr/xrRay_constructor.https.html} | 8 ++++---- .../wpt/webxr/xrRay_matrix.https.html} | 8 ++++---- .../webxr/xrRigidTransform_constructor.https.html} | 19 ++++++++----------- third_party/blink/web_tests/xr/ar_hittest.html | 2 +- .../blink/web_tests/xr/events_session_resetpose.html | 2 +- .../blink/web_tests/xr/events_session_select.html | 2 +- .../web_tests/xr/events_session_select_subframe.html | 2 +- third_party/blink/web_tests/xr/getInputPose_hand.html | 2 +- third_party/blink/web_tests/xr/getInputPose_ray.html | 2 +- third_party/blink/web_tests/xr/xrFrame_getPose.html | 2 +- .../blink/web_tests/xr/xrInputSource_add_remove.html | 2 +- .../web_tests/xr/xrSession_environmentBlendMode.html | 1 - .../xr/xrSession_requestAnimationFrame_timestamp.html | 2 +- ...xrStationaryReferenceSpace_floorlevel_updates.html | 2 +- third_party/blink/web_tests/xr/xrView_match.html | 2 +- .../blink/web_tests/xr/xrView_oneframeupdate.html | 2 +- third_party/blink/web_tests/xr/xrViewport_valid.html | 2 +- .../blink/web_tests/xr/xrWebGLLayer_constructor.html | 1 - .../web_tests/xr/xrWebGLLayer_dirty_framebuffer.html | 1 - .../web_tests/xr/xrWebGLLayer_framebuffer_draw.html | 1 - .../web_tests/xr/xrWebGLLayer_framebuffer_scale.html | 2 +- .../xr/xrWebGLLayer_incompatible_device.html | 1 - .../xr/xrWebGLLayer_non_exclusive_adjust_size.html | 1 - .../web_tests/xr/xrWebGLLayer_opaque_framebuffer.html | 1 - .../web_tests/xr/xrWebGLLayer_viewport_scale.html | 2 +- 28 files changed, 39 insertions(+), 41 deletions(-) commit 90832ad131a5ff72d60fd841030dfc131287fe76 Author: Tommy Steimel <steimel@chromium.org> Date: Wed Mar 6 19:59:37 2019 +0000 [Global Media Controls] Prevent null RemoteCommandCenterDelegate crash This CL adds a check to make sure there is a RemoteCommandCenterDelegate before we attempt to create a RemoteCommandMediaKeysListenerMac. Bug: 938070 Change-Id: Ie216a85e5c579b7d654888d00c24b67ddaa7351d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506108 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#638244} ui/base/accelerators/media_keys_listener_mac.mm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit c92b0f22f6d33955ec9e42acdd7d91d3577883b6 Author: Brandon Jones <bajones@chromium.org> Date: Wed Mar 6 19:58:36 2019 +0000 Changed XRHandedness enum to 'none' from empty string Bug: 933411 Change-Id: I7e698846e7c733c15a82bd9079855df1e2d5abf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504223 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#638243} .../blink/renderer/modules/xr/xr_input_source.cc | 5 +- .../blink/renderer/modules/xr/xr_input_source.h | 9 +- .../blink/renderer/modules/xr/xr_input_source.idl | 1 + .../web_tests/xr/getInputPose_handedness.html | 102 +++++++++++++++++++++ .../web_tests/xr/xrInputSource_add_remove.html | 4 +- 5 files changed, 116 insertions(+), 5 deletions(-) commit 6dc78681b96daf2e750c775095a738d8ccde365f Author: rbpotter <rbpotter@chromium.org> Date: Wed Mar 6 19:58:33 2019 +0000 Print Preview: Fix cut off ripples Bug: 936787 Change-Id: I7eeb1f3f9da68e6a4274afab2804ea3f2df21366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504309 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#638242} chrome/browser/resources/print_preview/new/link_container.html | 3 ++- chrome/browser/resources/print_preview/new/more_settings.html | 10 ++++++---- .../resources/cr_elements/cr_icon_button/cr_icon_button.html | 8 +++++--- 3 files changed, 13 insertions(+), 8 deletions(-) commit f334c44c04c1f6ad7624fc667fa877c06f3a51b5 Author: Mustafa Emre Acer <meacer@chromium.org> Date: Wed Mar 6 19:57:30 2019 +0000 Add an Android test for the lookalike interstitial This test sanity checks that we display a lookalike interstitial for a relevant domain name. The test is adapted from chrome/browser/ssl/CaptivePortalTest.java. Bug: 936565 Change-Id: Ic92be9630c15ec4d88043411a79edf0a07ed78ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497767 Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638241} .../chromium/chrome/browser/ChromeFeatureList.java | 2 + chrome/android/java_sources.gni | 1 + .../interstitials/LookalikeInterstitialTest.java | 69 ++++++++++++++++++++++ 3 files changed, 72 insertions(+) commit f3f987b3f51b80e8efe279ad21233588e476e7d7 Author: Christian Fremerey <chfremer@chromium.org> Date: Wed Mar 6 19:57:27 2019 +0000 [Video Capture] Wire |update_rect| through to AdaptedVideoTrackSource::OnFrame() This CL is in the context of enabling capturers to tell consumers, e.g. video encoders, what part of the video has changed (possibly none) since the last frame. Design Doc: https://docs.google.com/document/d/1YNYaP22fepgP_MXrFXytbo0LOyx29mdCKAsQ2TZAckg/edit?usp=sharing Functional changes in WebRTCVideoTrackSource: * Keep track of CAPTURE_COUNTER and and CAPTURE_UPDATE_RECT to determine when valid |update_rect| information is available. * Accumulate |update_rect| information when dropping frames before delivery to WebRTC * Mark whole frame as changed if cropping or scaling has changed since the last frame delivery. * Translate |update_rect| from being relative to the entire coded frame data (as delivered) to being relative to the visible_rect of the frame (as expected by WebRTC) * When hard-applying cropping and scaling into a new buffer, transform the |update_rect| information accordingly. Bug: 930186 Change-Id: Ic81e9d3bbe4a3f0c403dd709a338f0a699cbfeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464932 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#638240} .../media/webrtc/webrtc_video_track_source.cc | 212 ++++++++--- .../media/webrtc/webrtc_video_track_source.h | 34 ++ .../webrtc/webrtc_video_track_source_unittest.cc | 390 +++++++++++++++++++-- 3 files changed, 556 insertions(+), 80 deletions(-) commit f4805403a6940a049406e0ef5040ff8e4b89f9d0 Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 6 19:56:25 2019 +0000 Remove base::OnceCallback<>::Equals With the current Equals() semantics (BindStateBase pointer comparison), this should always return false as OnceCallback is a move only type. BUG=937566 Change-Id: I5477a51721f9c8bf1fa95636263b2095b9588452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497636 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#638239} base/callback.h | 2 -- 1 file changed, 2 deletions(-) commit a2c68d349adc041b3d9e0f8165ec7d7b2aefa973 Author: Sammie Quon <sammiequon@google.com> Date: Wed Mar 6 19:56:21 2019 +0000 overview: Fix bug which item did not receive events when have backdrop. The backdrop is created after the shield button and it's the same size so it was eating all the events. Set the backdrop to not be able to handle events. Test: ash_unittests OverviewSessionTest.SelectingWindowWithBackdrop Bug: 938645 Change-Id: I18d53cf9ba385ab24a7e3dcce1ceaf16fcde48d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504307 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638238} ash/wm/overview/caption_container_view.cc | 1 + ash/wm/overview/overview_session_unittest.cc | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) commit ca29909dcd3c27567d82261c529b58fbfa3aed9d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 19:55:21 2019 +0000 Roll src/third_party/chromite 6195cd0e66d0..767948b07604 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/6195cd0e66d0..767948b07604 git log 6195cd0e66d0..767948b07604 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 dgarrett@google.com workspace_stages: Only warn on unittest failures. Created with: gclient setdep -r src/third_party/chromite@767948b07604 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib342f2fcb94897acb58d3c276df488ab9e8eb263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506432 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638237} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bffcbc8bb6ae63e45f2242cc306338e5e521d8de Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 19:55:15 2019 +0000 Roll Fuchsia SDK from 8384d21f4cd0 to 30c5e3c76330 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id382889ba134a3fba888d19d4fe4372e6774f8b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506472 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638236} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit d0af18c4a7acde8ac472bd0eb17ecbb528ed983c Author: Karolina Soltys <ksolt@chromium.org> Date: Wed Mar 6 19:35:45 2019 +0000 DownloadDirectoryProvider: getUiThreadHandler -> PostTask Part of an ongoing effort of ThreadUtils --> PostTask migration. Bug: 863341 Change-Id: I2feb4d7dc6280da16d25e91f75f8b10266bb3fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1448219 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638235} .../chrome/browser/download/DownloadDirectoryProvider.java | 10 ++++------ .../chrome/browser/download/TestDownloadDirectoryProvider.java | 6 ++++-- 2 files changed, 8 insertions(+), 8 deletions(-) commit d9377f2a7615c65bb44d5e1a8be978f3a8f9f3f0 Author: Chase Phillips <cmp@chromium.org> Date: Wed Mar 6 19:30:10 2019 +0000 IndexedDB: Make IDBCursor.CursorContinue() use native Mojo callback Similar to the IDBCursor.Advance() commit 9a58b89a, IDBCursor.CursorContinue() previously took a separate IDBCallbacks interface that had its own lifecycle and could have a number of methods called on it. This CL updates CursorContinue() to use Mojo's native callback mechanism. Bug: 717812 Change-Id: Icc7d8b0be70a078f31d658ac9c35d83d8af12b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480810 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#638234} content/browser/indexed_db/cursor_impl.cc | 19 +-- content/browser/indexed_db/cursor_impl.h | 2 +- content/browser/indexed_db/indexed_db_cursor.cc | 134 ++++++++++++--------- content/browser/indexed_db/indexed_db_cursor.h | 19 ++- .../blink/public/mojom/indexeddb/indexeddb.mojom | 14 ++- .../modules/indexeddb/web_idb_cursor_impl.cc | 29 ++++- .../modules/indexeddb/web_idb_cursor_impl.h | 4 + .../indexeddb/web_idb_cursor_impl_unittest.cc | 4 +- 8 files changed, 138 insertions(+), 87 deletions(-) commit 67c41a7bc54c516ffe4ecf97070b5b299eda7315 Author: bsheedy <bsheedy@chromium.org> Date: Wed Mar 6 19:28:45 2019 +0000 Improve Android RenderTest speed Significantly improves the speed at which Android RenderTest comparisons take place if Bitmap.sameAs returns false. This is done by reducing the number of times we call methods that have to hop through JNI and by bulk editing images instead of going through pixel-by-pixel. Rough benchmarking shows this to result in a ~3x speedup. Bug: 904012 Change-Id: I51dc259df9124c6023572a8510fa87dd435bf2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500413 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#638233} .../explore_sites/ExploreSitesPageTest.java | 4 ++ .../chromium/chrome/test/util/RenderTestRule.java | 79 ++++++++++++++++------ 2 files changed, 63 insertions(+), 20 deletions(-) commit 08c128cd49af9bfb4ded6298441e158b41849061 Author: Carlos IL <carlosil@chromium.org> Date: Wed Mar 6 19:27:51 2019 +0000 Refactor SSLCertificateErrorPageController SSLCertificateErrorPageController is no longer only used on SSL errors, renamed it to SecurityInterstitialErrorPageController, and removed the net::Error code passed to EnablePageHelperFunctions since it's no longer used. Bug: 910794 Change-Id: I718e0fcbcb2643cb0c47818dda1f317aef4e75cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503910 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#638232} chrome/renderer/BUILD.gn | 4 +- chrome/renderer/net/net_error_helper.cc | 13 ++-- chrome/renderer/net/net_error_helper.h | 12 ++-- chrome/renderer/net/net_error_helper_core.cc | 3 +- chrome/renderer/net/net_error_helper_core.h | 2 +- .../renderer/net/net_error_helper_core_unittest.cc | 2 +- .../renderer/{ssl => security_interstitials}/DEPS | 0 .../{ssl => security_interstitials}/OWNERS | 0 .../security_interstitial_page_controller.cc} | 76 +++++++++++----------- .../security_interstitial_page_controller.h} | 16 ++--- 10 files changed, 65 insertions(+), 63 deletions(-) commit bbc0fa7607816fa41f97cba6f17fff7cc5acb161 Author: Christian Fremerey <chfremer@chromium.org> Date: Wed Mar 6 19:27:26 2019 +0000 [Video Capture Service] Multi-client: Add support for mixed buffer types Add support for having some clients require buffers of type kSharedMemoryViaRawFileDescriptor while others are using kSharedMemory while sharing the same device. This is done by having class BroadcastingReceiver convert the buffer type as needed when distributing buffer handles to the clients. Design Doc: https://docs.google.com/document/d/1mYnsZfLBRmbsDpUtfb6C7dzhfw2Kcxg_-uiG_6MnWVQ/edit?usp=sharing Test: content_browsertests --gtest_filter=WebRtcVideoCaptureSharedDeviceBrowserTest.* Bug: 783442 Change-Id: Ia636157dfddba3eec09476c4b2be7750ff931fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1413022 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#638231} ...brtc_video_capture_shared_device_browsertest.cc | 102 +++++++++++++-- services/video_capture/broadcasting_receiver.cc | 138 ++++++++++++++++----- services/video_capture/broadcasting_receiver.h | 20 ++- .../push_video_stream_subscription_impl.cc | 3 +- 4 files changed, 220 insertions(+), 43 deletions(-) commit a26ef5c8398d3906c6c9103149bb6fa47865a887 Author: Aga Wronska <agawronska@chromium.org> Date: Wed Mar 6 19:26:43 2019 +0000 a11y: Add accessible names to image buttons on ParentAccessView Bug: 938655 Test: manually Change-Id: I77a713e84a9fbd8b73470234e39f9a416c1cad4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504952 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#638230} ash/ash_strings.grd | 5 ++++- .../IDS_ASH_LOGIN_BACK_BUTTON_ACCESSIBLE_NAME.png.sha1 | 1 + .../IDS_ASH_LOGIN_SUBMIT_BUTTON_ACCESSIBLE_NAME.png.sha1 | 1 + ash/login/ui/login_password_view.cc | 4 ++-- ash/login/ui/parent_access_view.cc | 4 ++++ 5 files changed, 12 insertions(+), 3 deletions(-) commit 2055fe42db66c16b17fb0d44bdde99c5974fd95d Author: David Bertoni <dbertoni@chromium.org> Date: Wed Mar 6 19:26:19 2019 +0000 [Extensions] Remove routing_id member from IOThreadExtensionFunction. This data member is not used. Change-Id: I4542a818349e17863ec30faab2625ee0ab1c8322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504953 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#638229} extensions/browser/extension_function.cc | 4 +--- extensions/browser/extension_function.h | 7 +------ extensions/browser/extension_function_dispatcher.cc | 2 +- 3 files changed, 3 insertions(+), 10 deletions(-) commit 49bda8359001f2c1d2a5a0972ef3a0b9113e446f Author: Edin Kadric <edinkadric@google.com> Date: Wed Mar 6 19:25:15 2019 +0000 Enable EditableCombobox on Linux. This worked seamlessly; I only had to update unit tests: On Linux, Alt+left/right shouldn't do anything to be consistent with the behavior of Textfield. Also, on Mac Alt+left/right really moves between words, not to the beginning/end of the text. On Linux that's achieved with Ctrl+left/right. Bug: 923660 Change-Id: I891e7164e6dd2b88070915715d9e735321fd9b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503617 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Edin Kadric <edinkadric@google.com> Cr-Commit-Position: refs/heads/master@{#638228} ui/views/BUILD.gn | 26 ++++++++--- .../editable_combobox_unittest.cc | 50 +++++++++++++++++++--- 2 files changed, 63 insertions(+), 13 deletions(-) commit bdaf8b7e16163b648a527824dcb363d07d6f39ba Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 6 19:21:04 2019 +0000 Roll src/third_party/pdfium ed5dc24c07a3..9ba187ae4751 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/ed5dc24c07a3..9ba187ae4751 git log ed5dc24c07a3..9ba187ae4751 --date=short --no-merges --format='%ad %ae %s' 2019-03-06 thestig@chromium.org Fix FPDF_FILEACCESS lifetime issue with FPDF_LoadCustomDocument(). Created with: gclient setdep -r src/third_party/pdfium@9ba187ae4751 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I966a47b3dd1fa33080b6baf21c94cc179daf0ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505858 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638227} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1e4fa9e1b28fad22f66cf8dc5786c2ea6c81a65b Author: Owen Min <zmin@chromium.org> Date: Wed Mar 6 19:19:23 2019 +0000 Disable MediaInternalsAudioLogTest.AudioLogCreateStartStopErrorClose Disable the test on Android, Linux and Fuchsia due to flaky. Tbr: petewil@chromium.org Bug: 938812 Change-Id: I96504518c8556d5e8cdfb60a9e74c5dc8e1040ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506380 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638226} content/browser/media/media_internals_unittest.cc | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit 4479c603ce00bd479f7e83e3e3cc21576e669123 Author: Christopher Cameron <ccameron@chromium.org> Date: Wed Mar 6 19:17:42 2019 +0000 MacPWAs: Fix duplicate bundle creation The root cause of this bug is that the call to LSCopyApplicationURLsForBundleIdentifier that is made in WebAppShortcutCreator::GetAppBundlesByIdUnsorted will not necessarily find app shims that were created just moments ago (likely there is an asynchronous indexing that is going on). To fix this, make WebAppShortcutCreator::GetAppBundlesByIdUnsorted read through all of the app shims in the path under ~/Applications where app shims are created, and see if it finds an application that matches the one we are looking for, based on its Info.plist. Rather than add another place where Info.plists are manually parsed, merge all code that reads Info.plists from app bundles, and put all of the accessors for this data in a single BundleInfoPlist class. Note that some of the moved code is not well understood by this author (in particular, IsForCurrentUserDataDir and GetFullProfilePath). This BundleInfoPlist will be used more extensively in the updated code to delete zombie bundles and to provide more robust renaming. Bug: 937703 Change-Id: Ia292840debd9c74024d707f784dceab78443a536 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500851 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#638225} .../components/web_app_shortcut_mac.mm | 241 +++++++++++++-------- 1 file changed, 146 insertions(+), 95 deletions(-) commit b6619d810627e75e9626e2856bbe41e6e78ef64f Author: Owen Min <zmin@chromium.org> Date: Wed Mar 6 19:17:29 2019 +0000 Disable http/tests/devtools/elements/styles-4/stylesheet-source-url-comment.js Disable the test due to Timeout Bug: 938883 Change-Id: Id2b1f3bed6f8044bd8426dc42ac021ac2ec440ab Bug: 938883 Tbr: petewil@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506117 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638224} third_party/blink/web_tests/TestExpectations | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 108dae4745489f60dd711ec9dfb02e8231385268 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 6 19:14:15 2019 +0000 Roll src-internal 0563888d3868..a2179093ac06 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0563888d3868..a2179093ac06 Created with: gclient setdep -r src-internal@a2179093ac06 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I047a9b75faa3ba9f27b2e542ccd59f13f40aecd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505982 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638223} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 79e8352a6b65e5485e914769f5d4f20bfd9727df Author: Austin Eng <enga@chromium.org> Date: Wed Mar 6 19:09:44 2019 +0000 Move WebGPUDecoderImpl to separate files WebGPUDecoderImpl will later need to link against symbols in libdawn_native. This patch directly copies the contents to separate files which later can be conditionally compiled when building with use_dawn. Bug: 877147 Change-Id: Iab7abfa2dd636bb4d5d3f3b0a416f2c1f69de990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504495 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#638222} gpu/command_buffer/service/BUILD.gn | 2 + gpu/command_buffer/service/webgpu_decoder.cc | 329 +------------------- gpu/command_buffer/service/webgpu_decoder_impl.cc | 347 ++++++++++++++++++++++ gpu/command_buffer/service/webgpu_decoder_impl.h | 31 ++ 4 files changed, 382 insertions(+), 327 deletions(-) commit 99296108ec710f2df3111d9b49795e346b629683 Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Mar 6 19:07:49 2019 +0000 Reland: Reset NTP customizations when all settings are reset. This relands crrev.com/c/1472450 which was reverted because of a crash crbug.com/936830. The cause of the crash was fixed separately at crrev.com/c/1501493. Bug: 931806 Change-Id: Id659440b7798fe6f0a3c233c3b29a584565cdba3 TBR=ramyan@chromium.org, engedy@chromium.org Change-Id: Id659440b7798fe6f0a3c233c3b29a584565cdba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506107 Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#638221} chrome/browser/profile_resetter/profile_resetter.cc | 8 ++++++++ chrome/browser/profile_resetter/profile_resetter.h | 14 +++++++++++++- .../profile_resetter/profile_resetter_unittest.cc | 17 +++++++++++++++++ chrome/browser/search/instant_service.cc | 5 +++++ chrome/browser/search/instant_service.h | 11 ++++++++--- chrome/browser/search/instant_service_unittest.cc | 16 ++++++++++++++++ 6 files changed, 67 insertions(+), 4 deletions(-) commit d52a9885bb981d6134445c78367ca705cce5a60f Author: Alex Newcomer <newcomer@chromium.org> Date: Wed Mar 6 18:57:29 2019 +0000 cros: Fix homecher with docked magnifier in tablet mode HomeLauncherGestureHandler used to send the work area's y position as the max y position of the AppListView in an attempt to modify the work area. AppListView already accounts for work area changes. This bug went unnoticed until HomeLauncherGestureHandler had to deal with the workspace being shrunk from the top via the DockedMagnifier. Now, send 0 instead of the work area y position to AppListView and let AppListView handle the work area change. Also translate based on the keyboard being shown/hidden to prevent search results from being pushed off screen with docked magnifier enabled. TEST=manually tested with multiple display configurations Bug: 936381 Change-Id: I4de62a0f239a72ba69256f5561c7bfb10035a870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504434 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#638220} ash/app_list/home_launcher_gesture_handler.cc | 7 +++---- ash/app_list/views/app_list_view.cc | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) commit 6dbb276f30f2ff115318a41511bd2cddb8f40a6e Author: Arthur Hemery <ahemery@chromium.org> Date: Wed Mar 6 18:52:54 2019 +0000 Removing NavigationRequest::TakeNavigationHandle. This function is unused since the NavigationHandle and NavigationRequest are kept together now. Change-Id: I0ca24dc4dd37712c298084f7c2d2088df9a24e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495547 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#638219} content/browser/frame_host/navigation_request.cc | 5 ----- content/browser/frame_host/navigation_request.h | 3 --- 2 files changed, 8 deletions(-) commit b3a077b95fd34057c002e3f65b499afedf8c7273 Author: Jonathan Backer <backer@chromium.org> Date: Wed Mar 6 18:50:25 2019 +0000 Make fuzzers work with DCHECKS Bug: 938076 Change-Id: I39087f0882c9296975c4a02742898e76175e17a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503342 Commit-Queue: Jonathan Backer <backer@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#638218} gpu/command_buffer/tests/fuzzer_main.cc | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) commit 5b87535c02fa0135052bb6ac6f7a1b77d8ca814f Author: Owen Min <zmin@chromium.org> Date: Wed Mar 6 18:48:48 2019 +0000 Disable VolumeManagerTest.OnRenameEvent_Completed Disable the test on ChromeOS due to flaky. Tbr: petewil@chromium.org Bug: 938755 Change-Id: I99eb58c46f53ae6cac8c2925171b7c3e838e15b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506119 Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#638217} chrome/browser/chromeos/file_manager/volume_manager_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 46a73d3bcd4d15f41b5acc29a703ab07665d16bb Author: Peng Huang <penghuang@chromium.org> Date: Wed Mar 6 18:48:05 2019 +0000 Support ALPHA_8 & LUMINANCE_8 with Vulkan Bug: None Change-Id: I9675e5f6515131e24fab8d4e39b9b3420387bf80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506096 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#638216} components/viz/common/resources/resource_format_utils.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Updated tag 'tree_truth' (was bb1454a4cc71)