Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 43774 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919240912563688064 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itiq6QeK/luci_context.058034401 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2228-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 4387da64bf6bbf11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 80159cd63d55357ba19e2022d5a66eed0af28d03 flags: Assign pdf flags to owners whose usernames start with 't'. Lei Zhang, Mon Mar 11 23:12:34 2019 +0000 6bb741c6d69c8fd5778e1fb9214223cb87d5ded5 [Feed Internals] Add 4 new properties to page Natalie Chouinard, Mon Mar 11 23:11:46 2019 +0000 945e5ffd98912333b5a2eb417cd6be53bf8896e2 Fix nits in PrintPreviewDialogController tests. Lei Zhang, Mon Mar 11 23:11:03 2019 +0000 cf921a12eea3ac20c8a561cff63a482f75aa5a47 [Fuchsia] Fix path handling for readelf invocations on a single binary. Kevin Marshall, Mon Mar 11 23:09:56 2019 +0000 853933ebda6ea1fd3e7e4ce5f78f630a77d19674 Make the HTTPS Notification InfoBar more accessible to other code Robert Ogden, Mon Mar 11 23:06:12 2019 +0000 5cee796d74b81130620b5699cf586120919546f1 Remove icon_view in StopCasting functions. Clifford Cheng, Mon Mar 11 23:05:38 2019 +0000 c7b658d1a2e4bcdc4ef343efb3875826fd7a2ea8 Switch the remaining classes in core/css to use downcast helpers (6/n) Antonio Gomes, Mon Mar 11 23:05:06 2019 +0000 2a15ae9df1d9fb5b4edc81fc3476115a172b06ab Revert "[leveldb_proto] Add support for automatic conversion to client type." Giovanni Ortuño Urquidi, Mon Mar 11 22:59:36 2019 +0000 5e292d2ad45c3915bcbef9d0f8e83ed72530a964 Move the platform independent intent picker code out of chromeos folder. Maggie Cai, Mon Mar 11 22:58:24 2019 +0000 8a24bedfa35cd7e47e7cf0ee88f00c95c8c7da11 Gave two GetCreateNetworkFactoryCallback unique names Daniel Bratell, Mon Mar 11 22:53:12 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 80159cd63d55357ba19e2022d5a66eed0af28d03 Author: Lei Zhang <thestig@chromium.org> Date: Mon Mar 11 23:12:34 2019 +0000 flags: Assign pdf flags to owners whose usernames start with 't'. Also increase the expiration milestone for pdf-form-save. Change-Id: I3222d14f7096df1a917902cd8eb4c3a0549eb6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516615 Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#639692} chrome/browser/flag-metadata.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 6bb741c6d69c8fd5778e1fb9214223cb87d5ded5 Author: Natalie Chouinard <chouinard@chromium.org> Date: Mon Mar 11 23:11:46 2019 +0000 [Feed Internals] Add 4 new properties to page This internals page is used to surface debugging information useful to developers of the NTP Interest Feed. Adds 4 additional simple properties to the debugging page: - whether the Feed is visible - whether the Feed is allowed (by policy) - whether prefetching for offline use is enabled - the reason for the last fetch https://screenshot.googleplex.com/efYU09sWvNP Bug: 913126 Change-Id: Ib9cad2a6fca27b292f4cb5198e1298fc72ad13ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512267 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#639691} .../resources/feed_internals/feed_internals.html | 16 ++++++ .../resources/feed_internals/feed_internals.js | 4 ++ .../ui/webui/feed_internals/feed_internals.mojom | 14 ++++- .../feed_internals/feed_internals_page_handler.cc | 20 +++++++ components/feed/core/feed_scheduler_host.cc | 6 ++ components/feed/core/feed_scheduler_host.h | 12 +++- .../feed/core/feed_scheduler_host_unittest.cc | 67 +++++++++++++++++++++- 7 files changed, 134 insertions(+), 5 deletions(-) commit 945e5ffd98912333b5a2eb417cd6be53bf8896e2 Author: Lei Zhang <thestig@chromium.org> Date: Mon Mar 11 23:11:03 2019 +0000 Fix nits in PrintPreviewDialogController tests. Change-Id: I29fed149d32cdedead18820a60aee6f695f31820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504457 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#639690} .../print_preview_dialog_controller_browsertest.cc | 34 ++++++++++------------ .../print_preview_dialog_controller_unittest.cc | 9 +++--- 2 files changed, 19 insertions(+), 24 deletions(-) commit cf921a12eea3ac20c8a561cff63a482f75aa5a47 Author: Kevin Marshall <kmarshall@chromium.org> Date: Mon Mar 11 23:09:56 2019 +0000 [Fuchsia] Fix path handling for readelf invocations on a single binary. Fixes an issue with prepare_package_inputs.py where the value of "binary_shortname" was assigned to full binary path, instead of a path basename, on packages with only single binaries. The issue manifested in a different build tree which imported Chromium's //build . Bug: 772252 Change-Id: I171ac2027fac8f7be2650c0e35f3694b9d70c525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516053 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#639689} build/config/fuchsia/prepare_package_inputs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 853933ebda6ea1fd3e7e4ce5f78f630a77d19674 Author: Robert Ogden <robertogden@chromium.org> Date: Mon Mar 11 23:06:12 2019 +0000 Make the HTTPS Notification InfoBar more accessible to other code This will be reused by Opt Hints. Decided not to rename the InfoBar itself since the post-URLLoader cleanup will take the opportunity to address crbug.com/904552 Bug: 939422 Change-Id: I9896323e1d0fc30303994905442ac1e3b5d7f94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516289 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#639688} chrome/browser/BUILD.gn | 1 + chrome/browser/previews/previews_content_util.cc | 12 ++-- .../previews_https_notification_infobar_decider.h | 31 ++++++++++ .../browser/previews/previews_lite_page_decider.h | 11 ++-- .../previews_lite_page_decider_unittest.cc | 70 ++++++++++------------ ...reviews_lite_page_navigation_throttle_manager.h | 14 ----- .../previews_lite_page_serving_url_loader.cc | 21 +++---- chrome/browser/previews/previews_service.h | 9 ++- 8 files changed, 90 insertions(+), 79 deletions(-) commit 5cee796d74b81130620b5699cf586120919546f1 Author: Clifford Cheng <cliffordcheng@chromium.org> Date: Mon Mar 11 23:05:38 2019 +0000 Remove icon_view in StopCasting functions. The dialog now supports to click on the sink name to stop casting. The icon_view is also breaking some of the manual dialog tests. Change-Id: I56bc6672428300e5f08dc811fbaf58b588df69e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516038 Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org> Auto-Submit: Clifford Cheng <cliffordcheng@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#639687} chrome/test/media_router/media_router_ui_for_test.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit c7b658d1a2e4bcdc4ef343efb3875826fd7a2ea8 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Mon Mar 11 23:05:06 2019 +0000 Switch the remaining classes in core/css to use downcast helpers (6/n) The following class is migrated: CSSIdentifierValue. This is the second out of 2 CLs that migrate specifically CSSIdentifierValue. Its precursor CL (crrev.com/c/1514312) migrated more callsites. R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: Ic3e6cbf25a41f370632940fc16dc207ab7cbcffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515073 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#639686} ...s_border_image_length_box_interpolation_type.cc | 30 +++--- .../core/animation/css_clip_interpolation_type.cc | 4 +- .../core/animation/css_color_interpolation_type.cc | 20 ++-- .../css_filter_list_interpolation_type.cc | 4 +- .../animation/css_font_size_interpolation_type.cc | 5 +- .../css_font_weight_interpolation_type.cc | 3 +- .../animation/css_image_list_interpolation_type.cc | 4 +- .../animation/css_length_interpolation_type.cc | 4 +- .../css_position_axis_list_interpolation_type.cc | 8 +- .../css_shadow_list_interpolation_type.cc | 4 +- .../css_text_indent_interpolation_type.cc | 8 +- .../animation/css_visibility_interpolation_type.cc | 8 +- .../core/animation/size_interpolation_functions.cc | 12 ++- .../renderer/core/css/basic_shape_functions.cc | 11 ++- .../core/css/css_computed_style_declaration.cc | 4 +- .../blink/renderer/core/css/css_identifier_value.h | 2 - .../renderer/core/css/cssom/style_property_map.cc | 12 ++- .../core/css/parser/css_parser_fast_paths_test.cc | 3 +- .../core/css/parser/css_property_parser_helpers.cc | 29 +++--- .../core/css/parser/css_property_parser_test.cc | 8 +- .../core/css/properties/computed_style_utils.cc | 29 +++--- .../properties/longhands/baseline_shift_custom.cc | 5 +- .../core/css/properties/longhands/color_custom.cc | 5 +- .../core/css/properties/longhands/cursor_custom.cc | 5 +- .../css/properties/longhands/direction_custom.cc | 2 +- .../css/properties/longhands/display_custom.cc | 5 +- .../longhands/grid_template_areas_custom.cc | 4 +- .../properties/longhands/outline_style_custom.cc | 2 +- .../core/css/properties/longhands/resize_custom.cc | 2 +- .../core/css/properties/longhands/size_custom.cc | 10 +- .../css/properties/longhands/text_align_custom.cc | 9 +- .../css/properties/longhands/text_indent_custom.cc | 4 +- .../longhands/text_orientation_custom.cc | 2 +- .../longhands/webkit_app_region_custom.cc | 2 +- .../properties/longhands/webkit_locale_custom.cc | 4 +- .../longhands/webkit_text_emphasis_style_custom.cc | 5 +- .../longhands/webkit_text_orientation_custom.cc | 2 +- .../longhands/webkit_writing_mode_custom.cc | 2 +- .../css/properties/longhands/will_change_custom.cc | 8 +- .../properties/longhands/writing_mode_custom.cc | 2 +- .../core/css/properties/longhands/zoom_custom.cc | 5 +- .../renderer/core/css/resolver/css_to_style_map.cc | 102 ++++++++++----------- .../renderer/core/css/resolver/style_resolver.cc | 5 +- .../core/css/resolver/viewport_style_resolver.cc | 15 +-- .../core/editing/commands/style_commands.cc | 17 ++-- .../renderer/core/geometry/dom_matrix_read_only.cc | 4 +- .../svg/graphics/filters/svg_filter_builder.cc | 4 +- 47 files changed, 234 insertions(+), 210 deletions(-) commit 2a15ae9df1d9fb5b4edc81fc3476115a172b06ab Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Mon Mar 11 22:59:36 2019 +0000 Revert "[leveldb_proto] Add support for automatic conversion to client type." This reverts commit fe51f52034fb1d57844759a258eca133a9f69ff8. Reason for revert: Breaks ios-simulator-xcode-clang https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/89533 In file included from ../../components/feature_engagement/internal/tracker_impl.cc:36: In file included from ../../components/leveldb_proto/public/proto_database_provider.h:13: ../../components/leveldb_proto/internal/proto_database_impl.h:204:5: error: no matching function for call to 'MakeCheckOpValueString' DCHECK_EQ(std::make_unique<P>(), proto); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:978:31: note: expanded from macro 'DCHECK_EQ' #define DCHECK_EQ(val1, val2) DCHECK_OP(EQ, ==, val1, val2) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../base/logging.h:950:29: note: expanded from macro 'DCHECK_OP' EAT_STREAM_PARAMETERS << (::logging::MakeCheckOpValueString( \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../components/leveldb_proto/internal/proto_database_impl.h:214:10: note: in instantiation of function template specialization 'leveldb_proto::(anonymous namespace)::ParseToProto<feature_engagement::Event>' requested here return ParseToProto<T>(serialized_entry); ^ ../../components/leveldb_proto/internal/proto_database_impl.h:288:20: note: in instantiation of function template specialization 'leveldb_proto::(anonymous namespace)::ParseToClientType<feature_engagement::Event, feature_engagement::Event, nullptr>' requested here auto entry = ParseToClientType<P, T>(serialized_entry); ^ ../../components/leveldb_proto/internal/proto_database_impl.h:480:38: note: in instantiation of function template specialization 'leveldb_proto::(anonymous namespace)::ParseLoadedEntries<feature_engagement::Event, feature_engagement::Event>' requested here base::BindOnce(&ParseLoadedEntries<P, T>, ^ ../../components/leveldb_proto/internal/proto_database_impl.h:77:3: note: in instantiation of member function 'leveldb_proto::ProtoDatabaseImpl<feature_engagement::Event, feature_engagement::Event>::LoadEntriesWithFilter' requested here ProtoDatabaseImpl(ProtoDbType db_type, ^ ... Original change's description: > [leveldb_proto] Add support for automatic conversion to client type. > > The leveldb_proto::ProtoDatabase is a widely used storage backend in > Chrome, but it only supports storing protocol buffers when using the > external API. > > This CL makes it possible for clients to use ProtoDatabase<P, T>, > where P is their proto type, and T is their own type. Previously it was > only possible to pass in a proto type as the template argument. If no > client type is specified, it defaults to providing the proto type as > the API for all calls like before, so no changes are required to > current clients. > > For clients to be able to use this, they must implement conversion > methods to and from their proto type and their client type. This must > be within the leveldb_proto namespace and for T=ClientStruct and > P=ClientProto it would have the form: > namespace leveldb_proto { > void DataToProto(const ClientStruct& data, ClientProto* proto); > void ProtoToData(const ClientProto& proto, ClientStruct* data); > } // namespace leveldb_proto > > For retrieving a database of proto type ClientProto, use: > auto db = ProtoDatabaseProviderFactory::GetForBrowserContext(...) > -> GetDB<ClientProto>(...); > For automatically converting to a different data type, use: > auto db = ProtoDatabaseProviderFactory::GetForBrowserContext(...) > -> GetDB<ClientProto, ClientStruct>(...); > > Bug: 939986 > Change-Id: I3587d9e9fb72d30a39276a66df4eafa5b9e7fdcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513279 > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639674} TBR=nyquist@chromium.org,fgorski@chromium.org,oysteine@chromium.org Change-Id: I3d0ee06b31227a17fd75a1c72fc79e54c8204154 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516115 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#639685} components/gcm_driver/crypto/gcm_key_store.h | 6 +- .../leveldb_proto/internal/proto_database_impl.h | 223 ++++----- .../internal/proto_database_impl_unittest.cc | 529 +++++++++------------ .../internal/proto_database_selector.h | 1 - .../leveldb_proto/internal/shared_proto_database.h | 2 +- components/leveldb_proto/public/proto_database.h | 20 +- .../leveldb_proto/public/proto_database_provider.h | 19 +- components/leveldb_proto/testing/fake_db.h | 127 +++-- 8 files changed, 398 insertions(+), 529 deletions(-) commit 5e292d2ad45c3915bcbef9d0f8e83ed72530a964 Author: Maggie Cai <mxcai@chromium.org> Date: Mon Mar 11 22:58:24 2019 +0000 Move the platform independent intent picker code out of chromeos folder. This CL moves the platform independent intent picker code to chrome/browser/apps folder. So that we can implement the intent picker for all desktop platforms. BUG=939205 Change-Id: Ifec3a4ebca6817c764ca3a303ee7b01f810af23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507293 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#639684} chrome/browser/BUILD.gn | 14 ++++++++++++++ chrome/browser/DEPS | 1 + chrome/browser/{chromeos => }/apps/intent_helper/OWNERS | 0 .../apps/intent_helper/apps_navigation_throttle.cc | 8 ++++---- .../apps/intent_helper/apps_navigation_throttle.h | 6 +++--- .../intent_helper/apps_navigation_throttle_unittest.cc | 4 ++-- .../apps/intent_helper/apps_navigation_types.cc | 2 +- .../apps/intent_helper/apps_navigation_types.h | 6 +++--- .../intent_helper/intent_picker_auto_display_pref.cc | 2 +- .../apps/intent_helper/intent_picker_auto_display_pref.h | 6 +++--- .../intent_helper/intent_picker_auto_display_service.cc | 6 +++--- .../intent_helper/intent_picker_auto_display_service.h | 6 +++--- .../intent_picker_auto_display_service_factory.cc | 4 ++-- .../intent_picker_auto_display_service_factory.h | 6 +++--- .../intent_helper/intent_picker_controller.cc | 2 +- .../intent_helper/intent_picker_controller.h | 6 +++--- .../apps/intent_helper/page_transition_util.cc | 2 +- .../apps/intent_helper/page_transition_util.h | 6 +++--- .../apps/intent_helper/page_transition_util_unittest.cc | 2 +- chrome/browser/chrome_content_browser_client.cc | 2 +- chrome/browser/chromeos/BUILD.gn | 16 ---------------- .../arc/intent_helper/arc_external_protocol_dialog.cc | 6 +++--- .../arc/intent_helper/arc_intent_picker_app_fetcher.cc | 2 +- .../arc/intent_helper/arc_intent_picker_app_fetcher.h | 2 +- chrome/browser/ui/browser_window.h | 2 +- chrome/browser/ui/views/intent_picker_bubble_view.cc | 2 +- chrome/browser/ui/views/intent_picker_bubble_view.h | 2 +- .../ui/views/intent_picker_bubble_view_unittest.cc | 2 +- .../browser/ui/views/location_bar/intent_picker_view.cc | 4 ++-- chrome/test/BUILD.gn | 2 ++ chrome/test/base/test_browser_window.h | 2 +- 31 files changed, 67 insertions(+), 66 deletions(-) commit 8a24bedfa35cd7e47e7cf0ee88f00c95c8c7da11 Author: Daniel Bratell <bratell@opera.com> Date: Mon Mar 11 22:53:12 2019 +0000 Gave two GetCreateNetworkFactoryCallback unique names Both content/browser/frame_host and content/browser/worker_host needed a GetCreateNetworkFactoryCallback and in jumbo builds where those compiled in the same translation unit, those (identical) functions clashed. I see no obvious place to share them and I'm not sure if their static state should even be merged so this patch just gives the functions more distinct names. (Improved name suggestions welcome). Bug: 927849 Change-Id: Ib6556c42e7bdbba9702fb24a12b7b9c0a1fb93cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1472672 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#639683} .../browser/frame_host/render_frame_host_impl.cc | 23 +++++++++++----------- content/browser/worker_host/shared_worker_host.cc | 13 ++++++------ 2 files changed, 19 insertions(+), 17 deletions(-) commit a7463e241d477281069c8c2ffb8108a9d1304abb Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 11 22:46:16 2019 +0000 flags: assign ash-shelf-color-scheme Bug: None Change-Id: I8e8f2f76266973c6767b523316884f5f2aea1faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516613 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#639682} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b917a68e18af8752365bccc73747705dbf8636fb Author: Ben Smith <binji@chromium.org> Date: Mon Mar 11 22:41:19 2019 +0000 Mark Atomics.wake as deprecated It has been replaced by Atomics.notify. See the intent to deprecate and remove here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/_zPuM7ETNSE Bug: v8:7883 Change-Id: Iedbfab57a05301da262835191563303631ce26bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1410268 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#639681} third_party/blink/renderer/bindings/core/v8/use_counter_callback.cc | 1 + third_party/blink/renderer/core/frame/deprecation.cc | 5 +++++ 2 files changed, 6 insertions(+) commit 0dc6a003b15d294e1719e3862524738935be155d Author: Peter Boström <pbos@chromium.org> Date: Mon Mar 11 22:40:40 2019 +0000 Add Profile::IsIncognito Should be a significantly more convenient function for Chrome code to call. There's already confusion in code with whether IsOffTheRecord maps 1:1 to Incognito or not. Bug: chromium:3333, chromium:939610 Change-Id: I1653f4eb037263f216d9fbed20da8248b4fcaa23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509909 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#639680} chrome/browser/profiles/profile.cc | 4 ++++ chrome/browser/profiles/profile.h | 4 ++++ chrome/browser/ui/views/profiles/avatar_toolbar_button.cc | 4 ++-- content/public/browser/browser_context.h | 4 +++- 4 files changed, 13 insertions(+), 3 deletions(-) commit ca3825c08c9c6000cd7fa19bf0136d879761657e Author: Etienne Bergeron <etienneb@chromium.org> Date: Mon Mar 11 22:38:17 2019 +0000 Add trace events for fonts on linux. This CL is adding trace events for the fonts related calls on linux. The goal is to make them visible in chrome tracing and slow-reports to ease fonts debugging and to focus on fonts performance. R=oysteine@chromium.org, gab@chromium.org, drott@chromium.org Bug: 938971 Change-Id: Iecafe486a4bb6ff62f5cb76d564eea53494d69b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506493 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Dominik Röttsches <drott@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#639679} base/trace_event/builtin_categories.h | 1 + components/services/font/font_service_app.cc | 15 +++++++++++++++ components/services/font/public/cpp/font_loader.cc | 5 +++++ components/services/font/public/cpp/font_loader.h | 1 + .../child/child_process_sandbox_support_impl_linux.cc | 10 ++++++++++ ui/gfx/font_fallback_linux.cc | 7 +++++++ ui/gfx/font_render_params_linux.cc | 6 ++++++ ui/gfx/platform_font_skia.cc | 18 ++++++++++++++++-- 8 files changed, 61 insertions(+), 2 deletions(-) commit f748879c4c859ce2443b977c842804f8b3c05ac3 Author: Alex Moshchuk <alexmos@chromium.org> Date: Mon Mar 11 22:37:57 2019 +0000 Some cleanup to not pass both BrowserContext and IsolationContext. This CL removes BrowserContext from BrowsingInstance, since it is already stored in the BrowsingInstance's IsolationContext. It also removes BrowserContext from GetSiteForURL functions. Future CLs will clean up other process model functions that take both a BrowserContext and IsolationContext (such as DoesSiteRequireDedicatedProcess) to only take IsolationContext. Bug: 905513 Change-Id: Ibea91690930445a5c2d192476ad7180642dd2168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516098 Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#639678} content/browser/browsing_instance.cc | 26 ++++---- content/browser/browsing_instance.h | 15 ++--- .../browser/child_process_security_policy_impl.cc | 10 +-- content/browser/frame_host/navigation_request.cc | 2 - .../browser/frame_host/render_frame_host_impl.cc | 1 - .../frame_host/render_frame_host_manager.cc | 1 - content/browser/isolated_origin_browsertest.cc | 4 +- .../renderer_host/render_process_host_impl.cc | 9 ++- content/browser/site_instance_impl.cc | 44 +++++-------- content/browser/site_instance_impl.h | 18 +---- content/browser/site_instance_impl_unittest.cc | 77 ++++++++++------------ 11 files changed, 80 insertions(+), 127 deletions(-) commit 35d83281343da301a0f3515ff585cd4890f14ce6 Author: Harley Li <hhli@chromium.org> Date: Mon Mar 11 22:36:09 2019 +0000 [DevTools] Add notification of storage being limited in Incognito mode Add a message telling users that storage quota is limited in Incognito mode (why: crbug 800329 comment \#1). In non-Incognito mode, the quota is in gigabytes. But in Incognito, the quota cap is no more than 120MB. Bug: 794269, 800329 Change-Id: Ic0d9e9d40119424c0b44bdd314d1f836af4ed357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506462 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#639677} .../renderer/devtools/front_end/resources/ClearStorageView.js | 7 ++++++- .../application-panel/storage-view-reports-quota-expected.txt | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) commit 1b524d48b132c4fa6b1d858c886010c8182d0e6b Author: Robert Sesek <rsesek@chromium.org> Date: Mon Mar 11 22:31:07 2019 +0000 Refactor mojo::Channel to support record-oriented implementations. mojo::Channel is geared towards implementations that use stream-based communication, so it provides an underlying buffer into which bytes can be read, and then a way to notify it that a read is complete. With an upcoming ChannelMac implementation, the underlying communication primitive is record-oriented instead of stream-oriented, which makes using Channel's buffer implementation difficult. This change makes the buffer management optional, and it provides a new method to parse and dispatch messages with an un-owned span of a buffer. Bug: 932175 Change-Id: Ie02412d3cd5c2a2cf21151ac8e0fc5dd4b6d32c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512393 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#639676} mojo/core/channel.cc | 186 ++++++++++++++++++++++++++++----------------------- mojo/core/channel.h | 44 +++++++++++- 2 files changed, 146 insertions(+), 84 deletions(-) commit f2096d77f9b0762eae369337479af5831ad3fc73 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 11 22:28:35 2019 +0000 Roll src/third_party/depot_tools 53aa75c9ce55..973788f88dab (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/53aa75c9ce55..973788f88dab git log 53aa75c9ce55..973788f88dab --date=short --no-merges --format='%ad %ae %s' 2019-03-11 miladfar@ca.ibm.com Fixing getting machine arch on AIX running in an LPAR environment Created with: gclient setdep -r src/third_party/depot_tools@973788f88dab The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I291cc8e502e97769fbb582fe338cdd80a09b429b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516343 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639675} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fe51f52034fb1d57844759a258eca133a9f69ff8 Author: Tommy Nyquist <nyquist@chromium.org> Date: Mon Mar 11 22:28:26 2019 +0000 [leveldb_proto] Add support for automatic conversion to client type. The leveldb_proto::ProtoDatabase is a widely used storage backend in Chrome, but it only supports storing protocol buffers when using the external API. This CL makes it possible for clients to use ProtoDatabase<P, T>, where P is their proto type, and T is their own type. Previously it was only possible to pass in a proto type as the template argument. If no client type is specified, it defaults to providing the proto type as the API for all calls like before, so no changes are required to current clients. For clients to be able to use this, they must implement conversion methods to and from their proto type and their client type. This must be within the leveldb_proto namespace and for T=ClientStruct and P=ClientProto it would have the form: namespace leveldb_proto { void DataToProto(const ClientStruct& data, ClientProto* proto); void ProtoToData(const ClientProto& proto, ClientStruct* data); } // namespace leveldb_proto For retrieving a database of proto type ClientProto, use: auto db = ProtoDatabaseProviderFactory::GetForBrowserContext(...) -> GetDB<ClientProto>(...); For automatically converting to a different data type, use: auto db = ProtoDatabaseProviderFactory::GetForBrowserContext(...) -> GetDB<ClientProto, ClientStruct>(...); Bug: 939986 Change-Id: I3587d9e9fb72d30a39276a66df4eafa5b9e7fdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513279 Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#639674} components/gcm_driver/crypto/gcm_key_store.h | 6 +- .../leveldb_proto/internal/proto_database_impl.h | 223 +++++---- .../internal/proto_database_impl_unittest.cc | 529 ++++++++++++--------- .../internal/proto_database_selector.h | 1 + .../leveldb_proto/internal/shared_proto_database.h | 2 +- components/leveldb_proto/public/proto_database.h | 20 +- .../leveldb_proto/public/proto_database_provider.h | 19 +- components/leveldb_proto/testing/fake_db.h | 127 ++--- 8 files changed, 529 insertions(+), 398 deletions(-) Updated tag 'tree_truth' (was e70f06c73fef)