Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 37779 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919179317089812384 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ityFqlZs/luci_context.943711786 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2227-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 438b5ab5ac032a11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 3dd3dc30437a3fac7dd5c417ecc2ead6a89d660c Make it possible to remove the root layer in the android CompositorImpl Erik Elwing, Tue Mar 12 15:31:54 2019 +0000 0dd9caffd4631f5a34c5f34061232f2080901150 Blacklist zuk devices for bitmaps as notification icons Pavel Shmakov, Tue Mar 12 15:30:52 2019 +0000 3ece66a0224f21e1aa2a7c38dbbe11dcbbef1c73 Roll src/third_party/chromite d5417c72fe1a..2d6126cf865a (2 commits) chromium-autoroll, Tue Mar 12 15:30:48 2019 +0000 092e321172d6f12a7bc79c86d9d00598b3960924 Add C++ code to support security keys Settings UI Adam Langley, Tue Mar 12 15:29:44 2019 +0000 49d6d600e6e73a57575647df118d1c77ba9ea3c8 Convert some NavigationController unit tests to use NavigationSimulator Camille Lamy, Tue Mar 12 15:24:17 2019 +0000 a03681911775122dbb69690bcb025f0c3401ce04 Deprecate custom cursors intersecting the visible viewport Charlie Harrison, Tue Mar 12 15:23:45 2019 +0000 bdc0be28b9416be79001ac0fc9353bf22de9fe43 [iOS][web] Disable failing test Gauthier Ambard, Tue Mar 12 15:14:13 2019 +0000 7c80388ed0cb98d0b1624d53a1526d646ad6cca1 Get rid of MoveableAutoLock in preparation for using SchedulerLock Alex Clarke, Tue Mar 12 15:08:46 2019 +0000 47a8b8c1429bda3fdf5f6cf7eba2cc47bf6c43f9 Roll src/third_party/webrtc a5c0ba186149..6330818ec815 (9 commits) chromium-autoroll, Tue Mar 12 15:05:08 2019 +0000 5b84fd8011eb76152499427d4edad09954a53ef2 [iOS] Remove commented-out property from app_startup_parameters.h Mark Cogan, Tue Mar 12 15:02:24 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 3dd3dc30437a3fac7dd5c417ecc2ead6a89d660c Author: Erik Elwing <erikj@opera.com> Date: Tue Mar 12 15:31:54 2019 +0000 Make it possible to remove the root layer in the android CompositorImpl It was only possible to reassign the root layer not remove it. Change-Id: I6a2eb1cd7040ac6a3c50fba846a19fbb8e2db3a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503319 Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#639932} content/browser/renderer_host/compositor_impl_android.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0dd9caffd4631f5a34c5f34061232f2080901150 Author: Pavel Shmakov <pshmakov@google.com> Date: Tue Mar 12 15:30:52 2019 +0000 Blacklist zuk devices for bitmaps as notification icons Apparently Lenovo Zuk devices have Build.MANUFACTURER="ZUK" and not "LENOVO": https://forum.xda-developers.com/showpost.php?p=71768681&postcount=6 Bug: 927271 Change-Id: I3aff92a799255ac2c956e0a427ec7cab820f30ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517696 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#639931} .../chrome/browser/notifications/NotificationBuilderBase.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 3ece66a0224f21e1aa2a7c38dbbe11dcbbef1c73 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 15:30:48 2019 +0000 Roll src/third_party/chromite d5417c72fe1a..2d6126cf865a (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/d5417c72fe1a..2d6126cf865a git log d5417c72fe1a..2d6126cf865a --date=short --no-merges --format='%ad %ae %s' 2019-03-12 dhanyaganesh@chromium.org BuildStore: Delete ExtendDeadline occurence 2019-03-12 haddowk@chromium.org generic_stages: Filter out postsubmit artifacts from moblab. Created with: gclient setdep -r src/third_party/chromite@2d6126cf865a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6e9e2486b8af27b0168f89f984721751b318b84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518276 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639930} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 092e321172d6f12a7bc79c86d9d00598b3960924 Author: Adam Langley <agl@chromium.org> Date: Tue Mar 12 15:29:44 2019 +0000 Add C++ code to support security keys Settings UI This change adds the C++ code that future Javascript code will call in order to drive PIN operations on security keys. (Specifically setting PINs, changing PINs, and resettting devices.) BUG=870892 Change-Id: I7bf0e6efab5a529aa4f1394697b6d263da9e26af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493392 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#639929} chrome/browser/ui/BUILD.gn | 3 + chrome/browser/ui/webui/settings/md_settings_ui.cc | 2 + .../settings/settings_security_key_handler.cc | 251 +++++++++++++++++++++ .../webui/settings/settings_security_key_handler.h | 78 +++++++ device/fido/pin.h | 3 +- 5 files changed, 336 insertions(+), 1 deletion(-) commit 49d6d600e6e73a57575647df118d1c77ba9ea3c8 Author: Camille Lamy <clamy@chromium.org> Date: Tue Mar 12 15:24:17 2019 +0000 Convert some NavigationController unit tests to use NavigationSimulator This CL converts several NavigationController unit tests to use NavigationSimulator instead of methods on TestRenderFrameHost. This is needed to start enforcing having a NavigationRequest at commit time. Bug: 728571 Change-Id: I06d2f0700e2be2bcd79730dca41d1cefb6e897e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511365 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#639928} .../navigation_controller_impl_unittest.cc | 220 +++++++-------------- 1 file changed, 71 insertions(+), 149 deletions(-) commit a03681911775122dbb69690bcb025f0c3401ce04 Author: Charlie Harrison <csharrison@chromium.org> Date: Tue Mar 12 15:23:45 2019 +0000 Deprecate custom cursors intersecting the visible viewport This aligns our behavior with FF nightly. See i2d: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/e0bzxOfL-2I Bug: 880863 Change-Id: I82b7a7fe3c0aad84f3e4f26bb39a6df3156031e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512593 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#639927} .../blink/renderer/core/input/event_handler.cc | 1 + .../renderer/core/input/event_handler_test.cc | 116 +++++++++++++++++++++ 2 files changed, 117 insertions(+) commit bdc0be28b9416be79001ac0fc9353bf22de9fe43 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 12 15:14:13 2019 +0000 [iOS][web] Disable failing test Disable the two other failing tests. TBR=eugenebut@chromium.org Bug: 940880 Change-Id: Ib6a9de4ecd10379f6e6d14c013618c89024371eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517903 Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#639926} ios/web/browsing_data/browsing_data_remover_unittest.mm | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) commit 7c80388ed0cb98d0b1624d53a1526d646ad6cca1 Author: Alex Clarke <alexclarke@chromium.org> Date: Tue Mar 12 15:08:46 2019 +0000 Get rid of MoveableAutoLock in preparation for using SchedulerLock We don't need MoveableAutoLock anymore. Change-Id: I2a40c44166ab7a668c9e9542c2de3b6ade8f05fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505494 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#639925} base/task/sequence_manager/moveable_auto_lock.h | 41 ---------------------- base/task/sequence_manager/sequence_manager_impl.h | 1 - base/task/sequence_manager/task_queue.cc | 19 ++++------ base/task/sequence_manager/task_queue.h | 4 +-- 4 files changed, 8 insertions(+), 57 deletions(-) commit 47a8b8c1429bda3fdf5f6cf7eba2cc47bf6c43f9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 15:05:08 2019 +0000 Roll src/third_party/webrtc a5c0ba186149..6330818ec815 (9 commits) https://webrtc.googlesource.com/src.git/+log/a5c0ba186149..6330818ec815 git log a5c0ba186149..6330818ec815 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 alessiob@webrtc.org NetEQ RTP Play: Optionally write output audio file 2019-03-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 02df973441..ad6c7f0653 (639636:639761) 2019-03-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20749e92ed..02df973441 (639533:639636) 2019-03-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision f2f5c1896e..20749e92ed (639430:639533) 2019-03-11 danilchap@webrtc.org Remove rtc::QueuedTask alias, use webrtc::QueuedTask directly 2019-03-11 nisse@webrtc.org Refactor RtpVideoStreamReceiver::OnReceivedPayloadData without WebRtcRTPHeader 2019-03-11 srte@webrtc.org Removes rtp level keep alive support. 2019-03-11 srte@webrtc.org Removes unused mock_bitrate_controller. 2019-03-11 saza@webrtc.org Add an input size limit to APM fuzzer Created with: gclient setdep -r src/third_party/webrtc@6330818ec815 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None,chromium:940209 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie771a4bb01ae76fbb9e8dd28f8fb12236fd738d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516834 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639924} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5b84fd8011eb76152499427d4edad09954a53ef2 Author: Mark Cogan <marq@google.com> Date: Tue Mar 12 15:02:24 2019 +0000 [iOS] Remove commented-out property from app_startup_parameters.h https://chromium-review.googlesource.com/c/chromium/src/+/586593 left several lines commented out in this header. This CL removes the remaining one, and fills in a missing comment. Change-Id: I8931a030e188c9482728380a99ec086b77cb4ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1424840 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#639923} ios/chrome/browser/app_startup_parameters.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 8c2249374dbe0d985eb0cfd6c5f1aa6d7361ff39 Author: Jared Saul <jsaul@google.com> Date: Tue Mar 12 15:01:18 2019 +0000 Fix iOS flag ordering from CL 1506449 Change-Id: I7830d47560ed0017961125a64a722db8a51817c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516785 Auto-Submit: Jared Saul <jsaul@google.com> Commit-Queue: Eric Noyau <noyau@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#639922} ios/chrome/browser/about_flags.mm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 315eaf83fce271e287ef4908bb901db236ea7c20 Author: behdad <behdadb@chromium.org> Date: Tue Mar 12 14:59:53 2019 +0000 Added pinch zoom tests to rendering.mobile Bug: chromium:852373 Change-Id: Ic653899bf35b4da2b571d2e3e9b0586fc0de492f Currently, zoom pinch test_cases are only tested on mac, and we don't run them on any other desktop nor mobile platform. The mobile tests_cases are still running on smoothness benchmark, which was suppose to be moved to rendering benchmark. In this CL a new class for mobile test_cases of zoom pinch (rendering) is created. Also "DesktopToughPinchZoomCasesPageSet" is removed as it has not been used anywhere. Change-Id: Ic653899bf35b4da2b571d2e3e9b0586fc0de492f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506537 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#639921} tools/perf/benchmark.csv | 2 +- tools/perf/page_sets/data/rendering_desktop.json | 36 ++++---- .../data/rendering_desktop_79afb10dc5.wprgo.sha1 | 1 + .../data/rendering_desktop_f083c0f144.wprgo.sha1 | 1 + tools/perf/page_sets/data/rendering_mobile.json | 21 +++++ .../data/rendering_mobile_64b26a7503.wprgo.sha1 | 1 + .../data/rendering_mobile_8d57721c03.wprgo.sha1 | 1 + .../data/rendering_mobile_c47e7f29dd.wprgo.sha1 | 1 + .../data/rendering_mobile_d00c7313f6.wprgo.sha1 | 1 + .../page_sets/rendering/rendering_shared_state.py | 6 -- tools/perf/page_sets/rendering/story_tags.py | 2 + .../page_sets/rendering/tough_pinch_zoom_cases.py | 52 +++--------- .../rendering/tough_pinch_zoom_mobile_cases.py | 97 ++++++++++++++++++++++ 13 files changed, 156 insertions(+), 66 deletions(-) commit 0a26c374be322700e467c9d36d81229cc784f17e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 14:58:56 2019 +0000 Roll src/third_party/swiftshader abb57857c536..6193cb187e4a (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/abb57857c536..6193cb187e4a git log abb57857c536..6193cb187e4a --date=short --no-merges --format='%ad %ae %s' 2019-03-12 bclayton@google.com tests/regres/export_to_sheets: Fix off-by-one in loop Created with: gclient setdep -r src/third_party/swiftshader@6193cb187e4a The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I422ca0a530448dce2fc415237a495ccd12e63462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518272 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639920} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e0f6f249e6dcadf294b60c6680b0144d3756338f Author: Marc Treib <treib@chromium.org> Date: Tue Mar 12 14:53:39 2019 +0000 sync_ui_util: Don't check for NOT_MY_BIRTHDAY error Before this CL, sync_ui_util checked for a NOT_MY_BIRTHDAY protocol error (in addition to !IsSyncRequested()) to determine whether we're in the "Sync was reset from the dashboard" state. However, that's a) unnecessary; !IsSyncRequested() is a sufficient condition (since resetting Sync from the dashboard is the only way to get into a primary-account-but-sync-not-requested state), and b) incorrect, since the protocol error gets reset when Sync-the-transport starts up. So this CL removes the NOT_MY_BIRTHDAY check. This is also consistent with the check in GetSyncedStateStatusLabel (which provides the corresponding message). As a related cleanup, this CL introduces a GetClientAction() function which extracts the action from QueryDetailedSyncStatus(). That makes it clear that this is the only part of the detailed status that's relevant here. Bug: 940437, 911153 Change-Id: I00e925073bcfa7b1e13bb6df0b3017a0073fca7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517652 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#639919} chrome/browser/sync/sync_ui_util.cc | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) commit 878de358fcca41a5628af8f6551bca8c0d385b32 Author: James Cook <jamescook@chromium.org> Date: Tue Mar 12 14:51:15 2019 +0000 Fix transient window tracking in MultiUserWindowManager Transient window ownership is tracked through the owning parent window. SetWindowOwner() should be a no-op for transients. This fixes DCHECK failures due to MultiUserWindowManager trying to add duplicate aura::Window observers. Bug: 937333 Test: added to unit_tests Change-Id: I807bf0c808f463a3c2569d83fd9e66d56cfb2afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516774 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#639918} ash/multi_user/multi_user_window_manager.cc | 8 +++++++- ...ulti_user_window_manager_client_impl_unittest.cc | 21 +++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) commit 57c7b0c1f9433e6cbda9ea9bde1c0c4810a4760c Author: sebsg <sebsg@chromium.org> Date: Tue Mar 12 14:45:49 2019 +0000 [SelfShare] Extend GCMMessage object to access original_priority value. Adds a method to get the original_priority of the message. Also adds the code needed to (de)serialize as well as some unit tests. Bug: 939840 Change-Id: I9dfd3d7b203857205f774eabfa9b084ad932bf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511695 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#639917} .../chromium/components/gcm_driver/GCMMessage.java | 41 ++++++++++++++++++++-- .../components/gcm_driver/GCMMessageTest.java | 7 +++- 2 files changed, 45 insertions(+), 3 deletions(-) commit 1c4e88890ff21ae52db823e4dfba259cf4b7fbdf Author: Alex Ilin <alexilin@chromium.org> Date: Tue Mar 12 14:45:46 2019 +0000 Fix FieldTrialListTest.SerializeSharedMemoryRegionMetadata The test was failing on Windows when run without admin rights. The problem was that a shared memory handle wasn't shared with a child process correctly. This CL fixes the problem by registering a handle in the LaunchOptions::handles_to_inherit struct. Bug: 937936 Test: worked locally when run without admin rights Change-Id: I1d81fc661c19cf97f2c44d0e8c6b655430828421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517592 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#639916} base/metrics/field_trial_unittest.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit bf5f2e524f8882c61dc14290c0437db6f166109f Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Mar 12 14:43:11 2019 +0000 Remove restriction on handling only non-raw resource requests in SWR. Stale While Revalidate can handle all resource requests. BUG=348877 Change-Id: I0e3c8c6aa5e5dfc9bf3b1eb5d2635076cb562a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506595 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#639915} .../blink/renderer/platform/loader/fetch/resource_fetcher.cc | 7 ++----- third_party/blink/web_tests/TestExpectations | 6 ------ 2 files changed, 2 insertions(+), 11 deletions(-) commit b972cc26611ac3f2c9e18a16fd14652fba3f5a8e Author: Aditya Keerthi <adityakeerthi@google.com> Date: Tue Mar 12 14:37:19 2019 +0000 Enable memory purge prevention on foregrounded renderers when freezing Previously, freezing a tab triggered a memory purge on all renderers that host content within the tab. An experiment was introduced to only purge memory if the renderer was backgrounded. The experiment is being removed and enabled, as it has been agreed that this is the approach we want to take to handle memory purges when freezing. Note that the experiment showed no regression on memory/performance metrics. Bug: 926186 Change-Id: I960c437f5b3250851dd4693356286a09acda3b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514996 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Takashi Sakamoto <tasak@google.com> Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Cr-Commit-Position: refs/heads/master@{#639914} third_party/blink/common/features.cc | 4 -- third_party/blink/public/common/features.h | 2 - .../scheduler/main_thread/memory_purge_manager.cc | 4 +- .../scheduler/main_thread/memory_purge_manager.h | 5 +- .../main_thread/memory_purge_manager_unittest.cc | 60 +++------------------- 5 files changed, 11 insertions(+), 64 deletions(-) commit b64482d46a8f0781143dae90fd88837f6f9203ab Author: Mathias Carlen <mcarlen@chromium.org> Date: Tue Mar 12 14:35:09 2019 +0000 [Autofill Assistant] Add a DONE chip type. This chip looks like a highlighted blue chip. The chip is shown without an additional cancel button and behaves like a normal chip, meaning it continues the script flow when clicked. Further, in the mocks all highlighted chips are aligned right, cancel-ish chips are centered. To obtain that logic we adjust the alignment when there is a single highlight chip. R=szermatt@chromium.org Bug: b/125291252 Change-Id: I426d52989394198fdcde04af6da4bebb88ec1905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517693 Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#639913} .../browser/autofill_assistant/AutofillAssistantUiController.java | 5 +++-- chrome/browser/android/autofill_assistant/ui_controller_android.cc | 6 ++++++ components/autofill_assistant/browser/service.proto | 7 +++++++ 3 files changed, 16 insertions(+), 2 deletions(-) commit 2838e2936b918ed99fab4406f0dd713362251324 Author: Camille Lamy <clamy@chromium.org> Date: Tue Mar 12 14:31:07 2019 +0000 Refactor NavigationRequest selection in RenderFrameHost This is a preparatory CL for enforcing having a valid NavigationRequest at commit time. It makes clearer when NavigationRequests are deemed non-valid, and when a new NavigationRequest must be created at commit time. Change-Id: I02bcc43fb46378d4507ba90beaf0b007b909b048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493693 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#639912} .../navigation_controller_impl_unittest.cc | 41 ++- .../browser/frame_host/render_frame_host_impl.cc | 277 ++++++++++----------- .../browser/frame_host/render_frame_host_impl.h | 34 ++- content/browser/navigation_browsertest.cc | 91 ------- content/test/navigation_simulator_impl.cc | 4 +- content/test/navigation_simulator_impl.h | 1 + 6 files changed, 169 insertions(+), 279 deletions(-) commit 88f3f6a5d7fef38eb51713f8cee2712a9395bedc Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Mar 12 14:23:41 2019 +0000 OOR-CORS: Fix CORS preflight ResourceTimingInfo handling In blink::ResourceLoader::DidFinishLoading, when we have |response_body_loader_|, timing information for preflights are stored in |deferred_finish_loading_info_|, and reused in DidFinishLoadingBody to call DidFinishLoading again. But in didFinishLoading, we nullify the |deferred_finish_loading_info_| before using the passed cors_preflight_timing_info. Since the argument was a reference to the nullified instance, the timing information is lost, and results in missing ResourceTimingInfo for CORS preflights. This patch changes DidFinishLoadingBody to make a copy before calling DidFinishLoading and pass the copy's reference. Also, this patch enables http/tests/misc on virtual/outofblink-cors to avoid this kind of regressions. Bug: 940892 Change-Id: Ifccf1cb8d7c47bd3f1bf337f5c7a6c7aa359dc13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517486 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#639911} .../blink/renderer/platform/loader/fetch/resource_loader.cc | 6 +++++- .../web_tests/virtual/outofblink-cors/http/tests/misc/README.txt | 7 +++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit 532e430957e651c90d9494ac103a28bedf1d4b04 Author: Robert Sesek <rsesek@chromium.org> Date: Tue Mar 12 14:19:06 2019 +0000 Fix some book-keeping bugs in MessagePumpKqueue. Some logic bugs could result in the events_ buffer growing exceptionally large: 1. In StopWatchingFileDescriptor() and StopWatchingMachPort(), if removing the kevents from the kqueue fails, the event_count_ should still be decreased because the events are invalid. 2. In ProcessEvents() for EV_ONESHOT FDs, the event_count_ should be decremented after it is activated, since the event is removed. 3. If a controller is re-used with WatchFileDescriptor(), event_count_ is unconditionally incremented, even if it meant no truly new events were added to the kqueue. Bug: 940540, 932175 Change-Id: Ia2e547ea81b93332edbe20b85b1e80939a0104a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516718 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#639910} base/message_loop/message_pump_kqueue.cc | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) commit b614616e8b720ee0e5fe49aa6236f6279d03d64c Author: Christian Dullweber <dullweber@chromium.org> Date: Tue Mar 12 14:18:36 2019 +0000 Fix DCHECK in RewriteDB leveldb_env::RewriteDB hits a DCHECK when rewriting SessionStorage because SyncPrimitives are not allowed but required to delete a database. This is fixed by adding ScopedAllowBaseSyncPrimitives to the destructor of the database. Bug: 919069 Change-Id: Id23e751706f8dd7a20cbb4114033b54610f4124a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396123 Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#639909} base/threading/thread_restrictions.h | 4 ++++ content/browser/dom_storage/session_storage_area_impl_unittest.cc | 3 ++- third_party/leveldatabase/env_chromium.cc | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) commit 05b393603de98ba6eb3f9b6491496ca85735161a Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 12 14:17:34 2019 +0000 Speculatively remove the libsqlite3.so ASan suppression. The minimum supported Linux distribution has been bumped since this was added, so we may be able to rely on the fix now. Bug: 178677 Change-Id: I2d3c3316579739c25b0f3099bb9c0442147e059c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511937 Commit-Queue: Alexander Potapenko <glider@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#639908} build/sanitizers/asan_suppressions.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit 6caffe935c84c03ce703f80f2119c5a34fbd3b01 Author: Jonah Ryan-Davis <jonahr@google.com> Date: Tue Mar 12 14:16:44 2019 +0000 Fix conformance/renderbuffers/framebuffer-test in passthrough cmd decoder This test was failing because OES_fbo_render_mipmap was always requested when it should be disabled by default for webGL 1 Bug: 929882 Change-Id: I1c6b3a8ec408454b5855a64e2981b72efbecf1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516055 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Cr-Commit-Position: refs/heads/master@{#639907} content/test/gpu/gpu_tests/webgl_conformance_expectations.py | 2 -- gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc | 1 - 2 files changed, 3 deletions(-) commit c53d776278a84c5c76638899bf39f7eb29d5cacc Author: David 'Digit' Turner <digit@google.com> Date: Tue Mar 12 14:16:29 2019 +0000 android: Do not compress PNGs and other files in app bundles. The bundle config JSON file has an entry named compression.uncompressedGlob that can be used to list a number of glob expressions related to the files that should not be compressed in the APK. This allows more efficient access. An undocumented feature is that using '*' will only matches single file path components (directories or files), while '**' will work through directories. This distinction is important for file extensions like .png or .jpg which we don't want to compress further in the split APKs. This CL fixes a bug in the code generating this key's content, which only kept the top-level .png/.jpg files uncompressed, instead of those inside of sub-directories. NOTE: This adds about 12 kiB to Monochrome.minimal.apks, due to uncompressed PNGs. However, Monochrome.apks from the real bundles, which use webp instead, does not seem affected at all. BUG=940895 R=agrieve@chromium.org, estevenson@chromium.org, benmason@chromium.org Change-Id: I803f6a98419288c8ac05a491f4fa7429633ecb41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517695 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#639906} build/android/gyp/create_app_bundle.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit efc87731e19596d8ac5781f1ccf9d4e087701524 Author: Mike Wittman <wittman@chromium.org> Date: Tue Mar 12 14:11:44 2019 +0000 [Sampling profiler] Reland "Look up the libsystem_kernel module in the ModuleCache" Reimplements the check for the libsystem_kernel module in terms of the ModuleCache public interface. With this change the NativeStackSampler subclasses now consistently manipulate modules via the ModuleCache. The reland uses 'ptrace' rather than '_exit' as the function to expect in libsystem_kernel.dylib, as _exit is also defined by libclang_rt.asan_osx_dynamic.dylib. Bug: 931418 Change-Id: I73f9c3e25ae5cf851e1e1442046131a2f3e68ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515901 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#639905} base/profiler/native_stack_sampler_mac.cc | 34 ++++++++++++------------------- 1 file changed, 13 insertions(+), 21 deletions(-) commit b4093bc197a6355e198a188928f2651a5d0ca94e Author: David Jean <djean@chromium.org> Date: Tue Mar 12 14:10:13 2019 +0000 [ios] first step into adding app level url loading service Will allow factoring some url loading code out of main controller. App level service will take care of ‘global’ action, like incognito swap, modals closing, etc. The (singleton) app level loading service is piped down to the browser state level url loading services. Bug: 907527 Change-Id: Icc7c93204a67aa6d958be7f3d352e37766e8909c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496876 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#639904} ios/chrome/app/BUILD.gn | 1 + ios/chrome/app/main_controller.mm | 32 +++++++++++++++---- ios/chrome/browser/ui/main/BUILD.gn | 1 + ios/chrome/browser/ui/main/browser_coordinator.h | 6 ++++ ios/chrome/browser/ui/main/browser_coordinator.mm | 6 ++-- ios/chrome/browser/ui/main/browser_view_wrangler.h | 3 ++ .../browser/ui/main/browser_view_wrangler.mm | 5 +++ .../ui/main/browser_view_wrangler_unittest.mm | 1 + ios/chrome/browser/url_loading/BUILD.gn | 20 ++++++++++++ .../browser/url_loading/app_url_loading_service.h | 37 ++++++++++++++++++++++ .../browser/url_loading/app_url_loading_service.mm | 24 ++++++++++++++ .../url_loading/test_app_url_loading_service.h | 25 +++++++++++++++ .../url_loading/test_app_url_loading_service.mm | 18 +++++++++++ .../browser/url_loading/url_loading_service.h | 6 ++-- .../browser/url_loading/url_loading_service.mm | 15 +++++---- .../url_loading/url_loading_service_unittest.mm | 8 +++++ 16 files changed, 188 insertions(+), 20 deletions(-) commit 2c2627a1ef3d8859b45e832ea6156454ea0f803c Author: Hans Wennborg <hans@chromium.org> Date: Tue Mar 12 14:09:41 2019 +0000 Add ToTMacOfficial Milo, tests, and mb configs Bug: 937297 Change-Id: Id2c9c8ccccd629f3138b2ae1b737a347a80e8cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496883 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#639903} infra/config/luci-milo.cfg | 10 + testing/buildbot/chromium.clang.json | 616 +++++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 7 + tools/mb/mb_config.pyl | 5 +- 4 files changed, 636 insertions(+), 2 deletions(-) commit 1151818e164908bec62942380ea0d3251f6a321a Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Mar 12 14:07:30 2019 +0000 [chrome_cleaner] remove deps from proto_library I will deprecate deps in proto_library for improved build throughput. And we can use link_deps here instead. Also I moved "//third_party/protobuf:py_proto" to deps in appropriate target "ensure_py_protos". Bug: 938011 Change-Id: Ie55d157b5e643dea5bd89025fe565b5024d360ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514000 Reviewed-by: Joe Mason <joenotcharles@google.com> Commit-Queue: Joe Mason <joenotcharles@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#639902} chrome/chrome_cleaner/logging/proto/BUILD.gn | 22 ++++++---------------- chrome/chrome_cleaner/proto/BUILD.gn | 17 ++--------------- 2 files changed, 8 insertions(+), 31 deletions(-) commit 703698bcf6aea1a6864140966969aad808a2f2e2 Author: Jonathan Backer <backer@chromium.org> Date: Tue Mar 12 14:05:54 2019 +0000 Require OOPD for SkiaRenderer It does work without it. Some SitePerProcess content_browsertests turn off test with and without OOP-D. This changes makes those tests not fail when you run content_browsertests with --enable-features=UseSkiaRenderer. Bug: 911643 Change-Id: If0aa2e213174d627172d3b468c827d82a9c9a572 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515687 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#639901} components/viz/common/features.cc | 14 ++++++++++++++ .../display_embedder/skia_output_surface_impl_unittest.cc | 2 +- 2 files changed, 15 insertions(+), 1 deletion(-) commit 36d1b80812256f0055a2a765e49ed3eb7cb6a4e8 Author: Polina Bondarenko <pbond@google.com> Date: Tue Mar 12 13:59:29 2019 +0000 Add DeviceWilcoDtcConfiguration policy Create new external policy to fetch a wilco DTC configuration in JSON format to be passed to wilco DTC. BUG=b:123933434 TEST=unit_tests Change-Id: I63c48b162ed89e34455e36b9045eb88b8b2577ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511465 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#639900} chrome/browser/chromeos/BUILD.gn | 2 + .../policy/browser_policy_connector_chromeos.cc | 7 ++++ .../policy/browser_policy_connector_chromeos.h | 3 ++ .../policy/device_policy_decoder_chromeos.cc | 10 +++++ .../device_wilco_dtc_configuration_handler.cc | 37 ++++++++++++++++++ .../device_wilco_dtc_configuration_handler.h | 44 ++++++++++++++++++++++ .../configuration_policy_handler_list_factory.cc | 2 + chrome/test/data/policy/policy_test_cases.json | 10 +++++ components/policy/proto/chrome_device_policy.proto | 7 ++++ components/policy/resources/policy_templates.json | 36 +++++++++++++++++- tools/metrics/histograms/enums.xml | 1 + 11 files changed, 158 insertions(+), 1 deletion(-) commit b7b4699d224d6b74e2c405bc255cf18d7277066c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 13:56:07 2019 +0000 Roll src/third_party/perfetto 28f71e89e3ee..ffd908d91238 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/28f71e89e3ee..ffd908d91238 git log 28f71e89e3ee..ffd908d91238 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 rsavitski@google.com Merge "heapprofd unwinding fuzzer: update fuzzer to post-shmem-refactor interface" Created with: gclient setdep -r src/third_party/perfetto@ffd908d91238 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id4ebd7cf681cbf9c7160125e63806a80a3ac30e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516827 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639899} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d9cd943485a26c62fbba10e396fc716aa4e44b37 Author: Per Åhgren <peah@chromium.org> Date: Tue Mar 12 13:55:24 2019 +0000 Remove remaining code of the AEC2 activation code This CL removes the remaining code for the activation of AEC2. Bug: chromium:696930 Change-Id: Ied5491ffb76a76bf035f9599a291f19d79a96681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508280 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Henrik Grunell <grunell@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#639898} media/base/audio_processing.cc | 2 -- media/base/audio_processing.h | 5 ++--- media/webrtc/audio_processor.cc | 12 +++--------- media/webrtc/audio_processor_unittest.cc | 2 +- services/audio/input_controller.cc | 1 - services/audio/public/cpp/audio_processing_mojom_traits.h | 5 ----- services/audio/public/mojom/audio_processing.mojom | 1 - 7 files changed, 6 insertions(+), 22 deletions(-) commit 52439c07024966168b0e67eb01f355aebf8f7579 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Tue Mar 12 13:39:01 2019 +0000 Make probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl case style consistent The primary motivation is that the function names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL generate functions to follow proper case style. Bug: 936684 Change-Id: I0b4aa95941ce6c863f6393b40f3786f9ab914495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516112 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#639897} .../renderer/build/scripts/templates/instrumenting_probes_impl.cc.tmpl | 2 +- third_party/blink/renderer/build/scripts/templates/probe_sink.h.tmpl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit ed75c9569a4c94ce8648ef12ba0cc60e2a4f3207 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 12 13:36:42 2019 +0000 Update V8 to version 7.5.18. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dbc4bb4a..a79c24d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I566c15c8e3823631026f7736097ecb9c5994f279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517376 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639896} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d5b7481c73c598ca3e66d7a48abb445e380ed379 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Mar 12 13:35:11 2019 +0000 [libprotobuf-mutator] do not use deps in proto_library I will deprecate deps in proto_library for improved build throughput. https://chromium.googlesource.com/chromium/src/+/HEAD/third_party/protobuf/proto_library.gni For this, I changed deps in fuzzable_proto_library to proto_deps. (But no user of deps currently) And specify protobuf_config in extra_configs to have GOOGLE_PROTOBUF_NO_RTTI macro when compiling generated code. Bug: 938011 Change-Id: I51930a80036335b249da04596d35b8892ce66953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517478 Reviewed-by: Jonathan Metzman <metzman@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#639895} third_party/libprotobuf-mutator/fuzzable_proto_library.gni | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 6007029d12d639dda98bed9fcd022e26ea06fbb8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 13:30:43 2019 +0000 Roll src/third_party/spirv-headers/src f25b91a61ea8..3beb2a037310 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/f25b91a61ea8..3beb2a037310 git log f25b91a61ea8..3beb2a037310 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 cepheus@frii.com Add ability to skip ranges of instructions; no impact to public headers 2019-03-12 cepheus@frii.com Sync to rev. 7 of headers from Khronos. Created with: gclient setdep -r src/third_party/spirv-headers/src@3beb2a037310 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I6c64a47a040c73e71c93fec709f06515869949d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518132 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639894} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 564c95016450f2b4f9a0ac2c0e50624e6af86da4 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 12 13:30:16 2019 +0000 Import wpt@06b7597d484665af424d8c282643aafb2d49d97a Using wpt-import in Chromium 9499addc19a0ad37979f885d1fe3c0eeb7765af0. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mlamouri@chromium.org: external/wpt/screen-orientation NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I5ce88d246b50d5a89fb426386b31acd8594a67fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517375 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639893} .../blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 14 +++++++------- .../wpt/screen-orientation/event-before-promise.html | 1 + .../wpt/screen-orientation/orientation-reading.html | 4 ++++ 3 files changed, 12 insertions(+), 7 deletions(-) commit a94cd4a803bbdf21130698034273a6170c9f853c Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 12 13:17:08 2019 +0000 [iOS] Disable failing test This CL disables a test failing on iOS 11 device. The feature is not launched yet. TBR=eugenebut@chromium.com Bug: 940880 Change-Id: Iaf775d4888f55860ecd262635f2f5b8446688765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517698 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#639892} ios/web/browsing_data/browsing_data_remover_unittest.mm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit a68b77b3e7e03ba919ef032f58d514a4e5e702e3 Author: dstockwell <dstockwell@google.com> Date: Tue Mar 12 13:03:20 2019 +0000 pdf: Transform pointer coordinates to match Ink canvas When Ink is running with low-latency canvas enabled the rendering canvas is rotated. We must likewise rotate the coordinates of pointer events before dispatching to the Ink engine. In the future we'll add an API to ink to pass events directly, rather than dispatch synthetic pointer events and this transformation can be removed. Bug: 940804 Change-Id: Idae95cf12a19713de818c091eb1255b1aecf0cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517474 Auto-Submit: dstockwell <dstockwell@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#639891} chrome/browser/resources/pdf/ink/ink_api.js | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) commit bc69a62cefd15dd51c0f99ae1f4c6223dbe334d1 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Mar 12 13:02:40 2019 +0000 [AF Wallet Metadata] Test uploading local-only data in initial sync This CL covers one further part of behavior of the new USS sync bridge. Bug: 936013 Change-Id: Id9b5e632e3c0290073147e4aac2bf0fccc4c02b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517632 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#639890} ...utofill_wallet_metadata_sync_bridge_unittest.cc | 92 +++++++++++++++++++++- 1 file changed, 89 insertions(+), 3 deletions(-) commit 106f8eedbbd296f9bc1f221ec973eb1c6f483879 Author: Marc Treib <treib@chromium.org> Date: Tue Mar 12 12:49:21 2019 +0000 Remove unused ClientAction enum entries After https://crrev.com/c/1514755, many of this enum's entries are not used anymore. While we're here, also remove an unused entry of SyncProtocolErrorType. Bug: 940502 Change-Id: I173a19f5e4e38aa23f466f77191de468fb296453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514685 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#639889} chrome/app/generated_resources.grd | 3 --- chrome/browser/sync/sync_ui_util.cc | 6 ------ chrome/browser/sync/sync_ui_util_unittest.cc | 21 +++------------------ components/browser_sync/profile_sync_service.cc | 3 --- .../js_sync_manager_observer_unittest.cc | 2 +- components/sync/engine_impl/sync_scheduler_impl.cc | 4 ---- components/sync/protocol/sync_protocol_error.cc | 4 ---- components/sync/protocol/sync_protocol_error.h | 12 ------------ 8 files changed, 4 insertions(+), 51 deletions(-) commit 0193585e14d2baf5c9ae96a767c532a13973b011 Author: iOS Autoroller <ios-autoroller@chromium.org> Date: Tue Mar 12 12:33:45 2019 +0000 [MDC roll] Roll Material Motion Animator to 0581bc3dfacd34e40381e9cf45a15070b3868ba7 TBR=smut Change-Id: Ide68be711a9e15789819aaaad3fed5b391da1ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517852 Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#639888} DEPS | 2 +- ios/third_party/motion_animator_objc/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 1faee4813e3b412f00dc2639a07167158bccd26d Author: Vadym Doroshenko <dvadym@chromium.org> Date: Tue Mar 12 12:03:52 2019 +0000 Extend FormParsing fuzzing with server predictions testing. Bug: 845426 Change-Id: I679736b73bc22144de567a4bc994fbe7c7828a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514676 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#639887} .../core/browser/form_parsing/fuzzer/BUILD.gn | 1 + .../form_parsing/fuzzer/form_data_producer.cc | 54 +++++++++++++++++++++- .../form_parsing/fuzzer/form_data_producer.h | 8 ++-- .../form_parsing/fuzzer/form_parser_fuzzer.cc | 2 +- .../fuzzer/form_parser_generic_fuzzer.cc | 9 +++- 5 files changed, 68 insertions(+), 6 deletions(-) commit 12590179b627865b1db1188b990a214cca7c5caa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 12:01:12 2019 +0000 Roll src/third_party/catapult eb73833a2935..a7314e4d2310 (1 commits) https://chromium.googlesource.com/catapult.git/+log/eb73833a2935..a7314e4d2310 git log eb73833a2935..a7314e4d2310 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 crouleau@chromium.org [Telemetry] Use inspect to check for invalid Disabled decorator input Created with: gclient setdep -r src/third_party/catapult@a7314e4d2310 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:939639 TBR=sullivan@chromium.org Change-Id: I6c428f82d0309d31ca79ad8df6509e2862d76b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517792 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639886} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5cb6233cc8e90faf1e47b6fd1201a04c80206430 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Tue Mar 12 11:52:18 2019 +0000 [iOS][MF] Disconnect the mediator on |stop|. Now the mediator stops observing objects when the incognito BVC is destroyed. Waiting for dealloc was causing a race condition with the autorelease pool, and some times a DCHECK will be hit. A minor strong block reference is also fixed in this CL. Bug: 934628, 939727 Change-Id: Ic65a7297eabf7ffad19119832a11125698215ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515572 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#639885} .../autofill/form_input_accessory_coordinator.mm | 1 + .../ui/autofill/form_input_accessory_mediator.h | 3 + .../ui/autofill/form_input_accessory_mediator.mm | 15 +++-- .../manual_fill/fallback_coordinator_egtest.mm | 67 ++++++++++++++++++++++ 4 files changed, 81 insertions(+), 5 deletions(-) commit a404e77269eb018a43e2baeb0da2620c0a40370c Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Tue Mar 12 11:44:02 2019 +0000 [Sync] Clean up favicon_sync feature and Experiments struct This would unblock getting rid of EXPERIMENTS sync data type. TBR=sebsg Bug: 939821 Change-Id: Ie749fcef4fee03d6b03c5f9d36e5f86abbfed437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511469 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#639884} .../autofill_profile_data_type_controller.cc | 1 - components/browser_sync/profile_sync_service.cc | 9 ------- components/browser_sync/profile_sync_service.h | 5 ---- components/sync/BUILD.gn | 1 - components/sync/base/experiments.h | 30 ---------------------- components/sync/driver/glue/sync_engine_impl.cc | 13 ---------- components/sync/driver/glue/sync_engine_impl.h | 5 ---- .../sync/driver/glue/sync_engine_impl_unittest.cc | 1 - components/sync/engine/fake_sync_manager.cc | 4 --- components/sync/engine/fake_sync_manager.h | 1 - components/sync/engine/sync_engine_host.h | 3 --- components/sync/engine/sync_engine_host_stub.cc | 2 -- components/sync/engine/sync_engine_host_stub.h | 1 - components/sync/engine/sync_manager.h | 6 ----- .../engine_impl/sync_encryption_handler_impl.cc | 1 - components/sync/engine_impl/sync_manager_impl.cc | 22 ---------------- components/sync/engine_impl/sync_manager_impl.h | 1 - 17 files changed, 106 deletions(-) commit 51787dccabbe1f90486bd647b5dd7e34342ca230 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 11:41:01 2019 +0000 Roll src/third_party/chromite 96053d06c97b..d5417c72fe1a (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/96053d06c97b..d5417c72fe1a git log 96053d06c97b..d5417c72fe1a --date=short --no-merges --format='%ad %ae %s' 2019-03-12 saklein@chromium.org Reland "Upload Goma Logs: Include all files in folder instead." 2019-03-12 dhanyaganesh@chromium.org scheduler_stages: Send master-buildbucket-id to child builds 2019-03-12 vapier@chromium.org image_test: allow multiple targets for symlinks 2019-03-12 vapier@chromium.org git: reverse submit & notify arguments 2019-03-12 dhanyaganesh@chromium.org BuildStore: Redirect BoardPerBuild data through BuildStore Created with: gclient setdep -r src/third_party/chromite@d5417c72fe1a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iefc6aabfd16efd981f770993e9c0fe2002f56962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517613 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639883} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ac75314473806c776a641ac39b8a56d4eb3965e7 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 12 11:39:34 2019 +0000 Update V8 to version 7.5.17. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e74864a..dbc4bb4a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3d3c936c23ed053636d6c73b5924831f2c71eb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517210 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639882} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5a95abd54365828857c46043a3bca400faf93bcc Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 12 11:38:22 2019 +0000 Change long long to int64_t in third_party/blink/renderer/modules/webgl - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: Ib95503950e7215c827f43d33379e06a6353ee7d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517414 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#639881} .../modules/webgl/angle_instanced_arrays.cc | 2 +- .../modules/webgl/angle_instanced_arrays.h | 2 +- .../modules/webgl/webgl2_rendering_context_base.cc | 74 +++++++++++----------- .../modules/webgl/webgl2_rendering_context_base.h | 46 +++++++------- .../blink/renderer/modules/webgl/webgl_buffer.h | 6 +- .../modules/webgl/webgl_rendering_context_base.cc | 36 +++++------ .../modules/webgl/webgl_rendering_context_base.h | 26 ++++---- 7 files changed, 96 insertions(+), 96 deletions(-) commit 3af8f597aef47c95615a4e868e6d89d1b3a2a770 Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 12 11:38:03 2019 +0000 Change to template functions in third_party/blink/renderer/platform/wtf/text - int/unsigned/long/unsigned long/long long/unsigned long long -> template <typename T> & float Change those types together caused by the build error. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: I0e70b970f86d5d755924e5da680828a21c38b697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504600 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#639880} .../blink/renderer/core/css/css_color_value.cc | 6 ++--- .../editing/markers/document_marker_controller.cc | 2 +- .../core/html/forms/internal_popup_menu.cc | 2 +- .../core/inspector/inspector_emulation_agent.cc | 6 ++--- .../core/paint/text_paint_timing_detector_test.cc | 2 +- .../blink/renderer/modules/webmidi/midi_output.cc | 2 +- .../platform/fonts/shaping/shape_result.cc | 2 +- .../renderer/platform/wtf/text/atomic_string.cc | 31 ---------------------- .../renderer/platform/wtf/text/atomic_string.h | 12 ++++----- .../platform/wtf/text/atomic_string_test.cc | 12 ++++----- .../renderer/platform/wtf/text/string_builder.cc | 30 +++------------------ .../renderer/platform/wtf/text/string_builder.h | 17 +++++++----- .../renderer/platform/wtf/text/text_stream.cc | 12 ++++----- .../blink/renderer/platform/wtf/text/text_stream.h | 12 ++++----- .../blink/renderer/platform/wtf/text/wtf_string.cc | 31 ++-------------------- .../blink/renderer/platform/wtf/text/wtf_string.h | 14 +++++----- 16 files changed, 60 insertions(+), 133 deletions(-) commit d8124316b7be6a6c3aed753ae4e687f2f1a6ceb9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 11:27:48 2019 +0000 Roll src/third_party/swiftshader 3e2a4780e607..abb57857c536 (3 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3e2a4780e607..abb57857c536 git log 3e2a4780e607..abb57857c536 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 bclayton@google.com tests: Add a unit test for a simple memcpy compute shader 2019-03-12 bclayton@google.com Vulkan: Very rough first implementation of compute shaders 2019-03-12 bclayton@google.com Add vulkan unit tests to Kokoro Created with: gclient setdep -r src/third_party/swiftshader@abb57857c536 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126871859,chromium:b/126871859 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ied5d64cd5d6563f0cce0ce74e6bacf0e23843fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517533 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639879} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b6dfebfcd597a20620eb5a5de9ff5fa266836fde Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Mar 12 11:20:42 2019 +0000 Revert "Update PWA frame color to match HTML theme-color meta tag" This reverts commit ea67b57d05efdf10e6aadae6776cc0f428d0991a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 639842 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZWE2N2I1N2QwNWVmZGYxMGU2YWFkYWU2Nzc2Y2MwZjQyOGQwOTkxYQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/9916 Sample Failed Step: browser_tests on (none) GPU on Mac Sample Flaky Test: BrowserNonClientFrameViewBrowserTest.HTMLMetaThemeColorOverridesManifest Original change's description: > Update PWA frame color to match HTML theme-color meta tag > > This CL updates PWA windows to use the HTML theme-color meta tag > as the frame color over the manifest's theme_color. > > This is in line with the Web App Manifest spec text: > https://www.w3.org/TR/appmanifest/#theme_color-member > > Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382160&signed_aid=n5SryIX1Gm4-apNPrIOfzA==&inline=1 > After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382161&signed_aid=o5hmc8fm-i1d6FXwuam15A==&inline=1 > > Bug: 872121 > Change-Id: Ib431f7b7612c5167cde2489f0263240747d8d50d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496267 > Commit-Queue: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Auto-Submit: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639842} Change-Id: I534ff44a84967d528ecd5b8b6f24622d9fb51ea7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517793 Cr-Commit-Position: refs/heads/master@{#639878} chrome/browser/ui/browser_window.h | 3 -- .../ui/extensions/hosted_app_browser_controller.cc | 43 ++++++---------------- .../ui/extensions/hosted_app_browser_controller.h | 7 +--- .../views/frame/browser_non_client_frame_view.cc | 18 +++------ .../ui/views/frame/browser_non_client_frame_view.h | 12 ++---- .../browser_non_client_frame_view_browsertest.cc | 25 +------------ chrome/browser/ui/views/frame/browser_view.cc | 4 -- chrome/browser/ui/views/frame/browser_view.h | 1 - .../ui/views/frame/glass_browser_frame_view.cc | 16 ++++---- .../ui/views/frame/glass_browser_frame_view.h | 2 +- .../ui/views/frame/hosted_app_button_container.cc | 20 +++------- .../ui/views/frame/hosted_app_button_container.h | 9 ++--- chrome/test/base/test_browser_window.h | 1 - content/public/browser/web_contents.h | 4 +- 14 files changed, 41 insertions(+), 124 deletions(-) commit 9499addc19a0ad37979f885d1fe3c0eeb7765af0 Author: Lowell Manners <lowell@chromium.org> Date: Tue Mar 12 11:05:32 2019 +0000 Convert FrameHostMsg_DocumentOnLoadCompleted to Mojo. Also updated the comment describing this method to remove mentions of parameters that no longer exist. Bug: 786836 Change-Id: Iee2fe58736fa7b806bbc289c144d4c5975df023f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505941 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#639877} content/browser/frame_host/render_frame_host_impl.cc | 4 +--- content/browser/frame_host/render_frame_host_impl.h | 7 +++---- content/common/frame.mojom | 4 ++++ content/common/frame_messages.h | 6 ------ content/renderer/render_frame_impl.cc | 2 +- content/test/test_render_frame.cc | 2 ++ 6 files changed, 11 insertions(+), 14 deletions(-) commit 3dff7a154c6e7f743b7d6dcb2223fae7f9fcd7c3 Author: Hwanseung Lee <hs1217.lee@samsung.com> Date: Tue Mar 12 10:55:07 2019 +0000 [Sync] Remove prefs::kSyncFirstSyncTime This pref is set by ProfileSyncService, but never actually used. so remove this perf and add ClearObsoleteFirstSyncTime function in order to clean up all the stored pref values for existing users. Bug: 938865 Change-Id: Id1117ed9d3d12ad91366b7f7022386065c9de532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514872 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#639876} chrome/browser/prefs/browser_prefs.cc | 3 +++ components/browser_sync/profile_sync_service.cc | 11 ----------- components/browser_sync/profile_sync_service.h | 3 --- .../browser_sync/profile_sync_service_unittest.cc | 1 - components/sync/base/pref_names.cc | 3 --- components/sync/base/pref_names.h | 2 -- components/sync/base/sync_prefs.cc | 23 ++++++++-------------- components/sync/base/sync_prefs.h | 7 +------ 8 files changed, 12 insertions(+), 41 deletions(-) commit 0b16414deb18a1ce9f5877c286fd7b9a2b5dd334 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Tue Mar 12 10:18:31 2019 +0000 [Sync] Clean up the launched pre_commit_update_avoidance feature Bug: 930125 Change-Id: Ib2b6f9aa6317607ac1d2a359382116bfdf357393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511467 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#639875} chrome/browser/sync/test/integration/sync_test.cc | 8 ++++++++ components/browser_sync/profile_sync_service.cc | 4 ---- components/sync/base/experiments.h | 1 - components/sync/driver/sync_driver_switches.cc | 3 --- components/sync/driver/sync_driver_switches.h | 1 - components/sync/engine/engine_components_factory.h | 11 ----------- .../sync/engine/engine_components_factory_impl.cc | 2 -- components/sync/engine/sync_engine_switches.cc | 8 ++++++++ components/sync/engine/sync_engine_switches.h | 2 ++ .../sync/engine/test_engine_components_factory.cc | 2 -- .../sync/engine_impl/cycle/sync_cycle_context.cc | 4 ---- .../sync/engine_impl/cycle/sync_cycle_context.h | 19 ------------------- components/sync/engine_impl/sync_manager_impl.cc | 16 ++-------------- components/sync/engine_impl/sync_scheduler_impl.cc | 5 +---- components/sync/engine_impl/sync_scheduler_impl.h | 2 ++ .../sync/engine_impl/sync_scheduler_impl_unittest.cc | 1 - components/sync/engine_impl/syncer.cc | 9 ++++++++- components/sync/engine_impl/syncer_unittest.cc | 3 --- 18 files changed, 31 insertions(+), 70 deletions(-) commit fba3f288432a05167111287e4af5e4cb1a69331e Author: Lowell Manners <lowell@chromium.org> Date: Tue Mar 12 10:17:46 2019 +0000 Make IdentityAccessorImplTest fully driven by IdentityTestEnvironment. This required creating a temporary friendship with IdentityManager. The friendship can be removed as soon as IdentityAccessorImpl is fully converted to use IdentityManager. Bug: 933109 Change-Id: Ia3bb59d7677c9905c009e86734405af6085ae910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511421 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#639874} .../identity/identity_accessor_impl_unittest.cc | 84 ++++------------------ services/identity/public/cpp/identity_manager.h | 9 ++- .../public/cpp/identity_test_environment.cc | 18 ----- .../public/cpp/identity_test_environment.h | 23 ------ 4 files changed, 20 insertions(+), 114 deletions(-) commit 6208aa43211c09758870c44f7dd7c737e2cc3110 Author: Kent Tamura <tkent@chromium.org> Date: Tue Mar 12 10:17:07 2019 +0000 XMLSerializer: Keep redundant but harmless default namespace declarations Since crrev.com/632142, XMLSerializer has dropped redundant xmlns="..." declarations. It matches to IE, Edge, and DOM P&S standard. This CL reverts the behavior to unbreak existing applications. The restored behavior matches to Firefox and Safari. * MarkupAccumulator::AppendElement(): Even if ignore_namespace_definition_attribute_ is set, we drop a xmlns="..." only if its value is inconsistent with element's namespace. * MarkupAccumulator::AppendStartTagOpen(): if local_default_namespace is "" and ns is null, do not emit xmlns="". This avoids to serialize xmlns="" twice. Bug: https://github.com/w3c/DOM-Parsing/issues/47 Bug: 940204 Change-Id: I2978ddc9a3f9511d227a9a1b902f1811ac1c3c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516124 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#639873} .../renderer/core/editing/serializers/markup_accumulator.cc | 13 +++++++++---- .../domparsing/XMLSerializer-serializeToString-expected.txt | 1 + .../wpt/domparsing/XMLSerializer-serializeToString.html | 11 +++++++++-- 3 files changed, 19 insertions(+), 6 deletions(-) commit 1f2485fbff8eab4c38cab708f6bb5e4409d18876 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Mar 12 10:15:13 2019 +0000 OOR-CORS: Use Blob rather than about:blank to create a dummy Worker In dispatchEvent-crash.html test, Worker is constructed with about:blank URL, but it fails to load because it is assumed as a CORS request. This patch modifies the test to use Blob rather than about:blank. Bug: 870173 Change-Id: Ie918d52079fff4a8a78338cef70a0280173b26ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517502 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#639872} third_party/blink/web_tests/fast/events/dispatchEvent-crash.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 567a55bb26f55c5a926f62ca3073d94568cac7d9 Author: Clemens Hammacher <clemensh@chromium.org> Date: Tue Mar 12 10:01:39 2019 +0000 [v8][wasm] Fix outdated and missing UMA descriptions This updates a few WebAssembly related UMA descriptions, and adds information about when they are recorded. R=titzer@chromium.org, isherman@chromium.org Bug: v8:8975 Change-Id: Ifff7e4fe531a5330675c9c6ba985a6d22a9dfc5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514833 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#639871} tools/metrics/histograms/histograms.xml | 58 +++++++++++++++++++++++---------- 1 file changed, 41 insertions(+), 17 deletions(-) commit 15b94a4ed80f8f4a6b9644df72037b8fd7e91035 Author: Marc Treib <treib@chromium.org> Date: Tue Mar 12 10:00:48 2019 +0000 AvatarButtonErrorController: don't QueryDetailedSyncStatus SyncService::QueryDetailedSyncStatus() exposes internals, and should really only be used for debug UIs and the like. In this case, it was only used to check for an UPGRADE_CLIENT action. However, that action is always accompanied by an unrecoverable error [1], and the code also checks for those anyway, so the QueryDetailedSyncStatus() call is redundant. [1] https://cs.chromium.org/chromium/src/components/browser_sync/profile_sync_service.cc?rcl=8bb6670bf5943980e196ce3ef0743109c3ca1108&l=996 Bug: 940437 Change-Id: I4592b2ed18e3c438ed526f70f636547f0c83a36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514754 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#639870} chrome/browser/ui/avatar_button_error_controller.cc | 5 ----- 1 file changed, 5 deletions(-) commit 16a994578d9c58d4a8af818a8c2d7a8894cdf93a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 10:00:08 2019 +0000 Roll src/third_party/swiftshader 3364227fa0d8..3e2a4780e607 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/3364227fa0d8..3e2a4780e607 git log 3364227fa0d8..3e2a4780e607 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 swiftshader.regress@gmail.com Regres: Update test lists @ 3364227f Created with: gclient setdep -r src/third_party/swiftshader@3e2a4780e607 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iea0cc552b3bb92803c5980d2141aff49661a2ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517358 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639869} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f191a896f6320ed2e14ea686814d9c5664468bdf Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Mar 12 09:56:51 2019 +0000 [Files app] Disable Context Menu FSP which is flaky Tbr: adanilo@chromium.org Bug: 940459 Change-Id: Ie6ca7aacd4c1680a2945197cb058744cc0f04a69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517500 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#639868} chrome/browser/chromeos/file_manager/file_manager_browsertest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 33dd8cc60a57c4d82c0583189a0093b0432857d7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 09:42:01 2019 +0000 Roll Fuchsia SDK from 899835ec9999 to f6a5010b941c The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia73dcda3371d451d0cc8d1929888dda3990d0770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517532 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639867} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 4286a3d39891911e9685b27d555f68f0b5f9cf3f Author: Kentaro Hara <haraken@chromium.org> Date: Tue Mar 12 09:41:31 2019 +0000 Update WATCHLIST Bug: None Change-Id: I3b7ac9cde34f28617f36a3c9bc469ed47ca4cd84 TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517501 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639866} WATCHLISTS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 38bdba04061db32e437477720296e853bd8cfb76 Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Mar 12 09:29:40 2019 +0000 Dispatch mojo data pipe to ResourceLoader In order to deprecate WebDataConsumerHandle, this CL dispatches a mojo data pipe to ResourceLoader. Further cleanup CLs will follow. Bug: 894819 Change-Id: Id01b73053555ce0daf06a76f4521270663e40aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460577 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#639865} content/renderer/loader/web_url_loader_impl.cc | 44 +------- .../loader/web_url_loader_impl_unittest.cc | 114 ++++++--------------- .../core/html/imports/html_import_loader.cc | 2 +- .../blink/renderer/core/loader/preload_helper.cc | 6 ++ .../core/loader/resource/image_resource.cc | 1 + .../renderer/platform/loader/fetch/raw_resource.cc | 18 ++-- .../platform/loader/fetch/resource_loader.cc | 36 +++++-- .../platform/loader/fetch/resource_loader.h | 2 + .../platform/loader/fetch/response_body_loader.cc | 1 - 9 files changed, 77 insertions(+), 147 deletions(-) commit 6bc21ec0642483715b52f5a228523c1d3f98a25f Author: Kenichi Ishibashi <bashi@chromium.org> Date: Tue Mar 12 09:21:08 2019 +0000 OMT service worker fetch: Fix WebEmbeddedWorkerTestImplTests This CL adds some mock objects that are needed to write unittests for off-main-thread script fetch. This CL also adds unittests for off-main-thread script fetch. Change-Id: I589855d4e7610f5bd09a63d1d640cba114ca9750 Bug: 938151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510093 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#639864} .../modules/exported/web_embedded_worker_impl.cc | 5 + .../modules/exported/web_embedded_worker_impl.h | 2 + .../web_embedded_worker_impl_test.cc | 224 ++++++++++++++++++++- 3 files changed, 227 insertions(+), 4 deletions(-) commit 3790807cb9ec87d5f737a42761c3f60cbb8ccffc Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 12 09:10:08 2019 +0000 [iOS][web] Group JavaScript methods This CL groups the methods related to JavaScript in CRWWebController. Bug: 938255 Change-Id: I3eca974f27af38d41ba9a0c4823a53543123a7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511462 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#639863} ios/web/web_state/ui/crw_web_controller.mm | 370 ++++++++++++++--------------- 1 file changed, 179 insertions(+), 191 deletions(-) commit 8158f07c248883ba3928996a567df957581e1e89 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Mar 12 08:57:49 2019 +0000 Update FlagExpectations for disable-features=NetworkService Since virtual/outofblink-cors depends on NetworkService, we skip them if NetworkService is disabled. Bug: 940528, 940328 Change-Id: I2c13da62a95c0efb21fc7af9d1228d0e4d4b44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517495 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#639862} .../web_tests/FlagExpectations/disable-features=NetworkService | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) commit ff803c09369b53b0beb55bbe5339c1e5e5e42e1d Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Mar 12 08:49:39 2019 +0000 OOR-CORS: Call DispatchDidFail even for local file sync XHR failures Blink has a historical code not to call DispatchDidFail on local file sync XHR failures, but it's wrong in terms of spec conformance. After OOR-CORS is enabled, code path is changed, and the legacy historical code does not run any more. So, rather than adding the historical code again onto the OOR-CORS code path, let me remove the historical code, and change the behavior to conform the spec. After this behavior changes, some tests fail, and all reasons are tests were just wrong. - NavigationDisableWebSecurityTest.ValidateBaseUrlForDataUrl Expected failed local file sync XHR didn't raise an exception. The test script is fixed in this change. - fast/encoding/GBK/close-gbk-converter.html Ditto. - fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html Ditto. - fast/xmlhttprequest/set-dangerous-headers-local.html This was a dup of wpt/xhr/setrequestheader-header-forbidden.htm, and wrongly assuming it didn't raise an exception. Removed. - fast/xmlhttprequest/xmlhttprequest-missing-file-exception.html A wrong test for the historical code that had made the WebKit work for the very old broken wikipedia page. Removed. Bug: 909685 Change-Id: I46c63ef1ec014be3220285e70800b4b9b3dec32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1353041 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#639861} content/browser/navigation_browsertest.cc | 2 +- .../renderer/core/loader/threadable_loader.cc | 8 +-- third_party/blink/web_tests/SmokeTests | 1 - third_party/blink/web_tests/TestExpectations | 1 - .../fast/encoding/GBK/close-gbk-converter.html | 4 +- .../set-dangerous-headers-local-expected.txt | 31 ----------- .../set-dangerous-headers-local.html | 65 ---------------------- ...httprequest-missing-file-exception-expected.txt | 9 --- .../xmlhttprequest-missing-file-exception.html | 51 ----------------- .../xmlhttprequest-recursive-sync-event.html | 2 +- 10 files changed, 5 insertions(+), 169 deletions(-) commit 4fd158098ba2fd0c2877aa827234e9cb5f2e2d42 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Mar 12 08:40:46 2019 +0000 ServiceWorker: Add TIMEOUT event status to return it to the browser This is to align with the behavior of the non servicified path. Bug: 852658 Change-Id: I0a95231d6cc8e0c8745aaede523c54100c5e1603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511096 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#639860} .../service_worker_context_client.cc | 16 +++-- .../service_worker_subresource_loader.cc | 1 + .../service_worker/service_worker_timeout_timer.cc | 16 ++--- .../service_worker/service_worker_timeout_timer.h | 26 +++++--- .../service_worker_timeout_timer_unittest.cc | 73 +++++++++++++--------- .../service_worker_type_converters.cc | 2 + .../service_worker_event_status.mojom | 12 ++-- 7 files changed, 82 insertions(+), 64 deletions(-) commit 03fa6fe8b9f75cb012c3b153aacea40ef9bf8f25 Author: Mikel Astiz <mastiz@chromium.org> Date: Tue Mar 12 08:28:07 2019 +0000 Migrate sync migration tests away from python server These are the remaining tests that make use of the test server in components/sync/tools/testserver/ which can now be deleted in follow-up patches. The patch also reenables multiple tests that have been failing for years, and others that were reported flaky (let's hope that flakes no longer reproduce). In order to achieve this, LoopbackServer had to be extended with support for migration (and corresponding version tracking). This has been achieved in a backward-compatible way, such that local sync (enterprise use-cases) is not affected. Bug: 406545,918124,403778,565559 Change-Id: I73bda43bc95a000c7bf390a6f93b39035c51cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514553 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#639859} .../sync/test/integration/migration_test.cc | 76 +++-------- chrome/browser/sync/test/integration/sync_test.cc | 67 +--------- chrome/browser/sync/test/integration/sync_test.h | 30 +---- .../engine_impl/loopback_server/loopback_server.cc | 147 +++++++++++++++++---- .../engine_impl/loopback_server/loopback_server.h | 11 +- components/sync/test/fake_server/fake_server.cc | 5 + components/sync/test/fake_server/fake_server.h | 2 + 7 files changed, 170 insertions(+), 168 deletions(-) commit e9b850a1639cb2128b59d28b36f0be39f2493c99 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Mar 12 08:21:40 2019 +0000 Cleanup MediaStreamAudioSource and the classes around it This is a follow-up CL to https://chromium-review.googlesource.com/c/chromium/src/+/1508522 * Removes ExternalMediaStreamAudioSource, that is not used anywhere. * Removes 'explicit' keywords * Use std::move whenever possible * Moves FakeRTCRTPTransceiver to the test source sets Bug: 870606 Change-Id: I94569c5176e97cb2d862cb4c2088e1b34d31e691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511103 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#639858} content/renderer/BUILD.gn | 4 -- .../stream/external_media_stream_audio_source.cc | 82 ---------------------- .../stream/external_media_stream_audio_source.h | 62 ---------------- .../stream/local_media_stream_audio_source.cc | 4 +- .../media/stream/processed_local_audio_source.cc | 2 +- .../media/stream/webaudio_media_stream_source.cc | 5 +- .../media/stream/webaudio_media_stream_source.h | 2 +- .../media/webrtc/fake_rtc_rtp_transceiver.cc | 2 +- .../media/webrtc/fake_rtc_rtp_transceiver.h | 12 ++-- .../webrtc/peer_connection_remote_audio_source.cc | 3 +- .../webrtc/peer_connection_remote_audio_source.h | 2 +- .../html_audio_element_capturer_source.cc | 7 +- .../html_audio_element_capturer_source.h | 2 +- content/renderer/media_stream_utils.cc | 1 - content/renderer/render_thread_impl.cc | 8 +-- content/renderer/renderer_blink_platform_impl.cc | 4 +- content/test/BUILD.gn | 2 + .../mediastream/media_stream_audio_source.h | 2 +- .../mediastream/media_stream_audio_source.cc | 2 +- 19 files changed, 33 insertions(+), 175 deletions(-) commit cbd960dce298690a30ca51e71e60883a35aa9055 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Mar 12 08:11:44 2019 +0000 [journey] remove deps from proto_library I will deprecate deps in proto_library for improved build throughput. And we don't need to have empty deps here. Bug: 938011 Change-Id: Ie1b959cdb06d11d8ad3bcc2c4dd761cc08793e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514339 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#639857} components/journey/proto/BUILD.gn | 1 - 1 file changed, 1 deletion(-) commit 08073c98296c42600266d465e30899321169c34a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 08:07:33 2019 +0000 Roll src/third_party/dawn 1e1c13ed87ba..8d79f78c789d (1 commits) https://dawn.googlesource.com/dawn.git/+log/1e1c13ed87ba..8d79f78c789d git log 1e1c13ed87ba..8d79f78c789d --date=short --no-merges --format='%ad %ae %s' 2019-03-11 enga@chromium.org Remove GLVersion from GLAD header and make it static Created with: gclient setdep -r src/third_party/dawn@8d79f78c789d The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:877147 TBR=cwallez@chromium.org Change-Id: I8f6a6f500a0a88b912323b64be557316b679f253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516742 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639856} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fd69c0ac9f0326af2c698511f66db61dfeb6864 Author: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Date: Tue Mar 12 08:02:49 2019 +0000 Fix depthStreamToRGBAUint8Texture test logic. BUG=824438,819661 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25eab42d89c3b4ae76ccd012b3c52403d678b1b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/978251 Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#639855} content/test/data/media/depth_stream_test_utilities.js | 13 ++++++++----- content/test/gpu/gpu_tests/depth_capture_expectations.py | 4 ---- 2 files changed, 8 insertions(+), 9 deletions(-) commit 7b0f95b97c21b98173b1a9384e94fae05aa44fef Author: Roman Sorokin <rsorokin@chromium.org> Date: Tue Mar 12 07:57:59 2019 +0000 cros: Enable all the SAML testz From my testing and trybots the tests are not flaky. Let's enable it and keep an eye on waterfall. Change-Id: Ie236fa5416ebe170c1742e69baa6bebdd6a5f73a Bug: 504141, 830322, 659992, 834703, 766953 Bug: 683161, 714167 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514675 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#639854} .../chromeos/login/saml/saml_browsertest.cc | 114 +++------------------ 1 file changed, 12 insertions(+), 102 deletions(-) commit a034fd263f4ef334c4f2f5bd2752c2fca8f7ff88 Author: Koji Ishii <kojii@chromium.org> Date: Tue Mar 12 07:50:06 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 16477 16483 16506 16520 16526 16542 16550 0 lines were removed and 0 lines were deflaked by consecutive results since 16442. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I716ef0f306a885f2f8e83e1f9a0fba4698fdf015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514463 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#639853} .../enable-blink-features=LayoutNG | 33 ++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) commit 18350dee7dc0fe448c7e4a6f2ee7412dfde14443 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 12 07:49:24 2019 +0000 Remove UnderlyingImageChecker::Create and InheritedImageChecker::Create Many classes in blink have supported factory functions with legacy uses of RefPtr/adoptRef. It can block to make to use MakeGarbageCollected. Besides some classes have supported both a factory function and a public constructor. They aren't necessary. This CL removes UnderlyingImageChecker::Create() and InheritedImageChecker::Create and make their constructors public, then make the callers use std::make_unique_ptr<UnderlyingImageChecker> or std::make_unique<InheritedImageChecker> instead of their Create() factory functions. Bug: 939691 Change-Id: I3eda4620c238a091c696e412d5e2acf6ea0c33c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517432 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#639852} .../core/animation/css_image_interpolation_type.cc | 27 ++++++---------------- 1 file changed, 7 insertions(+), 20 deletions(-) commit 5ad5980458e4b0cfccb59c14ad30df32ae989612 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 12 07:44:47 2019 +0000 Remove IsMonospaceChecker::Create and InheritedFontSizeChecker::Create Many classes in blink have supported factory functions with legacy uses of RefPtr/adoptRef. It can block to make to use MakeGarbageCollected. Besides some classes have supported both a factory function and a public constructor. They aren't necessary. This CL removes IsMonospaceChecker::Create() and InheritedFonntSizeChecker::Create and make their constructors public, then make the callers use std::make_unique_ptr<IsMonospaceChecker> or std::make_unique<InheritedFontSizeChecker> instead of their Create() factory functions. Bug: 939691 Change-Id: I5d90f320d1f8a30487d7de1d8d0bcb9bdca3845f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517335 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#639851} .../animation/css_font_size_interpolation_type.cc | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) commit 54a9fc4813225aef47e861387a25574109df2912 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue Mar 12 07:01:08 2019 +0000 Fix null header dereference in PrerenderURLLoaderThrottle Bug: 940577 Change-Id: Ia7a0296069e2ab1cf34bf1cff0ae613ea5f02007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516129 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#639850} chrome/common/prerender_url_loader_throttle.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 59c7f1e14e015908935699102e85bbeb20880039 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Mar 12 07:00:56 2019 +0000 Revert "[Extensions Bindings] Remove the kNativeCrxBindings feature" This reverts commit 73c5a82773c0cff9d282e3e2273132b856a4de7e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 639786 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzNjNWE4Mjc3M2MwY2ZmOWQyODJlM2UyMjczMTMyYjg1NmE0ZGU3ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.11%20Tests/34992 Sample Failed Step: browser_tests on (none) GPU on Mac on Mac-10.11 Sample Flaky Test: ExternallyConnectableMessagingTest.FromIncognitoPromptApp Original change's description: > [Extensions Bindings] Remove the kNativeCrxBindings feature > > NativeCrxBindings have been enabled on stable channel since M72. Remove > the feature flag, and update the sites that were using it. > > This CL: > * Removes all references to the feature > * Updates parameterized tests (typically making them un-parameterized, > unless they were parameterized on multiple axes) > * Removes else-blocks that are unreachable > > Follow-up CLs will remove JS-binding specific code, such as the > unnecessary custom bindings files and the JSBindingsSystem concepts. > > Bug: 938998 > Change-Id: Ic68cf9da3f52f22321f1b02b00a1ea98951aa540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507041 > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Luke Halliwell <halliwell@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639786} Change-Id: I87902edde57847f1e6ca669fce4e1a60aba85d93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 938998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517109 Cr-Commit-Position: refs/heads/master@{#639849} .../incoming_native_messaging_apitest.cc | 26 +++- .../extensions/api/storage/settings_apitest.cc | 34 ++++- .../extensions/api_binding_perf_browsertest.cc | 35 ++++- .../browser/extensions/content_script_apitest.cc | 37 ++++- .../error_console/error_console_browsertest.cc | 80 ++++++++--- chrome/browser/extensions/extension_apitest.cc | 7 +- .../extensions/extension_bindings_apitest.cc | 153 ++++++++++++-------- .../extensions/extension_messages_apitest.cc | 111 ++++++++++----- .../browser/extensions/native_bindings_apitest.cc | 10 ++ .../browser/extensions/service_worker_apitest.cc | 158 +++++++++++++++------ .../extensions/service_worker_messaging_apitest.cc | 44 ++++-- .../chrome_extensions_dispatcher_delegate.cc | 20 +-- .../cast_extensions_dispatcher_delegate.cc | 3 + extensions/common/extension_features.cc | 4 + extensions/common/extension_features.h | 1 + extensions/renderer/dispatcher.cc | 48 ++++--- extensions/renderer/module_system.cc | 11 +- extensions/renderer/module_system.h | 4 + extensions/renderer/module_system_test.cc | 15 +- extensions/renderer/utils_unittest.cc | 13 ++ testing/variations/fieldtrial_testing_config.json | 18 +++ 21 files changed, 617 insertions(+), 215 deletions(-) commit 915a56f437103582ef4541927cce92553b5bdf26 Author: Alexander Hendrich <hendrich@chromium.org> Date: Tue Mar 12 06:59:48 2019 +0000 [ProtoSync] Add comment as hook for proto sync script This CL adds a comment as hook for the proto sync script (go/cros-proto-sync). Everything below this comment will be synced between server and client. I will add the same comment on the server-side (https://critique.corp.google.com/#review/237812222). Bug: 933348 Change-Id: I3e609c5f1027e00f8f35814e507592130c568875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515392 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#639848} components/policy/proto/device_management_backend.proto | 3 +++ 1 file changed, 3 insertions(+) commit 23fe8933199467a73ff88f3fb734d83b61747025 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Mar 12 06:57:09 2019 +0000 Reland "Reland "OOR-CORS: Make kOutOfBlinkCors depends on kNetworkService"" This is a reland of ba2a3b386a5a1bca8f54072c846a89324302010c Original change's description: > Reland "OOR-CORS: Make kOutOfBlinkCors depends on kNetworkService" > > This is a reland of 07b27bf0b096cada9ead5dda7ec8eb705c1f18ea > > This patch is revised so that VirtualTestSuites to have settings > for outofblink-cors to run always with NetworkService. > > Original change's description: > > OOR-CORS: Make kOutOfBlinkCors depends on kNetworkService > > > > To manage server side config safely, have a logic not to enable > > the feature if NetworkService is disabled. > > > > Bug: 905971 > > Change-Id: Icfc9525b1b2a22882944ccbe38a404e7219b2373 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506066 > > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638967} > > Bug: 905971, 940328 > Change-Id: I535a895e35b87989a5bfa56666de4976b33a4972 > > TBR: yhirano@chromium.org > Change-Id: I535a895e35b87989a5bfa56666de4976b33a4972 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514342 > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639410} TBR=toyoshim@chromium.org Bug: 905971, 940328 Change-Id: Id6411ebfff3f1e9457395fef8013d6f8e9c13d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516054 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#639847} .../loader/cors_origin_access_list_browsertest.cc | 63 ++++++---------------- content/child/runtime_features.cc | 2 +- services/network/cors/cors_url_loader_factory.cc | 3 +- services/network/cors/cors_url_loader_unittest.cc | 3 +- services/network/public/cpp/features.cc | 8 +++ services/network/public/cpp/features.h | 2 + third_party/blink/web_tests/VirtualTestSuites | 18 +++---- 7 files changed, 39 insertions(+), 60 deletions(-) commit 4ce0cb63dbd57af0ac6a96e41ecee8649092125b Author: Marina Ciocea <marinaciocea@chromium.org> Date: Tue Mar 12 06:51:12 2019 +0000 Update RTCDataChannel bufferedamountlow implementation. Maintain bufferedamount value in blink layer. Increase bufferedamount on send and decrease it on OnBufferedAmountChange updates from webrtc layer. Fire bufferedamountlow when bufferedamount goes below bufferedamountlowthreshold. This change builds upon the corresponding webrtc change: https://webrtc-review.googlesource.com/c/src/+/123237 Design doc: http://doc/1lorHBn-GMn5U0T0RQANxrsW0pXhw8XGZM-xZyVUOW90 Standard: https://w3c.github.io/webrtc-pc/#event-datachannel-bufferedamountlow Bug: 878682 Change-Id: Ifebc79f71f924ecb5cedce1c94e18440663337f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474764 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#639846} .../modules/peerconnection/rtc_data_channel.cc | 50 ++++++++++---------- .../modules/peerconnection/rtc_data_channel.h | 7 +-- .../peerconnection/rtc_data_channel_test.cc | 28 ++--------- .../RTCDataChannel-bufferedAmount-expected.txt | 11 +++-- .../wpt/webrtc/RTCDataChannel-bufferedAmount.html | 55 ++++++++++++++++++++++ 5 files changed, 98 insertions(+), 53 deletions(-) commit d21d2514e33484f0625431e8c1cb77e20d66d0a1 Author: Johann <johannkoenig@google.com> Date: Tue Mar 12 06:50:32 2019 +0000 libaom: fix WinARM64 build BUG=chromium:893460 TBR=tomfinegan@chromium.org Change-Id: I44626b4a29d037195a846c375cd0840f68196333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516921 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#639845} third_party/libaom/cmake_update.sh | 13 + .../source/config/win/arm64/config/aom_config.asm | 78 + .../source/config/win/arm64/config/aom_config.c | 13 + .../source/config/win/arm64/config/aom_config.h | 82 + .../source/config/win/arm64/config/aom_dsp_rtcd.h | 3320 ++++++++++++++++++++ .../config/win/arm64/config/aom_scale_rtcd.h | 166 + .../source/config/win/arm64/config/av1_rtcd.h | 1085 +++++++ 7 files changed, 4757 insertions(+) commit 2376593171a9307e12739777d2ff99638c2472f5 Author: liberato@chromium.org <liberato@chromium.org> Date: Tue Mar 12 06:46:21 2019 +0000 Start removing LearningSession::AddExample. This CL start switching LearningSession to provide unique-ptr'd LearningTaskControllers for a task, rather than proxying AddExample to tasks. The returned LearningTaskController will safely stop working if the session is destroyed, and will also cancel all in-flight observations if the LearningTaskController is deleted. This CL also removes the mojo LearningSession service / client code, which will be replaced in a future CL by LearningTaskController code. This change is needed because a singleton session on the browser side isn't sufficient anymore. We need a per-renderer object to make it easier integrate Ukm source id. Change-Id: I96e6c67a4453ce6c15025a9298e4be12fb01e973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510753 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#639844} media/capabilities/learning_helper.cc | 31 ++++++--- media/capabilities/learning_helper.h | 20 ++++-- media/learning/common/learning_session.h | 12 ++-- media/learning/common/learning_task_controller.h | 3 +- media/learning/impl/learning_session_impl.cc | 80 ++++++++++++++++++---- media/learning/impl/learning_session_impl.h | 7 +- .../impl/learning_session_impl_unittest.cc | 57 ++++++++++++++- media/learning/mojo/BUILD.gn | 7 +- media/learning/mojo/dummy.cc | 8 +++ media/learning/mojo/mojo_learning_session_impl.cc | 31 --------- media/learning/mojo/mojo_learning_session_impl.h | 53 -------------- .../mojo/mojo_learning_session_impl_unittest.cc | 63 ----------------- media/learning/mojo/public/cpp/BUILD.gn | 9 --- .../mojo/public/cpp/mojo_learning_session.cc | 24 ------- .../mojo/public/cpp/mojo_learning_session.h | 36 ---------- .../public/cpp/mojo_learning_session_unittest.cc | 68 ------------------ 16 files changed, 182 insertions(+), 327 deletions(-) commit 7bf6764bbe066cb4a545baaae4549802f4874e8d Author: Yutaka Hirano <yhirano@chromium.org> Date: Tue Mar 12 06:45:11 2019 +0000 RawResource::ResponseBodyReceived shouldn't rely on IsUnusedPreload Because Resource::AddClient calls FinishPendingClients asynchronously for RawResource, it's possible that ResponseBodyReceived is called when - IsUnusedPreload() is false, and - The client is not yet added. We need to store the BytesConsumer in such a care. Bug: 894819, 940299 Change-Id: I8399d9b6dd0b69dfa2f3eb7fb79e25ab4432ec04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511099 Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#639843} .../renderer/platform/loader/fetch/raw_resource.cc | 6 +-- .../platform/loader/fetch/raw_resource_test.cc | 54 ++++++++++++++++++++++ .../loader/fetch/response_body_loader_client.h | 2 +- .../loader/fetch/response_body_loader_test.cc | 2 +- 4 files changed, 57 insertions(+), 7 deletions(-) commit ea67b57d05efdf10e6aadae6776cc0f428d0991a Author: Alan Cutter <alancutter@chromium.org> Date: Tue Mar 12 06:44:27 2019 +0000 Update PWA frame color to match HTML theme-color meta tag This CL updates PWA windows to use the HTML theme-color meta tag as the frame color over the manifest's theme_color. This is in line with the Web App Manifest spec text: https://www.w3.org/TR/appmanifest/#theme_color-member Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382160&signed_aid=n5SryIX1Gm4-apNPrIOfzA==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=382161&signed_aid=o5hmc8fm-i1d6FXwuam15A==&inline=1 Bug: 872121 Change-Id: Ib431f7b7612c5167cde2489f0263240747d8d50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496267 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#639842} chrome/browser/ui/browser_window.h | 3 ++ .../ui/extensions/hosted_app_browser_controller.cc | 43 ++++++++++++++++------ .../ui/extensions/hosted_app_browser_controller.h | 7 +++- .../views/frame/browser_non_client_frame_view.cc | 18 ++++++--- .../ui/views/frame/browser_non_client_frame_view.h | 12 ++++-- .../browser_non_client_frame_view_browsertest.cc | 25 ++++++++++++- chrome/browser/ui/views/frame/browser_view.cc | 4 ++ chrome/browser/ui/views/frame/browser_view.h | 1 + .../ui/views/frame/glass_browser_frame_view.cc | 16 ++++---- .../ui/views/frame/glass_browser_frame_view.h | 2 +- .../ui/views/frame/hosted_app_button_container.cc | 20 +++++++--- .../ui/views/frame/hosted_app_button_container.h | 9 +++-- chrome/test/base/test_browser_window.h | 1 + content/public/browser/web_contents.h | 4 +- 14 files changed, 124 insertions(+), 41 deletions(-) commit 2175aa2ee4e956cb2d864b2e3a80fed04574ac58 Author: Uzair Jaleel <uzair.jaleel@samsung.com> Date: Tue Mar 12 06:33:12 2019 +0000 Remove unused function GetDefaultScreenInfo Change-Id: Ic4814b4cfb878005644f325e1f1b72136fa2627c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514462 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Cr-Commit-Position: refs/heads/master@{#639841} content/browser/web_contents/web_contents_view.h | 4 ---- 1 file changed, 4 deletions(-) commit 59817d1d0a7e5b9cea103fe7c789761a39616c25 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Mar 12 06:30:41 2019 +0000 sheriff: disable TabsTest.testTabSelectionPortrait TBR=twellington@chromium.org Bug: 940831 Change-Id: I0c2053d91de60866819f834936e00888d87d5383 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517333 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#639840} chrome/android/javatests/src/org/chromium/chrome/browser/TabsTest.java | 1 + 1 file changed, 1 insertion(+) commit 956e7f6d076c2a1ed49674cd756d865db2d9fda0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 06:13:23 2019 +0000 Roll src/third_party/angle 0f34f3f2f785..c9bc33cff483 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/0f34f3f2f785..c9bc33cff483 git log 0f34f3f2f785..c9bc33cff483 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 jiajia.qin@intel.com Disable the initialization of shared memory Created with: gclient setdep -r src/third_party/angle@c9bc33cff483 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If5ef9ade3d1b4f232b511454f4be30f1f709cac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517373 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639839} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cea445d3fffb76ed1ffaea0e0d7746780239b816 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 06:10:50 2019 +0000 Roll src/third_party/depot_tools 112a77f4bfed..77e5d48a085e (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/112a77f4bfed..77e5d48a085e git log 112a77f4bfed..77e5d48a085e --date=short --no-merges --format='%ad %ae %s' 2019-03-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@77e5d48a085e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9aaa21971e5538d33c7855bf2361a5613066f6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517372 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639838} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5744795c2ff82bb5e6ab7712dacae0f1bf920ff6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 06:05:27 2019 +0000 Roll src/third_party/glslang/src 40c16ec0b3ad..437a552f51ec (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/40c16ec0b3ad..437a552f51ec git log 40c16ec0b3ad..437a552f51ec --date=short --no-merges --format='%ad %ae %s' 2019-03-12 johnkslang@users.noreply.github.com Merge pull request #1723 from null77/gn-val-executable Created with: gclient setdep -r src/third_party/glslang/src@437a552f51ec The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie423e1d5c6be8e0730d3bec532c797c38e865f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517277 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639837} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8ad989a65c7b7a7cfa1351a12ae2b22b7380419 Author: Nicolas Ouellet-payeur <nicolaso@chromium.org> Date: Tue Mar 12 06:03:59 2019 +0000 update_annotations_sheet: don't insert elements above header row Running the script with new annotations added would previously look like this, which is incorrect: https://screenshot.googleplex.com/EkQM60xnaaj This ensures the new elements are inserted in the right place in the spreadsheet. Bug: 878759 Change-Id: Ibfc957a52ce7b8c857b0ab28f1cbe86ea9b72fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516712 Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#639836} tools/traffic_annotation/scripts/update_annotations_sheet.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit b8da3f9a6fd6f77c140ddbcc8aa9244a1fbcf529 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Mar 12 06:00:16 2019 +0000 Links and docs with just one image inside should get annotated. There were cases where no annotation was being read for an image inside of a link, depending on the exact syntax and the platform and screen reader. In addition, some screen readers weren't reading the image annotation when opening an image by itself in a tab. Address both of these by having a rootWebArea or link get the annotation of its inner image, when it has exactly one inner image and no other text or object with a name inside. Bug: 940043 Change-Id: Ic3283e6f8ea26f1ec9ed1cb1203800cd44a49a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512916 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#639835} .../accessibility/image_annotation_browsertest.cc | 74 ++++++++++++++++++++++ .../data/accessibility/image_annotation_doc.html | 6 ++ .../data/accessibility/image_annotation_link.html | 30 +++++++++ .../renderer/accessibility/ax_image_annotator.cc | 34 ++++++++-- .../renderer/accessibility/ax_image_annotator.h | 5 ++ .../renderer/accessibility/blink_ax_tree_source.cc | 72 ++++++++++++++++++++- .../render_accessibility_impl_browsertest.cc | 4 +- 7 files changed, 216 insertions(+), 9 deletions(-) commit 78b0a5e8574353af8d11f448841ad15249d70b07 Author: Wei Lee <wtlee@google.com> Date: Tue Mar 12 05:48:36 2019 +0000 Implement CrOS Image Capture Javascript API This CL implements CrOS Image Capture Javascript API to wrap the mojo usage and expose high level APIs to CCA. Bug: b/117817062 Change-Id: Ie7c198cc3006208b1aa4b7bb9def9e1bcb026242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1394351 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#639834} .../browser/resources/chromeos/camera/.eslintrc.js | 1 + chrome/browser/resources/chromeos/camera/BUILD.gn | 19 +++++ .../chromeos/camera/src/js/mojo/imagecapture.js | 90 ++++++++++++++++++++++ 3 files changed, 110 insertions(+) commit ca2d53ce575c7010a800d69ff51ca1cb461e9171 Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue Mar 12 05:47:47 2019 +0000 [Display Locking]: Handle elements in templates Elements in templates have a special type of Document different from the main document - it doesn't have a LocalFrameView, causing a failing DCHECK in the DisplayLockContext constructor. We should also treat them as not-connected even though isConnected() returns true for them. Bug: 937740 Change-Id: I52491b982dbc0465995bbb7a64f739d1e58dab10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506063 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#639833} .../core/display_lock/display_lock_context.cc | 24 +++--- .../core/display_lock/display_lock_context.h | 6 ++ .../core/display_lock/display_lock_context_test.cc | 90 ++++++++++++++++++++++ .../lock-before-append/element-in-template.html | 51 ++++++++++++ 4 files changed, 161 insertions(+), 10 deletions(-) commit d74e3a4096ed0452b695086a4b59c85a2e7fe0a6 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 12 05:41:59 2019 +0000 Remove SourceLocation::Create() factory function Many classes in blink have supported factory functions with legacy uses of RefPtr/adoptRef. It can block to make to use MakeGarbageCollected. Besides some classes have supported both a factory function and a public constructor. They aren't necessary. This CL removes SourceLocation::Create() and make it's constructor public, then make the callers use std::make_unique_ptr<SourceLocation> instead of SourceLocation::Create(). Bug: 939691 Change-Id: I9c5cdac6b9540c7cd1de17e4254c94ca572ed4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517292 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639832} .../v8/js_event_handler_for_content_attribute.cc | 5 ++-- .../renderer/bindings/core/v8/rejected_promises.cc | 14 +--------- .../renderer/bindings/core/v8/source_location.cc | 31 +++++++--------------- .../renderer/bindings/core/v8/source_location.h | 16 ++++------- .../renderer/bindings/core/v8/v8_initializer.cc | 4 +-- third_party/blink/renderer/core/dom/document.cc | 12 +++++---- .../blink/renderer/core/events/error_event.cc | 7 ++--- .../renderer/core/frame/web_local_frame_impl.cc | 15 ++++++----- .../renderer/core/inspector/console_message.cc | 4 +-- .../core/inspector/main_thread_debugger.cc | 6 ++--- .../core/inspector/worker_thread_debugger.cc | 6 ++--- third_party/blink/renderer/core/page/page.cc | 2 +- .../renderer/core/xml/xslt_processor_libxslt.cc | 2 +- .../modules/exported/web_embedded_worker_impl.cc | 4 +-- .../renderer/modules/websockets/dom_websocket.cc | 2 +- .../modules/websockets/web_pepper_socket_impl.cc | 2 +- .../websockets/websocket_channel_impl_test.cc | 6 ++--- 17 files changed, 57 insertions(+), 81 deletions(-) commit c22506e114d6c6c8589be76b07fdcbc0821372d5 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Mar 12 05:35:49 2019 +0000 [Files app] - Add context menu tests Add test for Crostini folder. Add test for ARC++ folder. Add test for USB folder. Change USB test partition to have a folder and fix tests that waits for USB partition's content. Fix directory_tree.js to not fail if trying to construct a SubDirectoryItem when its volume has been unmounted, this fixes tests with failing when USB partition is unmounted. Add test for FSP folder. Change test FSP implementation to return a folder inside root. Disable FSP test for now because it's flake. Add test for Documents Provider context menu and a folder inside it. Bug: 940459 Change-Id: I2beedd581b049e35b09d4df46212e7bd78a231cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516119 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#639831} .../file_manager/file_manager_browsertest.cc | 1 + .../file_manager/file_manager_browsertest_base.cc | 2 + .../foreground/js/ui/directory_tree.js | 2 +- .../file_manager/directory_tree_context_menu.js | 124 +++++++++++++++++++-- .../integration_tests/file_manager/file_display.js | 5 +- .../integration_tests/file_manager/quick_view.js | 5 +- .../testing_provider/background.js | 20 +++- 7 files changed, 145 insertions(+), 14 deletions(-) commit 97ac243809e448e7c70a44507131d59159c51892 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 05:33:01 2019 +0000 Roll src/third_party/catapult 4c54c5ccdebd..eb73833a2935 (1 commits) https://chromium.googlesource.com/catapult.git/+log/4c54c5ccdebd..eb73833a2935 git log 4c54c5ccdebd..eb73833a2935 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 dberris@chromium.org Use autoscaling and smaller instances Created with: gclient setdep -r src/third_party/catapult@eb73833a2935 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917914 TBR=sullivan@chromium.org Change-Id: I84b8c76337089375a1e1216b32aae53c80af3119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516408 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639830} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e2b207d9e9eefc7130adfd5445836e0fe249e9b8 Author: Eric Robinson <ericrobinson@google.com> Date: Tue Mar 12 05:32:39 2019 +0000 Reset FrameScheduler::task_time_ on DidCommitProvisionalLoad. Because the FrameScheduler for the main frame can be reused on navigate, we need to reset it when a load is initially committed. The subframes schedulers are kept and only reset when the main frame renavigates (when they go out of scope). Bug: 937298 Change-Id: Ie55c74bdb537198d53aa8de686f1aa0fbaf93b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499776 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#639829} .../blink/renderer/core/loader/document_loader.cc | 8 ++- .../scheduler/main_thread/frame_scheduler_impl.cc | 11 ++-- .../scheduler/main_thread/frame_scheduler_impl.h | 3 +- .../main_thread/frame_scheduler_impl_unittest.cc | 75 ++++++++++++++++++++-- .../platform/scheduler/public/frame_scheduler.h | 9 ++- .../platform/scheduler/test/fake_frame_scheduler.h | 6 +- .../test/renderer_scheduler_test_support.cc | 3 +- 7 files changed, 94 insertions(+), 21 deletions(-) commit 49ec914319f97d2ef015c487108d67d21fa05a49 Author: wutao <wutao@chromium.org> Date: Tue Mar 12 05:23:47 2019 +0000 app_list: Not recreate app_list layer in tablet mode This patch skips recreating layers in AppListTabletModeContainer, otherwise the mask layer will be removed. Bug: 924624, 940229 Test: manual Change-Id: I8511c5ffd83fa007cd655a1c8a6ee2256a33598a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513106 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#639828} ash/assistant/assistant_screen_context_controller.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 4e7cf3c9f332d98f912667ef0292d2da814a8d96 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 05:21:46 2019 +0000 Roll src/third_party/chromite 54010f6d8750..96053d06c97b (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/54010f6d8750..96053d06c97b git log 54010f6d8750..96053d06c97b --date=short --no-merges --format='%ad %ae %s' 2019-03-12 moragues@google.com Atlas: Remove Atlas from skylab for now Created with: gclient setdep -r src/third_party/chromite@96053d06c97b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ia666c58f4a9445830508eb3294acc8a817ca99e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516409 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639827} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3fd0d3c25ab5643c6350a5a64fc3d027831eea21 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 12 05:20:27 2019 +0000 Import wpt@dbabf5e0feee6f58cb92a39895d0fefbefdf3d73 Using wpt-import in Chromium 1c64fd91761d4150e4a50b04ab0dd4ffe13c3644. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" 3f8a3a514f "Portals: Make Portal a WebContentsDelegate" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I7764f3ede0d6b9ca997177faadc957230775ae42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517171 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639826} third_party/blink/web_tests/TestExpectations | 27 + .../web_tests/external/WPT_BASE_MANIFEST_5.json | 979 +++++++++++++++++++++ .../shaping/reference/shaping-000-ref.html | 25 + .../shaping/reference/shaping-001-ref.html | 28 + .../shaping/reference/shaping-002-ref.html | 28 + .../shaping/reference/shaping-003-ref.html | 28 + .../shaping/reference/shaping-004-ref.html | 28 + .../shaping/reference/shaping-005-ref.html | 28 + .../shaping/reference/shaping-006-ref.html | 30 + .../shaping/reference/shaping-007-ref.html | 28 + .../shaping/reference/shaping-008-ref.html | 28 + .../shaping/reference/shaping-009-ref.html | 27 + .../shaping/reference/shaping-010-ref.html | 27 + .../shaping/reference/shaping-011-ref.html | 27 + .../shaping/reference/shaping-012-ref.html | 28 + .../shaping/reference/shaping-013-ref.html | 28 + .../shaping/reference/shaping-014-ref.html | 26 + .../shaping/reference/shaping-015-ref.html | 27 + .../shaping/reference/shaping-016-ref.html | 27 + .../shaping/reference/shaping-017-ref.html | 28 + .../shaping/reference/shaping-018-ref.html | 28 + .../shaping/reference/shaping-020-ref.html | 26 + .../shaping/reference/shaping-021-ref.html | 26 + .../shaping/reference/shaping-022-ref.html | 26 + .../shaping/reference/shaping_cchar-000-ref.html | 25 + .../shaping/reference/shaping_cchar-001-ref.html | 27 + .../shaping/reference/shaping_cchar-002-ref.html | 27 + .../shaping/reference/shaping_cchar-003-ref.html | 27 + .../shaping/reference/shaping_cchar-004-ref.html | 27 + .../shaping/reference/shaping_cchar-005-ref.html | 27 + .../shaping/reference/shaping_cchar-006-ref.html | 27 + .../shaping/reference/shaping_cchar-007-ref.html | 27 + .../shaping/reference/shaping_cchar-008-ref.html | 27 + .../shaping/reference/shaping_cchar-009-ref.html | 27 + .../shaping/reference/shaping_cchar-010-ref.html | 27 + .../shaping/reference/shaping_cchar-011-ref.html | 27 + .../shaping/reference/shaping_lig-000-ref.html | 25 + .../wpt/css/css-text/shaping/shaping-000.html | 29 + .../wpt/css/css-text/shaping/shaping-001.html | 32 + .../wpt/css/css-text/shaping/shaping-002.html | 32 + .../wpt/css/css-text/shaping/shaping-003.html | 32 + .../wpt/css/css-text/shaping/shaping-004.html | 32 + .../wpt/css/css-text/shaping/shaping-005.html | 32 + .../wpt/css/css-text/shaping/shaping-006.html | 34 + .../wpt/css/css-text/shaping/shaping-007.html | 32 + .../wpt/css/css-text/shaping/shaping-008.html | 32 + .../wpt/css/css-text/shaping/shaping-009.html | 31 + .../wpt/css/css-text/shaping/shaping-010.html | 31 + .../wpt/css/css-text/shaping/shaping-011.html | 31 + .../wpt/css/css-text/shaping/shaping-012.html | 32 + .../wpt/css/css-text/shaping/shaping-013.html | 32 + .../wpt/css/css-text/shaping/shaping-014.html | 31 + .../wpt/css/css-text/shaping/shaping-015.html | 31 + .../wpt/css/css-text/shaping/shaping-016.html | 31 + .../wpt/css/css-text/shaping/shaping-017.html | 32 + .../wpt/css/css-text/shaping/shaping-018.html | 32 + .../wpt/css/css-text/shaping/shaping-020.html | 30 + .../wpt/css/css-text/shaping/shaping-021.html | 30 + .../wpt/css/css-text/shaping/shaping-022.html | 30 + .../wpt/css/css-text/shaping/shaping-023.html | 30 + .../wpt/css/css-text/shaping/shaping-024.html | 30 + .../wpt/css/css-text/shaping/shaping-025.html | 30 + .../css/css-text/shaping/shaping_cchar-000.html | 29 + .../css/css-text/shaping/shaping_cchar-001.html | 31 + .../css/css-text/shaping/shaping_cchar-002.html | 31 + .../css/css-text/shaping/shaping_cchar-003.html | 31 + .../css/css-text/shaping/shaping_cchar-004.html | 31 + .../css/css-text/shaping/shaping_cchar-005.html | 31 + .../css/css-text/shaping/shaping_cchar-006.html | 31 + .../css/css-text/shaping/shaping_cchar-007.html | 31 + .../css/css-text/shaping/shaping_cchar-008.html | 31 + .../css/css-text/shaping/shaping_cchar-009.html | 31 + .../css/css-text/shaping/shaping_cchar-010.html | 31 + .../css/css-text/shaping/shaping_cchar-011.html | 31 + .../wpt/css/css-text/shaping/shaping_lig-000.html | 29 + 75 files changed, 3135 insertions(+) commit a0c45835c270fb321d84c445a6b55bbecf8ecbb5 Author: Darwin Huang <huangdarwin@chromium.org> Date: Tue Mar 12 05:18:22 2019 +0000 Async Clipboard: Add DOMException for failed blob read. Failure in the FileReaderLoaderClient was handled but did not have a DOMException and description attached. Add this description. Change-Id: I88dca0a4abbb0c25942f540adf2e22082373382b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516720 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#639825} third_party/blink/renderer/modules/clipboard/clipboard_promise.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 6e17ab4916fbbe43806300bd716df18c69cbefd0 Author: Yuzu Saijo <yuzus@chromium.org> Date: Tue Mar 12 05:16:43 2019 +0000 Fix ReducedMemoryUsage for OomIntervention Currently ReducedMemoryUsage metrics in OomIntervention reports negative numbers when intervention reduces memory. This is confusing and thus this CL renames the metrics. Bug: 939702 Change-Id: I5bd7e8ba4d7ffb682ea4565a39964cce74b84c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510704 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639824} .../renderer/controller/oom_intervention_impl.cc | 16 +-- .../controller/oom_intervention_impl_test.cc | 15 +-- tools/metrics/histograms/histograms.xml | 114 ++++++++++++++++++--- 3 files changed, 118 insertions(+), 27 deletions(-) commit 81b865a087583b6d0ac5173e2c84d78b0afcdc80 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Mar 12 05:15:43 2019 +0000 Disable test that's flaky on ChromeOS TBR=sky@chromium.org Bug: 940687 Change-Id: Icc194da881656efdc1884a56c218b2060d76ebf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516915 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#639823} chrome/browser/chrome_browser_main_browsertest.cc | 9 ++++++++- .../chromeos/network_change_manager_client_browsertest.cc | 3 ++- 2 files changed, 10 insertions(+), 2 deletions(-) commit b3e2a6c7eab681f720402f6f281df7a85bd407ae Author: Maggie Cai <mxcai@chromium.org> Date: Tue Mar 12 05:12:54 2019 +0000 Add flag for desktop intent picker. This CL adds a feature flag for enabling intent picker in desktop platforms. BUG=939205 Change-Id: I17658f88e5417596f0715787b29d1ce71ac4b59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514340 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#639822} chrome/browser/about_flags.cc | 6 ++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 5 +++++ chrome/browser/flag_descriptions.h | 3 +++ chrome/common/chrome_features.cc | 12 ++++++++++++ chrome/common/chrome_features.h | 5 +++++ tools/metrics/histograms/enums.xml | 2 ++ 7 files changed, 38 insertions(+) commit e4094ac367690fcee975fd340603c98523392c3c Author: Austin Eng <enga@chromium.org> Date: Tue Mar 12 05:11:42 2019 +0000 Implement minimal WebGPU functions to test fences This patch gets some fence tests working to check that commands are properly sent between the WebGPUImplementation and WebGPUDecoder. Bug: 877147 Change-Id: I4387ba4d802b3312d4570c346744685e54a0baf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481618 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#639821} gpu/BUILD.gn | 11 +- gpu/command_buffer/client/webgpu_implementation.cc | 21 ++++ gpu/command_buffer/client/webgpu_implementation.h | 5 + .../client/webgpu_implementation_unittest.cc | 1 + gpu/command_buffer/client/webgpu_interface.h | 6 ++ gpu/command_buffer/tests/webgpu_fence_unittest.cc | 113 +++++++++++++++++++++ gpu/command_buffer/tests/webgpu_test.cc | 61 +++++++++++ gpu/command_buffer/tests/webgpu_test.h | 51 ++++++++++ gpu/ipc/webgpu_in_process_context.cc | 4 + gpu/ipc/webgpu_in_process_context.h | 1 + third_party/blink/renderer/modules/webgpu/BUILD.gn | 3 + 11 files changed, 276 insertions(+), 1 deletion(-) commit 8d044efee4fbefd86d6a8f6c1d3eaec542ad16e4 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Mar 12 05:08:03 2019 +0000 NetS13nSW: Remove old path around timers Bug: 852658, 926114 Change-Id: I57f0b0c743ce82e59c654bfa876792a882847019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511172 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639820} .../service_worker_data_pipe_reader.cc | 8 --- .../service_worker_data_pipe_reader.h | 3 -- .../service_worker_data_pipe_reader_unittest.cc | 22 +------- .../service_worker_navigation_loader.cc | 7 +-- .../service_worker_navigation_loader_unittest.cc | 2 - .../service_worker_url_request_job.cc | 4 +- .../service_worker/service_worker_version.cc | 47 +---------------- .../service_worker/service_worker_version.h | 12 ----- .../service_worker_version_unittest.cc | 54 -------------------- .../service_worker_context_client.cc | 2 - .../service_worker/service_worker_timeout_timer.cc | 10 ---- .../service_worker/service_worker_timeout_timer.h | 4 -- .../service_worker_timeout_timer_unittest.cc | 59 ---------------------- 13 files changed, 6 insertions(+), 228 deletions(-) commit 88101c09a6f140be7939b6010cbc1a2d3676b7f2 Author: Xiaohui Chen <xiaohuic@google.com> Date: Tue Mar 12 04:50:34 2019 +0000 applist: show assistant on top in tablet mode. Bug: 937132 Test: locally run, manual test Change-Id: I4c0821939b5a52862eca3d9cd2d9b3c203f78262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504167 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#639819} ash/app_list/app_list_controller_impl.cc | 54 ++++++++++++++++++++-- ash/app_list/app_list_controller_impl.h | 4 ++ ash/app_list/app_list_presenter_delegate_impl.cc | 18 ++++++++ ash/app_list/views/app_list_view.cc | 12 +---- .../views/assistant/assistant_main_view.cc | 22 +++++++-- ash/app_list/views/assistant/assistant_main_view.h | 7 +++ .../views/assistant/assistant_page_view.cc | 54 +++++++++++++--------- ash/app_list/views/assistant/assistant_page_view.h | 10 +--- ash/home_screen/home_launcher_gesture_handler.cc | 18 ++++++-- ash/home_screen/home_screen_delegate.h | 4 ++ 10 files changed, 151 insertions(+), 52 deletions(-) commit f1a1910481e51d60d722d72290d55220446afcad Author: Jay Harris <harrisjay@chromium.org> Date: Tue Mar 12 04:48:42 2019 +0000 Updates the CustomTabBar to display the origin instead of the full url. This also changes the url to elide from the head, for security reasons. It uncovered a bug where the interior margins of the layout manager were not being taken into account when calculating the preferred size, resulting in an incorrect elision. Bug: 939129 Change-Id: Ib75d3b4d397c32fdc282de0a60af2fb48c01e415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506673 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#639818} chrome/browser/ui/views/location_bar/OWNERS | 2 +- .../ui/views/location_bar/custom_tab_bar_view.cc | 15 +++++---- .../ui/views/location_bar/custom_tab_bar_view.h | 6 ++++ .../custom_tab_bar_view_browsertest.cc | 38 +++++----------------- 4 files changed, 24 insertions(+), 37 deletions(-) commit b2928f372e516c4c74977b01d20647033f464803 Author: Ken Rockot <rockot@chromium.org> Date: Tue Mar 12 04:43:03 2019 +0000 Eliminate Content's use of ServiceFactory Content sort of repurposed Service Manager's ServiceFactory interface to push service launching requests into child processes. ServiceFactory is going away to simplify Service Manager APIs, so this CL moves the child process "run a service" request into a new message on the existing content.mojom.ChildControl interface held by all ChildProcessHosts. Most of the CL is plumbing calls from process hosts down to their child threads. This also finally eliminates content::ServiceFactory which has over time diminished into a pretty useless base class for UtilityServiceFactory and GpuServiceFactory. Bug: 925860 Change-Id: I451de1f6e69f36a7fcacc4712aee67a8aca569d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512786 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#639817} components/viz/host/DEPS | 1 + components/viz/host/gpu_host_impl.cc | 6 +++ components/viz/host/gpu_host_impl.h | 8 ++++ content/browser/gpu/gpu_process_host.cc | 6 +++ content/browser/gpu/gpu_process_host.h | 3 ++ .../service_manager/service_manager_context.cc | 22 ++++------- content/browser/utility_process_host.cc | 6 +++ content/browser/utility_process_host.h | 8 ++++ content/child/BUILD.gn | 2 - content/child/child_thread_impl.cc | 6 +++ content/child/child_thread_impl.h | 4 ++ content/child/service_factory.cc | 39 -------------------- content/child/service_factory.h | 43 ---------------------- content/common/child_control.mojom | 12 +++++- content/common/child_process_host_impl.cc | 6 +++ content/common/child_process_host_impl.h | 3 ++ content/gpu/gpu_child_thread.cc | 38 +++++++++++++------ content/gpu/gpu_child_thread.h | 29 ++++++++++----- content/gpu/gpu_service_factory.cc | 11 +++--- content/gpu/gpu_service_factory.h | 13 +++---- content/public/common/child_process_host.h | 9 +++++ content/utility/utility_service_factory.cc | 41 +++++++++++---------- content/utility/utility_service_factory.h | 18 ++++----- content/utility/utility_thread_impl.cc | 12 ++---- content/utility/utility_thread_impl.h | 16 ++------ services/ws/gpu_host/gpu_host.cc | 6 +++ services/ws/gpu_host/gpu_host.h | 3 ++ 27 files changed, 185 insertions(+), 186 deletions(-) commit fc8260180684217176cedcb9ec7b16763db1611d Author: Austin Eng <enga@chromium.org> Date: Tue Mar 12 04:34:48 2019 +0000 Connect WebGPUImplementation to Dawn WireClient interfaces This patch implements the dawn_wire::CommandSerializer interface for the WebGPUImplementation so it can use the wire to serialize commands into a transfer buffer. The transfer buffer is sent to the WebGPUDecoder by sending a DawnCommands command. The WebGPUImplementation receives and handles the return command stream by forwarding GpuControlClient::OnGpuControlReturnData to WireClient::HandleCommands. Bug: 877147 Change-Id: I95dd243d248c2b24b4098f9a407c012acba0c165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481617 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#639816} gpu/command_buffer/client/BUILD.gn | 3 + gpu/command_buffer/client/webgpu_implementation.cc | 80 ++++++++++++++++++++-- gpu/command_buffer/client/webgpu_implementation.h | 28 +++++++- 3 files changed, 105 insertions(+), 6 deletions(-) commit 7d74603acc17e17f8eb37151de6b5afeabf4ae5d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 04:20:21 2019 +0000 Roll src/third_party/chromite 9c082a6bae75..54010f6d8750 (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c082a6bae75..54010f6d8750 git log 9c082a6bae75..54010f6d8750 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 moragues@google.com Atlas: Add factory branch 2019-03-12 moragues@google.com Atlas: Add Hardware Tests 2019-03-11 dgarrett@google.com chromeos_config: Remove deprecated branches. Created with: gclient setdep -r src/third_party/chromite@54010f6d8750 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I0b00358569e91a14863f6fa430c1a14857883344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515909 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639815} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b60f3da9565b2ca3244d1c43045befe5a223b5d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 04:17:18 2019 +0000 Roll AFDO from 74.0.3729.5_rc-r1-merged to 74.0.3729.6_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I82e2a5fcaf7f84396366a2acc9c0a9e54b6b2d2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516407 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639814} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 991fa805de2331c3a90ea824742c240cac1962c2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 04:14:42 2019 +0000 Roll src/third_party/perfetto 139c7cac4999..28f71e89e3ee (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/139c7cac4999..28f71e89e3ee git log 139c7cac4999..28f71e89e3ee --date=short --no-merges --format='%ad %ae %s' 2019-03-12 lalitm@google.com Merge "perfetto: refactor span join to prepare for left join" Created with: gclient setdep -r src/third_party/perfetto@28f71e89e3ee The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I53e890f1ebb50215ab997fa2c8737b7798c80e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516743 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639813} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1f1406884df6564c2e11b501e89ce4319588d7c4 Author: Alex Lau <alexlau@chromium.org> Date: Tue Mar 12 04:13:34 2019 +0000 Add libvda D-Bus service. This creates a D-Bus service which will allow libvda (go/libvda) to establish a pipe to the mojom::VideoAcceleratorFactory interface. CrOS changes: crosreview.com/1469082 Bug: b/123326297 Test: libvda connects and has working bindings to mojom::VideoAcceleratorFactory. Change-Id: I8cf3298da1d22a90d182536184e4819a2c47892d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478669 Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Alex Lau <alexlau@chromium.org> Cr-Commit-Position: refs/heads/master@{#639812} chrome/browser/chromeos/BUILD.gn | 3 + .../chromeos/chrome_browser_main_chromeos.cc | 11 ++++ .../chromeos/dbus/libvda_service_provider.cc | 77 ++++++++++++++++++++++ .../chromeos/dbus/libvda_service_provider.h | 61 +++++++++++++++++ .../chromeos/dbus/org.chromium.LibvdaService.conf | 23 +++++++ 5 files changed, 175 insertions(+) commit 0b4d00c954cf3a8e811e34577926ddfded757bf4 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Mar 12 04:09:02 2019 +0000 Enable accessibility labels feature on trunk This feature, known publicly as "Get Image Descriptions from Google", is feature-complete in M74 and we intend to do a beta experiment there, as indicated in the launch bug. The next step in that process is to enable it on trunk in M75. Bug: 905419, 929734 Change-Id: I3bcc74a6c06be2b72fa198d017e6e418e57e6e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513451 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#639811} chrome/browser/accessibility/accessibility_labels_service.cc | 6 ++++++ chrome/browser/accessibility/accessibility_state_utils.cc | 3 ++- .../accessibility/dump_accessibility_browsertest_base.cc | 12 ++++++++++++ .../accessibility/dump_accessibility_browsertest_base.h | 4 ++++ content/public/common/content_features.cc | 5 +++-- 5 files changed, 27 insertions(+), 3 deletions(-) commit eeb34d18c9bdac25d072bbd951a2cb5c0e99c00a Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Mar 12 04:08:41 2019 +0000 ServiceWorker: Add CSP tests for eval() on ServiceWorkerGlobalScope This CL adds WPTs to make sure eval() on ServiceWorkerGlobalScope is disallowed when `default-src` and `script-src` CSP directives are specified without `unsafe-eval` keyword. These tests are failing when off-the-main-thread worker script fetch is enabled or the installed script manager is used because of https://crbug.com/940316 Bug: 937168, 940316 Change-Id: I7b02519a15aeb14c21e0b26dfad3d84014f572df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514285 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#639810} .../resources/service-worker-csp-worker.py | 30 ++++++++++++++++++++ ...m-installed-service-worker-default-expected.txt | 8 ++++++ ...om-installed-service-worker-script-expected.txt | 8 ++++++ .../resources/fetch-with-csp-worker.php | 32 +++++++++++++++++++++- .../service-worker-csp-default.https-expected.txt | 8 ++++++ .../service-worker-csp-script.https-expected.txt | 8 ++++++ 6 files changed, 93 insertions(+), 1 deletion(-) commit c5aa69096c1fb5b4f352f3a8958549b1df60a1e2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 04:06:42 2019 +0000 Roll src/third_party/swiftshader 654540e86243..3364227fa0d8 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/654540e86243..3364227fa0d8 git log 654540e86243..3364227fa0d8 --date=short --no-merges --format='%ad %ae %s' 2019-03-11 sugoi@google.com Allow the Blitter to clear and blit vk::Image objects directly Created with: gclient setdep -r src/third_party/swiftshader@3364227fa0d8 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ibd7cae91ddaab6d4874abd11a7a64e9575cb1162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516420 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639809} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c2a17448ec3e0a707b01a34f295496996c649dc6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 04:05:33 2019 +0000 Roll src/third_party/depot_tools 8220b123a125..112a77f4bfed (5 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8220b123a125..112a77f4bfed git log 8220b123a125..112a77f4bfed --date=short --no-merges --format='%ad %ae %s' 2019-03-12 dpranke@chromium.org Make sys a top-level import in gclient_paths. 2019-03-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-12 ljusten@chromium.org my_activity.py: Add date to format 2019-03-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@112a77f4bfed The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:939959,chromium:None TBR=agable@chromium.org Change-Id: I961fa2a6d23919c0c28d2c312cf1c7b29c9bf327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516364 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639808} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 33181fad0fca0539d49fe759b4eda25e49f5033a Author: Matt Reynolds <mattreynolds@google.com> Date: Tue Mar 12 04:02:38 2019 +0000 Preserve haptic actuator internal state GamepadHapticActuator contains internal state that must be preserved when the GamepadList buffers are swapped. Previously, a new actuator instance would be created each time the buffer was swapped, causing the internal state to be lost. This could allow vibration effects to stop unexpectedly or be reported as "preempted" even when no other effect was sent to the gamepad. This CL modifies the buffer swapping logic to ensure both buffers retain a reference to the same GamepadHapticActuator instance. BUG=939061 Change-Id: Ife6659c9cad75585ba7a8c7eddb3aa9e11eeb29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506812 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#639807} .../blink/renderer/modules/gamepad/gamepad.cc | 35 +++++++++------ .../blink/renderer/modules/gamepad/gamepad.h | 39 ++++++++++++++++- .../renderer/modules/gamepad/navigator_gamepad.cc | 44 +++++++++++++++---- .../renderer/modules/gamepad/navigator_gamepad.h | 1 + .../blink/web_tests/gamepad/gamepad-vibration.html | 50 ++++++++++++++++++++++ 5 files changed, 147 insertions(+), 22 deletions(-) commit f9d645ab70bbd54a79e226bff415e6f374cb5248 Author: Wei-Han Chen <stimim@google.com> Date: Tue Mar 12 03:54:29 2019 +0000 Added support for new HWIDv3 format in HWID-checker. There is an extension to HWIDv3, which breaks current hwid_checker. Added more logic to HWID-checker to support that. Also refactor the code to make it more clear on each step. BUG=None TEST=run unit_tests Change-Id: Iec58664d5a42edb917a918dde021456b38d96b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514351 Commit-Queue: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#639806} chrome/browser/chromeos/login/hwid_checker.cc | 48 ++++++++++++++++++++-- .../chromeos/login/hwid_checker_unittest.cc | 7 ++++ 2 files changed, 51 insertions(+), 4 deletions(-) commit 36cdaf3da82467b851b33beb08016ae921e05767 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 03:48:23 2019 +0000 Roll src/third_party/angle 49c9dfe3b832..0f34f3f2f785 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/49c9dfe3b832..0f34f3f2f785 git log 49c9dfe3b832..0f34f3f2f785 --date=short --no-merges --format='%ad %ae %s' 2019-03-11 jmadill@chromium.org Use auto_script in run_code_generation. 2019-03-11 jonahr@google.com Reland "Fix unit test for setting locale creating malformed HLSL shader code Created with: gclient setdep -r src/third_party/angle@0f34f3f2f785 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I446503c77b6afb239a11f15cc425ad569741bd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515908 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639805} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d4ee8e8599f07de1e04ceef51bfda0dc6d476473 Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Tue Mar 12 03:43:24 2019 +0000 Revert "Fix SSL committed interstitials bugs when interacting with other CI." This reverts commit 94a6b7122ec29834903977e3df1b7efcf15a0cc6. Reason for revert: Causes CaptivePortal browser tests to fail on non_network_service_browser_tests https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11306 [2373:2373:0311/193039.746186:FATAL:cert_status_flags.cc(103)] Check failed: false. #0 0x7f3a3fba0851 base::debug::CollectStackTrace() #1 0x7f3a3fa01f8d base::debug::StackTrace::StackTrace() #2 0x7f3a3fa01f45 base::debug::StackTrace::StackTrace() #3 0x7f3a3fa3da17 logging::LogMessage::~LogMessage() #4 0x7f3a3ec695f8 net::MapCertStatusToNetError() #5 0x55c7467624ea SSLErrorNavigationThrottle::QueueShowInterstitial() #6 0x55c74676244d SSLErrorNavigationThrottle::WillFailRequest() #7 0x7f3a384b7d20 content::(anonymous namespace)::ExecuteNavigationEvent() #8 0x7f3a384b71f8 content::NavigationThrottleRunner::ProcessInternal() #9 0x7f3a384b6f67 content::NavigationThrottleRunner::ProcessNavigationEvent() #10 0x7f3a384a00b7 content::NavigationHandleImpl::WillFailRequest() #11 0x7f3a384ad0c2 content::NavigationRequest::OnRequestFailedInternal() #12 0x7f3a384b230b content::NavigationRequest::OnRequestFailed() #13 0x7f3a3862da3d content::NavigationURLLoaderImpl::OnComplete() #14 0x7f3a37fa7257 base::internal::FunctorTraits<>::Invoke<>() Original change's description: > Fix SSL committed interstitials bugs when interacting with other CI. > > The following bugs appeared when SB interstitials were being converted > to committed interstitials: > > -SSLErrorNavigationThrottle will not respect the cert whitelist when > WillFailRequest is triggered by other interstitials. This CL adds a > check. > > -DidStartResourceResponse is called on SSLManager on all network > errors, which are treated as valid SSL by the manager and cause cert > exceptions to be cleared, this also happened prior to CI, but became > obvious with Safe Browsing tests. This CL fixes this by only calling > DidStartResourceResponse on net::OK. > > Bug: 869894 > Change-Id: Ia1ce4a3130bf03ef7686ff2149a9ed49fb20c81b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504052 > Commit-Queue: Carlos IL <carlosil@chromium.org> > Reviewed-by: Emily Stark <estark@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639748} TBR=jam@chromium.org,estark@chromium.org,carlosil@chromium.org Change-Id: I4b16aa2ad17994953ca5fc0c0ca0e4aea1d03d4f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517312 Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#639804} chrome/browser/ssl/ssl_browsertest.cc | 30 ---------------------- .../browser/ssl/ssl_error_navigation_throttle.cc | 11 ++++---- .../ssl/ssl_error_navigation_throttle_unittest.cc | 28 +++++++++++++++----- content/browser/web_contents/web_contents_impl.cc | 8 +----- 4 files changed, 28 insertions(+), 49 deletions(-) commit b5d871e3ccc8f34c59c0b05b84e06441d38708dc Author: John Lee <johntlee@chromium.org> Date: Tue Mar 12 03:30:18 2019 +0000 Navi: Announce background being reset when skipping Bug: 938084 Change-Id: Ibf6ef15c780904b7e851f23064ab457042a97804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516778 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#639803} chrome/app/onboarding_welcome_strings.grdp | 3 +++ .../welcome/onboarding_welcome/ntp_background/nux_ntp_background.js | 4 ++++ chrome/browser/ui/webui/welcome/welcome_ui.cc | 1 + 3 files changed, 8 insertions(+) commit 9a08a5e480434999d3cfa852b35c45aae1ea9b48 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 12 03:24:41 2019 +0000 Update V8 to version 7.5.16. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/844fc6c8..4e74864a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03d3bd1ca6354e0d32fa80a2dbc0b3d46716441e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516885 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639802} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1c1e7344e80970df115abada528f8a105c4c1cf3 Author: Dan Beam <dbeam@chromium.org> Date: Tue Mar 12 03:24:38 2019 +0000 WebUI Dark Mode: update DICE version of welcome page Screenshot: https://imgur.com/a/4uB4iIq R=hcarmona@chromium.org BUG=940760 Change-Id: Ie6a970a2dda1d7014eaa8a6f8997f8cd0b5208d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517094 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#639801} chrome/browser/resources/welcome/dice_welcome/welcome.css | 9 +++++++++ chrome/browser/resources/welcome/dice_welcome/welcome.html | 6 +++++- chrome/browser/resources/welcome/dice_welcome/welcome_app.html | 6 +++++- 3 files changed, 19 insertions(+), 2 deletions(-) commit 0affa8b6ed7ed7e11cc5d1154c5c6989252df1cd Author: Joey Arhar <jarhar@chromium.org> Date: Tue Mar 12 03:20:50 2019 +0000 [DevTools] Increase network summary bar tooltip precision Bug: 939574 Change-Id: I72779a526ba43e26eeb198ae5bd60f6e24a5b15f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509900 Reviewed-by: Joel Einbinder <einbinder@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#639800} .../devtools/front_end/network/NetworkLogView.js | 75 +++++++++++++--------- .../devtools/front_end/network/NetworkOverview.js | 4 +- .../front_end/network/binaryResourceView.css | 1 - .../devtools/front_end/network/networkLogView.css | 16 ++--- 4 files changed, 51 insertions(+), 45 deletions(-) commit 917b074c60aa24bd3b8716c92791c89e8796731a Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 12 03:18:49 2019 +0000 Disable failing tests on Linux GPU FYI Exp Intel 630 and TSAN bots The following tests are being disabled on the experimental Intel 630 bot: 1) angle_end2end_tests since the failures are numerous to exclude individually. 2) tab_capture_end2end_tests since the test suite consists of 2 tests and one of them fails. 3) vulkan_content_browsertests since the test suite consists of 3 tests and all fail. vulkan_content_browsertests also flakes on Linux FYI GPU TSAN Release and is being disabled there as well. Bug: 940750, 927465, 940723 Change-Id: I6c95b04c5804887b0c5ec45e66cb11172660026c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517036 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#639799} testing/buildbot/chromium.gpu.fyi.json | 107 ----------------------------- testing/buildbot/test_suite_exceptions.pyl | 12 ++++ 2 files changed, 12 insertions(+), 107 deletions(-) commit 76ddc7025d32ef37d43ff1c9e841b183f9082687 Author: Livvie Lin <livvielin@chromium.org> Date: Tue Mar 12 03:18:15 2019 +0000 Update security summary text for non cert error pages Screenshot: https://drive.google.com/file/d/1qnsNZOToBx--6r_a-3uFbWOd96_EKHF3/view?usp=sharing Bug: 504499 Change-Id: I9c8c730c7c9ca768753d2683b1960220ddc91cc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474535 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#639798} components/security_state/content/content_utils.cc | 22 ++++++++++----- .../content/content_utils_unittest.cc | 31 ++++++++++++++++++++++ components/security_state/core/security_state.cc | 16 ++++++++--- components/security_state/core/security_state.h | 3 +++ .../security_state/core/security_state_unittest.cc | 16 +++++++++++ components/security_state_strings.grdp | 3 +++ 6 files changed, 81 insertions(+), 10 deletions(-) commit 09c91b30d8fb6b5c7c6d725be88aa1eb4ced9e36 Author: Bryan McQuade <bmcquade@chromium.org> Date: Tue Mar 12 03:17:43 2019 +0000 Record layout stability metric for AMP subframes. UKM collection review: https://docs.google.com/document/d/1rgvVN-Sl1grQXQDukd0WZGTqdXlTo6VEesLi1WaDWyY/edit Change-Id: Id35f14bbedc03bc87cd3fc427e83ac95f2780992 Bug: 939469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509368 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#639797} .../observers/amp_page_load_metrics_observer.cc | 44 ++++++++++++++++++++++ .../observers/amp_page_load_metrics_observer.h | 7 +++- .../amp_page_load_metrics_observer_unittest.cc | 35 +++++++++++++++++ .../page_load_metrics_observer_test_harness.cc | 6 +++ .../page_load_metrics_observer_test_harness.h | 2 + .../observers/page_load_metrics_observer_tester.cc | 15 ++++++-- .../observers/page_load_metrics_observer_tester.h | 2 + .../page_load_metrics/page_load_metrics_observer.h | 8 ++++ .../page_load_metrics_update_dispatcher.cc | 8 +++- .../page_load_metrics_update_dispatcher.h | 5 +++ .../browser/page_load_metrics/page_load_tracker.cc | 10 +++++ .../browser/page_load_metrics/page_load_tracker.h | 3 ++ tools/metrics/histograms/histograms.xml | 24 ++++++++++++ tools/metrics/ukm/ukm.xml | 6 +++ 14 files changed, 169 insertions(+), 6 deletions(-) commit a278d7ba3e64b862cfbad51f50533c4d6cb84535 Author: Dan Beam <dbeam@chromium.org> Date: Tue Mar 12 03:14:43 2019 +0000 WebUI Dark Mode: increase contrast for search results - Make search bubbles fully opaque (previously 0.9 opacity) - Specify the color within search bubbles and highlights (previously inherited) - Fixed no search results message color Screenshots: https://imgur.com/a/bKMGowO R=dpapad@chromium.org BUG=939708 Change-Id: Id21e386c8fe5af153b73b6195c47e11b3187b4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513079 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#639796} chrome/browser/resources/settings/settings_main/settings_main.html | 2 +- ui/webui/resources/cr_elements/search_highlight_style_css.html | 4 ++-- ui/webui/resources/js/search_highlight_utils.js | 5 +++-- 3 files changed, 6 insertions(+), 5 deletions(-) commit be11512c9ef21ae27f99e1654a69a50d48767a81 Author: Ian Prest <iapres@microsoft.com> Date: Tue Mar 12 03:14:27 2019 +0000 UIA: Fire UIA_SystemAlertEventId event 1. Fire the UIA version of the system-alert event in the same place the MSAA event was fired. 2. In `AXEventGenerator`, fire Event::ALERT for role="alertdialog". -- Note: this will affect all platforms. 3. Updated the `AddAlert` test to test some additional scenarios, and enabled it for the UIA test pass. 4. Enhance the `AccessibilityEventRecorderUia` class to listen to all UIA "automation" events. -- New utility function `UiaIdentifierToString` to get strings for UIA identifiers. -- Also fixed a missing AddRef after calling CComObject::CreateInstance 5. Tests were hanging with the addition of the new event listeners. -- Per MSDN documentation, all UIA calls had to be moved to a thread using the MTA model to prevent the hangs. -- This exposed a Windows bug where in-proc off-thread events are received twice. The event-recorder was modified to discard the duplicate events. 6. Refactored the base EventTest classes to fire a new event 'kEndOfTest' instead of 'kHover' to mark the end of the test. 7. Removed unnecessary noise ("UIA_", "EventId") in the expectation files for UIA event tests. Bug: 928949 Change-Id: I5b3fea613ef174df4e708aa871088a876c7ddd3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484824 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#639795} .../automation_internal/automation_internal_api.cc | 1 + chrome/common/extensions/api/automation.idl | 4 +- .../extensions/automation_ax_tree_wrapper.cc | 3 + .../automation_internal/automation_internal_api.cc | 1 + chromecast/common/extensions_api/automation.idl | 4 +- .../extensions/automation_ax_tree_wrapper.cc | 3 + .../accessibility/accessibility_event_recorder.h | 3 + .../accessibility_event_recorder_uia_win.cc | 229 ++++++++++++++++++--- .../accessibility_event_recorder_uia_win.h | 117 ++++++++--- .../accessibility_tree_formatter_utils_win.cc | 220 ++++++++++++++++++++ .../accessibility_tree_formatter_utils_win.h | 2 + .../accessibility/browser_accessibility_manager.cc | 9 + .../accessibility/browser_accessibility_manager.h | 1 + .../browser_accessibility_manager_win.cc | 17 ++ .../browser_accessibility_manager_win.h | 8 + .../dump_accessibility_events_browsertest.cc | 8 +- .../accessibility/render_accessibility_impl.cc | 3 + .../accessibility/event/add-alert-expected-mac.txt | 8 +- .../event/add-alert-expected-win-uia.txt | 3 + .../accessibility/event/add-alert-expected-win.txt | 4 +- .../test/data/accessibility/event/add-alert.html | 10 +- .../aria-combo-box-collapse-expected-win-uia.txt | 2 +- ...a-combo-box-delay-add-list-expected-win-uia.txt | 2 +- .../aria-combo-box-expand-expected-win-uia.txt | 2 +- .../aria-combo-box-focus-expected-win-uia.txt | 2 +- .../event/aria-combo-box-next-expected-win-uia.txt | 2 +- .../event/listbox-focus-expected-win-uia.txt | 2 +- .../event/listbox-next-expected-win-uia.txt | 2 +- .../event/menulist-focus-expected-win-uia.txt | 2 +- ...ort-validity-invalid-field-expected-win-uia.txt | 2 +- .../event/report-validity-invalid-field.html | 2 +- .../event/tbody-focus-expected-win-uia.txt | 2 +- .../event/tfoot-focus-expected-win-uia.txt | 2 +- .../event/thead-focus-expected-win-uia.txt | 2 +- third_party/closure_compiler/externs/automation.js | 2 + ui/accessibility/ax_enum_util.cc | 8 + ui/accessibility/ax_enums.mojom | 4 + ui/accessibility/ax_event_generator.cc | 2 +- ui/accessibility/ax_node_data.cc | 1 + ui/accessibility/ax_role_properties.cc | 10 + ui/accessibility/ax_role_properties.h | 3 + 41 files changed, 632 insertions(+), 82 deletions(-) commit faee10b5954508ea5e04bd2e735a84966df80fe1 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Tue Mar 12 03:14:06 2019 +0000 Updating trunk VERSION from 3731.0 to 3732.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I8b52122e19c4058d2f032709cef1879cd1db35e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517042 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#639794} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0041bfb922faef8bfc5fa9d2acbe218aa99bc0f1 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue Mar 12 03:12:43 2019 +0000 Remove PreloadImageSrcSet runtime feature flag This has been enabled by default since M73. Bug: 813452 Change-Id: I11aeb25c1b53aab0e4089499d18640d3bf4e7c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514281 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#639793} content/child/runtime_features.cc | 4 ---- third_party/blink/public/platform/web_runtime_features.h | 1 - third_party/blink/renderer/core/html/html_link_element.idl | 4 ++-- third_party/blink/renderer/core/html/parser/html_preload_scanner.cc | 3 +-- third_party/blink/renderer/core/loader/preload_helper.cc | 3 +-- third_party/blink/renderer/platform/exported/web_runtime_features.cc | 4 ---- third_party/blink/renderer/platform/runtime_enabled_features.json5 | 4 ---- 7 files changed, 4 insertions(+), 19 deletions(-) commit 5e16ea2b276b93a88eb33fae64fba9e7743f88d4 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Mar 12 03:10:59 2019 +0000 Worker: Use WorkerOrWorkletGlobalScope::Name() as human readable name of main thread worklets This CL makes WorkerOrWorkletScriptController::Initialize() use WorkerOrWorkletGlobalScope::Name() as the human readable name of main thread worklets instead of taking it as an argument. This doesn't change functional behavior because main thread worklets pass Name() as the argument before this change. Change-Id: I84f7bb23c189b4eb131513a7568f56658d2c2c9d Bug: 866666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516117 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#639792} .../core/v8/worker_or_worklet_script_controller.cc | 14 +++++--------- .../bindings/core/v8/worker_or_worklet_script_controller.h | 8 ++++---- .../core/layout/custom/layout_worklet_global_scope.cc | 3 +-- .../core/loader/modulescript/module_script_loader_test.cc | 3 +-- third_party/blink/renderer/core/workers/worker_thread.cc | 3 +-- .../modules/csspaint/paint_worklet_global_scope.cc | 3 +-- 6 files changed, 13 insertions(+), 21 deletions(-) commit 0249dde0b56f55a1d72e8da115b8271bbab8dc4a Author: Tanya Gupta <tgupta@chromium.org> Date: Tue Mar 12 03:10:39 2019 +0000 Added functionality to dismiss & delete entries in the SendTabToSelf Client Service. Plumbed this logic into Android Notification code. Bug: 939027,935719,921767 Change-Id: I4df81e57faa10a53b9969814032c8864dc97f126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512663 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#639791} .../browser/send_tab_to_self/NotificationManager.java | 7 +++++-- .../send_tab_to_self/android_notification_handler.cc | 13 +++++++++++-- .../android/send_tab_to_self/android_notification_handler.h | 5 ++++- .../send_tab_to_self/desktop_notification_handler.cc | 10 ++++++---- .../browser/send_tab_to_self/desktop_notification_handler.h | 3 ++- chrome/browser/send_tab_to_self/receiving_ui_handler.h | 4 ++-- .../send_tab_to_self/send_tab_to_self_client_service.cc | 8 +++++--- .../send_tab_to_self/send_tab_to_self_client_service.h | 4 ++-- 8 files changed, 37 insertions(+), 17 deletions(-) commit 9b6f9ac907c8f10ad540c0c4e1c0588d29ad9e53 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Mar 12 03:06:08 2019 +0000 Worker: Rename Import{Classic,Module}Script() to FetchAndRun{Classic,Module}Script() This CL just renams Import{Classic,Module}Script() to FetchAndRun{Classic,Module}Script(). The motivations of this change are as follows: - "Import" sounds confusing with importScripts() and import(). - "Fetch" and "Run" match the spec words. This is the follow-up for the comment in the previous review: https://chromium-review.googlesource.com/c/chromium/src/+/1514350/5/third_party/blink/renderer/core/workers/worker_global_scope.h#159 Bug: 938219 Change-Id: I02c9566a0d2c3e8f9ddf0cbb5df5bcef855e9f7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514874 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#639790} .../renderer/core/exported/web_shared_worker_impl.cc | 6 +++--- .../core/workers/dedicated_worker_global_scope.cc | 8 ++++---- .../core/workers/dedicated_worker_global_scope.h | 8 ++++---- .../core/workers/dedicated_worker_messaging_proxy.cc | 6 +++--- .../core/workers/experimental/thread_pool_thread.cc | 4 ++-- .../renderer/core/workers/shared_worker_global_scope.cc | 8 ++++---- .../renderer/core/workers/shared_worker_global_scope.h | 8 ++++---- .../blink/renderer/core/workers/worker_global_scope.h | 4 ++-- third_party/blink/renderer/core/workers/worker_thread.cc | 16 ++++++++-------- third_party/blink/renderer/core/workers/worker_thread.h | 16 ++++++++-------- .../renderer/core/workers/worker_thread_test_helper.h | 4 ++-- .../modules/exported/web_embedded_worker_impl.cc | 14 +++++++------- .../service_worker/service_worker_global_scope.cc | 12 ++++++------ .../modules/service_worker/service_worker_global_scope.h | 8 ++++---- 14 files changed, 61 insertions(+), 61 deletions(-) commit c82ee788b375f61a55e09ea48402d2ec01506baf Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 12 03:05:08 2019 +0000 SuperSize: Fix symbol flags not being set for LLD map files E.g. FLAG_UNLIKELY, FLAG_HOT, FLAG_STARTUP Also: * Adds flag stats to DescribeSizeInfoCoverage() * Removes "symbol gap" logic from gold parser in favor of adding such logic for all sections: https://crbug.com/872796 Bug: 939219 Change-Id: Iafb0f196388dee53162aad8c71d09b0a1861af07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510764 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#639789} tools/binary_size/libsupersize/archive.py | 47 ++------- tools/binary_size/libsupersize/console.py | 15 ++- tools/binary_size/libsupersize/describe.py | 116 ++++++++++++--------- .../binary_size/libsupersize/linker_map_parser.py | 97 +++++++++++------ tools/binary_size/libsupersize/models.py | 9 +- .../libsupersize/testdata/Archive.golden | 59 +++++++---- .../libsupersize/testdata/Archive_Apk.golden | 72 +++++++------ .../libsupersize/testdata/Archive_Elf.golden | 64 ++++++++---- .../testdata/Archive_MinimalApks.golden | 72 +++++++------ .../testdata/Archive_OutputDirectory.golden | 61 +++++++---- .../libsupersize/testdata/Archive_Pak_Files.golden | 68 ++++++------ .../libsupersize/testdata/Console.golden | 4 +- .../libsupersize/testdata/FullDescription.golden | 64 ++++++++---- .../testdata/linker_map_parser/Parser.golden | 4 +- .../testdata/linker_map_parser/Tokenize.golden | 5 + .../testdata/linker_map_parser/test_lld-lto_v1.map | 13 +++ 16 files changed, 467 insertions(+), 303 deletions(-) commit bdc78eeb3bc64fd69ff79b0626bf65ce5ef69b4a Author: Anne Lim <annelim@google.com> Date: Tue Mar 12 02:56:46 2019 +0000 [Autofill] Move autofill-internald under subfolder Created subfolder for chrome://autofill-internals/, in an effort to clean up the chrome/browser/resources folder. Change-Id: I3b6283cd537f2acf44f1a14412b40b61228b9eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516722 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#639788} chrome/browser/browser_resources.grd | 2 +- .../browser/resources/{ => autofill_internals}/autofill_internals.html | 0 2 files changed, 1 insertion(+), 1 deletion(-) commit 950fa8208e4dce4a7ecc74fe3f37193c7042dbef Author: Sam McNally <sammc@chromium.org> Date: Tue Mar 12 02:53:52 2019 +0000 Start files app with #thumbnail-grid hidden. During the initial load, the files list and files grid are both visible. Tabbing through focusable items shows a focus ring around the files list, taking half the available space since it's sharing with the files grid. Avoid this by hiding the files grid during initial launch. Bug: 939301 Change-Id: I2552c5ad9037b2a48108b76d069d51ab9da53d12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516122 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#639787} ui/file_manager/file_manager/main.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 73c5a82773c0cff9d282e3e2273132b856a4de7e Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 12 02:48:32 2019 +0000 [Extensions Bindings] Remove the kNativeCrxBindings feature NativeCrxBindings have been enabled on stable channel since M72. Remove the feature flag, and update the sites that were using it. This CL: * Removes all references to the feature * Updates parameterized tests (typically making them un-parameterized, unless they were parameterized on multiple axes) * Removes else-blocks that are unreachable Follow-up CLs will remove JS-binding specific code, such as the unnecessary custom bindings files and the JSBindingsSystem concepts. Bug: 938998 Change-Id: Ic68cf9da3f52f22321f1b02b00a1ea98951aa540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507041 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#639786} .../incoming_native_messaging_apitest.cc | 26 +--- .../extensions/api/storage/settings_apitest.cc | 34 +---- .../extensions/api_binding_perf_browsertest.cc | 35 +---- .../browser/extensions/content_script_apitest.cc | 37 +---- .../error_console/error_console_browsertest.cc | 80 +++-------- chrome/browser/extensions/extension_apitest.cc | 7 +- .../extensions/extension_bindings_apitest.cc | 153 ++++++++------------ .../extensions/extension_messages_apitest.cc | 111 +++++---------- .../browser/extensions/native_bindings_apitest.cc | 10 -- .../browser/extensions/service_worker_apitest.cc | 158 ++++++--------------- .../extensions/service_worker_messaging_apitest.cc | 44 ++---- .../chrome_extensions_dispatcher_delegate.cc | 20 ++- .../cast_extensions_dispatcher_delegate.cc | 3 - extensions/common/extension_features.cc | 4 - extensions/common/extension_features.h | 1 - extensions/renderer/dispatcher.cc | 48 +++---- extensions/renderer/module_system.cc | 11 +- extensions/renderer/module_system.h | 4 - extensions/renderer/module_system_test.cc | 15 +- extensions/renderer/utils_unittest.cc | 13 -- testing/variations/fieldtrial_testing_config.json | 18 --- 21 files changed, 215 insertions(+), 617 deletions(-) commit bed01ed51656d49f73fdf1f82975583efc4e5bf4 Author: Michael Spang <spang@chromium.org> Date: Tue Mar 12 02:47:41 2019 +0000 Fix local_machine_junit_test_run.py with long build dirs Since 4281ef15ee48 ("Android: Fix flaky resource-related failures in media_router_junit_tests") running junit tests from build directories with long pathnames fails with "File name too long". Fix it by giving the extraction directories boring sequential names: resources0, resources1, etc. Bug: b/128026577 Change-Id: Iabd009b7d981471fa5b0b0866b55d8c213b877ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516878 Commit-Queue: Michael Spang <spang@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#639785} .../pylib/local/machine/local_machine_junit_test_run.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) commit 076657cfe6375a60ab58a641f0c903e6b6fe5c04 Author: Victor Vasiliev <vasilvv@chromium.org> Date: Tue Mar 12 02:46:43 2019 +0000 Replace QuicString with std::string R=rch@chromium.org Change-Id: Iac93b506b5ef2afce24aa0ce3e05c3983028eef0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516729 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#639784} .../bidirectional_stream_quic_impl_unittest.cc | 56 ++--- net/quic/mock_crypto_client_stream.cc | 4 +- net/quic/platform/impl/quic_file_utils_impl.h | 6 +- net/quic/platform/impl/quic_flags_impl.cc | 17 +- net/quic/platform/impl/quic_flags_impl.h | 8 +- net/quic/platform/impl/quic_flags_test.cc | 7 +- net/quic/platform/impl/quic_hostname_utils_impl.cc | 2 +- net/quic/platform/impl/quic_hostname_utils_impl.h | 2 +- .../platform/impl/quic_linux_socket_utils_test.cc | 4 +- net/quic/platform/impl/quic_socket_utils.cc | 2 +- net/quic/platform/impl/quic_string_utils_impl.h | 2 +- net/quic/platform/impl/quic_thread_impl.h | 2 +- net/quic/quic_chromium_client_stream_test.cc | 32 +-- net/quic/quic_http_stream_test.cc | 36 +-- net/quic/quic_network_transaction_unittest.cc | 217 ++++++++-------- net/quic/quic_proxy_client_socket_unittest.cc | 273 ++++++++++----------- net/quic/quic_stream_factory_test.cc | 4 +- 17 files changed, 326 insertions(+), 348 deletions(-) commit 0926c9c060e6b2723e9c37d4718d497eb7365921 Author: Stefan Zager <szager@chromium.org> Date: Tue Mar 12 02:46:09 2019 +0000 [IntersectionObserver] Optimize occlusion checking Calculating occlusion information for IntersectionObserver V2 is expensive. To enable IntersectionObserver V2 running in an OOP iframe we must determine, in the process of the parent frame, whether the iframe element is occluded. However, we should only do that calculation if the child frame actually needs it. This CL adds IPC's to request a parent frame to compute occlusion information for an OOP child frame. This way, the cost is only paid when the feature is being used. BUG=926539 R=chrishtr@chromium.org Change-Id: I4b6982b004b839145c371047cc989a8d3eef0011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512698 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#639783} .../frame_host/cross_process_frame_connector.cc | 8 +-- .../frame_host/cross_process_frame_connector.h | 2 +- .../browser/frame_host/render_frame_host_impl.cc | 15 ++++++ .../browser/frame_host/render_frame_host_impl.h | 1 + .../renderer_host/frame_connector_delegate.h | 9 ++-- .../render_widget_host_view_child_frame.cc | 6 +-- .../render_widget_host_view_child_frame.h | 3 +- ...render_widget_host_view_child_frame_unittest.cc | 4 +- content/common/frame_messages.h | 17 ++++++- content/common/widget_messages.h | 5 +- content/renderer/render_frame_impl.cc | 4 ++ content/renderer/render_frame_impl.h | 1 + content/renderer/render_frame_proxy.cc | 17 +++++-- content/renderer/render_frame_proxy.h | 5 +- content/renderer/render_widget.cc | 4 +- content/renderer/render_widget.h | 3 +- third_party/blink/public/common/BUILD.gn | 1 + .../blink/public/common/frame/occlusion_state.h | 26 ++++++++++ third_party/blink/public/web/web_frame_widget.h | 4 +- .../blink/public/web/web_local_frame_client.h | 4 ++ third_party/blink/public/web/web_remote_frame.h | 2 + .../blink/public/web/web_remote_frame_client.h | 5 +- third_party/blink/renderer/core/dom/element.cc | 14 ++++-- third_party/blink/renderer/core/dom/element.h | 5 +- .../core/exported/web_remote_frame_impl.cc | 4 ++ .../renderer/core/exported/web_remote_frame_impl.h | 1 + third_party/blink/renderer/core/frame/frame.cc | 2 + .../blink/renderer/core/frame/frame_owner.h | 5 ++ third_party/blink/renderer/core/frame/frame_view.h | 2 +- .../blink/renderer/core/frame/local_frame.cc | 14 ++++-- .../blink/renderer/core/frame/local_frame.h | 9 ++-- .../blink/renderer/core/frame/local_frame_view.cc | 28 +++++++---- .../blink/renderer/core/frame/local_frame_view.h | 2 +- .../renderer/core/frame/remote_frame_client.h | 3 +- .../core/frame/remote_frame_client_impl.cc | 4 +- .../renderer/core/frame/remote_frame_client_impl.h | 3 +- .../renderer/core/frame/remote_frame_owner.cc | 10 ++++ .../blink/renderer/core/frame/remote_frame_owner.h | 2 + .../blink/renderer/core/frame/remote_frame_view.cc | 49 ++++++++++++------ .../blink/renderer/core/frame/remote_frame_view.h | 8 ++- .../renderer/core/frame/web_frame_widget_impl.cc | 4 +- .../renderer/core/frame/web_frame_widget_impl.h | 3 +- .../renderer/core/html/html_frame_owner_element.h | 1 + .../element_intersection_observer_data.cc | 16 +++++- .../element_intersection_observer_data.h | 3 +- .../intersection_observer/intersection_geometry.cc | 6 +-- .../intersection_observation.cc | 9 ++++ .../intersection_observer/intersection_observer.cc | 2 +- .../intersection_observer_controller.cc | 28 +++++++++-- .../intersection_observer_controller.h | 10 ++-- .../blink/renderer/core/loader/empty_clients.h | 5 +- .../blink/renderer/core/testing/internals.cc | 11 ++++ .../blink/renderer/core/testing/internals.h | 3 ++ .../blink/renderer/core/testing/internals.idl | 8 +++ .../cross-origin-occlusion-tracking.html | 58 ++++++++++++++++++++++ .../resources/subframe-occlusion-tracking.html | 29 +++++++++++ 56 files changed, 411 insertions(+), 96 deletions(-) commit 1ea6f41e42e3a6ca6f4c7e6dc51934c6c7009bc3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 02:44:43 2019 +0000 Roll src/third_party/perfetto 8bc65917405b..139c7cac4999 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/8bc65917405b..139c7cac4999 git log 8bc65917405b..139c7cac4999 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 treehugger-gerrit@google.com Merge "Satisfy clang-tidy" Created with: gclient setdep -r src/third_party/perfetto@139c7cac4999 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3d65913b4392f7600be3a5f8e70e01464f43a2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516361 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639782} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9335367f98053cb119698f23e2dfed7b5bec8aa9 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 12 02:39:56 2019 +0000 SuperSize: Apply ThinLTO object path deduction to all symbols Realized that it should apply to outlined symbols as well although outlining is disabled at the moment). Bug: 923936 Change-Id: I777b874c5b38d4ab308b1c9c8ede4f2907035a91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516046 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#639781} tools/binary_size/libsupersize/archive.py | 8 ++-- .../binary_size/libsupersize/linker_map_parser.py | 49 +++++++++++++--------- 2 files changed, 33 insertions(+), 24 deletions(-) commit d4dda8d53aeb2fbdb9462520f8eb4e19c4708768 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Tue Mar 12 02:38:41 2019 +0000 Make case style consistent in resource_response.h The primary motivation of CL is that the function names aren't consistent within web_url_response.h (e.g."SetMIMEType" and "MimeType"). This CL renames function |SetMIMEType| to |SetMimeType| and ports other dependent files to refer to a new function name. Bug: 937196 Change-Id: I80287d02c4a77832880f8f2b444d607283e3c44f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514136 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#639780} content/renderer/loader/web_url_loader_impl.cc | 2 +- .../blink/public/platform/web_url_response.h | 2 +- .../web_associated_url_loader_impl_test.cc | 36 +++++++++++----------- .../blink/renderer/core/exported/web_frame_test.cc | 6 ++-- .../core/exported/web_navigation_params.cc | 2 +- .../blink/renderer/core/fetch/fetch_manager.cc | 2 +- .../renderer/core/fetch/fetch_request_data.cc | 4 +-- .../blink/renderer/core/fetch/fetch_request_data.h | 2 +- .../renderer/core/fetch/fetch_response_data.h | 2 +- third_party/blink/renderer/core/fetch/request.cc | 2 +- third_party/blink/renderer/core/fetch/response.cc | 4 +-- .../renderer/core/frame/frame_serializer_test.cc | 2 +- .../renderer/core/frame/mhtml_loading_test.cc | 2 +- .../renderer/core/loader/document_loader_test.cc | 2 +- .../blink/renderer/core/testing/sim/sim_network.cc | 4 +-- .../web_embedded_worker_impl_test.cc | 4 +-- .../renderer/platform/exported/web_url_response.cc | 2 +- .../renderer/platform/testing/url_test_helpers.cc | 4 +-- 18 files changed, 42 insertions(+), 42 deletions(-) commit d64e2dc8eb9f921bced221b4fa8e518d37c81205 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 02:37:56 2019 +0000 Roll src/third_party/pdfium c6f50282a2af..c924d0027a7d (4 commits) https://pdfium.googlesource.com/pdfium.git/+log/c6f50282a2af..c924d0027a7d git log c6f50282a2af..c924d0027a7d --date=short --no-merges --format='%ad %ae %s' 2019-03-11 tsepez@chromium.org Use spans in CFGAS_FormatString, part 3 2019-03-11 tsepez@chromium.org Use spans in CFGAS_FormatString, part 2 2019-03-11 rycsmith@google.com Update parameter name in declaration to match definition. 2019-03-11 tsepez@chromium.org Make CFGAS_FormatString::GetNumericFormat() handle multiple dots. Created with: gclient setdep -r src/third_party/pdfium@c924d0027a7d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:938724 TBR=dsinclair@chromium.org Change-Id: If1cd1dc1a4be27ce1e6d651fef68126f6a806ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516359 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639779} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d16e0ebb8eca8fdcd6e56e20fb772475da064a88 Author: Dana Fried <dfried@chromium.org> Date: Tue Mar 12 02:37:36 2019 +0000 Re-lay-out toolbar after tab switch. Bug: 937798 Change-Id: Ibf03daf2c232a5150a7856def782cb6229aed1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515685 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#639778} chrome/browser/ui/views/frame/browser_view.cc | 6 ++++++ 1 file changed, 6 insertions(+) commit 1c64fd91761d4150e4a50b04ab0dd4ffe13c3644 Author: Brian Sheedy <bsheedy@chromium.org> Date: Tue Mar 12 02:34:22 2019 +0000 Update VR page info goldens Updates the goldens for VrBrowserNativeUiTest#testPageInfoAppearsOnSecurityTokenClick. The behavior was changed on chrome:// pages in http://crrev.com/c/1509533, but the images never updated. TBR=billorr@chromium.org Change-Id: I13a55bfd10adf2d87382450ef21c175f8d360eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516787 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#639777} ...rowserNativeUiTest.page_info_visible_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...rowserNativeUiTest.page_info_visible_browser_ui.Pixel_XL-26.png.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 41610f2794e3565f3077b2fc8cd541308274ef3b Author: dpapad <dpapad@chromium.org> Date: Tue Mar 12 02:33:43 2019 +0000 WebUI cleanup: Delete unused cr.ui.ContextMenuButton. c/b/r/ntp4/: Was including context_menu_button.js at runtime, but still does not seem it was actually used anywhere. ui/file_manager: Was declaring context_menu_button as a dependency for type-checking purposes, but the file was never included in the page at runtime. Bug: None Change-Id: I1e4c0b1c5ddac9e71c280d3ea8d47bb1636f14f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513084 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#639776} chrome/browser/resources/ntp4/BUILD.gn | 1 - chrome/browser/resources/ntp4/new_tab.html | 1 - .../file_manager/foreground/js/BUILD.gn | 2 - .../file_manager/foreground/js/ui/BUILD.gn | 8 +- .../resources/html/cr/ui/context_menu_button.html | 1 - ui/webui/resources/js/cr/ui/BUILD.gn | 7 -- ui/webui/resources/js/cr/ui/context_menu_button.js | 94 ---------------------- ui/webui/resources/webui_resources.grd | 6 -- 8 files changed, 3 insertions(+), 117 deletions(-) commit 37fe521d6049b55c5a75bf00a5e390d5d6448703 Author: May Lippert <maybelle@google.com> Date: Tue Mar 12 02:32:08 2019 +0000 Change Save button status only if info has changed. Save button enabled/disabled state is calculated each time the edit dialog is opened, but it only needs to be calculated if the textboxes have changed. The other info used to calculate the state are from dropdown menus, so we can trust that the input will be valid. BUG=chromium:882827 Change-Id: I99108b686524c757948f4f28a1794ce3377c94e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464821 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by: May Lippert <maybelle@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#639775} .../printing_page/cups_edit_printer_dialog.html | 4 ++ .../printing_page/cups_edit_printer_dialog.js | 29 ++++++++--- .../data/webui/settings/cups_printer_page_tests.js | 57 ++++++++++++++++++++-- 3 files changed, 79 insertions(+), 11 deletions(-) commit 7caad10788307f128f1d33dd386bad9dbb3aa006 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 12 02:27:40 2019 +0000 SuperSize: Remove "symbol gap" logic from gold parser Removing it makes it consistent with LLD parser. There aren't actually any gaps, so not a big deal that it's not there. We should do it for all sections instead, so will use linked bug to track follow-up. Bug: 872796 Change-Id: If4a435ecf94f7749e8ecb7e7e913ba51e1138829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515606 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#639774} .../binary_size/libsupersize/linker_map_parser.py | 10 - .../libsupersize/testdata/Archive.golden | 22 +- .../libsupersize/testdata/Archive_Apk.golden | 30 +- .../libsupersize/testdata/Archive_Elf.golden | 30 +- .../testdata/Archive_MinimalApks.golden | 30 +- .../testdata/Archive_OutputDirectory.golden | 30 +- .../libsupersize/testdata/Archive_Pak_Files.golden | 30 +- .../libsupersize/testdata/Console.golden | 112 ++++--- tools/binary_size/libsupersize/testdata/Csv.golden | 6 +- .../libsupersize/testdata/Diff_Basic.golden | 4 +- .../libsupersize/testdata/Diff_NullDiff.golden | 4 +- .../libsupersize/testdata/FullDescription.golden | 269 +++++++--------- .../testdata/SymbolGroupMethods.golden | 356 ++++++++++----------- 13 files changed, 426 insertions(+), 507 deletions(-) commit 3f8a3a514ff2ebf70237707d8ed280460d4bac5e Author: Adithya Srinivasan <adithyas@chromium.org> Date: Tue Mar 12 02:27:27 2019 +0000 Portals: Make Portal a WebContentsDelegate This CL fixes a crash caused when nesting portals. The nested portal tries to call a method on the delegate for its outer WebContents (which is also a portal WebContents), but it doesn't have a delegate. This is fixed by making the corresponding content::Portal a delegate for a portal's WebContents. Bug: 934942 Change-Id: I4909fce18fe01d160301277781b680fcde45a01a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504311 Reviewed-by: Lucas Gadani <lfg@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#639773} content/browser/portal/portal.cc | 11 +++++++++-- content/browser/portal/portal.h | 7 ++++++- .../external/wpt/portals/portals-nested.html | 20 ++++++++++++++++++++ .../wpt/portals/resources/portals-nested-1.html | 4 ++++ .../wpt/portals/resources/portals-nested-2.html | 6 ++++++ 5 files changed, 45 insertions(+), 3 deletions(-) commit 40bd86d1aa68b0e2837473249a9c9e07d4f1e0d6 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 12 02:25:43 2019 +0000 SuperSize: Fix -f detection when using an ELF a directory containing a "." This made integration tests fail when run with "./" prefix :P Change-Id: I674723aa1c2bc2ec705e45c139cab768a1efe9ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515640 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#639772} tools/binary_size/libsupersize/archive.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a3d60e3efdfd1ae4cd56ddf5bb2268dde61bc3b7 Author: Shuotao Gao <stgao@chromium.org> Date: Tue Mar 12 02:24:08 2019 +0000 Revert "Exclude mojo for Android from a Chrome on Chrome OS coverage build." This reverts commit 0cb1be90fb4c818386d047aaac61346aad97bc83. Reason for revert: Revert as the other fix was landed https://chromium-review.googlesource.com/c/chromium/src/+/1515902 Original change's description: > Exclude mojo for Android from a Chrome on Chrome OS coverage build. > > There are missing clang runtime libraries that are needed to > successfully link libmojo in a coverage configuration. This > workaround lets us get coverage data for the rest of Chrome on > Chrome OS. > > This patch was authored by Noel Gordon, who initially reported this > issue. > > Bug: 865376 > Change-Id: I88b309760836639b80dfa0f7b67e4bb5c2b55d37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493471 > Commit-Queue: Sajjad Mirza <sajjadm@google.com> > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638301} TBR=rkc@chromium.org,hans@chromium.org,dpranke@chromium.org,robertocn@chromium.org,liaoyuke@chromium.org,sajjadm@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 865376 Change-Id: Id35f96cd34574b3da46bc9c73b4837cb03524095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516916 Reviewed-by: Shuotao Gao <stgao@chromium.org> Commit-Queue: Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#639771} chrome/BUILD.gn | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 506fd04c22ea3870673c84ef6a817c977a2bf821 Author: Donn Denman <donnd@chromium.org> Date: Tue Mar 12 02:23:18 2019 +0000 [TTS] Fix a flaky test by restriction to M-phone. Should fix a flaky testLongPressGestureFollowedByTapDoesntSelect test which seems to work fine on M phones. BUG=837998 Change-Id: I23fa0a02b67dee0bfa46f782d3c4af505ed36708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516035 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639770} .../browser/contextualsearch/ContextualSearchManagerTest.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 6e1e54e25ee8830664cb377a1fd8fb70be10ea63 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Mar 12 02:20:43 2019 +0000 Worker: Remove unnecessary WorkerOrWorkletGlobalScope::GetDestinationForMainScript() WorkerOrWorkletGlobalScope::GetDestinationForMainScript() is no longer necessary thanks to the previous cleanup: https://chromium-review.googlesource.com/c/chromium/src/+/1514350/ Bug: 938219 Change-Id: I8c31eca163d692a9f945fb6b92a8fc66b4b723f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514876 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639769} .../core/workers/dedicated_worker_global_scope.cc | 5 ----- .../renderer/core/workers/dedicated_worker_global_scope.h | 2 -- .../core/workers/experimental/thread_pool_thread.cc | 5 ----- .../renderer/core/workers/shared_worker_global_scope.cc | 5 ----- .../renderer/core/workers/shared_worker_global_scope.h | 1 - .../core/workers/worker_or_worklet_global_scope.h | 2 -- .../renderer/core/workers/worker_thread_test_helper.h | 4 ---- .../blink/renderer/core/workers/worklet_global_scope.cc | 15 ++++++--------- .../blink/renderer/core/workers/worklet_global_scope.h | 2 -- .../modules/service_worker/service_worker_global_scope.cc | 5 ----- .../modules/service_worker/service_worker_global_scope.h | 1 - 11 files changed, 6 insertions(+), 41 deletions(-) commit 5f74138b0d08727748e9e66e29be3f646824092f Author: Darwin Huang <huangdarwin@chromium.org> Date: Tue Mar 12 02:20:08 2019 +0000 Async Clipboard: Add DCHECK(array_buffer), and reorder DCHECKs. The array_buffer should always exist because this OnLoadBufferComplete function should only be called on successful load, so document this assumption with a DCHECK. Change-Id: I802f7a5d2a6a56aa5cc6a7fc544e7ccd344e4883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516353 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#639768} third_party/blink/renderer/modules/clipboard/clipboard_promise.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit fd80cde1a01c2dee81e81318bd92eff2f75589b8 Author: Daniel McArdle <dmcardle@chromium.org> Date: Tue Mar 12 02:18:15 2019 +0000 Add UMA histogram to count SSL client cert request dialogs on Android Design doc (public to chromium.org): https://docs.google.com/document/d/1f0X0-U0WmGTZpP6yrx1emytYD32PMUWF4aHhMtESWxc/edit?usp=sharing Bug: 817208 Change-Id: I204f95633a5a56a5252331a9abc4c5027ef0915a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506881 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#639767} .../ui/android/ssl_client_certificate_request.cc | 84 ++++++++++++++++++---- tools/metrics/histograms/histograms.xml | 19 +++++ 2 files changed, 88 insertions(+), 15 deletions(-) commit 28e22c2e40add0dfcef82a68e012831db29a4ee1 Author: Manu Cornet <manucornet@chromium.org> Date: Tue Mar 12 02:13:05 2019 +0000 CrOS: Remove ash-shelf-color flag Bug: 924761 Change-Id: Iecf6e6af4147a0d6f880eb3fa807beb46439fe1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512668 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#639766} ash/public/cpp/ash_switches.cc | 7 +------ ash/shelf/shelf_background_animator_unittest.cc | 9 --------- ash/wallpaper/wallpaper_controller.cc | 20 +------------------- chrome/browser/about_flags.cc | 10 ---------- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- 6 files changed, 2 insertions(+), 54 deletions(-) commit ac10239e92c146b27b7fd154d49ace603d8c9c22 Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Tue Mar 12 02:12:38 2019 +0000 [Import Maps] Add UseCounter for import maps Bug: 848607 Change-Id: Ibf0d0ede9a4cc0d085f4661586000d5a9729f739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509894 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#639765} third_party/blink/public/mojom/web_feature/web_feature.mojom | 1 + third_party/blink/renderer/core/script/script_loader.cc | 2 ++ tools/metrics/histograms/enums.xml | 1 + 3 files changed, 4 insertions(+) commit 72bcbdc5ad799f60a53a6ba907b5c80646e2f4c8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 02:10:43 2019 +0000 Roll Fuchsia SDK from b32c720f683b to 899835ec9999 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I63a3af9d4c1855bd961575e87eb2ddff8dd64c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516738 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#639764} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 5fde1d9c0ffa473c15c489e382a85ab6d4a32414 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Tue Mar 12 02:09:15 2019 +0000 Worker: Make WorkerGlobalScope::ImportClassicScript() pure-virtual Note that WorkerGlobalScope::ImportClassicScript() is used only for off-the-main-thread worker script fetch that is an experimental feature behind the runtime flag. For code simplification, this CL makes WorkerGlobalScope::ImportClassicScript() pure-virtual, and instead make each WorkerGlobalScope derivative (e.g., DedicatedWorkerGlobalScope) implement it by itself. The motivations of this change are as follows: - DedicatedWorker and SharedWorker refer to the same HTML spec for script fetch. On the other hand, ServiceWorker refers to the ServiceWorker spec for script fetch. This difference makes it difficult to put spec texts in WorkerGlobalScope::ImportClassicScript(). After this change, we can put appropriate spec texts in each implementation. - As noted above, DedicatedWorker and SharedWorker refer to the same HTML spec, but its behavior is slightly different. For example, DedicatedWorker inherits the parent's CSP, but SharedWorker doesn't it. This change makes it possible to implement the differences in a more natural way. - ServiceWorker has the unique startup sequence known as the "installed service worker" case. To implement the case, WorkerGlobalScope has several non-pure-virtual functions for script fetch and evaluation. IMHO, these make it difficult to read the source code. This change is a preparation for further cleanups of the WorkerGlobalScope class layering. Bug: 938219 Change-Id: I9a2f9ea8c500c9235e4771ae7d085fd5232429e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514350 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#639763} .../core/workers/dedicated_worker_global_scope.cc | 95 ++++++++++++++ .../core/workers/dedicated_worker_global_scope.h | 10 ++ .../workers/experimental/thread_pool_thread.cc | 6 + .../core/workers/shared_worker_global_scope.cc | 101 +++++++++++++++ .../core/workers/shared_worker_global_scope.h | 10 ++ .../renderer/core/workers/worker_global_scope.cc | 117 ------------------ .../renderer/core/workers/worker_global_scope.h | 15 +-- .../core/workers/worker_thread_test_helper.h | 6 + .../service_worker/service_worker_global_scope.cc | 136 +++++++++++++++++++++ .../service_worker/service_worker_global_scope.h | 10 ++ 10 files changed, 380 insertions(+), 126 deletions(-) Updated tag 'tree_truth' (was 4d44f1490ec5)