Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 40310 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919079551776073424 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itVLZTzv/luci_context.524939009 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2227-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43910678e4de7311 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: fa25a7c629b94a9f1d67285105b582d9b4963f27 Pass Kerberos environment variables to NetworkContextParams. Robbie McElrath, Wed Mar 13 17:54:36 2019 +0000 abe722e80b7f71f649e6a810b5e1aac677146fc1 IndexedDB: Remove now-unused IDBCallbacks.SuccessCursorContinue Chase Phillips, Wed Mar 13 17:52:45 2019 +0000 d48d2b1639774af47043bf653ccfb15fd972005b Automate VR voice input manual tests bsheedy, Wed Mar 13 17:51:52 2019 +0000 86a5416466cfad52d5269efb744a3cbfdba5579c Revert "[Fuchsia] Use memory offsets instead of file offsets for ELF headers." Ahmed Fakhry, Wed Mar 13 17:48:58 2019 +0000 f10255ed9a4b7118e8a4f1f9bd3c00becb5444a1 [MDC roll] Roll Material Components to 651b6470f437cdc51bb97f285b213d1520bc7201 iOS Autoroller, Wed Mar 13 17:47:24 2019 +0000 63c041cdd13dfc77540aedc0af67e87216a36aba ozone/wayland: Fix flaky DataDevice unit tests Nick Diego Yamane, Wed Mar 13 17:44:58 2019 +0000 b025ca59258a98fcadbc0cf2b05668165225c197 Add comment explains no null check in onUnconsumedKeyboardEventAck chaopeng, Wed Mar 13 17:40:43 2019 +0000 5e3a67f9db20b8c7bedfbc1ea6911a4be5e394bf Make EnableSupervisionTransitionScreens flag default true. Bruno Santos, Wed Mar 13 17:40:25 2019 +0000 a21cdff108af94017266d3a1a9fa2b436d7eff03 No longer remove empty policy directory Owen Min, Wed Mar 13 17:38:27 2019 +0000 ad3a5890054d5bba4acc3dcdb6317f2f718525db Add SQLitePersistentStoreBackendBase Lily Chen, Wed Mar 13 17:36:11 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit fa25a7c629b94a9f1d67285105b582d9b4963f27 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Wed Mar 13 17:54:36 2019 +0000 Pass Kerberos environment variables to NetworkContextParams. This CL copies the KRB5CC and KRB5_CONFIG environment variables from the browser process to the network service utility process via NetworkServiceParams for all posix systems, and additionally a new NetworkService::SetEnvironment call for ChromeOS. Bug: 940532 Change-Id: I183aa4beabc030744b73dec40333a828b9b31a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518886 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#640405} .../authpolicy/auth_policy_credentials_manager.cc | 22 ++++++++++++++++--- content/browser/network_service_instance.cc | 25 ++++++++++++++++++++++ services/network/network_service.cc | 11 ++++++++++ services/network/network_service.h | 2 ++ .../network/public/mojom/network_service.mojom | 15 +++++++++++++ 5 files changed, 72 insertions(+), 3 deletions(-) commit abe722e80b7f71f649e6a810b5e1aac677146fc1 Author: Chase Phillips <cmp@chromium.org> Date: Wed Mar 13 17:52:45 2019 +0000 IndexedDB: Remove now-unused IDBCallbacks.SuccessCursorContinue Commit d9377f2 / https://crrev.com/c/1480810 updated CursorContinue() to use native Mojo callbacks. Remove the IDBCallbacks SuccessCursorContinue interface which is now no longer used as a result. Bug: 717812 Change-Id: I991f596c78bdc5e0b5eceb6c1cd9792a9e57e51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516481 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#640404} content/browser/indexed_db/indexed_db_callbacks.cc | 49 ---------------------- content/browser/indexed_db/indexed_db_callbacks.h | 5 --- .../indexed_db/mock_mojo_indexed_db_callbacks.h | 11 ----- .../blink/public/mojom/indexeddb/indexeddb.mojom | 3 -- .../renderer/modules/indexeddb/web_idb_callbacks.h | 6 +++ 5 files changed, 6 insertions(+), 68 deletions(-) commit d48d2b1639774af47043bf653ccfb15fd972005b Author: bsheedy <bsheedy@chromium.org> Date: Wed Mar 13 17:51:52 2019 +0000 Automate VR voice input manual tests Automates the manual tests related to the VR browser test's voice input mode. Specifically: 1. Ensures that the voice input exit button works. 2. Ensures that the Daydream controller's app button functions the same as the exit button when in voice input mode. 3. Ensures that voice input is not available if the website is using the microphone permission. Bug: 887574 Change-Id: I80250de570ca07b19369f94affe25ab2156332d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509336 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#640403} .../chrome/browser/vr/VrBrowserNativeUiTest.java | 93 ++++++++++++++++++++++ .../chrome/browser/vr/util/NativeUiUtils.java | 8 +- chrome/browser/vr/ui.cc | 4 + chrome/browser/vr/ui_test_input.h | 8 +- 4 files changed, 109 insertions(+), 4 deletions(-) commit 86a5416466cfad52d5269efb744a3cbfdba5579c Author: Ahmed Fakhry <afakhry@chromium.org> Date: Wed Mar 13 17:48:58 2019 +0000 Revert "[Fuchsia] Use memory offsets instead of file offsets for ELF headers." This reverts commit 224e8c23ceea93e0ba809c3761fd33a4c9d89d78. Reason for revert: Causes failures of ElfReaderTest.ReadElfLibraryName on chromeos-kevin-rel: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/2030 BUG=941603 Original change's description: > [Fuchsia] Use memory offsets instead of file offsets for ELF headers. > > The ELF reader code uses file offsets for computing locations of data > in ELF headers. It is technically incorrect but generally works on > Intel without problems. However, ARM has wider alignment boundaries > which results in the computation and access of incorrect memory > addresses, producing page faults in certain circumstances. > > The bug is fixed by using p_vaddr instead of p_offset. > > Bug: 941279 > Change-Id: Ia88dc58411dfe046f882a94cea0e80e8ec525957 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518226 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640165} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: I936b5066c457d46a3207ede23c7e37bf7a5671c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521302 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#640402} base/debug/elf_reader.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit f10255ed9a4b7118e8a4f1f9bd3c00becb5444a1 Author: iOS Autoroller <ios-autoroller@chromium.org> Date: Wed Mar 13 17:47:24 2019 +0000 [MDC roll] Roll Material Components to 651b6470f437cdc51bb97f285b213d1520bc7201 TBR=smut Change-Id: Iedba11b62dd800ca48d6f62ce2a5b71c390d9ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521228 Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#640401} DEPS | 2 +- ios/third_party/material_components_ios/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 63c041cdd13dfc77540aedc0af67e87216a36aba Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Wed Mar 13 17:44:58 2019 +0000 ozone/wayland: Fix flaky DataDevice unit tests This CL fixes 2 issues which were causing flakiness on Drag & Drop tests: (1) Most of the times, tests using wl::TestDataSource functions were not waiting for the async read callback to be performed to finish. Fixing this revealed issue (2). (2) The test has been passing the wrong mime type when calling TestDataSource::ReadData(). So no data was being written into pipe fd at client side (WaylandDataSource), so the string returned in the test callback (empty '') wasn't matching the expected one. Additionally this CL, aims to improve TestDataSource::SendData documentation, adding some comments explaing why each pass is intended to. Bug: 926101 Change-Id: Ic17ae793caca085a4e57b5913b6ad0736dcf36bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518601 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#640400} ui/ozone/platform/wayland/test/test_data_source.cc | 6 ++++ .../wayland/wayland_data_device_unittest.cc | 35 +++++++++++++--------- 2 files changed, 27 insertions(+), 14 deletions(-) commit b025ca59258a98fcadbc0cf2b05668165225c197 Author: chaopeng <chaopeng@chromium.org> Date: Wed Mar 13 17:40:43 2019 +0000 Add comment explains no null check in onUnconsumedKeyboardEventAck onUnconsumedKeyboardEventAck is called by native after hasTouchlessEventHandler calls, no null check is needed. Change-Id: I83ada8a2fb9a7d535ef78c49e2bbfb28df451e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520349 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640399} ui/android/java/src/org/chromium/ui/base/TouchlessEventHandler.java | 2 ++ 1 file changed, 2 insertions(+) commit 5e3a67f9db20b8c7bedfbc1ea6911a4be5e394bf Author: Bruno Santos <brunoad@chromium.org> Date: Wed Mar 13 17:40:25 2019 +0000 Make EnableSupervisionTransitionScreens flag default true. Bug: 903851 Change-Id: Id99f79afc871c8560498254c6f63fc4174a613d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520355 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640398} chromeos/constants/chromeos_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a21cdff108af94017266d3a1a9fa2b436d7eff03 Author: Owen Min <zmin@chromium.org> Date: Wed Mar 13 17:38:27 2019 +0000 No longer remove empty policy directory The clean up logic is introduced in M71 and is safe enough to be removed in M75. Bug: 883869 Change-Id: I02bb7e00f5013dd4ffa82f84bbf1c3b63de941e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519089 Reviewed-by: Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640397} chrome/browser/policy/browser_dm_token_storage.cc | 13 --- chrome/browser/policy/browser_dm_token_storage.h | 7 -- .../policy/browser_dm_token_storage_linux.cc | 19 ---- .../policy/browser_dm_token_storage_linux.h | 14 --- .../browser_dm_token_storage_linux_unittest.cc | 109 --------------------- .../browser/policy/browser_dm_token_storage_mac.h | 8 -- .../browser/policy/browser_dm_token_storage_mac.mm | 13 --- .../browser_dm_token_storage_mac_unittest.cc | 68 ------------- .../machine_level_user_cloud_policy_controller.cc | 17 ---- 9 files changed, 268 deletions(-) commit ad3a5890054d5bba4acc3dcdb6317f2f718525db Author: Lily Chen <chlily@chromium.org> Date: Wed Mar 13 17:36:11 2019 +0000 Add SQLitePersistentStoreBackendBase This CL makes a base class, SQLitePersistentStoreBackendBase, from which SQLitePersistentCookieStore::Backend can inherit, in order to reuse common code. This is in anticipation of adding yet another SQLite store for NEL and Reporting data. Bug: None Change-Id: Iebd1ef9a57147ab82edca3f817c3018a8d33ed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481117 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#640396} net/BUILD.gn | 2 + .../sqlite/sqlite_persistent_cookie_store.cc | 651 +++++++-------------- .../sqlite/sqlite_persistent_store_backend_base.cc | 272 +++++++++ .../sqlite/sqlite_persistent_store_backend_base.h | 199 +++++++ 4 files changed, 694 insertions(+), 430 deletions(-) commit 511ec6c0711e196962f3c1188654fc612effa893 Author: John Chen <johnchen@chromium.org> Date: Wed Mar 13 17:35:12 2019 +0000 [ChromeDriver] Save pointer location between actions Modify ChromeDriver to save pointer locations between multiple calls of Perform Actions, as required by WebDriver standard. Bug: chromedriver:1897 Change-Id: I11926ff8e4af92db339460491f12125b44b5e84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512939 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#640395} chrome/test/chromedriver/test/run_py_tests.py | 62 +++++++++++++++++++++++++++ chrome/test/chromedriver/window_commands.cc | 25 ++++++++++- 2 files changed, 85 insertions(+), 2 deletions(-) commit c5aa0091514521dbafd5124b2e9647a851bbdabb Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Mar 13 17:34:57 2019 +0000 Remove cruft from wtf/assertions.cc and the corresponding BUILD.gn. Change-Id: Icebe52b71e2f735e9fc9209a3bf3a7f513f10af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521031 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640394} third_party/blink/renderer/platform/wtf/BUILD.gn | 3 --- .../blink/renderer/platform/wtf/assertions.cc | 29 +++------------------- 2 files changed, 3 insertions(+), 29 deletions(-) commit 83470fe1ab9552f9fd342fb7f12552a5a01efe84 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 17:34:02 2019 +0000 Roll src/third_party/skia e22dba8d5e9e..673c538f8d74 (2 commits) https://skia.googlesource.com/skia.git/+log/e22dba8d5e9e..673c538f8d74 git log e22dba8d5e9e..673c538f8d74 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 stephana@google.com Fix Pixel 3 dimension 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3c1f5a6bd487..4e87659e289c (1 commits) Created with: gclient setdep -r src/third_party/skia@673c538f8d74 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ic9fbd224b74320106651e4102bfe523b2b4de0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521075 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640393} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ccbe07a1abb0752183c3d0761a394d0e7d23691 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Mar 13 17:33:13 2019 +0000 Fix deletion of FileSystems in CookiesTree UI Deletion of FileSystems through CannedBrowsingDataFileSystemHelper was missing. This changes the canned helper to inherit from the actual helper in order to allow it to trigger deletions. Bug: 940253 Change-Id: I2706325235a75963c87b0247b5f30cf846f10971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517813 Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#640392} .../browsing_data_file_system_helper.cc | 72 +++++++--------------- .../browsing_data_file_system_helper.h | 41 +++++++----- .../browsing_data_file_system_helper_unittest.cc | 11 ++-- .../mock_browsing_data_file_system_helper.cc | 8 ++- .../local_shared_objects_container.cc | 4 +- 5 files changed, 62 insertions(+), 74 deletions(-) commit 3eeae17c64f7efefb76cf389ef0a339ab6161b5f Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Mar 13 17:32:10 2019 +0000 Web Share: move webshare.mojom to public/mojom mojom files in blink should be placed inside public/mojom This avoid the duplicate symbol complications discussed in https://chromium-review.googlesource.com/c/chromium/src/+/1460583/5/third_party/blink/public/mojom/BUILD.gn#214 Bug: 903010 Change-Id: I891e3020360593c0ab6eec5c051913535013e02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510619 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#640391} WATCHLISTS | 2 +- .../src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java | 2 +- chrome/app/chrome_content_browser_overlay_manifest.cc | 2 +- chrome/browser/DEPS | 1 - chrome/browser/chrome_content_browser_client.cc | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 5 ++++- third_party/blink/public/{platform/modules => mojom}/webshare/OWNERS | 0 .../blink/public/{platform/modules => mojom}/webshare/webshare.mojom | 0 third_party/blink/renderer/modules/webshare/OWNERS | 2 +- third_party/blink/renderer/modules/webshare/navigator_share.h | 2 +- third_party/blink/web_tests/webshare/share-arity.html | 2 +- third_party/blink/web_tests/webshare/share-error.html | 2 +- third_party/blink/web_tests/webshare/share-nonutf8-encoding.html | 2 +- third_party/blink/web_tests/webshare/share-success.html | 2 +- third_party/blink/web_tests/webshare/share-types.html | 2 +- third_party/blink/web_tests/webshare/share-url-relative.html | 2 +- 17 files changed, 16 insertions(+), 15 deletions(-) commit 84aa37ed3a2f13288c93c4ad90fe00513d84d77c Author: Wez <wez@chromium.org> Date: Wed Mar 13 17:30:03 2019 +0000 [Fuchsia] Look for ApplicationConfigManager in Agent-provided services. Migrate CastRunner to request the ApplicationConfigManager from its Agent, rather than expecting to find it provided by a system service. This allows us to build a simpler stub Agent, which implements both per-component services (e.g. CastChannel) and also global services (e.g. ApplicationConfigManager). An AgentManager is added to //fuchsia/base, for use by components to cache connections to Agent services, and to keep-alive the target Agent(s). Bug: 914610, 893229 Change-Id: I437324df87e3296b534943332e1da218e4f3c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512703 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#640390} fuchsia/base/BUILD.gn | 2 + fuchsia/base/agent_manager.cc | 49 +++++++++++ fuchsia/base/agent_manager.h | 68 ++++++++++++++++ fuchsia/runners/BUILD.gn | 1 + fuchsia/runners/cast/cast_component.cc | 32 +++----- fuchsia/runners/cast/cast_component.h | 6 +- fuchsia/runners/cast/cast_runner.cc | 94 +++++++++++++--------- fuchsia/runners/cast/cast_runner.h | 24 ++++-- .../runners/cast/cast_runner_integration_test.cc | 21 ++--- fuchsia/runners/cast/main.cc | 2 - 10 files changed, 218 insertions(+), 81 deletions(-) commit 26d2ac238417326a677c4222506133d23c4c7dea Author: Josh Nohle <nohle@google.com> Date: Wed Mar 13 17:29:43 2019 +0000 Add fake CryptAuthV2Enroller and ClientAppMetadataProvider classes These implementations are needed for the CryptAuthV2EnrollmentManager unit tests. Bug: 899080 Change-Id: I8dd4b14745638066dc7f141467ef2d59197b6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516888 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#640389} chromeos/services/device_sync/BUILD.gn | 2 + .../services/device_sync/cryptauth_v2_enroller.cc | 1 + .../device_sync/fake_cryptauth_v2_enroller.cc | 34 +++++++++++ .../device_sync/fake_cryptauth_v2_enroller.h | 69 ++++++++++++++++++++++ chromeos/services/device_sync/public/cpp/BUILD.gn | 2 + .../cpp/fake_client_app_metadata_provider.cc | 34 +++++++++++ .../public/cpp/fake_client_app_metadata_provider.h | 61 +++++++++++++++++++ 7 files changed, 203 insertions(+) commit 6621d678cd80b9fe23895b895b8a93fa058555e5 Author: Denis Kuznetsov <antrim@google.com> Date: Wed Mar 13 17:28:56 2019 +0000 Use new JSChecker methods in ActiveDirectoryLoginTest Also migrating to new JSChecker methods uncovered that some of UI was not mobile-friendly. Bug: 940977 Change-Id: I45693fe791bd8ed52c34bd2db6b9315867494d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520826 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Auto-Submit: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640388} .../login/active_directory_login_browsertest.cc | 122 ++++++++++----------- 1 file changed, 60 insertions(+), 62 deletions(-) commit 6332a9402b4ed0199a4b15a77411c08564bcd70b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 17:28:17 2019 +0000 flags: assign enable-lookalike-url-navigation-suggestions Per email discussion. Bug: None Change-Id: Ib3b28f6b66962756697a32d45374abb140e2ab63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520696 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640387} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit ad4923fbcaf6a728f4c2908212b73eef929e80f2 Author: Oystein Eftevaag <oysteine@chromium.org> Date: Wed Mar 13 17:27:10 2019 +0000 Fix enumeration of tracing categories for ARC tracing agents ARC tracing agents aren't owned by TracingControllerImpl; add a function in the base TracedProcess registry that all agents register with, to populate the tracing categories. R=ssid@chromium.org BUG=941295 Change-Id: Ia2a2dd763be8961fe3f322499a1e3d8429bc249c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519328 Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640386} content/browser/tracing/tracing_controller_impl.cc | 5 +---- services/tracing/public/cpp/traced_process_impl.cc | 6 ++++++ services/tracing/public/cpp/traced_process_impl.h | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) commit 9b67c0ba2c9448d46c56bb1bbf59d6f2f379b147 Author: Victor Fei <vicfei@microsoft.com> Date: Wed Mar 13 17:26:43 2019 +0000 Improved and completed IExpandCollapseProvider in UIA IExpandCollapseProvider already existed in Chromium, however it needed improvements. Changes include: 1. Logic in SupportsExpandCollapse() for checking if a control type supports IExpandCollapseProvider. 2. Now get_ExpandCollapseState() returns ExpandCollapseState_LeafNode if the expand/collapsed state is not explicit. Before it was NOTREACHED() which was causing crash for many control types. 3. Logic in Expand(), Collapse() prevents expand/collapse action to be performed if the element is disabled. 4. Logic in Expand(), Collapse() prevents expand action to be performed if the state is already set to expanded. And collapse action to be performed if the state is already set to collapsed. Bug: 847971 Change-Id: I027c20f2f639cd93ef4b4503248ca92a8e877718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510657 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#640385} ui/accessibility/BUILD.gn | 1 + ui/accessibility/ax_role_properties.cc | 10 +- ui/accessibility/ax_role_properties.h | 5 +- ui/accessibility/ax_role_properties_unittest.cc | 48 +++++ ui/accessibility/platform/ax_platform_node_win.cc | 19 +- .../platform/ax_platform_node_win_unittest.cc | 224 +++++++++++++++++++++ .../platform/ax_platform_node_win_unittest.h | 2 + 7 files changed, 300 insertions(+), 9 deletions(-) commit d2675bf10dc4afe5fbbd12c4fb71dca26386b2b7 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 13 17:24:00 2019 +0000 Update V8 to version 7.5.29. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61514a9c..f7cc35d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38d2c491ce0a78832341b4f1072438c4fec3982d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520347 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640384} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7b505f32f5b8daf34c2b24e78c1aedc1b396a373 Author: Jared Saul <jsaul@google.com> Date: Wed Mar 13 17:23:47 2019 +0000 Update AutofillUpstreamEditableExpirationDate fieldtrial testing config Launched to Canary/Dev in cl/237273284 Bug: 926316 Change-Id: Ia19760e102d820751ac94850c728ff9c4e36b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518600 Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#640383} testing/variations/fieldtrial_testing_config.json | 1 + 1 file changed, 1 insertion(+) commit c9393c6d9156f6a75e7bd5d60d9070a485576dc5 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 17:11:29 2019 +0000 build: default to symbol_level=1 on all sanitizers These builds can generate >4GB of debug info on Mac, which breaks many DWARF-manipulation tools. This change causes sanitizer builds to always use symbol_level=1, even on Windows and Mac, which drops the size of this debug info from ~5GB to ~1.4GB. This also affects Windows, and will probably drop fuzzer build size there too. Bug: 940823 Change-Id: I3ca55db005e25e0072a063f6cdda29e26de00e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520695 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640382} build/config/compiler/compiler.gni | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit f5d30c90ef77e6d7eaaaf67a0b51f67cdcf0bd83 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Mar 13 17:09:24 2019 +0000 Move fuchsia libunwind dependency to common_deps Also be more strict about visibility checks and add a comment to common_deps about adding new global dependencies, since it seems a few have slipped in since it was added. BUG=None R=thakis Change-Id: Id7e2a136bff4ad60e3ea19604431d13048a25738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492426 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640381} build/config/BUILD.gn | 20 ++++++++++++++++++-- buildtools/third_party/libc++/BUILD.gn | 17 +++++++++++++++-- buildtools/third_party/libc++abi/BUILD.gn | 18 ++++-------------- buildtools/third_party/libunwind/BUILD.gn | 11 ++++++----- 4 files changed, 43 insertions(+), 23 deletions(-) commit 1b25201721ad59b8bac5cfa11691091ae2cf1f90 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Wed Mar 13 17:08:39 2019 +0000 TabManager: Remove unnecessary Stop() method TabManager::Stop simply resets unique_ptrs, which is already performed implicitly on destruction. There is no need for this method. Change-Id: Ic98cc1f2348afb94af07ab21983eb809a6a9e91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518906 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Cr-Commit-Position: refs/heads/master@{#640380} chrome/browser/resource_coordinator/tab_manager.cc | 12 +----------- chrome/browser/resource_coordinator/tab_manager.h | 3 +-- 2 files changed, 2 insertions(+), 13 deletions(-) commit 008221e0b56651002edf8db3d882050c66c3d5bc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 17:07:34 2019 +0000 Roll src/third_party/chromite 579a3b3e53ce..6b83d6b99335 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/579a3b3e53ce..6b83d6b99335 git log 579a3b3e53ce..6b83d6b99335 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 dgarrett@google.com chromeos_config: Increase factorybranch timeout. Created with: gclient setdep -r src/third_party/chromite@6b83d6b99335 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ibc1f6b933963896f7951b5c5629a1f16268214b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521186 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640379} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c02e9c7fd7f2958c126066eca749fa96ffd10360 Author: Joshua Pawlicki <waffles@chromium.org> Date: Wed Mar 13 17:07:31 2019 +0000 Launch improved recovery component. Bug: 687231 Change-Id: I68036b3f8d441738234907e43c22ade80fead5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516281 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640378} chrome/browser/chrome_browser_main.cc | 6 +----- chrome/common/chrome_features.cc | 6 ------ chrome/common/chrome_features.h | 3 --- 3 files changed, 1 insertion(+), 14 deletions(-) commit 4dfa1469c1a763b82be59e3cd1f5b3a0121c7d6f Author: Peter Boström <pbos@chromium.org> Date: Wed Mar 13 17:05:22 2019 +0000 Add Profile::IsRegularProfile Adds a short-hand for GetProfileType() == REGULAR_SESSION which should help discourage checking !IsIncognito() && !IsGuestSession(). Also adds usages of this to AvatarToolbarButton that helps illustrate how the Profile has been misused in the past and how the convenience method helps clear up related code. Bug: None Change-Id: I5a06c0bea64b7066de70261449322bf970f3c1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519103 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#640377} chrome/browser/profiles/profile.cc | 4 ++++ chrome/browser/profiles/profile.h | 4 ++++ chrome/browser/ui/views/profiles/avatar_toolbar_button.cc | 7 +++---- 3 files changed, 11 insertions(+), 4 deletions(-) commit c131c1f0d72ab7301c9aa9ece14f4c21f0e3abb7 Author: siashah <siashah@chromium.org> Date: Wed Mar 13 17:05:07 2019 +0000 Make the fix flows dialog not cancelable Currently the dialog is cancelled when the user clicks outside the dialog This change will make the dialog non cancelable Bug: 941250 Change-Id: I98cb827c8044cfb64d90eba2e4f8356ca4d17a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519074 Auto-Submit: Siddharth Shah <siashah@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#640376} .../chrome/browser/autofill/AutofillExpirationDateFixFlowPrompt.java | 2 +- .../org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 7b7be76a39254c467d1ba2a04dff20ff967a032a Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 17:00:58 2019 +0000 flags: remove enable-touchpad-three-finger-click Per email discussion, this flag is obsolete. Bug: 941520 Change-Id: I691402189e04e04de75c061a5d9647bbc1bcea43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521226 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#640375} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 4 ---- chrome/browser/flag_descriptions.h | 3 --- 4 files changed, 16 deletions(-) commit 8668489b8f40f9031efbb6ad419872b1ef7d3b11 Author: Lei Zhang <thestig@chromium.org> Date: Wed Mar 13 17:00:55 2019 +0000 Fix libfuzzer dictionary syntax in pdf_xfa_js.dict. Change-Id: I9cec3bfba58c43617cd65ee2d01b1262b82c463a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520686 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640374} pdf/pdfium/fuzzers/dicts/pdf_xfa_js.dict | 408 +++++++++++++++---------------- 1 file changed, 204 insertions(+), 204 deletions(-) commit 855be74de839b8a6bed313852f16e5d7bca4bd68 Author: Alex Clarke <alexclarke@chromium.org> Date: Wed Mar 13 16:58:11 2019 +0000 Add the task_queue name to PostTask flow events This will help us diagnose start up traces, and will likely be useful in blink too. TBR=derat@chromium.org Bug: 863341 Change-Id: I7916ef7e3ce0ff0e0df243ea2fe4fd5e0c1a40d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511471 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#640373} base/task/common/task_annotator.cc | 12 +++++++----- base/task/common/task_annotator.h | 7 +++++-- base/task/common/task_annotator_unittest.cc | 2 +- base/task/sequence_manager/sequence_manager_impl.cc | 5 +++-- base/task/sequence_manager/sequence_manager_impl.h | 2 +- base/task/sequence_manager/task_queue_impl.cc | 6 +++--- base/task/sequence_manager/thread_controller.h | 3 ++- base/task/sequence_manager/thread_controller_impl.cc | 6 ++++-- base/task/sequence_manager/thread_controller_impl.h | 3 ++- .../thread_controller_with_message_pump_impl.cc | 6 ++++-- .../thread_controller_with_message_pump_impl.h | 3 ++- base/task/task_scheduler/task_tracker.cc | 3 ++- components/timers/alarm_timer_chromeos.cc | 2 +- 13 files changed, 37 insertions(+), 23 deletions(-) commit 56742b0ebf655154493935203f782e80d7b5f4f3 Author: Mina Almasry <almasrymina@chromium.org> Date: Wed Mar 13 16:57:38 2019 +0000 Fix PTS reporting before playback has started Bug: internal b/124013079 Test: cast_media_unittests Change-Id: Ib5fc90c84ffc5dd0e30fd91d62f32aab19e61e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517095 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Auto-Submit: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#640372} chromecast/media/cma/backend/media_pipeline_backend_for_mixer.cc | 7 +++++++ chromecast/public/media/media_pipeline_backend.h | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) commit ab4b411e758672ab1dbdae1d68c524d46d18a478 Author: Mustaq Ahmed <mustaq@google.com> Date: Wed Mar 13 16:56:18 2019 +0000 Rename the flag for activation transfer API, complete plumbing. There has been a past flag for delegation through an <iframe> attribute. Renaming the new flag to clarify the difference, and also marking the past flag deprecated to avoid confusion. This CL will have this test passing with the flag: wpt/html/user-activation/activation-transfer-with-click.tentative.html Bug: 928838 Change-Id: I2f93142fb898ecc06f8921d0183840b59f4dd095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518063 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640371} content/child/runtime_features.cc | 4 ++++ content/public/common/content_features.cc | 6 ++++-- content/public/common/content_features.h | 2 +- third_party/blink/public/platform/web_runtime_features.h | 2 ++ third_party/blink/renderer/core/frame/dom_window.cc | 2 +- .../blink/renderer/core/frame/window_post_message_options.idl | 4 +++- .../blink/renderer/platform/exported/web_runtime_features.cc | 4 ++++ third_party/blink/renderer/platform/runtime_enabled_features.json5 | 4 ++-- 8 files changed, 21 insertions(+), 7 deletions(-) commit 56e472455c97d4ec7c5de2842dcdaac015fa98ad Author: Jessica Tallon <jtallon@igalia.com> Date: Wed Mar 13 16:51:38 2019 +0000 Emit ATK property-change:accessible-description for content Bug: 938237 Change-Id: Ieca3a7b35393da79e40a7156f95004b3a0d3b59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511422 Commit-Queue: Jessica Tallon <jtallon@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640370} .../accessibility_event_recorder_auralinux.cc | 4 ++++ .../browser_accessibility_manager_auralinux.cc | 8 ++++++++ .../browser_accessibility_manager_auralinux.h | 1 + .../event/description-change-expected-auralinux.txt | 1 + ui/accessibility/platform/ax_platform_node_auralinux.cc | 14 ++++++++++++++ ui/accessibility/platform/ax_platform_node_auralinux.h | 1 + 6 files changed, 29 insertions(+) commit 6e199eed21c923ce1d63a314f0c7304ae9ecaf65 Author: Emircan Uysaler <emircan@chromium.org> Date: Wed Mar 13 16:51:27 2019 +0000 Fix flakiness in VerifyCanvasCaptureOffscreenCanvasFrames I found out that we hit this issue when requestAnimationFrame() callbacks are drifted too much, such that we receive multiple within a vsync. In that case, we provide a single capture for multiple draws, which fails test expectations. Bug: 916928 Change-Id: I937c6f180707ec8e9aefd9c98d0f7d0caae49570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518915 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640369} .../webrtc/webrtc_capture_from_element_browsertest.cc | 4 +--- content/test/data/media/canvas_capture.html | 18 ++++++++++++++++-- 2 files changed, 17 insertions(+), 5 deletions(-) commit 8193738d084ad6c55f83d8c634de49f2075f02bf Author: Mike Wittman <wittman@chromium.org> Date: Wed Mar 13 16:50:06 2019 +0000 [Sampling profiler] Use different ModuleCaches for profiler threads in test ModuleCaches are expected to be allocated one per profiling thread because they do not support concurrent access. Update the test to do so. Bug: 931418 Change-Id: I52be2c645ecfaf71cb55ec113e34b455447f05a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521210 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#640368} base/profiler/stack_sampling_profiler_unittest.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit fbc8acb2e680f652f343b301358da15c4f2f2bbd Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Mar 13 16:49:12 2019 +0000 [MediaStream] Fix bug in applyConstraints() for video tracks This CL fixes a bug such that when a source had multiple tracks with the same settings (e.g., cloned tracks) and the settings for one of tracks changed via applyConstraints(), in some cases the modified track was not added back to the list of tracks backed by the source, resulting in tracks that reported themselves as live but produced no frames. Bug: 940518 Change-Id: I1f779179f52d1bfa4605855b4d092a215417314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520837 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#640367} .../webrtc/webrtc_getusermedia_browsertest.cc | 8 ++++++ content/test/data/media/getusermedia.html | 32 ++++++++++++++++++++++ .../modules/mediastream/video_track_adapter.cc | 4 ++- 3 files changed, 43 insertions(+), 1 deletion(-) commit 80bf614dfd6463318b4822d71cc37bebf29a852a Author: Ella Ge <eirage@chromium.org> Date: Wed Mar 13 16:48:58 2019 +0000 deflaky pointerevent_pointerlock_supercedes_capture-manual.html The test terminate at the second mouse move after call exitPointerLock, It may timeout when entering and exiting lock states took longer than the gap between events and we don't have enough moves to finish the test. This CL adds two pointer moves to the automation, so that the test can terminate successfully. Bug: 798680 Change-Id: Iac4276ff4f39a0d5884b4aaf0887fe8c43dabd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518733 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#640366} third_party/blink/web_tests/TestExpectations | 3 --- .../external/wpt_automation/pointerevents/pointerevent_common_input.js | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) commit 7427f77974bd0f72f65e485c788554d7dad56a7d Author: Jonathan Backer <backer@chromium.org> Date: Wed Mar 13 16:40:21 2019 +0000 DLOG instead of DCHECK destruction during write access This is motivated by our fuzzing of RasterDecoder. The fuzzer can issue a BeginRasterCHROMIUM without a matching EndRasterCHROMIUM. The DCHECK was causing clusterfuzz to think it found an legit error. It is possible for a renderer to crash between BeginRaster and EndRaster as well. Bug: 940190 Change-Id: Ia260b626ce516a700fc1159e4be33c7adb02740c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518144 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: enne <enne@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640365} .../service/shared_image_backing_factory_gl_texture.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 7aba201fa68d61309a88fd852d36f1b0cea3a742 Author: David Bokan <bokan@chromium.org> Date: Wed Mar 13 16:37:57 2019 +0000 Mark multi-touch-user-gesture.html as flaky Appears that landing https://crrev.com/c/1390330 has made this test very flaky. Adding it to expectations to green the bots while I investigate. TBR=danakj@chromium.org Bug: 915926 Change-Id: Iaa1956b76556a1d220dd9fd560780b0cab33c0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521029 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640364} third_party/blink/web_tests/TestExpectations | 5 +++++ 1 file changed, 5 insertions(+) commit 295c43f1854b16fc51b89aade6d86363c370cc16 Author: danakj <danakj@chromium.org> Date: Wed Mar 13 16:37:17 2019 +0000 Defer sending a request to close the page for remote main frames The same arguments apply as for a local main frame, in that JS could run a nested message loop and the browser may close the RenderWidget that the JS is running from before the stack unwinds, causing a crash. So we post a task to send the close request to the browser from RenderViewImpl in the remote main frame case, matching the local main frame/popup case. R=dcheng@chromium.org Bug: 912193 Change-Id: I5adc9694fc8d9898a98993adafa48b98f04a97de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480270 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640363} content/renderer/render_view_impl.cc | 29 +++++++++++++++++++++++++---- content/renderer/render_view_impl.h | 6 ++++++ content/renderer/render_widget.cc | 7 ++++--- 3 files changed, 35 insertions(+), 7 deletions(-) commit 298c6c31feaf11c17303500feaecadaa20e749e3 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 16:36:50 2019 +0000 Roll src-internal 63e898da8fa6..62079cb02868 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63e898da8fa6..62079cb02868 Created with: gclient setdep -r src-internal@62079cb02868 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I910e42e9bb526ac268d5ee950c64751e5d7b18e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520878 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640362} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 89b289f09f12998a61f98f7bcb86a80bbf49c803 Author: Garrett Beaty <gbeaty@chromium.org> Date: Wed Mar 13 16:31:37 2019 +0000 Remove the 16 minutes test timeout for Lollipop Phone Tester. Bug: 939945 Change-Id: I261374237caa3124084ca0ca95fcaf15f7241005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519188 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#640361} testing/buildbot/chromium.android.json | 63 ---------------------------------- testing/buildbot/waterfalls.pyl | 1 - 2 files changed, 64 deletions(-) commit 6244a1d8ecaf6e2ff3d90505bc369f6b822b62e4 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Wed Mar 13 16:29:41 2019 +0000 PM: Explicitly clean up RenderProcessUserData at shutdown. Also fold the RenderProcessHostObserver into the UserData as this saves on an allocation. Bug: 910288 Change-Id: Ieddf0435c1dcaad7ad8440847fd926f4d9fa3742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520704 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#640360} .../render_process_user_data.cc | 79 +++++++++++++--------- .../performance_manager/render_process_user_data.h | 24 ++++++- ...rowser_main_extra_parts_resource_coordinator.cc | 12 ++++ 3 files changed, 82 insertions(+), 33 deletions(-) commit 7601952f20db79350ec9ab6e961b7f1b39a14424 Author: Denis Kuznetsov <antrim@google.com> Date: Wed Mar 13 16:27:47 2019 +0000 Extract configuration-based enrollment test Also made it derive from OobeTestBase rather than LoginManagerTest Bug: 912704 Change-Id: I631650fb2e27046a84aca9f88179674ecbbca63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516312 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640359} .../configuration_based_enrollment_browsertest.cc | 326 +++++++++++++++++++++ .../login/enterprise_enrollment_browsertest.cc | 321 -------------------- .../browser/chromeos/login/test/oobe_base_test.cc | 20 +- .../browser/chromeos/login/test/oobe_base_test.h | 5 + chrome/test/BUILD.gn | 1 + 5 files changed, 347 insertions(+), 326 deletions(-) commit c353f3b77dc89975be6f6234c050db8c6b654532 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Mar 13 16:27:27 2019 +0000 Strip symbols from chrome in the CrOS sanity tests when running in VMs. Like for tast tests, sometimes we run out of room when deploying the browser during the sanity test. So let's start stripping symbols. Change-Id: I1e737f6fa71b919c2760d31d9b96f8aab1250636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519099 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#640358} build/chromeos/test_runner.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit a30d0ada945cbd74d29d1c6ec9eedceb2bab45f3 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Mar 13 16:17:27 2019 +0000 Import <Foundation/Foundation.h> instead of individual header files This is the official way to import framework files, so let's fix it now as a follow-up change right after the patch for CL1518573 has been merged. Bug: 929973 Change-Id: I7cf64b6c06226653375a2f1558001865db1db18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520602 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#640357} third_party/blink/renderer/platform/wtf/text/string_impl_mac.mm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit e4fd0df8392a8285ef9de7a393b1209e3a3937b8 Author: Denis Kuznetsov <antrim@google.com> Date: Wed Mar 13 16:16:18 2019 +0000 Add utility methods to JSChecker Bug: 940977 Change-Id: I40cd7e8edd7ccd74cb74154f6d1d4640dc348bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517709 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640356} .../login/enterprise_enrollment_browsertest.cc | 204 +++++++++------------ chrome/browser/chromeos/login/test/js_checker.cc | 97 +++++++++- chrome/browser/chromeos/login/test/js_checker.h | 30 +++ .../resources/chromeos/login/offline_ad_login.html | 16 +- .../resources/chromeos/login/oobe_select.js | 2 + 5 files changed, 214 insertions(+), 135 deletions(-) commit fccc0edf73c277d0435351d9190e299191a7ca28 Author: Joe Mason <joenotcharles@google.com> Date: Wed Mar 13 16:13:56 2019 +0000 Add misc chrome_cleaner switches - Add a kTestLoggingPathSwitch to set where logs are written to during tests. - Make sure unofficial builds never send logs except if the kTestLoggingUrlSwitch is given. - Add kFileSizeLimitSwitch and tests. R=proberge Bug: 78359771 Change-Id: I14d71d4794c1a06a48f8badd116682675af639b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519549 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640355} chrome/chrome_cleaner/logging/BUILD.gn | 1 + chrome/chrome_cleaner/logging/scoped_logging.cc | 19 ++++- .../logging/scoped_logging_unittest.cc | 93 ++++++++++++++++++++++ chrome/chrome_cleaner/settings/BUILD.gn | 2 +- .../settings/cleaner_settings_unittest.cc | 26 ++++-- .../settings/reporter_settings_unittest.cc | 30 ++++--- chrome/chrome_cleaner/settings/settings.cc | 23 ++++++ chrome/chrome_cleaner/settings/settings.h | 5 ++ .../chrome_cleaner/settings/settings_unittest.cc | 50 +++++++++++- chrome/chrome_cleaner/test/test_settings_util.h | 1 + 10 files changed, 227 insertions(+), 23 deletions(-) commit cd417503b725ea3e90a36a090395cc7c3cff3166 Author: danakj <danakj@chromium.org> Date: Wed Mar 13 16:13:21 2019 +0000 Move LayerTreeMutator setter to WebWidgetClient (5/n) The WebLayerTreeView is a shortcut past the WebWidgetClient that is not needed now that we always composite. This works toward eliminating this extra API layer. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. R=flackr@chromium.org Bug: 912193 Change-Id: Ic1abcf564154564c428ebde814db1be4a49c6c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490496 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640354} content/renderer/compositor/layer_tree_view.cc | 6 ------ content/renderer/compositor/layer_tree_view.h | 1 - content/renderer/render_widget.cc | 5 +++++ content/renderer/render_widget.h | 1 + third_party/blink/public/platform/web_layer_tree_view.h | 3 --- third_party/blink/public/web/web_widget_client.h | 11 ++++++++++- .../blink/renderer/core/frame/web_frame_widget_base.cc | 2 +- 7 files changed, 17 insertions(+), 12 deletions(-) commit 4bf4f510e7268c2bf994491d7e07115d5f4d6ec9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 16:12:52 2019 +0000 Roll src/third_party/skia 6d31ddee3c16..e22dba8d5e9e (4 commits) https://skia.googlesource.com/skia.git/+log/6d31ddee3c16..e22dba8d5e9e git log 6d31ddee3c16..e22dba8d5e9e --date=short --no-merges --format='%ad %ae %s' 2019-03-13 brianosman@google.com Clamp in GrBicubicEffect (to match SW and for general sanity) 2019-03-13 brianosman@google.com Include test name in error messages for failing tests 2019-03-13 mtklein@google.com Revert "add private non-copying SkReadBuffer::readString()" 2019-03-13 herb@google.com Check that a glyph will fit in the atlas instead of a bogus check Created with: gclient setdep -r src/third_party/skia@e22dba8d5e9e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I8483b84f0106fd71a3b492965bc76e5c3df31460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521128 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640353} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0d885e758e44671c943d3f2e4e59b0c3711ca331 Author: Joe Mason <joenotcharles@google.com> Date: Wed Mar 13 16:12:15 2019 +0000 Fix crashes in chrome_cleaner LNK parser R=proberge Bug: 78359771 Change-Id: I0d20a9d23e391f5c95c9e69989dc7c5f3ba5207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519551 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640352} .../parsers/shortcut_parser/target/lnk_parser.cc | 106 +++++---- .../shortcut_parser/target/lnk_parser_unittest.cc | 242 +++++++++++++++++++-- 2 files changed, 289 insertions(+), 59 deletions(-) commit 3cd59485f8dbbdcbaa71d92a01bb1476a07199bb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 16:11:45 2019 +0000 Roll Fuchsia SDK from a0d04e2f2507 to ddcb12bc41ac The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibbb26b2d9e33d2ee3646edfe2d08abe8ad3d7004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520877 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640351} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f0bb082b6a64b75e68585b04b176a50d610f4593 Author: David Roger <droger@chromium.org> Date: Wed Mar 13 16:09:20 2019 +0000 [signin][android] Move account settings utils Bug: 938554 Change-Id: I8090bd102861aead6873cba1180799963c33bda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517910 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#640350} chrome/android/BUILD.gn | 2 +- .../browser/signin/AccountManagementFragment.java | 16 ++-- .../signin/AccountManagementScreenHelper.java | 92 ---------------------- .../browser/signin/SignOutDialogFragment.java | 6 +- .../chrome/browser/signin/SigninUtils.java | 76 ++++++++++++++++++ chrome/android/java_sources.gni | 1 - chrome/browser/BUILD.gn | 4 +- ...management_screen_helper.cc => signin_utils.cc} | 15 ++-- ...t_management_screen_helper.h => signin_utils.h} | 12 +-- chrome/browser/signin/chrome_signin_helper.cc | 6 +- 10 files changed, 102 insertions(+), 128 deletions(-) commit f2a65048159a8bac7a1abc04f9e2b4f0e5bc27c1 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Mar 13 16:07:28 2019 +0000 Convert away from method method JSONReader::ReadDeprecated Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value> and convert surrounding code to the new base::Value API. Bug: 925165 Change-Id: Ida5525eedca3d679be6c042023bdf2f536576277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518514 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#640349} .../browser/autocomplete_match_type_unittest.cc | 8 +- components/omnibox/browser/document_provider.cc | 5 +- .../omnibox/browser/document_provider_unittest.cc | 52 +++++----- .../omnibox/browser/search_suggestion_parser.cc | 2 +- .../browser/search_suggestion_parser_unittest.cc | 13 +-- components/omnibox/browser/suggestion_answer.cc | 110 ++++++++++++--------- components/omnibox/browser/suggestion_answer.h | 26 ++--- .../omnibox/browser/suggestion_answer_unittest.cc | 8 +- 8 files changed, 118 insertions(+), 106 deletions(-) commit 1961e65309d8025a7d8811685fbca2bae6591c92 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 16:05:29 2019 +0000 flags: assign enable-shill-sandboxing TBR=avi@chromium.org Bug: None Change-Id: I811e6220d0920f3a17095bdd1e4b09ad81341e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520700 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#640348} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 5fd62324d3b863d227e8ea943d3a00deada4ef3c Author: David Roger <droger@chromium.org> Date: Wed Mar 13 16:00:41 2019 +0000 [signin][mice] Update credentials when Chrome-Connected header has email Bug: 938554 Change-Id: Iffcefb818c8400ae482442e3e7240d58a79db75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517701 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#640347} .../signin/AccountManagementScreenHelper.java | 34 +++++++++++++++++----- .../signin/account_management_screen_helper.cc | 11 +++++-- .../signin/account_management_screen_helper.h | 5 +++- chrome/browser/signin/chrome_signin_helper.cc | 4 +-- 4 files changed, 40 insertions(+), 14 deletions(-) commit 5f5f8aaa2502f3e776fba3e3d8a1234613931317 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:59:50 2019 +0000 Roll src/third_party/perfetto c4e085dbb2c7..c39f77fd46c2 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/c4e085dbb2c7..c39f77fd46c2 git log c4e085dbb2c7..c39f77fd46c2 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 treehugger-gerrit@google.com Merge "Fix crash when recreating producer." Created with: gclient setdep -r src/third_party/perfetto@c39f77fd46c2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iebf3b40ec2e1eb2f49e313fa9316105dbf86b971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521127 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640346} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 41828248626dedf74a472f1383b9121706bc7d36 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:56:25 2019 +0000 Roll src/third_party/webrtc 1175ae0d800e..208634763a17 (2 commits) https://webrtc.googlesource.com/src.git/+log/1175ae0d800e..208634763a17 git log 1175ae0d800e..208634763a17 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 titovartem@google.com Move creation of rtc::NetworkManager into network emulation layer 2019-03-13 ilnik@webrtc.org Add new webrtc_perf_test for lower stream of vp8 simulcast screenshare Created with: gclient setdep -r src/third_party/webrtc@208634763a17 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I74a3f80ea4c8ea607fb85e7a40741523f29c0b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520872 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640345} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2b1539f0470b531c8600205ebc5f9724c7d3db81 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:54:50 2019 +0000 Roll AFDO from 74.0.3729.7_rc-r1-merged to 74.0.3729.10_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4300766df2fccbc3e9e6016a06be1be2d4c526f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521187 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640344} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 68809c8b9975f1678af9a74215697a0d964cd6f6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:52:03 2019 +0000 Roll src/third_party/SPIRV-Tools/src b75f4362f01a..9d29c37ac507 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b75f4362f01a..9d29c37ac507 git log b75f4362f01a..9d29c37ac507 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 stevenperron@google.com Removing decorations when doing constant propagation. (#2444) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9d29c37ac507 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I82abc03a706ea1077986589b6fe3277b45dc94db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521126 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640343} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4ae2d9b3421d387e890088df716b801311e48bd7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:47:18 2019 +0000 Roll src/third_party/angle 3c1f5a6bd487..4e87659e289c (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/3c1f5a6bd487..4e87659e289c git log 3c1f5a6bd487..4e87659e289c --date=short --no-merges --format='%ad %ae %s' 2019-03-13 ianelliott@google.com Fix eglChooseConfig for attributes that have exact default values. Created with: gclient setdep -r src/third_party/angle@4e87659e289c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If592b1bce3b76c344b7328ae6131d9aafd88310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520875 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640342} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eeac4dcb135f6a81b828acd80cbb2c2bb5bd3599 Author: Raymond Toy <rtoy@chromium.org> Date: Wed Mar 13 15:47:15 2019 +0000 Use matching sample rate for the context as for the reference file The reference file has a certain sample rate. Use the same for the context to reduce the amount of resampling that might be required. Regenerated the webm-decode-expected.wave file with the fixed sample rate. This also changed the SNR slightly, so update the SNR test accordingly. Also manually compared the new and old files. These differ by at most 1 LSB (16-bit). Bug: 940970 Change-Id: I979bbeb512c36d7e2eb4cba85550fa4177b8aabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516723 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640341} ...diaElementAudioSourceToScriptProcessorTest.html | 6 ++++-- .../webm/resources/webm-decode-expected.wav | Bin 184398 -> 184364 bytes .../webaudio/codec-tests/webm/webm-decode.html | 11 +++++++++-- 3 files changed, 13 insertions(+), 4 deletions(-) commit eb9c8349b34fbe8cd23f09b38cd714b92193cb06 Author: Joe Mason <joenotcharles@google.com> Date: Wed Mar 13 15:45:52 2019 +0000 Stop inheriting stdout and stderr in the chrome_cleaner sandbox On windows 7, sometimes these handles are inherited incorrectly, randomly, which causes the sandbox process to die immediately. Also improve the error logging on sandbox startup. R=csharp Bug: 78359771 Change-Id: Icbbab071b71de513d3aaf32e940962f8caf093fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519550 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640340} chrome/chrome_cleaner/ipc/sandbox.cc | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) commit e55a096328305323a46ced532fbbf9a2e4fd4a0a Author: chaopeng@chromium.org <chaopeng@chromium.org> Date: Wed Mar 13 15:38:36 2019 +0000 Reland "Add plumbing for keymap" This is a reland of 6ec27fc3b6c3bde79347b07d89cc4b958c468a90 The bot failed because remoting/protocol/input_event_tracker includes dom_code.h but not deps on ui/events:dom_keycode_converter. Adding deps should fix. TBR=garykac@chromium.org,kerrnel@chromium.org Original change's description: > Add plumbing for keymap > > > Change-Id: I5b68fd4345e9331c7de5f6947a4cc17cf5d5992a > Bug: 920824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495594 > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640047} Bug: 920824 Change-Id: I313dbc9c0a83bf69e0f5f51ba87f421585d460a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518404 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640339} remoting/protocol/BUILD.gn | 1 + ui/events/BUILD.gn | 29 ++++++++++++++++++++++ ui/events/keycodes/dom/dom_key_data.inc | 6 +++++ .../dom/keycode_conversion_data_android.inc | 3 +++ ui/events/keycodes/dom/keycode_converter_data.inc | 6 +++++ .../keycodes/keyboard_code_conversion_android.cc | 12 +++++++++ ui/events/keycodes/keyboard_codes_posix.h | 1 + ui/events/mojo/keyboard_codes.mojom | 1 + 8 files changed, 59 insertions(+) commit c5352ce8b8674f1f6fa1edf6b0d2d2066c795b57 Author: danakj <danakj@chromium.org> Date: Wed Mar 13 15:37:51 2019 +0000 Move background color into the kAll lifecycle update. It was done in the kPrePaint cycle but not for any good reason, it just was meant to not be part of the layout update. To avoid an extra branch and make it less "interesting" move the background color in with the rest of the painting updates. R=chrishtr@chromium.org Change-Id: I4bb7091ed86f7d29ca6bc36a8f137f6b15d26008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518903 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640338} third_party/blink/renderer/core/exported/web_view_impl.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 6409110fbdbed9b667cea03ca7462c51575bacba Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Wed Mar 13 15:37:11 2019 +0000 Remove the future flag from the policy templates for the LBS policies. BUG=none Change-Id: Iaa5e4a3950ce1d62158128faf0ca3e325961f377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520831 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640337} components/policy/resources/policy_templates.json | 9 --------- 1 file changed, 9 deletions(-) commit 1f08e365e3fcf33c7f3f8f2155462fc41042866c Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Mar 13 15:36:45 2019 +0000 [iOS][Translate] Add ios_chrome_translate_egtests to main waterfall and CQ Also adds the ios_chrome_translate_egtests target to the slimnav bot. Bug: 910994 Change-Id: I8e8d1cd960bbfe75bbdd3f4850915b08a450090f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518914 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640336} ios/build/bots/chromium.mac/ios-slimnav.json | 48 ++++++++++++++++++++++++++++ ios/build/bots/tests/eg_tests.json | 7 ++++ testing/buildbot/gn_isolate_map.pyl | 7 ++++ testing/buildbot/manage.py | 1 + 4 files changed, 63 insertions(+) commit bd7e1f6d838615c1a7d4b601c77f6b34e2a8d909 Author: Alexandre Frechette <frechette@chromium.org> Date: Wed Mar 13 15:30:08 2019 +0000 Removing iOS specific accept languages pref. language::prefs owns and registers the accept language pref. No need to have a duplicate in iOS specific code. Bug: 872096 Change-Id: I2f97ed0cd8b957b686b2d5ef3a044cbd88024352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515213 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640335} ios/chrome/browser/BUILD.gn | 1 + ios/chrome/browser/autocomplete/BUILD.gn | 1 + .../autocomplete/autocomplete_provider_client_impl.mm | 4 +++- ios/chrome/browser/ios_chrome_main_parts.mm | 4 +++- .../browser/language/language_model_manager_factory.cc | 15 +++++++-------- ios/chrome/browser/net/BUILD.gn | 1 + .../browser/net/ios_chrome_http_user_agent_settings.mm | 4 ++-- ios/chrome/browser/pref_names.cc | 4 ---- ios/chrome/browser/pref_names.h | 1 - ios/chrome/browser/prefs/browser_prefs.mm | 4 ++-- .../browser/translate/chrome_ios_translate_client.mm | 5 +++-- .../translate/translate_accept_languages_factory.cc | 4 ++-- ios/chrome/browser/ui/settings/BUILD.gn | 1 + .../settings/translate_table_view_controller_unittest.mm | 4 ++-- 14 files changed, 28 insertions(+), 25 deletions(-) commit 6de975a87311df3fb8dc667920b8dc2a2a8d60e2 Author: vasilii <vasilii@chromium.org> Date: Wed Mar 13 15:24:35 2019 +0000 Remove GetPreferredMatch from PasswordFormManagerForUI. The UI should not care about the notion of preferred match. It displays username/password for saving which should come from GetPendingCredentials. Bug: 831123 Change-Id: Ia659ed13228d5d5aae27e9313ec5f38ba8ea011d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520492 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#640334} .../core/browser/new_password_form_manager.cc | 4 ---- .../core/browser/new_password_form_manager.h | 1 - .../core/browser/password_form_manager.cc | 4 ---- .../core/browser/password_form_manager.h | 4 +++- .../core/browser/password_form_manager_for_ui.h | 2 -- .../core/browser/password_form_manager_unittest.cc | 16 ++++++++-------- .../ios_chrome_update_password_infobar_delegate.mm | 2 +- .../internal/passwords/cwv_password_controller.mm | 6 +----- 8 files changed, 13 insertions(+), 26 deletions(-) commit 5f687b58ce7488c0f97901ed07a2be94326d4f40 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Mar 13 15:24:06 2019 +0000 Don't use Mojo to get account info in identity_get_auth_token_function.cc identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetAccountInfoFromGaiaId() to C++. Bug: 913853 Change-Id: Icd27b8c3b42ea63bf18417f75884ae04a890978b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1458301 Reviewed-by: Lowell Manners <lowell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#640333} .../identity/identity_get_auth_token_function.cc | 67 ++++++++-------------- .../identity/identity_get_auth_token_function.h | 19 ++---- 2 files changed, 28 insertions(+), 58 deletions(-) commit 156c9bb2aa863c46686fcae139eb4ca9a0b672d6 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 13 15:20:14 2019 +0000 Update V8 to version 7.5.26. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4244ba53..61514a9c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e76c7d4f992aa4127b1ef8b34522b2d072e6e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520283 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640332} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 307a1077bcdca3fe8acbd0035ad922cef05d1e46 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Mar 13 15:12:25 2019 +0000 Remove WTF::RetainPtr now that it's no longer used Now that the last conversion from WTF::RetainPtr for the Mac build has been merged, wtf/retain_ptr.h is no longer used anywhere and we can safely remove it, so let's do it now to prevent new code from using WTF::RetainPtr again. Also, remove an stray include in wtf/text/string_impl_cf.cc that should have been removed along with CL1518573, when that file was migrated. Bug: 929973 Change-Id: I5307c1fbf716a4f581fc6b0fadec608f8661bcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520489 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#640331} third_party/blink/renderer/platform/wtf/BUILD.gn | 1 - .../blink/renderer/platform/wtf/retain_ptr.h | 328 --------------------- .../renderer/platform/wtf/text/string_impl_cf.cc | 1 - 3 files changed, 330 deletions(-) commit 5c92556da6b0b82aecacdd85abf090be1872e21b Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Mar 13 15:11:15 2019 +0000 service worker: Remove ServiceWorkerServicification field trial config. The feature already launched on Stable in Dec 2018 and has been enabled in the code since M72. Bug: 846235 Change-Id: Ib5e280b9809f8f69ede02abbb127d2d475c285c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519971 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#640330} testing/variations/fieldtrial_testing_config.json | 20 -------------------- 1 file changed, 20 deletions(-) commit ed7199ce9aabf8c353453bb6ff1ec3dba3b1df4f Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 15:07:16 2019 +0000 flags: remove enable-ble-advertising-in-apps This flag is practically unused in the field according to UMA. The switch is retained for development/debugging. Bug: None Change-Id: Iab1476a20a70abeb8b2e48d84fb1e0da4bf508ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517914 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#640329} chrome/browser/about_flags.cc | 6 ------ chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- extensions/common/api/bluetooth_low_energy.idl | 4 ++-- 5 files changed, 2 insertions(+), 21 deletions(-) commit eac3343138a438f2da4a30f8785f89345f8c2e48 Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Mar 13 15:06:12 2019 +0000 [PM] Retire kVisibility property. This retires the kVisibilityproperty from the page node as part of the refactor that aims to get rid of the "bag of properties" from node impls. BUG=910288 Change-Id: I351345e2f9841c7fa8469b71726c77ff751a83b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518922 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640328} .../graph/graph_introspector_impl.cc | 2 +- .../performance_manager/graph/page_node_impl.cc | 27 +++++++++++----------- .../performance_manager/graph/page_node_impl.h | 8 +++++-- .../graph/page_node_impl_unittest.cc | 4 ++-- .../observers/coordination_unit_graph_observer.h | 2 +- .../observers/metrics_collector.cc | 26 ++++++++++----------- .../observers/metrics_collector.h | 1 + .../public/mojom/signals.mojom | 1 - 8 files changed, 37 insertions(+), 34 deletions(-) commit 394375a5f931373fc697e95f05ea9cee324d258d Author: Tim Volodine <timvolodine@chromium.org> Date: Wed Mar 13 15:03:05 2019 +0000 [AW NS] Fix crash when safebrowsing is disabled in WebView When safe browsing is disabled and network service is enabled WebView crashes while it attempts to load a url. For Android WebView safe browsing can be disabled by means of global security settings in Android or by WebView's individual settings i.e. WebSettings.setSafeBrowsingEnabled(false). The crash happens due to a validating mojo DCHECK that results in a failure when SafeBrowsing::CreateCheckerAndCheckCallback is not being run or the corresponding binding destroyed (see crbug.com/889479 for details). This happens when UrlCheckerDelegate::ShouldSkipRequestCheck is true. Note that in the case of chrome, the ShouldSkipRequestCheck() method currently always returns false when network service is enabled. In this patch we make sure to execute the callback before it is destroyed. This patch also adds an instrumentation test to make sure this code path is covered. In particular making sure that RendererURLLoaderThrottle attempts to check a url through loading an image. BUG=889479,841556 Test: run_webview_instrumentation_test_apk \ Test: -f SafeBrowsingTest#testSafeBrowsingCanBeDisabledPerWebview_withImage \ Test: --enable-features="NetworkService,NetworkServiceInProcess" Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I51737e71f62cacea2e2d6dd0d6273f9865b9c824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512552 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#640327} .../chromium/android_webview/test/SafeBrowsingTest.java | 17 +++++++++++++++++ android_webview/test/data/malware_with_image.html | 15 +++++++++++++++ .../safe_browsing/browser/mojo_safe_browsing_impl.cc | 6 ++++++ 3 files changed, 38 insertions(+) commit 38047ee3fe1adeb061216ac6f3f877d1ca9660fa Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 15:01:05 2019 +0000 Change long long to int64_t in third_party/blink/renderer/core/loader/history_item.h - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I44be2fae69ab80dfe358bd3ce57ef6188b6dfb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520521 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640326} third_party/blink/public/web/web_history_item.h | 8 ++++---- third_party/blink/renderer/core/exported/web_history_item.cc | 8 ++++---- third_party/blink/renderer/core/loader/history_item.cc | 4 ++-- third_party/blink/renderer/core/loader/history_item.h | 10 ++++------ 4 files changed, 14 insertions(+), 16 deletions(-) commit 1e7abe5db9307589091a580b204869c5b07ab04c Author: Ovidio Henriquez <odejesush@chromium.org> Date: Wed Mar 13 15:00:04 2019 +0000 android: Add |mIsManaged| to ChosenObjectInfo This change adds a |mIsManaged| boolean to ChosenObjectInfo that is true if the source of the preference is content_settings::SETTING_SOURCE_POLICY. This will prepare policy allowed chosen objects to be displayed properly in the Site Settings UI. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w/edit#heading=h.z7uyjhrr3ac2 Bug: 854329 Change-Id: Iaa943154d8c62587dff0fbdfdb88ceb994d2d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1428040 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#640325} .../browser/preferences/website/ChosenObjectInfo.java | 19 +++++++++++++++---- .../preferences/website/WebsitePreferenceBridge.java | 6 ++++-- .../android/preferences/website_preference_bridge.cc | 5 ++++- 3 files changed, 23 insertions(+), 7 deletions(-) commit 7a4256c4af0c42eda8732ba54e5d469843cbf079 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Mar 13 14:58:25 2019 +0000 OOR-CORS: variation config for Android WebView Now that the server is ready to start field trial on Android WebView, we want to enable it in the variation config so to start the beta trial even on WebView. Bug: 905971 Change-Id: I5ea08ba4d41afaf2d43a5d1ec0db44d92b680a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519972 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640324} testing/variations/fieldtrial_testing_config.json | 1 + 1 file changed, 1 insertion(+) commit 8906d05e9c116136f2b0ad0076b8cba5002eefc3 Author: Alex Clarke <alexclarke@chromium.org> Date: Wed Mar 13 14:58:04 2019 +0000 Add base/parameter_pack.h a collection of parameter pack utils This will be used by base::Promise<>. Bug: 906125 Change-Id: I4e2dbb44947c336d8fffa8f571b4d2a96aaa25b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496858 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#640323} base/BUILD.gn | 2 + base/parameter_pack.h | 108 ++++++++++++++++++++++++++++++++++++++++ base/parameter_pack_unittest.cc | 76 ++++++++++++++++++++++++++++ base/traits_bag.h | 52 +++---------------- 4 files changed, 194 insertions(+), 44 deletions(-) commit 2e82627fffe46c0586a6303e07989117f6bd258e Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 14:55:03 2019 +0000 content: remove asvitkine@ as a mac owner This change removes asvitkine from //content/browser/renderer_host OWNERS per comment on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1516354 Ownership of ~all Mac code in //content rests with the //content/OWNERS Mac owners. Bug: None Change-Id: I4905ebd692de9be3adc45fe1ec516f187652df7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520694 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640322} content/browser/renderer_host/OWNERS | 3 --- 1 file changed, 3 deletions(-) commit 3d03fcc883363d185a2aa10ff77b49fbd0934766 Author: Eugene Girard <girard@chromium.org> Date: Wed Mar 13 14:51:32 2019 +0000 Revert "Make BLINK_ANIMATION_USE_TIME_DELTA visible to renderer:blink_pch" This reverts commit b1055ded27ad9c5ab25f6cf9ddfbcc3f6dd5e0f2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make BLINK_ANIMATION_USE_TIME_DELTA visible to renderer:blink_pch > > There is code in renderer/modules that isn't currently seeing the correct version of AnimationTimeDelta > third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc > > blink_unittests was failing to link with precompiled headers enabled. > > > Bug: 737867 > Change-Id: I437abd16e2d53a4ef05af8b95fdd01d2b9215a53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515682 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Eugene Girard <girard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640299} TBR=girard@chromium.org,thakis@chromium.org,smcgruer@chromium.org Change-Id: Id2b407be68f4e550131fc6c84dfd7bd67ddeb113 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521146 Reviewed-by: Eugene Girard <girard@chromium.org> Commit-Queue: Eugene Girard <girard@chromium.org> Cr-Commit-Position: refs/heads/master@{#640321} build/buildflag_header.gni | 4 ++-- third_party/blink/renderer/core/BUILD.gn | 7 +++++++ third_party/blink/renderer/core/animation/BUILD.gn | 17 ----------------- .../renderer/core/animation/animation_time_delta.cc | 2 +- .../renderer/core/animation/animation_time_delta.h | 7 +++---- third_party/blink/renderer/core/core.gni | 6 ++++++ 6 files changed, 19 insertions(+), 24 deletions(-) commit 1020095d64cf6ef824a0eb63dabb28d64d3d1b35 Author: Javier Fernandez <jfernandez@igalia.com> Date: Wed Mar 13 14:51:21 2019 +0000 Updated the css-text test suite Added a few additional tests to verify some leading white-space cases with different properties. Fixed also some typos and bad design choices in some tests. Change-Id: Ic702d9ce4bd969408c4760724f1f9d4a1f6eb6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520829 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#640320} .../overflow-wrap-break-word-007.html | 38 ++++++++++++++++++++++ .../wpt/css/css-text/white-space/pre-wrap-008.html | 38 ++++++++++++++++++++++ .../word-break/word-break-break-all-011.html | 5 +-- .../word-break/word-break-break-all-012.html | 4 +-- .../word-break/word-break-break-all-013.html | 4 +-- .../word-break/word-break-break-all-015.html | 38 ++++++++++++++++++++++ 6 files changed, 121 insertions(+), 6 deletions(-) commit 079c6346008c942fd2c89166a606c0e57a802a33 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 13 14:50:12 2019 +0000 [Extensions Bindings] Remove obsolete JS resources from //chrome With Native Extension Bindings, many surfaces and custom hooks are implemented natively in C++ rather than in JS. Remove the obsolete JS resources from //chrome/renderer/resources/extensions and update the resource file. TBR=tommycli@chromium.org (just removing files from renderer_resources.grd) Bug: 938998 Change-Id: I97322ccd0145227ab3178f3a0fe1b0a1fac705c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509898 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640319} chrome/renderer/BUILD.gn | 4 - .../chrome_extensions_dispatcher_delegate.cc | 11 -- .../resources/extensions/app_custom_bindings.js | 83 --------------- .../resources/extensions/chrome_setting.js | 59 ----------- .../resources/extensions/content_setting.js | 112 --------------------- .../extensions/easy_unlock_proximity_required.js | 20 ---- .../resources/extensions/tabs_custom_bindings.js | 56 ----------- chrome/renderer/resources/renderer_resources.grd | 5 - 8 files changed, 350 deletions(-) commit e8b5a4a57127389583747b266c770c0ce797390f Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 14:46:49 2019 +0000 Change long long to int64_t in third_party/blink/renderer/ related blob - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: Ibd0fa8efcbc3d61b6e1a27cac8e26260ad6b2097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519509 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640318} third_party/blink/public/platform/web_drag_data.h | 2 +- third_party/blink/public/platform/web_http_body.h | 12 ++++++------ third_party/blink/renderer/core/fileapi/blob.cc | 6 +++--- third_party/blink/renderer/core/fileapi/blob.h | 18 ++++++++---------- third_party/blink/renderer/core/fileapi/file.cc | 8 ++++---- third_party/blink/renderer/core/fileapi/file.h | 6 +++--- third_party/blink/renderer/platform/blob/blob_data.cc | 14 +++++++------- third_party/blink/renderer/platform/blob/blob_data.h | 14 +++++++------- .../blink/renderer/platform/exported/web_http_body.cc | 8 ++++---- third_party/blink/renderer/platform/file_metadata.cc | 2 +- third_party/blink/renderer/platform/file_metadata.h | 4 ++-- .../renderer/platform/network/encoded_form_data.cc | 4 ++-- .../renderer/platform/network/encoded_form_data.h | 12 ++++++------ 13 files changed, 54 insertions(+), 56 deletions(-) commit b61811edae1e237ba37680474bea4cada3f02e25 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 14:46:26 2019 +0000 Roll src/third_party/perfetto e96498a32500..c4e085dbb2c7 (7 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/e96498a32500..c4e085dbb2c7 git log e96498a32500..c4e085dbb2c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 nuskos@google.com Move the variable declaration down into the #if this fixes the windows build. 2019-03-13 eseckler@google.com Merge "trace buffer: Ignore empty packets" 2019-03-12 lalitm@google.com Merge "trace_processor: massively speed up thread/process name lookups" 2019-03-12 lalitm@google.com trace_processor: improve query performance involving filter operations 2019-03-12 primiano@google.com Merge "Rename service_impl_unittest to match src files" 2019-03-12 ilkos@google.com Merge "Change deque to vector in the critical path" 2019-03-12 hjd@google.com Merge "traced: Add kernel version to trace" Created with: gclient setdep -r src/third_party/perfetto@c4e085dbb2c7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1bf5ea3a338e0517e665c2ad79ca845915e8fb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520871 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640317} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0d06196b004473cf5400f7ddca5ad27aaa9ff0de Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 14:43:44 2019 +0000 Change long long to int64_t in third_party/blink/public/platform/platform.h - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I948d6cc6e58f61a68f7fcade5774c148e7fe03de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520525 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640316} content/child/blink_platform_impl.cc | 6 +++--- content/child/blink_platform_impl.h | 6 +++--- content/renderer/renderer_blink_platform_impl.cc | 6 +++--- content/renderer/renderer_blink_platform_impl.h | 6 +++--- third_party/blink/public/platform/platform.h | 6 +++--- 5 files changed, 15 insertions(+), 15 deletions(-) commit 2d471b944fcf59f93b0c92be334efdbabb851997 Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Mar 13 14:42:48 2019 +0000 Remove unused NSColor (WebNSColorDetails) category. It is unused since April 2013, just after the Blink fork. Change-Id: I9c01ddbdda5febff68fd6561e347c647554cdc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518762 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640315} third_party/blink/renderer/core/scroll/scrollbar_theme_mac.mm | 4 ---- 1 file changed, 4 deletions(-) commit 6b93dab96c0c42f0dfa3ee8a4d7c9965a58e336e Author: Peter Mayo <petermayo@chromium.org> Date: Wed Mar 13 14:42:38 2019 +0000 [CC] clean up some test code Three cc_unittests worked around the fact that the animation host for the class provided animation classes was out of date by directly calling the correct animation host on their behalf, instead of using then normally. This makes refactoring the animation host calls break the tests incorrectly. The fix is to reset the animation host for the timeline in tests that use it and have created their own local FakeLayerTreeHostImpl. While examining them I added a little more explicit positive and negative checks that the tests were operating on solid assertions. (i.e. the property they expected to cause skipping is reflected the way they expect, before they validate that the presence of an animation changes it.) Bug: 771316 Change-Id: I5a57b9cc34fc60721355fd291176ce9920991669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518060 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640314} cc/trees/layer_tree_host_common_unittest.cc | 141 ++++++++++++++++++---------- 1 file changed, 91 insertions(+), 50 deletions(-) commit 0c4f1c57aa6beaebd1845cf0fbb1ab5dd385d6ff Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 14:40:30 2019 +0000 Roll src-internal 55881f78ae39..63e898da8fa6 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55881f78ae39..63e898da8fa6 Created with: gclient setdep -r src-internal@63e898da8fa6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Ibfa1a1db6ca60005003dfbcd13787b95ce305bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520870 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640313} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8962bf5c72ae4ef7b7cd6eb6a1f86b28e574ecb0 Author: Clemens Arbesser <arbesser@google.com> Date: Wed Mar 13 14:33:25 2019 +0000 [Autofill Assistant] Added new script parameter to hide initial details. Bug: b/128498126 Change-Id: If26ff8f51df147f1efe98fe4274195aac857bfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520669 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#640312} components/autofill_assistant/browser/details.cc | 4 ++++ 1 file changed, 4 insertions(+) commit a5ba44736cdef7e0185be359c5456d8c2cd22a40 Author: Marc Treib <treib@chromium.org> Date: Wed Mar 13 14:30:43 2019 +0000 Cleanup: Remove syncer::SyncEngine::Status typedef It was an alias for syncer::SyncStatus. All call sites are updated to refer to syncer::SyncStatus directly. Bug: none Change-Id: Iff1c0d330076ab7c6309d434b9846b236c6c8ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520671 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#640311} chrome/browser/sync/sync_error_notifier_ash_unittest.cc | 1 - chrome/browser/sync/sync_ui_util_unittest.cc | 16 ++++++++-------- components/browser_sync/profile_sync_service.cc | 6 +++--- components/browser_sync/profile_sync_service_mock.h | 3 +-- components/sync/engine/fake_sync_engine.cc | 4 ++-- components/sync/engine/fake_sync_engine.h | 2 +- components/sync/engine/mock_sync_engine.h | 2 +- components/sync/engine/sync_engine.h | 3 +-- 8 files changed, 17 insertions(+), 20 deletions(-) commit b637c0ca971f1cc91b61bdc69e5aa22445076cf8 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Wed Mar 13 14:28:15 2019 +0000 Treat first cpu usage value as NaN, not 0.0 Bug: 668718 Change-Id: I98773b30052b83d9a40afde8845a1a4d1704cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515174 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#640310} chrome/browser/task_manager/sampling/task_group.h | 1 + chrome/browser/task_manager/sampling/task_group_sampler.cc | 11 +++++++++-- chrome/browser/task_manager/sampling/task_group_sampler.h | 4 ++++ 3 files changed, 14 insertions(+), 2 deletions(-) commit 043193d8e685e737f61c2a2299282f255fc4a551 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Mar 13 14:26:25 2019 +0000 SuperSize: Fix .pak section sizes being calculated incorrectly It was summing symbol.size for each section, but should have been using PSS. The point of section_sizes it to be measured differently from sum(symbols) though, so changed the logic to be the sum of .pak file sizes. Also fixes a bug where we were considering es-419.pak a non-locale pak and updates the pak compression ratio to be more appropriate for bundles, which a have a different set of strings. Change-Id: I2384975c540e6d27a378c03c1ec5f084617d4c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518055 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#640309} tools/binary_size/libsupersize/archive.py | 48 ++++++++++++---------- .../libsupersize/testdata/Archive_Apk.golden | 2 +- .../testdata/Archive_MinimalApks.golden | 2 +- .../libsupersize/testdata/Archive_Pak_Files.golden | 2 +- 4 files changed, 29 insertions(+), 25 deletions(-) commit d3b815ac5d2d55032e66d66d10f9b142b27fc998 Author: Marc Treib <treib@chromium.org> Date: Wed Mar 13 14:25:45 2019 +0000 Remove unused OneClickSigninLinksDelegate::OnAdvancedLinkClicked It was only called in a single test, which is now removed as well. Bug: none Change-Id: I9e82211d5b129c10dd911e7fa79c96029fae47f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508274 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#640308} chrome/browser/ui/sync/one_click_signin_links_delegate.h | 1 - .../browser/ui/sync/one_click_signin_links_delegate_impl.cc | 5 ----- .../browser/ui/sync/one_click_signin_links_delegate_impl.h | 1 - .../one_click_signin_links_delegate_impl_browsertest.cc | 13 ------------- .../ui/views/sync/one_click_signin_dialog_view_unittest.cc | 3 --- 5 files changed, 23 deletions(-) commit 76440d1909785239d0eac7265de02e4efa79a80c Author: David Roger <droger@chromium.org> Date: Wed Mar 13 14:20:46 2019 +0000 [signin] Rename SigninManager::OnExternalSigninCompleted Change-Id: I60b2e4f0e5456b50429dcd95c51ef9a6ba8aca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515575 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#640307} chrome/browser/android/signin/signin_manager_android.cc | 5 ++--- components/signin/core/browser/signin_manager.cc | 2 +- components/signin/core/browser/signin_manager.h | 8 +++----- components/signin/core/browser/signin_manager_unittest.cc | 14 +++++++------- services/identity/public/cpp/identity_test_utils.cc | 2 +- .../identity/public/cpp/primary_account_mutator_impl.cc | 2 +- 6 files changed, 15 insertions(+), 18 deletions(-) commit c0acb512366015c242cf040dca4da2c72df16d68 Author: kylechar <kylechar@chromium.org> Date: Wed Mar 13 14:03:37 2019 +0000 Reland: Remove RefCountedThreadSafe from CommandBufferTaskExecutor. CommandBufferTaskExecutor needs to be created and destroyed on the GPU thread. To ensure it's destroyed on the GPU thread we hold onto a scoped_refptr there and destroy it last. Owning the object there and passing around a raw pointer accomplishes the same thing with less complexity. This was originally landed in https://crrev.com/c/1340907 but was causing GPU crashes on Android. There was a bug on Android that triggered a deserialization error on viz::mojom::FrameSinkManager interface. This deserialization error has been fixed so we should no longer hit the same failure mode. Bug: none Change-Id: I51bb2bff50f2e12106581bcd016b0a0568a78b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518710 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640306} .../browser/gfx/aw_render_thread_context_provider.cc | 12 ++++++------ .../browser/gfx/aw_render_thread_context_provider.h | 7 +++---- android_webview/browser/gfx/deferred_gpu_command_service.cc | 5 ++--- cc/test/pixel_test.cc | 4 ++-- cc/test/pixel_test.h | 2 +- .../viz/service/display_embedder/gpu_display_provider.cc | 4 ++-- .../viz/service/display_embedder/gpu_display_provider.h | 4 ++-- .../viz/service/display_embedder/skia_output_surface_impl.cc | 7 ++++--- .../viz/service/display_embedder/skia_output_surface_impl.h | 4 ++-- .../display_embedder/skia_output_surface_impl_unittest.cc | 6 +++--- .../service/display_embedder/viz_process_context_provider.cc | 6 +++--- .../service/display_embedder/viz_process_context_provider.h | 4 ++-- components/viz/service/main/viz_compositor_thread_runner.cc | 10 +++++----- components/viz/service/main/viz_compositor_thread_runner.h | 9 ++++----- components/viz/service/main/viz_main_impl.cc | 5 +++-- components/viz/service/main/viz_main_impl.h | 11 ++--------- gpu/ipc/command_buffer_task_executor.h | 10 ++-------- gpu/ipc/gl_in_process_context.cc | 5 ++--- gpu/ipc/gl_in_process_context.h | 2 +- gpu/ipc/gpu_in_process_thread_service.h | 3 +-- gpu/ipc/in_process_command_buffer.cc | 7 +++---- gpu/ipc/in_process_command_buffer.h | 7 +++---- gpu/ipc/in_process_gpu_thread_holder.cc | 7 +++---- gpu/ipc/in_process_gpu_thread_holder.h | 4 ++-- gpu/ipc/raster_in_process_context.cc | 5 ++--- gpu/ipc/raster_in_process_context.h | 2 +- gpu/ipc/webgpu_in_process_context.cc | 5 ++--- gpu/ipc/webgpu_in_process_context.h | 2 +- 28 files changed, 69 insertions(+), 90 deletions(-) commit 55b1707524e1111aa3b48ccf0e926e9f97efb5f0 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Wed Mar 13 14:00:39 2019 +0000 [Autofill Assistant] Invalidate decorations when the width of a carousel changes. This CL ensures that the item decorations of a carousel are recomputed when its size .changes (e.g. when its parent is resized or when the user switches the orientation of the phone). Change-Id: Ic0e284cfca9f64db87027f8ea00c8d7cf1e3b852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520591 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#640305} .../carousel/AssistantCarouselCoordinator.java | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 0823a2cdc994dc6e61478b3fd6aa15a7275bb46f Author: Madeleine Barowsky <mbarowsky@chromium.org> Date: Wed Mar 13 13:59:58 2019 +0000 [Telemetry] Properly trace YUV decoding in blink_perf.image_decoder. This moves the TRACE_EVENT for ImageFrameGenerator::DecodeToYUV to more precisely measure the decode step and also allows test cases to specify whether numbers for YUV decoding should be collected in in addition to the typical RGB path. Because YUV decoding for WebP will be landing soon (crbug.com/900264), it is important that the decode-lossy-webp.html test collects these too. Last, adds an informative promise rejection handler for runImageDecoderPerfTests. Bug: 900589 Change-Id: I8c77aefc99221d4b69b69af1bc2e9988c196a3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516017 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by: Chris Blume <cblume@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640304} .../perf_tests/image_decoder/decode-lossy-webp.html | 3 ++- .../image_decoder/resources/image_decoder_runner.js | 16 ++++++++++++---- .../renderer/platform/graphics/image_frame_generator.cc | 10 ++++++---- 3 files changed, 20 insertions(+), 9 deletions(-) commit cd59c39457a03c9fae209ea655c80efc0795ad9e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 13:59:32 2019 +0000 Roll src/third_party/skia bac53f089dbc..6d31ddee3c16 (1 commits) https://skia.googlesource.com/skia.git/+log/bac53f089dbc..6d31ddee3c16 git log bac53f089dbc..6d31ddee3c16 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1407297b7f7d..25ec7b0cd393 (1 commits) Created with: gclient setdep -r src/third_party/skia@6d31ddee3c16 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Id4da9c60b5f1f91cca02326662e07b260204312d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520868 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640303} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ac70a0f74a7c7b8dbf3206ad8651021bdacdaea9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 13:52:02 2019 +0000 Roll src/third_party/webrtc 4f779c6aec77..1175ae0d800e (25 commits) https://webrtc.googlesource.com/src.git/+log/4f779c6aec77..1175ae0d800e git log 4f779c6aec77..1175ae0d800e --date=short --no-merges --format='%ad %ae %s' 2019-03-13 srte@webrtc.org Add log based GoogCC simulation to visualizer. 2019-03-13 ilnik@webrtc.org Restore VideoCodecInitializer to use only the 1st stream maxFramerate 2019-03-13 srte@webrtc.org Reland "Replacing rtc::Thread with task queue for TestAudioDeviceModule." 2019-03-13 srte@webrtc.org Removes TaskQueueBase::Current call in repeating task. 2019-03-13 srte@webrtc.org Removes usages of repeating task without task queue argument. 2019-03-12 amithi@webrtc.org Modifying MediaChannel to accept CopyOnWriteBuffer by value. 2019-03-12 benwright@webrtc.org Fuzz rtc::StringToNumber. 2019-03-12 benwright@webrtc.org Add generic depacketizer fuzzer to WebRTC. 2019-03-12 benwright@webrtc.org Field trial fuzzer. 2019-03-12 shampson@webrtc.org Revert "Replacing rtc::Thread with task queue for TestAudioDeviceModule." 2019-03-12 shampson@webrtc.org Revert "Reland "DCHECK feedback_rtt is positive"" 2019-03-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8158f07c24..48038209dc (639862:640007) 2019-03-12 srte@webrtc.org Replacing rtc::Thread with task queue for TestAudioDeviceModule. 2019-03-12 eshr@google.com Reland "DCHECK feedback_rtt is positive" 2019-03-12 srte@webrtc.org Allow construction of TaskQueueForTest with TaskQueueBase 2019-03-12 jakobi@webrtc.org Check current buffer time span instead of number of samples in postpone decoding after expand. 2019-03-12 nisse@webrtc.org Delete VCMPacket constructor with WebRtcRTPHeader 2019-03-12 ivoc@webrtc.org Revert "NetEQ RTP Play: Optionally write output audio file" 2019-03-12 jonasolsson@webrtc.org Enable configuring probes via field trial. 2019-03-12 jonasolsson@webrtc.org Make FieldTrialOptionals operator bool() explicit 2019-03-12 nisse@webrtc.org Pass flexfec_sender only to the protected media send stream. 2019-03-12 titovartem@google.com Introduce EmulatedRoute 2019-03-12 titovartem@google.com Rename EndpointConfig into EmulatedEndpointConfig 2019-03-12 tommi@webrtc.org Remove dependency on DirectShow baseclasses (streams.h from the winsdk_samples directory). 2019-03-12 kuddai@google.com Change some RTC_DCHECKs to RTC_DCHECK_EQ Created with: gclient setdep -r src/third_party/webrtc@1175ae0d800e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:940466,chromium:None,chromium:None,chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: If262e1e0e7a3ded8d984d4072d88be2a67444ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520807 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640302} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ad72bf2887353709d5531ecd9f2bd4fdd2694c30 Author: Jesse Doherty <jwd@chromium.org> Date: Wed Mar 13 13:48:40 2019 +0000 Add ios implementation of GetUploadSigningKey. Bug: 906202 Change-Id: I3ca61a525286d04383c3c0d23a610724bfa51a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518249 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#640301} ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h | 1 + ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm | 8 ++++++++ 2 files changed, 9 insertions(+) commit f58a54747bc1f2f34a371783fba0c4194a45d932 Author: Philip Jägenstedt <foolip@chromium.org> Date: Wed Mar 13 13:47:44 2019 +0000 Mark new CSS Transforms test as flaky It's not necessarily flaky, but has both passed and failed when going through automatic import. Marking it flaky to unblock automatic imports. TBR=robertma@chromium.org No-Try: true Bug: 941471 Change-Id: I9cab0eecaf24f60a84baee4ca8e09cfaa804e89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520673 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#640300} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit b1055ded27ad9c5ab25f6cf9ddfbcc3f6dd5e0f2 Author: Eugene Girard <girard@chromium.org> Date: Wed Mar 13 13:46:52 2019 +0000 Make BLINK_ANIMATION_USE_TIME_DELTA visible to renderer:blink_pch There is code in renderer/modules that isn't currently seeing the correct version of AnimationTimeDelta third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc blink_unittests was failing to link with precompiled headers enabled. Bug: 737867 Change-Id: I437abd16e2d53a4ef05af8b95fdd01d2b9215a53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515682 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Eugene Girard <girard@chromium.org> Cr-Commit-Position: refs/heads/master@{#640299} build/buildflag_header.gni | 4 ++-- third_party/blink/renderer/core/BUILD.gn | 7 ------- third_party/blink/renderer/core/animation/BUILD.gn | 17 +++++++++++++++++ .../renderer/core/animation/animation_time_delta.cc | 2 +- .../renderer/core/animation/animation_time_delta.h | 7 ++++--- third_party/blink/renderer/core/core.gni | 6 ------ 6 files changed, 24 insertions(+), 19 deletions(-) commit b815500c12eae519b6a9b4c09b93fcf5494940a2 Author: Camille Lamy <clamy@chromium.org> Date: Wed Mar 13 13:46:39 2019 +0000 Make some tests use NavigationSimulator This CL converts several content_unittests to use NavigationSimulator instead of calls to TestRenderFrameHost. This is needed to start enforcing having a NavigationRequest at commit time and swap RenderFrameHost on each navigation. Bug: 728571 Change-Id: I6305a667ed8519feb69699d50341a6384f5dcafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517711 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#640298} .../navigation_controller_impl_unittest.cc | 9 +- .../browser/frame_host/navigator_impl_unittest.cc | 7 +- .../render_frame_host_manager_unittest.cc | 148 ++++----------------- .../web_contents/web_contents_impl_unittest.cc | 67 ++++------ 4 files changed, 64 insertions(+), 167 deletions(-) commit 0b99a4a11648ab6ce0c680887266ac9487426e14 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Wed Mar 13 13:45:28 2019 +0000 Adding 1 extension to the allowlist. Bug: 941215 Change-Id: Ica5568e57228ad046f9b819fcb318cdcd1883fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518406 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#640297} extensions/browser/url_loader_factory_manager.cc | 1 + 1 file changed, 1 insertion(+) commit a2799bcb5f546fd225a834df89f7962158f1e812 Author: Stephane Zermatten <szermatt@chromium.org> Date: Wed Mar 13 13:43:38 2019 +0000 [Autofill Assistant] Fix URL generated for non-authenticated request. Before this change, the string generate for non-authenticated requests did not reliably include the desired query string. This is because StringPieceReplacements keeps a reference on the strings it's given, instead of copying. The string returned by base::StrCat was not guaranteed to be kept around when ReplaceComponents() was called. This issue only affected testing, as authentication is required in production. Change-Id: I74b1c846a4d2067d6ae971ee718166d47af01ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520832 Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#640296} components/autofill_assistant/browser/service.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 820d4a63d429b675887f2a35f9fd81fef19962c3 Author: Jonathan Backer <backer@chromium.org> Date: Wed Mar 13 13:35:00 2019 +0000 Only CheckResetStatus if !WasContextLost This fixes a bug introduced in https://crrev.com/c/1503342 Bug: 939208 Change-Id: I6a406c7a668a98a74a00da74f197d96ed7516d0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518759 Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640295} gpu/command_buffer/tests/fuzzer_main.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 81e969d45bca772a488ae276cd9203870cc7e915 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 13:29:54 2019 +0000 Roll src-internal 5b3d78461572..55881f78ae39 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5b3d78461572..55881f78ae39 Created with: gclient setdep -r src-internal@55881f78ae39 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I28672c350e0e8a96373c74975985d4cbf677279f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520867 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640294} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bf59ad27ed534a6547b098b0116635def0667dae Author: Peter Wen <wnwen@chromium.org> Date: Wed Mar 13 13:25:39 2019 +0000 Android: Clarify reason for full third-party review Android deps can pull in any number of dependencies on maven through gradle. Thus we want third_party/OWNERS to be the gatekeepers and new libraries to go through full, proper, third-party review. Bug: 938950 Change-Id: I764f3201627df79c2b76d2f70a747bdcfa44249a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506454 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#640293} third_party/android_deps/OWNERS | 2 ++ third_party/android_deps/libs/OWNERS | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) commit 87db47624fde76e30cd29a9d7516bf590ad9a4ba Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Mar 13 13:17:29 2019 +0000 [Sync] Fix flaky MC_MergeDifferentBMModelsModeratelyComplex Enable Sync on clients one at a time in order to avoid race conditions. Bug: 908771 Change-Id: I73c78f9922060c2d09f9099314fc8547367a8258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520834 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640292} .../sync/test/integration/two_client_bookmarks_sync_test.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit 8106d8081eead915606f3f8ee09f5196e48c46dd Author: Tien Mai <tienmai@chromium.org> Date: Wed Mar 13 13:13:50 2019 +0000 [GCPW] Fix mdm enrollment errors when no other user is signed in. MDM enrollment requires that a user is signed in interactively at the time of enrollment. To fix this we move the enrollment code to the SaveAccountInfo step that occurs after the user has successfully signed in. Change-Id: I05372a4f8a8f0d48f1ed220e48fddce398b3641c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519553 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#640291} chrome/credential_provider/gaiacp/dllmain.cc | 8 ++ .../gaiacp/gaia_credential_base.cc | 7 -- .../gaiacp/gaia_credential_base_unittests.cc | 87 ---------------------- 3 files changed, 8 insertions(+), 94 deletions(-) commit c86b0e3d8a8604c656838382dbf2fee374e800f8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 13:10:17 2019 +0000 Roll src/third_party/swiftshader 1407297b7f7d..25ec7b0cd393 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1407297b7f7d..25ec7b0cd393 git log 1407297b7f7d..25ec7b0cd393 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 sugoi@google.com Removed references to sw::Surface Created with: gclient setdep -r src/third_party/swiftshader@25ec7b0cd393 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: Iab9d227b8780ca6473a0f7661d1b92a4c7b761b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520866 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640290} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 74d308303d9869b8c3f445a1da885f36a820c8fa Author: Lowell Manners <lowell@chromium.org> Date: Wed Mar 13 13:00:30 2019 +0000 SigninManagerBase: Change AddObserver to SetObserver. IdentityManager is intended to be the sole observer of SigninManagerBase, so we shouldn't allow multiple observers. Bug: 939372 Change-Id: I81454f4174e19c1dad8fe38df4191878fa9512e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515573 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#640289} components/signin/core/browser/signin_manager.cc | 14 +-- .../signin/core/browser/signin_manager_base.cc | 21 ++-- .../signin/core/browser/signin_manager_base.h | 15 +-- .../signin/core/browser/signin_manager_unittest.cc | 10 +- services/identity/public/cpp/identity_manager.cc | 4 +- .../public/cpp/identity_manager_unittest.cc | 114 --------------------- 6 files changed, 36 insertions(+), 142 deletions(-) commit 2e97b1552a4d73a3368ad5fd01a4fbd3546b8667 Author: David Jean <djean@chromium.org> Date: Wed Mar 13 13:00:09 2019 +0000 [ios] add url_load_params to url loading service. Leaving use of OpenNewTabCommand and ChromeLoadParams alone for now, but opened the road to deprecate their use in the loader. Bug: 907527 Change-Id: Ie20e7ccaf348b112ee39406ea573902957ef58bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503261 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640288} ios/chrome/app/BUILD.gn | 1 - ios/chrome/app/main_controller.mm | 2 +- .../bookmarks/bookmark_interaction_controller.mm | 2 +- ios/chrome/browser/ui/browser_view_controller.mm | 8 +- .../ui/content_suggestions/ntp_home_mediator.mm | 4 +- .../ntp_home_mediator_unittest.mm | 9 +- .../location_bar_coordinator_unittest.mm | 34 ++--- ios/chrome/browser/ui/main/BUILD.gn | 1 - ios/chrome/browser/ui/main/browser_coordinator.mm | 8 +- .../ui/page_info/page_info_legacy_coordinator.mm | 2 +- .../ui/reading_list/reading_list_coordinator.mm | 2 +- .../static_html_view_controller_unittest.mm | 21 +-- ios/chrome/browser/url_loading/BUILD.gn | 24 +--- .../browser/url_loading/app_url_loading_service.h | 6 +- .../browser/url_loading/app_url_loading_service.mm | 11 +- .../url_loading/test_app_url_loading_service.h | 8 +- .../url_loading/test_app_url_loading_service.mm | 8 +- .../browser/url_loading/test_url_loading_service.h | 33 +++-- .../url_loading/test_url_loading_service.mm | 25 ++-- .../browser/url_loading/url_loading_params.h | 9 ++ .../browser/url_loading/url_loading_params.mm | 10 ++ .../browser/url_loading/url_loading_service.h | 29 ++-- .../browser/url_loading/url_loading_service.mm | 151 +++++++++++++-------- .../url_loading/url_loading_service_unittest.mm | 31 ++--- 24 files changed, 246 insertions(+), 193 deletions(-) commit 84f141fd263fbb6371efc70c5be22fd12a24269f Author: Tanmoy Mollik <triploblastic@google.com> Date: Wed Mar 13 12:55:26 2019 +0000 Added memory dump for GrShaderCache Bug: 913935 Change-Id: Iaf5f1a27215a3802d9baa62681787aee7de45259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503415 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640287} gpu/command_buffer/service/gr_shader_cache.cc | 31 +++++++++++++++++++++++++-- gpu/command_buffer/service/gr_shader_cache.h | 7 +++++- 2 files changed, 35 insertions(+), 3 deletions(-) commit 3a9a6014d1e70d5c009b7a02442088c21ee81e7c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 13 12:50:05 2019 +0000 Update V8 to version 7.5.24. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8252496f..4244ba53 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia52dbe8eccaab353a1ed054e9ecc6a2bccd6e79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520311 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640286} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 787bf4cabe3d8f8bef8a7bb153e80ac266457d16 Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Wed Mar 13 12:27:48 2019 +0000 Automated Commit: LKGM 11919.0.0 for chromeos. BUG=762641 TBR=afakhry@google.com Change-Id: Ibf7a5becec61ae1fd1235ad3f5443524035d88c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520312 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640285} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e18ad7fb23409af91e60f68f9a2b87f72e2a9795 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 12:13:53 2019 +0000 Roll src-internal c124f12e44a5..5b3d78461572 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c124f12e44a5..5b3d78461572 Created with: gclient setdep -r src-internal@5b3d78461572 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I35ee483690802eedaf664ae7a8ad3007bd8f2169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520806 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640284} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 525a662d57a7086cb086e2ca2e090fcd5646c2ca Author: Mikhail Khokhlov <khokhlov@google.com> Date: Wed Mar 13 12:10:51 2019 +0000 Add possible_browser argument to all shared state constructors Currently FindBrowser() is called several times from different parts of code. To simplify and speed up the code, we want to construct a PossibleBrowser object only once and pass it everywhere. Now that SharedState has an optional possible_browser argument (see https://chromium-review.googlesource.com/c/catapult/+/1514535), we add it to all its derived classes. Bug: 939374 Change-Id: I8e245505db127a57012de05833154181fe35acb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514635 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#640283} tools/perf/benchmarks/startup_mobile.py | 7 ++++--- tools/perf/contrib/cluster_telemetry/shared_browserless_story.py | 4 ++-- tools/perf/contrib/vr_benchmarks/shared_android_vr_page_state.py | 6 +++--- tools/perf/page_sets/dual_browser_story.py | 5 +++-- tools/perf/page_sets/idle_platform.py | 5 +++-- 5 files changed, 15 insertions(+), 12 deletions(-) commit 0cecf4b5fd14b4ce373a9341cae090058aa9daba Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Wed Mar 13 11:52:35 2019 +0000 OnionSoup: Move insecure_input_service.mojom to public/mojom folder This CL moves public/platform/modules/insecure_input to public/mojom/ to gather mojom files to mojom folder and updates paths for insecure_input_service.mojom. Bug: 919393 Change-Id: I04257105a156ee903b3492c576d191dc31ed1522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514333 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#640282} chrome/browser/DEPS | 1 - chrome/browser/ssl/insecure_sensitive_input_driver.h | 2 +- chrome/browser/ssl/insecure_sensitive_input_driver_factory.h | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 1 + .../blink/public/{platform/modules => mojom}/insecure_input/OWNERS | 0 .../modules => mojom}/insecure_input/insecure_input_service.mojom | 0 third_party/blink/renderer/core/dom/document.cc | 2 +- third_party/blink/renderer/core/html/forms/password_input_type_test.cc | 2 +- 9 files changed, 5 insertions(+), 6 deletions(-) commit c58a0bf61c9b417fcdd17cc271da4b046c108925 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Wed Mar 13 11:49:12 2019 +0000 Updating trunk VERSION from 3732.0 to 3733.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I6967043cee6b73231213f41182c40459169f846e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520690 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#640281} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 629c542e4620714155a77393dcf928c39fe3309f Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Mar 13 11:28:01 2019 +0000 [Sync] Deprecate EXPERIMENTS Sync datatype Bug: 939819 Change-Id: Iaf823091860b4d9535d2924cc8a7c0aa2a02bf53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515537 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#640280} components/sync/PRESUBMIT.py | 3 +- components/sync/base/data_type_histogram.h | 2 +- components/sync/base/model_type.h | 14 +-- components/sync/base/sync_prefs.cc | 2 +- .../sync/driver/glue/sync_engine_impl_unittest.cc | 2 +- .../sync/driver/model_association_manager.cc | 8 +- .../sync/engine_impl/apply_control_data_updates.cc | 117 ++++---------------- .../sync/engine_impl/apply_control_data_updates.h | 13 +-- .../apply_control_data_updates_unittest.cc | 122 ++------------------- .../sync/engine_impl/sync_manager_impl_unittest.cc | 1 - components/sync/engine_impl/syncer.cc | 4 +- components/sync/syncable/base_node.cc | 5 - components/sync/syncable/base_node.h | 4 - components/sync/syncable/model_type.cc | 6 +- 14 files changed, 57 insertions(+), 246 deletions(-) commit fec19daa3b8faa6ace8737512473b2af2c3cd197 Author: Kush Sinha <sinhak@chromium.org> Date: Wed Mar 13 10:55:54 2019 +0000 Componentize Chrome OS Account Manager Bug: 939751 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Test: components_unittests --gtest_filter="*CrOSOAuthDelegateTest*" Test: browser_tests Change-Id: Ic13756eb1560f2ef2eb8c54899451f02c35f2990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517902 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#640279} .../browser_process_platform_part_chromeos.cc | 2 +- chrome/browser/chromeos/BUILD.gn | 1 + .../account_manager/account_manager_migrator.cc | 4 +- .../authpolicy/auth_policy_credentials_manager.cc | 4 +- chrome/browser/profiles/profile_impl.cc | 4 +- .../signin/profile_oauth2_token_service_factory.cc | 2 +- chrome/browser/sync/test/integration/sync_test.cc | 4 +- chrome/browser/ui/BUILD.gn | 1 + .../local_discovery_ui_browsertest.cc | 4 +- .../settings/chromeos/account_manager_handler.cc | 3 +- .../settings/chromeos/account_manager_handler.h | 2 +- chrome/browser/ui/webui/settings/md_settings_ui.cc | 4 +- .../webui/signin/inline_login_handler_chromeos.cc | 4 +- .../webui/signin/inline_login_handler_chromeos.h | 3 +- chrome/test/base/testing_profile.cc | 4 +- chromeos/BUILD.gn | 14 ------ chromeos/components/BUILD.gn | 1 + chromeos/components/account_manager/BUILD.gn | 55 ++++++++++++++++++++++ chromeos/{ => components}/account_manager/DEPS | 0 chromeos/{ => components}/account_manager/OWNERS | 0 .../account_manager/account_manager.cc | 8 ++-- .../account_manager/account_manager.h | 18 +++---- .../account_manager/account_manager_factory.cc | 4 +- .../account_manager/account_manager_factory.h | 11 +++-- .../account_manager/account_manager_unittest.cc | 2 +- .../{ => components}/account_manager/tokens.proto | 0 components/signin/core/browser/BUILD.gn | 4 +- components/signin/core/browser/DEPS | 2 +- ...ofile_oauth2_token_service_delegate_chromeos.cc | 1 - ...rofile_oauth2_token_service_delegate_chromeos.h | 2 +- ...th2_token_service_delegate_chromeos_unittest.cc | 2 +- 31 files changed, 107 insertions(+), 63 deletions(-) commit 0e4b4b599e0f8bb3ac848bd57e12332a110b2aed Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 10:55:36 2019 +0000 Roll src-internal 84907f082233..c124f12e44a5 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/84907f082233..c124f12e44a5 Created with: gclient setdep -r src-internal@c124f12e44a5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I56aea620710cdc65ccdb04bef84a7b08aa9457ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520293 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640278} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4419c1e7259d79dc23aad8363443bfe1022b1b29 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 10:51:52 2019 +0000 Roll src/third_party/dawn 8d79f78c789d..ea2c7f20f2f9 (1 commits) https://dawn.googlesource.com/dawn.git/+log/8d79f78c789d..ea2c7f20f2f9 git log 8d79f78c789d..ea2c7f20f2f9 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 cwallez@chromium.org TextureMTL: Use managed storage mode for IOSurfaces Created with: gclient setdep -r src/third_party/dawn@ea2c7f20f2f9 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I153f3bd5f2bfdd1ffe7b0d44c80dc41f9510d9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520292 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640277} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1d79137b330b3a0a5317f8650c2eff016bd48981 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Mar 13 10:36:22 2019 +0000 [Sync] Fix presubmit.py that didn't count comment line components/sync/PRESUBMIT.py has a bug since May 2018 that lines in model_type.cc weren't counted correctly by ignoring the comment lines. Change-Id: Ia27663861ecd9b7d7691b7c2cc104fcd1f3aa46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520589 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#640276} components/sync/PRESUBMIT.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b6c5c4932656be6eb90f0974380bf530169176f1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 10:24:25 2019 +0000 Roll src/third_party/pdfium d2cd38cdf78f..812b09bf5822 (1 commits) https://pdfium.googlesource.com/pdfium.git/+log/d2cd38cdf78f..812b09bf5822 git log d2cd38cdf78f..812b09bf5822 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 thestig@chromium.org Add pdf_formcalc_context_fuzzer. Created with: gclient setdep -r src/third_party/pdfium@812b09bf5822 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0f11669fcfbb5006740b7707504f7f5ca67bfe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520291 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640275} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 142e5a367007576535ba397dfe3f596f26eef193 Author: Marc Treib <treib@chromium.org> Date: Wed Mar 13 10:17:49 2019 +0000 sync_ui_util::ShouldRequestSyncConfirmation: don't check IsSyncRequested Before this CL, ShouldRequestSyncConfirmation() checked (among other things) "IsAuthenticatedAccountPrimary() && IsSyncRequested()". However, after a "Reset Sync" operation from the dashboard, IsSyncRequested() is set to false, which means ShouldRequestSyncConfirmation() is false, which means GetMessagesForAvatarSyncError() returns NO_SYNC_ERROR, which means no error shows up in the avatar menu - it still claims "Syncing to <account>", which is clearly wrong. To fix this, this CL simply drops the IsSyncRequested() check from ShouldRequestSyncConfirmation(). This is safe, because a dashboard reset is the only situation that can get the user into a primary-account-but- Sync-not-requested state (and even if there were another way to get into that state, we'd want to treat it as an error too). Note that this is only relevant for managed (i.e. enterprise) accounts, since all other accounts get signed out when Sync is reset from the dashboard. Bug: 936882 Change-Id: I4d40efaf8fc145e4db6b30bb4c44f0245f6f387b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517911 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#640274} chrome/browser/sync/sync_ui_util.cc | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 4a064a92747bd0515d55308b48182842faa506d1 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Wed Mar 13 10:17:45 2019 +0000 OnionSoup: Move lock_manager.mojom to public/mojom folder This CL moves platform/modules/locks to public/mojom/ to gather mojom files to mojom folder and updates paths for lock_manager.mojom. Bug: 919393 Change-Id: Iba329201034e73dc8c59d83c7a5c79b37d284ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510627 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#640273} content/browser/DEPS | 1 - content/browser/locks/lock_manager.h | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 1 + third_party/blink/public/{platform/modules => mojom}/locks/OWNERS | 0 .../blink/public/{platform/modules => mojom}/locks/lock_manager.mojom | 0 third_party/blink/renderer/modules/locks/lock.h | 2 +- third_party/blink/renderer/modules/locks/lock_manager.h | 2 +- 8 files changed, 4 insertions(+), 5 deletions(-) commit 628d60a2ccd84c2e4cebf0e12a76c71ab8c13903 Author: Mohamed Amir Yosef <mamir@chromium.org> Date: Wed Mar 13 10:11:42 2019 +0000 [Sync] Delete the obselete pref kSyncLongPollIntervalSeconds This is a follow up to this patch. http://crrev.com/c/1511975 which made the kSyncLongPollIntervalSeconds pref obsolete. Bug: 930125 Change-Id: I2566bb2121ea63363cb034e3b0158cf1a437d268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518577 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#640272} chrome/browser/prefs/browser_prefs.cc | 1 + components/sync/base/pref_names.cc | 1 - components/sync/base/pref_names.h | 1 - components/sync/base/sync_prefs.cc | 11 ++++++++--- components/sync/base/sync_prefs.h | 1 + 5 files changed, 10 insertions(+), 5 deletions(-) commit a04248122cce4d68f277c6c3e0c9c6612e0ce70b Author: Khushal <khushalsagar@chromium.org> Date: Wed Mar 13 10:05:43 2019 +0000 chrome/android: Update refresh rate on display changed. Currently the Vsync monitor, which decides the refresh rate for the display compositor, uses a constant refresh rate queried at initialization. Ensure that it is updated if the display refresh rate changed. TBR=boliu@chromium.org Bug: 937031 Change-Id: I61a6d3bc06c5369732362671b97b967a40863296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513080 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Aldo Culquicondor <acondor@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#640271} .../org/chromium/chrome/browser/vr/VrShell.java | 2 +- .../viz/common/frame_sinks/begin_frame_source.h | 7 ++++++ .../external_begin_frame_source_android.cc | 11 ++++++-- .../external_begin_frame_source_android.h | 3 ++- ...external_begin_frame_source_android_unittest.cc | 16 +++++++++++- .../frame_sinks/root_compositor_frame_sink_impl.cc | 8 +++++- .../frame_sinks/root_compositor_frame_sink_impl.h | 1 + .../ExternalBeginFrameSourceAndroid.java | 11 ++++++-- .../overscroll_controller_android_unittest.cc | 1 + .../renderer_host/compositor_impl_android.cc | 7 ++++++ .../renderer_host/compositor_impl_android.h | 1 + .../interfaces/compositing/display_private.mojom | 4 +++ .../compositing/frame_sink_manager.mojom | 3 +++ .../delegated_frame_host_android_unittest.cc | 1 + .../java/src/org/chromium/ui/VSyncMonitor.java | 19 +++++++------- .../src/org/chromium/ui/base/WindowAndroid.java | 20 ++++++++++++--- .../org/chromium/ui/display/DisplayAndroid.java | 29 +++++++++++++++++++--- .../ui/display/PhysicalDisplayAndroid.java | 3 ++- .../chromium/ui/display/VirtualDisplayAndroid.java | 8 +++--- ui/android/window_android.cc | 13 ++++++++++ ui/android/window_android.h | 4 +++ ui/android/window_android_compositor.h | 1 + 22 files changed, 146 insertions(+), 27 deletions(-) commit ea2e19afda39f8174e3ae1bf38c55ec1ea7116ab Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Wed Mar 13 09:59:49 2019 +0000 OnionSoup: Move hyphenation.mojom to public/mojom folder This CL moves platform/modules/hyphenation to public/mojom/ to gather mojom files to mojom folder and updates paths for hyphenation.mojom. Bug: 919393 Change-Id: I079cd10ac25f0301371bc5fa99c3b84552cabd4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511174 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#640270} content/browser/hyphenation/DEPS | 2 +- content/browser/hyphenation/hyphenation_impl.h | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 1 + third_party/blink/public/{platform/modules => mojom}/hyphenation/OWNERS | 0 .../public/{platform/modules => mojom}/hyphenation/hyphenation.mojom | 0 .../blink/renderer/platform/text/hyphenation/hyphenation_minikin.cc | 2 +- 7 files changed, 4 insertions(+), 4 deletions(-) commit e65a23e61708be3eafdb8a82bc4dd073f5333379 Author: Eliot Courtney <edcourtney@google.com> Date: Wed Mar 13 09:59:12 2019 +0000 Minimize ARC windows before hiding them when showing the launcher. This will make sure occlusion updates are sent to the ARC windows before they lose focus. This allows auto-PIP to happen upon showing the launcher. Bug: 910304 Test: unit test Change-Id: I893d37f3447f216c404790c13ec19f10d97bf5db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517481 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#640269} ash/wm/window_util.cc | 8 +++++--- ash/wm/window_util_unittest.cc | 40 ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+), 3 deletions(-) commit 97e94e2636f2d3ff1190f380c504f1c6d7428985 Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Wed Mar 13 09:58:41 2019 +0000 [css-properties-values-api] Substitute initial values as computed values. Registered custom properties substitute as token sequences equivalent to their computed values. We already do this correctly for non-initial values, but when substituting the initial value of a registered custom property, we would substitute the original token sequence instead of the computed value equivalent. R=futhark@chromium.org Bug: 641877 Change-Id: Icc9b8844d98cefd030be0daa91aef7963d55d7bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517700 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#640268} .../renderer/core/css/property_registration.cc | 6 ++-- .../core/css/resolver/css_variable_resolver.cc | 32 ++------------------ .../core/css/resolver/style_builder_converter.cc | 34 ++++++++++++++++++++++ .../core/css/resolver/style_builder_converter.h | 5 ++++ .../registered-property-initial.html | 20 +++++++++++-- 5 files changed, 63 insertions(+), 34 deletions(-) commit 63f7eed250be40fde1ff97a9e24ecba8c8f59b5b Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Mar 13 09:56:37 2019 +0000 OOR-CORS: use network::features::ShouldEnableOutOfBlinkCors To be consistent, it would be better to call network::features::ShouldEnableOutOfBlinkCors rather than checking network::features::kOutOfBlinkCors. Bug: 905971 Change-Id: I0a866020ea3a170a3b666173103b1012d4154cfc TBR: kinuko@chromium.org TBR: rdevlin.cronin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520512 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#640267} content/browser/service_worker/service_worker_browsertest.cc | 2 +- .../browser/api/web_request/web_request_proxying_url_loader_factory.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 62f0e41d0494a2a109a9919f82e108b4800985d5 Author: Alex Clarke <alexclarke@chromium.org> Date: Wed Mar 13 09:55:35 2019 +0000 Use SchedulerLock in SequenceManager Change-Id: Ie63f09f2d1a040185ef82baec4010bf65cd58759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505433 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#640266} base/task/sequence_manager/task_queue.cc | 4 +- base/task/sequence_manager/task_queue.h | 5 ++- base/task/sequence_manager/task_queue_impl.cc | 44 +++++++++++----------- base/task/sequence_manager/task_queue_impl.h | 3 +- .../thread_controller_with_message_pump_impl.cc | 7 ++-- .../thread_controller_with_message_pump_impl.h | 3 +- 6 files changed, 35 insertions(+), 31 deletions(-) commit 6c84fd8d855606e1da810157ffdc7122d4c75a63 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 09:52:17 2019 +0000 Roll src-internal aacd6fc869ed..84907f082233 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aacd6fc869ed..84907f082233 Created with: gclient setdep -r src-internal@84907f082233 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I186e7f0e2b3441691f50757ce161fa85dd423722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520289 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640265} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e4a8b6a5da9e86aaa915528c88a09f59b1340052 Author: Maksim Sisov <msisov@igalia.com> Date: Wed Mar 13 09:51:19 2019 +0000 ozone: enable ozone_unittests enable ozone_unittests on linux-ozone-rel bot with experiment_percentage: 100 Bug: 700309 Change-Id: Id1031f63c1f677da915af9dfccb5f836d89e6d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503324 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640264} testing/buildbot/chromium.linux.json | 7 +++++++ testing/buildbot/test_suites.pyl | 3 +++ 2 files changed, 10 insertions(+) commit e54a200fc898ab95fdebf73dc171d57a0d5b2ef8 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Mar 13 09:50:17 2019 +0000 Convert away from method method JSONReader::ReadDeprecated Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value> and convert surrounding code to the new base::Value API. Bug: 925165 Change-Id: Ib40acdfea5eb1f68f9afb4b563a82fc997dee961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517904 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#640263} .../autofill/core/browser/legal_message_line.cc | 61 ++++++++++++---------- .../autofill/core/browser/legal_message_line.h | 8 +-- .../core/browser/legal_message_line_unittest.cc | 11 ++-- .../core/browser/payments/payments_client.cc | 12 ++--- .../core/common/autofill_prefs_unittest.cc | 9 ++-- 5 files changed, 51 insertions(+), 50 deletions(-) commit 979da8820e6de5a8d2b458a2392de8be1e90d923 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 09:48:58 2019 +0000 Roll src/third_party/skia 39da0504bb5d..bac53f089dbc (2 commits) https://skia.googlesource.com/skia.git/+log/39da0504bb5d..bac53f089dbc git log 39da0504bb5d..bac53f089dbc --date=short --no-merges --format='%ad %ae %s' 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader dd2faaeee6b2..1407297b7f7d (1 commits) 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bea4751348ca..dd2faaeee6b2 (1 commits) Created with: gclient setdep -r src/third_party/skia@bac53f089dbc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I511229e46c0940767676f34ac23f32232d53730d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520290 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640262} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 52027437113bf69e62bb34d0a83330997e025f6e Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Mar 13 09:33:30 2019 +0000 Migrate string_impl_[cf|mac] away from WTF::RetainPtr Bug: 929973 Change-Id: I7a34255e423a21879aae55c9a4ad2d9ff3ba3211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518573 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640261} third_party/blink/renderer/platform/text/DEPS | 1 + .../renderer/platform/text/mac/hyphenation_mac.cc | 20 +++++++++++--------- third_party/blink/renderer/platform/wtf/DEPS | 2 ++ .../blink/renderer/platform/wtf/text/string_impl.h | 6 +++--- .../renderer/platform/wtf/text/string_impl_cf.cc | 8 ++++---- .../renderer/platform/wtf/text/string_impl_mac.mm | 18 +++--------------- 6 files changed, 24 insertions(+), 31 deletions(-) commit fc1bac3684b059df290e955929fb0ab52c6e8917 Author: Leon Han <leon.han@intel.com> Date: Wed Mar 13 09:32:40 2019 +0000 [ServiceWorker] Remove blink.mojom.ServiceWorkerProviderHostInfo After https://crrev.com/c/1517275, we no longer pass the mojom struct blink.mojom.ServiceWorkerProviderHostInfo on any Mojo interface, it only acts as a member of ServiceWorkerProviderHost for containing some information. This CL extracts those necessary information out of it to be held directly inside ServiceWorkerProviderHost, then removes it. BUG=931092 Change-Id: Ibd879f82e3a298c4aafaf9d6858e2938212d1052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519673 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#640260} .../service_worker/service_worker_client_utils.cc | 4 +- ...e_worker_controllee_request_handler_unittest.cc | 2 +- .../service_worker_object_host_unittest.cc | 2 +- .../service_worker/service_worker_provider_host.cc | 129 ++++++++------------- .../service_worker/service_worker_provider_host.h | 40 +++++-- .../service_worker/service_worker_version.cc | 4 +- .../service_worker/service_worker_provider.mojom | 47 -------- 7 files changed, 82 insertions(+), 146 deletions(-) commit b72914bb81b8a0e6271a4c574e2af8a85aac5290 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Wed Mar 13 09:20:39 2019 +0000 sensors: Add and use a new #enable-sensor-content-setting flag. This new flag, enabled by default, that is now used to control the availability of the content settings UI for the Generic Sensor API. The UI used to be tied to the #enable-generic-sensor-extra-classes flag, which is disabled by default and also controls whether non-motion sensors such as the Ambient Light sensor are available. We want to make it control only the latter, and leave the UI to this new flag to make it easier for users to control whether sensors (Device Motion included) should be enabled or not. Bug: 796904 Change-Id: I27387b9a935975c732b155c4f146b3ce70d6868f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508401 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#640259} .../java/src/org/chromium/chrome/browser/ChromeFeatureList.java | 2 +- .../chrome/browser/preferences/website/SiteSettingsPreferences.java | 4 ++-- chrome/browser/about_flags.cc | 4 ++++ chrome/browser/android/chrome_feature_list.cc | 2 +- chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 4 ++++ chrome/browser/flag_descriptions.h | 3 +++ chrome/browser/generic_sensor/sensor_permission_context.cc | 4 ++-- .../ui/webui/settings/md_settings_localized_strings_provider.cc | 2 +- services/device/public/cpp/device_features.cc | 4 ++++ services/device/public/cpp/device_features.h | 1 + tools/metrics/histograms/enums.xml | 2 ++ 12 files changed, 30 insertions(+), 7 deletions(-) commit 67749799b406001ea6e19b7cb9ecb95e8d9cc9d4 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Wed Mar 13 09:03:05 2019 +0000 Make case style consistent in resource_response.h The primary motivation of CL is that the function names aren't consistent within resource_response.h (e.g."SetURLListViaServiceWorker" and "UrlListViaServiceWorker"). This CL renames function |SetURLListViaServiceWorker| to |SetUrlListViaServiceWorker| and ports other dependent files to refer to a new function name. Bug: 937196 Change-Id: I199717956a04a1445c6f51f3e21c61ce9ec63ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514457 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#640258} content/renderer/loader/web_url_loader_impl.cc | 2 +- media/blink/multibuffer_data_source_unittest.cc | 8 ++++---- third_party/blink/public/platform/web_url_response.h | 2 +- third_party/blink/renderer/platform/exported/web_url_response.cc | 4 ++-- .../blink/renderer/platform/loader/fetch/resource_loader_test.cc | 4 ++-- .../blink/renderer/platform/loader/fetch/resource_response.h | 2 +- third_party/blink/renderer/platform/loader/fetch/resource_test.cc | 4 ++-- 7 files changed, 13 insertions(+), 13 deletions(-) commit c3491c8e777d15e6b49bf8ec7faf3576375b089d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 09:02:33 2019 +0000 Roll src/third_party/swiftshader bea4751348ca..1407297b7f7d (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/bea4751348ca..1407297b7f7d git log bea4751348ca..1407297b7f7d --date=short --no-merges --format='%ad %ae %s' 2019-03-13 bclayton@google.com src/Pipeline/ComputeProgram: Remove unused parameter numDescriptorSets 2019-03-13 swiftshader.regress@gmail.com Regres: Update test lists @ bea47513 Created with: gclient setdep -r src/third_party/swiftshader@1407297b7f7d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I467bf4c681d7f0c66a627a2b8323e80e54d85b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520288 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640257} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 510c33b112717f1ad0bfdbeb5f5265e109f1772d Author: Richard Townsend <Richard.Townsend@arm.com> Date: Wed Mar 13 08:54:54 2019 +0000 Add a flag to use the synchronous foreground parser Future CLs will introduce a new version of HTMLDocumentParser which is interruptible. Bug: 901056 Change-Id: I8320d8c947f239f856636194c8462bdca6449dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474390 Reviewed-by: Fergal Daly <fergal@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#640256} third_party/blink/public/platform/web_runtime_features.h | 1 + third_party/blink/renderer/platform/exported/web_runtime_features.cc | 4 ++++ third_party/blink/renderer/platform/runtime_enabled_features.json5 | 3 +++ 3 files changed, 8 insertions(+) commit 30d0fc8e4f7cda6d7f8db6c38be102fe827e763d Author: Chih-Yu Huang <akahuang@google.com> Date: Wed Mar 13 08:54:39 2019 +0000 media/gpu: Move DMA-buf VideoFrame related function. When we migrate Vaapi and V4L2 VDA to media::VideoDecoder interface, we need to allocate DMA-buf VideoFrame from Ozone. The need of buffer allocation is not only for testing. Therefore this CL moves the related functions from media/gpu/test/ to media/gpu/linux/. BUG=b:119794200 TEST=video_decoder_tests Change-Id: Ia98d188c6e42cd2223bd1f92cd62cd49bda6e045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514283 Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#640255} media/gpu/BUILD.gn | 9 ++++-- .../platform_video_frame_utils.cc} | 34 ++++++++++++++++++---- .../platform_video_frame_utils.h} | 14 +++++++-- media/gpu/test/texture_ref.cc | 3 +- media/gpu/test/video_frame_helpers.cc | 26 ++--------------- media/gpu/test/video_frame_helpers.h | 10 ------- .../gpu/test/video_player/video_decoder_client.cc | 3 +- 7 files changed, 53 insertions(+), 46 deletions(-) commit 4917c55d7a87471dd8941dfb25190357f892171a Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Wed Mar 13 08:52:11 2019 +0000 Use a per-frame task runner at IdleStatus's mojo binding This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. The actual test that executes JavaScript on the task runner is: external/wpt/idle-detection/interceptor.https.html Bug: 913912 Change-Id: I12f64f9e071b841be8a0c1d9003edc81be03f911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514460 Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640254} third_party/blink/renderer/modules/idle/idle_status.cc | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) commit 2e22152195de88d7f2938053ecf87f9d1f8f9f7a Author: Yves Gerey <yvesg@google.com> Date: Wed Mar 13 08:46:19 2019 +0000 [Sanitizer] Print stack trace when program aborts. We too often miss the context when an assertion fails, especially if it is buried in helper function. This CL instructs clang sanitizers to dump a stack track when abort occurs. Ref: https://github.com/google/sanitizers/wiki/SanitizerCommonFlags Bug: webrtc:9849 Change-Id: I5bdf47279275f9bb67ba4abbe9d67a70d6e4b90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518579 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yves Gerey <yvesg@google.com> Cr-Commit-Position: refs/heads/master@{#640253} testing/test_env.py | 3 +++ 1 file changed, 3 insertions(+) commit 103f6858528265a5764611c004227bb71d026d21 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Wed Mar 13 08:42:49 2019 +0000 Remove InterpolableNumber::Create() factory function Many classes in blink have supported factory functions with legacy uses of RefPtr/adoptRef. It can block to make to use MakeGarbageCollected. Besides some classes have supported both a factory function and a public constructor. They aren't necessary. This CL removes InterpolableNumber::Create() and make it's constructor public, then make all callers use std::make_unique<InterpolableNumber> instead of InterpolableNumber::Create(). Bug: 939691 Change-Id: Icbf2536da381fd3b99d3269059677586638811a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517499 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#640252} .../renderer/core/animation/animation_test.cc | 4 +- .../core/animation/css_angle_interpolation_type.cc | 4 +- ...s_border_image_length_box_interpolation_type.cc | 4 +- .../core/animation/css_color_interpolation_type.cc | 21 +++++---- ...s_font_variation_settings_interpolation_type.cc | 5 +- .../css_font_weight_interpolation_type.cc | 4 +- .../core/animation/css_image_interpolation_type.cc | 5 +- .../css_image_slice_interpolation_type.cc | 4 +- .../animation/css_number_interpolation_type.cc | 2 +- .../css_offset_rotate_interpolation_type.cc | 2 +- .../core/animation/css_ray_interpolation_type.cc | 2 +- .../animation/css_resolution_interpolation_type.cc | 6 +-- .../animation/css_rotate_interpolation_type.cc | 5 +- .../core/animation/css_scale_interpolation_type.cc | 4 +- .../core/animation/css_time_interpolation_type.cc | 4 +- .../animation/css_transform_interpolation_type.cc | 5 +- .../animation/css_visibility_interpolation_type.cc | 6 +-- .../animation/filter_interpolation_functions.cc | 12 ++--- .../renderer/core/animation/interpolable_value.h | 10 ++-- .../core/animation/interpolable_value_test.cc | 53 +++++++++++----------- .../core/animation/interpolation_effect_test.cc | 4 +- .../animation/length_interpolation_functions.cc | 19 ++++---- .../animation/list_interpolation_functions_test.cc | 11 +++-- .../core/animation/path_interpolation_functions.cc | 4 +- .../core/animation/svg_angle_interpolation_type.cc | 4 +- .../animation/svg_integer_interpolation_type.cc | 4 +- ..._integer_optional_integer_interpolation_type.cc | 8 ++-- .../animation/svg_length_interpolation_type.cc | 8 ++-- .../animation/svg_number_interpolation_type.cc | 4 +- .../svg_number_list_interpolation_type.cc | 10 ++-- ...vg_number_optional_number_interpolation_type.cc | 8 ++-- .../svg_path_seg_interpolation_functions.cc | 16 +++---- .../animation/svg_point_list_interpolation_type.cc | 6 +-- .../core/animation/svg_rect_interpolation_type.cc | 10 ++-- .../svg_transform_list_interpolation_type.cc | 18 ++++---- 35 files changed, 154 insertions(+), 142 deletions(-) commit f30b5835043d929a53271c3df49d2103a9c660be Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 08:39:57 2019 +0000 Change long long to int64_t in third_party/blink/renderer/modules/indexeddb - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I15aa37f41b3b33eebfa89a8de3d038b316f08433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518262 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640251} .../modules/indexeddb/mock_web_idb_database.h | 90 ++++++++++---------- .../modules/indexeddb/mock_web_idb_factory.h | 4 +- .../renderer/modules/indexeddb/web_idb_database.h | 95 +++++++++++----------- .../modules/indexeddb/web_idb_database_callbacks.h | 7 +- .../indexeddb/web_idb_database_callbacks_impl.cc | 8 +- .../indexeddb/web_idb_database_callbacks_impl.h | 6 +- .../modules/indexeddb/web_idb_database_impl.cc | 94 ++++++++++----------- .../modules/indexeddb/web_idb_database_impl.h | 92 ++++++++++----------- .../renderer/modules/indexeddb/web_idb_factory.h | 4 +- .../modules/indexeddb/web_idb_factory_impl.cc | 4 +- .../modules/indexeddb/web_idb_factory_impl.h | 4 +- 11 files changed, 203 insertions(+), 205 deletions(-) commit a1c31c1621ba15a5dea72078c24bf04094f1f5af Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 08:38:48 2019 +0000 Roll src/third_party/skia 435db2d5257f..39da0504bb5d (29 commits) https://skia.googlesource.com/skia.git/+log/435db2d5257f..39da0504bb5d git log 435db2d5257f..39da0504bb5d --date=short --no-merges --format='%ad %ae %s' 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 b6eb34122e07..3c1f5a6bd487 (2 commits) 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader aa8f699a90af..bea4751348ca (2 commits) 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 37fe521d6049..54744c955cd6 (411 commits) 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 914a46d47952..aa8f699a90af (1 commits) 2019-03-12 mtklein@google.com tweak Descriptor_invalid_rec_size to not over-copy 2019-03-12 reed@google.com retain colorspace in blurimagefilter_raster 2019-03-12 enne@chromium.org Fix null pointer crash in looking up nonexistent typeface 2019-03-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-12 herb@google.com Introduce bulk strike api for glyph metrics for one draw case 2019-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b4de34ef039f..914a46d47952 (2 commits) 2019-03-12 reed@google.com remove dead SK_SUPPORT_LEGACY_RASTERLAYERCOLORSPACE code 2019-03-12 kjlubick@google.com [pathkit/canvaskit] Address race when uploading results 2019-03-12 enne@chromium.org Add validation to reading kRec_SkDescriptorTags 2019-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f945a5e172d0..b4de34ef039f (1 commits) 2019-03-12 herb@google.com Move GlyphAndPos and PathAndPos to interface and rename. 2019-03-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-12 mtklein@google.com simplify matrix color filter clamps 2019-03-12 reed@google.com Initial add SkMixers 2019-03-12 mtklein@google.com add private non-copying SkReadBuffer::readString() 2019-03-12 stephana@google.com [infra] Add Pixel3 devices 2019-03-12 khushalsagar@chromium.org remote fonts: Remove debug asserts for deserialization failures. 2019-03-12 ethannicholas@google.com added SK_API to SkSK::Compiler 2019-03-12 mtklein@google.com remove unused clamp_a_dst 2019-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c9bc33cff483..b6eb34122e07 (1 commits) 2019-03-12 robertphillips@google.com Always explicitly allocate except in Android Framework (take 3) 2019-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 7ce5de0c17bd..f945a5e172d0 (1 commits) 2019-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6a1d92b526d4..7ce5de0c17bd (5 commits) 2019-03-12 jcgregorio@google.com Turn on CI/CD for api.skia.org. (skia) 2019-03-12 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6193cb187e4a..6a1d92b526d4 (1 commits) Created with: gclient setdep -r src/third_party/skia@39da0504bb5d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:939762,chromium:940284,chromium:940843,chromium:940370 TBR=benjaminwagner@chromium.org Change-Id: I6d6c965d326e3bc82b56ee9e63971b419f6dac7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520246 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640250} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bcb5676eed62cf6e70ce21fec00c6ab2fca86170 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 08:35:56 2019 +0000 Roll Fuchsia SDK from 423fcfc30ccd to a0d04e2f2507 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I3d3d57bda472d49011d752a41d5e4c28fcc38703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520287 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640249} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit ecd47a7aaee1b7ea616c086b60943ee46099f8f9 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Wed Mar 13 08:35:35 2019 +0000 RenderDocument: Add base::feature and tests. Currently, a RenderFrame represents neither a document nor a frame, but a frame in a process. A new RenderFrame is created on each cross-process navigation. On navigation commit, the previous and next RenderFrameHost are swapped. We would like a RenderFrame to have a document semantic instead. It requires switching RenderFrame on same-process navigations as well. This CL: * Adds the base::Feature flags to enable/disable RenderDocument. * Adds a set of tests. This doesn't implement RenderDocument at all. This will come later. (WIP) document: https://docs.google.com/document/d/1C2VKkFRSc0kdmqjKan1G4NlNlxWZqE4Wam41FNMgnmA/edit?usp=sharing Bug: 936696 Change-Id: Ic865129c51e873ad20c4718f918cf5abf42d4086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511077 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640248} .../frame_host/render_document_host_browsertest.cc | 218 +++++++++++++++++++++ content/public/common/content_features.cc | 15 ++ content/public/common/content_features.h | 2 + content/test/BUILD.gn | 1 + 4 files changed, 236 insertions(+) commit e9f738f02bcd513eec3b2bdca8d8c12235b4c9ba Author: Vikas Soni <vikassoni@chromium.org> Date: Wed Mar 13 08:34:41 2019 +0000 AbstractTexture implementation to be used by TextureOwner. Implementation of AbstractTexture which will be used by TextureOwner. This abstract texture is created on shared context state. Bug: 900963 Change-Id: I67cee6a7591b362609026a0b447e2b5e0f9e44cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475909 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640247} gpu/command_buffer/common/context_result.h | 6 +- gpu/command_buffer/service/BUILD.gn | 2 + .../abstract_texture_impl_shared_context_state.cc | 120 +++++++++++++++++++++ .../abstract_texture_impl_shared_context_state.h | 59 ++++++++++ gpu/command_buffer/service/shared_context_state.cc | 11 ++ gpu/command_buffer/service/shared_context_state.h | 14 +++ gpu/command_buffer/service/texture_manager.h | 1 + media/gpu/android/texture_owner.cc | 29 ++--- media/gpu/android/texture_owner.h | 4 +- media/gpu/android/video_frame_factory_impl.cc | 32 +++++- tools/metrics/histograms/enums.xml | 7 ++ tools/metrics/histograms/histograms.xml | 10 ++ 12 files changed, 276 insertions(+), 19 deletions(-) commit de5d43a633b62b7d31c79fd782c05fce99c4fdaa Author: Georges Khalil <georgesak@chromium.org> Date: Wed Mar 13 08:19:13 2019 +0000 Remove georgesak@ from chrome/browser/policy/OWNERS. Change-Id: I03671681c9202dc525e35a9c043e3dfc102c6152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518453 Reviewed-by: Owen Min <zmin@chromium.org> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Auto-Submit: Georges Khalil <georgesak@chromium.org> Cr-Commit-Position: refs/heads/master@{#640246} chrome/browser/policy/OWNERS | 1 - 1 file changed, 1 deletion(-) commit 41727a2ed129fb23ff151dcb645d0b50f8374f22 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 08:18:13 2019 +0000 Roll src/third_party/chromite 921920e85f89..579a3b3e53ce (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/921920e85f89..579a3b3e53ce git log 921920e85f89..579a3b3e53ce --date=short --no-merges --format='%ad %ae %s' 2019-03-13 dgarrett@google.com chromeos_config: Extend factory buildspec timeouts. 2019-03-12 dhanyaganesh@chromium.org cros_uprevchrome: Fix for uprevchrome failures with cidb-id 2019-03-12 pprabhu@chromium.org config: Migrate {peach_pit,tricky}-chrome-pfq to Skylab. 2019-03-12 pprabhu@chromium.org config: Mark peppy-chrome-pfq important 2019-03-12 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@579a3b3e53ce The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I5ba20cbf51a8ba26ab7eb6d5596ea957d46f72a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519629 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640245} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2bab2c79d672f563a95ff37a4e50bb4da1d36b39 Author: Tanja Gornak <melandory@chromium.org> Date: Wed Mar 13 08:15:22 2019 +0000 [Tango->FCM] Ditch invalidation client. Invalidation client was introduced during migration. Main reason for having it was that new architecture was heavily invfluenced by old one. Now it's clear that InvalidationClient is unnessesary. Bug: 801985, 878446 Change-Id: Ibdd832eb98143c02fd8a342f51ae7e509cfb8707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508393 Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#640244} components/invalidation/impl/BUILD.gn | 3 - .../invalidation/impl/fcm_invalidation_listener.cc | 56 ++++----- .../invalidation/impl/fcm_invalidation_listener.h | 22 +--- .../impl/fcm_invalidation_listener_unittest.cc | 140 ++++----------------- components/invalidation/impl/fcm_invalidator.cc | 5 +- components/invalidation/impl/invalidation_client.h | 35 ------ .../invalidation/impl/invalidation_listener.h | 35 ++---- .../impl/per_user_topic_invalidation_client.cc | 102 --------------- .../impl/per_user_topic_invalidation_client.h | 70 ----------- .../per_user_topic_invalidation_client_unittest.cc | 72 ----------- 10 files changed, 61 insertions(+), 479 deletions(-) commit 57523792b1ac07cb73b4c3123d28164740a392a9 Author: Chih-Yu Huang <akahuang@google.com> Date: Wed Mar 13 08:13:52 2019 +0000 media/gpu: Add sequence checker at V4L2DecodeSurface V4L2DecodeSurface is a RefCounted class. This CL adds sequence checker to ensure each method is run at the same thread. BUG=b:119794200 TEST=Run video_decoder_tests Change-Id: I5df7c2663df0f0bdccfa288bbd5bb209a33c0b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514512 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#640243} media/gpu/v4l2/v4l2_decode_surface.cc | 22 +++++++++++++++++++++- media/gpu/v4l2/v4l2_decode_surface.h | 3 +++ 2 files changed, 24 insertions(+), 1 deletion(-) commit 4a3d6b8e385beeecf343c5f5582f81d7775763d6 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 08:13:12 2019 +0000 Roll src-internal 8eff2c60e58d..aacd6fc869ed (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8eff2c60e58d..aacd6fc869ed Created with: gclient setdep -r src-internal@aacd6fc869ed The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ortuno@chromium.org,sdefresne@chromium.org,nicolaso@chromium.org Change-Id: Idd19abf90b474a9e398e6118a737957b65ac2691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520346 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640242} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ff51064c917d3de7e454cc9792f980792326351 Author: dpapad <dpapad@chromium.org> Date: Wed Mar 13 08:12:42 2019 +0000 Settings: Use cr-link-row in people and privace_page.html where possible. This not only removes redundant code, but also fixes the paddings when large fonts are used. Bug: 686905 Change-Id: I5ad9894b26a6b3d1d530c0c9e778171a0ffe2f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519097 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640241} .../settings/people_page/people_page.html | 14 ++--- .../settings/privacy_page/privacy_page.html | 64 ++++++---------------- .../settings/privacy_page/privacy_page.js | 8 +-- 3 files changed, 24 insertions(+), 62 deletions(-) commit fce15b3e49aa2bb83268650bb76f42314c10e7de Author: Mike West <mkwst@chromium.org> Date: Wed Mar 13 08:11:12 2019 +0000 Revert "Instrument WebRequestProxyingUrlLoader for bug 882661" This reverts commit 1e6f0927037b9bc8429840926e313a4586b49551. Reason for revert: The underlying bug has been fixed, and we can stop sending URLs to crash. Original change's description: > Instrument WebRequestProxyingUrlLoader for bug 882661 > > What we know about the bug: > * URLLoaderClient::OnStartLoadingResponseBody is sent before > URLLoaderClient::OnReceiveResponse. > * Users have one or more ad blocking extensions. > * The NetworkService is enabled. > * Websites are loading content inside an iframe that has never > navigated. Its URL is still about:blank or javascript:* > > This CL Instrument WebRequestProxyingUrlLoader. The goal is to confirm this > bug is about extensions. > > Bug: 882661 > Change-Id: I1ce33cdb703adb1a854c37f46cafd80a85649388 > Reviewed-on: https://chromium-review.googlesource.com/c/1319710 > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605730} TBR=jam@chromium.org,arthursonzogni@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882661 Change-Id: I60bb2a36b9bca71da5242cfedc27589780857787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517898 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#640240} .../web_request/web_request_proxying_url_loader_factory.cc | 12 ------------ .../web_request/web_request_proxying_url_loader_factory.h | 4 ---- 2 files changed, 16 deletions(-) commit c3642a696c1e0e57cd2fe393a6ea61903439b5f5 Author: Maksim Sisov <msisov@igalia.com> Date: Wed Mar 13 08:06:40 2019 +0000 ozone: update documentation regarding Ozone/Wayland. Updating the documentation: added new args - system minigbm and system libdrm. Change-Id: I4e77795221266d5fba30cc232e483a3c18ba53d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514056 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by: Maksim Sisov <msisov@igalia.com> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#640239} docs/ozone_overview.md | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) commit db38ea45b5075ccc5e6d0264f9773676e29e167c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 08:03:34 2019 +0000 Roll src/third_party/catapult 990e94fa16e9..293a9a2e27ba (1 commits) https://chromium.googlesource.com/catapult.git/+log/990e94fa16e9..293a9a2e27ba git log 990e94fa16e9..293a9a2e27ba --date=short --no-merges --format='%ad %ae %s' 2019-03-13 dberris@chromium.org Use incremental file decoding and JSON parsing Created with: gclient setdep -r src/third_party/catapult@293a9a2e27ba The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:917914 TBR=sullivan@chromium.org Change-Id: Icad3c9e5cab74f3d7fa0e712c0854e15e0c65137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520286 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640238} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 732cd1271d9d7258a01518c4bc4a352072d543bf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 08:02:53 2019 +0000 Roll src/third_party/pdfium c924d0027a7d..d2cd38cdf78f (9 commits) https://pdfium.googlesource.com/pdfium.git/+log/c924d0027a7d..d2cd38cdf78f git log c924d0027a7d..d2cd38cdf78f --date=short --no-merges --format='%ad %ae %s' 2019-03-13 tsepez@chromium.org Check result of GetEventParam() in CJX_Form::recalculate(). 2019-03-12 thestig@chromium.org Fix a crash in DataMerge_UpdateBindingRelations(). 2019-03-12 tsepez@chromium.org Use spans in CFGAS_StringFormatter::SplitFormatString() 2019-03-12 thestig@chromium.org In fixup_pdf_template.py, make errors in include directives fatal. 2019-03-12 thestig@chromium.org Fix a crash inside CJX_HostPseudoModel::openList(). 2019-03-12 tsepez@chromium.org Rename CFGAS_FormatString to CFGAS_StringFormatter. 2019-03-12 tsepez@chromium.org Return size_t from ParseTimeZone(). 2019-03-12 thestig@chromium.org Avoid crashing inside CPDF_DIBBase. 2019-03-12 tsepez@chromium.org Convert remaining signed indices to size_t in cfgas_formatstring.cpp Created with: gclient setdep -r src/third_party/pdfium@d2cd38cdf78f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I88263c59cf3ac589f2b9cc006ae59c7319da7eae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519631 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640237} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2aaa614c8ad18ca131449fec909084b37012d5d3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 08:02:06 2019 +0000 Roll src/third_party/swiftshader 7ce5de0c17bd..bea4751348ca (7 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/7ce5de0c17bd..bea4751348ca git log 7ce5de0c17bd..bea4751348ca --date=short --no-merges --format='%ad %ae %s' 2019-03-13 chrisforbes@google.com Add support for D16_UNORM depth test & write 2019-03-13 chrisforbes@google.com Remove very early depth test 2019-03-13 chrisforbes@google.com Subzero MulHigh implementation for Int4/UInt4 2019-03-12 hliatis@google.com Wait semaphores for VkQueuePresentKHR 2019-03-12 hliatis@google.com Handle oldSwapchains 2019-03-12 chrisforbes@google.com Remove complementary depth buffer option for Vulkan 2019-03-12 hliatis@google.com Fix resizing issues Created with: gclient setdep -r src/third_party/swiftshader@bea4751348ca The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128363727,chromium:b/128363727,chromium:b/124265819,chromium:b/124265819,chromium:b/128363727,chromium:b/124265819 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4338a82329d3d70cde3e2da53b9b51c9e1430f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519628 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640236} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aae9170e8bc5d0936b93b1024e61105699ba558b Author: Yuzu Saijo <yuzus@chromium.org> Date: Wed Mar 13 07:38:05 2019 +0000 Mojofy FrameMsg_PostMessageEvent This CL mojofies a legacy IPC FrameMsg_PostMessageEvent. I put PostMessageEvent method in FrameNavigationControl interface, which is an associated sub-interface, instead of Frame interface. This is because some browser tests depend on message ordering and would fail if we don't use associated interface. I will look into the test failures separately. Change-Id: I70a2fbf58ee71cb1739ec7669a44c26959fb91af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491234 Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640235} .../browser/frame_host/render_frame_host_impl.cc | 8 ++++ .../browser/frame_host/render_frame_host_impl.h | 6 +++ .../browser/frame_host/render_frame_proxy_host.cc | 21 ++++++---- content/browser/message_port_provider.cc | 38 ++++++++--------- content/common/frame.mojom | 16 ++++++++ content/common/frame_messages.h | 3 -- content/renderer/render_frame_impl.cc | 48 ++++++++-------------- content/renderer/render_frame_impl.h | 10 +++-- 8 files changed, 82 insertions(+), 68 deletions(-) commit 83642c3f637b0e70061ae89cc3cbe4add3fc48bd Author: Bo Liu <boliu@chromium.org> Date: Wed Mar 13 07:37:57 2019 +0000 aw: Implement presentation feedback for webview Webview's implementation makes the assumption that the frame token is a sequence and that it is ok to drop frames in the middle of the sequence. See LayerTreeHostImpl::DidPresentCompositorFrame. Combine the draw constraints post task with this one, which means that post task will now be delayed until after DrawAndSwap on render thread most of the time. Perf note. This is expected to increase the number of tasks per frame on the UI thread for webview by 1. Bug: 938956 Change-Id: I2bb895c23049441560118b0190e1e2d2a8534bd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512340 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640234} .../browser/gfx/browser_view_renderer.cc | 32 ++++++++++++++++------ .../browser/gfx/browser_view_renderer.h | 3 +- .../browser/gfx/browser_view_renderer_unittest.cc | 15 ++++++---- .../browser/gfx/compositor_frame_consumer.h | 8 ++++-- .../browser/gfx/compositor_frame_producer.h | 2 +- android_webview/browser/gfx/hardware_renderer.cc | 30 ++++++++++++++------ .../browser/gfx/render_thread_manager.cc | 24 ++++++++++++---- .../browser/gfx/render_thread_manager.h | 13 +++++++-- android_webview/browser/gfx/test/rendering_test.cc | 9 +++--- android_webview/browser/gfx/test/rendering_test.h | 2 +- .../browser/android/synchronous_compositor_host.cc | 13 +++++++-- .../browser/android/synchronous_compositor_host.h | 5 +++- .../render_widget_host_view_android.cc | 6 ++-- content/common/input/synchronous_compositor.mojom | 14 ++++++++-- .../browser/android/synchronous_compositor.h | 4 +++ .../test/test_synchronous_compositor_android.h | 2 ++ .../android/synchronous_compositor_proxy.cc | 6 ++-- .../android/synchronous_compositor_proxy.h | 5 +++- .../android/synchronous_layer_tree_frame_sink.cc | 8 +++++- .../android/synchronous_layer_tree_frame_sink.h | 3 +- 20 files changed, 148 insertions(+), 56 deletions(-) commit f6dda19b2bceadc482f7a2ab4884d701de9e86bf Author: Wei Lee <wtlee@google.com> Date: Wed Mar 13 07:25:42 2019 +0000 Fix DCHECK failure that GpuMemoryBuffer does not be unmapped properly This CL fixes DCHECK failure that StreamBufferManager does not unmap GpuMemoryBuffer when it reconfigures the streams. Bug: b/128393171 Test: Tested on DUT and the DCHECK pass with this CL. Change-Id: Icca27a7246b1f1b0f780cea2ffee8467c48c0b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519949 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#640233} .../video/chromeos/stream_buffer_manager.cc | 26 ++++++++++++++-------- .../capture/video/chromeos/stream_buffer_manager.h | 3 +++ 2 files changed, 20 insertions(+), 9 deletions(-) commit 162c2d28324645626f2f66188887e19a5e626df2 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Wed Mar 13 07:23:52 2019 +0000 OnionSoup: Move mojom files for permissions and geolocation to mojom folder This CL moves public/platform/modules/geolocation and public/platform/modules/permissions to public/mojom/ to gather mojom files to mojom folder and updates paths for geolocation_service.mojom, permission.mojom and permission_status.mojom. Bug: 919393 Change-Id: Ic27c7000cb3a9983de42296a16fd38e54ba8530f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510700 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#640232} WATCHLISTS | 2 +- chrome/browser/DEPS | 1 - .../search_permissions/search_geolocation_disclosure_tab_helper.cc | 2 +- chrome/browser/chromeos/attestation/platform_verification_flow.cc | 2 +- chrome/browser/geolocation/geolocation_permission_context_unittest.cc | 2 +- .../guest_view/web_view/chrome_web_view_permission_helper_delegate.h | 2 +- .../browser/notifications/notification_permission_context_unittest.cc | 2 +- .../browser/notifications/persistent_notification_handler_unittest.cc | 2 +- .../notifications/platform_notification_service_interactive_uitest.cc | 2 +- chrome/browser/plugins/flash_download_interception.cc | 2 +- chrome/browser/push_messaging/push_messaging_service_impl.cc | 2 +- content/browser/DEPS | 3 --- content/browser/background_sync/background_sync_manager.h | 2 +- content/browser/background_sync/background_sync_manager_unittest.cc | 2 +- content/browser/generic_sensor/sensor_provider_proxy_impl.h | 2 +- content/browser/geolocation/geolocation_service_impl.h | 2 +- content/browser/notifications/blink_notification_service_impl.h | 2 +- .../browser/notifications/blink_notification_service_impl_unittest.cc | 2 +- content/browser/payments/payment_app_provider_impl.cc | 2 +- content/browser/payments/payment_app_provider_impl_unittest.cc | 2 +- content/browser/permissions/permission_controller_impl.cc | 2 +- content/browser/permissions/permission_service_context.h | 2 +- content/browser/permissions/permission_service_impl.h | 2 +- content/browser/push_messaging/push_messaging_manager.cc | 2 +- content/common/DEPS | 2 -- content/public/browser/permission_controller.h | 2 +- content/public/browser/permission_controller_delegate.h | 2 +- content/public/browser/platform_notification_service.h | 2 +- content/public/common/common_param_traits_macros.h | 2 +- content/public/test/mock_permission_manager.cc | 2 +- content/renderer/frame_owner_properties.cc | 2 +- content/renderer/media/media_permission_dispatcher.h | 2 +- content/renderer/render_frame_impl.cc | 2 +- content/shell/browser/web_test/web_test_message_filter.h | 2 +- content/shell/common/web_test/web_test_messages.h | 2 +- third_party/blink/public/BUILD.gn | 3 --- third_party/blink/public/mojom/BUILD.gn | 3 +++ .../blink/public/{platform/modules => mojom}/geolocation/OWNERS | 0 .../{platform/modules => mojom}/geolocation/geolocation_service.mojom | 0 .../blink/public/{platform/modules => mojom}/permissions/OWNERS | 0 .../public/{platform/modules => mojom}/permissions/permission.mojom | 2 +- .../{platform/modules => mojom}/permissions/permission_status.mojom | 0 .../public/platform/modules/notifications/notification_service.mojom | 2 +- .../blink/renderer/modules/accessibility/ax_object_cache_impl.cc | 4 ++-- .../blink/renderer/modules/accessibility/ax_object_cache_impl.h | 4 ++-- third_party/blink/renderer/modules/clipboard/clipboard_promise.cc | 2 +- third_party/blink/renderer/modules/clipboard/clipboard_promise.h | 2 +- third_party/blink/renderer/modules/geolocation/geolocation.h | 2 +- third_party/blink/renderer/modules/notifications/notification.h | 4 ++-- .../blink/renderer/modules/notifications/notification_manager.cc | 4 ++-- .../blink/renderer/modules/notifications/notification_manager.h | 2 +- third_party/blink/renderer/modules/payments/payment_instruments.h | 2 +- third_party/blink/renderer/modules/permissions/permission_status.h | 2 +- third_party/blink/renderer/modules/permissions/permission_utils.h | 2 +- third_party/blink/renderer/modules/permissions/permissions.h | 2 +- .../blink/renderer/modules/push_messaging/push_messaging_bridge.h | 4 ++-- third_party/blink/renderer/modules/quota/storage_manager.h | 2 +- third_party/blink/renderer/modules/webmidi/midi_access_initializer.cc | 2 +- third_party/blink/renderer/modules/webmidi/midi_access_initializer.h | 4 ++-- .../blink/web_tests/geolocation-api/cached-position-called-once.html | 4 ++-- third_party/blink/web_tests/geolocation-api/callback-exception.html | 4 ++-- .../blink/web_tests/geolocation-api/callback-to-deleted-context.html | 4 ++-- .../blink/web_tests/geolocation-api/clear-watch-invalid-id-crash.html | 4 ++-- .../web_tests/geolocation-api/coordinates-interface-attributes.html | 4 ++-- .../delayed-permission-allowed-for-multiple-requests.html | 4 ++-- .../blink/web_tests/geolocation-api/delayed-permission-allowed.html | 4 ++-- .../delayed-permission-denied-for-multiple-requests.html | 4 ++-- .../blink/web_tests/geolocation-api/delayed-permission-denied.html | 4 ++-- .../blink/web_tests/geolocation-api/disconnected-frame-already.html | 4 ++-- .../geolocation-api/disconnected-frame-permission-denied.html | 4 ++-- third_party/blink/web_tests/geolocation-api/disconnected-frame.html | 4 ++-- third_party/blink/web_tests/geolocation-api/error-clear-watch.html | 4 ++-- .../web_tests/geolocation-api/error-service-connection-error.html | 4 ++-- third_party/blink/web_tests/geolocation-api/error.html | 4 ++-- third_party/blink/web_tests/geolocation-api/maximum-age.html | 4 ++-- third_party/blink/web_tests/geolocation-api/multiple-requests.html | 4 ++-- third_party/blink/web_tests/geolocation-api/notimer-after-unload.html | 4 ++-- .../geolocation-api/permission-denied-already-clear-watch.html | 4 ++-- .../web_tests/geolocation-api/permission-denied-already-error.html | 4 ++-- .../web_tests/geolocation-api/permission-denied-already-success.html | 4 ++-- .../web_tests/geolocation-api/permission-denied-stops-watches.html | 4 ++-- third_party/blink/web_tests/geolocation-api/permission-denied.html | 4 ++-- third_party/blink/web_tests/geolocation-api/position-string.html | 4 ++-- third_party/blink/web_tests/geolocation-api/reentrant-error.html | 4 ++-- .../blink/web_tests/geolocation-api/reentrant-permission-denied.html | 4 ++-- third_party/blink/web_tests/geolocation-api/reentrant-success.html | 4 ++-- .../geolocation-api/resources/callback-to-remote-context-inner.html | 4 ++-- .../remove-remote-context-in-error-callback-crash-inner.html | 4 ++-- .../blink/web_tests/geolocation-api/resources/window-close-popup.html | 4 ++-- third_party/blink/web_tests/geolocation-api/success-clear-watch.html | 4 ++-- third_party/blink/web_tests/geolocation-api/success.html | 4 ++-- third_party/blink/web_tests/geolocation-api/timeout-clear-watch.html | 4 ++-- third_party/blink/web_tests/geolocation-api/timeout-negative.html | 4 ++-- .../blink/web_tests/geolocation-api/timeout-over-max-of-unsigned.html | 4 ++-- third_party/blink/web_tests/geolocation-api/timeout-zero.html | 4 ++-- third_party/blink/web_tests/geolocation-api/timeout.html | 4 ++-- third_party/blink/web_tests/geolocation-api/timestamp.html | 4 ++-- third_party/blink/web_tests/geolocation-api/watch.html | 4 ++-- .../web_tests/geolocation-api/watchPosition-page-visibility.html | 4 ++-- third_party/blink/web_tests/geolocation-api/watchPosition-unique.html | 4 ++-- .../security/powerfulFeatureRestrictions/resources/geolocation.html | 4 ++-- 101 files changed, 143 insertions(+), 149 deletions(-) commit 088b19eadb8816b063dd739a9c35bec8b5e08e27 Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Mar 13 07:17:45 2019 +0000 Remove python sync server and P2PInvalidationService All dependendent test have been migrated away and have adopted the FakeServer, so the old code can be deleted (~5,000 LoC). Bug: 565559,406545 Change-Id: Ia9d9a7a797513f7f734781ae8d7fb4c182a114ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517552 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Tatiana Gornak <melandory@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640231} .gitignore | 1 - BUILD.gn | 1 - .../test/integration/p2p_invalidation_forwarder.cc | 33 - .../test/integration/p2p_invalidation_forwarder.h | 44 - chrome/browser/sync/test/integration/sync_test.cc | 183 +-- chrome/browser/sync/test/integration/sync_test.h | 39 +- chrome/test/BUILD.gn | 5 - components/invalidation/impl/BUILD.gn | 8 - .../invalidation/impl/p2p_invalidation_service.cc | 82 - .../invalidation/impl/p2p_invalidation_service.h | 76 - components/invalidation/impl/p2p_invalidator.cc | 345 ---- components/invalidation/impl/p2p_invalidator.h | 150 -- .../invalidation/impl/p2p_invalidator_unittest.cc | 360 ----- components/sync/BUILD.gn | 39 - components/sync/protocol/BUILD.gn | 5 - components/sync/test/local_sync_test_server.cc | 102 -- components/sync/test/local_sync_test_server.h | 49 - components/sync/tools/testserver/DEPS | 4 - components/sync/tools/testserver/chromiumsync.py | 1647 -------------------- .../sync/tools/testserver/chromiumsync_test.py | 680 -------- .../sync/tools/testserver/run_sync_testserver.cc | 122 -- .../sync/tools/testserver/sync_testserver.py | 571 ------- components/sync/tools/testserver/xmppserver.py | 603 ------- .../sync/tools/testserver/xmppserver_test.py | 421 ----- net/dns/BUILD.gn | 1 - tools/traffic_annotation/summary/annotations.xml | 1 - 26 files changed, 10 insertions(+), 5562 deletions(-) commit 9965121793407b5b899aefa62b9db8ca865e6281 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 07:17:11 2019 +0000 Roll src/third_party/angle b6eb34122e07..3c1f5a6bd487 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/b6eb34122e07..3c1f5a6bd487 git log b6eb34122e07..3c1f5a6bd487 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 jmadill@chromium.org Include script outputs in run_code_generation.py. 2019-03-12 syoussefi@chromium.org Add glmark2 to angle_perftests Created with: gclient setdep -r src/third_party/angle@3c1f5a6bd487 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I7d14ceaac9f355040ed672573e662967d934c9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519682 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640230} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 34fa539ae32030e31d3ab910afe3df24f8fb1e3b Author: Zinovy Nis <zynis@yandex-team.ru> Date: Wed Mar 13 07:08:11 2019 +0000 Add a mode for checking the diff only for clang_tidy_tool.py Usage: chromium/src$ git show -U5 | tools/clang/scripts/clang_tidy_tool.py --checks=* --diff out/Debug chrome or chromium/src$ git diff -U5 | tools/clang/scripts/clang_tidy_tool.py --checks=* --diff out/Debug chrome Add `--diff` mode to clang_tidy_tool.py to check only the modified lines of code. Can be used as a kind of presubmit routine. Will run much faster (parallelized) after my https://reviews.llvm.org/D57662 is landed in LLVM. Bug: 936989 Change-Id: I83369d3479f271ed62a757b42fea2e22802f9569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514052 Commit-Queue: Zinovy Nis <zynis@yandex-team.ru> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#640229} tools/clang/scripts/clang_tidy_tool.py | 68 ++++++++++++++++++++++++++++++---- 1 file changed, 61 insertions(+), 7 deletions(-) commit cf05e84b69d899dd0530d953fe2b1cb947390dd8 Author: Daniel Bratell <bratell@opera.com> Date: Wed Mar 13 07:07:50 2019 +0000 Don't emit RevocableInterfacePtr in mojo's blink bindings The code that we emit in mojo's blink bindings are sometimes loaded into non-blink code (see bug) and from there you should not access code inside blink. Since RevocableInterfacePtr lives inside blink, that causes dependency and layering violations. Everyone using blink bindings got something similar to. ERROR at //out/Default/gen/components/content_settings/core/common/content_settings.mojom-blink-forward.h:20:11: Include not allowed. #include "third_party/blink/renderer/platform/mojo/revocable_interface_ptr.h" ^----------------------------------------------------------------- It is not in any dependency of //components/content_settings/core/common:mojo_bindings_blink The include file is in the target(s): //third_party/blink/renderer/platform:platform which should somehow be reachable. ___________________ In total there were about 1000 reported dependency errors because of this. This fixes this by inlining the few uses and removing the includes. Bug: 938893 Change-Id: If0a682414b27912c8ff55b4bc0e477c9948ba051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511415 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#640228} .../generators/cpp_templates/module-forward.h.tmpl | 6 ----- .../generators/cpp_templates/module.h.tmpl | 4 --- .../blink/renderer/core/dom/document_test.cc | 1 + .../core/execution_context/execution_context.cc | 1 + .../renderer/modules/geolocation/geolocation.h | 5 ++-- .../renderer/modules/speech/speech_recognition.h | 3 ++- .../platform/mojo/interface_invalidator_test.cc | 30 +++++++++++----------- 7 files changed, 22 insertions(+), 28 deletions(-) commit c9819b64456f0917baa4be9ceeec100e0f7a8619 Author: Wei Lee <wtlee@google.com> Date: Wed Mar 13 07:07:06 2019 +0000 Fix DCHECK failure that TakePhoto() does not run on expected thread This CL fixes DHCECK failure that TakePhoto() runs on different thread after returning from ReprocessManager::ConsumeReprocessOptions(). Bug: b/128393171 Test: Tested on DUT and the DCHECK pass with this CL. Change-Id: Iabc7080aaa23380c2550e9c3ecfb291be8a03546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517480 Reviewed-by: Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#640227} media/capture/video/chromeos/camera_device_delegate.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit d5e55ca61390d264e8c69ef9d32d85c2f2e17c02 Author: Jay Harris <harrisjay@chromium.org> Date: Wed Mar 13 07:06:46 2019 +0000 Stops showing the back to scope button on in scope pages. Previously, if an in scope page showed a custom tab bar, it would also display the 'X' button for going back into app scope. This would do nothing as the pages were already in app scope. Some examples of situations where this could occur are on http sites and on sites which serve mixed content. Bug: 941238 Change-Id: I4cbe5f9efa92ec4c66c290ad312f30f20a6be9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519886 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#640226} .../ui/views/location_bar/custom_tab_bar_view.cc | 8 ++ .../custom_tab_bar_view_browsertest.cc | 115 +++++++++++++++++++-- 2 files changed, 113 insertions(+), 10 deletions(-) commit 27b1763803672c8215cadcfce27cf595a70ea2d1 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Mar 13 07:04:16 2019 +0000 Switch the remaining classes in core/css to use downcast helpers (9/n) The following class is migrated: CSSValuePair. It is the penultimate change before DEFINE_CSS_VALUE_TYPE_CASTS can be removed from core/css completely. R=rakeran@chromium.org CC=​blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I2ad38002d1da30a1f5046e8c4ad8a87fbcb8d7f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518598 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#640225} .../templates/style_builder_functions.tmpl | 2 +- .../animation/css_length_pair_interpolation_type.h | 2 +- .../css_position_axis_list_interpolation_type.cc | 7 ++-- .../animation/css_position_interpolation_type.h | 8 ++--- .../core/animation/size_interpolation_functions.cc | 5 ++- .../renderer/core/css/basic_shape_functions.cc | 9 +++-- .../renderer/core/css/css_basic_shape_values.cc | 6 ++-- .../blink/renderer/core/css/css_gradient_value.cc | 7 ++-- third_party/blink/renderer/core/css/css_value.cc | 6 ++-- .../blink/renderer/core/css/css_value_pair.h | 6 +++- .../renderer/core/css/cssom/css_position_value.cc | 6 ++-- .../renderer/core/css/cssom/style_value_factory.cc | 2 +- .../core/css/properties/css_parsing_utils.cc | 7 ++-- .../renderer/core/css/resolver/css_to_style_map.cc | 41 +++++++++++----------- .../core/css/resolver/style_builder_converter.cc | 33 ++++++++--------- .../core/css/resolver/style_builder_converter.h | 9 +++-- 16 files changed, 76 insertions(+), 80 deletions(-) commit cc2482fb4b426b17652dcfc9b4bed60b22e71910 Author: Sam McNally <sammc@chromium.org> Date: Wed Mar 13 07:02:08 2019 +0000 Detect missing downloads when using "Show in folder" on ChromeOS. Bug: 939736 Change-Id: Iee5e1cad7a5af7b08a6f2a6c26ceb167fa41079c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513995 Reviewed-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#640224} chrome/browser/chromeos/file_manager/open_util.cc | 28 +++++++++++++++++++--- .../download/internal/common/download_item_impl.cc | 5 ++++ 2 files changed, 30 insertions(+), 3 deletions(-) commit 0780bc597352bd3e4de1a6244f417c082fcff39b Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Mar 13 07:00:30 2019 +0000 OOR-CORS: Save-Data does not appear only in the CORS preflight request Save-Data header does not appear only in the CORS preflight request, but appears in the actual request even with the OOR-CORS flag is enabled. Bug: 940362 Change-Id: I556219c051bb5715624c44af87db83de3ac26301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517510 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#640223} content/browser/service_worker/service_worker_browsertest.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit 9a07f1225c4ec912fba847637b204e7e945e9ede Author: Yuki Shiino <yukishiino@chromium.org> Date: Wed Mar 13 06:59:56 2019 +0000 v8binding: Remove CallbackFunctionTreatedAsScriptValue CallbackFunctionTreatedAsScriptValue is deprecated and no longer used. This patch removes it. Change-Id: Iefdeb4990a38768671054663955ef63e26139028 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517479 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#640222} .../blink/renderer/bindings/scripts/idl_types.py | 13 +---- .../bindings/tests/idls/core/test_object.idl | 2 - .../bindings/tests/results/core/v8_test_object.cc | 62 ---------------------- .../bindings/tests/results/core/v8_test_object.h | 1 - 4 files changed, 1 insertion(+), 77 deletions(-) commit 64c01bae1c499364a69f20e19a38f23382603045 Author: Mitsuru Oshima <oshima@chromium.org> Date: Wed Mar 13 06:56:54 2019 +0000 Record Apps.StateTransition.Smoothness for clamshell/tablet mode separately Introduced new EnterOvervie/ExitOverview suffixes to record animations triggered by overview, as it applies quite different animations. Bug: 923159 Change-Id: Ia0066e96f8d59bbadd40f7ce3f419d13d41f38fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513295 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#640221} ash/app_list/presenter/app_list_presenter_impl.cc | 60 ++++++++++++++++------- ash/app_list/presenter/app_list_presenter_impl.h | 12 ++--- ash/app_list/views/app_list_view.cc | 37 ++++++++++++-- ash/app_list/views/app_list_view.h | 7 ++- tools/metrics/histograms/histograms.xml | 11 +++++ 5 files changed, 99 insertions(+), 28 deletions(-) commit 973d0e32df1f184a9157000af536c74709de7f4b Author: Yuki Shiino <yukishiino@chromium.org> Date: Wed Mar 13 06:55:58 2019 +0000 v8binding: Replace forEach's |callback| with an IDL callback function Replaces CallbackFunctionTreatedAsScriptValue (obsolete) at forEach iterators with IDL callback function type. Change-Id: I9de43e37636404a62ba03868f8efaefdfe5896df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514518 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#640220} .../blink/renderer/bindings/core/v8/BUILD.gn | 2 + .../blink/renderer/bindings/core/v8/iterable.h | 37 +++--- .../renderer/bindings/scripts/v8_interface.py | 5 +- .../tests/idls/core/test_callback_functions.idl | 4 + .../results/core/v8_for_each_iterator_callback.cc | 133 +++++++++++++++++++++ .../results/core/v8_for_each_iterator_callback.h | 77 ++++++++++++ .../tests/results/core/v8_test_integer_indexed.cc | 5 +- .../tests/results/core/v8_test_interface.cc | 5 +- .../tests/results/core/v8_test_interface_2.cc | 5 +- .../bindings/tests/results/core/v8_test_object.cc | 5 +- .../blink/renderer/core/dom/common_definitions.idl | 6 + 11 files changed, 252 insertions(+), 32 deletions(-) commit 1a03c5c41aac795269b1626473871f7844486a94 Author: Yuki Shiino <yukishiino@chromium.org> Date: Wed Mar 13 06:55:49 2019 +0000 v8binding: Add 'Blink' prefix to AudioWorkletProcessCallback To be consistent with BlinkAudioWorkletProcessorConstructor, adds 'Blink' prefix to AudioWorkletProcessCallback. This is a follow-up patch of https://crrev.com/c/1511754 . Change-Id: I9e791d348eac6eb4b5a2864ababad0e425d36183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517497 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#640219} third_party/blink/renderer/bindings/modules/v8/generated.gni | 4 ++-- .../renderer/modules/webaudio/audio_worklet_global_scope.cc | 6 +++--- .../renderer/modules/webaudio/audio_worklet_global_scope.idl | 4 +++- .../modules/webaudio/audio_worklet_processor_definition.cc | 6 +++--- .../modules/webaudio/audio_worklet_processor_definition.h | 12 +++++++----- 5 files changed, 18 insertions(+), 14 deletions(-) commit 69a8578130d7e316a02a296d9bb228af3f4b0e39 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 06:54:55 2019 +0000 Roll src-internal 77982de9efa9..8eff2c60e58d (14 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77982de9efa9..8eff2c60e58d Created with: gclient setdep -r src-internal@8eff2c60e58d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ortuno@chromium.org,sdefresne@chromium.org,nicolaso@chromium.org Change-Id: I0d6fa486f338892a0fae1a206c3c456bb1494851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519632 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640218} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5879002919f02232e2ebedfc7e0fbc1c90ea509f Author: Koji Ishii <kojii@chromium.org> Date: Wed Mar 13 06:54:45 2019 +0000 [LayoutNG] Cache InkOverflow for inline fragments crbug.com/892347 moved visual overflow computation from layout to compositing. Because NGPhysicalFragment is immutable, it moved the computed values storage to LayoutBox. Because InlineBox doesn't have corresponding LayoutBox, it left inline visual overflow unchanged. For LayoutNG, this means that visual overflow is no longer stored, re-computed every time they are needed. Pre-paint and paint assumes that asking visual overflow is fast, and use it to compute VisualRect, or to cull unnecessary painting. Re- computing every time is likely to slow these phases down. This patch changes |LayoutObject::RecalcVisualOverflow()| to compute visual overflow of LayoutNG inline fragments and cache the value so that subsequent usage is fast. NGPaintFragment seems to be the only reasonable place to store the computed visual overflow, because LayoutNG doesn't have InlineBox, and inline boxes don't have corresponding LayoutObject, and NGPhysicalFragment is immutable. We might revisit this design as we discuss what to do with NGPaintFragment. Functions in NGPhysicalFragment are renamed to clarify they are slow, and functions to retrieve stored values are added to NGPaintFragment because it is the only instance that can read values for both inline and block. Bug: 936024 Change-Id: I8663fa6bafe35f8209335feb5ed082a63af8dfb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513792 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#640217} .../renderer/core/layout/layout_block_flow.cc | 6 + .../renderer/core/layout/layout_block_flow_line.cc | 22 ++- .../blink/renderer/core/layout/layout_box.cc | 8 + .../blink/renderer/core/layout/layout_box.h | 1 + .../blink/renderer/core/layout/layout_inline.cc | 21 ++- .../ng/inline/ng_inline_layout_algorithm_test.cc | 20 ++- .../core/layout/ng/inline/ng_line_truncator.cc | 17 +- .../ng/inline/ng_physical_line_box_fragment.cc | 13 -- .../ng/inline/ng_physical_line_box_fragment.h | 6 - .../renderer/core/layout/ng/layout_ng_mixin.cc | 38 ----- .../renderer/core/layout/ng/layout_ng_mixin.h | 3 - .../core/layout/ng/ng_physical_box_fragment.cc | 33 +--- .../core/layout/ng/ng_physical_box_fragment.h | 18 +-- .../core/layout/ng/ng_physical_fragment.cc | 86 +++------- .../renderer/core/layout/ng/ng_physical_fragment.h | 22 ++- .../core/paint/ng/ng_box_fragment_painter.cc | 14 +- .../renderer/core/paint/ng/ng_paint_fragment.cc | 173 ++++++++++++++++++++- .../renderer/core/paint/ng/ng_paint_fragment.h | 39 +++++ 18 files changed, 322 insertions(+), 218 deletions(-) commit df1fede89a832a708df47f329e265bb3ff3366e3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 06:46:45 2019 +0000 Roll src/third_party/catapult 967fadd27a67..990e94fa16e9 (2 commits) https://chromium.googlesource.com/catapult.git/+log/967fadd27a67..990e94fa16e9 git log 967fadd27a67..990e94fa16e9 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 crouleau@chromium.org [Telemetry] Fix Minidumps outputting on desktop. 2019-03-13 mbarowsky@chromium.org Append ImageFrameGenerator::decodeToYUV to imageDecode tracing category Created with: gclient setdep -r src/third_party/catapult@990e94fa16e9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:941274,chromium:900264 TBR=sullivan@chromium.org Change-Id: Ic3acd952fa56a1e28122c9f451d94a71fa86a59d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519868 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640216} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5e6e5df2994ca4c9c012f8f4133981841f3ae04a Author: Trent Apted <tapted@chromium.org> Date: Wed Mar 13 06:46:38 2019 +0000 Revert "Remove input field selection regression in Gallery" This reverts commit eff97af594b79428ab62e834a09fd99646e7beab. Reason for revert: Can cause "Uncaught TypeError: input.select is not a function" Bug: 931157 Original change's description: > Remove input field selection regression in Gallery > > Change https://chromium-review.googlesource.com/c/chromium/src/+/1217747/ > introduced a side-effect that causes the entire input field to be > selected on a focus event. In the gallery app this caused the Width > input field to be fully selected when doing an image resize. This > change explicitly sets the selection to the end of the field as it > used to work before the regression. > > Bug: 914741 > Tests: Ran all browser and unit tests, manually checked as well. > Change-Id: I579660ebdbad43bd8ab739c76ada7289f3e6d943 > Reviewed-on: https://chromium-review.googlesource.com/c/1453696 > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Commit-Queue: Alex Danilo <adanilo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629349} TBR=joelhockey@chromium.org,adanilo@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 914741 Change-Id: I1d0777f3118b4a2c6eaf8d3fd51c509c3ca587d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519947 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#640215} ui/file_manager/gallery/js/image_editor/image_editor_toolbar.js | 2 -- 1 file changed, 2 deletions(-) commit c67216f5198df1b0e3d1a3afbb1d019ff6e5c1d9 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Mar 13 06:42:51 2019 +0000 Add data scheme support for org.chromium.UrlHandlerService UrlHandlerService is called in crostini by x-www-browser From crostini terminal, user can open chrome with a specified data URL such as: $ x-www-browser "data:text/plain,Hello World" Bug: 935150 Change-Id: I144ea1e518eb058aece3bc02cca5a392252d1309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501633 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#640214} ash/dbus/url_handler_service_provider.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 6bea623f16e966e69df3a14091e1fe6a4249014c Author: Mikel Astiz <mastiz@chromium.org> Date: Wed Mar 13 06:42:02 2019 +0000 Remove const for SyncValueStoreCache::GetSyncableService() Constness for a member function returning a non-const pointer has no good semantics, since the returned pointer can be used to mutate the object. There's also no need, so let's just remove const. Bug: None Change-Id: I39f394ffe96370b92a52ac40451758ac0fef40c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518578 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#640213} chrome/browser/extensions/api/storage/sync_value_store_cache.cc | 2 +- chrome/browser/extensions/api/storage/sync_value_store_cache.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 806234584ae03b8be3786c4d584dfe296ae60ea9 Author: Yoav Weiss <yoavweiss@chromium.org> Date: Wed Mar 13 06:38:02 2019 +0000 Add HTTP Refresh header usecounter Since the Refresh header is apparently non-standard, this CL adds a usecounter to see if it'd be feasible to remove support for it. Bug: 941351 Change-Id: I9f133689406d1c90978ae97df013765d49f8505e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520146 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Cr-Commit-Position: refs/heads/master@{#640212} third_party/blink/public/mojom/web_feature/web_feature.mojom | 1 + third_party/blink/renderer/core/dom/document.cc | 3 +++ tools/metrics/histograms/enums.xml | 1 + 3 files changed, 5 insertions(+) commit 70e8a0474cd1121e2b5cbc396ef42fff27dd4a85 Author: Eliot Courtney <edcourtney@google.com> Date: Wed Mar 13 06:27:38 2019 +0000 Do not include the caption height for MINIMIZED->SNAPPED transition. have a space where the caption would be Bug: 929983 Test: snap minimized ARC app, it correctly becomes snapped and does not Test: unit test Change-Id: I8f80240096c68165bf0f62937f303c100ea417e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511092 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#640211} components/exo/client_controlled_shell_surface.cc | 9 ++++++++- .../client_controlled_shell_surface_unittest.cc | 23 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) commit c0c936ee8b90a6761866bc5e874847d663d8feff Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 13 06:26:48 2019 +0000 [Extensions] Add a relaxed .eslintrc.js for //chrome/test/data/extensions //chrome/test/data/extensions is pretty wildly out of sync with our JS style, but until we properly format it, it's not worth having the eslint rules apply. Add a relaxed restriction until we get it formatted. Bug: 941239 Change-Id: I976932941c2ef8e909339def1cd083cbc51bdd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519187 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640210} chrome/test/data/extensions/.eslintrc.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) commit e63c9c30bd5ea200a478ff396b764f41af8850dc Author: Hirokazu Honda <hiroh@chromium.org> Date: Wed Mar 13 06:24:09 2019 +0000 media: Vaapi VDA: Enable kReduced/kSuperReduced mode on all intel device if ALLOCATE mode It is fact that "split |decoder_|s GetRequiredNumOfPictures()", crrev.com/c/1387391, caused a regression. We tried to resolve the regressions by limiting it on newer platforms, crrev.com/c/1409353. However, peformance downgrades more which is side-effected by enabling MojoVideoDecoder crrev.com/c/1405284. This CL backs the performance status to the time when crrev.com/c/1387391 is landed, which were better than the present performance. Test results of video.PlaybackPerfVP92160P30FPS on panther: ToT: 44-45 ToT + this CL: 27-29 Bug: 912295, 920510, 925709 Test: tast run video.PlaybackPerfVP92160P30FPS on panther Change-Id: I6bdaa152cf96113ad2edbccc4944ab98708fa178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513996 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640209} media/gpu/vaapi/vaapi_video_decode_accelerator.cc | 34 ++++++++--------------- media/gpu/vaapi/vaapi_video_decode_accelerator.h | 2 ++ 2 files changed, 13 insertions(+), 23 deletions(-) commit 656ad76089b858a771527d1e687a6ac1faaa7041 Author: Jeevan Shikaram <jshikaram@chromium.org> Date: Wed Mar 13 06:17:48 2019 +0000 [App Management] Implement Notification Permissions for ARC Apps. Notification Permissions for ARC apps were not implemented on the ARC side. This change enables chromium to make mojom requests to view and change notification permissions. Bug: 916380 Change-Id: I229bfd236ff338d2dedf035cc2f37f5a8b6196a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517336 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#640208} chrome/browser/resources/app_management/arc_permission_view.html | 6 ++---- chrome/browser/resources/app_management/fake_page_handler.js | 1 + chrome/browser/ui/webui/app_management/app_management.mojom | 7 ++++--- components/arc/common/app_permissions.mojom | 7 ++++--- 4 files changed, 11 insertions(+), 10 deletions(-) commit 074c3ad7d075d0043519c8fe49f373abc497a093 Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 06:16:36 2019 +0000 Change unsigned long long to uint64_t in third_party/blink/renderer/* - unsigned long long -> uint64_t - Use base::CheckedNumeric in image_decoder.h - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929980 Change-Id: Ifb70e997a40e6e443155a55abbe69693dd33ac5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517052 Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#640207} .../blink/renderer/bindings/core/v8/v8_binding_for_core.h | 11 +++++------ third_party/blink/renderer/core/dom/dom_time_stamp.h | 4 +++- .../blink/renderer/core/exported/web_frame_serializer.cc | 3 +-- third_party/blink/renderer/core/frame/local_frame_view.h | 2 +- .../renderer/core/inspector/inspector_performance_agent.h | 4 ++-- .../renderer/modules/notifications/notification_data_test.cc | 2 +- .../renderer/modules/webaudio/audio_worklet_global_scope.h | 2 +- .../blink/renderer/platform/image-decoders/image_decoder.h | 11 +++++------ 8 files changed, 19 insertions(+), 20 deletions(-) commit 4f1375e575682290721455658a034c5860d14349 Author: François Beaufort <beaufort.francois@gmail.com> Date: Wed Mar 13 06:16:33 2019 +0000 Allow the ChromeOS Video Player app to use <video> autoPictureInPicture Following low-latency canvas for PDF annotations feature approach, this CL makes sure Auto Picture-in-Picture is enabled for the built-in Chrome OS video player app. https://chromium-review.googlesource.com/c/chromium/src/+/1506916 https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/eFZ3h_A3VTY Bug: 938226 Change-Id: I0a1bd32130612a5ab1d2034751df293c76669ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508400 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: dstockwell <dstockwell@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#640206} chrome/browser/chromeos/file_manager/video_player_browsertest.cc | 6 ------ third_party/blink/renderer/core/loader/document_loader.cc | 8 ++++++++ 2 files changed, 8 insertions(+), 6 deletions(-) commit b367585dfe58911e65180f8cc046b6d0de56492f Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Mar 13 06:10:23 2019 +0000 [AF] Extend set of sync files co-owned by the sync team This CL makes sure all core autofill sync source code is co-owned by the sync team. Bug: none Change-Id: If481dfa736e283abad24b7ac93f7f6e6626558c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518517 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#640205} components/autofill/core/browser/OWNERS | 3 +++ components/autofill/core/browser/webdata/OWNERS | 6 ++++++ 2 files changed, 9 insertions(+) commit 82f18b5221d5520babacb1fb4c1dba1cb3986d53 Author: Joshua Pawlicki <waffles@chromium.org> Date: Wed Mar 13 06:03:56 2019 +0000 Switch to test crx3 Bug: 740715 Change-Id: I72aa072fb6ec46e0af94c6b479fbb6af378c9480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515637 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640204} chrome/test/data/extensions/gcm2.crx | Bin 896 -> 923 bytes chrome/test/data/extensions/gcm2.pem | 16 ++++++++++++++++ .../data/extensions/policy_shared_module/importer.crx | Bin 1023 -> 1050 bytes .../extensions/policy_shared_module/shared_module.crx | Bin 1014 -> 1041 bytes extensions/common/verifier_formats.cc | 3 +-- 5 files changed, 17 insertions(+), 2 deletions(-) commit e53cfb2f63883b4796ec002b11f0524c5e25aa92 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Wed Mar 13 05:57:12 2019 +0000 Disable vulkan_content_browsertests on more Linux GPU FYI bots These tests were disabled on a couple of Linux GPU FYI bots earlier but there are flakes on other bots as well. Bug: 940723 Change-Id: If4c7a519bf36bea3ad5e726675e798cb2129cbcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519101 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640203} testing/buildbot/chromium.gpu.fyi.json | 68 ------------------------------ testing/buildbot/test_suite_exceptions.pyl | 2 + 2 files changed, 2 insertions(+), 68 deletions(-) commit 6d288755364559f4e4ad609650903b4e5885cee7 Author: Andrey Kosyakov <caseq@chromium.org> Date: Wed Mar 13 05:56:22 2019 +0000 DevTools: add a test for sequence of nav events when posting a form from onload Change-Id: I7dd3f44317d371cd31ee494fa3ead3c2e78c802a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519326 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640202} .../page/form-post-scheduled-navigation-expected.txt | 8 ++++++++ .../page/form-post-scheduled-navigation.js | 16 ++++++++++++++++ .../page/resources/post-in-onload.html | 7 +++++++ 3 files changed, 31 insertions(+) commit 2aa7347fd859262ee0a54ed2453cf185df2e54fc Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Mar 13 05:47:04 2019 +0000 Re-land: Links and docs with just one image inside should get annotated. Landed in r639835: http://crrev.com/c/1512916 Reverted in r640194: http://crrev.com/c/1519933 Newly-added tests were flaky, will disable and then attempt to fix flakiness in follow-up. Links and docs with just one image inside should get annotated. There were cases where no annotation was being read for an image inside of a link, depending on the exact syntax and the platform and screen reader. In addition, some screen readers weren't reading the image annotation when opening an image by itself in a tab. Address both of these by having a rootWebArea or link get the annotation of its inner image, when it has exactly one inner image and no other text or object with a name inside. TBR=katie@chromium.org Bug: 940043 Change-Id: Ib15a6ed7a6732a50b0fd32f6c34f89686718cc72 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519938 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640201} .../accessibility/image_annotation_browsertest.cc | 76 ++++++++++++++++++++++ .../data/accessibility/image_annotation_doc.html | 6 ++ .../data/accessibility/image_annotation_link.html | 30 +++++++++ .../renderer/accessibility/ax_image_annotator.cc | 34 ++++++++-- .../renderer/accessibility/ax_image_annotator.h | 5 ++ .../renderer/accessibility/blink_ax_tree_source.cc | 72 +++++++++++++++++++- .../render_accessibility_impl_browsertest.cc | 4 +- 7 files changed, 218 insertions(+), 9 deletions(-) commit 342f6ea958a10b64d6730ca400bf824fad2c824d Author: Tsuyoshi Horo <horo@chromium.org> Date: Wed Mar 13 05:35:47 2019 +0000 Add tests of cross origin prefetching Bug: 939317 Change-Id: Ie1d6bb140b83df3e7135be6f2ccf1c2771be4697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517212 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#640200} content/browser/loader/prefetch_browsertest.cc | 528 +++++++++++++++++-------- 1 file changed, 373 insertions(+), 155 deletions(-) commit e51013dc3007aea626189c74a41ce6b5c1a2cdf9 Author: Johann Koenig <johannkoenig@google.com> Date: Wed Mar 13 05:21:09 2019 +0000 libaom: simplify sed regex This introduces some extra whitespace. Update the .asm generation to account for it. Change-Id: Ica812be73faefa29c4124bd543ef0529f3438672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516127 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by: James Zern <jzern@google.com> Auto-Submit: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#640199} third_party/libaom/cmake_update.sh | 54 ++++++++++++++++---------------------- 1 file changed, 23 insertions(+), 31 deletions(-) commit ad7522364b2a0793d34320cb940b34602e782fa2 Author: Jerome Jiang <jianj@google.com> Date: Wed Mar 13 05:15:33 2019 +0000 Revert "Roll src/third_party/libvpx/source/libvpx/ 8256c8b29..855a71dfd (9 commits)" This reverts commit 4b144ffda76694965bb5dca0a9cd1749deecd881. Reason for revert: This breaks WebRTC tests for inter-layer prediction. Original change's description: > Roll src/third_party/libvpx/source/libvpx/ 8256c8b29..855a71dfd (9 commits) > > https://chromium.googlesource.com/webm/libvpx.git/+log/8256c8b297c8..855a71dfda9f > > $ git log 8256c8b29..855a71dfd --date=short --no-merges --format='%ad %ae %s' > 2019-03-08 marpan vp9-screen: Rework the mode skip logic for screen > 2019-03-08 marpan vp9-screen: Fix to screen wth layered encoding > 2019-03-04 chiyotsai Optimize SSE4_1 lowbd temporal filter implementation > 2019-03-04 jianj vp9 svc: add simulcast mode when inter-layer pred is off. > 2019-03-07 marpan vp9-svc: Fix to sample encoder for 1 layer > 2019-03-05 angiebird Include mv_mode_arr info in dump_tpl_stats > 2019-03-05 angiebird Include gf_frame_offset in dump_tpl_stats > 2019-03-05 angiebird Refactor dump_tpl_stats > 2019-02-28 chiyotsai Add SSE4_1 highbd version of temporal filter > > Created with: > roll-dep src/third_party/libvpx/source/libvpx > R=​johannkoenig@google.com > > Change-Id: I0c7e78d00295bed61a26317e9b49c2d37721127e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516457 > Reviewed-by: Johann Koenig <johannkoenig@google.com> > Commit-Queue: Jerome Jiang <jianj@google.com> > Cr-Commit-Position: refs/heads/master@{#640088} TBR=johannkoenig@google.com,jianj@google.com Change-Id: Ib43d82f6f9d8bae0433a8857f4637aaa26f5b35d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519937 Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#640198} DEPS | 2 +- third_party/libvpx/README.chromium | 4 +-- third_party/libvpx/libvpx_srcs.gni | 37 ++++++++++++++++---------- third_party/libvpx/source/config/vpx_version.h | 6 ++--- 4 files changed, 29 insertions(+), 20 deletions(-) commit a5928a0a00e8ec90e9ed380a99b5cf1be6f26961 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Wed Mar 13 05:04:42 2019 +0000 Use blink::mojom::ConsoleMessageLevel instead of content::ConsoleMessageLevel blink::mojom::ConsoleMessageLevel and content::ConsoleMessageLevel are essentially the same enums and represent same values for logging. This CL replace use of content::ConsoleMessageLevel with blink::mojom::ConsoleMessageLevel. Bug: 937184 Change-Id: I4300df7d69c9759bac33947a4a857a5ecf3cb16d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506672 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#640197} chrome/browser/banners/app_banner_manager.cc | 2 +- .../launcher_search_provider/error_reporter.cc | 6 ++-- .../download/chrome_download_manager_delegate.cc | 2 +- .../certificate_provider_api.cc | 10 +++--- chrome/browser/extensions/api/mdns/mdns_api.cc | 13 ++++--- chrome/browser/extensions/api/mdns/mdns_api.h | 2 +- .../extensions/api/processes/processes_api.cc | 2 +- chrome/browser/installable/installable_logging.cc | 9 ++--- .../use_counter_page_load_metrics_observer.cc | 2 +- .../browser/permissions/permission_context_base.cc | 2 +- .../push_messaging/push_messaging_service_impl.cc | 3 +- .../extension_api/tts_engine_extension_api.cc | 4 +-- chrome/browser/ssl/security_state_tab_helper.cc | 4 +-- chrome/browser/ssl/ssl_error_handler.cc | 2 +- .../safe_browsing_triggered_popup_blocker.cc | 6 ++-- .../tab_under_navigation_throttle.cc | 4 +-- .../javascript_dialog_tab_helper.cc | 4 +-- .../renderer/plugins/chrome_plugin_placeholder.cc | 2 +- components/payments/content/DEPS | 1 + .../payments/content/developer_console_logger.cc | 4 +-- .../content/installable_payment_app_crawler.cc | 2 +- components/payments/content/manifest_verifier.cc | 2 +- .../content_subresource_filter_throttle_manager.cc | 4 +-- .../content/browser/navigation_console_logger.cc | 2 +- .../content/browser/navigation_console_logger.h | 6 ++-- .../browser/navigation_console_logger_unittest.cc | 30 ++++++++-------- .../subframe_navigation_filtering_throttle.cc | 4 +-- ...rce_filter_safe_browsing_activation_throttle.cc | 4 +-- .../bluetooth_device_chooser_controller.cc | 2 +- .../browsing_data/clear_site_data_handler.cc | 19 +++++----- .../browsing_data/clear_site_data_handler.h | 12 ++++--- .../clear_site_data_handler_unittest.cc | 15 ++++---- .../browsing_data/clear_site_data_throttle.cc | 21 +++++------ .../browsing_data/clear_site_data_throttle.h | 11 +++--- .../clear_site_data_throttle_unittest.cc | 13 +++---- content/browser/frame_host/ancestor_throttle.cc | 6 ++-- .../blocked_scheme_navigation_throttle.cc | 4 +-- content/browser/frame_host/navigation_request.cc | 8 +++-- .../browser/frame_host/render_frame_host_impl.cc | 5 +-- .../browser/frame_host/render_frame_host_impl.h | 2 +- .../keyboard_lock/keyboard_lock_service_impl.cc | 4 +-- .../browser/manifest/manifest_icon_downloader.cc | 11 +++--- .../browser/payments/payment_app_info_fetcher.cc | 10 +++--- .../push_messaging/push_messaging_manager.cc | 5 +-- .../service_worker_context_watcher.cc | 1 - content/browser/ssl/ssl_manager.cc | 2 +- .../browser/web_contents/web_contents_android.cc | 4 +-- content/browser/web_contents/web_contents_impl.cc | 2 +- .../web_package/signed_exchange_devtools_proxy.cc | 2 +- content/common/frame_messages.h | 4 +-- content/public/browser/render_frame_host.h | 4 +-- content/public/common/common_param_traits_macros.h | 6 ++-- content/public/renderer/render_frame.h | 4 +-- .../renderer/pepper/pepper_media_device_manager.cc | 7 ++-- content/renderer/render_frame_impl.cc | 34 ++++++------------ content/renderer/render_frame_impl.h | 6 ++-- content/test/test_render_frame_host.cc | 5 +-- content/test/test_render_frame_host.h | 2 +- extensions/browser/api/alarms/alarms_api.cc | 2 +- .../browser/api/alarms/alarms_api_unittest.cc | 4 +-- .../browser/api/app_window/app_window_api.cc | 10 +++--- .../browser/api/vpn_provider/vpn_provider_api.cc | 2 +- .../browser/app_window/app_web_contents_helper.cc | 6 ++-- extensions/browser/app_window/app_window.cc | 2 +- extensions/browser/extension_function.cc | 2 +- extensions/browser/extension_function.h | 4 +-- extensions/browser/suggest_permission_util.cc | 7 ++-- extensions/renderer/DEPS | 1 + extensions/renderer/console.cc | 41 +++++++--------------- extensions/renderer/console.h | 4 +-- extensions/renderer/content_setting.cc | 4 +-- extensions/renderer/extension_frame_helper.h | 2 +- extensions/renderer/module_system.cc | 6 ++-- .../renderer/native_extension_bindings_system.cc | 4 +-- .../renderer/object_backed_native_handler.cc | 3 +- .../public/mojom/devtools/console_message.mojom | 2 -- 76 files changed, 230 insertions(+), 245 deletions(-) commit 62bd3e5aeed09cfae7098ebde83a163116c639e5 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Wed Mar 13 04:49:08 2019 +0000 ServiceWorker: Separate entry points of {new,installed} {classic,module} script fetch For code simplification, this CL separates entry points of off-the-main-thread {new,installed} {classic,module} script fetch on ServiceWorkerGlobalScope as follows: - new classic script: FetchAndRunClassicScript() - new module script: FetchAndRunModuleScript() - installed classic script: RunInstalledClassicScript() - installed module script: RunInstalledModuleScript() In addition, this CL... - routes RunInstalled{Classic,Module}Script() calls from the main thread via ServiceWorkerThread (not WorkerThread) for better class layering. - adds a function ServiceWorkerGlobalScope::RunClassicScript() that implements the "Run Service Worker" algorithm defined in the service worker spec. This enables both FetchAndRunClassicScript() and RunInstalledClassicScript() to share the initialization and script evaluation code. - adds more spec texts. Bug: 938219 Change-Id: I3ac9c951d5f410c646efaf91b6e4cdb632a65f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516126 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#640196} .../modules/exported/web_embedded_worker_impl.cc | 85 +++++---- .../modules/exported/web_embedded_worker_impl.h | 4 +- .../service_worker/service_worker_global_scope.cc | 190 ++++++++++++--------- .../service_worker/service_worker_global_scope.h | 26 ++- .../service_worker/service_worker_thread.cc | 51 ++++++ .../modules/service_worker/service_worker_thread.h | 16 ++ 6 files changed, 250 insertions(+), 122 deletions(-) commit 3fc684865b79bd4b7990432df98a8547d994286f Author: David Bokan <bokan@chromium.org> Date: Wed Mar 13 04:48:49 2019 +0000 Create InputHandlerProxy in LayoutTests In LayoutTests, the compositor is run in "single threaded" mode. This means there is no compositor thread and the compositor runs on the same thread as Blink. Until now, input handling code would have branches based on whether we have a compositor thread. If no compositor thread existed, we would forward input directly to Blink by going through RenderWidgetInputHandler. This never happens (for frames) in shipped Chrome, where input always flows through InputHandlerProxy and, if it requires handling on the main thread, is returned and potentially queued for rAF before being dispatched to Blink from IHP. In this CL, we create an InputHandlerProxy even if we're in single threaded mode. In this case, we'll use the same "fallback to main" logic that's used in production. This should provide more consistency in behavior with how we operate in production. It will also allow us to (in a future CL) test compositor-side input handling without having to run layout tests in threaded mode, which is what we currently do for input features that have a compositor-side implementation. We still avoid using the cc input handler for non-frame RenderWidgets like popups and plugins since they don't use a compositor. Input handling is unchanged in these cases. In single-thread/layout-test mode, this CL makes InputHandlerProxy force all events to the main thread. In a future CL, we'll make this parameterized based on which side of the divide tests want to operate on. Finally, this CL changes behavior in some tests so we update the expectations. Now that we take the "real" path to the main thread, events get coalesced and scheduled based on event handler presence as they would in the real world so this is expected. Bug: 915926 Change-Id: Ic0e0f0c88b142f109dab31df1f9bac63d5597237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1390330 Reviewed-by: Stefan Zager <szager@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640195} .../renderer/input/widget_input_handler_manager.cc | 79 ++-- .../renderer/input/widget_input_handler_manager.h | 22 +- content/renderer/render_widget.cc | 7 +- .../events/pointerevents/multi-touch-events.html | 3 +- .../input/dispatchTouchEvent-expected.txt | 17 - .../inspector-protocol/input/dispatchTouchEvent.js | 8 +- ui/events/blink/input_handler_proxy.cc | 9 +- ui/events/blink/input_handler_proxy.h | 8 +- ui/events/blink/input_handler_proxy_unittest.cc | 426 ++++++++++++--------- 9 files changed, 329 insertions(+), 250 deletions(-) commit 9d7ba34e9ad8af99e9b57ba680d2778d016829ae Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Mar 13 04:42:49 2019 +0000 Revert "Links and docs with just one image inside should get annotated." This reverts commit b8da3f9a6fd6f77c140ddbcc8aa9244a1fbcf529. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 639835 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjhkYTNmOWE2ZmQ2Zjc3YzE0MGRkYmNjOGFhOTI0NGExZmJjZjUyOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/50176 Sample Failed Step: browser_tests Sample Flaky Test: ImageAnnotationBrowserTest.ImagesInLinks Original change's description: > Links and docs with just one image inside should get annotated. > > There were cases where no annotation was being read for an image > inside of a link, depending on the exact syntax and the platform > and screen reader. In addition, some screen readers weren't > reading the image annotation when opening an image by itself in > a tab. > > Address both of these by having a rootWebArea or link get the > annotation of its inner image, when it has exactly one inner > image and no other text or object with a name inside. > > Bug: 940043 > Change-Id: Ic3283e6f8ea26f1ec9ed1cb1203800cd44a49a00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512916 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639835} Change-Id: I94a23c0db273b554ba2586d1a6165993faffb3fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940043 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519933 Cr-Commit-Position: refs/heads/master@{#640194} .../accessibility/image_annotation_browsertest.cc | 74 ---------------------- .../data/accessibility/image_annotation_doc.html | 6 -- .../data/accessibility/image_annotation_link.html | 30 --------- .../renderer/accessibility/ax_image_annotator.cc | 34 ++-------- .../renderer/accessibility/ax_image_annotator.h | 5 -- .../renderer/accessibility/blink_ax_tree_source.cc | 72 +-------------------- .../render_accessibility_impl_browsertest.cc | 4 +- 7 files changed, 9 insertions(+), 216 deletions(-) commit a72b4c08b34245ae99147426b98799bd51e6dd15 Author: Robert Kaplow <rkaplow@chromium.org> Date: Wed Mar 13 04:40:51 2019 +0000 Some UI cleanups to chrome://ukm. Put the filter selections first. Add titles to the source table. Sort the metrics within an event. Removed the 'warnings' div, as it seems to be unused (am I missing something?) Bug: 941169 Change-Id: I26d8de8b9a2fe912000b500c63335bb6d96b5dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518839 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#640193} components/ukm/debug/ukm_internals.html | 9 ++++----- components/ukm/debug/ukm_internals.js | 23 +++++++++++++++++++---- 2 files changed, 23 insertions(+), 9 deletions(-) commit 73e7efc59060033748fb8de67f25f7d0a7c4248e Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Wed Mar 13 04:39:47 2019 +0000 Android: Inline Tab.loadIfNecessary The method has no outer call site. This CL inlines the method into the single internal call site. Bug: 925242 Change-Id: I9241dbaf796157b7c27c2c0bd24358855993445d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510628 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#640192} chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) commit ea50052073418fca6b6992002dae7a0b57b6e9f9 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Mar 13 04:39:44 2019 +0000 SuperSize: Change archive "stats" to show only for -vv You can always see the stats via "supersize console". Computing these stats takes >10 seconds, so slows down binary size trybot. Bug: 939165 Change-Id: Ie8e0022424bb63a143a9ac5b7e616233e6f09247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518898 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#640191} tools/binary_size/libsupersize/archive.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8d0bd841caa01f1f2b900671762e3cd3b4a3509c Author: Daniele Castagna <dcastagna@chromium.org> Date: Wed Mar 13 04:38:43 2019 +0000 Port FastInkView to SharedImage Use SharedImageInterface to create mailboxes in FastInk instead of GLES2. This removes FastInkView reliance on GLES2 API. Test: Laser pointer on nocturne with a pen. Change-Id: Ie7f5fcdd04bb28b70356ec687a5f7b6d3e9aac4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513738 Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#640190} ash/components/fast_ink/BUILD.gn | 3 +- ash/components/fast_ink/DEPS | 1 + ash/components/fast_ink/fast_ink_view.cc | 63 +++++++--------------- components/viz/test/test_context_provider.cc | 7 +++ components/viz/test/test_context_provider.h | 1 + gpu/command_buffer/client/shared_image_interface.h | 4 ++ .../common/gpu_memory_buffer_support.cc | 1 + gpu/ipc/client/shared_image_interface_proxy.cc | 14 +++-- gpu/ipc/client/shared_image_interface_proxy.h | 1 + gpu/ipc/in_process_command_buffer.cc | 7 +++ 10 files changed, 53 insertions(+), 49 deletions(-) commit 7a0f5628b671e96b6ef24f11bcc7f77f89c8f5fd Author: Tommy C. Li <tommycli@chromium.org> Date: Wed Mar 13 04:38:39 2019 +0000 Omnibox: Add a Remove Suggestion bubble accessed via context menu Overall goal of the project is to provide a context menu for omnibox suggestions for users to do things - like remove suggestions from history. This CL adds the bubble implementation confirming the removal of suggestions from history. Screenshots here: go/context-menu-for-suggestions Bug: 929477 Change-Id: I7be9479266428c938e999c8afa0e926002693396 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460432 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640189} .../browser/ui/omnibox/omnibox_view_browsertest.cc | 2 +- .../browser/ui/views/omnibox/omnibox_result_view.cc | 20 +++++++++++++++++++- .../browser/ui/views/omnibox/omnibox_result_view.h | 3 +++ .../browser/ui/views/omnibox/omnibox_view_views.cc | 19 +++++++++++++------ components/omnibox/browser/omnibox_popup_model.cc | 19 ++++++++++--------- components/omnibox/browser/omnibox_popup_model.h | 7 ++++--- 6 files changed, 50 insertions(+), 20 deletions(-) commit e018ea5f9ba6826e4a7102c7592e8aa95f459561 Author: Adrienne Walker <enne@chromium.org> Date: Wed Mar 13 04:37:35 2019 +0000 Remove enable passthrough raster decoder flag This is always available, so no need for a flag or preference. Change-Id: I21f4cadd0c3362f5e45db4b3dc29e4929ff1ddbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496542 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Jonathan Backer <backer@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#640188} content/browser/renderer_host/render_process_host_impl.cc | 1 - content/public/browser/gpu_utils.cc | 5 ----- gpu/command_buffer/service/gpu_switches.cc | 4 ---- gpu/command_buffer/service/gpu_switches.h | 1 - gpu/config/gpu_preferences.h | 1 - gpu/config/gpu_util.cc | 4 ---- gpu/ipc/common/gpu_preferences.mojom | 1 - gpu/ipc/common/gpu_preferences_struct_traits.h | 6 ------ gpu/ipc/in_process_command_buffer.cc | 9 +-------- gpu/ipc/service/gpu_channel.cc | 10 +--------- .../ws/public/cpp/gpu/context_provider_command_buffer.cc | 14 +------------- 11 files changed, 3 insertions(+), 53 deletions(-) commit 223d41a74d03aa4a54f6b833689e7304869bfd12 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 13 04:37:31 2019 +0000 Update V8 to version 7.5.23. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3dd1e8e0..8252496f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I14db1497bdf338c453679581c003ea93bfaacca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519167 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640187} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 54744c955cd60175454bfbeb3d8dfc0abfab7f67 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 02:41:12 2019 +0000 Roll src/third_party/catapult a7314e4d2310..967fadd27a67 (2 commits) https://chromium.googlesource.com/catapult.git/+log/a7314e4d2310..967fadd27a67 git log a7314e4d2310..967fadd27a67 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 rmhasan@google.com Adds new method that returns browser information tags to SeriallyExecutedBrowserTestCase 2019-03-12 rmhasan@google.com Reland "Modifies format of --test-filter value for telemetry browser tests" Created with: gclient setdep -r src/third_party/catapult@967fadd27a67 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:698902,chromium:938586,chromium:698902 TBR=sullivan@chromium.org Change-Id: Ib01b0595f9f97e3885cdf2ad73135b7d6b6a8db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518397 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640186} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a72ffe7ee48f23ea1ed43f1f6df967a672112965 Author: Yuri Wiitala <miu@chromium.org> Date: Wed Mar 13 02:33:46 2019 +0000 AudioService: Finish SnooperNode tests + timing bug fix. Provides missing testing of key functionality, cleans-up existing tests somewhat to improve readability and robustness, resolves run-time performance issues, and improves debugging facilities. As a result, a timing bug was also discovered and fixed in this change. 😃 1. Added a "dump to WAV file" function, activated via a command-line switch, to aid in confirming test correctness and otherwise debugging future issues. This allows developers to visualize the audio signal with an external editor. 2. By using #1, I came to a better understanding of the sources of timing and resolution error. Thus, certain test issues were better accounted for, and documented in the code. 3. Fixed timing bug in SnooperNode: The recently-added SuggestLatestRenderTime() method needed to also account for the pre- bufferred audio in the resampler. Bug: 934770, 842428 Change-Id: Ieb1638a9cd4b1703ed0325cd6cf365646db6b1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513045 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640185} services/audio/snooper_node.cc | 19 +- services/audio/snooper_node_unittest.cc | 644 +++++++++++++++++----- services/audio/test/fake_consumer.cc | 34 ++ services/audio/test/fake_consumer.h | 5 + services/audio/test/fake_loopback_group_member.cc | 10 +- services/audio/test/fake_loopback_group_member.h | 6 +- 6 files changed, 575 insertions(+), 143 deletions(-) commit 342081806e46ebf535b8fa6f39a44054c6f29aef Author: Chris Hall <chrishall@chromium.org> Date: Wed Mar 13 02:26:18 2019 +0000 Language detection minimum viable product. Hidden behind feature flag --enable-experimental-accessibility-language-detection Tuning and optimisations to come as follow-ups before feature goes live. R=aboxhall,dmazzoni,abakalov TBR=abakalov@chromium.org BUG=889370 Adding abakalov@ to TBR, he has given verbal LGTM but is unable to set code-review bit. Change-Id: Ie295f2ae1fed4a9c05fd751f913f7b2432e3d47c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484885 Auto-Submit: Chris Hall <chrishall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640184} .../accessibility_tree_formatter_blink.cc | 16 +- .../accessibility/browser_accessibility_cocoa.mm | 7 +- .../accessibility/browser_accessibility_com_win.cc | 6 +- .../dump_accessibility_tree_browsertest.cc | 4 + .../accessibility/css/language-expected-mac.txt | 2 +- .../lang-attribute-expected-mac.txt | 2 +- .../lang-attribute-nested-expected-mac.txt | 4 +- .../lang-attribute-switching-expected-mac.txt | 6 +- .../lang-detection-basic-expected-blink.txt | 4 +- .../lang-detection-basic-expected-mac.txt | 4 +- .../lang-detection-basic-expected-win.txt | 6 +- ui/accessibility/BUILD.gn | 5 + ui/accessibility/DEPS | 1 + ui/accessibility/ax_language_info.cc | 254 +++++++++++ ui/accessibility/ax_language_info.h | 138 +++++- ui/accessibility/ax_language_info_unittest.cc | 487 +++++++++++++++++---- ui/accessibility/ax_node.cc | 39 +- ui/accessibility/ax_node.h | 25 +- ui/accessibility/ax_tree.cc | 10 + ui/accessibility/ax_tree.h | 5 + 20 files changed, 861 insertions(+), 164 deletions(-) commit 4e15136bd0edd6bd021279dd9e63586d1f5bdbd0 Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com> Date: Wed Mar 13 02:14:39 2019 +0000 vaapi_wrapper: Add debug log for Low-power encode enablement Print a debug message if VA-API Low Power Encode entrypoint is enabled. Change-Id: I5d984904b96a9e2f0828dd41fcb52182d2f830e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518246 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640183} media/gpu/vaapi/vaapi_wrapper.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 492be8308c39933e81b585141938939ae48bb09d Author: Tom Tan <Tom.Tan@microsoft.com> Date: Wed Mar 13 02:11:38 2019 +0000 Disable dav1d decoder for Windows ARM64 dav1d //third_party/dav1d/ has not been configured for Windows ARM64, disable building with it to unblock Windows ARM64 build. Bug: 893460, 941022 Change-Id: I3006f91add51a2cb0eea452f1c62b189f3034939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518457 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Tom Tan <Tom.Tan@microsoft.com> Cr-Commit-Position: refs/heads/master@{#640182} media/media_options.gni | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit f5e1f8b05b78ba1d93e78ab64e2ae67cb7d87231 Author: Chris Blume <cblume@chromium.org> Date: Wed Mar 13 02:07:03 2019 +0000 Synchronize Vulkan writes in AHB SharedImage Vulkan writes need to be synchronized with each other. Previously, Vulkan reads were synchronized with OpenGL writes. OpenGL reads and writes were synchronized with each other. This CL synchronizes Vulkan writes. BUG=930294 R=ericrk@chromium.org Change-Id: Ie15b7cc37beeb73b341f528b047424b80c22acee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503335 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640181} ...shared_image_backing_factory_ahardwarebuffer.cc | 367 +++++++++++++-------- 1 file changed, 230 insertions(+), 137 deletions(-) commit 992e28665f8c2db319f0c36f4e0977927a7f7212 Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 13 01:58:26 2019 +0000 Convert views::RepeatController::RepeatController To Use base::RepeatingClosure BUG=714018,940130 TBR=sky@chromium.org Change-Id: Ica3939fc4249d190dc2f79f5cd234d1b4e191a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519311 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640180} ui/views/controls/scrollbar/base_scroll_bar.cc | 4 ++-- ui/views/controls/scrollbar/base_scroll_bar_button.cc | 4 ++-- ui/views/repeat_controller.cc | 5 ++--- ui/views/repeat_controller.h | 4 ++-- 4 files changed, 8 insertions(+), 9 deletions(-) commit aa36cbd7410cf7d75266e1b3161a510008a3af7f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 01:58:07 2019 +0000 Roll AFDO from 74.0.3729.6_rc-r1-merged to 74.0.3729.7_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia241b99157718c0a1759f632fa5c7e222925eb35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519587 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640179} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bd0a3c872f4c3693c80bacb04922eb6b64137cca Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Wed Mar 13 01:49:53 2019 +0000 Remove unnecessary Create() factory function in Blink's core/animation Many classes in blink have supported factory functions with legacy uses of RefPtr/adoptRef. It can block to make to use MakeGarbageCollected. Besides some classes have supported both a factory function and a public constructor. They aren't necessary. This CL removes unnecessary Foo::Create() in //third_party/blink/renderer/core/animation and make their constructors public, then make the callers use std::make_unique_ptr<Foo> instead of their Create() factory functions. Bug: 939691 Change-Id: If216c4dd940af4622cac8a9b072de6e841db84ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517494 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#640178} .../core/animation/css/css_transition_data.h | 10 +++----- .../core/animation/css/css_transition_data_test.cc | 24 ++++++++++++------ .../css_basic_shape_interpolation_type.cc | 11 ++------ .../core/animation/css_clip_interpolation_type.cc | 12 +++------ .../core/animation/css_color_interpolation_type.cc | 10 ++------ .../css_custom_list_interpolation_type.cc | 2 +- ...s_font_variation_settings_interpolation_type.cc | 11 +++----- .../animation/css_image_list_interpolation_type.cc | 17 ++++--------- .../css_image_slice_interpolation_type.cc | 11 ++------ .../core/animation/css_interpolation_type.cc | 12 ++------- .../animation/css_length_interpolation_type.cc | 12 +++------ .../css_length_list_interpolation_type.cc | 18 ++++---------- .../animation/css_number_interpolation_type.cc | 10 ++------ .../core/animation/css_paint_interpolation_type.cc | 17 +++---------- .../core/animation/css_ray_interpolation_type.cc | 18 ++++---------- .../animation/css_rotate_interpolation_type.cc | 11 +++----- .../core/animation/css_scale_interpolation_type.cc | 9 +++---- .../animation/css_size_list_interpolation_type.cc | 29 ++++++---------------- .../animation/css_var_cycle_interpolation_type.cc | 10 ++------ .../svg_length_list_interpolation_type.cc | 2 +- .../svg_number_list_interpolation_type.cc | 2 +- .../animation/svg_point_list_interpolation_type.cc | 2 +- .../svg_transform_list_interpolation_type.cc | 12 +++------ .../core/animation/underlying_length_checker.h | 9 ++----- .../blink/renderer/core/style/computed_style.cc | 2 +- 25 files changed, 84 insertions(+), 199 deletions(-) commit 94d2e3578f28e688ae9210df7b4a1b3a2d370a6d Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Wed Mar 13 01:45:33 2019 +0000 Make TakeFrontBuffer a deferred message If TakeFrontBuffer is sent as an independent IPC message, it's possible for it to be sequenced incorrectly with the preceding ReturnFrontBuffer message if there was no flush in between. This is a speculative fix for legacy ARC app rendering issues. Bug: 937524 Change-Id: I17792ed28e5c97e337c60a9c1f3dc440239c51b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517160 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#640177} gpu/ipc/client/command_buffer_proxy_impl.cc | 5 ++++- gpu/ipc/service/gpu_channel.cc | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) commit adc0e9be5563cee7dc975f4d3ae866098431fed7 Author: Joel Einbinder <einbinder@chromium.org> Date: Wed Mar 13 01:43:38 2019 +0000 DevTools: Focus the add workspace button by default Bug: 759491 Change-Id: I4dc8f3a1971964a2b301c4ca3c4e438e9d84ee27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513208 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#640176} .../renderer/devtools/front_end/persistence/WorkspaceSettingsTab.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 7f823e864b620773935e2bc0920f49614372ed1e Author: Andrew Luo <aluo@chromium.org> Date: Wed Mar 13 01:43:05 2019 +0000 Updated cts tests to latest versions Bug: 936222 Test: run_cts.py -f android.webkit.cts.WebViewTest.testLoadDataWithBaseUrl Change-Id: I1d28caefa4b96ae0a20ed1cf5018040e4f1d7a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516788 Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Auto-Submit: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#640175} DEPS | 2 +- android_webview/tools/cts_archive/cipd.yaml | 12 +++---- android_webview/tools/cts_archive/version.txt | 2 +- .../tools/cts_config/webview_cts_gcs_path.json | 42 +++++++++++----------- 4 files changed, 29 insertions(+), 29 deletions(-) commit 605b83720a34135bda61aacf5503bbe267eaed78 Author: Nicholas Hollingum <hollingum@google.com> Date: Wed Mar 13 01:41:57 2019 +0000 crostini transient windows: visibility controlled by parent By design, crostini transient windows (e.g. info dialogs, popups, context menus) do not have a shelf icon. As a result, minimizing and maximizing a window with an active transient child would permanently hide the child (i.e. you'd have to kill -9 the window process). We explicitly set the behaviour that transient windows visibility is controlled by the parent, which fixes almost all of these cases. This change will be made to all exo:: windows. Bug: 930597 Change-Id: Ieba345d43219f5bcb6a205beaa0996fc7045e06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501193 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#640174} components/exo/shell_surface.cc | 38 ++++++++++++++++++++++++++++++++ components/exo/shell_surface.h | 7 ++++++ components/exo/shell_surface_base.cc | 18 --------------- components/exo/shell_surface_base.h | 5 +---- components/exo/shell_surface_unittest.cc | 35 +++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 22 deletions(-) commit c13d53949366a325dc1e3ac68ac5b8e3bbf23f73 Author: Igor Kobylin <ikobylin@yandex-team.ru> Date: Wed Mar 13 01:39:21 2019 +0000 Replace direct call of cr.addWebUIListener with WebUIListenerBehavior R=dpapad@chromium.org Bug: None Change-Id: I336834ca1e138221203ad5bf23e751e37a248d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516492 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640173} ui/webui/resources/cr_components/managed_footnote/BUILD.gn | 2 +- .../resources/cr_components/managed_footnote/managed_footnote.html | 1 + ui/webui/resources/cr_components/managed_footnote/managed_footnote.js | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) commit 1374013cf7fbcf6c8f854534a864ad8f0035de0b Author: David Bokan <bokan@chromium.org> Date: Wed Mar 13 01:18:34 2019 +0000 Skip MISSED frames in browser compositor This CL fixes a dropped frame issue when a scroll transitions from dragging to a momentum "fling" phase. When the user is scrolling and lifts their finger with velocity, the scroll continues according to a decelerating animation curve. When this happens, the FlingController receives a FlingStart instead of a ScrollUpdate and it uses that to create an animation curve. When this happens the browser process registers itself as an animation observer so that it begins to receive BeginFrame signals. However, the display service issues a MISSED BeginFrame for the frame in which the animation was registered. This will frequently miss submission in the current frame, so it submit next frame and won't receive a BeginFrame then. This leads to a frame without the browser ticking the fling animation. See https://crbug.com/882907#c50 for a diagram and more complete explanation of the issue. The browser process shouldn't require processing MISSED frames so in this CL we simply drop MISSED frames if we're in the browser compositor (commit_to_active_tree is true). Longer term, the display scheduler should make these decisions but this is an immediate fix for the fling issue. Bug: 882907 Change-Id: Ieb6d14051dc05c5e177da1920dbd27684f941d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517164 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#640172} cc/scheduler/scheduler.cc | 11 +++++++++++ cc/scheduler/scheduler_unittest.cc | 20 ++++++++++++++++++++ 2 files changed, 31 insertions(+) commit 76c92640a648c363b6b39b008a4cf4b791b311e9 Author: Bo Liu <boliu@chromium.org> Date: Wed Mar 13 01:18:31 2019 +0000 aw: Implement GrabViewSnapshotAsync for webview Add a callback on ViewAndroid and set it for RWHVA's instance. If we ever need to readback WebContent's instance, we could set the callback there as well on RWHVA swap. This CL is intended to get GPU tests working so it's not needed yet. The rest of the code path is fairly straightforward. Note though since webview do not actually control the render thread, it's not always guaranteed that a readback will be fulfilled. However this is probably better than failing immediately though. One tricky function is WaitAndPruneFrameQueue which had to be updated in order to avoid dropping copy requests. Bug: 938956 Change-Id: I504db3200d13be062593dd82da8189193a3f6cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513732 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640171} .../browser/gfx/browser_view_renderer.cc | 20 ++++++++- .../browser/gfx/browser_view_renderer.h | 5 +++ android_webview/browser/gfx/child_frame.cc | 7 ++- android_webview/browser/gfx/child_frame.h | 9 +++- android_webview/browser/gfx/hardware_renderer.cc | 42 ++++++++++++++---- android_webview/browser/gfx/hardware_renderer.h | 14 +++--- .../browser/android/synchronous_compositor_host.cc | 8 ++++ .../browser/android/synchronous_compositor_host.h | 2 + .../render_widget_host_view_android.cc | 1 + .../android/synchronous_compositor_client.h | 10 +++++ ui/android/view_android.cc | 15 +++++++ ui/android/view_android.h | 17 ++++++++ ui/snapshot/snapshot_android.cc | 51 ++++++++++++++-------- 13 files changed, 164 insertions(+), 37 deletions(-) commit fde466435627a44e7f155a0d64082ffb8abca326 Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 13 01:17:29 2019 +0000 Convert ui::Layer::SetDidScrollCallback To Use RepeatingCallback BUG=714018,940130 TBR=sky@chromium.org Change-Id: I78716f9980536f8707b14a23d01e1708a7ef280c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519105 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640170} ui/compositor/layer.cc | 4 ++-- ui/compositor/layer.h | 4 ++-- ui/views/controls/scroll_view.cc | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) commit 7c503bda01eb52597f06588ad2310bf465e6cec9 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 01:17:25 2019 +0000 Roll src-internal 76fbbeea67f5..77982de9efa9 (123 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76fbbeea67f5..77982de9efa9 Created with: gclient setdep -r src-internal@77982de9efa9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:790652,chromium:915409,chromium:937297,chromium:790080,chromium:790073,chromium:915409 TBR=ortuno@chromium.org,sdefresne@chromium.org,nicolaso@chromium.org Change-Id: I7446682e3a78a764fcb9c9d8e4cf18fa8e04cac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518365 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640169} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0909b9189c7d05fd5241c371ff2d1f96d6a32101 Author: Dmitry Gozman <dgozman@chromium.org> Date: Wed Mar 13 01:16:22 2019 +0000 Fix flaky xss-ALLOWED-same-origin-top-navigation-without-user-gesture.html We should not call testRunner.notifyDone() twice. TBR=dcheng@chromium.org Bug: 855189 Change-Id: I048d906968811e0b0e32d918630ab43648cf9b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518408 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640168} ...s-ALLOWED-same-origin-top-navigation-without-user-gesture.html | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 586a1bf5acbf67ce1ac7bc27bcc43fa2b1f58b84 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 01:16:17 2019 +0000 Roll Fuchsia SDK from ddb838f4b90d to 423fcfc30ccd The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I904dfc1f7723877afdc761dc70aa7f513250e9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518367 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640167} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 572274cdf07c5c23dc703e0043f11a349f393e55 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Wed Mar 13 01:15:16 2019 +0000 SignedExchange: Fallback redirect shouldn't accept signed-exchange After this patch, Accept header of SignedExchange fallback redirect requests will not have "application/signed-exchange;v=b3". Bug: 939684 Change-Id: Id1e7242413706523c5b19fd32b9e83f43263668a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514275 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#640166} .../browser/loader/navigation_url_loader_impl.cc | 8 +++ .../browser/web_package/signed_exchange_loader.cc | 12 ++-- .../signed_exchange_request_handler_browsertest.cc | 72 ++++++++++++++++++---- net/url_request/redirect_info.cc | 5 +- net/url_request/redirect_info.h | 7 ++- services/network/public/cpp/net_ipc_param_traits.h | 1 + 6 files changed, 88 insertions(+), 17 deletions(-) commit 224e8c23ceea93e0ba809c3761fd33a4c9d89d78 Author: Kevin Marshall <kmarshall@chromium.org> Date: Wed Mar 13 01:15:14 2019 +0000 [Fuchsia] Use memory offsets instead of file offsets for ELF headers. The ELF reader code uses file offsets for computing locations of data in ELF headers. It is technically incorrect but generally works on Intel without problems. However, ARM has wider alignment boundaries which results in the computation and access of incorrect memory addresses, producing page faults in certain circumstances. The bug is fixed by using p_vaddr instead of p_offset. Bug: 941279 Change-Id: Ia88dc58411dfe046f882a94cea0e80e8ec525957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518226 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#640165} base/debug/elf_reader.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 3fee67ea17ed8a32a1b3930e37bd7c3d11bfd8e8 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Wed Mar 13 01:14:11 2019 +0000 Switch the remaining classes in core/css to use downcast helpers (8/n) The following class is migrated: CSSPrimitiveValue. R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: Ie13d3379ee3fb63472b4a746f899ffe98075f47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518596 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#640164} .../templates/style_builder_functions.tmpl | 4 +- .../animation/css/css_animatable_value_factory.cc | 9 +- .../core/animation/css_angle_interpolation_type.cc | 5 +- ...s_border_image_length_box_interpolation_type.cc | 8 +- .../css_font_weight_interpolation_type.cc | 4 +- .../css_image_slice_interpolation_type.cc | 27 +++-- .../animation/css_number_interpolation_type.cc | 8 +- .../animation/css_resolution_interpolation_type.cc | 10 +- .../core/animation/css_scale_interpolation_type.cc | 2 +- .../core/animation/css_time_interpolation_type.cc | 5 +- .../animation/css_transform_interpolation_type.cc | 3 +- .../animation/filter_interpolation_functions.cc | 4 +- .../animation/length_interpolation_functions.cc | 10 +- .../renderer/core/animation/scroll_timeline.cc | 2 +- .../renderer/core/css/basic_shape_functions.cc | 11 +- .../blink/renderer/core/css/css_axis_value.cc | 6 +- .../renderer/core/css/css_basic_shape_values.cc | 4 +- .../core/css/css_calculation_value_test.cc | 2 +- .../blink/renderer/core/css/css_gradient_value.cc | 2 +- .../blink/renderer/core/css/css_image_set_value.cc | 2 +- .../blink/renderer/core/css/css_primitive_value.h | 8 +- third_party/blink/renderer/core/css/css_value.cc | 6 +- .../core/css/cssom/css_matrix_component.cc | 2 +- .../renderer/core/css/cssom/css_perspective.cc | 2 +- .../renderer/core/css/cssom/css_position_value.cc | 10 +- .../blink/renderer/core/css/cssom/css_rotate.cc | 12 +- .../blink/renderer/core/css/cssom/css_scale.cc | 12 +- .../blink/renderer/core/css/cssom/css_skew.cc | 4 +- .../blink/renderer/core/css/cssom/css_skew_x.cc | 2 +- .../blink/renderer/core/css/cssom/css_skew_y.cc | 2 +- .../blink/renderer/core/css/cssom/css_translate.cc | 12 +- .../renderer/core/css/cssom/style_value_factory.cc | 7 +- third_party/blink/renderer/core/css/font_face.cc | 45 ++++---- .../core/css/parser/css_property_parser_helpers.cc | 12 +- .../core/css/parser/css_property_parser_test.cc | 2 +- .../core/css/parser/sizes_calc_parser_test.cc | 2 +- .../core/css/properties/css_parsing_utils.cc | 11 +- .../properties/longhands/baseline_shift_custom.cc | 2 +- .../properties/longhands/custom_property_test.cc | 8 +- .../core/css/properties/longhands/size_custom.cc | 12 +- .../css/properties/longhands/text_indent_custom.cc | 8 +- .../properties/longhands/vertical_align_custom.cc | 2 +- .../core/css/properties/longhands/zoom_custom.cc | 16 +-- .../renderer/core/css/property_registration.cc | 9 +- .../renderer/core/css/resolver/css_to_style_map.cc | 26 ++--- .../core/css/resolver/filter_operation_resolver.cc | 16 +-- .../core/css/resolver/style_builder_converter.cc | 127 ++++++++++----------- .../core/css/resolver/style_builder_converter.h | 6 +- .../core/css/resolver/transform_builder.cc | 85 +++++++------- .../core/css/resolver/viewport_style_resolver.cc | 4 +- .../renderer/core/css/style_property_serializer.cc | 7 +- .../core/editing/commands/apply_style_command.cc | 4 +- .../blink/renderer/core/editing/editing_style.cc | 34 +++--- .../blink/renderer/core/html/html_image_element.cc | 7 +- third_party/blink/renderer/core/svg/svg_length.cc | 4 +- 55 files changed, 338 insertions(+), 318 deletions(-) commit be8dba9815ce95a1a5face0a982ea8a0be7d12fe Author: Richard Li <richard.li@intel.com> Date: Wed Mar 13 01:14:08 2019 +0000 [OnionSoup] Build typemapping for blink::FormDataElement This CL typemaps blink::FormDataElement with network.mojom.DataElement. Bug: 860403 Change-Id: I7611e2cedf479f1da429fe8a026a290be447de5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1444794 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#640163} services/network/public/mojom/url_loader.mojom | 4 +- .../renderer/platform/mojo/blink_typemaps.gni | 1 + .../blink/renderer/platform/network/BUILD.gn | 4 + third_party/blink/renderer/platform/network/DEPS | 1 + .../platform/network/encoded_form_data.typemap | 10 ++ .../network/encoded_form_data_mojom_traits.cc | 164 +++++++++++++++++++++ .../network/encoded_form_data_mojom_traits.h | 60 ++++++++ .../platform/network/encoded_form_data_test.cc | 69 ++++++++- 8 files changed, 310 insertions(+), 3 deletions(-) commit 0afa7e9c0e8677d2827858a0dc0ca488cd1dd8c1 Author: Robert Liao <robliao@chromium.org> Date: Wed Mar 13 01:13:04 2019 +0000 Convert ui::test::ScrollStepCallback to RepeatingCallback With Associated Uses BUG=714018,940130 TBR=sky@chromium.org Change-Id: I7f0f6d390ba66fe40da720bcd5b2aa851516ca9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519075 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640162} ash/wm/resize_shadow_and_cursor_unittest.cc | 5 +++-- ui/events/test/event_generator.h | 5 +++-- ui/views/controls/resize_area_unittest.cc | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) commit 1d48b493fea6a83786fa732c2d50281ef0c5c8a1 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Wed Mar 13 01:13:01 2019 +0000 Remove sergeyu@ from //remoting/OWNERS. Change-Id: If4a1a40c9dc92146aeba17ca2c504622327afb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518712 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#640161} remoting/OWNERS | 1 - remoting/android/OWNERS | 1 - remoting/client/jni/OWNERS | 1 - 3 files changed, 3 deletions(-) commit c328928eaab4dceb25fb9dfe055cff645ccfb82b Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Wed Mar 13 00:59:50 2019 +0000 Revert "Make pointer capture work in same origin frame" This reverts commit d44248f2a896421c1382c1dbbf0d7e1a9b798470. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 640055 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZDQ0MjQ4ZjJhODk2NDIxYzEzODJjMWRiYmYwZDdlMWE5Yjc5ODQ3MAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29/78896 Sample Failed Step: webkit_layout_tests Sample Flaky Test: virtual/user-activation-v2/fast/events/pointerevents/mouse-pointer-capture-in-iframe.html Original change's description: > Make pointer capture work in same origin frame > > We used to send mouse event to the subframe before apply the pointer > capture target, and it causes the pointer capture doesn't work when > capture to a outer frame target and move to inner frame. > > This CL changes three things: > 1. 'Rename' the |capturing_mouse_events_element_| to > |capturing_subframe_element_| as it only used for the frame capture > (There is plan to remove the frame capture logic once we have pointer > capture work correctly) > 2. On HandleMouse*Event, instead of always perform a hit test, we use > either frame capture target or pointer capture target to re-construct > the HitTestResult. > 3. When using the capture target, update the hover active state for > capture target. > > This change makes captured pointer event sent correctly when over > same origin frame, and also decrease the hit_test_count because of > frame capturing. > > Note that after this change, we still NOT allow set/release pointer > capture across same-origin frame as the pointer id and active statue > is per frame. > > See design doc: > https://docs.google.com/document/d/1cOZu98UuKk5bdARUQKmj2Q8YoEMpd9l78T0k-cf5ttc/ > > This change is under a blink flag UnifiedPointerCaptureInBlink. > > Change-Id: I61c6a02086535d2a145df9d414df0bdc9673101e > Bug: 936190, 919908 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1446556 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640055} Change-Id: Idf2d9cd99b54ad4caa1517c54ba9c65401014ffa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936190, 919908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519468 Cr-Commit-Position: refs/heads/master@{#640160} .../blink/renderer/core/input/event_handler.cc | 117 ++++----------- .../blink/renderer/core/input/event_handler.h | 11 -- .../renderer/core/input/event_handling_util.cc | 4 +- .../renderer/core/input/event_handling_util.h | 2 +- .../renderer/core/input/pointer_event_manager.cc | 24 +-- .../renderer/core/input/pointer_event_manager.h | 2 - .../platform/runtime_enabled_features.json5 | 4 - .../spelling/context_click_select_misspelling.html | 2 - .../pointerevent_mouse_capture_change_hover.html | 165 --------------------- ...pointerevent_mouse_pointercapture_in_frame.html | 143 ------------------ ...nt_mouse_pointercapture_inactivate_pointer.html | 55 ------- .../pointerevent_mouse_pointercapture-iframe.html | 9 -- ...e_pointercapture_inactivate_pointer-iframe.html | 10 -- .../fast/events/click-after-mousedown-cancel.html | 2 - .../fast/events/hit-test-counts-expected.txt | 4 +- .../mouse-pointer-capture-in-iframe.html | 117 --------------- .../fast/events/hit-test-counts-expected.txt | 93 ++++++++++++ .../fast/events/hit-test-counts-expected.txt | 93 ++++++++++++ 18 files changed, 218 insertions(+), 639 deletions(-) commit 825e8adddbcec0d24d0ad44208a27c5773b41915 Author: mrefaat <mrefaat@chromium.org> Date: Wed Mar 13 00:36:33 2019 +0000 [TabRefactoring] Remove notifyTab call from preload. PreloadController is a webStateobserver and calls the notifyTab in DidStartNavigation, But also Tab is a webStateObserver and does the same logic in DidStartNavigation. There is no case where PreloadController observer method will be called but tab isn't. So removing this call from PreloadControlelr Bug: 941052 Change-Id: Iab80c7159f229dc7165fdbec1f2f38194cbd7b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518071 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#640159} ios/chrome/browser/prerender/preload_controller.mm | 7 ------- 1 file changed, 7 deletions(-) commit 03dd41fb94a7ccb01707da029a67553fc532bb4e Author: Alexander Alekseev <alemate@chromium.org> Date: Wed Mar 13 00:28:25 2019 +0000 Chrome OS: Remove unused imports. This Cl removes a bunch of imports from Chrome OS OOBE/Login code. Bug: 926638 Change-Id: I9768365dc64c23d468d3a4df578282c8cf22aa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513196 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640158} chrome/browser/resources/chromeos/login/apps_menu.css | 12 ------------ chrome/browser/resources/chromeos/login/md_login.html | 18 ------------------ chrome/browser/resources/chromeos/login/oobe.html | 19 ------------------- 3 files changed, 49 deletions(-) commit 9905c04ae0b74bfb471c67b4cc54d5565b9892d7 Author: Ken Rockot <rockot@chromium.org> Date: Wed Mar 13 00:27:45 2019 +0000 Remove most direct usage of ServiceFactory This removes all usage of the ServiceFactory outside of Service Manager client library code and a couple of tests, in preparation for complete removal of the interface. For now, ServiceBinding implements ServiceFactory and forwards to its Service impl via CreatePackagedServiceInstance. After some more internal Service Manager refactoring, this will be a message sent directly by the Service Manager over the existing Service pipe, and ServiceFactory can then be removed. Bug: 925860 Change-Id: I794449ed80489c03867a8407e0fb2b537bb92961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514216 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#640157} ash/ash_service.cc | 21 +++---- ash/ash_service.h | 17 ++--- ash/public/cpp/manifest.cc | 4 -- .../service_manager/service_manager_context.cc | 25 ++++---- content/browser/utility_process_host.cc | 32 +++++++--- content/browser/utility_process_host.h | 29 +++++---- .../service_manager_connection_impl.cc | 72 ++++++++++------------ .../service_manager_connection_impl.h | 4 +- content/public/app/content_browser_manifest.cc | 4 -- content/public/app/content_gpu_manifest.cc | 5 -- .../app/content_packaged_services_manifest.cc | 4 -- content/public/app/content_plugin_manifest.cc | 4 -- content/public/app/content_renderer_manifest.cc | 4 -- content/public/app/content_utility_manifest.cc | 5 -- content/public/common/service_manager_connection.h | 11 ++-- ios/web/service_manager_connection_impl.cc | 44 ++++--------- ios/web/web_browser_manifest.mm | 4 -- ios/web/web_packaged_services_manifest.mm | 4 -- services/audio/test/in_process_service_test.cc | 47 ++++---------- .../preferences/pref_service_factory_unittest.cc | 38 +++--------- services/service_manager/public/cpp/service.cc | 7 +++ services/service_manager/public/cpp/service.h | 20 ++++++ .../service_manager/public/cpp/service_binding.cc | 22 ++++++- .../service_manager/public/cpp/service_binding.h | 16 ++++- services/service_manager/service_manager.cc | 3 +- .../tests/connect/connect_test_package.cc | 41 +++++------- .../tests/connect/connect_unittest.cc | 7 +-- .../tests/lifecycle/lifecycle_unittest.cc | 3 - .../service_manager/tests/lifecycle/package.cc | 30 +++------ .../tests/service_manager/embedder.cc | 47 +++++--------- .../tests/service_manager/test_manifests.cc | 3 - services/ws/test_ws/BUILD.gn | 1 - services/ws/test_ws/test_manifest.cc | 4 -- services/ws/test_ws/test_window_service.cc | 24 +++----- services/ws/test_ws/test_window_service.h | 14 +---- 35 files changed, 255 insertions(+), 365 deletions(-) commit 9d62aa80235cb2baf0a4a23043e8e317adcdbbc8 Author: sczs <sczs@chromium.org> Date: Wed Mar 13 00:17:38 2019 +0000 [ios] Plumbs InfobarUI state to InfobarBadgeTabHelper delegate. - Creates InfobarBadgeUIDelegate to communicate UI state to the delegate. - The delegate (Consumer) communicates the state to InfobarBagdeTabHelper. - InfobarBagdeTabHelper delegate will store the badge state using a Bitmask since the object can have various states at the same time. Bug: 911864 Change-Id: I9a115ebf0160d0d8ce70321a77588b9b77bc23a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517035 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#640156} .../browser/infobars/infobar_badge_tab_helper.h | 7 ++++ .../browser/infobars/infobar_badge_tab_helper.mm | 12 +++++++ .../infobars/infobar_badge_tab_helper_delegate.h | 16 ++++++++++ ios/chrome/browser/ui/infobars/BUILD.gn | 2 ++ .../coordinators/infobar_confirm_coordinator.mm | 7 ++++ .../infobars/coordinators/infobar_coordinating.h | 4 +++ .../coordinators/infobar_password_coordinator.mm | 7 ++++ .../ui/infobars/infobar_badge_ui_delegate.h | 25 +++++++++++++++ .../ui/infobars/infobar_container_coordinator.mm | 1 + .../ui/infobars/infobar_container_mediator.h | 4 ++- .../ui/infobars/infobar_container_mediator.mm | 37 ++++++++++++++++++++++ .../ui/location_bar/location_bar_mediator.mm | 1 + 12 files changed, 122 insertions(+), 1 deletion(-) commit f1158ca9c1db68a082d7bfebec2bba5a1154cfdc Author: Leon Han <leon.han@intel.com> Date: Wed Mar 13 00:16:55 2019 +0000 [ServiceWorker] Eliminate ServiceWorkerDispatcherHost All ServiceWorkerDispatcherHost relevant things become useless after https://crrev.com/c/1490770. BUG=931092 Change-Id: Ic341e7f4788b40095010a588efcb4514a43493c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517275 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640155} content/browser/BUILD.gn | 2 - .../renderer_host/render_process_host_impl.cc | 9 --- .../renderer_host/render_process_host_impl.h | 4 - .../service_worker_context_wrapper.h | 1 - .../service_worker_dispatcher_host.cc | 71 ----------------- .../service_worker_dispatcher_host.h | 89 ---------------------- .../service_worker_object_host_unittest.cc | 1 - .../service_worker_provider_host_unittest.cc | 1 - .../service_worker_registration_unittest.cc | 1 - .../service_worker_version_unittest.cc | 1 - content/public/app/content_browser_manifest.cc | 1 - .../service_worker_network_provider_for_frame.h | 2 - .../service_worker_network_provider_for_worker.h | 3 - .../service_worker/service_worker_container.mojom | 5 +- .../service_worker/service_worker_provider.mojom | 21 +---- 15 files changed, 5 insertions(+), 207 deletions(-) commit f5923de856e2324486a7134f67209f62afc4e526 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Wed Mar 13 00:11:30 2019 +0000 Put CSSUnicodeRangeValue into the blink::cssvalue namespace. This is part of the gradual process of putting all types that derive from CSSValue into blink::cssvalue:: namespace. Bug: 667961 Change-Id: I114a8d85ffaed6be239b74dd5298721c68f1b5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517053 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#640154} third_party/blink/renderer/core/css/css_unicode_range_value.cc | 2 ++ third_party/blink/renderer/core/css/css_unicode_range_value.h | 5 ++++- third_party/blink/renderer/core/css/font_face.cc | 3 ++- .../blink/renderer/core/css/parser/at_rule_descriptor_parser.cc | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) commit e978a2c3f761de8c592ea3b6a0923a15b56b0ead Author: tby <tby@chromium.org> Date: Wed Mar 13 00:09:53 2019 +0000 [Cros SR] Fix name of (click index, query length) histogram. In the code, our histograms are named: Apps.AppListTileLaunchIndexAndQueryLength Apps.AppListResultLaunchIndexAndQueryLength But in histograms.xml they use "Click" instead of "Launch": Apps.AppListTileClickIndexAndQueryLength Apps.AppListResultCLickIndexAndQueryLength This CL changes histograms.xml to make them consistent. Bug: 938683 Change-Id: Ib7e163b4955a455b7a017fe321cbbc13773de61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518258 Reviewed-by: Jia Meng <jiameng@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640153} tools/metrics/histograms/histograms.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a7e88b444f2e0f3c09b4648d59f6dd121ec65562 Author: Robert Ogden <robertogden@chromium.org> Date: Wed Mar 13 00:08:50 2019 +0000 Check if Optimization Hints are loaded as a PreviewsEligibilityReason Refactored the decider_impl to be a bit cleaner. NoScript is always allowed on navigation start, but LitePageRedirect and ResourceLoading need to have hints loaded first. Bug: 938621 Change-Id: Ia8fd23604feb02b608d8a828b482a63a5024b365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510765 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Doug Arnett <dougarnett@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#640152} .../previews/previews_lite_page_browsertest.cc | 19 +++++++ .../resource_loading_hints_browsertest.cc | 20 ++++++- .../previews/content/previews_decider_impl.cc | 35 +++++------- .../content/previews_decider_impl_unittest.cc | 66 ++++++++++++++++++++++ .../previews/content/previews_optimization_guide.h | 12 ++-- components/previews/core/previews_black_list.h | 6 +- components/previews/core/previews_logger.cc | 7 ++- tools/metrics/histograms/enums.xml | 1 + 8 files changed, 137 insertions(+), 29 deletions(-) commit 49c3ff62f08d2285ec233939c0e6175fd29f4eb3 Author: Leon Han <leon.han@intel.com> Date: Wed Mar 13 00:08:01 2019 +0000 [ServiceWorker] Pass SW provider info via navigation commit IPC For a navigation, previously, - browser: precreate a provider host. - browser: send the provider id via navigation commit IPC. - renderer: create a provider for the provider id above. - renderer: call ServiceWorkerDispatcherHost.OnProviderCreated(), which carries ServiceWorkerContainer(Host) Mojo connections to help the browser-side provider host complete its initialization. now, - browser: precreate a provider host with ServiceWorkerContainer(Host) Mojo connections created, its lifetime is tied to the ServiceWorkerContainerHost Mojo connection. - browser: send the provider info (id, ServiceWorkerContainer(Host) Mojo connections) via navigation commit IPC. - renderer: create a provider based on the provider info above. - renderer: call ServiceWorkerContainerHost.OnProviderCreated() to notify the browser-side provider host. This simplifies lifetime management of ServiceWorkerProviderHost, it's tied to ServiceWorkerContainerHost Mojo connection from the point it's born. Also, after this CL, ServiceWorkerDispatcherHost becomes totally useless, a follow-up CL will remove it. BUG=931092 Change-Id: Ie6e8e574d6e6aad27e8ee0920c95ae7ce76e1317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490770 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#640151} content/browser/frame_host/navigation_request.cc | 20 +- .../browser/frame_host/render_frame_host_impl.cc | 12 +- .../browser/frame_host/render_frame_host_impl.h | 3 + .../service_worker_dispatcher_host.cc | 53 +--- .../service_worker_dispatcher_host.h | 4 +- .../service_worker_dispatcher_host_unittest.cc | 326 --------------------- .../service_worker/service_worker_job_unittest.cc | 3 +- .../service_worker_navigation_handle.cc | 36 ++- .../service_worker_navigation_handle.h | 75 +++-- .../service_worker_navigation_handle_core.cc | 47 ++- .../service_worker_navigation_handle_core.h | 25 +- .../service_worker/service_worker_provider_host.cc | 101 +++---- .../service_worker/service_worker_provider_host.h | 65 ++-- .../service_worker_provider_host_unittest.cc | 68 ++--- .../service_worker_request_handler.cc | 7 +- .../service_worker/service_worker_test_utils.cc | 124 ++++++-- .../service_worker/service_worker_test_utils.h | 17 +- content/common/frame.mojom | 4 + content/common/frame_messages.h | 1 - content/common/navigation_client.mojom | 4 + content/common/navigation_params.h | 5 - content/renderer/navigation_client.cc | 3 +- content/renderer/navigation_client.h | 1 + content/renderer/render_frame_impl.cc | 24 +- content/renderer/render_frame_impl.h | 7 +- .../service_worker_network_provider_for_frame.cc | 37 +-- .../service_worker_network_provider_for_frame.h | 2 +- .../service_worker_provider_context.cc | 7 + .../service_worker_provider_context.h | 5 + .../service_worker_provider_context_unittest.cc | 1 + .../service_worker_subresource_loader_unittest.cc | 1 + content/test/BUILD.gn | 1 - content/test/test_render_frame.cc | 2 + content/test/test_render_frame_host.cc | 1 + content/test/test_render_frame_host.h | 1 + .../service_worker/service_worker_container.mojom | 8 +- .../service_worker/service_worker_provider.mojom | 15 +- 37 files changed, 425 insertions(+), 691 deletions(-) commit 497adcae4aa40894c78d5c3573e45359cd132b22 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 23:59:23 2019 +0000 Roll src/third_party/depot_tools 920bada95c6d..8b94108e6848 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/920bada95c6d..8b94108e6848 git log 920bada95c6d..8b94108e6848 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 jbudorick@chromium.org cipd: link directly to created package on chrome-infra-packages. Created with: gclient setdep -r src/third_party/depot_tools@8b94108e6848 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I698899a29d61bb705b6512c246418b44745eb07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518764 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640150} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 83b3e44d0a8375e738e21259cf34a4dd007922f7 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 12 23:58:23 2019 +0000 Remove obsolete deps from //content/gpu brucedawson@ noticed WTL include config in //content/gpu which is obsolete. Remove that and a couple of other obsolete deps/configs. Bug: None Change-Id: I726f0dabce1da4c830ccbe7852d664e2691c5ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518902 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640149} content/gpu/BUILD.gn | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) commit 48a4d0845d7445342d8cf4b99f948ce374988728 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Mar 12 23:49:37 2019 +0000 Enabled download home v1 to work with the new backend This CL contains several fixes: 1 - Download home v1 can work with the new backend. This required ignoring the DownloadItem updates in order to avoid duplicate updates with OfflineItem. 2 - Fixed a bug where incognito profile's download provider was getting created inadvertently. 3 - Fixed a possible NPE Bug: 940798 Change-Id: Ia0a91d2ffe329bb77fb58b04f387fd0feaaa5b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516479 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640148} .../download/ui/DownloadHistoryAdapter.java | 24 +++++++++++++++++----- .../browser/download/ui/LoadingStateDelegate.java | 5 +++++ .../download/ui/DownloadHistoryAdapterTest.java | 1 + chrome/browser/android/download/download_utils.cc | 5 +++-- .../browser/download/download_core_service_impl.cc | 5 ++++- .../download/download_offline_content_provider.cc | 10 +++++---- 6 files changed, 38 insertions(+), 12 deletions(-) commit 5cff2f76fe93a7d66cf3351e3ac14cd56d80cecc Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 12 23:49:35 2019 +0000 Align Calls from base::Bind to base::Bind[Once|Repeating] Based on Declared Type BUG=714018,940130 TBR=sky@chromium.org Change-Id: I77fe2b7cedc6a62e99357102e9641626dffe41fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519086 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640147} ui/views/animation/ink_drop_impl.cc | 6 +++--- ui/views/controls/scrollbar/cocoa_scroll_bar.mm | 3 ++- ui/views/controls/scrollbar/overlay_scroll_bar.cc | 2 +- ui/views/controls/textfield/textfield.cc | 4 ++-- ui/views/controls/throbber.cc | 5 +++-- ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc | 9 +++------ 6 files changed, 14 insertions(+), 15 deletions(-) commit f7ad614fadec385e5d6d196ec6f44566fc0ec973 Author: Hesen Zhang <hesen@google.com> Date: Tue Mar 12 23:48:31 2019 +0000 Rename Download Glue Implementation > Implemented glue between UI side and native side code on both download manager path and offline item path > Defined API on native side for download item to excute rename > Added DownloadRename chrome feature flag Change-Id: I558713c37479bd0ebbf93f723e98278204580e0a Bug: 924751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1484617 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Hesen Zhang <hesen@google.com> Cr-Commit-Position: refs/heads/master@{#640146} .../chromium/chrome/browser/ChromeFeatureList.java | 1 + .../chrome/browser/download/DownloadItem.java | 2 + .../browser/download/DownloadManagerService.java | 9 +++ .../download/home/DownloadManagerUiConfig.java | 6 ++ .../browser/download/home/glue/DownloadGlue.java | 7 +++ .../home/glue/OfflineContentProviderGlue.java | 21 ++++--- .../home/list/DateOrderedListMediator.java | 3 +- .../home/list/holder/OfflineItemViewHolder.java | 10 +++- .../DownloadBlockedOfflineContentProvider.java | 6 ++ .../browser/download/ui/BackendProvider.java | 6 ++ .../browser/download/DownloadActivityTest.java | 1 + .../download/home/DownloadActivityV2Test.java | 1 + .../home/StubbedOfflineContentProvider.java | 6 ++ .../browser/download/ui/StubbedProvider.java | 11 ++++ .../home/list/DateOrderedListMutatorTest.java | 1 + chrome/browser/about_flags.cc | 6 ++ chrome/browser/android/chrome_feature_list.cc | 10 +++- chrome/browser/android/chrome_feature_list.h | 1 + .../android/download/download_manager_service.cc | 69 ++++++++++++++++++---- .../android/download/download_manager_service.h | 8 +++ .../background_fetch_delegate_impl.cc | 7 +++ .../background_fetch_delegate_impl.h | 3 + .../download/download_offline_content_provider.cc | 22 +++++++ .../download/download_offline_content_provider.h | 3 + chrome/browser/download/offline_item_utils.cc | 20 +++++++ chrome/browser/download/offline_item_utils.h | 8 +++ chrome/browser/flag-metadata.json | 5 ++ chrome/browser/flag_descriptions.cc | 3 + chrome/browser/flag_descriptions.h | 3 + .../download/internal/common/download_item_impl.cc | 18 ++++++ .../download/internal/common/download_utils.cc | 18 ++++-- components/download/public/common/download_item.h | 17 +++++- .../download/public/common/download_item_impl.h | 7 +++ components/download/public/common/download_utils.h | 4 ++ .../download/public/common/mock_download_item.h | 1 + .../OfflineContentAggregatorBridge.java | 8 +++ .../OfflineContentProvider.java | 3 + .../offline_items_collection/OfflineItem.java | 2 + .../bridges/OfflineItemBridge.java | 5 +- .../android/offline_content_aggregator_bridge.cc | 24 +++++++- .../android/offline_content_aggregator_bridge.h | 6 ++ .../core/android/offline_item_bridge.cc | 2 +- .../core/offline_content_aggregator.cc | 13 ++++ .../core/offline_content_aggregator.h | 4 +- .../core/offline_content_provider.h | 10 ++++ .../offline_items_collection/core/offline_item.cc | 2 + .../offline_items_collection/core/offline_item.h | 3 + .../offline_items_collection/core/rename_result.h | 9 +-- .../test_support/mock_offline_content_provider.h | 2 + .../core/throttled_offline_content_provider.cc | 6 ++ .../core/throttled_offline_content_provider.h | 3 + .../core/downloads/download_ui_adapter.cc | 6 ++ .../core/downloads/download_ui_adapter.h | 3 + content/public/test/fake_download_item.cc | 5 ++ content/public/test/fake_download_item.h | 2 + tools/metrics/histograms/enums.xml | 2 + 56 files changed, 400 insertions(+), 44 deletions(-) commit 8c1a3cc127bcc4ca5eebdbac694c04252633e2b7 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Mar 12 23:48:27 2019 +0000 [Payment Request][Blink] Use a pre-finalizer. Bug: 940444 Change-Id: Iccaf27c7cfd225796be2604377e1355b9637b713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518835 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#640145} third_party/blink/renderer/modules/payments/payment_request.h | 1 + 1 file changed, 1 insertion(+) commit d74ffc239459fcdf68ff7f7ebad062b2536145c8 Author: David Black <dmblack@google.com> Date: Tue Mar 12 23:41:42 2019 +0000 Don't animate mic state changes in Assistant if UI is not visible. This will eliminate jank caused by animations being queued up when Assistant UI is hidden. Bug: b:123934619 Change-Id: Ifed6d6db5ec42831dca650a9e28ed4c043753d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518917 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#640144} ash/assistant/ui/dialog_plate/action_view.cc | 7 +++++++ ash/assistant/ui/dialog_plate/action_view.h | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) commit 1574bd8b911ce74b9752e9a1ba61d5145f852b6c Author: Yue Li <updowndota@chromium.org> Date: Tue Mar 12 23:35:24 2019 +0000 Fix Assistant hotword settings logic Bug: b/128345413 Test: Manual Test Change-Id: I7cdb22c9e3f0a4b6d978361f4b09a3a12874be2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519126 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#640143} chromeos/services/assistant/assistant_manager_service_impl.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit bbee0c4fd56fbe71abf9a4948ce5a8426fab504e Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Mar 12 23:33:19 2019 +0000 Fire new ax event when image attribute status changes r638310 fired a NAME_CHANGED event when the image annotation status changes, but that wasn't actually hooked up on Windows, because NAME_CHANGED events are actually handled using different logic on Windows. To fix this, add a new AXEventGenerator event type IMAGE_ANNOTATION_CHANGED so that we can explicitly fire the right event on both Windows and Chrome OS (where we definitely need it now) and potentially other platforms in the future. Bug: 905419 Change-Id: Iafccdf05ccfd9557181fc57dc8828f2ea7281c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516744 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640142} chrome/renderer/extensions/automation_ax_tree_wrapper.cc | 1 + chromecast/renderer/extensions/automation_ax_tree_wrapper.cc | 1 + .../browser/accessibility/browser_accessibility_manager_android.cc | 1 + content/browser/accessibility/browser_accessibility_manager_mac.mm | 1 + content/browser/accessibility/browser_accessibility_manager_win.cc | 3 +++ ui/accessibility/ax_event_generator.cc | 4 ++-- ui/accessibility/ax_event_generator.h | 1 + ui/accessibility/ax_event_generator_unittest.cc | 7 +++++-- 8 files changed, 15 insertions(+), 4 deletions(-) commit 453eab4aa2a8660b73f1b2b80db50aab783aa3ea Author: liberato@chromium.org <liberato@chromium.org> Date: Tue Mar 12 23:31:18 2019 +0000 ObservationId => base::UnguessableToken It turns out to be much easier to use UnguessableToken with the mojo binds for LearningTaskController, since multiple clients will multiplex onto the same LearningTaskController. This prevents any aliasing between requests. Change-Id: I07ec7e402d2300a17398f3331387c93d9daf81e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518808 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#640141} media/capabilities/learning_helper.cc | 2 +- media/learning/common/learning_task_controller.h | 13 ++++-------- media/learning/impl/learning_session_impl.cc | 8 ++++---- .../impl/learning_session_impl_unittest.cc | 23 +++++++++++----------- .../impl/learning_task_controller_helper.cc | 11 ++++++----- .../impl/learning_task_controller_helper.h | 16 +++++++-------- .../learning_task_controller_helper_unittest.cc | 4 +++- .../learning/impl/learning_task_controller_impl.cc | 6 +++--- .../learning/impl/learning_task_controller_impl.h | 6 +++--- .../impl/learning_task_controller_impl_unittest.cc | 2 +- 10 files changed, 44 insertions(+), 47 deletions(-) commit 320a33682157b63aaf05acf1f137874d234a0d30 Author: David Trainor <dtrainor@chromium.org> Date: Tue Mar 12 23:27:25 2019 +0000 Revert "Prepare Stack/StackAnimation (migration to CompositorAnimator, part 4)" This reverts commit 796a483c569238b18c611f7d77b9e4be5b83d5bd. Reason for revert: Caused bug 940831. Left comment on possible bug! Original change's description: > Prepare Stack/StackAnimation (migration to CompositorAnimator, part 4) > > This is part of changes which put as goal removing redundant ChromeAnimation API by moving everything into CompositorAnimator. > > Public doc with proposal: https://docs.google.com/document/d/1VL5ntE7vn267IFjE4Zke0GkhVVTHz1bEP672Apj_E2k/edit > > This concrete patch is preparing Stack and StackAnimation by adding support for tab animations using AnimatorSet/CompositorAnimator. > > Notes: > > 1. both ChromeAnimation and CompositorAnimator will be supported until all patches from this series will be applied (until migration will be done) > > 2. in the onUpdateCompositorAnimations we're using AnimatorSet.isRunning() to detect if animation is still working (and if we want to complete it, we animatorSetFinished to true and immediately stop animation using finishAnimationsIfDone) > > BUG=890643 > > Change-Id: I5d698c729b9001554dc1c40636baae7016d02180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1395024 > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638881} TBR=dtrainor@chromium.org,changwan@chromium.org,mdjones@chromium.org,marcin@mwiacek.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 890643 Change-Id: I2a099310bc560f7ecde42d8c30c6d894f703f8ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519122 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#640140} .../compositor/layouts/phone/stack/Stack.java | 77 +++++----------------- .../layouts/phone/stack/StackAnimation.java | 30 +-------- 2 files changed, 19 insertions(+), 88 deletions(-) commit cc9affa04f6d1b0acad4b17688c1d9b5aff70e08 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 12 23:25:36 2019 +0000 Migrate widget_interactive_uitest.cc to RepeatingCallback/BindRepeating BUG=714018,940130 TBR=sky@chromium.org Change-Id: I5e998ea0afa83e4de7b1a838f3cd10b82d03dd72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519093 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640139} ui/views/widget/widget_interactive_uitest.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) commit 1fe86c6ff17925c205f4929c57eeddcfa3ea8b69 Author: John Abd-El-Malek <jam@chromium.org> Date: Tue Mar 12 23:22:48 2019 +0000 Always enable data URLs and disable file URLs with the network service. Currently we depend on the network service supporting data URLs, so don't make it a configurable option or otherwise embedders might not turn it on and navigation loads would fail. Similarly, we depend on the file scheme not being handled by the network service, or else there would be security bugs, so don't give that option. Change-Id: Ide12a7b4a5e4c92ecacba843fde524cb184f7319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512337 Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#640138} .../browser/aw_content_browser_client.cc | 1 - chrome/browser/io_thread.cc | 6 +++++ .../browser/net/profile_network_context_service.cc | 7 ------ .../browser/net/system_network_context_manager.cc | 6 +---- chrome/browser/profiles/profile_io_data.cc | 4 ++++ chromecast/browser/cast_network_contexts.cc | 1 - .../browser/safe_browsing_network_context.cc | 4 +--- content/public/browser/content_browser_client.cc | 1 - .../shell/browser/shell_content_browser_client.cc | 1 - google_apis/drive/base_requests_server_unittest.cc | 1 - google_apis/drive/base_requests_unittest.cc | 1 - google_apis/drive/drive_api_requests_unittest.cc | 1 - .../drive/files_list_request_runner_unittest.cc | 1 - .../browser/headless_request_context_manager.cc | 4 +--- services/network/network_context.cc | 13 +++++----- services/network/network_context_unittest.cc | 28 ++-------------------- .../public/cpp/simple_url_loader_unittest.cc | 1 - .../network/public/mojom/network_context.mojom | 8 ++----- 18 files changed, 24 insertions(+), 65 deletions(-) commit b7899d319aed995ef5e40361489294fc2ec7bcc0 Author: Dan Harrington <harringtond@chromium.org> Date: Tue Mar 12 23:20:12 2019 +0000 Fixes to net error page for DNS probe handling When we do a DNS probe, the error page is updated when the probe finishes. The update can result in different UI elements being displayed. For instance, the DNS probe result might imply the device is offline, and require triggering the dino page. This change fixes how we respond to a finalized DNS probe: - the content-on-dino feature is now activated if appropriate - the auto-fetch feature is now activated if appropriate - Some Net.ErrorPageCount UMA are now recorded as they should be - On-load logic for UI elements is now re-executed after the DNS probe finishes Also, I added a new enum value for Net.ErrorPageCounts to count when an offline error page (dino) is shown. In the past, we used 'download button shown' as an indicator for the dino page being shown, but now that's no longer always shown (for instance when auto-fetch is enabled). One implementation detail in this CL is that LocalizedError::GetStrings() was refactored slightly to return additional information, and renamed to GetPageState() because this function actually decides which elements should be shown in addition to returning localized strings. I used manual testing to confirm that we correctly handle the DNS probe update when it resolves to an offline error. Bug: 933828 Change-Id: I0a1f85f128a3953f431bb2882e6303be316ebb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492429 Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#640137} chrome/renderer/net/net_error_helper.cc | 67 +++----- chrome/renderer/net/net_error_helper.h | 17 +- chrome/renderer/net/net_error_helper_core.cc | 182 ++++++++++----------- chrome/renderer/net/net_error_helper_core.h | 21 ++- .../renderer/net/net_error_helper_core_unittest.cc | 72 ++++++-- chrome/renderer/net/net_error_page_controller.h | 2 + components/error_page/common/localized_error.cc | 174 ++++++++++---------- components/error_page/common/localized_error.h | 29 +++- components/error_page/common/net_error_info.h | 3 + components/neterror/resources/neterror.js | 54 +++--- ios/chrome/browser/web/error_page_util.mm | 22 +-- tools/metrics/histograms/enums.xml | 3 + 12 files changed, 348 insertions(+), 298 deletions(-) commit df5978bab08b4cf87b2139d53ed9b8af27ca2bb7 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Tue Mar 12 23:15:38 2019 +0000 GWP-ASan: Use random eviction to allocate slots I'd previously used random eviction to allocate slots, but changed that to use a ring buffer to minimize thread contention. I benchmarked random eviction with high thread contention for the GuardedPageAllocator and the results were almost identical to the ring buffer results. Using random eviction has the benefit that long-lived use-after-frees will occasionally still have metadata for that allocation (with a ring buffer only metadata for short-lived UAFs can survive long enough to be reported). It trades off occasionaly losing metadata for short-lived use-after-frees; however, these allocations still have a much higher probability of being reported. Bug: 939142 Change-Id: I7642128a47c48903f69b40643a795b45b45001da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509361 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#640136} .../gwp_asan/client/guarded_page_allocator.cc | 31 ++++++++++++---------- .../gwp_asan/client/guarded_page_allocator.h | 12 ++++----- 2 files changed, 22 insertions(+), 21 deletions(-) commit b47b2ca15684caba2ca3f648f8715873b2bb77b6 Author: Marcin Wiącek <marcin@mwiacek.com> Date: Tue Mar 12 23:06:30 2019 +0000 Improve using TimePeriod @IntDef @IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Before CL: we don't declare @TimePeriod before int values. After CL: we check values with @TimePeriod. BUG=919666 Change-Id: I0e41e187ce3fb5481b33b886ef3322221afeeeaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512636 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Christian Dullweber <dullweber@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#640135} .../chrome/browser/preferences/PrefServiceBridge.java | 12 ++++++------ .../browser/preferences/privacy/BrowsingDataBridge.java | 10 ++++------ .../preferences/privacy/ClearBrowsingDataPreferences.java | 13 +++++++------ 3 files changed, 17 insertions(+), 18 deletions(-) commit a597a94df51273168bd9ed529eaff9280d97813f Author: chaopeng@chromium.org <chaopeng@chromium.org> Date: Tue Mar 12 23:01:04 2019 +0000 Pumping keymap file TBR=agrieve@chromium.org Bug: 920824 Change-Id: I670a64ae13a0d2d5fdbce35c8db037b47e5f7e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518146 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640134} build/config/android/config.gni | 4 ++++ 1 file changed, 4 insertions(+) commit 6c8a26d5cfc847484308e45d0b814a47d83c7ca5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 22:56:57 2019 +0000 Roll src/third_party/SPIRV-Tools/src b1ff15f22062..b75f4362f01a (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b1ff15f22062..b75f4362f01a git log b1ff15f22062..b75f4362f01a --date=short --no-merges --format='%ad %ae %s' 2019-03-12 zoddicus@users.noreply.github.com Add validation for ExecutionMode in WebGPU (#2443) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@b75f4362f01a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7aa6dbc1a3033847e9e2d84be4cb819cc296046e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518346 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640133} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c41d42f5f313558d964e905645f816f75a904d26 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Mar 12 22:56:17 2019 +0000 [Media Controls] Prevent disabled controls from handling taps This CL fixes an issue where disabled controls would handle taps. Bug: 933990 Change-Id: I515a95ee72dd597c6505167cdf0904b69db58aaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518467 Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#640132} .../media_control_fullscreen_button_element.cc | 4 +-- .../elements/media_control_input_element.cc | 4 +-- .../elements/media_control_mute_button_element.cc | 4 +-- .../media_control_overflow_menu_button_element.cc | 5 ++-- .../media_control_overlay_play_button_element.cc | 4 +-- .../elements/media_control_play_button_element.cc | 4 +-- .../tapping-on-disabled-controls-does-nothing.html | 35 ++++++++++++++++++++++ 7 files changed, 47 insertions(+), 13 deletions(-) commit 6c1f389c9016a006096063eec1316f2f75b151d7 Author: Xiaohui Chen <xiaohuic@google.com> Date: Tue Mar 12 22:53:09 2019 +0000 Temporarly disable -Wextra-semi on ChromeOS Bug: 940863 Test: locally build without warning Change-Id: I8f7e2460a9a846d7335c627acd9b9d0685c41454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518719 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640131} build/config/compiler/BUILD.gn | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 45e4a4ffba390e0e0842f9d2dd29dd240f9a70bb Author: danakj <danakj@chromium.org> Date: Tue Mar 12 22:50:42 2019 +0000 Move window closing out of WebWidgetClient. JS can request to close a window even if there is no main frame in the process, in which case it goes to the WebView and needs to get to the browser to land at the main frame's RenderViewHost. Currently this goes through WebWidgetClient but we don't want a WebWidgetClient to *exist* when there's no local main frame - as that would be a frozen RenderWidget. So we move it from WebWidgetClient to two places: - WebViewClient for frames - WebPagePopupClient for popups The IPC moves from WidgetHostMsg to ViewHostMsg and is captured directly in RenderViewHost instead of going through the owner delegate. R=avi@chromium.org, dcheng@chromium.org Bug: 912193 Change-Id: I10bc4158803d8ad5419aa8429756c131537f9e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480232 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640130} .../browser/renderer_host/render_view_host_impl.cc | 17 +++++++++---- .../browser/renderer_host/render_view_host_impl.h | 2 +- .../renderer_host/render_widget_host_impl.cc | 12 ---------- .../renderer_host/render_widget_host_impl.h | 1 - .../render_widget_host_owner_delegate.h | 5 ---- content/common/swapped_out_messages.cc | 3 +-- content/common/view_messages.h | 7 ++++++ content/common/widget_messages.h | 7 ------ content/renderer/render_view_impl.cc | 16 ++++++++++++- content/renderer/render_view_impl.h | 1 + content/renderer/render_widget.cc | 16 ++++++------- content/renderer/render_widget.h | 8 +++++-- .../test/stub_render_widget_host_owner_delegate.h | 1 - third_party/blink/public/web/web_page_popup.h | 11 ++++++++- third_party/blink/public/web/web_view_client.h | 5 ++++ third_party/blink/public/web/web_widget_client.h | 7 ------ .../blink/renderer/core/exported/web_frame_test.cc | 8 +++---- .../renderer/core/exported/web_page_popup_impl.cc | 28 ++++++++++------------ .../renderer/core/exported/web_page_popup_impl.h | 6 ++--- .../blink/renderer/core/page/chrome_client_impl.cc | 4 ++-- 20 files changed, 88 insertions(+), 77 deletions(-) commit c73017bb8c6565fa3879a61173851bec9a646029 Author: Joe Mason <joenotcharles@google.com> Date: Tue Mar 12 22:49:31 2019 +0000 Prepare chrome_cleaner for upcoming engine tests - Add ParentProcess::AppendSwitchHandleToShare and ScopedProcessProtector, which will be used by upcoming unit tests. - Remove interface_log_service which will not be needed. R=proberge Bug: 78359771 Change-Id: I651de93078c03365cd1feccde023b4f46c66433f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518828 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640129} chrome/chrome_cleaner/ipc/ipc_test_util.cc | 12 +++- chrome/chrome_cleaner/ipc/ipc_test_util.h | 8 +++ chrome/chrome_cleaner/logging/BUILD.gn | 21 ------- chrome/chrome_cleaner/test/BUILD.gn | 2 + .../test/scoped_process_protector.cc | 72 ++++++++++++++++++++++ .../chrome_cleaner/test/scoped_process_protector.h | 40 ++++++++++++ 6 files changed, 133 insertions(+), 22 deletions(-) commit f1e1b029359ff01b1be2dc234915b7e3463f0f6d Author: dpapad <dpapad@chromium.org> Date: Tue Mar 12 22:47:21 2019 +0000 File Manager: Remove inaccurate @extends {cr.EventTarget} annotation. FileOperationManagerImpl class was falsely reporting to the JS compiler that it is a cr.EventTarget subclass, even though it was not. Bug: 854268 Change-Id: Ib891cbabebeca5fb1475e9a8d0f5037e873a20ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515911 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#640128} ui/file_manager/externs/background/file_operation_manager.js | 3 ++- .../file_manager/background/js/file_operation_manager.js | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) commit c9bc2ceeeab9d10e62fe84298ecc0a05fb6345f5 Author: Tommy Steimel <steimel@chromium.org> Date: Tue Mar 12 22:45:58 2019 +0000 [Global Media Controls] Add HardwareMediaKeyHandling flag to Linux This CL allows the HardwareMediaKeyHandling flag to show up in chrome://flags on Linux. Bug: 925201 Change-Id: I390a36dd25573171e7461bf1554eabb8c5944178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518907 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#640127} chrome/browser/about_flags.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 2cfd596e096df52afdf94ec717866ace7c989ae8 Author: Andrey Kosyakov <caseq@chromium.org> Date: Tue Mar 12 22:43:17 2019 +0000 Revert "Reland "Skip NavigationScheduler for form submission"" This reverts commit 60d3d2fcfa85cf58d84097896550c6c97dbf3581. Reason for revert: sorry for reverting this, but it looks like this has changed the order of DevTools protocol notifications that broke some of the headless clients. I'll troubleshoot this further and will follow up with you on getting it fixed. Original change's description: > Reland "Skip NavigationScheduler for form submission" > > This was initially reverted for flakiness in > PasswordManagerBrowserTest.DeleteFrameBeforeSubmit on a few bots. > I believe I resolved that in > https://chromium.googlesource.com/chromium/src/+/22ea6590de751cc3a9b2cb81dfd25176a6bfc41d > > Bug: 914587 > Change-Id: I7c5884f6effbdac9c19dc49f9eaac7b04932316d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1405542 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Nate Chapin <japhet@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639714} TBR=dgozman@chromium.org,japhet@chromium.org Change-Id: Ibf746e64143524a09da53048d53f945a1bf7e03e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 914587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519128 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640126} third_party/blink/renderer/core/frame/frame.h | 5 +- .../blink/renderer/core/frame/local_frame.cc | 24 +-------- .../blink/renderer/core/frame/local_frame.h | 4 +- .../blink/renderer/core/frame/remote_frame.cc | 3 +- .../blink/renderer/core/frame/remote_frame.h | 4 +- .../renderer/core/html/forms/html_form_element.cc | 48 ++++++++++++++---- .../blink/renderer/core/loader/form_submission.cc | 4 +- .../blink/renderer/core/loader/form_submission.h | 2 + .../blink/renderer/core/loader/frame_loader.cc | 52 ++++++++++--------- .../renderer/core/loader/navigation_scheduler.cc | 59 ++++++++++++++++++++++ .../renderer/core/loader/navigation_scheduler.h | 5 +- third_party/blink/web_tests/TestExpectations | 4 ++ .../xhtml/level2/html/HTMLFormElement10.js | 2 +- .../rel-base-target-expected.txt | 10 ---- .../rel-button-target-expected.txt | 10 ---- .../rel-form-target-expected.txt | 10 ---- .../rel-input-target-expected.txt | 10 ---- .../popup-blocked-to-post-blank-expected.txt | 2 +- .../fast/forms/form-submission-create-crash.xhtml | 1 - .../forms/select/select-empty-optgroup-crash.html | 3 -- .../fast/forms/submit-add-remove-element.html | 3 +- .../loading/307-after-303-after-post-expected.txt | 4 +- .../tests/loading/redirect-methods-expected.txt | 16 +++--- ...tion-src-get-blocked-with-redirect-expected.txt | 2 +- .../form-action-src-redirect-blocked-expected.txt | 2 +- .../popup-blocked-to-post-blank-expected.txt | 2 +- .../popup-blocked-to-post-blank-expected.txt | 2 +- 27 files changed, 157 insertions(+), 136 deletions(-) commit 25136d17fdf929d3405990b4c14a9782247ddba2 Author: Jianpeng Chao <chaopeng@chromium.org> Date: Tue Mar 12 22:29:17 2019 +0000 Revert "Add plumbing for keymap" This reverts commit 6ec27fc3b6c3bde79347b07d89cc4b958c468a90. Reason for revert: bots fail Original change's description: > Add plumbing for keymap > > > Change-Id: I5b68fd4345e9331c7de5f6947a4cc17cf5d5992a > Bug: 920824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495594 > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640047} TBR=garykac@chromium.org,kerrnel@chromium.org,chaopeng@chromium.org Change-Id: I1a7721517cf8fa24d0614c94f9f230f50d93f94d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518403 Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640125} ui/events/BUILD.gn | 29 ---------------------- ui/events/keycodes/dom/dom_key_data.inc | 6 ----- .../dom/keycode_conversion_data_android.inc | 3 --- ui/events/keycodes/dom/keycode_converter_data.inc | 6 ----- .../keycodes/keyboard_code_conversion_android.cc | 12 --------- ui/events/keycodes/keyboard_codes_posix.h | 1 - ui/events/mojo/keyboard_codes.mojom | 1 - 7 files changed, 58 deletions(-) commit fab8b81cb5c75397316b69af20513ee5b57af917 Author: Erik Jensen <rkjnsn@chromium.org> Date: Tue Mar 12 22:24:05 2019 +0000 remoting: Use remoting_host.exe to display file chooser. Previously, the Windows file-chooser implementation would invoke another instance of the current executable to show the file chooser dialog. This worked fine on local builds, but failed on official builds. This turns out to be because the current executable in this case is "remoting_desktop.exe", which is used for the desktop process. In official builds, this executable has the "require administrator" flag set in its manifest, and thus launching it with normal user privileges to show the chooser fails. This changes the implementation to explicitly invoke "remoting_host.exe" in the current executables directory, instead of invoking the current executable itself. "remoting_host.exe" uses the same manifest for all build configurations, and does not set the "require administrator" flag, so it can be invoked with normal user privileges. Bug: 941087 Change-Id: I15820484ac30e75ecc936e8e3ef944c67867124e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518143 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#640124} remoting/host/file_transfer/file_chooser_win.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) commit 26699a91857bdc2f625ca708eb1ada7de2eb9e85 Author: James Cook <jamescook@chromium.org> Date: Tue Mar 12 22:23:10 2019 +0000 docs: Replace remove_webcore_debug_symbols with blink_symbol_level=0 remove_webcore_debug_symbols is deprecated. Bug: none Change-Id: I85a5ec66f10b94fb5949e932601743d479a9a178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518753 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#640123} docs/linux_build_instructions.md | 2 +- docs/windows_build_instructions.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e2efda7420c59479a4b0cd6ed1f035eed61aff85 Author: Erik Anderson <Erik.Anderson@microsoft.com> Date: Tue Mar 12 22:23:01 2019 +0000 Update sleep.py to use high resolution timer In a previous change to this file (https://chromium-review.googlesource.com/c/chromium/src/+/1469655), I added a check after the sleep completes to check if we slept long enough. After submitting this to Microsoft's test environment which runs on Hyper-V VMs, we found that the test was still flaky because the timer we're using in the Python web server doesn't have sufficient precision. In the previous change, I had considered using time.clock() which uses QPC on Windows. However, on Unix, it maps to CPU time which means it doesn't advance while we're switched out for the sleep. This change uses time.default_timer() which is the best of both worlds: with Python 2 it maps to time.clock() on Windows and to time.time() on non-Windows platforms while on Python 3.3+ it maps to time.perf_counter(); this ensures it is measuring wall time with the most accurate clock available for the platform. This change has been run for over two weeks in Microsoft's test environment without any issues. Change-Id: I30fc5f72de24fafe0766ca9b607b63290e47fae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516914 Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#640122} third_party/blink/web_tests/external/wpt/common/sleep.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 07c205f65001b1481c742f9c7dd5ca17c5b7dc89 Author: Nikunj Bhagat <nikunjb@chromium.org> Date: Tue Mar 12 22:21:38 2019 +0000 For debugging UI, Client ID can be sent as hex string instead of pair of Int Bug: 922705 Change-Id: I477b96ac7c041951fe80e88845e7a614d583895d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1449007 Commit-Queue: Nik Bhagat <nikunjb@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640121} components/ukm/debug/ukm_debug_data_extractor.cc | 6 ++++-- components/ukm/debug/ukm_internals.js | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) commit 09b7ad56aab504f21fe6d62c852e32bf95b19f03 Author: Adam Ettenberger <adettenb@microsoft.com> Date: Tue Mar 12 22:17:56 2019 +0000 Finish implementing ISelectionItemProvider for UIA 1. Adding AXPlatformNodeBase::IsSelectionItemSupported, and removing ui::IsUIASelectable. Table components (headers, row, coilumn, cell) need to be handled specially since Chromium makes no distinction between the components of a role='table' vs role='grid' or role='treegrid'. e.g. ARIA 1.1+ role='table' IS NOT interactive, and its table-like children cannot be selectable. ARIA 1.1+ role='grid' IS interactive, and its table-like children may be selectable. See: AXPlatformNodeBase::IsSelectionItemSupported 2. ISelectionItemProvider::AddToSelection, RemoveFromSelection, Select are now all implemented via ISelectionItemProviderSetSelected(bool) since they have very little difference. 3. https://www.w3.org/TR/core-aam-1.1/#mapping_state-property_table ISelectionItemProvider::get_IsSelected, handles the special case for role='radio' and role='menuitemradio'. When the CheckedState is explicitly True or False, yields the respective value. This is undefined for Mixed or None, so UIA_E_INVALIDOPERATION. 4. Dispatching UIA_SelectionItem_* events when appropriate. UIA_SelectionItem_ElementSelectedEventId UIA_SelectionItem_ElementAddedToSelectionEventId UIA_SelectionItem_ElementRemovedFromSelectionEventId (a) Remove from BrowserAccessibilityComWin::UpdateStep3FireEvents (b) Add to BrowserAccessibilityManagerWin::FireGeneratedEvent. Also fixing a bug where it only checked for aria-multiselectable if the item was a direct descendant of the selection container. (c) AXPlatformNodeWin::NotifyAccessibilityEvent also needs to fire UIA events for top-level UI, so adding code to translate the ax::mojom::Event into the appropriate UIA event. More can be added as needed. 5. Updating AccessibilityNotificationWaiter to be able to handle ui::AXEventGenerator::Event. This uses a test-only callback for BrowserAccessibilityManager::FireGeneratedEvent. 6. Allow DumpAccessibilityEventsTest to run multiple stages. If the test 'go()' returns |true|, then all events will be sorted and appended to the results with "=== Start Continuation ===", and 'go()' will be called again. This only affects tests that return |true|, all other tests will behave the same as before. 7. Adding tests to content_browsertests and accessibility_unittests. Note that UIA event dumps and event watchers are not setup yet, so I provided aria-selected-changed-expected-win.txt, and did not include an aria-selected-changed-expected-win-uia.txt. Bug: 847971 Change-Id: I05fc1f023c2c130ad74215be7c6873b589c9587b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496450 Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#640120} .../accessibility_action_browsertest.cc | 76 +++++ .../browser/accessibility/browser_accessibility.cc | 32 +- .../browser/accessibility/browser_accessibility.h | 6 +- .../accessibility/browser_accessibility_com_win.cc | 24 -- .../accessibility/browser_accessibility_manager.cc | 14 + .../accessibility/browser_accessibility_manager.h | 17 +- .../browser_accessibility_manager_win.cc | 31 +- .../browser_accessibility_manager_win.h | 2 + .../dump_accessibility_events_browsertest.cc | 110 ++++--- .../browser/frame_host/render_frame_host_impl.cc | 3 +- .../browser/frame_host/render_frame_host_impl.h | 13 +- content/test/OWNERS | 3 + content/test/accessibility_browser_test_utils.cc | 82 +++++- content/test/accessibility_browser_test_utils.h | 32 +- .../event/aria-selected-changed-expected-win.txt | 27 ++ .../accessibility/event/aria-selected-changed.html | 94 ++++++ ui/accessibility/ax_role_properties.cc | 13 - ui/accessibility/ax_role_properties.h | 4 - ui/accessibility/platform/ax_platform_node_base.cc | 29 ++ ui/accessibility/platform/ax_platform_node_base.h | 1 + ui/accessibility/platform/ax_platform_node_win.cc | 125 +++++--- ui/accessibility/platform/ax_platform_node_win.h | 6 +- .../platform/ax_platform_node_win_unittest.cc | 323 +++++++++++++++++++++ ui/accessibility/platform/test_ax_node_wrapper.cc | 3 +- 24 files changed, 907 insertions(+), 163 deletions(-) commit de607a8e9006038aa3df9a0b04e0e4cfcc2376d8 Author: Aga Wronska <agawronska@chromium.org> Date: Tue Mar 12 22:10:46 2019 +0000 Improve screen reader messages for parent access code input Improve screen reader messages, keyboard navigation and focus handling for parent access code input: * Parent access input is not traversable with tab key. It supports navigation with arrows and numeric input. Tab navigates between top level views. * User password field is focused after parent access validation is finished. * Parent access dialog has accessible description * Moving focus to next input field has updated vocalization Bug: 938659, 938660 Test: Manually, LockContentsViewUnitTest, ParentAccessViewTest Change-Id: Ie5658647f8088abf361031ceb6552d7e695c80b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518235 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#640119} ash/ash_strings.grd | 6 ++ ...DS_ASH_LOGIN_PARENT_ACCESS_DIALOG_NAME.png.sha1 | 1 + ...LOGIN_PARENT_ACCESS_NEXT_NUMBER_PROMPT.png.sha1 | 1 + ash/login/ui/lock_contents_view_unittest.cc | 40 +++++++++++ ash/login/ui/login_big_user_view.cc | 3 +- ash/login/ui/login_big_user_view.h | 1 + ash/login/ui/login_test_base.cc | 11 +++ ash/login/ui/login_test_base.h | 4 ++ ash/login/ui/login_test_utils.cc | 27 ++++--- ash/login/ui/login_test_utils.h | 4 ++ ash/login/ui/parent_access_view.cc | 84 ++++++++++++++++++++-- ash/login/ui/parent_access_view.h | 5 ++ ash/login/ui/parent_access_view_unittest.cc | 60 ++++++++++++++++ 13 files changed, 233 insertions(+), 14 deletions(-) commit 89bf8cdddd76a4110b9419e19600928637ebd7ee Author: Ted Choc <tedchoc@chromium.org> Date: Tue Mar 12 22:05:14 2019 +0000 Suppress HTTP auth dialogs if the tab is hidden (or gets hidden). BUG=939689 Change-Id: Iac8e4043448ea6c313c22b5447548b1bb331db3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515639 Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#640118} .../chrome/browser/ChromeHttpAuthHandler.java | 41 +++++++++++----- .../chrome/browser/ChromeHttpAuthHandlerTest.java | 56 ++++++++++++++++++++-- .../browser/ui/android/chrome_http_auth_handler.cc | 10 +++- .../browser/ui/android/chrome_http_auth_handler.h | 3 +- chrome/browser/ui/android/login_handler_android.cc | 5 +- 5 files changed, 97 insertions(+), 18 deletions(-) commit f28ac533b060762a3208c492710f2878b1b4ddd1 Author: David Tseng <dtseng@chromium.org> Date: Tue Mar 12 22:03:44 2019 +0000 Add labels for unlabeled developer options button - hook up the span -> paper button properly otherwise the button itself announces simply as button, which is a glaring issue - apply aria-expanded to let users know this button toggles some content e.g. expanded means the folded content is showing Bug: 913811 Change-Id: Ia87bd1f138239829d8c5bf7413bcd3c91cbe34a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512256 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640117} .../chromeos/chromevox/chromevox/background/options.html | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 552a2015c838e57928d62fbf24e1b7aaf2f56c14 Author: Collin Baker <collinbaker@chromium.org> Date: Tue Mar 12 21:54:43 2019 +0000 Add myself as owner to in-product help related directories I've been the primary engineer working on in-product help for the past few months and plan to maintain it from now on. I figured it makes sense to take ownership of IPH code. Change-Id: I3a41dd3abcdd054fee44ea1246ecdd68ef8ee37a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516023 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640116} chrome/browser/feature_engagement/OWNERS | 4 ++++ chrome/browser/ui/in_product_help/OWNERS | 4 ++++ chrome/browser/ui/views/feature_promos/OWNERS | 5 ++++- 3 files changed, 12 insertions(+), 1 deletion(-) commit 47599ac696d95f19fa0b6f91dc4e42888a2156a6 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 12 21:54:21 2019 +0000 Update V8 to version 7.5.22. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db20ee17..3dd1e8e0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1bfbb67bed7b3cc8dc653f251b1f81cb9e22eb74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518069 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640115} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a950c7cc02780d54132944119ee22d3b34c01475 Author: Joe Mason <joenotcharles@google.com> Date: Tue Mar 12 21:53:30 2019 +0000 Add TryDeleteExtensions method to ChromePromptIPC This will call ChromePrompt::DisableExtensions if the interface version supports it. R=proberge Bug: 78359771 Change-Id: I4584c2747ca8ff06d1c7fe8c4998deccc573c6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518460 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640114} chrome/chrome_cleaner/chrome_utils/BUILD.gn | 5 +++++ chrome/chrome_cleaner/ipc/chrome_prompt_ipc.cc | 26 ++++++++++++++++++++++ chrome/chrome_cleaner/ipc/chrome_prompt_ipc.h | 7 ++++++ chrome/chrome_cleaner/ipc/mock_chrome_prompt_ipc.h | 4 ++++ 4 files changed, 42 insertions(+) commit 98851d4d94b150d99e7e2bc9c81b4b863bd78d40 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 12 21:46:55 2019 +0000 Roll src/third_party/depot_tools 77e5d48a085e..920bada95c6d (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/77e5d48a085e..920bada95c6d git log 77e5d48a085e..920bada95c6d --date=short --no-merges --format='%ad %ae %s' 2019-03-12 veranika@google.com Add sdk_root property to windows_sdk module Created with: gclient setdep -r src/third_party/depot_tools@920bada95c6d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:926631 TBR=agable@chromium.org Change-Id: I0ac9b540aa689f7a480f208c0a51ad9c0ef035ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518758 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640113} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit dc15b0ca58cb2bdbaa9d2a028a01d034b1233cf5 Author: Marcin Wiącek <marcin@mwiacek.com> Date: Tue Mar 12 21:43:36 2019 +0000 Migrate ClientType to the @IntDef @IntDef/@StringDef annotation are preferred way for declaring set of String/int values 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating ClientType enum to the @IntDef: 1. with @IntDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: Idd5d039df56d8e33f92666942f2edb21b4aec328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512634 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#640112} .../browser/widget/ThumbnailProviderImpl.java | 24 ++++++++++++++-------- 1 file changed, 16 insertions(+), 8 deletions(-) commit d2ef20c64a11ae979af3990cc8c734cf2fba73e1 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Mar 12 21:43:30 2019 +0000 Convert NQE to a base::Feature This makes it easier to write the finch config on the server side using the new format which works much better for Features than field trials. Change-Id: I7db7a4a933b13455835507b3bc5edee58aaee1bb Bug: 924160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516433 Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#640111} chrome/browser/io_thread_browsertest.cc | 10 ++++++---- .../interventions_internals_page_handler.cc | 4 +++- .../interventions_internals_page_handler_unittest.cc | 5 +++-- net/base/features.cc | 3 +++ net/base/features.h | 4 ++++ services/network/network_quality_estimator_manager.cc | 10 +++------- testing/variations/fieldtrial_testing_config.json | 5 ++++- 7 files changed, 26 insertions(+), 15 deletions(-) commit 4fb719cfe2c1e11a73024a6d2e1a59c4bf9f2f9c Author: James Cook <jamescook@chromium.org> Date: Tue Mar 12 21:42:25 2019 +0000 Fix blink_symbol_level = 0 override for Windows debug builds In an internal doc I recommended blink_symbol_level = 0 to reduce the size of debug builds. However, this misses a workaround for Windows builds that exists for remove_webcore_debug_symbols. Per comments in third_party/blink/renderer/config.gni we want to replace remove_webcore_debug_symbols with blink_symbol_level (for one thing, the name is clearer). So I replicated the workaround. Bug: none Change-Id: I277db3dac02c4a45817fc91f82fbd5695544dc4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518064 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#640110} third_party/blink/renderer/config.gni | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 22e540094fa391eac2c15b38041d873ffee07c05 Author: chaopeng@chromium.org <chaopeng@chromium.org> Date: Tue Mar 12 21:40:51 2019 +0000 Add Tab observer for TouchlessEventHandler Bug: 907116 Change-Id: I7e244b35b2edb6f582f6e5cf6cc973fbc8fcdd8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515636 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640109} chrome/android/java_sources.gni | 1 + .../chrome/browser/touchless/NoTouchActivity.java | 7 +++++ .../browser/touchless/TouchlessTabObserver.java | 33 ++++++++++++++++++++++ .../chromium/ui/base/TouchlessEventHandler.java | 16 +++++++++++ 4 files changed, 57 insertions(+) commit df3cd8c511dfda67819ca6ee33afbe95e954c070 Author: Fritz Koenig <frkoenig@chromium.org> Date: Tue Mar 12 21:40:29 2019 +0000 gpu: Remove internal_format parameter from BufferQueue |internal_format| can be derived from |format| at consumption, no need to pass it around. |internal_format| was already being DCHECKed against |format|, this change changes that DCHECK into an assignment. BUG=b:117429142 TEST=none Change-Id: I03962230e9bd8ef0d86f32490b59b82b5373df50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513075 Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#640108} .../viz/service/display_embedder/buffer_queue.cc | 8 ++------ .../viz/service/display_embedder/buffer_queue.h | 1 - .../display_embedder/buffer_queue_unittest.cc | 20 ++++++++------------ .../gl_output_surface_buffer_queue.cc | 3 +-- .../gl_output_surface_buffer_queue.h | 1 - .../gl_output_surface_buffer_queue_android.cc | 5 ----- .../display_embedder/gl_output_surface_mac.cc | 1 - .../display_embedder/gl_output_surface_ozone.cc | 4 +--- .../display_embedder/gl_output_surface_ozone.h | 3 +-- .../service/display_embedder/gpu_display_provider.cc | 2 +- content/browser/compositor/gpu_output_surface_mac.cc | 1 - .../compositor/gpu_process_transport_factory.cc | 3 +-- ..._surfaceless_browser_compositor_output_surface.cc | 7 +++---- ...u_surfaceless_browser_compositor_output_surface.h | 1 - 14 files changed, 18 insertions(+), 42 deletions(-) commit 97067e4d1c1c6a7814e681518d9b5ec6cf646967 Author: Joe Mason <joenotcharles@google.com> Date: Tue Mar 12 21:35:24 2019 +0000 Make chrome_cleaner service unit tests safer - Always use randomly generated service names so we don't clobber existing services. - Add an EnsureNoTestServicesRunning function and call it from every test that uses TestScopedServiceHandle to make sure they start from a known state. - Move the EnumServicesStatusEx call from ReportRunningServices into a public EnumerateServices function that can be called from EnsureNoTestServicesRunning, because the EnumServicesStatusEx interface is super confusing and easy to mess up. - Re-enable flaky tests. R=proberge Bug: https://crbug.com/871784 Change-Id: I709516063fec9885dbf2dd171d0b88da979e111c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518462 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640107} .../components/system_report_component.cc | 51 +++------- chrome/chrome_cleaner/os/system_util.cc | 42 +++++++++ chrome/chrome_cleaner/os/system_util.h | 20 ++++ .../os/system_util_cleaner_unittest.cc | 16 +--- chrome/chrome_cleaner/test/BUILD.gn | 1 - .../test/test_scoped_service_handle.cc | 103 ++++++++++++++++++--- .../test/test_scoped_service_handle.h | 13 ++- chrome/chrome_cleaner/test/test_strings.cc | 6 -- chrome/chrome_cleaner/test/test_strings.h | 13 --- 9 files changed, 182 insertions(+), 83 deletions(-) commit b710e5f67cf188f6c1a39c04bca5ba19345ae609 Author: Nicolás Peña Moreno <npm@chromium.org> Date: Tue Mar 12 21:33:28 2019 +0000 [ResourceTiming] Rename test resource_memory_cached->resource_reuse The test does not seem to exercise the memory cache, so I propose renaming the test to something that is more implementation-independent. Also, use an img_src variable to avoid repeating the location in the script. Change-Id: I88e4574d5267a75586fc7b74f39f67e0aab2bc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516789 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#640106} ...rce_memory_cached.sub.html => resource_reuse.sub.html} | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit 665ec7d41db2684ed6fd76c97d08b433b4fb2a24 Author: Jacob Dufault <jdufault@google.com> Date: Tue Mar 12 21:30:43 2019 +0000 cros: Remove ContextEditor usage for HID detection Bug: 926511 Change-Id: Ib84a39e63db6971221e7d9c45fb3154328c2fc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506598 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640105} .../chromeos/login/screens/hid_detection_screen.cc | 103 +++++++--------- .../chromeos/login/screens/hid_detection_screen.h | 13 +- .../screens/hid_detection_screen_browsertest.cc | 55 ++++----- .../chromeos/login/screens/hid_detection_view.h | 10 ++ .../chromeos/login/oobe_screen_hid_detection.js | 136 +++++++++++++-------- .../chromeos/login/hid_detection_screen_handler.cc | 47 +++++++ .../chromeos/login/hid_detection_screen_handler.h | 41 +++++++ 7 files changed, 248 insertions(+), 157 deletions(-) commit 089a16be5cb455f41858dd030c4ad8c195487c30 Author: Eugene But <eugenebut@chromium.org> Date: Tue Mar 12 21:21:27 2019 +0000 Remove ExternalFileController class. ExternalFileController implements deprecated CRWNativeContent protocol, and ExternalFileController is no longer used for it's original purpose. Notable changes: - Remove kExternalFilesLoadedInWebState flag - Remove ExternalFileController class - Fold -[ExternalFileController pathForExternalFileURL:] into external_file_remover_impl.mm Bug: 913602 Change-Id: I87fa27d5f64ff176cc96b781c90f8b0796d61ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516880 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640104} ios/chrome/app/application_delegate/url_opener.mm | 5 +- .../application_delegate/url_opener_unittest.mm | 56 +++------- .../application_delegate/user_activity_handler.mm | 5 +- .../user_activity_handler_unittest.mm | 75 ++++--------- ios/chrome/browser/about_flags.mm | 5 - ios/chrome/browser/ios_chrome_flag_descriptions.cc | 6 - ios/chrome/browser/ios_chrome_flag_descriptions.h | 5 - ios/chrome/browser/system_flags.h | 4 - ios/chrome/browser/system_flags.mm | 3 - ios/chrome/browser/ui/BUILD.gn | 2 - ios/chrome/browser/ui/browser_view_controller.mm | 18 --- ios/chrome/browser/ui/external_file_controller.h | 36 ------ ios/chrome/browser/ui/external_file_controller.mm | 124 --------------------- .../browser/ui/external_file_remover_impl.mm | 68 ++++++++++- 14 files changed, 100 insertions(+), 312 deletions(-) commit cce2645f44923ad367c0669703cf05a622a66a09 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 12 21:19:11 2019 +0000 SuperSize: Fix a few "Unexpected File" messages in the logs * META-INF/CERT.SF * lib/armeabi-v7a/libcrashpad_handler_trampoline.so * res/drawable/$$circular_progress_bar_indeterminate_large__1__0.xml Change-Id: I0100b47805c14d599ab9622d207efb898d8650ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518334 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#640103} tools/binary_size/libsupersize/archive.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit f002c1f69b983f6c7d65ce29351ce23428f67666 Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Mar 12 21:18:13 2019 +0000 SplitViewController::OnWindowDragStarted() should only be called once. Bug: 939989 Change-Id: I45e434ad7419b666db93ef72003636033fa22e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515683 Reviewed-by: Mitsuru Oshima (slow) <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#640102} ash/wm/overview/overview_window_drag_controller.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 593d857d48158551b0831c69eeb914f3364007b4 Author: Rune Lillesveen <futhark@chromium.org> Date: Tue Mar 12 21:18:06 2019 +0000 Remove unnecessary paint invalidation diff. LayoutObject::SetStyle() with existing style_ == nullptr means the LayoutObject has just been created and about to be inserted into the layout tree. Any invalidation of layout, paint, etc will be handled by the layout tree insertion code and the following layout. Bug: 817610 Change-Id: I75bff88c26037f662c1e3250e703d0920e34e46a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517706 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#640101} third_party/blink/renderer/core/layout/layout_object.cc | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) commit 28c2b2981d59f69e62007b26304b45322def4062 Author: Tommy Nyquist <nyquist@chromium.org> Date: Tue Mar 12 21:11:38 2019 +0000 Reland: [leveldb_proto] Add support for automatic conversion to client type. This reverts commit 2a15ae9df1d9fb5b4edc81fc3476115a172b06ab, which was a revert. This is therefore a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1513279 The leveldb_proto::ProtoDatabase is a widely used storage backend in Chrome, but it only supports storing protocol buffers when using the external API. This CL makes it possible for clients to use ProtoDatabase<P, T>, where P is their proto type, and T is their own type. Previously it was only possible to pass in a proto type as the template argument. If no client type is specified, it defaults to providing the proto type as the API for all calls like before, so no changes are required to current clients. For clients to be able to use this, they must implement conversion methods to and from their proto type and their client type. This must be within the leveldb_proto namespace and for T=ClientStruct and P=ClientProto it would have the form: namespace leveldb_proto { void DataToProto(const ClientStruct& data, ClientProto* proto); void ProtoToData(const ClientProto& proto, ClientStruct* data); } // namespace leveldb_proto For retrieving a database of proto type ClientProto, use: auto db = ProtoDatabaseProviderFactory::GetForBrowserContext(...) -> GetDB<ClientProto>(...); For automatically converting to a different data type, use: auto db = ProtoDatabaseProviderFactory::GetForBrowserContext(...) -> GetDB<ClientProto, ClientStruct>(...); TBR=fgorski@chromium.org Bug: 939986 Change-Id: I79c7f42c197c535cd4bc3e2fbf09e926b47cd677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516259 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640100} components/gcm_driver/crypto/gcm_key_store.h | 6 +- .../leveldb_proto/internal/proto_database_impl.h | 223 +++++---- .../internal/proto_database_impl_unittest.cc | 529 ++++++++++++--------- .../internal/proto_database_selector.h | 1 + .../leveldb_proto/internal/shared_proto_database.h | 2 +- components/leveldb_proto/public/proto_database.h | 20 +- .../leveldb_proto/public/proto_database_provider.h | 19 +- components/leveldb_proto/testing/fake_db.h | 127 ++--- 8 files changed, 529 insertions(+), 398 deletions(-) commit 8323134ad7b38fd3af2765bec33e7027fed7ab60 Author: Sam Maier <smaier@chromium.org> Date: Tue Mar 12 21:10:48 2019 +0000 Adding a dontwarn to a proguard flags file This should fix a proguard error coming from accessibility framework test code. TBR=peconn Bug: 939567 Change-Id: I6ea29d377c1fb5d49bd6d1c425789be34f6821b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518897 Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#640099} third_party/accessibility_test_framework/proguard.flags | 1 + 1 file changed, 1 insertion(+) commit fc2f44d885785c1de7d23f8ff62998b6acb3d1d5 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 12 21:01:42 2019 +0000 Migrate menu_controller_unittest.cc to RepeatingClosure/BindRepeating There is not a strong expectation that the callbacks only be called once. BUG=714018,940130 Change-Id: I4ee874093928a241b76663de7cdf9e15ee973b5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518445 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#640098} ui/views/controls/menu/menu_controller_unittest.cc | 29 +++++++++++----------- 1 file changed, 15 insertions(+), 14 deletions(-) commit 4d6f6b73cb55f494f02491783528f43eb17138ed Author: Avi Drissman <avi@chromium.org> Date: Tue Mar 12 20:56:42 2019 +0000 Don't use NSArray without definition. https://crrev.com/c/1495454, by removing RetainPtr, causes the compiler to directly see NSArray, which is only forward-declared, causing compilation issues with some setups. Include all of Foundation; including individual files from a framework isn't officially recommended, anyway. BUG=none Change-Id: I82fe3353d74f3319930e3cb8540dfeeef39e4b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518833 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640097} third_party/blink/renderer/platform/text/locale_mac.mm | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) commit 4f02ef0ff557c24823fe7e4f7b934815f6872156 Author: Mikel Astiz <mastiz@chromium.org> Date: Tue Mar 12 20:56:31 2019 +0000 Fix extension settings sync using KeyedServices on wrong thread Helper function GetSyncableService() in settings_sync_util.cc is ran on the FILE thread, but nevertheless uses APIs that are intended for the UI thread. This is hard to change for the old sync controller (now deprecated and disabled by default). For the new codepath, however, let's fix the issue by spitting the construction of a provider callback, on the UI thread, and the actual access to the SyncableService (on the FILE thread). Bug: 940014,701326 Change-Id: I15642469a7f518d9c4f87182888f902588500ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514594 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640096} .../extensions/api/storage/settings_sync_util.cc | 30 ++++++++++++++++++++++ .../extensions/api/storage/settings_sync_util.h | 17 ++++++++++-- .../api/storage/sync_value_store_cache.cc | 6 ++++- .../api/storage/sync_value_store_cache.h | 4 +++ chrome/browser/sync/chrome_sync_client.cc | 11 ++++---- .../browser/sync/profile_sync_service_factory.cc | 2 ++ extensions/browser/api/storage/storage_frontend.cc | 2 ++ 7 files changed, 64 insertions(+), 8 deletions(-) commit d07c9c7544fd582a0a44648a27b22425d9a1ab89 Author: Regan Hsu <hsuregan@chromium.org> Date: Tue Mar 12 20:55:17 2019 +0000 [CrOS Wallpaper] Persist checkmark on active wallpaper thumbnail. Currently, the checkmark does not persist if the user clicks a different category, and returns to the category in which the selected wallpaper exists. This is because the list element that wraps around the thumbnail is not selected upon return. This CL ensures that the active thumbnail is selected. Change-Id: Ic4906913966c9e9233c742daf395ea8fa89a3314 Bug: 871699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518461 Reviewed-by: May Lippert <maybelle@chromium.org> Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640095} .../chromeos/wallpaper_manager/js/wallpaper_images_grid.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 8d889f5202dbf3abbcb4923de9355dec8b2a145d Author: Marijn Kruisselbrink <mek@chromium.org> Date: Tue Mar 12 20:54:17 2019 +0000 Don't iterate over a set while its modified in BlobRegistryImpl destruction. In 0091f2edca192eb522c94525d217cf167c1c1b0f I changed how cleanup of BlobBuilderFromStream instances works, but in doing so ended up iterating over a set while it potentially is modified. This fixes that bug. Bug: 940000, 941101 Change-Id: Ice7c1f1d437c20d061c63ad2be548ffced76398e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518834 Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#640094} storage/browser/blob/blob_registry_impl.cc | 7 +++++-- storage/browser/blob/blob_registry_impl_unittest.cc | 8 +++++--- 2 files changed, 10 insertions(+), 5 deletions(-) commit 3010556ccd12b3b42d0d8475c0f6407a464239bb Author: Philip Rogers <pdr@chromium.org> Date: Tue Mar 12 20:53:22 2019 +0000 Re-enable BlinkGenPropertyTrees by default This patch re-enables BlinkGenPropertyTrees now that the M74 branch has passed. BlinkGenPropertyTrees is targeting M75. To force-enable BlinkGenPropertyTrees, use: --enable-features=BlinkGenPropertyTrees To force-disable BlinkGenPropertyTrees, use: --disable-features=BlinkGenPropertyTrees Bug: 836884 Change-Id: I51ab9d5fde0a6eb983ee8940992367976cf3cbe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518709 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640093} third_party/blink/common/features.cc | 2 +- third_party/blink/renderer/platform/runtime_enabled_features.json5 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 4ed2f6557e60be680cb00fc3b6accf04a4294d2a Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Tue Mar 12 20:52:40 2019 +0000 PM: Keep all TabHelpers in a linked list and clean them up on shutdown. This provides the teardown logic necessary for the lifetime changes in https://chromium-review.googlesource.com/c/chromium/src/+/1512301/. Bug: 910288 Change-Id: I662e340fe209713f7f4e666efbbfe8a72c8fe83d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518470 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#640092} .../performance_manager_tab_helper.cc | 29 +++++++++++++++++++++- .../performance_manager_tab_helper.h | 10 ++++++++ ...rowser_main_extra_parts_resource_coordinator.cc | 2 ++ 3 files changed, 40 insertions(+), 1 deletion(-) commit 4a9b6a2f28f27a5a63f2d1508d4b38881517a2d1 Author: sczs <sczs@chromium.org> Date: Tue Mar 12 20:52:16 2019 +0000 [ios] Fixes testBookmarkContextBarInVariousSelectionModes timeouts. - Closes the ToolsMenu in testAddRemoveBookmark before the test is over, this was leaving the test in an inconsistent state since [chrome_test_util::BrowserCommandDispatcherForMainBVC() closeCurrentTab]; wasn't actually closing it, so the next test was timing out. - Splits testBookmarkContextBarInVariousSelectionModes into testBookmarkContextBarInSingleSelectionModes and testBookmarkContextBarInMultipleSelectionModes since the test was too large. Bug: 939725 Change-Id: I03a30b2dd86eb3fab34d1676ab02ed7334d72006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518459 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#640091} .../browser/ui/bookmarks/bookmarks_egtest.mm | 27 +++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) commit 52e51fa320f2daed7b7a1a0a799a8bb9939ed9f5 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 12 20:51:32 2019 +0000 SuperSize: Remove ".rel.dyn (unpacked)" section size. Bug: 888855 Change-Id: I8afe8afcc369bd94b1a7f01d9156422fbf4b6b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517272 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#640090} tools/binary_size/libsupersize/archive.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) commit c0192b9125f473bf543b70b7c7511c150594237c Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 12 20:47:52 2019 +0000 [Extensions Bindings] Remove obsolete JS resources from //extensions With Native Extension Bindings, many surfaces and custom hooks are implemented natively in C++ rather than in JS. Remove the obsolete JS resources from //extensions and update the resource file. This shaves off >100KB worth from resources.pak. Bug: 938998 Change-Id: If68944b8b4a0218efe18e3c246c9927129459808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509647 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640089} extensions/renderer/BUILD.gn | 15 - extensions/renderer/dispatcher.cc | 18 - extensions/renderer/event_unittest.cc | 259 -------- extensions/renderer/json_schema_unittest.cc | 120 ---- extensions/renderer/messaging_utils_unittest.cc | 196 ------ extensions/renderer/resources/binding.js | 530 ---------------- extensions/renderer/resources/event.js | 535 ---------------- .../resources/extension_custom_bindings.js | 112 ---- .../resources/extensions_renderer_resources.grd | 14 - .../renderer/resources/i18n_custom_bindings.js | 50 -- extensions/renderer/resources/json_schema.js | 549 ----------------- extensions/renderer/resources/last_error.js | 140 ----- extensions/renderer/resources/messaging.js | 508 ---------------- extensions/renderer/resources/messaging_utils.js | 53 -- .../renderer/resources/runtime_custom_bindings.js | 124 ---- extensions/renderer/resources/schema_utils.js | 159 ----- extensions/renderer/resources/send_request.js | 141 ----- extensions/renderer/resources/storage_area.js | 51 -- extensions/test/data/json_schema_test.js | 670 --------------------- 19 files changed, 4244 deletions(-) commit 4b144ffda76694965bb5dca0a9cd1749deecd881 Author: Jerome Jiang <jianj@google.com> Date: Tue Mar 12 20:47:49 2019 +0000 Roll src/third_party/libvpx/source/libvpx/ 8256c8b29..855a71dfd (9 commits) https://chromium.googlesource.com/webm/libvpx.git/+log/8256c8b297c8..855a71dfda9f $ git log 8256c8b29..855a71dfd --date=short --no-merges --format='%ad %ae %s' 2019-03-08 marpan vp9-screen: Rework the mode skip logic for screen 2019-03-08 marpan vp9-screen: Fix to screen wth layered encoding 2019-03-04 chiyotsai Optimize SSE4_1 lowbd temporal filter implementation 2019-03-04 jianj vp9 svc: add simulcast mode when inter-layer pred is off. 2019-03-07 marpan vp9-svc: Fix to sample encoder for 1 layer 2019-03-05 angiebird Include mv_mode_arr info in dump_tpl_stats 2019-03-05 angiebird Include gf_frame_offset in dump_tpl_stats 2019-03-05 angiebird Refactor dump_tpl_stats 2019-02-28 chiyotsai Add SSE4_1 highbd version of temporal filter Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I0c7e78d00295bed61a26317e9b49c2d37721127e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516457 Reviewed-by: Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#640088} DEPS | 2 +- third_party/libvpx/README.chromium | 4 +-- third_party/libvpx/libvpx_srcs.gni | 37 ++++++++++---------------- third_party/libvpx/source/config/vpx_version.h | 6 ++--- 4 files changed, 20 insertions(+), 29 deletions(-) commit 9021ff8e4358d6b84769ac8292690674a12c9282 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Mar 12 20:44:02 2019 +0000 [BGPT] Remove dependency from PaintArtifactCompositor to has_potential_xxx_animation The animation properties will be managed by cc only, and blink should neither set them nor use them. Bug: 935770 Change-Id: I7942fc735211dbecc45c7ac285138ac90d8670db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513048 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640087} .../compositing/paint_artifact_compositor.cc | 89 +++++++++++++++++----- .../compositing/paint_artifact_compositor.h | 8 +- .../compositing/paint_artifact_compositor_test.cc | 12 +-- .../graphics/compositing/property_tree_manager.cc | 4 +- 4 files changed, 81 insertions(+), 32 deletions(-) commit 5712a3451d730d11ec5520aa768367e02481df79 Author: Edin Kadric <edinkadric@google.com> Date: Tue Mar 12 20:43:24 2019 +0000 Enable EditableCombobox on Windows. Tested on Windows and once again it worked seamlessly. The only change needed was in a unit test to capture the fact that ctrl+right behaves differently on Windows (it moves to the beginning of the next word instead of the end of the current one). Turns out the extra challenge of propagating the keys to the TextInputClient was only a problem on Mac. Bug: 923660 Change-Id: I58dfe93dbf282ddfd69ca9d2cf53847d5420a8dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513272 Commit-Queue: Edin Kadric <edinkadric@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#640086} ui/views/BUILD.gn | 7 ------- ui/views/controls/editable_combobox/editable_combobox_unittest.cc | 6 ++++++ 2 files changed, 6 insertions(+), 7 deletions(-) Updated tag 'tree_truth' (was a55367f0e4d8)