Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False base_name: 'tree truth steps' cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name: 'tree truth steps' nest_level: 0 ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 34243 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8919077360391071600 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it7TdIZJ/luci_context.324518536 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2233-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43912666374dcd11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: d45390a3ad1e899c7d50e4151d41ae0fc983db27 [Fuchsia] Update LoadUrl() and CreateContext() APIs to use extensible FIDL tables. Fabrice de Gans-Riberi, Wed Mar 13 18:31:49 2019 +0000 2d4a4909ac827256844ee0d22583b7681fc330ad Mark pointerevent_touch-action-table-test_touch-manual.html flaky Ella Ge, Wed Mar 13 18:30:14 2019 +0000 18ade9e33c566ce53e7a975f48063dee07ae465a Roll src/third_party/webrtc 208634763a17..cc3503248f1d (1 commits) chromium-autoroll, Wed Mar 13 18:29:55 2019 +0000 f06d1cd723a7ec186176e88587fbb0c0a1a2bb22 [PE] Remove DISALLOW* macro usage from cc/ Vladimir Levin, Wed Mar 13 18:24:10 2019 +0000 99a0dbeb6ea094405b8f26c72106e17ecd771c8e Clean unused code in ModuleBlacklistCacheUpdater Patrick Monette, Wed Mar 13 18:23:17 2019 +0000 04c15ffab1e7574c4659a1a44e0a7a4ec1bf91b0 Fix incorrect pdf_formcalc_context_fuzzer dependency. Lei Zhang, Wed Mar 13 18:21:33 2019 +0000 e27076eab10dc9fd5b92afdfbff4db4be7691d98 chromeos: ensure WindowTargeter's insets are reset Scott Violet, Wed Mar 13 18:20:57 2019 +0000 6efe9b2a40ddd38d750e0d8ddb608608d7b2d559 [DevTools] Roll inspector_protocol to a6bdf8a7cc95ee954ba2f701d10f4ecf03e86539. Johannes Henkel, Wed Mar 13 18:17:54 2019 +0000 02ff538a5e2654da30333807d4aba9fe279eb314 Android: Remove android_deps support aliases Peter Wen, Wed Mar 13 18:13:38 2019 +0000 415a9b3bfa494ee40b4c48fea7393741e670483b Fix host comparison for XMPP cert verification special case Pavol Marko, Wed Mar 13 18:13:19 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit d45390a3ad1e899c7d50e4151d41ae0fc983db27 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Wed Mar 13 18:31:49 2019 +0000 [Fuchsia] Update LoadUrl() and CreateContext() APIs to use extensible FIDL tables. In a previous CL, chromium.web.LoadUrlParams and chromium.web.CreateContextParams were replaced with an extensible version with the suffix "2". Now that the out-of-tree callers for the old APIs have been updated, this replaces the old APIs to match the newer APIs and replaces the Chromium-tree callers. Bug: 931831 Change-Id: Id1cf567ad1989ffa309cd01470fb66e0752521ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516887 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by: Wez <wez@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#640418} fuchsia/engine/browser/context_impl_browsertest.cc | 6 +- fuchsia/engine/browser/frame_impl.cc | 33 ++++---- fuchsia/engine/browser/frame_impl.h | 3 +- fuchsia/engine/browser/frame_impl_browsertest.cc | 93 +++++++++++----------- fuchsia/engine/context_provider_impl.cc | 36 ++++----- fuchsia/engine/context_provider_impl_unittest.cc | 60 +++++++------- fuchsia/fidl/web/context_provider.fidl | 10 +-- fuchsia/fidl/web/navigation_controller.fidl | 16 ++-- .../cast/cast_channel_bindings_browsertest.cc | 2 +- .../named_message_port_connector_browsertest.cc | 4 +- .../cast/queryable_data_bindings_browsertest.cc | 2 +- fuchsia/runners/common/web_component.cc | 4 +- 12 files changed, 131 insertions(+), 138 deletions(-) commit 2d4a4909ac827256844ee0d22583b7681fc330ad Author: Ella Ge <eirage@chromium.org> Date: Wed Mar 13 18:30:14 2019 +0000 Mark pointerevent_touch-action-table-test_touch-manual.html flaky Add test expections to avoid blocking CQ while investigating. TBR: nzolghadr@chromium.org Bug: 940829 Change-Id: I27968781d4fcdbf1cd012645aa2021efee811a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520360 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#640417} third_party/blink/web_tests/TestExpectations | 2 ++ 1 file changed, 2 insertions(+) commit 18ade9e33c566ce53e7a975f48063dee07ae465a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 18:29:55 2019 +0000 Roll src/third_party/webrtc 208634763a17..cc3503248f1d (1 commits) https://webrtc.googlesource.com/src.git/+log/208634763a17..cc3503248f1d git log 208634763a17..cc3503248f1d --date=short --no-merges --format='%ad %ae %s' 2019-03-13 xz4215@gmail.com Replace abs with std::abs in audio_coding/neteq/histogram.cc Created with: gclient setdep -r src/third_party/webrtc@cc3503248f1d The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie4d73d4349058c0c6e13fca58c264ae575040de9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521188 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640416} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f06d1cd723a7ec186176e88587fbb0c0a1a2bb22 Author: Vladimir Levin <vmpstr@chromium.org> Date: Wed Mar 13 18:24:10 2019 +0000 [PE] Remove DISALLOW* macro usage from cc/ This patch replaces DISALLOW style macros from base/macros.h with explicitly deleted constructors and/or operators. R=pkasting@chromium.org Change-Id: I78a2030015dbbb05e7e8c7fac4dcc502efc250c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518337 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640415} cc/PRESUBMIT.py | 22 +++++++ cc/animation/animation.h | 6 +- cc/animation/animation_host.cc | 1 - cc/animation/animation_host.h | 7 +- cc/animation/animation_id_provider.h | 6 +- cc/animation/animation_timeline.h | 6 +- cc/animation/element_animations.cc | 1 - cc/animation/element_animations.h | 6 +- cc/animation/keyframe_effect.h | 6 +- cc/animation/keyframe_model.h | 6 +- cc/animation/keyframed_animation_curve.h | 37 +++++++---- cc/animation/scroll_offset_animation_curve.h | 7 +- cc/animation/scroll_offset_animations_impl.h | 8 +-- cc/animation/single_keyframe_effect_animation.h | 7 +- cc/animation/timing_function.h | 18 ++--- cc/animation/transform_operations.h | 1 - cc/base/delayed_unique_notifier.h | 6 +- cc/base/devtools_instrumentation.h | 24 +++---- cc/base/histograms.h | 7 +- cc/base/list_container.h | 6 +- cc/base/list_container_helper.cc | 12 ++-- cc/base/list_container_helper.h | 6 +- cc/base/math_util.h | 7 +- cc/base/rolling_time_delta_history.h | 6 +- cc/base/rtree.h | 5 +- cc/base/unique_notifier.h | 6 +- cc/benchmarks/benchmark_instrumentation.h | 6 +- cc/benchmarks/micro_benchmark_controller.h | 6 +- cc/benchmarks/micro_benchmark_controller_impl.h | 7 +- cc/debug/debug_colors.cc | 1 - cc/debug/debug_colors.h | 6 +- cc/debug/rendering_stats_instrumentation.h | 7 +- cc/input/browser_controls_offset_manager.h | 7 +- cc/input/input_handler.h | 21 +++--- cc/input/page_scale_animation.h | 6 +- ...ingle_scrollbar_animation_controller_thinning.h | 10 +-- cc/input/snap_fling_controller.h | 5 +- cc/layers/deadline_policy.h | 1 - cc/layers/heads_up_display_layer.h | 6 +- cc/layers/heads_up_display_layer_impl.h | 6 +- cc/layers/layer.h | 6 +- cc/layers/layer_impl.h | 6 +- cc/layers/nine_patch_generator.h | 1 - cc/layers/nine_patch_layer.h | 6 +- cc/layers/nine_patch_layer_impl.h | 6 +- cc/layers/painted_overlay_scrollbar_layer.h | 6 +- cc/layers/painted_overlay_scrollbar_layer_impl.h | 7 +- cc/layers/painted_scrollbar_layer.h | 6 +- cc/layers/painted_scrollbar_layer_impl.h | 7 +- cc/layers/picture_image_layer.h | 6 +- cc/layers/picture_layer.h | 6 +- cc/layers/picture_layer_impl.h | 6 +- cc/layers/picture_layer_impl_perftest.cc | 7 +- cc/layers/picture_layer_impl_unittest.cc | 1 - cc/layers/recording_source.h | 6 +- cc/layers/render_surface_impl.h | 6 +- cc/layers/scrollbar_layer_impl_base.h | 6 +- cc/layers/scrollbar_layer_interface.h | 7 +- cc/layers/solid_color_layer.h | 6 +- cc/layers/solid_color_layer_impl.h | 6 +- cc/layers/solid_color_scrollbar_layer.h | 6 +- cc/layers/surface_layer.cc | 1 - cc/layers/surface_layer.h | 6 +- cc/layers/surface_layer_impl.h | 6 +- cc/layers/texture_layer.h | 16 +++-- cc/layers/texture_layer_impl.h | 6 +- cc/layers/texture_layer_unittest.cc | 1 - cc/layers/ui_resource_layer.h | 6 +- cc/layers/ui_resource_layer_impl.h | 6 +- cc/layers/video_frame_provider_client_impl.h | 7 +- .../video_frame_provider_client_impl_unittest.cc | 9 +-- cc/layers/video_layer.h | 6 +- cc/layers/video_layer_impl.h | 6 +- cc/layers/viewport.h | 6 +- cc/mojo_embedder/async_layer_tree_frame_sink.h | 7 +- .../async_layer_tree_frame_sink_unittest.cc | 7 +- cc/paint/decode_stashing_image_provider.h | 6 +- cc/paint/display_item_list.h | 4 +- cc/paint/image_provider.h | 6 +- cc/paint/paint_cache.h | 5 +- cc/paint/paint_canvas.h | 10 +-- cc/paint/paint_filter.h | 5 +- cc/paint/paint_image_generator.h | 6 +- cc/paint/paint_op_buffer.cc | 3 +- cc/paint/paint_op_buffer.h | 6 +- cc/paint/paint_recorder.h | 5 +- cc/paint/paint_shader.h | 5 +- cc/paint/record_paint_canvas.h | 6 +- cc/paint/render_surface_filters.h | 6 +- cc/paint/scoped_raster_flags.h | 6 +- cc/paint/skia_paint_canvas.h | 6 +- cc/paint/skia_paint_image_generator.h | 6 +- cc/paint/skottie_wrapper.h | 6 +- cc/raster/bitmap_raster_buffer_provider.cc | 5 +- cc/raster/bitmap_raster_buffer_provider.h | 7 +- cc/raster/gpu_raster_buffer_provider.cc | 1 - cc/raster/gpu_raster_buffer_provider.h | 11 ++-- cc/raster/one_copy_raster_buffer_provider.cc | 1 - cc/raster/one_copy_raster_buffer_provider.h | 12 ++-- cc/raster/paint_worklet_image_provider.h | 7 +- cc/raster/playback_image_provider.h | 8 ++- cc/raster/raster_buffer_provider_perftest.cc | 11 ++-- cc/raster/raster_buffer_provider_unittest.cc | 10 +-- cc/raster/raster_source.h | 6 +- cc/raster/scoped_gpu_raster.h | 6 +- cc/raster/staging_buffer_pool.h | 10 +-- cc/raster/task.h | 12 ++-- cc/raster/task_graph_runner_perftest.cc | 5 +- cc/raster/task_graph_work_queue.h | 17 ++--- cc/raster/task_graph_work_queue_unittest.cc | 4 +- cc/raster/zero_copy_raster_buffer_provider.cc | 6 +- cc/raster/zero_copy_raster_buffer_provider.h | 7 +- cc/resources/memory_history.h | 6 +- cc/resources/resource_pool.h | 6 +- cc/resources/scoped_ui_resource.h | 7 +- cc/resources/shared_bitmap_id_registrar.h | 7 +- cc/resources/ui_resource_manager.h | 6 +- cc/scheduler/compositor_timing_history.h | 7 +- cc/scheduler/compositor_timing_history_unittest.cc | 7 +- cc/scheduler/scheduler.h | 6 +- cc/scheduler/scheduler_state_machine.h | 7 +- cc/test/cc_test_suite.h | 5 +- cc/test/fake_paint_image_generator.h | 6 +- cc/test/fake_scrollbar.h | 6 +- cc/test/mock_layer_client.h | 7 +- cc/test/mock_occlusion_tracker.h | 7 +- cc/test/push_properties_counting_layer.h | 7 +- cc/test/push_properties_counting_layer_impl.h | 8 ++- cc/test/scheduler_test_common.h | 13 ++-- cc/test/task_graph_runner_test_template.h | 10 +-- cc/test/test_hooks.h | 1 - cc/test/test_image_factory.h | 7 +- cc/test/test_in_process_context_provider.cc | 1 - cc/test/test_task_graph_runner.h | 5 +- cc/tiles/checker_image_tracker.h | 10 +-- cc/tiles/decoded_image_tracker.h | 9 ++- cc/tiles/eviction_tile_priority_queue.h | 7 +- cc/tiles/frame_viewer_instrumentation.h | 9 ++- cc/tiles/gpu_image_decode_cache.cc | 10 +-- cc/tiles/image_controller.h | 6 +- cc/tiles/image_controller_unittest.cc | 10 +-- cc/tiles/paint_worklet_image_cache.cc | 5 +- cc/tiles/picture_layer_tiling.h | 7 +- cc/tiles/picture_layer_tiling_set.h | 7 +- cc/tiles/picture_layer_tiling_unittest.cc | 9 +-- cc/tiles/raster_tile_priority_queue.h | 7 +- cc/tiles/raster_tile_priority_queue_all.h | 7 +- cc/tiles/raster_tile_priority_queue_required.h | 8 ++- cc/tiles/software_image_decode_cache.cc | 7 +- cc/tiles/tile.h | 6 +- cc/tiles/tile_manager.cc | 14 ++-- cc/tiles/tile_manager.h | 7 +- cc/tiles/tile_task_manager.h | 6 +- cc/tiles/tiling_set_raster_queue_all.h | 6 +- cc/trees/damage_tracker.h | 6 +- cc/trees/debug_rect_history.h | 6 +- cc/trees/frame_rate_counter.h | 6 +- cc/trees/image_animation_controller.h | 7 +- cc/trees/layer_tree_frame_sink.cc | 5 +- cc/trees/layer_tree_frame_sink.h | 5 +- cc/trees/layer_tree_host.h | 6 +- cc/trees/layer_tree_host_common.h | 7 +- cc/trees/layer_tree_host_impl.h | 26 ++++---- cc/trees/layer_tree_host_impl_unittest.cc | 7 +- cc/trees/layer_tree_host_unittest_proxy.cc | 77 ++++++++++++++-------- cc/trees/layer_tree_impl.h | 6 +- cc/trees/layer_tree_impl_unittest.cc | 1 - cc/trees/layer_tree_mutator.h | 9 ++- cc/trees/occlusion_tracker.h | 6 +- cc/trees/proxy_impl.cc | 4 +- cc/trees/proxy_impl.h | 6 +- cc/trees/proxy_main.h | 7 +- cc/trees/render_frame_metadata_observer.h | 8 +-- cc/trees/scoped_abort_remaining_swap_promises.h | 8 ++- cc/trees/single_thread_proxy.h | 30 +++++---- cc/trees/swap_promise_manager.h | 6 +- cc/trees/task_runner_provider.h | 18 +++-- cc/trees/tree_synchronizer.h | 9 +-- 178 files changed, 735 insertions(+), 624 deletions(-) commit 99a0dbeb6ea094405b8f26c72106e17ecd771c8e Author: Patrick Monette <pmonette@chromium.org> Date: Wed Mar 13 18:23:17 2019 +0000 Clean unused code in ModuleBlacklistCacheUpdater Removing some remnant code that should have been removed in https://crrev.com/c/1141158 when the responsibility of draining blocked module events was withdrawn from ModuleBlacklistCacheUpdater. Bug: 846953 Change-Id: If43abb836b4e23786dc8639fac7ef187437b694c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520705 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#640414} .../module_blacklist_cache_updater_win.cc | 9 -------- .../conflicts/module_blacklist_cache_updater_win.h | 25 +++------------------- 2 files changed, 3 insertions(+), 31 deletions(-) commit 04c15ffab1e7574c4659a1a44e0a7a4ec1bf91b0 Author: Lei Zhang <thestig@chromium.org> Date: Wed Mar 13 18:21:33 2019 +0000 Fix incorrect pdf_formcalc_context_fuzzer dependency. Change-Id: I32236f5ccddab6083ce7449d691dc3e1274a4e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521267 Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640413} pdf/pdfium/fuzzers/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e27076eab10dc9fd5b92afdfbff4db4be7691d98 Author: Scott Violet <sky@chromium.org> Date: Wed Mar 13 18:20:57 2019 +0000 chromeos: ensure WindowTargeter's insets are reset There are some code paths that reset visible_fraction_ and don't call to SetVisibleFraction(). BUG=929184 TEST=covered by tests Change-Id: If0bbcba4050fbc0e05a65dcffe5b87de66b37cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518409 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#640412} chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc | 2 ++ .../ui/views/frame/immersive_mode_controller_ash_unittest.cc | 9 +++++++++ ui/views/controls/native/native_view_host.cc | 4 ++++ ui/views/controls/native/native_view_host.h | 1 + ui/views/controls/native/native_view_host_aura.cc | 4 ++++ ui/views/controls/native/native_view_host_aura.h | 1 + ui/views/controls/native/native_view_host_mac.h | 1 + ui/views/controls/native/native_view_host_mac.mm | 5 +++++ ui/views/controls/native/native_view_host_wrapper.h | 1 + 9 files changed, 28 insertions(+) commit 6efe9b2a40ddd38d750e0d8ddb608608d7b2d559 Author: Johannes Henkel <johannes@chromium.org> Date: Wed Mar 13 18:17:54 2019 +0000 [DevTools] Roll inspector_protocol to a6bdf8a7cc95ee954ba2f701d10f4ecf03e86539. Also: (1) Make a source_set in content/browser/devtools for the encoding_test, and add the test to content_unittest. This will ensure that further changes to our test won't break after the try-bots pass a submission to Chromium. I've broken the tree twice with that, previously. (2) third_party/inspector_protocol/BUILD.gn is now a different file than it is upstream. But the good news is it's really really simple. I've updated roll.py accordingly. Change-Id: Idbc56a183e0a1eb71ac0930c5f1f4118f6677240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516047 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#640411} content/browser/devtools/BUILD.gn | 13 + content/test/BUILD.gn | 1 + third_party/inspector_protocol/BUILD.gn | 108 +- third_party/inspector_protocol/DEPS | 4 +- third_party/inspector_protocol/README.chromium | 2 +- third_party/inspector_protocol/code_generator.py | 4 +- third_party/inspector_protocol/encoding/cbor.cc | 821 --------- third_party/inspector_protocol/encoding/cbor.h | 280 --- .../inspector_protocol/encoding/cbor_internals.h | 39 - .../inspector_protocol/encoding/encoding.cc | 1796 +++++++++++++++++++ third_party/inspector_protocol/encoding/encoding.h | 436 +++++ .../encoding/{cbor_test.cc => encoding_test.cc} | 935 ++++++++-- .../inspector_protocol/encoding/json_parser.cc | 588 ------- .../inspector_protocol/encoding/json_parser.h | 22 - .../encoding/json_parser_handler.h | 38 - .../encoding/json_parser_test.cc | 413 ----- .../encoding/json_std_string_writer.cc | 306 ---- .../encoding/json_std_string_writer.h | 25 - .../encoding/json_std_string_writer_test.cc | 162 -- .../encoding/linux_dev_platform.cc | 49 - .../encoding/linux_dev_platform.h | 17 - third_party/inspector_protocol/encoding/platform.h | 25 - third_party/inspector_protocol/encoding/span.h | 47 - .../inspector_protocol/encoding/span_test.cc | 57 - third_party/inspector_protocol/encoding/status.h | 61 - .../inspector_protocol/encoding/str_util.cc | 20 - third_party/inspector_protocol/encoding/str_util.h | 17 - .../inspector_protocol/inspector_protocol.gni | 4 +- .../inspector_protocol/inspector_protocol.gypi | 4 +- .../inspector_protocol/lib/CBOR_cpp.template | 828 --------- .../inspector_protocol/lib/Values_cpp.template | 114 +- .../lib/base_string_adapter_cc.template | 14 +- .../inspector_protocol/lib/encoding_cpp.template | 1807 ++++++++++++++++++++ .../lib/{CBOR_h.template => encoding_h.template} | 351 ++-- third_party/inspector_protocol/roll.py | 1 - 35 files changed, 5087 insertions(+), 4322 deletions(-) commit 02ff538a5e2654da30333807d4aba9fe279eb314 Author: Peter Wen <wnwen@chromium.org> Date: Wed Mar 13 18:13:38 2019 +0000 Android: Remove android_deps support aliases These aliases were added to ease the migration from //third_party/android_tools to //third_party/android_deps and are no longer necessary. Depending on the actual library target allows devs to directly see which dependency is necessary from bytecode rewriter's error output. Tbr: Mechanical build change Bug: 937987 Change-Id: I6737026759984268ed44116e5056fee69ec5584c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500780 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#640410} android_webview/BUILD.gn | 4 +- android_webview/tools/automated_ui_tests/BUILD.gn | 2 +- base/BUILD.gn | 8 +- base/test/BUILD.gn | 2 +- chrome/android/BUILD.gn | 36 ++++----- .../android/features/autofill_assistant/BUILD.gn | 2 +- chrome/android/features/media_router/BUILD.gn | 4 +- chrome/android/features/tab_ui/BUILD.gn | 8 +- chrome/android/features/vr/BUILD.gn | 2 +- chrome/android/webapk/libs/client/BUILD.gn | 2 +- chrome/android/webapk/libs/common/BUILD.gn | 2 +- .../android/webapk/libs/runtime_library/BUILD.gn | 4 +- chrome/test/android/BUILD.gn | 8 +- chrome/test/android/cast_emulator/BUILD.gn | 2 +- chromecast/browser/android/BUILD.gn | 6 +- chromecast/media/cma/backend/android/BUILD.gn | 4 +- chromecast/public/BUILD.gn | 2 +- components/autofill/android/BUILD.gn | 2 +- components/background_task_scheduler/BUILD.gn | 2 +- components/bookmarks/common/android/BUILD.gn | 2 +- components/cronet/android/BUILD.gn | 8 +- components/download/public/common/BUILD.gn | 2 +- components/download/public/task/BUILD.gn | 2 +- components/embedder_support/android/BUILD.gn | 2 +- components/feature_engagement/internal/BUILD.gn | 2 +- components/feature_engagement/public/BUILD.gn | 2 +- components/location/android/BUILD.gn | 2 +- components/minidump_uploader/BUILD.gn | 2 +- components/offline_items_collection/core/BUILD.gn | 2 +- components/omnibox/browser/BUILD.gn | 2 +- components/safe_browsing/android/BUILD.gn | 2 +- components/signin/core/browser/android/BUILD.gn | 8 +- components/sync/android/BUILD.gn | 2 +- components/variations/android/BUILD.gn | 2 +- content/public/android/BUILD.gn | 6 +- device/BUILD.gn | 4 +- device/gamepad/BUILD.gn | 2 +- media/base/android/BUILD.gn | 2 +- media/capture/video/android/BUILD.gn | 2 +- net/android/BUILD.gn | 6 +- remoting/android/client_java_tmpl.gni | 4 +- services/BUILD.gn | 2 +- third_party/android_deps/BUILD.gn | 89 +--------------------- third_party/android_media/BUILD.gn | 4 +- third_party/android_swipe_refresh/BUILD.gn | 2 +- third_party/blink/public/BUILD.gn | 2 +- third_party/custom_tabs_client/BUILD.gn | 6 +- third_party/espresso/BUILD.gn | 2 +- third_party/feed/BUILD.gn | 6 +- third_party/robolectric/BUILD.gn | 2 +- tools/android/audio_focus_grabber/BUILD.gn | 2 +- ui/android/BUILD.gn | 4 +- 52 files changed, 103 insertions(+), 188 deletions(-) commit 415a9b3bfa494ee40b4c48fea7393741e670483b Author: Pavol Marko <pmarko@chromium.org> Date: Wed Mar 13 18:13:19 2019 +0000 Fix host comparison for XMPP cert verification special case Fix the comparison that overrides the host for certificate verification so it compares hostname <-> hostname instead of hostname <-> hostname:port. This is a follow-up to CL:1409303. false, enroll the device for enterprise management and observe no cert verification errors in the logs. Bug: 941106 Test: manual: make TiclDeviceSettingsProvider::UseGCMChannel return Change-Id: Id375f7ba8f4b140c28e1361f3496a6ee3f0fc8bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520488 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#640409} third_party/libjingle_xmpp/README.chromium | 6 +----- third_party/libjingle_xmpp/xmpp/xmppclient.cc | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) commit 6cf56c24cac7872a4fc8767eac5a4a33a6c4def5 Author: Jan Krcal <jkrcal@chromium.org> Date: Wed Mar 13 18:10:33 2019 +0000 [AF Wallet Metadata] Record last use date of entities on startup This CL adds metrics to verify that wallet metadata sync on USS is working as expected. This is another safety nest in the launch since (a) the feature is almost invisible to the user (which makes it hard to spot regressions) and (b) the USS implementation is heavily re-designed which makes it impossible to use standard metrics such as Sync.ModelTypeEntityChange3.* Bug: 853688 Change-Id: I4f319ac652b1f5316f6e2f142a45ea6b4aaa5240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515533 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#640408} .../integration/single_client_wallet_sync_test.cc | 67 +++++++++++++++++++++- .../autofill_wallet_metadata_sync_bridge.cc | 14 +++++ .../autofill_wallet_metadata_syncable_service.cc | 29 ++++++++++ tools/metrics/histograms/histograms.xml | 18 ++++++ 4 files changed, 127 insertions(+), 1 deletion(-) commit 0e203582df2615daa53544dfd0c16d879e942890 Author: Chase Phillips <cmp@chromium.org> Date: Wed Mar 13 18:03:56 2019 +0000 IndexedDB: Make IDBCursorValue contain arrays of objects An upcoming change to transition IDBCursor.Prefetch() to use native Mojo callbacks will require IDBCursorValue to hold arrays of objects. Update IDBCursorValue now to support arrays of keys, primary keys, and values in advance so when that change lands, the support is already in IDBCursorValue. Bug: 717812 Change-Id: I2ad3a73214d96450d5ab4e91a40acdfe673fae7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516482 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#640407} content/browser/indexed_db/indexed_db_cursor.cc | 16 +++++++++--- .../blink/public/mojom/indexeddb/indexeddb.mojom | 6 ++--- .../modules/indexeddb/web_idb_cursor_impl.cc | 30 +++++++++++++++++----- 3 files changed, 39 insertions(+), 13 deletions(-) commit a9ac2956aa79c374dc35fd1a547c9db513f343e8 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Mar 13 18:00:45 2019 +0000 Correct libcxx{abi} revision in buildtools/DEPS libcxxabi_revision was incorrectly updated instead of libcxx_revision in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1516275 TBR=thakis,dpranke Change-Id: I72e8710752159de434e1dfdafe3895a688b33fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520361 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640406} buildtools/DEPS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit fa25a7c629b94a9f1d67285105b582d9b4963f27 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Wed Mar 13 17:54:36 2019 +0000 Pass Kerberos environment variables to NetworkContextParams. This CL copies the KRB5CC and KRB5_CONFIG environment variables from the browser process to the network service utility process via NetworkServiceParams for all posix systems, and additionally a new NetworkService::SetEnvironment call for ChromeOS. Bug: 940532 Change-Id: I183aa4beabc030744b73dec40333a828b9b31a03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518886 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#640405} .../authpolicy/auth_policy_credentials_manager.cc | 22 ++++++++++++++++--- content/browser/network_service_instance.cc | 25 ++++++++++++++++++++++ services/network/network_service.cc | 11 ++++++++++ services/network/network_service.h | 2 ++ .../network/public/mojom/network_service.mojom | 15 +++++++++++++ 5 files changed, 72 insertions(+), 3 deletions(-) commit abe722e80b7f71f649e6a810b5e1aac677146fc1 Author: Chase Phillips <cmp@chromium.org> Date: Wed Mar 13 17:52:45 2019 +0000 IndexedDB: Remove now-unused IDBCallbacks.SuccessCursorContinue Commit d9377f2 / https://crrev.com/c/1480810 updated CursorContinue() to use native Mojo callbacks. Remove the IDBCallbacks SuccessCursorContinue interface which is now no longer used as a result. Bug: 717812 Change-Id: I991f596c78bdc5e0b5eceb6c1cd9792a9e57e51f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516481 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#640404} content/browser/indexed_db/indexed_db_callbacks.cc | 49 ---------------------- content/browser/indexed_db/indexed_db_callbacks.h | 5 --- .../indexed_db/mock_mojo_indexed_db_callbacks.h | 11 ----- .../blink/public/mojom/indexeddb/indexeddb.mojom | 3 -- .../renderer/modules/indexeddb/web_idb_callbacks.h | 6 +++ 5 files changed, 6 insertions(+), 68 deletions(-) commit d48d2b1639774af47043bf653ccfb15fd972005b Author: bsheedy <bsheedy@chromium.org> Date: Wed Mar 13 17:51:52 2019 +0000 Automate VR voice input manual tests Automates the manual tests related to the VR browser test's voice input mode. Specifically: 1. Ensures that the voice input exit button works. 2. Ensures that the Daydream controller's app button functions the same as the exit button when in voice input mode. 3. Ensures that voice input is not available if the website is using the microphone permission. Bug: 887574 Change-Id: I80250de570ca07b19369f94affe25ab2156332d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509336 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#640403} .../chrome/browser/vr/VrBrowserNativeUiTest.java | 93 ++++++++++++++++++++++ .../chrome/browser/vr/util/NativeUiUtils.java | 8 +- chrome/browser/vr/ui.cc | 4 + chrome/browser/vr/ui_test_input.h | 8 +- 4 files changed, 109 insertions(+), 4 deletions(-) commit 86a5416466cfad52d5269efb744a3cbfdba5579c Author: Ahmed Fakhry <afakhry@chromium.org> Date: Wed Mar 13 17:48:58 2019 +0000 Revert "[Fuchsia] Use memory offsets instead of file offsets for ELF headers." This reverts commit 224e8c23ceea93e0ba809c3761fd33a4c9d89d78. Reason for revert: Causes failures of ElfReaderTest.ReadElfLibraryName on chromeos-kevin-rel: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/2030 BUG=941603 Original change's description: > [Fuchsia] Use memory offsets instead of file offsets for ELF headers. > > The ELF reader code uses file offsets for computing locations of data > in ELF headers. It is technically incorrect but generally works on > Intel without problems. However, ARM has wider alignment boundaries > which results in the computation and access of incorrect memory > addresses, producing page faults in certain circumstances. > > The bug is fixed by using p_vaddr instead of p_offset. > > Bug: 941279 > Change-Id: Ia88dc58411dfe046f882a94cea0e80e8ec525957 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518226 > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Kevin Marshall <kmarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640165} TBR=wez@chromium.org,kmarshall@chromium.org Change-Id: I936b5066c457d46a3207ede23c7e37bf7a5671c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 941279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521302 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#640402} base/debug/elf_reader.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit f10255ed9a4b7118e8a4f1f9bd3c00becb5444a1 Author: iOS Autoroller <ios-autoroller@chromium.org> Date: Wed Mar 13 17:47:24 2019 +0000 [MDC roll] Roll Material Components to 651b6470f437cdc51bb97f285b213d1520bc7201 TBR=smut Change-Id: Iedba11b62dd800ca48d6f62ce2a5b71c390d9ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521228 Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#640401} DEPS | 2 +- ios/third_party/material_components_ios/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 63c041cdd13dfc77540aedc0af67e87216a36aba Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Wed Mar 13 17:44:58 2019 +0000 ozone/wayland: Fix flaky DataDevice unit tests This CL fixes 2 issues which were causing flakiness on Drag & Drop tests: (1) Most of the times, tests using wl::TestDataSource functions were not waiting for the async read callback to be performed to finish. Fixing this revealed issue (2). (2) The test has been passing the wrong mime type when calling TestDataSource::ReadData(). So no data was being written into pipe fd at client side (WaylandDataSource), so the string returned in the test callback (empty '') wasn't matching the expected one. Additionally this CL, aims to improve TestDataSource::SendData documentation, adding some comments explaing why each pass is intended to. Bug: 926101 Change-Id: Ic17ae793caca085a4e57b5913b6ad0736dcf36bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518601 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#640400} ui/ozone/platform/wayland/test/test_data_source.cc | 6 ++++ .../wayland/wayland_data_device_unittest.cc | 35 +++++++++++++--------- 2 files changed, 27 insertions(+), 14 deletions(-) commit b025ca59258a98fcadbc0cf2b05668165225c197 Author: chaopeng <chaopeng@chromium.org> Date: Wed Mar 13 17:40:43 2019 +0000 Add comment explains no null check in onUnconsumedKeyboardEventAck onUnconsumedKeyboardEventAck is called by native after hasTouchlessEventHandler calls, no null check is needed. Change-Id: I83ada8a2fb9a7d535ef78c49e2bbfb28df451e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520349 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640399} ui/android/java/src/org/chromium/ui/base/TouchlessEventHandler.java | 2 ++ 1 file changed, 2 insertions(+) commit 5e3a67f9db20b8c7bedfbc1ea6911a4be5e394bf Author: Bruno Santos <brunoad@chromium.org> Date: Wed Mar 13 17:40:25 2019 +0000 Make EnableSupervisionTransitionScreens flag default true. Bug: 903851 Change-Id: Id99f79afc871c8560498254c6f63fc4174a613d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520355 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Bruno Santos <brunoad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640398} chromeos/constants/chromeos_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a21cdff108af94017266d3a1a9fa2b436d7eff03 Author: Owen Min <zmin@chromium.org> Date: Wed Mar 13 17:38:27 2019 +0000 No longer remove empty policy directory The clean up logic is introduced in M71 and is safe enough to be removed in M75. Bug: 883869 Change-Id: I02bb7e00f5013dd4ffa82f84bbf1c3b63de941e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519089 Reviewed-by: Georges Khalil <georgesak@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640397} chrome/browser/policy/browser_dm_token_storage.cc | 13 --- chrome/browser/policy/browser_dm_token_storage.h | 7 -- .../policy/browser_dm_token_storage_linux.cc | 19 ---- .../policy/browser_dm_token_storage_linux.h | 14 --- .../browser_dm_token_storage_linux_unittest.cc | 109 --------------------- .../browser/policy/browser_dm_token_storage_mac.h | 8 -- .../browser/policy/browser_dm_token_storage_mac.mm | 13 --- .../browser_dm_token_storage_mac_unittest.cc | 68 ------------- .../machine_level_user_cloud_policy_controller.cc | 17 ---- 9 files changed, 268 deletions(-) commit ad3a5890054d5bba4acc3dcdb6317f2f718525db Author: Lily Chen <chlily@chromium.org> Date: Wed Mar 13 17:36:11 2019 +0000 Add SQLitePersistentStoreBackendBase This CL makes a base class, SQLitePersistentStoreBackendBase, from which SQLitePersistentCookieStore::Backend can inherit, in order to reuse common code. This is in anticipation of adding yet another SQLite store for NEL and Reporting data. Bug: None Change-Id: Iebd1ef9a57147ab82edca3f817c3018a8d33ed5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481117 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#640396} net/BUILD.gn | 2 + .../sqlite/sqlite_persistent_cookie_store.cc | 651 +++++++-------------- .../sqlite/sqlite_persistent_store_backend_base.cc | 272 +++++++++ .../sqlite/sqlite_persistent_store_backend_base.h | 199 +++++++ 4 files changed, 694 insertions(+), 430 deletions(-) commit 511ec6c0711e196962f3c1188654fc612effa893 Author: John Chen <johnchen@chromium.org> Date: Wed Mar 13 17:35:12 2019 +0000 [ChromeDriver] Save pointer location between actions Modify ChromeDriver to save pointer locations between multiple calls of Perform Actions, as required by WebDriver standard. Bug: chromedriver:1897 Change-Id: I11926ff8e4af92db339460491f12125b44b5e84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512939 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#640395} chrome/test/chromedriver/test/run_py_tests.py | 62 +++++++++++++++++++++++++++ chrome/test/chromedriver/window_commands.cc | 25 ++++++++++- 2 files changed, 85 insertions(+), 2 deletions(-) commit c5aa0091514521dbafd5124b2e9647a851bbdabb Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Mar 13 17:34:57 2019 +0000 Remove cruft from wtf/assertions.cc and the corresponding BUILD.gn. Change-Id: Icebe52b71e2f735e9fc9209a3bf3a7f513f10af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521031 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640394} third_party/blink/renderer/platform/wtf/BUILD.gn | 3 --- .../blink/renderer/platform/wtf/assertions.cc | 29 +++------------------- 2 files changed, 3 insertions(+), 29 deletions(-) commit 83470fe1ab9552f9fd342fb7f12552a5a01efe84 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 17:34:02 2019 +0000 Roll src/third_party/skia e22dba8d5e9e..673c538f8d74 (2 commits) https://skia.googlesource.com/skia.git/+log/e22dba8d5e9e..673c538f8d74 git log e22dba8d5e9e..673c538f8d74 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 stephana@google.com Fix Pixel 3 dimension 2019-03-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3c1f5a6bd487..4e87659e289c (1 commits) Created with: gclient setdep -r src/third_party/skia@673c538f8d74 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ic9fbd224b74320106651e4102bfe523b2b4de0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521075 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640393} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0ccbe07a1abb0752183c3d0761a394d0e7d23691 Author: Christian Dullweber <dullweber@chromium.org> Date: Wed Mar 13 17:33:13 2019 +0000 Fix deletion of FileSystems in CookiesTree UI Deletion of FileSystems through CannedBrowsingDataFileSystemHelper was missing. This changes the canned helper to inherit from the actual helper in order to allow it to trigger deletions. Bug: 940253 Change-Id: I2706325235a75963c87b0247b5f30cf846f10971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517813 Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#640392} .../browsing_data_file_system_helper.cc | 72 +++++++--------------- .../browsing_data_file_system_helper.h | 41 +++++++----- .../browsing_data_file_system_helper_unittest.cc | 11 ++-- .../mock_browsing_data_file_system_helper.cc | 8 ++- .../local_shared_objects_container.cc | 4 +- 5 files changed, 62 insertions(+), 74 deletions(-) commit 3eeae17c64f7efefb76cf389ef0a339ab6161b5f Author: Eric Willigers <ericwilligers@chromium.org> Date: Wed Mar 13 17:32:10 2019 +0000 Web Share: move webshare.mojom to public/mojom mojom files in blink should be placed inside public/mojom This avoid the duplicate symbol complications discussed in https://chromium-review.googlesource.com/c/chromium/src/+/1460583/5/third_party/blink/public/mojom/BUILD.gn#214 Bug: 903010 Change-Id: I891e3020360593c0ab6eec5c051913535013e02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510619 Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#640391} WATCHLISTS | 2 +- .../src/org/chromium/chrome/browser/webshare/ShareServiceImpl.java | 2 +- chrome/app/chrome_content_browser_overlay_manifest.cc | 2 +- chrome/browser/DEPS | 1 - chrome/browser/chrome_content_browser_client.cc | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 5 ++++- third_party/blink/public/{platform/modules => mojom}/webshare/OWNERS | 0 .../blink/public/{platform/modules => mojom}/webshare/webshare.mojom | 0 third_party/blink/renderer/modules/webshare/OWNERS | 2 +- third_party/blink/renderer/modules/webshare/navigator_share.h | 2 +- third_party/blink/web_tests/webshare/share-arity.html | 2 +- third_party/blink/web_tests/webshare/share-error.html | 2 +- third_party/blink/web_tests/webshare/share-nonutf8-encoding.html | 2 +- third_party/blink/web_tests/webshare/share-success.html | 2 +- third_party/blink/web_tests/webshare/share-types.html | 2 +- third_party/blink/web_tests/webshare/share-url-relative.html | 2 +- 17 files changed, 16 insertions(+), 15 deletions(-) commit 84aa37ed3a2f13288c93c4ad90fe00513d84d77c Author: Wez <wez@chromium.org> Date: Wed Mar 13 17:30:03 2019 +0000 [Fuchsia] Look for ApplicationConfigManager in Agent-provided services. Migrate CastRunner to request the ApplicationConfigManager from its Agent, rather than expecting to find it provided by a system service. This allows us to build a simpler stub Agent, which implements both per-component services (e.g. CastChannel) and also global services (e.g. ApplicationConfigManager). An AgentManager is added to //fuchsia/base, for use by components to cache connections to Agent services, and to keep-alive the target Agent(s). Bug: 914610, 893229 Change-Id: I437324df87e3296b534943332e1da218e4f3c995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512703 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#640390} fuchsia/base/BUILD.gn | 2 + fuchsia/base/agent_manager.cc | 49 +++++++++++ fuchsia/base/agent_manager.h | 68 ++++++++++++++++ fuchsia/runners/BUILD.gn | 1 + fuchsia/runners/cast/cast_component.cc | 32 +++----- fuchsia/runners/cast/cast_component.h | 6 +- fuchsia/runners/cast/cast_runner.cc | 94 +++++++++++++--------- fuchsia/runners/cast/cast_runner.h | 24 ++++-- .../runners/cast/cast_runner_integration_test.cc | 21 ++--- fuchsia/runners/cast/main.cc | 2 - 10 files changed, 218 insertions(+), 81 deletions(-) commit 26d2ac238417326a677c4222506133d23c4c7dea Author: Josh Nohle <nohle@google.com> Date: Wed Mar 13 17:29:43 2019 +0000 Add fake CryptAuthV2Enroller and ClientAppMetadataProvider classes These implementations are needed for the CryptAuthV2EnrollmentManager unit tests. Bug: 899080 Change-Id: I8dd4b14745638066dc7f141467ef2d59197b6794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516888 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#640389} chromeos/services/device_sync/BUILD.gn | 2 + .../services/device_sync/cryptauth_v2_enroller.cc | 1 + .../device_sync/fake_cryptauth_v2_enroller.cc | 34 +++++++++++ .../device_sync/fake_cryptauth_v2_enroller.h | 69 ++++++++++++++++++++++ chromeos/services/device_sync/public/cpp/BUILD.gn | 2 + .../cpp/fake_client_app_metadata_provider.cc | 34 +++++++++++ .../public/cpp/fake_client_app_metadata_provider.h | 61 +++++++++++++++++++ 7 files changed, 203 insertions(+) commit 6621d678cd80b9fe23895b895b8a93fa058555e5 Author: Denis Kuznetsov <antrim@google.com> Date: Wed Mar 13 17:28:56 2019 +0000 Use new JSChecker methods in ActiveDirectoryLoginTest Also migrating to new JSChecker methods uncovered that some of UI was not mobile-friendly. Bug: 940977 Change-Id: I45693fe791bd8ed52c34bd2db6b9315867494d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520826 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Auto-Submit: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640388} .../login/active_directory_login_browsertest.cc | 122 ++++++++++----------- 1 file changed, 60 insertions(+), 62 deletions(-) commit 6332a9402b4ed0199a4b15a77411c08564bcd70b Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 17:28:17 2019 +0000 flags: assign enable-lookalike-url-navigation-suggestions Per email discussion. Bug: None Change-Id: Ib3b28f6b66962756697a32d45374abb140e2ab63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520696 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640387} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit ad4923fbcaf6a728f4c2908212b73eef929e80f2 Author: Oystein Eftevaag <oysteine@chromium.org> Date: Wed Mar 13 17:27:10 2019 +0000 Fix enumeration of tracing categories for ARC tracing agents ARC tracing agents aren't owned by TracingControllerImpl; add a function in the base TracedProcess registry that all agents register with, to populate the tracing categories. R=ssid@chromium.org BUG=941295 Change-Id: Ia2a2dd763be8961fe3f322499a1e3d8429bc249c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519328 Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640386} content/browser/tracing/tracing_controller_impl.cc | 5 +---- services/tracing/public/cpp/traced_process_impl.cc | 6 ++++++ services/tracing/public/cpp/traced_process_impl.h | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) commit 9b67c0ba2c9448d46c56bb1bbf59d6f2f379b147 Author: Victor Fei <vicfei@microsoft.com> Date: Wed Mar 13 17:26:43 2019 +0000 Improved and completed IExpandCollapseProvider in UIA IExpandCollapseProvider already existed in Chromium, however it needed improvements. Changes include: 1. Logic in SupportsExpandCollapse() for checking if a control type supports IExpandCollapseProvider. 2. Now get_ExpandCollapseState() returns ExpandCollapseState_LeafNode if the expand/collapsed state is not explicit. Before it was NOTREACHED() which was causing crash for many control types. 3. Logic in Expand(), Collapse() prevents expand/collapse action to be performed if the element is disabled. 4. Logic in Expand(), Collapse() prevents expand action to be performed if the state is already set to expanded. And collapse action to be performed if the state is already set to collapsed. Bug: 847971 Change-Id: I027c20f2f639cd93ef4b4503248ca92a8e877718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510657 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#640385} ui/accessibility/BUILD.gn | 1 + ui/accessibility/ax_role_properties.cc | 10 +- ui/accessibility/ax_role_properties.h | 5 +- ui/accessibility/ax_role_properties_unittest.cc | 48 +++++ ui/accessibility/platform/ax_platform_node_win.cc | 19 +- .../platform/ax_platform_node_win_unittest.cc | 224 +++++++++++++++++++++ .../platform/ax_platform_node_win_unittest.h | 2 + 7 files changed, 300 insertions(+), 9 deletions(-) commit d2675bf10dc4afe5fbbd12c4fb71dca26386b2b7 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 13 17:24:00 2019 +0000 Update V8 to version 7.5.29. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/61514a9c..f7cc35d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I38d2c491ce0a78832341b4f1072438c4fec3982d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520347 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640384} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7b505f32f5b8daf34c2b24e78c1aedc1b396a373 Author: Jared Saul <jsaul@google.com> Date: Wed Mar 13 17:23:47 2019 +0000 Update AutofillUpstreamEditableExpirationDate fieldtrial testing config Launched to Canary/Dev in cl/237273284 Bug: 926316 Change-Id: Ia19760e102d820751ac94850c728ff9c4e36b4ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518600 Auto-Submit: Jared Saul <jsaul@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#640383} testing/variations/fieldtrial_testing_config.json | 1 + 1 file changed, 1 insertion(+) commit c9393c6d9156f6a75e7bd5d60d9070a485576dc5 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 17:11:29 2019 +0000 build: default to symbol_level=1 on all sanitizers These builds can generate >4GB of debug info on Mac, which breaks many DWARF-manipulation tools. This change causes sanitizer builds to always use symbol_level=1, even on Windows and Mac, which drops the size of this debug info from ~5GB to ~1.4GB. This also affects Windows, and will probably drop fuzzer build size there too. Bug: 940823 Change-Id: I3ca55db005e25e0072a063f6cdda29e26de00e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520695 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640382} build/config/compiler/compiler.gni | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit f5d30c90ef77e6d7eaaaf67a0b51f67cdcf0bd83 Author: Tom Anderson <thomasanderson@chromium.org> Date: Wed Mar 13 17:09:24 2019 +0000 Move fuchsia libunwind dependency to common_deps Also be more strict about visibility checks and add a comment to common_deps about adding new global dependencies, since it seems a few have slipped in since it was added. BUG=None R=thakis Change-Id: Id7e2a136bff4ad60e3ea19604431d13048a25738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492426 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640381} build/config/BUILD.gn | 20 ++++++++++++++++++-- buildtools/third_party/libc++/BUILD.gn | 17 +++++++++++++++-- buildtools/third_party/libc++abi/BUILD.gn | 18 ++++-------------- buildtools/third_party/libunwind/BUILD.gn | 11 ++++++----- 4 files changed, 43 insertions(+), 23 deletions(-) commit 1b25201721ad59b8bac5cfa11691091ae2cf1f90 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Wed Mar 13 17:08:39 2019 +0000 TabManager: Remove unnecessary Stop() method TabManager::Stop simply resets unique_ptrs, which is already performed implicitly on destruction. There is no need for this method. Change-Id: Ic98cc1f2348afb94af07ab21983eb809a6a9e91b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518906 Reviewed-by: François Doray <fdoray@chromium.org> Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Cr-Commit-Position: refs/heads/master@{#640380} chrome/browser/resource_coordinator/tab_manager.cc | 12 +----------- chrome/browser/resource_coordinator/tab_manager.h | 3 +-- 2 files changed, 2 insertions(+), 13 deletions(-) commit 008221e0b56651002edf8db3d882050c66c3d5bc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 17:07:34 2019 +0000 Roll src/third_party/chromite 579a3b3e53ce..6b83d6b99335 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/579a3b3e53ce..6b83d6b99335 git log 579a3b3e53ce..6b83d6b99335 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 dgarrett@google.com chromeos_config: Increase factorybranch timeout. Created with: gclient setdep -r src/third_party/chromite@6b83d6b99335 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ibc1f6b933963896f7951b5c5629a1f16268214b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521186 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640379} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c02e9c7fd7f2958c126066eca749fa96ffd10360 Author: Joshua Pawlicki <waffles@chromium.org> Date: Wed Mar 13 17:07:31 2019 +0000 Launch improved recovery component. Bug: 687231 Change-Id: I68036b3f8d441738234907e43c22ade80fead5fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516281 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640378} chrome/browser/chrome_browser_main.cc | 6 +----- chrome/common/chrome_features.cc | 6 ------ chrome/common/chrome_features.h | 3 --- 3 files changed, 1 insertion(+), 14 deletions(-) commit 4dfa1469c1a763b82be59e3cd1f5b3a0121c7d6f Author: Peter Boström <pbos@chromium.org> Date: Wed Mar 13 17:05:22 2019 +0000 Add Profile::IsRegularProfile Adds a short-hand for GetProfileType() == REGULAR_SESSION which should help discourage checking !IsIncognito() && !IsGuestSession(). Also adds usages of this to AvatarToolbarButton that helps illustrate how the Profile has been misused in the past and how the convenience method helps clear up related code. Bug: None Change-Id: I5a06c0bea64b7066de70261449322bf970f3c1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519103 Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#640377} chrome/browser/profiles/profile.cc | 4 ++++ chrome/browser/profiles/profile.h | 4 ++++ chrome/browser/ui/views/profiles/avatar_toolbar_button.cc | 7 +++---- 3 files changed, 11 insertions(+), 4 deletions(-) commit c131c1f0d72ab7301c9aa9ece14f4c21f0e3abb7 Author: siashah <siashah@chromium.org> Date: Wed Mar 13 17:05:07 2019 +0000 Make the fix flows dialog not cancelable Currently the dialog is cancelled when the user clicks outside the dialog This change will make the dialog non cancelable Bug: 941250 Change-Id: I98cb827c8044cfb64d90eba2e4f8356ca4d17a96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519074 Auto-Submit: Siddharth Shah <siashah@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#640376} .../chrome/browser/autofill/AutofillExpirationDateFixFlowPrompt.java | 2 +- .../org/chromium/chrome/browser/autofill/AutofillNameFixFlowPrompt.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 7b7be76a39254c467d1ba2a04dff20ff967a032a Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 17:00:58 2019 +0000 flags: remove enable-touchpad-three-finger-click Per email discussion, this flag is obsolete. Bug: 941520 Change-Id: I691402189e04e04de75c061a5d9647bbc1bcea43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521226 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#640375} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 4 ---- chrome/browser/flag_descriptions.h | 3 --- 4 files changed, 16 deletions(-) commit 8668489b8f40f9031efbb6ad419872b1ef7d3b11 Author: Lei Zhang <thestig@chromium.org> Date: Wed Mar 13 17:00:55 2019 +0000 Fix libfuzzer dictionary syntax in pdf_xfa_js.dict. Change-Id: I9cec3bfba58c43617cd65ee2d01b1262b82c463a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520686 Commit-Queue: Max Moroz <mmoroz@chromium.org> Auto-Submit: Lei Zhang <thestig@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640374} pdf/pdfium/fuzzers/dicts/pdf_xfa_js.dict | 408 +++++++++++++++---------------- 1 file changed, 204 insertions(+), 204 deletions(-) commit 855be74de839b8a6bed313852f16e5d7bca4bd68 Author: Alex Clarke <alexclarke@chromium.org> Date: Wed Mar 13 16:58:11 2019 +0000 Add the task_queue name to PostTask flow events This will help us diagnose start up traces, and will likely be useful in blink too. TBR=derat@chromium.org Bug: 863341 Change-Id: I7916ef7e3ce0ff0e0df243ea2fe4fd5e0c1a40d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511471 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#640373} base/task/common/task_annotator.cc | 12 +++++++----- base/task/common/task_annotator.h | 7 +++++-- base/task/common/task_annotator_unittest.cc | 2 +- base/task/sequence_manager/sequence_manager_impl.cc | 5 +++-- base/task/sequence_manager/sequence_manager_impl.h | 2 +- base/task/sequence_manager/task_queue_impl.cc | 6 +++--- base/task/sequence_manager/thread_controller.h | 3 ++- base/task/sequence_manager/thread_controller_impl.cc | 6 ++++-- base/task/sequence_manager/thread_controller_impl.h | 3 ++- .../thread_controller_with_message_pump_impl.cc | 6 ++++-- .../thread_controller_with_message_pump_impl.h | 3 ++- base/task/task_scheduler/task_tracker.cc | 3 ++- components/timers/alarm_timer_chromeos.cc | 2 +- 13 files changed, 37 insertions(+), 23 deletions(-) commit 56742b0ebf655154493935203f782e80d7b5f4f3 Author: Mina Almasry <almasrymina@chromium.org> Date: Wed Mar 13 16:57:38 2019 +0000 Fix PTS reporting before playback has started Bug: internal b/124013079 Test: cast_media_unittests Change-Id: Ib5fc90c84ffc5dd0e30fd91d62f32aab19e61e8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517095 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Auto-Submit: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#640372} chromecast/media/cma/backend/media_pipeline_backend_for_mixer.cc | 7 +++++++ chromecast/public/media/media_pipeline_backend.h | 3 ++- 2 files changed, 9 insertions(+), 1 deletion(-) commit ab4b411e758672ab1dbdae1d68c524d46d18a478 Author: Mustaq Ahmed <mustaq@google.com> Date: Wed Mar 13 16:56:18 2019 +0000 Rename the flag for activation transfer API, complete plumbing. There has been a past flag for delegation through an <iframe> attribute. Renaming the new flag to clarify the difference, and also marking the past flag deprecated to avoid confusion. This CL will have this test passing with the flag: wpt/html/user-activation/activation-transfer-with-click.tentative.html Bug: 928838 Change-Id: I2f93142fb898ecc06f8921d0183840b59f4dd095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518063 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640371} content/child/runtime_features.cc | 4 ++++ content/public/common/content_features.cc | 6 ++++-- content/public/common/content_features.h | 2 +- third_party/blink/public/platform/web_runtime_features.h | 2 ++ third_party/blink/renderer/core/frame/dom_window.cc | 2 +- .../blink/renderer/core/frame/window_post_message_options.idl | 4 +++- .../blink/renderer/platform/exported/web_runtime_features.cc | 4 ++++ third_party/blink/renderer/platform/runtime_enabled_features.json5 | 4 ++-- 8 files changed, 21 insertions(+), 7 deletions(-) commit 56e472455c97d4ec7c5de2842dcdaac015fa98ad Author: Jessica Tallon <jtallon@igalia.com> Date: Wed Mar 13 16:51:38 2019 +0000 Emit ATK property-change:accessible-description for content Bug: 938237 Change-Id: Ieca3a7b35393da79e40a7156f95004b3a0d3b59a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511422 Commit-Queue: Jessica Tallon <jtallon@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640370} .../accessibility_event_recorder_auralinux.cc | 4 ++++ .../browser_accessibility_manager_auralinux.cc | 8 ++++++++ .../browser_accessibility_manager_auralinux.h | 1 + .../event/description-change-expected-auralinux.txt | 1 + ui/accessibility/platform/ax_platform_node_auralinux.cc | 14 ++++++++++++++ ui/accessibility/platform/ax_platform_node_auralinux.h | 1 + 6 files changed, 29 insertions(+) commit 6e199eed21c923ce1d63a314f0c7304ae9ecaf65 Author: Emircan Uysaler <emircan@chromium.org> Date: Wed Mar 13 16:51:27 2019 +0000 Fix flakiness in VerifyCanvasCaptureOffscreenCanvasFrames I found out that we hit this issue when requestAnimationFrame() callbacks are drifted too much, such that we receive multiple within a vsync. In that case, we provide a single capture for multiple draws, which fails test expectations. Bug: 916928 Change-Id: I937c6f180707ec8e9aefd9c98d0f7d0caae49570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518915 Reviewed-by: Christian Fremerey <chfremer@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640369} .../webrtc/webrtc_capture_from_element_browsertest.cc | 4 +--- content/test/data/media/canvas_capture.html | 18 ++++++++++++++++-- 2 files changed, 17 insertions(+), 5 deletions(-) commit 8193738d084ad6c55f83d8c634de49f2075f02bf Author: Mike Wittman <wittman@chromium.org> Date: Wed Mar 13 16:50:06 2019 +0000 [Sampling profiler] Use different ModuleCaches for profiler threads in test ModuleCaches are expected to be allocated one per profiling thread because they do not support concurrent access. Update the test to do so. Bug: 931418 Change-Id: I52be2c645ecfaf71cb55ec113e34b455447f05a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521210 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#640368} base/profiler/stack_sampling_profiler_unittest.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit fbc8acb2e680f652f343b301358da15c4f2f2bbd Author: Guido Urdaneta <guidou@chromium.org> Date: Wed Mar 13 16:49:12 2019 +0000 [MediaStream] Fix bug in applyConstraints() for video tracks This CL fixes a bug such that when a source had multiple tracks with the same settings (e.g., cloned tracks) and the settings for one of tracks changed via applyConstraints(), in some cases the modified track was not added back to the list of tracks backed by the source, resulting in tracks that reported themselves as live but produced no frames. Bug: 940518 Change-Id: I1f779179f52d1bfa4605855b4d092a215417314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520837 Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#640367} .../webrtc/webrtc_getusermedia_browsertest.cc | 8 ++++++ content/test/data/media/getusermedia.html | 32 ++++++++++++++++++++++ .../modules/mediastream/video_track_adapter.cc | 4 ++- 3 files changed, 43 insertions(+), 1 deletion(-) commit 80bf614dfd6463318b4822d71cc37bebf29a852a Author: Ella Ge <eirage@chromium.org> Date: Wed Mar 13 16:48:58 2019 +0000 deflaky pointerevent_pointerlock_supercedes_capture-manual.html The test terminate at the second mouse move after call exitPointerLock, It may timeout when entering and exiting lock states took longer than the gap between events and we don't have enough moves to finish the test. This CL adds two pointer moves to the automation, so that the test can terminate successfully. Bug: 798680 Change-Id: Iac4276ff4f39a0d5884b4aaf0887fe8c43dabd7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518733 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#640366} third_party/blink/web_tests/TestExpectations | 3 --- .../external/wpt_automation/pointerevents/pointerevent_common_input.js | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) commit 7427f77974bd0f72f65e485c788554d7dad56a7d Author: Jonathan Backer <backer@chromium.org> Date: Wed Mar 13 16:40:21 2019 +0000 DLOG instead of DCHECK destruction during write access This is motivated by our fuzzing of RasterDecoder. The fuzzer can issue a BeginRasterCHROMIUM without a matching EndRasterCHROMIUM. The DCHECK was causing clusterfuzz to think it found an legit error. It is possible for a renderer to crash between BeginRaster and EndRaster as well. Bug: 940190 Change-Id: Ia260b626ce516a700fc1159e4be33c7adb02740c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518144 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: enne <enne@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640365} .../service/shared_image_backing_factory_gl_texture.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 7aba201fa68d61309a88fd852d36f1b0cea3a742 Author: David Bokan <bokan@chromium.org> Date: Wed Mar 13 16:37:57 2019 +0000 Mark multi-touch-user-gesture.html as flaky Appears that landing https://crrev.com/c/1390330 has made this test very flaky. Adding it to expectations to green the bots while I investigate. TBR=danakj@chromium.org Bug: 915926 Change-Id: Iaa1956b76556a1d220dd9fd560780b0cab33c0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521029 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640364} third_party/blink/web_tests/TestExpectations | 5 +++++ 1 file changed, 5 insertions(+) commit 295c43f1854b16fc51b89aade6d86363c370cc16 Author: danakj <danakj@chromium.org> Date: Wed Mar 13 16:37:17 2019 +0000 Defer sending a request to close the page for remote main frames The same arguments apply as for a local main frame, in that JS could run a nested message loop and the browser may close the RenderWidget that the JS is running from before the stack unwinds, causing a crash. So we post a task to send the close request to the browser from RenderViewImpl in the remote main frame case, matching the local main frame/popup case. R=dcheng@chromium.org Bug: 912193 Change-Id: I5adc9694fc8d9898a98993adafa48b98f04a97de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480270 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640363} content/renderer/render_view_impl.cc | 29 +++++++++++++++++++++++++---- content/renderer/render_view_impl.h | 6 ++++++ content/renderer/render_widget.cc | 7 ++++--- 3 files changed, 35 insertions(+), 7 deletions(-) commit 298c6c31feaf11c17303500feaecadaa20e749e3 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 16:36:50 2019 +0000 Roll src-internal 63e898da8fa6..62079cb02868 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/63e898da8fa6..62079cb02868 Created with: gclient setdep -r src-internal@62079cb02868 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I910e42e9bb526ac268d5ee950c64751e5d7b18e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520878 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640362} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 89b289f09f12998a61f98f7bcb86a80bbf49c803 Author: Garrett Beaty <gbeaty@chromium.org> Date: Wed Mar 13 16:31:37 2019 +0000 Remove the 16 minutes test timeout for Lollipop Phone Tester. Bug: 939945 Change-Id: I261374237caa3124084ca0ca95fcaf15f7241005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519188 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#640361} testing/buildbot/chromium.android.json | 63 ---------------------------------- testing/buildbot/waterfalls.pyl | 1 - 2 files changed, 64 deletions(-) commit 6244a1d8ecaf6e2ff3d90505bc369f6b822b62e4 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Wed Mar 13 16:29:41 2019 +0000 PM: Explicitly clean up RenderProcessUserData at shutdown. Also fold the RenderProcessHostObserver into the UserData as this saves on an allocation. Bug: 910288 Change-Id: Ieddf0435c1dcaad7ad8440847fd926f4d9fa3742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520704 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#640360} .../render_process_user_data.cc | 79 +++++++++++++--------- .../performance_manager/render_process_user_data.h | 24 ++++++- ...rowser_main_extra_parts_resource_coordinator.cc | 12 ++++ 3 files changed, 82 insertions(+), 33 deletions(-) commit 7601952f20db79350ec9ab6e961b7f1b39a14424 Author: Denis Kuznetsov <antrim@google.com> Date: Wed Mar 13 16:27:47 2019 +0000 Extract configuration-based enrollment test Also made it derive from OobeTestBase rather than LoginManagerTest Bug: 912704 Change-Id: I631650fb2e27046a84aca9f88179674ecbbca63c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516312 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640359} .../configuration_based_enrollment_browsertest.cc | 326 +++++++++++++++++++++ .../login/enterprise_enrollment_browsertest.cc | 321 -------------------- .../browser/chromeos/login/test/oobe_base_test.cc | 20 +- .../browser/chromeos/login/test/oobe_base_test.h | 5 + chrome/test/BUILD.gn | 1 + 5 files changed, 347 insertions(+), 326 deletions(-) commit c353f3b77dc89975be6f6234c050db8c6b654532 Author: Ben Pastene <bpastene@chromium.org> Date: Wed Mar 13 16:27:27 2019 +0000 Strip symbols from chrome in the CrOS sanity tests when running in VMs. Like for tast tests, sometimes we run out of room when deploying the browser during the sanity test. So let's start stripping symbols. Change-Id: I1e737f6fa71b919c2760d31d9b96f8aab1250636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519099 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#640358} build/chromeos/test_runner.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit a30d0ada945cbd74d29d1c6ec9eedceb2bab45f3 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Mar 13 16:17:27 2019 +0000 Import <Foundation/Foundation.h> instead of individual header files This is the official way to import framework files, so let's fix it now as a follow-up change right after the patch for CL1518573 has been merged. Bug: 929973 Change-Id: I7cf64b6c06226653375a2f1558001865db1db18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520602 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#640357} third_party/blink/renderer/platform/wtf/text/string_impl_mac.mm | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit e4fd0df8392a8285ef9de7a393b1209e3a3937b8 Author: Denis Kuznetsov <antrim@google.com> Date: Wed Mar 13 16:16:18 2019 +0000 Add utility methods to JSChecker Bug: 940977 Change-Id: I40cd7e8edd7ccd74cb74154f6d1d4640dc348bc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517709 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640356} .../login/enterprise_enrollment_browsertest.cc | 204 +++++++++------------ chrome/browser/chromeos/login/test/js_checker.cc | 97 +++++++++- chrome/browser/chromeos/login/test/js_checker.h | 30 +++ .../resources/chromeos/login/offline_ad_login.html | 16 +- .../resources/chromeos/login/oobe_select.js | 2 + 5 files changed, 214 insertions(+), 135 deletions(-) commit fccc0edf73c277d0435351d9190e299191a7ca28 Author: Joe Mason <joenotcharles@google.com> Date: Wed Mar 13 16:13:56 2019 +0000 Add misc chrome_cleaner switches - Add a kTestLoggingPathSwitch to set where logs are written to during tests. - Make sure unofficial builds never send logs except if the kTestLoggingUrlSwitch is given. - Add kFileSizeLimitSwitch and tests. R=proberge Bug: 78359771 Change-Id: I14d71d4794c1a06a48f8badd116682675af639b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519549 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640355} chrome/chrome_cleaner/logging/BUILD.gn | 1 + chrome/chrome_cleaner/logging/scoped_logging.cc | 19 ++++- .../logging/scoped_logging_unittest.cc | 93 ++++++++++++++++++++++ chrome/chrome_cleaner/settings/BUILD.gn | 2 +- .../settings/cleaner_settings_unittest.cc | 26 ++++-- .../settings/reporter_settings_unittest.cc | 30 ++++--- chrome/chrome_cleaner/settings/settings.cc | 23 ++++++ chrome/chrome_cleaner/settings/settings.h | 5 ++ .../chrome_cleaner/settings/settings_unittest.cc | 50 +++++++++++- chrome/chrome_cleaner/test/test_settings_util.h | 1 + 10 files changed, 227 insertions(+), 23 deletions(-) commit cd417503b725ea3e90a36a090395cc7c3cff3166 Author: danakj <danakj@chromium.org> Date: Wed Mar 13 16:13:21 2019 +0000 Move LayerTreeMutator setter to WebWidgetClient (5/n) The WebLayerTreeView is a shortcut past the WebWidgetClient that is not needed now that we always composite. This works toward eliminating this extra API layer. More importantly this helps us Close/Restart the WebWidget parts of WebViewImpl by not requiring plumbing 2 pointers with slightly different lifetimes (WebLayerTreeView is created inside the Init of the WebWidgetClient). This will help avoid a bunch of complexity in creating WebFrameWidgets and other WebWidgets. R=flackr@chromium.org Bug: 912193 Change-Id: Ic1abcf564154564c428ebde814db1be4a49c6c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490496 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640354} content/renderer/compositor/layer_tree_view.cc | 6 ------ content/renderer/compositor/layer_tree_view.h | 1 - content/renderer/render_widget.cc | 5 +++++ content/renderer/render_widget.h | 1 + third_party/blink/public/platform/web_layer_tree_view.h | 3 --- third_party/blink/public/web/web_widget_client.h | 11 ++++++++++- .../blink/renderer/core/frame/web_frame_widget_base.cc | 2 +- 7 files changed, 17 insertions(+), 12 deletions(-) commit 4bf4f510e7268c2bf994491d7e07115d5f4d6ec9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 16:12:52 2019 +0000 Roll src/third_party/skia 6d31ddee3c16..e22dba8d5e9e (4 commits) https://skia.googlesource.com/skia.git/+log/6d31ddee3c16..e22dba8d5e9e git log 6d31ddee3c16..e22dba8d5e9e --date=short --no-merges --format='%ad %ae %s' 2019-03-13 brianosman@google.com Clamp in GrBicubicEffect (to match SW and for general sanity) 2019-03-13 brianosman@google.com Include test name in error messages for failing tests 2019-03-13 mtklein@google.com Revert "add private non-copying SkReadBuffer::readString()" 2019-03-13 herb@google.com Check that a glyph will fit in the atlas instead of a bogus check Created with: gclient setdep -r src/third_party/skia@e22dba8d5e9e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I8483b84f0106fd71a3b492965bc76e5c3df31460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521128 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640353} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0d885e758e44671c943d3f2e4e59b0c3711ca331 Author: Joe Mason <joenotcharles@google.com> Date: Wed Mar 13 16:12:15 2019 +0000 Fix crashes in chrome_cleaner LNK parser R=proberge Bug: 78359771 Change-Id: I0d20a9d23e391f5c95c9e69989dc7c5f3ba5207a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519551 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640352} .../parsers/shortcut_parser/target/lnk_parser.cc | 106 +++++---- .../shortcut_parser/target/lnk_parser_unittest.cc | 242 +++++++++++++++++++-- 2 files changed, 289 insertions(+), 59 deletions(-) commit 3cd59485f8dbbdcbaa71d92a01bb1476a07199bb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 16:11:45 2019 +0000 Roll Fuchsia SDK from a0d04e2f2507 to ddcb12bc41ac The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ibbb26b2d9e33d2ee3646edfe2d08abe8ad3d7004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520877 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640351} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f0bb082b6a64b75e68585b04b176a50d610f4593 Author: David Roger <droger@chromium.org> Date: Wed Mar 13 16:09:20 2019 +0000 [signin][android] Move account settings utils Bug: 938554 Change-Id: I8090bd102861aead6873cba1180799963c33bda9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517910 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#640350} chrome/android/BUILD.gn | 2 +- .../browser/signin/AccountManagementFragment.java | 16 ++-- .../signin/AccountManagementScreenHelper.java | 92 ---------------------- .../browser/signin/SignOutDialogFragment.java | 6 +- .../chrome/browser/signin/SigninUtils.java | 76 ++++++++++++++++++ chrome/android/java_sources.gni | 1 - chrome/browser/BUILD.gn | 4 +- ...management_screen_helper.cc => signin_utils.cc} | 15 ++-- ...t_management_screen_helper.h => signin_utils.h} | 12 +-- chrome/browser/signin/chrome_signin_helper.cc | 6 +- 10 files changed, 102 insertions(+), 128 deletions(-) commit f2a65048159a8bac7a1abc04f9e2b4f0e5bc27c1 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Wed Mar 13 16:07:28 2019 +0000 Convert away from method method JSONReader::ReadDeprecated Replace usage to instead use JSONReader::Read that returns a base::Optional<base::Value> and convert surrounding code to the new base::Value API. Bug: 925165 Change-Id: Ida5525eedca3d679be6c042023bdf2f536576277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518514 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#640349} .../browser/autocomplete_match_type_unittest.cc | 8 +- components/omnibox/browser/document_provider.cc | 5 +- .../omnibox/browser/document_provider_unittest.cc | 52 +++++----- .../omnibox/browser/search_suggestion_parser.cc | 2 +- .../browser/search_suggestion_parser_unittest.cc | 13 +-- components/omnibox/browser/suggestion_answer.cc | 110 ++++++++++++--------- components/omnibox/browser/suggestion_answer.h | 26 ++--- .../omnibox/browser/suggestion_answer_unittest.cc | 8 +- 8 files changed, 118 insertions(+), 106 deletions(-) commit 1961e65309d8025a7d8811685fbca2bae6591c92 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 16:05:29 2019 +0000 flags: assign enable-shill-sandboxing TBR=avi@chromium.org Bug: None Change-Id: I811e6220d0920f3a17095bdd1e4b09ad81341e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520700 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#640348} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 5fd62324d3b863d227e8ea943d3a00deada4ef3c Author: David Roger <droger@chromium.org> Date: Wed Mar 13 16:00:41 2019 +0000 [signin][mice] Update credentials when Chrome-Connected header has email Bug: 938554 Change-Id: Iffcefb818c8400ae482442e3e7240d58a79db75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517701 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#640347} .../signin/AccountManagementScreenHelper.java | 34 +++++++++++++++++----- .../signin/account_management_screen_helper.cc | 11 +++++-- .../signin/account_management_screen_helper.h | 5 +++- chrome/browser/signin/chrome_signin_helper.cc | 4 +-- 4 files changed, 40 insertions(+), 14 deletions(-) commit 5f5f8aaa2502f3e776fba3e3d8a1234613931317 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:59:50 2019 +0000 Roll src/third_party/perfetto c4e085dbb2c7..c39f77fd46c2 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/c4e085dbb2c7..c39f77fd46c2 git log c4e085dbb2c7..c39f77fd46c2 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 treehugger-gerrit@google.com Merge "Fix crash when recreating producer." Created with: gclient setdep -r src/third_party/perfetto@c39f77fd46c2 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iebf3b40ec2e1eb2f49e313fa9316105dbf86b971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521127 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640346} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 41828248626dedf74a472f1383b9121706bc7d36 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:56:25 2019 +0000 Roll src/third_party/webrtc 1175ae0d800e..208634763a17 (2 commits) https://webrtc.googlesource.com/src.git/+log/1175ae0d800e..208634763a17 git log 1175ae0d800e..208634763a17 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 titovartem@google.com Move creation of rtc::NetworkManager into network emulation layer 2019-03-13 ilnik@webrtc.org Add new webrtc_perf_test for lower stream of vp8 simulcast screenshare Created with: gclient setdep -r src/third_party/webrtc@208634763a17 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I74a3f80ea4c8ea607fb85e7a40741523f29c0b57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520872 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640345} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2b1539f0470b531c8600205ebc5f9724c7d3db81 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:54:50 2019 +0000 Roll AFDO from 74.0.3729.7_rc-r1-merged to 74.0.3729.10_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4300766df2fccbc3e9e6016a06be1be2d4c526f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521187 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640344} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 68809c8b9975f1678af9a74215697a0d964cd6f6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:52:03 2019 +0000 Roll src/third_party/SPIRV-Tools/src b75f4362f01a..9d29c37ac507 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b75f4362f01a..9d29c37ac507 git log b75f4362f01a..9d29c37ac507 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 stevenperron@google.com Removing decorations when doing constant propagation. (#2444) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9d29c37ac507 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I82abc03a706ea1077986589b6fe3277b45dc94db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521126 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640343} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4ae2d9b3421d387e890088df716b801311e48bd7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 15:47:18 2019 +0000 Roll src/third_party/angle 3c1f5a6bd487..4e87659e289c (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/3c1f5a6bd487..4e87659e289c git log 3c1f5a6bd487..4e87659e289c --date=short --no-merges --format='%ad %ae %s' 2019-03-13 ianelliott@google.com Fix eglChooseConfig for attributes that have exact default values. Created with: gclient setdep -r src/third_party/angle@4e87659e289c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If592b1bce3b76c344b7328ae6131d9aafd88310c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520875 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640342} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eeac4dcb135f6a81b828acd80cbb2c2bb5bd3599 Author: Raymond Toy <rtoy@chromium.org> Date: Wed Mar 13 15:47:15 2019 +0000 Use matching sample rate for the context as for the reference file The reference file has a certain sample rate. Use the same for the context to reduce the amount of resampling that might be required. Regenerated the webm-decode-expected.wave file with the fixed sample rate. This also changed the SNR slightly, so update the SNR test accordingly. Also manually compared the new and old files. These differ by at most 1 LSB (16-bit). Bug: 940970 Change-Id: I979bbeb512c36d7e2eb4cba85550fa4177b8aabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516723 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640341} ...diaElementAudioSourceToScriptProcessorTest.html | 6 ++++-- .../webm/resources/webm-decode-expected.wav | Bin 184398 -> 184364 bytes .../webaudio/codec-tests/webm/webm-decode.html | 11 +++++++++-- 3 files changed, 13 insertions(+), 4 deletions(-) commit eb9c8349b34fbe8cd23f09b38cd714b92193cb06 Author: Joe Mason <joenotcharles@google.com> Date: Wed Mar 13 15:45:52 2019 +0000 Stop inheriting stdout and stderr in the chrome_cleaner sandbox On windows 7, sometimes these handles are inherited incorrectly, randomly, which causes the sandbox process to die immediately. Also improve the error logging on sandbox startup. R=csharp Bug: 78359771 Change-Id: Icbbab071b71de513d3aaf32e940962f8caf093fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519550 Reviewed-by: Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640340} chrome/chrome_cleaner/ipc/sandbox.cc | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) commit e55a096328305323a46ced532fbbf9a2e4fd4a0a Author: chaopeng@chromium.org <chaopeng@chromium.org> Date: Wed Mar 13 15:38:36 2019 +0000 Reland "Add plumbing for keymap" This is a reland of 6ec27fc3b6c3bde79347b07d89cc4b958c468a90 The bot failed because remoting/protocol/input_event_tracker includes dom_code.h but not deps on ui/events:dom_keycode_converter. Adding deps should fix. TBR=garykac@chromium.org,kerrnel@chromium.org Original change's description: > Add plumbing for keymap > > > Change-Id: I5b68fd4345e9331c7de5f6947a4cc17cf5d5992a > Bug: 920824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495594 > Reviewed-by: Gary Kacmarcik <garykac@chromium.org> > Reviewed-by: Greg Kerr <kerrnel@chromium.org> > Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640047} Bug: 920824 Change-Id: I313dbc9c0a83bf69e0f5f51ba87f421585d460a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518404 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640339} remoting/protocol/BUILD.gn | 1 + ui/events/BUILD.gn | 29 ++++++++++++++++++++++ ui/events/keycodes/dom/dom_key_data.inc | 6 +++++ .../dom/keycode_conversion_data_android.inc | 3 +++ ui/events/keycodes/dom/keycode_converter_data.inc | 6 +++++ .../keycodes/keyboard_code_conversion_android.cc | 12 +++++++++ ui/events/keycodes/keyboard_codes_posix.h | 1 + ui/events/mojo/keyboard_codes.mojom | 1 + 8 files changed, 59 insertions(+) commit c5352ce8b8674f1f6fa1edf6b0d2d2066c795b57 Author: danakj <danakj@chromium.org> Date: Wed Mar 13 15:37:51 2019 +0000 Move background color into the kAll lifecycle update. It was done in the kPrePaint cycle but not for any good reason, it just was meant to not be part of the layout update. To avoid an extra branch and make it less "interesting" move the background color in with the rest of the painting updates. R=chrishtr@chromium.org Change-Id: I4bb7091ed86f7d29ca6bc36a8f137f6b15d26008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518903 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640338} third_party/blink/renderer/core/exported/web_view_impl.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 6409110fbdbed9b667cea03ca7462c51575bacba Author: Julian Pastarmov <pastarmovj@chromium.org> Date: Wed Mar 13 15:37:11 2019 +0000 Remove the future flag from the policy templates for the LBS policies. BUG=none Change-Id: Iaa5e4a3950ce1d62158128faf0ca3e325961f377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520831 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640337} components/policy/resources/policy_templates.json | 9 --------- 1 file changed, 9 deletions(-) commit 1f08e365e3fcf33c7f3f8f2155462fc41042866c Author: Moe Ahmadi <mahmadi@chromium.org> Date: Wed Mar 13 15:36:45 2019 +0000 [iOS][Translate] Add ios_chrome_translate_egtests to main waterfall and CQ Also adds the ios_chrome_translate_egtests target to the slimnav bot. Bug: 910994 Change-Id: I8e8d1cd960bbfe75bbdd3f4850915b08a450090f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518914 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640336} ios/build/bots/chromium.mac/ios-slimnav.json | 48 ++++++++++++++++++++++++++++ ios/build/bots/tests/eg_tests.json | 7 ++++ testing/buildbot/gn_isolate_map.pyl | 7 ++++ testing/buildbot/manage.py | 1 + 4 files changed, 63 insertions(+) commit bd7e1f6d838615c1a7d4b601c77f6b34e2a8d909 Author: Alexandre Frechette <frechette@chromium.org> Date: Wed Mar 13 15:30:08 2019 +0000 Removing iOS specific accept languages pref. language::prefs owns and registers the accept language pref. No need to have a duplicate in iOS specific code. Bug: 872096 Change-Id: I2f97ed0cd8b957b686b2d5ef3a044cbd88024352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515213 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640335} ios/chrome/browser/BUILD.gn | 1 + ios/chrome/browser/autocomplete/BUILD.gn | 1 + .../autocomplete/autocomplete_provider_client_impl.mm | 4 +++- ios/chrome/browser/ios_chrome_main_parts.mm | 4 +++- .../browser/language/language_model_manager_factory.cc | 15 +++++++-------- ios/chrome/browser/net/BUILD.gn | 1 + .../browser/net/ios_chrome_http_user_agent_settings.mm | 4 ++-- ios/chrome/browser/pref_names.cc | 4 ---- ios/chrome/browser/pref_names.h | 1 - ios/chrome/browser/prefs/browser_prefs.mm | 4 ++-- .../browser/translate/chrome_ios_translate_client.mm | 5 +++-- .../translate/translate_accept_languages_factory.cc | 4 ++-- ios/chrome/browser/ui/settings/BUILD.gn | 1 + .../settings/translate_table_view_controller_unittest.mm | 4 ++-- 14 files changed, 28 insertions(+), 25 deletions(-) commit 6de975a87311df3fb8dc667920b8dc2a2a8d60e2 Author: vasilii <vasilii@chromium.org> Date: Wed Mar 13 15:24:35 2019 +0000 Remove GetPreferredMatch from PasswordFormManagerForUI. The UI should not care about the notion of preferred match. It displays username/password for saving which should come from GetPendingCredentials. Bug: 831123 Change-Id: Ia659ed13228d5d5aae27e9313ec5f38ba8ea011d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520492 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#640334} .../core/browser/new_password_form_manager.cc | 4 ---- .../core/browser/new_password_form_manager.h | 1 - .../core/browser/password_form_manager.cc | 4 ---- .../core/browser/password_form_manager.h | 4 +++- .../core/browser/password_form_manager_for_ui.h | 2 -- .../core/browser/password_form_manager_unittest.cc | 16 ++++++++-------- .../ios_chrome_update_password_infobar_delegate.mm | 2 +- .../internal/passwords/cwv_password_controller.mm | 6 +----- 8 files changed, 13 insertions(+), 26 deletions(-) commit 5f687b58ce7488c0f97901ed07a2be94326d4f40 Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Wed Mar 13 15:24:06 2019 +0000 Don't use Mojo to get account info in identity_get_auth_token_function.cc identity_get_auth_token_function.cc uses a mix of C++ and Mojo code. This CL ports GetAccountInfoFromGaiaId() to C++. Bug: 913853 Change-Id: Icd27b8c3b42ea63bf18417f75884ae04a890978b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1458301 Reviewed-by: Lowell Manners <lowell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#640333} .../identity/identity_get_auth_token_function.cc | 67 ++++++++-------------- .../identity/identity_get_auth_token_function.h | 19 ++---- 2 files changed, 28 insertions(+), 58 deletions(-) commit 156c9bb2aa863c46686fcae139eb4ca9a0b672d6 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Wed Mar 13 15:20:14 2019 +0000 Update V8 to version 7.5.26. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4244ba53..61514a9c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6e76c7d4f992aa4127b1ef8b34522b2d072e6e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520283 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640332} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 307a1077bcdca3fe8acbd0035ad922cef05d1e46 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Mar 13 15:12:25 2019 +0000 Remove WTF::RetainPtr now that it's no longer used Now that the last conversion from WTF::RetainPtr for the Mac build has been merged, wtf/retain_ptr.h is no longer used anywhere and we can safely remove it, so let's do it now to prevent new code from using WTF::RetainPtr again. Also, remove an stray include in wtf/text/string_impl_cf.cc that should have been removed along with CL1518573, when that file was migrated. Bug: 929973 Change-Id: I5307c1fbf716a4f581fc6b0fadec608f8661bcb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520489 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#640331} third_party/blink/renderer/platform/wtf/BUILD.gn | 1 - .../blink/renderer/platform/wtf/retain_ptr.h | 328 --------------------- .../renderer/platform/wtf/text/string_impl_cf.cc | 1 - 3 files changed, 330 deletions(-) commit 5c92556da6b0b82aecacdd85abf090be1872e21b Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Mar 13 15:11:15 2019 +0000 service worker: Remove ServiceWorkerServicification field trial config. The feature already launched on Stable in Dec 2018 and has been enabled in the code since M72. Bug: 846235 Change-Id: Ib5e280b9809f8f69ede02abbb127d2d475c285c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519971 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#640330} testing/variations/fieldtrial_testing_config.json | 20 -------------------- 1 file changed, 20 deletions(-) commit ed7199ce9aabf8c353453bb6ff1ec3dba3b1df4f Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 15:07:16 2019 +0000 flags: remove enable-ble-advertising-in-apps This flag is practically unused in the field according to UMA. The switch is retained for development/debugging. Bug: None Change-Id: Iab1476a20a70abeb8b2e48d84fb1e0da4bf508ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517914 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#640329} chrome/browser/about_flags.cc | 6 ------ chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- extensions/common/api/bluetooth_low_energy.idl | 4 ++-- 5 files changed, 2 insertions(+), 21 deletions(-) commit eac3343138a438f2da4a30f8785f89345f8c2e48 Author: Chris Hamilton <chrisha@chromium.org> Date: Wed Mar 13 15:06:12 2019 +0000 [PM] Retire kVisibility property. This retires the kVisibilityproperty from the page node as part of the refactor that aims to get rid of the "bag of properties" from node impls. BUG=910288 Change-Id: I351345e2f9841c7fa8469b71726c77ff751a83b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518922 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640328} .../graph/graph_introspector_impl.cc | 2 +- .../performance_manager/graph/page_node_impl.cc | 27 +++++++++++----------- .../performance_manager/graph/page_node_impl.h | 8 +++++-- .../graph/page_node_impl_unittest.cc | 4 ++-- .../observers/coordination_unit_graph_observer.h | 2 +- .../observers/metrics_collector.cc | 26 ++++++++++----------- .../observers/metrics_collector.h | 1 + .../public/mojom/signals.mojom | 1 - 8 files changed, 37 insertions(+), 34 deletions(-) commit 394375a5f931373fc697e95f05ea9cee324d258d Author: Tim Volodine <timvolodine@chromium.org> Date: Wed Mar 13 15:03:05 2019 +0000 [AW NS] Fix crash when safebrowsing is disabled in WebView When safe browsing is disabled and network service is enabled WebView crashes while it attempts to load a url. For Android WebView safe browsing can be disabled by means of global security settings in Android or by WebView's individual settings i.e. WebSettings.setSafeBrowsingEnabled(false). The crash happens due to a validating mojo DCHECK that results in a failure when SafeBrowsing::CreateCheckerAndCheckCallback is not being run or the corresponding binding destroyed (see crbug.com/889479 for details). This happens when UrlCheckerDelegate::ShouldSkipRequestCheck is true. Note that in the case of chrome, the ShouldSkipRequestCheck() method currently always returns false when network service is enabled. In this patch we make sure to execute the callback before it is destroyed. This patch also adds an instrumentation test to make sure this code path is covered. In particular making sure that RendererURLLoaderThrottle attempts to check a url through loading an image. BUG=889479,841556 Test: run_webview_instrumentation_test_apk \ Test: -f SafeBrowsingTest#testSafeBrowsingCanBeDisabledPerWebview_withImage \ Test: --enable-features="NetworkService,NetworkServiceInProcess" Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I51737e71f62cacea2e2d6dd0d6273f9865b9c824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512552 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#640327} .../chromium/android_webview/test/SafeBrowsingTest.java | 17 +++++++++++++++++ android_webview/test/data/malware_with_image.html | 15 +++++++++++++++ .../safe_browsing/browser/mojo_safe_browsing_impl.cc | 6 ++++++ 3 files changed, 38 insertions(+) commit 38047ee3fe1adeb061216ac6f3f877d1ca9660fa Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 15:01:05 2019 +0000 Change long long to int64_t in third_party/blink/renderer/core/loader/history_item.h - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I44be2fae69ab80dfe358bd3ce57ef6188b6dfb47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520521 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640326} third_party/blink/public/web/web_history_item.h | 8 ++++---- third_party/blink/renderer/core/exported/web_history_item.cc | 8 ++++---- third_party/blink/renderer/core/loader/history_item.cc | 4 ++-- third_party/blink/renderer/core/loader/history_item.h | 10 ++++------ 4 files changed, 14 insertions(+), 16 deletions(-) commit 1e7abe5db9307589091a580b204869c5b07ab04c Author: Ovidio Henriquez <odejesush@chromium.org> Date: Wed Mar 13 15:00:04 2019 +0000 android: Add |mIsManaged| to ChosenObjectInfo This change adds a |mIsManaged| boolean to ChosenObjectInfo that is true if the source of the preference is content_settings::SETTING_SOURCE_POLICY. This will prepare policy allowed chosen objects to be displayed properly in the Site Settings UI. Design doc: https://docs.google.com/document/d/1MPvsrWiVD_jAC8ELyk8njFpy6j1thfVU5aWT3TCWE8w/edit#heading=h.z7uyjhrr3ac2 Bug: 854329 Change-Id: Iaa943154d8c62587dff0fbdfdb88ceb994d2d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1428040 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#640325} .../browser/preferences/website/ChosenObjectInfo.java | 19 +++++++++++++++---- .../preferences/website/WebsitePreferenceBridge.java | 6 ++++-- .../android/preferences/website_preference_bridge.cc | 5 ++++- 3 files changed, 23 insertions(+), 7 deletions(-) commit 7a4256c4af0c42eda8732ba54e5d469843cbf079 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Wed Mar 13 14:58:25 2019 +0000 OOR-CORS: variation config for Android WebView Now that the server is ready to start field trial on Android WebView, we want to enable it in the variation config so to start the beta trial even on WebView. Bug: 905971 Change-Id: I5ea08ba4d41afaf2d43a5d1ec0db44d92b680a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519972 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640324} testing/variations/fieldtrial_testing_config.json | 1 + 1 file changed, 1 insertion(+) commit 8906d05e9c116136f2b0ad0076b8cba5002eefc3 Author: Alex Clarke <alexclarke@chromium.org> Date: Wed Mar 13 14:58:04 2019 +0000 Add base/parameter_pack.h a collection of parameter pack utils This will be used by base::Promise<>. Bug: 906125 Change-Id: I4e2dbb44947c336d8fffa8f571b4d2a96aaa25b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496858 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#640323} base/BUILD.gn | 2 + base/parameter_pack.h | 108 ++++++++++++++++++++++++++++++++++++++++ base/parameter_pack_unittest.cc | 76 ++++++++++++++++++++++++++++ base/traits_bag.h | 52 +++---------------- 4 files changed, 194 insertions(+), 44 deletions(-) commit 2e82627fffe46c0586a6303e07989117f6bd258e Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Wed Mar 13 14:55:03 2019 +0000 content: remove asvitkine@ as a mac owner This change removes asvitkine from //content/browser/renderer_host OWNERS per comment on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1516354 Ownership of ~all Mac code in //content rests with the //content/OWNERS Mac owners. Bug: None Change-Id: I4905ebd692de9be3adc45fe1ec516f187652df7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520694 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640322} content/browser/renderer_host/OWNERS | 3 --- 1 file changed, 3 deletions(-) commit 3d03fcc883363d185a2aa10ff77b49fbd0934766 Author: Eugene Girard <girard@chromium.org> Date: Wed Mar 13 14:51:32 2019 +0000 Revert "Make BLINK_ANIMATION_USE_TIME_DELTA visible to renderer:blink_pch" This reverts commit b1055ded27ad9c5ab25f6cf9ddfbcc3f6dd5e0f2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Make BLINK_ANIMATION_USE_TIME_DELTA visible to renderer:blink_pch > > There is code in renderer/modules that isn't currently seeing the correct version of AnimationTimeDelta > third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc > > blink_unittests was failing to link with precompiled headers enabled. > > > Bug: 737867 > Change-Id: I437abd16e2d53a4ef05af8b95fdd01d2b9215a53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515682 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Eugene Girard <girard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640299} TBR=girard@chromium.org,thakis@chromium.org,smcgruer@chromium.org Change-Id: Id2b407be68f4e550131fc6c84dfd7bd67ddeb113 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 737867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521146 Reviewed-by: Eugene Girard <girard@chromium.org> Commit-Queue: Eugene Girard <girard@chromium.org> Cr-Commit-Position: refs/heads/master@{#640321} build/buildflag_header.gni | 4 ++-- third_party/blink/renderer/core/BUILD.gn | 7 +++++++ third_party/blink/renderer/core/animation/BUILD.gn | 17 ----------------- .../renderer/core/animation/animation_time_delta.cc | 2 +- .../renderer/core/animation/animation_time_delta.h | 7 +++---- third_party/blink/renderer/core/core.gni | 6 ++++++ 6 files changed, 19 insertions(+), 24 deletions(-) commit 1020095d64cf6ef824a0eb63dabb28d64d3d1b35 Author: Javier Fernandez <jfernandez@igalia.com> Date: Wed Mar 13 14:51:21 2019 +0000 Updated the css-text test suite Added a few additional tests to verify some leading white-space cases with different properties. Fixed also some typos and bad design choices in some tests. Change-Id: Ic702d9ce4bd969408c4760724f1f9d4a1f6eb6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520829 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#640320} .../overflow-wrap-break-word-007.html | 38 ++++++++++++++++++++++ .../wpt/css/css-text/white-space/pre-wrap-008.html | 38 ++++++++++++++++++++++ .../word-break/word-break-break-all-011.html | 5 +-- .../word-break/word-break-break-all-012.html | 4 +-- .../word-break/word-break-break-all-013.html | 4 +-- .../word-break/word-break-break-all-015.html | 38 ++++++++++++++++++++++ 6 files changed, 121 insertions(+), 6 deletions(-) commit 079c6346008c942fd2c89166a606c0e57a802a33 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Wed Mar 13 14:50:12 2019 +0000 [Extensions Bindings] Remove obsolete JS resources from //chrome With Native Extension Bindings, many surfaces and custom hooks are implemented natively in C++ rather than in JS. Remove the obsolete JS resources from //chrome/renderer/resources/extensions and update the resource file. TBR=tommycli@chromium.org (just removing files from renderer_resources.grd) Bug: 938998 Change-Id: I97322ccd0145227ab3178f3a0fe1b0a1fac705c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509898 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640319} chrome/renderer/BUILD.gn | 4 - .../chrome_extensions_dispatcher_delegate.cc | 11 -- .../resources/extensions/app_custom_bindings.js | 83 --------------- .../resources/extensions/chrome_setting.js | 59 ----------- .../resources/extensions/content_setting.js | 112 --------------------- .../extensions/easy_unlock_proximity_required.js | 20 ---- .../resources/extensions/tabs_custom_bindings.js | 56 ----------- chrome/renderer/resources/renderer_resources.grd | 5 - 8 files changed, 350 deletions(-) commit e8b5a4a57127389583747b266c770c0ce797390f Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 14:46:49 2019 +0000 Change long long to int64_t in third_party/blink/renderer/ related blob - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: Ibd0fa8efcbc3d61b6e1a27cac8e26260ad6b2097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519509 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640318} third_party/blink/public/platform/web_drag_data.h | 2 +- third_party/blink/public/platform/web_http_body.h | 12 ++++++------ third_party/blink/renderer/core/fileapi/blob.cc | 6 +++--- third_party/blink/renderer/core/fileapi/blob.h | 18 ++++++++---------- third_party/blink/renderer/core/fileapi/file.cc | 8 ++++---- third_party/blink/renderer/core/fileapi/file.h | 6 +++--- third_party/blink/renderer/platform/blob/blob_data.cc | 14 +++++++------- third_party/blink/renderer/platform/blob/blob_data.h | 14 +++++++------- .../blink/renderer/platform/exported/web_http_body.cc | 8 ++++---- third_party/blink/renderer/platform/file_metadata.cc | 2 +- third_party/blink/renderer/platform/file_metadata.h | 4 ++-- .../renderer/platform/network/encoded_form_data.cc | 4 ++-- .../renderer/platform/network/encoded_form_data.h | 12 ++++++------ 13 files changed, 54 insertions(+), 56 deletions(-) commit b61811edae1e237ba37680474bea4cada3f02e25 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Mar 13 14:46:26 2019 +0000 Roll src/third_party/perfetto e96498a32500..c4e085dbb2c7 (7 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/e96498a32500..c4e085dbb2c7 git log e96498a32500..c4e085dbb2c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 nuskos@google.com Move the variable declaration down into the #if this fixes the windows build. 2019-03-13 eseckler@google.com Merge "trace buffer: Ignore empty packets" 2019-03-12 lalitm@google.com Merge "trace_processor: massively speed up thread/process name lookups" 2019-03-12 lalitm@google.com trace_processor: improve query performance involving filter operations 2019-03-12 primiano@google.com Merge "Rename service_impl_unittest to match src files" 2019-03-12 ilkos@google.com Merge "Change deque to vector in the critical path" 2019-03-12 hjd@google.com Merge "traced: Add kernel version to trace" Created with: gclient setdep -r src/third_party/perfetto@c4e085dbb2c7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1bf5ea3a338e0517e665c2ad79ca845915e8fb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520871 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640317} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0d06196b004473cf5400f7ddca5ad27aaa9ff0de Author: Miyoung Shin <myid.shin@igalia.com> Date: Wed Mar 13 14:43:44 2019 +0000 Change long long to int64_t in third_party/blink/public/platform/platform.h - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I948d6cc6e58f61a68f7fcade5774c148e7fe03de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520525 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640316} content/child/blink_platform_impl.cc | 6 +++--- content/child/blink_platform_impl.h | 6 +++--- content/renderer/renderer_blink_platform_impl.cc | 6 +++--- content/renderer/renderer_blink_platform_impl.h | 6 +++--- third_party/blink/public/platform/platform.h | 6 +++--- 5 files changed, 15 insertions(+), 15 deletions(-) commit 2d471b944fcf59f93b0c92be334efdbabb851997 Author: Jeremy Roman <jbroman@chromium.org> Date: Wed Mar 13 14:42:48 2019 +0000 Remove unused NSColor (WebNSColorDetails) category. It is unused since April 2013, just after the Blink fork. Change-Id: I9c01ddbdda5febff68fd6561e347c647554cdc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518762 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640315} third_party/blink/renderer/core/scroll/scrollbar_theme_mac.mm | 4 ---- 1 file changed, 4 deletions(-) commit 6b93dab96c0c42f0dfa3ee8a4d7c9965a58e336e Author: Peter Mayo <petermayo@chromium.org> Date: Wed Mar 13 14:42:38 2019 +0000 [CC] clean up some test code Three cc_unittests worked around the fact that the animation host for the class provided animation classes was out of date by directly calling the correct animation host on their behalf, instead of using then normally. This makes refactoring the animation host calls break the tests incorrectly. The fix is to reset the animation host for the timeline in tests that use it and have created their own local FakeLayerTreeHostImpl. While examining them I added a little more explicit positive and negative checks that the tests were operating on solid assertions. (i.e. the property they expected to cause skipping is reflected the way they expect, before they validate that the presence of an animation changes it.) Bug: 771316 Change-Id: I5a57b9cc34fc60721355fd291176ce9920991669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518060 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640314} cc/trees/layer_tree_host_common_unittest.cc | 141 ++++++++++++++++++---------- 1 file changed, 91 insertions(+), 50 deletions(-) commit 0c4f1c57aa6beaebd1845cf0fbb1ab5dd385d6ff Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Wed Mar 13 14:40:30 2019 +0000 Roll src-internal 55881f78ae39..63e898da8fa6 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55881f78ae39..63e898da8fa6 Created with: gclient setdep -r src-internal@63e898da8fa6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Ibfa1a1db6ca60005003dfbcd13787b95ce305bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520870 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640313} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8962bf5c72ae4ef7b7cd6eb6a1f86b28e574ecb0 Author: Clemens Arbesser <arbesser@google.com> Date: Wed Mar 13 14:33:25 2019 +0000 [Autofill Assistant] Added new script parameter to hide initial details. Bug: b/128498126 Change-Id: If26ff8f51df147f1efe98fe4274195aac857bfda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520669 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#640312} components/autofill_assistant/browser/details.cc | 4 ++++ 1 file changed, 4 insertions(+) commit a5ba44736cdef7e0185be359c5456d8c2cd22a40 Author: Marc Treib <treib@chromium.org> Date: Wed Mar 13 14:30:43 2019 +0000 Cleanup: Remove syncer::SyncEngine::Status typedef It was an alias for syncer::SyncStatus. All call sites are updated to refer to syncer::SyncStatus directly. Bug: none Change-Id: Iff1c0d330076ab7c6309d434b9846b236c6c8ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520671 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#640311} chrome/browser/sync/sync_error_notifier_ash_unittest.cc | 1 - chrome/browser/sync/sync_ui_util_unittest.cc | 16 ++++++++-------- components/browser_sync/profile_sync_service.cc | 6 +++--- components/browser_sync/profile_sync_service_mock.h | 3 +-- components/sync/engine/fake_sync_engine.cc | 4 ++-- components/sync/engine/fake_sync_engine.h | 2 +- components/sync/engine/mock_sync_engine.h | 2 +- components/sync/engine/sync_engine.h | 3 +-- 8 files changed, 17 insertions(+), 20 deletions(-) commit b637c0ca971f1cc91b61bdc69e5aa22445076cf8 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Wed Mar 13 14:28:15 2019 +0000 Treat first cpu usage value as NaN, not 0.0 Bug: 668718 Change-Id: I98773b30052b83d9a40afde8845a1a4d1704cbc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515174 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#640310} chrome/browser/task_manager/sampling/task_group.h | 1 + chrome/browser/task_manager/sampling/task_group_sampler.cc | 11 +++++++++-- chrome/browser/task_manager/sampling/task_group_sampler.h | 4 ++++ 3 files changed, 14 insertions(+), 2 deletions(-) commit 043193d8e685e737f61c2a2299282f255fc4a551 Author: Andrew Grieve <agrieve@chromium.org> Date: Wed Mar 13 14:26:25 2019 +0000 SuperSize: Fix .pak section sizes being calculated incorrectly It was summing symbol.size for each section, but should have been using PSS. The point of section_sizes it to be measured differently from sum(symbols) though, so changed the logic to be the sum of .pak file sizes. Also fixes a bug where we were considering es-419.pak a non-locale pak and updates the pak compression ratio to be more appropriate for bundles, which a have a different set of strings. Change-Id: I2384975c540e6d27a378c03c1ec5f084617d4c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518055 Reviewed-by: Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#640309} tools/binary_size/libsupersize/archive.py | 48 ++++++++++++---------- .../libsupersize/testdata/Archive_Apk.golden | 2 +- .../testdata/Archive_MinimalApks.golden | 2 +- .../libsupersize/testdata/Archive_Pak_Files.golden | 2 +- 4 files changed, 29 insertions(+), 25 deletions(-) commit d3b815ac5d2d55032e66d66d10f9b142b27fc998 Author: Marc Treib <treib@chromium.org> Date: Wed Mar 13 14:25:45 2019 +0000 Remove unused OneClickSigninLinksDelegate::OnAdvancedLinkClicked It was only called in a single test, which is now removed as well. Bug: none Change-Id: I9e82211d5b129c10dd911e7fa79c96029fae47f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508274 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#640308} chrome/browser/ui/sync/one_click_signin_links_delegate.h | 1 - .../browser/ui/sync/one_click_signin_links_delegate_impl.cc | 5 ----- .../browser/ui/sync/one_click_signin_links_delegate_impl.h | 1 - .../one_click_signin_links_delegate_impl_browsertest.cc | 13 ------------- .../ui/views/sync/one_click_signin_dialog_view_unittest.cc | 3 --- 5 files changed, 23 deletions(-) Updated tag 'tree_truth' (was 76440d190978)