Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 44306 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918972761890950592 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itbKUFit/luci_context.968389345 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm570-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43971876b2d72911 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 6b1606cdc4dbf926c205bb6664c9e326c91437ef [Extensions Bindings] Remove TestConfig.nativeCrxBindingsEnabled Devlin Cronin, Thu Mar 14 22:15:18 2019 +0000 0a59002c267af015a2162d31f9450fb28c00f1b6 Roll src/third_party/catapult 44a43fd4ffa9..f8e231582d6a (1 commits) chromium-autoroll, Thu Mar 14 22:14:44 2019 +0000 5003308957c3369314cca767781265de87603aab Fix remoting perf tests. Jamie Walch, Thu Mar 14 22:13:50 2019 +0000 ebb194673e328a12e8db73751b33e0e8a2abe7fa Roll src/third_party/chromite 0f6a92f63625..69d4958ee9b3 (2 commits) chromium-autoroll, Thu Mar 14 22:12:27 2019 +0000 93d4131ac913d43b4f36b36924f270d9bf4c6f02 [AR][IOS] Cleans up USZD file preview base::Feature code post launch Moe Ahmadi, Thu Mar 14 22:04:02 2019 +0000 9dcba5033ec946df6c21d0254f5b59857dbdff9e Clean up fuzzer teardown Jonathan Backer, Thu Mar 14 22:03:38 2019 +0000 d6cd75bec10d294b5c6cfe7fb72f5f9ef8d980c3 Add a finch flag for Android wide color gamut Eric Karl, Thu Mar 14 22:01:36 2019 +0000 dd9bcb241b9d2582f67c086a0f2af762336c7adb cros: Eliminate ScreenContext in ResetScreen Jacob Dufault, Thu Mar 14 21:55:11 2019 +0000 d02e5e992b88f63a49efd57dc7af7c65515add20 Fix libEGL CFI-icall failures Vlad Tsyrklevich, Thu Mar 14 21:53:25 2019 +0000 87da6a7a9c6c56684412a8bdb09cc1a0fee65108 Reland "Launch Android Intent for media playback" Li Lin, Thu Mar 14 21:51:27 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 6b1606cdc4dbf926c205bb6664c9e326c91437ef Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 14 22:15:18 2019 +0000 [Extensions Bindings] Remove TestConfig.nativeCrxBindingsEnabled Remove nativeCrxBindingsEnabled from the TestConfig object in the chrome.test extension API. Since native bindings are now always enabled, we don't need this boolean. Update JS files that were using it. Bug: 938998, 792602 Change-Id: Ica1e78b4c7a2e86258977e9c7939181ff3a8cec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518147 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640951} chrome/browser/extensions/extension_apitest.cc | 3 -- .../api_test/activity_log_private/test/test.js | 47 ++-------------------- .../bindings/invalidate_context/background.js | 16 +------- .../extensions/api_test/messaging/connect/page.js | 24 ----------- .../extensions/api_test/messaging/connect/test.js | 32 ++------------- extensions/common/api/test.json | 5 --- 6 files changed, 9 insertions(+), 118 deletions(-) commit 0a59002c267af015a2162d31f9450fb28c00f1b6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:14:44 2019 +0000 Roll src/third_party/catapult 44a43fd4ffa9..f8e231582d6a (1 commits) https://chromium.googlesource.com/catapult.git/+log/44a43fd4ffa9..f8e231582d6a git log 44a43fd4ffa9..f8e231582d6a --date=short --no-merges --format='%ad %ae %s' 2019-03-14 benjhayden@chromium.org Add chart-section to chromeperf-app Created with: gclient setdep -r src/third_party/catapult@f8e231582d6a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: Ic03b3ae769188a0d223487aa6186ea9fbc25fd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524377 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640950} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5003308957c3369314cca767781265de87603aab Author: Jamie Walch <jamiewalch@chromium.org> Date: Thu Mar 14 22:13:50 2019 +0000 Fix remoting perf tests. These tests had not been run in some time and there were a few crashes: * ScopedTaskEnvironment is now preferred, and there's a DCHECK to ensure that any TaskScheduler created in a test is cleaned up after it exits. * A NetworkChangeNotifier is required by Rfc7050PrefixRefresher. Change-Id: I6988f05d873bedc02fe63d0760a464e3c82249c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524707 Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#640949} remoting/test/protocol_perftest.cc | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) commit ebb194673e328a12e8db73751b33e0e8a2abe7fa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:12:27 2019 +0000 Roll src/third_party/chromite 0f6a92f63625..69d4958ee9b3 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f6a92f63625..69d4958ee9b3 git log 0f6a92f63625..69d4958ee9b3 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 pprabhu@chromium.org config: Move {caroline*,kevin*} chrome PFQ to Skylab 2019-03-14 pprabhu@chromium.org config: Move pi-android PFQ for {caroline-arcnext,kevin} to Skylab Created with: gclient setdep -r src/third_party/chromite@69d4958ee9b3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib1bca464d698b554ec64261a6cd4acb4f7d0637d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524380 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640948} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 93d4131ac913d43b4f36b36924f270d9bf4c6f02 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Mar 14 22:04:02 2019 +0000 [AR][IOS] Cleans up USZD file preview base::Feature code post launch Bug: 1476057 Change-Id: I4537b2ed44f4c440de1acd893b3f4ea01156a7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524643 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640947} ios/chrome/browser/BUILD.gn | 1 - ios/chrome/browser/about_flags.mm | 4 ---- ios/chrome/browser/download/browser_download_service_unittest.mm | 4 ---- ios/chrome/browser/download/features.h | 4 ---- ios/chrome/browser/download/features.mm | 6 +----- ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ---- ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 ---- 7 files changed, 1 insertion(+), 26 deletions(-) commit 9dcba5033ec946df6c21d0254f5b59857dbdff9e Author: Jonathan Backer <backer@chromium.org> Date: Thu Mar 14 22:03:38 2019 +0000 Clean up fuzzer teardown Two changes: - only Destroy decoder_ if successfully Initialized. A failing initialization will call Destroy and it's not safe to call twice. - DestroyAllSharedImages with context_state_ current. If |decoder_| did not properly Initialize, there may not be a context current. Moved it after destroying decoder so that destruction order is the opposite of construction order. Bug: 941668, 941704 Change-Id: I45f6bae446f1540c84737e76d46879e144f75154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525005 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640946} gpu/command_buffer/tests/fuzzer_main.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit d6cd75bec10d294b5c6cfe7fb72f5f9ef8d980c3 Author: Eric Karl <ericrk@chromium.org> Date: Thu Mar 14 22:01:36 2019 +0000 Add a finch flag for Android wide color gamut Allow finch trial of wide color gamut on specific device models. Also add a setting in ContentBrowserClient to determine whether Android uses the Window's colorspace (needed for WebView to match embedding app), or the display's capabilities (used in full Chrome). Bug: 884376 Change-Id: Ice9a421c87e52620ce3f10595f676ad2946da56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516595 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640945} .../browser/aw_content_browser_client.cc | 8 +++++ .../browser/aw_content_browser_client.h | 2 ++ android_webview/browser/aw_feature_list.cc | 1 - .../chromium/android_webview/AwBrowserProcess.java | 5 --- .../chromium/android_webview/AwFeatureList.java | 1 - chrome/browser/chrome_content_browser_client.cc | 10 ++++++ chrome/browser/chrome_content_browser_client.h | 5 +++ chrome/common/chrome_features.cc | 42 ++++++++++++++++++++++ chrome/common/chrome_features.h | 8 +++++ content/browser/browser_main_loop.cc | 5 ++- .../renderer_host/render_widget_host_unittest.cc | 3 +- .../render_widget_host_view_android.cc | 7 +++- content/public/browser/content_browser_client.cc | 7 ++++ content/public/browser/content_browser_client.h | 12 +++++++ ui/android/display_android_manager.cc | 19 ++++++---- ui/android/display_android_manager.h | 5 +-- .../src/org/chromium/ui/base/WindowAndroid.java | 9 ----- ui/android/screen_android.h | 2 +- ui/android/window_android.cc | 3 -- 19 files changed, 122 insertions(+), 32 deletions(-) commit dd9bcb241b9d2582f67c086a0f2af762336c7adb Author: Jacob Dufault <jdufault@google.com> Date: Thu Mar 14 21:55:11 2019 +0000 cros: Eliminate ScreenContext in ResetScreen Bug: 926511 Change-Id: I956961db07987b17f51a7b2757c6f2f1851f1fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506755 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640944} .../browser/chromeos/login/screens/reset_screen.cc | 136 +++++------- .../browser/chromeos/login/screens/reset_screen.h | 7 - chrome/browser/chromeos/login/screens/reset_view.h | 27 +++ .../chromeos/login/oobe_screen_hid_detection.js | 4 +- .../resources/chromeos/login/oobe_screen_reset.js | 237 ++++++++++++--------- .../webui/chromeos/login/reset_screen_handler.cc | 83 +++++++- .../ui/webui/chromeos/login/reset_screen_handler.h | 24 +++ 7 files changed, 318 insertions(+), 200 deletions(-) commit d02e5e992b88f63a49efd57dc7af7c65515add20 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Mar 14 21:53:25 2019 +0000 Fix libEGL CFI-icall failures This is required as of https://crrev.com/c/1380511 since it replaces direct calls with dynamically resolved cross-DSO calls. Bug: 941468 Change-Id: I6fdc99cde23a6d69f5d15667d10e847b8cad2f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525043 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#640943} tools/cfi/blacklist.txt | 1 + 1 file changed, 1 insertion(+) commit 87da6a7a9c6c56684412a8bdb09cc1a0fee65108 Author: Li Lin <llin@chromium.org> Date: Thu Mar 14 21:51:27 2019 +0000 Reland "Launch Android Intent for media playback" This is a reland of fb0e628497c513215b458fc2236406f7ab7eafb0 Original change's description: > Launch Android Intent for media playback. > > Bug: b:124796759 > Test: Manual > Change-Id: I197f984578e9f80096ada1701e0399058bf9e848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Li Lin <llin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638359} Bug: b:124796759 Change-Id: Ic6933c129ccb68232987c19c5eca8c16032fc303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509817 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640942} chrome/browser/ui/ash/assistant/device_actions.cc | 3 ++ .../assistant/assistant_manager_service_impl.cc | 47 ++++++++++++++++++++-- .../assistant/assistant_manager_service_impl.h | 4 ++ .../assistant/public/mojom/assistant.mojom | 12 ++++++ 4 files changed, 62 insertions(+), 4 deletions(-) commit 93337ded59d1232dd0f695c6703d729e324b787f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Mar 14 21:49:12 2019 +0000 CORB allowlist additions - 2019-03-14. Bug: 941720 Bug: 941755 Bug: 941774 Bug: 941857 Bug: 941816 Bug: 941921 Bug: 941928 Bug: 941815 Bug: 941812 Bug: 941973 Bug: 941974 Bug: 941992 Bug: 941813 Bug: 942009 Bug: 942026 Bug: 942079 Bug: 942143 Bug: 942146 Bug: 942148 Bug: 942178 Bug: 941890 Change-Id: Ie615fd44e49ee28a5f610db008397752d90bb1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521973 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#640941} extensions/browser/url_loader_factory_manager.cc | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) commit 6cb102aab2070730da90a0f2baee202e36f146b2 Author: Tatiana Buldina <buldina@chromium.org> Date: Thu Mar 14 21:48:25 2019 +0000 [ChromeDriver] Allow null value for script timeout Bug: chromedriver:2796 Change-Id: If8ea3747baac59a7deb6a63c5abb15ca9695abda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521768 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#640940} chrome/test/chromedriver/capabilities.cc | 18 +++++++++++----- chrome/test/chromedriver/session_commands.cc | 32 +++++++++++++++++++++------- 2 files changed, 37 insertions(+), 13 deletions(-) commit af84026e54147863098b8585d6b3d431a6102943 Author: Azeem Arshad <azeemarshad@chromium.org> Date: Thu Mar 14 21:47:52 2019 +0000 [AndroidSms] Fix issues with messages commandline url override. This CL adds a new commandline arg for the android messages PWA installation url. Also fixed issue with localhost urls crashing PWA installation. Fixed this by not passing secure flag for cookies when setting it on localhost urls. Bug: 904686 Change-Id: Ib084c554b8977d5f60a288935ce5fad384a1281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524901 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640939} .../android_sms_app_setup_controller_impl.cc | 13 +++++++------ .../chromeos/android_sms/android_sms_switches.cc | 3 +++ .../chromeos/android_sms/android_sms_switches.h | 4 ++++ .../chromeos/android_sms/android_sms_urls.cc | 22 ++++++++++++++++------ 4 files changed, 30 insertions(+), 12 deletions(-) commit 35928a46c0e9fe4d7a35a262fb5f64f749e435b8 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Thu Mar 14 21:46:31 2019 +0000 PM: Change graph node lifetime and stop using mojo for local IPC. This change retires the {Frame|Page|Process|System}ResourceCoordinator classes. Instead owners of graph nodes maintain unique_ptrs to them, and communicate via PostTask to the graph. There is now strict lifetime ordering between the PerformanceManager and the graph nodes, all of which have to be destroyed before the PerformanceManager itself is destroyed. A followup CL will retire the mojo interfaces and methods that have been replaced. Bug: 910288 Change-Id: I45fa86f648b79dae688574b8022a213b16ec0d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512301 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640938} chrome/browser/BUILD.gn | 11 --- .../browser_child_process_watcher.cc | 58 +++++++++--- .../browser_child_process_watcher.h | 14 +-- ...tent_browser_client_performance_manager_part.cc | 18 +++- .../frame_resource_coordinator.cc | 82 ----------------- .../frame_resource_coordinator.h | 55 ------------ chrome/browser/performance_manager/graph/README.md | 17 ++++ .../performance_manager/graph/frame_node_impl.cc | 9 +- .../performance_manager/graph/frame_node_impl.h | 2 +- chrome/browser/performance_manager/graph/graph.cc | 57 ++++-------- chrome/browser/performance_manager/graph/graph.h | 32 ++----- .../graph/graph_node_provider_impl.cc | 81 ----------------- .../graph/graph_node_provider_impl.h | 58 ------------ .../graph/graph_test_harness.cc | 3 +- .../performance_manager/graph/graph_test_harness.h | 62 ++++++++++--- .../performance_manager/graph/graph_unittest.cc | 53 +++-------- .../browser/performance_manager/graph/node_base.cc | 14 --- .../browser/performance_manager/graph/node_base.h | 14 +-- .../graph/node_base_unittest.cc | 1 - .../performance_manager/graph/page_node_impl.cc | 11 ++- .../performance_manager/graph/page_node_impl.h | 4 +- .../performance_manager/graph/process_node_impl.cc | 5 +- .../performance_manager/graph/system_node_impl.cc | 4 +- .../page_resource_coordinator.cc | 100 --------------------- .../page_resource_coordinator.h | 56 ------------ .../performance_manager/performance_manager.cc | 41 ++++++++- .../performance_manager/performance_manager.h | 36 +++++++- .../performance_manager_tab_helper.cc | 87 +++++++++++++----- .../performance_manager_tab_helper.h | 17 ++-- .../performance_manager_unittest.cc | 100 +++++---------------- .../process_resource_coordinator.cc | 63 ------------- .../process_resource_coordinator.h | 47 ---------- .../render_process_user_data.cc | 38 ++++++-- .../performance_manager/render_process_user_data.h | 12 +-- .../resource_coordinator_interface.h | 70 --------------- .../system_resource_coordinator.cc | 34 ------- .../system_resource_coordinator.h | 34 ------- ...rowser_main_extra_parts_resource_coordinator.cc | 1 - 38 files changed, 401 insertions(+), 1000 deletions(-) commit 7338b86fd1bee62ca503e90f69d974ee8e187fff Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 14 21:44:19 2019 +0000 [code coverage] move linux-chromeos-code-coverage to chromium.fyi This was created in the wrong waterfall by mistake. NOTRY=true TBR=liaoyuke,bpastene Change-Id: Ib58bc027fc79bd4bd444ba29ef019fd258aa3bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525053 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#640937} testing/buildbot/chromium.chromiumos.json | 700 ------------------------------ testing/buildbot/chromium.fyi.json | 700 ++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 16 +- 3 files changed, 708 insertions(+), 708 deletions(-) commit edaf3b880a7e338f06321b2d3977e41ee55a6aa6 Author: Matt Menke <mmenke@chromium.org> Date: Thu Mar 14 21:39:44 2019 +0000 Fix crash in SpdyStream::SetPriority. When a ConnectJob is assigned to a request in the socket pool, there is often some reassignment of ConnectJobs to stream requests. This can result in reprioritizing ConnectJobs. If one of those ConnectJobs was using a SpdyProxyClientSocket that is using a torn down SpdySession, trying to change its priority would result in a null dereference. This CL makes reprioritizing SpdyProxyClientSockets and QuicProxyClientSockets do nothing, as the reprioritizations in this stage are often superfluous, and doesn't really get us much in either case. In followup CLs, I both want to remove the unnecessary reprioritizations and use a fixed priority of all H2/QUIC tunnels. Bug: 940848 Change-Id: I7c646b1bfcb18977dc2837c73f7b05172d6f908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521279 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#640936} net/http/http_proxy_connect_job_unittest.cc | 5 +- net/quic/quic_network_transaction_unittest.cc | 66 ++++++ net/quic/quic_proxy_client_socket.cc | 10 +- net/quic/quic_proxy_client_socket_unittest.cc | 4 +- .../transport_client_socket_pool_unittest.cc | 255 +++++++++++++++++++++ net/spdy/spdy_proxy_client_socket.cc | 10 +- net/spdy/spdy_proxy_client_socket_unittest.cc | 8 +- net/spdy/spdy_test_util_common.cc | 3 +- 8 files changed, 348 insertions(+), 13 deletions(-) commit d7a6f417f2e12fca309f942797c15a44d224f27f Author: Dan Beam <dbeam@chromium.org> Date: Thu Mar 14 21:33:03 2019 +0000 WebUI Dark Mode: update guest NTP Screenshot: https://imgur.com/a/D9Y8VjF Note: Guest NTP differs from many other webui pages. * It overrides request handling to use NTPResourceCache, which has a separate way of doing i18n/loadTimeData, and caches a pre-built string of page content/CSS. It also tracks inputs that might affect that cache and invalidates. * In order to resolve $i18n{} messages (i.e. $i18n{dark}) like other webui pages, it'd have to go to the I/O thread to block, which breaks a few assumptions about NTPResourceCache's synchronously returning a string on the UI thread. * It uses URLDataSource instead of WebUIDataSource, which doesn't let you update it after being created (i.e. to update whether dark mode has changed to have the right default when refreshing the page after system dark mode is flipped). * It doesn't use loadTimeData and if it did, it doesn't set loadTimeData.data_ (as currently written), which throws if you trying to call overrideValues() (which dark_mode.js does). ^ These are probably all worth changing or fixing, but not with the possibility of a merge to 74 (we'll see if that happens). R=dpapad@chromium.org BUG=930269 Change-Id: I259d0b7e5e9c7664336451fa06c843cd4c17a077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519930 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640935} chrome/browser/resources/ntp4/guest_tab.html | 2 +- .../resources/ntp4/incognito_and_guest_tab.css | 12 +++++++++--- chrome/browser/ui/webui/ntp/new_tab_ui.cc | 21 ++++++++++++++++++++- chrome/browser/ui/webui/ntp/new_tab_ui.h | 6 +++++- 4 files changed, 35 insertions(+), 6 deletions(-) commit 872b28eb24c54a404d6151aa47b08e24bed69a85 Author: Joshua Seaton <joshuaseaton@google.com> Date: Thu Mar 14 21:31:29 2019 +0000 [fuchsia] Create manifest of debug symbol archives. Change-Id: I7fb9e9873e4133f62785ca1b0e977e2bc3a26697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524705 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Joshua Seaton <joshuaseaton@google.com> Cr-Commit-Position: refs/heads/master@{#640934} fuchsia/BUILD.gn | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) Updated tag 'tree_truth' (was 068c097d2528)