Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 39335 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918951422369006928 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itMEof_I/luci_context.221099919 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: trusty-webrtc-d2a17ac3-us-central1-b-t6k2 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43984efb1bbf1011 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: a75df8ee6e26020c55ffa6108d6c40514ee7c6f5 Update V8 to version 7.5.47. v8-ci-autoroll-builder, Fri Mar 15 03:23:28 2019 +0000 9b9fae0f892483e685ba43406cc5fd042d1d7320 Change navigator.gpu.getAdapter to navigator.gpu.requestAdapter. Austin Eng, Fri Mar 15 03:16:07 2019 +0000 e0245949b9cf07609ab922480585b2f1ddb4e1e3 Updating trunk VERSION from 3734.0 to 3735.0 chrome-release-bot, Fri Mar 15 03:13:37 2019 +0000 67eee7cfb86d4cdf9d6e074d8f20189eadfd3d91 Update Swarming dimensions of Linux Intel HD 630 Experimental bot. Kenneth Russell, Fri Mar 15 03:08:14 2019 +0000 6012d3cb4069456e3e72b09b2b4a55559c43d05c Settings WebUI: Remove double border in font subpage. dpapad, Fri Mar 15 03:02:24 2019 +0000 01e38032e30184e8e6c4669315d89e420ea9b5b6 NS: fix test filter syntax Nate Fischer, Fri Mar 15 03:00:42 2019 +0000 9c719d1d65362fb85c90bb11719f513d44a35255 Disable flaky tests in UserActivityManagerTest and WindowActivityWatcherTest Paul Dyson, Fri Mar 15 02:59:12 2019 +0000 fa3c60680c891176c2c3342fbabed75e23f745a2 Only delete WPR if it is not used by other stories Sergiy Belozorov, Fri Mar 15 02:55:32 2019 +0000 5d85114cbc8ab79b7f88a74220503e05081475e9 [VK] Remove some old features and flags. Darren Shen, Fri Mar 15 02:55:13 2019 +0000 5428f7c6e1aaa7d3457e0954e21382495ac31e0c Add an App Service icon cache Nigel Tao, Fri Mar 15 02:51:55 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit a75df8ee6e26020c55ffa6108d6c40514ee7c6f5 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 03:23:28 2019 +0000 Update V8 to version 7.5.47. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f6dd8f7..e6ea6c00 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3463a17314e1fb321c7e4dbf291835f810d3e463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525448 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641062} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b9fae0f892483e685ba43406cc5fd042d1d7320 Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 03:16:07 2019 +0000 Change navigator.gpu.getAdapter to navigator.gpu.requestAdapter. This function now returns a Promise instead of getting an adapter synchronously. GPUAdapterDescriptor is renamed to GPURequestAdapterOptions. Bug: 941531 Change-Id: If8a996fe15adc6301f7378ce15f084cba1ae2601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521235 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641061} third_party/blink/renderer/modules/modules_idl_files.gni | 2 +- third_party/blink/renderer/modules/webgpu/gpu.cc | 15 ++++++++++++--- third_party/blink/renderer/modules/webgpu/gpu.h | 9 ++++++--- third_party/blink/renderer/modules/webgpu/gpu.idl | 5 ++++- ...ter_descriptor.idl => gpu_request_adapter_options.idl} | 5 ++--- 5 files changed, 25 insertions(+), 11 deletions(-) commit e0245949b9cf07609ab922480585b2f1ddb4e1e3 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Fri Mar 15 03:13:37 2019 +0000 Updating trunk VERSION from 3734.0 to 3735.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib942d816a32db8edc45e5206cc8acea8fc3842a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525414 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641060} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 67eee7cfb86d4cdf9d6e074d8f20189eadfd3d91 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Mar 15 03:08:14 2019 +0000 Update Swarming dimensions of Linux Intel HD 630 Experimental bot. It's been upgraded to Mesa 18.3.3 from 18.0.5. Bug: 928530 Change-Id: I2cebf3cfe028ed4e3108b021fc5277c818b66943 Tbr: sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525407 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641059} testing/buildbot/chromium.gpu.fyi.json | 34 +++++++++++++++++----------------- testing/buildbot/mixins.pyl | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) commit 6012d3cb4069456e3e72b09b2b4a55559c43d05c Author: dpapad <dpapad@chromium.org> Date: Fri Mar 15 03:02:24 2019 +0000 Settings WebUI: Remove double border in font subpage. Before/after screenshots: https://imgur.com/a/0NpIjAz Bug: None Change-Id: I0a8db2d980ae58c489e4375e2d83505eabc424b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524715 Reviewed-by: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641058} .../resources/settings/appearance_page/appearance_fonts_page.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 01e38032e30184e8e6c4669315d89e420ea9b5b6 Author: Nate Fischer <ntfschr@chromium.org> Date: Fri Mar 15 03:00:42 2019 +0000 NS: fix test filter syntax I added some tests to the filter in http://crrev/c/1522556. I forgot that "#" is illegal, and I should use "." instead. TBR=timvolodine@chromium.org Bug: 941856, 941858 Test: N/A Change-Id: I153abf26f9098460e2e9f2a6454978ae3682c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525413 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641057} .../buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9c719d1d65362fb85c90bb11719f513d44a35255 Author: Paul Dyson <pdyson@chromium.org> Date: Fri Mar 15 02:59:12 2019 +0000 Disable flaky tests in UserActivityManagerTest and WindowActivityWatcherTest Disable UserActivityManagerTest.BasicTabs as it has been flagged as flaky. Also disable WindowActivityWatcherTest.Basic and WindowActivityWatcherTest.ReplaceTab which sometimes fail at the same time as UserActivityManagerTest.BasicTabs. Bug: 938055 Change-Id: Ib8c8ce28e565cd032a5d1255a6e355a449679e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504474 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641056} chrome/browser/chromeos/power/ml/user_activity_manager_unittest.cc | 3 ++- chrome/browser/ui/tabs/window_activity_watcher_unittest.cc | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) commit fa3c60680c891176c2c3342fbabed75e23f745a2 Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Fri Mar 15 02:55:32 2019 +0000 Only delete WPR if it is not used by other stories R=perezju@chromium.org Bug: 895891 Change-Id: I2f363662f6f9ce4da0c6c76674db94c0404fa21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523093 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641055} tools/perf/cli_tools/update_wpr/update_wpr.py | 20 ++++++++++++++------ .../perf/cli_tools/update_wpr/update_wpr_unittest.py | 10 +++++++++- 2 files changed, 23 insertions(+), 7 deletions(-) commit 5d85114cbc8ab79b7f88a74220503e05081475e9 Author: Darren Shen <shend@chromium.org> Date: Fri Mar 15 02:55:13 2019 +0000 [VK] Remove some old features and flags. Change-Id: I3a21355822ad2c8e4b59c542471e280b656e6500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520859 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#641054} chrome/browser/about_flags.cc | 13 ------------- .../extensions/api/input_ime/input_ime_api_chromeos.cc | 3 +-- .../chrome_virtual_keyboard_delegate.cc | 5 +---- chrome/browser/flag_descriptions.cc | 16 ---------------- chrome/browser/flag_descriptions.h | 9 --------- ui/base/ui_base_features.cc | 11 ----------- ui/base/ui_base_features.h | 6 ------ ui/keyboard/keyboard_ukm_recorder.cc | 4 +--- ui/keyboard/keyboard_ukm_recorder_unittest.cc | 8 -------- 9 files changed, 3 insertions(+), 72 deletions(-) commit 5428f7c6e1aaa7d3457e0954e21382495ac31e0c Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 02:51:55 2019 +0000 Add an App Service icon cache BUG=826982 Change-Id: Id697f87ffb5dc143caea60fc02fd91133cb60938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522869 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641053} chrome/browser/BUILD.gn | 1 + .../browser/apps/app_service/app_service_proxy.cc | 42 ++-- .../browser/apps/app_service/app_service_proxy.h | 20 +- chrome/services/app_service/public/cpp/BUILD.gn | 14 ++ .../services/app_service/public/cpp/icon_cache.cc | 155 +++++++++++++++ .../services/app_service/public/cpp/icon_cache.h | 116 +++++++++++ .../app_service/public/cpp/icon_cache_unittest.cc | 212 +++++++++++++++++++++ .../services/app_service/public/cpp/icon_loader.cc | 66 +++++++ .../services/app_service/public/cpp/icon_loader.h | 99 ++++++++++ .../services/app_service/public/mojom/types.mojom | 3 + 10 files changed, 701 insertions(+), 27 deletions(-) commit 5618e8eadac015c2411429fe1775ec882810ddcc Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Mar 15 02:49:05 2019 +0000 [Audio Focus] Return id from request audio focus Return the ID from RequestAudioFocus which the media session can then be used to identify itself. This is for assistant so they can differentiate between the AssistantMediaSession and other sessions when controlling them. BUG=941578 Change-Id: Ie114c36b111e79125c918b9964196b3434d1294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521472 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641052} .../media_session/assistant_media_session.cc | 8 +- .../media_session/assistant_media_session.h | 2 + .../media/session/audio_focus_delegate_default.cc | 13 +++- services/media_session/audio_focus_manager.cc | 33 ++++----- services/media_session/audio_focus_manager.h | 3 +- .../media_session/audio_focus_manager_unittest.cc | 2 +- .../media_session/media_controller_unittest.cc | 13 +++- .../public/cpp/test/mock_media_session.cc | 86 +++++++++++----------- .../public/cpp/test/mock_media_session.h | 8 +- .../media_session/public/mojom/audio_focus.mojom | 15 ++-- 10 files changed, 101 insertions(+), 82 deletions(-) commit 0fcaa3b3fca2d10171f5bd2423b5a2ad55debada Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 02:47:01 2019 +0000 Convert ui::PlatformEventWaiter::PlatformEventMatcher and Related Code to base::RepeatingCallback BUG=714018,940130 TBR=sky@chromium.org Change-Id: I2dcacc52febbe0aeb72e90fe390239d1cb9ac201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525481 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641051} ui/aura/test/ui_controls_factory_aurax11.cc | 3 ++- ui/events/test/platform_event_waiter.cc | 14 ++++++++------ ui/events/test/platform_event_waiter.h | 7 ++++--- ui/views/test/ui_controls_factory_desktop_aurax11.cc | 3 ++- 4 files changed, 16 insertions(+), 11 deletions(-) commit 3e4613d9e2e704b6dcaaa362b7b6a355fd03b4ab Author: Yupei Lin <yplam@yplam.com> Date: Fri Mar 15 02:46:22 2019 +0000 Fix gdb viewg command While following the steps from docs/graphical_debugging_aid_chromium_views.md using gdb. Change-Id: Ic4d2193c29604bc548bdb6c84e8f0f70684366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522560 Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641050} AUTHORS | 1 + tools/gdb/viewg.gdb | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) commit 8c30e8ce823191ef55a548420df7e290a95d4cbc Author: Shu Chen <shuchen@google.com> Date: Fri Mar 15 02:45:12 2019 +0000 Move the mojom & typemap for ui::TextInputType to ui/base/ime/mojo. Currently the mojom for ui::TextInputType is under ui/platform_window/mojo, and the typemap is under services/ws/public/mojom/ime. It will cause problem if some other code wants to use ui.mojom.TextInputType. ui::TextInputType is defined under ui/base/ime, where the mojom and typemap should be. Bug: 937167 Change-Id: Ie62a49e7d9f0be5d8f6b9038b581543b8d9ca0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517339 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641049} content/common/render_widget_host_ns_view.mojom | 1 + .../bindings/chromium_bindings_configuration.gni | 5 +- services/ws/public/mojom/BUILD.gn | 2 +- services/ws/public/mojom/ime/BUILD.gn | 12 +- services/ws/public/mojom/ime/ime.mojom | 16 +-- services/ws/public/mojom/ime/ime.typemap | 2 - services/ws/public/mojom/ime/ime_struct_traits.cc | 129 ------------------- services/ws/public/mojom/ime/ime_struct_traits.h | 12 -- .../public/mojom/ime/ime_struct_traits_unittest.cc | 71 +---------- ui/aura/mus/input_method_mus.cc | 2 +- ui/base/BUILD.gn | 6 +- ui/base/ime/DEPS | 1 + ui/base/ime/mojo/BUILD.gn | 21 ++++ ui/base/ime/mojo/OWNERS | 8 ++ .../base/ime/mojo}/ime_struct_traits_test.mojom | 7 +- ui/base/ime/mojo/ime_struct_traits_unittest.cc | 96 ++++++++++++++ ui/base/ime/mojo/ime_types.mojom | 56 +++++++++ ui/base/ime/mojo/ime_types.typemap | 21 ++++ ui/base/ime/mojo/ime_types_struct_traits.cc | 138 +++++++++++++++++++++ ui/base/ime/mojo/ime_types_struct_traits.h | 30 +++++ ui/base/ime/mojo/typemaps.gni | 5 + ui/platform_window/mojo/BUILD.gn | 6 +- ui/platform_window/mojo/ime_type_converters.cc | 14 --- ui/platform_window/mojo/ime_type_converters.h | 12 -- ui/platform_window/mojo/text_input_state.mojom | 38 +----- 25 files changed, 400 insertions(+), 311 deletions(-) commit 752a1561485e8ed8d0dc38335a5a9a6058753762 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 02:42:02 2019 +0000 Roll src/third_party/swiftshader a2749f39f47d..9b156615197d (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/a2749f39f47d..9b156615197d git log a2749f39f47d..9b156615197d --date=short --no-merges --format='%ad %ae %s' 2019-03-14 bclayton@google.com SpirvShader: Split instructions into blocks. 2019-03-14 capn@google.com Fix allocation of low-alignment memory Created with: gclient setdep -r src/third_party/swiftshader@9b156615197d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5385d7628f5985a5085977d08495951d0c8569a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525034 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641048} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 95c1f858b14bbf3d619c1ce0ca0630603535233c Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri Mar 15 02:40:11 2019 +0000 [layoutng] Inline a couple more geometry functions Change-Id: I9c0c299f8aa576ea34f357ac88c2c79c0a50fb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1315669 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641047} third_party/blink/renderer/core/layout/BUILD.gn | 1 - .../core/layout/ng/geometry/ng_border_edges.cc | 36 --------------- .../core/layout/ng/geometry/ng_border_edges.h | 27 ++++++++++- .../core/layout/ng/geometry/ng_box_strut.cc | 50 -------------------- .../core/layout/ng/geometry/ng_box_strut.h | 54 +++++++++++++++++++++- 5 files changed, 77 insertions(+), 91 deletions(-) commit 6130949eaaf724cec6c90b2b54515b9e3dfe81e1 Author: Qingsi Wang <qingsi@chromium.org> Date: Fri Mar 15 02:27:48 2019 +0000 Move the getUserMedia gating of mDNS protection to FilteringNetworkManager. Our previous implementation would destroy the connection to the mDNS responder service host when the media capture permission is granted. As a result, any mDNS candidate created before the grant would become unresolvable. This issue is particularly evident when we have multiple peer connections of the same origin, where a newly created peer connection would temporarily toggle the permission to blocked before restoring the granted status if the user did give the permission. This could cause a peer connection created earlier and in the process of ICE candidate gathering to perform unnecessary mDNS obfuscation. After this change, the connection to the mDNS responder service host keeps alive, but just becomes unavailable for registration of new names when we have permissions granted. Bug: 930339, 937992 Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641046} .../webrtc/peer_connection_dependency_factory.cc | 49 +++++++--------------- .../webrtc/peer_connection_dependency_factory.h | 12 ++---- content/renderer/p2p/filtering_network_manager.cc | 30 +++++++------ content/renderer/p2p/filtering_network_manager.h | 13 +----- .../p2p/filtering_network_manager_unittest.cc | 4 +- content/renderer/p2p/ipc_network_manager.cc | 18 ++++---- content/renderer/p2p/ipc_network_manager.h | 6 +-- .../renderer/p2p/ipc_network_manager_unittest.cc | 3 +- 8 files changed, 49 insertions(+), 86 deletions(-) commit 609b4bbd7be1c7620c78a184a276d566f1e05a10 Author: Ben Hayden <benjhayden@chromium.org> Date: Fri Mar 15 02:27:02 2019 +0000 Reland Batch Histogram uploads. Some benchmarks such as rendering.mobile produce more data than the chromeperf dashboard can handle at once. This CL passes the new --max_bytes flag to add_reserved_diagnostics to batch histograms into multiple files, then uploads them one at a time. Initial CL: https://chromium-review.googlesource.com/c/1478085 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1486679 Reason for revert: File "...\upload_results_to_perf_dashboard.py", line 61, in _GenerateDashboardJSONs with open(options.output_json_file, 'w') as f: TypeError: coercing to Unicode: need string or buffer, file found Patchset 1 is the initial CL. Patchset 5 simplifies the initial approach and adds a test. Bug: chromium:909961 Change-Id: Ia66cff24531333ecea386785ccbae04e7386f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515649 Commit-Queue: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#641045} tools/perf/core/results_dashboard.py | 36 ++--- .../perf/core/upload_results_to_perf_dashboard.py | 72 +++++++--- tools/perf/process_perf_results.py | 149 +++++++++++---------- tools/perf/process_perf_results_unittest.py | 58 +++++++- 4 files changed, 202 insertions(+), 113 deletions(-) commit bfb994e1a78fd93a6adfacec2bb1fd665b4b58af Author: Siye Liu <siliu@microsoft.com> Date: Fri Mar 15 02:26:41 2019 +0000 Append block element that only contains br element onto clipboard during copy if the block element is at selection end. This patch adds a logic in blink::StyledMarkupSerializer<Strategy>::CreateMarkup and blink::StyledMarkupTraverser<Strategy>::Traverse so that the empty block element that only contains br element can be appended to blink::StyledMarkupAccumulator if the block element is at the end of selection during copy. The logic helps in creating the right markup to put onto clipboard during serialization. For example, <i>some text</i><p><br></p>, select all and copy, clipboard content should be look like: <!--startFrament--><i>some text</i></font><p><br></p><!--EndFragment--> Bug: 856324 Change-Id: Idd55bde473d4e6b3d7bf06b62167dd227ae65672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495371 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641044} .../serializers/styled_markup_serializer.cc | 28 ++++++- ...ste-blockquote-and-paragraph-break-expected.txt | 45 ---------- .../paste-blockquote-and-paragraph-break.html | 61 ++++++-------- .../editing/pasteboard/paste-text-016.html | 93 ++++++++++----------- ...ine-break-at-end-of-pasted-content-expected.txt | 18 ---- ...eserve-line-break-at-end-of-pasted-content.html | 53 ++++++------ .../editing/pasteboard/paste-text-016-expected.png | Bin 19984 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- .../editing/pasteboard/paste-text-016-expected.png | Bin 6555 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- .../editing/pasteboard/paste-text-016-expected.png | Bin 6439 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- 12 files changed, 124 insertions(+), 351 deletions(-) commit 457193040c9cb74b8eb7d524bbec073385a47758 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Mar 15 02:23:28 2019 +0000 Fix search widget location bar color not correct We simplified the location bar text color logic to be mostly based on the primary color at https://chromium-review.googlesource.com/c/chromium/src/+/1489416. This becomes an issue for the search widget because the primary color was transparent all the time. Bug: 940897 Change-Id: I16db7596d9a0db0ee277a106b5b890be2045e391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525286 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641043} chrome/android/java/res/layout/search_activity.xml | 2 +- .../chrome/browser/searchwidget/SearchActivity.java | 2 +- .../chrome/browser/searchwidget/SearchBoxDataProvider.java | 13 ++++++++++++- 3 files changed, 14 insertions(+), 3 deletions(-) commit 76e3f160394df9e89d62be3a85ca5a2fd68b25db Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Mar 15 02:22:48 2019 +0000 Roll src/ios/third_party/edo/src/ 0146bd6e1..57586e721 (1 commit) https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/0146bd6e1f05..57586e721389 $ git log 0146bd6e1..57586e721 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 haowoo Move the block from the stack to the heap before assigning it to the weak pointer. Created with: roll-dep src/ios/third_party/edo/src BUG=941680 Change-Id: Id616069d5894a535839547169669d49b02648e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524653 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641042} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 44a2f14903cae5f66435ffb42635089453721c04 Author: Peter Boström <pbos@chromium.org> Date: Fri Mar 15 02:21:48 2019 +0000 Remove custom InkDrop logic from NewTabButton This change removes InkDropContainerView usage and overrides of: * AddInkDropLayer * RemoveInkDropLayer * CreateInkDrop * CreateInkDropRipple * CreateInkDropHighlight * CreateInkDropMask ... and replaces them with a HighlightPath already in use by the FocusRing. Bug: None Change-Id: Id347f19d32f8b38443092eedd6604c71c5d9e6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525462 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#641041} chrome/browser/ui/views/tabs/new_tab_button.cc | 71 +++----------------------- chrome/browser/ui/views/tabs/new_tab_button.h | 19 +------ chrome/browser/ui/views/tabs/tab_strip.cc | 5 +- 3 files changed, 11 insertions(+), 84 deletions(-) commit 068025b22e63bdca62076e5752936b5a73e6a5e0 Author: John Z Wu <jzw@chromium.org> Date: Fri Mar 15 02:19:27 2019 +0000 Fix shutdown crash related to WebViewRequestContextGetter. Several member variables of WebViewRequestContextGetter may attempt to access net::NetLog during destruction, but since the latter gets destructed *after* the former, it can easily lead to dangling pointer issues. The fix is to just ensure those member variables are destroyed before net::NetLog so they can still access it safely. Alternatively, we can also just reorder the member variable list. Change-Id: I768f235fc8f62835fdcab603b254a87620ab046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525446 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#641040} ios/web_view/internal/web_view_url_request_context_getter.mm | 7 +++++++ 1 file changed, 7 insertions(+) commit d21fb154db5a3f55413c07d616d13baecac1abe1 Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 02:17:33 2019 +0000 Recreate golden file loader for the time limit consistency tests, after last one was reverted. This time, a separated test binary is used to avoid dependency clashes between protobuf libs. Bug: 935711 Change-Id: I0789418f3a2c6c959845a1926f21832dcd0c389d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515206 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641039} BUILD.gn | 1 + .../consistency_golden_loader.cc | 71 ++++++++++++++ .../consistency_golden_loader.h | 41 ++++++++ .../consistency_golden_loader_unittest.cc | 47 +++++++++ .../goldens/consistency_golden.proto | 108 +++++++++++++++++++++ .../time_limit_consistency_test/proto_matcher.h | 43 ++++++++ .../run_all_unittests.cc | 15 +++ .../test_goldens/test_golden.textproto | 6 ++ .../test_goldens/test_golden_unsupported.textproto | 6 ++ chrome/test/BUILD.gn | 42 ++++++++ testing/buildbot/chromium.chromiumos.json | 14 +++ testing/buildbot/chromium.fyi.json | 7 ++ testing/buildbot/chromium.memory.json | 26 +++++ testing/buildbot/gn_isolate_map.pyl | 4 + testing/buildbot/test_suites.pyl | 3 + third_party/protobuf/BUILD.gn | 8 +- 16 files changed, 441 insertions(+), 1 deletion(-) commit 44aa7404976050b14858e6a5877c1880816dc776 Author: Ken Rockot <rockot@chromium.org> Date: Fri Mar 15 02:16:33 2019 +0000 [mojo-js] Correct compiled JS exports We were missing some goog.provide directives for generated interface types. This also removes usage of mojo.internal.exportModule when we're generating goog.provide, since only one of the two is necessary. Bug: 939680 Change-Id: I1f813fe9cebb3cac6b68c2e86cff650fcf51ed21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524331 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#641038} .../generators/js_templates/lite/interface_definition.tmpl | 12 ++++++++---- .../bindings/generators/js_templates/lite/mojom-lite.js.tmpl | 4 ++-- 2 files changed, 10 insertions(+), 6 deletions(-) commit a576e34ca7ceb3a511cd8a9aa6f478354e71ab8d Author: Leon Han <leon.han@intel.com> Date: Fri Mar 15 02:16:25 2019 +0000 [ServiceWorker] All provider hosts are owned by context core from birth A provider host on creation is always added into ServiceWorkerContextCore and owned there, later it'll destroy either when ServiceWorkerContextCore destroys or the Mojo connection it's bound breaks. This CL refactors code to strengthen the logic above. BUG=931092 Change-Id: I8feaebec0e1c539ad5e24bde3af7518e2f81aa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522559 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641037} .../service_worker/service_worker_provider_host.cc | 34 +++++++++------------- .../service_worker/service_worker_provider_host.h | 4 +++ 2 files changed, 18 insertions(+), 20 deletions(-) commit 151b8b48a472342ba37786fd42b2c9b007bc8a52 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Mar 15 02:14:52 2019 +0000 [Dark] Contextual search dark support + bar background to grey 900 + 6% white in dark mode + promo background to grey 100 in light, grey 900 to dark + icon colors for close button and arrow button Bug: 934580 Change-Id: I35ed4db9ba156c92223e4e2aa9f48c22e1e2a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521770 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641036} .../res/layout/contextual_search_term_view.xml | 2 +- .../java/res/layout/ephemeral_tab_text_view.xml | 2 +- chrome/android/java/res/values-v17/styles.xml | 4 +-- chrome/android/java/res/values/colors.xml | 7 ++-- chrome/android/java/res_night/OWNERS | 9 +++++ .../android/java/res_night/values-night/colors.xml | 1 - .../compositor/bottombar/OverlayPanelBase.java | 27 +++++++++++++++ .../scene_layer/ContextualSearchSceneLayer.java | 40 ++++++++++++---------- .../scene_layer/EphemeralTabSceneLayer.java | 16 +++++---- .../compositor/layer/contextual_search_layer.cc | 18 ++++++---- .../compositor/layer/contextual_search_layer.h | 2 ++ .../compositor/layer/ephemeral_tab_layer.cc | 8 +++-- .../android/compositor/layer/ephemeral_tab_layer.h | 2 ++ .../compositor/layer/overlay_panel_layer.cc | 9 +++-- .../android/compositor/layer/overlay_panel_layer.h | 2 ++ .../scene_layer/contextual_search_scene_layer.cc | 34 ++++++++++-------- .../scene_layer/contextual_search_scene_layer.h | 2 ++ .../scene_layer/ephemeral_tab_scene_layer.cc | 9 +++-- .../scene_layer/ephemeral_tab_scene_layer.h | 2 ++ ui/android/java/res/values/color_palette.xml | 13 +++++++ ui/android/java/res/values/colors.xml | 17 ++++++++- ui/android/java/res_night/OWNERS | 9 +++++ ui/android/java/res_night/values-night/colors.xml | 6 +++- 23 files changed, 177 insertions(+), 64 deletions(-) commit cd746d79aba30cebb6525a0312f3c309c4b58628 Author: Leon Han <leon.han@intel.com> Date: Fri Mar 15 02:14:21 2019 +0000 [ServiceWorker] Make provider id be non-negative int Previously the browser-assigned provider id was a negative int going down from -2, to differentiate from the renderer-assigned provider id which has non-negative value. Now the renderer-assigned provider id has gone away with https://crrev.com/c/1520688 and we just have all provider ids created in the browser process, so we can make it be non-negative to be more like of an ID. BUG=931092 Change-Id: Icdc9933cc04e13c823e0a733d963f1f4411abf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522557 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641035} .../browser/service_worker/service_worker_context_unittest.cc | 10 +++++----- content/browser/service_worker/service_worker_provider_host.cc | 7 +++---- 2 files changed, 8 insertions(+), 9 deletions(-) commit 8f30a2e75761511431980d03a5a7db1c165ff968 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 02:13:03 2019 +0000 Roll Fuchsia SDK from ddcb12bc41ac to 1a0b0112a4d8 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If46e19cad054575896ac34ed44f96efc4460c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525348 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641034} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 31e0a7112702537088afc8781b76e0b9e479c91f Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Mar 15 01:54:03 2019 +0000 DNR: Support loading/re-indexing multiple rulesets in FileSequenceHelper. This adds support for loading/re-indexing multiple rulesets in FileSequenceHelper. No behavior changes are made in this CL. This is in preparation of adding support for dynamic rules and possibly multiple static rulesets. BUG=930961 Change-Id: I13c99a3e5a89f7615317a04e08ecd5fc52464a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519548 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641033} extensions/browser/BUILD.gn | 1 + .../file_sequence_helper.cc | 186 ++++++++++++++------ .../declarative_net_request/file_sequence_helper.h | 29 ++-- .../file_sequence_helper_unittest.cc | 189 +++++++++++++++++++++ .../rules_monitor_service.cc | 45 ++--- .../data_decoder/public/cpp/testing_json_parser.cc | 6 +- 6 files changed, 369 insertions(+), 87 deletions(-) commit 56d7a4891c5d2b977223e47f1d5b74772df8de0a Author: Alex Danilo <adanilo@chromium.org> Date: Fri Mar 15 01:49:44 2019 +0000 Remove tooltip from Open in quickview. The Open button in the quickview panel was changed from an icon to text to match the main FilesApp panel. This change removes the tooltip, since it's redundant. Bug: 941956 Change-Id: I1cd38e8787a56fe9a8647a5793314dbfcb1866fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525248 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641032} ui/file_manager/file_manager/foreground/elements/files_quick_view.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 78128d88ba9d52844d344a677c2eb84b12e9a585 Author: Vladislav Kaznacheev <kaznacheev@chromium.org> Date: Fri Mar 15 01:49:23 2019 +0000 Revert "app_list: Set AppList as parent of uninstall dialog" This reverts commit fb08feb52da0cfd813ff9f409d620aa59371601f. Reason for revert: caused a crash (http://crbug.com/939667) Original change's description: > app_list: Set AppList as parent of uninstall dialog > > Currently, when the uninstall dialog is opened from the Launcher, the Launcher > is dismissed, which is confusing to the user. By parenting the dialog to the > Launcher, the UX is much better. > > Because we cannot directly access Ash windows anymore, this fix requires us to > explicitly set the dialog's parent window via MUS properties. > > TEST=manually verified + new browser tests > BUG=814619 > > Change-Id: Ic25cb376191aaba8048f95fa5d0032b0328b8bc8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496447 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638016} TBR=xiyuan@chromium.org,tengs@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814619 Change-Id: I7dd1c47d2edfc19fddd4302ae0b7fb1e42d835ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525273 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#641031} ash/public/interfaces/shell_test_api.test-mojom | 4 -- ash/shell_test_api.cc | 11 ---- ash/shell_test_api.h | 3 - .../extensions/extension_uninstall_dialog.cc | 1 - .../extensions/extension_uninstall_dialog.h | 3 - .../extensions/extension_uninstall_dialog_view.cc | 30 --------- .../extension_uninstall_dialog_view_browsertest.cc | 76 ---------------------- 7 files changed, 128 deletions(-) commit 37608a45ad317e3932b5aabe6fa32f8d2a114456 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Fri Mar 15 01:37:40 2019 +0000 Make HomeScreenController control home screen visibility Make HomeScreenController responsible for determining home screen visibility instead of AppListControllerImpl, including updates based on window dragging and wallpaper preview. The app list controller now implements HomeScreenDelegate::ShowHomeScreen() to show the full-screen app list window. Also adds IsHomeScreenAvailable() which should be used to determine whether to use the home screen instead of checking tablet mode directly. Bug: 937549 Change-Id: If864614e7dcc4a818dc5368cf5e68e9475afacb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504847 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641030} ash/app_list/app_list_controller_impl.cc | 57 ++++-------------- ash/app_list/app_list_controller_impl.h | 26 +-------- ash/home_screen/home_screen_controller.cc | 68 +++++++++++++++++++++- ash/home_screen/home_screen_controller.h | 37 +++++++++++- ash/home_screen/home_screen_delegate.h | 12 ++++ ash/shelf/app_list_button.cc | 21 ++++--- .../tablet_mode_browser_window_drag_delegate.cc | 8 +-- 7 files changed, 144 insertions(+), 85 deletions(-) commit 464770194eb7074a04e8d977f9d5207def329650 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Mar 15 01:36:40 2019 +0000 [Files app] Fix gruped partitions format menu Fix directory tree context menu for removable partitions when they're grouped with a common root, where the "format" option wasn't shown. Directory tree has 2 context menus root and non-root menus, when partitions are grouped it's using a non-root menu which didn't have the "format" command. This CL add the "format" command to non-root menu and fix the condition to only display for removable root. Bug: 941174 Change-Id: I27ff6f8e1813f84d76341c6abd4376a0743c14d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522508 Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641029} .../file_manager/foreground/js/file_manager_commands.js | 9 +++++---- ui/file_manager/file_manager/main.html | 1 + .../file_manager/directory_tree_context_menu.js | 1 + 3 files changed, 7 insertions(+), 4 deletions(-) commit 2f207048010835e377a95134c731462a6e664f19 Author: Justin Cohen <justincohen@google.com> Date: Fri Mar 15 01:25:32 2019 +0000 [ios] Rewrite remote session urls on restore for legacy nav too. Followup to http://crrev.com/c/1444011, which corrected remote sessions for slimnav, but not for legacy nav. Bug: 942139 Change-Id: I824bd4f7b45fac99d97ef78f53d84563086775b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525054 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641028} ios/web/navigation/legacy_navigation_manager_impl.mm | 3 +++ 1 file changed, 3 insertions(+) commit e3e7947724ac866479d8432a7055b5f25e16584f Author: Dan Beam <dbeam@chromium.org> Date: Fri Mar 15 01:23:33 2019 +0000 Navi: fix gzip-related crash Based on https://crrev.com/c/1524907 by Hector Carmona <hcarmona@chromium.org> Bug: 941882 Change-Id: Iea5cd2c0bd22bb57eafa6a4d507c93b045e50c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525196 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641027} chrome/browser/ui/webui/welcome/welcome_ui.cc | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) commit 4e362ac4ed51bab4f3eebac378846644249dd96f Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 01:10:09 2019 +0000 Convert LinuxUI::NativeThemeGetter to RepeatingCallback and Update Related Calls BUG=714018,940130 TBR=sky@chromium.org Change-Id: I330f1a83003019ce1af35cf554fb7116e3da5bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525271 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641026} chrome/browser/ui/libgtkui/gtk_ui.cc | 4 ++-- chrome/browser/ui/libgtkui/gtk_ui.h | 5 +---- .../browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc | 2 +- ui/views/linux_ui/linux_ui.h | 6 +++--- 4 files changed, 7 insertions(+), 10 deletions(-) commit 4a2231b919c944b79dbc3cf0da2fd19f315b1c84 Author: John Budorick <jbudorick@chromium.org> Date: Fri Mar 15 01:09:59 2019 +0000 Disable ChromeVoxEditingTest.RichTextMoveByCharacterAllAttributes. Bug: 942241 Change-Id: I39e2bf63413a0bf2b646d465a9f694f411b0b0fb Tbr: akihiroota@chromium.org,dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525006 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641025} .../resources/chromeos/chromevox/cvox2/background/editing_test.extjs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 40727b5f8eb1413cb11a09ae348a0794853095b9 Author: Christian Fremerey <chfremer@chromium.org> Date: Fri Mar 15 01:09:04 2019 +0000 [Video Capture Service, ChromeOS] Run video capture service in browser process Before this CL, the video capture service, on ChromeOS, would run in a separate utility process unless the HAL v3 service was being used. This CL changes this so that on ChromeOS the video capture service always runs in the browser process. This is to mitigate an issue with screen rotation events only being available in the browser process. Bug: 891961 Change-Id: I4764f7cf131fff819e9e0f726d45bb86af09ed9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506604 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641024} .../webrtc/webrtc_video_capture_browsertest.cc | 19 +++++++------------ content/public/common/content_features.cc | 13 ++++--------- 2 files changed, 11 insertions(+), 21 deletions(-) commit d16fde55af5633ac086e9a04b2fe7ee65fd513ab Author: Scott Graham <scottmg@chromium.org> Date: Fri Mar 15 01:08:55 2019 +0000 Reland "Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263" This is a reland of 5b33ce1bbedab114c8657acb8047c0f3150ac0de Original change's description: > Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263 > > 48ee086ca4c4 fuchsia: Update to run crashpad_test as package rather than > from /system > 2271f00fe076 Add missing BUILD.gn for third_party/apple_cf > 3332ae354672 compat: Provide <elf.h> and <mach-o/loader.h> for everyone > 708367f5badf POSIX: ScopedMmap length refinement > 5a21d038c9c9 Work around libcrashpad_handler_trampoline.so ASan trunk > clang problem > c8fdad4fe58f Update DEPS for buildtools and GYP > 2a47ea4663dd Obtain the Fuchsia SDK from the correct (updated) location > 36f9051cafca Enable clang -Wextra-semi in POSIX/Fuchsia clang builds > 348022def8d5 Fuchsia: Proper Fuchsia-on-macOS cross build support > aa160f658175 [fuchsia] Update header include > 1bb8ca4059d8 Silence some warnings > > Change-Id: Ic40aa09f581c5b1339ac7d7c0a50a55f2d15ea99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524084 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Scott Graham <scottmg@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640817} Change-Id: If37cdebfafda6ae1526c665f9362a86b5a59ed68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525281 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#641023} third_party/crashpad/README.chromium | 2 +- third_party/crashpad/crashpad/BUILD.gn | 48 +- third_party/crashpad/crashpad/DEPS | 32 +- third_party/crashpad/crashpad/compat/BUILD.gn | 25 +- third_party/crashpad/crashpad/compat/non_elf/elf.h | 20 + .../crashpad/compat/non_mac/mach-o/loader.h | 20 + .../crashpad/compat/non_mac/mach/machine.h | 21 + .../crashpad/compat/non_mac/mach/vm_prot.h | 20 + .../snapshot/minidump/thread_snapshot_minidump.cc | 4 - .../crashpad/test/fuchsia_crashpad_tests.cmx | 21 + third_party/crashpad/crashpad/test/test_paths.cc | 31 +- .../crashpad/third_party/apple_cf/BUILD.gn | 19 + .../third_party/apple_cf/CFStreamAbstract.h | 17 +- .../crashpad/third_party/apple_cf/README.crashpad | 2 +- .../crashpad/crashpad/third_party/fuchsia/BUILD.gn | 137 +- .../crashpad/crashpad/third_party/glibc/BUILD.gn | 19 + .../crashpad/third_party/glibc/COPYING.LIB | 502 +++ .../crashpad/third_party/glibc/README.crashpad | 16 + .../crashpad/crashpad/third_party/glibc/elf/elf.h | 4003 ++++++++++++++++++++ .../crashpad/third_party/xnu/APPLE_LICENSE | 367 ++ .../crashpad/crashpad/third_party/xnu/BUILD.gn | 19 + .../xnu/EXTERNAL_HEADERS/mach-o/loader.h | 1531 ++++++++ .../crashpad/third_party/xnu/README.crashpad | 19 + third_party/crashpad/crashpad/util/BUILD.gn | 5 +- .../crashpad/util/fuchsia/koid_utilities.cc | 2 +- .../crashpad/crashpad/util/posix/scoped_mmap.cc | 26 +- .../crashpad/crashpad/util/posix/scoped_mmap.h | 5 + .../crashpad/util/posix/scoped_mmap_test.cc | 12 +- tools/licenses.py | 6 + 29 files changed, 6793 insertions(+), 158 deletions(-) commit de7b81d1ca8f98c0666d232092058277ace9e266 Author: Dana Fried <dfried@chromium.org> Date: Fri Mar 15 01:08:00 2019 +0000 Move most of TabStyle into c/b/ui. Because tab thumbnailing logic will be using standard tab size as part of its calculation of how large of a thumbnail to create (to be used in tab hover cards) the core properties of a tab need to be available in c/b/ui rather than just c/b/ui/views. Otherwise, an illegal dependency is created. The updated thumbnailing logic will be added in a later CL. Bug: 928954 Change-Id: Ie51ef3057828a0baad670fd1459df3cb6784651e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519322 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641022} chrome/browser/ui/BUILD.gn | 6 +- chrome/browser/ui/ash/tab_scrubber.cc | 9 ++- chrome/browser/ui/tabs/tab_style.cc | 75 +++++++++++++++++++ chrome/browser/ui/{views => }/tabs/tab_style.h | 67 +++++++++-------- .../browser/ui/views/tabs/glow_hover_controller.cc | 12 ++-- .../browser/ui/views/tabs/glow_hover_controller.h | 12 +--- chrome/browser/ui/views/tabs/tab.cc | 9 +-- chrome/browser/ui/views/tabs/tab.h | 8 +-- .../browser/ui/views/tabs/tab_drag_controller.cc | 2 +- .../ui/views/tabs/tab_hover_card_bubble_view.cc | 2 +- chrome/browser/ui/views/tabs/tab_strip.cc | 10 +-- chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 14 ++-- .../tabs/{tab_style.cc => tab_style_views.cc} | 83 ++++------------------ chrome/browser/ui/views/tabs/tab_style_views.h | 38 ++++++++++ chrome/browser/ui/views/tabs/tab_unittest.cc | 6 +- 15 files changed, 202 insertions(+), 151 deletions(-) commit 3c18a385aebd1e0498231d59c0e269a95678cfb9 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Mar 15 01:07:51 2019 +0000 Add presubmit checks for //buildtools/DEPS entries. Due to limitations in how gclient works, we currently need to duplicate entries in //DEPS and //buildtools/DEPS, and it is possible for them to not be kept in sync. We don't want that. This CL adds a presubmit check so that if you modify the relevant lines in one file you are required to modify them in another. If we ever fix the linked bug so that we don't need to duplicate the content, we can remove these presubmit checks. This CL also gets rid of deps_revisions.gni in //buildtools, and switches to passing the libcxx_revision value from gclient to GN via gclient_gn_args. In order for this to work correctly, anyone using both //buildtools and //build in GN will need to *also* export the variable from their DEPS files. Bug: 941824, 930836 Change-Id: I438c9966c497737cd4984a14cdb0c8993ffcad9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522466 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641021} DEPS | 29 +++++++++++++++-------------- PRESUBMIT.py | 41 +++++++++++++++++++++++++++++++++++++++++ PRESUBMIT_test.py | 44 ++++++++++++++++++++++++++++++++++++++++++++ buildtools/DEPS | 10 ++++++++++ 4 files changed, 110 insertions(+), 14 deletions(-) commit bb5c7b0beb6d6aca295cdc2ff32e91be1de8801f Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 01:06:54 2019 +0000 Convert DesktopWindowTreeHostX11::DisableEventListening to OnceClosure and Fix Memory Leak OnFilePickerDestroy() needs to also destroy the pointer it receives. BUG=714018,940130 Change-Id: Ib0402575a7115b0e8b125e1131b61238561e95f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524879 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641020} chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc | 15 +++++++++------ .../widget/desktop_aura/desktop_window_tree_host_x11.cc | 8 +++----- .../widget/desktop_aura/desktop_window_tree_host_x11.h | 2 +- 3 files changed, 13 insertions(+), 12 deletions(-) commit 9f3eb4a941e865dcfff420344b06fb004097a1d2 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Mar 15 01:06:46 2019 +0000 DCHECK desktop media class names before casting, not after. Technically, if we violated this assertion, we'd do an invalid cast before calling a member function, leading to undefined behavior. This also switches to using the generic View* base type in cases where the subtype is not needed, which allows using standard Views accessors more. Bug: none Change-Id: I40b51579273b0b1f3c64d0cf15beeaed4708957e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524540 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641019} .../desktop_capture/desktop_media_list_view.cc | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) commit cdd7912a80b10e956ae4904c7db079c8a931c6b3 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Mar 15 01:05:45 2019 +0000 Revert "[protobuf] remove deprecated deps parameter" This reverts commit 48e4811635167d4f1c7aaccb5256152f1475ee99. Reason for revert: To unblock libassistant roll Original change's description: > [protobuf] remove deprecated deps parameter > > I replaced all appearance of deps with proto_deps or link_deps. > > Bug: 938011 > Change-Id: I95b8d6363358ecd8c350f095baaa10b12a968e3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506915 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640063} TBR=pkasting@chromium.org,xyzzyz@chromium.org,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 938011 Change-Id: Idccc769b22a11b46a8db421c6d62e09ce012b67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524744 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641018} third_party/protobuf/proto_library.gni | 10 ++++++++++ 1 file changed, 10 insertions(+) commit ed504eff44d516b9235793b5a0c2e9d6430183b8 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Fri Mar 15 01:05:42 2019 +0000 GWP-ASan: Send fewer metrics Don't send metrics for unrelated crashes, only for GWP-ASan crashes and error reports. The unrelated crashes are uninteresting and obscure the other (smaller) numbers of reports that I am interested in. Bug: 896019 Change-Id: Ic205f5fb0798b489889c2fa639fc2464f066bb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518755 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#641017} components/gwp_asan/crash_handler/crash_handler.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b647caba150591930587799f9ade2f8a2d2fdad4 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Mar 15 01:04:37 2019 +0000 MacPWAs: Move NSRunningApplication KVO creation to UI thread This is a speculative fix. We create a KVO for -[NSRunningApplication isTerminated] on the IO thread, where the NSRunningApplication is created. In the observer, we post a task to the UI thread, and we remove the KVO in that callback. This removal causes a crash claiming that no such observer exists. Note that the observer is also called with the initial value, because of the NSKeyValueObservingOptionInitial argument. I can see two potential problems here: 1. This code assumes that the KVO is only called once. - This is a boolean property that will only ever to NO->YES, so this would seem a safe assumption. - If this were not true, then we would call removeObserver twice, which is what we're seeing occur. We would also use-after-free the TerminationObserver. 2. The callback on the UI thread could potentially be made before the call to addObserver on the IO thread is complete. - This would call removeObserver from within addObserver, which is not allowed. Fix the two problems by: 1a. In onTerminated, early-out if |callback_| has already been issued. 1b. Use a scoped_nsobject for the task posted to the UI thread. 2. Call both addObserver and removeObserver on the UI thread (so that they won't become reentrant). X. Only create the observer if -[NSRunningApplication isTerminated] is NO. This is not needed to fix any bugs, but limits the cases in which we create a TerminationObserver. Bug: 941909 Change-Id: Id3b36900ac0c46a7ec48d4c7d2e3600cc5c61ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524340 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#641016} .../components/web_app_shortcut_mac.mm | 62 +++++++++++++++++----- 1 file changed, 50 insertions(+), 12 deletions(-) commit a88298a08628bf98a70125fbfe2208d55b3bc454 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 01:04:19 2019 +0000 Update V8 to version 7.5.45. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7677b798..3f6dd8f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c3a802251af5656fa7f6ac064265dd0708a99f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524916 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641015} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c3546aa21061ef3fcbad1739682aa1f21b77b9b7 Author: Donn Denman <donnd@chromium.org> Date: Fri Mar 15 01:03:29 2019 +0000 [TTS] Fix a flaky test by restriction to M+ phones Should fix a flaky testLongPressGestureFollowedByTapDoesntSelect test which seems to work fine on M phones, and hopefully later versions of Android too. BUG=837998 Change-Id: I4233b6eda177ff1bde9449581f32b8029d4b41bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524092 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641014} .../chrome/browser/contextualsearch/ContextualSearchManagerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8448a194ca90ae308d9d02e547a2b326bdf846cc Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 15 01:03:16 2019 +0000 [Extensions Bindings] Remove JS-bindings C++ messaging code The old JS-based bindings for extension messaging had a handful of native helpers, which are now obsolete with the full native implementation. Remove the JSRendererMessagingService and ExtensionPort classes entirely, and remove the vast majority of MessagingBindings. MessagingBindings::BindToGC() is used outside of messaging, and so needs to remain (but we should rename the class or move the method in a follow-up). Bug: 938998 Change-Id: Ia697f4e19b8ac03ef87a62d9b8385cced8f08fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523981 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641013} extensions/renderer/BUILD.gn | 4 - extensions/renderer/extension_port.cc | 58 ---- extensions/renderer/extension_port.h | 56 ---- .../renderer/js_renderer_messaging_service.cc | 189 ------------ .../renderer/js_renderer_messaging_service.h | 51 ---- extensions/renderer/messaging_bindings.cc | 318 +-------------------- extensions/renderer/messaging_bindings.h | 57 +--- extensions/renderer/renderer_messaging_service.cc | 1 - extensions/renderer/renderer_messaging_service.h | 2 + 9 files changed, 9 insertions(+), 727 deletions(-) commit 80fd8006a00feb8b33cea78ef31dde9372ae1329 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Mar 15 01:02:21 2019 +0000 Move ScopedVisibilityTracker to chrome/browser This CL: 1. Moves the ScopedVisibility tracker to chrome/browser 2. Adds it to the PageLoadMetricsObserverDelegate 3. Updates the http/s engagement observer to use the new delegate method. 4. Updates ScopedVisibilityTracker::GetForegroundDuration to be properly const. This CL is in preparation for another page load metrics observer that needs this kind of capability. It shouldn't have any behavior change. Bug: 937298 Change-Id: I685b05e191ccc04915eb5be7685332d800fda278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525182 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#641012} chrome/browser/BUILD.gn | 2 + .../https_engagement_page_load_metrics_observer.cc | 51 +++++----------------- .../https_engagement_page_load_metrics_observer.h | 11 ----- .../page_load_metrics_observer_delegate.h | 4 ++ .../browser/page_load_metrics/page_load_tracker.cc | 8 ++++ .../browser/page_load_metrics/page_load_tracker.h | 4 ++ .../scoped_visibility_tracker.cc | 7 +-- .../scoped_visibility_tracker.h | 8 ++-- .../scoped_visibility_tracker_unittest.cc | 2 +- chrome/browser/ui/BUILD.gn | 2 - .../ui/blocked_content/popup_opener_tab_helper.cc | 2 +- chrome/browser/ui/blocked_content/popup_tracker.h | 2 +- chrome/test/BUILD.gn | 2 +- 13 files changed, 41 insertions(+), 64 deletions(-) commit c53dd1380176044273b047bf50e332fbf9f05b82 Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 01:01:48 2019 +0000 Remove a redundant InternalAppIconLoader field Change-Id: I73c538d0ebf1e4b1aa71e91f32d8102e1fd0c435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510696 Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641011} chrome/browser/ui/app_list/internal_app/internal_app_icon_loader.cc | 5 ++--- chrome/browser/ui/app_list/internal_app/internal_app_icon_loader.h | 3 --- 2 files changed, 2 insertions(+), 6 deletions(-) commit 7756e9422c35e63e32de28fd9344f8db32f83518 Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Fri Mar 15 01:00:45 2019 +0000 Only try to commit if there is diff This is important if first attempt to upload CL has failed for some reason, e.g. presubmit failure, and on the second try we only need to execute git-cl-upload. R=perezju@chromium.org Bug: 895891 Change-Id: If55e2143365ae4b1135e0d65bdaf2fc5a4edcb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520679 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641010} tools/perf/cli_tools/update_wpr/update_wpr.py | 3 ++- tools/perf/cli_tools/update_wpr/update_wpr_unittest.py | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) commit 9e20b1f940adcfdfc188160985b03ec3f05923a6 Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Fri Mar 15 01:00:41 2019 +0000 [remoting host] Apply bitrate caps correctly. Bitrate caps were set only during OnStatsDelivered(), which is connected to the ICE connection state, not the signalling (SDP) state. This CL sets the global (PeerConnection) bitrates after SetRemoteDescription() is called. And it sets the Sender bitrates when the (Video)Sender is created. Since the relay status is (probably) not known at those times, the bitrates are also set in OnStatsDelivered() if the relay status has changed. By setting the min/max caps sooner, this may improve BWE performance. Bug: 941217 Change-Id: Ic623eb78544d22b1ebc94dcef906fd85e4d289b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524690 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Seth Hampson <shampson@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#641009} remoting/protocol/webrtc_audio_stream.cc | 2 ++ remoting/protocol/webrtc_audio_stream.h | 3 +- remoting/protocol/webrtc_transport.cc | 52 ++++++++++++++++++++++++-------- remoting/protocol/webrtc_transport.h | 24 +++++++++++++++ remoting/protocol/webrtc_video_stream.cc | 2 ++ remoting/protocol/webrtc_video_stream.h | 3 +- 6 files changed, 72 insertions(+), 14 deletions(-) commit 466cf0e47344fefc6c963525953d088857ffa24e Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 00:59:38 2019 +0000 Convert DesktopWidgetTest.CloseDestroys To Use RunLoop::QuitClosure BUG=940130 TBR=sky@chromium.org Change-Id: I62f09fa321aec2fabb551a38b216e3dd0aef281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525189 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641008} ui/views/widget/widget_unittest.cc | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) commit b6747a875c97018c48b92ef078c6d1e3ca3abfb0 Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Mar 15 00:59:34 2019 +0000 Mark several tasks in BrowserStartupControllerImpl.java as BOOTSTRAP In future this will prioritize them and make starup slightly faster. Bug: 863341 Change-Id: Ie38780ac22b83ec754a6c1b924a8ad0cfd25c641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524046 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641007} .../org/chromium/content/browser/BrowserStartupControllerImpl.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit d3327fdc7f5ff6a26ff8cafd4e118b3bd118a75f Author: Ross McIlroy <rmcilroy@chromium.org> Date: Fri Mar 15 00:21:59 2019 +0000 Revert "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab." This reverts commit eb14a6d18ec6c078e26fbf85a8172d880c4f34a3. Reason for revert: Broke Pixel2 bots Original change's description: > [Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab. > > This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit > browser. In making this change a new 'exact_browser' option is added to > tester_config in perf_data_generator to allow specifying a particular binary to > be run rather than guessing. > > BUG=934251 > > Change-Id: I2cd42eb3d7d6c4f36f4d15e36e4a605bf6f86e2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511455 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639530} TBR=rmcilroy@chromium.org,perezju@chromium.org,crouleau@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934251 Change-Id: I9c541463d9ff94e1f08f83842aa8d58072167870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524287 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#641006} testing/buildbot/chromium.perf.fyi.json | 4 +- tools/perf/core/perf_data_generator.py | 11 +---- tools/perf/core/perf_data_generator_unittest.py | 55 ------------------------- tools/perf/core/perf_json_config_validator.py | 13 +++--- 4 files changed, 8 insertions(+), 75 deletions(-) commit 09472a0fb420ac613c8a21f3185f405367f09519 Author: rbpotter <rbpotter@chromium.org> Date: Fri Mar 15 00:18:13 2019 +0000 Print Preview: Move destination and invitation stores, user info print-preview-app and print-preview-model owned properties used exclusively by destination-settings. This CL moves these properties and the user-info element into destination-settings. It also converts recent destinations to a setting, so that sticky settings updates can be done the same way they are for other settings, and so that destination-settings can own this property as well. This CL also adds a new destinationState for the print-preview-app to correctly update its state based on destination events. These changes will facilitate more easily refactoring print-preview-app in future, by reducing the properties and logic it is responsible for. Bug: 942345 Change-Id: I1cbad055b40a2ba1ca4e067284320c2752f47c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517045 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641005} .../resources/print_preview/data/destination.js | 13 + .../print_preview/data/destination_store.js | 48 ++- .../resources/print_preview/data/user_info.js | 16 +- .../browser/resources/print_preview/new/BUILD.gn | 7 +- .../browser/resources/print_preview/new/app.html | 25 +- chrome/browser/resources/print_preview/new/app.js | 249 ++++---------- .../print_preview/new/destination_dialog.js | 2 +- .../print_preview/new/destination_select.html | 9 +- .../print_preview/new/destination_select.js | 23 +- .../print_preview/new/destination_settings.html | 27 +- .../print_preview/new/destination_settings.js | 381 +++++++++++++++------ .../browser/resources/print_preview/new/model.js | 77 +---- .../print_preview/new/settings_behavior.js | 18 + .../print_preview/print_preview_resources.grd | 9 +- .../webui/print_preview/destination_select_test.js | 105 +++--- .../print_preview/destination_settings_test.js | 240 +++++++------ .../print_preview/invalid_settings_browsertest.js | 42 ++- chrome/test/data/webui/print_preview/model_test.js | 50 --- .../new_print_preview_ui_browsertest.js | 13 +- .../webui/print_preview/preview_generation_test.js | 2 + .../data/webui/print_preview/print_button_test.js | 49 ++- .../webui/print_preview/print_preview_app_test.js | 69 +--- 22 files changed, 729 insertions(+), 745 deletions(-) commit fb8e53f0793de0647f65d7edc6416bc9b13a651b Author: Zhenyao Mo <zmo@chromium.org> Date: Fri Mar 15 00:13:57 2019 +0000 Move GpuIntegrationTestAdapter to its own file This paves way for it to also be used in run_performance_tests.py BUG=867155 TEST=bots R=kbr@chromium.org,crouleau@chromium.org Change-Id: Ib6f88708e3a292649719fef87729240f3b683786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521792 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641004} chrome/test/BUILD.gn | 1 + testing/scripts/get_compile_targets.py | 4 ++- testing/scripts/gpu_integration_test_adapter.py | 34 +++++++++++++++++++++ .../run_gpu_integration_test_as_googletest.py | 35 ++-------------------- 4 files changed, 40 insertions(+), 34 deletions(-) commit 8a128cc02ae22a00b82d3696e97fe97d5ff75c76 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Mar 15 00:12:19 2019 +0000 C++ tips: remove guidance for hiding static details in implementation. The current guidance recommends a construct that generates a global constructor / destructor, which is forbidden. Since this is similar enough to the previous section on inner classes, just remove it since a separate section shouldn't be needed. Change-Id: Ie3150e6e85bb700d17f802fbe71c244329feb660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524338 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641003} styleguide/c++/c++-dos-and-donts.md | 37 ++----------------------------------- 1 file changed, 2 insertions(+), 35 deletions(-) commit 012cf25029f0585801528c811a03410fcb80f60c Author: Justin Cohen <justincohen@google.com> Date: Fri Mar 15 00:05:25 2019 +0000 [ios] Don't rely on nil webState in LocationBarCoordinator. Bug: 934294 Change-Id: I3737b1560f138250206f9f1b8648d32ada9f0392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520702 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641002} .../ui/location_bar/location_bar_coordinator.mm | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) commit 532802dbc667c84da2465aafda960196124549c8 Author: Salvador Guerrero <salg@google.com> Date: Fri Mar 15 00:02:57 2019 +0000 Changed DOM distiller store to new leveldb_proto API dom_distiller_store now uses the new leveldb_proto API, which enables migrating to a shared leveldb database. TBR=sdefresne@chromium.org Bug: 870813 Change-Id: Iee75d947149165e4408902e44d4e31fbaa83cbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504170 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#641001} .../dom_distiller/dom_distiller_service_factory.cc | 14 +++++++---- .../dom_distiller_viewer_source_browsertest.cc | 2 +- components/BUILD.gn | 1 + .../core/dom_distiller_service_unittest.cc | 2 +- .../dom_distiller/core/dom_distiller_store.cc | 27 ++++++---------------- .../dom_distiller/core/dom_distiller_store.h | 18 ++++----------- .../core/dom_distiller_store_unittest.cc | 12 ++++------ .../dom_distiller/core/dom_distiller_test_util.cc | 2 +- .../standalone/content_extractor_browsertest.cc | 11 +++++++-- .../public/shared_proto_database_client_list.cc | 2 ++ .../public/shared_proto_database_client_list.h | 3 ++- 11 files changed, 44 insertions(+), 50 deletions(-) commit d4377bf6ecc353ba6524081cba485ad583b98064 Author: John Budorick <jbudorick@chromium.org> Date: Fri Mar 15 00:01:51 2019 +0000 Revert "Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds." This reverts commit 889a9665145519f88a755826e6c4a3c15f8fda7a. Reason for revert: broke Mac ASan 64: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/78868 Original change's description: > Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. > > Removes some special-case code and potentially makes debug info a bit smaller. > > Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case > on linux -- this helps with build determinism. > > Bug: 942155,899438,906741,429358 > Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640963} TBR=thakis@chromium.org,mark@chromium.org Change-Id: Ie941d4661c81d97a79ac93f86e8f39df0be467e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942155, 899438, 906741, 429358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525280 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641000} build/config/compiler/BUILD.gn | 67 +++++++++++++++++++++--------------------- 1 file changed, 34 insertions(+), 33 deletions(-) commit ca9980bcc4e866719edaa0cbd27316621880136b Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 00:00:44 2019 +0000 Inline RunAllPendingInMessageLoop in DesktopWindowTreeHostX11Test.Shape BUG=940130 TBR=sky@chromium.org Change-Id: I667c1f9a46409a427f7665a199e52dd879389b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525283 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640999} .../widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit 2d64b464b19d7678e3b0f60b59c11b936cd5cf33 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 14 23:53:45 2019 +0000 Fix FULL_SAFE_BROWSING typo TBR=vakh@chromium.org Bug: 928236 Change-Id: I0907d71ab816be59acf670c2f477b6d545c2b67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525014 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640998} chrome/browser/ui/webui/settings/md_settings_ui.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 82e8c07b1f829b666b7d1a5567b229c30b8c0d34 Author: Guohui Deng <guohuideng@chromium.org> Date: Thu Mar 14 23:52:17 2019 +0000 [chromecast ]Add ChannelLayout to chromecast::media::AudioConfig With ChannelLayout, IsValidConfig() can determine if the config is valid without the workaround. Bug: internal b/126765436 Merge-With: eureka-internal/249019 Test: mannually compile and cast. Change-Id: Ib96054cb2e83cfdb03898d90d5ac823ca917e540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500015 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640997} .../audio_decoder_software_wrapper_unittest.cc | 1 + .../audio_video_pipeline_device_unittest.cc | 2 + .../cma/backend/multizone_backend_unittest.cc | 2 + .../media/cma/base/decoder_config_adapter.cc | 46 +++++++++++++++----- chromecast/public/media/decoder_config.h | 49 ++++++++++++++++++---- 5 files changed, 83 insertions(+), 17 deletions(-) commit 3ebc974328d269f701aebcf1f9f2686a798cc3d9 Author: Johannes Henkel <johannes@chromium.org> Date: Thu Mar 14 23:50:30 2019 +0000 Add virtual test suites for --enable-internal-devtools-binary-protocol. This flag is introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1507232 and it switches the wire encoding for devtools to a binary protocol within browser and renderer. Definining these two test suites gives us test coverage until we make this setting the default. Change-Id: I81b5dd2850e07a9e0fb57c6e03c45578f49a4a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510117 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640996} third_party/blink/web_tests/ASANExpectations | 4 + .../FlagExpectations/disable-site-isolation-trials | 5 + third_party/blink/web_tests/LeakExpectations | 5 + third_party/blink/web_tests/MSANExpectations | 26 +++++ third_party/blink/web_tests/NeverFixTests | 1 + third_party/blink/web_tests/SlowTests | 62 ++++++++++++ third_party/blink/web_tests/TestExpectations | 110 +++++++++++++++++++++ third_party/blink/web_tests/VirtualTestSuites | 10 ++ .../http/tests/devtools/README.txt | 2 + .../http/tests/inspector-protocol/README.txt | 2 + 10 files changed, 227 insertions(+) commit 11783fa425781ee244415a5fcc431c0f0a239ee6 Author: Johannes Henkel <johannes@chromium.org> Date: Thu Mar 14 23:48:51 2019 +0000 Reland "Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession.""" This reverts commit fc637deb511059129c296585e4c96bf899752f1d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession.""" > > This reverts commit 8f3ff47631cfdd7b80c37a859b68bb878c710fd8. > > Reason for revert: Depends on reverted change https://chromium-review.googlesource.com/c/chromium/src/+/1522494 > > Original change's description: > > Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession."" > > > > This is a reland of a741fa4abd37baa4d8618c27b5c8a3b5e0c53fcd > > > > Original change's description: > > > Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession." > > > > > > This is a reland of 6ab258258c8ba0c7ebda22756062abc720859b6a > > > > > > Original change's description: > > > > [DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession. > > > > > > > > When the flag is enabled, we send messages to agents / handlers as CBOR, > > > > even if the cient sends us JSON. We convert responses back to JSON if > > > > needed. > > > > > > > > Change-Id: I6123e38262d6eeb82206d28a936a32f7db8235b8 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507232 > > > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#638897} > > > > > > Change-Id: I20975e3119d3ac65a3e4294ea7cf0bf2d9516389 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512336 > > > Reviewed-by: Johannes Henkel <johannes@chromium.org> > > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#639164} > > > > Change-Id: I94019b6915a99e6b101892c5b3d451718250ba53 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521466 > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#640487} > > TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,johannes@chromium.org > > Change-Id: Ie10a272952b579fd168d2bf54978c31c95c22837 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522496 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640618} TBR=dgozman@chromium.org,aboxhall@chromium.org,caseq@chromium.org,pfeldman@chromium.org,johannes@chromium.org Change-Id: Ia569dd8f17ab84bae00acb32ef3a0bf42ae80a7d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525402 Reviewed-by: Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#640995} chrome/browser/devtools/chrome_devtools_session.cc | 16 +++- content/browser/BUILD.gn | 3 + content/browser/devtools/DEPS | 3 + .../devtools/browser_devtools_agent_host.cc | 2 +- content/browser/devtools/devtools_session.cc | 98 +++++++++++++++++----- content/browser/devtools/devtools_session.h | 5 ++ .../browser/devtools/devtools_session_encoding.cc | 94 +++++++++++++++++++++ .../browser/devtools/devtools_session_encoding.h | 29 +++++++ .../devtools/render_frame_devtools_agent_host.cc | 3 +- content/public/common/content_switches.cc | 6 ++ content/public/common/content_switches.h | 1 + 11 files changed, 236 insertions(+), 24 deletions(-) commit 0356e21b384c11ec5aea21f15d3ce568c1464de3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 23:42:08 2019 +0000 Roll src/third_party/angle 094c40dce601..2fb6563bf503 (4 commits) https://chromium.googlesource.com/angle/angle.git/+log/094c40dce601..2fb6563bf503 git log 094c40dce601..2fb6563bf503 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 syoussefi@chromium.org Vulkan: Fix CommandGraph barrier nodes w.r.t to first node 2019-03-14 syoussefi@chromium.org Vulkan: Fix copySubImage to non-cube-complete images. 2019-03-14 geofflang@chromium.org Mark RGB HALF_FLOAT_OES as renderable with EXT_color_buffer_half_float and WebGL 2019-03-14 raul@tambre.ee Support Python 3 in //scripts/file_exists.py Created with: gclient setdep -r src/third_party/angle@2fb6563bf503 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:941671,chromium:941669 TBR=geofflang@chromium.org Change-Id: I56d4b149923b55db9b8dc7cab4cc9cee67edaec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525141 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640994} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 769d61c7fb033bfcb1a9e68015d80d9cbf261ddb Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Mar 14 23:41:58 2019 +0000 flags: Update metadata for ChromeOS Launcher flags Removing enable-app-shortcut-search. Adding owners for enable-app-data-search and enable-play-store-search. Bug: None Change-Id: Ice0ca8ceadbacffcfc787903cfcfd356ff41775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524914 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#640993} chrome/browser/flag-metadata.json | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) commit 4680e2e63630a16d48c88c7e65e829ba851c1598 Author: dpapad <dpapad@chromium.org> Date: Thu Mar 14 23:40:14 2019 +0000 Grit: Don't attempt to inline srcset="$i18n{foo}" occurrences. This allows replacing the last i18n-values usage in plugin_poster.html (also done in this CL), which further unblocks the i18n-values to $i18n{} migration. Bug: 936220 Change-Id: Ib53347621854b69dd13331fcc81601cf0654b9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490404 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640992} .../renderer/resources/plugins/plugin_poster.html | 2 +- tools/grit/grit/format/html_inline.py | 2 +- tools/grit/grit/format/html_inline_unittest.py | 32 ++++++++++++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-) commit a2360ee97104be9c0b9eb65f5314bb6fff537704 Author: Brian Sheedy <bsheedy@chromium.org> Date: Thu Mar 14 23:39:41 2019 +0000 Add GPU FYI Pixel 2 builder + manual trybot Adds "Android FYI Release (Pixel 2)" to chromium.gpu.fyi to run the WebGL 2.0 conformance tests on Pixel 2s w/ P. Also adds a manual-only trybot equivalent of this to luci.chromium.try. Also drive-by fixes some "-vk" manual trybots' Milo names that got missed during the rename. Bug: 850257 Change-Id: I927543c56506a8fc0895db48ea161ade6018c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517152 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#640991} infra/config/cr-buildbucket.cfg | 11 +++++++++++ infra/config/luci-milo.cfg | 25 ++++++++++++++++++------- infra/config/luci-scheduler.cfg | 11 +++++++++++ testing/buildbot/chromium.gpu.fyi.json | 32 ++++++++++++++++++++++++++++++++ testing/buildbot/test_suites.pyl | 18 ++++++++++++++++++ testing/buildbot/waterfalls.pyl | 15 +++++++++++++++ tools/mb/mb_config.pyl | 2 ++ 7 files changed, 107 insertions(+), 7 deletions(-) commit b523747b1eafcca8c3d9894bf7aa5c4e3e980246 Author: Xiaohui Chen <xiaohuic@google.com> Date: Thu Mar 14 23:38:32 2019 +0000 assistant: add launcher integration chrome://flags Bug: 942190 Test: locally build and run, see experiment in chrome://flags Change-Id: I7967e8ce60e12a02d1b7f73b6ff120febf2c0767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524905 Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#640990} chrome/browser/about_flags.cc | 7 +++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 14 ++++++++++---- chrome/browser/flag_descriptions.h | 9 ++++++--- tools/metrics/histograms/enums.xml | 2 ++ 5 files changed, 30 insertions(+), 7 deletions(-) commit 38b8fb8ddfcd480deed0ef3b823fb3321fa10720 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Thu Mar 14 23:37:02 2019 +0000 [layoutng] Remove some mac-specific expectation lines These tests all pass now R=ikilpatrick@chromium.org Change-Id: Ic35d9b6b64352abb5ec9ad5adff64a038d495f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524334 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640989} third_party/blink/web_tests/TestExpectations | 9 --------- 1 file changed, 9 deletions(-) commit 2a8190617a5f6f5db393be1e561c3f9b1589a05e Author: Pavel Feldman <pfeldman@chromium.org> Date: Thu Mar 14 23:31:46 2019 +0000 DevTools: remove Overlay.setSuspended protocol method, use enable/disable instead. Change-Id: Iab079eb08be6e47ac9bbdfd30ba72b3f94f320e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521791 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640988} .../renderer/core/inspector/browser_protocol.pdl | 5 - .../core/inspector/inspector_overlay_agent.cc | 42 ++------ .../core/inspector/inspector_overlay_agent.h | 3 - .../renderer/devtools/front_end/common/Settings.js | 3 +- .../devtools/front_end/emulation/DeviceModeView.js | 6 -- .../devtools/front_end/sdk/OverlayModel.js | 114 ++++++++++++--------- .../devtools/front_end/sdk/ScreenCaptureModel.js | 7 +- .../profiler/agents-disabled-check-expected.txt | 6 +- 8 files changed, 84 insertions(+), 102 deletions(-) commit 3e9d78c2a9b4d3e402c9bd9ff6086f4dfe09ed45 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Mar 14 23:29:02 2019 +0000 Elim ash lock screen calls to SessionManagerClient Bug: 644350 Change-Id: I315e72637710b3bc8403edc8b742e49474a4fe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521960 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640987} ash/DEPS | 2 -- ash/dbus/DEPS | 2 ++ ash/system/power/power_button_controller_unittest.cc | 7 +++---- ash/system/power/power_button_test_base.cc | 9 --------- ash/system/power/power_button_test_base.h | 7 ------- ash/wm/lock_state_controller.cc | 6 +----- ash/wm/lock_state_controller_unittest.cc | 19 +++++++++---------- 7 files changed, 15 insertions(+), 37 deletions(-) commit 6025f939957a9172fe65d9456b954abc9bd5fe85 Author: John Budorick <jbudorick@chromium.org> Date: Thu Mar 14 23:28:02 2019 +0000 Disable ArcPolicyBridgeAffiliatedTest. Bug: 941861 Change-Id: I3b203957e3e3e4939384b738c3a5ebf4cfe3d62c Tbr: bartfab@chromium.org,yoichio@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525058 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640986} chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 09b2d0e69effe8b2a37d7326468e191b356cb8be Author: Andrew Luo <aluo@chromium.org> Date: Thu Mar 14 23:24:11 2019 +0000 pass device and verbosity arguments correctly. The test runner shards tests across all devices that are specified. By default, all healthy, non-blacklisted devices will be used. Bug: 941589, 929892 Test: run_cts.py --verbose --device <serial 1> --device <serial 2> Change-Id: I551281018859e35fc551d21fe5f0589f3d8b2014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521295 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640985} android_webview/tools/run_cts.py | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) commit 64d2c34061c4bc2c74a9634d1c13d11325f49127 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Mar 14 23:22:16 2019 +0000 [Files app] Add drag'n'drop test and fix dragover error Fix error when hovering a dragged file on USB grouped root, which uses a EntryList which doesn't have volumeInfo. Add test for drag'n'drop from file list to directory tree and drag and hover for USB roots (grouped or not). Bug: 940416 Change-Id: Ia1d4abd97edefb22b13d135531d6bba7a0f784d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522489 Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#640984} .../file_manager/file_manager_browsertest.cc | 2 + .../background/js/runtime_loaded_test_util.js | 55 ++++++++++++++++ .../foreground/js/file_transfer_controller.js | 3 +- .../integration_tests/file_manager/transfer.js | 76 ++++++++++++++++++++++ 4 files changed, 135 insertions(+), 1 deletion(-) commit afea2d19da0b2ef9ad445e20b2ae8d0f0c97c14c Author: John Z Wu <jzw@chromium.org> Date: Thu Mar 14 23:21:17 2019 +0000 Fix shut down issues with //ios/web_view. 1. WebViewURLRequestContextGetter needs to call NotifyContextShuttingDown() as documented in URLRequestContextGetter. See: https://cs.chromium.org/chromium/src/net/url_request/url_request_context_getter.h?q=URLRequestContextGetter&sq=package:chromium&dr=CSs&l=69 2. WebViewBrowserStates should be shutdown before threads are destroyed. See: https://cs.chromium.org/chromium/src/ios/chrome/browser/application_context_impl.cc?sq=package:chromium&dr=CSs&q=application_context_impl.cc&g=0&l=142 Change-Id: I6057c7b505845b23ac203b799d932f2af7de8d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522471 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#640983} ios/web_view/internal/web_view_browser_state.mm | 5 +++++ ios/web_view/internal/web_view_url_request_context_getter.h | 7 +++++++ .../internal/web_view_url_request_context_getter.mm | 13 ++++++++++++- ios/web_view/internal/web_view_web_main_parts.mm | 5 ++++- 4 files changed, 28 insertions(+), 2 deletions(-) commit a075dbe3f854ee00416990e85760683bd97e65e1 Author: Mike Wasserman <msw@chromium.org> Date: Thu Mar 14 23:20:49 2019 +0000 Add extra browser window checks for shortcut crashes The cause of the crash is unclear, this may help with investigation. Bug: 937088 Change-Id: I60fff2732fd4393b932437ba5ca3207b58cc4813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524337 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#640982} .../ui/ash/launcher/browser_shortcut_launcher_item_controller.cc | 4 ++++ 1 file changed, 4 insertions(+) commit f8ac476152d551bbe4134f14449ca9d9013bbe2a Author: Johannes Henkel <johannes@chromium.org> Date: Thu Mar 14 23:19:41 2019 +0000 [DevTools] Roll inspector_protocol to 1e65f2e3a9759b799ca3a87a41dcc9f58fdd720f. This is a reland, but I can't use the reland feature unfortunately. The revert PR was https://chromium-review.googlesource.com/c/chromium/src/+/1522494 This new roll lowers the stack limit for the json / cbor parser, so I'm hoping it will work on win-asan. I have no reasonable way to try this at the moment however. (1) Make a source_set in content/browser/devtools for the encoding_test, and add the test to content_unittest. This will ensure that further changes to our test won't break after the try-bots pass a submission to Chromium. I've broken the tree twice with that, previously. (2) third_party/inspector_protocol/BUILD.gn is now a different file than it is upstream. But the good news is it's really really simple. I've updated roll.py accordingly. Also: Change-Id: I935624d156b2ffc9df12fd5f1d745da8a10998c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524917 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#640981} content/browser/devtools/BUILD.gn | 13 + content/test/BUILD.gn | 1 + third_party/inspector_protocol/BUILD.gn | 108 +- third_party/inspector_protocol/DEPS | 4 +- third_party/inspector_protocol/README.chromium | 2 +- third_party/inspector_protocol/code_generator.py | 4 +- third_party/inspector_protocol/encoding/cbor.cc | 821 --------- third_party/inspector_protocol/encoding/cbor.h | 280 --- .../inspector_protocol/encoding/cbor_internals.h | 39 - .../inspector_protocol/encoding/encoding.cc | 1796 +++++++++++++++++++ third_party/inspector_protocol/encoding/encoding.h | 436 +++++ .../encoding/{cbor_test.cc => encoding_test.cc} | 951 ++++++++-- .../inspector_protocol/encoding/json_parser.cc | 588 ------- .../inspector_protocol/encoding/json_parser.h | 22 - .../encoding/json_parser_handler.h | 38 - .../encoding/json_parser_test.cc | 413 ----- .../encoding/json_std_string_writer.cc | 306 ---- .../encoding/json_std_string_writer.h | 25 - .../encoding/json_std_string_writer_test.cc | 162 -- .../encoding/linux_dev_platform.cc | 49 - .../encoding/linux_dev_platform.h | 17 - third_party/inspector_protocol/encoding/platform.h | 25 - third_party/inspector_protocol/encoding/span.h | 47 - .../inspector_protocol/encoding/span_test.cc | 57 - third_party/inspector_protocol/encoding/status.h | 61 - .../inspector_protocol/encoding/str_util.cc | 20 - third_party/inspector_protocol/encoding/str_util.h | 17 - .../inspector_protocol/inspector_protocol.gni | 4 +- .../inspector_protocol/inspector_protocol.gypi | 4 +- .../inspector_protocol/lib/CBOR_cpp.template | 828 --------- .../inspector_protocol/lib/Values_cpp.template | 114 +- .../lib/base_string_adapter_cc.template | 14 +- .../inspector_protocol/lib/encoding_cpp.template | 1807 ++++++++++++++++++++ .../lib/{CBOR_h.template => encoding_h.template} | 351 ++-- third_party/inspector_protocol/roll.py | 1 - 35 files changed, 5095 insertions(+), 4330 deletions(-) commit c1c44d25ce1370bae60df2c23a4c6027f2fd7b69 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 23:18:22 2019 +0000 Roll src/third_party/SPIRV-Tools/src bdcb155163d4..e545522146af (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bdcb155163d4..e545522146af git log bdcb155163d4..e545522146af --date=short --no-merges --format='%ad %ae %s' 2019-03-14 zoddicus@users.noreply.github.com Add --strip-atomic-counter-memory (#2413) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e545522146af The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic238ec629f2c4e05677e7b54ae5705f1cee208f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524328 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640980} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 204a4deb68c99e3a571e1875f3b5418bbf383fa6 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Mar 14 23:14:52 2019 +0000 Revert "Roll Fuchsia SDK from ddcb12bc41ac to 1fdc2abd2818" This reverts commit ec3da85e11e147cf7b7285c0e5859bbe40cdbdf1. Reason for revert: Speculative revert following netstack issues. Bug: 942324 Original change's description: > Roll Fuchsia SDK from ddcb12bc41ac to 1fdc2abd2818 > > > The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: Ie62d4cf99eaae566bc703347ed83e7807f4cc9d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523065 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#640802} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I12b9f615fd3d626f72e0170f091a43c89b4c158a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525287 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#640979} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit c728833110d8813d3fae09ee78632efcae1b3409 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 14 23:08:07 2019 +0000 Roll src-internal 36082da2f20c..b58fe2ab9436 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36082da2f20c..b58fe2ab9436 Created with: gclient setdep -r src-internal@b58fe2ab9436 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I16813b7736c66a446db13118187907f487ff10d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524329 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640978} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Updated tag 'tree_truth' (was 022f9c0ca5d8)