Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 37527 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918910656067568160 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itC8QU0a/luci_context.768935548 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm609-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 439aa04090de9d11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 6772582d4c3499cb21fc28656bfcf717eee9c1a6 Disable a few failing inspector-protocol tests. Finnur Thorarinsson, Fri Mar 15 14:43:00 2019 +0000 a595a7cdd07c759366f2c1d4899ba6097934e2a5 Add support for overrides on the consistency tests. G. Silva, Fri Mar 15 14:35:58 2019 +0000 6bb0da9252be517aec17312e9caddfb73f18f65c [ios] Updates build-webkit.py to be easier to run manually. Rohit Rao, Fri Mar 15 14:33:26 2019 +0000 88cd402005df5075e1ee389d001e599cfa1f4a31 Call StopLoading before loading data Olivier Robin, Fri Mar 15 14:31:21 2019 +0000 af143bb75682c2746aa0e28c9ef376b8b65f28ce Roll src/third_party/perfetto 34e6c9d3d1b6..eff66d82dc0d (1 commits) chromium-autoroll, Fri Mar 15 14:29:54 2019 +0000 453267c11fa78fb6fa800c0f210347d84f38519e Add support for usage limits on the consistency tests. G. Silva, Fri Mar 15 14:29:04 2019 +0000 a7fde61eb5014d4a1645cf225a58f166b99ddfcf Fix handling of half-escaped Location headers. David Benjamin, Fri Mar 15 14:20:58 2019 +0000 02cfc79ba8801c578d1d06c6063583f59abfacc6 Do not hold TaskQueue lock while deleting tasks during shutdown Carlos Caballero, Fri Mar 15 14:19:47 2019 +0000 461d2b1cdff4603896597218d6ade24ea02f742a Import wpt@96dd05afd40377e90acd1da0599846be65fa8001 Chromium WPT Sync, Fri Mar 15 14:16:53 2019 +0000 c4eaf35240cab77ec7038facbc7b2eb97dd6782a [auto] Update FlagExpectations for LayoutNG Koji Ishii, Fri Mar 15 14:16:33 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 6772582d4c3499cb21fc28656bfcf717eee9c1a6 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Fri Mar 15 14:43:00 2019 +0000 Disable a few failing inspector-protocol tests. TBR: caseq NOTRY: true Bug: 942517 Change-Id: I35bacfca8ff7882d8871743da0ba7eda6933566a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524358 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#641193} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit a595a7cdd07c759366f2c1d4899ba6097934e2a5 Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 14:35:58 2019 +0000 Add support for overrides on the consistency tests. Also includes new |last_updated| fields on usage limit and bedtime entries and a lot of test cases. Bug: 935711 Change-Id: I589216931896d22f106b9a241ab3e81c5ce48108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518947 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641192} .../consistency_golden_converter.cc | 71 ++++++++++-- .../consistency_golden_converter.h | 14 ++- .../consistency_golden_converter_unittest.cc | 127 +++++++++++++++++++-- .../consistency_test.cc | 5 +- .../consistency_test_utils.cc | 51 +++++++-- .../consistency_test_utils.h | 33 +++++- .../goldens/consistency_golden.proto | 35 ++++++ .../goldens/override_bedtimes.textproto | 110 ++++++++++++++++++ .../goldens/override_then_modify.textproto | 102 +++++++++++++++++ .../override_usage_limits_android.textproto | 61 ++++++++++ .../goldens/override_usage_limits_cros.textproto | 61 ++++++++++ .../goldens/simple_override.textproto | 24 ++++ 12 files changed, 659 insertions(+), 35 deletions(-) commit 6bb0da9252be517aec17312e9caddfb73f18f65c Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Mar 15 14:33:26 2019 +0000 [ios] Updates build-webkit.py to be easier to run manually. Adds a default value for WEBKIT_OUTPUTDIR that matches what ninja is expected to use. Moves "-j" into BUILD.gn, so that invoking build-webkit.py directly doesn't set a limit on the number of parallel jobs. Switches to the argparse in order to pass unparsed commandline arguments along to the underlying build-webkit command. BUG=934252 Change-Id: I6a818a852759558416a0b7e95c75612a1c2c6703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525983 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641191} ios/third_party/webkit/BUILD.gn | 8 ++++++++ ios/third_party/webkit/build_webkit.py | 37 +++++++++++++++++----------------- 2 files changed, 27 insertions(+), 18 deletions(-) commit 88cd402005df5075e1ee389d001e599cfa1f4a31 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Mar 15 14:31:21 2019 +0000 Call StopLoading before loading data |CRWWebController loadData:| will replace the content of the page loaded by the lastCommittedItem. If there is a pending item, this pending loading must be cancelled before proceeding in loading data. This can be the case when loading offline page in place of an uncommitted reloading navigation. Bug: 942025 Change-Id: Id735961110218eb9ede2531c19c33b29879a688f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524264 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641190} ios/web/web_state/ui/crw_web_controller.h | 1 + ios/web/web_state/ui/crw_web_controller.mm | 1 + 2 files changed, 2 insertions(+) commit af143bb75682c2746aa0e28c9ef376b8b65f28ce Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 14:29:54 2019 +0000 Roll src/third_party/perfetto 34e6c9d3d1b6..eff66d82dc0d (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/34e6c9d3d1b6..eff66d82dc0d git log 34e6c9d3d1b6..eff66d82dc0d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 rsavitski@google.com Merge "Remove unused RecordReader." Created with: gclient setdep -r src/third_party/perfetto@eff66d82dc0d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I336b8bd9e10a751d23554af961d4200e27542b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525815 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641189} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 453267c11fa78fb6fa800c0f210347d84f38519e Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 14:29:04 2019 +0000 Add support for usage limits on the consistency tests. Also, includes two new output fields - |next_active_policy| and |remaining_quota_mins| - and creates utils to make unit tests for the converter more readable. Bug: 935711 Change-Id: If6ac3fe73040b9f50fd46ddb8f4704a2b08006c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514313 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641188} .../consistency_golden_converter.cc | 53 +++++++--- .../consistency_golden_converter_unittest.cc | 107 +++++++++++++++++---- .../consistency_test.cc | 8 +- .../consistency_test_utils.cc | 37 +++++++ .../consistency_test_utils.h | 33 +++++++ .../goldens/consistency_golden.proto | 31 ++++++ .../goldens/simple_bedtimes.textproto | 8 +- .../goldens/simple_usage_limits.textproto | 50 ++++++++++ chrome/test/BUILD.gn | 2 + 9 files changed, 295 insertions(+), 34 deletions(-) commit a7fde61eb5014d4a1645cf225a58f166b99ddfcf Author: David Benjamin <davidben@chromium.org> Date: Fri Mar 15 14:20:58 2019 +0000 Fix handling of half-escaped Location headers. Non-ASCII characters in URLs are supposed to be percent-escaped. This includes when those characters are used in Location headers. However, we tolerate unescaped characters by escaping them ourselves at various stages in the process. ru.wikipedia.org sometimes sends redirects where the path is percent-escaped, but the fragment is not. Previously, we would fix the escaping in the fragment, but leave the path as-is. However, https://chromium-review.googlesource.com/c/chromium/src/+/1366759 switched it to always unformly escape everything, so the %s became %25. This causes us to follow the redirect incorrectly. Uniformly escaping things makes sense for NetLog, where we want to unambiguously represent what the server actually sent, but escaping as part of URL resolution as not intended to be invertible. Restore the old behavior here and add some regression tests. Bug: 942073 Change-Id: I009bc0dc9c5c8f836f072fe23ccd824698d550e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525483 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#641187} net/base/escape.cc | 9 +++++++++ net/base/escape.h | 5 +++++ net/base/escape_unittest.cc | 5 +++++ net/http/http_response_headers.cc | 9 ++++++--- net/url_request/url_request_unittest.cc | 32 ++++++++++++++++++++++++++++++++ 5 files changed, 57 insertions(+), 3 deletions(-) commit 02cfc79ba8801c578d1d06c6063583f59abfacc6 Author: Carlos Caballero <carlscab@google.com> Date: Fri Mar 15 14:19:47 2019 +0000 Do not hold TaskQueue lock while deleting tasks during shutdown Change-Id: I6b18e3ff12d85b1337a63094a5f0ea34704142f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524345 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641186} .../sequence_manager_impl_unittest.cc | 31 +++++++++++++++++----- base/task/sequence_manager/task_queue.cc | 4 +-- 2 files changed, 26 insertions(+), 9 deletions(-) commit 461d2b1cdff4603896597218d6ade24ea02f742a Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 14:16:53 2019 +0000 Import wpt@96dd05afd40377e90acd1da0599846be65fa8001 Using wpt-import in Chromium e04a4c8e055c2864e624b21c3db18ccfb9804cf8. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ice3de01b4b9e58a7ada24a35b3a57e5cfeae9f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525814 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641185} third_party/blink/web_tests/TestExpectations | 6 ++ .../web_tests/external/WPT_BASE_MANIFEST_5.json | 48 ++++++++- .../child-document-raf-order-expected.txt | 4 + .../update-rendering/child-document-raf-order.html | 118 +++++++++++++++++++++ .../fractions/frac-linethickness-004-ref.html | 27 +++++ .../fractions/frac-linethickness-004.html | 30 ++++++ .../web_tests/external/wpt/tools/manifest/item.py | 16 +-- .../external/wpt/tools/manifest/sourcefile.py | 2 + 8 files changed, 234 insertions(+), 17 deletions(-) commit c4eaf35240cab77ec7038facbc7b2eb97dd6782a Author: Koji Ishii <kojii@chromium.org> Date: Fri Mar 15 14:16:33 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 16553 16557 16561 16564 16578 16593 16605 16618 16624 16628 16643 16657 16676 16685 16692 16699 16705 16715 16719 16729 16749 16760 16768 16776 16781 16785 5 lines were removed and 4 lines were deflaked by consecutive results since 16692. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I56d7b4cc9ed153fb7260566643d8c6e4039dd5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517475 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641184} .../enable-blink-features=LayoutNG | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) commit 2575fe0547ee3c9a58b0a443856f0abb09527a78 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Fri Mar 15 14:09:54 2019 +0000 Disable failing paste-text-016.html test. Failing persistently on multiple Mac bots. TBR: yosin NOTRY: true Bug: 942509 Change-Id: I4f0a6877a30689868a6d1431c515be4d444d9965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526044 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#641183} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit ededf16bac4fd6a9176c2f3a6f5e3b058e26e2d8 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Mar 15 13:58:34 2019 +0000 [AF Profile] Unify model data <-> specifics conversion with Directory This CL removes the additional smartness of the autofill_profile sync bridge and adapts closer to the logic of the syncable service. It is still not cut&paste as this would need more refactoring (to code that is arguably harder to reason about). This CL still leaves around one difference: the syncable service does trim strings as if they were ASCII which may result in incorrect UTF8 strings; the bridge fixes this issue and treats the strings as UTF8. Apart from that, there should be no functional differences. There is a hope that this could reduce inconsistencies in observed autofill_profile sync traffic between USS and Directory. Bug: 904390 Change-Id: Ie5448e0991d56ee435a31c62178c50d2c729d692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520505 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641182} .../core/browser/autofill_profile_sync_util.cc | 207 ++++++++------------- .../browser/autofill_profile_sync_util_unittest.cc | 8 +- 2 files changed, 86 insertions(+), 129 deletions(-) commit fe80676157f90edb8695d6013df7333987ead53f Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 13:57:44 2019 +0000 Roll src-internal 59b9a059b2f8..fa2d5d1b4ecf (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59b9a059b2f8..fa2d5d1b4ecf Created with: gclient setdep -r src-internal@fa2d5d1b4ecf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I013b3b629d698d8bd3d125323d54f7fae37f1d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525816 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641181} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 766b4f772c50479992e1a3943f160b2799d1a5c9 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Mar 15 13:56:18 2019 +0000 [AF Wallet Sync] Remove an obsolete TODO The TODO is already fixed. Bug: 853688 Change-Id: I2b720f860e0bae5eef9eea6f4085c3af11093aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524356 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641180} .../core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc | 1 - 1 file changed, 1 deletion(-) commit 6170a2f1055a1bd59c5e7382a8ce7aef1e681f84 Author: Miyoung Shin <myid.shin@igalia.com> Date: Fri Mar 15 13:55:01 2019 +0000 Change long long to int64_t in third_party/blink/renderer/modules/filesystem/ - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I223ab28a0ebc9ea19688c619f48b32cf812c4652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524748 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641179} third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc | 2 +- third_party/blink/renderer/modules/filesystem/file_system_callbacks.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 7f0d3109e49ec195b0e09661824647a16639f1f0 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 13:46:55 2019 +0000 Clean up unnecessary Create() factory functions in modules/indexeddb As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/modules/indexeddb and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I189e6024d9db77a45793dbaffbf0e77632be2b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525251 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641178} .../bindings/modules/v8/v8_binding_for_modules_test.cc | 3 +-- .../renderer/modules/indexeddb/idb_factory_test.cc | 4 ++-- .../renderer/modules/indexeddb/idb_object_store.cc | 4 ++-- .../blink/renderer/modules/indexeddb/idb_request.cc | 3 +-- .../renderer/modules/indexeddb/idb_request_test.cc | 8 ++++---- .../renderer/modules/indexeddb/idb_test_helper.cc | 8 ++++---- .../renderer/modules/indexeddb/idb_transaction_test.cc | 12 ++++++------ .../blink/renderer/modules/indexeddb/idb_value.cc | 5 ----- .../blink/renderer/modules/indexeddb/idb_value.h | 6 +----- .../modules/indexeddb/idb_value_wrapping_test.cc | 18 +++++++++--------- .../modules/indexeddb/indexed_db_blink_mojom_traits.cc | 8 ++++---- .../indexeddb/indexed_db_blink_mojom_traits_test.cc | 4 ++-- .../indexeddb/indexed_db_database_callbacks_impl.cc | 4 ++-- .../modules/indexeddb/mock_web_idb_database.cc | 4 ---- .../renderer/modules/indexeddb/mock_web_idb_database.h | 6 +----- .../renderer/modules/indexeddb/mock_web_idb_factory.cc | 4 ---- .../renderer/modules/indexeddb/mock_web_idb_factory.h | 4 +--- .../modules/indexeddb/web_idb_callbacks_impl.cc | 18 ++++++------------ .../modules/indexeddb/web_idb_callbacks_impl.h | 5 +---- .../modules/indexeddb/web_idb_cursor_impl_unittest.cc | 12 ++++++------ .../indexeddb/web_idb_database_impl_unittest.cc | 4 ++-- 21 files changed, 55 insertions(+), 89 deletions(-) commit f9a572ae432399ea4283680b02cdc2b5e7c22215 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Mar 15 13:46:46 2019 +0000 Remove useless loop from ContentSetting.java This seems to be a very inefficient way to index an array. Change-Id: Ia37a746554c62f669e20931bf4b566bb56bd31b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524353 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#641177} .../chrome/browser/preferences/website/ContentSetting.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) commit d1867d9ae36b6e09c0ccb04830887bf2a10b9234 Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Mar 15 13:40:13 2019 +0000 Annotate NativeBackgroundTask.java as BOOTSTRAP tasks In future this will prioritize them which will help ensure native is loaded as soon as possible. Bug: 863341 Change-Id: I93eb8d575adf0e68f5dd7e3554370e7588072beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524272 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641176} .../background_task_scheduler/NativeBackgroundTask.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit ea301c1941d6468406dd105c1e878cf135a1f29d Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 13:37:11 2019 +0000 Create the test suite responsible for running the consistency tests. Also includes the first golden file with a few test cases. Bug: 935711 Change-Id: Ife7bb83aee8789bf81aaeea8f20e173b81a69097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494676 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641175} .../consistency_test.cc | 62 ++++++++++++++++++++++ .../goldens/simple_bedtimes.textproto | 62 ++++++++++++++++++++++ chrome/test/BUILD.gn | 4 ++ 3 files changed, 128 insertions(+) commit eda183557a2ec0ce8357a3255f9ae565252cc224 Author: Justin Cohen <justincohen@google.com> Date: Fri Mar 15 13:28:29 2019 +0000 Revert "[iOS] Disable [NTPHomeTestCase testOpeningNewTab]." This reverts commit 41b87eb4713304adf24e36b816b035450418b1f9. Reason for revert: Works around bug with tapping on the tab grid button. For some reason, this tap sometimes triggers a long press. Disabling sync and forcing a 50ms tap seems to work. Original change's description: > [iOS] Disable [NTPHomeTestCase testOpeningNewTab]. > > The test fails on the slimnav and full-configs bots. There is no > suspected culprit CL, and the test seems to be failing due to a > grey_tap() action being executed as a grey_longPress(). > > Bug: 933953 > Change-Id: Ic386d911ab962538139db7a948f37843dc985e2a > TBR: gambard@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1479282 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633939} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933953 Change-Id: I36ca99f02933c6e982bce8139427aa1767f4cfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505994 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641174} ios/chrome/browser/ui/content_suggestions/BUILD.gn | 1 + .../browser/ui/content_suggestions/ntp_home_egtest.mm | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) commit e5294f17b81e7666a4ea484a0ba6ca38753813bb Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Fri Mar 15 13:26:50 2019 +0000 Print Preview: Change Pin setting availability. Make Pin setting unavailable for unmanaged devices and "unsecure" PrintingAllowedPinModes policy value. Bug: 848942 Change-Id: Id867f203225020b3cec115183de33d9a9f196758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509832 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#641173} chrome/browser/resources/print_preview/new/model.js | 7 ++++++- .../webui/print_preview/model_settings_availability_test.js | 12 ++++++++++++ .../data/webui/print_preview/model_settings_policy_test.js | 13 +++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) commit e2d84ae271ef7e28e3cc694ad9a27590355f15b3 Author: Aaron Tagliaboschi <aarontag@chromium.org> Date: Fri Mar 15 13:24:02 2019 +0000 Adding CookieInclusionStatus to Cookie Manager Adding support for net::CanonicalCookie::CookieInclusionStatus into the Cookie Manager to pass status from getting and setting cookies. Mechanical changes for now, changing the callbacks (and related changes) will come in another commit. Bug: 856777 Change-Id: I89b44571a5d8f26f3ace957b640c4078fa3ccba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520693 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641172} net/cookies/canonical_cookie.h | 5 +- services/network/public/cpp/BUILD.gn | 1 + services/network/public/cpp/cookie_manager.typemap | 2 + .../public/cpp/cookie_manager_mojom_traits.cc | 135 +++++++++++++++++++++ .../public/cpp/cookie_manager_mojom_traits.h | 26 ++++ .../cpp/cookie_manager_mojom_traits_unittest.cc | 116 ++++++++++++++++++ services/network/public/mojom/cookie_manager.mojom | 29 +++++ 7 files changed, 313 insertions(+), 1 deletion(-) commit ab6264c3594a412e73a71fca21f67a5b7c3b2c9d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 13:19:40 2019 +0000 Update V8 to version 7.5.53. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1ed1ebd..16271966 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5642f93a0c97073b07404da02632d2b5e3a11e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525812 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641171} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a25c409ebe87ed8165f2b2f51ff7dad9f58b35a8 Author: Andreea Costinas <acostinas@google.com> Date: Fri Mar 15 13:16:11 2019 +0000 Add update mode to policy TPMFirmwareUpdateSettings This CL adds the int-enum option AutoUpdateMode to policy TPMFirmwareUpdateSettings, which controls how TPM firmware update flows are enforced on devices with vulnerable TPM. The option can have one of the following values: 0: Never force update TPM firmware. 1: Update the TPM firmware at the next reboot after user acknowledgment. Implemented in CL:1470751 2: Foce update the TPM firmware at the next reboot. Implemented in CL:1477902 3: Update the TPM firmware after enrollment. Implemented in CL:1483014 Bug:875266 Change-Id: I669560a5fd4671b3fa82694c98b660d535c2ee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1469462 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641170} chrome/browser/chromeos/BUILD.gn | 2 + .../policy/browser_policy_connector_chromeos.cc | 5 + .../policy/browser_policy_connector_chromeos.h | 7 ++ .../policy/tpm_auto_update_mode_policy_handler.cc | 102 +++++++++++++++++++++ .../policy/tpm_auto_update_mode_policy_handler.h | 40 ++++++++ chrome/browser/chromeos/tpm_firmware_update.cc | 6 ++ chrome/browser/chromeos/tpm_firmware_update.h | 1 + chrome/test/data/policy/policy_test_cases.json | 3 +- components/policy/proto/chrome_device_policy.proto | 17 ++++ components/policy/resources/policy_templates.json | 12 +++ 10 files changed, 194 insertions(+), 1 deletion(-) commit 93e7806036ae8630679b30a2a726bdc41dad4a83 Author: Takashi Sakamoto <tasak@google.com> Date: Fri Mar 15 13:14:03 2019 +0000 Add py_proto dependency to chrome/chrome_cleaner/test/resources:compute_sample_dll_digest E.g. https://ci.chromium.org/p/chromium/builders/ci/win-rel/12639 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8918950699201116848/+/steps/compile/0/stdout File "../../chrome/chrome_cleaner/tools/compute_digests.py", line 21, in <module> import file_digest_pb2 File "C:\b\swarming\w\ir\cache\builder\src\out\Release_x64\pyproto\chrome\chrome_cleaner\proto\file_digest_pb2.py", line 22, in <module> TypeError: __init__() got an unexpected keyword argument 'serialized_options' FAILED: gen/chrome/chrome_cleaner/test/resources/sample_dll_digest.pb Change-Id: I3249bc3b56207bf68d33044e69f858308037b66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525259 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#641169} chrome/chrome_cleaner/test/resources/BUILD.gn | 1 + 1 file changed, 1 insertion(+) commit 5d9cb96d4d51f827da22d400c51f6a1683c88900 Author: Marc Treib <treib@chromium.org> Date: Fri Mar 15 13:05:40 2019 +0000 Introduce MockSyncService It's a straightforward mock implementation of SyncService. It's not used so far, but it will be used soon to replace ProfileSyncServiceMock. Bug: 910518 Change-Id: Ifcc3172993991d8698ae5429b387c7149638d2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524277 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641168} components/sync/BUILD.gn | 2 + components/sync/driver/mock_sync_service.cc | 25 ++++++++ components/sync/driver/mock_sync_service.h | 99 +++++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) commit 7c523243a37679f4e4bfa97129f754476fe63398 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 13:04:39 2019 +0000 Roll src/third_party/swiftshader 633b2fb00ed0..e37ce613d1c7 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/633b2fb00ed0..e37ce613d1c7 git log 633b2fb00ed0..e37ce613d1c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 bclayton@google.com SpirvShader: Implement OpBranch 2019-03-15 bclayton@google.com Reactor: Add even more RR_WATCH_FMT_ overloads Created with: gclient setdep -r src/third_party/swiftshader@e37ce613d1c7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I85cb3cb755ed1608c185d2428e1b7423f9e76db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525810 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641167} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 87c784fdfe5746e2f5d021b5df70b924363a9bca Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 13:04:36 2019 +0000 Roll src/third_party/skia d2493a1e53ba..69600007e278 (1 commits) https://skia.googlesource.com/skia.git/+log/d2493a1e53ba..69600007e278 git log d2493a1e53ba..69600007e278 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 633b2fb00ed0..e37ce613d1c7 (2 commits) Created with: gclient setdep -r src/third_party/skia@69600007e278 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I37a9a26bf40117600c708ab2107ffc641e9f6898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525813 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641166} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 363e9bb9c2ff9d1f70f6cccbd9e9c89196a9440d Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 12:40:28 2019 +0000 Clean up unnecessary Create() factory functions in modules/webdatabase As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/modules/webdatabase and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ieb05b6cc4a8e4f6a0938c0732bd6ec68a100fd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524395 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641165} .../modules/webdatabase/change_version_wrapper.cc | 7 ++-- .../blink/renderer/modules/webdatabase/database.cc | 17 ++++----- .../renderer/modules/webdatabase/database_task.h | 42 +++------------------- .../blink/renderer/modules/webdatabase/sql_error.h | 18 +++------- .../modules/webdatabase/sql_statement_backend.cc | 13 +++---- .../modules/webdatabase/sql_transaction.cc | 13 +++---- .../modules/webdatabase/sql_transaction_backend.cc | 14 ++++---- 7 files changed, 43 insertions(+), 81 deletions(-) commit bd555610161ed4963beab8bcdf23782fe87cb6cf Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 12:33:04 2019 +0000 Roll src-internal 798a5f3dda67..59b9a059b2f8 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/798a5f3dda67..59b9a059b2f8 Created with: gclient setdep -r src-internal@59b9a059b2f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I335db1ea7658305c206468fc4da82ca143e782f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525811 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641164} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e68791c36431d0698fa550f2701365c9d514dd1e Author: Oleh Lamzin <lamzin@google.com> Date: Fri Mar 15 12:25:24 2019 +0000 Add DevicePowerPeakShift* device policies Add DevicePowerPeakShiftEnabled, DevicePowerPeakShiftBatteryThreshold and DevicePowerPeakShiftDayConfig device policies. Peak Shift is power saving policy that minimizes alternating current usage during the peak usage times during the day. BUG=b:123925343 TEST=unit_tests/browser_tests Change-Id: I27318e3b2471d45b8257b7e54b463dd30c4e797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491951 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#641163} ash/public/cpp/ash_pref_names.cc | 10 ++ ash/public/cpp/ash_pref_names.h | 4 + ash/shell.cc | 1 + ash/system/power/power_prefs.cc | 10 ++ ash/system/power/power_prefs.h | 4 + .../policy/device_policy_decoder_chromeos.cc | 22 ++++ .../configuration_policy_handler_list_factory.cc | 9 ++ chrome/test/data/policy/policy_test_cases.json | 68 +++++++++++ components/policy/proto/chrome_device_policy.proto | 18 +++ components/policy/resources/policy_templates.json | 136 ++++++++++++++++++++- tools/metrics/histograms/enums.xml | 3 + 11 files changed, 284 insertions(+), 1 deletion(-) commit 4031f28e181ae3a335f80f5d3dc5945e694fe76c Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Mar 15 12:24:07 2019 +0000 Don't match prefers-color-scheme:dark with forced darkening. Forced darkening will adjust the page after author styles are applied. We don't match @media (prefers-color-scheme:dark) which may cause author content to try to adapt before the forced darkening is applied. Bug: 889087 Change-Id: I324ba83ababd568d9c31b198390dce183ec4f402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523766 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641162} .../blink/renderer/core/css/media_values.cc | 2 ++ .../blink/renderer/core/css/style_engine_test.cc | 25 ++++++++++++++++++++++ 2 files changed, 27 insertions(+) commit 5c96b7e56d4dd9a2d72f6ad88ea9feac55fb902f Author: Lin Sun <lin.sun@intel.com> Date: Fri Mar 15 12:13:08 2019 +0000 Remove flaky WebGL2 suppressions for Linux/Intel Bug: 618447, 872302 Change-Id: I0f93c86fedc6ffc22bab5fcc3516be7012f714d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506095 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#641161} content/test/gpu/gpu_tests/webgl2_conformance_expectations.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 0a3218a8bfa93ad43b1ad4df4fe7413451c2764c Author: Balazs Engedy <engedy@chromium.org> Date: Fri Mar 15 12:09:59 2019 +0000 Make engedy@ OWNER of content_settings. Bug: None Change-Id: If5a10d821e7ab228dba6dfd72dff2318762ee1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525923 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#641160} chrome/browser/content_settings/OWNERS | 1 + chrome/browser/ui/content_settings/OWNERS | 1 + components/content_settings/OWNERS | 1 + 3 files changed, 3 insertions(+) commit d029437cb3bfe3585d893fa8b716d25831b30d14 Author: Yuki Shiino <yukishiino@chromium.org> Date: Fri Mar 15 11:57:22 2019 +0000 v8binding: Treat |optional any arg = null| as v8::Null |ScriptValue()| creates an empty ScriptValue, which corresponds to |v8::Local<v8::Value>()| (empty handle), which will be v8::Undefined. It's not v8::Null. This patch makes it v8::Null explicitly. Change-Id: Ibf5afaff05174bb1458e86fc84fd8c8e8010a6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520523 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641159} third_party/blink/renderer/bindings/scripts/v8_types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 463cf9e8847a310f7a5ef0b8fae77750fc94e22c Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:54:40 2019 +0000 Clean up unnecessary Create() factory functions in modules' medaistream and service_worker As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/modules/mediastream and service_worker and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: If0e295dcc02093c7c70d29e559705e004ed930cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525260 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641158} .../blink/renderer/modules/mediastream/user_media_client.h | 6 +----- third_party/blink/renderer/modules/modules_initializer.cc | 3 ++- .../service_worker/service_worker_installed_scripts_manager.cc | 2 +- .../modules/service_worker/thread_safe_script_container.cc | 9 --------- .../modules/service_worker/thread_safe_script_container.h | 10 +++------- .../service_worker/thread_safe_script_container_test.cc | 9 +++++---- 6 files changed, 12 insertions(+), 27 deletions(-) commit 86b7b16e74e935d2103d2dbea8c21ada198220e2 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:53:55 2019 +0000 Remove WebRTCStatsReportCallbackResolver::Create in modules/peerconnection As advised in [1], this CL removes unnecessary WebRTCStatsReportCallbackResolver::Create() in //third_party/blink/renderer/modules/indexeddb and make their constructors public, then make the callers use std::make_unique<WebRTCStatsReportCallbackResolver> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I2adebce9cf1df122e400a08a83bc9f9aa895c6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524391 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641157} .../blink/renderer/modules/peerconnection/rtc_peer_connection.cc | 5 +++-- .../blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc | 5 +++-- .../blink/renderer/modules/peerconnection/rtc_rtp_sender.cc | 5 +++-- .../peerconnection/web_rtc_stats_report_callback_resolver.cc | 7 ------- .../peerconnection/web_rtc_stats_report_callback_resolver.h | 5 +---- 5 files changed, 10 insertions(+), 17 deletions(-) commit a9296c7b266ddbc19d22606d34384607038d362f Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:53:35 2019 +0000 Clean up unnecessary Create() factory functions in platform/audio As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/audio and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic613dd9ef74061fe92234fbd9680cab37f3db5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525762 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641156} .../modules/webaudio/stereo_panner_node.cc | 2 +- .../blink/renderer/platform/audio/hrtf_database.cc | 4 --- .../blink/renderer/platform/audio/hrtf_database.h | 4 +-- .../platform/audio/hrtf_database_loader.cc | 2 +- .../renderer/platform/audio/hrtf_elevation.cc | 8 +++--- .../blink/renderer/platform/audio/hrtf_kernel.cc | 4 +-- .../blink/renderer/platform/audio/hrtf_kernel.h | 29 ++++++---------------- .../blink/renderer/platform/audio/stereo_panner.cc | 4 --- .../blink/renderer/platform/audio/stereo_panner.h | 4 +-- 9 files changed, 17 insertions(+), 44 deletions(-) commit 3941c4781bd0d88283d671805ed22283e49b163d Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:52:50 2019 +0000 Remove BlobData::Create() in blink As advised in [1], this CL removes unnecessary BlobData::Create() in //third_party/blink/renderer/ and make it's constructors public, then make the callers use std::make_unique<BlobData> instead of their Create() factory function. Additionally this CL makes to use auto keyword when creating a local variable by using std::make_unique<BlobData> because it's clear the returned type is std::unique_ptr. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Id5800e816128f640f79e1c422ff0b98a57798e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525786 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641155} .../renderer/core/clipboard/data_object_item.cc | 2 +- .../blink/renderer/core/exported/web_blob.cc | 2 +- third_party/blink/renderer/core/fetch/body.cc | 2 +- .../renderer/core/fetch/body_stream_buffer_test.cc | 2 +- .../renderer/core/fetch/bytes_consumer_tee_test.cc | 4 ++-- .../blink/renderer/core/fetch/fetch_data_loader.cc | 6 ++--- .../renderer/core/fetch/fetch_data_loader_test.cc | 4 ++-- .../core/fetch/form_data_bytes_consumer.cc | 4 ++-- .../core/fetch/form_data_bytes_consumer_test.cc | 2 +- third_party/blink/renderer/core/fileapi/blob.cc | 6 ++--- third_party/blink/renderer/core/fileapi/file.cc | 10 ++++----- .../core/xmlhttprequest/xml_http_request.cc | 4 ++-- .../blink/renderer/modules/cache_storage/cache.cc | 4 ++-- .../modules/filesystem/file_system_dispatcher.cc | 2 +- .../modules/indexeddb/idb_value_wrapping.cc | 2 +- .../modules/mediarecorder/media_recorder.cc | 2 +- .../presentation/presentation_connection.cc | 2 +- .../modules/push_messaging/push_message_data.cc | 2 +- .../renderer/modules/websockets/dom_websocket.cc | 2 +- .../blink/renderer/platform/blob/blob_data.cc | 5 ----- .../blink/renderer/platform/blob/blob_data.h | 16 ++++++------- .../blink/renderer/platform/blob/blob_data_test.cc | 26 +++++++++++----------- 22 files changed, 52 insertions(+), 59 deletions(-) commit bf60ea0026156b48884edd4817ef17c54cbb31f9 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:52:30 2019 +0000 Clean up unnecessary Create() factory functions in platform/bindings As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/bindings and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I0a28a2b8ce259313b6e2c55ed69d6d52eb36437d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525767 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641154} .../bindings/core/v8/v0_custom_element_constructor_builder.cc | 4 ++-- third_party/blink/renderer/platform/bindings/script_state.cc | 2 +- .../blink/renderer/platform/bindings/v0_custom_element_binding.cc | 6 ------ .../blink/renderer/platform/bindings/v0_custom_element_binding.h | 5 +---- .../blink/renderer/platform/bindings/v8_per_context_data.cc | 5 ----- .../blink/renderer/platform/bindings/v8_per_context_data.h | 4 +--- .../blink/renderer/platform/bindings/v8_per_isolate_data.cc | 4 ++-- .../blink/renderer/platform/bindings/v8_private_property.h | 8 ++------ 8 files changed, 9 insertions(+), 29 deletions(-) commit 8532eaa24218e5856bb969f87a2a749abf6fb70c Author: Robbie Gibson <rkgibson@google.com> Date: Fri Mar 15 11:43:24 2019 +0000 Switch Bing search-by-image to upload image data instead of URL The current Bing Search-by-image URL is the one for searching based off of an image's url. However, we now have cases where we want to search by the image data, which uses a different parameter. Also, in all cases where we search with the url today, we also have the image data already. This CL also adds support for converting the image data to a base64 encoding, as that is what Bing uses. If there is some process for updating search engines, let me know. I also thought about a way to support both versions of the image search url (search by url and image data) but couldn't come up with a good solution. Bug: 938669 Change-Id: I978c7a45bcd37835cda15f43a93bec0b8737b6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508394 Reviewed-by: Orin Jaworski <orinj@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#641153} components/search_engines/prepopulated_engines.json | 6 +++--- components/search_engines/template_url.cc | 14 ++++++++++++++ components/search_engines/template_url.h | 1 + components/search_engines/template_url_unittest.cc | 14 ++++++++++++-- 4 files changed, 30 insertions(+), 5 deletions(-) commit c6b4325b4fc9acb774ca9956fb76d37325bebd6c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 11:40:41 2019 +0000 Roll src/third_party/skia aefecad7c0d2..d2493a1e53ba (1 commits) https://skia.googlesource.com/skia.git/+log/aefecad7c0d2..d2493a1e53ba git log aefecad7c0d2..d2493a1e53ba --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1b8cd2d9ce2c..633b2fb00ed0 (1 commits) Created with: gclient setdep -r src/third_party/skia@d2493a1e53ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6889d98e44029bfa62bd8779d583b2724c7468ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525808 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641152} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bfcf35ffb0447b9e863a10768e23989a952a939b Author: iOS Autoroller <ios-autoroller@chromium.org> Date: Fri Mar 15 11:40:00 2019 +0000 [MDC roll] Roll Material Components to d4fdb374214cfe2010d167338affd3fa9e67263c TBR=smut Change-Id: Ibe4f52c66ed13d88b41b902c805b03b34fe993ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525419 Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#641151} DEPS | 2 +- ios/third_party/material_components_ios/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e04a4c8e055c2864e624b21c3db18ccfb9804cf8 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 11:22:11 2019 +0000 Update V8 to version 7.5.50. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4181d035..d1ed1ebd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53e7c07d83fe3bf80051a05b57852875951d5eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525473 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641150} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c6a0a663cf3715fdf2d1187c398cb903cafdbe21 Author: Boris Sazonov <bsazonov@chromium.org> Date: Fri Mar 15 11:15:31 2019 +0000 [Android] Extract FreIntentCreator This CL extracts FreIntentCreator class that takes care of creating an intent to launch First Run Experience. Instances of this class are created using AppHooks, allowing downstream adjustments. Bug: 942175 Change-Id: I7f5c67d91f8d09d8b9945af87e6f905d1b67149c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520605 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#641149} .../src/org/chromium/chrome/browser/AppHooks.java | 8 + .../browser/firstrun/FirstRunFlowSequencer.java | 159 +----------------- .../chrome/browser/firstrun/FreIntentCreator.java | 183 +++++++++++++++++++++ chrome/android/java_sources.gni | 1 + 4 files changed, 197 insertions(+), 154 deletions(-) commit 52e32015d63e910a64a0829041142780a2b9cc86 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Fri Mar 15 11:02:50 2019 +0000 a11y: Fix cfi-icall failure Control Flow Integrity indirect call checking [1] verifies that indirect calls are only made to functions defined with a type signature that matches the function pointer type. The accessibility_unittests fail with CFI-icall enabled when a test casts a lambda so types don't match; however, from my brief look at ATK I believe that 3rd-party DSOs can also register callbacks. There is currently only a way to safely perform calls to functions that are address-taken in other DSOs when there is a single possible target. Hence, disable CFI-icall here for now. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 941466 Change-Id: If4550beb1101c8077f394e717b5bdc052e173049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524649 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#641148} ui/accessibility/platform/atk_util_auralinux.cc | 2 ++ 1 file changed, 2 insertions(+) commit 6b998b00a2a930b24c8b006344595630389d6cef Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 10:58:10 2019 +0000 Import wpt@b90e1587455350962c4efc39b7c1bbf588d6ab64 Using wpt-import in Chromium 80d04032c47e38b504e174750ec5bcb9900e482a. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I846b81cf7b8a0e7c53987cf49031bde4cdbd7232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525675 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641147} third_party/blink/web_tests/TestExpectations | 5 - .../web_tests/external/WPT_BASE_MANIFEST_5.json | 145 ++++++++++++++------- .../external/wpt/interfaces/wake-lock.idl | 13 +- .../wake-lock/idlharness.https.any-expected.txt | 21 +++ .../external/wpt/wake-lock/idlharness.https.any.js | 16 +++ .../idlharness.https.any.worker-expected.txt | 21 +++ .../wpt/wake-lock/idlharness.https.window.js | 31 ----- .../external/wpt/wake-lock/wakelock-api.https.html | 20 --- ...akelock-applicability-manual.https-expected.txt | 5 + .../wakelock-applicability-manual.https.html | 26 ++-- .../wpt/wake-lock/wakelock-cancel-twice.https.html | 20 --- .../wakelock-document-hidden.https-expected.txt | 4 + .../wake-lock/wakelock-document-hidden.https.html | 10 +- .../wpt/wake-lock/wakelock-insecure-context.html | 2 +- .../wakelock-onactivechange.https-expected.txt | 4 + .../wake-lock/wakelock-onactivechange.https.html | 9 +- .../wpt/wake-lock/wakelock-promise.https.html | 13 -- .../wakelock-state-is-global.https-expected.txt | 4 + .../wake-lock/wakelock-state-is-global.https.html | 12 +- .../wpt/wake-lock/wakelock-type.https-expected.txt | 7 + .../wpt/wake-lock/wakelock-type.https.html | 28 ++-- .../wakelockrequest-is-independent.https.html | 15 --- .../nested-context-navigations-expected.txt | 0 .../nested-context-navigations-expected.txt | 21 +++ 24 files changed, 261 insertions(+), 191 deletions(-) commit 7272f741496ecd9aab6013c328c24a193c868d07 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Fri Mar 15 10:48:13 2019 +0000 Make autofill tests working with RenderDocument. RenderDocument is making Chrome switching RenderFrameHost on each Documents. RenderFrameHost are currently switched on each cross-process navigations. In the future, they will be switched on each same-process navigation as well. The class autofill_uitest instruments the AutofillManager associated with the current main RenderFrameHost. The tests assumes it will be preserved. With RenderDocument, it will be swapped after each new document. This CL makes the following RenderFrameHost to be instrumented as well. Bug: 936696, 940935 Change-Id: I23f9785781df1b1921778d1ff6269d69e248ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520843 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641146} chrome/browser/autofill/autofill_uitest.cc | 20 +++++++++++++++----- chrome/browser/autofill/autofill_uitest.h | 8 +++++++- 2 files changed, 22 insertions(+), 6 deletions(-) commit d92df3877b1aa5926abdb5bcd99cb55ba5bf3ffe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 10:44:31 2019 +0000 Roll src/third_party/swiftshader 1b8cd2d9ce2c..633b2fb00ed0 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1b8cd2d9ce2c..633b2fb00ed0 git log 1b8cd2d9ce2c..633b2fb00ed0 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 swiftshader.regress@gmail.com Regres: Update test lists @ 1b8cd2d9 Created with: gclient setdep -r src/third_party/swiftshader@633b2fb00ed0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I67f5d65972780f949c3f86d35e16fe5aec5a802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525807 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641145} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9cb0c848a58b49ae9e75e9d25e9e1400cc9fbed7 Author: Marc Treib <treib@chromium.org> Date: Fri Mar 15 10:40:22 2019 +0000 Rewrite ExternalPrefLoaderTest in terms of TestSyncService ...instead of ProfileSyncServiceMock, which is an antipattern. Bug: 910518 Change-Id: I4ff332d9aa851886954e0a1c72da296668c56915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523706 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#641144} .../extensions/external_pref_loader_unittest.cc | 42 +++++----------------- 1 file changed, 9 insertions(+), 33 deletions(-) commit 9c67c048f084beaeeee9a53146f9184cfe156399 Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Mar 15 10:40:19 2019 +0000 Revert "media: Remove VaapiVP8Encoder media_feature" This reverts commit 169c1a699fcc58ee3bfb3cd30f02484794056adb. The VP8 stream generated by using VA-API causes some issues on targets. To disable HW VP8 encoding using VA-API via finch, we should recover this feature variable. TBR=beccahughes@chromium.org Bug: 942419 Test: None Change-Id: I5617fa55e3cb1af74b1e4fe7eaef1ed84e681c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525784 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641143} media/base/media_switches.cc | 4 ++++ media/base/media_switches.h | 1 + media/gpu/vaapi/vaapi_wrapper.cc | 7 +++++++ 3 files changed, 12 insertions(+) commit cf85bf419e279db0d606f15e6035d32e90161a5e Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Mar 15 09:56:18 2019 +0000 Use failing URL to load the error page. VirtualURL should not be used as the baseURL to load error page. VirtualURL can be set by the client and can be different from URL which will will lead to navigationItem inconsistencies. Instead, the WebView should load the failing URL or the URL extracted from the placeholder. Bug: 942025 Change-Id: I425ff6c62aedf9d205a6918e5655bad3a7cca54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524263 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641142} ios/web/web_state/error_page_inttest.mm | 20 ++++++++++++++++++++ ios/web/web_state/ui/crw_web_controller.mm | 17 ++++++++--------- 2 files changed, 28 insertions(+), 9 deletions(-) commit 72a1bcfe791c4bb76c654d8caa2190a327bbf854 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri Mar 15 09:46:09 2019 +0000 [css-multicol] Mark some functions/classes final R=mstensho@chromium.org Change-Id: Ic60362dee1a92a029c470ee06ac3f007f3f08142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524904 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#641141} .../core/layout/layout_multi_column_flow_thread.h | 16 ++++++++-------- .../blink/renderer/core/layout/layout_multi_column_set.h | 2 +- .../renderer/core/layout/layout_paged_flow_thread.h | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) commit c7ed6319ca44efd25367d3d89759e78a7088d52e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 09:45:03 2019 +0000 Roll src-internal ff717d8fff9b..798a5f3dda67 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff717d8fff9b..798a5f3dda67 Created with: gclient setdep -r src-internal@798a5f3dda67 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I784cc616761f2eb8b15ef20106021db585c24d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525806 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641140} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 00804c8d0bb340e2b5b38157f6ae6b2353fb5d6e Author: Dominik Röttsches <drott@chromium.org> Date: Fri Mar 15 09:44:01 2019 +0000 Roll src/third_party/harfbuzz-ng/src/ 4f37ab63d..8aaab78ef (16 commits) https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/4f37ab63de97..8aaab78efcac The included fix for HarfBuzz issue #1617 addresses Chromium issue 939285, the rejection at sanitisation stage of variable fonts with 0 named instances. $ git log 4f37ab63d..8aaab78ef --date=short --no-merges --format='%ad %ae %s' 2019-03-14 ebrahim Allow zero length ranges in sanitization (#1617) 2019-03-14 khaledhosny [ci] Cache FreeType build on Travis 2019-03-12 corbett.dav Categorize U+09FC as Consonant_Placeholder 2019-03-13 khaledhosny [ci] Simplify and fix Travis CI macOS build 2019-03-11 behdad Remove redundant hb_ot_layout_lookup_would_substitute_fast 2019-03-12 khaledhosny [doc] Add placeholder since version for new flag 2019-03-08 corbett.dav Remove obsolete overrides from Indic/USE scripts 2019-02-12 emuller Update generation code for hb-ot-shape-complex-vowel-constraints.cc. Remove 'unlikely' 2019-02-10 emuller Fix coding style. 2019-02-09 emuller Add a flag to hb_buffer_t to prevent the insertion of dotted circles on incorrect character sequences. 2019-03-08 ebrahim Add a macOS 10.14.3 fonts tests (#1608) 2019-03-06 corbett.dav Update to Unicode 12.0.0 2019-02-13 adrianwjw [indic] Remove superfluous ZWNJ check in final reorder of pre-base matras 2019-03-05 sbergman Fix hb_atomic_* variants based on C++11 atomics 2019-03-04 martin_hosken Fix offset drift in graphite integration 2019-03-02 ebrahim Minor, remove .editorconfig hack Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 939285 Change-Id: I1a2db150a65db902a6cb2890f93b04e7430357fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524292 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#641139} DEPS | 2 +- third_party/harfbuzz-ng/README.chromium | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) commit 8a24757ea784afcc4cedf29cbd33984f4feea29b Author: Yu-Hsuan Hsu <yuhsuan@chromium.org> Date: Fri Mar 15 09:43:58 2019 +0000 Moving SoundsManager to use audio service Don't use audio manager instance directly to create output streams in SoundsManager, use audio service instead. In detail, use output device in audio_stream_handler. Bug: 847212 Change-Id: I8ff131af309ed9b0a5e27e59bdffbe63e241deab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482276 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641138} .../chromeos/chrome_browser_main_chromeos.cc | 5 +- chrome/browser/chromeos/login/kiosk_browsertest.cc | 7 +- .../chromeos/login/lock/screen_locker_unittest.cc | 18 ++- chrome/browser/vr/sounds_manager_audio_delegate.cc | 9 +- services/audio/BUILD.gn | 2 - services/audio/public/cpp/BUILD.gn | 2 + .../audio/public/cpp/debug_recording_session.cc | 1 - .../public/cpp/sounds/audio_stream_handler.cc | 145 +++++++++------------ .../audio/public/cpp/sounds/audio_stream_handler.h | 25 ++-- .../cpp/sounds/audio_stream_handler_unittest.cc | 60 ++++----- services/audio/public/cpp/sounds/sounds_manager.cc | 15 ++- services/audio/public/cpp/sounds/sounds_manager.h | 5 +- .../public/cpp/sounds/sounds_manager_unittest.cc | 26 +--- services/audio/public/cpp/sounds/test_data.cc | 23 +++- services/audio/public/cpp/sounds/test_data.h | 22 ++-- 15 files changed, 186 insertions(+), 179 deletions(-) commit 29d132569770b641c28e5cc5dab7e021121cf138 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 09:38:38 2019 +0000 Roll src/third_party/dawn d263d752ac35..931311700c7c (1 commits) https://dawn.googlesource.com/dawn.git/+log/d263d752ac35..931311700c7c git log d263d752ac35..931311700c7c --date=short --no-merges --format='%ad %ae %s' 2019-03-15 jiawei.shao@intel.com Add validation on the sample count of the depth stencil attachment Created with: gclient setdep -r src/third_party/dawn@931311700c7c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ida00edb4fa4cb68defdbec638a98cdee583edd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525802 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641137} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e722f040f6f467b42aa897d4d26c0a28602f0789 Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Fri Mar 15 09:35:28 2019 +0000 [ribbon] Merge css_property_base_custom.cc into css_property.cc. Now that CSSProperty is not generated, we don't need this file. Note: The functions have been moved without any modification. Change-Id: I1ab12d34b9df452ecea74a7f977b0719e8bdc892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506514 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641136} third_party/blink/renderer/core/css/BUILD.gn | 1 - .../renderer/core/css/properties/css_property.cc | 91 ++++++++++++++++++ .../css/properties/css_property_base_custom.cc | 103 --------------------- 3 files changed, 91 insertions(+), 104 deletions(-) commit 10142116fbc66f09b8af63bea339254ef0e6ac74 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 09:33:17 2019 +0000 Roll Fuchsia SDK from 1a0b0112a4d8 to 644d5b59c068 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I71bbea5dedcf93d83713ed9de9b54764a5ec4053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525805 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641135} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit d6e25304636313702a581628263139eee1f4cff1 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Mar 15 09:19:43 2019 +0000 Format brackets in PasswordManager::OnPasswordFormsRendered. Change-Id: I56603ab0a9ceed0f8df23ff4b4e9512b63b03ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524271 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#641134} .../core/browser/password_manager.cc | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 8d3be0305b450d2eedccf12863b38118cd511e36 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Mar 15 09:16:56 2019 +0000 Migrate ServiceWorkerScriptCacheMap methods to net::CompletionOnceCallback Replace usage of net::CompletionCallback and update callers. Bug: 807724 Change-Id: I90f180fa481ea20e5e67aaab08f27e421342ca39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524045 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641133} .../service_worker/service_worker_script_cache_map.cc | 19 +++++++++++-------- .../service_worker/service_worker_script_cache_map.h | 8 ++++---- .../browser/service_worker/service_worker_version.cc | 8 ++++---- 3 files changed, 19 insertions(+), 16 deletions(-) commit 082829750298c5c54b14187123c07d6b2d2eb7ad Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Mar 15 09:12:24 2019 +0000 [java] Prioritize bootstrap and navigation tasks behind a feature flag. When prioritizing tasks SingleThreadTaskRunnerImpl will post async messages at the head of the queue. It's important for these messages to be async because we want to bypass the java fences and run the tasks immediately, rather than having them batched up to run every vsync. Bug: 863341 Change-Id: I4faf7846e628cc05c05809e626d22788ae9a148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514533 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641132} .../base/task/SingleThreadTaskRunnerImpl.java | 45 +++++++++++++++++++--- .../base/task/SingleThreadTaskRunnerImplTest.java | 37 ++++++++++++++++-- .../browser/init/ProcessInitializationHandler.java | 3 ++ .../browser/BrowserTaskExecutor.java | 29 +++++++++++++- .../browser/scheduler/UiThreadSchedulerTest.java | 32 +++++++++++++++ 5 files changed, 135 insertions(+), 11 deletions(-) commit 0709283f45fa0c69e411c99a2043481ab78b0d5a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 09:00:14 2019 +0000 Roll src/third_party/chromite 5d06c3522353..35b4e4c67938 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d06c3522353..35b4e4c67938 git log 5d06c3522353..35b4e4c67938 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dhanyaganesh@chromium.org chromite: Use master_buildbucket_id instead of master_build_id Created with: gclient setdep -r src/third_party/chromite@35b4e4c67938 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I3d3138b4655d0033f907d24640d645a87a455b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525804 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641131} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 455cad9e41974edec1df88f7aa42d9ae8ce87877 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Mar 15 08:48:46 2019 +0000 RemoteMacViews: Replace IOSurface with CAContext in gfx::CALayerParams A gfx::CALayerParams may pass the content to be drawn across processes via either an IOSurface (sent as mach port) or a CAContextID (which is an integer). For historical reasons (software compositing output surfaces used to be based in the browser process), software compositing uses IOSurfaces instead of CAContextIDs. The mojo connection to the app shim process does not support sending mach ports, which results in nothing being drawn when using software compositing. To work around this issue, add a IOSurfaceToRemoteLayerInterceptor that inspects the gfx::CALayerParameters before they are sent from BridgedNativeWidgetHost to its BridgedNativeWidget, and re-packages the IOSurface as a CAContextID on the fly. Restrict this workaround to only be applied when the BridgedNativeWidget is out-of-process (that is, when using a PWA) to avoid unforeseen consequences impacting release branches. Bug: 942213 Change-Id: I30ff907e62d9d4c9416bfde9771529a13e012600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525625 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#641130} ui/views/BUILD.gn | 1 + ui/views/cocoa/bridged_native_widget_host_impl.h | 6 ++ ui/views/cocoa/bridged_native_widget_host_impl.mm | 78 ++++++++++++++++++++++- 3 files changed, 83 insertions(+), 2 deletions(-) commit 1f4ad234db2f13bbaa280b7e933ed9b888b0e35b Author: Richard Knoll <knollr@chromium.org> Date: Fri Mar 15 08:46:40 2019 +0000 Invalidate notification content view on update. We need to recalculate the layout as the right content might add or remove the icon view on update. Bug: 937862 Change-Id: Ibc96cb0580c9fcd3f6446d5a969b63ed6dcbf5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523391 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641129} ui/message_center/views/notification_view_md.cc | 2 +- ui/message_center/views/notification_view_md.h | 25 +++++++++++----------- .../views/notification_view_md_unittest.cc | 25 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 13 deletions(-) commit 86ac38b4d765e1b4945678e85179060c42e52d8c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 08:44:00 2019 +0000 Update V8 to version 7.5.48. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6ea6c00..4181d035 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd0b1091d0a43f79a40dfd9609ce3cf0b75fae59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525683 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641128} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 906b794a4ef51432fb2cf08f2bd54b5109aa5c38 Author: Siye Liu <siliu@microsoft.com> Date: Fri Mar 15 08:41:30 2019 +0000 Hook up InputMethodWinTSF with IME extension on Windows. This CL hooks up InputMethodWinTsf with IME extension. Since ui::TSFBridge may be null for unit tests, this Cl also adds protection in InputMethodWinTSF. Bug: 657623 Change-Id: I608ceba376f0fdba537339030d35c11993e16822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507234 Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#641127} ui/base/ime/input_method_win_base.cc | 44 +++++++++++++++++++++++++++++++++++ ui/base/ime/input_method_win_base.h | 13 +++++++++++ ui/base/ime/input_method_win_imm32.cc | 36 ++++------------------------ ui/base/ime/input_method_win_tsf.cc | 41 +++++++++++++++++++++++++++----- ui/base/ime/win/tsf_text_store.cc | 2 +- 5 files changed, 97 insertions(+), 39 deletions(-) commit 789f0c99464682927ad8c2edfc5c5c787061e0d6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 08:37:09 2019 +0000 Roll src/third_party/skia 61d38ade8c1d..aefecad7c0d2 (1 commits) https://skia.googlesource.com/skia.git/+log/61d38ade8c1d..aefecad7c0d2 git log 61d38ade8c1d..aefecad7c0d2 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6299cd6e9d2d..558a982945cf (482 commits) Created with: gclient setdep -r src/third_party/skia@aefecad7c0d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I7f933a6902fdd6e893e026b07b75a9b7843e3098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525803 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641126} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 418708c1c3f7cadf639c910dfd83915eab707b0d Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 08:35:54 2019 +0000 Add DawnControlClientHolder to track Dawn client state WebGPU objects will be backed by Dawn objects. If the Dawn client is destroyed, Dawn objects are destroyed by the Dawn Wire. The Blink WebGPU objects need to know if the client is destroyed so that they do not call the destructors and double-free Dawn handles. Bug: 941536 Change-Id: I288ec5c55a29ae135c4ec0b202bdd7d61e781d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519552 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641125} third_party/blink/renderer/modules/webgpu/BUILD.gn | 4 +++ .../modules/webgpu/dawn_control_client_holder.cc | 28 +++++++++++++++ .../modules/webgpu/dawn_control_client_holder.h | 42 ++++++++++++++++++++++ .../blink/renderer/modules/webgpu/dawn_object.cc | 30 ++++++++++++++++ .../blink/renderer/modules/webgpu/dawn_object.h | 42 ++++++++++++++++++++++ third_party/blink/renderer/modules/webgpu/gpu.cc | 8 +++-- third_party/blink/renderer/modules/webgpu/gpu.h | 7 ++-- .../blink/renderer/modules/webgpu/gpu_adapter.cc | 16 ++++++--- .../blink/renderer/modules/webgpu/gpu_adapter.h | 13 ++++--- .../blink/renderer/modules/webgpu/gpu_device.cc | 16 ++++++--- .../blink/renderer/modules/webgpu/gpu_device.h | 19 ++++++---- 11 files changed, 198 insertions(+), 27 deletions(-) commit bf9177139b45e47eaba377c40383b2e704de9f02 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 08:35:49 2019 +0000 Roll src-internal 824201d8b700..ff717d8fff9b (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/824201d8b700..ff717d8fff9b Created with: gclient setdep -r src-internal@ff717d8fff9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I90c63a17303b8434c18708bb87a6a3d56e2a05f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525801 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641124} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80d04032c47e38b504e174750ec5bcb9900e482a Author: Yoav Weiss <yoavweiss@chromium.org> Date: Fri Mar 15 08:12:06 2019 +0000 [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] https://github.com/web-platform-tests/wpt/pull/13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123} .../blink/renderer/core/timing/performance.cc | 3 +- .../blink/web_tests/external/wpt/lint.whitelist | 3 +- ...AO-case-insensitive-null-opaque-origin.sub.html | 42 ++++++++++++++++++++++ .../TAO-null-opaque-origin.sub.html | 42 ++++++++++++++++++++++ .../wpt/resource-timing/resources/TAOResponse.py | 5 ++- 5 files changed, 91 insertions(+), 4 deletions(-) commit 1fb467a0ae1898a8e69f282b6ab5bd4ac61eca79 Author: Colin Blundell <blundell@chromium.org> Date: Fri Mar 15 08:07:16 2019 +0000 Change content_shell to lazily create PowerMonitorTestImpl PowerMonitorTestImpl must live entirely on the main thread of the child process, as the global PowerMonitor instance that it accesses can only be accessed from the main thread. Currently, content_shell's child processes create a PowerMonitorTestImpl instance and pass it to their BinderRegistry as a bound argument of a PowerMonitorTestImpl::MakeStrongBinding() callback. This BinderRegistry lives on the IO thread. While the child processes specify that the binding should be done on the main thread, if a PowerMonitorRequest never comes in from the browser the PowerMonitorTestImpl instance will be destroyed on the IO thread when the BinderRegistry is destroyed. This leads to MSAN crashes in content_shell (crbug.com/940283 is restricted, but just shows that that the PowerMonitor global that PowerMonitorTestImpl accesses in its destructor is unitialized, which is due to the PowerMonitorTestImpl destructor and PowerMonitor destructor racing with each other on different threads). To eliminate these crashes, this CL changes PowerMonitorTestImpl to be created on-demand. Making this change also requires that the PowerMonitor browsertest ensure that the PowerMonitorTestImpl instances have been created in the various child processes before simulating power state changes that those instances are supposed to observe, as the simulation of the power state changes occurs on a different Mojo pipe than that of the PowerMonitorTest connection. Bug: 940283 Change-Id: I369b365cfece451a89cc1844695d3571abfc310f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522992 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641122} content/browser/power_monitor_browsertest.cc | 15 +++++++++++++++ content/shell/common/power_monitor_test_impl.cc | 4 ++-- content/shell/common/power_monitor_test_impl.h | 1 - content/shell/gpu/shell_content_gpu_client.cc | 4 +--- content/shell/renderer/shell_content_renderer_client.cc | 3 +-- content/shell/utility/shell_content_utility_client.cc | 4 +--- 6 files changed, 20 insertions(+), 11 deletions(-) commit 9880c61d56788f36e54adfe50348b0618039fbff Author: Colin Blundell <blundell@chromium.org> Date: Fri Mar 15 07:58:04 2019 +0000 Add blundell to //chrome OWNERS Change-Id: I7ad4f41c3af77ea60587555f87a493462305bba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520597 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641121} chrome/OWNERS | 1 + 1 file changed, 1 insertion(+) commit 2e31d2510d218206cbd64012fb77e08cc5185db3 Author: Eyor Alemayehu <eyor@google.com> Date: Fri Mar 15 07:43:24 2019 +0000 Disable screen context toggle in setup if disabled by administrator A G-Suite user should not be able to do a screen context query if it is disabled by the administrator. Therefore, we should not allow the G-Suite user to enable screen context queries during the setup flow. This is currently implemented by disabling the screen context toggle and setting it to false. Bug: 941818 Change-Id: I6bfff2387e2e2994e3358a5f24f621f70a9adfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518062 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641120} .../chromeos/assistant_optin/assistant_get_more.js | 3 ++ .../assistant_optin/assistant_optin_utils.cc | 34 ++++++++++++++++++++-- .../assistant_optin/assistant_optin_utils.h | 15 ++++++---- .../login/assistant_optin_flow_screen_handler.cc | 7 ++++- .../settings/chromeos/google_assistant_handler.cc | 1 + 5 files changed, 50 insertions(+), 10 deletions(-) commit 55f6ecb9a35ee316dd1887a38be0c9aa64c557e9 Author: Dominick Ng <dominickn@chromium.org> Date: Fri Mar 15 07:38:27 2019 +0000 Record the correct install source in BookmarkAppInstallationTask. Prior to this CL, BookmarkAppInstallationTask exclusively passed WebappInstallSource::MENU_BROWSER_TAB to BookmarkAppHelper, which would eventually record the source in the Webapp.Install.InstallEvent metric. This causes huge skew in the metric on Chrome OS, which uses the pending queue for default installation. This CL introduces new metric categories for the different default install categories and updates BookmarkAppInstallationTask to use them, correcting the skew. BUG=942402 Change-Id: Iada40c6a918c095e35948ab8e73ff5da8726c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525256 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#641119} chrome/browser/installable/installable_metrics.cc | 7 ++++++- chrome/browser/installable/installable_metrics.h | 13 +++++++++++++ .../extensions/bookmark_app_installation_task.cc | 22 +++++++++++++++++++--- tools/metrics/histograms/enums.xml | 4 ++++ 4 files changed, 42 insertions(+), 4 deletions(-) commit 72739caa4a3b6f677d296b0adc937a3927a18da1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 07:38:17 2019 +0000 Roll src/third_party/skia 5366a45c6103..61d38ade8c1d (2 commits) https://skia.googlesource.com/skia.git/+log/5366a45c6103..61d38ade8c1d git log 5366a45c6103..61d38ade8c1d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 979f3bbe2c50..2fb6563bf503 (2 commits) Created with: gclient setdep -r src/third_party/skia@61d38ade8c1d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6ab8ff085cf11408d663253c0d8c124c9895a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525469 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641118} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af6978673f6a47555c15cacb5fbe9b1a8dd07c9f Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Mar 15 07:32:57 2019 +0000 Stop FetchClientSettingsObject::GetAddressSpace from returning optional Bug: 914739 Change-Id: I95cc0ecfa16624e16aff17097e9587ecd4756dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524394 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#641117} third_party/blink/renderer/core/loader/base_fetch_context.cc | 5 ++--- .../renderer/core/script/fetch_client_settings_object_impl.cc | 3 +-- .../renderer/core/script/fetch_client_settings_object_impl.h | 2 +- .../platform/loader/fetch/fetch_client_settings_object.h | 4 +--- .../loader/fetch/fetch_client_settings_object_snapshot.cc | 2 +- .../loader/fetch/fetch_client_settings_object_snapshot.h | 10 +++++----- 6 files changed, 11 insertions(+), 15 deletions(-) commit e095d73a8f2f2cfd6a258a805d4a64c09a896b49 Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 07:27:03 2019 +0000 Create GPUDevice from GPUDeviceDescriptor This patch updates GPUAdapter::createDevice to take a GPUDeviceDescriptor which will contain parameters for Device creation. Bug: 941531 Change-Id: I2c96a892846a8ec7ee2e0cf253141faac5b871e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521236 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641116} third_party/blink/renderer/modules/modules_idl_files.gni | 3 +++ third_party/blink/renderer/modules/webgpu/gpu_adapter.cc | 4 ++-- third_party/blink/renderer/modules/webgpu/gpu_adapter.h | 3 ++- third_party/blink/renderer/modules/webgpu/gpu_adapter.idl | 2 +- third_party/blink/renderer/modules/webgpu/gpu_device.cc | 12 ++++++++---- third_party/blink/renderer/modules/webgpu/gpu_device.h | 6 ++++-- .../blink/renderer/modules/webgpu/gpu_device_descriptor.idl | 10 ++++++++++ third_party/blink/renderer/modules/webgpu/gpu_extensions.idl | 8 ++++++++ third_party/blink/renderer/modules/webgpu/gpu_limits.idl | 8 ++++++++ 9 files changed, 46 insertions(+), 10 deletions(-) commit e17fb70e53a19afb8ab526b55413f5fffe8f2bef Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Mar 15 07:26:14 2019 +0000 Add PreferredColorScheme to content::WebPreferences. Also add the plumbing to pass it into blink. Bug: 889087, 925935 Change-Id: I5027a1fc30b14f77423b33ac9e85ba5697a95b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522246 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#641115} content/public/common/common_param_traits_macros.h | 4 ++++ content/public/common/web_preferences.cc | 1 + content/public/common/web_preferences.h | 7 +++++++ content/renderer/render_view_impl.cc | 1 + 4 files changed, 13 insertions(+) commit d91952ef9df602753c4e2ed56b66f3967f790c2d Author: Cathy Li <chili@chromium.org> Date: Fri Mar 15 07:17:14 2019 +0000 [ExploreSites][Touchless] Refactor TileWithTextView into TileView and TextView and allow the new touchless suggestions files to depend on TileView Bug: 936050 Change-Id: Ib611b788b532a72a8fce6e8b982c4e288b91408b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518251 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#641114} .../res/layout/tile_no_text_view_condensed.xml | 50 +++++++++++++++++ .../java/res/layout/tile_view_modern_condensed.xml | 39 +------------- .../chrome/browser/widget/tile/TileView.java | 63 ++++++++++++++++++++++ .../browser/widget/tile/TileWithTextView.java | 23 +------- chrome/android/java_sources.gni | 2 + .../res/layout/touchless_suggestions_tile_view.xml | 14 +++++ .../browser/touchless/SiteSuggestionsAdapter.java | 12 ++--- .../browser/touchless/SiteSuggestionsTileView.java | 61 +++++++++++++++++++++ .../SiteSuggestionsViewHolderFactory.java | 4 +- 9 files changed, 199 insertions(+), 69 deletions(-) commit 1fec8e450203ccede4022a3448dc13e8cc044125 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Fri Mar 15 07:11:49 2019 +0000 OOR-CORS: Skip CORS preflight cache if the original request wants CORS preflight cache wasn't skipped regardless of the load_flags, but with this change, it is skipped if the original request has one of flags that want to skip caches. Also, we do not store results to the cache if net::LOAD_DISABLE_CACHE is specified. Bug: 941297 Change-Id: Ibf356949dd6267eb65faf650d76b0c5e58ce5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520427 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#641113} .../loader/cors_preflight_cache_browsertest.cc | 129 +++++++++++++++++++++ content/test/BUILD.gn | 1 + content/test/data/loader/cors_preflight.html | 12 ++ services/network/cors/preflight_controller.cc | 13 ++- .../network/cors/preflight_controller_unittest.cc | 19 +++ 5 files changed, 170 insertions(+), 4 deletions(-) commit 76ccc9c47bd7ebe599dd85404f2e4c9f846afdef Author: Christopher Lam <calamity@chromium.org> Date: Fri Mar 15 07:11:45 2019 +0000 [System Web Apps] Extract launch utilities, fix launch disposition. This CL extracts System Web App launch utilities into its own file as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1370239. It also changes the launch disposition for System Web Apps to CURRENT_TAB to correctly provide singleton behavior. Bug: 836128 Change-Id: Iefd691ed3a5c1f1858197599cff5282e22a254ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504603 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#641112} .../browser/chromeos/crostini/crostini_manager.cc | 4 +- chrome/browser/ui/BUILD.gn | 2 + chrome/browser/ui/extensions/application_launch.cc | 8 +- chrome/browser/ui/extensions/application_launch.h | 5 +- .../browser/ui/settings_window_manager_chromeos.cc | 135 +++++++-------------- .../system_web_app_ui_utils_chromeos.cc | 102 ++++++++++++++++ .../system_web_app_ui_utils_chromeos.h | 34 ++++++ 7 files changed, 197 insertions(+), 93 deletions(-) commit 230ac82f9f2cb6c8389ff36c5c476bf1dba02e84 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 07:10:44 2019 +0000 Roll src-internal ddc3e674c3c0..824201d8b700 (12 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddc3e674c3c0..824201d8b700 Created with: gclient setdep -r src-internal@824201d8b700 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:885919,chromium:885407,chromium:790659,chromium:790657,chromium:790654 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I879a1d976a1d86275f8c5c6044ab61ca3470c5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525460 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641111} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19c8b4eaaea2582d032d7420572c7e08431fbedc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 07:10:40 2019 +0000 Roll src/third_party/chromite 58f92a13bcd8..5d06c3522353 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/58f92a13bcd8..5d06c3522353 git log 58f92a13bcd8..5d06c3522353 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 bpastene@chromium.org cros_test: Point Tast to the specified SSH key when running outside the chroot. 2019-03-15 dhanyaganesh@chromium.org GetSlaveStatuses: Split some callers off to GetBuildStatuses Created with: gclient setdep -r src/third_party/chromite@5d06c3522353 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6abe9a1411ea4458a6f2c4aa6fede53f7f63063e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525459 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641110} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19574981b2967dc3e17da37df392bb3ae6695ae8 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Mar 15 07:09:38 2019 +0000 Make NGAbstractInlineText::GetOrCreate() to take only NGPaintFragment This patch changes to |NGAbstractInlineText::GetOrCreate()| to take only |NGPaintFragment| to avoid to create |NGAbstractInlineText| having |NGPaintFragment| not to associated to |line_layout_item_| member variable. These invalid |NGAbstractInlineText| causes crash by referring destructed |LayoutObject| in |NGAbstractInlineText::Detach()|. This crash can be happend in following scenario: 1. Create |NGAbstractInlineText| by |LayoutText::FirstAbstractInlineText()| with layout object L1 and fragment F1_1 then get A1(L1, F1) 2. Create |NGAbstractInlineText::NextOnLine()| with L1 and F2 then get A2(L1, F2) where F2 is associated to L2. 3. Destroy L1 then call Detach() for A1(L1, F1) => no problem 4. Destroy L2 then call Detach() for A2(L1, F2) => crash since L1 is destroyed Bug: 928925 Change-Id: Ic0a55b4e15723e1988d0727aba45723aed4d3a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525257 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641109} third_party/blink/renderer/core/layout/layout_text.cc | 3 +-- .../core/layout/ng/inline/ng_abstract_inline_text_box.cc | 10 +++++----- .../core/layout/ng/inline/ng_abstract_inline_text_box.h | 3 --- 3 files changed, 6 insertions(+), 10 deletions(-) commit b48ffad8dd1e0aa410bfd778a89b1e1fe8d01196 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 07:09:34 2019 +0000 Roll src/third_party/pdfium 9284a7cf9ba6..bcb9892d16d3 (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/9284a7cf9ba6..bcb9892d16d3 git log 9284a7cf9ba6..bcb9892d16d3 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 tsepez@chromium.org Better bounds check in CFGAS_StringFormatter::GetCategory() 2019-03-14 tsepez@chromium.org Remove stringviews in cfgas_stringformatter.cpp, part2. 2019-03-14 tsepez@chromium.org Cache pattern span in xfa/fgas/crt/cfgas_stringformatter.h Created with: gclient setdep -r src/third_party/pdfium@bcb9892d16d3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c57571b0ed4907cb09043a56f2fd4eead0c1998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525458 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641108} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 655669175e7f527d42dbc113aef67ddd0e1670bf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 06:34:47 2019 +0000 Roll src/third_party/depot_tools 26b4a64918d4..04600b4f26bd (3 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26b4a64918d4..04600b4f26bd git log 26b4a64918d4..04600b4f26bd --date=short --no-merges --format='%ad %ae %s' 2019-03-15 yyanagisawa@chromium.org Expose gclient_paths via InputAPI. 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@04600b4f26bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:939959 TBR=agable@chromium.org Change-Id: If95206c72c9ede5ea741929d60535cd7e604a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525457 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641107} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit df9f61b51b9dfe9c3b3cf2ec7ba2d6b5882247a7 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Mar 15 06:33:11 2019 +0000 [AF Wallet sync] Ensure proper order of notifications to metadata bridge This CL fixes a speculative bug in interaction between the wallet data bridge and the wallet metadata bridge. The bug occurs when the bridge deletes and re-creates a particular entity (because it is different than before). If these notifications are sent out in the wrong order (first ADD, then DELETE), we end up without the metadata entity. It is speculative because I am not sure that it can happen in reality that payments sends the same card with different data. Anyway, it feels safer to assume less. Bug: 928758 Change-Id: I74a2d6c68107fffdde18a69810828d629ca4e50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518575 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641106} .../integration/single_client_wallet_sync_test.cc | 104 ++++++++++++++++++++- .../browser/webdata/autofill_wallet_sync_bridge.cc | 23 ++++- 2 files changed, 119 insertions(+), 8 deletions(-) commit aee84c522e39fed15b0310e732d72616b26f824c Author: Nico Weber <thakis@chromium.org> Date: Fri Mar 15 06:24:14 2019 +0000 Reland "Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds." This is a reland of 889a9665145519f88a755826e6c4a3c15f8fda7a Original change's description: > Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. > > Removes some special-case code and potentially makes debug info a bit smaller. > > Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case > on linux -- this helps with build determinism. > > Bug: 942155,899438,906741,429358 > Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640963} TBR=mark Bug: 942155, 899438, 906741, 429358 Change-Id: I382c93c02eefd3cbbcf1d8df0670297319f3ac31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525415 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641105} build/config/compiler/BUILD.gn | 67 +++++++++++++++++++++--------------------- 1 file changed, 33 insertions(+), 34 deletions(-) commit 3662db4044c922fdd6ed8789b8984f53a3313a71 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Mar 15 06:24:11 2019 +0000 Use per-frame task runner at extnsions' GCCallback This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. The callback of GC in extensions executes JavaScript, but this callback is now executed on the default task runner. This CL replaces this with a per-frame task runner. Some tests hit this: e.g. extensions_browsertests --gtest_filter=WebViewAPITest.TestDialogConfirmDefaultGCCancel Bug: 870606 Change-Id: Ic1c2968a2e9e07629e7c117e1e1c4e97c2df0457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514516 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641104} extensions/renderer/gc_callback.cc | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) commit 251c3e7000c1f64eddfe7b10d03d746a637d1d27 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 06:20:37 2019 +0000 Roll src/third_party/angle 2fb6563bf503..de52ca373d98 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/2fb6563bf503..de52ca373d98 git log 2fb6563bf503..de52ca373d98 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 syoussefi@chromium.org Vulkan: Fix GraphViz dump in presence of queries and fences Created with: gclient setdep -r src/third_party/angle@de52ca373d98 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idf3d1a755fe66d8df1ceda4c9d5105a21c2da579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525456 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641103} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fcb13a76d9f014a44fa5872d534f49c5e8d1869 Author: Fergus Dall <sidereal@google.com> Date: Fri Mar 15 06:16:18 2019 +0000 Uninitialized variable preventing crostini uninstall option from appearing This fixes a regression introduced by crrev.com/c/1472013, which leaves the flag that decides to show/hide the uninstaller uninitialized. Depending on the build, this may end up in the hiding state initially, rather then the showing state. This CL fixes the regression and adds automated testing to prevent reoccurence. Bug: 941865 Change-Id: I7dc2c3c770fc5fbef838d82c82f46c0717fb7ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522061 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641102} .../browser/chromeos/crostini/crostini_manager.h | 4 ++- .../chromeos/crostini/crostini_manager_unittest.cc | 4 +++ .../crostini_page/crostini_browser_proxy.js | 9 ++++++ .../settings/crostini_page/crostini_subpage.html | 1 + .../settings/crostini_page/crostini_subpage.js | 9 +++--- .../ui/webui/settings/chromeos/crostini_handler.cc | 6 ++-- .../test/data/webui/settings/crostini_page_test.js | 32 ++++++++++++++++++++-- .../webui/settings/test_crostini_browser_proxy.js | 4 +++ 8 files changed, 58 insertions(+), 11 deletions(-) commit c3957448cfc6e299165196a33cd954b790875fdb Author: David Bokan <bokan@chromium.org> Date: Fri Mar 15 06:15:17 2019 +0000 Cleanup and remove dead code in SetFocusedElement This early-out was added in: https://crrev.com/ce8ea3446283965c7eabab592cbffe223b1cf2bc Back then, we applied fragment focus in LayoutUpdated() which could cause this issue. This got cleaned up in: https://crrev.com/45236fd563e9df53dc45579be1f3d0b4784885a2 so that focus is no longer applied after layout. +Cleanup: Goto considered harmful Bug: 795381 Change-Id: Ifeb4d2e03e872fd48cca6720b1d4de36ad1ecbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524417 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#641101} third_party/blink/renderer/core/dom/document.cc | 38 +++++++++++++------------ 1 file changed, 20 insertions(+), 18 deletions(-) commit ded259df83e1e4bac3b20f8f28a7e21a7d88e752 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 06:12:59 2019 +0000 Roll src/third_party/SPIRV-Tools/src e545522146af..2ac348b5c0a5 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e545522146af..2ac348b5c0a5 git log e545522146af..2ac348b5c0a5 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dneto@google.com Repair test for unused storage buffer with descriptor (#2436) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2ac348b5c0a5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I16aa5cb80a3747d3da5e2ab796951cb6bc65dbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525347 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641100} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bdfbcff52d04b8182799d43eb66ab9be98ee0b86 Author: Adam Rice <ricea@chromium.org> Date: Fri Mar 15 06:10:27 2019 +0000 Fix the error message when TransformStream controller enqueue fails Calling enqueue() on a TransformStream that was closed or errored would throw an exception with the message "Cannot read property 'Symbol(bit field for [[started]], [[closeRequested]], [[pulling]], [[pullAgain]])' of undefined". Fix the message. Also add a Chromium-specific test that the message is correct. BUG=941970 Change-Id: I690bfb909efe72a6ba6859dc886b37b2bda71ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523211 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641099} .../blink/renderer/core/streams/TransformStream.js | 3 +- .../streams/chromium/transform-stream-enqueue.html | 42 ++++++++++++++++++++++ .../chromium/transform-stream-enqueue-expected.txt | 5 +++ 3 files changed, 49 insertions(+), 1 deletion(-) commit 6240f4c4c19ad2901662ed5e0128af523706de48 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Mar 15 06:08:07 2019 +0000 Reland "[BGPT] Let cc initialize animation states in property nodes" This is a reland of 54b17c7e812cd7c961abb45b4f8bcc7e2b1bbe43 The original CL called MutatorHost::InitClientAnimationState() before updating animations. The new CL calls it after updating animations. Not sure why the original CL caused flakiness of virtual/threaded/animations/hit-testing/composited-with-hit-testing.html, but the test is no longer flaky with this new CL. Original change's description: > [BGPT] Let cc initialize animation states in property nodes > > In this way, blink::PropertyTreeManager no longer needs to care about > the animation states. Now we initialize and change the states from a > single source to avoid duplicate code and inconsistency. > > Bug: 935770 > Change-Id: I7f98d66677f557213fd4559895e9c2069de196e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513922 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640892} TBR=flackr@chromium.org, pdr@chromium.org Bug: 935770 Change-Id: Icd7ec59b9e5b95f2c268baf88732788cde5da9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525449 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641098} cc/animation/animation_host.cc | 5 + cc/animation/animation_host.h | 2 + cc/animation/element_animations.cc | 8 + cc/animation/element_animations.h | 7 + cc/trees/mutator_host.h | 2 + .../core/animation/compositor_animations.h | 12 -- .../core/animation/compositor_animations_test.cc | 214 +++++++++++++-------- .../blink/renderer/core/frame/local_frame_view.cc | 15 ++ .../renderer/core/paint/link_highlight_impl.cc | 8 +- .../compositing/paint_artifact_compositor.cc | 1 + .../compositing/paint_artifact_compositor_test.cc | 30 ++- .../graphics/compositing/property_tree_manager.cc | 16 -- 12 files changed, 187 insertions(+), 133 deletions(-) commit e5e713ea03d4573796b4f62347935e76903142fb Author: Antonio Gomes <tonikitoo@igalia.com> Date: Fri Mar 15 05:56:07 2019 +0000 Invoke FileSystemCallbacks's success/error closures directly Previously, the success and error callbacks in the various classes in [1] were either invoked immediately or scheduled to run depending on the execution context's task runner. Lately, according to offline conversations with mek@chromium.org, it is possible to get rid of the scheduling logic altogether because an earlier, change made it so that things like FilesystmeDispatcher::DidReadMetadata already run on a per-execution context task runner, and presumably they would already be scheduled properly. This CL implements that idea, as part of the effort to clean FileSystemCallbacks's implementation. It also greatly simplifies FileSystemCallbacksBase, which can be eliminated in a follow up CL with minimal effort. [1] //third_party/blink/renderer/modules/filesystem/file_system_callbacks.h R=mek@chromium.org CC=blink-reviews-vendor@chromium.org, dgozman@chromium.org BUG=933878 Change-Id: Ib446249bab8ac1c9d9f2e4d11340d258cbac1751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525101 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641097} .../modules/filesystem/file_system_callbacks.cc | 118 +++++++-------------- .../modules/filesystem/file_system_callbacks.h | 11 -- 2 files changed, 41 insertions(+), 88 deletions(-) commit 1108c4224984e1e247ec3fd2ee5b43f1f04f1f88 Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Mar 15 05:48:23 2019 +0000 Add clangd to gitignore This folder is an output for an experimental `-background-index` command line argument. Bug: None Change-Id: Iaa1db62f54d844d271b2c56a686cdad5117ebe74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524392 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#641096} .gitignore | 1 + 1 file changed, 1 insertion(+) commit 7cf2cfad067a9837990a99369e52e95dd8edc1e7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 05:40:34 2019 +0000 Roll src/third_party/skia f4438d56e989..5366a45c6103 (14 commits) https://skia.googlesource.com/skia.git/+log/f4438d56e989..5366a45c6103 git log f4438d56e989..5366a45c6103 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b156615197d..1b8cd2d9ce2c (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 brianosman@google.com Ganesh: Clamp blend inputs when using F16_Clamped pixel config 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader becb44f1177a..9b156615197d (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a2749f39f47d..becb44f1177a (1 commits) 2019-03-14 jvanverth@google.com Fix cached perspective shadows 2019-03-14 michaelludwig@google.com Blacklist compositor_quads_filter on chromecast 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader af973b67141e..a2749f39f47d (1 commits) 2019-03-14 bsalomon@google.com Clamp override color to bytes in GrFillRectOp when half float vertex 2019-03-14 kjlubick@google.com [canvaskit] Fallback to CPU more gracefully 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 37b996425a0e..979f3bbe2c50 (5 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@5366a45c6103 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123261126 TBR=benjaminwagner@chromium.org Change-Id: Idff8f55d51703b5bf63f6ba0948b349c84dceedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525455 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641095} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fa476237ab4afbaf19b769a80550aadb8f2ed9e9 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Fri Mar 15 05:36:44 2019 +0000 Add to_snake_case function in make_instrumenting_probes.py The primary motivation is that the data member names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL add to_snake_case function in make_instrumenting_probes.py to convert data members to snake case format. Bug: 936684 Change-Id: I9934aec12dfd85094335078f7c1784f56d6aafac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524801 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641094} .../blink/renderer/build/scripts/make_instrumenting_probes.py | 6 +++--- .../build/scripts/templates/instrumenting_probes_impl.cc.tmpl | 4 ++-- .../blink/renderer/build/scripts/templates/probe_sink.h.tmpl | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) commit e91cd380877656737479db291ddb2855c90a9c72 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Mar 15 05:35:04 2019 +0000 [CompositeAfterPaint] Update test expectations - Skip virtual/binary-for-devtools/http/tests/devtools - Mark css3/masking/mask-composite-missing-image.html failing - Rebaseline 5 tests: - gradient, rounded edges and anti-alias differences - invalidation rect changes (no image failure) All because of base test rebaselines TBR=pdr@chromium.org Bug: 524134 Change-Id: I171f3eaff7e78649903441c142ebc9c25171ad2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525681 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641093} .../enable-blink-features=CompositeAfterPaint | 2 ++ .../masking/mask-repeat-space-border-expected.png | Bin 17867 -> 22541 bytes .../paint/invalidation/svg/tabgroup-expected.txt | 2 +- .../text-line-clamp-truncation-expected.txt | 6 +++--- ...d-image-preserveaspectRatio-support-expected.png | Bin 49696 -> 49697 bytes .../background-repeat-expected.png | Bin 68576 -> 68533 bytes 6 files changed, 6 insertions(+), 4 deletions(-) commit 5242713e8266e6b56f3c5cb8e4ecd259fd236467 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Mar 15 05:25:58 2019 +0000 Mark http/tests/devtools/service-workers/service-workers-force-update-on-page-load.js slow According to the flakiness dashboard it could take more than 10 sec on dbg build and 3 sec on release build. Mark it slow. Bug: 937378 Change-Id: I14fcd04a6d315a61f559fbc7a3cadf8ce2914dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525255 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641092} third_party/blink/web_tests/SlowTests | 2 ++ third_party/blink/web_tests/TestExpectations | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) commit 321ed56aabe64572e13f74807ad7ecd96868e8ea Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Date: Fri Mar 15 05:16:58 2019 +0000 Rename latest goma cros and ios builders to omit "client" Since we don't have "client"s in canary, let me remove that from the name. Also let me add an ios rule for the iOS latest builder. Bug: 874754 Change-Id: I46e1ec5d33f30caaa723184fdc7dea46f372de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502892 Commit-Queue: smut <smut@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: smut <smut@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641091} infra/config/cr-buildbucket.cfg | 2 +- infra/config/luci-milo.cfg | 4 ++-- infra/config/luci-scheduler.cfg | 12 +++++------ .../ios-device-goma-latest-clobber.json | 25 ++++++++++++++++++++++ tools/mb/mb_config.pyl | 2 ++ 5 files changed, 36 insertions(+), 9 deletions(-) commit 9cd0fb799a0369da431729e932be51fe24106e71 Author: Maksim Ivanov <emaxx@chromium.org> Date: Fri Mar 15 05:13:46 2019 +0000 Remove unused enums from enterprise_metrics.h These enums haven't been used by any code for a while. Also remove the corresponding dead histogram definitions. BUG=chromium:690733 TEST=existing tests Change-Id: I93b00807807e1869e5a7ab8daae277a07b6cf1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1425724 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#641090} .../policy/core/common/cloud/enterprise_metrics.cc | 2 - .../policy/core/common/cloud/enterprise_metrics.h | 105 --------------------- tools/metrics/histograms/enums.xml | 6 ++ tools/metrics/histograms/histograms.xml | 6 ++ 4 files changed, 12 insertions(+), 107 deletions(-) commit 558a982945cf9d3133b413b05f9300de17c3a371 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Fri Mar 15 05:07:21 2019 +0000 Android: Close preview panel on some events Preview (a.k.a Sneak Peek) panel needs to be closed on various events such as when a new tab is opened, or its base panel navigates, etc. This CL adds a couple of tab model observers to detect those events, and invokes |closePanel| accordingly. Bug: 940919 Change-Id: Ieee694db214ded1f031ac24db3586496d19bee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519966 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641089} .../chromium/chrome/browser/ChromeActivity.java | 1 - .../bottombar/ephemeraltab/EphemeralTabPanel.java | 61 ++++++++++++++++++++++ .../browser/compositor/layouts/LayoutManager.java | 1 + .../contextualsearch/ContextualSearchManager.java | 56 ++++++++------------ 4 files changed, 84 insertions(+), 35 deletions(-) commit 197aede3ca09f2e0393a507bd50d51c0efe55ef2 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 04:58:06 2019 +0000 Roll src-internal b58fe2ab9436..ddc3e674c3c0 (8 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58fe2ab9436..ddc3e674c3c0 Created with: gclient setdep -r src-internal@ddc3e674c3c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:942176 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Id383f2517feb021d79065d9a527de04c7a36f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525303 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641088} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ff94864113f0406193ac4ead46b2a5ce2650b7f0 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Mar 15 04:53:49 2019 +0000 [Files app] Add context menu test for USB with DCIM folder Re-sending CL: 1514005 based in the new strategy to make it non-flaky. Add more explicit waiting on checkContextMenu to wait for each entry to be displayed before trying to expand or click. Change-Id: Id7a6f9ea27d5bade800837480df79721dcab4329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524749 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641087} .../file_manager/file_manager_browsertest.cc | 1 + .../file_manager/directory_tree_context_menu.js | 47 ++++++++++++++++++++-- 2 files changed, 45 insertions(+), 3 deletions(-) commit 437ee022676233d01e05b7d640c808e4d37bd05a Author: Pavel Feldman <pfeldman@chromium.org> Date: Fri Mar 15 04:53:46 2019 +0000 DevTools: refactor overlay input handling Routes each message type into its own method. Change-Id: I8dacbc37d614794f6757d6b9c669fa751de5ab4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525263 Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641086} .../core/inspector/inspector_overlay_agent.cc | 172 +++++++++++++-------- .../core/inspector/inspector_overlay_agent.h | 10 ++ 2 files changed, 115 insertions(+), 67 deletions(-) commit fe043db5936303d3d7d7c194b244b07f6649de78 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 04:52:42 2019 +0000 Import wpt@4acb8924f765913a520d5f6fefbc8c870e500476 Using wpt-import in Chromium 8f30a2e75761511431980d03a5a7db1c165ff968. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ib7511d306d305de610cf7479d5f49531ba7c6d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524973 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641085} .../blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 12 ++++++------ .../web_tests/external/wpt/web-nfc/resources/nfc_help.js | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) commit 9481795e17f5f5561110e53650d6d973cb0406a0 Author: kylechar <kylechar@chromium.org> Date: Fri Mar 15 04:52:38 2019 +0000 Remove viz related tests from FYI bots. 1. Remove all viz related tests from FYI bots on Linux, Windows and Mac. The feature has launched on those platforms and no longer needs special testing. 2. Remove all viz related tests from FYI bots on Android. The feature is default enabled on Android and will be launched before M75. Fixing regressions in the viz disabled case is no longer necessary. Bug: 730193, 732555 Change-Id: Idd01543bb059971152a168a279a2ebe56fcfa325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524870 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#641084} testing/buildbot/chromium.fyi.json | 433 ------------------------------------- testing/buildbot/test_suites.pyl | 44 ---- 2 files changed, 477 deletions(-) commit 9d4bc8c9486f1d43fe244e3aa2987379368265cc Author: Eliot Courtney <edcourtney@google.com> Date: Fri Mar 15 04:51:36 2019 +0000 Fix DCHECK crash inside SetMaximizedOrFullscreenBounds. If the set bounds event was meant to be animated, and occurred during a drag, then it would trigger the DCHECK in SetMaximizedOrFullscreenBounds. Bug: 941017 Test: No DCHECK on finishing dragging a PIP window. Change-Id: I9ced916fa8f7eafbac2df232b3abe242a704a329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523126 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#641083} ash/wm/default_state.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 6e0feb3c71d51ef49aa534e77aa91fa104263390 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Fri Mar 15 04:51:33 2019 +0000 [Extensions] Add web request info for activities in the stream This CL shows web request info for activities in the stream if provided (also shown in Chrome Apps & Extensions Developer Tool). The web request info is a JSON object and is found in chrome.activityLogPrivate.ExtensionActivity.other.webRequest Screenshot: https://imgur.com/a/ZdxqfBC Note: I'm not using any fancy styling/formatting here, as the keys in the web request object can be somewhat long and are variable in length. The objects don't seem to be very large and so the entire web request object is shown as a JSON string (see screenshot). Bug: 932768 Change-Id: Idc14b337e6cb953331a1988bf1cd675f381c30f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517142 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641082} chrome/app/md_extensions_strings.grdp | 3 ++ .../activity_log/activity_log_stream.js | 4 ++ .../activity_log/activity_log_stream_item.html | 23 ++++++-- .../activity_log/activity_log_stream_item.js | 29 ++++++---- .../browser/ui/webui/extensions/extensions_ui.cc | 1 + .../extensions/activity_log_stream_item_test.js | 63 ++++++++++++---------- 6 files changed, 80 insertions(+), 43 deletions(-) commit b2ebac90f6f6adaa33eae986c1b6e70df436f2dd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 04:50:30 2019 +0000 Roll src/third_party/pdfium b271c06e57ba..9284a7cf9ba6 (8 commits) https://pdfium.googlesource.com/pdfium.git/+log/b271c06e57ba..9284a7cf9ba6 git log b271c06e57ba..9284a7cf9ba6 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 tsepez@chromium.org Avoid WideStringViews from constant strings in cfgas_stringformatter.cpp 2019-03-14 thestig@chromium.org Rename some variables in fpdf_edittext.cpp. 2019-03-14 thestig@chromium.org Split CFFL_InteractiveFormFiller::GetFormFiller() in two. 2019-03-14 thestig@chromium.org Use "bs" prefix for ByteStrings in cfxjse_formcalc_context.cpp. 2019-03-14 thestig@chromium.org Fix two XFA JS calls that trigger fatal errors in v8::FromJust(). 2019-03-14 tsepez@chromium.org Specify CFGAS_StringFormatter format at creation time. 2019-03-14 thestig@chromium.org Remove extra slashes in fxjs/BUILD.gn. 2019-03-14 thestig@chromium.org Mark CPDF_FontEncoding::Realize() as a const method. Created with: gclient setdep -r src/third_party/pdfium@9284a7cf9ba6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8dbaeebcedd68b9f5c472778f2b0b7ca8497cc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524970 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641081} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 153043d1a91dc7a1228c5be0c3ea3a4ecc06ca0c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 04:50:26 2019 +0000 Roll src/third_party/chromite 69d4958ee9b3..58f92a13bcd8 (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/69d4958ee9b3..58f92a13bcd8 git log 69d4958ee9b3..58f92a13bcd8 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 pprabhu@chromium.org config: Move {quawks,octopus,sentry}-paladin to Skylab 2019-03-14 dgarrett@google.com chromeos_config: Make buildspec builders internal. 2019-03-14 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-14 dhanyaganesh@chromium.org PreCQLauncher: Revert the 1505981 CL 2019-03-14 saklein@chromium.org Build API: Add update sdk endpoint. Created with: gclient setdep -r src/third_party/chromite@58f92a13bcd8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I97837336910a68acd7414b8b902ea4a530617c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525454 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641080} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ab465d99332a41932cd01f852167b358ba3d221 Author: Charlie Reis <creis@chromium.org> Date: Fri Mar 15 04:49:25 2019 +0000 Add diagnostics to catch commits of URLs in incompatible processes. These should be removed once we have some data indicating how it is occurring in practice. BUG=931895 Change-Id: Ic8977b194892328a32d1db6f4492f9bb84938ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524835 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641079} .../browser/frame_host/render_frame_host_impl.cc | 28 +++++++++++++++++++ .../frame_host/render_frame_host_manager.cc | 31 ++++++++++++++++++++++ 2 files changed, 59 insertions(+) commit ad9da4e45bb501e872658fd4d12e69b61acf98eb Author: Adam Rice <ricea@chromium.org> Date: Fri Mar 15 04:49:22 2019 +0000 Disable TransformStream when StreamsNative enabled The V8 extras TransformStream implementation will always produce a V8 extras ReadableStream and WritableStream, even if the StreamsNative feature is turned on. Since this breaks the expectation that a ReadableStream is always a ReadableStreamNative when we are using the new implementation, it can cause crashes. Prevent constructing a TransformStream when StreamsNative is enabled to prevent this issue. BUG=902633 Change-Id: I718b493f19db7a47bea9db0c5ffb7dd1d6d12e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523209 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641078} .../renderer/core/streams/transform_stream.cc | 9 ++++++ .../piping/transform-streams.any-expected.txt | 2 +- ...ransform-streams.any.serviceworker-expected.txt | 2 +- ...transform-streams.any.sharedworker-expected.txt | 2 +- .../transform-streams.any.worker-expected.txt | 2 +- .../backpressure.any-expected.txt | 29 ++++++++--------- .../backpressure.any.serviceworker-expected.txt | 29 ++++++++--------- .../backpressure.any.sharedworker-expected.txt | 29 ++++++++--------- .../backpressure.any.worker-expected.txt | 29 ++++++++--------- .../brand-checks.any-expected.txt | 4 +++ .../brand-checks.any.serviceworker-expected.txt | 4 +++ .../brand-checks.any.sharedworker-expected.txt | 4 +++ .../brand-checks.any.worker-expected.txt | 4 +++ .../transform-streams/constructor.any-expected.txt | 23 ++++++++++++++ .../constructor.any.serviceworker-expected.txt | 23 ++++++++++++++ .../constructor.any.sharedworker-expected.txt | 23 ++++++++++++++ .../constructor.any.worker-expected.txt | 23 ++++++++++++++ .../transform-streams/errors.any-expected.txt | 37 ++++++++++++++++++++++ .../errors.any.serviceworker-expected.txt | 37 ++++++++++++++++++++++ .../errors.any.sharedworker-expected.txt | 37 ++++++++++++++++++++++ .../errors.any.worker-expected.txt | 37 ++++++++++++++++++++++ .../transform-streams/flush.any-expected.txt | 8 +++++ .../flush.any.serviceworker-expected.txt | 8 +++++ .../flush.any.sharedworker-expected.txt | 8 +++++ .../flush.any.worker-expected.txt | 8 +++++ .../transform-streams/general.any-expected.txt | 29 +++++++++++++++++ .../general.any.serviceworker-expected.txt | 29 +++++++++++++++++ .../general.any.sharedworker-expected.txt | 29 +++++++++++++++++ .../general.any.worker-expected.txt | 29 +++++++++++++++++ .../transform-streams/lipfuzz.any-expected.txt | 23 ++++++++++++++ .../lipfuzz.any.serviceworker-expected.txt | 23 ++++++++++++++ .../lipfuzz.any.sharedworker-expected.txt | 23 ++++++++++++++ .../lipfuzz.any.worker-expected.txt | 23 ++++++++++++++ .../patched-global.any-expected.txt | 5 +++ .../patched-global.any.serviceworker-expected.txt | 5 +++ .../patched-global.any.sharedworker-expected.txt | 5 +++ .../patched-global.any.worker-expected.txt | 5 +++ .../transform-streams/properties.any-expected.txt | 5 +++ .../properties.any.serviceworker-expected.txt | 4 +++ .../properties.any.sharedworker-expected.txt | 5 +++ .../properties.any.worker-expected.txt | 5 +++ .../reentrant-strategies.any-expected.txt | 23 +++++++------- ...trant-strategies.any.serviceworker-expected.txt | 23 +++++++------- ...ntrant-strategies.any.sharedworker-expected.txt | 23 +++++++------- .../reentrant-strategies.any.worker-expected.txt | 23 +++++++------- .../transform-streams/strategies.any-expected.txt | 13 ++++++++ .../strategies.any.serviceworker-expected.txt | 13 ++++++++ .../strategies.any.sharedworker-expected.txt | 13 ++++++++ .../strategies.any.worker-expected.txt | 13 ++++++++ .../transform-streams/terminate.any-expected.txt | 13 ++++---- .../terminate.any.serviceworker-expected.txt | 13 ++++---- .../terminate.any.sharedworker-expected.txt | 13 ++++---- .../terminate.any.worker-expected.txt | 13 ++++---- .../streams/chromium/use-counters-expected.txt | 7 ++++ .../transferable/enabled/enabled-expected.txt | 6 ++++ .../transferable/transform-stream-expected.txt | 10 +++--- .../tests/streams/transferable/window-expected.txt | 13 ++++++++ 57 files changed, 755 insertions(+), 145 deletions(-) commit ad4613668225feb1a870882b1e0b6242a30ceadc Author: Chris Lu <thegreenfrog@chromium.org> Date: Fri Mar 15 04:48:20 2019 +0000 [ios] Only Add Optional Text if Exists in ClearBrowsingDataItem optionalTextLabel always exists, but it does not always have text. Currently adds that empty string to the array used to construct the accessibilityValue. Now only add it to the returned string if there is text. Bug: 937016 Change-Id: I43d28777ed9ee872bebf741db985d49280b21c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525272 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#641077} .../ui/settings/cells/table_view_clear_browsing_data_item.mm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 6243800b26c38e8b6433cb0d79900b2ffbe4d3c0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 04:48:17 2019 +0000 Roll src/third_party/depot_tools 1c2fa0fdda12..26b4a64918d4 (3 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c2fa0fdda12..26b4a64918d4 git log 1c2fa0fdda12..26b4a64918d4 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@26b4a64918d4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I39c632b13063d4aca963ef58c5182b16df45546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525032 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641076} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bd35099ed01b0bd9619c4cef4765c5678b64141a Author: Peter Kasting <pkasting@chromium.org> Date: Fri Mar 15 04:08:03 2019 +0000 Add RemoveAllMenuItems(). This allows callers that want this to be both clearer and more efficient. Bug: none Change-Id: Ida11ebd5e131b250aeaf6a505be7d5176ff3e472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525279 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#641075} chrome/browser/ui/views/toolbar/app_menu.cc | 4 +--- ui/views/controls/menu/menu_item_view.cc | 12 +++++++++--- ui/views/controls/menu/menu_item_view.h | 4 ++++ ui/views/controls/menu/menu_model_adapter.cc | 7 ++----- 4 files changed, 16 insertions(+), 11 deletions(-) commit 13df76ecf29881670b04171632eb0dabf11e0323 Author: Jenny Zhang <jennyz@chromium.org> Date: Fri Mar 15 04:08:00 2019 +0000 Don't activate search box on context menu mouse click. When user right click the mouse on an empty inactive search box, we should only open context menu, but not zero state suggestion window. Bug: 941428 Change-Id: Ic3fb9934880232e5576266508845985ce9e88e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524339 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641074} ash/app_list/views/search_box_view.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 009e0bc2e196b48f567eaa66e3d6ed252c0aa006 Author: Jenny Zhang <jennyz@chromium.org> Date: Fri Mar 15 04:06:25 2019 +0000 Fix the zero state crash during quick key traversing. The result has not be set for its result view yet when the focus is forwarded to the result view due to the quick traverse via forward key, which leads to the crash. Bug: 942231 Change-Id: I49f7978a84a422c7f1eec661b6c950c1ee9efd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525278 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641073} ash/app_list/views/search_result_page_view.cc | 3 +++ 1 file changed, 3 insertions(+) commit 9660779c20cf7ac0471626e8ab1283e953d43537 Author: Siyu An <siyua@chromium.org> Date: Fri Mar 15 04:05:48 2019 +0000 Revert "[AF][Paradise] Enable Paradise settings button for non-sync users" This reverts commit c8d72cdba1671a341b9fa11d4cc0707c23a3f66f. Reason for revert: It breaks local card migration browsertests and guests window. 941880, 941780 Original change's description: > [AF][Paradise] Enable Paradise settings button for non-sync users > > Previously there were two sets of prerequisites checks which are fragile > and complex. Here I refactored the LocalCardMigrationManager to allow > prerequisites checks to be shared by both checkout form flow and > settings page flow. > > Change in the LocalCardMigrationManager is already covered by unittests > and browsertests. So I only modify the test file for payments_section.js > > Bug: 897998 > Change-Id: I894f0ba7010615fa602fa808dc9493c58d0f1d94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510635 > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640028} TBR=hcarmona@chromium.org,tmartino@chromium.org,jsaul@google.com,siyua@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897998 Change-Id: Ib287dea02f7025e0fe6f95e712185302870e4116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524716 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641072} .../settings/autofill_page/payments_section.html | 2 +- .../settings/autofill_page/payments_section.js | 139 ++++++++++++++- .../md_settings_localized_strings_provider.cc | 63 ++++++- .../data/webui/settings/payments_section_test.js | 190 ++++++++++++++++++++- .../autofill/core/browser/autofill_experiments.cc | 32 ---- .../autofill/core/browser/autofill_experiments.h | 7 - .../payments/local_card_migration_manager.cc | 34 +++- .../core/browser/payments/payments_util.cc | 10 -- .../autofill/core/browser/payments/payments_util.h | 4 - .../browser/payments/payments_util_unittest.cc | 27 +-- 10 files changed, 408 insertions(+), 100 deletions(-) commit 3a304e8e81472cd6c4b397ef30d5c3a11ee635ed Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 04:05:19 2019 +0000 Note that you cannot uninstall built-in apps BUG=826982 Change-Id: Ib5e26c2b13f302b70b5fce500c8d130facd13016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525244 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641071} chrome/browser/apps/app_service/built_in_chromeos_apps.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit f8ee72281ece4c3a3a2d648174bd94600f25a9dd Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Mar 15 03:54:11 2019 +0000 Support sending all request and response headers to webRequest for websockets with network service. Since this incurs a performance overhead of extra process hops, only do it if extraHeaders is specified. Bug: 937852 Change-Id: I5db329c5eaf8781bef418b64afc5f0ab1c0c18f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517144 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641070} chrome/browser/chrome_content_browser_client.cc | 6 +- chrome/browser/chrome_content_browser_client.h | 3 +- .../api/web_request/web_request_apitest.cc | 4 +- .../extensions/api_test/webrequest/framework.js | 25 ++++ .../api_test/webrequest/test_extra_headers.js | 24 ---- .../api_test/webrequest/test_websocket.js | 110 ++++++++++++++++- .../browser/frame_host/render_frame_host_impl.cc | 8 +- content/browser/renderer_interface_binders.cc | 4 +- content/browser/websockets/websocket_manager.cc | 10 +- content/browser/websockets/websocket_manager.h | 1 + .../websockets/websocket_manager_unittest.cc | 1 + .../browser/worker_host/dedicated_worker_host.cc | 11 +- content/public/browser/content_browser_client.cc | 3 +- content/public/browser/content_browser_client.h | 3 +- .../browser/api/web_request/web_request_api.cc | 12 +- .../browser/api/web_request/web_request_api.h | 3 +- .../web_request/web_request_proxying_websocket.cc | 130 ++++++++++++++++++--- .../web_request/web_request_proxying_websocket.h | 21 +++- services/network/network_context.cc | 9 +- services/network/network_context.h | 3 +- .../network/network_service_network_delegate.cc | 21 ++++ .../network/public/mojom/network_context.mojom | 8 +- services/network/test/test_network_context.h | 3 +- services/network/websocket.cc | 75 ++++++++++++ services/network/websocket.h | 46 ++++++++ services/network/websocket_factory.cc | 3 +- services/network/websocket_factory.h | 2 + 27 files changed, 471 insertions(+), 78 deletions(-) commit 7123adc5e98d9f0a49790064cebb7a365a334d17 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 03:53:27 2019 +0000 Roll src/third_party/swiftshader 9b156615197d..1b8cd2d9ce2c (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/9b156615197d..1b8cd2d9ce2c git log 9b156615197d..1b8cd2d9ce2c --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dsinclair@google.com Copy build artifacts to CMAKE_BINARY_DIR. Created with: gclient setdep -r src/third_party/swiftshader@1b8cd2d9ce2c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123752208 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I382218117ff1227bbb9a460af0218462283d03c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525452 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641069} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 478090f913eb012ff15afe538cf18cf51ac6930b Author: Jazz Xu <jazzhsu@chromium.org> Date: Fri Mar 15 03:53:24 2019 +0000 [Media Controls] Arrow key handling Handle arrow keys for volume up/down, seek forward/backward. Bug: 942151 Change-Id: I71ba2f6d557fa824535c5fbfa4a5b87dca119239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522335 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641068} .../non_touch/media_controls_non_touch_impl.cc | 126 +++++++++++++++++++- .../non_touch/media_controls_non_touch_impl.h | 15 +++ .../media_controls_non_touch_impl_test.cc | 127 +++++++++++++++++++-- 3 files changed, 258 insertions(+), 10 deletions(-) commit daaeb82ec89cec76961a1d69a21f405fb08d0220 Author: Harley Li <hhli@chromium.org> Date: Fri Mar 15 03:51:22 2019 +0000 [DevTools] Display number of entries in an IndexedDB object store The number of entries stored in an object store is an important metadata. Bug: 941197 Change-Id: I8166a106593fecb34428825787e884f51d11963b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512692 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641067} .../renderer/core/inspector/browser_protocol.pdl | 14 ++- .../core/inspector/inspector_protocol_config.json | 2 +- .../devtools/front_end/resources/IndexedDBModel.js | 20 ++-- .../devtools/front_end/resources/IndexedDBViews.js | 33 +++--- .../indexeddb/inspector_indexed_db_agent.cc | 129 +++++++++++++-------- .../modules/indexeddb/inspector_indexed_db_agent.h | 9 +- .../devtools/indexeddb/database-data-expected.txt | 6 +- .../http/tests/devtools/indexeddb/database-data.js | 19 ++- 8 files changed, 142 insertions(+), 90 deletions(-) commit e05c7762ddd3b73a408a89c091aa0b46757a5710 Author: Anand K. Mistry <amistry@chromium.org> Date: Fri Mar 15 03:46:21 2019 +0000 Fix SMB mDNS host discovery. The return value of MDnsClient::StartListening() changed from a bool to an int, which effectively inversed the result. BUG=942390 Change-Id: I808836086203f3500c94160784d8135b4de8926d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525254 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#641066} chrome/browser/chromeos/smb_client/discovery/mdns_host_locator.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 847d871a716ed5243ff92e48f9279d86bee0884f Author: Eugene But <eugenebut@google.com> Date: Fri Mar 15 03:31:52 2019 +0000 Fix NavigationContext::HasCommitted if WebState has multiple pending navigations. For new navigations GetPendingItem() may not return the item associated with current navigation. So existing code incorrectly computed pending item URL when there are more than one pending navigations. This CL fixes the computation of pendingURL by using pending URL from NavigationContext for new navigations. Bug: 899827 Change-Id: Iea949ef96d64d40c28d38fdb21af127fdd0fff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519331 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641065} ios/web/web_state/ui/crw_web_controller.mm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) commit 8eab09675658354839e6a047427d63cc7c51993d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 03:30:29 2019 +0000 Roll src/third_party/perfetto 8320e6d2b742..34e6c9d3d1b6 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/8320e6d2b742..34e6c9d3d1b6 git log 8320e6d2b742..34e6c9d3d1b6 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 fmayer@google.com Use relaxed increment for stats in ring buffer. Created with: gclient setdep -r src/third_party/perfetto@34e6c9d3d1b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:126724929 TBR=perfetto-bugs@google.com Change-Id: I5b740b6b752ed62d7a469fce2f7f1441baa8ce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525522 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641064} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 869671963e2246aaa01bec4f4b40458456cbe60c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 03:26:13 2019 +0000 Roll src/third_party/dawn 5625b6320279..d263d752ac35 (1 commits) https://dawn.googlesource.com/dawn.git/+log/5625b6320279..d263d752ac35 git log 5625b6320279..d263d752ac35 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 hao.x.li@intel.com Fix scissor rect larger than render pass width/height in Metal backend Created with: gclient setdep -r src/third_party/dawn@d263d752ac35 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I29c074bf7255a3d60dffb1dc392e237461fa9f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525523 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641063} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a75df8ee6e26020c55ffa6108d6c40514ee7c6f5 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 03:23:28 2019 +0000 Update V8 to version 7.5.47. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f6dd8f7..e6ea6c00 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3463a17314e1fb321c7e4dbf291835f810d3e463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525448 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641062} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b9fae0f892483e685ba43406cc5fd042d1d7320 Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 03:16:07 2019 +0000 Change navigator.gpu.getAdapter to navigator.gpu.requestAdapter. This function now returns a Promise instead of getting an adapter synchronously. GPUAdapterDescriptor is renamed to GPURequestAdapterOptions. Bug: 941531 Change-Id: If8a996fe15adc6301f7378ce15f084cba1ae2601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521235 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641061} third_party/blink/renderer/modules/modules_idl_files.gni | 2 +- third_party/blink/renderer/modules/webgpu/gpu.cc | 15 ++++++++++++--- third_party/blink/renderer/modules/webgpu/gpu.h | 9 ++++++--- third_party/blink/renderer/modules/webgpu/gpu.idl | 5 ++++- ...ter_descriptor.idl => gpu_request_adapter_options.idl} | 5 ++--- 5 files changed, 25 insertions(+), 11 deletions(-) commit e0245949b9cf07609ab922480585b2f1ddb4e1e3 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Fri Mar 15 03:13:37 2019 +0000 Updating trunk VERSION from 3734.0 to 3735.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib942d816a32db8edc45e5206cc8acea8fc3842a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525414 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641060} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 67eee7cfb86d4cdf9d6e074d8f20189eadfd3d91 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Mar 15 03:08:14 2019 +0000 Update Swarming dimensions of Linux Intel HD 630 Experimental bot. It's been upgraded to Mesa 18.3.3 from 18.0.5. Bug: 928530 Change-Id: I2cebf3cfe028ed4e3108b021fc5277c818b66943 Tbr: sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525407 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641059} testing/buildbot/chromium.gpu.fyi.json | 34 +++++++++++++++++----------------- testing/buildbot/mixins.pyl | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) commit 6012d3cb4069456e3e72b09b2b4a55559c43d05c Author: dpapad <dpapad@chromium.org> Date: Fri Mar 15 03:02:24 2019 +0000 Settings WebUI: Remove double border in font subpage. Before/after screenshots: https://imgur.com/a/0NpIjAz Bug: None Change-Id: I0a8db2d980ae58c489e4375e2d83505eabc424b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524715 Reviewed-by: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641058} .../resources/settings/appearance_page/appearance_fonts_page.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 01e38032e30184e8e6c4669315d89e420ea9b5b6 Author: Nate Fischer <ntfschr@chromium.org> Date: Fri Mar 15 03:00:42 2019 +0000 NS: fix test filter syntax I added some tests to the filter in http://crrev/c/1522556. I forgot that "#" is illegal, and I should use "." instead. TBR=timvolodine@chromium.org Bug: 941856, 941858 Test: N/A Change-Id: I153abf26f9098460e2e9f2a6454978ae3682c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525413 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641057} .../buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9c719d1d65362fb85c90bb11719f513d44a35255 Author: Paul Dyson <pdyson@chromium.org> Date: Fri Mar 15 02:59:12 2019 +0000 Disable flaky tests in UserActivityManagerTest and WindowActivityWatcherTest Disable UserActivityManagerTest.BasicTabs as it has been flagged as flaky. Also disable WindowActivityWatcherTest.Basic and WindowActivityWatcherTest.ReplaceTab which sometimes fail at the same time as UserActivityManagerTest.BasicTabs. Bug: 938055 Change-Id: Ib8c8ce28e565cd032a5d1255a6e355a449679e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504474 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641056} chrome/browser/chromeos/power/ml/user_activity_manager_unittest.cc | 3 ++- chrome/browser/ui/tabs/window_activity_watcher_unittest.cc | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) commit fa3c60680c891176c2c3342fbabed75e23f745a2 Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Fri Mar 15 02:55:32 2019 +0000 Only delete WPR if it is not used by other stories R=perezju@chromium.org Bug: 895891 Change-Id: I2f363662f6f9ce4da0c6c76674db94c0404fa21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523093 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641055} tools/perf/cli_tools/update_wpr/update_wpr.py | 20 ++++++++++++++------ .../perf/cli_tools/update_wpr/update_wpr_unittest.py | 10 +++++++++- 2 files changed, 23 insertions(+), 7 deletions(-) commit 5d85114cbc8ab79b7f88a74220503e05081475e9 Author: Darren Shen <shend@chromium.org> Date: Fri Mar 15 02:55:13 2019 +0000 [VK] Remove some old features and flags. Change-Id: I3a21355822ad2c8e4b59c542471e280b656e6500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520859 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#641054} chrome/browser/about_flags.cc | 13 ------------- .../extensions/api/input_ime/input_ime_api_chromeos.cc | 3 +-- .../chrome_virtual_keyboard_delegate.cc | 5 +---- chrome/browser/flag_descriptions.cc | 16 ---------------- chrome/browser/flag_descriptions.h | 9 --------- ui/base/ui_base_features.cc | 11 ----------- ui/base/ui_base_features.h | 6 ------ ui/keyboard/keyboard_ukm_recorder.cc | 4 +--- ui/keyboard/keyboard_ukm_recorder_unittest.cc | 8 -------- 9 files changed, 3 insertions(+), 72 deletions(-) commit 5428f7c6e1aaa7d3457e0954e21382495ac31e0c Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 02:51:55 2019 +0000 Add an App Service icon cache BUG=826982 Change-Id: Id697f87ffb5dc143caea60fc02fd91133cb60938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522869 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641053} chrome/browser/BUILD.gn | 1 + .../browser/apps/app_service/app_service_proxy.cc | 42 ++-- .../browser/apps/app_service/app_service_proxy.h | 20 +- chrome/services/app_service/public/cpp/BUILD.gn | 14 ++ .../services/app_service/public/cpp/icon_cache.cc | 155 +++++++++++++++ .../services/app_service/public/cpp/icon_cache.h | 116 +++++++++++ .../app_service/public/cpp/icon_cache_unittest.cc | 212 +++++++++++++++++++++ .../services/app_service/public/cpp/icon_loader.cc | 66 +++++++ .../services/app_service/public/cpp/icon_loader.h | 99 ++++++++++ .../services/app_service/public/mojom/types.mojom | 3 + 10 files changed, 701 insertions(+), 27 deletions(-) commit 5618e8eadac015c2411429fe1775ec882810ddcc Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Mar 15 02:49:05 2019 +0000 [Audio Focus] Return id from request audio focus Return the ID from RequestAudioFocus which the media session can then be used to identify itself. This is for assistant so they can differentiate between the AssistantMediaSession and other sessions when controlling them. BUG=941578 Change-Id: Ie114c36b111e79125c918b9964196b3434d1294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521472 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641052} .../media_session/assistant_media_session.cc | 8 +- .../media_session/assistant_media_session.h | 2 + .../media/session/audio_focus_delegate_default.cc | 13 +++- services/media_session/audio_focus_manager.cc | 33 ++++----- services/media_session/audio_focus_manager.h | 3 +- .../media_session/audio_focus_manager_unittest.cc | 2 +- .../media_session/media_controller_unittest.cc | 13 +++- .../public/cpp/test/mock_media_session.cc | 86 +++++++++++----------- .../public/cpp/test/mock_media_session.h | 8 +- .../media_session/public/mojom/audio_focus.mojom | 15 ++-- 10 files changed, 101 insertions(+), 82 deletions(-) commit 0fcaa3b3fca2d10171f5bd2423b5a2ad55debada Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 02:47:01 2019 +0000 Convert ui::PlatformEventWaiter::PlatformEventMatcher and Related Code to base::RepeatingCallback BUG=714018,940130 TBR=sky@chromium.org Change-Id: I2dcacc52febbe0aeb72e90fe390239d1cb9ac201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525481 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641051} ui/aura/test/ui_controls_factory_aurax11.cc | 3 ++- ui/events/test/platform_event_waiter.cc | 14 ++++++++------ ui/events/test/platform_event_waiter.h | 7 ++++--- ui/views/test/ui_controls_factory_desktop_aurax11.cc | 3 ++- 4 files changed, 16 insertions(+), 11 deletions(-) commit 3e4613d9e2e704b6dcaaa362b7b6a355fd03b4ab Author: Yupei Lin <yplam@yplam.com> Date: Fri Mar 15 02:46:22 2019 +0000 Fix gdb viewg command While following the steps from docs/graphical_debugging_aid_chromium_views.md using gdb. Change-Id: Ic4d2193c29604bc548bdb6c84e8f0f70684366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522560 Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641050} AUTHORS | 1 + tools/gdb/viewg.gdb | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) commit 8c30e8ce823191ef55a548420df7e290a95d4cbc Author: Shu Chen <shuchen@google.com> Date: Fri Mar 15 02:45:12 2019 +0000 Move the mojom & typemap for ui::TextInputType to ui/base/ime/mojo. Currently the mojom for ui::TextInputType is under ui/platform_window/mojo, and the typemap is under services/ws/public/mojom/ime. It will cause problem if some other code wants to use ui.mojom.TextInputType. ui::TextInputType is defined under ui/base/ime, where the mojom and typemap should be. Bug: 937167 Change-Id: Ie62a49e7d9f0be5d8f6b9038b581543b8d9ca0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517339 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641049} content/common/render_widget_host_ns_view.mojom | 1 + .../bindings/chromium_bindings_configuration.gni | 5 +- services/ws/public/mojom/BUILD.gn | 2 +- services/ws/public/mojom/ime/BUILD.gn | 12 +- services/ws/public/mojom/ime/ime.mojom | 16 +-- services/ws/public/mojom/ime/ime.typemap | 2 - services/ws/public/mojom/ime/ime_struct_traits.cc | 129 ------------------- services/ws/public/mojom/ime/ime_struct_traits.h | 12 -- .../public/mojom/ime/ime_struct_traits_unittest.cc | 71 +---------- ui/aura/mus/input_method_mus.cc | 2 +- ui/base/BUILD.gn | 6 +- ui/base/ime/DEPS | 1 + ui/base/ime/mojo/BUILD.gn | 21 ++++ ui/base/ime/mojo/OWNERS | 8 ++ .../base/ime/mojo}/ime_struct_traits_test.mojom | 7 +- ui/base/ime/mojo/ime_struct_traits_unittest.cc | 96 ++++++++++++++ ui/base/ime/mojo/ime_types.mojom | 56 +++++++++ ui/base/ime/mojo/ime_types.typemap | 21 ++++ ui/base/ime/mojo/ime_types_struct_traits.cc | 138 +++++++++++++++++++++ ui/base/ime/mojo/ime_types_struct_traits.h | 30 +++++ ui/base/ime/mojo/typemaps.gni | 5 + ui/platform_window/mojo/BUILD.gn | 6 +- ui/platform_window/mojo/ime_type_converters.cc | 14 --- ui/platform_window/mojo/ime_type_converters.h | 12 -- ui/platform_window/mojo/text_input_state.mojom | 38 +----- 25 files changed, 400 insertions(+), 311 deletions(-) commit 752a1561485e8ed8d0dc38335a5a9a6058753762 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 02:42:02 2019 +0000 Roll src/third_party/swiftshader a2749f39f47d..9b156615197d (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/a2749f39f47d..9b156615197d git log a2749f39f47d..9b156615197d --date=short --no-merges --format='%ad %ae %s' 2019-03-14 bclayton@google.com SpirvShader: Split instructions into blocks. 2019-03-14 capn@google.com Fix allocation of low-alignment memory Created with: gclient setdep -r src/third_party/swiftshader@9b156615197d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5385d7628f5985a5085977d08495951d0c8569a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525034 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641048} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 95c1f858b14bbf3d619c1ce0ca0630603535233c Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri Mar 15 02:40:11 2019 +0000 [layoutng] Inline a couple more geometry functions Change-Id: I9c0c299f8aa576ea34f357ac88c2c79c0a50fb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1315669 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641047} third_party/blink/renderer/core/layout/BUILD.gn | 1 - .../core/layout/ng/geometry/ng_border_edges.cc | 36 --------------- .../core/layout/ng/geometry/ng_border_edges.h | 27 ++++++++++- .../core/layout/ng/geometry/ng_box_strut.cc | 50 -------------------- .../core/layout/ng/geometry/ng_box_strut.h | 54 +++++++++++++++++++++- 5 files changed, 77 insertions(+), 91 deletions(-) commit 6130949eaaf724cec6c90b2b54515b9e3dfe81e1 Author: Qingsi Wang <qingsi@chromium.org> Date: Fri Mar 15 02:27:48 2019 +0000 Move the getUserMedia gating of mDNS protection to FilteringNetworkManager. Our previous implementation would destroy the connection to the mDNS responder service host when the media capture permission is granted. As a result, any mDNS candidate created before the grant would become unresolvable. This issue is particularly evident when we have multiple peer connections of the same origin, where a newly created peer connection would temporarily toggle the permission to blocked before restoring the granted status if the user did give the permission. This could cause a peer connection created earlier and in the process of ICE candidate gathering to perform unnecessary mDNS obfuscation. After this change, the connection to the mDNS responder service host keeps alive, but just becomes unavailable for registration of new names when we have permissions granted. Bug: 930339, 937992 Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641046} .../webrtc/peer_connection_dependency_factory.cc | 49 +++++++--------------- .../webrtc/peer_connection_dependency_factory.h | 12 ++---- content/renderer/p2p/filtering_network_manager.cc | 30 +++++++------ content/renderer/p2p/filtering_network_manager.h | 13 +----- .../p2p/filtering_network_manager_unittest.cc | 4 +- content/renderer/p2p/ipc_network_manager.cc | 18 ++++---- content/renderer/p2p/ipc_network_manager.h | 6 +-- .../renderer/p2p/ipc_network_manager_unittest.cc | 3 +- 8 files changed, 49 insertions(+), 86 deletions(-) commit 609b4bbd7be1c7620c78a184a276d566f1e05a10 Author: Ben Hayden <benjhayden@chromium.org> Date: Fri Mar 15 02:27:02 2019 +0000 Reland Batch Histogram uploads. Some benchmarks such as rendering.mobile produce more data than the chromeperf dashboard can handle at once. This CL passes the new --max_bytes flag to add_reserved_diagnostics to batch histograms into multiple files, then uploads them one at a time. Initial CL: https://chromium-review.googlesource.com/c/1478085 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1486679 Reason for revert: File "...\upload_results_to_perf_dashboard.py", line 61, in _GenerateDashboardJSONs with open(options.output_json_file, 'w') as f: TypeError: coercing to Unicode: need string or buffer, file found Patchset 1 is the initial CL. Patchset 5 simplifies the initial approach and adds a test. Bug: chromium:909961 Change-Id: Ia66cff24531333ecea386785ccbae04e7386f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515649 Commit-Queue: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#641045} tools/perf/core/results_dashboard.py | 36 ++--- .../perf/core/upload_results_to_perf_dashboard.py | 72 +++++++--- tools/perf/process_perf_results.py | 149 +++++++++++---------- tools/perf/process_perf_results_unittest.py | 58 +++++++- 4 files changed, 202 insertions(+), 113 deletions(-) commit bfb994e1a78fd93a6adfacec2bb1fd665b4b58af Author: Siye Liu <siliu@microsoft.com> Date: Fri Mar 15 02:26:41 2019 +0000 Append block element that only contains br element onto clipboard during copy if the block element is at selection end. This patch adds a logic in blink::StyledMarkupSerializer<Strategy>::CreateMarkup and blink::StyledMarkupTraverser<Strategy>::Traverse so that the empty block element that only contains br element can be appended to blink::StyledMarkupAccumulator if the block element is at the end of selection during copy. The logic helps in creating the right markup to put onto clipboard during serialization. For example, <i>some text</i><p><br></p>, select all and copy, clipboard content should be look like: <!--startFrament--><i>some text</i></font><p><br></p><!--EndFragment--> Bug: 856324 Change-Id: Idd55bde473d4e6b3d7bf06b62167dd227ae65672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495371 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641044} .../serializers/styled_markup_serializer.cc | 28 ++++++- ...ste-blockquote-and-paragraph-break-expected.txt | 45 ---------- .../paste-blockquote-and-paragraph-break.html | 61 ++++++-------- .../editing/pasteboard/paste-text-016.html | 93 ++++++++++----------- ...ine-break-at-end-of-pasted-content-expected.txt | 18 ---- ...eserve-line-break-at-end-of-pasted-content.html | 53 ++++++------ .../editing/pasteboard/paste-text-016-expected.png | Bin 19984 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- .../editing/pasteboard/paste-text-016-expected.png | Bin 6555 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- .../editing/pasteboard/paste-text-016-expected.png | Bin 6439 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- 12 files changed, 124 insertions(+), 351 deletions(-) commit 457193040c9cb74b8eb7d524bbec073385a47758 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Mar 15 02:23:28 2019 +0000 Fix search widget location bar color not correct We simplified the location bar text color logic to be mostly based on the primary color at https://chromium-review.googlesource.com/c/chromium/src/+/1489416. This becomes an issue for the search widget because the primary color was transparent all the time. Bug: 940897 Change-Id: I16db7596d9a0db0ee277a106b5b890be2045e391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525286 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641043} chrome/android/java/res/layout/search_activity.xml | 2 +- .../chrome/browser/searchwidget/SearchActivity.java | 2 +- .../chrome/browser/searchwidget/SearchBoxDataProvider.java | 13 ++++++++++++- 3 files changed, 14 insertions(+), 3 deletions(-) commit 76e3f160394df9e89d62be3a85ca5a2fd68b25db Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Mar 15 02:22:48 2019 +0000 Roll src/ios/third_party/edo/src/ 0146bd6e1..57586e721 (1 commit) https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/0146bd6e1f05..57586e721389 $ git log 0146bd6e1..57586e721 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 haowoo Move the block from the stack to the heap before assigning it to the weak pointer. Created with: roll-dep src/ios/third_party/edo/src BUG=941680 Change-Id: Id616069d5894a535839547169669d49b02648e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524653 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641042} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 44a2f14903cae5f66435ffb42635089453721c04 Author: Peter Boström <pbos@chromium.org> Date: Fri Mar 15 02:21:48 2019 +0000 Remove custom InkDrop logic from NewTabButton This change removes InkDropContainerView usage and overrides of: * AddInkDropLayer * RemoveInkDropLayer * CreateInkDrop * CreateInkDropRipple * CreateInkDropHighlight * CreateInkDropMask ... and replaces them with a HighlightPath already in use by the FocusRing. Bug: None Change-Id: Id347f19d32f8b38443092eedd6604c71c5d9e6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525462 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#641041} chrome/browser/ui/views/tabs/new_tab_button.cc | 71 +++----------------------- chrome/browser/ui/views/tabs/new_tab_button.h | 19 +------ chrome/browser/ui/views/tabs/tab_strip.cc | 5 +- 3 files changed, 11 insertions(+), 84 deletions(-) commit 068025b22e63bdca62076e5752936b5a73e6a5e0 Author: John Z Wu <jzw@chromium.org> Date: Fri Mar 15 02:19:27 2019 +0000 Fix shutdown crash related to WebViewRequestContextGetter. Several member variables of WebViewRequestContextGetter may attempt to access net::NetLog during destruction, but since the latter gets destructed *after* the former, it can easily lead to dangling pointer issues. The fix is to just ensure those member variables are destroyed before net::NetLog so they can still access it safely. Alternatively, we can also just reorder the member variable list. Change-Id: I768f235fc8f62835fdcab603b254a87620ab046b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525446 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#641040} ios/web_view/internal/web_view_url_request_context_getter.mm | 7 +++++++ 1 file changed, 7 insertions(+) commit d21fb154db5a3f55413c07d616d13baecac1abe1 Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 02:17:33 2019 +0000 Recreate golden file loader for the time limit consistency tests, after last one was reverted. This time, a separated test binary is used to avoid dependency clashes between protobuf libs. Bug: 935711 Change-Id: I0789418f3a2c6c959845a1926f21832dcd0c389d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515206 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641039} BUILD.gn | 1 + .../consistency_golden_loader.cc | 71 ++++++++++++++ .../consistency_golden_loader.h | 41 ++++++++ .../consistency_golden_loader_unittest.cc | 47 +++++++++ .../goldens/consistency_golden.proto | 108 +++++++++++++++++++++ .../time_limit_consistency_test/proto_matcher.h | 43 ++++++++ .../run_all_unittests.cc | 15 +++ .../test_goldens/test_golden.textproto | 6 ++ .../test_goldens/test_golden_unsupported.textproto | 6 ++ chrome/test/BUILD.gn | 42 ++++++++ testing/buildbot/chromium.chromiumos.json | 14 +++ testing/buildbot/chromium.fyi.json | 7 ++ testing/buildbot/chromium.memory.json | 26 +++++ testing/buildbot/gn_isolate_map.pyl | 4 + testing/buildbot/test_suites.pyl | 3 + third_party/protobuf/BUILD.gn | 8 +- 16 files changed, 441 insertions(+), 1 deletion(-) commit 44aa7404976050b14858e6a5877c1880816dc776 Author: Ken Rockot <rockot@chromium.org> Date: Fri Mar 15 02:16:33 2019 +0000 [mojo-js] Correct compiled JS exports We were missing some goog.provide directives for generated interface types. This also removes usage of mojo.internal.exportModule when we're generating goog.provide, since only one of the two is necessary. Bug: 939680 Change-Id: I1f813fe9cebb3cac6b68c2e86cff650fcf51ed21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524331 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#641038} .../generators/js_templates/lite/interface_definition.tmpl | 12 ++++++++---- .../bindings/generators/js_templates/lite/mojom-lite.js.tmpl | 4 ++-- 2 files changed, 10 insertions(+), 6 deletions(-) commit a576e34ca7ceb3a511cd8a9aa6f478354e71ab8d Author: Leon Han <leon.han@intel.com> Date: Fri Mar 15 02:16:25 2019 +0000 [ServiceWorker] All provider hosts are owned by context core from birth A provider host on creation is always added into ServiceWorkerContextCore and owned there, later it'll destroy either when ServiceWorkerContextCore destroys or the Mojo connection it's bound breaks. This CL refactors code to strengthen the logic above. BUG=931092 Change-Id: I8feaebec0e1c539ad5e24bde3af7518e2f81aa17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522559 Commit-Queue: Leon Han <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641037} .../service_worker/service_worker_provider_host.cc | 34 +++++++++------------- .../service_worker/service_worker_provider_host.h | 4 +++ 2 files changed, 18 insertions(+), 20 deletions(-) commit 151b8b48a472342ba37786fd42b2c9b007bc8a52 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Mar 15 02:14:52 2019 +0000 [Dark] Contextual search dark support + bar background to grey 900 + 6% white in dark mode + promo background to grey 100 in light, grey 900 to dark + icon colors for close button and arrow button Bug: 934580 Change-Id: I35ed4db9ba156c92223e4e2aa9f48c22e1e2a6e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521770 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641036} .../res/layout/contextual_search_term_view.xml | 2 +- .../java/res/layout/ephemeral_tab_text_view.xml | 2 +- chrome/android/java/res/values-v17/styles.xml | 4 +-- chrome/android/java/res/values/colors.xml | 7 ++-- chrome/android/java/res_night/OWNERS | 9 +++++ .../android/java/res_night/values-night/colors.xml | 1 - .../compositor/bottombar/OverlayPanelBase.java | 27 +++++++++++++++ .../scene_layer/ContextualSearchSceneLayer.java | 40 ++++++++++++---------- .../scene_layer/EphemeralTabSceneLayer.java | 16 +++++---- .../compositor/layer/contextual_search_layer.cc | 18 ++++++---- .../compositor/layer/contextual_search_layer.h | 2 ++ .../compositor/layer/ephemeral_tab_layer.cc | 8 +++-- .../android/compositor/layer/ephemeral_tab_layer.h | 2 ++ .../compositor/layer/overlay_panel_layer.cc | 9 +++-- .../android/compositor/layer/overlay_panel_layer.h | 2 ++ .../scene_layer/contextual_search_scene_layer.cc | 34 ++++++++++-------- .../scene_layer/contextual_search_scene_layer.h | 2 ++ .../scene_layer/ephemeral_tab_scene_layer.cc | 9 +++-- .../scene_layer/ephemeral_tab_scene_layer.h | 2 ++ ui/android/java/res/values/color_palette.xml | 13 +++++++ ui/android/java/res/values/colors.xml | 17 ++++++++- ui/android/java/res_night/OWNERS | 9 +++++ ui/android/java/res_night/values-night/colors.xml | 6 +++- 23 files changed, 177 insertions(+), 64 deletions(-) commit cd746d79aba30cebb6525a0312f3c309c4b58628 Author: Leon Han <leon.han@intel.com> Date: Fri Mar 15 02:14:21 2019 +0000 [ServiceWorker] Make provider id be non-negative int Previously the browser-assigned provider id was a negative int going down from -2, to differentiate from the renderer-assigned provider id which has non-negative value. Now the renderer-assigned provider id has gone away with https://crrev.com/c/1520688 and we just have all provider ids created in the browser process, so we can make it be non-negative to be more like of an ID. BUG=931092 Change-Id: Icdc9933cc04e13c823e0a733d963f1f4411abf6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522557 Commit-Queue: Leon Han <leon.han@intel.com> Auto-Submit: Leon Han <leon.han@intel.com> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641035} .../browser/service_worker/service_worker_context_unittest.cc | 10 +++++----- content/browser/service_worker/service_worker_provider_host.cc | 7 +++---- 2 files changed, 8 insertions(+), 9 deletions(-) commit 8f30a2e75761511431980d03a5a7db1c165ff968 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 02:13:03 2019 +0000 Roll Fuchsia SDK from ddcb12bc41ac to 1a0b0112a4d8 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If46e19cad054575896ac34ed44f96efc4460c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525348 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641034} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 31e0a7112702537088afc8781b76e0b9e479c91f Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Mar 15 01:54:03 2019 +0000 DNR: Support loading/re-indexing multiple rulesets in FileSequenceHelper. This adds support for loading/re-indexing multiple rulesets in FileSequenceHelper. No behavior changes are made in this CL. This is in preparation of adding support for dynamic rules and possibly multiple static rulesets. BUG=930961 Change-Id: I13c99a3e5a89f7615317a04e08ecd5fc52464a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519548 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Jay Civelli <jcivelli@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641033} extensions/browser/BUILD.gn | 1 + .../file_sequence_helper.cc | 186 ++++++++++++++------ .../declarative_net_request/file_sequence_helper.h | 29 ++-- .../file_sequence_helper_unittest.cc | 189 +++++++++++++++++++++ .../rules_monitor_service.cc | 45 ++--- .../data_decoder/public/cpp/testing_json_parser.cc | 6 +- 6 files changed, 369 insertions(+), 87 deletions(-) commit 56d7a4891c5d2b977223e47f1d5b74772df8de0a Author: Alex Danilo <adanilo@chromium.org> Date: Fri Mar 15 01:49:44 2019 +0000 Remove tooltip from Open in quickview. The Open button in the quickview panel was changed from an icon to text to match the main FilesApp panel. This change removes the tooltip, since it's redundant. Bug: 941956 Change-Id: I1cd38e8787a56fe9a8647a5793314dbfcb1866fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525248 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641032} ui/file_manager/file_manager/foreground/elements/files_quick_view.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 78128d88ba9d52844d344a677c2eb84b12e9a585 Author: Vladislav Kaznacheev <kaznacheev@chromium.org> Date: Fri Mar 15 01:49:23 2019 +0000 Revert "app_list: Set AppList as parent of uninstall dialog" This reverts commit fb08feb52da0cfd813ff9f409d620aa59371601f. Reason for revert: caused a crash (http://crbug.com/939667) Original change's description: > app_list: Set AppList as parent of uninstall dialog > > Currently, when the uninstall dialog is opened from the Launcher, the Launcher > is dismissed, which is confusing to the user. By parenting the dialog to the > Launcher, the UX is much better. > > Because we cannot directly access Ash windows anymore, this fix requires us to > explicitly set the dialog's parent window via MUS properties. > > TEST=manually verified + new browser tests > BUG=814619 > > Change-Id: Ic25cb376191aaba8048f95fa5d0032b0328b8bc8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496447 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Tim Song <tengs@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638016} TBR=xiyuan@chromium.org,tengs@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 814619 Change-Id: I7dd1c47d2edfc19fddd4302ae0b7fb1e42d835ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525273 Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#641031} ash/public/interfaces/shell_test_api.test-mojom | 4 -- ash/shell_test_api.cc | 11 ---- ash/shell_test_api.h | 3 - .../extensions/extension_uninstall_dialog.cc | 1 - .../extensions/extension_uninstall_dialog.h | 3 - .../extensions/extension_uninstall_dialog_view.cc | 30 --------- .../extension_uninstall_dialog_view_browsertest.cc | 76 ---------------------- 7 files changed, 128 deletions(-) commit 37608a45ad317e3932b5aabe6fa32f8d2a114456 Author: Michael Giuffrida <michaelpg@chromium.org> Date: Fri Mar 15 01:37:40 2019 +0000 Make HomeScreenController control home screen visibility Make HomeScreenController responsible for determining home screen visibility instead of AppListControllerImpl, including updates based on window dragging and wallpaper preview. The app list controller now implements HomeScreenDelegate::ShowHomeScreen() to show the full-screen app list window. Also adds IsHomeScreenAvailable() which should be used to determine whether to use the home screen instead of checking tablet mode directly. Bug: 937549 Change-Id: If864614e7dcc4a818dc5368cf5e68e9475afacb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504847 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641030} ash/app_list/app_list_controller_impl.cc | 57 ++++-------------- ash/app_list/app_list_controller_impl.h | 26 +-------- ash/home_screen/home_screen_controller.cc | 68 +++++++++++++++++++++- ash/home_screen/home_screen_controller.h | 37 +++++++++++- ash/home_screen/home_screen_delegate.h | 12 ++++ ash/shelf/app_list_button.cc | 21 ++++--- .../tablet_mode_browser_window_drag_delegate.cc | 8 +-- 7 files changed, 144 insertions(+), 85 deletions(-) commit 464770194eb7074a04e8d977f9d5207def329650 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Mar 15 01:36:40 2019 +0000 [Files app] Fix gruped partitions format menu Fix directory tree context menu for removable partitions when they're grouped with a common root, where the "format" option wasn't shown. Directory tree has 2 context menus root and non-root menus, when partitions are grouped it's using a non-root menu which didn't have the "format" command. This CL add the "format" command to non-root menu and fix the condition to only display for removable root. Bug: 941174 Change-Id: I27ff6f8e1813f84d76341c6abd4376a0743c14d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522508 Reviewed-by: Stuart Langley <slangley@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641029} .../file_manager/foreground/js/file_manager_commands.js | 9 +++++---- ui/file_manager/file_manager/main.html | 1 + .../file_manager/directory_tree_context_menu.js | 1 + 3 files changed, 7 insertions(+), 4 deletions(-) commit 2f207048010835e377a95134c731462a6e664f19 Author: Justin Cohen <justincohen@google.com> Date: Fri Mar 15 01:25:32 2019 +0000 [ios] Rewrite remote session urls on restore for legacy nav too. Followup to http://crrev.com/c/1444011, which corrected remote sessions for slimnav, but not for legacy nav. Bug: 942139 Change-Id: I824bd4f7b45fac99d97ef78f53d84563086775b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525054 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641028} ios/web/navigation/legacy_navigation_manager_impl.mm | 3 +++ 1 file changed, 3 insertions(+) commit e3e7947724ac866479d8432a7055b5f25e16584f Author: Dan Beam <dbeam@chromium.org> Date: Fri Mar 15 01:23:33 2019 +0000 Navi: fix gzip-related crash Based on https://crrev.com/c/1524907 by Hector Carmona <hcarmona@chromium.org> Bug: 941882 Change-Id: Iea5cd2c0bd22bb57eafa6a4d507c93b045e50c31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525196 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641027} chrome/browser/ui/webui/welcome/welcome_ui.cc | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) commit 4e362ac4ed51bab4f3eebac378846644249dd96f Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 01:10:09 2019 +0000 Convert LinuxUI::NativeThemeGetter to RepeatingCallback and Update Related Calls BUG=714018,940130 TBR=sky@chromium.org Change-Id: I330f1a83003019ce1af35cf554fb7116e3da5bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525271 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641026} chrome/browser/ui/libgtkui/gtk_ui.cc | 4 ++-- chrome/browser/ui/libgtkui/gtk_ui.h | 5 +---- .../browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc | 2 +- ui/views/linux_ui/linux_ui.h | 6 +++--- 4 files changed, 7 insertions(+), 10 deletions(-) commit 4a2231b919c944b79dbc3cf0da2fd19f315b1c84 Author: John Budorick <jbudorick@chromium.org> Date: Fri Mar 15 01:09:59 2019 +0000 Disable ChromeVoxEditingTest.RichTextMoveByCharacterAllAttributes. Bug: 942241 Change-Id: I39e2bf63413a0bf2b646d465a9f694f411b0b0fb Tbr: akihiroota@chromium.org,dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525006 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641025} .../resources/chromeos/chromevox/cvox2/background/editing_test.extjs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 40727b5f8eb1413cb11a09ae348a0794853095b9 Author: Christian Fremerey <chfremer@chromium.org> Date: Fri Mar 15 01:09:04 2019 +0000 [Video Capture Service, ChromeOS] Run video capture service in browser process Before this CL, the video capture service, on ChromeOS, would run in a separate utility process unless the HAL v3 service was being used. This CL changes this so that on ChromeOS the video capture service always runs in the browser process. This is to mitigate an issue with screen rotation events only being available in the browser process. Bug: 891961 Change-Id: I4764f7cf131fff819e9e0f726d45bb86af09ed9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506604 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641024} .../webrtc/webrtc_video_capture_browsertest.cc | 19 +++++++------------ content/public/common/content_features.cc | 13 ++++--------- 2 files changed, 11 insertions(+), 21 deletions(-) commit d16fde55af5633ac086e9a04b2fe7ee65fd513ab Author: Scott Graham <scottmg@chromium.org> Date: Fri Mar 15 01:08:55 2019 +0000 Reland "Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263" This is a reland of 5b33ce1bbedab114c8657acb8047c0f3150ac0de Original change's description: > Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263 > > 48ee086ca4c4 fuchsia: Update to run crashpad_test as package rather than > from /system > 2271f00fe076 Add missing BUILD.gn for third_party/apple_cf > 3332ae354672 compat: Provide <elf.h> and <mach-o/loader.h> for everyone > 708367f5badf POSIX: ScopedMmap length refinement > 5a21d038c9c9 Work around libcrashpad_handler_trampoline.so ASan trunk > clang problem > c8fdad4fe58f Update DEPS for buildtools and GYP > 2a47ea4663dd Obtain the Fuchsia SDK from the correct (updated) location > 36f9051cafca Enable clang -Wextra-semi in POSIX/Fuchsia clang builds > 348022def8d5 Fuchsia: Proper Fuchsia-on-macOS cross build support > aa160f658175 [fuchsia] Update header include > 1bb8ca4059d8 Silence some warnings > > Change-Id: Ic40aa09f581c5b1339ac7d7c0a50a55f2d15ea99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524084 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Scott Graham <scottmg@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640817} Change-Id: If37cdebfafda6ae1526c665f9362a86b5a59ed68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525281 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Scott Graham <scottmg@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#641023} third_party/crashpad/README.chromium | 2 +- third_party/crashpad/crashpad/BUILD.gn | 48 +- third_party/crashpad/crashpad/DEPS | 32 +- third_party/crashpad/crashpad/compat/BUILD.gn | 25 +- third_party/crashpad/crashpad/compat/non_elf/elf.h | 20 + .../crashpad/compat/non_mac/mach-o/loader.h | 20 + .../crashpad/compat/non_mac/mach/machine.h | 21 + .../crashpad/compat/non_mac/mach/vm_prot.h | 20 + .../snapshot/minidump/thread_snapshot_minidump.cc | 4 - .../crashpad/test/fuchsia_crashpad_tests.cmx | 21 + third_party/crashpad/crashpad/test/test_paths.cc | 31 +- .../crashpad/third_party/apple_cf/BUILD.gn | 19 + .../third_party/apple_cf/CFStreamAbstract.h | 17 +- .../crashpad/third_party/apple_cf/README.crashpad | 2 +- .../crashpad/crashpad/third_party/fuchsia/BUILD.gn | 137 +- .../crashpad/crashpad/third_party/glibc/BUILD.gn | 19 + .../crashpad/third_party/glibc/COPYING.LIB | 502 +++ .../crashpad/third_party/glibc/README.crashpad | 16 + .../crashpad/crashpad/third_party/glibc/elf/elf.h | 4003 ++++++++++++++++++++ .../crashpad/third_party/xnu/APPLE_LICENSE | 367 ++ .../crashpad/crashpad/third_party/xnu/BUILD.gn | 19 + .../xnu/EXTERNAL_HEADERS/mach-o/loader.h | 1531 ++++++++ .../crashpad/third_party/xnu/README.crashpad | 19 + third_party/crashpad/crashpad/util/BUILD.gn | 5 +- .../crashpad/util/fuchsia/koid_utilities.cc | 2 +- .../crashpad/crashpad/util/posix/scoped_mmap.cc | 26 +- .../crashpad/crashpad/util/posix/scoped_mmap.h | 5 + .../crashpad/util/posix/scoped_mmap_test.cc | 12 +- tools/licenses.py | 6 + 29 files changed, 6793 insertions(+), 158 deletions(-) commit de7b81d1ca8f98c0666d232092058277ace9e266 Author: Dana Fried <dfried@chromium.org> Date: Fri Mar 15 01:08:00 2019 +0000 Move most of TabStyle into c/b/ui. Because tab thumbnailing logic will be using standard tab size as part of its calculation of how large of a thumbnail to create (to be used in tab hover cards) the core properties of a tab need to be available in c/b/ui rather than just c/b/ui/views. Otherwise, an illegal dependency is created. The updated thumbnailing logic will be added in a later CL. Bug: 928954 Change-Id: Ie51ef3057828a0baad670fd1459df3cb6784651e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519322 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641022} chrome/browser/ui/BUILD.gn | 6 +- chrome/browser/ui/ash/tab_scrubber.cc | 9 ++- chrome/browser/ui/tabs/tab_style.cc | 75 +++++++++++++++++++ chrome/browser/ui/{views => }/tabs/tab_style.h | 67 +++++++++-------- .../browser/ui/views/tabs/glow_hover_controller.cc | 12 ++-- .../browser/ui/views/tabs/glow_hover_controller.h | 12 +--- chrome/browser/ui/views/tabs/tab.cc | 9 +-- chrome/browser/ui/views/tabs/tab.h | 8 +-- .../browser/ui/views/tabs/tab_drag_controller.cc | 2 +- .../ui/views/tabs/tab_hover_card_bubble_view.cc | 2 +- chrome/browser/ui/views/tabs/tab_strip.cc | 10 +-- chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 14 ++-- .../tabs/{tab_style.cc => tab_style_views.cc} | 83 ++++------------------ chrome/browser/ui/views/tabs/tab_style_views.h | 38 ++++++++++ chrome/browser/ui/views/tabs/tab_unittest.cc | 6 +- 15 files changed, 202 insertions(+), 151 deletions(-) commit 3c18a385aebd1e0498231d59c0e269a95678cfb9 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Mar 15 01:07:51 2019 +0000 Add presubmit checks for //buildtools/DEPS entries. Due to limitations in how gclient works, we currently need to duplicate entries in //DEPS and //buildtools/DEPS, and it is possible for them to not be kept in sync. We don't want that. This CL adds a presubmit check so that if you modify the relevant lines in one file you are required to modify them in another. If we ever fix the linked bug so that we don't need to duplicate the content, we can remove these presubmit checks. This CL also gets rid of deps_revisions.gni in //buildtools, and switches to passing the libcxx_revision value from gclient to GN via gclient_gn_args. In order for this to work correctly, anyone using both //buildtools and //build in GN will need to *also* export the variable from their DEPS files. Bug: 941824, 930836 Change-Id: I438c9966c497737cd4984a14cdb0c8993ffcad9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522466 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641021} DEPS | 29 +++++++++++++++-------------- PRESUBMIT.py | 41 +++++++++++++++++++++++++++++++++++++++++ PRESUBMIT_test.py | 44 ++++++++++++++++++++++++++++++++++++++++++++ buildtools/DEPS | 10 ++++++++++ 4 files changed, 110 insertions(+), 14 deletions(-) commit bb5c7b0beb6d6aca295cdc2ff32e91be1de8801f Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 01:06:54 2019 +0000 Convert DesktopWindowTreeHostX11::DisableEventListening to OnceClosure and Fix Memory Leak OnFilePickerDestroy() needs to also destroy the pointer it receives. BUG=714018,940130 Change-Id: Ib0402575a7115b0e8b125e1131b61238561e95f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524879 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641020} chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc | 15 +++++++++------ .../widget/desktop_aura/desktop_window_tree_host_x11.cc | 8 +++----- .../widget/desktop_aura/desktop_window_tree_host_x11.h | 2 +- 3 files changed, 13 insertions(+), 12 deletions(-) commit 9f3eb4a941e865dcfff420344b06fb004097a1d2 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Mar 15 01:06:46 2019 +0000 DCHECK desktop media class names before casting, not after. Technically, if we violated this assertion, we'd do an invalid cast before calling a member function, leading to undefined behavior. This also switches to using the generic View* base type in cases where the subtype is not needed, which allows using standard Views accessors more. Bug: none Change-Id: I40b51579273b0b1f3c64d0cf15beeaed4708957e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524540 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641019} .../desktop_capture/desktop_media_list_view.cc | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) commit cdd7912a80b10e956ae4904c7db079c8a931c6b3 Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Mar 15 01:05:45 2019 +0000 Revert "[protobuf] remove deprecated deps parameter" This reverts commit 48e4811635167d4f1c7aaccb5256152f1475ee99. Reason for revert: To unblock libassistant roll Original change's description: > [protobuf] remove deprecated deps parameter > > I replaced all appearance of deps with proto_deps or link_deps. > > Bug: 938011 > Change-Id: I95b8d6363358ecd8c350f095baaa10b12a968e3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506915 > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640063} TBR=pkasting@chromium.org,xyzzyz@chromium.org,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 938011 Change-Id: Idccc769b22a11b46a8db421c6d62e09ce012b67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524744 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641018} third_party/protobuf/proto_library.gni | 10 ++++++++++ 1 file changed, 10 insertions(+) commit ed504eff44d516b9235793b5a0c2e9d6430183b8 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Fri Mar 15 01:05:42 2019 +0000 GWP-ASan: Send fewer metrics Don't send metrics for unrelated crashes, only for GWP-ASan crashes and error reports. The unrelated crashes are uninteresting and obscure the other (smaller) numbers of reports that I am interested in. Bug: 896019 Change-Id: Ic205f5fb0798b489889c2fa639fc2464f066bb6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518755 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#641017} components/gwp_asan/crash_handler/crash_handler.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit b647caba150591930587799f9ade2f8a2d2fdad4 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Mar 15 01:04:37 2019 +0000 MacPWAs: Move NSRunningApplication KVO creation to UI thread This is a speculative fix. We create a KVO for -[NSRunningApplication isTerminated] on the IO thread, where the NSRunningApplication is created. In the observer, we post a task to the UI thread, and we remove the KVO in that callback. This removal causes a crash claiming that no such observer exists. Note that the observer is also called with the initial value, because of the NSKeyValueObservingOptionInitial argument. I can see two potential problems here: 1. This code assumes that the KVO is only called once. - This is a boolean property that will only ever to NO->YES, so this would seem a safe assumption. - If this were not true, then we would call removeObserver twice, which is what we're seeing occur. We would also use-after-free the TerminationObserver. 2. The callback on the UI thread could potentially be made before the call to addObserver on the IO thread is complete. - This would call removeObserver from within addObserver, which is not allowed. Fix the two problems by: 1a. In onTerminated, early-out if |callback_| has already been issued. 1b. Use a scoped_nsobject for the task posted to the UI thread. 2. Call both addObserver and removeObserver on the UI thread (so that they won't become reentrant). X. Only create the observer if -[NSRunningApplication isTerminated] is NO. This is not needed to fix any bugs, but limits the cases in which we create a TerminationObserver. Bug: 941909 Change-Id: Id3b36900ac0c46a7ec48d4c7d2e3600cc5c61ef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524340 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#641016} .../components/web_app_shortcut_mac.mm | 62 +++++++++++++++++----- 1 file changed, 50 insertions(+), 12 deletions(-) commit a88298a08628bf98a70125fbfe2208d55b3bc454 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 01:04:19 2019 +0000 Update V8 to version 7.5.45. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7677b798..3f6dd8f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4c3a802251af5656fa7f6ac064265dd0708a99f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524916 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641015} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c3546aa21061ef3fcbad1739682aa1f21b77b9b7 Author: Donn Denman <donnd@chromium.org> Date: Fri Mar 15 01:03:29 2019 +0000 [TTS] Fix a flaky test by restriction to M+ phones Should fix a flaky testLongPressGestureFollowedByTapDoesntSelect test which seems to work fine on M phones, and hopefully later versions of Android too. BUG=837998 Change-Id: I4233b6eda177ff1bde9449581f32b8029d4b41bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524092 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641014} .../chrome/browser/contextualsearch/ContextualSearchManagerTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8448a194ca90ae308d9d02e547a2b326bdf846cc Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Mar 15 01:03:16 2019 +0000 [Extensions Bindings] Remove JS-bindings C++ messaging code The old JS-based bindings for extension messaging had a handful of native helpers, which are now obsolete with the full native implementation. Remove the JSRendererMessagingService and ExtensionPort classes entirely, and remove the vast majority of MessagingBindings. MessagingBindings::BindToGC() is used outside of messaging, and so needs to remain (but we should rename the class or move the method in a follow-up). Bug: 938998 Change-Id: Ia697f4e19b8ac03ef87a62d9b8385cced8f08fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523981 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641013} extensions/renderer/BUILD.gn | 4 - extensions/renderer/extension_port.cc | 58 ---- extensions/renderer/extension_port.h | 56 ---- .../renderer/js_renderer_messaging_service.cc | 189 ------------ .../renderer/js_renderer_messaging_service.h | 51 ---- extensions/renderer/messaging_bindings.cc | 318 +-------------------- extensions/renderer/messaging_bindings.h | 57 +--- extensions/renderer/renderer_messaging_service.cc | 1 - extensions/renderer/renderer_messaging_service.h | 2 + 9 files changed, 9 insertions(+), 727 deletions(-) commit 80fd8006a00feb8b33cea78ef31dde9372ae1329 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Mar 15 01:02:21 2019 +0000 Move ScopedVisibilityTracker to chrome/browser This CL: 1. Moves the ScopedVisibility tracker to chrome/browser 2. Adds it to the PageLoadMetricsObserverDelegate 3. Updates the http/s engagement observer to use the new delegate method. 4. Updates ScopedVisibilityTracker::GetForegroundDuration to be properly const. This CL is in preparation for another page load metrics observer that needs this kind of capability. It shouldn't have any behavior change. Bug: 937298 Change-Id: I685b05e191ccc04915eb5be7685332d800fda278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525182 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#641012} chrome/browser/BUILD.gn | 2 + .../https_engagement_page_load_metrics_observer.cc | 51 +++++----------------- .../https_engagement_page_load_metrics_observer.h | 11 ----- .../page_load_metrics_observer_delegate.h | 4 ++ .../browser/page_load_metrics/page_load_tracker.cc | 8 ++++ .../browser/page_load_metrics/page_load_tracker.h | 4 ++ .../scoped_visibility_tracker.cc | 7 +-- .../scoped_visibility_tracker.h | 8 ++-- .../scoped_visibility_tracker_unittest.cc | 2 +- chrome/browser/ui/BUILD.gn | 2 - .../ui/blocked_content/popup_opener_tab_helper.cc | 2 +- chrome/browser/ui/blocked_content/popup_tracker.h | 2 +- chrome/test/BUILD.gn | 2 +- 13 files changed, 41 insertions(+), 64 deletions(-) commit c53dd1380176044273b047bf50e332fbf9f05b82 Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 01:01:48 2019 +0000 Remove a redundant InternalAppIconLoader field Change-Id: I73c538d0ebf1e4b1aa71e91f32d8102e1fd0c435 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510696 Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641011} chrome/browser/ui/app_list/internal_app/internal_app_icon_loader.cc | 5 ++--- chrome/browser/ui/app_list/internal_app/internal_app_icon_loader.h | 3 --- 2 files changed, 2 insertions(+), 6 deletions(-) commit 7756e9422c35e63e32de28fd9344f8db32f83518 Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Fri Mar 15 01:00:45 2019 +0000 Only try to commit if there is diff This is important if first attempt to upload CL has failed for some reason, e.g. presubmit failure, and on the second try we only need to execute git-cl-upload. R=perezju@chromium.org Bug: 895891 Change-Id: If55e2143365ae4b1135e0d65bdaf2fc5a4edcb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520679 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641010} tools/perf/cli_tools/update_wpr/update_wpr.py | 3 ++- tools/perf/cli_tools/update_wpr/update_wpr_unittest.py | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) commit 9e20b1f940adcfdfc188160985b03ec3f05923a6 Author: Lambros Lambrou <lambroslambrou@chromium.org> Date: Fri Mar 15 01:00:41 2019 +0000 [remoting host] Apply bitrate caps correctly. Bitrate caps were set only during OnStatsDelivered(), which is connected to the ICE connection state, not the signalling (SDP) state. This CL sets the global (PeerConnection) bitrates after SetRemoteDescription() is called. And it sets the Sender bitrates when the (Video)Sender is created. Since the relay status is (probably) not known at those times, the bitrates are also set in OnStatsDelivered() if the relay status has changed. By setting the min/max caps sooner, this may improve BWE performance. Bug: 941217 Change-Id: Ic623eb78544d22b1ebc94dcef906fd85e4d289b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524690 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Seth Hampson <shampson@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#641009} remoting/protocol/webrtc_audio_stream.cc | 2 ++ remoting/protocol/webrtc_audio_stream.h | 3 +- remoting/protocol/webrtc_transport.cc | 52 ++++++++++++++++++++++++-------- remoting/protocol/webrtc_transport.h | 24 +++++++++++++++ remoting/protocol/webrtc_video_stream.cc | 2 ++ remoting/protocol/webrtc_video_stream.h | 3 +- 6 files changed, 72 insertions(+), 14 deletions(-) commit 466cf0e47344fefc6c963525953d088857ffa24e Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 00:59:38 2019 +0000 Convert DesktopWidgetTest.CloseDestroys To Use RunLoop::QuitClosure BUG=940130 TBR=sky@chromium.org Change-Id: I62f09fa321aec2fabb551a38b216e3dd0aef281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525189 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641008} ui/views/widget/widget_unittest.cc | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) commit b6747a875c97018c48b92ef078c6d1e3ca3abfb0 Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Mar 15 00:59:34 2019 +0000 Mark several tasks in BrowserStartupControllerImpl.java as BOOTSTRAP In future this will prioritize them and make starup slightly faster. Bug: 863341 Change-Id: Ie38780ac22b83ec754a6c1b924a8ad0cfd25c641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524046 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641007} .../org/chromium/content/browser/BrowserStartupControllerImpl.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit d3327fdc7f5ff6a26ff8cafd4e118b3bd118a75f Author: Ross McIlroy <rmcilroy@chromium.org> Date: Fri Mar 15 00:21:59 2019 +0000 Revert "[Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab." This reverts commit eb14a6d18ec6c078e26fbf85a8172d880c4f34a3. Reason for revert: Broke Pixel2 bots Original change's description: > [Perf] Update Pixel2 FYI perf bot to MonoChrome6432.aab. > > This will update the Pixel2 bots to use the MonoChrome6432.aab which is a 64bit > browser. In making this change a new 'exact_browser' option is added to > tester_config in perf_data_generator to allow specifying a particular binary to > be run rather than guessing. > > BUG=934251 > > Change-Id: I2cd42eb3d7d6c4f36f4d15e36e4a605bf6f86e2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511455 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Reviewed-by: Matthew Cary <mattcary@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639530} TBR=rmcilroy@chromium.org,perezju@chromium.org,crouleau@chromium.org,mattcary@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934251 Change-Id: I9c541463d9ff94e1f08f83842aa8d58072167870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524287 Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#641006} testing/buildbot/chromium.perf.fyi.json | 4 +- tools/perf/core/perf_data_generator.py | 11 +---- tools/perf/core/perf_data_generator_unittest.py | 55 ------------------------- tools/perf/core/perf_json_config_validator.py | 13 +++--- 4 files changed, 8 insertions(+), 75 deletions(-) commit 09472a0fb420ac613c8a21f3185f405367f09519 Author: rbpotter <rbpotter@chromium.org> Date: Fri Mar 15 00:18:13 2019 +0000 Print Preview: Move destination and invitation stores, user info print-preview-app and print-preview-model owned properties used exclusively by destination-settings. This CL moves these properties and the user-info element into destination-settings. It also converts recent destinations to a setting, so that sticky settings updates can be done the same way they are for other settings, and so that destination-settings can own this property as well. This CL also adds a new destinationState for the print-preview-app to correctly update its state based on destination events. These changes will facilitate more easily refactoring print-preview-app in future, by reducing the properties and logic it is responsible for. Bug: 942345 Change-Id: I1cbad055b40a2ba1ca4e067284320c2752f47c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517045 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641005} .../resources/print_preview/data/destination.js | 13 + .../print_preview/data/destination_store.js | 48 ++- .../resources/print_preview/data/user_info.js | 16 +- .../browser/resources/print_preview/new/BUILD.gn | 7 +- .../browser/resources/print_preview/new/app.html | 25 +- chrome/browser/resources/print_preview/new/app.js | 249 ++++---------- .../print_preview/new/destination_dialog.js | 2 +- .../print_preview/new/destination_select.html | 9 +- .../print_preview/new/destination_select.js | 23 +- .../print_preview/new/destination_settings.html | 27 +- .../print_preview/new/destination_settings.js | 381 +++++++++++++++------ .../browser/resources/print_preview/new/model.js | 77 +---- .../print_preview/new/settings_behavior.js | 18 + .../print_preview/print_preview_resources.grd | 9 +- .../webui/print_preview/destination_select_test.js | 105 +++--- .../print_preview/destination_settings_test.js | 240 +++++++------ .../print_preview/invalid_settings_browsertest.js | 42 ++- chrome/test/data/webui/print_preview/model_test.js | 50 --- .../new_print_preview_ui_browsertest.js | 13 +- .../webui/print_preview/preview_generation_test.js | 2 + .../data/webui/print_preview/print_button_test.js | 49 ++- .../webui/print_preview/print_preview_app_test.js | 69 +--- 22 files changed, 729 insertions(+), 745 deletions(-) commit fb8e53f0793de0647f65d7edc6416bc9b13a651b Author: Zhenyao Mo <zmo@chromium.org> Date: Fri Mar 15 00:13:57 2019 +0000 Move GpuIntegrationTestAdapter to its own file This paves way for it to also be used in run_performance_tests.py BUG=867155 TEST=bots R=kbr@chromium.org,crouleau@chromium.org Change-Id: Ib6f88708e3a292649719fef87729240f3b683786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521792 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641004} chrome/test/BUILD.gn | 1 + testing/scripts/get_compile_targets.py | 4 ++- testing/scripts/gpu_integration_test_adapter.py | 34 +++++++++++++++++++++ .../run_gpu_integration_test_as_googletest.py | 35 ++-------------------- 4 files changed, 40 insertions(+), 34 deletions(-) commit 8a128cc02ae22a00b82d3696e97fe97d5ff75c76 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Mar 15 00:12:19 2019 +0000 C++ tips: remove guidance for hiding static details in implementation. The current guidance recommends a construct that generates a global constructor / destructor, which is forbidden. Since this is similar enough to the previous section on inner classes, just remove it since a separate section shouldn't be needed. Change-Id: Ie3150e6e85bb700d17f802fbe71c244329feb660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524338 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641003} styleguide/c++/c++-dos-and-donts.md | 37 ++----------------------------------- 1 file changed, 2 insertions(+), 35 deletions(-) commit 012cf25029f0585801528c811a03410fcb80f60c Author: Justin Cohen <justincohen@google.com> Date: Fri Mar 15 00:05:25 2019 +0000 [ios] Don't rely on nil webState in LocationBarCoordinator. Bug: 934294 Change-Id: I3737b1560f138250206f9f1b8648d32ada9f0392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520702 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641002} .../ui/location_bar/location_bar_coordinator.mm | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) commit 532802dbc667c84da2465aafda960196124549c8 Author: Salvador Guerrero <salg@google.com> Date: Fri Mar 15 00:02:57 2019 +0000 Changed DOM distiller store to new leveldb_proto API dom_distiller_store now uses the new leveldb_proto API, which enables migrating to a shared leveldb database. TBR=sdefresne@chromium.org Bug: 870813 Change-Id: Iee75d947149165e4408902e44d4e31fbaa83cbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504170 Commit-Queue: Salvador Guerrero <salg@google.com> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#641001} .../dom_distiller/dom_distiller_service_factory.cc | 14 +++++++---- .../dom_distiller_viewer_source_browsertest.cc | 2 +- components/BUILD.gn | 1 + .../core/dom_distiller_service_unittest.cc | 2 +- .../dom_distiller/core/dom_distiller_store.cc | 27 ++++++---------------- .../dom_distiller/core/dom_distiller_store.h | 18 ++++----------- .../core/dom_distiller_store_unittest.cc | 12 ++++------ .../dom_distiller/core/dom_distiller_test_util.cc | 2 +- .../standalone/content_extractor_browsertest.cc | 11 +++++++-- .../public/shared_proto_database_client_list.cc | 2 ++ .../public/shared_proto_database_client_list.h | 3 ++- 11 files changed, 44 insertions(+), 50 deletions(-) commit d4377bf6ecc353ba6524081cba485ad583b98064 Author: John Budorick <jbudorick@chromium.org> Date: Fri Mar 15 00:01:51 2019 +0000 Revert "Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds." This reverts commit 889a9665145519f88a755826e6c4a3c15f8fda7a. Reason for revert: broke Mac ASan 64: https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/78868 Original change's description: > Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. > > Removes some special-case code and potentially makes debug info a bit smaller. > > Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case > on linux -- this helps with build determinism. > > Bug: 942155,899438,906741,429358 > Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640963} TBR=thakis@chromium.org,mark@chromium.org Change-Id: Ie941d4661c81d97a79ac93f86e8f39df0be467e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942155, 899438, 906741, 429358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525280 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641000} build/config/compiler/BUILD.gn | 67 +++++++++++++++++++++--------------------- 1 file changed, 34 insertions(+), 33 deletions(-) commit ca9980bcc4e866719edaa0cbd27316621880136b Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 00:00:44 2019 +0000 Inline RunAllPendingInMessageLoop in DesktopWindowTreeHostX11Test.Shape BUG=940130 TBR=sky@chromium.org Change-Id: I667c1f9a46409a427f7665a199e52dd879389b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525283 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640999} .../widget/desktop_aura/desktop_window_tree_host_x11_unittest.cc | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit 2d64b464b19d7678e3b0f60b59c11b936cd5cf33 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 14 23:53:45 2019 +0000 Fix FULL_SAFE_BROWSING typo TBR=vakh@chromium.org Bug: 928236 Change-Id: I0907d71ab816be59acf670c2f477b6d545c2b67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525014 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640998} chrome/browser/ui/webui/settings/md_settings_ui.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 82e8c07b1f829b666b7d1a5567b229c30b8c0d34 Author: Guohui Deng <guohuideng@chromium.org> Date: Thu Mar 14 23:52:17 2019 +0000 [chromecast ]Add ChannelLayout to chromecast::media::AudioConfig With ChannelLayout, IsValidConfig() can determine if the config is valid without the workaround. Bug: internal b/126765436 Merge-With: eureka-internal/249019 Test: mannually compile and cast. Change-Id: Ib96054cb2e83cfdb03898d90d5ac823ca917e540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500015 Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640997} .../audio_decoder_software_wrapper_unittest.cc | 1 + .../audio_video_pipeline_device_unittest.cc | 2 + .../cma/backend/multizone_backend_unittest.cc | 2 + .../media/cma/base/decoder_config_adapter.cc | 46 +++++++++++++++----- chromecast/public/media/decoder_config.h | 49 ++++++++++++++++++---- 5 files changed, 83 insertions(+), 17 deletions(-) commit 3ebc974328d269f701aebcf1f9f2686a798cc3d9 Author: Johannes Henkel <johannes@chromium.org> Date: Thu Mar 14 23:50:30 2019 +0000 Add virtual test suites for --enable-internal-devtools-binary-protocol. This flag is introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1507232 and it switches the wire encoding for devtools to a binary protocol within browser and renderer. Definining these two test suites gives us test coverage until we make this setting the default. Change-Id: I81b5dd2850e07a9e0fb57c6e03c45578f49a4a49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510117 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640996} third_party/blink/web_tests/ASANExpectations | 4 + .../FlagExpectations/disable-site-isolation-trials | 5 + third_party/blink/web_tests/LeakExpectations | 5 + third_party/blink/web_tests/MSANExpectations | 26 +++++ third_party/blink/web_tests/NeverFixTests | 1 + third_party/blink/web_tests/SlowTests | 62 ++++++++++++ third_party/blink/web_tests/TestExpectations | 110 +++++++++++++++++++++ third_party/blink/web_tests/VirtualTestSuites | 10 ++ .../http/tests/devtools/README.txt | 2 + .../http/tests/inspector-protocol/README.txt | 2 + 10 files changed, 227 insertions(+) commit 11783fa425781ee244415a5fcc431c0f0a239ee6 Author: Johannes Henkel <johannes@chromium.org> Date: Thu Mar 14 23:48:51 2019 +0000 Reland "Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession.""" This reverts commit fc637deb511059129c296585e4c96bf899752f1d. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession.""" > > This reverts commit 8f3ff47631cfdd7b80c37a859b68bb878c710fd8. > > Reason for revert: Depends on reverted change https://chromium-review.googlesource.com/c/chromium/src/+/1522494 > > Original change's description: > > Reland "Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession."" > > > > This is a reland of a741fa4abd37baa4d8618c27b5c8a3b5e0c53fcd > > > > Original change's description: > > > Reland "[DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession." > > > > > > This is a reland of 6ab258258c8ba0c7ebda22756062abc720859b6a > > > > > > Original change's description: > > > > [DevTools] Add a flag --enable-devtools-binary-protocol for DevToolsSession. > > > > > > > > When the flag is enabled, we send messages to agents / handlers as CBOR, > > > > even if the cient sends us JSON. We convert responses back to JSON if > > > > needed. > > > > > > > > Change-Id: I6123e38262d6eeb82206d28a936a32f7db8235b8 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507232 > > > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#638897} > > > > > > Change-Id: I20975e3119d3ac65a3e4294ea7cf0bf2d9516389 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512336 > > > Reviewed-by: Johannes Henkel <johannes@chromium.org> > > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#639164} > > > > Change-Id: I94019b6915a99e6b101892c5b3d451718250ba53 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521466 > > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > > Commit-Queue: Johannes Henkel <johannes@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#640487} > > TBR=dgozman@chromium.org,caseq@chromium.org,pfeldman@chromium.org,johannes@chromium.org > > Change-Id: Ie10a272952b579fd168d2bf54978c31c95c22837 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522496 > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Commit-Queue: Alice Boxhall <aboxhall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640618} TBR=dgozman@chromium.org,aboxhall@chromium.org,caseq@chromium.org,pfeldman@chromium.org,johannes@chromium.org Change-Id: Ia569dd8f17ab84bae00acb32ef3a0bf42ae80a7d No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525402 Reviewed-by: Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#640995} chrome/browser/devtools/chrome_devtools_session.cc | 16 +++- content/browser/BUILD.gn | 3 + content/browser/devtools/DEPS | 3 + .../devtools/browser_devtools_agent_host.cc | 2 +- content/browser/devtools/devtools_session.cc | 98 +++++++++++++++++----- content/browser/devtools/devtools_session.h | 5 ++ .../browser/devtools/devtools_session_encoding.cc | 94 +++++++++++++++++++++ .../browser/devtools/devtools_session_encoding.h | 29 +++++++ .../devtools/render_frame_devtools_agent_host.cc | 3 +- content/public/common/content_switches.cc | 6 ++ content/public/common/content_switches.h | 1 + 11 files changed, 236 insertions(+), 24 deletions(-) commit 0356e21b384c11ec5aea21f15d3ce568c1464de3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 23:42:08 2019 +0000 Roll src/third_party/angle 094c40dce601..2fb6563bf503 (4 commits) https://chromium.googlesource.com/angle/angle.git/+log/094c40dce601..2fb6563bf503 git log 094c40dce601..2fb6563bf503 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 syoussefi@chromium.org Vulkan: Fix CommandGraph barrier nodes w.r.t to first node 2019-03-14 syoussefi@chromium.org Vulkan: Fix copySubImage to non-cube-complete images. 2019-03-14 geofflang@chromium.org Mark RGB HALF_FLOAT_OES as renderable with EXT_color_buffer_half_float and WebGL 2019-03-14 raul@tambre.ee Support Python 3 in //scripts/file_exists.py Created with: gclient setdep -r src/third_party/angle@2fb6563bf503 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:941671,chromium:941669 TBR=geofflang@chromium.org Change-Id: I56d4b149923b55db9b8dc7cab4cc9cee67edaec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525141 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640994} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 769d61c7fb033bfcb1a9e68015d80d9cbf261ddb Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Mar 14 23:41:58 2019 +0000 flags: Update metadata for ChromeOS Launcher flags Removing enable-app-shortcut-search. Adding owners for enable-app-data-search and enable-play-store-search. Bug: None Change-Id: Ice0ca8ceadbacffcfc787903cfcfd356ff41775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524914 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#640993} chrome/browser/flag-metadata.json | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) commit 4680e2e63630a16d48c88c7e65e829ba851c1598 Author: dpapad <dpapad@chromium.org> Date: Thu Mar 14 23:40:14 2019 +0000 Grit: Don't attempt to inline srcset="$i18n{foo}" occurrences. This allows replacing the last i18n-values usage in plugin_poster.html (also done in this CL), which further unblocks the i18n-values to $i18n{} migration. Bug: 936220 Change-Id: Ib53347621854b69dd13331fcc81601cf0654b9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490404 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640992} .../renderer/resources/plugins/plugin_poster.html | 2 +- tools/grit/grit/format/html_inline.py | 2 +- tools/grit/grit/format/html_inline_unittest.py | 32 ++++++++++++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-) commit a2360ee97104be9c0b9eb65f5314bb6fff537704 Author: Brian Sheedy <bsheedy@chromium.org> Date: Thu Mar 14 23:39:41 2019 +0000 Add GPU FYI Pixel 2 builder + manual trybot Adds "Android FYI Release (Pixel 2)" to chromium.gpu.fyi to run the WebGL 2.0 conformance tests on Pixel 2s w/ P. Also adds a manual-only trybot equivalent of this to luci.chromium.try. Also drive-by fixes some "-vk" manual trybots' Milo names that got missed during the rename. Bug: 850257 Change-Id: I927543c56506a8fc0895db48ea161ade6018c3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517152 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#640991} infra/config/cr-buildbucket.cfg | 11 +++++++++++ infra/config/luci-milo.cfg | 25 ++++++++++++++++++------- infra/config/luci-scheduler.cfg | 11 +++++++++++ testing/buildbot/chromium.gpu.fyi.json | 32 ++++++++++++++++++++++++++++++++ testing/buildbot/test_suites.pyl | 18 ++++++++++++++++++ testing/buildbot/waterfalls.pyl | 15 +++++++++++++++ tools/mb/mb_config.pyl | 2 ++ 7 files changed, 107 insertions(+), 7 deletions(-) commit b523747b1eafcca8c3d9894bf7aa5c4e3e980246 Author: Xiaohui Chen <xiaohuic@google.com> Date: Thu Mar 14 23:38:32 2019 +0000 assistant: add launcher integration chrome://flags Bug: 942190 Test: locally build and run, see experiment in chrome://flags Change-Id: I7967e8ce60e12a02d1b7f73b6ff120febf2c0767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524905 Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#640990} chrome/browser/about_flags.cc | 7 +++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 14 ++++++++++---- chrome/browser/flag_descriptions.h | 9 ++++++--- tools/metrics/histograms/enums.xml | 2 ++ 5 files changed, 30 insertions(+), 7 deletions(-) commit 38b8fb8ddfcd480deed0ef3b823fb3321fa10720 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Thu Mar 14 23:37:02 2019 +0000 [layoutng] Remove some mac-specific expectation lines These tests all pass now R=ikilpatrick@chromium.org Change-Id: Ic35d9b6b64352abb5ec9ad5adff64a038d495f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524334 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640989} third_party/blink/web_tests/TestExpectations | 9 --------- 1 file changed, 9 deletions(-) commit 2a8190617a5f6f5db393be1e561c3f9b1589a05e Author: Pavel Feldman <pfeldman@chromium.org> Date: Thu Mar 14 23:31:46 2019 +0000 DevTools: remove Overlay.setSuspended protocol method, use enable/disable instead. Change-Id: Iab079eb08be6e47ac9bbdfd30ba72b3f94f320e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521791 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640988} .../renderer/core/inspector/browser_protocol.pdl | 5 - .../core/inspector/inspector_overlay_agent.cc | 42 ++------ .../core/inspector/inspector_overlay_agent.h | 3 - .../renderer/devtools/front_end/common/Settings.js | 3 +- .../devtools/front_end/emulation/DeviceModeView.js | 6 -- .../devtools/front_end/sdk/OverlayModel.js | 114 ++++++++++++--------- .../devtools/front_end/sdk/ScreenCaptureModel.js | 7 +- .../profiler/agents-disabled-check-expected.txt | 6 +- 8 files changed, 84 insertions(+), 102 deletions(-) commit 3e9d78c2a9b4d3e402c9bd9ff6086f4dfe09ed45 Author: Steven Bennetts <stevenjb@chromium.org> Date: Thu Mar 14 23:29:02 2019 +0000 Elim ash lock screen calls to SessionManagerClient Bug: 644350 Change-Id: I315e72637710b3bc8403edc8b742e49474a4fe65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521960 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640987} ash/DEPS | 2 -- ash/dbus/DEPS | 2 ++ ash/system/power/power_button_controller_unittest.cc | 7 +++---- ash/system/power/power_button_test_base.cc | 9 --------- ash/system/power/power_button_test_base.h | 7 ------- ash/wm/lock_state_controller.cc | 6 +----- ash/wm/lock_state_controller_unittest.cc | 19 +++++++++---------- 7 files changed, 15 insertions(+), 37 deletions(-) commit 6025f939957a9172fe65d9456b954abc9bd5fe85 Author: John Budorick <jbudorick@chromium.org> Date: Thu Mar 14 23:28:02 2019 +0000 Disable ArcPolicyBridgeAffiliatedTest. Bug: 941861 Change-Id: I3b203957e3e3e4939384b738c3a5ebf4cfe3d62c Tbr: bartfab@chromium.org,yoichio@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525058 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640986} chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 09b2d0e69effe8b2a37d7326468e191b356cb8be Author: Andrew Luo <aluo@chromium.org> Date: Thu Mar 14 23:24:11 2019 +0000 pass device and verbosity arguments correctly. The test runner shards tests across all devices that are specified. By default, all healthy, non-blacklisted devices will be used. Bug: 941589, 929892 Test: run_cts.py --verbose --device <serial 1> --device <serial 2> Change-Id: I551281018859e35fc551d21fe5f0589f3d8b2014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521295 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640985} android_webview/tools/run_cts.py | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) commit 64d2c34061c4bc2c74a9634d1c13d11325f49127 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Mar 14 23:22:16 2019 +0000 [Files app] Add drag'n'drop test and fix dragover error Fix error when hovering a dragged file on USB grouped root, which uses a EntryList which doesn't have volumeInfo. Add test for drag'n'drop from file list to directory tree and drag and hover for USB roots (grouped or not). Bug: 940416 Change-Id: Ia1d4abd97edefb22b13d135531d6bba7a0f784d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522489 Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#640984} .../file_manager/file_manager_browsertest.cc | 2 + .../background/js/runtime_loaded_test_util.js | 55 ++++++++++++++++ .../foreground/js/file_transfer_controller.js | 3 +- .../integration_tests/file_manager/transfer.js | 76 ++++++++++++++++++++++ 4 files changed, 135 insertions(+), 1 deletion(-) commit afea2d19da0b2ef9ad445e20b2ae8d0f0c97c14c Author: John Z Wu <jzw@chromium.org> Date: Thu Mar 14 23:21:17 2019 +0000 Fix shut down issues with //ios/web_view. 1. WebViewURLRequestContextGetter needs to call NotifyContextShuttingDown() as documented in URLRequestContextGetter. See: https://cs.chromium.org/chromium/src/net/url_request/url_request_context_getter.h?q=URLRequestContextGetter&sq=package:chromium&dr=CSs&l=69 2. WebViewBrowserStates should be shutdown before threads are destroyed. See: https://cs.chromium.org/chromium/src/ios/chrome/browser/application_context_impl.cc?sq=package:chromium&dr=CSs&q=application_context_impl.cc&g=0&l=142 Change-Id: I6057c7b505845b23ac203b799d932f2af7de8d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522471 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#640983} ios/web_view/internal/web_view_browser_state.mm | 5 +++++ ios/web_view/internal/web_view_url_request_context_getter.h | 7 +++++++ .../internal/web_view_url_request_context_getter.mm | 13 ++++++++++++- ios/web_view/internal/web_view_web_main_parts.mm | 5 ++++- 4 files changed, 28 insertions(+), 2 deletions(-) commit a075dbe3f854ee00416990e85760683bd97e65e1 Author: Mike Wasserman <msw@chromium.org> Date: Thu Mar 14 23:20:49 2019 +0000 Add extra browser window checks for shortcut crashes The cause of the crash is unclear, this may help with investigation. Bug: 937088 Change-Id: I60fff2732fd4393b932437ba5ca3207b58cc4813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524337 Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#640982} .../ui/ash/launcher/browser_shortcut_launcher_item_controller.cc | 4 ++++ 1 file changed, 4 insertions(+) commit f8ac476152d551bbe4134f14449ca9d9013bbe2a Author: Johannes Henkel <johannes@chromium.org> Date: Thu Mar 14 23:19:41 2019 +0000 [DevTools] Roll inspector_protocol to 1e65f2e3a9759b799ca3a87a41dcc9f58fdd720f. This is a reland, but I can't use the reland feature unfortunately. The revert PR was https://chromium-review.googlesource.com/c/chromium/src/+/1522494 This new roll lowers the stack limit for the json / cbor parser, so I'm hoping it will work on win-asan. I have no reasonable way to try this at the moment however. (1) Make a source_set in content/browser/devtools for the encoding_test, and add the test to content_unittest. This will ensure that further changes to our test won't break after the try-bots pass a submission to Chromium. I've broken the tree twice with that, previously. (2) third_party/inspector_protocol/BUILD.gn is now a different file than it is upstream. But the good news is it's really really simple. I've updated roll.py accordingly. Also: Change-Id: I935624d156b2ffc9df12fd5f1d745da8a10998c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524917 Reviewed-by: Victor Costan <pwnall@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#640981} content/browser/devtools/BUILD.gn | 13 + content/test/BUILD.gn | 1 + third_party/inspector_protocol/BUILD.gn | 108 +- third_party/inspector_protocol/DEPS | 4 +- third_party/inspector_protocol/README.chromium | 2 +- third_party/inspector_protocol/code_generator.py | 4 +- third_party/inspector_protocol/encoding/cbor.cc | 821 --------- third_party/inspector_protocol/encoding/cbor.h | 280 --- .../inspector_protocol/encoding/cbor_internals.h | 39 - .../inspector_protocol/encoding/encoding.cc | 1796 +++++++++++++++++++ third_party/inspector_protocol/encoding/encoding.h | 436 +++++ .../encoding/{cbor_test.cc => encoding_test.cc} | 951 ++++++++-- .../inspector_protocol/encoding/json_parser.cc | 588 ------- .../inspector_protocol/encoding/json_parser.h | 22 - .../encoding/json_parser_handler.h | 38 - .../encoding/json_parser_test.cc | 413 ----- .../encoding/json_std_string_writer.cc | 306 ---- .../encoding/json_std_string_writer.h | 25 - .../encoding/json_std_string_writer_test.cc | 162 -- .../encoding/linux_dev_platform.cc | 49 - .../encoding/linux_dev_platform.h | 17 - third_party/inspector_protocol/encoding/platform.h | 25 - third_party/inspector_protocol/encoding/span.h | 47 - .../inspector_protocol/encoding/span_test.cc | 57 - third_party/inspector_protocol/encoding/status.h | 61 - .../inspector_protocol/encoding/str_util.cc | 20 - third_party/inspector_protocol/encoding/str_util.h | 17 - .../inspector_protocol/inspector_protocol.gni | 4 +- .../inspector_protocol/inspector_protocol.gypi | 4 +- .../inspector_protocol/lib/CBOR_cpp.template | 828 --------- .../inspector_protocol/lib/Values_cpp.template | 114 +- .../lib/base_string_adapter_cc.template | 14 +- .../inspector_protocol/lib/encoding_cpp.template | 1807 ++++++++++++++++++++ .../lib/{CBOR_h.template => encoding_h.template} | 351 ++-- third_party/inspector_protocol/roll.py | 1 - 35 files changed, 5095 insertions(+), 4330 deletions(-) commit c1c44d25ce1370bae60df2c23a4c6027f2fd7b69 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 23:18:22 2019 +0000 Roll src/third_party/SPIRV-Tools/src bdcb155163d4..e545522146af (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/bdcb155163d4..e545522146af git log bdcb155163d4..e545522146af --date=short --no-merges --format='%ad %ae %s' 2019-03-14 zoddicus@users.noreply.github.com Add --strip-atomic-counter-memory (#2413) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e545522146af The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic238ec629f2c4e05677e7b54ae5705f1cee208f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524328 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640980} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 204a4deb68c99e3a571e1875f3b5418bbf383fa6 Author: Fabrice de Gans-Riberi <fdegans@chromium.org> Date: Thu Mar 14 23:14:52 2019 +0000 Revert "Roll Fuchsia SDK from ddcb12bc41ac to 1fdc2abd2818" This reverts commit ec3da85e11e147cf7b7285c0e5859bbe40cdbdf1. Reason for revert: Speculative revert following netstack issues. Bug: 942324 Original change's description: > Roll Fuchsia SDK from ddcb12bc41ac to 1fdc2abd2818 > > > The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+/master/autoroll/README.md > > If the roll is causing failures, please contact the current sheriff, who should > be CC'd on the roll, and stop the roller if necessary. > > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast > TBR=cr-fuchsia+bot@chromium.org > > Change-Id: Ie62d4cf99eaae566bc703347ed83e7807f4cc9d1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523065 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#640802} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,cr-fuchsia+bot@chromium.org Change-Id: I12b9f615fd3d626f72e0170f091a43c89b4c158a No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525287 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#640979} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit c728833110d8813d3fae09ee78632efcae1b3409 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 14 23:08:07 2019 +0000 Roll src-internal 36082da2f20c..b58fe2ab9436 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36082da2f20c..b58fe2ab9436 Created with: gclient setdep -r src-internal@b58fe2ab9436 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I16813b7736c66a446db13118187907f487ff10d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524329 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640978} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 022f9c0ca5d86deece03a93666712ff984aae0e9 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 14 23:04:54 2019 +0000 Migrate Menus to RepeatingCallback/BindRepeating BUG=714018,940130 Change-Id: I29462959936570c7fc9f723829ce4dfe98a03156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519120 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#640977} .../browser/ui/views/download/download_shelf_context_menu_view.cc | 4 ++-- .../browser/ui/views/extensions/media_galleries_dialog_views.cc | 4 ++-- chrome/browser/ui/views/frame/browser_frame.cc | 3 ++- chrome/browser/ui/views/toolbar/toolbar_action_view.cc | 4 ++-- ui/views/controls/combobox/combobox.cc | 8 ++++---- ui/views/controls/menu/menu_model_adapter.cc | 8 +++++--- ui/views/controls/menu/menu_model_adapter.h | 4 ++-- ui/views/controls/menu/menu_runner.cc | 2 +- ui/views/controls/menu/menu_runner.h | 3 ++- ui/views/controls/menu/menu_runner_cocoa_unittest.mm | 6 +++--- ui/views/controls/menu/menu_runner_impl.cc | 2 +- ui/views/controls/menu/menu_runner_impl_adapter.cc | 2 +- ui/views/controls/menu/menu_runner_impl_adapter.h | 2 +- ui/views/controls/menu/menu_runner_impl_cocoa.h | 4 ++-- ui/views/controls/menu/menu_runner_impl_cocoa.mm | 4 ++-- ui/views/controls/menu/menu_runner_impl_interface.h | 2 +- 16 files changed, 33 insertions(+), 29 deletions(-) commit 4d04f34d13c5b1f475daf52cc9486e578c13bd3b Author: khmel@chromium.org <khmel@chromium.org> Date: Thu Mar 14 23:03:42 2019 +0000 arc: Various fixes for the graphics tracing tool It includes: Insensitivity to tracing hierarchy change in Chrome. Hierarchy of required events is determined dynamically. Handling combination of possible end of event sequences due to different render methods in Chrome. Extra space to separate different buffers in Android. BUG=b:122555793 TEST=Locally + unit tests Change-Id: I858c6f24fcb56afdeeeefccb49e56ed1492eddc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521817 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640976} .../arc/tracing/arc_tracing_event_matcher.cc | 2 +- .../arc/tracing/arc_tracing_graphics_model.cc | 124 +++++++++++++------ .../arc/tracing/arc_tracing_graphics_model.h | 13 +- .../arc/tracing/arc_tracing_model_unittest.cc | 21 +++- .../arc_graphics_tracing/arc_graphics_tracing.css | 5 + .../arc_graphics_tracing_ui.js | 132 +++++++++++++++------ 6 files changed, 219 insertions(+), 78 deletions(-) commit 1389ea83805e70f6587619ee38b7833bfa698231 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 23:02:38 2019 +0000 Roll src/third_party/swiftshader af973b67141e..a2749f39f47d (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/af973b67141e..a2749f39f47d git log af973b67141e..a2749f39f47d --date=short --no-merges --format='%ad %ae %s' 2019-03-14 bclayton@google.com SpirvShader: Fix for integer overflow in SDiv and SMod. Created with: gclient setdep -r src/third_party/swiftshader@a2749f39f47d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128614198 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ib81d9e0563f87d75790cf6a22792151a78262bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524961 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640975} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ff7f45c5f3f2f49bfabd3a71f7c223f10d80944c Author: Vladislav Kaznacheev <kaznacheev@google.com> Date: Thu Mar 14 23:02:16 2019 +0000 Remove kEnableAppShortcutSearch feature switch and related flag The feature has successfully launched in M72 and the flag is no longer needed. Bug: 942186 Test: flag not in chrome://flags, app shortcuts search still works. Change-Id: Ibcb0aa9f50ddee55c37f88cf3756d5f1615062c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524906 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#640974} ash/app_list/views/search_result_tile_item_view.cc | 1 - ash/public/cpp/app_list/app_list_features.cc | 6 ------ ash/public/cpp/app_list/app_list_features.h | 4 ---- chrome/browser/about_flags.cc | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- chrome/browser/ui/app_list/search/search_controller_factory.cc | 3 +-- 7 files changed, 1 insertion(+), 26 deletions(-) commit f71404e8d5d8b198b599b9d8cadce312d2675f15 Author: Srikanth Gatta <srikanthg@chromium.org> Date: Thu Mar 14 23:01:32 2019 +0000 Add language selection to Experimental Settings Bundle. Demo: https://drive.google.com/file/d/1Y4fG9ZVth9jfxgt-LG5KX2JkLt7Lamge/view Bug: 934940 Change-Id: I76ad66247bd77221bd4d53ceee119fb978bb3bad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506131 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Srikanth Gatta <srikanthg@chromium.org> Cr-Commit-Position: refs/heads/master@{#640973} ios/chrome/app/chrome_exe_main.mm | 15 ++++++++++++ .../resources/Settings.bundle/Experimental.plist | 28 ++++++++++++++++++++++ 2 files changed, 43 insertions(+) commit 505b27211af994704eb24c6ada149607257fbd43 Author: Dana Fried <dfried@chromium.org> Date: Thu Mar 14 23:01:11 2019 +0000 Add dfried to thumbnailing code owners. Bug: 928954 Change-Id: Ib44c943364cd75096d542ba9596eed37eb13f0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518243 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#640972} chrome/browser/ui/thumbnails/OWNERS | 1 + 1 file changed, 1 insertion(+) commit dd6e15f795dea488a8b7fca2eacde6cec132e075 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:57:45 2019 +0000 Roll src/third_party/depot_tools 40c19421b4ba..1c2fa0fdda12 (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/40c19421b4ba..1c2fa0fdda12 git log 40c19421b4ba..1c2fa0fdda12 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@1c2fa0fdda12 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5dd0fbd136574e708aeb35c996c529fa2a5eb43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524326 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640971} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 595990e1e5904c4aba4a6c253264e09fe51f232a Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 14 22:57:30 2019 +0000 Import wpt@1b8bf0be8de51658e7e71f7a65abe561b8fc9930 Using wpt-import in Chromium 80945e90d44d18faa444e5c1516a34e8cebca44b. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bajones@chromium.org: external/wpt/gamepad bjonesbe@adobe.com: external/wpt/css/css-shapes cbiesinger@chromium.org: external/wpt/css/css-flexbox domenic@chromium.org, ricea@chromium.org: external/wpt/streams fmeawad@chromium.org, panicker@chromium.org: external/wpt/device-memory guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc jochen@chromium.org, estark@chromium.org: external/wpt/referrer-policy jrummell@chromium.org: external/wpt/encrypted-media jsbell@chromium.org, mek@chromium.org: external/wpt/webstorage kojii@chromium.org: external/wpt/css/css-writing-modes kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 ksakamoto@chromium.org: external/wpt/resource-timing mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org: external/wpt/cookies mkwst@chromium.org, jochen@chromium.org: external/wpt/subresource-integrity mlamouri@chromium.org: external/wpt/screen-orientation nzolghadr@chromium.org, mustaq@chromium.org: external/wpt/pointerevents panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing raphael.kubo.da.costa@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor rego@igalia.com: external/wpt/css/css-grid external/wpt/css/css-ui external/wpt/css/selectors rijubrata.bhaumik@intel.com, mcasas@chromium.org: external/wpt/html-media-capture rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-id external/wpt/payment-request smcgruer@chromium.org: external/wpt/css/css-position tdresser@chromium.org: external/wpt/navigation-timing timvolodine@chromium.org: external/wpt/battery-status NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I07e6cc2c80a3342231984dbab9f6c481b1856cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524419 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640970} third_party/blink/web_tests/TestExpectations | 6 + .../web_tests/external/WPT_BASE_MANIFEST_5.json | 1087 ++++++++++++++++---- .../web_tests/external/wpt/2dcontext/META.yml | 1 - .../blink/web_tests/external/wpt/WebIDL/META.yml | 1 - .../web_tests/external/wpt/accelerometer/META.yml | 1 - .../web_tests/external/wpt/ambient-light/META.yml | 1 - .../web_tests/external/wpt/battery-status/META.yml | 1 - .../web_tests/external/wpt/bluetooth/META.yml | 1 - .../blink/web_tests/external/wpt/common/META.yml | 1 - .../blink/web_tests/external/wpt/cookies/META.yml | 1 - .../blink/web_tests/external/wpt/css/CSS2/META.yml | 1 - .../external/wpt/css/css-backgrounds/META.yml | 2 - .../web_tests/external/wpt/css/css-color/META.yml | 1 - .../external/wpt/css/css-flexbox/META.yml | 1 - .../web_tests/external/wpt/css/css-grid/META.yml | 2 - ...em-overflow-auto-max-height-percentage-ref.html | 62 ++ ...d-item-overflow-auto-max-height-percentage.html | 69 ++ .../grid-item-percentage-sizes-001-ref.html | 312 ++++++ .../grid-items/grid-item-percentage-sizes-001.html | 318 ++++++ .../grid-item-percentage-sizes-002-ref.html | 312 ++++++ .../grid-items/grid-item-percentage-sizes-002.html | 318 ++++++ .../grid-item-percentage-sizes-003-ref.html | 316 ++++++ .../grid-items/grid-item-percentage-sizes-003.html | 318 ++++++ .../external/wpt/css/css-logical/META.yml | 1 - .../external/wpt/css/css-position/META.yml | 2 +- .../external/wpt/css/css-scrollbars/META.yml | 2 +- .../web_tests/external/wpt/css/css-shapes/META.yml | 2 - .../range-percent-intrinsic-size-2-ref.html | 20 +- .../range-percent-intrinsic-size-2a-ref.html | 5 +- .../external/wpt/css/css-style-attr/META.yml | 1 - .../web_tests/external/wpt/css/css-syntax/META.yml | 1 - .../web_tests/external/wpt/css/css-text/META.yml | 1 - .../external/wpt/css/css-transforms/META.yml | 1 - .../css-transforms/transform-flattening-001.html | 10 + .../web_tests/external/wpt/css/css-ui/META.yml | 1 - .../external/wpt/css/css-writing-modes/META.yml | 1 - .../web_tests/external/wpt/css/selectors/META.yml | 1 - .../web_tests/external/wpt/device-memory/META.yml | 1 - .../external/wpt/encrypted-media/META.yml | 5 +- .../web_tests/external/wpt/event-timing/META.yml | 1 - .../web_tests/external/wpt/feature-policy/META.yml | 2 +- .../blink/web_tests/external/wpt/gamepad/META.yml | 2 +- .../web_tests/external/wpt/generic-sensor/META.yml | 1 - .../web_tests/external/wpt/gyroscope/META.yml | 1 - .../external/wpt/html-media-capture/META.yml | 1 - .../the-window-object/document-attribute.window.js | 15 + .../the-window-object/self-et-al.window.js | 43 + .../wpt/imagebitmap-renderingcontext/META.yml | 1 - .../blink/web_tests/external/wpt/lint.whitelist | 2 + .../web_tests/external/wpt/magnetometer/META.yml | 1 - .../fractions/frac-linethickness-001-ref.html | 25 +- .../fractions/frac-linethickness-001.html | 19 +- .../external/wpt/mediacapture-depth/META.yml | 1 - .../external/wpt/mediacapture-streams/META.yml | 2 - ...test_redirect_chain_xserver_partial_opt_in.html | 58 ++ ...cross_origin_redirect_chain_partial_opt_in.html | 61 ++ ...adEvents_with_cross_origin_redirect_opt_in.html | 57 + .../web_tests/external/wpt/notifications/META.yml | 1 - .../external/wpt/offscreen-canvas/META.yml | 1 - .../external/wpt/orientation-sensor/META.yml | 1 - .../web_tests/external/wpt/paint-timing/META.yml | 1 - .../external/wpt/payment-method-id/META.yml | 1 - .../attributes-and-toJSON-method-manual.https.html | 1 + ...onpayerdetailchange-attribute-manual.https.html | 11 +- .../show-method-postmessage-manual.https.html | 37 - .../web_tests/external/wpt/pointerevents/META.yml | 2 - .../external/wpt/referrer-policy/META.yml | 2 - .../external/wpt/resource-timing/META.yml | 1 - .../resource-timing/TAO-crossorigin-port.sub.html | 25 + .../nested-context-navigations.html | 31 + .../wpt/resource-timing/resources/TAOResponse.py | 6 + .../resources/document-navigated.html | 12 + .../resources/document-refreshed.html | 12 + .../resources/document-that-navigates.html | 11 + .../resources/document-that-refreshes.html | 8 + .../resources/embed-navigate-back.html | 14 + .../resource-timing/resources/embed-navigate.html | 15 + .../resource-timing/resources/embed-refresh.html | 15 + .../resources/iframe-TAO-crossorigin-port.sub.html | 31 + .../resources/iframe-navigate-back.html | 14 + .../resource-timing/resources/iframe-navigate.html | 15 + .../resource-timing/resources/iframe-refresh.html | 15 + .../resource-timing/resources/navigate_back.html | 7 + .../resource-timing/resources/nested-contexts.js | 95 ++ .../resources/object-navigate-back.html | 14 + .../resource-timing/resources/object-navigate.html | 15 + .../resource-timing/resources/object-refresh.html | 15 + .../external/wpt/screen-orientation/META.yml | 1 - .../lock-unlock-check-expected.txt | 4 + .../wpt/screen-orientation/lock-unlock-check.html | 26 + .../resources/orientation-utils.js | 17 + .../external/wpt/scroll-animations/META.yml | 1 - .../wpt/selection/Document-open-expected.txt | 4 + .../external/wpt/selection/Document-open.html | 48 +- .../web_tests/external/wpt/speech-api/META.yml | 1 - .../blink/web_tests/external/wpt/streams/META.yml | 1 - .../external/wpt/subresource-integrity/META.yml | 1 - .../blink/web_tests/external/wpt/svg/META.yml | 1 - .../external/wpt/tools/ci/azure/affected_tests.yml | 2 +- .../external/wpt/tools/ci/taskcluster-run.py | 9 + .../external/wpt/tools/manifest/manifest.py | 3 +- .../blink/web_tests/external/wpt/tools/wpt/run.py | 2 - .../web_tests/external/wpt/tools/wpt/virtualenv.py | 35 + .../external/wpt/tools/wptrunner/requirements.txt | 2 +- .../wpt/tools/wptrunner/requirements_firefox.txt | 2 +- .../blink/web_tests/external/wpt/url/META.yml | 1 - .../web_tests/external/wpt/vibration/META.yml | 1 - .../web_tests/external/wpt/wake-lock/META.yml | 1 - .../web_tests/external/wpt/webmessaging/META.yml | 1 - .../blink/web_tests/external/wpt/webrtc/META.yml | 2 - .../webrtc/RTCPeerConnection-getStats.https.html | 47 +- ...PeerConnection-onnegotiationneeded-expected.txt | 2 +- .../RTCPeerConnection-onnegotiationneeded.html | 23 +- .../RTCPeerConnection-setLocalDescription.html | 64 +- .../RTCPeerConnection-transceivers.https.html | 10 +- .../web_tests/external/wpt/webstorage/META.yml | 1 - .../blink/web_tests/external/wpt/webxr/META.yml | 2 - .../blink/web_tests/external/wpt/xhr/META.yml | 3 - .../nested-context-navigations-expected.txt | 21 + .../nested-context-navigations-expected.txt | 21 + .../nested-context-navigations-expected.txt | 21 + .../nested-context-navigations-expected.txt | 21 + .../nested-context-navigations-expected.txt | 21 + ...PeerConnection-onnegotiationneeded-expected.txt | 2 +- ...CPeerConnection-transceivers.https-expected.txt | 2 +- 125 files changed, 3919 insertions(+), 418 deletions(-) commit 50ab190c6ad00809ed49b886baf7307f178f46c4 Author: Austin Eng <enga@chromium.org> Date: Thu Mar 14 22:56:16 2019 +0000 Move WebGPU context creation from GPUDevice to NavigatorGPU nagivator.gpu should hold the WebGPU context. The context needs to be initialized before any GPUAdapters or GPUDevices are created. Bug: 941531 Change-Id: Ie70416a59c09b49fe799365e2c17a7616cbb0609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521234 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#640969} third_party/blink/renderer/modules/webgpu/gpu.cc | 48 ++++++++++++++++++++-- third_party/blink/renderer/modules/webgpu/gpu.h | 22 ++++++++-- .../blink/renderer/modules/webgpu/gpu_adapter.cc | 4 +- .../blink/renderer/modules/webgpu/gpu_adapter.h | 2 +- .../blink/renderer/modules/webgpu/gpu_adapter.idl | 2 +- .../blink/renderer/modules/webgpu/gpu_device.cc | 37 ++--------------- .../blink/renderer/modules/webgpu/gpu_device.h | 9 +--- .../blink/renderer/modules/webgpu/navigator_gpu.cc | 11 +++-- .../blink/renderer/modules/webgpu/navigator_gpu.h | 4 +- .../renderer/modules/webgpu/navigator_gpu.idl | 2 +- 10 files changed, 82 insertions(+), 59 deletions(-) commit 2733a02cc27e44bac55b86b928e1076b660b6908 Author: Marco Paniconi <marpan@google.com> Date: Thu Mar 14 22:56:03 2019 +0000 Roll src/third_party/libvpx/source/libvpx/ 8256c8b29..1533bd84f (19 commits) https://chromium.googlesource.com/webm/libvpx.git/+log/8256c8b297c8..1533bd84f12e $ git log 8256c8b29..1533bd84f --date=short --no-merges --format='%ad %ae %s' 2019-03-13 marpan vp9-rtc: Avoid TM intra on big blocks for screen 2019-03-13 jingning Safe guard zero median filter outcome case 2019-03-13 jianj vp9 simulcast: update buffer slot flag used in API. 2019-03-13 jingning Refactor speed feature settings 2019-03-05 jingning Adaptive multiplier based on the Wiener variance 2019-03-05 jingning Add normalization over frame level Wiener variance 2019-03-05 jingning Set up Wiener variance for macroblocks in a frame 2019-03-12 chiyotsai Remove highbd_temporal_filter_sse4.c when REAL_TIME_ONLY is on 2019-03-11 jianj vp9-decoder: use long int for buffer offset. 2019-03-08 marpan vp9-screen: Rework the mode skip logic for screen 2019-03-08 marpan vp9-screen: Fix to screen wth layered encoding 2019-03-04 chiyotsai Optimize SSE4_1 lowbd temporal filter implementation 2019-03-04 jianj vp9 svc: add simulcast mode when inter-layer pred is off. 2019-03-07 marpan vp9-svc: Fix to sample encoder for 1 layer 2019-03-05 angiebird Include mv_mode_arr info in dump_tpl_stats 2019-03-01 jianj vp9: map speed > 9 to speed 9. 2019-03-05 angiebird Include gf_frame_offset in dump_tpl_stats 2019-03-05 angiebird Refactor dump_tpl_stats 2019-02-28 chiyotsai Add SSE4_1 highbd version of temporal filter Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: Id706f8b51d44b50e99431e57e123c843a0bbdb4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524090 Reviewed-by: Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Marco Paniconi <marpan@google.com> Cr-Commit-Position: refs/heads/master@{#640968} DEPS | 2 +- third_party/libvpx/README.chromium | 4 +-- third_party/libvpx/libvpx_srcs.gni | 35 +++++++++----------------- third_party/libvpx/source/config/vpx_version.h | 6 ++--- 4 files changed, 18 insertions(+), 29 deletions(-) commit 14503350bba4af0193653c5534a923e4632820be Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:54:15 2019 +0000 Roll src/third_party/skia a4323d71424f..f4438d56e989 (7 commits) https://skia.googlesource.com/skia.git/+log/a4323d71424f..f4438d56e989 git log a4323d71424f..f4438d56e989 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 mtklein@google.com skvx: allow more implicit conversions 2019-03-14 michaelludwig@google.com Avoid unsafe casts to int in SkNx 2019-03-14 mtklein@google.com update docs for SkLumaColorFilter 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 ethannicholas@google.com re-re-fixed RelaxedPrecision 2019-03-14 robertphillips@google.com Allocate the backing SkBitmap in the SerializedImageFilter fuzzer 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f4438d56e989 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Id0a04e3a9b027082dbc54f9c7d396d87d630bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524376 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640967} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 713b777746f6192e81aa0d06a910d9dbd829b585 Author: Sergey Ulanov <sergeyu@google.com> Date: Thu Mar 14 22:53:32 2019 +0000 [Fuchsia] Replace GetHandleFromFile() with OpenDirectory() GetHandleFromFile() was used only to open directories. Replaced it with OpenDirectory() which: 1. Open the specified path instead of taking base::File. All GetHandleFromFile were already calling base::File() anyway. 2. Returns InterfaceHandle<fuchsia::io::Directory> which is more type-safe. This is a reland of https://crbug.com/640675 Change-Id: I5c6962acc64d285f600d273316839552e08d4cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524864 Reviewed-by: Wez <wez@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640966} base/BUILD.gn | 1 + base/fuchsia/file_utils.cc | 42 ++++++++++++---------- base/fuchsia/file_utils.h | 18 ++++------ base/fuchsia/file_utils_unittest.cc | 44 ++++++++++++++++++++++++ base/fuchsia/service_directory_client.cc | 12 ++----- base/process/launch_fuchsia.cc | 9 ++--- base/process/process_util_unittest.cc | 21 +++++------ base/test/launcher/test_launcher.cc | 13 +++---- fuchsia/engine/context_provider_impl_unittest.cc | 15 ++------ fuchsia/runners/common/web_content_runner.cc | 14 ++++---- 10 files changed, 106 insertions(+), 83 deletions(-) commit a8b17b5c87141d3d438822c754c4352765c75d76 Author: Rick James <rickj@microsoft.com> Date: Thu Mar 14 22:49:55 2019 +0000 Add a bounds check for rtree_ rects access in tracing Bug: 941199 Change-Id: I455a98ec6a1f2b19dabb909e2ed422e8dc93aa74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522339 Commit-Queue: vmpstr <vmpstr@chromium.org> Auto-Submit: Rick James MSFT <rickj@microsoft.com> Reviewed-by: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640965} cc/paint/display_item_list.cc | 5 ++++- cc/paint/display_item_list.h | 1 + cc/paint/display_item_list_unittest.cc | 25 +++++++++++++++++++++++++ 3 files changed, 30 insertions(+), 1 deletion(-) commit 4598b59aac9ba57547b06df3350e9462a69cf169 Author: Dan Beam <dbeam@chromium.org> Date: Thu Mar 14 22:48:35 2019 +0000 WebUI Dark Mode: add 1px white border to bottom of toolbars R=dpapad@chromium.org BUG=939270 Change-Id: Ibe12a10f04e29f83b354cf820af8b4d12b568602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524865 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#640964} chrome/browser/resources/app_management/app.html | 5 ----- chrome/browser/resources/app_management/shared_vars.html | 1 - chrome/browser/resources/bookmarks/bookmarks.html | 9 +++++++-- chrome/browser/resources/bookmarks/toolbar.html | 1 - chrome/browser/resources/downloads/downloads.html | 9 +++++++-- chrome/browser/resources/downloads/toolbar.html | 1 - chrome/browser/resources/history/app.html | 4 ---- chrome/browser/resources/history/history.html | 4 +++- chrome/browser/resources/management/management.html | 10 +++++++--- chrome/browser/resources/management/management_ui.html | 1 - chrome/browser/resources/md_extensions/extensions.html | 6 +++--- chrome/browser/resources/md_extensions/toolbar.html | 11 ----------- chrome/browser/resources/settings/settings.html | 9 +++++++-- .../browser/resources/settings/settings_ui/settings_ui.html | 1 - ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html | 5 ++++- ui/webui/resources/css/md_colors.css | 3 +++ 16 files changed, 41 insertions(+), 39 deletions(-) commit 889a9665145519f88a755826e6c4a3c15f8fda7a Author: Nico Weber <thakis@chromium.org> Date: Thu Mar 14 22:45:07 2019 +0000 Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. Removes some special-case code and potentially makes debug info a bit smaller. Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case on linux -- this helps with build determinism. Bug: 942155,899438,906741,429358 Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#640963} build/config/compiler/BUILD.gn | 67 +++++++++++++++++++++--------------------- 1 file changed, 33 insertions(+), 34 deletions(-) commit 6001a8212fe59772d66641e345709b13c461f3e5 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Mar 14 22:43:34 2019 +0000 Revert "[BGPT] Let cc initialize animation states in property nodes" This reverts commit 54b17c7e812cd7c961abb45b4f8bcc7e2b1bbe43. Reason for revert: caused flakiness of virtual/threaded/animations/hit-testing/composited-with-hit-testing.html Original change's description: > [BGPT] Let cc initialize animation states in property nodes > > In this way, blink::PropertyTreeManager no longer needs to care about > the animation states. Now we initialize and change the states from a > single source to avoid duplicate code and inconsistency. > > Bug: 935770 > Change-Id: I7f98d66677f557213fd4559895e9c2069de196e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513922 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640892} TBR=flackr@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ic050f559601864d7654c5fe6a3e3656293361e04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525266 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640962} cc/animation/animation_host.cc | 5 - cc/animation/animation_host.h | 2 - cc/animation/element_animations.cc | 8 - cc/animation/element_animations.h | 7 - cc/trees/mutator_host.h | 2 - .../core/animation/compositor_animations.h | 12 ++ .../core/animation/compositor_animations_test.cc | 214 ++++++++------------- .../renderer/core/paint/link_highlight_impl.cc | 8 +- .../compositing/paint_artifact_compositor.cc | 5 - .../compositing/paint_artifact_compositor_test.cc | 30 +-- .../graphics/compositing/property_tree_manager.cc | 16 ++ 11 files changed, 133 insertions(+), 176 deletions(-) commit 2b670361e250c8ba7f0128c9339646ed5e5c5c2d Author: Daniel Murphy <dmurph@chromium.org> Date: Thu Mar 14 22:42:48 2019 +0000 [IndexedDB] Fixed blobs being saved on disk during incognito mode R=cmp@chromium.org Bug: 941965 Change-Id: I37fec1b2c90c7e3bd2b6c20115e307b2f4efebf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524097 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#640961} .../browser/indexed_db/indexed_db_backing_store.h | 3 +- .../browser/indexed_db/indexed_db_browsertest.cc | 21 ++++++- .../browser/indexed_db/indexed_db_factory_impl.cc | 11 +++- .../indexed_db/indexed_db_factory_unittest.cc | 14 +++++ content/test/data/indexeddb/simple_blob_read.html | 10 ++++ content/test/data/indexeddb/simple_blob_read.js | 68 ++++++++++++++++++++++ 6 files changed, 122 insertions(+), 5 deletions(-) commit bf34b7945336f640eb43fffe49e420285385dcbb Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Thu Mar 14 22:41:36 2019 +0000 Fix arguments for running benchmarks on mobile devices R=perezju@chromium.org Bug: 895891 Change-Id: I888566b25de62ee4976592e1cd0663b0a6357c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520678 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#640960} tools/perf/cli_tools/update_wpr/update_wpr.py | 87 +++++++++++----------- .../cli_tools/update_wpr/update_wpr_unittest.py | 10 +-- 2 files changed, 49 insertions(+), 48 deletions(-) commit 87e19e4ee1f2be73a317bba82c61e87da5bf1935 Author: Sinan Sahin <sinansahin@google.com> Date: Thu Mar 14 22:37:15 2019 +0000 Changing the styles and colors of the bookmark widget Bug: 939149 Change-Id: I22f960d7ef2545d1560abc535308edec2ba40960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524098 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640959} chrome/android/java/res/layout/bookmark_widget.xml | 2 +- chrome/android/java/res/layout/bookmark_widget_item.xml | 3 +-- chrome/android/java/res/values-v17/styles.xml | 4 ++++ chrome/android/java/res/values/colors.xml | 1 + .../chrome/browser/bookmarkswidget/BookmarkWidgetService.java | 2 +- ui/android/java/res/values/color_palette.xml | 2 ++ ui/android/java/res/values/colors.xml | 2 +- 7 files changed, 11 insertions(+), 5 deletions(-) commit aae80a81fafee6883a5cfb59a94bdc1eb438129b Author: wutao <wutao@chromium.org> Date: Thu Mar 14 22:30:06 2019 +0000 app_list: Bring back G icon Per UX request, we bring back the G icon in the search box. Bug: 924624, 940812 Test: manual Change-Id: Ib54e15ca391ef0afb75dff8963d923b52ff1096c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518716 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640958} ash/app_list/views/search_box_view.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 6384e45a73991700fb926b64459ec9c6cf5679ea Author: Avi Drissman <avi@chromium.org> Date: Thu Mar 14 22:27:14 2019 +0000 Simplify obtaining a result from JavaScript execution. BUG=646113 TEST=no changes Change-Id: I04c1ec3049b25236611ad072af3f9eff2b858984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524652 Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640957} chrome/browser/ui/browser_browsertest.cc | 34 ++++++++++---------------------- 1 file changed, 10 insertions(+), 24 deletions(-) commit 3f740bb0338e9d23d53de9e8cc1a3f8b993546bd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:26:14 2019 +0000 Roll src/third_party/perfetto 29885798ac66..8320e6d2b742 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/29885798ac66..8320e6d2b742 git log 29885798ac66..8320e6d2b742 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 lalitm@google.com trace_processor: split up counters table Created with: gclient setdep -r src/third_party/perfetto@8320e6d2b742 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:124495829 TBR=perfetto-bugs@google.com Change-Id: I34fa771d0630cbf22e692543525aee4f7803c1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524327 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640956} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c86a43558b41dfeb5f9c33a7ee25f17a69cab8c7 Author: Xiaohui Chen <xiaohuic@google.com> Date: Thu Mar 14 22:20:40 2019 +0000 assistant: enable audio eraser Enable audio eraser in libassistant. Tweaked the input sampling format to better match audio eraser requirement. Bug: b:79496686 Test: locally build and run with background audio Change-Id: Ia39b63889b3085e35a2662c7ef50c99ad8f1d916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521957 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#640955} .../assistant/platform/audio_input_impl.cc | 28 +++++++++-------- .../services/assistant/platform/audio_input_impl.h | 2 +- .../platform/audio_input_provider_impl.cc | 6 +++- .../platform/audio_output_provider_impl.cc | 9 ++++-- .../platform/audio_output_provider_impl.h | 2 ++ chromeos/services/assistant/public/features.cc | 35 ++++++++++++++-------- chromeos/services/assistant/public/features.h | 17 +++++++---- chromeos/services/assistant/utils.cc | 10 +++++++ 8 files changed, 73 insertions(+), 36 deletions(-) commit 1d16787c12b00a3eda52d60f7dba3dc609ae45ef Author: Toni Barzic <tbarzic@chromium.org> Date: Thu Mar 14 22:18:26 2019 +0000 Remove some unneded code from wizard_controller Removes some screen exit handler methods from the header - the implementations are already gone, but these were left by mistake (during rebasing wip cls). Removes ShowPreviousScreen - not used anymore. Removes VLOG(1) and UpdateStatusAreaVisibility from Show*Screen methods. ShowCurrentScreenSmooth, which is called for all of these methods already logs the screen that is being shown, and updates the status area visibilty. BUG=None Change-Id: If547b33fc68656e1eda7db8bc9d5128ad26de750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524658 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#640954} chrome/browser/chromeos/login/wizard_controller.cc | 59 ---------------------- chrome/browser/chromeos/login/wizard_controller.h | 11 ---- 2 files changed, 70 deletions(-) commit 9408d220a11fb53f133d2cc018678646fd54c118 Author: Yan, Shaobo <shaobo.yan@intel.com> Date: Thu Mar 14 22:17:34 2019 +0000 Skip WebGL CTS test cases "biuDepthRange_001_to_002.html" and "no-over-optimization-on-uniform-array-09.html" on Intel Platform This is an OpenGL driver bug on Intel platform and it is fixed in Intel Driver 25.20.100.6444. Case no-over-optimization-on-uniform-array-09 always fail if run case biuDepthRange_001_to_002 first. Temporarily skip these two cases now because this issue blocks WEBGL_video_texture implementation. BUG=907195 Change-Id: I0698603337c0ff9b2d719cbf5aaf635dd72f9abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512767 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640953} .../test/gpu/gpu_tests/webgl2_conformance_expectations.py | 13 +++++++++++++ .../test/gpu/gpu_tests/webgl_conformance_expectations.py | 13 +++++++++++++ 2 files changed, 26 insertions(+) commit 630a8832e28ed4676c3a3564b5ca954b293fedd4 Author: ZhengkunLi <zhengkli@amazon.com> Date: Thu Mar 14 22:16:20 2019 +0000 Clean up KeyboardVisibilityListener on InfobarContainer destruction A bug was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1346129 which caused InfobarContainer objects to be leaked after associated tab is closed. This patch adds code to remove the listener upon destroying InfobarContainer objects. R=fhorschig@chromium.org, mdjones@chromium.org Bug: 940073 Change-Id: Idf9f765a191a99a574aca25259f4f50e1ff1318e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516783 Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#640952} AUTHORS | 1 + .../chromium/chrome/browser/infobar/InfoBarContainer.java | 14 ++++++++++---- 2 files changed, 11 insertions(+), 4 deletions(-) commit 6b1606cdc4dbf926c205bb6664c9e326c91437ef Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Mar 14 22:15:18 2019 +0000 [Extensions Bindings] Remove TestConfig.nativeCrxBindingsEnabled Remove nativeCrxBindingsEnabled from the TestConfig object in the chrome.test extension API. Since native bindings are now always enabled, we don't need this boolean. Update JS files that were using it. Bug: 938998, 792602 Change-Id: Ica1e78b4c7a2e86258977e9c7939181ff3a8cec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518147 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640951} chrome/browser/extensions/extension_apitest.cc | 3 -- .../api_test/activity_log_private/test/test.js | 47 ++-------------------- .../bindings/invalidate_context/background.js | 16 +------- .../extensions/api_test/messaging/connect/page.js | 24 ----------- .../extensions/api_test/messaging/connect/test.js | 32 ++------------- extensions/common/api/test.json | 5 --- 6 files changed, 9 insertions(+), 118 deletions(-) commit 0a59002c267af015a2162d31f9450fb28c00f1b6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:14:44 2019 +0000 Roll src/third_party/catapult 44a43fd4ffa9..f8e231582d6a (1 commits) https://chromium.googlesource.com/catapult.git/+log/44a43fd4ffa9..f8e231582d6a git log 44a43fd4ffa9..f8e231582d6a --date=short --no-merges --format='%ad %ae %s' 2019-03-14 benjhayden@chromium.org Add chart-section to chromeperf-app Created with: gclient setdep -r src/third_party/catapult@f8e231582d6a The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:918193 TBR=sullivan@chromium.org Change-Id: Ic03b3ae769188a0d223487aa6186ea9fbc25fd3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524377 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640950} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5003308957c3369314cca767781265de87603aab Author: Jamie Walch <jamiewalch@chromium.org> Date: Thu Mar 14 22:13:50 2019 +0000 Fix remoting perf tests. These tests had not been run in some time and there were a few crashes: * ScopedTaskEnvironment is now preferred, and there's a DCHECK to ensure that any TaskScheduler created in a test is cleaned up after it exits. * A NetworkChangeNotifier is required by Rfc7050PrefixRefresher. Change-Id: I6988f05d873bedc02fe63d0760a464e3c82249c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524707 Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#640949} remoting/test/protocol_perftest.cc | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) commit ebb194673e328a12e8db73751b33e0e8a2abe7fa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 22:12:27 2019 +0000 Roll src/third_party/chromite 0f6a92f63625..69d4958ee9b3 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f6a92f63625..69d4958ee9b3 git log 0f6a92f63625..69d4958ee9b3 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 pprabhu@chromium.org config: Move {caroline*,kevin*} chrome PFQ to Skylab 2019-03-14 pprabhu@chromium.org config: Move pi-android PFQ for {caroline-arcnext,kevin} to Skylab Created with: gclient setdep -r src/third_party/chromite@69d4958ee9b3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ib1bca464d698b554ec64261a6cd4acb4f7d0637d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524380 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640948} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 93d4131ac913d43b4f36b36924f270d9bf4c6f02 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Mar 14 22:04:02 2019 +0000 [AR][IOS] Cleans up USZD file preview base::Feature code post launch Bug: 1476057 Change-Id: I4537b2ed44f4c440de1acd893b3f4ea01156a7ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524643 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640947} ios/chrome/browser/BUILD.gn | 1 - ios/chrome/browser/about_flags.mm | 4 ---- ios/chrome/browser/download/browser_download_service_unittest.mm | 4 ---- ios/chrome/browser/download/features.h | 4 ---- ios/chrome/browser/download/features.mm | 6 +----- ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ---- ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 ---- 7 files changed, 1 insertion(+), 26 deletions(-) commit 9dcba5033ec946df6c21d0254f5b59857dbdff9e Author: Jonathan Backer <backer@chromium.org> Date: Thu Mar 14 22:03:38 2019 +0000 Clean up fuzzer teardown Two changes: - only Destroy decoder_ if successfully Initialized. A failing initialization will call Destroy and it's not safe to call twice. - DestroyAllSharedImages with context_state_ current. If |decoder_| did not properly Initialize, there may not be a context current. Moved it after destroying decoder so that destruction order is the opposite of construction order. Bug: 941668, 941704 Change-Id: I45f6bae446f1540c84737e76d46879e144f75154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525005 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640946} gpu/command_buffer/tests/fuzzer_main.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) commit d6cd75bec10d294b5c6cfe7fb72f5f9ef8d980c3 Author: Eric Karl <ericrk@chromium.org> Date: Thu Mar 14 22:01:36 2019 +0000 Add a finch flag for Android wide color gamut Allow finch trial of wide color gamut on specific device models. Also add a setting in ContentBrowserClient to determine whether Android uses the Window's colorspace (needed for WebView to match embedding app), or the display's capabilities (used in full Chrome). Bug: 884376 Change-Id: Ice9a421c87e52620ce3f10595f676ad2946da56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516595 Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640945} .../browser/aw_content_browser_client.cc | 8 +++++ .../browser/aw_content_browser_client.h | 2 ++ android_webview/browser/aw_feature_list.cc | 1 - .../chromium/android_webview/AwBrowserProcess.java | 5 --- .../chromium/android_webview/AwFeatureList.java | 1 - chrome/browser/chrome_content_browser_client.cc | 10 ++++++ chrome/browser/chrome_content_browser_client.h | 5 +++ chrome/common/chrome_features.cc | 42 ++++++++++++++++++++++ chrome/common/chrome_features.h | 8 +++++ content/browser/browser_main_loop.cc | 5 ++- .../renderer_host/render_widget_host_unittest.cc | 3 +- .../render_widget_host_view_android.cc | 7 +++- content/public/browser/content_browser_client.cc | 7 ++++ content/public/browser/content_browser_client.h | 12 +++++++ ui/android/display_android_manager.cc | 19 ++++++---- ui/android/display_android_manager.h | 5 +-- .../src/org/chromium/ui/base/WindowAndroid.java | 9 ----- ui/android/screen_android.h | 2 +- ui/android/window_android.cc | 3 -- 19 files changed, 122 insertions(+), 32 deletions(-) commit dd9bcb241b9d2582f67c086a0f2af762336c7adb Author: Jacob Dufault <jdufault@google.com> Date: Thu Mar 14 21:55:11 2019 +0000 cros: Eliminate ScreenContext in ResetScreen Bug: 926511 Change-Id: I956961db07987b17f51a7b2757c6f2f1851f1fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506755 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#640944} .../browser/chromeos/login/screens/reset_screen.cc | 136 +++++------- .../browser/chromeos/login/screens/reset_screen.h | 7 - chrome/browser/chromeos/login/screens/reset_view.h | 27 +++ .../chromeos/login/oobe_screen_hid_detection.js | 4 +- .../resources/chromeos/login/oobe_screen_reset.js | 237 ++++++++++++--------- .../webui/chromeos/login/reset_screen_handler.cc | 83 +++++++- .../ui/webui/chromeos/login/reset_screen_handler.h | 24 +++ 7 files changed, 318 insertions(+), 200 deletions(-) commit d02e5e992b88f63a49efd57dc7af7c65515add20 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Thu Mar 14 21:53:25 2019 +0000 Fix libEGL CFI-icall failures This is required as of https://crrev.com/c/1380511 since it replaces direct calls with dynamically resolved cross-DSO calls. Bug: 941468 Change-Id: I6fdc99cde23a6d69f5d15667d10e847b8cad2f32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525043 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#640943} tools/cfi/blacklist.txt | 1 + 1 file changed, 1 insertion(+) commit 87da6a7a9c6c56684412a8bdb09cc1a0fee65108 Author: Li Lin <llin@chromium.org> Date: Thu Mar 14 21:51:27 2019 +0000 Reland "Launch Android Intent for media playback" This is a reland of fb0e628497c513215b458fc2236406f7ab7eafb0 Original change's description: > Launch Android Intent for media playback. > > Bug: b:124796759 > Test: Manual > Change-Id: I197f984578e9f80096ada1701e0399058bf9e848 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480726 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Commit-Queue: Li Lin <llin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638359} Bug: b:124796759 Change-Id: Ic6933c129ccb68232987c19c5eca8c16032fc303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509817 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#640942} chrome/browser/ui/ash/assistant/device_actions.cc | 3 ++ .../assistant/assistant_manager_service_impl.cc | 47 ++++++++++++++++++++-- .../assistant/assistant_manager_service_impl.h | 4 ++ .../assistant/public/mojom/assistant.mojom | 12 ++++++ 4 files changed, 62 insertions(+), 4 deletions(-) commit 93337ded59d1232dd0f695c6703d729e324b787f Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Mar 14 21:49:12 2019 +0000 CORB allowlist additions - 2019-03-14. Bug: 941720 Bug: 941755 Bug: 941774 Bug: 941857 Bug: 941816 Bug: 941921 Bug: 941928 Bug: 941815 Bug: 941812 Bug: 941973 Bug: 941974 Bug: 941992 Bug: 941813 Bug: 942009 Bug: 942026 Bug: 942079 Bug: 942143 Bug: 942146 Bug: 942148 Bug: 942178 Bug: 941890 Change-Id: Ie615fd44e49ee28a5f610db008397752d90bb1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521973 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#640941} extensions/browser/url_loader_factory_manager.cc | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) commit 6cb102aab2070730da90a0f2baee202e36f146b2 Author: Tatiana Buldina <buldina@chromium.org> Date: Thu Mar 14 21:48:25 2019 +0000 [ChromeDriver] Allow null value for script timeout Bug: chromedriver:2796 Change-Id: If8ea3747baac59a7deb6a63c5abb15ca9695abda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521768 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#640940} chrome/test/chromedriver/capabilities.cc | 18 +++++++++++----- chrome/test/chromedriver/session_commands.cc | 32 +++++++++++++++++++++------- 2 files changed, 37 insertions(+), 13 deletions(-) commit af84026e54147863098b8585d6b3d431a6102943 Author: Azeem Arshad <azeemarshad@chromium.org> Date: Thu Mar 14 21:47:52 2019 +0000 [AndroidSms] Fix issues with messages commandline url override. This CL adds a new commandline arg for the android messages PWA installation url. Also fixed issue with localhost urls crashing PWA installation. Fixed this by not passing secure flag for cookies when setting it on localhost urls. Bug: 904686 Change-Id: Ib084c554b8977d5f60a288935ce5fad384a1281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524901 Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640939} .../android_sms_app_setup_controller_impl.cc | 13 +++++++------ .../chromeos/android_sms/android_sms_switches.cc | 3 +++ .../chromeos/android_sms/android_sms_switches.h | 4 ++++ .../chromeos/android_sms/android_sms_urls.cc | 22 ++++++++++++++++------ 4 files changed, 30 insertions(+), 12 deletions(-) commit 35928a46c0e9fe4d7a35a262fb5f64f749e435b8 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Thu Mar 14 21:46:31 2019 +0000 PM: Change graph node lifetime and stop using mojo for local IPC. This change retires the {Frame|Page|Process|System}ResourceCoordinator classes. Instead owners of graph nodes maintain unique_ptrs to them, and communicate via PostTask to the graph. There is now strict lifetime ordering between the PerformanceManager and the graph nodes, all of which have to be destroyed before the PerformanceManager itself is destroyed. A followup CL will retire the mojo interfaces and methods that have been replaced. Bug: 910288 Change-Id: I45fa86f648b79dae688574b8022a213b16ec0d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512301 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640938} chrome/browser/BUILD.gn | 11 --- .../browser_child_process_watcher.cc | 58 +++++++++--- .../browser_child_process_watcher.h | 14 +-- ...tent_browser_client_performance_manager_part.cc | 18 +++- .../frame_resource_coordinator.cc | 82 ----------------- .../frame_resource_coordinator.h | 55 ------------ chrome/browser/performance_manager/graph/README.md | 17 ++++ .../performance_manager/graph/frame_node_impl.cc | 9 +- .../performance_manager/graph/frame_node_impl.h | 2 +- chrome/browser/performance_manager/graph/graph.cc | 57 ++++-------- chrome/browser/performance_manager/graph/graph.h | 32 ++----- .../graph/graph_node_provider_impl.cc | 81 ----------------- .../graph/graph_node_provider_impl.h | 58 ------------ .../graph/graph_test_harness.cc | 3 +- .../performance_manager/graph/graph_test_harness.h | 62 ++++++++++--- .../performance_manager/graph/graph_unittest.cc | 53 +++-------- .../browser/performance_manager/graph/node_base.cc | 14 --- .../browser/performance_manager/graph/node_base.h | 14 +-- .../graph/node_base_unittest.cc | 1 - .../performance_manager/graph/page_node_impl.cc | 11 ++- .../performance_manager/graph/page_node_impl.h | 4 +- .../performance_manager/graph/process_node_impl.cc | 5 +- .../performance_manager/graph/system_node_impl.cc | 4 +- .../page_resource_coordinator.cc | 100 --------------------- .../page_resource_coordinator.h | 56 ------------ .../performance_manager/performance_manager.cc | 41 ++++++++- .../performance_manager/performance_manager.h | 36 +++++++- .../performance_manager_tab_helper.cc | 87 +++++++++++++----- .../performance_manager_tab_helper.h | 17 ++-- .../performance_manager_unittest.cc | 100 +++++---------------- .../process_resource_coordinator.cc | 63 ------------- .../process_resource_coordinator.h | 47 ---------- .../render_process_user_data.cc | 38 ++++++-- .../performance_manager/render_process_user_data.h | 12 +-- .../resource_coordinator_interface.h | 70 --------------- .../system_resource_coordinator.cc | 34 ------- .../system_resource_coordinator.h | 34 ------- ...rowser_main_extra_parts_resource_coordinator.cc | 1 - 38 files changed, 401 insertions(+), 1000 deletions(-) commit 7338b86fd1bee62ca503e90f69d974ee8e187fff Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 14 21:44:19 2019 +0000 [code coverage] move linux-chromeos-code-coverage to chromium.fyi This was created in the wrong waterfall by mistake. NOTRY=true TBR=liaoyuke,bpastene Change-Id: Ib58bc027fc79bd4bd444ba29ef019fd258aa3bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525053 Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#640937} testing/buildbot/chromium.chromiumos.json | 700 ------------------------------ testing/buildbot/chromium.fyi.json | 700 ++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 16 +- 3 files changed, 708 insertions(+), 708 deletions(-) commit edaf3b880a7e338f06321b2d3977e41ee55a6aa6 Author: Matt Menke <mmenke@chromium.org> Date: Thu Mar 14 21:39:44 2019 +0000 Fix crash in SpdyStream::SetPriority. When a ConnectJob is assigned to a request in the socket pool, there is often some reassignment of ConnectJobs to stream requests. This can result in reprioritizing ConnectJobs. If one of those ConnectJobs was using a SpdyProxyClientSocket that is using a torn down SpdySession, trying to change its priority would result in a null dereference. This CL makes reprioritizing SpdyProxyClientSockets and QuicProxyClientSockets do nothing, as the reprioritizations in this stage are often superfluous, and doesn't really get us much in either case. In followup CLs, I both want to remove the unnecessary reprioritizations and use a fixed priority of all H2/QUIC tunnels. Bug: 940848 Change-Id: I7c646b1bfcb18977dc2837c73f7b05172d6f908d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521279 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#640936} net/http/http_proxy_connect_job_unittest.cc | 5 +- net/quic/quic_network_transaction_unittest.cc | 66 ++++++ net/quic/quic_proxy_client_socket.cc | 10 +- net/quic/quic_proxy_client_socket_unittest.cc | 4 +- .../transport_client_socket_pool_unittest.cc | 255 +++++++++++++++++++++ net/spdy/spdy_proxy_client_socket.cc | 10 +- net/spdy/spdy_proxy_client_socket_unittest.cc | 8 +- net/spdy/spdy_test_util_common.cc | 3 +- 8 files changed, 348 insertions(+), 13 deletions(-) commit d7a6f417f2e12fca309f942797c15a44d224f27f Author: Dan Beam <dbeam@chromium.org> Date: Thu Mar 14 21:33:03 2019 +0000 WebUI Dark Mode: update guest NTP Screenshot: https://imgur.com/a/D9Y8VjF Note: Guest NTP differs from many other webui pages. * It overrides request handling to use NTPResourceCache, which has a separate way of doing i18n/loadTimeData, and caches a pre-built string of page content/CSS. It also tracks inputs that might affect that cache and invalidates. * In order to resolve $i18n{} messages (i.e. $i18n{dark}) like other webui pages, it'd have to go to the I/O thread to block, which breaks a few assumptions about NTPResourceCache's synchronously returning a string on the UI thread. * It uses URLDataSource instead of WebUIDataSource, which doesn't let you update it after being created (i.e. to update whether dark mode has changed to have the right default when refreshing the page after system dark mode is flipped). * It doesn't use loadTimeData and if it did, it doesn't set loadTimeData.data_ (as currently written), which throws if you trying to call overrideValues() (which dark_mode.js does). ^ These are probably all worth changing or fixing, but not with the possibility of a merge to 74 (we'll see if that happens). R=dpapad@chromium.org BUG=930269 Change-Id: I259d0b7e5e9c7664336451fa06c843cd4c17a077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519930 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#640935} chrome/browser/resources/ntp4/guest_tab.html | 2 +- .../resources/ntp4/incognito_and_guest_tab.css | 12 +++++++++--- chrome/browser/ui/webui/ntp/new_tab_ui.cc | 21 ++++++++++++++++++++- chrome/browser/ui/webui/ntp/new_tab_ui.h | 6 +++++- 4 files changed, 35 insertions(+), 6 deletions(-) commit 872b28eb24c54a404d6151aa47b08e24bed69a85 Author: Joshua Seaton <joshuaseaton@google.com> Date: Thu Mar 14 21:31:29 2019 +0000 [fuchsia] Create manifest of debug symbol archives. Change-Id: I7fb9e9873e4133f62785ca1b0e977e2bc3a26697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524705 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Joshua Seaton <joshuaseaton@google.com> Cr-Commit-Position: refs/heads/master@{#640934} fuchsia/BUILD.gn | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit 068c097d2528ceded19232ba0131dc23c6bdc25d Author: Jared Saul <jsaul@google.com> Date: Thu Mar 14 21:29:29 2019 +0000 Migrate AutofillWalletDataTypeController to /payments This was done separately from CL 1513105 due to using banned base::Bind functions and needing to convert them to base::BindRepeating in order to move the file. Bug: 940042 Change-Id: I182856e2c2b3075b4b75b55a55891e5503bc3013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519321 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#640933} components/autofill/core/browser/BUILD.gn | 6 +++--- .../autofill_wallet_data_type_controller.cc | 8 ++++---- .../autofill_wallet_data_type_controller.h | 8 ++++---- .../autofill_wallet_data_type_controller_unittest.cc | 20 ++++++++++++-------- .../profile_sync_components_factory_impl.cc | 2 +- 5 files changed, 24 insertions(+), 20 deletions(-) commit 39f6d3b3ba0b61eb6f8a71a420300ed60109392a Author: Yaron Friedman <yfriedman@chromium.org> Date: Thu Mar 14 21:28:05 2019 +0000 [Touchless] Disable Webapp disclosure snackbar. UI isn't great for no-touch. Bug: b/120101151 Change-Id: Icc2339416b891f7ffdea0283730bd5f1be22dcbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524420 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640932} .../chrome/browser/webapps/WebappDisclosureSnackbarController.java | 6 ++++++ 1 file changed, 6 insertions(+) commit df0bfb1511bc57d31ff9a53ed53a8eb393415f51 Author: David Bokan <bokan@chromium.org> Date: Thu Mar 14 21:26:07 2019 +0000 Don't move interest when focused editable This ensures focus and interest don't diverge. It also ensures common drop down input boxes function correctly. e.g. drop downs that produce a list of suggested autocompletions that can be selected with arrow keys. Change-Id: Ic4e152e77bfb6b8ecf61466ad6b7ff958ec75a4d Bug: 942110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524412 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640931} .../core/page/spatial_navigation_controller.cc | 14 ++++ ...focusless-focused-editable-blocks-movement.html | 89 ++++++++++++++++++++++ 2 files changed, 103 insertions(+) commit 057d5a3fac331dff179014f6d6d8b94605451ebb Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 14 21:23:45 2019 +0000 Add flag to aggressively pre-warm renderers for SingleTabActivity. We want to experiment with always keeping a pre-warmed renderer around to make PWA and view intent launches faster. This CL also ensures CCT-related histograms are only captured for usage of the WarmupManager by CCT and adds a "STOLEN" histogram bucket capturing when the WebContents warmed up for CCT is used by something that isn't CCT. Bug: 922045 Change-Id: Ifd4c1af30dd56b588c061daa2fb3c51b9d497931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1426920 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640930} .../chromium/chrome/browser/SingleTabActivity.java | 34 ++++++++++ .../org/chromium/chrome/browser/WarmupManager.java | 36 ++++++----- .../browser/customtabs/CustomTabActivity.java | 3 +- .../browser/customtabs/CustomTabsConnection.java | 14 +++-- .../content/CustomTabActivityTabController.java | 2 +- .../browser/init/AsyncInitializationActivity.java | 4 +- .../src/org/chromium/chrome/browser/tab/Tab.java | 9 ++- .../java_templates/ChromeSwitches.java.tmpl | 6 ++ .../chromium/chrome/browser/WarmupManagerTest.java | 72 ++++++++++++---------- .../customtabs/CustomTabsConnectionTest.java | 31 ++++++++-- .../browser/tabmodel/ChromeTabCreatorTest.java | 5 +- .../CustomTabActivityTabControllerTest.java | 3 +- tools/metrics/histograms/enums.xml | 11 ++++ 13 files changed, 161 insertions(+), 69 deletions(-) commit 61ba2fac47df7da007013387dcfcb5c9ce27081c Author: Justin Cohen <justincohen@google.com> Date: Thu Mar 14 21:20:44 2019 +0000 [ios] Don't reference transient item after it's been released. crrev.com/c/1401436 introduced a use-after-free bug because the NavigationItem |item| can be cleared when calling -registerLoadRequestForURL Instead, grab |item| VirtualURL before calling register. Bug: 941421 Change-Id: Id39b94b44c33adf4dbbf62d3584c1da793a0d0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524527 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#640929} ios/web/web_state/ui/crw_web_controller.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit 0719e065cf0d77610400b0ed4552079e7534eea9 Author: danakj <danakj@chromium.org> Date: Thu Mar 14 21:19:11 2019 +0000 Let RenderWidget call WebWidgetClient methods on itself. Now the RenderWidget is always the WebWidgetClient even in web-tests since they will override RenderWidget instead of replace it thanks to https://chromium-review.googlesource.com/c/chromium/src/+/1437324. R=ajwong@chromium.org Bug: 545684, 912193 Change-Id: Ie1740b91c4730841f4381df2ea5785d52ecefd51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524866 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640928} content/renderer/render_view_impl.cc | 4 ---- content/renderer/render_view_impl.h | 1 - content/renderer/render_widget.cc | 10 +++------- content/renderer/render_widget_delegate.h | 4 ---- content/renderer/render_widget_unittest.cc | 3 --- 5 files changed, 3 insertions(+), 19 deletions(-) commit 55ba66cbee96c235fd57ce7d53bb465bb5fdcfb5 Author: Raul Tambre <raul@tambre.ee> Date: Thu Mar 14 21:17:03 2019 +0000 //jingle: Convert base::(U)Int(64)ToString(16) to NumberToString(16) The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I4b294370ac7d15dac6adbfd04173be082d0dc0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1461128 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640927} jingle/glue/network_service_async_socket_unittest.cc | 7 ++++--- jingle/notifier/listener/xml_element_util.cc | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) commit 49505e67e966fd9036592e564df7fc87bac1b75d Author: Robbie McElrath <rmcelrath@chromium.org> Date: Thu Mar 14 21:16:08 2019 +0000 Add ThrottlingURLLoader unit test. This is a unit test for the issue fixed in crrev.com/c/1511620. Bug: 933538 Change-Id: I9ae72bb4189605b1fc69dd1186c55867346ab024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521823 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#640926} content/common/throttling_url_loader_unittest.cc | 34 ++++++++++++++++++++++++ 1 file changed, 34 insertions(+) commit 1ab6a5fe448a153786aadcd92c7fe0abbbcaa644 Author: Roberto Carrillo <robertocn@google.com> Date: Thu Mar 14 21:15:56 2019 +0000 [code coverage] Create linux-chromeos-code-coverage. This builder is intended to build test targets with chromeos as its target os, run them with code coverage instrumentation and provide code coverage information specially for targets that are not yet running on the vm builder. R=jbudorick,liaoyuke,sajjadm,bpastene BUG=942123 Change-Id: I78b04fabc4f452aee024177d81627a05306a065f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522434 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#640925} infra/config/cr-buildbucket.cfg | 8 + infra/config/luci-milo.cfg | 5 + infra/config/luci-scheduler.cfg | 11 + testing/buildbot/chromium.chromiumos.json | 700 ++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 8 + tools/mb/mb_config.pyl | 5 + 6 files changed, 737 insertions(+) commit 567d1d3d60fe53d8a1c2e1939c8d1113c61dac84 Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Thu Mar 14 21:13:01 2019 +0000 Make BoxOverflowModel use fast malloc. In SSM this showed up as a performance hit using the standard allocator. Change-Id: I5a05caabe558c6cc7b79cc18c9f5a4143dece0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489420 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640924} third_party/blink/renderer/core/layout/overflow_model.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) commit 6a933904d193b48c457952e1b77ba4f05eb8b415 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Thu Mar 14 21:09:27 2019 +0000 Introduce delayed memory purge after freezing Decoupling memory purging from freezing is necessary in order to make freezing lower-cost. Currently, memory purging is performed immediately after a page is frozen. This approach results in more work for the CPU immediately following a freeze and makes freezing more expensive than necessary. A lower-cost freezing functionality enables freezing to be performed more aggressively, and allows for better use of the CPU. Specifically, short-term freezing should be performed within minimal cost, allowing us to better allocate CPU time in times of higher workload. However, completely removing memory purging from freezing is not an option, since there is a measurable memory benefit (10-50 MB) associated with freezing. Using a delay ensures we retain the memory benefit associated with freezing, while making short-term freezing lower-cost. To support this effort, a timer responsible for triggering the memory purge was introduced in MemoryPurgeManager. Furthermore, a memory purge will only occur if all pages are frozen. This approach ensures that once a purge occurs, there will be no need to purge the renderer again and prevents unnecessary purges. In order to measure the effects of the new behaviour, the new functionality is being introduced as an experiment. A FeatureParam has also been introduced to allow for the variation of delay time. Bug: 926186 Change-Id: If497e4e8de914136179c75de0ac032c058a2a527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1457023 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#640923} third_party/blink/common/features.cc | 4 + third_party/blink/public/common/features.h | 1 + .../main_thread/main_thread_scheduler_impl.cc | 9 +- .../main_thread/main_thread_scheduler_impl.h | 4 +- .../scheduler/main_thread/memory_purge_manager.cc | 63 ++++-- .../scheduler/main_thread/memory_purge_manager.h | 34 +++- .../main_thread/memory_purge_manager_unittest.cc | 214 ++++++++++++++++++--- .../scheduler/main_thread/page_scheduler_impl.cc | 19 +- .../scheduler/main_thread/page_scheduler_impl.h | 3 + 9 files changed, 292 insertions(+), 59 deletions(-) commit ea9fc5e9eea847949898b161261fe829b0f4928b Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Thu Mar 14 21:08:27 2019 +0000 [css-properties-values-api] Compute <length> values to px. According to the spec, the computed value of <length> registered properties is the absolute value expressed in pixels. Currently, we are only behaving correctly if the value is a calc() or if the CSSPrimitiveValue contains a relative unit (e.g. em). This means that values like '1in' would not be expressed in pixels. As of this CL, we absolutize any <length> which isn't already a simple (non-calc) px value. R=futhark@chromium.org Bug: 641877 Change-Id: Idec079671a094952e122847fc5ebd4b0cb609674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520586 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#640922} .../renderer/core/css/resolver/style_builder_converter.cc | 15 ++++++++++----- .../registered-property-computation-expected.txt | 7 ++++++- .../registered-property-computation.html | 6 ++++++ .../registered-property-initial.html | 6 ++++++ 4 files changed, 28 insertions(+), 6 deletions(-) commit 3777dc1dc5bf950b4632bacf314512b130918f25 Author: Mike Wasserman <msw@chromium.org> Date: Thu Mar 14 21:08:23 2019 +0000 Check custom cursors for bitmap equality as needed Make ui::Cursor::operator==() check gfx::BitmapsAreEqual() as needed. CursorManager::SetCursor() skips unnecessary work when cursors are equal. This avoids excessively copying custom cursor images on every mouse move. Add and refine tests; do some cleanup. TODO: Avoid RenderWidgetHostViewAura's new bitmaps on each mouse move. Bug: 940217 Change-Id: I15f003d4aa6ef0b30b2fd7f995bf2da62f6cb406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521036 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#640921} ui/aura/mus/window_port_mus.cc | 2 +- ui/aura/mus/window_tree_client.cc | 4 +- ui/base/BUILD.gn | 1 + ui/base/cursor/cursor.cc | 32 +++++------ ui/base/cursor/cursor.h | 66 ++++++----------------- ui/base/cursor/cursor_unittest.cc | 78 +++++++++++++++++++++++++++ ui/base/mojo/cursor_struct_traits_unittest.cc | 39 ++++++-------- 7 files changed, 131 insertions(+), 91 deletions(-) commit 2770c9c0d860d4ff6ef3dd1f3c4b96a982219861 Author: Raul Tambre <raul@tambre.ee> Date: Thu Mar 14 21:05:04 2019 +0000 Support Python 3 in //tools/clang/scripts/update.py The changes are to allow build files to be generated using Python 3 on Windows. The scripts still work with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: Ib997abb1f397af18165e2b6d2350667df4755f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521348 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#640920} tools/clang/scripts/update.py | 100 +++++++++++++++++++++++------------------- 1 file changed, 54 insertions(+), 46 deletions(-) commit 57142b1ceec4b60caf79323e0a04bf49b12a0bfd Author: Nick Harper <nharper@chromium.org> Date: Thu Mar 14 21:03:59 2019 +0000 Remove ChannelIDService* from CookieMonster Bug: 875053 Change-Id: I304bc44f6776478b6afef6b5c50aa61396c4cbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518561 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: Eric Orth <ericorth@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640919} .../render_frame_message_filter_browsertest.cc | 2 +- content/browser/net/quota_policy_cookie_store.cc | 8 +- ios/chrome/browser/net/cookie_util.mm | 7 +- ios/components/io_thread/ios_io_thread.mm | 5 +- ios/net/cookies/cookie_store_ios.mm | 1 - net/cookies/cookie_monster.cc | 28 +---- net/cookies/cookie_monster.h | 14 +-- net/cookies/cookie_monster_netlog_params.cc | 2 - net/cookies/cookie_monster_netlog_params.h | 1 - net/cookies/cookie_monster_perftest.cc | 14 +-- net/cookies/cookie_monster_store_test.cc | 2 +- net/cookies/cookie_monster_unittest.cc | 140 ++++++++------------- net/cookies/cookie_store_test_helpers.cc | 1 - .../sqlite_persistent_cookie_store_unittest.cc | 7 +- net/url_request/url_request_context_builder.cc | 3 +- net/url_request/url_request_test_util.cc | 3 +- net/url_request/url_request_unittest.cc | 2 +- services/network/cookie_manager_unittest.cc | 3 +- services/network/network_context.cc | 2 +- .../network/restricted_cookie_manager_unittest.cc | 2 +- 20 files changed, 77 insertions(+), 170 deletions(-) commit c82069b96164c2a5df12b452403768d4f2a8a5f5 Author: David Black <dmblack@google.com> Date: Thu Mar 14 21:03:56 2019 +0000 Modify embedded Assistant UI to match spec. Made the following modifications: - Increased dialog plate height to 56dip. - Removed top margin from first card. - Removed bottom padding from UI element container. - Fixed suggestion container and opt in view vertical alignment. - Modified opacity of text elements when transitioning to the next Assistant response to match that of card elements since they no longer share layout space with the thinking dots. Spec: https://docs.google.com/presentation/d/1wwbrR1tlTNGNK7tzjv3sLUr_Zs4gozxovmgTHoYhsyg/ Before: https://drive.google.com/open?id=1FXsKJ-3-hgoyAwxOJqLR4fneD44BatZ8 After: https://drive.google.com/open?id=109FheiueZNC7L2YQN_kdEHH27uiXDFep Bug: b:128607135 Change-Id: I2702a5f96cb8c9737718b09d69ff8ac4fba41119 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524682 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#640918} .../views/assistant/assistant_main_stage.cc | 4 --- .../views/assistant/assistant_main_view.cc | 8 +---- ash/app_list/views/assistant/dialog_plate.cc | 3 +- .../ui/main_stage/assistant_opt_in_view.cc | 5 ++- .../ui/main_stage/suggestion_container_view.cc | 5 ++- .../ui/main_stage/ui_element_container_view.cc | 41 +++++++++++++++++----- 6 files changed, 43 insertions(+), 23 deletions(-) commit faaf1e633564b03d9371b94431347c7fc1ac6bf0 Author: Avi Drissman <avi@chromium.org> Date: Thu Mar 14 21:01:15 2019 +0000 Remove unneeded function. content::ExecuteScriptAndGetValue used to return a raw pointer, so a helper function to call it and delete the result was useful. Now that it returns a unique_ptr, having a helper function is not needed. BUG=none TEST=no change Change-Id: Ief08df42629801358dd6cbe99e70ff85c436ec24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524651 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#640917} .../web_contents_view_aura_browsertest.cc | 42 ++++++++++------------ 1 file changed, 19 insertions(+), 23 deletions(-) commit 9f1c31f03260bf25dbce857357a083c8b1cf8085 Author: Jun Mukai <mukai@chromium.org> Date: Thu Mar 14 20:54:57 2019 +0000 Do not observe transient parents in OverviewItem It seems OverviewItem can be created for a transparent child, but wm::GetTransientTreeIterator() returns the windows of the whole tree, which means it also observes transparent ancestors. This causes a crash. Bug: 941945 Test: manually Change-Id: I0a1a05510ff84596560e8b45c3909a8d715c0a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524418 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#640916} ash/wm/overview/overview_item.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit 7ab386cf55740f6c5afd79ae45110c62d58b1d3e Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Thu Mar 14 20:51:52 2019 +0000 Fixed proc.info in psutil.process_iter Added proc.as_dict(attrs['name']) parameter during psutil.process_iter(). https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8919001567384837856/+/steps/components_unittests__iPhone_X_iOS_12.1.4__on_iOS-12.1.4/0/stdout Bug: 912323 Change-Id: I8d44894ac6466fd87f2eeb3287a5babac7fb1a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524408 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#640915} ios/build/bots/scripts/test_runner.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 1af581e64a1585e67bc1102611efd155b5aa8150 Author: Marcin Wiącek <marcin@mwiacek.com> Date: Thu Mar 14 20:51:43 2019 +0000 Migrate ReferenceTimestampState to @IntDef @IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Patch is migrating ReferenceTimestampState into @IntDef using rules similar to other @IntDef inside Chromium project: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with @Retention(RetentionPolicy.SOURCE) 4. without "static final" in the @interface BUG=919666 Change-Id: I6cd29a847a26113461af27cd90406166c561a727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512639 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by: Simeon Anfinrud <sanfin@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#640914} .../backend/android/AudioSinkAudioTrackImpl.java | 47 +++++++++++++--------- 1 file changed, 28 insertions(+), 19 deletions(-) commit 6b0a72e887407e781fa370f2c8ba15b5e82bc2e8 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Thu Mar 14 20:47:56 2019 +0000 Remove a number of non-flaky TestExpectations that pass Change-Id: Ib7da54151186265666eac3f429ec3bbdbf9afcc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524099 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640913} third_party/blink/web_tests/TestExpectations | 31 ---------------------------- 1 file changed, 31 deletions(-) commit b5e299669075cb1296312c21ebad85d58edf9847 Author: Emily Stark <estark@google.com> Date: Thu Mar 14 20:47:10 2019 +0000 Adapt omnibox to not use a SecurityInfo This is part of a larger refactoring to get rid of the SecurityInfo struct and change consumers to use a SecurityLevel and/or VisibleSecurityState instead. See https://chromium-review.googlesource.com/c/chromium/src/+/1500414 for more of the reasoning/background. This CL changes the LocationBarModelDelegate to expose a SecurityLevel and a VisibleSecurityState instead of a SecurityInfo. Change-Id: Idfcaf34180803b83574b4595ddeeb59022285c4b Bug: 939588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506602 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#640912} .../toolbar/chrome_location_bar_model_delegate.cc | 21 +++++-- .../toolbar/chrome_location_bar_model_delegate.h | 4 +- .../omnibox/browser/location_bar_model_delegate.cc | 11 +++- .../omnibox/browser/location_bar_model_delegate.h | 10 +++- .../omnibox/browser/location_bar_model_impl.cc | 26 ++++----- .../browser/location_bar_model_impl_unittest.cc | 68 +++++++++------------- .../location_bar/location_bar_model_delegate_ios.h | 4 +- .../location_bar_model_delegate_ios.mm | 21 +++++-- 8 files changed, 95 insertions(+), 70 deletions(-) commit 7aa9ebd90f5037108c9425d7f8e33d04e68043ba Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 14 20:46:51 2019 +0000 Roll src-internal eae9be8ac5e0..36082da2f20c (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eae9be8ac5e0..36082da2f20c Created with: gclient setdep -r src-internal@36082da2f20c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Iba637959ab217653779b2624c32e1eb484842068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524325 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640911} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9319e3431f5207b8bfb2d6717afc65326d44bbba Author: Austin Eng <enga@chromium.org> Date: Thu Mar 14 20:46:02 2019 +0000 Move window.webgpu to navigator.gpu The WebGPU working group decided to expose WebGPU at navigator.gpu to match other Web APIs like WebUSB and WebBluetooth at navigator.usb and navigator.bluetooth. This patch also drops the "Web" prefix from "WebGPU". Bug: 941531 Change-Id: Iccf248b79b4b3430b3abc7b70f39b1338f39b515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521233 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#640910} .../blink/renderer/modules/modules_idl_files.gni | 10 ++--- third_party/blink/renderer/modules/webgpu/BUILD.gn | 16 ++++---- third_party/blink/renderer/modules/webgpu/gpu.cc | 23 +++++++++++ third_party/blink/renderer/modules/webgpu/gpu.h | 30 ++++++++++++++ .../modules/webgpu/{webgpu_device.idl => gpu.idl} | 6 ++- .../blink/renderer/modules/webgpu/gpu_adapter.cc | 26 ++++++++++++ .../webgpu/{webgpu_adapter.h => gpu_adapter.h} | 19 ++++----- .../webgpu/{webgpu_adapter.idl => gpu_adapter.idl} | 6 ++- ...r_descriptor.idl => gpu_adapter_descriptor.idl} | 8 ++-- .../webgpu/{webgpu_device.cc => gpu_device.cc} | 21 +++++----- .../webgpu/{webgpu_device.h => gpu_device.h} | 21 +++++----- .../modules/webgpu/{webgpu.idl => gpu_device.idl} | 6 ++- .../blink/renderer/modules/webgpu/navigator_gpu.cc | 46 ++++++++++++++++++++++ .../blink/renderer/modules/webgpu/navigator_gpu.h | 43 ++++++++++++++++++++ .../renderer/modules/webgpu/navigator_gpu.idl | 12 ++++++ .../blink/renderer/modules/webgpu/webgpu.cc | 23 ----------- third_party/blink/renderer/modules/webgpu/webgpu.h | 29 -------------- .../renderer/modules/webgpu/webgpu_adapter.cc | 26 ------------ .../blink/renderer/modules/webgpu/window_webgpu.cc | 45 --------------------- .../blink/renderer/modules/webgpu/window_webgpu.h | 37 ----------------- .../renderer/modules/webgpu/window_webgpu.idl | 10 ----- 21 files changed, 241 insertions(+), 222 deletions(-) commit c0c6b8b5a9859b640186a818dc4927fe6d3d2b92 Author: danakj <danakj@chromium.org> Date: Thu Mar 14 20:45:48 2019 +0000 Make the BlinkTestRunner owned by WebViewTestProxy Instead of nulling out the WebTestInterfaces pointer to it but leaking the instance of BlinkTestRunner, we can delete it and use a unique_ptr to own it. R=ajwong@chromium.org Bug: 912193, 545684 Change-Id: Ied770982ec3110f9e254812169c6ab4c503b2fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524881 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640909} content/shell/test_runner/web_test_delegate.h | 5 ++--- content/shell/test_runner/web_view_test_proxy.cc | 8 +++----- content/shell/test_runner/web_view_test_proxy.h | 7 ++++--- content/test/web_test_support.cc | 6 +++--- 4 files changed, 12 insertions(+), 14 deletions(-) commit dc710a15ebe35a261159334c408532b8e0b119a4 Author: Alex Clarke <alexclarke@chromium.org> Date: Thu Mar 14 20:44:50 2019 +0000 Minor optimization of TaskQueueImpl::WakeUpForDelayedWork The following optimizations have been applied: 1. We avoid moving Task into an unnecessary temporary which matters since Task is quite large. 2. We avoid unnecessary logic per Push to check if we need to update WorkQueueSets 3. We make it the responsibility of the caller to call ScheduleWork. This measures as about 3% faster on SequenceManagerPerfTest.PostDelayedTasks_OneQueue/3 Bug: 897751 Change-Id: I1fb61c20dbedb464a04817fce172eefad8ddf368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520828 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640908} .../task/sequence_manager/sequence_manager_impl.cc | 15 +++--- base/task/sequence_manager/sequence_manager_impl.h | 2 +- .../sequence_manager_impl_unittest.cc | 12 +++-- base/task/sequence_manager/task_queue_impl.cc | 32 ++++++------ base/task/sequence_manager/task_queue_impl.h | 5 +- .../test/sequence_manager_for_test.h | 2 +- base/task/sequence_manager/time_domain.cc | 4 +- base/task/sequence_manager/time_domain.h | 5 +- base/task/sequence_manager/time_domain_unittest.cc | 12 ++--- base/task/sequence_manager/work_queue.cc | 40 ++++++++++++++- base/task/sequence_manager/work_queue.h | 21 ++++++++ base/task/sequence_manager/work_queue_unittest.cc | 58 ++++++++++++++++++++++ 12 files changed, 162 insertions(+), 46 deletions(-) commit fed595846e803d242409237ea432b0abdfd5d7ec Author: Austin Eng <enga@chromium.org> Date: Thu Mar 14 20:44:41 2019 +0000 Release dawnDevice when WebGPUDecoderImpl is destroyed The Dawn WireServer destroys all Dawn objects it owns when it is destructed. However, it does not own the Device so this needs to be released separately. Bug: 941685 Change-Id: Ife39eb914de3d109101c2fb70021d721d54fd56c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521626 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640907} gpu/command_buffer/service/webgpu_decoder_impl.cc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) commit ae7f3cb3c7218bda82e75c2953ffa6b3ba62a99e Author: Robert Sesek <rsesek@chromium.org> Date: Thu Mar 14 20:40:53 2019 +0000 Revert "Set FLAG_EXCLUDE_STOPPED_PACKAGES on outbound Intents." This reverts commit b64089207217843aa59d0daee8f9ae0e991770f5. Reason for revert: Breaking Firebase Deep Links Bug: 939905, 607966 Original change's description: > Set FLAG_EXCLUDE_STOPPED_PACKAGES on outbound Intents. > > This will prevent packages that have been installed but not yet > explicitly launched by the user, as well those that have been force- > stopped, from being the target of an Intent from the web. > > Bug: 607966 > Change-Id: I17e1168a7ee8a73e1b42175f7bd0b6f2e61aed04 > Reviewed-on: https://chromium-review.googlesource.com/c/1316112 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606066} Change-Id: Icee5a3f91080e78bc7e55d4803735c2afbb5f010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524522 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#640906} .../browser/externalnav/ExternalNavigationHandler.java | 9 ++------- .../browser/externalnav/ExternalNavigationHandlerTest.java | 12 ------------ 2 files changed, 2 insertions(+), 19 deletions(-) commit 5c57a3449a567916fbfb09769c226c297e062091 Author: danakj <danakj@chromium.org> Date: Thu Mar 14 20:37:38 2019 +0000 Remove GetWebViewTestProxy(). This method is there just to call Reset() on the WebViewTestProxy after the RenderViewImpl has been partially initialized. This doesn't seem to be important ordering, and Reset() doesn't change anything compared to how the test proxy objects are constructed, so we can just not call Reset() there. R=ajwong@chromium.org Bug: 912193, 545684 Change-Id: I5867072290221410d4f72ae874e39c458ed4f3bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524407 Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640905} content/public/test/web_test_support.h | 5 ----- .../shell/renderer/web_test/web_test_content_renderer_client.cc | 7 ------- content/test/web_test_support.cc | 4 ---- 3 files changed, 16 deletions(-) commit 78345ac03ff313356d4b414425febaeb97f19260 Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Date: Thu Mar 14 20:34:11 2019 +0000 image_capture_test-html : cleanup No functionality change. Reilly suggested this change here at https://chromium-review.googlesource.com/c/chromium/src/+/1508519/1/content/test/data/media/image_capture_test.html#176 Bug: none. Change-Id: I19a6c63abf33a5d0e3e7dc0cb53ac0596e32a90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514574 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#640904} content/test/data/media/image_capture_test.html | 65 ++++++++----------------- 1 file changed, 20 insertions(+), 45 deletions(-) commit 0d8ba43470722c38445b06f913cebe62aafaa8d8 Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Mar 14 20:33:48 2019 +0000 Async Clipboard: Update comments and TODOs. - Filed a bug to track removal of Misc TaskType. - Removed duplicate comments tracking adding of more types. - Removed other extraneous comments. - No logic/functional changes. Change-Id: I47ceca45f5b472574ad888a68b87390fe2da4672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522546 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#640903} .../blink/renderer/modules/clipboard/clipboard_promise.cc | 11 ++++++----- .../blink/renderer/modules/clipboard/clipboard_promise.h | 5 +++-- 2 files changed, 9 insertions(+), 7 deletions(-) commit 19c181deb1cb53cb8924277eda4b768baa414f79 Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Thu Mar 14 20:32:02 2019 +0000 ozone/wayland: Clean up TestDataSource This CL cleans up TestDataSource API and implementation: - Removed unneeded callback from ReadData implementation; - Parameterizing mime type in ReadData function, making tests using it more readable with less implict logic regarding mime type handling; - Adds a test to validate the case where the client offers a given mime type and the the server is expecting another one, where no data should be sent; - Remove unneeded WeakPtrFactory class variable; - Simplify ReadDataOnWorkerThread logic; Bug: 926101 Change-Id: Ic35de3a9740eb9d56809cbf38a16b10c97347cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521170 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#640902} ui/ozone/platform/wayland/test/test_data_source.cc | 31 +++++-------- ui/ozone/platform/wayland/test/test_data_source.h | 12 ++--- .../wayland/wayland_data_device_unittest.cc | 52 +++++++++++++++++----- 3 files changed, 58 insertions(+), 37 deletions(-) commit 5e4e70648a6da715d6d28447357765079b94bb02 Author: Philip Rogers <pdr@chromium.org> Date: Thu Mar 14 20:30:02 2019 +0000 Remove unused CompositingReasonsForAnimation call Change-Id: Ibcab5423f9cb731ecfc73594f12c509dc809dd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524861 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640901} third_party/blink/renderer/core/paint/paint_property_tree_builder.cc | 1 - 1 file changed, 1 deletion(-) commit 94a82ccf8ead4f644f97b39f822ba6d3914e1968 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Thu Mar 14 20:20:16 2019 +0000 [layoutng] Inline the ShapeResultSpacing constructor Good performance data: https://pinpoint-dot-chromeperf.appspot.com/job/11a140e8f40000 Change-Id: I171ca316fbd8336576dbc78929bf48d35b1494e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1330077 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#640900} .../platform/fonts/shaping/shape_result_spacing.cc | 15 --------------- .../platform/fonts/shaping/shape_result_spacing.h | 13 ++++++++++++- 2 files changed, 12 insertions(+), 16 deletions(-) commit 8ddaa62025cb1934a3ff6bb924d2c4790e90d149 Author: Eric Karl <ericrk@chromium.org> Date: Thu Mar 14 20:18:22 2019 +0000 exit_on_context_lost for PowerVR Rogue GE8* These devices do not appear to recover from robustness context loss correctly. Bug: 942106 Change-Id: I1f61bd7b81a9df2ead8f9cf42429af0d0ed8fc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524415 Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#640899} gpu/config/gpu_driver_bug_list.json | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 41d7a082ac6c6cfd7f54855f7235b38073905f4a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 20:17:37 2019 +0000 Roll src/third_party/SPIRV-Tools/src 6df8a917a449..bdcb155163d4 (2 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/6df8a917a449..bdcb155163d4 git log 6df8a917a449..bdcb155163d4 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 33432579+alan-baker@users.noreply.github.com Relax function call parameter check (#2448) 2019-03-13 stevenperron@google.com Remove duplicates from list of interface IDs in OpEntryPoint instruction (#2449) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@bdcb155163d4 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8b9310388e1e32677f81c5aeff5ee10ba9b80fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524366 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640898} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 98fc50733d97fd5836d4964cfe895b013456e7e3 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Mar 14 20:17:17 2019 +0000 chromeos: Preflight CL to run perf tests on device. When running on device: - No adding "ash-host-window-bounds" switch. Otherwise the display is not properly configured; - Enable stub user login so that test runs in regular user session as on dev box; - No logging redirect in browser tests; - Use session manager daemon for shutdown only when DBusThreadManager uses real client; Bug: 939010 Test: Run interactive_ui_tests on device Change-Id: I059f28ef6cfe9dae3b605aa5ff8f7504eb4e9da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512612 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640897} .../login/session/chrome_session_manager.cc | 4 +-- .../browser/lifetime/termination_notification.cc | 4 +-- chrome/test/base/in_process_browser_test.cc | 34 ++++++++++++++++++---- 3 files changed, 32 insertions(+), 10 deletions(-) commit 1c2c049680ae9344a4f77c4ec95ecb0c17c5d879 Author: Nasko Oskov <nasko@chromium.org> Date: Thu Mar 14 20:13:39 2019 +0000 Revert "Add temporary simplified process lock check in the renderer process." This partially reverts https://chromium-review.googlesource.com/1507195 since we don't need the instrumentation anymore. The parts that are kept are plumbing of the network error code into Blink and some minor refactoring in RenderFrameImpl - both of these at the request of the reviewers of the CL as useful parts to stay. Bug: 931895 Change-Id: I71b7cdf82f76d4dfe7f9110f6bd077cc673e14c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524095 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#640896} .../renderer_host/render_process_host_impl.cc | 2 +- .../service_worker/embedded_worker_test_helper.cc | 2 +- content/common/renderer.mojom | 5 +-- content/renderer/render_frame_impl.cc | 39 +--------------------- content/renderer/render_thread_impl.cc | 3 +- content/renderer/render_thread_impl.h | 11 +----- 6 files changed, 6 insertions(+), 56 deletions(-) commit 43267a07945e7cb8b6b03737ce868a29f808eb0d Author: Marcin Wiącek <marcin@mwiacek.com> Date: Thu Mar 14 20:11:44 2019 +0000 Reland "Prepare Stack/StackAnimation (migration to CompositorAnimator, part 4)" This is a reland of 796a483c569238b18c611f7d77b9e4be5b83d5bd Original change's description: > Prepare Stack/StackAnimation (migration to CompositorAnimator, part 4) > > This is part of changes which put as goal removing redundant ChromeAnimation API by moving everything into CompositorAnimator. > > Public doc with proposal: https://docs.google.com/document/d/1VL5ntE7vn267IFjE4Zke0GkhVVTHz1bEP672Apj_E2k/edit > > This concrete patch is preparing Stack and StackAnimation by adding support for tab animations using AnimatorSet/CompositorAnimator. > > Notes: > > 1. both ChromeAnimation and CompositorAnimator will be supported until all patches from this series will be applied (until migration will be done) > > 2. in the onUpdateCompositorAnimations we're using AnimatorSet.isRunning() to detect if animation is still working (and if we want to complete it, we animatorSetFinished to true and immediately stop animation using finishAnimationsIfDone) > > BUG=890643 > > Change-Id: I5d698c729b9001554dc1c40636baae7016d02180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1395024 > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Matthew Jones <mdjones@chromium.org> > Reviewed-by: Changwan Ryu <changwan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638881} Bug: 890643, 940831 Change-Id: Ic96d6a3a4e053c4bbb712d1dcf8b9ce889d92e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518522 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#640895} .../compositor/layouts/phone/stack/Stack.java | 84 ++++++++++++++++------ .../layouts/phone/stack/StackAnimation.java | 30 +++++++- .../src/org/chromium/chrome/browser/TabsTest.java | 1 - 3 files changed, 91 insertions(+), 24 deletions(-) commit c1207fcbd9065e639203b335eb5ab3ab10eb5538 Author: Chris Hamilton <chrisha@chromium.org> Date: Thu Mar 14 20:08:38 2019 +0000 [PM] Retire kNetworkAlmostIdle property. This retires the kNetworkAlmostIdle from the frame node as part of the refactor that aims to get rid of the "bag of properties" from node impls. BUG=910288 Change-Id: I78b7d0f03cc23b91122328d1b7eab4b1f09a3176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520701 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Auto-Submit: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#640894} .../decorators/page_almost_idle_decorator.cc | 20 ++++++-------------- .../decorators/page_almost_idle_decorator.h | 5 +---- .../page_almost_idle_decorator_test_utils.cc | 4 +--- .../performance_manager/graph/frame_node_impl.cc | 7 ++++--- .../performance_manager/graph/frame_node_impl.h | 4 ++++ chrome/browser/performance_manager/graph/node_base.h | 16 ++++++++++++++++ .../performance_manager/graph/page_node_impl.cc | 14 ++++---------- .../observers/coordination_unit_graph_observer.h | 4 ++++ .../resource_coordinator/public/mojom/signals.mojom | 3 --- 9 files changed, 40 insertions(+), 37 deletions(-) commit 40014e7209c57bcb42f3bc67c25d729e8315972c Author: siashah <siashah@chromium.org> Date: Thu Mar 14 20:07:37 2019 +0000 Remove validation logic from ExpirationDateFixFlowPrompt, since it is already moved to AutofillUiUtils Bug: 941807 Change-Id: I1b4be7fedfbd5b99b8e52ee2dd92cda6d6704443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522331 Auto-Submit: Siddharth Shah <siashah@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#640893} .../AutofillExpirationDateFixFlowPrompt.java | 39 ++-------------------- 1 file changed, 2 insertions(+), 37 deletions(-) commit 54b17c7e812cd7c961abb45b4f8bcc7e2b1bbe43 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Mar 14 20:07:21 2019 +0000 [BGPT] Let cc initialize animation states in property nodes In this way, blink::PropertyTreeManager no longer needs to care about the animation states. Now we initialize and change the states from a single source to avoid duplicate code and inconsistency. Bug: 935770 Change-Id: I7f98d66677f557213fd4559895e9c2069de196e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513922 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640892} cc/animation/animation_host.cc | 5 + cc/animation/animation_host.h | 2 + cc/animation/element_animations.cc | 8 + cc/animation/element_animations.h | 7 + cc/trees/mutator_host.h | 2 + .../core/animation/compositor_animations.h | 12 -- .../core/animation/compositor_animations_test.cc | 214 +++++++++++++-------- .../renderer/core/paint/link_highlight_impl.cc | 8 +- .../compositing/paint_artifact_compositor.cc | 5 + .../compositing/paint_artifact_compositor_test.cc | 30 ++- .../graphics/compositing/property_tree_manager.cc | 16 -- 11 files changed, 176 insertions(+), 133 deletions(-) commit 2caaf068adc04741a9818afe6eb3bf7dad897154 Author: Sammie Quon <sammiequon@google.com> Date: Thu Mar 14 20:05:41 2019 +0000 overview: Remove shield button. The shield button is not neccessary, the caption container view itself can handle the events and forward them to OverviewItem. Makes this class more reusable for non overview uses. Test: manual Bug: 914147, 914948 Change-Id: Iec166629d800dc9d2646f9d91056097bc2a544fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499838 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#640891} ash/wm/overview/caption_container_view.cc | 245 ++++++++++++++---------------- ash/wm/overview/caption_container_view.h | 42 +++-- ash/wm/overview/overview_item.cc | 183 +++++++++++----------- ash/wm/overview/overview_item.h | 30 ++-- 4 files changed, 242 insertions(+), 258 deletions(-) commit d50caef9fcd83d2b112cff420e7986bbfaf28428 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 20:04:47 2019 +0000 Roll src/third_party/chromite 7a62eb7d2b04..0f6a92f63625 (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/7a62eb7d2b04..0f6a92f63625 git log 7a62eb7d2b04..0f6a92f63625 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-14 dhanyaganesh@chromium.org GetBuildMessages: Sanitize BuildIdentifiers before query 2019-03-14 dgarrett@google.com workspace_stages: Add step text for version synced. 2019-03-14 mikenichols@chromium.org chromeos_config: Update PFQ builds to use PFQ builder 2019-03-14 dhanyaganesh@chromium.org GetBuildStatuses: sanitize inputs to fix PreCQLauncher Created with: gclient setdep -r src/third_party/chromite@0f6a92f63625 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iffe2e4a0227b007271c1a106a66e4813f47c78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524374 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640890} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0e9ad4e93bec5760b73e6a66fe904c29083be81c Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Mar 14 20:03:47 2019 +0000 Move IsOriginSecure from //content/public to //services/network/public. This CL moves the code behind content::IsOriginSecure from //content/common/origin_util.cc into //services/network/public/cpp. Having this functionality in the //services/network layer will help develop //services/network features (like Sec-Fetch-Site header) which can't depend on //content layer. content::IsOriginSecure after this CL mostly just forwards the calls to the new network::IsUrlPotentiallyTrustworthy: *) Behavior of blob: and data: URLs is preserved to minimize changes in this CL. These schemes will be made spec-compliant in follow-up CLs (the new network::IsUrlPotentiallyTrustworthy already agrees with the spec). *) url::GetLocalSchemes are now considered secure (for consistency with content::IsPotentiallyTrustworthyOrigin). By default this only covers file: URLs, but //chrome layer also adds externalfile: scheme on CrOS and content: scheme on Android. *) There are no other intended changes in behavior (unit tests have been added for about:, blob:, data: and javascript: URLs). content::IsPotentiallyTrustworthyOrigin after this CL just forwards the calls to the new network::IsOriginPotentiallyTrustworthy: *) data: URLs behave the same (are considered insecure) before and after the CL (since unique |origin| would be considered insecure before this CL + it would also be caught by url::GetNoAccessSchemes check). *) Note that removing url::GetNoAccessSchemes check doesn't change any behavior, because such schemes result in opaque origins. *) Overall there are no intended changes in behavior (unit tests have been added for about:, data: and javascript: URLs). Bug: 937451 Change-Id: I6be8b9c7a0197fa64e1574f250964732d704fb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492935 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#640889} content/common/origin_util.cc | 59 ++++--------- content/common/origin_util_unittest.cc | 38 ++++++++- content/public/common/origin_util.h | 6 ++ ios/web/public/origin_util.mm | 4 + .../public/cpp/is_potentially_trustworthy.cc | 87 ++++++++++++++++++++ .../public/cpp/is_potentially_trustworthy.h | 12 +++ .../cpp/is_potentially_trustworthy_unittest.cc | 96 +++++++++++++++++----- .../renderer/platform/weborigin/security_origin.cc | 7 ++ 8 files changed, 246 insertions(+), 63 deletions(-) commit d499702fc9c08a1d43ec860af758f42ea0508435 Author: Nate Fischer <ntfschr@chromium.org> Date: Thu Mar 14 20:02:19 2019 +0000 NS: add flaky/failing tests to the filter No change to logic, this only disables tests for the Network Service bots. This disables WebApkIntegrationTest#testActivateWebApk and PaymentRequestUpdateWithTest#testUpdateWithShippingOptions, both of which fail fairly steadily on the android-mojo-webview-rel bot. R=timvolodine@chromium.org Bug: 941856, 941858 Test: N/A Change-Id: I6a079cfd0d319200b56564e273bba4c1f180e086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522556 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#640888} .../filters/mojo.fyi.network_chrome_public_test_apk.filter | 7 +++++++ 1 file changed, 7 insertions(+) commit 6f1dcf52ba3b154baac1e07ec0867f5d1bdfd601 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 14 20:00:13 2019 +0000 Migrate Safe Cases to OnceClosure/RepeatingClosure BUG=714018,940130 TBR=sky@chromium.org Change-Id: I5d7b5258637e83fceeb03a57e64905bc262d7bd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521975 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640887} ui/views/controls/scroll_view_unittest.cc | 2 +- ui/views/mus/desktop_window_tree_host_mus.cc | 4 ++-- ui/views/test/x11_property_change_waiter.cc | 4 +++- ui/views/test/x11_property_change_waiter.h | 2 +- .../widget/desktop_aura/desktop_native_widget_aura_unittest.cc | 10 ++++------ ui/views/widget/desktop_aura/x11_whole_screen_move_loop.cc | 2 +- ui/views/widget/desktop_aura/x11_whole_screen_move_loop.h | 2 +- 7 files changed, 13 insertions(+), 13 deletions(-) commit eb401f6d8e37c58407b23d95d589fc174cfad3dd Author: Evan Stade <estade@chromium.org> Date: Thu Mar 14 19:57:06 2019 +0000 Relay kAvatarIcon from browser process to Ash. This fixes the appearance of avatar icon on files app. Also, don't set kAvatarIconKey on browser windows, since it's ignored anyway. This should save a little memory (storing the image) and computation (creating the masked image). Bug: 940730 Change-Id: I3898070673eb719e9dbde20a2b0de1d8fab1d4ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519333 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#640886} .../multi_user/multi_user_window_manager_client_impl.cc | 10 +++++++--- .../multi_user_window_manager_client_impl_unittest.cc | 17 ++++++++++++----- services/ws/public/mojom/window_manager.mojom | 3 +++ ui/aura/mus/property_converter.cc | 2 ++ 4 files changed, 24 insertions(+), 8 deletions(-) commit f2f97e0dfb51b94a91138984f8a265426c2da800 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 14 19:52:42 2019 +0000 Update V8 to version 7.5.44. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/72287902..7677b798 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I77ab6d2edc4e22401631762587f610b4ac03b7d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524410 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640885} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0bd10e13a008389ec14bbe7cc95f17d82ea151c1 Author: Roger McFarlane <rogerm@chromium.org> Date: Thu Mar 14 19:50:30 2019 +0000 [autofill] Pin preview font-family to a system font Bug: 916838 Change-Id: I4e874105262f2e15a11a7a18a7afd204e5827400 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1423109 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#640884} chrome/renderer/autofill/form_autofill_browsertest.cc | 16 ++++++++++++++++ third_party/blink/renderer/core/html/resources/html.css | 10 ++++++++-- 2 files changed, 24 insertions(+), 2 deletions(-) commit a4a4c31a74c3541075a70ed60a984bf28cac4d34 Author: Edwin Joe <ejoe@google.com> Date: Thu Mar 14 19:47:32 2019 +0000 Added new UMA to track the entirety of tab switching duration. Created a new class TabSwitchTimeRecorder that tracks tab switching duration from the input event timestamp until the frame is presented on the screen. The the data will be uploaded on an UMA called Browser.Tabs.TotalSwitchDuration.(WithSavedFrames|NoSavedFrames), depending on whether we have saved frames when we switch to the tab. Also merged the MPArch.RWH_TabSwitchPaintDuration metric tracking with this new class, and removed the old callback creator for the MPArch.RWH_TabSwitchPaintDuration metric. Combining the MPArch.RWH_TabSwitchPaintDuration metric with this class addresses the issue with that metric where sometimes the callback is not fired on a tab switch, uploading wrong metric. See crbug/936858. With this new UMA, we have data for the different stages on tab switch: 1. From input event timestamp to when the TabStripModel starts processing it (Browser.Tabs.InputEventToSelectionTime) 2. From when the TabStripModel starts processing tab switch until when the visibility request is sent by the Browser to the Renderer (Browser.Tabs.SelectionToVisibilityRequestTime) 3. From when the visibility request is sent until the frame presentation time (MPArch.RWH_TabSwitchPaintDuration) 4. The overall/total time (Browser.Tabs.TotalSwitchDuration) Bug:921120 Change-Id: I72edae19bd885f4bae0bc9aab6e78bb221422a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494935 Commit-Queue: Edwin Joe <ejoe@google.com> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#640883} chrome/browser/ui/tabs/tab_strip_model.cc | 13 ++- .../ui/tabs/tab_switch_event_latency_recorder.h | 4 + .../browser/renderer_host/delegated_frame_host.cc | 11 ++- .../browser/renderer_host/delegated_frame_host.h | 7 +- .../renderer_host/render_widget_host_impl.cc | 5 +- .../renderer_host/render_widget_host_impl.h | 3 +- .../renderer_host/render_widget_host_view_aura.cc | 7 +- .../renderer_host/render_widget_host_view_base.cc | 11 +++ .../renderer_host/render_widget_host_view_base.h | 11 +++ ...der_widget_host_view_child_frame_browsertest.cc | 3 +- .../renderer_host/render_widget_host_view_mac.mm | 8 +- content/common/BUILD.gn | 4 +- content/common/tab_switch_time_recorder.cc | 68 ++++++++++++++ content/common/tab_switch_time_recorder.h | 55 +++++++++++ .../common/tab_switch_time_recorder_unittest.cc | 104 +++++++++++++++++++++ content/common/tab_switching_time_callback.cc | 32 ------- content/common/tab_switching_time_callback.h | 22 ----- content/common/widget_messages.h | 5 +- content/public/browser/render_widget_host_view.h | 4 + content/renderer/render_frame_impl_browsertest.cc | 10 +- content/renderer/render_widget.cc | 8 +- content/renderer/render_widget.h | 8 +- content/test/BUILD.gn | 1 + tools/metrics/histograms/histograms.xml | 24 +++++ 24 files changed, 347 insertions(+), 81 deletions(-) commit 0bbcb6ba68246c9c4bee24fcea9c9d0497fca839 Author: Rohit Rao <rohitrao@chromium.org> Date: Thu Mar 14 19:42:32 2019 +0000 Roll src/ios/third_party/edo/src/ 4ec31ccbe..0146bd6e1 (72 commits) https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/4ec31ccbe1e0..0146bd6e1f05 $ git log 4ec31ccbe..0146bd6e1 --date=short --no-merges --format='%ad %ae %s' 2019-03-12 ynzhang Removing unnecessary log. 2019-03-11 haowoo Clean up the executor after the test finishes. 2019-03-11 ynzhang Add missing semaphore wait for connector. 2019-03-11 ynzhang Minor refactoring and some extra comments for implementation. 2019-03-08 ynzhang Use dispatch_after instead of CFRunloop since CFRunloop in background thread does not have a timer or source. 2019-03-07 ynzhang Fix the return logic of register service on device. 2019-03-06 ynzhang Use NSLog instead of NSAssert to avoid unused variable warning. 2019-03-06 ynzhang Optimize API for device support. 2019-03-04 ynzhang Add custom user info keys for device info of attachment/detachment notifications. 2019-02-27 ynzhang Update documents for API connectToDevice:onPort:error:. 2019-02-26 ynzhang Refactor DeviceLib into a separate target. 2019-02-15 haowoo Add more debugging info when sending request fails. 2019-02-14 haowoo Defer to request the hostPort. 2019-02-12 haowoo Invalidate the service after the test is done. 2019-02-11 rrallo Update README.md 2019-01-30 haowoo Fix the strong self reference when creating the listen socket. 2019-01-23 ynzhang Split the device channel creation method into a particular category. 2019-01-21 ynzhang Add a flag in the initializer to explicitly indicate device registration when starting host service, and update related log info. 2019-01-18 ynzhang Add device support for eDO. 2019-01-16 ynzhang Allow EDOSocketChannel to initialize with dispatch_io_t. 2019-01-16 haowoo Remove the unneeded test and rephrase the comment. 2019-01-15 haowoo Forward the -description of EDOObject. 2019-01-11 ynzhang Add device serial information to EDOObject from requests. 2019-01-09 haowoo Resolve EDOObject to the same ones for the same underlying objects in the arguments. 2019-01-08 ynzhang Extend EDOServicePort to include service name and device serial information. 2019-01-07 haowoo Increase test timeout to reduce flakiness on the slower machines. 2019-01-07 ynzhang Fix race condition of EDOChannelPool by always waiting before entering synchronization queue to update channels. 2019-01-04 ynzhang Updated channel pool fetch from async to sync, and added a semaphore for each host port to guarantee channel availability on creation. 2019-01-03 ynzhang Minor cleanup for EDOChannelPool by removing unnecessary check and making once token of service connection port an ivar. 2019-01-03 ynzhang Refactor EDOSocketChannel to extract frame header logic into a util file, and extend EDOHostNamingService to support service registration with name. 2019-01-02 ynzhang Minor cleanup for comments and code readability with moving content in EDOHostService invocation category to EDOHostService private category. 2019-01-01 ynzhang Refactor EDOHostService to extract requests receiving logic for reuse. 2018-12-27 ynzhang Rename sharedObject of EDOHostNamingService to sharedService to be consistent. 2018-12-25 ynzhang Added EDOHostNamingServiceObject to provide service ports information. 2018-12-17 ynzhang Refactoring for code clean up by removing redundant method and add extra #pragma. 2018-12-12 haowoo Add libMeasure dependency to libeDO. 2018-12-12 haowoo Add the client statistics for the connection, request, and response. 2018-12-10 haowoo Revert Xcode version. 2018-12-10 haowoo Fix the mismatched filename EDOServiceUtils. 2018-12-10 haowoo Refactor how to collect the response handling time spent. 2018-12-03 ynzhang Use EDOChannel protocol instead of EDOSocketChannel type in EDOSocketChannelPool to make it more generic. 2018-12-03 ynzhang Update the error log to be more readable. 2018-11-30 haowoo Add the measure support. 2018-11-28 ynzhang Add missing files to the Xcode project file. 2018-11-28 ynzhang Add optional device serial information in host port key. 2018-11-28 haowoo Calculate and save the time spent on handling a single request. 2018-11-19 haowoo Create the listen socket lazily if the object or port is not given. 2018-11-14 haowoo Add comment for unwrapping nullable objects. 2018-11-13 haowoo Create a temporary service when sending a remote request if needed. 2018-11-13 haowoo Move the send and receive data from EDOExecutor to EDOClientService. 2018-11-12 haowoo Remove the executor dependency on the channels. 2018-11-05 haowoo Use the correct return type to avoid memory corruption. 2018-11-02 haowoo Refactor EDOMessageQueue to handle the last message. 2018-10-31 haowoo Unwrap an object from EDOClientService. 2018-10-30 haowoo Resolve the outvar to be local whenever possible. 2018-10-26 haowoo Refactor the executor message to be able to wait on the response. 2018-10-26 ynzhang Add new files references into the Xcode proj file. 2018-10-26 ynzhang Make ping message optional when sending request. 2018-10-26 wuhao.wise Add email notifications for travis failures 2018-10-25 ynzhang Small fixes for comments and category name. 2018-10-25 ynzhang Exposed the public API for users to enable their custom class to be pass-by-value by default. 2018-10-23 wuhao.wise Marks EDOMessageQueue.empty readonly as it should be. 2018-10-22 wuhao.wise Refactor the message queue. 2018-10-22 wuhao.wise Fix the missing generic type. 2018-10-19 wuhao.wise Fix all missing NSSecureCoding support. 2018-10-19 wuhao.wise Expose API to retrieve the EDOHostService from a given queue. 2018-10-18 ynzhang Use value type for NSURL since it is immutable and implements NSCoding. 2018-10-15 wuhao.wise Turn off secureEncoding as there is an unexpected read error during decoding. 2018-10-15 wuhao.wise iOS 12 API deprecation and support NSSecureCoding. 2018-10-12 wuhao.wise Add -hash to EDOObject. 2018-10-11 wuhao.wise Revert replace the deprecated archiver and unarchiver's API's. 2018-10-11 wuhao.wise Replace the deprecated archiver and unarchiver's API's. Created with: roll-dep src/ios/third_party/edo/src Change-Id: I646df4dc83341e54b17231c2e0351626cb6e143a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523612 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640882} DEPS | 2 +- ios/third_party/edo/BUILD.gn | 33 +++++++++++++++++++++++++++++++-- 2 files changed, 32 insertions(+), 3 deletions(-) commit 52716f040edbda1b9f34cd86034b890f94fefe67 Author: gogerald <gogerald@google.com> Date: Thu Mar 14 19:41:48 2019 +0000 Correct comments Change-Id: I9c1f208a62d9b5bc5d6934151dc8fb2e29010c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504502 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#640881} base/android/java/src/org/chromium/base/LocaleUtils.java | 4 ++-- components/autofill_assistant/browser/service.proto | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 6b4ebb33e10af81bdf2cc70503c5488cfad03259 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 14 19:41:28 2019 +0000 Format notification timestamps in the future. This formats timestamps in the future the same way as Android is formatting them. Example: "in 5m" for a notification set in 5 minutes. Bug: 914432 Change-Id: Ibb73f5d999defa2f1b9aa347dd1d368de1867766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523398 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#640880} ui/message_center/BUILD.gn | 4 + .../views/notification_header_view.cc | 43 +----- ui/message_center/views/notification_header_view.h | 7 +- ui/message_center/views/timestamp_view.cc | 71 +++++++++ ui/message_center/views/timestamp_view.h | 29 ++++ ui/message_center/views/timestamp_view_unittest.cc | 167 +++++++++++++++++++++ ui/strings/ui_strings.grd | 12 ++ 7 files changed, 291 insertions(+), 42 deletions(-) commit 7f76ee2a984b8e6172c2a5669ee2c8285eb2b9e1 Author: Robert Liao <robliao@chromium.org> Date: Thu Mar 14 19:40:41 2019 +0000 Remove Unimplemented Method views::MenuController::RunMessageLoop() BUG=940130 TBR=sky@chromium.org Change-Id: I67dfc7c6e63bfec3667a4ccaf03938b6342d4e23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524091 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#640879} ui/views/controls/menu/menu_controller.h | 3 --- 1 file changed, 3 deletions(-) commit c4756c3b2567d902e33e0cfeed32042b2074f3da Author: Brian Sheedy <bsheedy@chromium.org> Date: Thu Mar 14 19:36:57 2019 +0000 Disable WebVR focus lock test on K/M WebXrVrInputTest#testPresentationLocksFocus has been flaky on K and M for a while now. The root cause is somewhat known, but hard to reproduce or get additional information out of. Since WebVR is on its way out anyways, disable the test on the affected OSes (WebXR version is still enabled everywhere). Bug: 897259 Change-Id: I628c768bb96f102cbbb49a9f845ff3ddbeb07363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524683 Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#640878} .../javatests/src/org/chromium/chrome/browser/vr/WebXrVrInputTest.java | 2 ++ 1 file changed, 2 insertions(+) commit f806b39f96a038eb5f53a5a7257a8e9504b1dc53 Author: John Budorick <jbudorick@chromium.org> Date: Thu Mar 14 19:36:09 2019 +0000 Mark virtual/exotic-color-space/images/feature-policy-oversized-images.html as failing on win. Bug: 942134 Change-Id: I3e98985b4986d2c4302450c91eae1f1ab08a2026 Tbr: anthonyvd@chromium.org,futhark@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524094 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640877} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 3de509f46d4132a11af22e8f44d44ac1954bdcc5 Author: Travis Skare <skare@chromium.org> Date: Thu Mar 14 19:35:48 2019 +0000 Allow searching for "javascript:foo" if foo is likely not code where "likely not code" = [^;=().]* Bug: 31661 Change-Id: Ib5286b844b7d88c43bb377eb172e9a109f3d35cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513096 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Travis Skare <skare@chromium.org> Cr-Commit-Position: refs/heads/master@{#640876} components/omnibox/browser/autocomplete_input.cc | 7 +++++++ components/omnibox/browser/autocomplete_input_unittest.cc | 9 +++++++++ 2 files changed, 16 insertions(+) commit 1261081fc2a0e703c19832eda2b263757d8d3609 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 19:24:29 2019 +0000 Roll src/third_party/catapult 1a088f27008b..44a43fd4ffa9 (1 commits) https://chromium.googlesource.com/catapult.git/+log/1a088f27008b..44a43fd4ffa9 git log 1a088f27008b..44a43fd4ffa9 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 khokhlov@google.com Pass possible_browser to shared state constructor Created with: gclient setdep -r src/third_party/catapult@44a43fd4ffa9 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:939374 TBR=sullivan@chromium.org Change-Id: I18feb03e634f182d4f35d141c9a81943f2a4ac0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524364 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640875} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6eba93c0d038333092d0f9f4855c024250aa10f0 Author: Khushal <khushalsagar@chromium.org> Date: Thu Mar 14 19:23:50 2019 +0000 gpu/android: Support native GpuMemoryBuffers for BGR_565 format. R=piman@chromium.org Bug: 889328 Change-Id: I9db78b07b5e067ecc3303decc9c3588ba7b55350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522340 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#640874} gpu/ipc/common/gpu_memory_buffer_support.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit c7933dd73e5c01f755a431170a70cdec7d88b4be Author: Jonathan Backer <backer@chromium.org> Date: Thu Mar 14 19:22:00 2019 +0000 Generate unique texture IDs with GLStubApi Only consumers of GLStubApi are GpuChannelTestCommon (gpu_unittests) and GPU fuzzers. We get a new GLStubApi for every case executed by fuzzer_main.cc, so we don't have to worry about ID exhaustion. Bug: 939873 Change-Id: I335c4d9b0c340af62c8e90013669259a0226deef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518893 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#640873} ui/gl/gl_stub_api.cc | 9 --------- ui/gl/gl_stub_api.h | 9 +++++++++ 2 files changed, 9 insertions(+), 9 deletions(-) commit 195f1eed34ae4eba1c6f9d8c76a1e47253762e94 Author: Raymond Toy <rtoy@chromium.org> Date: Thu Mar 14 19:20:34 2019 +0000 Gather statistics for AudioContextOptions.sampleRate Record the selected sample rate along with the ratio between that and the HW sample rate. The selected rate will tell us what rate is mostly commonly used. The ratio will allow us to find the most commonly used ratios so we can potentially optimize the resampler for those cases. Also fix the WebAudio.AudioContext.HardwareSampleRate histogram which is recording the context rate instead of the HW rate. We really want the HW rate. Bug: 939848 Change-Id: I4630c52bdf59a8c02456d1e10f25815f83bca8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511916 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640872} .../renderer/modules/webaudio/audio_context.cc | 3 --- .../renderer/platform/audio/audio_destination.cc | 30 +++++++++++++++++++++- tools/metrics/histograms/histograms.xml | 22 ++++++++++++++++ 3 files changed, 51 insertions(+), 4 deletions(-) commit e36870121d2cc32edc8a7be4491d125804441d03 Author: Geoff Lang <geofflang@chromium.org> Date: Thu Mar 14 19:17:31 2019 +0000 Mark webgl-to-canvas tests as failing on all Vulkan drivers. Previously these were just failing on NVIDIA but we've seen failures on AMD now too. TBR=kbr@chromium.org NOTRY=true BUG=angleproject:2918 Change-Id: I6a22692fc46fdc9ecde7e744a0f3855cb85f587c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524689 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Auto-Submit: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#640871} content/test/gpu/gpu_tests/webgl_conformance_expectations.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit e9c45cc3b3cc964fd9feb1805d030f3a918ac76a Author: Michael Spang <spang@chromium.org> Date: Thu Mar 14 19:17:21 2019 +0000 chromecast: Move locales to data_deps Move locale paks to data_deps so we can use GN to get a list of them along with any other runtime dependencies. Test: gn gen out/chromecast --args='is_chromecast=true'; \ gn desc out/chromecast //chromecast:cast_shell runtime_deps Bug: b/128440739 Change-Id: I5fbfc7d8511c916c46bd256dd92e52721e34369a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519169 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#640870} chromecast/BUILD.gn | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 32bac7bf27395aaa7dbbe1d4269dacfe75665451 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 19:12:12 2019 +0000 Roll src/third_party/skia 44c8131b779b..a4323d71424f (7 commits) https://skia.googlesource.com/skia.git/+log/44c8131b779b..a4323d71424f git log 44c8131b779b..a4323d71424f --date=short --no-merges --format='%ad %ae %s' 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader eb7cf3c4b0b1..af973b67141e (2 commits) 2019-03-14 michaelludwig@google.com Reland "Update SkCanvas' experimental SkiaRenderer API" 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader ca56e8b07a1a..eb7cf3c4b0b1 (1 commits) 2019-03-14 reed@google.com Use '&' to toggle showing the gm's size in viewer 2019-03-14 mtklein@google.com move in center of radial_gradient_precision 2019-03-14 bsalomon@google.com Update color type after color override in GrFillRectOp. 2019-03-14 jvanverth@google.com Set RG_float to be texturable on Metal Created with: gclient setdep -r src/third_party/skia@a4323d71424f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Iabb44202697b1432badcbf5b976f8ae1dec2bafa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524369 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640869} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2e04a95b13e3ee0ade1152c87c25ed3e22595194 Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Mar 14 19:11:21 2019 +0000 Update UI layer API for rounded corner and fast rounded corner This patch adds an API for fast rounded corner on UI layers which tries to optimize for performance at the cost of quality. The patch also updates the rounded corner to work with clones and mirror layers while also working with different layer types. Updated respective unittests. Bug: 903486 Change-Id: I1e5e45cb32f4cf9dd327df598074d382ce5d6bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522344 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#640868} ui/compositor/layer.cc | 15 +++++++++++++++ ui/compositor/layer.h | 8 ++++++++ ui/compositor/layer_unittest.cc | 35 +++++++++++++++++++++++++++++++++++ 3 files changed, 58 insertions(+) commit 7685997cda6b42c79ec814ae267979adac6d93da Author: Lowell Manners <lowell@chromium.org> Date: Thu Mar 14 19:11:06 2019 +0000 Remove unused GetAccountInfoFromGaiaId method. The last reference to this method was deleted in https://crrev.com/c/1458301. Bug: 933109 Change-Id: Ic490527d37387753339e82ec91f7ebce414cd71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520680 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#640867} chromeos/services/assistant/service_unittest.cc | 3 - services/identity/identity_accessor_impl.cc | 8 -- services/identity/identity_accessor_impl.h | 3 - .../identity/identity_accessor_impl_unittest.cc | 91 +--------------------- .../identity/public/mojom/identity_accessor.mojom | 7 -- 5 files changed, 1 insertion(+), 111 deletions(-) commit a0e48542dcd07cc0e40ea568f8b8a9147d9d9965 Author: Ian Clelland <iclelland@chromium.org> Date: Thu Mar 14 19:10:10 2019 +0000 Allow null execution context in feature policy OT check The previous code, which simply returned 'disabled' when the execution context is null, prevents unit tests from parsing OT-gated features. Removing that check allows nullptr to be passed into the origin_trials methods, which will fall back to a runtime flag check. Bug: 941595 Change-Id: I183292bee591d9c48ff7d73e12e6b74da239e0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521033 Reviewed-by: Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#640866} third_party/blink/renderer/core/feature_policy/feature_policy.cc | 4 ---- 1 file changed, 4 deletions(-) commit 731910ad315fa6c5468bd850241627d6bd837a12 Author: Tomasz Śniatowski <tsniatowski@vewd.com> Date: Thu Mar 14 19:10:02 2019 +0000 Fix any_internal_unittest on some less common platforms The test as written assumed that sizeof(std::string) > sizeof(void*). The C++ standard doesn't appear to guarantee that, and on some platforms in some configurations the two sizes are in fact equal. This seems to be the case in some old ABI compatibility cases on gcc. Use a helper two-void-pointer struct instead of std::string to avoid confusing breakages. Bug: 906125 Change-Id: I47946fecf2317c16ac38b8395a48c5f87d25ffeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523396 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Tomasz Śniatowski <tsniatowski@vewd.com> Cr-Commit-Position: refs/heads/master@{#640865} base/containers/any_internal_unittest.cc | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) commit 5802b300e19a5facdace0df0566a25540e33dee0 Author: David Valleau <valleau@chromium.org> Date: Thu Mar 14 19:09:02 2019 +0000 Adding unit tests for LocalPrinterHandlerChromeos This change is adding unit tests for some of the functions in LocalPrinterHandlerChromeos with the intention of catching possible regressions earlier. For example http://crbug.com/921837 describes a bug which caused a crash in Chrome. In order to create these tests, some parts of the LocalPrinterHandlerChromeos has been refactored in order to allow for mocking some of the class dependencies. R=rbpotter@chromium.org, skau@chromium.org Bug: 922286 Change-Id: Icdd75eb097e69d0c20c8f3e220dd11a899333249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518449 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#640864} .../local_printer_handler_chromeos.cc | 81 ++++-- .../print_preview/local_printer_handler_chromeos.h | 22 +- .../local_printer_handler_chromeos_unittest.cc | 293 +++++++++++++++++++++ .../ui/webui/print_preview/printer_handler.cc | 4 +- chrome/test/BUILD.gn | 2 + 5 files changed, 374 insertions(+), 28 deletions(-) commit b1b3f0e866174acdcbbaecfe48b888513f3f4c9b Author: Salvador Guerrero <salg@google.com> Date: Thu Mar 14 19:08:59 2019 +0000 leveldb_proto: Added options and removed name from Init The new Init method used by the GetDB API has no way to specify leveldb Options, which is used by some clients, such as download_store to specify cache size. All Init methods receive a client_name, which is used to record UMA metrics, and the new GetDB API introduces a ProtoDbType Enum, which is used to identify every client and for the finch experiment that will be used to migrate the clients. This may cause some confusion, as there has to be two different strings set up for similar purposes (name for UMA metrics and name for finch experiment). This CL adds 2 new Init functions for the new API, these functions don't have a client_name parameter, instead they report UMA metrics using the name received from SharedProtoDatabaseClientList::ProtoTypeToString function. Init(callback) Initialize using default unique DB options. Init(unique_db_options, callback) Initialize using provided unique DB options, options will be ignored if a shared DB is used. The old Init(client_name, callback) still remains for compatibility purposes. Bug: 870813 Change-Id: If8f9571d9964ba36a402f0b6f7cbd235f9810f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519094 Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#640863} .../leveldb_proto/internal/proto_database_impl.h | 63 +++++++++++++++------- .../internal/proto_database_impl_unittest.cc | 55 ++++++++++++++----- .../internal/proto_database_selector.cc | 17 ++++-- .../internal/proto_database_selector.h | 2 +- .../shared_proto_database_client_list_unittest.cc | 8 +-- components/leveldb_proto/public/proto_database.h | 23 ++++++-- .../public/shared_proto_database_client_list.cc | 43 ++++++++------- .../public/shared_proto_database_client_list.h | 5 ++ components/leveldb_proto/testing/fake_db.h | 14 +++++ 9 files changed, 162 insertions(+), 68 deletions(-) commit 5cef02b5fd2a3b96b3e2d79f3a696541abb00c0c Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Thu Mar 14 19:01:37 2019 +0000 UsbServiceLinux: Remove outdated comment UsbServiceLinux::BlockingTaskHelper::Start() hasn't been static since 2016's 3b9a7a6338 ("Remove DeviceMonitorLinux::WillDestroyCurrentMessageLoop()"). Change-Id: Ifc3112b5e63a3ca751ba85bbc92a1b8d1d70c0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524043 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#640862} device/usb/usb_service_linux.cc | 1 - 1 file changed, 1 deletion(-) commit 0f5a047f130a221e028dac09a65441075d8d2ec7 Author: George Burgess IV <gbiv@chromium.org> Date: Thu Mar 14 19:01:08 2019 +0000 Revert to chromeos-chrome-amd64-74.0.3725.0_rc-r1-merged Our source for these profiles is currently having issues. To minimize the impact of this, I'm kicking us back to our 3725 profile. The autoroller has been stopped, as well. TBR=sullivan@chromium.org Bug: chromium:942050 Change-Id: Iecaac82ceef8bba9859d8d08aeae2a4b994c5952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524684 Reviewed-by: George Burgess <gbiv@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#640861} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 549922da7022990688f77d79cdd1cf2b89fe1dc1 Author: Theresa <twellington@chromium.org> Date: Thu Mar 14 18:55:33 2019 +0000 [Dark] Paint the bottom system nav black in dark mode BUG=934490 Change-Id: Iad68306ebc8c5f723b2932cca58a47eb84cea07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519286 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#640860} chrome/android/java/res/values-v27/styles.xml | 8 ++++---- chrome/android/java/res/values/values.xml | 3 +++ chrome/android/java/res_night/values-night/colors.xml | 5 ++++- chrome/android/java/res_night/values-night/values.xml | 10 ++++++++++ 4 files changed, 21 insertions(+), 5 deletions(-) commit 2465d5f2e95e6fcd5622172bb104b5d278f2fd87 Author: mrefaat <mrefaat@chromium.org> Date: Thu Mar 14 18:54:43 2019 +0000 Create OverscrollActionsTabHelper and move logic from Tab to it. Observe webState to implement webStateDestroyed. Add Unit tests for overscroll_actions_tab_helper. Bug: 902082, 902079 Change-Id: Ia54c352186175d128d2916dc18809e146ccc3cce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507212 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#640859} ios/chrome/browser/overscroll_actions/BUILD.gn | 42 +++++++ .../overscroll_actions_tab_helper.h | 60 +++++++++ .../overscroll_actions_tab_helper.mm | 68 +++++++++++ .../overscroll_actions_tab_helper_unittest.mm | 135 +++++++++++++++++++++ ios/chrome/browser/tabs/BUILD.gn | 1 + ios/chrome/browser/tabs/tab.h | 10 -- ios/chrome/browser/tabs/tab.mm | 40 ------ ios/chrome/browser/tabs/tab_helper_util.mm | 2 + ios/chrome/browser/ui/BUILD.gn | 1 + ios/chrome/browser/ui/browser_view_controller.mm | 12 +- .../overscroll_actions/overscroll_actions_view.h | 9 ++ .../overscroll_actions/overscroll_actions_view.mm | 23 ++-- ios/chrome/test/BUILD.gn | 1 + ios/chrome/test/fakes/BUILD.gn | 3 + .../fake_overscroll_actions_controller_delegate.h | 28 +++++ .../fake_overscroll_actions_controller_delegate.mm | 47 +++++++ 16 files changed, 417 insertions(+), 65 deletions(-) commit bd3060e96e6bcc6aa4f6a5016b9a1fb5a248e59e Author: Sergey Ulanov <sergeyu@chromium.org> Date: Thu Mar 14 18:51:17 2019 +0000 Revert "[Fuchsia] Replace GetHandleFromFile() with OpenDirectory()" This reverts commit 365a08b1cccfae2c49f1f20d182f2125216073f3. Reason for revert: Many tests started flaking. Original change's description: > [Fuchsia] Replace GetHandleFromFile() with OpenDirectory() > > GetHandleFromFile() was used only to open directories. Replaced it with > OpenDirectory() which: > 1. Open the specified path instead of taking base::File. All > GetHandleFromFile were already calling base::File() anyway. > 2. Returns InterfaceHandle<fuchsia::io::Directory> which is more > type-safe. > > Change-Id: I7a1edbf4a0908e9a599bf30d9b12d917a8769356 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512653 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640675} TBR=wez@chromium.org,sergeyu@chromium.org Change-Id: I28c25f7cdea8169933fa06fd763a90e7f7c0e754 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524862 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640858} base/BUILD.gn | 1 - base/fuchsia/file_utils.cc | 41 ++++++++++------------ base/fuchsia/file_utils.h | 18 ++++++---- base/fuchsia/file_utils_unittest.cc | 44 ------------------------ base/fuchsia/service_directory_client.cc | 12 +++++-- base/process/launch_fuchsia.cc | 9 +++-- base/process/process_util_unittest.cc | 21 ++++++----- base/test/launcher/test_launcher.cc | 13 ++++--- fuchsia/engine/context_provider_impl_unittest.cc | 15 ++++++-- fuchsia/runners/common/web_content_runner.cc | 14 ++++---- 10 files changed, 84 insertions(+), 104 deletions(-) commit 489ec3c4b0c9ef4b466ea7ec696c0cc21828a26f Author: Chris Hamilton <chrisha@chromium.org> Date: Thu Mar 14 18:47:06 2019 +0000 [PM] Create NodeAttachedData base class. This creates strongly typed helpers for associating user data with nodes in the node graph. The data is centrally hosted in a single map owned by the graph, and automatically cleaned up when nodes are removed. Alternatively, storage can be provided directly in a node without the node implementation having to know about the data types. Change-Id: I90c662d251e926acb10c6ea65c2a6197bc0239df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490439 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#640857} chrome/browser/BUILD.gn | 3 + .../performance_manager/graph/frame_node_impl.h | 2 +- chrome/browser/performance_manager/graph/graph.cc | 24 ++ chrome/browser/performance_manager/graph/graph.h | 16 + .../graph/node_attached_data.cc | 62 +++ .../performance_manager/graph/node_attached_data.h | 109 ++++++ .../graph/node_attached_data_impl.h | 432 +++++++++++++++++++++ .../graph/node_attached_data_unittest.cc | 307 +++++++++++++++ .../performance_manager/graph/page_node_impl.h | 2 +- .../performance_manager/graph/process_node_impl.h | 2 +- .../performance_manager/graph/system_node_impl.h | 2 +- chrome/test/BUILD.gn | 1 + 12 files changed, 958 insertions(+), 4 deletions(-) commit 10d9e15652aec80dc8444b4a0683c1fbc826f3c9 Author: Lei Zhang <thestig@chromium.org> Date: Thu Mar 14 18:46:02 2019 +0000 Remove base::win::OSInfo::architecture(). Use GetArchitecture() instead. TBR=bbudge@chromium.org,piman@chromium.org Change-Id: Idaa14b959ee0d0d77c33b04e7af0d06889040f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521311 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#640856} base/base_paths_win.cc | 3 +-- base/win/windows_version.h | 2 -- chrome/browser/conflicts/installed_applications_win.cc | 2 +- chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc | 4 ++-- .../safe_browsing/chrome_cleaner/srt_field_trial_win_unittest.cc | 6 +++--- chrome/browser/ui/webui/nacl_ui.cc | 2 +- chrome/chrome_cleaner/http/http_agent_impl.cc | 2 +- chrome/chrome_cleaner/os/disk_util.cc | 2 +- chrome/chrome_cleaner/os/disk_util_unittest.cc | 2 +- chrome/chrome_cleaner/os/system_util.cc | 2 +- chrome/install_static/product_install_details_unittest.cc | 2 +- chrome/test/nacl/nacl_browsertest.cc | 6 +++--- cloud_print/virtual_driver/win/virtual_driver_helpers.cc | 2 +- components/nacl/renderer/platform_info.cc | 2 +- content/browser/tracing/tracing_controller_impl.cc | 2 +- content/common/user_agent.cc | 2 +- 16 files changed, 20 insertions(+), 23 deletions(-) commit 66898c52b38c4a437e819f4f0d187620f9b4a92e Author: Bo Liu <boliu@chromium.org> Date: Thu Mar 14 18:45:59 2019 +0000 Viewport for tile priority should not grow viewport Change LayerFreeFrameSinkClient viewport to be in view (ie root layer) space and update comment. Move the code to compute the viewport in view space to browser_view_renderer so it can be intersected with the regular viewport. Bug: 940083 Change-Id: If7fb829894409c0e55162e61218b63586f1f2044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516152 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640855} .../browser/gfx/browser_view_renderer.cc | 37 +++++++++++++++++++-- cc/layers/picture_layer_impl_unittest.cc | 38 ++++++---------------- cc/trees/layer_tree_frame_sink_client.h | 2 ++ cc/trees/layer_tree_host_impl.cc | 15 ++------- 4 files changed, 48 insertions(+), 44 deletions(-) commit d37de0b82ab8cacc9fa12c743d81f16ab90bf47b Author: Cathy Li <chili@chromium.org> Date: Thu Mar 14 18:42:14 2019 +0000 [ExploreSites][Touchless]: Add basic carousel scaffolding for most likely tiles. Bug: 936050 Change-Id: If2a65123c04caa97a4777bfcde3e47f097bb7835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508575 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640854} chrome/android/java_sources.gni | 3 + .../java/res/layout/most_likely_touchless.xml | 27 ++++++++ .../java/res/layout/new_tab_page_touchless.xml | 3 +- .../browser/touchless/SiteSuggestionsAdapter.java | 64 ++++++++++++++++++ .../touchless/SiteSuggestionsController.java | 75 ++++++++++++++++++++++ .../SiteSuggestionsViewHolderFactory.java | 35 ++++++++++ 6 files changed, 206 insertions(+), 1 deletion(-) commit 84017e9fb7df521970fe534c75ac1926392c1ce6 Author: Yuke Liao <liaoyuke@chromium.org> Date: Thu Mar 14 18:33:25 2019 +0000 [code coverage] import jinja2 from third_party An user reported that running coverage_test.py fails due to missing jinja2, this CL fixes the problem by importing it from third_party/. Bug: 941573 Change-Id: I1efdd45424668fcd46b091eccde484fdf81ecaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521795 Reviewed-by: Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640853} tools/code_coverage/coverage_test.py | 8 ++++++++ 1 file changed, 8 insertions(+) commit 2d7469d701e2820f3a3e8b39662819efd3ba8b32 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 14 18:30:14 2019 +0000 Roll src-internal dd52ff0514b0..eae9be8ac5e0 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd52ff0514b0..eae9be8ac5e0 Created with: gclient setdep -r src-internal@eae9be8ac5e0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:915409,chromium:891734 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I5ca1e6321f357c2fd4dc24886f0ee0726b514150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524365 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640852} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit db7beeb35a308947e19e7f552a7d2e1c5ef1dd5d Author: Patrick Monette <pmonette@chromium.org> Date: Thu Mar 14 18:29:52 2019 +0000 Batch module load events between the browser process its children This will reduce the number of IPC calls made between each process type significantly (from 100~ to 1 or 2 on average). Bug: 662084 Change-Id: I6bb347f5558a7ff9c1078a08664725b981811d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521227 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#640851} .../conflicts/module_event_sink_impl_win.cc | 20 +++++++----- .../browser/conflicts/module_event_sink_impl_win.h | 5 ++- .../module_event_sink_impl_win_unittest.cc | 17 ++++++++-- .../common/conflicts/module_event_sink_win.mojom | 8 ++--- .../common/conflicts/remote_module_watcher_win.cc | 23 ++++++++++++-- .../common/conflicts/remote_module_watcher_win.h | 19 ++++++++++++ .../remote_module_watcher_win_unittest.cc | 36 +++++++++++++++------- 7 files changed, 100 insertions(+), 28 deletions(-) commit 0f0d658417e22f4ad5faaad44d795cc0427ea041 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Mar 14 18:27:36 2019 +0000 Remove moar unnecessary Create methods in modules/filesystem classes ... in favor of calling their ctor directly. cAnother driven by CL part of effort to clean up Callback classes in t_p/blink/renderer/modules/filesystem/. As advised in [1], the CL removes trivial Create / factory methods, in favor of public ctors. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ R=mek@chromium.org CC=​bink-reviews-vendor@chromium.org,gyuyoung@igalia.com BUG=939691,933878 Change-Id: I5d56677046096bfd5449c1945c03dceb3abba059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524301 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#640850} .../blink/renderer/modules/filesystem/directory_entry_sync.cc | 6 +++--- .../blink/renderer/modules/filesystem/dom_file_system_sync.cc | 3 +-- third_party/blink/renderer/modules/filesystem/entry_sync.cc | 9 ++++----- .../blink/renderer/modules/filesystem/sync_callback_helper.h | 4 ---- .../modules/filesystem/worker_global_scope_file_system.cc | 5 ++--- 5 files changed, 10 insertions(+), 17 deletions(-) commit 1cc0adc40ab14d232b079ec47c5d385ce2afbe53 Author: Mustaq Ahmed <mustaq@google.com> Date: Thu Mar 14 18:26:31 2019 +0000 Check activation transfer state synchronously for postMessage sender. Bug: 928838 Change-Id: I320d2669905f141910bb3bc490d79670c93a8e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523962 Reviewed-by: Lan Wei <lanwei@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#640849} ...ation-transfer-cross-origin-with-click.sub.tentative.html | 12 ++++++++++-- .../activation-transfer-with-click.tentative.html | 12 ++++++++++-- 2 files changed, 20 insertions(+), 4 deletions(-) commit 0d47faa44f6c40285c0ae2fe99d6c66e6808a7c2 Author: Justin DeWitt <dewittj@chromium.org> Date: Thu Mar 14 18:24:25 2019 +0000 [Touchless] Add active eng to OWNERS. Change-Id: Ia9606a626d17fb238cbdbfe85de5ae614051b0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524414 Auto-Submit: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#640848} chrome/android/touchless/OWNERS | 5 +++++ 1 file changed, 5 insertions(+) commit 1439f34ee639db2ec07a463d8ea52c2e03e2e2d7 Author: Joe Mason <joenotcharles@google.com> Date: Thu Mar 14 18:21:25 2019 +0000 Re-enable flaky ServiceUtilCleanerTests with better logging R=proberge Bug: 871784 Change-Id: If8db9843014b65adcf467f872ea0d18f600db828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524526 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#640847} .../os/system_util_cleaner_unittest.cc | 6 +- chrome/chrome_cleaner/test/BUILD.gn | 1 + .../test/test_scoped_service_handle.cc | 104 ++++++++++++--------- .../test/test_scoped_service_handle.h | 11 +-- 4 files changed, 67 insertions(+), 55 deletions(-) commit 73de2201dba00884f80cd3df12a96a6743b04069 Author: Kurt Catti-Schmidt <kschmi@microsoft.com> Date: Thu Mar 14 18:21:02 2019 +0000 Implement ITextRangeProvider::GetBoundingRectangles This change adds support for ITextRangeProvider::GetBoundingRectangles. Additional support methods were added to AXRange for collecting anchors within a range and getting bounding rects within a range. This also moves CreateNextAnchorPosition() and CreatePreviousAnchorPosition() to public so they can be accessed by AXRange and GetScreenBoundsForRange to AXPlatformNodeDelegate. Unit tests are added for collecting a single rect from a single text node as well as multiple nodes on a document. Bug: 928948 Change-Id: I5300888d78a05b0256fa5f4aa6a7fcfce339ac8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518348 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640846} .../browser/accessibility/browser_accessibility.h | 8 +- .../accessibility/browser_accessibility_manager.cc | 14 +++ .../accessibility/browser_accessibility_manager.h | 2 + ui/accessibility/BUILD.gn | 9 +- ui/accessibility/ax_position.h | 88 ++++++++-------- ui/accessibility/ax_range.h | 113 +++++++++++++++++++++ ui/accessibility/ax_tree_manager.h | 8 ++ .../platform/ax_platform_node_delegate.h | 6 ++ .../platform/ax_platform_node_delegate_base.cc | 7 ++ .../platform/ax_platform_node_delegate_base.h | 8 ++ .../ax_platform_node_textrangeprovider_win.cc | 52 +++++++++- .../ax_platform_node_textrangeprovider_win.h | 2 - ...platform_node_textrangeprovider_win_unittest.cc | 100 ++++++++++++++++++ .../platform/ax_platform_node_unittest.cc | 22 ++++ .../platform/ax_platform_node_unittest.h | 8 +- ui/accessibility/platform/test_ax_node_wrapper.cc | 10 ++ ui/accessibility/platform/test_ax_node_wrapper.h | 3 + 17 files changed, 400 insertions(+), 60 deletions(-) commit 0486d4d0111d68814854bce21ed89250fe7e9e01 Author: Yusuf Ozuysal <yusufo@google.com> Date: Thu Mar 14 18:20:20 2019 +0000 Don't try to add a tab that is not in the TabModel to grid There are a few cases in grid, where we get the didAddTab call before didSelectTab and also some where the current model is actually incognito and an external app adds a normal tab. In these cases we should ignore the TabModelObserver signals for adding. BUG=938682 Change-Id: I50de1e687474fea85bd312e911c5d13df5e6fb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524524 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#640845} .../chromium/chrome/browser/tasks/tab_management/TabListMediator.java | 2 ++ 1 file changed, 2 insertions(+) commit a9004d60fd3d161af790e8a3792f43affe4b355b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 18:19:53 2019 +0000 Roll src/third_party/chromite 37978c4b3bea..7a62eb7d2b04 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/37978c4b3bea..7a62eb7d2b04 git log 37978c4b3bea..7a62eb7d2b04 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 dhanyaganesh@chromium.org GetBuildStatuses: sanitize the inputs to fix PreCQLauncher Created with: gclient setdep -r src/third_party/chromite@7a62eb7d2b04 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Iaff045b80dbe0f80fdbf5e5268f8e7fa2c45a033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524363 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640844} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f64ac2b6a61c1080f8cdfd8a48bc174f8d128410 Author: Xiaohan Wang <xhwang@chromium.org> Date: Thu Mar 14 18:17:54 2019 +0000 media: Lower max number of pre-provisioned origin IDs In MediaDrmOriginIdManager, reduce the maximum number of pre-provisioned origin IDs from 5 to 2, to alleviate potential provisioning server surge. We can adjust this value later after initial launch if needed. Bug: 917527 Test: Updated test. Change-Id: I44bae26680f7fd6400395ee5744d0ab6f5933cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524409 Reviewed-by: John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#640843} chrome/browser/media/android/cdm/media_drm_origin_id_manager.cc | 8 ++++++-- .../media/android/cdm/media_drm_origin_id_manager_unittest.cc | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) commit fbc8f947295c9d4c29b00c3cbf90b2c82a4a9ad7 Author: Wei Li <weili@chromium.org> Date: Thu Mar 14 18:10:07 2019 +0000 CrOS Shelf: Use shelf item title for tooltip This CL reverts the tooltip related changes in https://crrev.com/c/1410425 mainly because that change used GetTooltipText() in a non-conforming way which set the proper tooltip text in output parameter but returned value as false. In addition, that previous change duplicated tooltip text from its shelf item title which could be avoided. Instead, this CL adds an additional check in ShelfTooltipManager::ShowTooltip() to retrieve overflow button's tooltip since it doesn't have a corresponding shelf item. BUG=155933 Change-Id: I60889becb21eb52fed925ec10036b48e47d08116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521789 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#640842} ash/shelf/shelf_app_button.cc | 8 +------- ash/shelf/shelf_app_button.h | 5 +---- ash/shelf/shelf_button.cc | 12 ++---------- ash/shelf/shelf_button.h | 2 -- ash/shelf/shelf_tooltip_manager.cc | 6 ++---- ash/shelf/shelf_view.cc | 11 +++++++++-- ash/shelf/shelf_view.h | 3 +++ ash/shelf/shelf_view_unittest.cc | 5 ++--- 8 files changed, 20 insertions(+), 32 deletions(-) commit 2e04537b39f7847aad3a81930f7793aca66a35fc Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Mar 14 18:08:31 2019 +0000 More fixes necessary for Windows/libc++ Fixes more configurations when usinguse_custom_libcxx=true on Windows, in particular ASAN. Summary of changes: * base/test/test_suite.cc: IWYU: macros like _CRT_ASSERT are used without including <crtdbg.h> where they're defined. * chrome_elf/BUILD.gn: //build/config/sanitizers:default_sanitizer_flags are removed, causing the ASAN runtime to not be linked in. no_default_deps needs to be set in order to prevent pulling in libc++ which was built with asan, and therefore has dependencies on the ASAN runtime. Fixes undefined symbol errors. * third_party/yasm/BUILD.gn: Always uses the release CRT even on debug builds, so symbols like _CrtDbgReportW referenced by libc++ will be missing. Add no_default_deps to prevent undefined symbol errors when linking. BUG=801780 R=thakis Change-Id: I8f39531ec6c8df30bd6c689d257d5fc3bfb427a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521275 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Patrick Monette <pmonette@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640841} base/test/test_suite.cc | 4 ++++ chrome_elf/BUILD.gn | 2 ++ third_party/yasm/BUILD.gn | 6 ++++++ 3 files changed, 12 insertions(+) commit b4bd227d318ffe4e60cbe451068143bb89eacc71 Author: Caleb Raitto <caraitto@chromium.org> Date: Thu Mar 14 18:08:16 2019 +0000 [Cronet] Remove unnecessary comment. The style guide doesn't require definition comments except for functions with tricky implementations [1]. [1] https://google.github.io/styleguide/cppguide.html#Function_Comments Change-Id: I6eeffd415786c3299cc78354bc2bd75ccc87c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520993 Reviewed-by: Misha Efimov <mef@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#640840} components/cronet/native/url_request.cc | 1 - 1 file changed, 1 deletion(-) commit c342e6a6334a8e3a48ba44df6a981cb714beca2e Author: Chase Phillips <cmp@chromium.org> Date: Thu Mar 14 18:07:25 2019 +0000 IndexedDB: Rename connection and cursor wrappers The SafeIOThreadConnectionWrapper and SafeIOThreadCursorWrapper classes were previously needed when IndexedDBCallbacks was bound on the IDB task runner and was passing a connection or cursor to an IO thread-bound environment. After commit 77bf9a9 / https://crrev.com/c/1405718 landed, the connection and cursor were no longer passed outside the IDB task runner environment, so the wrappers are no longer needed for that purpose. We would remove them, but it's not possible to delete these objects at this point in their lifecycle without violating their design. For example, a connection can't be destroyed while it has an open connection to a database. And a connection can't be forced close while the transaction task queue is being processed. Since we still need these wrappers, update their names to reflect their general purpose to protect these objects. Bug: 717812 Change-Id: Ie5fea19ff7bab74fde5b92a6aa2b4315911614d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518756 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#640839} content/browser/indexed_db/indexed_db_callbacks.cc | 31 +++++++++++----------- 1 file changed, 15 insertions(+), 16 deletions(-) commit adea09dce50c767aeb84f979ba955add30225193 Author: Eugene But <eugenebut@chromium.org> Date: Thu Mar 14 18:07:08 2019 +0000 Implement WebStateImpl::GetPendingItem(). This method returns pending item stored in navigation context and used by WKBasedNavigationManager via NavigationDelegate. Bug: 899827 Change-Id: I985a5d7b6a45806e81581701066b24d71714014d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521767 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#640838} ios/web/web_state/ui/crw_web_controller.h | 4 ++++ ios/web/web_state/ui/crw_web_controller.mm | 16 ++++++++++----- .../web_state/ui/crw_web_controller_unittest.mm | 24 ++++++++++++++++++++++ ios/web/web_state/web_state_impl.mm | 3 +-- 4 files changed, 40 insertions(+), 7 deletions(-) commit d059fc7da0acf73531a75b56eb546b571ff454dd Author: Jun Mukai <mukai@chromium.org> Date: Thu Mar 14 18:05:13 2019 +0000 Notifies the new local_surface_id to the client when re-generated When the window bounds change is requested from the client, it can cause to generate a new local_surface_id, but the new id can be left within the window server. This causes a mismatch of surface id and then possible UI janks. Bug: 939743 Test: manually Change-Id: I8586ff05edfc0918ba36e8a808f6b8e16defca98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521972 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#640837} services/ws/client_root.cc | 5 ++++- services/ws/window_tree_unittest.cc | 10 +++++++++- 2 files changed, 13 insertions(+), 2 deletions(-) commit 9f4bf88c5a8a83f3a66070087497610e176e96f9 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Mar 14 18:03:43 2019 +0000 Roll src/third_party/nasm/ 4ee6a69ce..076332ea7 (5 commits) https://chromium.googlesource.com/chromium/deps/nasm.git/+log/4ee6a69ce33b..076332ea7c41 $ git log 4ee6a69ce..076332ea7 --date=short --no-merges --format='%ad %ae %s' 2019-03-13 thomasanderson Fix condition for using no_default_deps=true 2019-03-13 thomasanderson Add no_default_deps to nasm executable 2019-02-19 tikuta use no_chromium_code config 2019-02-13 tikuta Fix wrong filename for win 2018-12-05 raphael.kubo.da.costa nasm: Fix license path in README.chromium Created with: roll-dep src/third_party/nasm BUG=801780 R=thakis Change-Id: Id2c9220a3c5be378a04a7d44e3cdc7693cebdaba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521970 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640836} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80945e90d44d18faa444e5c1516a34e8cebca44b Author: Mohamed Heikal <mheikal@chromium.org> Date: Thu Mar 14 17:54:22 2019 +0000 Test full browser startup after reduced mode Adds smoke test that ensures native full browser can start successfully after already partially loaded in service manager only mode. Also some refactoring. Change-Id: I4248d3738a51c5380d11535d547d47a483babdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516732 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Xi Han <hanxi@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#640835} .../browser/ServicificationBackgroundService.java | 62 ++++++++++++++++------ .../ServicificationBackgroundServiceTest.java | 26 +++++---- .../download/ServicificationDownloadTest.java | 7 +-- 3 files changed, 68 insertions(+), 27 deletions(-) commit 9cf78ea0762b65819a8d0ea6e3311d7f52af98e7 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Thu Mar 14 17:53:08 2019 +0000 Make case style consistent in resource_response.h The primary motivation of CL is that the function names aren't consistent within resource_response.h (e.g."SetHTTPVersion" and "HttpVersion"). This CL renames function |SetHTTPVersion| to |SetHttpVersion| and ports other dependent files to refer to a new function name. Bug: 937196 Change-Id: I843afa0f2852053cc735f43a6601b190fdfb7273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518257 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#640834} content/renderer/loader/web_url_loader_impl.cc | 2 +- media/blink/cache_util_unittest.cc | 2 +- third_party/blink/public/platform/web_url_response.h | 2 +- third_party/blink/renderer/platform/exported/web_url_response.cc | 4 ++-- third_party/blink/renderer/platform/loader/fetch/resource_response.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) commit 0a768a8b98be7cd28a154056411460c8b5025921 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Mar 14 17:50:59 2019 +0000 WebUI: FocusRow, handle tab focus in key handler make row active when focusing Bug: 930687 Change-Id: I998739784876a4a3e7b6853dfb0500f065807cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504112 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#640833} ui/webui/resources/js/cr/ui/focus_row_behavior.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4ec16c670b919557d3e16b508450e2441d57a89f Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Thu Mar 14 17:48:24 2019 +0000 Use ScopedTaskEnvironment instead of MessageLoop in platform_sensor_and_provider_unittest_linux MessageLoop is going away at some point, port away from it. Bug: 891670 Change-Id: Icc4628afb5e8a6421e42f4f7d002501ba36e4177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524281 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#640832} .../generic_sensor/platform_sensor_and_provider_unittest_linux.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 943f94a5c68305275d4d52594b0cceba095e61c2 Author: Thomas Anderson <thomasanderson@chromium.org> Date: Thu Mar 14 17:45:19 2019 +0000 Revert "Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263" This reverts commit 5b33ce1bbedab114c8657acb8047c0f3150ac0de. Reason for revert: Causing build failure on android-rel https://ci.chromium.org/p/chromium/builders/ci/android-rel/9681 Original change's description: > Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263 > > 48ee086ca4c4 fuchsia: Update to run crashpad_test as package rather than > from /system > 2271f00fe076 Add missing BUILD.gn for third_party/apple_cf > 3332ae354672 compat: Provide <elf.h> and <mach-o/loader.h> for everyone > 708367f5badf POSIX: ScopedMmap length refinement > 5a21d038c9c9 Work around libcrashpad_handler_trampoline.so ASan trunk > clang problem > c8fdad4fe58f Update DEPS for buildtools and GYP > 2a47ea4663dd Obtain the Fuchsia SDK from the correct (updated) location > 36f9051cafca Enable clang -Wextra-semi in POSIX/Fuchsia clang builds > 348022def8d5 Fuchsia: Proper Fuchsia-on-macOS cross build support > aa160f658175 [fuchsia] Update header include > 1bb8ca4059d8 Silence some warnings > > Change-Id: Ic40aa09f581c5b1339ac7d7c0a50a55f2d15ea99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524084 > Commit-Queue: Scott Graham <scottmg@chromium.org> > Commit-Queue: Mark Mentovai <mark@chromium.org> > Auto-Submit: Scott Graham <scottmg@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640817} TBR=wez@chromium.org,scottmg@chromium.org,mark@chromium.org Change-Id: If2eb829164c0923dd7657f34bfad33a7c0aab477 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524622 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#640831} third_party/crashpad/README.chromium | 2 +- third_party/crashpad/crashpad/BUILD.gn | 48 +- third_party/crashpad/crashpad/DEPS | 32 +- third_party/crashpad/crashpad/compat/BUILD.gn | 25 +- third_party/crashpad/crashpad/compat/non_elf/elf.h | 20 - .../crashpad/compat/non_mac/mach-o/loader.h | 20 - .../crashpad/compat/non_mac/mach/machine.h | 21 - .../crashpad/compat/non_mac/mach/vm_prot.h | 20 - .../snapshot/minidump/thread_snapshot_minidump.cc | 4 + .../crashpad/test/fuchsia_crashpad_tests.cmx | 21 - third_party/crashpad/crashpad/test/test_paths.cc | 31 +- .../crashpad/third_party/apple_cf/BUILD.gn | 19 - .../third_party/apple_cf/CFStreamAbstract.h | 17 +- .../crashpad/third_party/apple_cf/README.crashpad | 2 +- .../crashpad/crashpad/third_party/fuchsia/BUILD.gn | 137 +- .../crashpad/crashpad/third_party/glibc/BUILD.gn | 19 - .../crashpad/third_party/glibc/COPYING.LIB | 502 --- .../crashpad/third_party/glibc/README.crashpad | 16 - .../crashpad/crashpad/third_party/glibc/elf/elf.h | 4003 -------------------- .../crashpad/third_party/xnu/APPLE_LICENSE | 367 -- .../crashpad/crashpad/third_party/xnu/BUILD.gn | 19 - .../xnu/EXTERNAL_HEADERS/mach-o/loader.h | 1531 -------- .../crashpad/third_party/xnu/README.crashpad | 19 - third_party/crashpad/crashpad/util/BUILD.gn | 5 +- .../crashpad/util/fuchsia/koid_utilities.cc | 2 +- .../crashpad/crashpad/util/posix/scoped_mmap.cc | 26 +- .../crashpad/crashpad/util/posix/scoped_mmap.h | 5 - .../crashpad/util/posix/scoped_mmap_test.cc | 12 +- 28 files changed, 158 insertions(+), 6787 deletions(-) commit a9996a7d75cbb12800c93aea0053ca539463a930 Author: Mikel Astiz <mastiz@chromium.org> Date: Thu Mar 14 17:40:58 2019 +0000 Fix sync not recovering if custom passphrase cleared Sync datatype HISTORY_DELETE_DIRECTIVES should stop if custom passphrase is set. Prior to this patch, that was implemented by issuing a datatype policy error, but that also meant (in the USS codepath, i.e. ModelTypeController) that the datatype cannot recover from that state without a restart of the browser. This was somewhat weird or asymmetrical because, during normal startup, the condition is detected in the controller's ReadyForStart(), which doesn't enter an error state. A cleaner solution for this requirement is to treat the passphrase state exclusively as precondition, and when it changes, report it via ReadyForStartChanged(). This means no error states are involved, and that the controller can resume normally if preconditions are met (i.e. custom passphrase cleared), fixing the issue at hand. Bug: 941733 Change-Id: Icf5ac07bd52260182c71ae6ca303c264699f3f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523387 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#640830} ...tory_delete_directives_model_type_controller.cc | 27 +-------- ...story_delete_directives_model_type_controller.h | 4 -- components/sync/driver/data_type_manager.h | 2 +- .../sync/driver/data_type_manager_impl_unittest.cc | 64 ++++++++++++++++++++++ .../sync/driver/model_association_manager.cc | 8 ++- components/sync/driver/sync_service.h | 2 +- 6 files changed, 75 insertions(+), 32 deletions(-) commit 5890f232c3043d1553383139bc5a1a9f26379bda Author: Justin DeWitt <dewittj@chromium.org> Date: Thu Mar 14 17:38:21 2019 +0000 Create a Touchless new tab page that doesn't include omnibox This creates a mostly empty Top Layout section that is rendered above the content suggestions cards. Bug: 937430 Change-Id: I577c1eb34f97696335771f9048d1e4348003fdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500833 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Cathy Li <chili@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#640829} .../chromium/chrome/browser/ntp/NewTabPage.java | 44 +++++-- .../chromium/chrome/browser/ntp/NewTabPageUma.java | 21 +++- .../browser/ntp/cards/NewTabPageRecyclerView.java | 12 -- .../suggestions/SuggestionsRecyclerView.java | 12 ++ chrome/android/java_sources.gni | 4 + .../java/res/layout/new_tab_page_touchless.xml | 10 +- .../res/layout/new_tab_page_touchless_view.xml | 18 +++ .../android/touchless/java/res/values/dimens.xml | 7 ++ .../touchless/ContentSuggestionsViewBinder.java | 34 +++++ .../browser/touchless/TouchlessNewTabPage.java | 138 +++++++++++++++++++-- .../touchless/TouchlessNewTabPageMediator.java | 82 ++++++++++++ .../touchless/TouchlessNewTabPageProperties.java | 21 ++++ .../touchless/TouchlessNewTabPageTopLayout.java | 20 +++ 13 files changed, 384 insertions(+), 39 deletions(-) commit 2a541ea6e5766479ebe42acb7df8fd3ddfd973f4 Author: Mario Sanchez Prada <mario@igalia.com> Date: Thu Mar 14 17:37:36 2019 +0000 Migrate Socket, TCPSocket and UDPSocket methods to net::CompletionOnceCallback This includes Bind(), RecvFrom(), SendTo(), JoinGroup(), LeaveGroup() and SetBroadcast(), as well as changing callers and relevant unit tests to use BindOnce() instead of Bind() or BindRepeating(). Bug: 807724 Change-Id: Ibdae0ae98c2b6a09451326a3aecedf41b627f37e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523096 Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#640828} .../extensions/api/socket/udp_socket_unittest.cc | 22 ++--- extensions/browser/api/socket/socket.h | 17 ++-- extensions/browser/api/socket/socket_api.cc | 13 ++- extensions/browser/api/socket/tcp_socket.cc | 15 ++-- extensions/browser/api/socket/tcp_socket.h | 6 +- extensions/browser/api/socket/udp_socket.cc | 99 ++++++++++++---------- extensions/browser/api/socket/udp_socket.h | 27 +++--- .../browser/api/sockets_tcp/sockets_tcp_api.cc | 5 +- .../api/sockets_tcp/tcp_socket_event_dispatcher.cc | 2 +- .../browser/api/sockets_udp/sockets_udp_api.cc | 8 +- .../api/sockets_udp/udp_socket_event_dispatcher.cc | 2 +- 11 files changed, 113 insertions(+), 103 deletions(-) commit 902601eb53fb46fa0245f864e62c8ce94bd2a268 Author: Richard Knoll <knollr@chromium.org> Date: Thu Mar 14 17:37:11 2019 +0000 Move notification trigger timer into chrome/. This is the final preparation to have platform specific trigger logic so we can leverage the BackgroundTaskScheduler on Android. This only keeps one trigger across all profiles and storage partitions, so we need to iterate over all of them to trigger pending ones and get the next trigger time. To prevent iterating over profiles without anything to trigger at this time, we store the next trigger timestamp per profile in prefs. Bug: 891339 Change-Id: I097af593cba2cce1bc4bc12a163a3b931305bd2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479330 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640827} chrome/browser/BUILD.gn | 2 + .../notification_trigger_scheduler.cc | 95 ++++++++++++++++++++++ .../notifications/notification_trigger_scheduler.h | 49 +++++++++++ .../notification_trigger_scheduler_unittest.cc | 88 ++++++++++++++++++++ .../platform_notification_service_impl.cc | 35 +++++++- .../platform_notification_service_impl.h | 13 +++ chrome/common/pref_names.cc | 4 + chrome/common/pref_names.h | 1 + chrome/test/BUILD.gn | 1 + .../platform_notification_context_impl.cc | 43 ++++------ .../platform_notification_context_impl.h | 11 +-- ...atform_notification_context_trigger_unittest.cc | 32 ++++++++ .../platform_notification_service_proxy.cc | 18 ++++ .../platform_notification_service_proxy.h | 7 ++ .../public/browser/platform_notification_context.h | 5 ++ .../public/browser/platform_notification_service.h | 11 +++ content/test/mock_platform_notification_service.cc | 9 ++ content/test/mock_platform_notification_service.h | 4 + 18 files changed, 389 insertions(+), 39 deletions(-) commit d6718b5af639e0b3dbf7fed92918b93bd761e59e Author: Yann Dago <ydago@chromium.org> Date: Thu Mar 14 17:36:06 2019 +0000 Policy WebUI: fix bad android pre-process tags Bug: 937331 Change-Id: I39715930d5d7f80fdbfc9ca411160ad7f67f8adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514993 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#640826} chrome/browser/resources/policy/policy.css | 4 ++-- chrome/browser/resources/policy/policy_base.js | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) commit 6a655b34394bafbb2711f5dc72813b4af8081765 Author: Leonardo Padilha <ldaguilar@chromium.org> Date: Thu Mar 14 17:31:42 2019 +0000 Add notification for when the override with duration is almost over. Bug: 934923 Change-Id: I13891228e5c529e4074a765e95f0709490b1aac5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521167 Commit-Queue: Leonardo Padilha <ldaguilar@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#640825} chrome/browser/chromeos/child_accounts/screen_time_controller.cc | 2 +- chrome/browser/chromeos/child_accounts/time_limit_notifier.h | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) commit e47b3c57c160e28f6e7a782e1ca5855e44141838 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 17:30:20 2019 +0000 Roll src/third_party/skia f699bf0437db..44c8131b779b (10 commits) https://skia.googlesource.com/skia.git/+log/f699bf0437db..44c8131b779b git log f699bf0437db..44c8131b779b --date=short --no-merges --format='%ad %ae %s' 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 49d2c13943ef..ca56e8b07a1a (1 commits) 2019-03-14 kjlubick@google.com [canvaskit] missing extern 2019-03-14 bsalomon@google.com Reland "Reintroduce deinstantiate lazy proxy types and use for promise images." 2019-03-14 michaelludwig@google.com Revert "Update SkCanvas' experimental SkiaRenderer API" 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b62c5ea2af3..49d2c13943ef (1 commits) 2019-03-14 brianosman@google.com SkLumaColorFilter: Keep alpha in [0,1] 2019-03-14 michaelludwig@google.com Update SkCanvas' experimental SkiaRenderer API 2019-03-14 mtklein@google.com remove plus clamp 2019-03-14 nifong@google.com fill out more of SkDebugCanvas interface 2019-03-14 bsalomon@google.com Reland "Try to avoid vertex colors in Texture/FillRect ops when possible." Created with: gclient setdep -r src/third_party/skia@44c8131b779b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: If0fb21d783b507fdd162e2190a3bbe7761213f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524321 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640824} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fb27962cabaa6fe58a40e97a1f59bdf646f6790 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Thu Mar 14 17:27:40 2019 +0000 Make NaN sort to bottom of task mgr. Bug: 932932 Change-Id: Ie402b9a9250e083abe3aface32932c446e8ae1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522343 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#640823} chrome/browser/ui/task_manager/task_manager_table_model.cc | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit f9431a203b1ddd5c98d62bc72a3abfe448c4c582 Author: Sami Kyostila <skyostil@chromium.org> Date: Thu Mar 14 17:27:01 2019 +0000 SequenceManager: Record asynchronous call stack into a crash key SequenceManager currently records crash keys for one level of asynchronous call stack information for tasks (i.e., the FROM_HERE of the posting location) in the form of function and file name strings. This information is useful for tracking down the source of crashing tasks, but the cost of recording these strings is not insignificant (~1.5% of overall renderer CPU time on Windows according to sampling profiler data). This patch adds an alternate mechanism for recording this information in the form of hexadecimal code addresses. This form is cheaper to encode and more compact: we can now fit two levels of asynchronous stack frames in 64 characters. The downside is that the data now needs to be symbolized. This can be down with crsym as described at [1]. We still leave the old crash keys in place in order to have reliable data while this new alternative is being proven. Note that we use a hand-rolled function to write out the hex addresses because it is faster than snprintf. The full results are in [2][3], but to summarize this function is 81% faster on Android than the current code, compared to 33% for snprintf. Bug : 897751 [1] https://chromium.googlesource.com/chromium/src/+/master/docs/debugging_with_crash_keys.md [2] https://docs.google.com/spreadsheets/d/1YxuWobFQaMh-XkkwiCJFVVqnpLT6vcBdMTQ3Ntszf3M/edit#gid=0 [3] https://chromium-review.googlesource.com/c/chromium/src/+/1523094 Change-Id: I6f43c6d2a57ed3d2fc500cd7b051621aeb499590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518576 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640822} base/task/sequence_manager/sequence_manager.h | 3 +- .../task/sequence_manager/sequence_manager_impl.cc | 80 ++++++++++++++++++---- base/task/sequence_manager/sequence_manager_impl.h | 12 ++-- .../sequence_manager_impl_unittest.cc | 51 ++++++++++++++ .../main_thread/main_thread_scheduler_helper.cc | 3 +- 5 files changed, 128 insertions(+), 21 deletions(-) commit b539890c97fa9126a6beb560666caf2cc694bde7 Author: Xianda Sun <sunxd@chromium.org> Date: Thu Mar 14 17:25:27 2019 +0000 Fix viz hit test to correctly detect mask layers when BGPT is enabled When Blink-gen-property-trees is enabled, mask layers are no longer created for border-radius and clip-path, instead synthesized clip layers are created. Viz hit test needs to detect the existence of irregular clips for OOPIF hit testing correctness. As there are no mask layer bits in effect tree, it has to look up effect node's has_masking_child in this case. With https://chromium-review.googlesource.com/c/chromium/src/+/1427788, SitePerProcessHitTestDataGenerationTest.MaskedOOPIF/2 fails due to this mask issue. With this patch, this is fixed. Bug: 937476 Change-Id: I6f16edd3a55e753373ed812e869c0754eebae41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516039 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianda Sun <sunxd@chromium.org> Cr-Commit-Position: refs/heads/master@{#640821} cc/trees/effect_node.cc | 2 ++ cc/trees/effect_node.h | 6 ++++-- cc/trees/layer_tree_host_impl.cc | 4 ++-- cc/trees/layer_tree_host_impl_unittest.cc | 2 ++ cc/trees/property_tree.cc | 20 ++++++++++++++++---- cc/trees/property_tree.h | 7 ++++++- cc/trees/property_tree_builder.cc | 1 + 7 files changed, 33 insertions(+), 9 deletions(-) commit 3ecf829c455cc06f66aa6585fff8a70ab18f8a55 Author: Yuly Novikov <ynovikov@chromium.org> Date: Thu Mar 14 17:24:23 2019 +0000 Stop running WebGL 1 and 2 tests with validating CB on Win Intel GPU bots Since passthrough command decoder is the default now, and we lack capacity on Win Intel bots. Remove webgl2_conformance_d3d11_validating_tests webgl_conformance_d3d11_validating_tests webgl_conformance_d3d9_validating_tests from: ANGLE GPU Win10 Release (Intel HD 630) Optional Win10 Release (Intel HD 630) Win10 FYI Release (Intel HD 630) Win10 FYI Exp Release (Intel HD 630) and add webgl_conformance_tests to ANGLE GPU Win10 Release (Intel HD 630) Optional Win10 Release (Intel HD 630) These 4 bots now run: webgl2_conformance_tests webgl_conformance_tests webgl_conformance_d3d9_passthrough_tests webgl_conformance_gl_passthrough_tests webgl_conformance_vulkan_passthrough_tests And 3 bots other than Optional Win10 Release (Intel HD 630) also run: webgl2_conformance_gl_passthrough_tests Bug: 882580 Change-Id: Ib0c955aa6f5e9bc4d52b7f4df07ccbf7514f49df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521813 Reviewed-by: Geoff Lang <geofflang@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#640820} testing/buildbot/chromium.gpu.fyi.json | 254 ++------------------------------- testing/buildbot/test_suites.pyl | 68 ++++++--- testing/buildbot/waterfalls.pyl | 4 +- 3 files changed, 64 insertions(+), 262 deletions(-) commit d2ec84810d8befb81129f43cabd84cc32d0774ba Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Thu Mar 14 17:23:51 2019 +0000 Implement the AtkTableCell interface Bug: 934815 Change-Id: I6d3ab551580818142b7ad7c289b442f6aa841343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492111 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#640819} .../accessibility_tree_formatter_auralinux.cc | 8 + .../html/caption-expected-auralinux.txt | 12 +- .../accessibility/html/col-expected-auralinux.txt | 8 +- .../html/colgroup-expected-auralinux.txt | 8 +- ...tenteditable-descendants-expected-auralinux.txt | 2 +- ...scendants-with-selection-expected-auralinux.txt | 2 +- ...table-focusable-sections-expected-auralinux.txt | 16 +- .../html/table-simple-expected-auralinux.txt | 12 +- .../html/table-spans-expected-auralinux.txt | 14 +- .../html/table-th-colheader-expected-auralinux.txt | 8 +- .../html/table-th-rowheader-expected-auralinux.txt | 8 +- .../table-thead-tbody-tfoot-expected-auralinux.txt | 16 +- .../platform/ax_platform_node_auralinux.cc | 214 ++++++++++++++++++++- .../platform/ax_platform_node_auralinux.h | 1 + 14 files changed, 274 insertions(+), 55 deletions(-) commit 1ad64af757dd144e9aa4166bf4ad576c6291ea81 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Mar 14 17:21:41 2019 +0000 flags: assign instant-tethering Per email discussion :) Bug: None Change-Id: Ifc89b0db4b8525181beadc7facc11805d59251a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523607 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#640818} chrome/browser/flag-metadata.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 5b33ce1bbedab114c8657acb8047c0f3150ac0de Author: Scott Graham <scottmg@chromium.org> Date: Thu Mar 14 17:20:19 2019 +0000 Update Crashpad to 1bb8ca4059d8bcc933478e02d7869dda7daa0263 48ee086ca4c4 fuchsia: Update to run crashpad_test as package rather than from /system 2271f00fe076 Add missing BUILD.gn for third_party/apple_cf 3332ae354672 compat: Provide <elf.h> and <mach-o/loader.h> for everyone 708367f5badf POSIX: ScopedMmap length refinement 5a21d038c9c9 Work around libcrashpad_handler_trampoline.so ASan trunk clang problem c8fdad4fe58f Update DEPS for buildtools and GYP 2a47ea4663dd Obtain the Fuchsia SDK from the correct (updated) location 36f9051cafca Enable clang -Wextra-semi in POSIX/Fuchsia clang builds 348022def8d5 Fuchsia: Proper Fuchsia-on-macOS cross build support aa160f658175 [fuchsia] Update header include 1bb8ca4059d8 Silence some warnings Change-Id: Ic40aa09f581c5b1339ac7d7c0a50a55f2d15ea99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524084 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Scott Graham <scottmg@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#640817} third_party/crashpad/README.chromium | 2 +- third_party/crashpad/crashpad/BUILD.gn | 48 +- third_party/crashpad/crashpad/DEPS | 32 +- third_party/crashpad/crashpad/compat/BUILD.gn | 25 +- third_party/crashpad/crashpad/compat/non_elf/elf.h | 20 + .../crashpad/compat/non_mac/mach-o/loader.h | 20 + .../crashpad/compat/non_mac/mach/machine.h | 21 + .../crashpad/compat/non_mac/mach/vm_prot.h | 20 + .../snapshot/minidump/thread_snapshot_minidump.cc | 4 - .../crashpad/test/fuchsia_crashpad_tests.cmx | 21 + third_party/crashpad/crashpad/test/test_paths.cc | 31 +- .../crashpad/third_party/apple_cf/BUILD.gn | 19 + .../third_party/apple_cf/CFStreamAbstract.h | 17 +- .../crashpad/third_party/apple_cf/README.crashpad | 2 +- .../crashpad/crashpad/third_party/fuchsia/BUILD.gn | 137 +- .../crashpad/crashpad/third_party/glibc/BUILD.gn | 19 + .../crashpad/third_party/glibc/COPYING.LIB | 502 +++ .../crashpad/third_party/glibc/README.crashpad | 16 + .../crashpad/crashpad/third_party/glibc/elf/elf.h | 4003 ++++++++++++++++++++ .../crashpad/third_party/xnu/APPLE_LICENSE | 367 ++ .../crashpad/crashpad/third_party/xnu/BUILD.gn | 19 + .../xnu/EXTERNAL_HEADERS/mach-o/loader.h | 1531 ++++++++ .../crashpad/third_party/xnu/README.crashpad | 19 + third_party/crashpad/crashpad/util/BUILD.gn | 5 +- .../crashpad/util/fuchsia/koid_utilities.cc | 2 +- .../crashpad/crashpad/util/posix/scoped_mmap.cc | 26 +- .../crashpad/crashpad/util/posix/scoped_mmap.h | 5 + .../crashpad/util/posix/scoped_mmap_test.cc | 12 +- 28 files changed, 6787 insertions(+), 158 deletions(-) commit 7a7bd40a97c9a8cc1505b09149029306a0ba6160 Author: Sharon Yang <yangsharon@chromium.org> Date: Thu Mar 14 17:19:19 2019 +0000 [Fuchsia] Removed stray comment in run_package.py. Bug was fixed in change 1362248, but TODO comment was not removed. Bug: 895627 Change-Id: I16dd56bd6165967948265560959d9a7c3e7c4596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521471 Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Cr-Commit-Position: refs/heads/master@{#640816} build/fuchsia/run_package.py | 2 -- 1 file changed, 2 deletions(-) commit 57f7613daab082ffdedbf79a09037dce6ec0d908 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 17:19:15 2019 +0000 Roll src/third_party/swiftshader 49d2c13943ef..af973b67141e (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/49d2c13943ef..af973b67141e git log 49d2c13943ef..af973b67141e --date=short --no-merges --format='%ad %ae %s' 2019-03-14 bclayton@google.com SpirvShader: ObjectID -> Object::ID, TypeID -> Type::ID. 2019-03-14 chrisforbes@google.com Protect against DBZ in OpUMod also 2019-03-14 capn@google.com Update CONTRIBUTORS 2019-03-14 bclayton@google.com Reactor: Add a PrintValue for Bool types. Created with: gclient setdep -r src/third_party/swiftshader@af973b67141e The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820,chromium:b/127962486 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ie227571ff8a0a315ae73ff9281a52fc35c20300a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524322 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640815} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f3c3938d2af60ca1221e07db9fbd1eeef0f70d14 Author: Ben Pastene <bpastene@chromium.org> Date: Thu Mar 14 17:18:15 2019 +0000 Roll the cts_archive package for swarmed CTS testers. From 1.1 to 1.4. Bug: 925321 Change-Id: I48dde53d4abd804219a849ed2c8be0075896de7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521457 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640814} testing/buildbot/chromium.android.fyi.json | 2 +- testing/buildbot/chromium.android.json | 37 ++++++++++++++++++++++++++---- testing/buildbot/test_suites.pyl | 19 +-------------- testing/buildbot/waterfalls.pyl | 2 +- 4 files changed, 35 insertions(+), 25 deletions(-) commit fa72db0d4118df2a331190e34f415dfa7374d246 Author: Eugene But <eugenebut@google.com> Date: Thu Mar 14 17:13:47 2019 +0000 Call webPageChangedWithContext: for new navigations. For new navigations webPageChangedWithContext: commits pending item from navigation context. Also remove |DCHECK_EQ(_loadPhase, web::LOAD_REQUESTED);|, which makes no sense with WKWebView, because there can be multiple pending navigations and not a single |_loadPhase| state. Bug: 899827 Change-Id: Idc1244b9c8f261816bf6ade79ab0bf5aca03e603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519626 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#640813} ios/web/web_state/ui/crw_web_controller.mm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit d87d1fecdb25763ec5e585288cd60ab77c117729 Author: Piotr Bialecki <bialpio@chromium.org> Date: Thu Mar 14 17:13:23 2019 +0000 Refactor ArCoreGl to implement XR* interfaces This CL refactors ArCoreGl into effectively representing a session. The blink code will now directly interact with ArCoreGl through mojo interfaces, thus reducing the number of cross-thread calls. Make ArCoreGl implement 3 interfaces: - XRFrameDataProvider - XREnvironmentIntegrationProvider - XRSessionController Subsequent CLs will rename ArCoreGl into ArCoreSession and perform other miscellaneous cleanup. This CL should contain all of the work started with lincolnfrog@ in https://crrev.com/c/1357759 after taking the CL out of the freezer & rebasing on ToT. Add DVLOGs in VRDisplayImpl and ArCoreGl. Change-Id: Ica248cbe41564bd42545dae7e674c08380377faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515600 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#640812} .../android/vr/arcore_device/arcore_device.cc | 132 ++++----------------- .../android/vr/arcore_device/arcore_device.h | 22 +--- .../browser/android/vr/arcore_device/arcore_gl.cc | 105 ++++++++++++++-- .../browser/android/vr/arcore_device/arcore_gl.h | 50 ++++++-- device/vr/vr_display_impl.cc | 44 +------ device/vr/vr_display_impl.h | 12 +- 6 files changed, 173 insertions(+), 192 deletions(-) commit eb73339ed84f3fceef3529276abc2756fb452018 Author: Eyor Alemayehu <eyor@google.com> Date: Thu Mar 14 17:11:24 2019 +0000 Update description of policy and fix typo Bug: b:126901443 Change-Id: I485d3bf41b73a4ac1e245468db35e21357a05fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521708 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#640811} components/policy/resources/policy_templates.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 76be86e2c8cfac3b17edcbac79e71982e33415d0 Author: Chase Phillips <cmp@chromium.org> Date: Thu Mar 14 17:08:02 2019 +0000 IndexedDB: Merge IndexedDBDatabaseCallbacks and its helper class Originally, IndexedDBDatabaseCallbacks was bound on the IDB task runner and its helper class was bound on the IO thread. After commit 77bf9a9 / https://crrev.com/c/1405718, both moved to the IDB task runner, making it possible to merge them together. This commit updates IndexedDBDatabaseCallbacks so calls issued to it can now be executed directly rather than holding a helper instance and calling methods on the helper. Bug: 717812 Change-Id: If45d04c3e6d2f57c096b632eb02e347ae6779564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517170 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#640810} .../indexed_db/indexed_db_database_callbacks.cc | 103 ++++----------------- .../indexed_db/indexed_db_database_callbacks.h | 6 +- 2 files changed, 21 insertions(+), 88 deletions(-) commit 36c843e6683e08e3acff554946e5ea0c70cb7817 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Thu Mar 14 17:06:43 2019 +0000 Barcode detection mac: extend unitttests to check barcode symbology This CL extends the barcode detection unit tests to check that the detected barcode symbology is the expected. Cq-Depends: CL:1509364 Bug: 938663 Change-Id: I59df28b3487c7995d32db888b86f6edb7e0851ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524121 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#640809} .../barcode_detection_impl_mac_unittest.mm | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) commit 8e485c04713280cc08eeb31ffbafca08ec46276d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 14 17:05:05 2019 +0000 Roll src-internal 4726cc8c72a9..dd52ff0514b0 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4726cc8c72a9..dd52ff0514b0 Created with: gclient setdep -r src-internal@dd52ff0514b0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Id59d3188e6d9bd0ace5417e7f494778b8cdae8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524362 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640808} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 391175e25d7db0df08d3d93316d1804e19e0471c Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Mar 14 17:05:01 2019 +0000 Wait for main frame to be available in ios_web_view autofill tests This is the ios/web_view equivalent of https://chromium-review.googlesource.com/c/chromium/src/+/1505532 Change-Id: I4acc29bcb11b8f792fddba51999136d1227ec9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517702 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#640807} ios/web_view/test/web_view_autofill_inttest.mm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 3c0bb7fb53025fea4cc67db36af0587945a36826 Author: Paul Wankadia <junyer@chromium.org> Date: Thu Mar 14 17:03:00 2019 +0000 Roll src/third_party/re2/src/ 96b75fa24..5a982a6db (12 commits) https://chromium.googlesource.com/external/github.com/google/re2.git/+log/96b75fa24527..5a982a6dba7c $ git log 96b75fa24..5a982a6db --date=short --no-merges --format='%ad %ae %s' 2019-03-14 junyer Make the BitState bitmap use list heads. 2019-03-13 junyer Make NFA use hints. 2019-03-11 junyer Avoid touching the bitmap even more. 2019-03-11 junyer Make BitState avoid touching the bitmap unnecessarily. 2019-03-10 junyer Give foldcase 1 bit and hint 15 bits. 2019-03-08 junyer Remove a bogus comment. 2019-03-08 junyer Handle foldcase when computing hints. Mea culpa. 2019-03-08 junyer Compute hints for ByteRange instructions. Make BitState use them. 2019-03-06 junyer Tidy up a call to fullrune(). 2019-03-05 junyer Fix a silly buffer underflow. 2019-03-05 junyer Implement run length encoding for BitState. 2019-03-04 junyer Simplify AltMatch and Capture handling in BitState. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I6330c03f7f7f53a62f0bd18c1cdb9af9787d934e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523529 Commit-Queue: Paul Wankadia <junyer@chromium.org> Reviewed-by: Max Moroz <mmoroz@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#640806} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c0ab07251a9c8afeffd8756edfe993b494ee9338 Author: dalyk <dalyk@google.com> Date: Thu Mar 14 17:00:58 2019 +0000 Refactor dns_test_util.h to remove overloading of BuildTestDnsResponse. There are now separate BuildTestDns*Response methods for building responses with different record types, which should improve readability. Change-Id: I19a044afdc1fa1023b4ad7d4ea8bf2cd62592efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496292 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#640805} .../log_dns_client_unittest.cc | 28 ++++++++++++---------- net/dns/dns_test_util.cc | 11 +++++---- net/dns/dns_test_util.h | 13 ++++++---- net/dns/host_resolver_manager_unittest.cc | 22 ++++++++--------- services/network/host_resolver_unittest.cc | 2 +- 5 files changed, 41 insertions(+), 35 deletions(-) commit 612d7b8c2cfa757c8937b6a0d7f21a69b0572451 Author: Xida Chen <xidachen@chromium.org> Date: Thu Mar 14 17:00:04 2019 +0000 Merge two lines of test expectations These two lines points to the same test, the test is crashing or fail on all platforms. Bug: 806357 Change-Id: Iecc685dff2d24ffd435e4c38ab3bad28c0a37749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523901 Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#640804} third_party/blink/web_tests/TestExpectations | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit d0b70ca979a60f4c631cfc1761952cc3200d9fd7 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 14 16:58:10 2019 +0000 Update V8 to version 7.5.42. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4404f08..72287902 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I89fc4bf6c8062e4e4ec38f1c3a12838c3d0f95e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523666 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640803} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ec3da85e11e147cf7b7285c0e5859bbe40cdbdf1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 16:57:12 2019 +0000 Roll Fuchsia SDK from ddcb12bc41ac to 1fdc2abd2818 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie62d4cf99eaae566bc703347ed83e7807f4cc9d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523065 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640802} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 892ebabe71d120271cf4ae3a43d0c2ca15faad69 Author: Chase Phillips <cmp@chromium.org> Date: Thu Mar 14 16:56:14 2019 +0000 IndexedDB: Merge IndexedDBCallbacks and its helper class Originally, IndexedDBCallbacks was bound on the IDB task runner and its helper class was bound on the IO thread. After commit 77bf9a9 / https://crrev.com/c/1405718, both moved to the IDB task runner, making it possible to merge them together. This commit updates IndexedDBCallbacks so calls issued to it can now be executed directly rather than holding a helper instance and calling methods on the helper. Bug: 717812 Change-Id: Icddfe1e288111a59d6cb5bd761e2af1454454b09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517169 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#640801} content/browser/indexed_db/indexed_db_callbacks.cc | 415 +++++++-------------- content/browser/indexed_db/indexed_db_callbacks.h | 10 +- 2 files changed, 138 insertions(+), 287 deletions(-) commit 7f3de8830a5989d9da3af819fd7ed21d35fad9e6 Author: Caio <caiol@google.com> Date: Thu Mar 14 16:52:22 2019 +0000 Create URLCheckerKidsManagementClient to call KidsManagement. feat(kids_management_url_checker_client): create KidsManagementURLCheckerClient BUG=934444 Change-Id: Iae7f9cf0bd7edfc1b75d7ef62473140bae36a9bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481472 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Caio Lima <caiol@google.com> Cr-Commit-Position: refs/heads/master@{#640800} chrome/browser/BUILD.gn | 2 + .../kids_management_url_checker_client.cc | 328 +++++++++++++++++++++ .../kids_management_url_checker_client.h | 80 +++++ .../kids_management_url_checker_client_unittest.cc | 164 +++++++++++ chrome/test/BUILD.gn | 1 + tools/metrics/histograms/enums.xml | 9 + tools/metrics/histograms/histograms.xml | 33 +++ tools/traffic_annotation/summary/annotations.xml | 1 + 8 files changed, 618 insertions(+) commit 2d3e8e7780c4f8b67b80847d37e2ebef4eb66150 Author: Eugene But <eugenebut@google.com> Date: Thu Mar 14 16:47:27 2019 +0000 Use NavigationManager::GetPendingItemIndex instead of CRWSeessionController.pendingItemIndex. CRWSeessionController is always nil if slim-nav is enabled, so this CL makes code more compatible with slim navigation manager feature. This change is one of multiple CLs which will allow storing pending navigation items in navigation context if slim-nav is enabled. Bug: 665189, 899827 Change-Id: I563ca1835bd31eae40c02379526b405c37a6bc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521969 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#640799} ios/web/navigation/legacy_navigation_manager_impl.mm | 4 +--- ios/web/web_state/ui/crw_web_controller.mm | 13 ++++--------- 2 files changed, 5 insertions(+), 12 deletions(-) commit 004d6d20e80809afe2f13567456d86a8989c7295 Author: John Budorick <jbudorick@chromium.org> Date: Thu Mar 14 16:47:12 2019 +0000 Disable flaky ArcPolicyTest. Bug: 941861 Change-Id: Ia6988ac6cf6935f7d9874ac3be2a34701174afe4 Tbr: bartfab@chromium.org,anthonyvd@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524405 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#640798} chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e56a5cad66afef58b3ea5bd32344054e767910f6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 14 16:45:56 2019 +0000 Roll src/third_party/dawn ea2c7f20f2f9..5625b6320279 (1 commits) https://dawn.googlesource.com/dawn.git/+log/ea2c7f20f2f9..5625b6320279 git log ea2c7f20f2f9..5625b6320279 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 senorblanco@chromium.org Fix glTexStorage2D errors. Created with: gclient setdep -r src/third_party/dawn@5625b6320279 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8f22bdf04578aeb5694cb18551d8d8fcd7841f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523107 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#640797} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d3ed7be37596bab2c1a98ddc5649924d98aecf8 Author: Marc Treib <treib@chromium.org> Date: Thu Mar 14 16:39:53 2019 +0000 Add null check to sync_ui_util::GetStatusLabels Apparently it's possible to get here when Sync is disabled via --disable-sync. Let's not crash in that case. Bug: 942044 Change-Id: I67e67a768739a1b86ec84f900bbeaf84ecd6470f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524261 Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#640796} chrome/browser/sync/sync_ui_util.cc | 4 ++++ 1 file changed, 4 insertions(+) Updated tag 'tree_truth' (was 3ae1d7c4c38e)