Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 40152 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918910656067567920 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itkgWv6p/luci_context.393838557 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2228-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 439aa040ffda7311 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 6772582d4c3499cb21fc28656bfcf717eee9c1a6 Disable a few failing inspector-protocol tests. Finnur Thorarinsson, Fri Mar 15 14:43:00 2019 +0000 a595a7cdd07c759366f2c1d4899ba6097934e2a5 Add support for overrides on the consistency tests. G. Silva, Fri Mar 15 14:35:58 2019 +0000 6bb0da9252be517aec17312e9caddfb73f18f65c [ios] Updates build-webkit.py to be easier to run manually. Rohit Rao, Fri Mar 15 14:33:26 2019 +0000 88cd402005df5075e1ee389d001e599cfa1f4a31 Call StopLoading before loading data Olivier Robin, Fri Mar 15 14:31:21 2019 +0000 af143bb75682c2746aa0e28c9ef376b8b65f28ce Roll src/third_party/perfetto 34e6c9d3d1b6..eff66d82dc0d (1 commits) chromium-autoroll, Fri Mar 15 14:29:54 2019 +0000 453267c11fa78fb6fa800c0f210347d84f38519e Add support for usage limits on the consistency tests. G. Silva, Fri Mar 15 14:29:04 2019 +0000 a7fde61eb5014d4a1645cf225a58f166b99ddfcf Fix handling of half-escaped Location headers. David Benjamin, Fri Mar 15 14:20:58 2019 +0000 02cfc79ba8801c578d1d06c6063583f59abfacc6 Do not hold TaskQueue lock while deleting tasks during shutdown Carlos Caballero, Fri Mar 15 14:19:47 2019 +0000 461d2b1cdff4603896597218d6ade24ea02f742a Import wpt@96dd05afd40377e90acd1da0599846be65fa8001 Chromium WPT Sync, Fri Mar 15 14:16:53 2019 +0000 c4eaf35240cab77ec7038facbc7b2eb97dd6782a [auto] Update FlagExpectations for LayoutNG Koji Ishii, Fri Mar 15 14:16:33 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 6772582d4c3499cb21fc28656bfcf717eee9c1a6 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Fri Mar 15 14:43:00 2019 +0000 Disable a few failing inspector-protocol tests. TBR: caseq NOTRY: true Bug: 942517 Change-Id: I35bacfca8ff7882d8871743da0ba7eda6933566a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524358 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#641193} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit a595a7cdd07c759366f2c1d4899ba6097934e2a5 Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 14:35:58 2019 +0000 Add support for overrides on the consistency tests. Also includes new |last_updated| fields on usage limit and bedtime entries and a lot of test cases. Bug: 935711 Change-Id: I589216931896d22f106b9a241ab3e81c5ce48108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518947 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641192} .../consistency_golden_converter.cc | 71 ++++++++++-- .../consistency_golden_converter.h | 14 ++- .../consistency_golden_converter_unittest.cc | 127 +++++++++++++++++++-- .../consistency_test.cc | 5 +- .../consistency_test_utils.cc | 51 +++++++-- .../consistency_test_utils.h | 33 +++++- .../goldens/consistency_golden.proto | 35 ++++++ .../goldens/override_bedtimes.textproto | 110 ++++++++++++++++++ .../goldens/override_then_modify.textproto | 102 +++++++++++++++++ .../override_usage_limits_android.textproto | 61 ++++++++++ .../goldens/override_usage_limits_cros.textproto | 61 ++++++++++ .../goldens/simple_override.textproto | 24 ++++ 12 files changed, 659 insertions(+), 35 deletions(-) commit 6bb0da9252be517aec17312e9caddfb73f18f65c Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Mar 15 14:33:26 2019 +0000 [ios] Updates build-webkit.py to be easier to run manually. Adds a default value for WEBKIT_OUTPUTDIR that matches what ninja is expected to use. Moves "-j" into BUILD.gn, so that invoking build-webkit.py directly doesn't set a limit on the number of parallel jobs. Switches to the argparse in order to pass unparsed commandline arguments along to the underlying build-webkit command. BUG=934252 Change-Id: I6a818a852759558416a0b7e95c75612a1c2c6703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525983 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641191} ios/third_party/webkit/BUILD.gn | 8 ++++++++ ios/third_party/webkit/build_webkit.py | 37 +++++++++++++++++----------------- 2 files changed, 27 insertions(+), 18 deletions(-) commit 88cd402005df5075e1ee389d001e599cfa1f4a31 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Mar 15 14:31:21 2019 +0000 Call StopLoading before loading data |CRWWebController loadData:| will replace the content of the page loaded by the lastCommittedItem. If there is a pending item, this pending loading must be cancelled before proceeding in loading data. This can be the case when loading offline page in place of an uncommitted reloading navigation. Bug: 942025 Change-Id: Id735961110218eb9ede2531c19c33b29879a688f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524264 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641190} ios/web/web_state/ui/crw_web_controller.h | 1 + ios/web/web_state/ui/crw_web_controller.mm | 1 + 2 files changed, 2 insertions(+) commit af143bb75682c2746aa0e28c9ef376b8b65f28ce Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 14:29:54 2019 +0000 Roll src/third_party/perfetto 34e6c9d3d1b6..eff66d82dc0d (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/34e6c9d3d1b6..eff66d82dc0d git log 34e6c9d3d1b6..eff66d82dc0d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 rsavitski@google.com Merge "Remove unused RecordReader." Created with: gclient setdep -r src/third_party/perfetto@eff66d82dc0d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I336b8bd9e10a751d23554af961d4200e27542b51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525815 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641189} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 453267c11fa78fb6fa800c0f210347d84f38519e Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 14:29:04 2019 +0000 Add support for usage limits on the consistency tests. Also, includes two new output fields - |next_active_policy| and |remaining_quota_mins| - and creates utils to make unit tests for the converter more readable. Bug: 935711 Change-Id: If6ac3fe73040b9f50fd46ddb8f4704a2b08006c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514313 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641188} .../consistency_golden_converter.cc | 53 +++++++--- .../consistency_golden_converter_unittest.cc | 107 +++++++++++++++++---- .../consistency_test.cc | 8 +- .../consistency_test_utils.cc | 37 +++++++ .../consistency_test_utils.h | 33 +++++++ .../goldens/consistency_golden.proto | 31 ++++++ .../goldens/simple_bedtimes.textproto | 8 +- .../goldens/simple_usage_limits.textproto | 50 ++++++++++ chrome/test/BUILD.gn | 2 + 9 files changed, 295 insertions(+), 34 deletions(-) commit a7fde61eb5014d4a1645cf225a58f166b99ddfcf Author: David Benjamin <davidben@chromium.org> Date: Fri Mar 15 14:20:58 2019 +0000 Fix handling of half-escaped Location headers. Non-ASCII characters in URLs are supposed to be percent-escaped. This includes when those characters are used in Location headers. However, we tolerate unescaped characters by escaping them ourselves at various stages in the process. ru.wikipedia.org sometimes sends redirects where the path is percent-escaped, but the fragment is not. Previously, we would fix the escaping in the fragment, but leave the path as-is. However, https://chromium-review.googlesource.com/c/chromium/src/+/1366759 switched it to always unformly escape everything, so the %s became %25. This causes us to follow the redirect incorrectly. Uniformly escaping things makes sense for NetLog, where we want to unambiguously represent what the server actually sent, but escaping as part of URL resolution as not intended to be invertible. Restore the old behavior here and add some regression tests. Bug: 942073 Change-Id: I009bc0dc9c5c8f836f072fe23ccd824698d550e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525483 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#641187} net/base/escape.cc | 9 +++++++++ net/base/escape.h | 5 +++++ net/base/escape_unittest.cc | 5 +++++ net/http/http_response_headers.cc | 9 ++++++--- net/url_request/url_request_unittest.cc | 32 ++++++++++++++++++++++++++++++++ 5 files changed, 57 insertions(+), 3 deletions(-) commit 02cfc79ba8801c578d1d06c6063583f59abfacc6 Author: Carlos Caballero <carlscab@google.com> Date: Fri Mar 15 14:19:47 2019 +0000 Do not hold TaskQueue lock while deleting tasks during shutdown Change-Id: I6b18e3ff12d85b1337a63094a5f0ea34704142f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524345 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641186} .../sequence_manager_impl_unittest.cc | 31 +++++++++++++++++----- base/task/sequence_manager/task_queue.cc | 4 +-- 2 files changed, 26 insertions(+), 9 deletions(-) commit 461d2b1cdff4603896597218d6ade24ea02f742a Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 14:16:53 2019 +0000 Import wpt@96dd05afd40377e90acd1da0599846be65fa8001 Using wpt-import in Chromium e04a4c8e055c2864e624b21c3db18ccfb9804cf8. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ice3de01b4b9e58a7ada24a35b3a57e5cfeae9f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525814 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641185} third_party/blink/web_tests/TestExpectations | 6 ++ .../web_tests/external/WPT_BASE_MANIFEST_5.json | 48 ++++++++- .../child-document-raf-order-expected.txt | 4 + .../update-rendering/child-document-raf-order.html | 118 +++++++++++++++++++++ .../fractions/frac-linethickness-004-ref.html | 27 +++++ .../fractions/frac-linethickness-004.html | 30 ++++++ .../web_tests/external/wpt/tools/manifest/item.py | 16 +-- .../external/wpt/tools/manifest/sourcefile.py | 2 + 8 files changed, 234 insertions(+), 17 deletions(-) commit c4eaf35240cab77ec7038facbc7b2eb97dd6782a Author: Koji Ishii <kojii@chromium.org> Date: Fri Mar 15 14:16:33 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 16553 16557 16561 16564 16578 16593 16605 16618 16624 16628 16643 16657 16676 16685 16692 16699 16705 16715 16719 16729 16749 16760 16768 16776 16781 16785 5 lines were removed and 4 lines were deflaked by consecutive results since 16692. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I56d7b4cc9ed153fb7260566643d8c6e4039dd5b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517475 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641184} .../enable-blink-features=LayoutNG | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) commit 2575fe0547ee3c9a58b0a443856f0abb09527a78 Author: Finnur Thorarinsson <finnur@chromium.org> Date: Fri Mar 15 14:09:54 2019 +0000 Disable failing paste-text-016.html test. Failing persistently on multiple Mac bots. TBR: yosin NOTRY: true Bug: 942509 Change-Id: I4f0a6877a30689868a6d1431c515be4d444d9965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526044 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#641183} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit ededf16bac4fd6a9176c2f3a6f5e3b058e26e2d8 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Mar 15 13:58:34 2019 +0000 [AF Profile] Unify model data <-> specifics conversion with Directory This CL removes the additional smartness of the autofill_profile sync bridge and adapts closer to the logic of the syncable service. It is still not cut&paste as this would need more refactoring (to code that is arguably harder to reason about). This CL still leaves around one difference: the syncable service does trim strings as if they were ASCII which may result in incorrect UTF8 strings; the bridge fixes this issue and treats the strings as UTF8. Apart from that, there should be no functional differences. There is a hope that this could reduce inconsistencies in observed autofill_profile sync traffic between USS and Directory. Bug: 904390 Change-Id: Ie5448e0991d56ee435a31c62178c50d2c729d692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520505 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641182} .../core/browser/autofill_profile_sync_util.cc | 207 ++++++++------------- .../browser/autofill_profile_sync_util_unittest.cc | 8 +- 2 files changed, 86 insertions(+), 129 deletions(-) commit fe80676157f90edb8695d6013df7333987ead53f Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 13:57:44 2019 +0000 Roll src-internal 59b9a059b2f8..fa2d5d1b4ecf (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59b9a059b2f8..fa2d5d1b4ecf Created with: gclient setdep -r src-internal@fa2d5d1b4ecf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I013b3b629d698d8bd3d125323d54f7fae37f1d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525816 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641181} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 766b4f772c50479992e1a3943f160b2799d1a5c9 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Mar 15 13:56:18 2019 +0000 [AF Wallet Sync] Remove an obsolete TODO The TODO is already fixed. Bug: 853688 Change-Id: I2b720f860e0bae5eef9eea6f4085c3af11093aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524356 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641180} .../core/browser/webdata/autofill_wallet_metadata_sync_bridge.cc | 1 - 1 file changed, 1 deletion(-) commit 6170a2f1055a1bd59c5e7382a8ce7aef1e681f84 Author: Miyoung Shin <myid.shin@igalia.com> Date: Fri Mar 15 13:55:01 2019 +0000 Change long long to int64_t in third_party/blink/renderer/modules/filesystem/ - long long -> int64_t - No logic change. - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 929984 Change-Id: I223ab28a0ebc9ea19688c619f48b32cf812c4652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524748 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641179} third_party/blink/renderer/modules/filesystem/file_system_callbacks.cc | 2 +- third_party/blink/renderer/modules/filesystem/file_system_callbacks.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 7f0d3109e49ec195b0e09661824647a16639f1f0 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 13:46:55 2019 +0000 Clean up unnecessary Create() factory functions in modules/indexeddb As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/modules/indexeddb and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I189e6024d9db77a45793dbaffbf0e77632be2b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525251 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641178} .../bindings/modules/v8/v8_binding_for_modules_test.cc | 3 +-- .../renderer/modules/indexeddb/idb_factory_test.cc | 4 ++-- .../renderer/modules/indexeddb/idb_object_store.cc | 4 ++-- .../blink/renderer/modules/indexeddb/idb_request.cc | 3 +-- .../renderer/modules/indexeddb/idb_request_test.cc | 8 ++++---- .../renderer/modules/indexeddb/idb_test_helper.cc | 8 ++++---- .../renderer/modules/indexeddb/idb_transaction_test.cc | 12 ++++++------ .../blink/renderer/modules/indexeddb/idb_value.cc | 5 ----- .../blink/renderer/modules/indexeddb/idb_value.h | 6 +----- .../modules/indexeddb/idb_value_wrapping_test.cc | 18 +++++++++--------- .../modules/indexeddb/indexed_db_blink_mojom_traits.cc | 8 ++++---- .../indexeddb/indexed_db_blink_mojom_traits_test.cc | 4 ++-- .../indexeddb/indexed_db_database_callbacks_impl.cc | 4 ++-- .../modules/indexeddb/mock_web_idb_database.cc | 4 ---- .../renderer/modules/indexeddb/mock_web_idb_database.h | 6 +----- .../renderer/modules/indexeddb/mock_web_idb_factory.cc | 4 ---- .../renderer/modules/indexeddb/mock_web_idb_factory.h | 4 +--- .../modules/indexeddb/web_idb_callbacks_impl.cc | 18 ++++++------------ .../modules/indexeddb/web_idb_callbacks_impl.h | 5 +---- .../modules/indexeddb/web_idb_cursor_impl_unittest.cc | 12 ++++++------ .../indexeddb/web_idb_database_impl_unittest.cc | 4 ++-- 21 files changed, 55 insertions(+), 89 deletions(-) commit f9a572ae432399ea4283680b02cdc2b5e7c22215 Author: Christian Dullweber <dullweber@chromium.org> Date: Fri Mar 15 13:46:46 2019 +0000 Remove useless loop from ContentSetting.java This seems to be a very inefficient way to index an array. Change-Id: Ia37a746554c62f669e20931bf4b566bb56bd31b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524353 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#641177} .../chrome/browser/preferences/website/ContentSetting.java | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) commit d1867d9ae36b6e09c0ccb04830887bf2a10b9234 Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Mar 15 13:40:13 2019 +0000 Annotate NativeBackgroundTask.java as BOOTSTRAP tasks In future this will prioritize them which will help ensure native is loaded as soon as possible. Bug: 863341 Change-Id: I93eb8d575adf0e68f5dd7e3554370e7588072beb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524272 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641176} .../background_task_scheduler/NativeBackgroundTask.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit ea301c1941d6468406dd105c1e878cf135a1f29d Author: G. Silva <gfaus@chromium.org> Date: Fri Mar 15 13:37:11 2019 +0000 Create the test suite responsible for running the consistency tests. Also includes the first golden file with a few test cases. Bug: 935711 Change-Id: Ife7bb83aee8789bf81aaeea8f20e173b81a69097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494676 Commit-Queue: G. Silva <gfaus@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641175} .../consistency_test.cc | 62 ++++++++++++++++++++++ .../goldens/simple_bedtimes.textproto | 62 ++++++++++++++++++++++ chrome/test/BUILD.gn | 4 ++ 3 files changed, 128 insertions(+) commit eda183557a2ec0ce8357a3255f9ae565252cc224 Author: Justin Cohen <justincohen@google.com> Date: Fri Mar 15 13:28:29 2019 +0000 Revert "[iOS] Disable [NTPHomeTestCase testOpeningNewTab]." This reverts commit 41b87eb4713304adf24e36b816b035450418b1f9. Reason for revert: Works around bug with tapping on the tab grid button. For some reason, this tap sometimes triggers a long press. Disabling sync and forcing a 50ms tap seems to work. Original change's description: > [iOS] Disable [NTPHomeTestCase testOpeningNewTab]. > > The test fails on the slimnav and full-configs bots. There is no > suspected culprit CL, and the test seems to be failing due to a > grey_tap() action being executed as a grey_longPress(). > > Bug: 933953 > Change-Id: Ic386d911ab962538139db7a948f37843dc985e2a > TBR: gambard@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/1479282 > Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> > Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> > Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#633939} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 933953 Change-Id: I36ca99f02933c6e982bce8139427aa1767f4cfd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505994 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641174} ios/chrome/browser/ui/content_suggestions/BUILD.gn | 1 + .../browser/ui/content_suggestions/ntp_home_egtest.mm | 13 +++++++++---- 2 files changed, 10 insertions(+), 4 deletions(-) commit e5294f17b81e7666a4ea484a0ba6ca38753813bb Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Fri Mar 15 13:26:50 2019 +0000 Print Preview: Change Pin setting availability. Make Pin setting unavailable for unmanaged devices and "unsecure" PrintingAllowedPinModes policy value. Bug: 848942 Change-Id: Id867f203225020b3cec115183de33d9a9f196758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509832 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#641173} chrome/browser/resources/print_preview/new/model.js | 7 ++++++- .../webui/print_preview/model_settings_availability_test.js | 12 ++++++++++++ .../data/webui/print_preview/model_settings_policy_test.js | 13 +++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) commit e2d84ae271ef7e28e3cc694ad9a27590355f15b3 Author: Aaron Tagliaboschi <aarontag@chromium.org> Date: Fri Mar 15 13:24:02 2019 +0000 Adding CookieInclusionStatus to Cookie Manager Adding support for net::CanonicalCookie::CookieInclusionStatus into the Cookie Manager to pass status from getting and setting cookies. Mechanical changes for now, changing the callbacks (and related changes) will come in another commit. Bug: 856777 Change-Id: I89b44571a5d8f26f3ace957b640c4078fa3ccba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520693 Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641172} net/cookies/canonical_cookie.h | 5 +- services/network/public/cpp/BUILD.gn | 1 + services/network/public/cpp/cookie_manager.typemap | 2 + .../public/cpp/cookie_manager_mojom_traits.cc | 135 +++++++++++++++++++++ .../public/cpp/cookie_manager_mojom_traits.h | 26 ++++ .../cpp/cookie_manager_mojom_traits_unittest.cc | 116 ++++++++++++++++++ services/network/public/mojom/cookie_manager.mojom | 29 +++++ 7 files changed, 313 insertions(+), 1 deletion(-) commit ab6264c3594a412e73a71fca21f67a5b7c3b2c9d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 13:19:40 2019 +0000 Update V8 to version 7.5.53. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d1ed1ebd..16271966 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5642f93a0c97073b07404da02632d2b5e3a11e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525812 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641171} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a25c409ebe87ed8165f2b2f51ff7dad9f58b35a8 Author: Andreea Costinas <acostinas@google.com> Date: Fri Mar 15 13:16:11 2019 +0000 Add update mode to policy TPMFirmwareUpdateSettings This CL adds the int-enum option AutoUpdateMode to policy TPMFirmwareUpdateSettings, which controls how TPM firmware update flows are enforced on devices with vulnerable TPM. The option can have one of the following values: 0: Never force update TPM firmware. 1: Update the TPM firmware at the next reboot after user acknowledgment. Implemented in CL:1470751 2: Foce update the TPM firmware at the next reboot. Implemented in CL:1477902 3: Update the TPM firmware after enrollment. Implemented in CL:1483014 Bug:875266 Change-Id: I669560a5fd4671b3fa82694c98b660d535c2ee90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1469462 Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641170} chrome/browser/chromeos/BUILD.gn | 2 + .../policy/browser_policy_connector_chromeos.cc | 5 + .../policy/browser_policy_connector_chromeos.h | 7 ++ .../policy/tpm_auto_update_mode_policy_handler.cc | 102 +++++++++++++++++++++ .../policy/tpm_auto_update_mode_policy_handler.h | 40 ++++++++ chrome/browser/chromeos/tpm_firmware_update.cc | 6 ++ chrome/browser/chromeos/tpm_firmware_update.h | 1 + chrome/test/data/policy/policy_test_cases.json | 3 +- components/policy/proto/chrome_device_policy.proto | 17 ++++ components/policy/resources/policy_templates.json | 12 +++ 10 files changed, 194 insertions(+), 1 deletion(-) commit 93e7806036ae8630679b30a2a726bdc41dad4a83 Author: Takashi Sakamoto <tasak@google.com> Date: Fri Mar 15 13:14:03 2019 +0000 Add py_proto dependency to chrome/chrome_cleaner/test/resources:compute_sample_dll_digest E.g. https://ci.chromium.org/p/chromium/builders/ci/win-rel/12639 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8918950699201116848/+/steps/compile/0/stdout File "../../chrome/chrome_cleaner/tools/compute_digests.py", line 21, in <module> import file_digest_pb2 File "C:\b\swarming\w\ir\cache\builder\src\out\Release_x64\pyproto\chrome\chrome_cleaner\proto\file_digest_pb2.py", line 22, in <module> TypeError: __init__() got an unexpected keyword argument 'serialized_options' FAILED: gen/chrome/chrome_cleaner/test/resources/sample_dll_digest.pb Change-Id: I3249bc3b56207bf68d33044e69f858308037b66f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525259 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#641169} chrome/chrome_cleaner/test/resources/BUILD.gn | 1 + 1 file changed, 1 insertion(+) commit 5d9cb96d4d51f827da22d400c51f6a1683c88900 Author: Marc Treib <treib@chromium.org> Date: Fri Mar 15 13:05:40 2019 +0000 Introduce MockSyncService It's a straightforward mock implementation of SyncService. It's not used so far, but it will be used soon to replace ProfileSyncServiceMock. Bug: 910518 Change-Id: Ifcc3172993991d8698ae5429b387c7149638d2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524277 Reviewed-by: Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641168} components/sync/BUILD.gn | 2 + components/sync/driver/mock_sync_service.cc | 25 ++++++++ components/sync/driver/mock_sync_service.h | 99 +++++++++++++++++++++++++++++ 3 files changed, 126 insertions(+) commit 7c523243a37679f4e4bfa97129f754476fe63398 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 13:04:39 2019 +0000 Roll src/third_party/swiftshader 633b2fb00ed0..e37ce613d1c7 (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/633b2fb00ed0..e37ce613d1c7 git log 633b2fb00ed0..e37ce613d1c7 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 bclayton@google.com SpirvShader: Implement OpBranch 2019-03-15 bclayton@google.com Reactor: Add even more RR_WATCH_FMT_ overloads Created with: gclient setdep -r src/third_party/swiftshader@e37ce613d1c7 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I85cb3cb755ed1608c185d2428e1b7423f9e76db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525810 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641167} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 87c784fdfe5746e2f5d021b5df70b924363a9bca Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 13:04:36 2019 +0000 Roll src/third_party/skia d2493a1e53ba..69600007e278 (1 commits) https://skia.googlesource.com/skia.git/+log/d2493a1e53ba..69600007e278 git log d2493a1e53ba..69600007e278 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 633b2fb00ed0..e37ce613d1c7 (2 commits) Created with: gclient setdep -r src/third_party/skia@69600007e278 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I37a9a26bf40117600c708ab2107ffc641e9f6898 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525813 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641166} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 363e9bb9c2ff9d1f70f6cccbd9e9c89196a9440d Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 12:40:28 2019 +0000 Clean up unnecessary Create() factory functions in modules/webdatabase As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/modules/webdatabase and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ieb05b6cc4a8e4f6a0938c0732bd6ec68a100fd69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524395 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641165} .../modules/webdatabase/change_version_wrapper.cc | 7 ++-- .../blink/renderer/modules/webdatabase/database.cc | 17 ++++----- .../renderer/modules/webdatabase/database_task.h | 42 +++------------------- .../blink/renderer/modules/webdatabase/sql_error.h | 18 +++------- .../modules/webdatabase/sql_statement_backend.cc | 13 +++---- .../modules/webdatabase/sql_transaction.cc | 13 +++---- .../modules/webdatabase/sql_transaction_backend.cc | 14 ++++---- 7 files changed, 43 insertions(+), 81 deletions(-) commit bd555610161ed4963beab8bcdf23782fe87cb6cf Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 12:33:04 2019 +0000 Roll src-internal 798a5f3dda67..59b9a059b2f8 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/798a5f3dda67..59b9a059b2f8 Created with: gclient setdep -r src-internal@59b9a059b2f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I335db1ea7658305c206468fc4da82ca143e782f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525811 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641164} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e68791c36431d0698fa550f2701365c9d514dd1e Author: Oleh Lamzin <lamzin@google.com> Date: Fri Mar 15 12:25:24 2019 +0000 Add DevicePowerPeakShift* device policies Add DevicePowerPeakShiftEnabled, DevicePowerPeakShiftBatteryThreshold and DevicePowerPeakShiftDayConfig device policies. Peak Shift is power saving policy that minimizes alternating current usage during the peak usage times during the day. BUG=b:123925343 TEST=unit_tests/browser_tests Change-Id: I27318e3b2471d45b8257b7e54b463dd30c4e797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491951 Commit-Queue: Oleh Lamzin <lamzin@google.com> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Lutz Justen <ljusten@chromium.org> Reviewed-by: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#641163} ash/public/cpp/ash_pref_names.cc | 10 ++ ash/public/cpp/ash_pref_names.h | 4 + ash/shell.cc | 1 + ash/system/power/power_prefs.cc | 10 ++ ash/system/power/power_prefs.h | 4 + .../policy/device_policy_decoder_chromeos.cc | 22 ++++ .../configuration_policy_handler_list_factory.cc | 9 ++ chrome/test/data/policy/policy_test_cases.json | 68 +++++++++++ components/policy/proto/chrome_device_policy.proto | 18 +++ components/policy/resources/policy_templates.json | 136 ++++++++++++++++++++- tools/metrics/histograms/enums.xml | 3 + 11 files changed, 284 insertions(+), 1 deletion(-) commit 4031f28e181ae3a335f80f5d3dc5945e694fe76c Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Mar 15 12:24:07 2019 +0000 Don't match prefers-color-scheme:dark with forced darkening. Forced darkening will adjust the page after author styles are applied. We don't match @media (prefers-color-scheme:dark) which may cause author content to try to adapt before the forced darkening is applied. Bug: 889087 Change-Id: I324ba83ababd568d9c31b198390dce183ec4f402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523766 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641162} .../blink/renderer/core/css/media_values.cc | 2 ++ .../blink/renderer/core/css/style_engine_test.cc | 25 ++++++++++++++++++++++ 2 files changed, 27 insertions(+) commit 5c96b7e56d4dd9a2d72f6ad88ea9feac55fb902f Author: Lin Sun <lin.sun@intel.com> Date: Fri Mar 15 12:13:08 2019 +0000 Remove flaky WebGL2 suppressions for Linux/Intel Bug: 618447, 872302 Change-Id: I0f93c86fedc6ffc22bab5fcc3516be7012f714d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506095 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Lin Sun <lin.sun@intel.com> Cr-Commit-Position: refs/heads/master@{#641161} content/test/gpu/gpu_tests/webgl2_conformance_expectations.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) commit 0a3218a8bfa93ad43b1ad4df4fe7413451c2764c Author: Balazs Engedy <engedy@chromium.org> Date: Fri Mar 15 12:09:59 2019 +0000 Make engedy@ OWNER of content_settings. Bug: None Change-Id: If5a10d821e7ab228dba6dfd72dff2318762ee1e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525923 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#641160} chrome/browser/content_settings/OWNERS | 1 + chrome/browser/ui/content_settings/OWNERS | 1 + components/content_settings/OWNERS | 1 + 3 files changed, 3 insertions(+) commit d029437cb3bfe3585d893fa8b716d25831b30d14 Author: Yuki Shiino <yukishiino@chromium.org> Date: Fri Mar 15 11:57:22 2019 +0000 v8binding: Treat |optional any arg = null| as v8::Null |ScriptValue()| creates an empty ScriptValue, which corresponds to |v8::Local<v8::Value>()| (empty handle), which will be v8::Undefined. It's not v8::Null. This patch makes it v8::Null explicitly. Change-Id: Ibf5afaff05174bb1458e86fc84fd8c8e8010a6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520523 Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641159} third_party/blink/renderer/bindings/scripts/v8_types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 463cf9e8847a310f7a5ef0b8fae77750fc94e22c Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:54:40 2019 +0000 Clean up unnecessary Create() factory functions in modules' medaistream and service_worker As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/modules/mediastream and service_worker and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: If0e295dcc02093c7c70d29e559705e004ed930cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525260 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641158} .../blink/renderer/modules/mediastream/user_media_client.h | 6 +----- third_party/blink/renderer/modules/modules_initializer.cc | 3 ++- .../service_worker/service_worker_installed_scripts_manager.cc | 2 +- .../modules/service_worker/thread_safe_script_container.cc | 9 --------- .../modules/service_worker/thread_safe_script_container.h | 10 +++------- .../service_worker/thread_safe_script_container_test.cc | 9 +++++---- 6 files changed, 12 insertions(+), 27 deletions(-) commit 86b7b16e74e935d2103d2dbea8c21ada198220e2 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:53:55 2019 +0000 Remove WebRTCStatsReportCallbackResolver::Create in modules/peerconnection As advised in [1], this CL removes unnecessary WebRTCStatsReportCallbackResolver::Create() in //third_party/blink/renderer/modules/indexeddb and make their constructors public, then make the callers use std::make_unique<WebRTCStatsReportCallbackResolver> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I2adebce9cf1df122e400a08a83bc9f9aa895c6b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524391 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641157} .../blink/renderer/modules/peerconnection/rtc_peer_connection.cc | 5 +++-- .../blink/renderer/modules/peerconnection/rtc_rtp_receiver.cc | 5 +++-- .../blink/renderer/modules/peerconnection/rtc_rtp_sender.cc | 5 +++-- .../peerconnection/web_rtc_stats_report_callback_resolver.cc | 7 ------- .../peerconnection/web_rtc_stats_report_callback_resolver.h | 5 +---- 5 files changed, 10 insertions(+), 17 deletions(-) commit a9296c7b266ddbc19d22606d34384607038d362f Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:53:35 2019 +0000 Clean up unnecessary Create() factory functions in platform/audio As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/audio and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic613dd9ef74061fe92234fbd9680cab37f3db5d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525762 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641156} .../modules/webaudio/stereo_panner_node.cc | 2 +- .../blink/renderer/platform/audio/hrtf_database.cc | 4 --- .../blink/renderer/platform/audio/hrtf_database.h | 4 +-- .../platform/audio/hrtf_database_loader.cc | 2 +- .../renderer/platform/audio/hrtf_elevation.cc | 8 +++--- .../blink/renderer/platform/audio/hrtf_kernel.cc | 4 +-- .../blink/renderer/platform/audio/hrtf_kernel.h | 29 ++++++---------------- .../blink/renderer/platform/audio/stereo_panner.cc | 4 --- .../blink/renderer/platform/audio/stereo_panner.h | 4 +-- 9 files changed, 17 insertions(+), 44 deletions(-) commit 3941c4781bd0d88283d671805ed22283e49b163d Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:52:50 2019 +0000 Remove BlobData::Create() in blink As advised in [1], this CL removes unnecessary BlobData::Create() in //third_party/blink/renderer/ and make it's constructors public, then make the callers use std::make_unique<BlobData> instead of their Create() factory function. Additionally this CL makes to use auto keyword when creating a local variable by using std::make_unique<BlobData> because it's clear the returned type is std::unique_ptr. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Id5800e816128f640f79e1c422ff0b98a57798e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525786 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641155} .../renderer/core/clipboard/data_object_item.cc | 2 +- .../blink/renderer/core/exported/web_blob.cc | 2 +- third_party/blink/renderer/core/fetch/body.cc | 2 +- .../renderer/core/fetch/body_stream_buffer_test.cc | 2 +- .../renderer/core/fetch/bytes_consumer_tee_test.cc | 4 ++-- .../blink/renderer/core/fetch/fetch_data_loader.cc | 6 ++--- .../renderer/core/fetch/fetch_data_loader_test.cc | 4 ++-- .../core/fetch/form_data_bytes_consumer.cc | 4 ++-- .../core/fetch/form_data_bytes_consumer_test.cc | 2 +- third_party/blink/renderer/core/fileapi/blob.cc | 6 ++--- third_party/blink/renderer/core/fileapi/file.cc | 10 ++++----- .../core/xmlhttprequest/xml_http_request.cc | 4 ++-- .../blink/renderer/modules/cache_storage/cache.cc | 4 ++-- .../modules/filesystem/file_system_dispatcher.cc | 2 +- .../modules/indexeddb/idb_value_wrapping.cc | 2 +- .../modules/mediarecorder/media_recorder.cc | 2 +- .../presentation/presentation_connection.cc | 2 +- .../modules/push_messaging/push_message_data.cc | 2 +- .../renderer/modules/websockets/dom_websocket.cc | 2 +- .../blink/renderer/platform/blob/blob_data.cc | 5 ----- .../blink/renderer/platform/blob/blob_data.h | 16 ++++++------- .../blink/renderer/platform/blob/blob_data_test.cc | 26 +++++++++++----------- 22 files changed, 52 insertions(+), 59 deletions(-) commit bf60ea0026156b48884edd4817ef17c54cbb31f9 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Mar 15 11:52:30 2019 +0000 Clean up unnecessary Create() factory functions in platform/bindings As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/bindings and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I0a28a2b8ce259313b6e2c55ed69d6d52eb36437d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525767 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641154} .../bindings/core/v8/v0_custom_element_constructor_builder.cc | 4 ++-- third_party/blink/renderer/platform/bindings/script_state.cc | 2 +- .../blink/renderer/platform/bindings/v0_custom_element_binding.cc | 6 ------ .../blink/renderer/platform/bindings/v0_custom_element_binding.h | 5 +---- .../blink/renderer/platform/bindings/v8_per_context_data.cc | 5 ----- .../blink/renderer/platform/bindings/v8_per_context_data.h | 4 +--- .../blink/renderer/platform/bindings/v8_per_isolate_data.cc | 4 ++-- .../blink/renderer/platform/bindings/v8_private_property.h | 8 ++------ 8 files changed, 9 insertions(+), 29 deletions(-) commit 8532eaa24218e5856bb969f87a2a749abf6fb70c Author: Robbie Gibson <rkgibson@google.com> Date: Fri Mar 15 11:43:24 2019 +0000 Switch Bing search-by-image to upload image data instead of URL The current Bing Search-by-image URL is the one for searching based off of an image's url. However, we now have cases where we want to search by the image data, which uses a different parameter. Also, in all cases where we search with the url today, we also have the image data already. This CL also adds support for converting the image data to a base64 encoding, as that is what Bing uses. If there is some process for updating search engines, let me know. I also thought about a way to support both versions of the image search url (search by url and image data) but couldn't come up with a good solution. Bug: 938669 Change-Id: I978c7a45bcd37835cda15f43a93bec0b8737b6bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508394 Reviewed-by: Orin Jaworski <orinj@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#641153} components/search_engines/prepopulated_engines.json | 6 +++--- components/search_engines/template_url.cc | 14 ++++++++++++++ components/search_engines/template_url.h | 1 + components/search_engines/template_url_unittest.cc | 14 ++++++++++++-- 4 files changed, 30 insertions(+), 5 deletions(-) commit c6b4325b4fc9acb774ca9956fb76d37325bebd6c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 11:40:41 2019 +0000 Roll src/third_party/skia aefecad7c0d2..d2493a1e53ba (1 commits) https://skia.googlesource.com/skia.git/+log/aefecad7c0d2..d2493a1e53ba git log aefecad7c0d2..d2493a1e53ba --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1b8cd2d9ce2c..633b2fb00ed0 (1 commits) Created with: gclient setdep -r src/third_party/skia@d2493a1e53ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6889d98e44029bfa62bd8779d583b2724c7468ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525808 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641152} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bfcf35ffb0447b9e863a10768e23989a952a939b Author: iOS Autoroller <ios-autoroller@chromium.org> Date: Fri Mar 15 11:40:00 2019 +0000 [MDC roll] Roll Material Components to d4fdb374214cfe2010d167338affd3fa9e67263c TBR=smut Change-Id: Ibe4f52c66ed13d88b41b902c805b03b34fe993ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525419 Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org> Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#641151} DEPS | 2 +- ios/third_party/material_components_ios/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e04a4c8e055c2864e624b21c3db18ccfb9804cf8 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 11:22:11 2019 +0000 Update V8 to version 7.5.50. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4181d035..d1ed1ebd Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I53e7c07d83fe3bf80051a05b57852875951d5eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525473 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641150} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c6a0a663cf3715fdf2d1187c398cb903cafdbe21 Author: Boris Sazonov <bsazonov@chromium.org> Date: Fri Mar 15 11:15:31 2019 +0000 [Android] Extract FreIntentCreator This CL extracts FreIntentCreator class that takes care of creating an intent to launch First Run Experience. Instances of this class are created using AppHooks, allowing downstream adjustments. Bug: 942175 Change-Id: I7f5c67d91f8d09d8b9945af87e6f905d1b67149c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520605 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#641149} .../src/org/chromium/chrome/browser/AppHooks.java | 8 + .../browser/firstrun/FirstRunFlowSequencer.java | 159 +----------------- .../chrome/browser/firstrun/FreIntentCreator.java | 183 +++++++++++++++++++++ chrome/android/java_sources.gni | 1 + 4 files changed, 197 insertions(+), 154 deletions(-) commit 52e32015d63e910a64a0829041142780a2b9cc86 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Fri Mar 15 11:02:50 2019 +0000 a11y: Fix cfi-icall failure Control Flow Integrity indirect call checking [1] verifies that indirect calls are only made to functions defined with a type signature that matches the function pointer type. The accessibility_unittests fail with CFI-icall enabled when a test casts a lambda so types don't match; however, from my brief look at ATK I believe that 3rd-party DSOs can also register callbacks. There is currently only a way to safely perform calls to functions that are address-taken in other DSOs when there is a single possible target. Hence, disable CFI-icall here for now. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 941466 Change-Id: If4550beb1101c8077f394e717b5bdc052e173049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524649 Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#641148} ui/accessibility/platform/atk_util_auralinux.cc | 2 ++ 1 file changed, 2 insertions(+) commit 6b998b00a2a930b24c8b006344595630389d6cef Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 10:58:10 2019 +0000 Import wpt@b90e1587455350962c4efc39b7c1bbf588d6ab64 Using wpt-import in Chromium 80d04032c47e38b504e174750ec5bcb9900e482a. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I846b81cf7b8a0e7c53987cf49031bde4cdbd7232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525675 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641147} third_party/blink/web_tests/TestExpectations | 5 - .../web_tests/external/WPT_BASE_MANIFEST_5.json | 145 ++++++++++++++------- .../external/wpt/interfaces/wake-lock.idl | 13 +- .../wake-lock/idlharness.https.any-expected.txt | 21 +++ .../external/wpt/wake-lock/idlharness.https.any.js | 16 +++ .../idlharness.https.any.worker-expected.txt | 21 +++ .../wpt/wake-lock/idlharness.https.window.js | 31 ----- .../external/wpt/wake-lock/wakelock-api.https.html | 20 --- ...akelock-applicability-manual.https-expected.txt | 5 + .../wakelock-applicability-manual.https.html | 26 ++-- .../wpt/wake-lock/wakelock-cancel-twice.https.html | 20 --- .../wakelock-document-hidden.https-expected.txt | 4 + .../wake-lock/wakelock-document-hidden.https.html | 10 +- .../wpt/wake-lock/wakelock-insecure-context.html | 2 +- .../wakelock-onactivechange.https-expected.txt | 4 + .../wake-lock/wakelock-onactivechange.https.html | 9 +- .../wpt/wake-lock/wakelock-promise.https.html | 13 -- .../wakelock-state-is-global.https-expected.txt | 4 + .../wake-lock/wakelock-state-is-global.https.html | 12 +- .../wpt/wake-lock/wakelock-type.https-expected.txt | 7 + .../wpt/wake-lock/wakelock-type.https.html | 28 ++-- .../wakelockrequest-is-independent.https.html | 15 --- .../nested-context-navigations-expected.txt | 0 .../nested-context-navigations-expected.txt | 21 +++ 24 files changed, 261 insertions(+), 191 deletions(-) commit 7272f741496ecd9aab6013c328c24a193c868d07 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Fri Mar 15 10:48:13 2019 +0000 Make autofill tests working with RenderDocument. RenderDocument is making Chrome switching RenderFrameHost on each Documents. RenderFrameHost are currently switched on each cross-process navigations. In the future, they will be switched on each same-process navigation as well. The class autofill_uitest instruments the AutofillManager associated with the current main RenderFrameHost. The tests assumes it will be preserved. With RenderDocument, it will be swapped after each new document. This CL makes the following RenderFrameHost to be instrumented as well. Bug: 936696, 940935 Change-Id: I23f9785781df1b1921778d1ff6269d69e248ff92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520843 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641146} chrome/browser/autofill/autofill_uitest.cc | 20 +++++++++++++++----- chrome/browser/autofill/autofill_uitest.h | 8 +++++++- 2 files changed, 22 insertions(+), 6 deletions(-) commit d92df3877b1aa5926abdb5bcd99cb55ba5bf3ffe Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 10:44:31 2019 +0000 Roll src/third_party/swiftshader 1b8cd2d9ce2c..633b2fb00ed0 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1b8cd2d9ce2c..633b2fb00ed0 git log 1b8cd2d9ce2c..633b2fb00ed0 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 swiftshader.regress@gmail.com Regres: Update test lists @ 1b8cd2d9 Created with: gclient setdep -r src/third_party/swiftshader@633b2fb00ed0 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I67f5d65972780f949c3f86d35e16fe5aec5a802d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525807 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641145} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9cb0c848a58b49ae9e75e9d25e9e1400cc9fbed7 Author: Marc Treib <treib@chromium.org> Date: Fri Mar 15 10:40:22 2019 +0000 Rewrite ExternalPrefLoaderTest in terms of TestSyncService ...instead of ProfileSyncServiceMock, which is an antipattern. Bug: 910518 Change-Id: I4ff332d9aa851886954e0a1c72da296668c56915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523706 Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#641144} .../extensions/external_pref_loader_unittest.cc | 42 +++++----------------- 1 file changed, 9 insertions(+), 33 deletions(-) commit 9c67c048f084beaeeee9a53146f9184cfe156399 Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Mar 15 10:40:19 2019 +0000 Revert "media: Remove VaapiVP8Encoder media_feature" This reverts commit 169c1a699fcc58ee3bfb3cd30f02484794056adb. The VP8 stream generated by using VA-API causes some issues on targets. To disable HW VP8 encoding using VA-API via finch, we should recover this feature variable. TBR=beccahughes@chromium.org Bug: 942419 Test: None Change-Id: I5617fa55e3cb1af74b1e4fe7eaef1ed84e681c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525784 Reviewed-by: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641143} media/base/media_switches.cc | 4 ++++ media/base/media_switches.h | 1 + media/gpu/vaapi/vaapi_wrapper.cc | 7 +++++++ 3 files changed, 12 insertions(+) commit cf85bf419e279db0d606f15e6035d32e90161a5e Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Mar 15 09:56:18 2019 +0000 Use failing URL to load the error page. VirtualURL should not be used as the baseURL to load error page. VirtualURL can be set by the client and can be different from URL which will will lead to navigationItem inconsistencies. Instead, the WebView should load the failing URL or the URL extracted from the placeholder. Bug: 942025 Change-Id: I425ff6c62aedf9d205a6918e5655bad3a7cca54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524263 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641142} ios/web/web_state/error_page_inttest.mm | 20 ++++++++++++++++++++ ios/web/web_state/ui/crw_web_controller.mm | 17 ++++++++--------- 2 files changed, 28 insertions(+), 9 deletions(-) commit 72a1bcfe791c4bb76c654d8caa2190a327bbf854 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri Mar 15 09:46:09 2019 +0000 [css-multicol] Mark some functions/classes final R=mstensho@chromium.org Change-Id: Ic60362dee1a92a029c470ee06ac3f007f3f08142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524904 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#641141} .../core/layout/layout_multi_column_flow_thread.h | 16 ++++++++-------- .../blink/renderer/core/layout/layout_multi_column_set.h | 2 +- .../renderer/core/layout/layout_paged_flow_thread.h | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) commit c7ed6319ca44efd25367d3d89759e78a7088d52e Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 09:45:03 2019 +0000 Roll src-internal ff717d8fff9b..798a5f3dda67 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff717d8fff9b..798a5f3dda67 Created with: gclient setdep -r src-internal@798a5f3dda67 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I784cc616761f2eb8b15ef20106021db585c24d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525806 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641140} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 00804c8d0bb340e2b5b38157f6ae6b2353fb5d6e Author: Dominik Röttsches <drott@chromium.org> Date: Fri Mar 15 09:44:01 2019 +0000 Roll src/third_party/harfbuzz-ng/src/ 4f37ab63d..8aaab78ef (16 commits) https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/4f37ab63de97..8aaab78efcac The included fix for HarfBuzz issue #1617 addresses Chromium issue 939285, the rejection at sanitisation stage of variable fonts with 0 named instances. $ git log 4f37ab63d..8aaab78ef --date=short --no-merges --format='%ad %ae %s' 2019-03-14 ebrahim Allow zero length ranges in sanitization (#1617) 2019-03-14 khaledhosny [ci] Cache FreeType build on Travis 2019-03-12 corbett.dav Categorize U+09FC as Consonant_Placeholder 2019-03-13 khaledhosny [ci] Simplify and fix Travis CI macOS build 2019-03-11 behdad Remove redundant hb_ot_layout_lookup_would_substitute_fast 2019-03-12 khaledhosny [doc] Add placeholder since version for new flag 2019-03-08 corbett.dav Remove obsolete overrides from Indic/USE scripts 2019-02-12 emuller Update generation code for hb-ot-shape-complex-vowel-constraints.cc. Remove 'unlikely' 2019-02-10 emuller Fix coding style. 2019-02-09 emuller Add a flag to hb_buffer_t to prevent the insertion of dotted circles on incorrect character sequences. 2019-03-08 ebrahim Add a macOS 10.14.3 fonts tests (#1608) 2019-03-06 corbett.dav Update to Unicode 12.0.0 2019-02-13 adrianwjw [indic] Remove superfluous ZWNJ check in final reorder of pre-base matras 2019-03-05 sbergman Fix hb_atomic_* variants based on C++11 atomics 2019-03-04 martin_hosken Fix offset drift in graphite integration 2019-03-02 ebrahim Minor, remove .editorconfig hack Created with: roll-dep src/third_party/harfbuzz-ng/src TBR=bashi@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 939285 Change-Id: I1a2db150a65db902a6cb2890f93b04e7430357fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524292 Reviewed-by: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#641139} DEPS | 2 +- third_party/harfbuzz-ng/README.chromium | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) commit 8a24757ea784afcc4cedf29cbd33984f4feea29b Author: Yu-Hsuan Hsu <yuhsuan@chromium.org> Date: Fri Mar 15 09:43:58 2019 +0000 Moving SoundsManager to use audio service Don't use audio manager instance directly to create output streams in SoundsManager, use audio service instead. In detail, use output device in audio_stream_handler. Bug: 847212 Change-Id: I8ff131af309ed9b0a5e27e59bdffbe63e241deab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482276 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Reviewed-by: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641138} .../chromeos/chrome_browser_main_chromeos.cc | 5 +- chrome/browser/chromeos/login/kiosk_browsertest.cc | 7 +- .../chromeos/login/lock/screen_locker_unittest.cc | 18 ++- chrome/browser/vr/sounds_manager_audio_delegate.cc | 9 +- services/audio/BUILD.gn | 2 - services/audio/public/cpp/BUILD.gn | 2 + .../audio/public/cpp/debug_recording_session.cc | 1 - .../public/cpp/sounds/audio_stream_handler.cc | 145 +++++++++------------ .../audio/public/cpp/sounds/audio_stream_handler.h | 25 ++-- .../cpp/sounds/audio_stream_handler_unittest.cc | 60 ++++----- services/audio/public/cpp/sounds/sounds_manager.cc | 15 ++- services/audio/public/cpp/sounds/sounds_manager.h | 5 +- .../public/cpp/sounds/sounds_manager_unittest.cc | 26 +--- services/audio/public/cpp/sounds/test_data.cc | 23 +++- services/audio/public/cpp/sounds/test_data.h | 22 ++-- 15 files changed, 186 insertions(+), 179 deletions(-) commit 29d132569770b641c28e5cc5dab7e021121cf138 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 09:38:38 2019 +0000 Roll src/third_party/dawn d263d752ac35..931311700c7c (1 commits) https://dawn.googlesource.com/dawn.git/+log/d263d752ac35..931311700c7c git log d263d752ac35..931311700c7c --date=short --no-merges --format='%ad %ae %s' 2019-03-15 jiawei.shao@intel.com Add validation on the sample count of the depth stencil attachment Created with: gclient setdep -r src/third_party/dawn@931311700c7c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ida00edb4fa4cb68defdbec638a98cdee583edd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525802 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641137} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e722f040f6f467b42aa897d4d26c0a28602f0789 Author: Anders Hartvoll Ruud <andruud@chromium.org> Date: Fri Mar 15 09:35:28 2019 +0000 [ribbon] Merge css_property_base_custom.cc into css_property.cc. Now that CSSProperty is not generated, we don't need this file. Note: The functions have been moved without any modification. Change-Id: I1ab12d34b9df452ecea74a7f977b0719e8bdc892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506514 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641136} third_party/blink/renderer/core/css/BUILD.gn | 1 - .../renderer/core/css/properties/css_property.cc | 91 ++++++++++++++++++ .../css/properties/css_property_base_custom.cc | 103 --------------------- 3 files changed, 91 insertions(+), 104 deletions(-) commit 10142116fbc66f09b8af63bea339254ef0e6ac74 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 09:33:17 2019 +0000 Roll Fuchsia SDK from 1a0b0112a4d8 to 644d5b59c068 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I71bbea5dedcf93d83713ed9de9b54764a5ec4053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525805 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641135} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit d6e25304636313702a581628263139eee1f4cff1 Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Fri Mar 15 09:19:43 2019 +0000 Format brackets in PasswordManager::OnPasswordFormsRendered. Change-Id: I56603ab0a9ceed0f8df23ff4b4e9512b63b03ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524271 Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#641134} .../core/browser/password_manager.cc | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) commit 8d3be0305b450d2eedccf12863b38118cd511e36 Author: Mario Sanchez Prada <mario@igalia.com> Date: Fri Mar 15 09:16:56 2019 +0000 Migrate ServiceWorkerScriptCacheMap methods to net::CompletionOnceCallback Replace usage of net::CompletionCallback and update callers. Bug: 807724 Change-Id: I90f180fa481ea20e5e67aaab08f27e421342ca39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524045 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641133} .../service_worker/service_worker_script_cache_map.cc | 19 +++++++++++-------- .../service_worker/service_worker_script_cache_map.h | 8 ++++---- .../browser/service_worker/service_worker_version.cc | 8 ++++---- 3 files changed, 19 insertions(+), 16 deletions(-) commit 082829750298c5c54b14187123c07d6b2d2eb7ad Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Mar 15 09:12:24 2019 +0000 [java] Prioritize bootstrap and navigation tasks behind a feature flag. When prioritizing tasks SingleThreadTaskRunnerImpl will post async messages at the head of the queue. It's important for these messages to be async because we want to bypass the java fences and run the tasks immediately, rather than having them batched up to run every vsync. Bug: 863341 Change-Id: I4faf7846e628cc05c05809e626d22788ae9a148c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514533 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641132} .../base/task/SingleThreadTaskRunnerImpl.java | 45 +++++++++++++++++++--- .../base/task/SingleThreadTaskRunnerImplTest.java | 37 ++++++++++++++++-- .../browser/init/ProcessInitializationHandler.java | 3 ++ .../browser/BrowserTaskExecutor.java | 29 +++++++++++++- .../browser/scheduler/UiThreadSchedulerTest.java | 32 +++++++++++++++ 5 files changed, 135 insertions(+), 11 deletions(-) commit 0709283f45fa0c69e411c99a2043481ab78b0d5a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 09:00:14 2019 +0000 Roll src/third_party/chromite 5d06c3522353..35b4e4c67938 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d06c3522353..35b4e4c67938 git log 5d06c3522353..35b4e4c67938 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dhanyaganesh@chromium.org chromite: Use master_buildbucket_id instead of master_build_id Created with: gclient setdep -r src/third_party/chromite@35b4e4c67938 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I3d3138b4655d0033f907d24640d645a87a455b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525804 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641131} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 455cad9e41974edec1df88f7aa42d9ae8ce87877 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Mar 15 08:48:46 2019 +0000 RemoteMacViews: Replace IOSurface with CAContext in gfx::CALayerParams A gfx::CALayerParams may pass the content to be drawn across processes via either an IOSurface (sent as mach port) or a CAContextID (which is an integer). For historical reasons (software compositing output surfaces used to be based in the browser process), software compositing uses IOSurfaces instead of CAContextIDs. The mojo connection to the app shim process does not support sending mach ports, which results in nothing being drawn when using software compositing. To work around this issue, add a IOSurfaceToRemoteLayerInterceptor that inspects the gfx::CALayerParameters before they are sent from BridgedNativeWidgetHost to its BridgedNativeWidget, and re-packages the IOSurface as a CAContextID on the fly. Restrict this workaround to only be applied when the BridgedNativeWidget is out-of-process (that is, when using a PWA) to avoid unforeseen consequences impacting release branches. Bug: 942213 Change-Id: I30ff907e62d9d4c9416bfde9771529a13e012600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525625 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#641130} ui/views/BUILD.gn | 1 + ui/views/cocoa/bridged_native_widget_host_impl.h | 6 ++ ui/views/cocoa/bridged_native_widget_host_impl.mm | 78 ++++++++++++++++++++++- 3 files changed, 83 insertions(+), 2 deletions(-) commit 1f4ad234db2f13bbaa280b7e933ed9b888b0e35b Author: Richard Knoll <knollr@chromium.org> Date: Fri Mar 15 08:46:40 2019 +0000 Invalidate notification content view on update. We need to recalculate the layout as the right content might add or remove the icon view on update. Bug: 937862 Change-Id: Ibc96cb0580c9fcd3f6446d5a969b63ed6dcbf5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523391 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641129} ui/message_center/views/notification_view_md.cc | 2 +- ui/message_center/views/notification_view_md.h | 25 +++++++++++----------- .../views/notification_view_md_unittest.cc | 25 ++++++++++++++++++++++ 3 files changed, 39 insertions(+), 13 deletions(-) commit 86ac38b4d765e1b4945678e85179060c42e52d8c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 08:44:00 2019 +0000 Update V8 to version 7.5.48. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e6ea6c00..4181d035 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idd0b1091d0a43f79a40dfd9609ce3cf0b75fae59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525683 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641128} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 906b794a4ef51432fb2cf08f2bd54b5109aa5c38 Author: Siye Liu <siliu@microsoft.com> Date: Fri Mar 15 08:41:30 2019 +0000 Hook up InputMethodWinTSF with IME extension on Windows. This CL hooks up InputMethodWinTsf with IME extension. Since ui::TSFBridge may be null for unit tests, this Cl also adds protection in InputMethodWinTSF. Bug: 657623 Change-Id: I608ceba376f0fdba537339030d35c11993e16822 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507234 Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#641127} ui/base/ime/input_method_win_base.cc | 44 +++++++++++++++++++++++++++++++++++ ui/base/ime/input_method_win_base.h | 13 +++++++++++ ui/base/ime/input_method_win_imm32.cc | 36 ++++------------------------ ui/base/ime/input_method_win_tsf.cc | 41 +++++++++++++++++++++++++++----- ui/base/ime/win/tsf_text_store.cc | 2 +- 5 files changed, 97 insertions(+), 39 deletions(-) commit 789f0c99464682927ad8c2edfc5c5c787061e0d6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 08:37:09 2019 +0000 Roll src/third_party/skia 61d38ade8c1d..aefecad7c0d2 (1 commits) https://skia.googlesource.com/skia.git/+log/61d38ade8c1d..aefecad7c0d2 git log 61d38ade8c1d..aefecad7c0d2 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 6299cd6e9d2d..558a982945cf (482 commits) Created with: gclient setdep -r src/third_party/skia@aefecad7c0d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I7f933a6902fdd6e893e026b07b75a9b7843e3098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525803 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641126} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 418708c1c3f7cadf639c910dfd83915eab707b0d Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 08:35:54 2019 +0000 Add DawnControlClientHolder to track Dawn client state WebGPU objects will be backed by Dawn objects. If the Dawn client is destroyed, Dawn objects are destroyed by the Dawn Wire. The Blink WebGPU objects need to know if the client is destroyed so that they do not call the destructors and double-free Dawn handles. Bug: 941536 Change-Id: I288ec5c55a29ae135c4ec0b202bdd7d61e781d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519552 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641125} third_party/blink/renderer/modules/webgpu/BUILD.gn | 4 +++ .../modules/webgpu/dawn_control_client_holder.cc | 28 +++++++++++++++ .../modules/webgpu/dawn_control_client_holder.h | 42 ++++++++++++++++++++++ .../blink/renderer/modules/webgpu/dawn_object.cc | 30 ++++++++++++++++ .../blink/renderer/modules/webgpu/dawn_object.h | 42 ++++++++++++++++++++++ third_party/blink/renderer/modules/webgpu/gpu.cc | 8 +++-- third_party/blink/renderer/modules/webgpu/gpu.h | 7 ++-- .../blink/renderer/modules/webgpu/gpu_adapter.cc | 16 ++++++--- .../blink/renderer/modules/webgpu/gpu_adapter.h | 13 ++++--- .../blink/renderer/modules/webgpu/gpu_device.cc | 16 ++++++--- .../blink/renderer/modules/webgpu/gpu_device.h | 19 ++++++---- 11 files changed, 198 insertions(+), 27 deletions(-) commit bf9177139b45e47eaba377c40383b2e704de9f02 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 08:35:49 2019 +0000 Roll src-internal 824201d8b700..ff717d8fff9b (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/824201d8b700..ff717d8fff9b Created with: gclient setdep -r src-internal@ff717d8fff9b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I90c63a17303b8434c18708bb87a6a3d56e2a05f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525801 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641124} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 80d04032c47e38b504e174750ec5bcb9900e482a Author: Yoav Weiss <yoavweiss@chromium.org> Date: Fri Mar 15 08:12:06 2019 +0000 [resource-timing] Add TAO null check tests and make sure they pass This CL brings in the pending test [1] for a null TAO check and opaque origins, adds another test to make sure only case-sensitive "null" is taken into account, and changes the TAO implementation to actually pass the tests. [1] https://github.com/web-platform-tests/wpt/pull/13507 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 BUG=940898 Change-Id: I1656d5a5cf2a833ada4dc83278eda0a07cec66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517653 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641123} .../blink/renderer/core/timing/performance.cc | 3 +- .../blink/web_tests/external/wpt/lint.whitelist | 3 +- ...AO-case-insensitive-null-opaque-origin.sub.html | 42 ++++++++++++++++++++++ .../TAO-null-opaque-origin.sub.html | 42 ++++++++++++++++++++++ .../wpt/resource-timing/resources/TAOResponse.py | 5 ++- 5 files changed, 91 insertions(+), 4 deletions(-) commit 1fb467a0ae1898a8e69f282b6ab5bd4ac61eca79 Author: Colin Blundell <blundell@chromium.org> Date: Fri Mar 15 08:07:16 2019 +0000 Change content_shell to lazily create PowerMonitorTestImpl PowerMonitorTestImpl must live entirely on the main thread of the child process, as the global PowerMonitor instance that it accesses can only be accessed from the main thread. Currently, content_shell's child processes create a PowerMonitorTestImpl instance and pass it to their BinderRegistry as a bound argument of a PowerMonitorTestImpl::MakeStrongBinding() callback. This BinderRegistry lives on the IO thread. While the child processes specify that the binding should be done on the main thread, if a PowerMonitorRequest never comes in from the browser the PowerMonitorTestImpl instance will be destroyed on the IO thread when the BinderRegistry is destroyed. This leads to MSAN crashes in content_shell (crbug.com/940283 is restricted, but just shows that that the PowerMonitor global that PowerMonitorTestImpl accesses in its destructor is unitialized, which is due to the PowerMonitorTestImpl destructor and PowerMonitor destructor racing with each other on different threads). To eliminate these crashes, this CL changes PowerMonitorTestImpl to be created on-demand. Making this change also requires that the PowerMonitor browsertest ensure that the PowerMonitorTestImpl instances have been created in the various child processes before simulating power state changes that those instances are supposed to observe, as the simulation of the power state changes occurs on a different Mojo pipe than that of the PowerMonitorTest connection. Bug: 940283 Change-Id: I369b365cfece451a89cc1844695d3571abfc310f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522992 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641122} content/browser/power_monitor_browsertest.cc | 15 +++++++++++++++ content/shell/common/power_monitor_test_impl.cc | 4 ++-- content/shell/common/power_monitor_test_impl.h | 1 - content/shell/gpu/shell_content_gpu_client.cc | 4 +--- content/shell/renderer/shell_content_renderer_client.cc | 3 +-- content/shell/utility/shell_content_utility_client.cc | 4 +--- 6 files changed, 20 insertions(+), 11 deletions(-) commit 9880c61d56788f36e54adfe50348b0618039fbff Author: Colin Blundell <blundell@chromium.org> Date: Fri Mar 15 07:58:04 2019 +0000 Add blundell to //chrome OWNERS Change-Id: I7ad4f41c3af77ea60587555f87a493462305bba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520597 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641121} chrome/OWNERS | 1 + 1 file changed, 1 insertion(+) commit 2e31d2510d218206cbd64012fb77e08cc5185db3 Author: Eyor Alemayehu <eyor@google.com> Date: Fri Mar 15 07:43:24 2019 +0000 Disable screen context toggle in setup if disabled by administrator A G-Suite user should not be able to do a screen context query if it is disabled by the administrator. Therefore, we should not allow the G-Suite user to enable screen context queries during the setup flow. This is currently implemented by disabling the screen context toggle and setting it to false. Bug: 941818 Change-Id: I6bfff2387e2e2994e3358a5f24f621f70a9adfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518062 Commit-Queue: Eyor Alemayehu <eyor@google.com> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641120} .../chromeos/assistant_optin/assistant_get_more.js | 3 ++ .../assistant_optin/assistant_optin_utils.cc | 34 ++++++++++++++++++++-- .../assistant_optin/assistant_optin_utils.h | 15 ++++++---- .../login/assistant_optin_flow_screen_handler.cc | 7 ++++- .../settings/chromeos/google_assistant_handler.cc | 1 + 5 files changed, 50 insertions(+), 10 deletions(-) commit 55f6ecb9a35ee316dd1887a38be0c9aa64c557e9 Author: Dominick Ng <dominickn@chromium.org> Date: Fri Mar 15 07:38:27 2019 +0000 Record the correct install source in BookmarkAppInstallationTask. Prior to this CL, BookmarkAppInstallationTask exclusively passed WebappInstallSource::MENU_BROWSER_TAB to BookmarkAppHelper, which would eventually record the source in the Webapp.Install.InstallEvent metric. This causes huge skew in the metric on Chrome OS, which uses the pending queue for default installation. This CL introduces new metric categories for the different default install categories and updates BookmarkAppInstallationTask to use them, correcting the skew. BUG=942402 Change-Id: Iada40c6a918c095e35948ab8e73ff5da8726c7e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525256 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#641119} chrome/browser/installable/installable_metrics.cc | 7 ++++++- chrome/browser/installable/installable_metrics.h | 13 +++++++++++++ .../extensions/bookmark_app_installation_task.cc | 22 +++++++++++++++++++--- tools/metrics/histograms/enums.xml | 4 ++++ 4 files changed, 42 insertions(+), 4 deletions(-) commit 72739caa4a3b6f677d296b0adc937a3927a18da1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 07:38:17 2019 +0000 Roll src/third_party/skia 5366a45c6103..61d38ade8c1d (2 commits) https://skia.googlesource.com/skia.git/+log/5366a45c6103..61d38ade8c1d git log 5366a45c6103..61d38ade8c1d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 979f3bbe2c50..2fb6563bf503 (2 commits) Created with: gclient setdep -r src/third_party/skia@61d38ade8c1d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6ab8ff085cf11408d663253c0d8c124c9895a3eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525469 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641118} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit af6978673f6a47555c15cacb5fbe9b1a8dd07c9f Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Mar 15 07:32:57 2019 +0000 Stop FetchClientSettingsObject::GetAddressSpace from returning optional Bug: 914739 Change-Id: I95cc0ecfa16624e16aff17097e9587ecd4756dfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524394 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#641117} third_party/blink/renderer/core/loader/base_fetch_context.cc | 5 ++--- .../renderer/core/script/fetch_client_settings_object_impl.cc | 3 +-- .../renderer/core/script/fetch_client_settings_object_impl.h | 2 +- .../platform/loader/fetch/fetch_client_settings_object.h | 4 +--- .../loader/fetch/fetch_client_settings_object_snapshot.cc | 2 +- .../loader/fetch/fetch_client_settings_object_snapshot.h | 10 +++++----- 6 files changed, 11 insertions(+), 15 deletions(-) commit e095d73a8f2f2cfd6a258a805d4a64c09a896b49 Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 07:27:03 2019 +0000 Create GPUDevice from GPUDeviceDescriptor This patch updates GPUAdapter::createDevice to take a GPUDeviceDescriptor which will contain parameters for Device creation. Bug: 941531 Change-Id: I2c96a892846a8ec7ee2e0cf253141faac5b871e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521236 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641116} third_party/blink/renderer/modules/modules_idl_files.gni | 3 +++ third_party/blink/renderer/modules/webgpu/gpu_adapter.cc | 4 ++-- third_party/blink/renderer/modules/webgpu/gpu_adapter.h | 3 ++- third_party/blink/renderer/modules/webgpu/gpu_adapter.idl | 2 +- third_party/blink/renderer/modules/webgpu/gpu_device.cc | 12 ++++++++---- third_party/blink/renderer/modules/webgpu/gpu_device.h | 6 ++++-- .../blink/renderer/modules/webgpu/gpu_device_descriptor.idl | 10 ++++++++++ third_party/blink/renderer/modules/webgpu/gpu_extensions.idl | 8 ++++++++ third_party/blink/renderer/modules/webgpu/gpu_limits.idl | 8 ++++++++ 9 files changed, 46 insertions(+), 10 deletions(-) commit e17fb70e53a19afb8ab526b55413f5fffe8f2bef Author: Rune Lillesveen <futhark@chromium.org> Date: Fri Mar 15 07:26:14 2019 +0000 Add PreferredColorScheme to content::WebPreferences. Also add the plumbing to pass it into blink. Bug: 889087, 925935 Change-Id: I5027a1fc30b14f77423b33ac9e85ba5697a95b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522246 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#641115} content/public/common/common_param_traits_macros.h | 4 ++++ content/public/common/web_preferences.cc | 1 + content/public/common/web_preferences.h | 7 +++++++ content/renderer/render_view_impl.cc | 1 + 4 files changed, 13 insertions(+) commit d91952ef9df602753c4e2ed56b66f3967f790c2d Author: Cathy Li <chili@chromium.org> Date: Fri Mar 15 07:17:14 2019 +0000 [ExploreSites][Touchless] Refactor TileWithTextView into TileView and TextView and allow the new touchless suggestions files to depend on TileView Bug: 936050 Change-Id: Ib611b788b532a72a8fce6e8b982c4e288b91408b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518251 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#641114} .../res/layout/tile_no_text_view_condensed.xml | 50 +++++++++++++++++ .../java/res/layout/tile_view_modern_condensed.xml | 39 +------------- .../chrome/browser/widget/tile/TileView.java | 63 ++++++++++++++++++++++ .../browser/widget/tile/TileWithTextView.java | 23 +------- chrome/android/java_sources.gni | 2 + .../res/layout/touchless_suggestions_tile_view.xml | 14 +++++ .../browser/touchless/SiteSuggestionsAdapter.java | 12 ++--- .../browser/touchless/SiteSuggestionsTileView.java | 61 +++++++++++++++++++++ .../SiteSuggestionsViewHolderFactory.java | 4 +- 9 files changed, 199 insertions(+), 69 deletions(-) commit 1fec8e450203ccede4022a3448dc13e8cc044125 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Fri Mar 15 07:11:49 2019 +0000 OOR-CORS: Skip CORS preflight cache if the original request wants CORS preflight cache wasn't skipped regardless of the load_flags, but with this change, it is skipped if the original request has one of flags that want to skip caches. Also, we do not store results to the cache if net::LOAD_DISABLE_CACHE is specified. Bug: 941297 Change-Id: Ibf356949dd6267eb65faf650d76b0c5e58ce5d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520427 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#641113} .../loader/cors_preflight_cache_browsertest.cc | 129 +++++++++++++++++++++ content/test/BUILD.gn | 1 + content/test/data/loader/cors_preflight.html | 12 ++ services/network/cors/preflight_controller.cc | 13 ++- .../network/cors/preflight_controller_unittest.cc | 19 +++ 5 files changed, 170 insertions(+), 4 deletions(-) commit 76ccc9c47bd7ebe599dd85404f2e4c9f846afdef Author: Christopher Lam <calamity@chromium.org> Date: Fri Mar 15 07:11:45 2019 +0000 [System Web Apps] Extract launch utilities, fix launch disposition. This CL extracts System Web App launch utilities into its own file as suggested in https://chromium-review.googlesource.com/c/chromium/src/+/1370239. It also changes the launch disposition for System Web Apps to CURRENT_TAB to correctly provide singleton behavior. Bug: 836128 Change-Id: Iefd691ed3a5c1f1858197599cff5282e22a254ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504603 Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Alexey Baskakov <loyso@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#641112} .../browser/chromeos/crostini/crostini_manager.cc | 4 +- chrome/browser/ui/BUILD.gn | 2 + chrome/browser/ui/extensions/application_launch.cc | 8 +- chrome/browser/ui/extensions/application_launch.h | 5 +- .../browser/ui/settings_window_manager_chromeos.cc | 135 +++++++-------------- .../system_web_app_ui_utils_chromeos.cc | 102 ++++++++++++++++ .../system_web_app_ui_utils_chromeos.h | 34 ++++++ 7 files changed, 197 insertions(+), 93 deletions(-) commit 230ac82f9f2cb6c8389ff36c5c476bf1dba02e84 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 07:10:44 2019 +0000 Roll src-internal ddc3e674c3c0..824201d8b700 (12 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddc3e674c3c0..824201d8b700 Created with: gclient setdep -r src-internal@824201d8b700 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:885919,chromium:885407,chromium:790659,chromium:790657,chromium:790654 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: I879a1d976a1d86275f8c5c6044ab61ca3470c5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525460 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641111} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19c8b4eaaea2582d032d7420572c7e08431fbedc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 07:10:40 2019 +0000 Roll src/third_party/chromite 58f92a13bcd8..5d06c3522353 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/58f92a13bcd8..5d06c3522353 git log 58f92a13bcd8..5d06c3522353 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 bpastene@chromium.org cros_test: Point Tast to the specified SSH key when running outside the chroot. 2019-03-15 dhanyaganesh@chromium.org GetSlaveStatuses: Split some callers off to GetBuildStatuses Created with: gclient setdep -r src/third_party/chromite@5d06c3522353 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I6abe9a1411ea4458a6f2c4aa6fede53f7f63063e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525459 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641110} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19574981b2967dc3e17da37df392bb3ae6695ae8 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Mar 15 07:09:38 2019 +0000 Make NGAbstractInlineText::GetOrCreate() to take only NGPaintFragment This patch changes to |NGAbstractInlineText::GetOrCreate()| to take only |NGPaintFragment| to avoid to create |NGAbstractInlineText| having |NGPaintFragment| not to associated to |line_layout_item_| member variable. These invalid |NGAbstractInlineText| causes crash by referring destructed |LayoutObject| in |NGAbstractInlineText::Detach()|. This crash can be happend in following scenario: 1. Create |NGAbstractInlineText| by |LayoutText::FirstAbstractInlineText()| with layout object L1 and fragment F1_1 then get A1(L1, F1) 2. Create |NGAbstractInlineText::NextOnLine()| with L1 and F2 then get A2(L1, F2) where F2 is associated to L2. 3. Destroy L1 then call Detach() for A1(L1, F1) => no problem 4. Destroy L2 then call Detach() for A2(L1, F2) => crash since L1 is destroyed Bug: 928925 Change-Id: Ic0a55b4e15723e1988d0727aba45723aed4d3a4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525257 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641109} third_party/blink/renderer/core/layout/layout_text.cc | 3 +-- .../core/layout/ng/inline/ng_abstract_inline_text_box.cc | 10 +++++----- .../core/layout/ng/inline/ng_abstract_inline_text_box.h | 3 --- 3 files changed, 6 insertions(+), 10 deletions(-) commit b48ffad8dd1e0aa410bfd778a89b1e1fe8d01196 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 07:09:34 2019 +0000 Roll src/third_party/pdfium 9284a7cf9ba6..bcb9892d16d3 (3 commits) https://pdfium.googlesource.com/pdfium.git/+log/9284a7cf9ba6..bcb9892d16d3 git log 9284a7cf9ba6..bcb9892d16d3 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 tsepez@chromium.org Better bounds check in CFGAS_StringFormatter::GetCategory() 2019-03-14 tsepez@chromium.org Remove stringviews in cfgas_stringformatter.cpp, part2. 2019-03-14 tsepez@chromium.org Cache pattern span in xfa/fgas/crt/cfgas_stringformatter.h Created with: gclient setdep -r src/third_party/pdfium@bcb9892d16d3 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I0c57571b0ed4907cb09043a56f2fd4eead0c1998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525458 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641108} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 655669175e7f527d42dbc113aef67ddd0e1670bf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 06:34:47 2019 +0000 Roll src/third_party/depot_tools 26b4a64918d4..04600b4f26bd (3 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/26b4a64918d4..04600b4f26bd git log 26b4a64918d4..04600b4f26bd --date=short --no-merges --format='%ad %ae %s' 2019-03-15 yyanagisawa@chromium.org Expose gclient_paths via InputAPI. 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@04600b4f26bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:939959 TBR=agable@chromium.org Change-Id: If95206c72c9ede5ea741929d60535cd7e604a6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525457 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641107} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit df9f61b51b9dfe9c3b3cf2ec7ba2d6b5882247a7 Author: Jan Krcal <jkrcal@chromium.org> Date: Fri Mar 15 06:33:11 2019 +0000 [AF Wallet sync] Ensure proper order of notifications to metadata bridge This CL fixes a speculative bug in interaction between the wallet data bridge and the wallet metadata bridge. The bug occurs when the bridge deletes and re-creates a particular entity (because it is different than before). If these notifications are sent out in the wrong order (first ADD, then DELETE), we end up without the metadata entity. It is speculative because I am not sure that it can happen in reality that payments sends the same card with different data. Anyway, it feels safer to assume less. Bug: 928758 Change-Id: I74a2d6c68107fffdde18a69810828d629ca4e50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518575 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641106} .../integration/single_client_wallet_sync_test.cc | 104 ++++++++++++++++++++- .../browser/webdata/autofill_wallet_sync_bridge.cc | 23 ++++- 2 files changed, 119 insertions(+), 8 deletions(-) commit aee84c522e39fed15b0310e732d72616b26f824c Author: Nico Weber <thakis@chromium.org> Date: Fri Mar 15 06:24:14 2019 +0000 Reland "Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds." This is a reland of 889a9665145519f88a755826e6c4a3c15f8fda7a Original change's description: > Use DWARF4 for mac and ios simulator builds, use DWARF3 for ios device builds. > > Removes some special-case code and potentially makes debug info a bit smaller. > > Also stop passing -g2 to (non-pnacl) nacl compiles on mac, like already the case > on linux -- this helps with build determinism. > > Bug: 942155,899438,906741,429358 > Change-Id: Ic4c7138d232813e12426de2c161c78121bd3fc80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525041 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640963} TBR=mark Bug: 942155, 899438, 906741, 429358 Change-Id: I382c93c02eefd3cbbcf1d8df0670297319f3ac31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525415 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641105} build/config/compiler/BUILD.gn | 67 +++++++++++++++++++++--------------------- 1 file changed, 33 insertions(+), 34 deletions(-) commit 3662db4044c922fdd6ed8789b8984f53a3313a71 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Fri Mar 15 06:24:11 2019 +0000 Use per-frame task runner at extnsions' GCCallback This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. The callback of GC in extensions executes JavaScript, but this callback is now executed on the default task runner. This CL replaces this with a per-frame task runner. Some tests hit this: e.g. extensions_browsertests --gtest_filter=WebViewAPITest.TestDialogConfirmDefaultGCCancel Bug: 870606 Change-Id: Ic1c2968a2e9e07629e7c117e1e1c4e97c2df0457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514516 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641104} extensions/renderer/gc_callback.cc | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) commit 251c3e7000c1f64eddfe7b10d03d746a637d1d27 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 06:20:37 2019 +0000 Roll src/third_party/angle 2fb6563bf503..de52ca373d98 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/2fb6563bf503..de52ca373d98 git log 2fb6563bf503..de52ca373d98 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 syoussefi@chromium.org Vulkan: Fix GraphViz dump in presence of queries and fences Created with: gclient setdep -r src/third_party/angle@de52ca373d98 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Idf3d1a755fe66d8df1ceda4c9d5105a21c2da579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525456 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641103} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fcb13a76d9f014a44fa5872d534f49c5e8d1869 Author: Fergus Dall <sidereal@google.com> Date: Fri Mar 15 06:16:18 2019 +0000 Uninitialized variable preventing crostini uninstall option from appearing This fixes a regression introduced by crrev.com/c/1472013, which leaves the flag that decides to show/hide the uninstaller uninitialized. Depending on the build, this may end up in the hiding state initially, rather then the showing state. This CL fixes the regression and adds automated testing to prevent reoccurence. Bug: 941865 Change-Id: I7dc2c3c770fc5fbef838d82c82f46c0717fb7ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522061 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641102} .../browser/chromeos/crostini/crostini_manager.h | 4 ++- .../chromeos/crostini/crostini_manager_unittest.cc | 4 +++ .../crostini_page/crostini_browser_proxy.js | 9 ++++++ .../settings/crostini_page/crostini_subpage.html | 1 + .../settings/crostini_page/crostini_subpage.js | 9 +++--- .../ui/webui/settings/chromeos/crostini_handler.cc | 6 ++-- .../test/data/webui/settings/crostini_page_test.js | 32 ++++++++++++++++++++-- .../webui/settings/test_crostini_browser_proxy.js | 4 +++ 8 files changed, 58 insertions(+), 11 deletions(-) commit c3957448cfc6e299165196a33cd954b790875fdb Author: David Bokan <bokan@chromium.org> Date: Fri Mar 15 06:15:17 2019 +0000 Cleanup and remove dead code in SetFocusedElement This early-out was added in: https://crrev.com/ce8ea3446283965c7eabab592cbffe223b1cf2bc Back then, we applied fragment focus in LayoutUpdated() which could cause this issue. This got cleaned up in: https://crrev.com/45236fd563e9df53dc45579be1f3d0b4784885a2 so that focus is no longer applied after layout. +Cleanup: Goto considered harmful Bug: 795381 Change-Id: Ifeb4d2e03e872fd48cca6720b1d4de36ad1ecbb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524417 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#641101} third_party/blink/renderer/core/dom/document.cc | 38 +++++++++++++------------ 1 file changed, 20 insertions(+), 18 deletions(-) commit ded259df83e1e4bac3b20f8f28a7e21a7d88e752 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 06:12:59 2019 +0000 Roll src/third_party/SPIRV-Tools/src e545522146af..2ac348b5c0a5 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/e545522146af..2ac348b5c0a5 git log e545522146af..2ac348b5c0a5 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dneto@google.com Repair test for unused storage buffer with descriptor (#2436) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@2ac348b5c0a5 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I16aa5cb80a3747d3da5e2ab796951cb6bc65dbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525347 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641100} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bdfbcff52d04b8182799d43eb66ab9be98ee0b86 Author: Adam Rice <ricea@chromium.org> Date: Fri Mar 15 06:10:27 2019 +0000 Fix the error message when TransformStream controller enqueue fails Calling enqueue() on a TransformStream that was closed or errored would throw an exception with the message "Cannot read property 'Symbol(bit field for [[started]], [[closeRequested]], [[pulling]], [[pullAgain]])' of undefined". Fix the message. Also add a Chromium-specific test that the message is correct. BUG=941970 Change-Id: I690bfb909efe72a6ba6859dc886b37b2bda71ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523211 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641099} .../blink/renderer/core/streams/TransformStream.js | 3 +- .../streams/chromium/transform-stream-enqueue.html | 42 ++++++++++++++++++++++ .../chromium/transform-stream-enqueue-expected.txt | 5 +++ 3 files changed, 49 insertions(+), 1 deletion(-) commit 6240f4c4c19ad2901662ed5e0128af523706de48 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Mar 15 06:08:07 2019 +0000 Reland "[BGPT] Let cc initialize animation states in property nodes" This is a reland of 54b17c7e812cd7c961abb45b4f8bcc7e2b1bbe43 The original CL called MutatorHost::InitClientAnimationState() before updating animations. The new CL calls it after updating animations. Not sure why the original CL caused flakiness of virtual/threaded/animations/hit-testing/composited-with-hit-testing.html, but the test is no longer flaky with this new CL. Original change's description: > [BGPT] Let cc initialize animation states in property nodes > > In this way, blink::PropertyTreeManager no longer needs to care about > the animation states. Now we initialize and change the states from a > single source to avoid duplicate code and inconsistency. > > Bug: 935770 > Change-Id: I7f98d66677f557213fd4559895e9c2069de196e7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513922 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640892} TBR=flackr@chromium.org, pdr@chromium.org Bug: 935770 Change-Id: Icd7ec59b9e5b95f2c268baf88732788cde5da9c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525449 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641098} cc/animation/animation_host.cc | 5 + cc/animation/animation_host.h | 2 + cc/animation/element_animations.cc | 8 + cc/animation/element_animations.h | 7 + cc/trees/mutator_host.h | 2 + .../core/animation/compositor_animations.h | 12 -- .../core/animation/compositor_animations_test.cc | 214 +++++++++++++-------- .../blink/renderer/core/frame/local_frame_view.cc | 15 ++ .../renderer/core/paint/link_highlight_impl.cc | 8 +- .../compositing/paint_artifact_compositor.cc | 1 + .../compositing/paint_artifact_compositor_test.cc | 30 ++- .../graphics/compositing/property_tree_manager.cc | 16 -- 12 files changed, 187 insertions(+), 133 deletions(-) commit e5e713ea03d4573796b4f62347935e76903142fb Author: Antonio Gomes <tonikitoo@igalia.com> Date: Fri Mar 15 05:56:07 2019 +0000 Invoke FileSystemCallbacks's success/error closures directly Previously, the success and error callbacks in the various classes in [1] were either invoked immediately or scheduled to run depending on the execution context's task runner. Lately, according to offline conversations with mek@chromium.org, it is possible to get rid of the scheduling logic altogether because an earlier, change made it so that things like FilesystmeDispatcher::DidReadMetadata already run on a per-execution context task runner, and presumably they would already be scheduled properly. This CL implements that idea, as part of the effort to clean FileSystemCallbacks's implementation. It also greatly simplifies FileSystemCallbacksBase, which can be eliminated in a follow up CL with minimal effort. [1] //third_party/blink/renderer/modules/filesystem/file_system_callbacks.h R=mek@chromium.org CC=blink-reviews-vendor@chromium.org, dgozman@chromium.org BUG=933878 Change-Id: Ib446249bab8ac1c9d9f2e4d11340d258cbac1751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525101 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641097} .../modules/filesystem/file_system_callbacks.cc | 118 +++++++-------------- .../modules/filesystem/file_system_callbacks.h | 11 -- 2 files changed, 41 insertions(+), 88 deletions(-) commit 1108c4224984e1e247ec3fd2ee5b43f1f04f1f88 Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Mar 15 05:48:23 2019 +0000 Add clangd to gitignore This folder is an output for an experimental `-background-index` command line argument. Bug: None Change-Id: Iaa1db62f54d844d271b2c56a686cdad5117ebe74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524392 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#641096} .gitignore | 1 + 1 file changed, 1 insertion(+) commit 7cf2cfad067a9837990a99369e52e95dd8edc1e7 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 05:40:34 2019 +0000 Roll src/third_party/skia f4438d56e989..5366a45c6103 (14 commits) https://skia.googlesource.com/skia.git/+log/f4438d56e989..5366a45c6103 git log f4438d56e989..5366a45c6103 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 9b156615197d..1b8cd2d9ce2c (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 brianosman@google.com Ganesh: Clamp blend inputs when using F16_Clamped pixel config 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader becb44f1177a..9b156615197d (1 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a2749f39f47d..becb44f1177a (1 commits) 2019-03-14 jvanverth@google.com Fix cached perspective shadows 2019-03-14 michaelludwig@google.com Blacklist compositor_quads_filter on chromecast 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader af973b67141e..a2749f39f47d (1 commits) 2019-03-14 bsalomon@google.com Clamp override color to bytes in GrFillRectOp when half float vertex 2019-03-14 kjlubick@google.com [canvaskit] Fallback to CPU more gracefully 2019-03-14 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 37b996425a0e..979f3bbe2c50 (5 commits) 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@5366a45c6103 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123261126 TBR=benjaminwagner@chromium.org Change-Id: Idff8f55d51703b5bf63f6ba0948b349c84dceedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525455 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641095} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fa476237ab4afbaf19b769a80550aadb8f2ed9e9 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Fri Mar 15 05:36:44 2019 +0000 Add to_snake_case function in make_instrumenting_probes.py The primary motivation is that the data member names are not following proper naming conventions within probe_sink.h.tmpl and instrumenting_probes_impl.cc.tmpl. This CL add to_snake_case function in make_instrumenting_probes.py to convert data members to snake case format. Bug: 936684 Change-Id: I9934aec12dfd85094335078f7c1784f56d6aafac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524801 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641094} .../blink/renderer/build/scripts/make_instrumenting_probes.py | 6 +++--- .../build/scripts/templates/instrumenting_probes_impl.cc.tmpl | 4 ++-- .../blink/renderer/build/scripts/templates/probe_sink.h.tmpl | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) commit e91cd380877656737479db291ddb2855c90a9c72 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Mar 15 05:35:04 2019 +0000 [CompositeAfterPaint] Update test expectations - Skip virtual/binary-for-devtools/http/tests/devtools - Mark css3/masking/mask-composite-missing-image.html failing - Rebaseline 5 tests: - gradient, rounded edges and anti-alias differences - invalidation rect changes (no image failure) All because of base test rebaselines TBR=pdr@chromium.org Bug: 524134 Change-Id: I171f3eaff7e78649903441c142ebc9c25171ad2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525681 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641093} .../enable-blink-features=CompositeAfterPaint | 2 ++ .../masking/mask-repeat-space-border-expected.png | Bin 17867 -> 22541 bytes .../paint/invalidation/svg/tabgroup-expected.txt | 2 +- .../text-line-clamp-truncation-expected.txt | 6 +++--- ...d-image-preserveaspectRatio-support-expected.png | Bin 49696 -> 49697 bytes .../background-repeat-expected.png | Bin 68576 -> 68533 bytes 6 files changed, 6 insertions(+), 4 deletions(-) commit 5242713e8266e6b56f3c5cb8e4ecd259fd236467 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Mar 15 05:25:58 2019 +0000 Mark http/tests/devtools/service-workers/service-workers-force-update-on-page-load.js slow According to the flakiness dashboard it could take more than 10 sec on dbg build and 3 sec on release build. Mark it slow. Bug: 937378 Change-Id: I14fcd04a6d315a61f559fbc7a3cadf8ce2914dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525255 Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641092} third_party/blink/web_tests/SlowTests | 2 ++ third_party/blink/web_tests/TestExpectations | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) commit 321ed56aabe64572e13f74807ad7ecd96868e8ea Author: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Date: Fri Mar 15 05:16:58 2019 +0000 Rename latest goma cros and ios builders to omit "client" Since we don't have "client"s in canary, let me remove that from the name. Also let me add an ios rule for the iOS latest builder. Bug: 874754 Change-Id: I46e1ec5d33f30caaa723184fdc7dea46f372de67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502892 Commit-Queue: smut <smut@google.com> Auto-Submit: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: smut <smut@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641091} infra/config/cr-buildbucket.cfg | 2 +- infra/config/luci-milo.cfg | 4 ++-- infra/config/luci-scheduler.cfg | 12 +++++------ .../ios-device-goma-latest-clobber.json | 25 ++++++++++++++++++++++ tools/mb/mb_config.pyl | 2 ++ 5 files changed, 36 insertions(+), 9 deletions(-) commit 9cd0fb799a0369da431729e932be51fe24106e71 Author: Maksim Ivanov <emaxx@chromium.org> Date: Fri Mar 15 05:13:46 2019 +0000 Remove unused enums from enterprise_metrics.h These enums haven't been used by any code for a while. Also remove the corresponding dead histogram definitions. BUG=chromium:690733 TEST=existing tests Change-Id: I93b00807807e1869e5a7ab8daae277a07b6cf1e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1425724 Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#641090} .../policy/core/common/cloud/enterprise_metrics.cc | 2 - .../policy/core/common/cloud/enterprise_metrics.h | 105 --------------------- tools/metrics/histograms/enums.xml | 6 ++ tools/metrics/histograms/histograms.xml | 6 ++ 4 files changed, 12 insertions(+), 107 deletions(-) commit 558a982945cf9d3133b413b05f9300de17c3a371 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Fri Mar 15 05:07:21 2019 +0000 Android: Close preview panel on some events Preview (a.k.a Sneak Peek) panel needs to be closed on various events such as when a new tab is opened, or its base panel navigates, etc. This CL adds a couple of tab model observers to detect those events, and invokes |closePanel| accordingly. Bug: 940919 Change-Id: Ieee694db214ded1f031ac24db3586496d19bee42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519966 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641089} .../chromium/chrome/browser/ChromeActivity.java | 1 - .../bottombar/ephemeraltab/EphemeralTabPanel.java | 61 ++++++++++++++++++++++ .../browser/compositor/layouts/LayoutManager.java | 1 + .../contextualsearch/ContextualSearchManager.java | 56 ++++++++------------ 4 files changed, 84 insertions(+), 35 deletions(-) commit 197aede3ca09f2e0393a507bd50d51c0efe55ef2 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 04:58:06 2019 +0000 Roll src-internal b58fe2ab9436..ddc3e674c3c0 (8 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b58fe2ab9436..ddc3e674c3c0 Created with: gclient setdep -r src-internal@ddc3e674c3c0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:942176 TBR=jbudorick@chromium.org,anthonyvd@chromium.org,andypaicu@chromium.org,aboxhall@chromium.org Change-Id: Id383f2517feb021d79065d9a527de04c7a36f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525303 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641088} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ff94864113f0406193ac4ead46b2a5ce2650b7f0 Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Mar 15 04:53:49 2019 +0000 [Files app] Add context menu test for USB with DCIM folder Re-sending CL: 1514005 based in the new strategy to make it non-flaky. Add more explicit waiting on checkContextMenu to wait for each entry to be displayed before trying to expand or click. Change-Id: Id7a6f9ea27d5bade800837480df79721dcab4329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524749 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641087} .../file_manager/file_manager_browsertest.cc | 1 + .../file_manager/directory_tree_context_menu.js | 47 ++++++++++++++++++++-- 2 files changed, 45 insertions(+), 3 deletions(-) commit 437ee022676233d01e05b7d640c808e4d37bd05a Author: Pavel Feldman <pfeldman@chromium.org> Date: Fri Mar 15 04:53:46 2019 +0000 DevTools: refactor overlay input handling Routes each message type into its own method. Change-Id: I8dacbc37d614794f6757d6b9c669fa751de5ab4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525263 Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641086} .../core/inspector/inspector_overlay_agent.cc | 172 +++++++++++++-------- .../core/inspector/inspector_overlay_agent.h | 10 ++ 2 files changed, 115 insertions(+), 67 deletions(-) commit fe043db5936303d3d7d7c194b244b07f6649de78 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 04:52:42 2019 +0000 Import wpt@4acb8924f765913a520d5f6fefbc8c870e500476 Using wpt-import in Chromium 8f30a2e75761511431980d03a5a7db1c165ff968. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 2b037bdc25 "[Animation Worklet] Fix flaky worklet-animation-with-fill-mode.https.html" fc735f1b74 "[IndexedDB] Fixed DisjointRangeLockManager usage in IndexedDB" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ib7511d306d305de610cf7479d5f49531ba7c6d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524973 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641085} .../blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 12 ++++++------ .../web_tests/external/wpt/web-nfc/resources/nfc_help.js | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) commit 9481795e17f5f5561110e53650d6d973cb0406a0 Author: kylechar <kylechar@chromium.org> Date: Fri Mar 15 04:52:38 2019 +0000 Remove viz related tests from FYI bots. 1. Remove all viz related tests from FYI bots on Linux, Windows and Mac. The feature has launched on those platforms and no longer needs special testing. 2. Remove all viz related tests from FYI bots on Android. The feature is default enabled on Android and will be launched before M75. Fixing regressions in the viz disabled case is no longer necessary. Bug: 730193, 732555 Change-Id: Idd01543bb059971152a168a279a2ebe56fcfa325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524870 Reviewed-by: Jonathan Ross <jonross@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#641084} testing/buildbot/chromium.fyi.json | 433 ------------------------------------- testing/buildbot/test_suites.pyl | 44 ---- 2 files changed, 477 deletions(-) commit 9d4bc8c9486f1d43fe244e3aa2987379368265cc Author: Eliot Courtney <edcourtney@google.com> Date: Fri Mar 15 04:51:36 2019 +0000 Fix DCHECK crash inside SetMaximizedOrFullscreenBounds. If the set bounds event was meant to be animated, and occurred during a drag, then it would trigger the DCHECK in SetMaximizedOrFullscreenBounds. Bug: 941017 Test: No DCHECK on finishing dragging a PIP window. Change-Id: I9ced916fa8f7eafbac2df232b3abe242a704a329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523126 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#641083} ash/wm/default_state.cc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) commit 6e0feb3c71d51ef49aa534e77aa91fa104263390 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Fri Mar 15 04:51:33 2019 +0000 [Extensions] Add web request info for activities in the stream This CL shows web request info for activities in the stream if provided (also shown in Chrome Apps & Extensions Developer Tool). The web request info is a JSON object and is found in chrome.activityLogPrivate.ExtensionActivity.other.webRequest Screenshot: https://imgur.com/a/ZdxqfBC Note: I'm not using any fancy styling/formatting here, as the keys in the web request object can be somewhat long and are variable in length. The objects don't seem to be very large and so the entire web request object is shown as a JSON string (see screenshot). Bug: 932768 Change-Id: Idc14b337e6cb953331a1988bf1cd675f381c30f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517142 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641082} chrome/app/md_extensions_strings.grdp | 3 ++ .../activity_log/activity_log_stream.js | 4 ++ .../activity_log/activity_log_stream_item.html | 23 ++++++-- .../activity_log/activity_log_stream_item.js | 29 ++++++---- .../browser/ui/webui/extensions/extensions_ui.cc | 1 + .../extensions/activity_log_stream_item_test.js | 63 ++++++++++++---------- 6 files changed, 80 insertions(+), 43 deletions(-) commit b2ebac90f6f6adaa33eae986c1b6e70df436f2dd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 04:50:30 2019 +0000 Roll src/third_party/pdfium b271c06e57ba..9284a7cf9ba6 (8 commits) https://pdfium.googlesource.com/pdfium.git/+log/b271c06e57ba..9284a7cf9ba6 git log b271c06e57ba..9284a7cf9ba6 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 tsepez@chromium.org Avoid WideStringViews from constant strings in cfgas_stringformatter.cpp 2019-03-14 thestig@chromium.org Rename some variables in fpdf_edittext.cpp. 2019-03-14 thestig@chromium.org Split CFFL_InteractiveFormFiller::GetFormFiller() in two. 2019-03-14 thestig@chromium.org Use "bs" prefix for ByteStrings in cfxjse_formcalc_context.cpp. 2019-03-14 thestig@chromium.org Fix two XFA JS calls that trigger fatal errors in v8::FromJust(). 2019-03-14 tsepez@chromium.org Specify CFGAS_StringFormatter format at creation time. 2019-03-14 thestig@chromium.org Remove extra slashes in fxjs/BUILD.gn. 2019-03-14 thestig@chromium.org Mark CPDF_FontEncoding::Realize() as a const method. Created with: gclient setdep -r src/third_party/pdfium@9284a7cf9ba6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8dbaeebcedd68b9f5c472778f2b0b7ca8497cc74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524970 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641081} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 153043d1a91dc7a1228c5be0c3ea3a4ecc06ca0c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 04:50:26 2019 +0000 Roll src/third_party/chromite 69d4958ee9b3..58f92a13bcd8 (5 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/69d4958ee9b3..58f92a13bcd8 git log 69d4958ee9b3..58f92a13bcd8 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 pprabhu@chromium.org config: Move {quawks,octopus,sentry}-paladin to Skylab 2019-03-14 dgarrett@google.com chromeos_config: Make buildspec builders internal. 2019-03-14 chrome-bot@chromium.org Update config settings by config-updater. 2019-03-14 dhanyaganesh@chromium.org PreCQLauncher: Revert the 1505981 CL 2019-03-14 saklein@chromium.org Build API: Add update sdk endpoint. Created with: gclient setdep -r src/third_party/chromite@58f92a13bcd8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I97837336910a68acd7414b8b902ea4a530617c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525454 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641080} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ab465d99332a41932cd01f852167b358ba3d221 Author: Charlie Reis <creis@chromium.org> Date: Fri Mar 15 04:49:25 2019 +0000 Add diagnostics to catch commits of URLs in incompatible processes. These should be removed once we have some data indicating how it is occurring in practice. BUG=931895 Change-Id: Ic8977b194892328a32d1db6f4492f9bb84938ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524835 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641079} .../browser/frame_host/render_frame_host_impl.cc | 28 +++++++++++++++++++ .../frame_host/render_frame_host_manager.cc | 31 ++++++++++++++++++++++ 2 files changed, 59 insertions(+) commit ad9da4e45bb501e872658fd4d12e69b61acf98eb Author: Adam Rice <ricea@chromium.org> Date: Fri Mar 15 04:49:22 2019 +0000 Disable TransformStream when StreamsNative enabled The V8 extras TransformStream implementation will always produce a V8 extras ReadableStream and WritableStream, even if the StreamsNative feature is turned on. Since this breaks the expectation that a ReadableStream is always a ReadableStreamNative when we are using the new implementation, it can cause crashes. Prevent constructing a TransformStream when StreamsNative is enabled to prevent this issue. BUG=902633 Change-Id: I718b493f19db7a47bea9db0c5ffb7dd1d6d12e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523209 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641078} .../renderer/core/streams/transform_stream.cc | 9 ++++++ .../piping/transform-streams.any-expected.txt | 2 +- ...ransform-streams.any.serviceworker-expected.txt | 2 +- ...transform-streams.any.sharedworker-expected.txt | 2 +- .../transform-streams.any.worker-expected.txt | 2 +- .../backpressure.any-expected.txt | 29 ++++++++--------- .../backpressure.any.serviceworker-expected.txt | 29 ++++++++--------- .../backpressure.any.sharedworker-expected.txt | 29 ++++++++--------- .../backpressure.any.worker-expected.txt | 29 ++++++++--------- .../brand-checks.any-expected.txt | 4 +++ .../brand-checks.any.serviceworker-expected.txt | 4 +++ .../brand-checks.any.sharedworker-expected.txt | 4 +++ .../brand-checks.any.worker-expected.txt | 4 +++ .../transform-streams/constructor.any-expected.txt | 23 ++++++++++++++ .../constructor.any.serviceworker-expected.txt | 23 ++++++++++++++ .../constructor.any.sharedworker-expected.txt | 23 ++++++++++++++ .../constructor.any.worker-expected.txt | 23 ++++++++++++++ .../transform-streams/errors.any-expected.txt | 37 ++++++++++++++++++++++ .../errors.any.serviceworker-expected.txt | 37 ++++++++++++++++++++++ .../errors.any.sharedworker-expected.txt | 37 ++++++++++++++++++++++ .../errors.any.worker-expected.txt | 37 ++++++++++++++++++++++ .../transform-streams/flush.any-expected.txt | 8 +++++ .../flush.any.serviceworker-expected.txt | 8 +++++ .../flush.any.sharedworker-expected.txt | 8 +++++ .../flush.any.worker-expected.txt | 8 +++++ .../transform-streams/general.any-expected.txt | 29 +++++++++++++++++ .../general.any.serviceworker-expected.txt | 29 +++++++++++++++++ .../general.any.sharedworker-expected.txt | 29 +++++++++++++++++ .../general.any.worker-expected.txt | 29 +++++++++++++++++ .../transform-streams/lipfuzz.any-expected.txt | 23 ++++++++++++++ .../lipfuzz.any.serviceworker-expected.txt | 23 ++++++++++++++ .../lipfuzz.any.sharedworker-expected.txt | 23 ++++++++++++++ .../lipfuzz.any.worker-expected.txt | 23 ++++++++++++++ .../patched-global.any-expected.txt | 5 +++ .../patched-global.any.serviceworker-expected.txt | 5 +++ .../patched-global.any.sharedworker-expected.txt | 5 +++ .../patched-global.any.worker-expected.txt | 5 +++ .../transform-streams/properties.any-expected.txt | 5 +++ .../properties.any.serviceworker-expected.txt | 4 +++ .../properties.any.sharedworker-expected.txt | 5 +++ .../properties.any.worker-expected.txt | 5 +++ .../reentrant-strategies.any-expected.txt | 23 +++++++------- ...trant-strategies.any.serviceworker-expected.txt | 23 +++++++------- ...ntrant-strategies.any.sharedworker-expected.txt | 23 +++++++------- .../reentrant-strategies.any.worker-expected.txt | 23 +++++++------- .../transform-streams/strategies.any-expected.txt | 13 ++++++++ .../strategies.any.serviceworker-expected.txt | 13 ++++++++ .../strategies.any.sharedworker-expected.txt | 13 ++++++++ .../strategies.any.worker-expected.txt | 13 ++++++++ .../transform-streams/terminate.any-expected.txt | 13 ++++---- .../terminate.any.serviceworker-expected.txt | 13 ++++---- .../terminate.any.sharedworker-expected.txt | 13 ++++---- .../terminate.any.worker-expected.txt | 13 ++++---- .../streams/chromium/use-counters-expected.txt | 7 ++++ .../transferable/enabled/enabled-expected.txt | 6 ++++ .../transferable/transform-stream-expected.txt | 10 +++--- .../tests/streams/transferable/window-expected.txt | 13 ++++++++ 57 files changed, 755 insertions(+), 145 deletions(-) commit ad4613668225feb1a870882b1e0b6242a30ceadc Author: Chris Lu <thegreenfrog@chromium.org> Date: Fri Mar 15 04:48:20 2019 +0000 [ios] Only Add Optional Text if Exists in ClearBrowsingDataItem optionalTextLabel always exists, but it does not always have text. Currently adds that empty string to the array used to construct the accessibilityValue. Now only add it to the returned string if there is text. Bug: 937016 Change-Id: I43d28777ed9ee872bebf741db985d49280b21c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525272 Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#641077} .../ui/settings/cells/table_view_clear_browsing_data_item.mm | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 6243800b26c38e8b6433cb0d79900b2ffbe4d3c0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 04:48:17 2019 +0000 Roll src/third_party/depot_tools 1c2fa0fdda12..26b4a64918d4 (3 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1c2fa0fdda12..26b4a64918d4 git log 1c2fa0fdda12..26b4a64918d4 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-14 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@26b4a64918d4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I39c632b13063d4aca963ef58c5182b16df45546a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525032 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641076} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bd35099ed01b0bd9619c4cef4765c5678b64141a Author: Peter Kasting <pkasting@chromium.org> Date: Fri Mar 15 04:08:03 2019 +0000 Add RemoveAllMenuItems(). This allows callers that want this to be both clearer and more efficient. Bug: none Change-Id: Ida11ebd5e131b250aeaf6a505be7d5176ff3e472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525279 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#641075} chrome/browser/ui/views/toolbar/app_menu.cc | 4 +--- ui/views/controls/menu/menu_item_view.cc | 12 +++++++++--- ui/views/controls/menu/menu_item_view.h | 4 ++++ ui/views/controls/menu/menu_model_adapter.cc | 7 ++----- 4 files changed, 16 insertions(+), 11 deletions(-) commit 13df76ecf29881670b04171632eb0dabf11e0323 Author: Jenny Zhang <jennyz@chromium.org> Date: Fri Mar 15 04:08:00 2019 +0000 Don't activate search box on context menu mouse click. When user right click the mouse on an empty inactive search box, we should only open context menu, but not zero state suggestion window. Bug: 941428 Change-Id: Ic3fb9934880232e5576266508845985ce9e88e2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524339 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641074} ash/app_list/views/search_box_view.cc | 7 +++++++ 1 file changed, 7 insertions(+) commit 009e0bc2e196b48f567eaa66e3d6ed252c0aa006 Author: Jenny Zhang <jennyz@chromium.org> Date: Fri Mar 15 04:06:25 2019 +0000 Fix the zero state crash during quick key traversing. The result has not be set for its result view yet when the focus is forwarded to the result view due to the quick traverse via forward key, which leads to the crash. Bug: 942231 Change-Id: I49f7978a84a422c7f1eec661b6c950c1ee9efd7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525278 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641073} ash/app_list/views/search_result_page_view.cc | 3 +++ 1 file changed, 3 insertions(+) commit 9660779c20cf7ac0471626e8ab1283e953d43537 Author: Siyu An <siyua@chromium.org> Date: Fri Mar 15 04:05:48 2019 +0000 Revert "[AF][Paradise] Enable Paradise settings button for non-sync users" This reverts commit c8d72cdba1671a341b9fa11d4cc0707c23a3f66f. Reason for revert: It breaks local card migration browsertests and guests window. 941880, 941780 Original change's description: > [AF][Paradise] Enable Paradise settings button for non-sync users > > Previously there were two sets of prerequisites checks which are fragile > and complex. Here I refactored the LocalCardMigrationManager to allow > prerequisites checks to be shared by both checkout form flow and > settings page flow. > > Change in the LocalCardMigrationManager is already covered by unittests > and browsertests. So I only modify the test file for payments_section.js > > Bug: 897998 > Change-Id: I894f0ba7010615fa602fa808dc9493c58d0f1d94 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510635 > Reviewed-by: Jared Saul <jsaul@google.com> > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Reviewed-by: Hector Carmona <hcarmona@chromium.org> > Commit-Queue: Siyu An <siyua@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640028} TBR=hcarmona@chromium.org,tmartino@chromium.org,jsaul@google.com,siyua@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 897998 Change-Id: Ib287dea02f7025e0fe6f95e712185302870e4116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524716 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641072} .../settings/autofill_page/payments_section.html | 2 +- .../settings/autofill_page/payments_section.js | 139 ++++++++++++++- .../md_settings_localized_strings_provider.cc | 63 ++++++- .../data/webui/settings/payments_section_test.js | 190 ++++++++++++++++++++- .../autofill/core/browser/autofill_experiments.cc | 32 ---- .../autofill/core/browser/autofill_experiments.h | 7 - .../payments/local_card_migration_manager.cc | 34 +++- .../core/browser/payments/payments_util.cc | 10 -- .../autofill/core/browser/payments/payments_util.h | 4 - .../browser/payments/payments_util_unittest.cc | 27 +-- 10 files changed, 408 insertions(+), 100 deletions(-) commit 3a304e8e81472cd6c4b397ef30d5c3a11ee635ed Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 04:05:19 2019 +0000 Note that you cannot uninstall built-in apps BUG=826982 Change-Id: Ib5e26c2b13f302b70b5fce500c8d130facd13016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525244 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641071} chrome/browser/apps/app_service/built_in_chromeos_apps.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit f8ee72281ece4c3a3a2d648174bd94600f25a9dd Author: John Abd-El-Malek <jam@chromium.org> Date: Fri Mar 15 03:54:11 2019 +0000 Support sending all request and response headers to webRequest for websockets with network service. Since this incurs a performance overhead of extra process hops, only do it if extraHeaders is specified. Bug: 937852 Change-Id: I5db329c5eaf8781bef418b64afc5f0ab1c0c18f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517144 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641070} chrome/browser/chrome_content_browser_client.cc | 6 +- chrome/browser/chrome_content_browser_client.h | 3 +- .../api/web_request/web_request_apitest.cc | 4 +- .../extensions/api_test/webrequest/framework.js | 25 ++++ .../api_test/webrequest/test_extra_headers.js | 24 ---- .../api_test/webrequest/test_websocket.js | 110 ++++++++++++++++- .../browser/frame_host/render_frame_host_impl.cc | 8 +- content/browser/renderer_interface_binders.cc | 4 +- content/browser/websockets/websocket_manager.cc | 10 +- content/browser/websockets/websocket_manager.h | 1 + .../websockets/websocket_manager_unittest.cc | 1 + .../browser/worker_host/dedicated_worker_host.cc | 11 +- content/public/browser/content_browser_client.cc | 3 +- content/public/browser/content_browser_client.h | 3 +- .../browser/api/web_request/web_request_api.cc | 12 +- .../browser/api/web_request/web_request_api.h | 3 +- .../web_request/web_request_proxying_websocket.cc | 130 ++++++++++++++++++--- .../web_request/web_request_proxying_websocket.h | 21 +++- services/network/network_context.cc | 9 +- services/network/network_context.h | 3 +- .../network/network_service_network_delegate.cc | 21 ++++ .../network/public/mojom/network_context.mojom | 8 +- services/network/test/test_network_context.h | 3 +- services/network/websocket.cc | 75 ++++++++++++ services/network/websocket.h | 46 ++++++++ services/network/websocket_factory.cc | 3 +- services/network/websocket_factory.h | 2 + 27 files changed, 471 insertions(+), 78 deletions(-) commit 7123adc5e98d9f0a49790064cebb7a365a334d17 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 03:53:27 2019 +0000 Roll src/third_party/swiftshader 9b156615197d..1b8cd2d9ce2c (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/9b156615197d..1b8cd2d9ce2c git log 9b156615197d..1b8cd2d9ce2c --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dsinclair@google.com Copy build artifacts to CMAKE_BINARY_DIR. Created with: gclient setdep -r src/third_party/swiftshader@1b8cd2d9ce2c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123752208 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I382218117ff1227bbb9a460af0218462283d03c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525452 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641069} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 478090f913eb012ff15afe538cf18cf51ac6930b Author: Jazz Xu <jazzhsu@chromium.org> Date: Fri Mar 15 03:53:24 2019 +0000 [Media Controls] Arrow key handling Handle arrow keys for volume up/down, seek forward/backward. Bug: 942151 Change-Id: I71ba2f6d557fa824535c5fbfa4a5b87dca119239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522335 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641068} .../non_touch/media_controls_non_touch_impl.cc | 126 +++++++++++++++++++- .../non_touch/media_controls_non_touch_impl.h | 15 +++ .../media_controls_non_touch_impl_test.cc | 127 +++++++++++++++++++-- 3 files changed, 258 insertions(+), 10 deletions(-) commit daaeb82ec89cec76961a1d69a21f405fb08d0220 Author: Harley Li <hhli@chromium.org> Date: Fri Mar 15 03:51:22 2019 +0000 [DevTools] Display number of entries in an IndexedDB object store The number of entries stored in an object store is an important metadata. Bug: 941197 Change-Id: I8166a106593fecb34428825787e884f51d11963b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512692 Commit-Queue: Haihong Li (Harley) <hhli@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641067} .../renderer/core/inspector/browser_protocol.pdl | 14 ++- .../core/inspector/inspector_protocol_config.json | 2 +- .../devtools/front_end/resources/IndexedDBModel.js | 20 ++-- .../devtools/front_end/resources/IndexedDBViews.js | 33 +++--- .../indexeddb/inspector_indexed_db_agent.cc | 129 +++++++++++++-------- .../modules/indexeddb/inspector_indexed_db_agent.h | 9 +- .../devtools/indexeddb/database-data-expected.txt | 6 +- .../http/tests/devtools/indexeddb/database-data.js | 19 ++- 8 files changed, 142 insertions(+), 90 deletions(-) commit e05c7762ddd3b73a408a89c091aa0b46757a5710 Author: Anand K. Mistry <amistry@chromium.org> Date: Fri Mar 15 03:46:21 2019 +0000 Fix SMB mDNS host discovery. The return value of MDnsClient::StartListening() changed from a bool to an int, which effectively inversed the result. BUG=942390 Change-Id: I808836086203f3500c94160784d8135b4de8926d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525254 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#641066} chrome/browser/chromeos/smb_client/discovery/mdns_host_locator.cc | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 847d871a716ed5243ff92e48f9279d86bee0884f Author: Eugene But <eugenebut@google.com> Date: Fri Mar 15 03:31:52 2019 +0000 Fix NavigationContext::HasCommitted if WebState has multiple pending navigations. For new navigations GetPendingItem() may not return the item associated with current navigation. So existing code incorrectly computed pending item URL when there are more than one pending navigations. This CL fixes the computation of pendingURL by using pending URL from NavigationContext for new navigations. Bug: 899827 Change-Id: Iea949ef96d64d40c28d38fdb21af127fdd0fff6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519331 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641065} ios/web/web_state/ui/crw_web_controller.mm | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) commit 8eab09675658354839e6a047427d63cc7c51993d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 03:30:29 2019 +0000 Roll src/third_party/perfetto 8320e6d2b742..34e6c9d3d1b6 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/8320e6d2b742..34e6c9d3d1b6 git log 8320e6d2b742..34e6c9d3d1b6 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 fmayer@google.com Use relaxed increment for stats in ring buffer. Created with: gclient setdep -r src/third_party/perfetto@34e6c9d3d1b6 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:126724929 TBR=perfetto-bugs@google.com Change-Id: I5b740b6b752ed62d7a469fce2f7f1441baa8ce81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525522 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641064} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 869671963e2246aaa01bec4f4b40458456cbe60c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 03:26:13 2019 +0000 Roll src/third_party/dawn 5625b6320279..d263d752ac35 (1 commits) https://dawn.googlesource.com/dawn.git/+log/5625b6320279..d263d752ac35 git log 5625b6320279..d263d752ac35 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 hao.x.li@intel.com Fix scissor rect larger than render pass width/height in Metal backend Created with: gclient setdep -r src/third_party/dawn@d263d752ac35 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I29c074bf7255a3d60dffb1dc392e237461fa9f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525523 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641063} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a75df8ee6e26020c55ffa6108d6c40514ee7c6f5 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Mar 15 03:23:28 2019 +0000 Update V8 to version 7.5.47. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f6dd8f7..e6ea6c00 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3463a17314e1fb321c7e4dbf291835f810d3e463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525448 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641062} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9b9fae0f892483e685ba43406cc5fd042d1d7320 Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 03:16:07 2019 +0000 Change navigator.gpu.getAdapter to navigator.gpu.requestAdapter. This function now returns a Promise instead of getting an adapter synchronously. GPUAdapterDescriptor is renamed to GPURequestAdapterOptions. Bug: 941531 Change-Id: If8a996fe15adc6301f7378ce15f084cba1ae2601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521235 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641061} third_party/blink/renderer/modules/modules_idl_files.gni | 2 +- third_party/blink/renderer/modules/webgpu/gpu.cc | 15 ++++++++++++--- third_party/blink/renderer/modules/webgpu/gpu.h | 9 ++++++--- third_party/blink/renderer/modules/webgpu/gpu.idl | 5 ++++- ...ter_descriptor.idl => gpu_request_adapter_options.idl} | 5 ++--- 5 files changed, 25 insertions(+), 11 deletions(-) commit e0245949b9cf07609ab922480585b2f1ddb4e1e3 Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Fri Mar 15 03:13:37 2019 +0000 Updating trunk VERSION from 3734.0 to 3735.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: Ib942d816a32db8edc45e5206cc8acea8fc3842a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525414 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641060} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 67eee7cfb86d4cdf9d6e074d8f20189eadfd3d91 Author: Kenneth Russell <kbr@chromium.org> Date: Fri Mar 15 03:08:14 2019 +0000 Update Swarming dimensions of Linux Intel HD 630 Experimental bot. It's been upgraded to Mesa 18.3.3 from 18.0.5. Bug: 928530 Change-Id: I2cebf3cfe028ed4e3108b021fc5277c818b66943 Tbr: sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525407 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641059} testing/buildbot/chromium.gpu.fyi.json | 34 +++++++++++++++++----------------- testing/buildbot/mixins.pyl | 2 +- 2 files changed, 18 insertions(+), 18 deletions(-) commit 6012d3cb4069456e3e72b09b2b4a55559c43d05c Author: dpapad <dpapad@chromium.org> Date: Fri Mar 15 03:02:24 2019 +0000 Settings WebUI: Remove double border in font subpage. Before/after screenshots: https://imgur.com/a/0NpIjAz Bug: None Change-Id: I0a8db2d980ae58c489e4375e2d83505eabc424b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524715 Reviewed-by: Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641058} .../resources/settings/appearance_page/appearance_fonts_page.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 01e38032e30184e8e6c4669315d89e420ea9b5b6 Author: Nate Fischer <ntfschr@chromium.org> Date: Fri Mar 15 03:00:42 2019 +0000 NS: fix test filter syntax I added some tests to the filter in http://crrev/c/1522556. I forgot that "#" is illegal, and I should use "." instead. TBR=timvolodine@chromium.org Bug: 941856, 941858 Test: N/A Change-Id: I153abf26f9098460e2e9f2a6454978ae3682c9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525413 Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641057} .../buildbot/filters/mojo.fyi.network_chrome_public_test_apk.filter | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 9c719d1d65362fb85c90bb11719f513d44a35255 Author: Paul Dyson <pdyson@chromium.org> Date: Fri Mar 15 02:59:12 2019 +0000 Disable flaky tests in UserActivityManagerTest and WindowActivityWatcherTest Disable UserActivityManagerTest.BasicTabs as it has been flagged as flaky. Also disable WindowActivityWatcherTest.Basic and WindowActivityWatcherTest.ReplaceTab which sometimes fail at the same time as UserActivityManagerTest.BasicTabs. Bug: 938055 Change-Id: Ib8c8ce28e565cd032a5d1255a6e355a449679e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504474 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641056} chrome/browser/chromeos/power/ml/user_activity_manager_unittest.cc | 3 ++- chrome/browser/ui/tabs/window_activity_watcher_unittest.cc | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) commit fa3c60680c891176c2c3342fbabed75e23f745a2 Author: Sergiy Belozorov <sergiyb@chromium.org> Date: Fri Mar 15 02:55:32 2019 +0000 Only delete WPR if it is not used by other stories R=perezju@chromium.org Bug: 895891 Change-Id: I2f363662f6f9ce4da0c6c76674db94c0404fa21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523093 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641055} tools/perf/cli_tools/update_wpr/update_wpr.py | 20 ++++++++++++++------ .../perf/cli_tools/update_wpr/update_wpr_unittest.py | 10 +++++++++- 2 files changed, 23 insertions(+), 7 deletions(-) commit 5d85114cbc8ab79b7f88a74220503e05081475e9 Author: Darren Shen <shend@chromium.org> Date: Fri Mar 15 02:55:13 2019 +0000 [VK] Remove some old features and flags. Change-Id: I3a21355822ad2c8e4b59c542471e280b656e6500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520859 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#641054} chrome/browser/about_flags.cc | 13 ------------- .../extensions/api/input_ime/input_ime_api_chromeos.cc | 3 +-- .../chrome_virtual_keyboard_delegate.cc | 5 +---- chrome/browser/flag_descriptions.cc | 16 ---------------- chrome/browser/flag_descriptions.h | 9 --------- ui/base/ui_base_features.cc | 11 ----------- ui/base/ui_base_features.h | 6 ------ ui/keyboard/keyboard_ukm_recorder.cc | 4 +--- ui/keyboard/keyboard_ukm_recorder_unittest.cc | 8 -------- 9 files changed, 3 insertions(+), 72 deletions(-) commit 5428f7c6e1aaa7d3457e0954e21382495ac31e0c Author: Nigel Tao <nigeltao@chromium.org> Date: Fri Mar 15 02:51:55 2019 +0000 Add an App Service icon cache BUG=826982 Change-Id: Id697f87ffb5dc143caea60fc02fd91133cb60938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522869 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641053} chrome/browser/BUILD.gn | 1 + .../browser/apps/app_service/app_service_proxy.cc | 42 ++-- .../browser/apps/app_service/app_service_proxy.h | 20 +- chrome/services/app_service/public/cpp/BUILD.gn | 14 ++ .../services/app_service/public/cpp/icon_cache.cc | 155 +++++++++++++++ .../services/app_service/public/cpp/icon_cache.h | 116 +++++++++++ .../app_service/public/cpp/icon_cache_unittest.cc | 212 +++++++++++++++++++++ .../services/app_service/public/cpp/icon_loader.cc | 66 +++++++ .../services/app_service/public/cpp/icon_loader.h | 99 ++++++++++ .../services/app_service/public/mojom/types.mojom | 3 + 10 files changed, 701 insertions(+), 27 deletions(-) commit 5618e8eadac015c2411429fe1775ec882810ddcc Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Mar 15 02:49:05 2019 +0000 [Audio Focus] Return id from request audio focus Return the ID from RequestAudioFocus which the media session can then be used to identify itself. This is for assistant so they can differentiate between the AssistantMediaSession and other sessions when controlling them. BUG=941578 Change-Id: Ie114c36b111e79125c918b9964196b3434d1294e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521472 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641052} .../media_session/assistant_media_session.cc | 8 +- .../media_session/assistant_media_session.h | 2 + .../media/session/audio_focus_delegate_default.cc | 13 +++- services/media_session/audio_focus_manager.cc | 33 ++++----- services/media_session/audio_focus_manager.h | 3 +- .../media_session/audio_focus_manager_unittest.cc | 2 +- .../media_session/media_controller_unittest.cc | 13 +++- .../public/cpp/test/mock_media_session.cc | 86 +++++++++++----------- .../public/cpp/test/mock_media_session.h | 8 +- .../media_session/public/mojom/audio_focus.mojom | 15 ++-- 10 files changed, 101 insertions(+), 82 deletions(-) commit 0fcaa3b3fca2d10171f5bd2423b5a2ad55debada Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 02:47:01 2019 +0000 Convert ui::PlatformEventWaiter::PlatformEventMatcher and Related Code to base::RepeatingCallback BUG=714018,940130 TBR=sky@chromium.org Change-Id: I2dcacc52febbe0aeb72e90fe390239d1cb9ac201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525481 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641051} ui/aura/test/ui_controls_factory_aurax11.cc | 3 ++- ui/events/test/platform_event_waiter.cc | 14 ++++++++------ ui/events/test/platform_event_waiter.h | 7 ++++--- ui/views/test/ui_controls_factory_desktop_aurax11.cc | 3 ++- 4 files changed, 16 insertions(+), 11 deletions(-) commit 3e4613d9e2e704b6dcaaa362b7b6a355fd03b4ab Author: Yupei Lin <yplam@yplam.com> Date: Fri Mar 15 02:46:22 2019 +0000 Fix gdb viewg command While following the steps from docs/graphical_debugging_aid_chromium_views.md using gdb. Change-Id: Ic4d2193c29604bc548bdb6c84e8f0f70684366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522560 Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641050} AUTHORS | 1 + tools/gdb/viewg.gdb | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) commit 8c30e8ce823191ef55a548420df7e290a95d4cbc Author: Shu Chen <shuchen@google.com> Date: Fri Mar 15 02:45:12 2019 +0000 Move the mojom & typemap for ui::TextInputType to ui/base/ime/mojo. Currently the mojom for ui::TextInputType is under ui/platform_window/mojo, and the typemap is under services/ws/public/mojom/ime. It will cause problem if some other code wants to use ui.mojom.TextInputType. ui::TextInputType is defined under ui/base/ime, where the mojom and typemap should be. Bug: 937167 Change-Id: Ie62a49e7d9f0be5d8f6b9038b581543b8d9ca0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517339 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641049} content/common/render_widget_host_ns_view.mojom | 1 + .../bindings/chromium_bindings_configuration.gni | 5 +- services/ws/public/mojom/BUILD.gn | 2 +- services/ws/public/mojom/ime/BUILD.gn | 12 +- services/ws/public/mojom/ime/ime.mojom | 16 +-- services/ws/public/mojom/ime/ime.typemap | 2 - services/ws/public/mojom/ime/ime_struct_traits.cc | 129 ------------------- services/ws/public/mojom/ime/ime_struct_traits.h | 12 -- .../public/mojom/ime/ime_struct_traits_unittest.cc | 71 +---------- ui/aura/mus/input_method_mus.cc | 2 +- ui/base/BUILD.gn | 6 +- ui/base/ime/DEPS | 1 + ui/base/ime/mojo/BUILD.gn | 21 ++++ ui/base/ime/mojo/OWNERS | 8 ++ .../base/ime/mojo}/ime_struct_traits_test.mojom | 7 +- ui/base/ime/mojo/ime_struct_traits_unittest.cc | 96 ++++++++++++++ ui/base/ime/mojo/ime_types.mojom | 56 +++++++++ ui/base/ime/mojo/ime_types.typemap | 21 ++++ ui/base/ime/mojo/ime_types_struct_traits.cc | 138 +++++++++++++++++++++ ui/base/ime/mojo/ime_types_struct_traits.h | 30 +++++ ui/base/ime/mojo/typemaps.gni | 5 + ui/platform_window/mojo/BUILD.gn | 6 +- ui/platform_window/mojo/ime_type_converters.cc | 14 --- ui/platform_window/mojo/ime_type_converters.h | 12 -- ui/platform_window/mojo/text_input_state.mojom | 38 +----- 25 files changed, 400 insertions(+), 311 deletions(-) commit 752a1561485e8ed8d0dc38335a5a9a6058753762 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 02:42:02 2019 +0000 Roll src/third_party/swiftshader a2749f39f47d..9b156615197d (2 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/a2749f39f47d..9b156615197d git log a2749f39f47d..9b156615197d --date=short --no-merges --format='%ad %ae %s' 2019-03-14 bclayton@google.com SpirvShader: Split instructions into blocks. 2019-03-14 capn@google.com Fix allocation of low-alignment memory Created with: gclient setdep -r src/third_party/swiftshader@9b156615197d The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128527271 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5385d7628f5985a5085977d08495951d0c8569a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525034 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641048} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 95c1f858b14bbf3d619c1ce0ca0630603535233c Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri Mar 15 02:40:11 2019 +0000 [layoutng] Inline a couple more geometry functions Change-Id: I9c0c299f8aa576ea34f357ac88c2c79c0a50fb48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1315669 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641047} third_party/blink/renderer/core/layout/BUILD.gn | 1 - .../core/layout/ng/geometry/ng_border_edges.cc | 36 --------------- .../core/layout/ng/geometry/ng_border_edges.h | 27 ++++++++++- .../core/layout/ng/geometry/ng_box_strut.cc | 50 -------------------- .../core/layout/ng/geometry/ng_box_strut.h | 54 +++++++++++++++++++++- 5 files changed, 77 insertions(+), 91 deletions(-) commit 6130949eaaf724cec6c90b2b54515b9e3dfe81e1 Author: Qingsi Wang <qingsi@chromium.org> Date: Fri Mar 15 02:27:48 2019 +0000 Move the getUserMedia gating of mDNS protection to FilteringNetworkManager. Our previous implementation would destroy the connection to the mDNS responder service host when the media capture permission is granted. As a result, any mDNS candidate created before the grant would become unresolvable. This issue is particularly evident when we have multiple peer connections of the same origin, where a newly created peer connection would temporarily toggle the permission to blocked before restoring the granted status if the user did give the permission. This could cause a peer connection created earlier and in the process of ICE candidate gathering to perform unnecessary mDNS obfuscation. After this change, the connection to the mDNS responder service host keeps alive, but just becomes unavailable for registration of new names when we have permissions granted. Bug: 930339, 937992 Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 Commit-Queue: Qingsi Wang <qingsi@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641046} .../webrtc/peer_connection_dependency_factory.cc | 49 +++++++--------------- .../webrtc/peer_connection_dependency_factory.h | 12 ++---- content/renderer/p2p/filtering_network_manager.cc | 30 +++++++------ content/renderer/p2p/filtering_network_manager.h | 13 +----- .../p2p/filtering_network_manager_unittest.cc | 4 +- content/renderer/p2p/ipc_network_manager.cc | 18 ++++---- content/renderer/p2p/ipc_network_manager.h | 6 +-- .../renderer/p2p/ipc_network_manager_unittest.cc | 3 +- 8 files changed, 49 insertions(+), 86 deletions(-) commit 609b4bbd7be1c7620c78a184a276d566f1e05a10 Author: Ben Hayden <benjhayden@chromium.org> Date: Fri Mar 15 02:27:02 2019 +0000 Reland Batch Histogram uploads. Some benchmarks such as rendering.mobile produce more data than the chromeperf dashboard can handle at once. This CL passes the new --max_bytes flag to add_reserved_diagnostics to batch histograms into multiple files, then uploads them one at a time. Initial CL: https://chromium-review.googlesource.com/c/1478085 Revert: https://chromium-review.googlesource.com/c/chromium/src/+/1486679 Reason for revert: File "...\upload_results_to_perf_dashboard.py", line 61, in _GenerateDashboardJSONs with open(options.output_json_file, 'w') as f: TypeError: coercing to Unicode: need string or buffer, file found Patchset 1 is the initial CL. Patchset 5 simplifies the initial approach and adds a test. Bug: chromium:909961 Change-Id: Ia66cff24531333ecea386785ccbae04e7386f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515649 Commit-Queue: Ben Hayden <benjhayden@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Simon Hatch <simonhatch@chromium.org> Cr-Commit-Position: refs/heads/master@{#641045} tools/perf/core/results_dashboard.py | 36 ++--- .../perf/core/upload_results_to_perf_dashboard.py | 72 +++++++--- tools/perf/process_perf_results.py | 149 +++++++++++---------- tools/perf/process_perf_results_unittest.py | 58 +++++++- 4 files changed, 202 insertions(+), 113 deletions(-) commit bfb994e1a78fd93a6adfacec2bb1fd665b4b58af Author: Siye Liu <siliu@microsoft.com> Date: Fri Mar 15 02:26:41 2019 +0000 Append block element that only contains br element onto clipboard during copy if the block element is at selection end. This patch adds a logic in blink::StyledMarkupSerializer<Strategy>::CreateMarkup and blink::StyledMarkupTraverser<Strategy>::Traverse so that the empty block element that only contains br element can be appended to blink::StyledMarkupAccumulator if the block element is at the end of selection during copy. The logic helps in creating the right markup to put onto clipboard during serialization. For example, <i>some text</i><p><br></p>, select all and copy, clipboard content should be look like: <!--startFrament--><i>some text</i></font><p><br></p><!--EndFragment--> Bug: 856324 Change-Id: Idd55bde473d4e6b3d7bf06b62167dd227ae65672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495371 Commit-Queue: Siye Liu <siliu@microsoft.com> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641044} .../serializers/styled_markup_serializer.cc | 28 ++++++- ...ste-blockquote-and-paragraph-break-expected.txt | 45 ---------- .../paste-blockquote-and-paragraph-break.html | 61 ++++++-------- .../editing/pasteboard/paste-text-016.html | 93 ++++++++++----------- ...ine-break-at-end-of-pasted-content-expected.txt | 18 ---- ...eserve-line-break-at-end-of-pasted-content.html | 53 ++++++------ .../editing/pasteboard/paste-text-016-expected.png | Bin 19984 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- .../editing/pasteboard/paste-text-016-expected.png | Bin 6555 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- .../editing/pasteboard/paste-text-016-expected.png | Bin 6439 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.txt | 59 ------------- 12 files changed, 124 insertions(+), 351 deletions(-) commit 457193040c9cb74b8eb7d524bbec073385a47758 Author: Becky Zhou <huayinz@chromium.org> Date: Fri Mar 15 02:23:28 2019 +0000 Fix search widget location bar color not correct We simplified the location bar text color logic to be mostly based on the primary color at https://chromium-review.googlesource.com/c/chromium/src/+/1489416. This becomes an issue for the search widget because the primary color was transparent all the time. Bug: 940897 Change-Id: I16db7596d9a0db0ee277a106b5b890be2045e391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525286 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641043} chrome/android/java/res/layout/search_activity.xml | 2 +- .../chrome/browser/searchwidget/SearchActivity.java | 2 +- .../chrome/browser/searchwidget/SearchBoxDataProvider.java | 13 ++++++++++++- 3 files changed, 14 insertions(+), 3 deletions(-) commit 76e3f160394df9e89d62be3a85ca5a2fd68b25db Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Mar 15 02:22:48 2019 +0000 Roll src/ios/third_party/edo/src/ 0146bd6e1..57586e721 (1 commit) https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/0146bd6e1f05..57586e721389 $ git log 0146bd6e1..57586e721 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 haowoo Move the block from the stack to the heap before assigning it to the weak pointer. Created with: roll-dep src/ios/third_party/edo/src BUG=941680 Change-Id: Id616069d5894a535839547169669d49b02648e50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524653 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641042} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 44a2f14903cae5f66435ffb42635089453721c04 Author: Peter Boström <pbos@chromium.org> Date: Fri Mar 15 02:21:48 2019 +0000 Remove custom InkDrop logic from NewTabButton This change removes InkDropContainerView usage and overrides of: * AddInkDropLayer * RemoveInkDropLayer * CreateInkDrop * CreateInkDropRipple * CreateInkDropHighlight * CreateInkDropMask ... and replaces them with a HighlightPath already in use by the FocusRing. Bug: None Change-Id: Id347f19d32f8b38443092eedd6604c71c5d9e6f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525462 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#641041} chrome/browser/ui/views/tabs/new_tab_button.cc | 71 +++----------------------- chrome/browser/ui/views/tabs/new_tab_button.h | 19 +------ chrome/browser/ui/views/tabs/tab_strip.cc | 5 +- 3 files changed, 11 insertions(+), 84 deletions(-) Updated tag 'tree_truth' (was 068025b22e63)