Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 44197 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918886017015478688 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it2D3jel/luci_context.088244921 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2227-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 439c06c5dacf4311 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 3c3b2fa2c0a9bf0684b99b788fbd53a8de0f2fe2 sensors: Move SensorReader::thread_checker_ to PollingSensorReader Raphael Kubo da Costa, Fri Mar 15 21:15:55 2019 +0000 512a24da877a5916875a11b55d0a043e09fb0be7 Add metrics about number of display items, subsequences and paint chunks Xianzhu Wang, Fri Mar 15 21:14:10 2019 +0000 c2f7f0a97b615657ea6e1e4dfc4084170aa0d376 Remove crbug.com/904400 workaround. Mirko Bonadei, Fri Mar 15 21:13:36 2019 +0000 0209d8d2c67bcbe798c12ba293975536460387a3 Improve logs in ExternalVkImageBacking when BeginAccess fails Saman Sami, Fri Mar 15 21:12:47 2019 +0000 41bde581e91d08d30991ab63dab2fe18eb1d074f [Sampling profiler] Hoist top frame bool manipulation Mike Wittman, Fri Mar 15 21:11:01 2019 +0000 7a50610bb0146a001c5bbae126445186e7c36b05 PM: Fix a crash on GPU process exit notification. Sigurdur Asgeirsson, Fri Mar 15 21:09:09 2019 +0000 dc2c91d1d1cf5aeac19b25210e470909f175b160 [Zucchini] Add helpers for 2 byte and 4 byte alignment. Samuel Huang, Fri Mar 15 21:08:23 2019 +0000 386583bbe5a57761ff36bf925066f281b57d9d26 Support international characters in animation worklets. Kevin Ellis, Fri Mar 15 21:06:57 2019 +0000 e5737708dcead1b3e031fabfb05a4f518ee727b2 PDF Viewer: Use HTML imports polyfill rbpotter, Fri Mar 15 21:04:24 2019 +0000 d8951befac58618473a3ea2db3c423dd3753fc8a Add different lock screen messages to each Time Limit policy. Henrique Grandinetti, Fri Mar 15 21:04:05 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 3c3b2fa2c0a9bf0684b99b788fbd53a8de0f2fe2 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Fri Mar 15 21:15:55 2019 +0000 sensors: Move SensorReader::thread_checker_ to PollingSensorReader This does not have any visible effects, but it improves design: whether to use a ThreadChecker, a SequenceChecker or nothing at all is part of the implementation strategy of each SensorReader subclass, so |thread_checker_| shouldn't be in SensorReader itself. Bug: 941559 Change-Id: Ifb9eb5a8460077ae7ae96d7ade79537257c63812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525937 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641285} .../device/generic_sensor/platform_sensor_reader_linux.cc | 15 +++++++++------ .../device/generic_sensor/platform_sensor_reader_linux.h | 5 ----- 2 files changed, 9 insertions(+), 11 deletions(-) commit 512a24da877a5916875a11b55d0a043e09fb0be7 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Fri Mar 15 21:14:10 2019 +0000 Add metrics about number of display items, subsequences and paint chunks The existing metrics about percentages of cached display items and subsequences show that LayoutNG is painting more uncached display items and subsequences. This might mean that we are invalidating more in LayoutNG, but might also mean that we are painting more. Add metrics about the numbers of display items, subsequences and paint chunks so see how they differ between LayoutNG and legacy. The number of paint chunks may also helpful for analyzing performance of CompositeAfterPaint. Bug: 940806 Change-Id: If3dbaee9eeb0dad9fea70b9206922c48d69847a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525997 Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641284} .../platform/graphics/paint/paint_controller.cc | 13 +++++- .../platform/graphics/paint/paint_controller.h | 6 +-- tools/metrics/histograms/histograms.xml | 46 ++++++++++++++++++---- 3 files changed, 52 insertions(+), 13 deletions(-) commit c2f7f0a97b615657ea6e1e4dfc4084170aa0d376 Author: Mirko Bonadei <mbonadei@chromium.org> Date: Fri Mar 15 21:13:36 2019 +0000 Remove crbug.com/904400 workaround. Removes code that should've been removed in https://chromium-review.googlesource.com/c/chromium/src/+/1394742. Bug: 904400 Change-Id: I43ead0e293117a7292d761085c3aa3cec41d49d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524343 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641283} build_overrides/build.gni | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) commit 0209d8d2c67bcbe798c12ba293975536460387a3 Author: Saman Sami <samans@chromium.org> Date: Fri Mar 15 21:12:47 2019 +0000 Improve logs in ExternalVkImageBacking when BeginAccess fails Add logs to BeginGlReadAccess, and split BeginGlWriteAccess logs into two. Bug: 930333 Change-Id: Iba1a78262ae4c40444ea38a708202903ea8f2e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526170 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#641282} .../service/external_vk_image_backing.cc | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) commit 41bde581e91d08d30991ab63dab2fe18eb1d074f Author: Mike Wittman <wittman@chromium.org> Date: Fri Mar 15 21:11:01 2019 +0000 [Sampling profiler] Hoist top frame bool manipulation Moves manipulation of the top frame boolean into a separate function to minimize chance of forgetting to set the state before returning from the unwinding function. Also, make the implementation static and pass all dependent state via parameters to make depencies explicit. No functional change is intended. Bug: 931418 Change-Id: I6b73405ed4142a8bc4af0325f6b417546534a689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513203 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641281} base/profiler/win32_stack_frame_unwinder.cc | 26 +++++++++++++++++--------- base/profiler/win32_stack_frame_unwinder.h | 8 ++++++-- 2 files changed, 23 insertions(+), 11 deletions(-) commit 7a50610bb0146a001c5bbae126445186e7c36b05 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Fri Mar 15 21:09:09 2019 +0000 PM: Fix a crash on GPU process exit notification. Bug: 942500 Change-Id: I1af70d04081db1fb1a4f1880f00dee1406e55de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525987 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#641280} .../performance_manager/browser_child_process_watcher.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit dc2c91d1d1cf5aeac19b25210e470909f175b160 Author: Samuel Huang <huangs@chromium.org> Date: Fri Mar 15 21:08:23 2019 +0000 [Zucchini] Add helpers for 2 byte and 4 byte alignment. This CL adds specialized versions of AlignCeil(): {IncrementForAlignCeil2(), IncrementForAlignCeil4()}. Given a value to be aligned, these functions return an increment that the caller can add to the given value to cause alignment. This scheme admits iterator alignment. e.g., by: aligned_it = it + IncrementForAlignCeil4(it - base_it); These functions will be used by code to add ARM support. Bug: 918867 Change-Id: I6da038a748a29cde82e4c82e597455644213abd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524920 Reviewed-by: Samuel Huang <huangs@chromium.org> Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641279} components/zucchini/algorithm.h | 14 ++++++++++++++ components/zucchini/algorithm_unittest.cc | 27 +++++++++++++++++++++++++++ 2 files changed, 41 insertions(+) commit 386583bbe5a57761ff36bf925066f281b57d9d26 Author: Kevin Ellis <kevers@chromium.org> Date: Fri Mar 15 21:06:57 2019 +0000 Support international characters in animation worklets. Code in cc/ is not permitted to use wtf::String. Thus, we perform conversions between wtf::String and std::string. The later is not aware of encodings. This is OK provided a consistent encoding is used for round tripping, where the encoding supports the set of allowed characters. The UTF-8 encoding is adequate for this task and supported by wtf::String. Bug: 940493 Change-Id: Ie2b994412f502ea11df06713439b8cf8ffedc885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524087 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#641278} .../modules/animationworklet/worklet_animation.cc | 6 +-- .../platform/animation/compositor_animation.cc | 4 +- .../worklet-animation-with-non-ascii-name-ref.html | 12 +++++ ...orklet-animation-with-non-ascii-name.https.html | 59 ++++++++++++++++++++++ 4 files changed, 75 insertions(+), 6 deletions(-) commit e5737708dcead1b3e031fabfb05a4f518ee727b2 Author: rbpotter <rbpotter@chromium.org> Date: Fri Mar 15 21:04:24 2019 +0000 PDF Viewer: Use HTML imports polyfill - Imports the HTML imports polyfill into the PDF viewer, and adjusts as needed to allow the polyfill to finish loading before creating Polymer elements that require imports. - Reverts https://chromium-review.googlesource.com/c/chromium/src/+/1405955, which created an exception for the PDF viewer to use HTML imports after they are deprecated. - Testing: PDF viewer + Print Preview with and browser_tests with filter *PDFExtension* with the --disable-blink-features=HTMLImports. Bug: 924031 Change-Id: Ife1c2402933f3eec399927212c6738955cdb8b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481607 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#641277} chrome/browser/resources/pdf/index.html | 2 ++ chrome/browser/resources/pdf/main.js | 14 ++++++++------ extensions/renderer/dispatcher.cc | 10 +++++++--- 3 files changed, 17 insertions(+), 9 deletions(-) commit d8951befac58618473a3ea2db3c423dd3753fc8a Author: Henrique Grandinetti <hgrandinetti@chromium.org> Date: Fri Mar 15 21:04:05 2019 +0000 Add different lock screen messages to each Time Limit policy. Previously, a single message was displayed independently of what was locking the device. Preview of the new screens: https://screenshot.googleplex.com/AAoz8u8dowy https://screenshot.googleplex.com/fMBeaMz7tc6 https://screenshot.googleplex.com/iY17J9OH9X5 https://screenshot.googleplex.com/YFHCbFRpTaQ https://screenshot.googleplex.com/padYPM0EYsa https://screenshot.googleplex.com/azPSahevLuw Bug: 930099 Change-Id: If73c2255e0c5dc87a9fbf11879130e09c388083a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1456917 Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#641276} ash/login/login_screen_controller.cc | 14 +- ash/login/login_screen_controller.h | 6 +- ash/login/ui/lock_contents_view.cc | 37 +++-- ash/login/ui/lock_contents_view.h | 7 +- ash/login/ui/lock_contents_view_unittest.cc | 58 ++++---- ash/login/ui/lock_debug_view.cc | 37 ++++- ash/login/ui/login_auth_user_view.cc | 149 ++++++++++++++++++--- ash/login/ui/login_auth_user_view.h | 8 +- ash/login/ui/login_data_dispatcher.cc | 21 +-- ash/login/ui/login_data_dispatcher.h | 20 +-- ash/public/interfaces/login_screen.mojom | 48 +++++-- ash/resources/vector_icons/BUILD.gn | 4 +- .../vector_icons/lock_screen_time_limit_alarm.icon | 37 ----- .../vector_icons/lock_screen_time_limit_lock.icon | 32 +++++ .../vector_icons/lock_screen_time_limit_moon.icon | 37 +++++ .../vector_icons/lock_screen_time_limit_timer.icon | 32 +++++ .../child_accounts/screen_time_controller.cc | 81 +++++++---- .../child_accounts/screen_time_controller.h | 25 ++-- .../browser/chromeos/login/lock/screen_locker.cc | 23 ++-- chrome/browser/chromeos/login/lock/screen_locker.h | 15 ++- .../login/lock/screen_locker_browsertest.cc | 27 ++-- chrome/browser/ui/ash/test_login_screen.cc | 7 +- chrome/browser/ui/ash/test_login_screen.h | 6 +- 23 files changed, 523 insertions(+), 208 deletions(-) commit 40dcab153baa8a94a6a5fcbdabd1d0ab327e3343 Author: dalyk <dalyk@google.com> Date: Fri Mar 15 21:03:15 2019 +0000 Downgrade DoH hostname lookups to plaintext DNS. Using secure or automatic mode for DoH hostname lookups can lead to never-ending recursion. For example, if we had two DoH servers, neither of which had cached results for their hostnames, we would create a long chain of DoH transactions where each DoH server is trying to resolve the other DoH server's hostname. Bug: 878582 Change-Id: I58f5445d8deeae1e8988dfdd604eb26c7ba5b79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504234 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#641275} net/dns/dns_transaction.cc | 13 ++----------- net/dns/dns_transaction_unittest.cc | 12 +++++++----- net/dns/host_resolver_manager.cc | 13 ++++++++++++- net/dns/host_resolver_manager_unittest.cc | 23 +++++++++++++++++++++++ 4 files changed, 44 insertions(+), 17 deletions(-) commit a8ebf47163711054ee24e4cd327c390a9763d43c Author: James Darpinian <jdarpinian@chromium.org> Date: Fri Mar 15 21:01:53 2019 +0000 gpu: Disable sampler/texture type validation The sampler/texture type validation validation added in https://chromium-review.googlesource.com/c/1368832 did not correctly consider sampler objects. This is a minimal change to disable the validation temporarily, which I intend to merge back to 74. A fix for the validation is in progress at: https://chromium-review.googlesource.com/c/chromium/src/+/1513199 Bug: 940080, 809237 Change-Id: I1c2ed6ca7ad1e0b48f8e1a997dd8f34eb23a6c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525274 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#641274} .../gpu/gpu_tests/webgl2_conformance_expectations.py | 17 ++++++++++++++--- gpu/command_buffer/service/gles2_cmd_decoder.cc | 13 ------------- 2 files changed, 14 insertions(+), 16 deletions(-) commit 0e4807ab97bd4442b6766f721c1f8f1bef3db8d0 Author: Tommy Steimel <steimel@chromium.org> Date: Fri Mar 15 20:53:58 2019 +0000 [Media Controls] Prevent panel from getting stuck in transparent state This CL makes the MediaControlPanelElement remove it's "transparent" class even when the controls are hidden. This prevents the panel from getting stuck in a transparent state and remaining hidden even once the controls are shown. Bug: 933428 Change-Id: Ide89d5e347831f7f68b18df0d22376574b9061ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526307 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641273} .../elements/media_control_panel_element.cc | 2 +- ...nsparent-class-when-controls-are-not-shown.html | 39 ++++++++++++++++++++++ 2 files changed, 40 insertions(+), 1 deletion(-) commit 1fb0bb493b993ddf771f9aa957aa97d9aefe29bd Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri Mar 15 20:51:59 2019 +0000 Fix caBLE regression on Mac. caBLE was successfully establishing a connection to an external authenticator by correctly advertising and receiving advertisements, but never continued sending actual CTAP2 requests. The regression looks like it was introduced by crrev.com/1455647 as an unintended side effect of re-enabling caBLE on Windows. The embedder mistakenly thought it was responsible for handling the CTAP2 requests to the caBLE authenticator, and as there is no further UI involved to drive the request handling after the caBLE connection is established, the requests were never dispatched. This CL adds helpful logs as well. Bug: 941732 Change-Id: I5b34fbdee8bfd1e2c6d68b32554d25e524e152f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521980 Reviewed-by: Martin Kreichgauer <martinkr@google.com> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#641272} .../chrome_authenticator_request_delegate.cc | 7 ++-- device/fido/cable/fido_cable_device.cc | 2 ++ device/fido/cable/fido_cable_discovery.cc | 41 +++++++++++++--------- device/fido/cable/fido_cable_discovery.h | 6 ++-- device/fido/cable/fido_cable_handshake_handler.cc | 1 + device/fido/fido_device.cc | 4 ++- device/fido/fido_request_handler_base.cc | 4 +++ 7 files changed, 41 insertions(+), 24 deletions(-) commit 18ae9d500280b5521458286e00c5e4c84c7a7627 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Mar 15 20:50:17 2019 +0000 Barcode Detection Mac: Use CIDetector ISO Vision on 10.14.{0,1,2} The Vision API we use for Barcode detection on Mac is broken on 10.14.{0,1,2} (and I didn't know we have to consider the |patchVersion| explicitly and beyond the @available() check). This CL adds a static method BarcodeDetectionImplMacVision::IsBlockedMacOSVersion() and calls it appropriately to avoid using Vision and fallback to the CoreImage API on those Mac OS versions. Bug: 921968 Change-Id: I1c3f456cffd281842e7c68cfc9ee69f39f8d01b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524687 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641271} .../barcode_detection_impl_mac_unittest.mm | 6 ++-- .../barcode_detection_impl_mac_vision.h | 2 ++ .../barcode_detection_impl_mac_vision.mm | 9 ++++++ .../barcode_detection_provider_mac.mm | 37 ++++++++++++---------- .../barcode_detection_provider_mac_unittest.mm | 15 +++++---- 5 files changed, 44 insertions(+), 25 deletions(-) commit bbdac6ac5970f31a1fcc671248ad361d8c3f23be Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Mar 15 20:49:40 2019 +0000 Move SessionManagerClient::EmitAshInitialized call to Chrome Bug: 644350 Change-Id: I14196a6a6ad6f84d7243fb12540a1b8402c10e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525267 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#641270} ash/dbus/DEPS | 2 -- ash/dbus/ash_dbus_services.cc | 7 ------- ash/dbus/ash_dbus_services.h | 4 ---- ash/public/interfaces/session_controller.mojom | 4 ++++ ash/session/session_controller.cc | 5 +++++ ash/session/session_controller.h | 3 +++ ash/session/test_session_controller_client.cc | 2 ++ ash/session/test_session_controller_client.h | 1 + ash/shell.cc | 11 +++-------- chrome/browser/ui/ash/session_controller_client.cc | 12 ++++++++++++ chrome/browser/ui/ash/session_controller_client.h | 1 + 11 files changed, 31 insertions(+), 21 deletions(-) Updated tag 'tree_truth' (was 7ecdbf4c8077)