Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 39924 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918858889895116304 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it7kZLQN/luci_context.441856371 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2233-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 439d918bd48fec11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: b2c72608d8a4ee0bd08d6fc87fae0b4127a679bf Add checks in ChromeClientImpl for invalid ScheduleAnimation calls. danakj, Sat Mar 16 04:26:41 2019 +0000 5d646e711bbdcacf5379c941ad23ce3c4c46f8d7 Convert PlatformTestHelper::Factory to RepeatingCallback with Miscellaneous Cleanup Robert Liao, Sat Mar 16 04:25:12 2019 +0000 e1b1f3a5f273c8da533fad495b9de316e2c83c9b [base] Add Dead Type to base::Value jdoerrie, Sat Mar 16 04:08:01 2019 +0000 f33d6950649b1062d0ac1739ff713948af8adb0e Roll src/third_party/boringssl/src 3390fd88d..aadcce380 David Benjamin, Sat Mar 16 04:01:06 2019 +0000 dc12c3e904b755ce68f5048732a091fc946d0448 Implemented ITextRangeProvider::CompareEndpoints Victor Fei, Sat Mar 16 04:00:21 2019 +0000 5876e5c517d396bf1dfa9c7a5d2d056e55ec80e6 Fix media::VideoFrame double deletion Sergey Abbakumov, Sat Mar 16 04:00:02 2019 +0000 34097108d4dbff9895ed9bed167050ea3ba30ec1 Handle longer blocks and bypasses in DRP rajendrant, Sat Mar 16 03:57:51 2019 +0000 4a3a0dbd1480af83e9f996734ec7bd51e703ed6e Reland "OnionSoup: Move mojom files from public/platform/web to public/mojom folder" Julie Jeongeun Kim, Sat Mar 16 03:52:41 2019 +0000 38d91556db2ee20b573e9133434042e3d3f41599 Replace Autofill Substring Match switch with feature Tommy Martino, Sat Mar 16 03:50:20 2019 +0000 fc9e445c7a43ef620177c8039711cd64fde82aee Roll src/third_party/catapult 0a33de82760c..4e9bccd7a0cf (6 commits) chromium-autoroll, Sat Mar 16 03:45:21 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit b2c72608d8a4ee0bd08d6fc87fae0b4127a679bf Author: danakj <danakj@chromium.org> Date: Sat Mar 16 04:26:41 2019 +0000 Add checks in ChromeClientImpl for invalid ScheduleAnimation calls. We expect that we don't go to ScheduleAnimation if the document is shutdown. We can perhaps also see if the frame is the mainframe or another frame with an aliased local variable. R=dcheng@chromium.org Bug: 939262 Change-Id: Iafe808bcda161cffdb5889c438bc232398db01af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526431 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641406} .../blink/renderer/core/exported/web_view_impl.cc | 6 ++++++ .../blink/renderer/core/page/chrome_client_impl.cc | 19 +++++++++++++++++++ .../blink/renderer/core/page/chrome_client_impl.h | 7 +++++++ 3 files changed, 32 insertions(+) commit 5d646e711bbdcacf5379c941ad23ce3c4c46f8d7 Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 04:25:12 2019 +0000 Convert PlatformTestHelper::Factory to RepeatingCallback with Miscellaneous Cleanup BUG=714018,940130 TBR=sky@chromium.org Change-Id: I6fe5a4d82d299bc0676a802bc42c28086dc796bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526742 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641405} ui/views/test/platform_test_helper.cc | 16 +++++++++------- ui/views/test/platform_test_helper.h | 8 +++++--- 2 files changed, 14 insertions(+), 10 deletions(-) commit e1b1f3a5f273c8da533fad495b9de316e2c83c9b Author: jdoerrie <jdoerrie@chromium.org> Date: Sat Mar 16 04:08:01 2019 +0000 [base] Add Dead Type to base::Value This change adds a temporary DEAD type to base::Value which should help to track down use-after-free bugs. Furthermore, this change also removes the now unneeded is_alive_ flag. Bug: 859477, 941404 Change-Id: I9b7a2f3cbb0b22d7e3ed35b2453537419f3f7e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478897 Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: David Turner <digit@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641404} base/json/json_writer.cc | 5 ++ base/values.cc | 68 ++++++++++++++-------- base/values.h | 23 ++------ base/values_unittest.cc | 10 +++- .../ui/cocoa/applescript/apple_event_util.mm | 10 ++++ chromeos/network/onc/variable_expander.cc | 6 ++ .../core/browser/android/policy_converter.cc | 11 +++- .../core/common/policy_loader_win_unittest.cc | 8 ++- components/policy/core/common/policy_test_utils.cc | 5 ++ components/policy/core/common/registry_dict.cc | 4 ++ .../java/gin_java_script_to_java_types_coercion.cc | 8 ++- ipc/ipc_message_utils.cc | 11 +++- mojo/public/cpp/base/values_mojom_traits.h | 7 ++- .../private/ppb_x509_certificate_private_shared.cc | 2 + 14 files changed, 127 insertions(+), 51 deletions(-) commit f33d6950649b1062d0ac1739ff713948af8adb0e Author: David Benjamin <davidben@chromium.org> Date: Sat Mar 16 04:01:06 2019 +0000 Roll src/third_party/boringssl/src 3390fd88d..aadcce380 https://boringssl.googlesource.com/boringssl/+log/3390fd88d716ea599d659c2b72b9a6cd4bb36442..aadcce380fe9e5e17ff38f8471e956463fc4df21 The following commits have Chromium bugs associated: aadcce380 Implement sk_find manually. Bug: 941463 Change-Id: I1cde0f9631c186577e6b073ca7a0687d56006027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525003 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#641403} DEPS | 2 +- .../ios-aarch64/crypto/fipsmodule/vpaes-armv8.S | 54 +++++++++++++++------- .../linux-aarch64/crypto/fipsmodule/vpaes-armv8.S | 54 +++++++++++++++------- 3 files changed, 75 insertions(+), 35 deletions(-) commit dc12c3e904b755ce68f5048732a091fc946d0448 Author: Victor Fei <vicfei@microsoft.com> Date: Sat Mar 16 04:00:21 2019 +0000 Implemented ITextRangeProvider::CompareEndpoints Implemented CompareEndpoints of ITextRangeProvider with assoicated unittests. Bug: 928948 Change-Id: I184554c8493e131c05787ef262edf6d0298f9de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516879 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#641402} .../ax_platform_node_textrangeprovider_win.cc | 44 ++- .../ax_platform_node_textrangeprovider_win.h | 12 +- ...platform_node_textrangeprovider_win_unittest.cc | 330 ++++++++++++++++++++- 3 files changed, 366 insertions(+), 20 deletions(-) commit 5876e5c517d396bf1dfa9c7a5d2d056e55ec80e6 Author: Sergey Abbakumov <sabbakumov@yandex-team.ru> Date: Sat Mar 16 04:00:02 2019 +0000 Fix media::VideoFrame double deletion MaybePrepareAnotherOutput() takes unprepared_outputs_.front() reference to scoped_refptr<VideoFrame>. Then GpuMemoryBufferVideoFramePool::PoolImpl::CreateHardwareFrame() is called which calls frame_ready_cb (DecoderStream<StreamType>::OnPreparedOutputReady) in turn (after fix https://chromium-review.googlesource.com/c/chromium/src/+/1180543/6/media/video/gpu_memory_buffer_video_frame_pool.cc). DecoderStream<StreamType>::OnPreparedOutputReady does unprepared_outputs_.pop_front() and we have dangling reference to scoped_refptr<VideoFrame>. Then we use that reference and get double deletion of VideoFrame. Bug: 859477,939238 Change-Id: Iff99fdfe67cad77682629b72b187ac81b9bf4f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506750 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641401} media/filters/decoder_stream.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 34097108d4dbff9895ed9bed167050ea3ba30ec1 Author: rajendrant <rajendrant@chromium.org> Date: Sat Mar 16 03:57:51 2019 +0000 Handle longer blocks and bypasses in DRP Currently block=86400 is not handled, which could be sent when DRP proxy should be disabled for longer periods. Bug: 942693 Change-Id: I184750825d67d56d1ef13a5b415ba0007bbcd2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526429 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#641400} .../data_reduction_proxy_browsertest.cc | 24 ++++++++++++++++++++++ .../core/browser/data_reduction_proxy_io_data.cc | 9 ++++---- 2 files changed, 29 insertions(+), 4 deletions(-) commit 4a3a0dbd1480af83e9f996734ec7bd51e703ed6e Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Sat Mar 16 03:52:41 2019 +0000 Reland "OnionSoup: Move mojom files from public/platform/web to public/mojom folder" This is a reland of e656908dbda6ced2f4743a9b5c2ed926dc6b5b67 It updates deps from //content/public/android/BUILD.gn. Original change's description: > OnionSoup: Move mojom files from public/platform/web to public/mojom folder > > This CL moves window_features.mojom, commit_result.mojom, > devtools_frontend.mojom, selection_menu_behavior.mojom and > remote_objects.mojom from public/platform/web to public/mojom/ > to gather mojom files to mojom folder and updates paths for these > mojom files. > > Bug: 919393 > Change-Id: If6df031ed39d70e700986bd13a40d0598257e009 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514434 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#640633} Bug: 919393 Change-Id: I7c0cf251bb1fa336645a6f12d90cf42c3ee837fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523210 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#641399} chrome/browser/DEPS | 1 - chrome/browser/ui/blocked_content/blocked_window_params.h | 2 +- chrome/browser/ui/blocked_content/popup_blocker.h | 2 +- chrome/common/chrome_render_frame.mojom | 2 +- content/browser/DEPS | 2 -- content/browser/devtools/devtools_frontend_host_impl.h | 2 +- content/browser/frame_host/render_frame_host_impl.h | 2 +- content/common/frame.mojom | 4 ++-- content/common/input/input_handler.mojom | 2 +- content/common/navigation_client.mojom | 2 +- content/public/android/BUILD.gn | 6 +++--- content/public/browser/content_browser_client.h | 2 +- content/public/common/common_param_traits_macros.h | 2 +- content/public/renderer/window_features_converter.h | 2 +- content/renderer/navigation_state.cc | 2 +- content/renderer/render_frame_impl.h | 2 +- third_party/blink/public/BUILD.gn | 5 ----- third_party/blink/public/mojom/BUILD.gn | 11 +++++++++-- third_party/blink/public/mojom/commit_result/OWNERS | 2 ++ .../public/{web => mojom/commit_result}/commit_result.mojom | 0 .../public/{web => mojom/devtools}/devtools_frontend.mojom | 0 third_party/blink/public/mojom/remote_objects/OWNERS | 2 ++ .../public/{web => mojom/remote_objects}/remote_objects.mojom | 0 third_party/blink/public/mojom/selection_menu/OWNERS | 2 ++ .../selection_menu}/selection_menu_behavior.mojom | 0 third_party/blink/public/mojom/window_features/OWNERS | 2 ++ .../{web => mojom/window_features}/window_features.mojom | 0 third_party/blink/public/web/web_local_frame.h | 4 ++-- .../blink/renderer/controller/dev_tools_frontend_impl.h | 2 +- third_party/blink/renderer/core/loader/frame_loader.cc | 2 +- 30 files changed, 38 insertions(+), 31 deletions(-) commit 38d91556db2ee20b573e9133434042e3d3f41599 Author: Tommy Martino <tmartino@chromium.org> Date: Sat Mar 16 03:50:20 2019 +0000 Replace Autofill Substring Match switch with feature Bug: 77194 Change-Id: I72ee1acdf05f1beb9e2580cd4b16dadc18674155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525059 Commit-Queue: Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641398} chrome/browser/about_flags.cc | 3 +-- chrome/browser/chrome_content_browser_client.cc | 1 - .../core/browser/autofill_manager_unittest.cc | 30 +++++++++------------- .../browser/webdata/autofill_table_unittest.cc | 5 ++-- .../autofill/core/common/autofill_features.cc | 5 ++++ .../autofill/core/common/autofill_features.h | 1 + .../autofill/core/common/autofill_switches.cc | 4 --- .../autofill/core/common/autofill_switches.h | 1 - components/autofill/core/common/autofill_util.cc | 3 +-- .../autofill/core/common/autofill_util_unittest.cc | 24 ++++++++++------- .../browser/password_autofill_manager_unittest.cc | 27 +++++++++---------- tools/metrics/histograms/enums.xml | 2 ++ 12 files changed, 53 insertions(+), 53 deletions(-) commit fc9e445c7a43ef620177c8039711cd64fde82aee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 03:45:21 2019 +0000 Roll src/third_party/catapult 0a33de82760c..4e9bccd7a0cf (6 commits) https://chromium.googlesource.com/catapult.git/+log/0a33de82760c..4e9bccd7a0cf git log 0a33de82760c..4e9bccd7a0cf --date=short --no-merges --format='%ad %ae %s' 2019-03-16 kbr@chromium.org Add dont-require-rooted-device compatibility-mode to Telemetry. 2019-03-15 crouleau@chromium.org Make myself an OWNER of catapult. 2019-03-15 dberris@chromium.org Undo threadsafe:true for now 2019-03-15 benjhayden@chromium.org Store session state in URL in spa. 2019-03-15 dberris@chromium.org Store more objects in memcache 2019-03-15 dberris@chromium.org Use partial decompression in critical path Created with: gclient setdep -r src/third_party/catapult@4e9bccd7a0cf The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:826295,chromium:941267,chromium:941888,chromium:918193,chromium:941888,chromium:941888 TBR=sullivan@chromium.org Change-Id: Ib4e53c6c17dba6377d04a648e28885641bb5f3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526822 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641397} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9836fbdfa8be22b3f4f0a99b6cd145ba633ac33f Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 03:27:20 2019 +0000 Convert the AppbarAutohideEdges Callback and Related Code to use OnceClosure BUG=714018,940130 TBR=sky@chromium.org Change-Id: Iaa812e52c01a35c43717a9d6935a1c8c238d6e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526682 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641396} chrome/browser/ui/views/chrome_views_delegate.h | 4 ++-- .../browser/ui/views/chrome_views_delegate_win.cc | 23 +++++++++++----------- ui/views/views_delegate.cc | 2 +- ui/views/views_delegate.h | 2 +- ui/views/win/hwnd_message_handler.cc | 5 +++-- 5 files changed, 19 insertions(+), 17 deletions(-) commit d02b8d3c418f378b68fc783fd68d4b7801718917 Author: Liquan(Max) Gu <maxlg@chromium.org> Date: Sat Mar 16 03:24:41 2019 +0000 [FCP++] Text: test ancestry visible rect clipping This is to add a test about clipping of the ancestry visible rect. For example, we have the following snippet. The outer box has a limiting visible area, and within it is a text larger than the outer box. The visual size of the text will be subject to the outer rect's size. <style> #outer { overflow: hidden; height: 1px; width: 1px; } </style> <div id='outer'> <div id='inner'> ######################################### </div> </div> Bug: 940996 Change-Id: I659756b7092de9a4a578a77841c3bcf3af65006c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521586 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641395} .../core/paint/text_paint_timing_detector_test.cc | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) commit 0f52044146f44ec904e3069da1afa4dd0cd8cfa5 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Sat Mar 16 03:16:30 2019 +0000 Print Preview: Fix "More settings" show condition. Bug: 848942 Change-Id: I7ab947d2288488eceb951b95435b4eeb2f158903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525936 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#641394} chrome/browser/resources/print_preview/new/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8a56464a22f1b01ccc13b5994784b2a498ea338 Author: Adrienne Walker <enne@chromium.org> Date: Sat Mar 16 03:11:47 2019 +0000 gpu: Ping watchdog before slow oopr operations as well This matches the behavior in the RasterDecoder, and merges the shared code. Bug: 940390,705957 Change-Id: Iab75121c4c4693ed5f4ccf7eea5aab845dc6b2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526636 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641393} gpu/command_buffer/service/raster_decoder.cc | 19 ++----------------- ui/gl/init/create_gr_gl_interface.cc | 14 ++------------ ui/gl/progress_reporter.h | 16 ++++++++++++++++ 3 files changed, 20 insertions(+), 29 deletions(-) commit 3f100ad82c20d17896c4968130013ec3e7c280fc Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Sat Mar 16 03:11:20 2019 +0000 Updating trunk VERSION from 3735.0 to 3736.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: If197bb57771add072dfacd03095d3770c0d7ccf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526753 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641392} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a3cc40975cfe59e2adb1749b9fa0dcda02500c62 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Sat Mar 16 03:01:46 2019 +0000 CORB allowlist additions - 2019-03-15. Bug: 942102 Bug: 942232 Bug: 942498 Bug: 942527 Bug: 942384 Bug: 942592 Bug: 942575 Bug: 942475 Change-Id: I160efe9dbf0b5e12a16b2422f3ec07c23757da9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525200 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#641391} extensions/browser/url_loader_factory_manager.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 384a17351407b134a4235e2b548391d9c107ad38 Author: Kenneth Russell <kbr@chromium.org> Date: Sat Mar 16 02:36:02 2019 +0000 Use named stable versions of Windows and Linux graphics drivers. In order to effect seamless driver upgrades across the Swarming fleet, make the following configurations: Win10 Quadro P400 Linux Quadro P400 Win10 Intel HD 630 Linux Intel HD 630 refer to "stable" versions of their graphics drivers, defined in Swarming's bot_config.py. In this way, the definitions of these stable versions can be changed on the fly. Bug: 920665, 925587 Change-Id: I28f0393a5d11223be32ba25b93148667c117bc98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517105 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jamie Madill <jmadill@chromium.org> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641390} docs/gpu/gpu_testing_bot_details.md | 61 +- testing/buildbot/chromium.gpu.fyi.json | 908 ++++++++++----------- testing/buildbot/chromium.gpu.json | 208 ++--- testing/buildbot/client.v8.fyi.json | 100 +-- testing/buildbot/generate_buildbot_json.py | 8 +- .../buildbot/generate_buildbot_json_unittest.py | 168 ++++ testing/buildbot/mixins.pyl | 12 +- 7 files changed, 813 insertions(+), 652 deletions(-) commit 2a0d6643a62aeb55ce41793cf4c45104a0d59b29 Author: Payton Turnage <turnage@google.com> Date: Sat Mar 16 02:24:06 2019 +0000 [Fuchsia] Re-enable Video Decoder. Updates video decoder for Fuchsia codec API change. Change-Id: I642810b3f923fd24f8ecfc039388601261692036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497357 Commit-Queue: Payton Turnage <turnage@google.com> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641389} media/filters/BUILD.gn | 15 +++ media/filters/fuchsia/fuchsia_video_decoder.cc | 178 +++++++++++++++++-------- media/renderers/default_decoder_factory.cc | 8 ++ 3 files changed, 144 insertions(+), 57 deletions(-) commit 14d743dee36810efbc410d8daa2ade7e7761bcdb Author: Lucas Tenorio <ltenorio@chromium.org> Date: Sat Mar 16 02:11:22 2019 +0000 Add tests for the Kiosk Next Shell settings page. This change also addresses the missing comments from the previous review https://crrev.com/c/1471110. Bug: 922687 Change-Id: If54ce5c9d6d1705123386f64c588b3ad9b2a3ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517157 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641388} .../settings/kiosk_next_shell_page/BUILD.gn | 4 +- .../kiosk_next_shell_confirmation_dialog.html | 9 +-- .../kiosk_next_shell_confirmation_dialog.js | 35 +++++---- .../kiosk_next_shell_page.html | 6 +- .../kiosk_next_shell_page/kiosk_next_shell_page.js | 17 +++-- .../data/webui/settings/cr_settings_browsertest.js | 38 ++++++++++ .../webui/settings/kiosk_next_shell_page_tests.js | 86 ++++++++++++++++++++++ 7 files changed, 162 insertions(+), 33 deletions(-) commit 24c707bff5da3c503608d298de461184d403df8a Author: Paul Irish <paulirish@chromium.org> Date: Sat Mar 16 01:37:07 2019 +0000 DevTools: Correct ServiceDispatcher's error reporting Change-Id: Ifd79d5b1889cbb657995efe4081ee8373664fcb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1119115 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641387} .../renderer/devtools/front_end/worker_service/ServiceDispatcher.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 6a4a833bc00340e9d4084e7ca945131a1e380e37 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 01:28:15 2019 +0000 Roll src/third_party/webrtc 35816cc9a150..69008a871859 (1 commits) https://webrtc.googlesource.com/src.git/+log/35816cc9a150..69008a871859 git log 35816cc9a150..69008a871859 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 brandtr@webrtc.org Avoid div-by-zero in VideoCodecTest stats calculation. Created with: gclient setdep -r src/third_party/webrtc@69008a871859 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic3af6d27e8e16a9e6faba0a03d7ae61b547244fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525678 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641386} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 627048cbd85ae5c0dc173397f528da13f30a9cb0 Author: Kelvin Jiang <kelvinjiang@chromium.org> Date: Sat Mar 16 01:17:34 2019 +0000 [Extensions] Move expanded property from stream item to its parent This CL moves the |isExpanded| property from activity_log_stream_item to |StreamItem.expanded| in activity_log_stream and is a precursor CL for iron-list. Moving the property from an iron-list's item to its parent (the element with iron-list) solves the problem where iron-list wrongly recycles property values defined on its items when it recycles DOM nodes that are Polymer components. Bug: 932768 Change-Id: Ia8356bb56ccc6011121e830b6487615a63a23975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525485 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641385} .../md_extensions/activity_log/activity_log_stream.js | 1 + .../md_extensions/activity_log/activity_log_stream_item.html | 4 ++-- .../md_extensions/activity_log/activity_log_stream_item.js | 11 +++-------- .../data/webui/extensions/activity_log_stream_item_test.js | 5 ++++- 4 files changed, 10 insertions(+), 11 deletions(-) commit 8fea969dad20282c9aa04484fa882a3a5ed7e1c9 Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Sat Mar 16 01:16:44 2019 +0000 ozone/wayland: Fix Drag&Drop crash when dragging within chromium With dcheck enabled, dragging any data between chromium windows (e.g: drag a page link into omnibar) makes it to crash just after drop. This CL fixes it. That happens because when the drag session starts from a chromium window, the (singleton) WaylandDataDevice's source_data_ already holds the OSExchangeData instance (which contains the data to be transferred), so in this case an optimization was partially implemented to avoid sending data through wayland pipe in this special case. So, to fix the crash this change add the missing bits to this alternative code path, so that the respective dcheck does not fails anymore at aura level. Additionally, this CL does some readability improvements and cleanups in the DataDevice class implementation and interface. Bug: 875164 Change-Id: I34f53bdf5415997b15f27ba874da9968efba1e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524884 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#641384} ui/ozone/platform/wayland/wayland_data_device.cc | 114 +++++++++++------------ ui/ozone/platform/wayland/wayland_data_device.h | 15 ++- 2 files changed, 67 insertions(+), 62 deletions(-) commit aefb25cb0d5bb634efda75e248203fce8ac59c29 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 01:15:01 2019 +0000 Roll Fuchsia SDK from 4a56f4ef93ff to 3fd87c335a94 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5fe28817c8c5bb5d32deee9a2f7c0cc816d769dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526554 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641383} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 70a9af06f674b342e6e92f0c180cba8660ff51b1 Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 01:07:50 2019 +0000 Convert drag_interactive_uitest.cc to Use OnceClosure/RepeatingClosure BUG=714018,940130 TBR=sky@chromium.org Change-Id: I93041fc5b0728dcc804471221436e5a1beeb27ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526751 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641382} ui/views/mus/drag_interactive_uitest.cc | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) commit 54c6297ba875ec8e6f83b151b50dbe7b69d67411 Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 01:07:07 2019 +0000 Convert DragDropClientMac::quit_closure_ to OnceClosure BUG=714018,940130 TBR=ellyjones@chromium.org Change-Id: I584e597bad4f43fcfe521418400dfe301d58746c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526689 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641381} ui/views/cocoa/drag_drop_client_mac.h | 2 +- ui/views/cocoa/drag_drop_client_mac.mm | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) commit 9bdf6cdfcce250bfe450be522083c36269c0df29 Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 01:06:15 2019 +0000 Convert DesktopAuraTestValidPaintWidget::quit_closure_ to OnceClosure BUG=714018,940130 TBR=sky@chromium.org Change-Id: I953a07191b1fbc85f7285d78fd3001de83451b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526793 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641380} ui/views/widget/widget_unittest.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 806295775a64da39b557a18ab5a85807bcfb2691 Author: Theresa <twellington@chromium.org> Date: Sat Mar 16 01:05:47 2019 +0000 [Dark] Prevent navigation bar color updates in dark mode When in dark mode, the navigation bar is always black so there's no need to update. BUG=942712 Change-Id: I45d558592273ad1dddf289930e730adec9792eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526604 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641379} .../browser/NavigationBarColorController.java | 28 +++++++++++++++++----- 1 file changed, 22 insertions(+), 6 deletions(-) commit 9a17e910d322062d1ceab01476e55e4cd1f79aec Author: Andres Calderon Jaramillo <andrescj@chromium.org> Date: Sat Mar 16 01:04:26 2019 +0000 media: Validate min/max surface size in IsVaapiSupportedJpeg(). This CL makes IsVaapiSupportedJpeg() detect the min and max supported surface size for JPEG decoding instead of using hard-coded values. Tests are added to validate this new behavior. Test: jpeg_decode_accelerator_unittest passes on grunt and samus. Bug: 934560 Change-Id: I3677584c90e9402c660790311c7e4b239d4a13a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1482137 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#641378} media/gpu/vaapi/BUILD.gn | 2 + media/gpu/vaapi/vaapi_jpeg_decoder.cc | 45 ++-- media/gpu/vaapi/vaapi_jpeg_decoder_unittest.cc | 279 ++++++++++++++++++++++++- media/gpu/vaapi/vaapi_wrapper.cc | 102 ++++++--- media/gpu/vaapi/vaapi_wrapper.h | 11 + 5 files changed, 388 insertions(+), 51 deletions(-) commit 7dcd27fa2f73783682210bf4b1dd16e8f73b818e Author: Mike Wittman <wittman@chromium.org> Date: Sat Mar 16 01:03:27 2019 +0000 [Sampling profiler] Encapsulate Mac stack walking 4/4: unw_init_local workaround The platform-native stack walking needs to be encapsulated into a function that can be invoked in an alternating fashion with V8 unwinding, once supported. This change inlines the workaround for avoiding a crash in unw_init_local into the core stack walking function. The encapsulation requires inlining otherwise-sensible abstractions to enable creation of future abstractions that can be used across platforms. No functional change is intended. Bug: 931418 Change-Id: I89065f8afa2e88f6a263880e0f7bb8ed1c5a6c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513210 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641377} base/profiler/native_stack_sampler_mac.cc | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) commit 36f5a0a5b0fe280a9a8910b7db4a23f2a5341601 Author: sczs <sczs@chromium.org> Date: Sat Mar 16 01:00:52 2019 +0000 [ios] Populates InfobarPasswordBanner/Modal data - Adds GetUserNameText() and GetURLHostText() to the PasswordManagerInfobarDelegate. This is used to populate the Infobar Banner/Modal with the username and URL host. - Uses String IDs for most of the PasswordsInfobarModal strings. Screenshots: https://drive.google.com/open?id=1dRsunqItRD-lkuxeGCwK7yh8xT7QuahE https://drive.google.com/open?id=1AUgq8jwZf4uH1z7cBzriWztO99Z2ju0V Bug: 911864 Change-Id: If45a13b854e9b1558fdf18df16c79c52f36b4111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525265 Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641376} .../ios_chrome_password_manager_infobar_delegate.h | 6 ++++++ .../ios_chrome_password_manager_infobar_delegate.mm | 11 +++++++++++ .../coordinators/infobar_password_coordinator.mm | 6 ++++++ ios/chrome/browser/ui/infobars/modals/BUILD.gn | 2 ++ .../modals/infobar_password_table_view_controller.h | 6 +++++- .../modals/infobar_password_table_view_controller.mm | 20 ++++++++++++++------ 6 files changed, 44 insertions(+), 7 deletions(-) commit 9f8f421e6904edf6880b46418f3a49f34f8e4746 Author: Amit Hilbuch <amithi@chromium.org> Date: Sat Mar 16 00:53:13 2019 +0000 Fixing references to CopyOnWriteBuffer which might copy data. CopyOnWriteBuffer has two versions of data(). One is const the other is not. The const version returns the data as read-only. The non-const version returns the data as writable and could potentially make a copy of the data before returning it (hence, copy-on-write buffer). This code wants a const pointer to the data, but is using a non-const buffer, so the non-const method is actually called. The change is to use the cdata() method which is the same as the data() const method. Bug: None Change-Id: Ie8c25a53d4a9691853cb31752a79059249067e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525163 Reviewed-by: Steve Anton <steveanton@chromium.org> Commit-Queue: Amit Hilbuch <amithi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641375} third_party/blink/renderer/modules/peerconnection/rtc_data_channel.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 78fb7e60d9d8170c1272cfe6cd732f469217b495 Author: Becky Zhou <huayinz@chromium.org> Date: Sat Mar 16 00:52:24 2019 +0000 Fix tab switcher title color on dark mode Bug: 934563 Change-Id: Id6d6006bbe3f70148e069227edaafaf3fa08d7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526744 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641374} chrome/android/java/res/values/colors.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 129f7c2471b8e2fb4c0b6f2e9ce6d1ed8152c976 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Sat Mar 16 00:49:40 2019 +0000 [BidiCaretAffinity] Implement visual caret movement to previous/next block This patch implements left/right visual caret movement that moves from the beginning/end of a block into the previous/next block: 1. SelectionModifierCharacter adds handling of Before/AfterContext result types of NGCaretNavigator: - For BeforeContext, traverse to the last line of the previous block; Otherwise, traverse the the first line of the next block - Whether we choose the left or right boundary of the target line depends on the direction of the visual movement 2. Post order traversal functions are added to LayoutObject to support traversing into the previous block Note: This patch only implements the basics of cross-block movement. It doesn't support the case when we move out from an inline block and enter the interior of the parent block. Bug: 894651 Change-Id: I090fab332365693d136b8932afe0c6f468ab9830 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516919 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641373} .../core/editing/selection_modifier_character.cc | 151 +++++++++++++++++++-- .../blink/renderer/core/layout/layout_object.cc | 23 ++++ .../blink/renderer/core/layout/layout_object.h | 9 ++ third_party/blink/web_tests/TestExpectations | 8 -- .../modify_move/move_left_character_23_rtl.html | 105 ++++++++++---- .../modify_move/move_left_character_24_ltr.html | 104 ++++++++++---- .../modify_move/move_right_character_23_rtl.html | 104 ++++++++++---- .../modify_move/move_right_character_24_ltr.html | 104 ++++++++++---- 8 files changed, 492 insertions(+), 116 deletions(-) commit 55ba9443ffec5a2201e291e277076df132d75d69 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 00:48:01 2019 +0000 Roll src/third_party/chromite c59012f09dd0..9d6e19d6ef05 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c59012f09dd0..9d6e19d6ef05 git log c59012f09dd0..9d6e19d6ef05 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dgarrett@google.com chromeos_config: Create master branch factorybranch targets. Created with: gclient setdep -r src/third_party/chromite@9d6e19d6ef05 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I1730af0ff12724c325f9cc39095533697286d77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526387 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641372} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 99668392ca4e7e6b597aa15403b1e3c4724f645d Author: Yue Li <updowndota@chromium.org> Date: Sat Mar 16 00:47:57 2019 +0000 Enable open app feature flag Bug: b/117793081 Test: Manual Test Change-Id: I014f1ca138af203d6af8a9e548f2cd28010bfc8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521799 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#641371} chromeos/services/assistant/public/features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 822d38eacde7849678cc7cca74b75d0c5f4ed773 Author: Ahmed Fakhry <afakhry@google.com> Date: Sat Mar 16 00:45:17 2019 +0000 Remove unnecessary looping over all root windows We don't need to check magnitism between windows on different roots/displays. We should just use the same root of the window being dragged. BUG=942728 Change-Id: Iffbdcc9fef29c84fe090a8c50dde88e4a387dc2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526632 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#641370} ash/wm/workspace/workspace_window_resizer.cc | 36 ++++++++++++++-------------- 1 file changed, 18 insertions(+), 18 deletions(-) commit 0814830e05ce942111d30e2f8f3fc82ecad19a9c Author: Mitsuru Oshima <oshima@chromium.org> Date: Sat Mar 16 00:42:54 2019 +0000 Fix crash when entering overview from home launcher. The overview's shield widget can be created async, thus it can be null. Bug: 942622 Test: manual Change-Id: Ib39ccd4dff02b67ad08bb280e8a3dd803a478673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525166 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#641369} ash/wm/overview/overview_grid.cc | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) commit a48ce82ffac7e575d3fb22a17aa5a3c14ba292de Author: Varun Khaneja <vakh@chromium.org> Date: Sat Mar 16 00:41:34 2019 +0000 #crashfix: Check CheckApiIsSupported() before de-ref-ing j_api_handler_ Also required dropping const from GetSafetyNetId() R=drubery Bug: 940345,907280 Change-Id: I8718b07e35d8e90f76053d493459a62b6e90d00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526633 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by: Daniel Rubery <drubery@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641368} .../safe_browsing/android/remote_database_manager_unittest.cc | 2 +- components/safe_browsing/android/safe_browsing_api_handler.h | 2 +- .../safe_browsing/android/safe_browsing_api_handler_bridge.cc | 7 ++----- .../safe_browsing/android/safe_browsing_api_handler_bridge.h | 2 +- 4 files changed, 5 insertions(+), 8 deletions(-) commit ffe96ee76d86ce6577672237656a2bd9f6578dae Author: Kenneth Russell <kbr@chromium.org> Date: Sat Mar 16 00:37:29 2019 +0000 Update Chrome GPU fleet status links. Bug: 941679 Tbr: ddoman@google.com Change-Id: I29d51a93bf21a90b5835b8b2b525e6295b81280c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526791 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641367} docs/gpu/pixel_wrangling.md | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) commit 4f1b4355a3c0769101858302fc4258a2d5c99105 Author: Mei Liang <meiliang@chromium.org> Date: Sat Mar 16 00:33:05 2019 +0000 [TabGroupModelFilter] Fix bug in indexOf This CL fixes a bug in the indexOf method. The rootId should be used instead of tab id. In addition, this CL makes sure that the given tab is in the same TabModel. Change-Id: Ib8e75f4ae9fc2dac32fc71643c6e8978cb82da57 Bug: 942739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526639 Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641366} .../chromium/chrome/browser/tasks/tabgroup/TabGroupModelFilter.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 8c7cea52fa9ca38a2048403bac7b25101eeb4244 Author: Nasko Oskov <nasko@chromium.org> Date: Sat Mar 16 00:31:45 2019 +0000 Revert "Refactor NavigationRequest selection in RenderFrameHost" This reverts commit 2838e2936b918ed99fab4406f0dd713362251324. Reason for revert: Cause of https://crbug.com/942515 which results in a renderer process termination for the DevTools process once a DevTools extension is installed. Original change's description: > Refactor NavigationRequest selection in RenderFrameHost > > This is a preparatory CL for enforcing having a valid NavigationRequest at > commit time. It makes clearer when NavigationRequests are deemed non-valid, and > when a new NavigationRequest must be created at commit time. > > Change-Id: I02bcc43fb46378d4507ba90beaf0b007b909b048 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493693 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Commit-Queue: Camille Lamy <clamy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639912} TBR=nasko@chromium.org,clamy@chromium.org,ahemery@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic9df88267bf27e894abbd7d5a808243d2e87e3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526209 Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641365} .../navigation_controller_impl_unittest.cc | 41 +-- .../browser/frame_host/render_frame_host_impl.cc | 277 +++++++++++---------- .../browser/frame_host/render_frame_host_impl.h | 34 +-- content/browser/navigation_browsertest.cc | 91 +++++++ content/test/navigation_simulator_impl.cc | 4 +- content/test/navigation_simulator_impl.h | 1 - 6 files changed, 279 insertions(+), 169 deletions(-) commit 9c361fa956c2e0e47414fe42fe9fd357ab6490c4 Author: dpapad <dpapad@chromium.org> Date: Sat Mar 16 00:25:47 2019 +0000 WebUI: Remove usage of webui::AppendI18nTemplateSourceHtml. This method should no longer be needed, because all clients have been migrated to use the $i18n{} C++ mechanism, instead of i18n-values and i18n-content. Bug: 677338 Change-Id: Ib0aeb7ef9d762876aaeb360118ca0551a39b8767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518501 Reviewed-by: Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641364} ui/base/webui/jstemplate_builder.cc | 26 -------------------------- 1 file changed, 26 deletions(-) commit 9ad67ac7d97f5d65c59587ff6643a7bc8bd38e51 Author: Alex Leung <alexleung@google.com> Date: Sat Mar 16 00:10:16 2019 +0000 Refactor cast_mojo gn args so that the cast renderer can be enabled with ENABLE_CAST_RENDERER Bug: b/126906251 Test: Verified that mojo_media args did not change. Change-Id: I167fde3c1cea718c87d03d3dc2c3b61964e77988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512677 Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#641363} build/config/chromecast_build.gni | 34 +++++++++++++++++++++++ chromecast/browser/BUILD.gn | 5 +++- chromecast/browser/cast_content_browser_client.cc | 13 +++++---- media/media_options.gni | 30 +++++--------------- 4 files changed, 52 insertions(+), 30 deletions(-) commit 9d8348e56ff2d88165322b91add1b93020d6174d Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Sat Mar 16 00:01:12 2019 +0000 sensors: Clean up sequence, task and thread handling in the Linux implementation Bug 941559 refers to a DCHECK hit in device::PlatformSensorProviderLinux::StopPollingThread() caused by the fact that polling thread we create was being stopped in a task that shouldn't block. Use this as an excuse to do some long-needed cleanup in the Linux code by making it follow a more recommended style when interacting with the task scheduler API. The essence of the change is that we do not need a polling thread (which is a bare base::Thread) in the first place. Not only that, but we do not need to create it in PlatformSensorProviderLinux and pass it around to PlatformSensorLinux (which then used this thread's task runner to call specific parts of SensorReader). Instead, we move the responsibility of setting up the infrastructure to do blocking I/O to the place that actually needs it: PollingSensorReader. This way, we can just create a blocking SequencedTaskRunner there and use it to drive a newly-created BlockingTaskHelper class that performs the base::ReadFile calls while PollingSensorReaderLinux acts as a wrapper around it running in a regular sequence. This change is inspired by //device/usb's UsbServiceLinux which does something similar. While here, use a SequenceChecker rather than a ThreadChecker for PollingSensorReader, as we do not need thread-affinity here to begin with. TEST=service_unittests --gtest_filter=PlatformSensorAndProviderLinuxTest.\*, visiting multiple pages that create sensors with Chrome and then closing it, both in debug mode Bug: 941559 Change-Id: Ia93a166476383e0f559c693f1c70434b77a8f504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526047 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#641362} .../device/generic_sensor/platform_sensor_linux.cc | 15 +- .../device/generic_sensor/platform_sensor_linux.h | 16 +- .../platform_sensor_provider_linux.cc | 40 +---- .../platform_sensor_provider_linux.h | 15 +- .../generic_sensor/platform_sensor_reader_linux.cc | 193 +++++++++++++++------ 5 files changed, 155 insertions(+), 124 deletions(-) commit 8c66199b51cc1f2c52f1b206823bc9054d6fa1bb Author: Lily Chen <chlily@chromium.org> Date: Sat Mar 16 00:00:35 2019 +0000 NEL: Add SQLitePersistentReportingAndNELStore This CL adds SQLitePersistentReportingAndNELStore which persists NEL policies to disk in a SQLite database. It will eventually also store Reporting clients and reports. The code is based on that of the SQLitePersistentCookieStore. It is not hooked up to anything yet (just unittests). Bug: 895821 Change-Id: I99ea14ace6f9b7fecd6075b1be98647db80d2bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504493 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641361} net/BUILD.gn | 13 + .../sqlite_persistent_reporting_and_nel_store.cc | 567 +++++++++++++++++++++ .../sqlite_persistent_reporting_and_nel_store.h | 62 +++ ..._persistent_reporting_and_nel_store_unittest.cc | 339 ++++++++++++ .../network_error_logging_service.cc | 55 +- .../network_error_logging_service.h | 54 ++ 6 files changed, 1056 insertions(+), 34 deletions(-) commit d95d47bf8275b4caaf3bc8ee875c370bc8af6f06 Author: Mehran Mahmoudi <mahmoudi@chromium.org> Date: Fri Mar 15 23:58:49 2019 +0000 Add key functions IPH tooltip for NoTouchActivity This will show an In-Product Help tooltip for key functions on the first successful page load of a session, as well as when the user switches from spatial navigation mode to fallback cursor mode. Screenshots are included in the bug. Design deck: https://docs.google.com/presentation/d/1c-aVSZ_zsBuzCwQ4CrBJppmRQjiupa6PXmlC2OS-F-Q/edit#slide=id.g4e304ebd4c_0_18 Bug: 924748 Change-Id: I0e4b556bd0c364a444bf1e491317648d4704246f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1471242 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#641360} chrome/android/java_sources.gni | 6 ++ .../java/res/drawable/ic_cursor_navigation.xml | 12 +++ .../java/res/drawable/ic_spatial_navigation.xml | 12 +++ .../touchless/java/res/drawable/ic_zoom_in.xml | 12 +++ .../touchless/java/res/drawable/ic_zoom_out.xml | 12 +++ .../drawable/notouch_key_functions_iph_item_bg.xml | 13 +++ .../java/res/drawable/notouch_tooltip_bg.xml | 12 +++ .../java/res/layout/notouch_key_functions_view.xml | 98 ++++++++++++++++++++++ .../java/res/layout/notouch_tooltip_view.xml | 9 ++ .../touchless/java/res/values-v17/colors.xml | 2 + .../touchless/java/res/values-v17/dimens.xml | 14 ++++ .../touchless/java/res/values-v17/styles.xml | 7 +- .../android/touchless/java/res/values/dimens.xml | 7 -- .../chrome/browser/touchless/NoTouchActivity.java | 21 +++-- .../ui/iph/KeyFunctionsIPHCoordinator.java | 36 ++++++++ .../touchless/ui/iph/KeyFunctionsIPHMediator.java | 83 ++++++++++++++++++ .../ui/iph/KeyFunctionsIPHProperties.java | 25 ++++++ .../touchless/ui/iph/KeyFunctionsIPHView.java | 52 ++++++++++++ .../ui/iph/KeyFunctionsIPHViewBinder.java | 25 ++++++ .../ui/progressbar/ProgressBarCoordinator.java | 2 +- .../browser/touchless/ui/tooltip/TooltipView.java | 60 +++++++++++++ 21 files changed, 503 insertions(+), 17 deletions(-) commit e6710e059cd251f178c384b3c0742f9af9c53591 Author: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Date: Fri Mar 15 23:57:29 2019 +0000 sensors: Store a SensorInfoLinux copy in PollingSensorReader Add a copy constructor to SensorInfoLinux so that we can keep our own copy in PollingSensorReader rather than awkwardly copying half of SensorInfoLinux's members to it. Bug: 941559 Change-Id: I27819f8b2042557350a06d2d7de8e2fbc791a61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526185 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by: Reilly Grant <reillyg@chromium.org> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#641359} .../generic_sensor/linux/sensor_data_linux.cc | 2 ++ .../generic_sensor/linux/sensor_data_linux.h | 2 ++ .../device/generic_sensor/platform_sensor_linux.cc | 2 +- .../generic_sensor/platform_sensor_reader_linux.cc | 41 +++++++++------------- .../generic_sensor/platform_sensor_reader_linux.h | 2 +- 5 files changed, 23 insertions(+), 26 deletions(-) commit efad090bb9b9a7e115c9075e2118e4979b0a6ad3 Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Mar 15 23:54:39 2019 +0000 Various refactoring in TabStripModel tests. This patch refactors tab_strip_model_unittest.cc and some associated files in several ways: * Removes ChromeRenderViewHostTestHarness as a superclass of TabStripModelTest. Only one test was relying on anything other than TestingProfile; those dependencies are all made explicit. This speeds up the suite by about 30% (~5000 ms runtime vs. ~7000ms before this patch). * Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to return false, and deletes subclasses that exist solely to override that method (all of them, except TabStripDummyDelegate, which is renamed to UnloadListenerTabStripModelDelegate). * Moved several helper classes to be defined immediately before the test that uses them. * Deletes member variables from MockTabStripModelObserver, which are unused. * Fixes lint errors and cleans up unused includes. Change-Id: I3d70fd3c6013ea06b17146f8f551bb12510fadf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515904 Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#641358} .../tab_lifecycle_unit_source_unittest.cc | 18 +- .../resource_coordinator/tab_manager_unittest.cc | 9 +- .../tab_strip_model_stats_recorder_unittest.cc | 24 +- chrome/browser/ui/tabs/tab_strip_model_unittest.cc | 400 +++++++++++---------- .../ui/tabs/test_tab_strip_model_delegate.cc | 4 +- 5 files changed, 228 insertions(+), 227 deletions(-) commit 0acdcbb8df1a5202af4a95b4bc21b2bd8d4bb00e Author: Joey Arhar <jarhar@chromium.org> Date: Fri Mar 15 23:49:59 2019 +0000 [DevTools] Add violation console counter for spotlight Bug: 934031 Change-Id: I6e9a00ea25a2a1d87b7684f12302d4aed98c3c6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524880 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#641357} .../console_counters/WarningErrorCounter.js | 53 ++++++++++++++++++---- .../front_end/console_counters/module.json | 2 +- .../blink/renderer/devtools/front_end/main/Main.js | 1 + .../devtools/front_end/sdk/ConsoleModel.js | 13 +++++- 4 files changed, 57 insertions(+), 12 deletions(-) commit c7012d771ed373968b6d44febeb38a596d858b6c Author: Tina Wang <tinazwang@chromium.org> Date: Fri Mar 15 23:49:02 2019 +0000 [Self Share] Improves the translation for the receiving notification on desktop Responding to additional comments on CL: https://chromium-review.googlesource.com/c/chromium/src/+/1476103 - Add a placeholder to IDS_MESSAGE_NOTIFICATION_SEND_TAB_TO_SELF_DEVICE_INFO in source file to improve the translation. - nit: delete unnecessary inclusions and declarations. - nit: format the usage of variables. Bug: 937693 Change-Id: If1972a1623d88aeafbc10ea5e59eca3c23297efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524330 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641356} .../notifications/notification_display_service_impl.cc | 2 +- .../send_tab_to_self/desktop_notification_handler.cc | 13 ++++--------- .../browser/send_tab_to_self/desktop_notification_handler.h | 3 +-- ui/strings/ui_strings.grd | 4 ++-- ...SSAGE_NOTIFICATION_SEND_TAB_TO_SELF_DEVICE_INFO.png.sha1 | 1 + 5 files changed, 9 insertions(+), 14 deletions(-) commit fdf6331fb04b1bdbed52758c8008babbefcbaabb Author: Tom Anderson <thomasanderson@chromium.org> Date: Fri Mar 15 23:48:31 2019 +0000 Set WINVER to WIN7 for libc++ This is needed to prevent libc++ from adding a dependency on GetSystemTimePreciseAsFileTime, which was introduced in Windows 8. See the thread with subject "should _WIN32_WINNT be set to _WIN32_WINNT_WIN10 or _WIN32_WINNT_WIN7" [1] on chromium-dev for more information. [1] https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/QP4cZtF7B0E BUG=801780 R=thakis Change-Id: Idd10dc296d383cbb0fb25d2e95d6b4c2f08ac0c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524992 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641355} buildtools/third_party/libc++/BUILD.gn | 13 +++++++++++++ 1 file changed, 13 insertions(+) commit 335241a86c87b3add8797d2c55b2c3c1f7ccfa73 Author: Pavel Feldman <pfeldman@chromium.org> Date: Fri Mar 15 23:45:31 2019 +0000 DevTools: convert all the overlay highlighters into the tools. This change: - introduces QuadHighlightTool, NodeHighlightTool, ShowViewSizeTool - updates the SearchingForNodeTool to manage its own highlights - removes the old InnerHideHighlight / IsEmpty management Change-Id: Ic6c8d136b3136debe441ff355cff10dc4bd38361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525820 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641354} .../blink/renderer/core/inspector/inspect_tools.cc | 180 ++++++++++++++++++--- .../blink/renderer/core/inspector/inspect_tools.h | 68 +++++++- .../core/inspector/inspector_overlay_agent.cc | 170 ++++--------------- .../core/inspector/inspector_overlay_agent.h | 29 +--- 4 files changed, 254 insertions(+), 193 deletions(-) commit 6d095b42d3bd8a430cfbaf856212e7e3dcef8281 Author: Dirk Pranke <dpranke@chromium.org> Date: Fri Mar 15 23:44:01 2019 +0000 Use CIPD packages for GN instead of GCS. This CL switches things so that instead of fetching GN binaries from a Google Cloud Storage bucket, we just fetch them directly from CIPD, which is generally faster and a bit safer. This CL does *not* change the current version of GN we're using; it still pulls r1496 (0790d304). "Rolling" GN in the future will simply involve updating the revisions in //DEPS and //buildtools/DEPS. Bug: 855791 Change-Id: Id005250f680618206cbecaba4080933c40b23833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519726 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641353} DEPS | 76 +++++++++++++++++++++------------------------- PRESUBMIT.py | 2 +- buildtools/DEPS | 35 ++++++++++++++++++++- buildtools/linux64/gn.sha1 | 1 - buildtools/mac/gn.sha1 | 1 - buildtools/win/gn.exe.sha1 | 1 - 6 files changed, 70 insertions(+), 46 deletions(-) commit 88c77a70d3c83ba420bb113a25560df97b5c9057 Author: Adam Langley <agl@chromium.org> Date: Fri Mar 15 23:43:51 2019 +0000 device/fido: return a vector of assertion results. In preparation for resident-key support, return a vector of results when getting an assertion: there may be multiple resident keys and CTAP2 returns all the signatures for account selection. Bug: 941120 Change-Id: I06e9ee2c5b3cd81632ddecaaff16da380be87edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518468 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#641352} content/browser/webauth/authenticator_impl.cc | 24 +++++++++++++++--------- content/browser/webauth/authenticator_impl.h | 4 +++- device/fido/get_assertion_handler_unittest.cc | 7 ++++--- device/fido/get_assertion_request_handler.cc | 5 ++++- device/fido/get_assertion_request_handler.h | 4 +++- 5 files changed, 29 insertions(+), 15 deletions(-) commit 320912dedbb2ac1ebf16e1e19d4b789bc80722f0 Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 23:42:21 2019 +0000 Convert WidgetTestInteractive.DisableCaptureWidgetFromMousePress To Use RunLoop::QuitClosure BUG=940130 Change-Id: I81325f531f495766e2af6e16444ef5cf678a54e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524627 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#641351} ui/views/widget/widget_interactive_uitest.cc | 27 ++++++++++++++++++++------- 1 file changed, 20 insertions(+), 7 deletions(-) commit 5b0e0ae453b4cd2c402c79ebe60dd19f2b5d19bf Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Fri Mar 15 23:42:03 2019 +0000 ozone/wayland: Clean up data device related code This CL cleans up, improve readability and fixes some styling/convention inconsistencies in wayland data device related code in ozone/wayland, such as: - Use more meaningful names for DataDevice's sync callback and related variables, in this case used to defer data reading from data device's pipe file descriptor. Also, use local variables to store wayland callback structs, making it more consistent with other ozone wayland classes; - Move data source factory method into data device manager, which is its actual factory in wayland API/protocol; - Improve and expand WaylandDataSource class variable names making it easier to distinguish between clipboard and drag&drop instances; - Fix lint errors in files touched by this change; Bug: 875164 Change-Id: I9af0e09908d94ada285f60592bba70ff0cc3904f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521887 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#641350} ui/ozone/platform/wayland/wayland_connection.cc | 40 +++++++---------- ui/ozone/platform/wayland/wayland_connection.h | 11 +++-- ui/ozone/platform/wayland/wayland_data_device.cc | 52 +++++++++++----------- ui/ozone/platform/wayland/wayland_data_device.h | 20 ++++++--- .../wayland/wayland_data_device_manager.cc | 7 ++- .../platform/wayland/wayland_data_device_manager.h | 5 ++- 6 files changed, 73 insertions(+), 62 deletions(-) commit bbaa1bb799b0b0af5b571b4a3f1c41564cb47eb2 Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 23:37:44 2019 +0000 Convert CancelableCallback and Related Code to CancelableOnceCallback BUG=714018,940130 TBR=thomasanderson@chromium.org Change-Id: I98c015e854c7eaebc0b664eeb1c0e08507aeabf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526622 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641349} ui/views/widget/desktop_aura/desktop_screen_x11.cc | 2 +- ui/views/widget/desktop_aura/desktop_screen_x11.h | 2 +- ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc | 6 +++--- ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) commit fcf7ef633ca2cb8bb946c03c26b0974efb7c1a1f Author: Fabio Tirelo <ftirelo@chromium.org> Date: Fri Mar 15 23:35:48 2019 +0000 Add tmartino@ as owner of two autofill flags Change-Id: Ibf25f840e24c1602f209914e3c9c4b65bc66f582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526605 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641348} chrome/browser/flag-metadata.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit d4c629248014cb1b05e49be962a8ce8c9742802f Author: Collin Baker <collinbaker@chromium.org> Date: Fri Mar 15 23:34:47 2019 +0000 Update ReopenTabPromoController::is_showing_ in PromoEnded() This ensures that if OnTabReopened(IDC_RESTORE_TAB) is called after the promo has finished, promo_bubble_ (which is null) won't be accessed and PromoEnded() won't be called. This also adds a sanity check for promo_bubble_ being non-null even if is_showing_ is true. Bug: 942338 Change-Id: I68ae5fb66b2317552d4e94319dcff163b73fb664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525489 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#641347} .../ui/views/feature_promos/reopen_tab_promo_controller.cc | 8 +++++++- .../browser/ui/views/feature_promos/reopen_tab_promo_controller.h | 4 ++++ 2 files changed, 11 insertions(+), 1 deletion(-) commit 59cca1357b50c663db2e34c88370e5f96b6c08dc Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Fri Mar 15 23:31:24 2019 +0000 Reland "Add tests that lookalike interstitial decisions are shared with incognito." This is a reland of 281e80c30694a97f69f9c4b5f627483376972199 Original change's description: > Add tests that lookalike interstitial decisions are shared with incognito. > > This CL adds tests to verify that a decision to bypass the lookalike > interstitial made in the main profile does not affect incognito and vice > versa. > > Bug: 927924 > Change-Id: I238e2e263db42c1434b9190de007aa775129417e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506458 > Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638329} Bug: 927924 Change-Id: I4d24590ef79ae29d1ff0dcdc0176006028a14b3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526445 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#641346} ...ookalike_url_navigation_throttle_browsertest.cc | 58 ++++++++++++++++++---- 1 file changed, 47 insertions(+), 11 deletions(-) commit 9948dfc60639a1fd8d16ec735403b1048eb07c0e Author: Caitlin Fischer <caitlinfischer@google.com> Date: Fri Mar 15 23:23:22 2019 +0000 [Autofill] Shows nationally formatted phone number suggestion values. This happens only when a feature is enabled. US phone numbers: https://screenshot.googleplex.com/NGGFGdNtre0 UK, BR, and US phone numbers: https://screenshot.googleplex.com/1wKZPAz8LEb Change-Id: I98c3c99103fffbd9789268d2843f7cdc15e91b49 Bug: 942650 Change-Id: I98c3c99103fffbd9789268d2843f7cdc15e91b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521277 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641345} components/autofill/core/browser/suggestion_selection.cc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit e29c5393078940e886abd116061dd65034b0bac7 Author: Hannes Payer <hpayer@chromium.org> Date: Fri Mar 15 23:18:15 2019 +0000 Add Memory.Experimental.Renderer2.Malloc.AllocatedObjects UMA and UKM Memory.Experimental.Renderer2.Malloc.AllocatedObjects measures the total size of allocated objects in the malloc allocator. Change-Id: I55074e72d40430ff9cd943409761d82e0b87e1ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524291 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#641344} chrome/browser/metrics/process_memory_metrics_emitter.cc | 3 +++ tools/metrics/histograms/histograms.xml | 3 +++ tools/metrics/ukm/ukm.xml | 5 +++++ 3 files changed, 11 insertions(+) commit c7b3f1a9a421c922f7a7893cdce400f582ce7686 Author: Robert Ogden <robertogden@chromium.org> Date: Fri Mar 15 23:16:09 2019 +0000 Enable Previews Omnibox UI by default ifdef's a test which is dependent on the feature not being enabled. Updates WebDriver tests too. Bug: 942572 Change-Id: I3d5fd864eccd01fc561b0fbd08dc2f528caa6cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524241 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#641343} .../previews/previews_ui_tab_helper_unittest.cc | 12 +++++-- .../content/browser/content_lofi_ui_service.cc | 5 +++ .../browser/content_lofi_ui_service_unittest.cc | 3 ++ components/previews/core/previews_features.cc | 2 +- tools/chrome_proxy/webdriver/common.py | 42 ++++++++++++++++++++++ tools/chrome_proxy/webdriver/https_previews.py | 7 ++-- tools/chrome_proxy/webdriver/lite_page.py | 23 +++++------- tools/chrome_proxy/webdriver/lofi.py | 24 ++++--------- 8 files changed, 78 insertions(+), 40 deletions(-) commit 0a40326e0e88ce8fa9bc0c3a427c77e00d98df2b Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Fri Mar 15 23:15:25 2019 +0000 Show IPH for tab strip Bug: 930965 Change-Id: I0c9aba62bbdc90a3c885429b5108c1a6170600b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525151 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641342} .../tasks/tab_management/TabGroupUiMediator.java | 3 ++- .../tasks/tab_management/TabListCoordinator.java | 17 +++++++++++++---- 2 files changed, 15 insertions(+), 5 deletions(-) commit 175a17ae227f6edc336a0b079004d9502bbed100 Author: danakj <danakj@chromium.org> Date: Fri Mar 15 23:10:38 2019 +0000 Remove RenderViewImpl::WidgetClient. Have all callers grab the full RenderWidget via GetWidget instead, as these are now redundant ways to grab the blink::WidgetClient. RenderWidget is now always the WidgetClient, web tests don't replace it with another object type. R=ajwong@chromium.org Bug: 545684, 912193 Change-Id: I4734b4f221739ec6c7734a0c903706d958030481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524868 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641341} content/renderer/gpu_benchmarking_extension.cc | 8 ++++---- content/renderer/render_frame_impl.cc | 4 ++-- content/renderer/render_view_browsertest.cc | 6 +++--- content/renderer/render_view_impl.cc | 15 ++++----------- content/renderer/render_view_impl.h | 4 ---- third_party/blink/public/web/web_view_client.h | 2 +- 6 files changed, 14 insertions(+), 25 deletions(-) commit e2c4395b3a7132d1b697a18d054acb19fcfbbd94 Author: Richard Knoll <knollr@chromium.org> Date: Fri Mar 15 23:09:45 2019 +0000 Use SessionChangeObserver to track session locked state. This improves lookup performance to check if windows is currently locked. Bug: 940607 Change-Id: Id1cccd31fdb80da65c2c67421339f03f1b95a35e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520841 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#641340} ui/base/win/lock_state.cc | 66 ++++++++++++++++++++++++++++------------------- 1 file changed, 39 insertions(+), 27 deletions(-) commit 8562d7b43dfa0a5a0da58d3c878389710b05a5ed Author: Fritz Koenig <frkoenig@chromium.org> Date: Fri Mar 15 23:04:10 2019 +0000 gpu: Remove target parameter from BufferQueue |target| is already platform dependant. Instead of passing it around, derive it at the usage site. BUG=none TEST=none Change-Id: Ia88c9c08f0f6c3aef8e21c56917027eb879ab299 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516030 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Fritz Koenig <frkoenig@chromium.org> Cr-Commit-Position: refs/heads/master@{#641339} .../viz/service/display_embedder/buffer_queue.cc | 8 +- .../viz/service/display_embedder/buffer_queue.h | 6 +- .../display_embedder/buffer_queue_unittest.cc | 93 +++++++++++----------- .../gl_output_surface_buffer_queue.cc | 5 +- .../gl_output_surface_buffer_queue.h | 1 - .../gl_output_surface_buffer_queue_android.cc | 1 - .../display_embedder/gl_output_surface_mac.cc | 1 - .../display_embedder/gl_output_surface_ozone.cc | 4 +- .../display_embedder/gl_output_surface_ozone.h | 3 +- .../display_embedder/gpu_display_provider.cc | 3 +- .../browser/compositor/gpu_output_surface_mac.cc | 1 - .../compositor/gpu_process_transport_factory.cc | 2 +- ...urfaceless_browser_compositor_output_surface.cc | 7 +- ...surfaceless_browser_compositor_output_surface.h | 1 - .../common/gpu_memory_buffer_support.cc | 5 ++ 15 files changed, 69 insertions(+), 72 deletions(-) commit d0798749d584916722ae1ee381a5d1fbc49b6caa Author: David Black <dmblack@google.com> Date: Fri Mar 15 22:57:17 2019 +0000 Renames Assistant's ActionView and LogoView. Previously ActionView was named because it encapsulated a few possible states depending on whether the user was using text or voice input modality. Now, ActionView is just a wrapper around a LogoView and is only used with voice input modality to represent mic state. As such, I've renamed ActionView to MicView to be more easily understood. Previously BaseLogoView was created to wrap LogoView depending on the status of the LibAssitant build flag, but users of LogoView will never actually use LogoView directly, only BaseLogoView. This being the case, I am renaming LogoView to LogoViewImpl and BaseLogoView to LogoView. I will rename BaseLogoView in a separate CL so that git can accurately track the diff. Bug: b:111571925 Change-Id: I3c543471c93af3a513afa6280ffe0cb037d54a00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521590 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641338} ash/app_list/views/app_list_view.h | 1 + ash/app_list/views/assistant/dialog_plate.cc | 3 +- ash/app_list/views/assistant/dialog_plate.h | 11 +++--- ash/assistant/ui/BUILD.gn | 8 ++-- ash/assistant/ui/dialog_plate/dialog_plate.cc | 3 +- ash/assistant/ui/dialog_plate/dialog_plate.h | 11 +++--- .../dialog_plate/{action_view.cc => mic_view.cc} | 26 ++++++------ .../ui/dialog_plate/{action_view.h => mic_view.h} | 21 +++++----- ash/assistant/ui/logo_view/base_logo_view.cc | 7 ++-- .../logo_view/{logo_view.cc => logo_view_impl.cc} | 46 ++++++++++++---------- .../ui/logo_view/{logo_view.h => logo_view_impl.h} | 18 ++++----- 11 files changed, 80 insertions(+), 75 deletions(-) commit 08bbc7ceae2e9bbf71ebdb315771929a7658581a Author: Mei Liang <meiliang@chromium.org> Date: Fri Mar 15 22:56:25 2019 +0000 [TabModelFilter] Change default behavior of getRelatedTabList The default behavior should be returning an unmodifiable list that only contains the Tab with the given id. Change-Id: Iae0ea4da145799c007f0c9e9b4f3427c71a5bd43 Bug: 942314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524538 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641337} .../org/chromium/chrome/browser/tabmodel/TabModelFilter.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit 82fb8ada44d5767278bcb0f99c1177cfff54113b Author: Aleks Totic <atotic@chromium.org> Date: Fri Mar 15 22:49:31 2019 +0000 Revert "SPM: Fix EmbedRoot focus" This reverts commit 45bcac82eb11e7701cfcfc70a0ccd673e2aeb516. Reason for revert: MSAN uninitialized memory use https://crbug.com/942741 Original change's description: > SPM: Fix EmbedRoot focus > > - Notify FocusSynchronizer when a window in EmbedRoot is focused > so that WS side would focused its proxy window; > - Observe FocusSynchronizer to reset the focused window in EmbedRoot > when the FocusSynchronizer changes to different focus client so > that the observers of the focused window gets the expected "blur" > call; > > Bug: b/127864880 > Change-Id: I00f76dd36040b3fdff05a8130093596aa5be6ffa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525057 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641213} TBR=xiyuan@chromium.org,sky@chromium.org Change-Id: I4994ae4526f67aa98f017dc72a42bf96f01003ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/127864880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526640 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641336} ui/aura/mus/embed_root.cc | 42 +++--------------------------- ui/aura/mus/window_tree_client_unittest.cc | 21 --------------- ui/aura/test/mus/test_window_tree.cc | 1 - ui/aura/test/mus/test_window_tree.h | 2 -- 4 files changed, 4 insertions(+), 62 deletions(-) commit c76561e6ccf5c7e647ca0d493dd0a4152294ccd2 Author: Robert Liao <robliao@chromium.org> Date: Fri Mar 15 22:46:12 2019 +0000 Rename ViewsContentClient and ViewsContentClientAppController Task Accessors To Their Specific Callback Phase and Migrate to OnceClosure/BindOnce BUG=714018,940130 Change-Id: Id145d0832e6e4e4e5009919cd78fa46a6038b39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521793 Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#641335} ash/app_list/demo/app_list_demo_views.cc | 3 ++- .../examples/examples_with_content_main_exe.cc | 2 +- ui/views_content_client/views_content_client.cc | 9 +++++++++ ui/views_content_client/views_content_client.h | 20 ++++++++++++++------ .../views_content_client_main_parts_chromeos.cc | 3 ++- ...views_content_client_main_parts_desktop_aura.cc | 2 +- .../views_content_client_main_parts_mac.mm | 22 ++++++++++++++-------- 7 files changed, 43 insertions(+), 18 deletions(-) commit 45d8e2b69ff8fa0a0ec996ea2bc65467bd65c97d Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Mar 15 22:44:54 2019 +0000 Android: Add MIN_SDK_VERSION to BuildConfig.java Planning to use this to restrict experimental Q features to TriChrome. Change-Id: Id894608c123484fece733d0eb388235a7e9abaa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526304 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#641334} base/android/java/templates/BuildConfig.template | 13 +++++++++++++ build/config/android/rules.gni | 10 +++++++++- 2 files changed, 22 insertions(+), 1 deletion(-) commit 6ec39d30bd45a1d3d7884658e70c326fd3a3eecd Author: danakj <danakj@chromium.org> Date: Fri Mar 15 22:43:22 2019 +0000 More checks to disagnose why we are using an invalid RenderWidget. These checks differentiate if the RenderWidget is being used before initialization or after being closed. R=dcheng@chromium.org NOTRY=true Bug: 939262 Change-Id: I70e0f6e06e10ea55bdaacdd9e54098d4ef0696da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524036 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641333} content/renderer/render_widget.cc | 11 ++++++++--- content/renderer/render_widget.h | 4 ++++ 2 files changed, 12 insertions(+), 3 deletions(-) commit 191d968fb31d2bb079e4f7a015db35f2e4d987b6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 22:36:52 2019 +0000 Roll src/third_party/angle de52ca373d98..e41882aaf55d (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/de52ca373d98..e41882aaf55d git log de52ca373d98..e41882aaf55d --date=short --no-merges --format='%ad %ae %s' 2019-03-15 ianelliott@google.com dEQP-EGL.functional.choose_config.* now passing Created with: gclient setdep -r src/third_party/angle@e41882aaf55d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: If2c8c822000f7cd020cd5fbcba8cdecc4e49a932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525679 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641332} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f699d73a0e08331754d9a3b344a2132974edd049 Author: James Cook <jamescook@chromium.org> Date: Fri Mar 15 22:33:51 2019 +0000 chromeos: Material Design version of Set Time dialog, part 1 * Add SetTimeDialogMd feature flag. * Port the core functionality to Polymer. * Add test using mocha. TODO: Styling to spec will be done in follow-up CLs. BUG=927732 TEST=browser_tests SetTimeWebUITest, manual Change-Id: I32e283e0c3db86536a392108bce9aba162f6b836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497494 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641331} chrome/browser/browser_resources.grd | 4 + chrome/browser/chromeos/set_time_dialog.cc | 22 ++- chrome/browser/chromeos/set_time_dialog.h | 3 + chrome/browser/chromeos/system/timezone_util.cc | 2 + chrome/browser/resources/chromeos/BUILD.gn | 1 + .../resources/chromeos/md_set_time/BUILD.gn | 30 ++++ .../resources/chromeos/md_set_time/set_time.html | 98 ++++++++++ .../resources/chromeos/md_set_time/set_time.js | 197 +++++++++++++++++++++ .../md_set_time/set_time_browser_proxy.html | 2 + .../chromeos/md_set_time/set_time_browser_proxy.js | 51 ++++++ .../resources/chromeos/set_time/set_time.html | 1 + chrome/browser/ui/webui/chromeos/set_time_ui.cc | 32 +++- chrome/test/data/webui/BUILD.gn | 1 + chrome/test/data/webui/md_set_time_browsertest.js | 119 +++++++++++++ chromeos/constants/chromeos_features.cc | 10 ++ chromeos/constants/chromeos_features.h | 5 + .../filters/webui_polymer1_browser_tests.filter | 1 + 17 files changed, 571 insertions(+), 8 deletions(-) commit 4f0f0ee52fc07ab619e341e20599c8cd49d95ad2 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Fri Mar 15 22:32:35 2019 +0000 Roll src-internal fa2d5d1b4ecf..dd08c2522931 (12 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa2d5d1b4ecf..dd08c2522931 Created with: gclient setdep -r src-internal@dd08c2522931 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org Change-Id: I2eac388a8d6277b6cd5c9f255fd0df3981fa7ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524440 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641330} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0e121588d500217a38d57f5e285aa586676059b2 Author: Sergey Abbakumov <sabbakumov@yandex-team.ru> Date: Fri Mar 15 22:32:16 2019 +0000 base::Value::SetKey/SetPath performance improvements Use rvalue references to avoid copying sizeof(base::Value). This commit gives about -20KB of the browser.dll and browser_child.dll size. Also it reduces renderer memory consumption by ~200 KB max. Bug: 646113 Change-Id: I8c86594838292a2faf4d134b899a7978dbc214fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520407 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641329} base/values.cc | 10 +++++----- base/values.h | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) commit 926e8f9782a27848fef67e00d62e8eb09ea8b1bf Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Mar 15 22:28:16 2019 +0000 Roll src/third_party/chromite 35b4e4c67938..c59012f09dd0 (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/35b4e4c67938..c59012f09dd0 git log 35b4e4c67938..c59012f09dd0 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 dgarrett@google.com manifest_versions: Improve logging slightly. 2019-03-15 pprabhu@chromium.org config: Mark new skylab chrome-pfqs important Created with: gclient setdep -r src/third_party/chromite@c59012f09dd0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I3c34324574e73638ca32f3861100aca2985065ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526325 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641328} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 947f6d0d33c32259b73b384ec028c7b570f5ffe7 Author: Tomasz Wiszkowski <ender@google.com> Date: Fri Mar 15 22:27:25 2019 +0000 Introduce Zero Prefix URL Suggestions flag. This flag controls support for Omnibox Zero Prefix URL Suggestions on Clank. When enabled, Omnibox will start supplying suggestions for currently visited website. Bug: 934922 Change-Id: Ic28e81855198c5a21e1c0e2eeee02629f422ca1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516713 Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#641327} chrome/browser/about_flags.cc | 7 +++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 5 +++++ chrome/browser/flag_descriptions.h | 3 +++ components/omnibox/browser/zero_suggest_provider.cc | 7 +++---- components/omnibox/common/omnibox_features.cc | 5 +++++ components/omnibox/common/omnibox_features.h | 1 + tools/metrics/histograms/enums.xml | 2 ++ 8 files changed, 31 insertions(+), 4 deletions(-) commit 4f1386039c5ae69de6b24ebdbd77b2402f6f5678 Author: Mike Wittman <wittman@chromium.org> Date: Fri Mar 15 22:27:10 2019 +0000 [Sampling profiler] Encapsulate Mac stack walking 3/4: frame recording The platform-native stack walking needs to be encapsulated into a function that can be invoked in an alternating fashion with V8 unwinding, once supported. This change inlines the frame recording into the core stack walking function. The encapsulation requires inlining otherwise-sensible abstractions to enable creation of future abstractions that can be used across platforms. No functional change is intended. Bug: 931418 Change-Id: I40880b76b65cda63892ce98395a0fcc46ec3259c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513209 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641326} base/profiler/native_stack_sampler_mac.cc | 41 ++++++++++++++----------------- 1 file changed, 19 insertions(+), 22 deletions(-) commit a5795e0a0e58d1bba6c9890f2467bbe2055791a8 Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Fri Mar 15 22:23:26 2019 +0000 [LayoutNG] Allow bfc_line_offset movement in caching logic. Previously if a childs bfc_line_offset changed, we didn't allow caching of the fragment. However we can safely do this if there aren't any floats. Also only performs a copy of the layout_result if the bfc_offset actually changed and removes NGConstraintSpace::operator==(). Bug: 635619 Change-Id: I3189cd5dd4636ed48e1d948b9642ab232044b282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524623 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#641325} .../renderer/core/layout/ng/layout_ng_mixin.cc | 20 ++++++++---- .../layout/ng/ng_block_layout_algorithm_test.cc | 36 ++++++++++++++++++++++ .../renderer/core/layout/ng/ng_constraint_space.cc | 14 --------- .../renderer/core/layout/ng/ng_constraint_space.h | 10 +----- .../renderer/core/layout/ng/ng_layout_result.cc | 4 +-- .../renderer/core/layout/ng/ng_layout_result.h | 1 + 6 files changed, 54 insertions(+), 31 deletions(-) commit 4a09e5d4414137fe789b304213db2c1a55bd8486 Author: Austin Eng <enga@chromium.org> Date: Fri Mar 15 22:23:12 2019 +0000 Add GetProcs() to DawnObject This allows WebGPU objects to get the client DawnProcTable. Implementation of the WebGPU API will primarily call the Dawn procs. Bug: 941536 Change-Id: I6e8cc572ddf4935363e971b6fc0adfbb448df660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521237 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641324} third_party/blink/renderer/bindings/modules/v8/BUILD.gn | 1 + .../blink/renderer/modules/webgpu/dawn_control_client_holder.cc | 7 +++++++ .../blink/renderer/modules/webgpu/dawn_control_client_holder.h | 3 +++ third_party/blink/renderer/modules/webgpu/dawn_object.cc | 4 ++++ third_party/blink/renderer/modules/webgpu/dawn_object.h | 3 +++ 5 files changed, 18 insertions(+) commit 0fa8787c2b817de5618eaa13f1e1c4224c6cbfad Author: Andrew Grieve <agrieve@chromium.org> Date: Fri Mar 15 22:21:12 2019 +0000 Android: Move third_party/checkstyle to CIPD It's the last user of GCS bucket "chromium-android-tools" Change-Id: I51b0c296e83f18effa155ae4f6d2ca6d84733b8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524975 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641323} DEPS | 26 ++++++++++------------ third_party/checkstyle/checkstyle-8.0-all.jar.sha1 | 1 - third_party/checkstyle/cipd.yaml | 9 ++++++++ 3 files changed, 21 insertions(+), 15 deletions(-) commit 23bb4e93dc5a69152d0b3cc23b2521285e80c7cd Author: Sergey Ulanov <sergeyu@google.com> Date: Fri Mar 15 22:18:59 2019 +0000 Add Vulkan support in SkiaOutputSurfaceImpl::YUVAPromiseTextureHelper Previously SkiaOutputSurfaceImpl::YUVAPromiseTextureHelper was always trying to create GL GrBackendFormat to makeYUVAPromiseTexture() even when Vulkan is being used by the renderer. As the result it was failing to render video. Updated it to use GrBackendFormat::MakeVk() when using Vulkan backend. Bug: 942370 Change-Id: I3806ec1ea8e728639599e3844eb5b9f7a0fadecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525410 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641322} .../display_embedder/skia_output_surface_impl.cc | 60 ++++++++++++---------- .../display_embedder/skia_output_surface_impl.h | 2 + 2 files changed, 35 insertions(+), 27 deletions(-) commit 436d90b87dd5c4870c871165c826766e32092c40 Author: Yusuf Ozuysal <yusufo@google.com> Date: Fri Mar 15 22:17:58 2019 +0000 Add an entry for TabGroups to chrome://flags This starts using the GridTabSwitcher as the main layout for tab groups (while bottomsheet and tabstrip are for within group switching). Also adds a chrome://flag entry now that all pieces are there. BUG=942300 Change-Id: I83412b56abc8fbf81a90985f6dc14e29aa25fa59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525275 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641321} .../tab_management/GridTabSwitcherCoordinator.java | 11 ++++--- .../tab_management/GridTabSwitcherMediator.java | 35 ++++++++++++++------- .../GridTabSwitcherMediatorUnitTest.java | 36 ++++++++++++++-------- .../chrome/browser/ChromeTabbedActivity.java | 3 +- chrome/browser/about_flags.cc | 4 +++ chrome/browser/flag-metadata.json | 5 +++ chrome/browser/flag_descriptions.cc | 4 +++ chrome/browser/flag_descriptions.h | 3 ++ tools/metrics/histograms/enums.xml | 2 ++ 9 files changed, 73 insertions(+), 30 deletions(-) commit 3250db49dec2c6d4d18109dbbd7ceea7cfab634e Author: Caio <caiol@google.com> Date: Fri Mar 15 22:17:48 2019 +0000 Add to kids_management_url_checker trafic annotation data the auth token. fix(kids_management_url_checker_client): add to traffic annotation data the auth token Bug: 934444 Change-Id: I810b971c98cf0a952090731bf8cfed1bf4d7cfa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524303 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Caio Lima <caiol@google.com> Cr-Commit-Position: refs/heads/master@{#641320} chrome/browser/supervised_user/kids_management_url_checker_client.cc | 4 +++- tools/traffic_annotation/summary/annotations.xml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) commit d9d8d87356ddbe5bd57f8c34f46ab24943e20e91 Author: Aleks Totic <atotic@chromium.org> Date: Fri Mar 15 22:16:30 2019 +0000 Revert "Add support for overrides on the consistency tests." This reverts commit a595a7cdd07c759366f2c1d4899ba6097934e2a5. Reason for revert: stack-use-after-scope detected by ASAN. https://crbug.com/942726 Original change's description: > Add support for overrides on the consistency tests. > > Also includes new |last_updated| fields on usage limit and bedtime entries and a lot of test cases. > > Bug: 935711 > Change-Id: I589216931896d22f106b9a241ab3e81c5ce48108 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518947 > Commit-Queue: G. Silva <gfaus@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641192} TBR=michaelpg@chromium.org,agawronska@chromium.org,hgrandinetti@chromium.org,gfaus@chromium.org Change-Id: I0d340daf85b4b97b48c2fcb95f1fac1458f3d30b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935711 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526627 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641319} .../consistency_golden_converter.cc | 71 ++---------- .../consistency_golden_converter.h | 14 +-- .../consistency_golden_converter_unittest.cc | 127 ++------------------- .../consistency_test.cc | 5 +- .../consistency_test_utils.cc | 51 ++------- .../consistency_test_utils.h | 33 +----- .../goldens/consistency_golden.proto | 35 ------ .../goldens/override_bedtimes.textproto | 110 ------------------ .../goldens/override_then_modify.textproto | 102 ----------------- .../override_usage_limits_android.textproto | 61 ---------- .../goldens/override_usage_limits_cros.textproto | 61 ---------- .../goldens/simple_override.textproto | 24 ---- 12 files changed, 35 insertions(+), 659 deletions(-) commit 75a822156241cfa40368a97cf8f228c73dc3e396 Author: Allison Pastewka <alpastew@microsoft.com> Date: Fri Mar 15 22:16:25 2019 +0000 Add support for overload resolution algo when using variadic arguments Implemented the portion of the effective overload set algorithm that disambiguates overloads with variadic arguments. Previously there was no support for these types of overloaded JavaScript APIs and when compiled not all of the effective overload sets were being produced causing us to generate incorrect V8 code. To get the correct effective overload sets, we need to distinguish if an argument is 'required', 'optional' or 'variadic'. At the moment, the algorithm uses a boolean to distinguish between a 'required' argument and either an 'optional' or 'variadic' argument. I changed it so that all three were distinguishable from each other and added the necessary steps for when a variadic argument is present. I followed the spec steps. The spec can be found here: https://heycam.github.io/webidl/ and then search for effective overload set. I also updated and added new tests to the effective overload set test suite and added a new webidl test that tests the scenario where you have an overloaded JavaScirpt API that has variadic arguments. Finally I added node_or_string.h and node_or_string.cc to the test directory because these reference files were missing after I added the test. Bug: 929192 Change-Id: I1fbcc250a705e12632e2b3fd3ea42672b97c5e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506438 Commit-Queue: Allison Pastewka <alpastew@microsoft.com> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641318} .../bindings/scripts/overload_set_algorithm.py | 180 +++++++++++------ .../scripts/overload_set_algorithm_test.py | 215 +++++++++++++++++++-- .../bindings/templates/interface_base.cc.tmpl | 2 + .../tests/idls/core/test_interface_node.idl | 3 + .../bindings/tests/results/core/v8_array_buffer.cc | 2 + .../tests/results/core/v8_array_buffer_view.cc | 2 + .../bindings/tests/results/core/v8_data_view.cc | 2 + .../tests/results/core/v8_svg_test_interface.cc | 2 + .../tests/results/core/v8_test_attributes.cc | 2 + .../results/core/v8_test_callback_functions.cc | 2 + .../tests/results/core/v8_test_constants.cc | 2 + .../tests/results/core/v8_test_integer_indexed.cc | 2 + .../results/core/v8_test_integer_indexed_global.cc | 2 + .../tests/results/core/v8_test_interface.cc | 2 + .../tests/results/core/v8_test_interface_2.cc | 2 + .../core/v8_test_interface_check_security.cc | 2 + ...v8_test_interface_conditional_secure_context.cc | 2 + .../results/core/v8_test_interface_constructor.cc | 2 + .../core/v8_test_interface_constructor_2.cc | 2 + .../core/v8_test_interface_constructor_3.cc | 2 + .../core/v8_test_interface_constructor_4.cc | 2 + .../core/v8_test_interface_custom_constructor.cc | 2 + .../results/core/v8_test_interface_document.cc | 2 + .../tests/results/core/v8_test_interface_empty.cc | 2 + .../v8_test_interface_event_init_constructor.cc | 2 + .../results/core/v8_test_interface_event_target.cc | 2 + .../core/v8_test_interface_named_constructor.cc | 2 + .../core/v8_test_interface_named_constructor_2.cc | 2 + .../tests/results/core/v8_test_interface_node.cc | 99 ++++++++++ .../tests/results/core/v8_test_interface_node.h | 1 + .../core/v8_test_interface_origin_trial_enabled.cc | 2 + .../core/v8_test_interface_secure_context.cc | 2 + .../bindings/tests/results/core/v8_test_node.cc | 2 + .../bindings/tests/results/core/v8_test_object.cc | 2 + .../results/core/v8_test_special_operations.cc | 2 + .../v8_test_special_operations_not_enumerable.cc | 2 + .../tests/results/core/v8_test_typedefs.cc | 2 + .../core/v8_test_variadic_constructor_arguments.cc | 2 + .../tests/results/core/v8_uint8_clamped_array.cc | 2 + ...herited_legacy_unenumerable_named_properties.cc | 2 + .../results/modules/v8_test_interface_2_partial.cc | 2 + .../tests/results/modules/v8_test_interface_5.cc | 2 + .../results/modules/v8_test_interface_partial.cc | 2 + .../modules/v8_test_not_enumerable_named_getter.cc | 2 + .../tests/results/modules/v8_test_sub_object.cc | 2 + 45 files changed, 498 insertions(+), 80 deletions(-) commit 65f285aff72745e44a53a0b977e4ad2f57256f0d Author: Daniel Murphy <dmurph@chromium.org> Date: Fri Mar 15 22:14:00 2019 +0000 [LevelDBScopes] Scopes metadata Scopes metadata & encoding function, along with tests. Bug: 862456 Change-Id: Ia73885959b3154280c8c9eec1084ab3217bfd4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521470 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#641317} content/browser/BUILD.gn | 3 + content/browser/indexed_db/scopes/BUILD.gn | 17 +++ .../indexed_db/scopes/leveldb_scopes_coding.cc | 122 +++++++++++++++ .../indexed_db/scopes/leveldb_scopes_coding.h | 104 +++++++++++++ .../scopes/leveldb_scopes_coding_unittest.cc | 168 +++++++++++++++++++++ .../indexed_db/scopes/scopes_metadata.proto | 48 ++++++ content/test/BUILD.gn | 1 + 7 files changed, 463 insertions(+) commit 081ad5e9f15e8b6e7c6cafe9ba408988b6e78bdc Author: Ella Ge <eirage@chromium.org> Date: Fri Mar 15 22:13:00 2019 +0000 Reland "Make pointer capture work in same origin frame" This is a reland of d44248f2a896421c1382c1dbbf0d7e1a9b798470 Original change is reverted by findit due to test flaky. The flaky test is: fast/events/pointerevents/mouse-pointer-capture-in-iframe.html This is reland with fixing tests. Original change's description: > Make pointer capture work in same origin frame > > We used to send mouse event to the subframe before apply the pointer > capture target, and it causes the pointer capture doesn't work when > capture to a outer frame target and move to inner frame. > > This CL changes three things: > 1. 'Rename' the |capturing_mouse_events_element_| to > |capturing_subframe_element_| as it only used for the frame capture > (There is plan to remove the frame capture logic once we have pointer > capture work correctly) > 2. On HandleMouse*Event, instead of always perform a hit test, we use > either frame capture target or pointer capture target to re-construct > the HitTestResult. > 3. When using the capture target, update the hover active state for > capture target. > > This change makes captured pointer event sent correctly when over > same origin frame, and also decrease the hit_test_count because of > frame capturing. > > Note that after this change, we still NOT allow set/release pointer > capture across same-origin frame as the pointer id and active statue > is per frame. > > See design doc: > https://docs.google.com/document/d/1cOZu98UuKk5bdARUQKmj2Q8YoEMpd9l78T0k-cf5ttc/ > > This change is under a blink flag UnifiedPointerCaptureInBlink. > > Change-Id: I61c6a02086535d2a145df9d414df0bdc9673101e > Bug: 936190, 919908 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1446556 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640055} Bug: 936190, 919908 Change-Id: Icc374c16b1aee0b9125593801c8787f28c7db554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520941 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#641316} .../blink/renderer/core/input/event_handler.cc | 117 ++++++++++++--- .../blink/renderer/core/input/event_handler.h | 11 ++ .../renderer/core/input/event_handling_util.cc | 4 +- .../renderer/core/input/event_handling_util.h | 2 +- .../renderer/core/input/pointer_event_manager.cc | 24 ++- .../renderer/core/input/pointer_event_manager.h | 2 + .../platform/runtime_enabled_features.json5 | 4 + .../spelling/context_click_select_misspelling.html | 2 + .../pointerevent_mouse_capture_change_hover.html | 167 +++++++++++++++++++++ ...pointerevent_mouse_pointercapture_in_frame.html | 143 ++++++++++++++++++ ...nt_mouse_pointercapture_inactivate_pointer.html | 55 +++++++ .../pointerevent_mouse_pointercapture-iframe.html | 9 ++ ...e_pointercapture_inactivate_pointer-iframe.html | 10 ++ .../fast/events/click-after-mousedown-cancel.html | 2 + .../fast/events/hit-test-counts-expected.txt | 4 +- .../mouse-pointer-capture-in-iframe.html | 117 +++++++++++++++ .../fast/events/hit-test-counts-expected.txt | 93 ------------ .../fast/events/hit-test-counts-expected.txt | 93 ------------ 18 files changed, 641 insertions(+), 218 deletions(-) commit e21a8ba1a54688ff7e39901fe8832a13c51fa645 Author: Alex Cooper <alcooper@chromium.org> Date: Fri Mar 15 22:12:10 2019 +0000 Reland "Remove usage of HMD devices as an inline provider" The previous change was failing two sets of tests: WebXrVrBrowserTestStandard.TestPresentationPoses and WebXRVrDeviceTest#testForNullPosesInInlineVR*. For the first set, it was discovered that there was a bug in the logic for scheduling a non-immersive frame that would cause two frames to be scheduled for every one frame if we did not have a magic window provider, only possible after this change. For the second set, the tests were not expected to get valid poses, which was happening now that the boilerplate had been updated to return an inline identity session, which is guaranteed available across all platforms. The fix for this was to revert the test to request an eye-level stationary reference space as before, since this was on an android device which actually supported that reference space. A few changes had to be made to webxr_boilerplate to properly allow the override logic. The revert of the original commit was commit: 85f4903e9e207c6429f7df86cd39581bae31257a Original change's description: > Revert "Remove usage of HMD devices as an inline provider" > > This reverts commit 28bae1e221f99f4330a12d5af68fcdeaa28f6466. > > Reason for revert: 939887,939901 > > Original change's description: > > Remove usage of HMD devices as an inline provider > > > > Now that the inline identity space is always supported as per the spec > > we don't need to have GVR and other HMDs support the inline scenario. > > Until/unless we have support for orientation sensors on the platforms > > (which should support the stationary spatial reference spaces), we will > > simply use the identity space. > > > > Bug: 891552 > > Change-Id: Id9f56bb42f87dfac0c4a37878da9763ecbb5a5c7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490523 > > Commit-Queue: Alexander Cooper <alcooper@chromium.org> > > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Reviewed-by: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638787} > > TBR=bajones@chromium.org,bsheedy@chromium.org,billorr@chromium.org > Change-Id: Ie45b8745aa4b4a4da3f5f4a2234affdeba07dd18 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 891552 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512333 > Reviewed-by: Bill Orr <billorr@chromium.org> > Commit-Queue: Bill Orr <billorr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#639110} Change-Id: I12869d97f6a5aeab36f698180698ea6f1fd73df4 Bug: 891552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512334 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641315} chrome/browser/vr/service/xr_runtime_manager.cc | 5 +- .../e2e_test_files/html/test_inline_vr_poses.html | 12 +++++ .../e2e_test_files/resources/webxr_boilerplate.js | 41 ++++++++++++----- device/vr/android/gvr/gvr_device.cc | 20 +------- device/vr/android/gvr/gvr_device.h | 2 - device/vr/oculus/oculus_device.cc | 19 +------- device/vr/oculus/oculus_device.h | 2 - device/vr/openvr/openvr_device.cc | 22 +-------- device/vr/openvr/openvr_device.h | 4 -- .../windows_mixed_reality/mixed_reality_device.cc | 5 +- .../blink/renderer/modules/vr/vr_display.cc | 53 ++++++++++++++++------ third_party/blink/renderer/modules/vr/vr_display.h | 1 + third_party/blink/renderer/modules/xr/xr.cc | 19 ++++++-- third_party/blink/renderer/modules/xr/xr.h | 2 + .../blink/renderer/modules/xr/xr_frame_provider.cc | 22 +++++---- third_party/blink/renderer/modules/xr/xr_session.h | 8 +++- 16 files changed, 124 insertions(+), 113 deletions(-) commit 8e2de5472fb68b94d0ab76762932760021989077 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Fri Mar 15 22:11:37 2019 +0000 Break an infinite loop in PageDown In PageDown selection movement, NextLinePosition() is called iteratively until we've moved far enough vertically. However, in some cases, the results of NextLinePosition() may end up in a cycle, causing an infinite loop. The root cause of the cycle is not worthy to fix, as it's due to a collapsed whitespace having a zero width InlineBox. Hence, this patch works around it by hard limiting the iteration. Bug: 933839 Change-Id: Icbe6c42b16e5b06d43535ce9ac3be24a6153ab74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525002 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641314} .../blink/renderer/core/editing/selection_modifier.cc | 10 +++++++++- .../modify_move/move_page_down_inline_block_hang.html | 16 ++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) commit 778da80ed8377aa466cc1e8fc4a80a7b553ce495 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Fri Mar 15 22:11:02 2019 +0000 PM: Thin down the RC mojo interfaces. This CL retires the Page and System CUs, as well as any method of the remaining CUs that is no longer used for renderer->browser communication. The CU Provider interface is likewise turfed. Bug: 910288 Change-Id: I769282c4369c2e00d30bb24fabc9d1d248dee1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523531 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#641313} .../performance_manager/graph/frame_node_impl.h | 10 +-- .../browser/performance_manager/graph/node_base.h | 63 +++++++------- .../performance_manager/graph/page_node_impl.cc | 4 +- .../performance_manager/graph/page_node_impl.h | 26 ++---- .../graph/page_node_impl_unittest.cc | 4 +- .../performance_manager/graph/process_node_impl.h | 9 +- .../performance_manager/graph/system_node_impl.cc | 15 ++-- .../performance_manager/graph/system_node_impl.h | 46 +++++++++-- .../graph/system_node_impl_unittest.cc | 23 +++--- .../observers/metrics_collector_unittest.cc | 30 +++---- .../page_signal_generator_impl_unittest.cc | 23 +++--- .../performance_manager/performance_manager.cc | 4 +- .../performance_manager/performance_manager.h | 6 +- .../performance_manager_tab_helper.cc | 2 +- .../resource_coordinator/render_process_probe.cc | 27 +++--- .../resource_coordinator/render_process_probe.h | 10 ++- .../render_process_probe_browsertest.cc | 23 +++--- .../resource_coordinator/public/mojom/BUILD.gn | 1 - .../public/mojom/coordination_unit.mojom | 95 ---------------------- .../public/mojom/coordination_unit_provider.mojom | 17 ---- 20 files changed, 177 insertions(+), 261 deletions(-) commit d0b9fad939ca664207743a87e1c85e813f01138a Author: David Black <dmblack@google.com> Date: Fri Mar 15 22:10:29 2019 +0000 Adds deep links for Assistant Notes and Lists. Note that server side changes will be required to start sending these deep links down to the client, this change only adds the client support. We will likely need to send the server some indication (e.g. experiment ID) to let it know that this capability is available, but we will attempt to use user agent or some other already available signal if possible. Bug: b:126957591 Change-Id: Iba6fbef9678d76f9be3df6aa2fda72c246916b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501936 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641312} ash/assistant/assistant_controller.cc | 2 + ash/assistant/util/deep_link_util.cc | 55 ++++++--- ash/assistant/util/deep_link_util.h | 12 +- ash/assistant/util/deep_link_util_unittest.cc | 164 ++++++++++++++++++++++++-- 4 files changed, 203 insertions(+), 30 deletions(-) commit 8d2d98ea77efce9e0673c47845130aa403c27159 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Fri Mar 15 22:09:55 2019 +0000 [modules] Show error messages why fake install may be failing Bug: 926209 Change-Id: I2daff7024df075471e072d7733e496a2cd8196ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526432 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641311} .../FakeModuleInstallerBackend.java | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) commit 43b68c311585a91b04ae83520fdcbedc82eb5ad0 Author: Johannes Henkel <johannes@chromium.org> Date: Fri Mar 15 22:05:33 2019 +0000 Switch HttpServer::Delegate::OnWebSocketMessage to std::string. Previously, this was a const std::string&, so in practice this forces a copy. Now, the server std::moves the payload to the delegate instance when calling OnWebSocketMessage. I'm not updating client code more than necessary here, so there are still copies e.g. in devtools_http_handler.cc. I plan to resolve them a different way, by introducing a custom class for devtools messages. But since net is a lower layer, it seems better to do the string moves there and keep it minimal. Change-Id: Ia74c7b67b19f2c6d80494889721b7201b2a3b5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525405 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641310} chrome/test/chromedriver/net/net_util_unittest.cc | 3 +-- chrome/test/chromedriver/net/test_http_server.cc | 3 +-- chrome/test/chromedriver/net/test_http_server.h | 2 +- chrome/test/chromedriver/server/chromedriver_server.cc | 3 +-- content/browser/devtools/devtools_http_handler.cc | 8 +++----- net/server/http_server.cc | 2 +- net/server/http_server.h | 3 +-- net/server/http_server_fuzzer.cc | 2 +- net/server/http_server_unittest.cc | 5 ++--- 9 files changed, 12 insertions(+), 19 deletions(-) commit e48a2e80b37a749dcec57661f723f0a14649de11 Author: Victor Costan <pwnall@chromium.org> Date: Fri Mar 15 22:02:34 2019 +0000 websql: Switch blink::Platform::DatabaseOpenFile() to return base::File. Bug: 925739 Change-Id: Ia2e1fbe637ecf6ad0a090bd3302cfea16d893e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525447 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641309} PRESUBMIT.py | 4 +-- content/child/blink_platform_impl.cc | 8 ++---- content/child/blink_platform_impl.h | 6 ++-- content/renderer/renderer_blink_platform_impl.cc | 4 +-- content/renderer/renderer_blink_platform_impl.h | 5 ++-- third_party/blink/public/platform/platform.h | 19 +++---------- .../webdatabase/sqlite/sqlite_file_system_posix.cc | 19 +++++++------ .../webdatabase/sqlite/sqlite_file_system_win.cc | 32 +++++++++++----------- 8 files changed, 41 insertions(+), 56 deletions(-) commit 6b6b41bd83e2084f697505046c7afb96d3e0d40e Author: Eugene But <eugenebut@chromium.org> Date: Fri Mar 15 22:02:23 2019 +0000 Create ios/web/common directory. This directory will contain common code shared between //ios/web and the rest of the layers (//components, //ios/chrome, //ios/web_view). This directory will not contain the public API to create and manage web contents (//ios/web//public is public API directory). Bug: 942244 Change-Id: I22a93738863b82592edcebe6882e75ca7f61adb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525008 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641308} ios/web/BUILD.gn | 1 + ios/web/common/BUILD.gn | 15 +++++++++++++++ ios/web/common/DEPS | 12 ++++++++++++ ios/web/common/README.md | 1 + .../{public/web_state/ui => common}/crw_content_view.h | 8 ++++---- ios/web/interstitials/BUILD.gn | 1 + ios/web/interstitials/web_interstitial_impl.h | 2 +- ios/web/public/BUILD.gn | 2 +- ios/web/public/DEPS | 1 + ios/web/public/test/fakes/BUILD.gn | 1 + ios/web/public/test/fakes/test_web_state.mm | 2 +- ios/web/public/web_state/ui/crw_web_view_content_view.h | 2 +- ios/web/web_state/BUILD.gn | 1 + ios/web/web_state/ui/BUILD.gn | 1 + ios/web/web_state/ui/crw_web_controller.mm | 2 +- ios/web/web_state/ui/crw_web_controller_container_view.h | 2 +- ios/web/web_state/ui/crw_web_controller_container_view.mm | 2 +- ios/web/web_state/ui/crw_web_controller_unittest.mm | 2 +- ios/web/web_state/ui/crw_web_view_proxy_impl.h | 2 +- ios/web/web_state/ui/crw_web_view_proxy_impl.mm | 2 +- ios/web/web_state/web_state_impl.mm | 2 +- 21 files changed, 49 insertions(+), 15 deletions(-) commit 6abc3675fba3160dabe86894f869f900d2056a65 Author: Joone Hur <joone.hur@intel.com> Date: Fri Mar 15 21:59:39 2019 +0000 Remove ui_scale_factor from AshWindowTreeHostInitParams struct Change-Id: I32d6f96792ce4ba5548891844874410abf9008cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525175 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Joone Hur <joone.hur@intel.com> Cr-Commit-Position: refs/heads/master@{#641307} ash/host/ash_window_tree_host_init_params.h | 1 - 1 file changed, 1 deletion(-) commit a3807853280fbed12e92d4156d67a38f8bdc7e8b Author: Peng Huang <penghuang@chromium.org> Date: Fri Mar 15 21:57:45 2019 +0000 SkiaOutputSurface: call flush() after releasing skimages. We need call flush() after releasing skimages to make sure release and done callbacks are called. So the shared image backing can be reused. Bug: 942547 Change-Id: I1fec108d7404ade33a20629da1cea60412d14d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526382 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641306} .../service/display_embedder/skia_output_surface_impl_on_gpu.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 90cb7f1f12807327978b2047f7e157b151561228 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Fri Mar 15 21:56:57 2019 +0000 [iOS][Translate] Fixes crash in language selection dismissal. Fixes the crash by not animating the dismissal of the language selector. Bug: 942421 Change-Id: I5c8124014c87b9dfb7441d5893de4ebb87604f1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525988 Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641305} ios/chrome/browser/ui/translate/language_selection_coordinator.mm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2cc6c7f979b10ed5e1d8f7e9e3f3792cc45c393b Author: Bruno Santos <brunoad@chromium.org> Date: Fri Mar 15 21:56:40 2019 +0000 Give KioskNextHome app access to IdentityAccessor via KioskNextHomeInterfaceBroker Mojo service. This allows KioskNextHome platform app to access IdentityAccessor mojo service via its generated JS bindings as if it were bundled with the app. Bug: 927809 Change-Id: I3833b2422ce98d07e634b9a38b60e1078c624a26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516780 Commit-Queue: Bruno Santos <brunoad@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#641304} chrome/app/BUILD.gn | 1 + .../app/chrome_content_browser_overlay_manifest.cc | 3 ++ chrome/browser/BUILD.gn | 2 + chrome/browser/chromeos/kiosk_next_home/BUILD.gn | 17 +++++++ chrome/browser/chromeos/kiosk_next_home/OWNERS | 2 + .../kiosk_next_home_interface_broker_impl.cc | 34 ++++++++++++++ .../kiosk_next_home_interface_broker_impl.h | 52 ++++++++++++++++++++++ .../chromeos/kiosk_next_home/mojom/BUILD.gn | 15 +++++++ .../browser/chromeos/kiosk_next_home/mojom/OWNERS | 2 + .../mojom/kiosk_next_home_interface_broker.mojom | 15 +++++++ chrome/browser/extensions/BUILD.gn | 2 + .../chrome_component_extension_resource_manager.cc | 6 +++ .../chrome_extensions_interface_registration.cc | 35 +++++++++++++++ chrome/browser/resources/BUILD.gn | 14 ++++++ .../resources/chromeos/kiosk_next_home/BUILD.gn | 13 ++++-- .../resources/chromeos/kiosk_next_home/api_impl.js | 39 ++++++++++------ .../kiosk_next_home/kiosk_next_resources.grdp | 1 + .../resources/chromeos/kiosk_next_home/main.html | 3 ++ .../chromeos/kiosk_next_home/manifest.json | 3 +- 19 files changed, 241 insertions(+), 18 deletions(-) commit 104e1355d44da283db616ee143eccb4de127c48f Author: Nick Burris <nburris@chromium.org> Date: Fri Mar 15 21:53:40 2019 +0000 Make Element::scrollIntoView scroll the visual viewport. scrollIntoView() should also scroll the visual viewport instead of just the layout viewport. This was previously disabled out of caution when Inert Visual Viewport was introduced. Bug: 914450 Change-Id: Ief541de518ff03ea1dafca11e4d187a064c22f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1481730 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641303} components/test/data/payments/initiated_test.html | 2 +- .../data/payments/payment_request_abort_test.html | 2 +- ..._alicepay_bobpay_charliepay_and_cards_test.html | 2 +- .../payments/payment_request_blob_url_test.html | 2 +- ...asic_card_with_modifier_optional_data_test.html | 4 +- ..._bobpay_and_basic_card_with_modifiers_test.html | 2 +- .../payment_request_bobpay_and_cards_test.html | 2 +- .../data/payments/payment_request_bobpay_test.html | 2 +- ...ayment_request_bobpay_ui_skip_preload_test.html | 2 +- .../payment_request_bobpay_ui_skip_test.html | 2 +- ...ment_request_can_make_payment_metrics_test.html | 2 +- ...request_can_make_payment_query_bobpay_test.html | 2 +- ...ent_request_can_make_payment_query_cc_test.html | 2 +- ...ayment_request_can_make_payment_query_test.html | 2 +- ...est_contact_details_and_free_shipping_test.html | 2 +- .../payment_request_contact_details_test.html | 2 +- .../data/payments/payment_request_debit_test.html | 2 +- .../payment_request_dynamic_shipping_test.html | 2 +- ...yment_request_email_and_free_shipping_test.html | 2 +- .../payment_request_email_and_phone_test.html | 2 +- .../data/payments/payment_request_email_test.html | 2 +- .../payment_request_empty_update_test.html | 2 +- ...ayment_request_extra_shipping_options_test.html | 2 +- .../payment_request_fail_complete_test.html | 2 +- .../payment_request_free_shipping_test.html | 2 +- ...ent_request_free_shipping_with_iframe_test.html | 2 +- .../data/payments/payment_request_id_test.html | 2 +- .../payments/payment_request_long_id_test.html | 2 +- .../payments/payment_request_metrics_test.html | 2 +- .../payments/payment_request_modifier_test.html | 2 +- .../payment_request_multiple_show_test.html | 4 +- ...ayment_request_name_and_free_shipping_test.html | 2 +- .../data/payments/payment_request_name_test.html | 2 +- .../payments/payment_request_no_shipping_test.html | 2 +- .../payment_request_no_update_with_test.html | 4 +- ...ent_request_payment_method_identifier_test.html | 2 +- ...yment_request_phone_and_free_shipping_test.html | 2 +- .../data/payments/payment_request_phone_test.html | 2 +- .../test/data/payments/payment_request_retry.html | 2 +- ...ment_request_retry_with_no_payment_options.html | 2 +- .../payment_request_retry_with_payer_errors.html | 2 +- ...request_retry_with_shipping_address_errors.html | 2 +- ...yment_request_shipping_address_change_test.html | 2 +- ...ent_request_shipping_address_instance_test.html | 2 +- .../payments/payment_request_show_promise.html | 4 +- .../payments/payment_request_show_twice_test.html | 2 +- .../payments/payment_request_update_with_test.html | 2 +- .../content_public/browser/test/util/DOMUtils.java | 2 + third_party/blink/renderer/core/dom/element.cc | 13 ++- .../renderer/core/frame/root_frame_viewport.cc | 9 +- .../scroll-into-view-scrolls-layout-viewport.html | 51 ------------ .../scroll-into-view-scrolls-viewport.html | 96 ++++++++++++++++++++++ 52 files changed, 159 insertions(+), 114 deletions(-) commit a3c635bb37ea2b4b3939c48a7c765bf43925ce56 Author: Peter Mayo <petermayo@chromium.org> Date: Fri Mar 15 21:51:31 2019 +0000 Code cleanup Remove hanging block intertwined with switch statement in compositor element selection code. Bug: None Change-Id: I7dc057101a939e2bbba0c2ef3f34bd3f7da15c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524979 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Peter Mayo <petermayo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641302} .../blink/renderer/core/animation/compositor_animations.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) commit d96da30a0dd94e4ddf0904764d8a2baae57259de Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Mar 15 21:47:24 2019 +0000 Allow downstream targets to intercept PWA intents. Bug: 914828 Change-Id: I3ff198f934a232c1080fe6c7b7dc86944b1c58ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525992 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#641301} chrome/android/java/src/org/chromium/chrome/browser/AppHooks.java | 7 +++++++ .../src/org/chromium/chrome/browser/webapps/WebappActivity.java | 3 +++ 2 files changed, 10 insertions(+) commit 5b5a85eca9285e8b09199484e49aa9dca8847354 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Mar 15 21:46:32 2019 +0000 [Media Controller] Add id to observer Adds a new method to the MediaControllerObserver that allows a client to observe which session the controller is currently bound to. Also removes a similar method from AudioFocusObserver which could not be reused and is not used anymore. This is for assistant so they can differentiate between the AssistantMediaSession and other sessions when controlling them. BUG=941578 Change-Id: I9ba74bad0ff0f394e653de2a9d9dde267d5f91e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521452 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641300} ash/media/media_controller.h | 2 + ash/media/media_notification_controller.h | 2 - ash/media/media_notification_item.h | 2 + .../browser/media/hardware_key_media_controller.h | 2 + .../media/media_internals_audio_focus_helper.h | 2 - services/media_session/audio_focus_manager.cc | 17 ++--- .../media_session/audio_focus_manager_unittest.cc | 55 -------------- services/media_session/media_controller.cc | 83 ++++++++++++++-------- services/media_session/media_controller.h | 15 +++- .../media_session/media_controller_unittest.cc | 67 +++++++++++++++++ .../public/cpp/test/audio_focus_test_util.cc | 6 -- .../public/cpp/test/audio_focus_test_util.h | 9 --- .../public/cpp/test/test_media_controller.cc | 20 ++++++ .../public/cpp/test/test_media_controller.h | 8 +++ .../media_session/public/mojom/audio_focus.mojom | 6 -- .../public/mojom/media_controller.mojom | 4 ++ 16 files changed, 176 insertions(+), 124 deletions(-) commit c5983e29cdad61723ea2caa40e547f7d217f1bd0 Author: Christian Fremerey <chfremer@chromium.org> Date: Fri Mar 15 21:45:43 2019 +0000 [Video Capture] Copy documentation from media::VideoFrameReceiver to video_capture::mojom::Receiver video_capture::mojom::Receiver did not yet have any documentation, because of redundancy with the equivalent C++ interface media::VideoFrameReceiver. The plan was to eventually move everything to video_capture::mojom::Receiver and delete media::VideoFrameReceiver. It however turned out infeasible to do this. This CL copies the (mostly redundant) documentation from more likely to be read. It also adds explanation in a class-level comment as for why these almost identical interfaces cannot be collapsed into one. media: :VideoFrameReceiver to video_capture::mojom::Receiver where it is Change-Id: I9d5da3f3c24018a0b69c24c9704a7b732443d6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509092 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641299} media/capture/video/video_frame_receiver.h | 13 ++++++--- services/video_capture/public/mojom/receiver.mojom | 34 ++++++++++++++++++++-- 2 files changed, 41 insertions(+), 6 deletions(-) commit 835066fce5e03cdf92248d3d3b51e7533bcbfacc Author: Natalie Chouinard <chouinard@chromium.org> Date: Fri Mar 15 21:43:57 2019 +0000 Enable histograms for RemoteSuggestionsDatabase Add LevelDBClient suffixes for the two ProtoDatabases in RemoteSuggestionsDatabase, so the metrics provided by default are actually logged. Having these histograms available will help us track the success of the migration from unique to shared Proto database. Bug: 941731 Change-Id: I9e978a9dbd4491b822f75230c9f1659b50ce10c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521599 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641298} tools/metrics/histograms/histograms.xml | 3 +++ 1 file changed, 3 insertions(+) commit be9d8e81e8c3ac82d25597e653d929dfff2d8ec1 Author: Matt Mueller <mattm@chromium.org> Date: Fri Mar 15 21:38:44 2019 +0000 Use a weakptr on the URLRequestHttpJob::OnHeadersReceivedCallback callback. Although this doesn't protect the out-params passed to NotifyHeadersReceived, it does prevent a case where the URLRequestHttpJob tries to access a null transaction_ if the callback is called immediately after the job is killed but before it is destroyed. Bug: 934588 Change-Id: I6d92e30e311e820d99dac3b438274ecd43fe544b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520215 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641297} net/url_request/url_request_http_job.cc | 8 +- services/network/network_context_unittest.cc | 250 +++++++++++++++++++++++++++ 2 files changed, 254 insertions(+), 4 deletions(-) commit 5e61d4cc36c8b9cef19af789020a7ae77fbceff1 Author: Aleks Totic <atotic@chromium.org> Date: Fri Mar 15 21:37:11 2019 +0000 [Sheriff] fix obsolete image baseline In https://chromium-review.googlesource.com/c/chromium/src/+/1495371 couple of baselines were not removed. Bug: 942580 Change-Id: I7f0a57be617d1fffd09ec58f11dbd3837420ed0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525153 Auto-Submit: Aleks Totic <atotic@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641296} third_party/blink/web_tests/TestExpectations | 3 +-- .../editing/pasteboard/paste-text-016-expected.png | Bin 20438 -> 0 bytes .../editing/pasteboard/paste-text-016-expected.png | Bin 6576 -> 0 bytes 3 files changed, 1 insertion(+), 2 deletions(-) Updated tag 'tree_truth' (was 4152f9787493)