Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 43375 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918690792733249072 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it5DaxCb/luci_context.147422785 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm240-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43a71fb63981d611 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: efc4aae1db85dcc317995306dfab3bd797dfab7c Roll src-internal 4928a6b80fa9..ce552ff5de4f (1 commits) chromium-internal-autoroll, Mon Mar 18 00:47:26 2019 +0000 e6a84baeab7918f9b53307432e257906f06c8afa worker: Rename GlobalScopeCreationParams::content_security_policy_parsed_headers Kenichi Ishibashi, Mon Mar 18 00:16:25 2019 +0000 98a21223adae514c0a9ea87a32a61f1e3ea4ed01 Roll src-internal 7010adb0fc99..4928a6b80fa9 (3 commits) chromium-internal-autoroll, Sun Mar 17 23:39:56 2019 +0000 3816656e07a2ed731f5855d3449772ba8d426be8 More of the renaming Team Drive to Shared Drive migration. Stuart Langley, Sun Mar 17 23:09:02 2019 +0000 efcf624b173ad4fc68c8597855972ebba4a944ac [Files app] - Add context menu test for MTP Luciano Pacheco, Sun Mar 17 23:01:52 2019 +0000 1690f398d43bac0d9ffd5915a780437d2a9188a3 Roll src-internal 29b3d75fe324..7010adb0fc99 (5 commits) chromium-internal-autoroll, Sun Mar 17 22:28:39 2019 +0000 f34afc5ab7930e80f78530b3c7c027a50bdb27bd Roll src/third_party/skia 72ef2d519a0e..895e1eedb420 (1 commits) chromium-autoroll, Sun Mar 17 21:59:58 2019 +0000 ec5a2ade9ff13cbd50c5b8de61c9093074638191 [Autofill] Implemented GetLabels() for address and contact forms. Caitlin Fischer, Sun Mar 17 21:04:35 2019 +0000 7055f9306618b86b5d5c3aa39e577e35dfa8f6bd Roll src-internal d5a741226f7e..29b3d75fe324 (1 commits) chromium-internal-autoroll, Sun Mar 17 20:37:20 2019 +0000 abc1fd51abe85756c0b872a8920d94aea0b033d6 Split GetFirstFocusableView() into two pieces and eliminate magic -1. Peter Kasting, Sun Mar 17 20:36:20 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit efc4aae1db85dcc317995306dfab3bd797dfab7c Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 18 00:47:26 2019 +0000 Roll src-internal 4928a6b80fa9..ce552ff5de4f (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4928a6b80fa9..ce552ff5de4f Created with: gclient setdep -r src-internal@ce552ff5de4f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Ic1d93e833f8ab6ed472692842290630c25889fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526490 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641499} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e6a84baeab7918f9b53307432e257906f06c8afa Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Mar 18 00:16:25 2019 +0000 worker: Rename GlobalScopeCreationParams::content_security_policy_parsed_headers This is a follow-up CL of https://crrev.com/c/1493694. |outside_content_security_policy_headers| is a better name for the field. Bug: 924043 Change-Id: Ifa65eeec8ec833e67d28435efc788db968e87794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525763 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#641498} .../renderer/core/workers/global_scope_creation_params.cc | 10 +++++----- .../blink/renderer/core/workers/global_scope_creation_params.h | 7 +++++-- third_party/blink/renderer/core/workers/worker_global_scope.cc | 4 ++-- .../renderer/core/workers/worker_or_worklet_global_scope.cc | 5 ++--- .../renderer/core/workers/worker_or_worklet_global_scope.h | 2 +- .../blink/renderer/core/workers/worklet_global_scope.cc | 4 ++-- .../modules/service_worker/service_worker_global_scope.cc | 2 +- 7 files changed, 18 insertions(+), 16 deletions(-) commit 98a21223adae514c0a9ea87a32a61f1e3ea4ed01 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 23:39:56 2019 +0000 Roll src-internal 7010adb0fc99..4928a6b80fa9 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7010adb0fc99..4928a6b80fa9 Created with: gclient setdep -r src-internal@4928a6b80fa9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Ic6444d5934a22f250c0a8aa99c380ddbf554ff69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526489 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641497} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3816656e07a2ed731f5855d3449772ba8d426be8 Author: Stuart Langley <slangley@google.com> Date: Sun Mar 17 23:09:02 2019 +0000 More of the renaming Team Drive to Shared Drive migration. Another CL migrating variable names, method names and comments from Team Drive to Shared Drive as requested by Drive team. Bug: 928637 Change-Id: Ife214baa6e9c7f637346f47e5c1f2dd3e49d3a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525252 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641496} ui/file_manager/base/js/volume_manager_types.js | 16 +++---- ui/file_manager/externs/volume_info.js | 4 +- .../file_manager/background/js/crostini.js | 4 +- .../background/js/crostini_unittest.js | 4 +- .../background/js/entry_location_impl.js | 6 +-- .../background/js/mock_volume_manager.js | 4 +- .../file_manager/background/js/volume_info_impl.js | 4 +- .../background/js/volume_manager_impl.js | 6 +-- .../background/js/volume_manager_unittest.js | 4 +- ui/file_manager/file_manager/common/js/util.js | 32 +++++++------- .../file_manager/foreground/css/file_types.css | 4 +- .../foreground/js/file_manager_commands.js | 6 +-- .../foreground/js/file_transfer_controller.js | 51 ++++++++++++---------- .../foreground/js/ui/directory_tree.js | 50 ++++++++++----------- .../file_manager/foreground/js/ui/location_line.js | 2 +- .../integration_tests/file_manager/background.js | 4 +- .../integration_tests/file_manager/context_menu.js | 6 +-- .../integration_tests/file_manager/metadata.js | 16 +++---- .../file_manager/share_and_manage_dialog.js | 6 +-- .../integration_tests/file_manager/transfer.js | 18 ++++---- ui/file_manager/integration_tests/test_util.js | 6 +-- 21 files changed, 128 insertions(+), 125 deletions(-) commit efcf624b173ad4fc68c8597855972ebba4a944ac Author: Luciano Pacheco <lucmult@chromium.org> Date: Sun Mar 17 23:01:52 2019 +0000 [Files app] - Add context menu test for MTP Change-Id: I21e66169ecb1e7bd2b3749ea904cd86bd561d6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516118 Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641495} .../file_manager/file_manager_browsertest.cc | 1 + .../file_manager/directory_tree_context_menu.js | 43 ++++++++++++++++++++++ 2 files changed, 44 insertions(+) commit 1690f398d43bac0d9ffd5915a780437d2a9188a3 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 22:28:39 2019 +0000 Roll src-internal 29b3d75fe324..7010adb0fc99 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/29b3d75fe324..7010adb0fc99 Created with: gclient setdep -r src-internal@7010adb0fc99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Iafb260c6d379e677e2c4c6c371712e643e252457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527552 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641494} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f34afc5ab7930e80f78530b3c7c027a50bdb27bd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 21:59:58 2019 +0000 Roll src/third_party/skia 72ef2d519a0e..895e1eedb420 (1 commits) https://skia.googlesource.com/skia.git/+log/72ef2d519a0e..895e1eedb420 git log 72ef2d519a0e..895e1eedb420 --date=short --no-merges --format='%ad %ae %s' 2019-03-17 reed@google.com lowp stages for load/stores and lerp-native Created with: gclient setdep -r src/third_party/skia@895e1eedb420 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I7c34fc241c92a1b5b838078e33b484fe7daf612d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527551 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641493} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ec5a2ade9ff13cbd50c5b8de61c9093074638191 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Sun Mar 17 21:04:35 2019 +0000 [Autofill] Implemented GetLabels() for address and contact forms. Made helper functions to extract names, emails, and phones from profiles. Added an ordering for LabelFormatters' field_types_for_labels_. Bug: http://crbug.com/936168 Change-Id: Idf830c4be658f6ee13a35da68af5ed59287d43f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516056 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641492} components/autofill/core/browser/BUILD.gn | 9 +- .../core/browser/address_form_label_formatter.cc | 11 +- .../address_form_label_formatter_unittest.cc | 175 +++++++++++++ .../core/browser/contact_form_label_formatter.cc | 78 +++++- .../core/browser/contact_form_label_formatter.h | 28 ++ .../contact_form_label_formatter_unittest.cc | 291 +++++++++++++++++++++ .../autofill/core/browser/label_formatter.cc | 48 +++- components/autofill/core/browser/label_formatter.h | 9 + .../core/browser/label_formatter_creator.cc | 94 ------- .../core/browser/label_formatter_creator.h | 49 ---- .../core/browser/label_formatter_unittest.cc | 22 ++ .../autofill/core/browser/label_formatter_utils.cc | 112 ++++++++ .../autofill/core/browser/label_formatter_utils.h | 86 ++++++ ...ittest.cc => label_formatter_utils_unittest.cc} | 2 +- 14 files changed, 863 insertions(+), 151 deletions(-) commit 7055f9306618b86b5d5c3aa39e577e35dfa8f6bd Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 20:37:20 2019 +0000 Roll src-internal d5a741226f7e..29b3d75fe324 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d5a741226f7e..29b3d75fe324 Created with: gclient setdep -r src-internal@29b3d75fe324 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I75b2b3f6fa3fde06d2eaab1eb818d8ce6e865b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527548 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641491} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit abc1fd51abe85756c0b872a8920d94aea0b033d6 Author: Peter Kasting <pkasting@chromium.org> Date: Sun Mar 17 20:36:20 2019 +0000 Split GetFirstFocusableView() into two pieces and eliminate magic -1. This is clearer to understand and facilitates later conversion to iterators. It also makes it more possible to change forward and backward searching to behave distinctly, which we may want to fix bug 942358. This makes one behavior change: GetNextFocusedView(.., false) will now be willing to return parent views where the child was the first child. This is symmetric with the "forward" behavior, makes more sense in the abstract, and I believe was simply an artifact of the original code trying to avoid overloading the meaning of "-1" (which would have meant "check all children" when this callsite meant "check no children"). I did not think deeply through how this change would affect callers in practice. Bug: 942358 Change-Id: Ie25208878db4e61dea2b39c6628575959c037544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525159 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641490} ui/views/controls/menu/menu_controller.cc | 56 ++++++++++++++++--------------- 1 file changed, 29 insertions(+), 27 deletions(-) commit 107efba2a9a4e4cc4028736411debe92c797ae72 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 20:35:00 2019 +0000 Roll src/third_party/skia 3ea586f9f959..72ef2d519a0e (1 commits) https://skia.googlesource.com/skia.git/+log/3ea586f9f959..72ef2d519a0e git log 3ea586f9f959..72ef2d519a0e --date=short --no-merges --format='%ad %ae %s' 2019-03-17 brianosman@google.com Suppress MSVC C4756 (constant arithmetic overflow) in fiddle examples Created with: gclient setdep -r src/third_party/skia@72ef2d519a0e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ie34a954e0544afb0dbecb5c96d44e82f5b46f82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526735 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641489} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fc0836fb331a28c03a88933b9d30f5db2e77ac15 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sun Mar 17 19:57:50 2019 +0000 Reland "[BGPT] Don't collect non-animation non-scroll element ids" This is a reland of 2313e474dbcf48dd8a7858206b6e3343f0f473f9 Was reverted because before we reverted the depended https://chromium-review.googlesource.com/c/chromium/src/+/1513736. Reland because the depended CL has been rewritten and relanded. Original change's description: > [BGPT] Don't collect non-animation non-scroll element ids > > Collecting non-animation element ids gave compositor wrong information > that they need to be handled by the compositor, causing non-composited > animation (caused by will-change: contents) on composited-layer failed > to start in BGPT mode. > > Also add virtual/disable-blink-gen-property-trees/transitions. > > Bug: 936912 > Change-Id: I3ff64a732920ef884d838064d2d3a005e8a50860 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512765 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641429} TBR=pdr@chromium.org,flackr@chromium.org Bug: 936912 Change-Id: If9688689ef6adefba3517c3f602b4a6b5ddafccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527550 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641488} .../core/paint/paint_property_tree_builder_test.cc | 27 +++++--- .../compositing/paint_artifact_compositor.cc | 12 +--- .../compositing/paint_artifact_compositor_test.cc | 72 +++++++++------------ .../graphics/paint/effect_paint_property_node.h | 6 ++ .../graphics/paint/transform_paint_property_node.h | 6 ++ .../platform/testing/paint_property_test_helpers.h | 25 +++++++ third_party/blink/web_tests/VirtualTestSuites | 6 ++ ...3d-transform-will-change-contents-expected.html | 11 ++++ ...ansition-3d-transform-will-change-contents.html | 28 ++++++++ .../transitions/README.txt | 2 + ...ransform-transitions-inside-iframe-expected.png | Bin 0 -> 3095 bytes 11 files changed, 134 insertions(+), 61 deletions(-) commit c742e2d0986a4bd46133b88371289fe527d775b9 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sun Mar 17 18:46:14 2019 +0000 [BGPT] Remove XXXPaintPropertyNode::IsRunningXXXAnimationOnCompositor() This is a rewritten version of https://chromium-review.googlesource.com/c/chromium/src/+/1513736. The functionality is equivalent, but this new CL is simpler and allows future new types of paint property change. Recent investigation and discussions made it clear that ComputedStyle::IsRunningXXXAnimationOnCompositor() methods actually reflect the animation status from the compositor. The previous plan about using them was wrong because it caused a chicken-and-egg problem: we wanted them to inform the compositor to start animations, but they actually came from the compositor after animations were started. Now use ComputedStyle::IsRunningXXXAnimationOnCompositor() only to ignore changes of animation values at blink side. Changes of the flags themselves no longer need to be handled by blink in any way. Bug: 935770 Change-Id: If4ecd501e318c75bc5ef5af8fa3933de27020450 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527204 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641487} .../paint/compositing/compositing_reason_finder.cc | 20 +++---- .../compositing/compositing_reason_finder_test.cc | 25 -------- .../renderer/core/paint/link_highlight_impl.cc | 1 - .../core/paint/link_highlight_impl_test.cc | 4 +- .../renderer/core/paint/object_paint_properties.h | 16 +++-- .../core/paint/paint_property_tree_builder.cc | 35 +++++------ .../core/paint/paint_property_tree_update_tests.cc | 6 +- .../blink/renderer/core/style/computed_style.cc | 8 --- .../core/style/computed_style_extra_fields.json5 | 12 ++++ .../renderer/core/style/computed_style_test.cc | 24 ++++++-- .../compositing/paint_artifact_compositor_test.cc | 68 +++++----------------- .../graphics/compositing/property_tree_manager.cc | 4 +- .../graphics/paint/clip_paint_property_node.h | 10 +++- .../graphics/paint/effect_paint_property_node.h | 61 +++++++------------ .../graphics/paint/scroll_paint_property_node.h | 10 +++- .../graphics/paint/transform_paint_property_node.h | 32 +++++----- .../platform/testing/paint_property_test_helpers.h | 32 ++++++++-- third_party/blink/web_tests/TestExpectations | 1 + .../animation-overlap-with-children-expected.txt | 16 ++++- 19 files changed, 178 insertions(+), 207 deletions(-) commit 6e45b4f4eadb60d9ec5f67d412649858cffbf69d Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 18:22:04 2019 +0000 Roll src-internal 5d9edd93be03..d5a741226f7e (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5d9edd93be03..d5a741226f7e Created with: gclient setdep -r src-internal@d5a741226f7e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I8e17951c09d60e66069d2a5e098833f34c30a476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527653 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641486} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fd7b44dd54fa594f4809b8546376061a959b6e2 Author: Christopher Cameron <ccameron@chromium.org> Date: Sun Mar 17 17:58:04 2019 +0000 MacPWAs: Fix non-english-keyboard shortcuts Keyboard NSEvents can take the path 1. -[RenderWidgetHostViewCocoa keyEvent] (app shim) 2. RenderWidgetHostViewMac::ForwardKeyboardEvent (browser) 3. Various callbacks, all using the same NSEvent pointer from [2], even though this may involve bouncing to the renderer process and back. 4. BrowserFrameMac::HandleKeyboardEvent (browser) 5. NativeWidgetMac::RedispatchKeyEvent (browser) 6. BridgedNativeWidgetHostImpl::RedispatchKeyEvent (app shim) 7. -[CommandDispatcher redispatchKeyEvent:] (app shim) We need the NSEvents from [1] and [7] to be identical. For an ordinary browser window, the pointers are the same. But for an app shim, we serialize to a NativeWebKeyboardEvent at [1]->[2] and deserialize at [5]->[6], and this serialization is broken. An ideal fix would be to save off the event at [1] with a token that can be retrieved at [6]. Such a fix would not be a good merge candidate. In -[ChromeCommandDispatcherDelegate prePerformKeyEquivalent], tell the BridgedNativeWidgetImpl to save the NSEvent. Then, at the next call to BridgedNativeWidgetImpl::RedispatchKeyEvent, see if the event received is similar to the one saved. If so, use the saved event. Note that the modified path is only taken for PWAs, because only PWAs will use the BridgedNativeWidgetImpl::RedispatchKeyEvent overload that doesn't take a NSEvent directly. This is not an ideal long-term solution, but it is a small enough patch to be merged. Bug: 942690 Change-Id: I276072d0e17cf78e8cab6607abbe38707c85f463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525839 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#641485} .../ui/cocoa/chrome_command_dispatcher_delegate.mm | 1 + ui/views_bridge_mac/bridged_native_widget_impl.h | 5 +++++ ui/views_bridge_mac/bridged_native_widget_impl.mm | 22 ++++++++++++++++++++++ 3 files changed, 28 insertions(+) commit 5cd124a4ac805b203eba1452b69a6a00949e2772 Author: Nico Weber <thakis@chromium.org> Date: Sun Mar 17 17:25:54 2019 +0000 Attempt to make WebCursorTest.CursorScaleFactor 1000x as fast. On the release swarming bots, cuts test time from 6s to 6ms, on the debug swarming bots, cuts test time from 30-60s to 33ms. TBR=bsep Bug: 942882 Change-Id: I2cc9782a740ab37639c0b8e4271f36cfa5063f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526618 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641484} content/common/cursors/webcursor_unittest.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 3800de243580b2dda158e9a068d76234a360dc32 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 16:52:39 2019 +0000 Roll src-internal 3b15c93f79a5..5d9edd93be03 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3b15c93f79a5..5d9edd93be03 Created with: gclient setdep -r src-internal@5d9edd93be03 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I1772f60416879d241265cfc1460274e9c4266181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526734 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641483} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c56acf942db00ec3668ed87f2be4c1ec5e443399 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 16:02:59 2019 +0000 Roll src/third_party/skia 143542fa28e9..3ea586f9f959 (1 commits) https://skia.googlesource.com/skia.git/+log/143542fa28e9..3ea586f9f959 git log 143542fa28e9..3ea586f9f959 --date=short --no-merges --format='%ad %ae %s' 2019-03-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src f4c60d43323d..ad85caa87461 (55 commits) Created with: gclient setdep -r src/third_party/skia@3ea586f9f959 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I759935430e1f68506ce4c68deee540de38874292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527544 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641482} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ad85caa874615a62149768ae7812d237e13e3352 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 13:24:02 2019 +0000 Roll src-internal 6bd42b9d6b56..3b15c93f79a5 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bd42b9d6b56..3b15c93f79a5 Created with: gclient setdep -r src-internal@3b15c93f79a5 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I6f92ad178375889fd6c76456e9da5c5a89c74bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527542 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641481} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f06536c88b8e551b2f473298175c5480d58ffe38 Author: Ian Swett <ianswett@chromium.org> Date: Sun Mar 17 12:25:52 2019 +0000 Roll src/net/third_party/quiche/src/ 348de99ee..f08778a58 (13 commits) https://quiche.googlesource.com/quiche.git/+log/348de99ee1f1..f08778a58e71 $ git log 348de99ee..f08778a58 --date=short --no-merges --format='%ad %ae %s' 2019-03-14 quiche-dev Pass data_size into QuicPacketCreator::CreateStreamFrame instead of calculating it inside the method and no longer special case the 0 length case, except the existing QUIC_BUG. 2019-03-14 bnc Add frame header and payload length argument to HttpDecoder::Visitor::OnHeadersFrameStart(). 2019-03-13 vasilvv Remove direct references to //base from shared QUIC code 2019-03-13 quiche-dev Use QuicMakeUnique where possible in quic_crypto_server_config.cc 2019-03-13 bnc Remove HttpDecoder::has_payload(). 2019-03-13 quiche-dev gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_connection_do_not_add_to_write_blocked_list_if_disconnected. 2019-03-13 quiche-dev Set packet type in quic_connection_test according to encryption levels. Also have some other minor test changes. 2019-03-13 quiche-dev gfe-relnote: In QUIC, do not close connection if received an in-order ACK with decreased largest_acked. Protected by gfe2_reloadable_flag_quic_tolerate_reneging. 2019-03-13 quiche-dev Remove unused QuicConnection::ValidateAckFrame. 2019-03-12 vasilvv Remove QuicString wrapper for std::string 2019-03-11 quiche-dev Use QuicVersionUsesCryptoFrames instead of checking against QUIC_VERSION_47 2019-03-11 quiche-dev Add ShouldUpdateExpectedConnectionIdLength to QuicFramer 2019-03-11 vasilvv Replace QuicString with std::string, pass 1 Created with: roll-dep src/net/third_party/quiche/src R=rch@chromium.org Change-Id: I8827206d9d718513b44441c20d82078b0ba7ecad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524982 Reviewed-by: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Ian Swett <ianswett@chromium.org> Cr-Commit-Position: refs/heads/master@{#641480} DEPS | 2 +- net/BUILD.gn | 2 -- net/quic/platform/impl/quic_file_utils_impl.h | 1 - net/quic/platform/impl/quic_flags_impl.h | 1 - net/quic/platform/impl/quic_flags_test.cc | 1 - net/quic/platform/impl/quic_hostname_utils_impl.h | 1 - .../platform/impl/quic_linux_socket_utils_test.cc | 1 - net/quic/platform/impl/quic_string_impl.h | 16 ------------ net/quic/platform/impl/quic_string_utils_impl.h | 1 - net/quic/platform/impl/quic_thread_impl.h | 1 - net/quic/quic_flags_list.h | 4 +++ .../p2p_quic_crypto_config_factory_impl.cc | 30 +++++++++++----------- .../adapters/p2p_quic_transport_impl.cc | 4 +-- .../adapters/p2p_quic_transport_test.cc | 30 +++++++++++----------- 14 files changed, 37 insertions(+), 58 deletions(-) commit c266297cb89c16b17f538681d5c02f4de98973db Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 12:00:38 2019 +0000 Roll src-internal 342fc4be7d44..6bd42b9d6b56 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/342fc4be7d44..6bd42b9d6b56 Created with: gclient setdep -r src-internal@6bd42b9d6b56 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I3aff30a9fe85cf9adc7e776c756cc378120602d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527541 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641479} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 06d3e0fe5a6d5e46d5a0d1a4ee6cd5b1ef2d1ed4 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 10:58:57 2019 +0000 Roll src-internal a74fac49f237..342fc4be7d44 (1 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a74fac49f237..342fc4be7d44 Created with: gclient setdep -r src-internal@342fc4be7d44 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Ie7fa93b521490f96a7ba33bab2b9b3593e349bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527348 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641478} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c58927ee59d5b38b981b1cd892ffa96705941445 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 10:13:47 2019 +0000 Roll src/third_party/skia e1f2a572cec0..143542fa28e9 (1 commits) https://skia.googlesource.com/skia.git/+log/e1f2a572cec0..143542fa28e9 git log e1f2a572cec0..143542fa28e9 --date=short --no-merges --format='%ad %ae %s' 2019-03-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@143542fa28e9 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ie18bc3a3471917e2b55dc025a9a4a493056f8f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527344 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641477} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eef180300f20ddb083cd8c79e72f4a33d912d889 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 09:52:56 2019 +0000 Roll src-internal e3189b81534f..a74fac49f237 (4 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e3189b81534f..a74fac49f237 Created with: gclient setdep -r src-internal@a74fac49f237 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Ifbbc19d481022c1936266b2f1dff28911ae809a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527343 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641476} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 92b18eb968891d19b29a8e7212d7cba9d4c3354a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 08:35:14 2019 +0000 Roll src/third_party/skia d95286de1dda..e1f2a572cec0 (1 commits) https://skia.googlesource.com/skia.git/+log/d95286de1dda..e1f2a572cec0 git log d95286de1dda..e1f2a572cec0 --date=short --no-merges --format='%ad %ae %s' 2019-03-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@e1f2a572cec0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I02ee44d63cb945dbc5567de86056f7ef831b2687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525476 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641475} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8389c47993bd27f28a51bdfbac68c97bc1ce66ec Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 07:30:15 2019 +0000 Roll src/third_party/spirv-headers/src 3beb2a037310..111a25e4ae45 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers.git/+log/3beb2a037310..111a25e4ae45 git log 3beb2a037310..111a25e4ae45 --date=short --no-merges --format='%ad %ae %s' 2019-03-17 johnkslang@users.noreply.github.com Merge pull request #99 from Naghasan/contact-update Created with: gclient setdep -r src/third_party/spirv-headers/src@111a25e4ae45 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-headers-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I32d94ed67264f403aac640610543252d485c745a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525477 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641474} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cc656f8e8e19b1b97f9a1b3c80389cc37a8e2fec Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 07:17:54 2019 +0000 Roll src/third_party/glslang/src f925eefb2147..80c36be4a9c5 (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/f925eefb2147..80c36be4a9c5 git log f925eefb2147..80c36be4a9c5 --date=short --no-merges --format='%ad %ae %s' 2019-03-17 johnkslang@users.noreply.github.com Merge pull request #1728 from alelenv/shaderrecord_fix Created with: gclient setdep -r src/third_party/glslang/src@80c36be4a9c5 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I067d54d1a8f878f2b8a5a21fda2e4499e21be54a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525478 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641473} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 122cc33de75ed7b65ac23e1838a346313d520ff1 Author: Aleks Totic <atotic@chromium.org> Date: Sun Mar 17 06:46:14 2019 +0000 Revert "NEL: Add SQLitePersistentReportingAndNELStore" This reverts commit 8c66199b51cc1f2c52f1b206823bc9054d6fa1bb. Reason for revert: Failed MSAN bots, use of uninitialized memory. Details at https://crbug.com/942889 Original change's description: > NEL: Add SQLitePersistentReportingAndNELStore > > This CL adds SQLitePersistentReportingAndNELStore which persists > NEL policies to disk in a SQLite database. It will eventually also store > Reporting clients and reports. > > The code is based on that of the SQLitePersistentCookieStore. > > It is not hooked up to anything yet (just unittests). > > Bug: 895821 > Change-Id: I99ea14ace6f9b7fecd6075b1be98647db80d2bcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504493 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641361} TBR=morlovich@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 895821 Change-Id: I505c3595d1b294be60af479d39f03f2edb1fe700 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526158 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641472} net/BUILD.gn | 13 - .../sqlite_persistent_reporting_and_nel_store.cc | 567 --------------------- .../sqlite_persistent_reporting_and_nel_store.h | 62 --- ..._persistent_reporting_and_nel_store_unittest.cc | 339 ------------ .../network_error_logging_service.cc | 55 +- .../network_error_logging_service.h | 54 -- 6 files changed, 34 insertions(+), 1056 deletions(-) commit 513560b62d335f7c98a7943ef10dc183d67717ef Author: Aleks Totic <atotic@chromium.org> Date: Sun Mar 17 06:33:54 2019 +0000 Revert "Various refactoring in TabStripModel tests." This reverts commit efad090bb9b9a7e115c9075e2118e4979b0a6ad3. Reason for revert: runtime error: control flow integrity check for type 'content::TestRenderViewHost https://crbug.com/942892 Original change's description: > Various refactoring in TabStripModel tests. > > This patch refactors tab_strip_model_unittest.cc and some associated > files in several ways: > * Removes ChromeRenderViewHostTestHarness as a superclass of > TabStripModelTest. Only one test was relying on anything other than > TestingProfile; those dependencies are all made explicit. This > speeds up the suite by about 30% (~5000 ms runtime vs. ~7000ms > before this patch). > * Changes TestTabStripModelDelegate::RunUnloadListenerBeforeClosing to > return false, and deletes subclasses that exist solely to override > that method (all of them, except TabStripDummyDelegate, which is > renamed to UnloadListenerTabStripModelDelegate). > * Moved several helper classes to be defined immediately before the > test that uses them. > * Deletes member variables from MockTabStripModelObserver, which are > unused. > * Fixes lint errors and cleans up unused includes. > > Change-Id: I3d70fd3c6013ea06b17146f8f551bb12510fadf9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515904 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641358} TBR=fdoray@chromium.org,erikchen@chromium.org,bsep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I3fd41245f3ce09dbb3bb9a3d2913dc034fcd7b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526160 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641471} .../tab_lifecycle_unit_source_unittest.cc | 18 +- .../resource_coordinator/tab_manager_unittest.cc | 9 +- .../tab_strip_model_stats_recorder_unittest.cc | 24 +- chrome/browser/ui/tabs/tab_strip_model_unittest.cc | 400 ++++++++++----------- .../ui/tabs/test_tab_strip_model_delegate.cc | 4 +- 5 files changed, 227 insertions(+), 228 deletions(-) commit 8684ecde85b4aff01990cd932a72e050958b20ee Author: Aleks Totic <atotic@chromium.org> Date: Sun Mar 17 06:32:54 2019 +0000 Revert "Ash Tray: Fix tray bubble opening on another display." This reverts commit 464d6f6e5243d9b754cd2caa629fd83f3b3a6ec6. Reason for revert: stack use after out of scope. https://crbug.com/942890 Original change's description: > Ash Tray: Fix tray bubble opening on another display. > > An off-by-one error caused the anchor bounds of the bubble to be inside > the bounds of the next display rather than the current display, causing > the bubble to be shown on the wrong display. > > This regression was caused by http://crrev/c/1474278. > > TEST=manually verified & new unit test case > BUG=937420 > > Change-Id: I6a248a785ea1ee36bdbb8ab75853efba71938272 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526383 > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641288} TBR=xiyuan@chromium.org,kaznacheev@chromium.org,msw@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937420 Change-Id: Ib3b61fe577d366d9c85c4498ded1af13f5e38ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526159 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641470} ash/extended_desktop_unittest.cc | 15 +++-------- ash/shelf/shelf.cc | 9 +++---- .../unified/unified_slider_bubble_controller.cc | 6 +---- ash/system/unified/unified_system_tray_bubble.cc | 6 +---- ash/system/unified/unified_system_tray_unittest.cc | 29 ---------------------- 5 files changed, 9 insertions(+), 56 deletions(-) commit 7f044421f9feca69319cf0f384539b4b4b233a14 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 06:16:22 2019 +0000 Roll src-internal 11a259f6c925..e3189b81534f (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11a259f6c925..e3189b81534f Created with: gclient setdep -r src-internal@e3189b81534f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I4027b1d3300529cb5b7c934505ffb78608086e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525475 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641469} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f7abc8473c616fecfc2f4d43851ba3f39f59a717 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 05:06:41 2019 +0000 Roll src-internal 8bfa2d484a94..11a259f6c925 (3 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8bfa2d484a94..11a259f6c925 Created with: gclient setdep -r src-internal@11a259f6c925 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Icf497789ba77d5c2383d5df47a6047618d637496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527218 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641468} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 374c6085432408ba9969f0805c0abc9da59f5d3c Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sun Mar 17 03:55:01 2019 +0000 Roll src-internal 2277de8e59f0..8bfa2d484a94 (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2277de8e59f0..8bfa2d484a94 Created with: gclient setdep -r src-internal@8bfa2d484a94 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I1babaa08691309e236ef0e792f7995d4ed9b79df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527210 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641467} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 074a7d40d8b472f2745430c25030f1575cda77fd Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Sun Mar 17 03:11:00 2019 +0000 Updating trunk VERSION from 3736.0 to 3737.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I8b7c5a2e1848cae9704863be0a43ec182970f25b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526619 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641466} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4f901e61b7166f04dcdbbadd9715862ace5680d4 Author: Nico Weber <thakis@chromium.org> Date: Sun Mar 17 02:44:37 2019 +0000 Shard net_unittests 4x on win/asan bots after libc++ switch. TBR=thomasanderson@chromium.org Bug: 942881 Change-Id: I9e78c87c68c51bba613ff1b08bbdb750c5000810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526617 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641465} testing/buildbot/chromium.clang.json | 6 ++++-- testing/buildbot/chromium.memory.json | 3 ++- testing/buildbot/test_suite_exceptions.pyl | 15 +++++++++++++++ 3 files changed, 21 insertions(+), 3 deletions(-) commit ea9077b3af407be0e97766f16f773703edf4627b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 01:27:41 2019 +0000 Roll src/third_party/skia e91825a07a21..d95286de1dda (1 commits) https://skia.googlesource.com/skia.git/+log/e91825a07a21..d95286de1dda git log e91825a07a21..d95286de1dda --date=short --no-merges --format='%ad %ae %s' 2019-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f06076396afa..38e282570676 (4 commits) Created with: gclient setdep -r src/third_party/skia@d95286de1dda The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I103da327122b2bda562fce4e790178c2b507b116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527206 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641464} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 44928402a408282984c5a9cadf49cc23187f4634 Author: Alex Danilo <adanilo@chromium.org> Date: Sun Mar 17 00:19:22 2019 +0000 Remove incorrect image/svg+xml MAGIC_NUMBER The MIME sniffing code that inspects the start of a content stream uses arrays of magic numbers with the expected MIME type when trying to work out the correct type. This CL removes the magic number that matched an incorrect XML start pattern that incorrectly identifies an SVG file. this to re-appear. Bug: 940336 Tests: Manually checked in ChromeOS File Viewer, don't expect Change-Id: I34daf5662202999deaf1087f27b786bba7d5e2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525581 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641463} net/base/mime_sniffer.cc | 1 - 1 file changed, 1 deletion(-) commit bf2793b522a5f9a7b9c0f7a429b5107790bfaa2c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sun Mar 17 00:11:22 2019 +0000 Roll src/third_party/skia 90155edf140b..e91825a07a21 (1 commits) https://skia.googlesource.com/skia.git/+log/90155edf140b..e91825a07a21 git log 90155edf140b..e91825a07a21 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 reed@google.com add animated version of mixer gm Created with: gclient setdep -r src/third_party/skia@e91825a07a21 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I962b3d3259ac4e1442a47818256a7c3a9d8e2f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526179 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641462} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e345c2296047a92754a846de7f2f26d9e4d727eb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 23:53:43 2019 +0000 Roll src/third_party/chromite 4be2437d7ee0..f9f298eb11ce (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/4be2437d7ee0..f9f298eb11ce git log 4be2437d7ee0..f9f298eb11ce --date=short --no-merges --format='%ad %ae %s' 2019-03-16 dburger@chromium.org Remove link builders. Created with: gclient setdep -r src/third_party/chromite@f9f298eb11ce The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I13808ab7a078804fcbb090bd9f983d08629108a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527203 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641461} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7eaea36b3ce4cd172f0ba2b245a3cd42cba38ed6 Author: Martin Kreichgauer <martinkr@google.com> Date: Sat Mar 16 23:28:01 2019 +0000 //device/fido: add more of the PIN request UI - Add sheet views for soft block, hard block, and key removed errors. - Add a sheet view asking for a second tap after entering a PIN. - Display an error if obtaining the PIN token fails. Bug: 870892 Change-Id: I656aef65efd0ac08d0a246129406b1b6e4cac408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507124 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#641460} chrome/app/generated_resources.grd | 23 ++++ .../authenticator_client_pin_entry_sheet_view.cc | 5 +- .../authenticator_client_pin_entry_view.cc | 1 + .../ui/views/webauthn/sheet_view_factory.cc | 20 +++ chrome/browser/ui/webauthn/sheet_models.cc | 153 ++++++++++++++++++--- chrome/browser/ui/webauthn/sheet_models.h | 45 ++++++ .../webauthn/authenticator_request_dialog_model.cc | 29 +++- .../webauthn/authenticator_request_dialog_model.h | 16 +++ .../chrome_authenticator_request_delegate.cc | 15 +- content/browser/webauth/authenticator_impl.cc | 19 ++- .../authenticator_request_client_delegate.h | 1 + 11 files changed, 287 insertions(+), 40 deletions(-) commit 0b3619ce1293c34e868a9bc75ecc1f13203ceda8 Author: Meilin Wang <meilinw@google.com> Date: Sat Mar 16 23:26:41 2019 +0000 assistant: add more information to log in autotest private APIs. This change adds AssistantAllowedState to the log message to help with debugging autotest/tast tests failures. Misc: Used SetWhitelistedPref helper function in AutotestPrivateSetAssistantEnabled to avoid repeated pref validation. BUG=None TEST=browser_tests modified in this CL. Change-Id: Ie325de646aaa682b257397c6c311ec42eda7d7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521473 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641459} .../autotest_private/autotest_private_api.cc | 31 ++++++++++++---------- .../extensions/api_test/autotest_private/test.js | 6 ++--- 2 files changed, 20 insertions(+), 17 deletions(-) commit 081e0701987adc17d6555f4cbcb27e250a29c486 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 16 22:15:57 2019 +0000 Roll src-internal 1d512824c7e8..2277de8e59f0 (19 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d512824c7e8..2277de8e59f0 Created with: gclient setdep -r src-internal@2277de8e59f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: If2e98e954d152a2140d5c3a9b5f18e2f376dd176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526178 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641458} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6b067103e2a68b3c7d69dd1f221de6d872bd2b20 Author: Adam Langley <agl@chromium.org> Date: Sat Mar 16 21:18:05 2019 +0000 webauthn: add a couple of PIN tests for other UV preferences. Change-Id: Idedf9ab93bb4bfdf3ac00856bd5bbc258389bc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504336 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#641457} .../browser/webauth/authenticator_impl_unittest.cc | 43 ++++++++++++++++++++++ 1 file changed, 43 insertions(+) commit 0002f97ce0bcc883c145952598caecc3c85b2185 Author: Thomas Anderson <thomasanderson@chromium.org> Date: Sat Mar 16 21:06:09 2019 +0000 Revert "[BGPT] Remove XXXPaintPropertyNode::IsRunningXXXAnimationOnCompositor()" This reverts commit a7a7e28d7e04442e9668ff725cb2c36ae8686c9c. Reason for revert: Causing build failure on win-google-rel: https://ci.chromium.org/p/chrome/builders/ci/win-google-rel/525 Original change's description: > [BGPT] Remove XXXPaintPropertyNode::IsRunningXXXAnimationOnCompositor() > > Recent investigation and discussions made it clear that > ComputedStyle::IsRunningXXXAnimationOnCompositor() methods actually > reflect the animation status from the compositor. The previous > plan about using them was wrong because it caused a chicken-and-egg > problem: we wanted them to inform the compositor to start animations, > but they actually came from the compositor after animations were > started. > > Now use ComputedStyle::IsRunningXXXAnimationOnCompositor() only to > ignore changes of animation values at blink side. Changes of the flags > themselves no longer need to be handled by blink in any way. > > Bug: 935770 > Change-Id: I2523b8b9d2b6d57dcea19dc020d95ebe66a38c9a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513736 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641421} TBR=wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Ic85569b888118dcac7c97438ec2f0947876dcb8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527120 Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641456} .../paint/compositing/compositing_reason_finder.cc | 20 ++-- .../compositing/compositing_reason_finder_test.cc | 25 +++++ .../renderer/core/paint/link_highlight_impl.cc | 1 + .../core/paint/link_highlight_impl_test.cc | 4 +- .../renderer/core/paint/object_paint_properties.h | 31 +++--- .../core/paint/paint_property_tree_builder.cc | 74 +++++++------ .../core/paint/paint_property_tree_builder.h | 6 +- .../core/paint/paint_property_tree_update_tests.cc | 6 +- .../renderer/core/paint/pre_paint_tree_walk.cc | 20 ++-- .../blink/renderer/core/style/computed_style.cc | 8 ++ .../core/style/computed_style_extra_fields.json5 | 12 -- .../renderer/core/style/computed_style_test.cc | 24 +--- third_party/blink/renderer/platform/BUILD.gn | 1 - .../compositing/paint_artifact_compositor_test.cc | 68 +++++++++--- .../graphics/compositing/property_tree_manager.cc | 4 +- .../graphics/paint/clip_paint_property_node.h | 19 ++-- .../graphics/paint/effect_paint_property_node.h | 66 +++++++++-- .../graphics/paint/paint_property_change.h | 122 --------------------- .../platform/graphics/paint/paint_property_node.h | 17 ++- .../graphics/paint/scroll_paint_property_node.h | 19 ++-- .../graphics/paint/transform_paint_property_node.h | 37 +++++-- .../platform/testing/paint_property_test_helpers.h | 32 +----- third_party/blink/web_tests/TestExpectations | 1 - .../animation-overlap-with-children-expected.txt | 16 +-- 24 files changed, 304 insertions(+), 329 deletions(-) commit 3c9906fc334a6169e371b089f96c5ee6134ad41d Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat Mar 16 21:03:51 2019 +0000 Revert "[BGPT] Don't collect non-animation non-scroll element ids" This reverts commit 2313e474dbcf48dd8a7858206b6e3343f0f473f9. Reason for revert: The depended CL https://chromium-review.googlesource.com/c/chromium/src/+/1513736 caused compile failure on several bots. Original change's description: > [BGPT] Don't collect non-animation non-scroll element ids > > Collecting non-animation element ids gave compositor wrong information > that they need to be handled by the compositor, causing non-composited > animation (caused by will-change: contents) on composited-layer failed > to start in BGPT mode. > > Also add virtual/disable-blink-gen-property-trees/transitions. > > Bug: 936912 > Change-Id: I3ff64a732920ef884d838064d2d3a005e8a50860 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512765 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641429} TBR=flackr@chromium.org,wangxianzhu@chromium.org,pdr@chromium.org Change-Id: Iaea65ea9fd2b798c6434e6505521bd9ff545e2ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 936912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527165 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641455} .../core/paint/paint_property_tree_builder_test.cc | 27 +++----- .../compositing/paint_artifact_compositor.cc | 12 +++- .../compositing/paint_artifact_compositor_test.cc | 72 ++++++++++++--------- .../graphics/paint/effect_paint_property_node.h | 6 -- .../graphics/paint/transform_paint_property_node.h | 6 -- .../platform/testing/paint_property_test_helpers.h | 25 ------- third_party/blink/web_tests/VirtualTestSuites | 6 -- ...3d-transform-will-change-contents-expected.html | 11 ---- ...ansition-3d-transform-will-change-contents.html | 28 -------- .../transitions/README.txt | 2 - ...ransform-transitions-inside-iframe-expected.png | Bin 3095 -> 0 bytes 11 files changed, 61 insertions(+), 134 deletions(-) commit b2119e130bb1ba31e308fd62c61ba5fcf733198d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 16 19:41:45 2019 +0000 Update V8 to version 7.5.59. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c35de7d0..f413181b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I744852d9d5204a8f8056d99613b9a245ca449217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527065 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641454} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 781e496e366ce508c2e16fa1c2e0c3ed110b8e2e Author: Wei Li <weili@chromium.org> Date: Sat Mar 16 19:06:43 2019 +0000 Remove unused GetTooltipTextOrigin() in View The API GetTooltipTextOrigin() is not used, so we remove it. Also, tooltip_text() in ImageViewBase seems to be a duplicate of GetTooltipText(), so remove it as well. BUG=941799 Change-Id: Id61c5e8ad172811f8941dedf2a2bb8737e44f17c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524693 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#641453} chrome/browser/ui/views/tabs/tab.cc | 6 --- chrome/browser/ui/views/tabs/tab.h | 2 - .../views/notification_header_view.cc | 2 +- ui/views/controls/image_view_base.cc | 2 +- ui/views/controls/image_view_base.h | 3 +- ui/views/controls/table/table_view.cc | 52 +++++----------------- ui/views/controls/table/table_view.h | 9 ---- ui/views/view.cc | 4 -- ui/views/view.h | 5 --- 9 files changed, 13 insertions(+), 72 deletions(-) commit 19f53f022fbe228cf62942981a4205ea08c5e2ac Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Sat Mar 16 19:02:43 2019 +0000 ozone/wayland: Clean up WaylandCursor This CL makes a code cleanup in WaylandCursor class: - Remove unneeded/unused header includes - Switch to forward declarations instead of header includes where possible - Fix lint errors Bug: 578890 Change-Id: I481723749b1c7ddb5dcd7d4569d3517be8a924ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525104 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#641452} ui/ozone/platform/wayland/wayland_cursor.cc | 11 ++++------- ui/ozone/platform/wayland/wayland_cursor.h | 4 +++- 2 files changed, 7 insertions(+), 8 deletions(-) commit 833d12e61aa13bb59a4c75db9dc8062871bd7c2c Author: Toni Barzic <tbarzic@chromium.org> Date: Sat Mar 16 18:42:13 2019 +0000 md_login: Do not preload gaia screen during initialization While preloading GAIA screen makes sense for add-user flow, this might cause issues when OOBE UI is required to initially show another screen. For example, public account login might require the user to accept ToS before entering the session. If public session login timing conincides with md_login.js initialization, gaia screen UI might trump over the Terms of Service screen, and break the login flow. (Note that for public sessions, new user login, which might show terms of service, does not require user to enter credentials, and thus bypasses GAIA screen). Fixes race in user_affiliation_browsertest.cc, where tests started to wait for LOCK_OR_LOGIN_WEBUI_VISIBLE after views login screen was shown (previously, the test would get unblocked by the notification sent by removed showAddUser call) BUG=938973 TEST=set up public session policy with auto login delay of 3s and public account user policy with TermsOfServiceURL policy set Verify that public session auto login (ToS screen in paericular) does not get hijacked by add user screen - repeated with few reboots, and restart uis Change-Id: Ia45f554435d2ca8a88eed9b88031a7339b1d38eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524883 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#641451} .../chromeos/login/ui/login_display_host_common.cc | 12 +----------- .../chromeos/policy/user_affiliation_browsertest.cc | 18 ++++++++++++++---- chrome/browser/resources/chromeos/login/md_login.js | 3 --- .../ui/webui/chromeos/login/gaia_screen_handler.cc | 13 ++++++++----- .../ui/webui/chromeos/login/gaia_screen_handler.h | 7 +++++-- 5 files changed, 28 insertions(+), 25 deletions(-) commit 7c3e4ef1dd3d35e57eae5bd5309bf4e6983fc24c Author: Tom Anderson <thomasanderson@chromium.org> Date: Sat Mar 16 18:20:04 2019 +0000 Switch Windows to build with in-tree libc++ Design document: https://docs.google.com/document/d/1VPxepzuyWbXFzv1VpkSKEn0wPvSUffpcaOLislhcwrA/edit?usp=sharing chromium-dev@ announcement: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/LqlnZ8sWcME BUG=801780 R=thakis Change-Id: Id60ba267d533b3c54ecc5d72852f7a16220fe244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1465168 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641450} build/config/c++/c++.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d10df99696f6792e9bb3403054ba3024bb31df4 Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Sat Mar 16 18:17:33 2019 +0000 ozone/wayland: Fix cursor regression when running in Weston After crrev.com/c/1503374 regressions have been observed when running chromium on Weston compositor. This cursor basically remains with its default shape regardless the view is under it (link, text, etc). This CL fixes it by adding back the wl_surface::damage() call before committing the cursor surface. Bug: 942732 Change-Id: Ic96d6ee209424838f09e29a5a9eedff0e1591c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526465 Reviewed-by: Maksim Sisov <msisov@igalia.com> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#641449} ui/ozone/platform/wayland/wayland_cursor.cc | 2 ++ 1 file changed, 2 insertions(+) commit 3ef1d15c0ef471aa851042200b69cc7ff527cdc8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 17:50:41 2019 +0000 Roll src/third_party/skia f3f7059cb736..90155edf140b (1 commits) https://skia.googlesource.com/skia.git/+log/f3f7059cb736..90155edf140b git log f3f7059cb736..90155edf140b --date=short --no-merges --format='%ad %ae %s' 2019-03-16 reed@google.com add bench for mixers Created with: gclient setdep -r src/third_party/skia@90155edf140b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I14ca7bf3e86dfb5e58ea94133e524afcbf69d140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527048 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641448} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 15f5878070bb887040eccdbea9769c81ef6078b5 Author: Austin Eng <enga@chromium.org> Date: Sat Mar 16 16:30:28 2019 +0000 Implement WebGPU GPUQueue creation This patch adds the creation of GPUQueue from GPUDevice but does not yet implement any GPUQueue methods. Bug: 941543 Change-Id: Ia721532b142bc50bf261c42391426b9b1ef3279e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521239 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641447} .../blink/renderer/modules/modules_idl_files.gni | 1 + third_party/blink/renderer/modules/webgpu/BUILD.gn | 2 ++ .../blink/renderer/modules/webgpu/gpu_device.cc | 10 ++++++++- .../blink/renderer/modules/webgpu/gpu_device.h | 3 +++ .../blink/renderer/modules/webgpu/gpu_device.idl | 2 ++ .../blink/renderer/modules/webgpu/gpu_queue.cc | 26 ++++++++++++++++++++++ .../blink/renderer/modules/webgpu/gpu_queue.h | 25 +++++++++++++++++++++ .../blink/renderer/modules/webgpu/gpu_queue.idl | 10 +++++++++ 8 files changed, 78 insertions(+), 1 deletion(-) commit 50138d7ffe5ec7edf57a62197e5ca9adbd982a7a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 16:27:24 2019 +0000 Roll Fuchsia SDK from 7079afd6a928 to 8506a2a60f1a The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I08fbe11287eccfee9e135ef335a49eced259b9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527045 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641446} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit f38a390ece1f055f4e65b411d1f4519929bd14bc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 16:26:44 2019 +0000 Roll src/third_party/skia 5ba22f3131b8..f3f7059cb736 (4 commits) https://skia.googlesource.com/skia.git/+log/5ba22f3131b8..f3f7059cb736 git log 5ba22f3131b8..f3f7059cb736 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader faed9d31b44d..4af8826ee423 (9 commits) 2019-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 558a982945cf..f4c60d43323d (337 commits) 2019-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 de52ca373d98..f06076396afa (3 commits) 2019-03-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 71673c81fb1e..faed9d31b44d (1 commits) Created with: gclient setdep -r src/third_party/skia@f3f7059cb736 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I79dda3cf26b24e7fac8ff61d734e236cdd9e1056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527046 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641445} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ebd236b88ef087c72a9794fdc5f713ca876ca078 Author: Adam Langley <agl@chromium.org> Date: Sat Mar 16 16:24:14 2019 +0000 device/fido: move UV mapping into request handlers. This change moves the mapping of Webauthn's ternary UV preference to CTAP2's binary value into the request handlers. This puts it next to the logic that deals with PIN support. Change-Id: I3c35e78ceeee78651d3bfa9b4dd48eacb2118601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504335 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#641444} .../browser/webauth/authenticator_impl_unittest.cc | 14 ++-- device/fido/ctap_get_assertion_request.h | 2 +- device/fido/ctap_make_credential_request.h | 2 +- device/fido/fido_authenticator.cc | 11 ++++ device/fido/fido_authenticator.h | 12 ++++ device/fido/fido_device_authenticator.cc | 66 ++++++++----------- device/fido/fido_device_authenticator.h | 7 ++ device/fido/get_assertion_request_handler.cc | 57 +++++++++-------- device/fido/get_assertion_task.cc | 7 +- device/fido/make_credential_request_handler.cc | 74 ++++++++++------------ device/fido/make_credential_task.cc | 7 +- 11 files changed, 139 insertions(+), 120 deletions(-) commit da83a4c6487505841ff7fd18ee281ffd23ada77e Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 16 15:36:41 2019 +0000 Update V8 to version 7.5.58. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aadbf465..c35de7d0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0a10660c5ce892e444bae1042c9ee6ee0cfaa151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527061 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641443} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e0a167d38a1caa4e4b056c5b317b38b2b19bb7b0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 15:25:55 2019 +0000 Roll src/third_party/skia 3d42a0521d12..5ba22f3131b8 (2 commits) https://skia.googlesource.com/skia.git/+log/3d42a0521d12..5ba22f3131b8 git log 3d42a0521d12..5ba22f3131b8 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-16 kjlubick@google.com Clean up some types in SkFont Created with: gclient setdep -r src/third_party/skia@5ba22f3131b8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I1659ebe51c78568daadeced08f13510aeab546e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527042 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641442} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit affd77b6fb740997879eb6c21cbc60824d6f988f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 13:53:11 2019 +0000 Roll src/third_party/skia f34d0c79dc6c..3d42a0521d12 (1 commits) https://skia.googlesource.com/skia.git/+log/f34d0c79dc6c..3d42a0521d12 git log f34d0c79dc6c..3d42a0521d12 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 halcanary@google.com Examples: Two changes from kevin Created with: gclient setdep -r src/third_party/skia@3d42a0521d12 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I8bb96373f08f59417d14727ce2d648233aab2058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526400 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641441} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a71f5186b8cf120f2c7d9868aee266a5c2f0fe1d Author: Adam Rice <ricea@chromium.org> Date: Sat Mar 16 10:36:44 2019 +0000 Add functionality to StreamThenPromise() ReadableStreamNative needs some extra functionality from StreamThenPromise(): * Support the single argument form of Then(). The |on_rejected| argument is now optional. * Behave as Catch() by setting the |on_fulfilled| argument to nullptr. * Return the return value from Then() instead of void. Only a Promise resolving to undefined can be created due to the StreamScriptFunction API having no provision for a return value, but this is sufficient to implement ReadableStream. BUG=902633 Change-Id: I44f0ba0109568c8fd09882e2f1f05ba50816364a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523214 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641440} .../core/streams/stream_script_function.cc | 31 +++++++++++++++------- .../renderer/core/streams/stream_script_function.h | 12 +++++---- 2 files changed, 29 insertions(+), 14 deletions(-) commit 0a7e34d2bb1e5ee86c19832cd2080d50482b9402 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 10:29:54 2019 +0000 Roll src/third_party/swiftshader 845cb5e1e729..4af8826ee423 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/845cb5e1e729..4af8826ee423 git log 845cb5e1e729..4af8826ee423 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 swiftshader.regress@gmail.com Regres: Update test lists @ 845cb5e1 Created with: gclient setdep -r src/third_party/swiftshader@4af8826ee423 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I3ebdcb65a5b2b3fd22892e442d2e78f011046e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526397 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641439} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ee3e1d2a538f5659c3ad887ea5de95d31b9c8a72 Author: Austin Eng <enga@chromium.org> Date: Sat Mar 16 09:41:53 2019 +0000 Don't create a WebGPUGraphicsContext3DProvider if use_dawn = false. The WebGPUImplementation requires Dawn, so it should not be possible to create a WebGPU context if Dawn is not available. Bug: 877147 Change-Id: I09732f03dafe152ea3b35ff3e9d134a9a1451aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521230 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641438} content/renderer/renderer_blink_platform_impl.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit db028d129fa8b84fa9e7fc5d069e0b582d172dca Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 16 09:19:14 2019 +0000 Update V8 to version 7.5.57. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b17b455a..aadbf465 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84c51aa5867ba469b967f533375d3dbe70da1158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526890 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641437} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0326117220736e61d3675c14edd640e9abbf8554 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 09:18:03 2019 +0000 Roll src/third_party/chromite 9d6e19d6ef05..4be2437d7ee0 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/9d6e19d6ef05..4be2437d7ee0 git log 9d6e19d6ef05..4be2437d7ee0 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@4be2437d7ee0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I90b820a2121b317c65a06d046bab42d499eab0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526532 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641436} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1de668715021a2a9789c47c0824e3be2cd778548 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 09:17:13 2019 +0000 Roll src/third_party/swiftshader f0d22ad90891..845cb5e1e729 (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f0d22ad90891..845cb5e1e729 git log f0d22ad90891..845cb5e1e729 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 chrisforbes@google.com Fix stencil state plumbing 2019-03-16 chrisforbes@google.com Propagate image view clear aspect mask to image clear 2019-03-16 chrisforbes@google.com Add support for OpFRem 2019-03-16 chrisforbes@google.com Add support for OpFMod 2019-03-16 chrisforbes@google.com Add support for OpInBoundsAccessChain Created with: gclient setdep -r src/third_party/swiftshader@845cb5e1e729 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/128715612,chromium:b/128715612,chromium:b/126873455,chromium:b/126873455,chromium:b/128690261,chromium:b/127950082 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id93fa7e51311b537163867d967b549533a9a8e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526395 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641435} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a34ffea07eb138cb613aa18919fc5952d90a3b41 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 09:04:43 2019 +0000 Roll Fuchsia SDK from 3fd87c335a94 to 7079afd6a928 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib538248188d1c24ab1f156b0f9b6c1e8b61c87b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526392 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641434} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit eb961909628cc123245ed1516f9808f3cb4378c6 Author: Min Qin <qinmin@chromium.org> Date: Sat Mar 16 08:08:22 2019 +0000 Warm up the network service process on Android This CL warms up the child process connection to the network service when it is running OOP. This will hopefully reduce the delay of the first navigation commit. BUG=932566 Change-Id: I40494c499aeb4f6cd47032adee078170075f434d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516724 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641433} .../chromium/android_webview/AwBrowserProcess.java | 2 +- .../browser/customtabs/CustomTabsConnection.java | 2 +- .../chrome/browser/init/AsyncInitTaskRunner.java | 6 ++- .../preferences/ChromePreferenceManager.java | 7 +++ .../chrome/browser/util/FeatureUtilities.java | 25 +++++++++ chrome/browser/android/feature_utilities.cc | 7 +++ content/browser/browser_child_process_host_impl.cc | 12 +++++ content/browser/browser_child_process_host_impl.h | 13 +++++ content/browser/child_process_launcher.cc | 9 ++++ content/browser/child_process_launcher.h | 4 ++ .../browser/child_process_launcher_browsertest.cc | 5 ++ content/browser/child_process_launcher_helper.cc | 14 ++++- content/browser/child_process_launcher_helper.h | 8 +++ .../child_process_launcher_helper_android.cc | 4 +- content/browser/utility_process_host.cc | 5 ++ .../browser/ChildProcessLauncherHelperImpl.java | 63 ++++++++++++++-------- .../browser/ChildProcessLauncherHelper.java | 5 +- .../browser/ChildProcessLauncherHelperTest.java | 61 +++++++++++++++++---- content/public/common/content_features.cc | 4 ++ content/public/common/content_features.h | 1 + .../ChildProcessLauncherTestUtils.java | 3 +- 21 files changed, 218 insertions(+), 42 deletions(-) commit 28683226fcf15245985dad45daab140aec08dfb1 Author: Mitsuru Oshima <oshima@chromium.org> Date: Sat Mar 16 07:46:03 2019 +0000 Remove unused "ignored_by_shelf". Bug: None Change-Id: I73b6b9601aa87cb071dc9843e08b261c460c9de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526690 Reviewed-by: Sammie Quon <sammiequon@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#641432} ash/wm/overview/overview_session.cc | 1 - ash/wm/overview/scoped_overview_transform_window.h | 3 --- 2 files changed, 4 deletions(-) commit 535885e49b6b614a97dddf79d7206cd8f38351df Author: Charlie Reis <creis@chromium.org> Date: Sat Mar 16 07:29:27 2019 +0000 Do not display error page for unsafe redirects to javascript URLs. Chrome used to drop the navigation request when it encountered a redirect to a javascript URL. Now in Chrome M73/M74, Chrome started displaying an error page with the net::ERR_UNSAFE_REDIRECT error instead. This started with CL: https://chromium-review.googlesource.com/c/chromium/src/+/1488152 It turns out in https://crbug.com/941653 that the Meta4 ClickOnce launcher extension (260K users) was using this edge case to cancel download and replace it by its build-in download manager. It redirects the navigation to javascript:void() to avoid displaying an error page. This revert part of this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1488152 without regressing: https://crbug.com/935175 (CL authored by arthursonzogni@, with minor changes by creis@.) Bug: 941653 Bug: 935175 Change-Id: Ic6cf06b7c878fac10d2be181ec621c328d1f0229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526634 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641431} chrome/browser/chrome_navigation_browsertest.cc | 12 ++++++------ .../navigation_controller_impl_browsertest.cc | 20 +++++++++++++------- .../frame_host/navigation_handle_impl_browsertest.cc | 9 +++++++-- content/browser/frame_host/navigation_request.cc | 13 +++++++++---- 4 files changed, 35 insertions(+), 19 deletions(-) commit a6a88668be6c38f5ff5378553184f545b00a88de Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Sat Mar 16 06:56:46 2019 +0000 Automated Commit: LKGM 11934.0.0 for chromeos. BUG=762641 TBR=afakhry@google.com Change-Id: I6c2cebdbe59af8c9b735c0066a9e5cfb26eb232d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526502 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641430} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2313e474dbcf48dd8a7858206b6e3343f0f473f9 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat Mar 16 06:55:16 2019 +0000 [BGPT] Don't collect non-animation non-scroll element ids Collecting non-animation element ids gave compositor wrong information that they need to be handled by the compositor, causing non-composited animation (caused by will-change: contents) on composited-layer failed to start in BGPT mode. Also add virtual/disable-blink-gen-property-trees/transitions. Bug: 936912 Change-Id: I3ff64a732920ef884d838064d2d3a005e8a50860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512765 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641429} .../core/paint/paint_property_tree_builder_test.cc | 27 +++++--- .../compositing/paint_artifact_compositor.cc | 12 +--- .../compositing/paint_artifact_compositor_test.cc | 72 +++++++++------------ .../graphics/paint/effect_paint_property_node.h | 6 ++ .../graphics/paint/transform_paint_property_node.h | 6 ++ .../platform/testing/paint_property_test_helpers.h | 25 +++++++ third_party/blink/web_tests/VirtualTestSuites | 6 ++ ...3d-transform-will-change-contents-expected.html | 11 ++++ ...ansition-3d-transform-will-change-contents.html | 28 ++++++++ .../transitions/README.txt | 2 + ...ransform-transitions-inside-iframe-expected.png | Bin 0 -> 3095 bytes 11 files changed, 134 insertions(+), 61 deletions(-) commit c3dddef8161bb75aae275a1f78715a06ddd28b3c Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 16 06:23:26 2019 +0000 Update V8 to version 7.5.56. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6418da5..b17b455a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id4dab8048d0f7bdc029a0760a2e5dbdb5c98f8e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524254 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641428} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 369496d006f97ad8e27e67117fa7265cecbabcfc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 06:10:36 2019 +0000 Roll src/third_party/angle e41882aaf55d..38e282570676 (6 commits) https://chromium.googlesource.com/angle/angle.git/+log/e41882aaf55d..38e282570676 git log e41882aaf55d..38e282570676 --date=short --no-merges --format='%ad %ae %s' 2019-03-16 jdarpinian@chromium.org Fix ASSERT macro not printing message 2019-03-16 syoussefi@chromium.org Use valid glmark2 test result names 2019-03-16 jdarpinian@chromium.org Disable sampler/texture type validation 2019-03-16 jmadill@chromium.org Fix several small issues in angle_end2end_tests. 2019-03-15 jmadill@chromium.org DisplayWGL: Allow MakeCurrent(null). 2019-03-15 geofflang@chromium.org Disable loop unrolling when encounting errors about invalid array indices. Created with: gclient setdep -r src/third_party/angle@38e282570676 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:780507,chromium:940080,chromium:809237 TBR=geofflang@chromium.org Change-Id: I4af02e56c9b581bd69665f113437867b6d2ab965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526528 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641427} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f4c60d43323d57b521598d1ca9fa65e2de9b881b Author: Nicholas Verne <nverne@chromium.org> Date: Sat Mar 16 05:50:06 2019 +0000 Manage Shared USB devices with CrosUsbDetector This CL enables Shared USB device management from the Crostini Shared Usb devices settings page via CrosUsbDetector. To do this, it moves USB Detector functionality out of Crostini Manager into the CrosUsbDetector. This simplifies the interactions between the Crostini services and the USB Service. It also introduces calls into the CrostiniHandler and browser proxy to allow a request for the current available usb devices (and their sharing state) and web ui events to pass the available usb devices back to the settings page. This continues work originally started by jopra@chromium.org Bug: 899568 Change-Id: Id05c824c3add72466236faa980d2de374f9d489e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516123 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641426} chrome/app/generated_resources.grd | 7 +- chrome/app/settings_strings.grdp | 11 +- .../chromeos/chrome_browser_main_chromeos.cc | 7 +- .../browser/chromeos/crostini/crostini_manager.cc | 151 ++------- .../browser/chromeos/crostini/crostini_manager.h | 53 ++-- .../chromeos/crostini/crostini_manager_unittest.cc | 74 +---- chrome/browser/chromeos/usb/OWNERS | 1 + chrome/browser/chromeos/usb/cros_usb_detector.cc | 350 ++++++++++++++++++--- chrome/browser/chromeos/usb/cros_usb_detector.h | 100 +++++- .../chromeos/usb/cros_usb_detector_unittest.cc | 147 +++++---- .../resources/settings/crostini_page/BUILD.gn | 3 +- .../crostini_page/crostini_browser_proxy.js | 28 ++ .../crostini_page/crostini_shared_usb_devices.html | 29 +- .../crostini_page/crostini_shared_usb_devices.js | 40 ++- .../ui/webui/settings/chromeos/crostini_handler.cc | 94 +++++- .../ui/webui/settings/chromeos/crostini_handler.h | 17 +- .../md_settings_localized_strings_provider.cc | 6 +- .../test/data/webui/settings/crostini_page_test.js | 23 +- .../webui/settings/test_crostini_browser_proxy.js | 14 + 19 files changed, 765 insertions(+), 390 deletions(-) commit 4195ee15954190cfa696464e3a166db6e9e63e77 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Sat Mar 16 05:41:06 2019 +0000 Roll src-internal dd08c2522931..1d512824c7e8 (22 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd08c2522931..1d512824c7e8 Created with: gclient setdep -r src-internal@1d512824c7e8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: I5fcfc1159b064c741143a3297802927960b18165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526529 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641425} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f1242cb898abbcda69e3d83bec83ac187cf251cf Author: James Darpinian <jdarpinian@chromium.org> Date: Sat Mar 16 05:33:44 2019 +0000 Revert "Remove failing Android test expectations for WebGL2 video textures" This reverts commit e74d0fafbdb149e7c8add8de6e885944a79b39bd. Reason for revert: These tests are failing on the new Pixel 2 bot. Original change's description: > Remove failing Android test expectations for WebGL2 video textures > > These tests were previously failing but no longer fail on top of tree. > > Bug: 906735 > Change-Id: I2c2c024de7478a668a9c81727849f6710338851b > Reviewed-on: https://chromium-review.googlesource.com/c/1438020 > Reviewed-by: James Darpinian <jdarpinian@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Austin Eng <enga@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629843} TBR=kbr@chromium.org,jdarpinian@chromium.org,kainino@chromium.org,enga@chromium.org Bug: 906735 Change-Id: If63c56aaa7b62475f875298a95070a5fd7a3ae6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526623 Reviewed-by: James Darpinian <jdarpinian@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641424} content/test/gpu/gpu_tests/webgl2_conformance_expectations.py | 11 +++++++++++ 1 file changed, 11 insertions(+) commit a8a44a0d207f3304bb21cf866f3df0cf0ff192b8 Author: Zhenyao Mo <zmo@chromium.org> Date: Sat Mar 16 05:06:34 2019 +0000 Add two crash keys before GPU watchdog kicks in. One is how long ago ReportProgress() is called. This gives us a hint if we need to call it more often. Second is the available physical memory. This indicates if GPU delay is caused by page swap, etc. BUG=597700 TEST=none R=piman@chromium.org Change-Id: I18d87b2fcdaf061a388c7da4d763b303c6197013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525412 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641423} gpu/config/gpu_crash_keys.cc | 4 ++++ gpu/config/gpu_crash_keys.h | 4 ++++ gpu/ipc/service/command_buffer_stub.cc | 2 +- gpu/ipc/service/gpu_watchdog_thread.cc | 14 ++++++++++++++ gpu/ipc/service/gpu_watchdog_thread.h | 6 ++++-- 5 files changed, 27 insertions(+), 3 deletions(-) commit f8686743a674c3d5020db511e546cdfe41b692cb Author: Tommy Steimel <steimel@chromium.org> Date: Sat Mar 16 05:01:15 2019 +0000 [NowPlaying] Give MediaSession playback state to MPNowPlayingInfoCenter This CL adds a NowPlayingInfoCenterDelegate class that interacts with Mac OS's MPNowPlayingInfoCenter API. This also adds a new media session observer that uses the NowPlayingInfoCenterDelegate to update the "Now Playing" playback state. This CL only adds playback state data, which allows the Mac OS to properly decide whether Chrome or another app should receive the media keys. Bug: 936513, 930180 Change-Id: Ic4a62905e590bc8185d7d6ce7beb1e639d1408d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1492778 Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641422} content/browser/BUILD.gn | 2 + .../media/media_keys_listener_manager_impl.cc | 23 +++++- .../media/media_keys_listener_manager_impl.h | 11 +++ .../media/now_playing_info_center_notifier.cc | 63 +++++++++++++++ .../media/now_playing_info_center_notifier.h | 67 ++++++++++++++++ .../now_playing_info_center_notifier_unittest.cc | 90 ++++++++++++++++++++++ content/test/BUILD.gn | 6 +- ui/base/now_playing/BUILD.gn | 8 ++ .../mock_now_playing_info_center_delegate.cc | 13 ++++ .../mock_now_playing_info_center_delegate.h | 29 +++++++ .../now_playing_info_center_delegate.cc | 11 +++ .../now_playing/now_playing_info_center_delegate.h | 36 +++++++++ .../now_playing_info_center_delegate_cocoa.h | 24 ++++++ .../now_playing_info_center_delegate_cocoa.mm | 64 +++++++++++++++ .../now_playing_info_center_delegate_impl.h | 44 +++++++++++ .../now_playing_info_center_delegate_impl.mm | 60 +++++++++++++++ 16 files changed, 548 insertions(+), 3 deletions(-) commit a7a7e28d7e04442e9668ff725cb2c36ae8686c9c Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat Mar 16 04:59:44 2019 +0000 [BGPT] Remove XXXPaintPropertyNode::IsRunningXXXAnimationOnCompositor() Recent investigation and discussions made it clear that ComputedStyle::IsRunningXXXAnimationOnCompositor() methods actually reflect the animation status from the compositor. The previous plan about using them was wrong because it caused a chicken-and-egg problem: we wanted them to inform the compositor to start animations, but they actually came from the compositor after animations were started. Now use ComputedStyle::IsRunningXXXAnimationOnCompositor() only to ignore changes of animation values at blink side. Changes of the flags themselves no longer need to be handled by blink in any way. Bug: 935770 Change-Id: I2523b8b9d2b6d57dcea19dc020d95ebe66a38c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513736 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641421} .../paint/compositing/compositing_reason_finder.cc | 20 ++-- .../compositing/compositing_reason_finder_test.cc | 25 ----- .../renderer/core/paint/link_highlight_impl.cc | 1 - .../core/paint/link_highlight_impl_test.cc | 4 +- .../renderer/core/paint/object_paint_properties.h | 31 +++--- .../core/paint/paint_property_tree_builder.cc | 74 ++++++------- .../core/paint/paint_property_tree_builder.h | 6 +- .../core/paint/paint_property_tree_update_tests.cc | 6 +- .../renderer/core/paint/pre_paint_tree_walk.cc | 20 ++-- .../blink/renderer/core/style/computed_style.cc | 8 -- .../core/style/computed_style_extra_fields.json5 | 12 ++ .../renderer/core/style/computed_style_test.cc | 24 +++- third_party/blink/renderer/platform/BUILD.gn | 1 + .../compositing/paint_artifact_compositor_test.cc | 68 +++--------- .../graphics/compositing/property_tree_manager.cc | 4 +- .../graphics/paint/clip_paint_property_node.h | 19 ++-- .../graphics/paint/effect_paint_property_node.h | 66 ++--------- .../graphics/paint/paint_property_change.h | 122 +++++++++++++++++++++ .../platform/graphics/paint/paint_property_node.h | 17 +-- .../graphics/paint/scroll_paint_property_node.h | 19 ++-- .../graphics/paint/transform_paint_property_node.h | 37 ++----- .../platform/testing/paint_property_test_helpers.h | 32 +++++- third_party/blink/web_tests/TestExpectations | 1 + .../animation-overlap-with-children-expected.txt | 16 ++- 24 files changed, 329 insertions(+), 304 deletions(-) commit 84536b3ddc809cc6401d24fe1e70259ac4888603 Author: Rakib M. Hasan <rmhasan@google.com> Date: Sat Mar 16 04:54:22 2019 +0000 Overrides the GetPlatformTags and GenerateTags methods in the GpuIntegrationTest class The GetPlatformTags function will return the operating system name, operating system version name, browser type, gpu vendor, gpu device id, angle renderer and command decoder tags. The GpuIntegrationTest's GenerateTags implementation calls GetPlatformTags and returns the list of tags returned. Bug: chromium:698902 Change-Id: I9ee60139dd080b7ba17a6e1d8c614c834a679ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524537 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641420} content/test/gpu/gpu_tests/gpu_helper.py | 87 +++++++++++++ content/test/gpu/gpu_tests/gpu_integration_test.py | 44 +++++++ .../gpu/gpu_tests/gpu_integration_test_unittest.py | 141 +++++++++++++++++++++ 3 files changed, 272 insertions(+) commit 39fe16436cc38208ba072fc94d6e1fef6cfd8a59 Author: Austin Eng <enga@chromium.org> Date: Sat Mar 16 04:50:42 2019 +0000 Make DawnObject hold onto a Dawn object handle and Member<GPUDevice> WebGPU objects need to hold onto the device because if the GPUDevice is destructed, all Dawn objects created from it will also be destroyed. This patch also updates DawnObject<T> to hold an opaque Handle to a Dawn object. Bug: 941536 Change-Id: I7ddbc960da0b1ac917295820b1c1096a249f4690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521238 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641419} .../blink/renderer/modules/webgpu/dawn_object.cc | 25 ++++++++---- .../blink/renderer/modules/webgpu/dawn_object.h | 45 ++++++++++++++++++++-- .../blink/renderer/modules/webgpu/gpu_adapter.cc | 2 +- .../blink/renderer/modules/webgpu/gpu_adapter.h | 2 +- .../blink/renderer/modules/webgpu/gpu_device.cc | 14 ++++++- .../blink/renderer/modules/webgpu/gpu_device.h | 3 +- 6 files changed, 74 insertions(+), 17 deletions(-) commit e0164961aae763b662cc17923f3fdbb0af0fbb6e Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Sat Mar 16 04:48:55 2019 +0000 Revert "Reland "OnionSoup: Move mojom files from public/platform/web to public/mojom folder"" This reverts commit 4a3a0dbd1480af83e9f996734ec7bd51e703ed6e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 641399 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhM2EwZGJkMTQ4MGFmODNlOWY5OTY3MzRlYzdiZDUxZTcwM2VkNmUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/9755 Sample Failed Step: compile Original change's description: > Reland "OnionSoup: Move mojom files from public/platform/web to public/mojom folder" > > This is a reland of e656908dbda6ced2f4743a9b5c2ed926dc6b5b67 > > It updates deps from //content/public/android/BUILD.gn. > > Original change's description: > > OnionSoup: Move mojom files from public/platform/web to public/mojom folder > > > > This CL moves window_features.mojom, commit_result.mojom, > > devtools_frontend.mojom, selection_menu_behavior.mojom and > > remote_objects.mojom from public/platform/web to public/mojom/ > > to gather mojom files to mojom folder and updates paths for these > > mojom files. > > > > Bug: 919393 > > Change-Id: If6df031ed39d70e700986bd13a40d0598257e009 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514434 > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#640633} > > Bug: 919393 > Change-Id: I7c0cf251bb1fa336645a6f12d90cf42c3ee837fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523210 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#641399} Change-Id: I40faf63f28e93bead479330fdb584a9389dd3039 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524253 Cr-Commit-Position: refs/heads/master@{#641418} chrome/browser/DEPS | 1 + chrome/browser/ui/blocked_content/blocked_window_params.h | 2 +- chrome/browser/ui/blocked_content/popup_blocker.h | 2 +- chrome/common/chrome_render_frame.mojom | 2 +- content/browser/DEPS | 2 ++ content/browser/devtools/devtools_frontend_host_impl.h | 2 +- content/browser/frame_host/render_frame_host_impl.h | 2 +- content/common/frame.mojom | 4 ++-- content/common/input/input_handler.mojom | 2 +- content/common/navigation_client.mojom | 2 +- content/public/android/BUILD.gn | 6 +++--- content/public/browser/content_browser_client.h | 2 +- content/public/common/common_param_traits_macros.h | 2 +- content/public/renderer/window_features_converter.h | 2 +- content/renderer/navigation_state.cc | 2 +- content/renderer/render_frame_impl.h | 2 +- third_party/blink/public/BUILD.gn | 5 +++++ third_party/blink/public/mojom/BUILD.gn | 11 ++--------- third_party/blink/public/mojom/commit_result/OWNERS | 2 -- third_party/blink/public/mojom/remote_objects/OWNERS | 2 -- third_party/blink/public/mojom/selection_menu/OWNERS | 2 -- third_party/blink/public/mojom/window_features/OWNERS | 2 -- .../public/{mojom/commit_result => web}/commit_result.mojom | 0 .../public/{mojom/devtools => web}/devtools_frontend.mojom | 0 .../public/{mojom/remote_objects => web}/remote_objects.mojom | 0 .../selection_menu => web}/selection_menu_behavior.mojom | 0 third_party/blink/public/web/web_local_frame.h | 4 ++-- .../{mojom/window_features => web}/window_features.mojom | 0 .../blink/renderer/controller/dev_tools_frontend_impl.h | 2 +- third_party/blink/renderer/core/loader/frame_loader.cc | 2 +- 30 files changed, 31 insertions(+), 38 deletions(-) commit 451bb9cff734135f877128221edf5d6061f98987 Author: Victor Costan <pwnall@chromium.org> Date: Sat Mar 16 04:48:07 2019 +0000 websql: Use a dedicated SQLite VFS. This is the first step in removing our SQLite VFS patches that support WebSQL. After this CL proves stable, a follow-up will remove the SQLite patches. Bug: 925739 Change-Id: I9c709242f815ffa4e97787c37cea247a222c9990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1438818 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Reviewed-by: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641417} .../blink/renderer/modules/webdatabase/BUILD.gn | 15 +- .../modules/webdatabase/database_tracker.cc | 2 - .../blink/renderer/modules/webdatabase/sqlite/DEPS | 2 + .../modules/webdatabase/sqlite/sandboxed_vfs.cc | 319 ++++++++++++ .../modules/webdatabase/sqlite/sandboxed_vfs.h | 71 +++ .../webdatabase/sqlite/sandboxed_vfs_file.cc | 532 +++++++++++++++++++++ .../webdatabase/sqlite/sandboxed_vfs_file.h | 95 ++++ .../modules/webdatabase/sqlite/sqlite_database.cc | 9 +- .../webdatabase/sqlite/sqlite_file_system.cc | 71 --- .../webdatabase/sqlite/sqlite_file_system.h | 73 --- .../webdatabase/sqlite/sqlite_file_system_posix.cc | 368 -------------- .../webdatabase/sqlite/sqlite_file_system_win.cc | 194 -------- .../blinkpy/presubmit/audit_non_blink_usage.py | 1 + .../storage/websql/fts-pointer-leak-742407.html | 3 +- 14 files changed, 1031 insertions(+), 724 deletions(-) commit dfb2a72d5c4eebe72a8b77fe27a74d32cf8de1e4 Author: Ella Ge <eirage@chromium.org> Date: Sat Mar 16 04:47:27 2019 +0000 Turn the UnifiedPointerCapture flag on This CL turn on the UnifiedPointerCaptureInBlink flag. It does not need an 'intent' as it's only minor behavior change, more like bug fixing. The behavior changing is: 1. Fix setPointerCapture to an element in outer frame and move mouse cursor to inner frame, event will sending to the capture element correctly instead of send to inner frame 2. Reduce the mouse event hit test count when mouse dragging in same origin iframe. Bug: 919908 Change-Id: Ib73e722165da751bffef597f4e5818c727fb568b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524978 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641416} third_party/blink/renderer/platform/runtime_enabled_features.json5 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c259d20aa5abf1caa536a905ce4cf9cc418fdca8 Author: Yue Li <updowndota@chromium.org> Date: Sat Mar 16 04:47:02 2019 +0000 Adding already setup animation for Assistant voice match Also fix a bug that setting zippy are added multiple times while reloading. Bug: b/127840716 Test: Manual Test Change-Id: I84f11431c9fb42faaf282f4efc7d2b267d7d9796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516912 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#641415} .../chromeos/assistant_optin/assistant_get_more.js | 8 ++++++++ .../chromeos/assistant_optin/assistant_third_party.js | 7 +++++++ .../chromeos/assistant_optin/assistant_value_prop.js | 7 +++++++ .../chromeos/assistant_optin/assistant_voice_match.css | 8 ++++++++ .../chromeos/assistant_optin/assistant_voice_match.html | 6 +++++- .../chromeos/assistant_optin/voice_already_setup.png | Bin 3409 -> 0 bytes .../chromeos/assistant_optin/voice_already_setup.webm | Bin 0 -> 88464 bytes 7 files changed, 35 insertions(+), 1 deletion(-) commit 59cd4809921fad94178b6b4bddd946889b655e4b Author: Austin Eng <enga@chromium.org> Date: Sat Mar 16 04:46:22 2019 +0000 Skip WebGPU tests on Linux AMD WebGPU tests are failing on Linux FYI Release (AMD R7 240). This patch skips all WebGPU tests on Linux AMD. Bug: 941685 Change-Id: Ic57da7b263d4ffdda3347f4d59c4c37e15b18c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526343 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641414} gpu/BUILD.gn | 1 - gpu/command_buffer/tests/webgpu_fence_unittest.cc | 12 +++++ gpu/command_buffer/tests/webgpu_test.cc | 17 ++++++ gpu/command_buffer/tests/webgpu_test.h | 1 + gpu/ipc/client/webgpu_in_process_context_tests.cc | 63 ----------------------- 5 files changed, 30 insertions(+), 64 deletions(-) commit 231355ab4f39fefa7712fe21ab340ef7e375e300 Author: rbpotter <rbpotter@chromium.org> Date: Sat Mar 16 04:44:22 2019 +0000 Print Preview: Ensure no bad custom margin values get sent Speculative fix for crashes. Although it is unclear how custom margins is getting into a bad state (bad sticky settings?) for some users, it appears Print Preview is sending invalid custom margins values. Check for these before starting any preview request. Bug: 942211 Change-Id: I8ebeeb62246b6123730b53398d31a8f0ec9c9f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524877 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#641413} .../resources/print_preview/new/preview_area.js | 89 ++++++++++++++++------ .../new_print_preview_ui_browsertest.js | 4 + .../webui/print_preview/preview_generation_test.js | 82 +++++++++++++++++++- 3 files changed, 147 insertions(+), 28 deletions(-) commit 5a4a694fb059ba21b4fabf61a39f2847d4875227 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Sat Mar 16 04:42:22 2019 +0000 Update V8 to version 7.5.55. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1eab4506..a6418da5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I78c53f39989f57cdfa103cf8a9156fcf46aadb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526430 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641412} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e8124433cc00353d3ad5ee6de45d76b22155dda8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 04:40:22 2019 +0000 Roll src/third_party/depot_tools e5c289fde0a1..24b5f9087ff6 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e5c289fde0a1..24b5f9087ff6 git log e5c289fde0a1..24b5f9087ff6 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 hans@chromium.org Metrics: stop trying to print the notice in color and unicode Created with: gclient setdep -r src/third_party/depot_tools@24b5f9087ff6 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:934279 TBR=agable@chromium.org Change-Id: If28b047534ab3f844b21dfcd037fcb081cc2247e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526521 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641411} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 75bb44e0357c9b21037228eb985b0b1de3f76c54 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 04:39:42 2019 +0000 Roll src/third_party/swiftshader f3b57974620d..f0d22ad90891 (13 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/f3b57974620d..f0d22ad90891 git log f3b57974620d..f0d22ad90891 --date=short --no-merges --format='%ad %ae %s' 2019-03-15 capn@google.com Remove Reactor argument tests for small integers 2019-03-15 bclayton@google.com Revert "VkDebug: Update macros to address issues in b/127433389" 2019-03-15 capn@google.com Add Python path to Kokoro batch script 2019-03-15 chrisforbes@google.com Add support for OpVectorInsertDynamic, OpVectorExtractDynamic 2019-03-15 chrisforbes@google.com Add support for OpSRem 2019-03-15 chrisforbes@google.com Remove asserts on depth bounds values 2019-03-15 chrisforbes@google.com Remove asserts blocking specialization constant use 2019-03-15 chrisforbes@google.com Run spirv-opt pass to eliminate dead functions after inlining 2019-03-15 bclayton@google.com ComputeProgram: Add subgroup builtins. 2019-03-15 sugoi@google.com DescriptorSetLayout destruction fix 2019-03-15 sugoi@google.com sRGB filtering fix 2019-03-15 sugoi@google.com CubeMap fixes 2019-03-15 sugoi@google.com Dedicated allocation verification Created with: gclient setdep -r src/third_party/swiftshader@f0d22ad90891 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126873455,chromium:b/126873455,chromium:b/118386749,chromium:b/124058197,chromium:b/126871859 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I492e8fe502152ad9334664a907a28e74e9e0dc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526526 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641410} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 05248635c4a6a24a544d1cb192d93e1fab8855f8 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 04:38:22 2019 +0000 Roll src/third_party/skia 69600007e278..f34d0c79dc6c (27 commits) https://skia.googlesource.com/skia.git/+log/69600007e278..f34d0c79dc6c git log 69600007e278..f34d0c79dc6c --date=short --no-merges --format='%ad %ae %s' 2019-03-16 mtklein@google.com re-hash images once more artificially 2019-03-16 halcanary@google.com Revert "Revert "Compile all fiddle examples locally"" 2019-03-15 kjlubick@google.com [canvaskit] Add TextOnPath helper to TextBlob 2019-03-15 mtklein@google.com hash and encode rework, wip 2019-03-15 reed@google.com use load_f32_dst 2019-03-15 reed@google.com allow mixer to defer to a shader 2019-03-15 jvanverth@google.com Fix asserts in Metal tests. 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1e6a9898b73b..71673c81fb1e (8 commits) 2019-03-15 enne@chromium.org Enforce alignment in SkDescriptor deserialization 2019-03-15 benjaminwagner@google.com [infra] Update Win10 in Skolo. 2019-03-15 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f3b57974620d..1e6a9898b73b (1 commits) 2019-03-15 halcanary@google.com GN: split out skia_*_public from skia_*_sources 2019-03-15 robertphillips@google.com Reduce work done by GrYUVtoRGBEffect for kIdentity_SkYUVColorSpace 2019-03-15 halcanary@google.com Revert "Compile all fiddle examples locally" 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 36411219ff2b..f3b57974620d (3 commits) 2019-03-15 brianosman@google.com Standardize naming on CoverageAsAlpha (rather than AlphaAsCoverage) 2019-03-15 bsalomon@google.com Revert "Revert "Distinguish between "flushed" and "finished" idle state callbacks on GrTexture."" 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e37ce613d1c7..36411219ff2b (1 commits) 2019-03-15 nifong@google.com Add selectable GPU backend to wasm debugger 2019-03-15 halcanary@google.com Compile all fiddle examples locally 2019-03-15 brianosman@google.com Add shader based blending of kPlus for configs that need clamping 2019-03-15 mtklein@google.com Revert "remove plus clamp" 2019-03-15 fmalita@chromium.org [skottie] Initial text box support 2019-03-15 bsalomon@google.com Revert "Reland "Update SkCanvas' experimental SkiaRenderer API"" 2019-03-15 brianosman@google.com Change --checkF16 behavior to just print - it's easier to see all failures 2019-03-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2fb6563bf503..de52ca373d98 (1 commits) Created with: gclient setdep -r src/third_party/skia@f34d0c79dc6c The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:942430 TBR=benjaminwagner@chromium.org Change-Id: I5a567c84542ccb1cd3695eda4897dc10a7a81fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526527 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641409} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 489d9ba193990f9228c5509578f15c95360a6fd3 Author: Dan Beam <dbeam@chromium.org> Date: Sat Mar 16 04:38:02 2019 +0000 WebUI Dark Mode: make chrome://apps usable by fixing text color Note: known issues with this page still (after this patch): * native theme changes still don't update chrome://apps * links have the same color as the rest of the text on the page (when they should probably be Google Blue 300 or something along those lines) * makes chrome://apps inconsistent with incognito NTP (which uses the text color of Google Grey 300 instead of 200) R=pkasting@chromium.org BUG=925384,941389 Change-Id: I9b6e6a8ba81bd50441f185ae8804e4607311770c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526786 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641408} chrome/browser/themes/theme_properties.cc | 2 ++ 1 file changed, 2 insertions(+) commit ceee653f25a17f315e625326d8bb07dff4ab49ab Author: Oystein Eftevaag <oysteine@google.com> Date: Sat Mar 16 04:31:22 2019 +0000 Perfetto: Enable by default everywhere This enables Perfetto (https://www.perfetto.dev/) by default as the new backend for the Chrome tracing system (what drives about://tracing). R=ssid@chromium.org TBR=nasko@chromium.org Bug: 839084 Change-Id: I6a239424aaa69aa38143ec10f30636c12e858d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508695 Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#641407} components/tracing/common/tracing_switches.cc | 6 ++---- components/tracing/common/tracing_switches.h | 2 +- content/browser/browser_child_process_host_impl.cc | 2 +- content/browser/renderer_host/render_process_host_impl.cc | 2 +- .../public/cpp/perfetto/chrome_bundle_thread_local_event_sink.h | 2 +- services/tracing/public/cpp/perfetto/trace_event_data_source.cc | 7 ++++++- services/tracing/public/cpp/tracing_features.cc | 8 +++----- 7 files changed, 15 insertions(+), 14 deletions(-) commit b2c72608d8a4ee0bd08d6fc87fae0b4127a679bf Author: danakj <danakj@chromium.org> Date: Sat Mar 16 04:26:41 2019 +0000 Add checks in ChromeClientImpl for invalid ScheduleAnimation calls. We expect that we don't go to ScheduleAnimation if the document is shutdown. We can perhaps also see if the frame is the mainframe or another frame with an aliased local variable. R=dcheng@chromium.org Bug: 939262 Change-Id: Iafe808bcda161cffdb5889c438bc232398db01af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526431 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641406} .../blink/renderer/core/exported/web_view_impl.cc | 6 ++++++ .../blink/renderer/core/page/chrome_client_impl.cc | 19 +++++++++++++++++++ .../blink/renderer/core/page/chrome_client_impl.h | 7 +++++++ 3 files changed, 32 insertions(+) commit 5d646e711bbdcacf5379c941ad23ce3c4c46f8d7 Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 04:25:12 2019 +0000 Convert PlatformTestHelper::Factory to RepeatingCallback with Miscellaneous Cleanup BUG=714018,940130 TBR=sky@chromium.org Change-Id: I6fe5a4d82d299bc0676a802bc42c28086dc796bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526742 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641405} ui/views/test/platform_test_helper.cc | 16 +++++++++------- ui/views/test/platform_test_helper.h | 8 +++++--- 2 files changed, 14 insertions(+), 10 deletions(-) commit e1b1f3a5f273c8da533fad495b9de316e2c83c9b Author: jdoerrie <jdoerrie@chromium.org> Date: Sat Mar 16 04:08:01 2019 +0000 [base] Add Dead Type to base::Value This change adds a temporary DEAD type to base::Value which should help to track down use-after-free bugs. Furthermore, this change also removes the now unneeded is_alive_ flag. Bug: 859477, 941404 Change-Id: I9b7a2f3cbb0b22d7e3ed35b2453537419f3f7e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478897 Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Tao Bai <michaelbai@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: David Turner <digit@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641404} base/json/json_writer.cc | 5 ++ base/values.cc | 68 ++++++++++++++-------- base/values.h | 23 ++------ base/values_unittest.cc | 10 +++- .../ui/cocoa/applescript/apple_event_util.mm | 10 ++++ chromeos/network/onc/variable_expander.cc | 6 ++ .../core/browser/android/policy_converter.cc | 11 +++- .../core/common/policy_loader_win_unittest.cc | 8 ++- components/policy/core/common/policy_test_utils.cc | 5 ++ components/policy/core/common/registry_dict.cc | 4 ++ .../java/gin_java_script_to_java_types_coercion.cc | 8 ++- ipc/ipc_message_utils.cc | 11 +++- mojo/public/cpp/base/values_mojom_traits.h | 7 ++- .../private/ppb_x509_certificate_private_shared.cc | 2 + 14 files changed, 127 insertions(+), 51 deletions(-) commit f33d6950649b1062d0ac1739ff713948af8adb0e Author: David Benjamin <davidben@chromium.org> Date: Sat Mar 16 04:01:06 2019 +0000 Roll src/third_party/boringssl/src 3390fd88d..aadcce380 https://boringssl.googlesource.com/boringssl/+log/3390fd88d716ea599d659c2b72b9a6cd4bb36442..aadcce380fe9e5e17ff38f8471e956463fc4df21 The following commits have Chromium bugs associated: aadcce380 Implement sk_find manually. Bug: 941463 Change-Id: I1cde0f9631c186577e6b073ca7a0687d56006027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525003 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#641403} DEPS | 2 +- .../ios-aarch64/crypto/fipsmodule/vpaes-armv8.S | 54 +++++++++++++++------- .../linux-aarch64/crypto/fipsmodule/vpaes-armv8.S | 54 +++++++++++++++------- 3 files changed, 75 insertions(+), 35 deletions(-) commit dc12c3e904b755ce68f5048732a091fc946d0448 Author: Victor Fei <vicfei@microsoft.com> Date: Sat Mar 16 04:00:21 2019 +0000 Implemented ITextRangeProvider::CompareEndpoints Implemented CompareEndpoints of ITextRangeProvider with assoicated unittests. Bug: 928948 Change-Id: I184554c8493e131c05787ef262edf6d0298f9de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516879 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#641402} .../ax_platform_node_textrangeprovider_win.cc | 44 ++- .../ax_platform_node_textrangeprovider_win.h | 12 +- ...platform_node_textrangeprovider_win_unittest.cc | 330 ++++++++++++++++++++- 3 files changed, 366 insertions(+), 20 deletions(-) commit 5876e5c517d396bf1dfa9c7a5d2d056e55ec80e6 Author: Sergey Abbakumov <sabbakumov@yandex-team.ru> Date: Sat Mar 16 04:00:02 2019 +0000 Fix media::VideoFrame double deletion MaybePrepareAnotherOutput() takes unprepared_outputs_.front() reference to scoped_refptr<VideoFrame>. Then GpuMemoryBufferVideoFramePool::PoolImpl::CreateHardwareFrame() is called which calls frame_ready_cb (DecoderStream<StreamType>::OnPreparedOutputReady) in turn (after fix https://chromium-review.googlesource.com/c/chromium/src/+/1180543/6/media/video/gpu_memory_buffer_video_frame_pool.cc). DecoderStream<StreamType>::OnPreparedOutputReady does unprepared_outputs_.pop_front() and we have dangling reference to scoped_refptr<VideoFrame>. Then we use that reference and get double deletion of VideoFrame. Bug: 859477,939238 Change-Id: Iff99fdfe67cad77682629b72b187ac81b9bf4f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506750 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641401} media/filters/decoder_stream.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) commit 34097108d4dbff9895ed9bed167050ea3ba30ec1 Author: rajendrant <rajendrant@chromium.org> Date: Sat Mar 16 03:57:51 2019 +0000 Handle longer blocks and bypasses in DRP Currently block=86400 is not handled, which could be sent when DRP proxy should be disabled for longer periods. Bug: 942693 Change-Id: I184750825d67d56d1ef13a5b415ba0007bbcd2a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526429 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#641400} .../data_reduction_proxy_browsertest.cc | 24 ++++++++++++++++++++++ .../core/browser/data_reduction_proxy_io_data.cc | 9 ++++---- 2 files changed, 29 insertions(+), 4 deletions(-) commit 4a3a0dbd1480af83e9f996734ec7bd51e703ed6e Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Sat Mar 16 03:52:41 2019 +0000 Reland "OnionSoup: Move mojom files from public/platform/web to public/mojom folder" This is a reland of e656908dbda6ced2f4743a9b5c2ed926dc6b5b67 It updates deps from //content/public/android/BUILD.gn. Original change's description: > OnionSoup: Move mojom files from public/platform/web to public/mojom folder > > This CL moves window_features.mojom, commit_result.mojom, > devtools_frontend.mojom, selection_menu_behavior.mojom and > remote_objects.mojom from public/platform/web to public/mojom/ > to gather mojom files to mojom folder and updates paths for these > mojom files. > > Bug: 919393 > Change-Id: If6df031ed39d70e700986bd13a40d0598257e009 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514434 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> > Cr-Commit-Position: refs/heads/master@{#640633} Bug: 919393 Change-Id: I7c0cf251bb1fa336645a6f12d90cf42c3ee837fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523210 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#641399} chrome/browser/DEPS | 1 - chrome/browser/ui/blocked_content/blocked_window_params.h | 2 +- chrome/browser/ui/blocked_content/popup_blocker.h | 2 +- chrome/common/chrome_render_frame.mojom | 2 +- content/browser/DEPS | 2 -- content/browser/devtools/devtools_frontend_host_impl.h | 2 +- content/browser/frame_host/render_frame_host_impl.h | 2 +- content/common/frame.mojom | 4 ++-- content/common/input/input_handler.mojom | 2 +- content/common/navigation_client.mojom | 2 +- content/public/android/BUILD.gn | 6 +++--- content/public/browser/content_browser_client.h | 2 +- content/public/common/common_param_traits_macros.h | 2 +- content/public/renderer/window_features_converter.h | 2 +- content/renderer/navigation_state.cc | 2 +- content/renderer/render_frame_impl.h | 2 +- third_party/blink/public/BUILD.gn | 5 ----- third_party/blink/public/mojom/BUILD.gn | 11 +++++++++-- third_party/blink/public/mojom/commit_result/OWNERS | 2 ++ .../public/{web => mojom/commit_result}/commit_result.mojom | 0 .../public/{web => mojom/devtools}/devtools_frontend.mojom | 0 third_party/blink/public/mojom/remote_objects/OWNERS | 2 ++ .../public/{web => mojom/remote_objects}/remote_objects.mojom | 0 third_party/blink/public/mojom/selection_menu/OWNERS | 2 ++ .../selection_menu}/selection_menu_behavior.mojom | 0 third_party/blink/public/mojom/window_features/OWNERS | 2 ++ .../{web => mojom/window_features}/window_features.mojom | 0 third_party/blink/public/web/web_local_frame.h | 4 ++-- .../blink/renderer/controller/dev_tools_frontend_impl.h | 2 +- third_party/blink/renderer/core/loader/frame_loader.cc | 2 +- 30 files changed, 38 insertions(+), 31 deletions(-) commit 38d91556db2ee20b573e9133434042e3d3f41599 Author: Tommy Martino <tmartino@chromium.org> Date: Sat Mar 16 03:50:20 2019 +0000 Replace Autofill Substring Match switch with feature Bug: 77194 Change-Id: I72ee1acdf05f1beb9e2580cd4b16dadc18674155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525059 Commit-Queue: Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Auto-Submit: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641398} chrome/browser/about_flags.cc | 3 +-- chrome/browser/chrome_content_browser_client.cc | 1 - .../core/browser/autofill_manager_unittest.cc | 30 +++++++++------------- .../browser/webdata/autofill_table_unittest.cc | 5 ++-- .../autofill/core/common/autofill_features.cc | 5 ++++ .../autofill/core/common/autofill_features.h | 1 + .../autofill/core/common/autofill_switches.cc | 4 --- .../autofill/core/common/autofill_switches.h | 1 - components/autofill/core/common/autofill_util.cc | 3 +-- .../autofill/core/common/autofill_util_unittest.cc | 24 ++++++++++------- .../browser/password_autofill_manager_unittest.cc | 27 +++++++++---------- tools/metrics/histograms/enums.xml | 2 ++ 12 files changed, 53 insertions(+), 53 deletions(-) commit fc9e445c7a43ef620177c8039711cd64fde82aee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Mar 16 03:45:21 2019 +0000 Roll src/third_party/catapult 0a33de82760c..4e9bccd7a0cf (6 commits) https://chromium.googlesource.com/catapult.git/+log/0a33de82760c..4e9bccd7a0cf git log 0a33de82760c..4e9bccd7a0cf --date=short --no-merges --format='%ad %ae %s' 2019-03-16 kbr@chromium.org Add dont-require-rooted-device compatibility-mode to Telemetry. 2019-03-15 crouleau@chromium.org Make myself an OWNER of catapult. 2019-03-15 dberris@chromium.org Undo threadsafe:true for now 2019-03-15 benjhayden@chromium.org Store session state in URL in spa. 2019-03-15 dberris@chromium.org Store more objects in memcache 2019-03-15 dberris@chromium.org Use partial decompression in critical path Created with: gclient setdep -r src/third_party/catapult@4e9bccd7a0cf The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:826295,chromium:941267,chromium:941888,chromium:918193,chromium:941888,chromium:941888 TBR=sullivan@chromium.org Change-Id: Ib4e53c6c17dba6377d04a648e28885641bb5f3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526822 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641397} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9836fbdfa8be22b3f4f0a99b6cd145ba633ac33f Author: Robert Liao <robliao@chromium.org> Date: Sat Mar 16 03:27:20 2019 +0000 Convert the AppbarAutohideEdges Callback and Related Code to use OnceClosure BUG=714018,940130 TBR=sky@chromium.org Change-Id: Iaa812e52c01a35c43717a9d6935a1c8c238d6e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526682 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641396} chrome/browser/ui/views/chrome_views_delegate.h | 4 ++-- .../browser/ui/views/chrome_views_delegate_win.cc | 23 +++++++++++----------- ui/views/views_delegate.cc | 2 +- ui/views/views_delegate.h | 2 +- ui/views/win/hwnd_message_handler.cc | 5 +++-- 5 files changed, 19 insertions(+), 17 deletions(-) commit d02b8d3c418f378b68fc783fd68d4b7801718917 Author: Liquan(Max) Gu <maxlg@chromium.org> Date: Sat Mar 16 03:24:41 2019 +0000 [FCP++] Text: test ancestry visible rect clipping This is to add a test about clipping of the ancestry visible rect. For example, we have the following snippet. The outer box has a limiting visible area, and within it is a text larger than the outer box. The visual size of the text will be subject to the outer rect's size. <style> #outer { overflow: hidden; height: 1px; width: 1px; } </style> <div id='outer'> <div id='inner'> ######################################### </div> </div> Bug: 940996 Change-Id: I659756b7092de9a4a578a77841c3bcf3af65006c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521586 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641395} .../core/paint/text_paint_timing_detector_test.cc | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) commit 0f52044146f44ec904e3069da1afa4dd0cd8cfa5 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Sat Mar 16 03:16:30 2019 +0000 Print Preview: Fix "More settings" show condition. Bug: 848942 Change-Id: I7ab947d2288488eceb951b95435b4eeb2f158903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525936 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#641394} chrome/browser/resources/print_preview/new/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8a56464a22f1b01ccc13b5994784b2a498ea338 Author: Adrienne Walker <enne@chromium.org> Date: Sat Mar 16 03:11:47 2019 +0000 gpu: Ping watchdog before slow oopr operations as well This matches the behavior in the RasterDecoder, and merges the shared code. Bug: 940390,705957 Change-Id: Iab75121c4c4693ed5f4ccf7eea5aab845dc6b2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526636 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by: Khushal <khushalsagar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641393} gpu/command_buffer/service/raster_decoder.cc | 19 ++----------------- ui/gl/init/create_gr_gl_interface.cc | 14 ++------------ ui/gl/progress_reporter.h | 16 ++++++++++++++++ 3 files changed, 20 insertions(+), 29 deletions(-) commit 3f100ad82c20d17896c4968130013ec3e7c280fc Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Sat Mar 16 03:11:20 2019 +0000 Updating trunk VERSION from 3735.0 to 3736.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: If197bb57771add072dfacd03095d3770c0d7ccf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526753 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641392} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a3cc40975cfe59e2adb1749b9fa0dcda02500c62 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Sat Mar 16 03:01:46 2019 +0000 CORB allowlist additions - 2019-03-15. Bug: 942102 Bug: 942232 Bug: 942498 Bug: 942527 Bug: 942384 Bug: 942592 Bug: 942575 Bug: 942475 Change-Id: I160efe9dbf0b5e12a16b2422f3ec07c23757da9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525200 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#641391} extensions/browser/url_loader_factory_manager.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) Updated tag 'tree_truth' (was 384a17351407)