Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 44489 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918680837283286672 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/iti4fXv_/luci_context.195335563 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: trusty-webrtc-d2a17ac3-us-central1-b-zkrb SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43a7b0847d8f3411 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 4c428bdc69a2c16fdb0c5576e4098373bd6cc4e3 Gardening: media/controls/controls-layout-in-different-size.html is slow Matt Falkenhagen, Mon Mar 18 03:31:30 2019 +0000 323134b4c16c23e6bd9b8ec16abc0073b4274456 service worker: Improve WPT tests for async respondWith/waitUntil. Matt Falkenhagen, Mon Mar 18 03:30:20 2019 +0000 e81fdb9bce80f9e2e1d2d70de6f3aade9307fe0d Put CSSURIValue into the blink::cssvalue namespace. Zhuoyu Qian, Mon Mar 18 03:29:20 2019 +0000 6538b75388959eca3153335444b098338393fb4d Revert "Move credential_manager.mojom to third_party/blink/public/mojom/" Findit, Mon Mar 18 03:28:56 2019 +0000 d113b9fb51b82df84df507c2e2f37b0b3cb79539 Fix ctrl+space on file list Luciano Pacheco, Mon Mar 18 03:24:58 2019 +0000 89e587c0d0f1d47b0ed187c626485fcf793431be Roll src/third_party/depot_tools 24b5f9087ff6..efe902b20b6a (1 commits) chromium-autoroll, Mon Mar 18 03:13:36 2019 +0000 4b1a19531389487b0954203ac5111e6fc9ed052d Updating trunk VERSION from 3737.0 to 3738.0 chrome-release-bot, Mon Mar 18 03:12:12 2019 +0000 92497fb4a159e0bb0f2e2cede8012fd1454a3f58 Add field_trial_config for OomIntervention v2 experiments Yuzu Saijo, Mon Mar 18 03:12:06 2019 +0000 64b50e0ea351d597c2a5f882283888756e82d91d Disable libc++ on Windows/cl.exe and Windows/libfuzzer Tom Anderson, Mon Mar 18 03:11:06 2019 +0000 b223caabf45e1b8b8291dfceb87660161ca83765 Roll src-internal ce552ff5de4f..ccf524e79fe7 (1 commits) chromium-internal-autoroll, Mon Mar 18 03:07:46 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 4c428bdc69a2c16fdb0c5576e4098373bd6cc4e3 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 18 03:31:30 2019 +0000 Gardening: media/controls/controls-layout-in-different-size.html is slow It takes 4-6 seconds to run on a release bot, so it sometimes times out. Bug: 942951 TBR: jazzhsu No-Try: true Change-Id: If2915735384ce5ec3ae1698b9505022d45510d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527904 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641515} third_party/blink/web_tests/SlowTests | 3 +++ 1 file changed, 3 insertions(+) commit 323134b4c16c23e6bd9b8ec16abc0073b4274456 Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Mar 18 03:30:20 2019 +0000 service worker: Improve WPT tests for async respondWith/waitUntil. See discussion at [1] and [2]. This makes the following changes. 1. Adds a test for: self.addEventListener('fetch', e => { Promise.resolve().then(() => { e.respondWith(new Response('hi')); }); }); This should not throw because respondWith() is called while the event dispatch flag is still set. The microtask checkpoint is in "Cleanup After Running Scripts" here: https://html.spec.whatwg.org/multipage/webappapis.html#clean-up-after-running-script This is called from step 16.2 here: https://heycam.github.io/webidl/#call-a-user-objects-operation Which in turn is called from the DOM spec's "Inner Invoke" to call event targets: https://dom.spec.whatwg.org/#concept-event-listener-inner-invoke 2. Changes the expectation for: addEventListener('message', event => { Promise.resolve().then(event.waitUntil(p)); }); From throws to not throws, for the same reasoning as above. 3. Changes the expectation for: addEventListener('message', event => { waitPromise = Promise.resolve(); event.waitUntil(waitPromise); waitPromise.then(() => { Promise.resolve().then(() => {event.waitUntil();}); }); }); From throws to not throws. This is subtle. Because all the promises are just Promise.resolve(), the event dispatch flag is still set by the time the second waitUntil() is called. 4. To test what 3. originally intended, a new test is added which makes waitPromise a promise that does not immediately resolve. 5. Changes the expectation for: addEventListener(‘fetch’, event => { response = Promise.resolve(new Response('RESP')); event.respondWith(response); response.then(() => { Promise.resolve().then(() => {event.waitUntil();}); }) }); Again this is because the promises used resolve immediately, so the event dispatch flag is still set. Similarly, a new test is added to cover the original intent. These WPT changes appear to match the behavior of Safari and Edge while diverging from Chrome and (partially) Firefox. [1] https://github.com/w3c/ServiceWorker/issues/1213 [2] https://github.com/w3c/ServiceWorker/issues/1394 Bug: 942414 Change-Id: I9a4a56d71d3919ed614ff78df2bdc6cc0251dadd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524393 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#641514} third_party/blink/web_tests/TestExpectations | 5 + ...ndable-event-async-waituntil.https-expected.txt | 17 +++ .../extendable-event-async-waituntil.https.html | 49 ++++++--- .../fetch-event-async-respond-with.https.html | 85 +++++++++------ .../resources/extendable-event-async-waituntil.js | 116 ++++++++++++++++++--- .../fetch-event-async-respond-with-worker.js | 67 +++++++++--- 6 files changed, 265 insertions(+), 74 deletions(-) Updated tag 'tree_truth' (was e81fdb9bce80)