Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 39633 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918636578629731104 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itLgd619/luci_context.907766673 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2229-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43aa349482c85e11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 215c32e9abe8ae9bb30706aa337982e42e46ebfc ozone: demo: Use PlatformWindowSurface in ozone_demo Michael Spang, Mon Mar 18 15:20:07 2019 +0000 e2787d5e525e9d5c2a2fa494870ca56d0be4ce69 Make WPT's .gitignore only ignore the testharness_runner.html in the root dir. Luke Zielinski, Mon Mar 18 15:17:26 2019 +0000 6a40c4f5a8139ce93bfd8d207643d1a7f2799dba Roll src/third_party/skia 2c043c288169..cfea834b8da6 (1 commits) chromium-autoroll, Mon Mar 18 15:16:02 2019 +0000 165fea1563b46c6a5daa447a76716162dd7ebbd5 Disable very flaky facebook and voicememos tests for loading.mobile Annie Sullivan, Mon Mar 18 15:15:10 2019 +0000 3b78caac8ef67c41c3b4994c9807449ac4a305ec [ios]Move GREYAssert out of helper and into test Lindsay Pasricha, Mon Mar 18 15:14:31 2019 +0000 a6f2e18dfeadd7e903f23076b70b318964e9e024 Remove use_drfuzz. Nico Weber, Mon Mar 18 15:09:25 2019 +0000 ba1cae6b5d69788d8124b1ac27f17e05cfde8337 Fix notification border on Windows and ChromeOS. Richard Knoll, Mon Mar 18 15:07:15 2019 +0000 633d6d588e0d481f0e942a477716bc8ee25fc1e0 sync_ui_util: Handle UPGRADE_CLIENT error more explicitly Marc Treib, Mon Mar 18 15:04:43 2019 +0000 7f4dc0d178c3173ebe83d39ec2785b4b72276784 [Autofill] Cleaned up a few minor issues. Caitlin Fischer, Mon Mar 18 15:03:53 2019 +0000 c8e238b6a91261e6e45835b83c109023bb498f7f [Locked Fullscreen] Disable page navigation in Locked Fullscreen mode Ivan Sandrk, Mon Mar 18 15:00:02 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 215c32e9abe8ae9bb30706aa337982e42e46ebfc Author: Michael Spang <spang@chromium.org> Date: Mon Mar 18 15:20:07 2019 +0000 ozone: demo: Use PlatformWindowSurface in ozone_demo This allows the demo to run on Fuchsia, and has no effect on other platforms. This does not quite work yet because we do not initialize mojo. Bug: 942745 Change-Id: Ife62b7db115f0dd35727884ef9748205d69e9820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526664 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641610} ui/ozone/demo/gl_renderer.cc | 34 +++++++++++++--------- ui/ozone/demo/gl_renderer.h | 6 +++- ui/ozone/demo/simple_renderer_factory.cc | 27 ++++++++++------- ui/ozone/demo/skia/skia_gl_renderer.cc | 10 +++++-- ui/ozone/demo/skia/skia_gl_renderer.h | 6 +++- ui/ozone/demo/skia/skia_renderer_factory.cc | 18 ++++++++---- ui/ozone/demo/skia/skia_surfaceless_gl_renderer.cc | 9 ++++-- ui/ozone/demo/skia/skia_surfaceless_gl_renderer.h | 9 ++++-- ui/ozone/demo/software_renderer.cc | 11 ++++--- ui/ozone/demo/software_renderer.h | 7 ++++- ui/ozone/demo/surfaceless_gl_renderer.cc | 33 +++++++++++---------- ui/ozone/demo/surfaceless_gl_renderer.h | 6 +++- ui/ozone/demo/vulkan_overlay_renderer.cc | 3 ++ ui/ozone/demo/vulkan_overlay_renderer.h | 6 +++- ui/ozone/demo/vulkan_renderer.cc | 33 ++++++++++++--------- ui/ozone/demo/vulkan_renderer.h | 8 +++-- 16 files changed, 148 insertions(+), 78 deletions(-) commit e2787d5e525e9d5c2a2fa494870ca56d0be4ce69 Author: Luke Zielinski <lpz@chromium.org> Date: Mon Mar 18 15:17:26 2019 +0000 Make WPT's .gitignore only ignore the testharness_runner.html in the root dir. This avoids ignoring $wpt/tools/wptrunner/wptrunner/testharness_runner.html, which is auto-imported and required to run WPT on Chromium CI. Bug: 937369 Change-Id: I75a15f7e848ffc50df9e38f1c2cfb5b5ac110358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527876 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#641609} third_party/blink/web_tests/external/wpt/.gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6a40c4f5a8139ce93bfd8d207643d1a7f2799dba Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 15:16:02 2019 +0000 Roll src/third_party/skia 2c043c288169..cfea834b8da6 (1 commits) https://skia.googlesource.com/skia.git/+log/2c043c288169..cfea834b8da6 git log 2c043c288169..cfea834b8da6 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 62758f581672..c2bb50b73101 (1 commits) Created with: gclient setdep -r src/third_party/skia@cfea834b8da6 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I5ac332323f3194cf1c7fb03bcd1ad8fdd10c58c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527419 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641608} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 165fea1563b46c6a5daa447a76716162dd7ebbd5 Author: Annie Sullivan <sullivan@chromium.org> Date: Mon Mar 18 15:15:10 2019 +0000 Disable very flaky facebook and voicememos tests for loading.mobile Bug: 942631 Change-Id: I64233f1edaa25832af7fdf7cda5585c1ed670527 TBR: crouleau@chromium.org NOTRY: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525307 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641607} tools/perf/expectations.config | 5 +++++ 1 file changed, 5 insertions(+) commit 3b78caac8ef67c41c3b4994c9807449ac4a305ec Author: Lindsay Pasricha <lindsayw@google.com> Date: Mon Mar 18 15:14:31 2019 +0000 [ios]Move GREYAssert out of helper and into test Moves GREYAssert out of loadURL and waitForWebViewContainingText so that debugging is easier in EG1 and to convert for EG2 so that loadURL can be an app side helper. Bug: 922813 Change-Id: I2236ff34295059bfe02e391ae265bea380900b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524681 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641606} ios/web/shell/test/context_menu_egtest.mm | 12 ++++++++---- ios/web/shell/test/earl_grey/shell_earl_grey.h | 9 +++++---- ios/web/shell/test/earl_grey/shell_earl_grey.mm | 13 ++++++------- ios/web/shell/test/page_state_egtest.mm | 8 +++++--- 4 files changed, 24 insertions(+), 18 deletions(-) commit a6f2e18dfeadd7e903f23076b70b318964e9e024 Author: Nico Weber <thakis@chromium.org> Date: Mon Mar 18 15:09:25 2019 +0000 Remove use_drfuzz. Nothing sets it, and it depended on Dr. Memory, which we removed a while ago. Depends on https://webrtc-review.googlesource.com/c/src/+/128222/ TBR=vasilii Bug: 566930,655521 Change-Id: Ifab2f0951a1c954e0efa7206611f7b823e7c0867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527323 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641605} BUILD.gn | 4 ++-- build/config/sanitizers/sanitizers.gni | 5 ----- .../core/browser/form_parsing/BUILD.gn | 2 +- testing/libfuzzer/BUILD.gn | 2 -- testing/libfuzzer/drfuzz_main.cc | 19 ------------------- testing/libfuzzer/fuzzer_test.gni | 2 +- 6 files changed, 4 insertions(+), 30 deletions(-) commit ba1cae6b5d69788d8124b1ac27f17e05cfde8337 Author: Richard Knoll <knollr@chromium.org> Date: Mon Mar 18 15:07:15 2019 +0000 Fix notification border on Windows and ChromeOS. This brings back notification borders on Windows. This has been done before in [http://crrev.com/c/1233014] but was missing a clip of the background which paints over the shadow otherwise. On ChromeOS the border is updated depending on the position in the notification center so we need to use GetContentsBounds to take that into account during layout. Bug: 914428,914433,882826 Change-Id: Iac7bbe46f6c55a5186e15189cbd92fa2473a5cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524348 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641604} ui/message_center/views/message_view.cc | 2 ++ ui/message_center/views/notification_view_md.cc | 21 ++++++++------------- 2 files changed, 10 insertions(+), 13 deletions(-) commit 633d6d588e0d481f0e942a477716bc8ee25fc1e0 Author: Marc Treib <treib@chromium.org> Date: Mon Mar 18 15:04:43 2019 +0000 sync_ui_util: Handle UPGRADE_CLIENT error more explicitly This makes use of two facts: 1) UPGRADE_CLIENT is the only type of actionable error that gets special treatment in sync_ui_util. 2) An UPGRADE_CLIENT actionable error always comes with an unrecoverable error. Together, these observations let us untangle things a bit. Bug: 940437, 911153 Change-Id: Ib262051133726f7ac0fdd8011bcda5d9c4cd5a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520672 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641603} chrome/browser/sync/sync_ui_util.cc | 135 ++++++++++++++---------------------- 1 file changed, 53 insertions(+), 82 deletions(-) commit 7f4dc0d178c3173ebe83d39ec2785b4b72276784 Author: Caitlin Fischer <caitlinfischer@google.com> Date: Mon Mar 18 15:03:53 2019 +0000 [Autofill] Cleaned up a few minor issues. Fixed a comment. Changed back_inserter to std::back_inserter. Removed an unnecessary #include. Change-Id: Iabf6a9c31d61bdaebcfd3d10e3a87e6f08161bb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527338 Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#641602} components/autofill/core/browser/contact_form_label_formatter.cc | 1 - components/autofill/core/browser/contact_form_label_formatter.h | 4 ++-- components/autofill/core/browser/label_formatter.cc | 3 ++- 3 files changed, 4 insertions(+), 4 deletions(-) commit c8e238b6a91261e6e45835b83c109023bb498f7f Author: Ivan Sandrk <isandrk@google.com> Date: Mon Mar 18 15:00:02 2019 +0000 [Locked Fullscreen] Disable page navigation in Locked Fullscreen mode Locked fullscreen mode is a special fullscreen mode used for administering quizzes to students on Chrome OS devices (where the user is basically locked inside of one browser window). To further lock down the mode (and fix the linked ChromeVox issue) we disable any links from being opened. Bug: 935668 Change-Id: Ia627a53fb7412888371a4be9851fdb8550537ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517699 Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641601} chrome/browser/platform_util.cc | 4 ++ chrome/browser/platform_util.h | 6 +++ chrome/browser/platform_util_chromeos.cc | 16 +++++++ chrome/browser/ui/browser_navigator.cc | 7 +++ .../ui/browser_navigator_browsertest_chromeos.cc | 50 ++++++++++++++++++++++ 5 files changed, 83 insertions(+) commit 726278c6d99b731e5604fe5bb5030b13b41c12dc Author: Yann Dago <ydago@chromium.org> Date: Mon Mar 18 14:59:55 2019 +0000 Extension UI: Hide 'Load unpacked' button if no extension is whitelisted Bug: 912577 Change-Id: Ieef966f29199f35f2494099bcae6cd4cc98e66a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524531 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#641600} .../extensions/api/developer_private/developer_private_api.cc | 4 ++-- chrome/browser/extensions/extension_management.cc | 11 +++++++++++ chrome/browser/extensions/extension_management.h | 5 +++++ 3 files changed, 18 insertions(+), 2 deletions(-) commit ef61fce8a0f96b1137ac421af5ddea8c05e1cc41 Author: Stephen McGruer <smcgruer@chromium.org> Date: Mon Mar 18 14:57:05 2019 +0000 Cleanup: Remove unused function in timing_calculations.h The passed-in 'parent phase' is always AnimationEffect::kPhaseActive (since we didn't actually implement parent phases at any point), so IsActiveInParentPhase was always just 'return true'. Bug: None Change-Id: Ief54256c82f7217d33196979f50a1ec206170ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527066 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#641599} .../renderer/core/animation/animation_effect.cc | 6 +-- .../renderer/core/animation/timing_calculations.h | 22 +---------- .../core/animation/timing_calculations_test.cc | 45 ++++++---------------- 3 files changed, 14 insertions(+), 59 deletions(-) commit 474b1d4cab6a0c1f6b0b20153e18205b739a90be Author: Adam Rice <ricea@chromium.org> Date: Mon Mar 18 14:56:22 2019 +0000 Mark fetch.tentative.html as flaky external/wpt/fetch/stale-while-revalidate/fetch.tentative.html is flaky. Add it to TestExpectations. Also include virtual/outofblink-cors/external/wpt/fetch/stale-while-revalidate/fetch.tentative.html. BUG=943095 Change-Id: I02ab09d8bb921228802e502aacb66eaef9874c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528132 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#641598} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit 69be71e10036d30d7924ee0c730fb848bef4a6f3 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Mar 18 14:48:40 2019 +0000 Mark heap snapshot test as slow The test never fails but is just slow and runs into timeouts. Bug: chromium:939037 Change-Id: I5b75dc4e3df15a8d0c291936497b1bce0fc034f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528245 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641597} third_party/blink/web_tests/SlowTests | 2 ++ third_party/blink/web_tests/TestExpectations | 4 ---- 2 files changed, 2 insertions(+), 4 deletions(-) commit 5e55c2f0a4eaa4166ac634ac96691c8fffa41dcd Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Mon Mar 18 14:48:30 2019 +0000 Clean up unnecessary Create() factory functions in platform/json As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/json and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ibeb9140708887b9232166e8b53d9f1fd1dcf2f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527950 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641596} .../core/frame/csp/content_security_policy.cc | 4 +- .../core/html/parser/xss_auditor_delegate.cc | 4 +- .../compositing/graphics_layer_tree_as_text.cc | 24 +++++----- .../blink/renderer/modules/crypto/subtle_crypto.cc | 4 +- .../filesystem/dev_tools_host_file_system.cc | 4 +- .../renderer/platform/geometry/geometry_as_json.h | 8 ++-- .../compositing/content_layer_client_impl.cc | 10 ++--- .../compositing/paint_artifact_compositor.cc | 4 +- .../renderer/platform/graphics/logging_canvas.cc | 37 ++++++++-------- .../graphics/paint/clip_paint_property_node.cc | 2 +- .../platform/graphics/paint/display_item.cc | 2 +- .../platform/graphics/paint/display_item_list.cc | 4 +- .../graphics/paint/effect_paint_property_node.cc | 2 +- .../graphics/paint/paint_controller_debug_data.cc | 8 ++-- .../graphics/paint/raster_invalidation_tracking.cc | 10 ++--- .../graphics/paint/scroll_paint_property_node.cc | 4 +- .../paint/transform_paint_property_node.cc | 2 +- .../blink/renderer/platform/json/json_parser.cc | 14 +++--- .../blink/renderer/platform/json/json_values.cc | 28 ++++++------ .../blink/renderer/platform/json/json_values.h | 51 ++++++---------------- .../platform/transforms/transformation_matrix.cc | 10 ++--- 21 files changed, 105 insertions(+), 131 deletions(-) commit 172253bbbf57074f652b3856b2640f2a66774a34 Author: David Roger <droger@chromium.org> Date: Mon Mar 18 14:46:54 2019 +0000 [signin] Dont create AccountConsistencyModeManager for guest sessions This was causing a crash because AccountConsistencyModeManager CHECKS that the account consistency mode doesn't change after initialization. However, the guest session changes the kSigninAllowed preference after startup, which causes the account consistency mode to change. Bug: 940026 Change-Id: I3e37c4facd70151d03afea1765a288269c3bc8d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526020 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#641595} .../signin/account_consistency_mode_manager.cc | 23 ++++++++++++++-------- .../signin/account_consistency_mode_manager.h | 5 +++++ .../account_consistency_mode_manager_factory.cc | 7 +++++-- .../account_consistency_mode_manager_unittest.cc | 6 ++++++ 4 files changed, 31 insertions(+), 10 deletions(-) commit f8103f6f8d0233d709ad692862c2dcdc3c592cbd Author: Tim Song <tengs@chromium.org> Date: Mon Mar 18 14:44:32 2019 +0000 Reland "Ash Tray: Fix tray bubble opening on another display." This is a reland of 464d6f6e5243d9b754cd2caa629fd83f3b3a6ec6 Original change's description: > Ash Tray: Fix tray bubble opening on another display. > > An off-by-one error caused the anchor bounds of the bubble to be inside > the bounds of the next display rather than the current display, causing > the bubble to be shown on the wrong display. > > This regression was caused by http://crrev/c/1474278. > > TEST=manually verified & new unit test case > BUG=937420 > > Change-Id: I6a248a785ea1ee36bdbb8ab75853efba71938272 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526383 > Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> > Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> > Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641288} Bug: 937420 Change-Id: Ib49e87142e988276aae5ba31a05f30713f765fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528061 Auto-Submit: Tim Song <tengs@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641594} ash/extended_desktop_unittest.cc | 15 ++++++++--- ash/shelf/shelf.cc | 9 ++++--- .../unified/unified_slider_bubble_controller.cc | 6 ++++- ash/system/unified/unified_system_tray_bubble.cc | 6 ++++- ash/system/unified/unified_system_tray_unittest.cc | 29 ++++++++++++++++++++++ 5 files changed, 56 insertions(+), 9 deletions(-) commit 4c768b89da6973c6d3ff31d22179225e25a93d4a Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Mon Mar 18 14:44:07 2019 +0000 Clean up unnecessary Create() factory functions in platform/text As advised in [1], this CL removes unnecessary Foo::Create() in //third_party/blink/renderer/platform/text and make their constructors public, then make the callers use std::make_unique<Foo> instead of their Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ib30ac5fe0707fa727a713a41e630d823929a479f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527916 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641593} third_party/blink/renderer/platform/text/locale_icu.cc | 6 +----- third_party/blink/renderer/platform/text/locale_icu.h | 3 +-- .../blink/renderer/platform/text/locale_icu_test.cc | 16 ++++++++-------- .../renderer/platform/text/text_break_iterator_icu.cc | 6 +----- 4 files changed, 11 insertions(+), 20 deletions(-) commit 14f74347a65cb47c9a92005b818b057fff0db1e1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 14:43:26 2019 +0000 Roll src/third_party/webrtc df644be3536b..6d83592367c2 (4 commits) https://webrtc.googlesource.com/src.git/+log/df644be3536b..6d83592367c2 git log df644be3536b..6d83592367c2 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 jonaso@webrtc.org Improve handling of packets with unknown ssrc. 2019-03-18 kwiberg@webrtc.org Make the stacktrace unit test more robust 2019-03-18 titovartem@google.com Reduce smoke test video resolution. 2019-03-18 oprypin@webrtc.org [build] Port: Use CIPD packages for GN instead of GCS Created with: gclient setdep -r src/third_party/webrtc@6d83592367c2 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:855791 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia0c8b47a362b0897a64996d63afa1300229d7f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527416 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641592} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c83861b020ecab8368aab72b78405cae6263d402 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Mon Mar 18 14:42:10 2019 +0000 PM: Start renaming {cu|coordination_unit}->node. This renames most of the cases where we use _cu or _coordination_unit or CoordinationUnit to _node or Node. Additionally renames the DestroyNode and OnBeforeDestroyNode to Remove. Bug: 910288 Change-Id: I7ecf4661f47ac52a272e553ac359fd5f0fd4b128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526342 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#641591} .../decorators/page_almost_idle_decorator.h | 2 +- .../page_almost_idle_decorator_test_utils.cc | 4 +- .../page_almost_idle_decorator_unittest.cc | 22 +-- chrome/browser/performance_manager/graph/README.md | 3 +- .../performance_manager/graph/frame_node_impl.cc | 125 ++++++------ .../performance_manager/graph/frame_node_impl.h | 35 ++-- .../graph/frame_node_impl_unittest.cc | 157 +++++++-------- chrome/browser/performance_manager/graph/graph.cc | 41 ++-- chrome/browser/performance_manager/graph/graph.h | 10 +- .../graph/graph_introspector_impl.cc | 26 +-- .../performance_manager/graph/graph_test_harness.h | 17 +- .../performance_manager/graph/graph_unittest.cc | 6 +- .../graph/node_attached_data_unittest.cc | 79 ++++---- .../browser/performance_manager/graph/node_base.cc | 2 +- .../graph/node_base_unittest.cc | 84 ++++---- .../performance_manager/graph/page_node_impl.cc | 108 +++++----- .../performance_manager/graph/page_node_impl.h | 18 +- .../graph/page_node_impl_unittest.cc | 219 ++++++++++----------- .../performance_manager/graph/process_node_impl.cc | 42 ++-- .../performance_manager/graph/process_node_impl.h | 12 +- .../graph/process_node_impl_unittest.cc | 70 ++++--- .../graph/system_node_impl_unittest.cc | 90 +++++---- .../observers/coordination_unit_graph_observer.h | 52 +++-- .../coordination_unit_graph_observer_unittest.cc | 57 +++--- .../observers/metrics_collector.cc | 106 +++++----- .../observers/metrics_collector.h | 22 +-- .../observers/metrics_collector_unittest.cc | 141 +++++++------ .../observers/page_signal_generator_impl.cc | 8 +- .../observers/page_signal_generator_impl.h | 12 +- .../page_signal_generator_impl_unittest.cc | 60 +++--- .../observers/working_set_trimmer_win.cc | 10 +- .../observers/working_set_trimmer_win.h | 4 +- .../observers/working_set_trimmer_win_unittest.cc | 17 +- .../performance_manager/performance_manager.cc | 2 +- .../webui_graph_dump_impl_unittest.cc | 6 +- 35 files changed, 810 insertions(+), 859 deletions(-) commit f3ca8671852c7c804aa5c59e75a12bca5e683e02 Author: Peter Wen <wnwen@chromium.org> Date: Mon Mar 18 14:40:31 2019 +0000 Android: Update android_deps for test targets - Add testonly targets through testCompile dependencies - Plumb through testOnly and licenseAndroidCompatible - Add logic allowing generated targets to depend on existing third_party libs (junit and hamcrest). Bug: 913062 Change-Id: I9edc1f291f4979861370cf98bc311fd73dbb5fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524401 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641590} third_party/android_deps/BUILD.gn | 8 +++-- .../androidx_annotation_annotation/README.chromium | 4 +-- .../README.chromium | 4 +-- .../libs/androidx_test_core/README.chromium | 4 +-- .../libs/androidx_test_ext_junit/README.chromium | 4 +-- .../libs/androidx_test_monitor/README.chromium | 4 +-- .../android_deps/libs/com_google_ar_core/LICENSE | 37 ++++++++++---------- tools/android/roll/android_deps/build.gradle | 6 ++-- .../src/main/groovy/BuildConfigGenerator.groovy | 34 ++++++++++++++----- .../src/main/groovy/ChromiumDepGraph.groovy | 39 +++++++++++++++------- .../buildSrc/src/main/groovy/ChromiumPlugin.groovy | 5 ++- 11 files changed, 93 insertions(+), 56 deletions(-) commit 6438c3178cc63c8bb46f2cb66ff4d77ece01c997 Author: Sam Maier <smaier@chromium.org> Date: Mon Mar 18 14:39:36 2019 +0000 Android: Strip drawables from Play Services libraries Bug: 921154 Change-Id: Ibc651458afb8b92053330b40d778c79d2773034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516672 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641589} build/android/gyp/prepare_resources.py | 38 ++++++++++---- build/config/android/internal_rules.gni | 4 ++ build/config/android/rules.gni | 28 +++++++--- third_party/android_deps/BUILD.gn | 60 ++++++++++++++++++++++ .../src/main/groovy/BuildConfigGenerator.groovy | 9 ++++ 5 files changed, 120 insertions(+), 19 deletions(-) commit 05956259a6876f54dfba2f68b9af0b449e0c7b58 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Mon Mar 18 14:39:21 2019 +0000 MemoryPurgeManager: Only count WebView pages towards the total page count AreAllPagesFrozen() is implemented by keeping track of total number of pages in a renderer and the number of frozen pages in the same renderer. However, pages that are not owned by a WebViewImpl cannot be frozen. For example, SVG images and validation message overlays create pages that cannot be frozen. In some cases, this results in the number of frozen pages always being smaller than the total number of pages counted, preventing us from performing a memory purge. An example of a website that encounters this issue is Google News, which creates two pages. One owned by the WebViewImpl, and an SVG image. When freezing this site, only the first page is frozen and we always have one "unfrozen" page (the SVG image). Pages owned by a WebViewImpl are referred to as "ordinary" pages. In order to ensure that AreAllPagesFrozen() works as intended, we should only count ordinary pages towards the count of all pages in MemoryPurgeManager. This approach was implemented by introducing an IsOrdinary() method to PageScheduler::Delegate. This method can then be checked at the appropriate time, to ensure correct accounting. Bug: 926186 Change-Id: I33c04ba6841338546ea857850ba52303808a9a0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524710 Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Cr-Commit-Position: refs/heads/master@{#641588} .../blink/renderer/core/exported/web_page_popup_impl.cc | 2 +- .../blink/renderer/core/inspector/inspector_overlay_agent.cc | 2 +- third_party/blink/renderer/core/page/page.cc | 11 +++++++++-- third_party/blink/renderer/core/page/page.h | 6 +++++- .../renderer/core/page/validation_message_overlay_delegate.cc | 2 +- third_party/blink/renderer/core/svg/graphics/svg_image.cc | 2 +- third_party/blink/renderer/core/testing/dummy_page_holder.cc | 2 +- .../scheduler/main_thread/main_thread_scheduler_impl.cc | 11 ++++++++--- .../platform/scheduler/main_thread/page_scheduler_impl.cc | 9 +++++++++ .../platform/scheduler/main_thread/page_scheduler_impl.h | 4 ++++ .../blink/renderer/platform/scheduler/public/page_scheduler.h | 2 ++ 11 files changed, 42 insertions(+), 11 deletions(-) commit 8a68b23250d180283739eca8ef95dd2f44f1e112 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Mar 18 14:30:26 2019 +0000 [Background Sync] Use min_delay across storage partitions. This is a reland of the CL: https://chromium-review.googlesource.com/c/chromium/src/+/1479230 with a fix for crbug.com/941808, which was happening because BackgroundSyncManager should be accessed on the IO thread only. The fix was to post a task from the UI to the IO thread to access BackgroundSyncManager and post a response back to the UI thread. Verified through manual testing on a Pixel device. Original change: Background Sync currently schedules Chrome to be woken up on Android to fire Background Sync events. We're currently scheduling/cancelling this task based on soonest_wakeup_delta from one storage partition, which means that the last storage partition to be processed overwrites these values. The task could also be cancelled by the last storage partition to be processed, if it had no pending background sync registrations. This CL fixes that by calculating soonest_wakeup_delta across all storage partitions for the profile. If this is set to MAX by all of them, we cancel the task, else we use the minimum wakeup delta to schedule when Chrome should be woken up. It also adds BackgroundSyncLauncher unit tests. Bug: 924490, 933849, Change-Id: I1017d822997ab96f6dc12aad8b210a1665465f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523397 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641587} .../android/background_sync_launcher_android.cc | 76 ++++------- .../android/background_sync_launcher_android.h | 22 ++-- .../background_sync_controller_impl.cc | 8 +- .../background_sync_controller_impl.h | 2 +- content/browser/BUILD.gn | 2 + .../background_sync_context_impl.cc | 63 ++++++++- .../background_sync/background_sync_context_impl.h | 16 ++- .../background_sync/background_sync_launcher.cc | 145 +++++++++++++++++++++ .../background_sync/background_sync_launcher.h | 59 +++++++++ .../background_sync_launcher_unittest.cc | 129 ++++++++++++++++++ .../background_sync/background_sync_manager.cc | 27 ++-- .../background_sync/background_sync_manager.h | 5 + .../background_sync_manager_unittest.cc | 17 ++- content/public/browser/background_sync_context.h | 34 ++++- .../public/browser/background_sync_controller.h | 13 +- content/test/BUILD.gn | 1 + content/test/mock_background_sync_controller.cc | 5 +- content/test/mock_background_sync_controller.h | 7 +- content/test/test_background_sync_manager.cc | 5 + content/test/test_background_sync_manager.h | 10 ++ 20 files changed, 523 insertions(+), 123 deletions(-) commit d85ac15f17d7dffc519057c2eb193eee96043650 Author: Danyao Wang <danyao@chromium.org> Date: Mon Mar 18 14:24:46 2019 +0000 [Payment Request] Fix validation order of PaymentCurrencyAmount. The "check and canonicalize amount" algorithm in the spec requires that the |currency| field is validated before the |amount| field. https://w3c.github.io/payment-request/#validity-checkers Without this patch, Chrome incorrectly throws TypeError instead of RangeError when both the currency and amount are invalid. With the patch, Chrome passes the currency validation tests in https://w3c-test.org/payment-request/PaymentRequestUpdateEvent/updateWith-method-abort-update-manual.https.html Also fixed a typo in WPT test name. Bug: 942656 Change-Id: I76b249bc1970740e0c3c9e2309bf2b9ce912450a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526434 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641586} .../blink/renderer/modules/payments/payment_request.cc | 12 ++++++------ .../updateWith-method-abort-update-manual.https.html | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) commit cc4b373be6b4675ab25fcb518093d90d089958ca Author: Alex Clarke <alexclarke@chromium.org> Date: Mon Mar 18 14:23:46 2019 +0000 Revert "Annotate NativeBackgroundTask.java as BOOTSTRAP tasks" This reverts commit d1867d9ae36b6e09c0ccb04830887bf2a10b9234. Reason for revert: We came to the conclusion these tasks are not on the critical path. Original change's description: > Annotate NativeBackgroundTask.java as BOOTSTRAP tasks > > In future this will prioritize them which will help ensure native is > loaded as soon as possible. > > Bug: 863341 > Change-Id: I93eb8d575adf0e68f5dd7e3554370e7588072beb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524272 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641176} TBR=alexclarke@chromium.org,agrieve@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 863341 Change-Id: Ia5a04205544f83fcbc36e4519ad3a39063d0e064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526191 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641585} .../background_task_scheduler/NativeBackgroundTask.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) commit 1fcca8c07c1418b7043c6f234bc82e69721a8701 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 14:23:35 2019 +0000 Roll src/third_party/swiftshader 62758f581672..c2bb50b73101 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/62758f581672..c2bb50b73101 git log 62758f581672..c2bb50b73101 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 bclayton@google.com ComputeProgram: Clean up usage of Float4/Int4 and SIMD::Float/SIMD::Int Created with: gclient setdep -r src/third_party/swiftshader@c2bb50b73101 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126126820 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I98d1bbf83c17946ffc2f82f091aba4ec9b14a814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526818 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641584} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 06bf266f84c4f7ea65a315c5399fc0f8cb2bcd3d Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 18 14:17:46 2019 +0000 clang: build dsymutil with thread support This avoids a message about trying to use a thread pool without threads during building, and might also speed up dsymutil. Bug: 943098 Change-Id: I120e9cdd00dfb655e0f5a28bd32c00b0fbf623ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527340 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641583} tools/clang/scripts/update.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 08ce76a20c68b49d9d3f76540741821d96335f5e Author: Adam Rice <ricea@chromium.org> Date: Mon Mar 18 14:14:02 2019 +0000 Virtualise ReadableStreamDefaultControllerWrapper Replace ReadableStreamDefaultControllerWrapper with ReadableStreamDefaultControllerInterface, a base class which ReadableStreamDefaultControllerWrapper implements. This will permit using a different implementation when native streams are enabled. The error() method had been erroneously renamed to GetError(). It is not a getter (it errors the stream), so change it back to Error(). BUG=902633 Change-Id: I56c6646de7fe0c7c1ded2f39f28276459ed6c9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525793 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#641582} .../renderer/core/fetch/body_stream_buffer.cc | 6 +- .../renderer/core/fetch/body_stream_buffer_test.cc | 2 +- .../fetch/readable_stream_bytes_consumer_test.cc | 2 +- third_party/blink/renderer/core/streams/BUILD.gn | 3 +- ...eadable_stream_default_controller_interface.cc} | 63 ++++++++++++-------- .../readable_stream_default_controller_interface.h | 67 ++++++++++++++++++++++ .../streams/readable_stream_operations_test.cc | 8 +-- .../renderer/core/streams/readable_stream_test.cc | 4 +- .../renderer/core/streams/test_underlying_source.h | 4 +- .../core/streams/underlying_source_base.cc | 5 +- .../renderer/core/streams/underlying_source_base.h | 6 +- 11 files changed, 125 insertions(+), 45 deletions(-) commit 8203655c713449abe981f9a10b7bcfafb248dc53 Author: Adam Rice <ricea@chromium.org> Date: Mon Mar 18 14:09:21 2019 +0000 Make WritableStreamNative methods needed by PipeTo public This CL just moves methods around and has no other changes. BUG=902633 Change-Id: Ifff2a1b3fbb42497028a5fb9b4f4377b7dcf656c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524802 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#641581} .../core/streams/writable_stream_default_writer.cc | 282 ++++++++++----------- .../core/streams/writable_stream_default_writer.h | 30 ++- .../core/streams/writable_stream_native.cc | 29 +-- .../renderer/core/streams/writable_stream_native.h | 12 +- 4 files changed, 180 insertions(+), 173 deletions(-) commit 91e6617ff23d78420a298e849bd1b5b33bac80cd Author: Egor Pasko <pasko@chromium.org> Date: Mon Mar 18 14:08:52 2019 +0000 Ignore orderfile when not using LLD for Android As discussed in http://crrev.com/c/1525173 the "!use_lld" configuration uses an orderfile in a misleading way: the orderfile does not have section expansions, so while it would reorder some _parts_, it probably won't result in any good properties added. Bug: 922460 Change-Id: I59279d046e66de7dca9f879e6acd8bce7911d594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528187 Reviewed-by: Matthew Cary <mattcary@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641580} chrome/android/BUILD.gn | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit f66bd4003032a6258fcfbed757f27bf2d4960ec2 Author: Peter Wen <wnwen@chromium.org> Date: Mon Mar 18 14:04:33 2019 +0000 Android: Move the rest of autofill_assistant Similar to features/tab_ui, move the rest of the java files under autofill_assistant under features/autofill_assistant and add it to chrome_java_sources through autofill_assistant's public sources. This allows all autofill_assistant related feature work to go in under features/autofill_assistant, completing the migration from chrome_java. Bug: 846440 Change-Id: Ifc7a98c036c953c14b402716e2e1b3f32ed5527b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523578 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641579} WATCHLISTS | 3 +-- chrome/android/BUILD.gn | 2 +- chrome/android/features/autofill_assistant/public/java/DEPS | 3 +++ .../browser/autofill_assistant/AutofillAssistantClient.java | 0 .../browser/autofill_assistant/AutofillAssistantFacade.java | 0 .../browser/autofill_assistant/AutofillAssistantMetrics.java | 0 .../autofill_assistant/AutofillAssistantPreferencesUtil.java | 0 .../features/autofill_assistant/public/java_sources.gni | 10 ++++++++++ .../src/org/chromium/chrome/browser/autofill_assistant/OWNERS | 1 - chrome/android/java_sources.gni | 7 +++---- 10 files changed, 18 insertions(+), 8 deletions(-) Updated tag 'tree_truth' (was 0fc91f390b41)