Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 46033 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918606524157687744 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/it0BxSJF/luci_context.394275549 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2233-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43abea00379e3011 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: ddf870ba8d01cd04357db9ae6a480d75a7e2f398 [Chromeshine] Hook up in-memory components to persistence Patrick Noland, Mon Mar 18 23:06:10 2019 +0000 b485ce0d14da468eae2e0042cb110f86af51c692 Change unsigned long to uint32_t/size_t in third_party/blink/renderer/modules/indexeddb/ Miyoung Shin, Mon Mar 18 23:00:38 2019 +0000 034404fdfa28b23c87729ea83dda01c0f3c5d7c5 Fix the crash bug by the overflow in LayoutFrameSet. Miyoung Shin, Mon Mar 18 23:00:35 2019 +0000 9e8687f45cee16d54fb14e25eccdb2b9277a9b30 [Chromecast][BLE] Enable change GATT Client connectability Tiansong Cui, Mon Mar 18 22:51:14 2019 +0000 8edbbaf99bf4c5a644f2791aae0912bf1392f456 Ensure BaseView correctly processes captured NSLeftMouseUp. Trent Apted, Mon Mar 18 22:32:21 2019 +0000 e613f9e78b0f43a2eff084aab079b00b4083ec11 [ios] Sets badge to Selected state while InfobarBanner is being presented. sczs, Mon Mar 18 22:28:42 2019 +0000 3c2c55134ec4613d23965df322926fa3beaf6100 Uprev min env version for rtanalytics-light and rtanalytics-full. Luke Sorenson, Mon Mar 18 22:27:55 2019 +0000 25530944fc15bd97c9820623f559cc5783d29551 Update ServiceWorkerAggressiveCodeCache fieldtrial testing config Kenichi Ishibashi, Mon Mar 18 22:23:51 2019 +0000 89403f2679a259daf76c3c35f93085b0d21f8535 Revert "[Android] Inflate toolbar stub on a BG thread" Mohamed Heikal, Mon Mar 18 22:06:58 2019 +0000 44049eb7a2da9f01fb618c226ef99d7c0d3ffcc2 Revert "[Background Sync] Use min_delay across storage partitions." Sky Malice, Mon Mar 18 22:03:25 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit ddf870ba8d01cd04357db9ae6a480d75a7e2f398 Author: Patrick Noland <pnoland@chromium.org> Date: Mon Mar 18 23:06:10 2019 +0000 [Chromeshine] Hook up in-memory components to persistence (the correct patch this time) This CL makes a large number changes to account for the fact that UsageStatsService operations are now async. The major upshot is that promises are used instead of actual values. If data has been loaded, then promises are fulfilled immediately. Otherwise, they're fulfilled once the database is loaded. There is a corresponding downstream change that adjusts UsageStatsBrowserService to account for this. There are also a couple bug fixes; usage stats database needs to split its databases into different folders, so that is fixed. Bug: 939456 Change-Id: I63ed0a33b0545f017af48d9a4e1f0ec9b2381a6f TBR: fgorski@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529522 Reviewed-by: Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#641783} .../chrome/browser/usage_stats/EventTracker.java | 113 ++++++++++++++---- .../browser/usage_stats/PageViewObserver.java | 27 ++--- .../browser/usage_stats/SuspensionTracker.java | 78 ++++++++++--- .../chrome/browser/usage_stats/TokenTracker.java | 126 ++++++++++++++------- .../browser/usage_stats/UsageStatsBridge.java | 4 +- .../browser/usage_stats/UsageStatsService.java | 53 ++++++--- .../browser/usage_stats/EventTrackerTest.java | 53 +++++++-- .../browser/usage_stats/PageViewObserverTest.java | 3 + .../android/usage_stats/usage_stats_database.cc | 32 +++--- 9 files changed, 356 insertions(+), 133 deletions(-) commit b485ce0d14da468eae2e0042cb110f86af51c692 Author: Miyoung Shin <myid.shin@igalia.com> Date: Mon Mar 18 23:00:38 2019 +0000 Change unsigned long to uint32_t/size_t in third_party/blink/renderer/modules/indexeddb/ - unsigned long -> uint32_t/size_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: I62b8f0114b9202f1bfdee2f8993be331adc894b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528128 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641782} third_party/blink/renderer/modules/indexeddb/idb_index.cc | 4 ++-- third_party/blink/renderer/modules/indexeddb/idb_index.h | 4 ++-- third_party/blink/renderer/modules/indexeddb/idb_object_store.cc | 4 ++-- third_party/blink/renderer/modules/indexeddb/idb_object_store.h | 4 ++-- third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.cc | 2 +- third_party/blink/renderer/modules/indexeddb/web_idb_cursor_impl.h | 2 +- .../renderer/modules/indexeddb/web_idb_database_impl_unittest.cc | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) commit 034404fdfa28b23c87729ea83dda01c0f3c5d7c5 Author: Miyoung Shin <myid.shin@igalia.com> Date: Mon Mar 18 23:00:35 2019 +0000 Fix the crash bug by the overflow in LayoutFrameSet. The overflow of the integer type would make the crash since base::CheckedNumeric was added at https://crrev.com/c/1520847, and the previous patch pulled out the potential crash issue by clusterfuzz. This patch changes int type to int64_t for a total fixed size of the grid's columns because each column could have a maximum value of |int| type. Fuzzer report: https://clusterfuzz.com/testcase?key=5705475707502592 Bug: 942821 Change-Id: If64e91dd940a5e6d8d4c5b42fc94776074c7a61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526065 Reviewed-by: Steve Kobes <skobes@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641781} third_party/blink/renderer/core/layout/layout_frame_set.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 9e8687f45cee16d54fb14e25eccdb2b9277a9b30 Author: Tiansong Cui <tiansong@google.com> Date: Mon Mar 18 22:51:14 2019 +0000 [Chromecast][BLE] Enable change GATT Client connectability This CL also fixes the issue that callback never gets executed if remote device Connect fails at initial request. Bug: internal b/128708044 Bug: internal b/128536732 Bug: internal b/128464672 Test: cast_bluetooth_unittests, manual Change-Id: I3ce09b18275d8aaac46a74310fe99414eac45488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526799 Auto-Submit: Tiansong Cui <tiansong@google.com> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Reviewed-by: Bailey Forrest <bcf@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#641780} .../bluetooth/le/gatt_client_manager_impl.cc | 45 +++++++++++--- .../device/bluetooth/le/gatt_client_manager_impl.h | 13 ++++ .../bluetooth/le/gatt_client_manager_impl_test.cc | 71 +++++++++++++++++++++- .../device/bluetooth/le/remote_device_impl.cc | 12 ++-- 4 files changed, 125 insertions(+), 16 deletions(-) commit 8edbbaf99bf4c5a644f2791aae0912bf1392f456 Author: Trent Apted <tapted@chromium.org> Date: Mon Mar 18 22:32:21 2019 +0000 Ensure BaseView correctly processes captured NSLeftMouseUp. BaseView provides a -mouseEvent: override that funnels all mouse event subtypes into one method, after some subtype-specific pre-processing. Subclasses override -mouseEvent:, but do not call the base class implementation (which does nothing). Mouse events received via Widget::SetCapture() currently bypass the pre-processing done by BaseView. An important step missed is the one that handles logic around the suppression of NSMouseExited until a mouse-up is observed. Currently, an NSLeftMouseUp in SetCapture() incorrectly leaves the suppression in place. To fix, provide -handleLeftMouseUp: so that events received via capture can apply the correct logic. Principally, this affects the OverlayWindowViews Widget subclass used for Picture-in-Picture. Native mouse-enter/exit events don't normally propagate to individual Views, but PiP has hooks into views::Widget via this subclass to observe them. Bug: 942452 Test: views_unittests NativeWidgetMacTest.CapturedMouseUpClearsDrag Change-Id: I3d256dca295f374f70dd11844a4848b6b68feec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527902 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#641779} ui/base/cocoa/base_view.h | 6 +++ ui/base/cocoa/base_view.mm | 39 ++++++++++-------- ui/events/test/cocoa_test_event_utils.h | 4 +- ui/events/test/cocoa_test_event_utils.mm | 16 ++++---- ui/views/widget/native_widget_mac_unittest.mm | 59 +++++++++++++++++++++++++++ ui/views_bridge_mac/bridged_content_view.mm | 8 ++-- 6 files changed, 103 insertions(+), 29 deletions(-) commit e613f9e78b0f43a2eff084aab079b00b4083ec11 Author: sczs <sczs@chromium.org> Date: Mon Mar 18 22:28:42 2019 +0000 [ios] Sets badge to Selected state while InfobarBanner is being presented. - The InfobarBadge will now be on selected State when the InfobarBanner is being presented. Screenshot: https://drive.google.com/open?id=1Jy9Y9jo7IMmZ-sbEcxSJ-r-ExRq2yURV Bug: 911864 Change-Id: Ic5e32ec78c835f86d4200033486f0d7d3da4d8df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526687 Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641778} ios/chrome/browser/infobars/infobar_badge_tab_helper.h | 2 ++ ios/chrome/browser/infobars/infobar_badge_tab_helper.mm | 8 +++++++- .../ui/infobars/coordinators/infobar_confirm_coordinator.mm | 1 + .../ui/infobars/coordinators/infobar_password_coordinator.mm | 1 + ios/chrome/browser/ui/infobars/infobar_badge_ui_delegate.h | 3 +++ ios/chrome/browser/ui/infobars/infobar_container_mediator.mm | 11 +++++++++++ 6 files changed, 25 insertions(+), 1 deletion(-) commit 3c2c55134ec4613d23965df322926fa3beaf6100 Author: Luke Sorenson <lasoren@chromium.org> Date: Mon Mar 18 22:27:55 2019 +0000 Uprev min env version for rtanalytics-light and rtanalytics-full. Will merge back to M74 since M73 was env version 9.0 Bug: 943281 Test: Not necessary. Change-Id: I3a3cd16b2aca2073d4b13a9e02c32ac0a0226269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529519 Reviewed-by: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#641777} chrome/browser/component_updater/cros_component_installer_chromeos.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 25530944fc15bd97c9820623f559cc5783d29551 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Mar 18 22:23:51 2019 +0000 Update ServiceWorkerAggressiveCodeCache fieldtrial testing config Re-enabling the experiment on beta. Bug: 915081 Change-Id: I98cef800047ea502bf46eb7f15dc2a5dd6876b22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527910 Reviewed-by: Jesse Doherty <jwd@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641776} testing/variations/fieldtrial_testing_config.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 89403f2679a259daf76c3c35f93085b0d21f8535 Author: Mohamed Heikal <mheikal@chromium.org> Date: Mon Mar 18 22:06:58 2019 +0000 Revert "[Android] Inflate toolbar stub on a BG thread" This reverts commit 4f0ac5703fb84e357fd43736589e84b87385f7ee. Reason for revert: Experiment showed not-so-good results Original change's description: > [Android] Inflate toolbar stub on a BG thread > > Toolbar inflation currently takes around 200-300ms on the critical path during > startup. This cl creates the class AsyncViewStub so that the toolbar stub is > inflated on a background thread outside of the critical path. This leads to an > improvement of 60ms for startup and 50ms for startup to contentful paint. > > Improvements are less than the 200ms being saved due to the remeasure+redraw > caused by adding new views to the view hierarchy after startup. > > Design doc https://docs.google.com/document/d/1lwfhlWqp6os_QhikuqCx60LW5FdSbJ-40Es8ACGd4fI/edit?usp=sharing > > Change-Id: I1841f5adbb01a853e952b2e61dedfd4c951e125e > Bug: 762120 > Reviewed-on: https://chromium-review.googlesource.com/1136797 > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584551} Bug: 762120 Change-Id: I5f85b20a796b8bf5d0bfdd4b8962cf3342700e00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519076 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#641775} .../android/java/res/layout/control_container.xml | 2 +- chrome/android/java/res/values/attrs.xml | 8 - .../chromium/chrome/browser/ChromeFeatureList.java | 1 - .../preferences/ChromePreferenceManager.java | 6 +- .../chrome/browser/toolbar/ToolbarManager.java | 197 +++++++++------------ .../toolbar/top/ToolbarControlContainer.java | 18 +- .../browser/toolbar/top/TopToolbarCoordinator.java | 92 +++++----- .../chrome/browser/util/FeatureUtilities.java | 25 --- chrome/browser/android/chrome_feature_list.cc | 4 - chrome/browser/android/chrome_feature_list.h | 1 - 10 files changed, 130 insertions(+), 224 deletions(-) commit 44049eb7a2da9f01fb618c226ef99d7c0d3ffcc2 Author: Sky Malice <skym@chromium.org> Date: Mon Mar 18 22:03:25 2019 +0000 Revert "[Background Sync] Use min_delay across storage partitions." This reverts commit 8a68b23250d180283739eca8ef95dd2f44f1e112. Reason for revert: DCHECK in background_sync_manager.cc on x86 Android emulators, see crbug.com/943264 Original change's description: > [Background Sync] Use min_delay across storage partitions. > > This is a reland of the CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1479230 > with a fix for crbug.com/941808, which was happening because > BackgroundSyncManager should be accessed on the IO thread only. > The fix was to post a task from the UI to the IO thread to access > BackgroundSyncManager and post a response back to the UI thread. > > Verified through manual testing on a Pixel device. > > Original change: > > Background Sync currently schedules Chrome to be woken up on Android to > fire Background Sync events. We're currently scheduling/cancelling this > task based on soonest_wakeup_delta from one storage partition, which > means that the last storage partition to be processed overwrites these > values. The task could also be cancelled by the last storage partition > to be processed, if it had no pending background sync registrations. > > This CL fixes that by calculating soonest_wakeup_delta across all > storage partitions for the profile. If this is set to MAX by all of > them, we cancel the task, else we use the minimum wakeup delta to > schedule when Chrome should be woken up. > > It also adds BackgroundSyncLauncher unit tests. > > Bug: 924490, 933849, > Change-Id: I1017d822997ab96f6dc12aad8b210a1665465f08 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523397 > Commit-Queue: Mugdha Lakhani <nator@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Rayan Kanso <rayankans@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641587} TBR=avi@chromium.org,peter@chromium.org,dtrainor@chromium.org,nator@chromium.org,rayankans@chromium.org Change-Id: I37b58efd8f88538ea1ea8dc0b088d2a34e252849 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 924490, 933849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529528 Reviewed-by: Sky Malice <skym@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#641774} .../android/background_sync_launcher_android.cc | 76 +++++++---- .../android/background_sync_launcher_android.h | 22 ++-- .../background_sync_controller_impl.cc | 8 +- .../background_sync_controller_impl.h | 2 +- content/browser/BUILD.gn | 2 - .../background_sync_context_impl.cc | 63 +-------- .../background_sync/background_sync_context_impl.h | 16 +-- .../background_sync/background_sync_launcher.cc | 145 --------------------- .../background_sync/background_sync_launcher.h | 59 --------- .../background_sync_launcher_unittest.cc | 129 ------------------ .../background_sync/background_sync_manager.cc | 27 ++-- .../background_sync/background_sync_manager.h | 5 - .../background_sync_manager_unittest.cc | 17 +-- content/public/browser/background_sync_context.h | 34 +---- .../public/browser/background_sync_controller.h | 13 +- content/test/BUILD.gn | 1 - content/test/mock_background_sync_controller.cc | 5 +- content/test/mock_background_sync_controller.h | 7 +- content/test/test_background_sync_manager.cc | 5 - content/test/test_background_sync_manager.h | 10 -- 20 files changed, 123 insertions(+), 523 deletions(-) commit 1523cdb4849797bc4b7467e290970468c8ca8f07 Author: Michael Spang <spang@chromium.org> Date: Mon Mar 18 22:01:55 2019 +0000 ozone: demo: Initialize mojo We need to initialize mojo for platforms that use it such as scenic, otherwise we'll crash on the first call to a mojo API. Bug: 942745 Change-Id: I7b181f41b79933a81d46eb49fed4dc38dd32ba5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526665 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641773} ui/ozone/demo/BUILD.gn | 2 ++ ui/ozone/demo/DEPS | 1 + ui/ozone/demo/ozone_demo.cc | 21 +++++++++++++++++++-- ui/ozone/demo/simple_renderer_factory.cc | 11 ++--------- ui/ozone/demo/simple_renderer_factory.h | 3 --- ui/ozone/demo/skia/skia_demo.cc | 19 +++++++++++++++++++ ui/ozone/demo/skia/skia_renderer_factory.cc | 8 +------- ui/ozone/demo/skia/skia_renderer_factory.h | 3 --- 8 files changed, 44 insertions(+), 24 deletions(-) commit 670d282df5559c9e4c9d64c739623a7f2723d018 Author: Mario Sanchez Prada <mario@igalia.com> Date: Mon Mar 18 21:52:41 2019 +0000 Migrate //remoting/protocol to net::CompletionRepeatingCallback While working on CL1524492, I've found that nearly all the occurrences of net::CompletionCallback required repeating callbacks, so this is a quick CL to make that explicit, and use net::CompletionRepeatingCallback(). Bug: 714018, 807724 Change-Id: Ib5e05a3ff4da15206e63f8d0eff545919d9e9b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529052 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#641772} remoting/protocol/channel_socket_adapter.cc | 19 ++++++++++--------- remoting/protocol/channel_socket_adapter.h | 14 ++++++++------ remoting/protocol/channel_socket_adapter_unittest.cc | 2 +- remoting/protocol/fake_datagram_socket.cc | 11 ++++++----- remoting/protocol/fake_datagram_socket.h | 19 +++++++++++-------- remoting/protocol/p2p_datagram_socket.h | 12 +++++++----- remoting/protocol/pseudotcp_adapter_unittest.cc | 14 ++++++++------ 7 files changed, 51 insertions(+), 40 deletions(-) commit 5f2c980fe1adc62e5da788f829c84c075d891473 Author: Mario Sanchez Prada <mario@igalia.com> Date: Mon Mar 18 21:52:18 2019 +0000 Migrate //remoting/base and //remoting/protocol to net::CompletionOnceCallback Replace usage of net::CompletionCallback as well as replace usages of base::Bind() with base::BindOnce(), which are just a few occurrences since most of the completion callbacks used in //remoting are repeating callbacks, which will be explicitly declared as such in a follow-up CL. Bug: 807724 Change-Id: Ifb9c0fea63bfbd316c0d9ba0aee32851782f3699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524492 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#641771} remoting/base/buffered_socket_writer_unittest.cc | 2 +- remoting/protocol/pseudotcp_adapter_unittest.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) commit ad078a43e7f3ce9333114b947c14b9cc489d1b72 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Mar 18 21:35:56 2019 +0000 SuperSize: Print out coverage for WhereHasComponent() in stats Section .text: * 590186 have a component assigned. Accounts for 33813461 bytes (83.9%). Section .rodata: * 117119 have a component assigned. Accounts for 4424595 bytes (67.8%). Section .data.rel.ro: * 27468 have a component assigned. Accounts for 1745384 bytes (85.0%). Section .data: * 2617 have a component assigned. Accounts for 147982 bytes (94.8%). Section .bss: * 19198 have a component assigned. Accounts for 5535364 bytes (99.0%). Section .dex: * 30037 have a component assigned. Accounts for 608366 bytes (66.2%). Section .dex.method: * 41086 have a component assigned. Accounts for 4502289 bytes (65.9%). Section .pak.translations: * 1562 have a component assigned. Accounts for 1604374 bytes (89.8%). Section .pak.nontranslated: * 388 have a component assigned. Accounts for 1138251 bytes (78.9%). Section .other: * 1578 have a component assigned. Accounts for 2964134 bytes (18.7%). Change-Id: I3669fe09966f108559d26dd360ac4ebe113e1386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529376 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641770} tools/binary_size/libsupersize/describe.py | 2 ++ tools/binary_size/libsupersize/testdata/Archive.golden | 10 ++++++++++ tools/binary_size/libsupersize/testdata/Archive_Apk.golden | 10 ++++++++++ tools/binary_size/libsupersize/testdata/Archive_Elf.golden | 10 ++++++++++ .../libsupersize/testdata/Archive_MinimalApks.golden | 10 ++++++++++ .../libsupersize/testdata/Archive_OutputDirectory.golden | 10 ++++++++++ .../binary_size/libsupersize/testdata/Archive_Pak_Files.golden | 10 ++++++++++ tools/binary_size/libsupersize/testdata/FullDescription.golden | 10 ++++++++++ 8 files changed, 72 insertions(+) commit f57cceafd496c8d5daa274813df817fb9b4470f5 Author: Yun Liu <yliuyliu@google.com> Date: Mon Mar 18 21:31:23 2019 +0000 Change Android SDK path to third_party/android_sdk/public third_party/android_tools/sdk will be gradually deprecated and replaced with third_party/android_sdk/public Bug: 659808 Change-Id: I7e006f12723cf9a4dbce3c9d87b728e4e662b6c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518245 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641769} BUILD.gn | 2 +- DEPS | 45 ++++++++++------------ android_webview/tools/apk_merger.py | 2 +- build/android/devil_chromium.json | 12 +++--- build/android/docs/build_config.md | 4 +- build/android/download_doclava.py | 10 +---- build/android/envsetup.sh | 2 +- build/android/lint/suppressions.xml | 2 + build/android/pylib/constants/__init__.py | 4 +- build/config/android/config.gni | 8 ++-- build/config/android/internal_rules.gni | 2 +- build/secondary/third_party/android_tools/BUILD.gn | 8 ++-- .../evaluation/run_offline_page_evaluation_test.py | 2 +- chrome/test/vr/perf/BUILD.gn | 2 +- chrome/test/vr/perf/vr_test_arg_parser.py | 2 +- components/cronet/tools/generate_javadoc.py | 2 +- docs/android_build_instructions.md | 4 +- docs/android_cast_build_instructions.md | 2 +- docs/android_debugging_instructions.md | 2 +- docs/android_test_instructions.md | 2 +- docs/chromoting_android_hacking.md | 6 +-- docs/profiling_content_shell_on_android.md | 2 +- docs/working_remotely_with_android.md | 2 +- testing/buildbot/gn_isolate_map.pyl | 8 ++-- third_party/android_sdk/README.chromium | 5 ++- third_party/android_sdk/cipd_build-tools.yaml | 4 ++ third_party/android_sdk/cipd_emulator.yaml | 4 ++ third_party/android_sdk/cipd_extras.yaml | 4 ++ third_party/android_sdk/cipd_patcher.yaml | 15 ++++++++ third_party/android_sdk/cipd_platform-tools.yaml | 4 ++ third_party/android_sdk/cipd_platforms.yaml | 4 ++ third_party/android_sdk/cipd_sources.yaml | 4 ++ third_party/android_sdk/cipd_tools-lint.yaml | 4 ++ third_party/android_sdk/cipd_tools.yaml | 4 ++ tools/android/eclipse/.classpath | 18 ++++----- tools/android/sdk_updater/update_sdk.py | 7 +--- tools/binary_size/libsupersize/path_util.py | 2 +- tools/cr/cr/base/android.py | 2 +- 38 files changed, 128 insertions(+), 90 deletions(-) commit 4fd9317c1dfee20b7647cbf0f0c51be9f8d6f511 Author: Miguel Casas <mcasas@chromium.org> Date: Mon Mar 18 21:30:26 2019 +0000 VaAPI JDA unit test: s/visible_/coded_/ where appropriate s/visible_/coded_/ where appropriate Test: jpeg_decode_accelerator_unittest on nocturne Bug: 942813 Change-Id: Id6ff39f3f916fe4fd3844be96890be7b2f135131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529516 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#641768} media/gpu/vaapi/vaapi_jpeg_decoder_unittest.cc | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) commit ce26bb2c47f60cf5fb309d8c6cc228e2d7dde743 Author: Robert Ogden <robertogden@chromium.org> Date: Mon Mar 18 21:29:18 2019 +0000 Update DRP OWNERS ASCII Art with new icon Bug: 909915 Change-Id: Id5ce252f681a97b0a38bb8db1dd77611e287c836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525306 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#641767} components/data_reduction_proxy/OWNERS | 71 ++++++++++++++++++---------------- 1 file changed, 37 insertions(+), 34 deletions(-) commit d93b0c9f0cffc731fd71345ba040a414c1258d28 Author: Mina Almasry <almasrymina@chromium.org> Date: Mon Mar 18 21:29:02 2019 +0000 [Chromecast] Delete obsolete AV sync unittests Checks for AV sync are integrated into cast_media_unittests now. Bug: 109701656 Test: CQ Change-Id: I412253b03f3e25beff928690812a96245c09f276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525047 Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Reviewed-by: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Mina Almasry <almasrymina@chromium.org> Cr-Commit-Position: refs/heads/master@{#641766} chromecast/BUILD.gn | 5 +- chromecast/media/cma/backend/BUILD.gn | 23 -- chromecast/media/cma/backend/av_sync_unittest.cc | 165 -------------- .../cma/backend/mock_audio_decoder_for_mixer.cc | 102 --------- .../cma/backend/mock_audio_decoder_for_mixer.h | 59 ----- .../cma/backend/mock_video_decoder_for_mixer.cc | 247 --------------------- .../cma/backend/mock_video_decoder_for_mixer.h | 104 --------- 7 files changed, 1 insertion(+), 704 deletions(-) commit 86c01ed2cacfbe1ac62673593d882628fb76a7d7 Author: Nate Fischer <ntfschr@chromium.org> Date: Mon Mar 18 21:27:15 2019 +0000 AW: don't use URLRequestContextGetter This removes content/'s and android_webview/'s dependencies on AwURLRequestContextGetter. This removes ContentBrowserClient::NeedURLRequestContext() since the API only existed so WebView could continue to rely on AwURLRequestContextGetter. After removing this (and the chrome/ override), content layer no longer requests the URLRequestContext{Getter} from the embedder. This removes android_webview/'s dependency on AwURLRequestContextGetter and nulls it out. This also cleans up some code in AwURLRequestContextGetter (as that class is now only used when the Network Service is disabled). This adds TODOs in dependent code to implement the Network Service path (this code was already non-functional). This also updates Chrome for Android code (specifically, content_suggestions_service_factory) to stop calling GetURLRequestContext (since we previously didn't DCHECK for Android OS). Bug: 936735, 902658 Test: run_webview_instrumentation_test_apk \ Test: --enable-features=NetworkService,NetworkServiceInProcess Change-Id: I5e3276d98c9b8b86aaa8bbfaa52a60a52aa42e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516476 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641765} android_webview/browser/aw_browser_context.cc | 15 +++++--- android_webview/browser/aw_proxy_controller.cc | 44 ++++++++++++++-------- .../browser/net/aw_url_request_context_getter.cc | 8 +--- .../aw_safe_browsing_blocking_page.cc | 1 - chrome/browser/chrome_content_browser_client.cc | 6 --- chrome/browser/chrome_content_browser_client.h | 3 -- .../content_suggestions_service_factory.cc | 3 -- content/browser/storage_partition_impl.cc | 8 +--- content/browser/storage_partition_impl_map.cc | 13 +------ content/public/browser/content_browser_client.cc | 4 -- content/public/browser/content_browser_client.h | 4 -- 11 files changed, 42 insertions(+), 67 deletions(-) commit 68d16e435d9e78f63020cc266fe23e181247275f Author: Piotr Bialecki <bialpio@chromium.org> Date: Mon Mar 18 21:25:50 2019 +0000 Fix crash in AR instrumentation tests The issue is that we attempt to reuse mojo bindings in ArCoreGl. Fix for now is to close all bindings when ArCoreGl::CreateSession() gets invoked. Additionally, this patch will also make ArCoreGl register an error handler for its mojo bindings. Bug: 942692 Change-Id: Iadd982c97f499bd95e968c109a2535ec2901da4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526795 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#641764} .../browser/android/vr/arcore_device/arcore_gl.cc | 22 ++++++++++++++++++++++ .../browser/android/vr/arcore_device/arcore_gl.h | 3 +++ 2 files changed, 25 insertions(+) commit e4152da0abed8675d13039c46b81a89a3ed0dd9d Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Mar 18 21:21:23 2019 +0000 histograms: Add labels for unified heap GC Bug: 843903 Change-Id: I1d325d18f8ff1aea1b36dd117a7ee4bc143e7cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528670 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#641763} tools/metrics/histograms/enums.xml | 1 + tools/metrics/histograms/histograms.xml | 1 + 2 files changed, 2 insertions(+) commit e1cbda8a3f3287a2a3ea264c0c7659d66b8a8b0f Author: Johannes Henkel <johannes@chromium.org> Date: Mon Mar 18 21:17:03 2019 +0000 Make HttpServer interface more precise to reduce copying. OnWebSocketMessage receives an std::string, so now it can be moved. SendOverWebSocket accepts a base::StringPiece data, so now it can come from anything that provides such bytes (e.g. a vector of bytes), not just from std::string. This change is similar to https://chromium-review.googlesource.com/c/chromium/src/+/1525276 and https://chromium-review.googlesource.com/c/chromium/src/+/1525405 which I submitted earlier. Change-Id: I8a4eed11f46867158b67f24953ffcf801b6bf4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526695 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#641762} components/ui_devtools/devtools_server.cc | 3 +-- components/ui_devtools/devtools_server.h | 2 +- services/network/public/cpp/server/http_server.cc | 4 ++-- services/network/public/cpp/server/http_server.h | 6 +++--- services/network/public/cpp/server/http_server_unittest.cc | 5 ++--- services/network/public/cpp/server/web_socket.cc | 2 +- services/network/public/cpp/server/web_socket.h | 2 +- services/network/public/cpp/server/web_socket_encoder.cc | 9 ++++----- services/network/public/cpp/server/web_socket_encoder.h | 4 ++-- 9 files changed, 17 insertions(+), 20 deletions(-) commit 3316358ad559f3cf2cb57fed7bbee36dc13d41c1 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Mar 18 21:16:35 2019 +0000 [Non-BGPT] Don't invalidate raster on start/end of animation In non-BGPT, don't induce effect and filter nodes for transform animation, and don't induce filter node for opacity animation. This reverts non-BGPT to the state before https://chromium-review.googlesource.com/c/1410165 which accidentally changed the condition for non-BGPT effect and filter nodes. Bug: 942681 Change-Id: I9a289f2eb3cd1a1f111e3d76f53be324d08ef68f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527549 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641761} .../core/paint/paint_property_tree_builder.cc | 24 +++++++++-- .../core/paint/paint_property_tree_builder_test.cc | 22 +++++++++- third_party/blink/web_tests/TestExpectations | 3 ++ .../animation/opacity-animation-expected.html | 2 + .../animation/opacity-animation-expected.txt | 30 +++++++++++++ .../invalidation/animation/opacity-animation.html | 13 ++++++ .../animation/transform-animation-expected.html | 2 + .../animation/transform-animation-expected.txt | 50 ++++++++++++++++++++++ .../animation/transform-animation.html | 14 ++++++ 9 files changed, 155 insertions(+), 5 deletions(-) commit 8fa44e8b6f939cee5f03ce25a239901ad4295013 Author: Toni Barzic <tbarzic@chromium.org> Date: Mon Mar 18 21:12:54 2019 +0000 Delay public session login until associated policy store load Public session login fails if attempted before the cloud policy store is loaded, which might happen if login is attempted with short delay (e.g. 0) auto login policy. BUG=938973, 942689 Change-Id: I3a64a0dda2ab9b5a98525dee508fc457e478401d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526463 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#641760} .../chromeos/login/existing_user_controller.cc | 67 ++++++++++++++++++++++ .../chromeos/login/existing_user_controller.h | 14 +++++ 2 files changed, 81 insertions(+) commit 6a0038632bc08750f20df1574d078bdb173b9643 Author: Patrick Noland <pnoland@chromium.org> Date: Mon Mar 18 21:09:35 2019 +0000 Revert "[Chromeshine] Hook up in-memory components to persistence" This reverts commit 5e4ec2489fb091b79055fe8748530fb82b76becb. Reason for revert: Bad merge caused wrong patchset to get committed Original change's description: > [Chromeshine] Hook up in-memory components to persistence > > This CL makes a large number changes to account for the > fact that UsageStatsService operations are now async. The major upshot > is that promises are used instead of actual values. If data has been loaded, > then promises are fulfilled immediately. Otherwise, they're fulfilled once > the database is loaded. There is a corresponding downstream change that > adjusts UsageStatsBrowserService to account for this. > > There are also a couple bug fixes; usage stats database needs to split its > databases into different folders, so that is fixed. > > Bug: 939456 > Change-Id: I0869318b5733ea6cb496af31224c6e9c93030fb5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509103 > Commit-Queue: Patrick Noland <pnoland@chromium.org> > Reviewed-by: Filip Gorski <fgorski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641699} TBR=fgorski@chromium.org,pnoland@chromium.org,chouinard@chromium.org Change-Id: Ic8d6b7d66bbd630e729fb2882ab2afc23875dea5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 939456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529364 Reviewed-by: Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#641759} .../chrome/browser/usage_stats/EventTracker.java | 10 +- .../browser/usage_stats/PageViewObserver.java | 31 ++- .../browser/usage_stats/SuspensionTracker.java | 6 +- .../chrome/browser/usage_stats/TokenTracker.java | 16 +- .../browser/usage_stats/UsageStatsService.java | 271 ++------------------- .../browser/usage_stats/EventTrackerTest.java | 3 +- .../browser/usage_stats/PageViewObserverTest.java | 96 +++----- .../android/usage_stats/usage_stats_database.cc | 32 +-- 8 files changed, 94 insertions(+), 371 deletions(-) commit 39586ceb77b77e4ccc44d77828c52c5e0da3ca31 Author: Lutz Justen <ljusten@chromium.org> Date: Mon Mar 18 21:08:14 2019 +0000 Add Kerberos client Adds a real and a fake implementation of a D-Bus client that talks to the Kerberos daemon in Chrome OS. BUG=chromium:933798 TEST=Validated the fake and real implementation with custom test code Change-Id: Ic4f025c87ed17f242c383c42d00972e9c5606c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1478895 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#641758} chrome/browser/chromeos/BUILD.gn | 1 + chrome/browser/chromeos/dbus/dbus_helper.cc | 4 + chromeos/dbus/kerberos/BUILD.gn | 32 ++++ chromeos/dbus/kerberos/fake_kerberos_client.cc | 133 +++++++++++++++ chromeos/dbus/kerberos/fake_kerberos_client.h | 71 ++++++++ chromeos/dbus/kerberos/kerberos_client.cc | 226 +++++++++++++++++++++++++ chromeos/dbus/kerberos/kerberos_client.h | 97 +++++++++++ 7 files changed, 564 insertions(+) commit d37748b81e3872f110b767da94178d9cc26c7c55 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Mon Mar 18 20:59:31 2019 +0000 [Extensions Bindings] Remove obsolete native handlers from //extensions With Native Extension Bindings, some native handlers are no longer used (because the JS resources that called into them are also obsolete). Remove the methods and classes that are unnecessary from //extensions. Bug: 938998 Change-Id: Ic9978fe467613312a4ad633cfdec3759f94f168f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510298 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641757} .../chrome_extensions_dispatcher_delegate.cc | 4 - .../cast_extensions_dispatcher_delegate.cc | 4 - extensions/renderer/BUILD.gn | 4 - extensions/renderer/dispatcher.cc | 7 -- extensions/renderer/i18n_custom_bindings.cc | 80 ------------------- extensions/renderer/i18n_custom_bindings.h | 29 ------- extensions/renderer/runtime_custom_bindings.cc | 16 ---- extensions/renderer/runtime_custom_bindings.h | 1 - extensions/renderer/send_request_natives.cc | 92 ---------------------- extensions/renderer/send_request_natives.h | 40 ---------- 10 files changed, 277 deletions(-) commit d88a116b1050d76a59ae4d85c31bc7b561d35200 Author: Eugene But <eugenebut@google.com> Date: Mon Mar 18 20:59:15 2019 +0000 Fix WKBasedNavigationManagerImpl::CommitPendingItem for back forward navigations. The change mirrors LegacyNavigationManagerImpl::CommitPendingItem implementation by calling CommitPendingItem() if pending item index is not -1. Bug: 899827 Change-Id: Iab6459b6673e2a2d0e413728de4b870affb30956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526629 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#641756} ios/web/navigation/wk_based_navigation_manager_impl.mm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 37ab79b64b18c68a048ffd03f8ada0d62494d104 Author: Nate Fischer <ntfschr@chromium.org> Date: Mon Mar 18 20:54:37 2019 +0000 AW: simplify JNI in cookie_manager No expected change to behavior, this should be a refactor. This leverages RunBooleanCallbackAndroid to simplify the JNI callback code in cookie_manager.cc It also avoids passing in null Callback Java instances, so this adds a DCHECK to enforce the JavaRef is non-null. Bug: 932535 Test: run_webview_instrumentation_test_apk -f=CookieManagerTest#* Change-Id: I3f0616bbc141603ac20e912d8b235d2cb5d2736d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526318 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641755} android_webview/browser/cookie_manager.cc | 7 ++- .../chromium/android_webview/AwCookieManager.java | 58 ++++++++++------------ 2 files changed, 29 insertions(+), 36 deletions(-) commit 424f33edffd4e873ee0983d9067b33ce6fe49cfe Author: Oksana Zhuravlova <oksamyt@chromium.org> Date: Mon Mar 18 20:53:21 2019 +0000 Reland "Move credential_manager.mojom to third_party/blink/public/mojom/" This is a reland of ee9a12a0b094cb187c53ecd180580cb93d0ffa40 The reland adds a missed update to chrome_content_browser_overlay_manifest.cc to include the credential_manager header from the new location. Original change's description: > Move credential_manager.mojom to third_party/blink/public/mojom/ > > This change moves credential_manager.mojom to > third_party/blink/public/mojom. This allows making a follow-up change > where document_interface_broker.mojom depends on credential_manager.mojom > without creating a circular dependency: > //third_party/blink/public:mojo_bindings -> > //third_party/blink/public/mojom:mojom_platform > (document_interface_broker) -> > //third_party/blink/public:mojo_bindings > (credential_manager). > > Also there is a # TODO: Move these into blink/public/mojom. > > Bug: 936482 > > Change-Id: Ia160559a665d74a77a1b20b506812b6b7c6536b1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525013 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641503} TBR=haraken@chromium.org Bug: 936482 Change-Id: Ib2fed536124094d1fdde49d142b3ce0b0bedc45b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527780 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#641754} chrome/app/chrome_content_browser_overlay_manifest.cc | 2 +- components/password_manager/content/DEPS | 2 +- .../password_manager/content/browser/content_credential_manager.h | 2 +- components/password_manager/content/common/credential_manager.typemap | 2 +- .../password_manager/content/common/credential_manager_mojom_traits.h | 2 +- third_party/blink/public/BUILD.gn | 1 - third_party/blink/public/mojom/BUILD.gn | 1 + .../blink/public/{platform/modules => mojom}/credentialmanager/OWNERS | 4 ---- .../modules => mojom}/credentialmanager/credential_manager.mojom | 0 .../renderer/modules/credentialmanager/credential_manager_proxy.h | 2 +- .../modules/credentialmanager/credential_manager_type_converters.h | 2 +- .../blink/renderer/modules/credentialmanager/credentials_container.cc | 2 +- .../renderer/modules/credentialmanager/credentials_container_test.cc | 2 +- .../tests/credentialmanager/credentialscontainer-create-basics.html | 2 +- .../http/tests/credentialmanager/credentialscontainer-get-basics.html | 2 +- .../http/tests/credentialmanager/credentialscontainer-get-errors.html | 2 +- .../tests/credentialmanager/credentialscontainer-get-origins.html | 2 +- .../credentialscontainer-preventsilentaccess-basics.html | 2 +- .../tests/credentialmanager/credentialscontainer-store-basics.html | 2 +- .../web_tests/http/tests/credentialmanager/mock-authenticator.html | 2 +- 20 files changed, 17 insertions(+), 21 deletions(-) commit 5381a53cc54b24fdcd08ec72b8669554386d014e Author: Peter Boström <pbos@chromium.org> Date: Mon Mar 18 20:43:35 2019 +0000 Move observable changes into InkDropEventHandler This specifically moves InkDropHostView::OnBoundsChanged and ::VisibilityChanged into InkDropEventHandler, using the corresponding ViewObserver APIs. Note that there's no API corresponding to ::ViewHierarchyChanged so a TODO is left to make sure that we can observe when the host gets removed from the hierarchy. Bug: chromium:939419 Change-Id: Iec2d36cd1977afe9ede897e753fd95b3069986dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521961 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#641753} ui/views/animation/ink_drop_event_handler.cc | 14 ++++++++++++++ ui/views/animation/ink_drop_event_handler.h | 5 +++++ ui/views/animation/ink_drop_host_view.cc | 20 +++++++------------- ui/views/animation/ink_drop_host_view.h | 3 +-- 4 files changed, 27 insertions(+), 15 deletions(-) commit fa556b475748f2e6f2aeff230952c92f1ea17aa2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 20:40:06 2019 +0000 Roll src/third_party/skia 252996c72d2c..4a20dbeaf31a (13 commits) https://skia.googlesource.com/skia.git/+log/252996c72d2c..4a20dbeaf31a git log 252996c72d2c..4a20dbeaf31a --date=short --no-merges --format='%ad %ae %s' 2019-03-18 bsalomon@google.com Revert "Add small offset to t in GrLinearGradientLayout." 2019-03-18 robertphillips@google.com Mark tmp path in shadow utils as volatile 2019-03-18 mtklein@google.com shard failing bots 2019-03-18 mtklein@google.com rework --ignoreSigInt 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 036614c8468c..1cef4e693fc3 (1 commits) 2019-03-18 csmartdalton@google.com Reland "Disable coverage counting by default" 2019-03-18 csmartdalton@google.com Revert "Disable coverage counting by default" 2019-03-18 kjlubick@google.com [canvaskit] Various cleanups around docs/build 2019-03-18 robertphillips@google.com Unblock Flutter 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src ad85caa87461..69be71e10036 (116 commits) 2019-03-18 brianosman@google.com Suppress /RTCc error about losing information during case to smaller type 2019-03-18 bsalomon@google.com Add small offset to t in GrLinearGradientLayout. 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 00424c1bc233..036614c8468c (2 commits) Created with: gclient setdep -r src/third_party/skia@4a20dbeaf31a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:938592,chromium:938592 TBR=brianosman@chromium.org Change-Id: Id6541dde1c2536ae7a9d93db16ecdac5c950b8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529150 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641752} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fabbb29429ff490291c636e42d4ad68783f38c07 Author: Mathieu Perreault <mathp@chromium.org> Date: Mon Mar 18 20:34:45 2019 +0000 Removing mathp@ from owners of components/leveldb_proto Change-Id: If897648b06eba5ced5c81afbaae72d2850407758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526348 Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#641751} components/leveldb_proto/OWNERS | 1 - 1 file changed, 1 deletion(-) commit 484648051f4fd3a11fce9e0caf70848c0c576eef Author: Vadym Doroshenko <dvadym@chromium.org> Date: Mon Mar 18 20:34:06 2019 +0000 Removed expired metric PasswordManager.SendPasswordFormToBrowserProcess. Bug: 930919 Change-Id: I1d546809b1e47c0a51367c3945ca61fbd607b946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523098 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#641750} .../content/renderer/password_autofill_agent.cc | 49 +++------------------- .../content/renderer/password_autofill_agent.h | 20 --------- tools/metrics/histograms/enums.xml | 3 ++ tools/metrics/histograms/histograms.xml | 3 ++ 4 files changed, 12 insertions(+), 63 deletions(-) commit 9294fcf1591dcc10e69ffddb70890d0e3c5b6594 Author: Qingsi Wang <qingsi@chromium.org> Date: Mon Mar 18 20:21:52 2019 +0000 Revert "Move the getUserMedia gating of mDNS protection to FilteringNetworkManager." This reverts commit 6130949eaaf724cec6c90b2b54515b9e3dfe81e1. Reason for revert: this change breaks the canary. TBR=sergeyu@chromium.org Original change's description: > Move the getUserMedia gating of mDNS protection to FilteringNetworkManager. > > Our previous implementation would destroy the connection to the mDNS > responder service host when the media capture permission is granted. > As a result, any mDNS candidate created before the grant would become > unresolvable. This issue is particularly evident when we have multiple > peer connections of the same origin, where a newly created peer > connection would temporarily toggle the permission to blocked before > restoring the granted status if the user did give the permission. This > could cause a peer connection created earlier and in the process of ICE > candidate gathering to perform unnecessary mDNS obfuscation. After this > change, the connection to the mDNS responder service host keeps alive, > but just becomes unavailable for registration of new names when we have > permissions granted. > > Bug: 930339, 937992 > Change-Id: I8ccdf0e6b578bc9e327337c6fbd102cdc542d15c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522687 > Commit-Queue: Qingsi Wang <qingsi@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641046} TBR=sergeyu@chromium.org,qingsi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 930339, 937992 Change-Id: I6f07087bceb320300e536a8c867fac8d8cd5a557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528921 Reviewed-by: Steve Anton <steveanton@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641749} .../webrtc/peer_connection_dependency_factory.cc | 49 +++++++++++++++------- .../webrtc/peer_connection_dependency_factory.h | 12 ++++-- content/renderer/p2p/filtering_network_manager.cc | 30 ++++++------- content/renderer/p2p/filtering_network_manager.h | 13 +++++- .../p2p/filtering_network_manager_unittest.cc | 4 +- content/renderer/p2p/ipc_network_manager.cc | 18 ++++---- content/renderer/p2p/ipc_network_manager.h | 6 +-- .../renderer/p2p/ipc_network_manager_unittest.cc | 3 +- 8 files changed, 86 insertions(+), 49 deletions(-) commit f9c0b1eca6b69172d4530ecd8e842c73bc338823 Author: David Benjamin <davidben@chromium.org> Date: Mon Mar 18 20:21:04 2019 +0000 Detect RSA-PSS support in NSS keys. This will change the error from ERR_SSL_CLIENT_AUTH_SIGNATURE_FAILED to ERR_SSL_CLIENT_AUTH_NO_COMMON_ALGORITHMS and allow us to consider doing something more clever, if we can find an arrangement that doesn't introduce a downgrade vulnerability. Tested manually with a PKCS#11 module that didn't support PSS. Bug: 924284 Change-Id: Ia49ddd3d9a2ee5e0a9af177e3af1cafe63447bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522338 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641748} net/ssl/ssl_platform_key_nss.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) commit 8ff1d2b7351cd8a931fec5a4c003b231ccedb742 Author: James Cook <jamescook@chromium.org> Date: Mon Mar 18 20:18:56 2019 +0000 Add mnissler as TPM firmware update owner Bug: none Change-Id: I16a94d1ddeecf6b31d150cad23c6e6ed33c70902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521976 Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Mattias Nissler <mnissler@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#641747} chrome/browser/chromeos/OWNERS | 1 + 1 file changed, 1 insertion(+) commit d1a6a2b70245dee786d6229fcdaacc6f41992dee Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Mar 18 20:18:17 2019 +0000 Android: Add M74 to generate_milestone_reports.py Change-Id: I0657cffa9c08358fbb2e922176d6c5aba8b1c488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529115 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641746} tools/binary_size/generate_milestone_reports.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit d7bc037170d0851b9f67c49aaab6f88fb2a3e7a3 Author: Katie D <katie@chromium.org> Date: Mon Mar 18 20:17:43 2019 +0000 Updates auto alt strings per request. Bug: 943160 Change-Id: I316d1432510c22eb5aeb4b6888c48f256a744e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528794 Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#641745} chrome/app/chromium_strings.grd | 4 ++-- chrome/app/google_chrome_strings.grd | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) commit ba1db3499f2693ae37f5b44e754cdd3d01a07aea Author: Matt Menke <mmenke@chromium.org> Date: Mon Mar 18 20:14:38 2019 +0000 Remove simulated DNS errors from SetPriority ConnectJob tests. ConnectJobs used to sit on top of lower layer socket pools, so a number of SetPriority tests with multiple loop iterations had to simulate a DNS error at the end of each iteration to remove a pending ConnectJob from a lower layer pool, to avoid affecting the next loop iterations. Now that ConnectJobs no longer call into lower layer SocketPools, that logic can safely be removed. Bug: 927088, 472729 Change-Id: I42e70b01dc21c9c1933775cc6694459a39abf8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528754 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#641744} net/http/http_proxy_connect_job_unittest.cc | 13 ------------- net/socket/ssl_connect_job_unittest.cc | 30 ----------------------------- 2 files changed, 43 deletions(-) commit f3d3c67414d3add04bf95004336dd2ca835b8a95 Author: Philip Rogers <pdr@chromium.org> Date: Mon Mar 18 20:10:27 2019 +0000 Remove ProxyImpl::input_throttled_until_commit_ and associated code This patch removes ProxyImpl::input_throttled_until_commit_ and used. ProxyImpl: :SetInputThrottledUntilCommitOnImpl and ProxyMain: :NotifyInputThrottledUntilCommit because the code is no longer Change-Id: Ic73f9177d8a42e4e84a8265855550976b01e2021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525320 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641743} cc/test/fake_proxy.h | 1 - cc/trees/layer_tree_host.cc | 4 ---- cc/trees/layer_tree_host.h | 5 ----- cc/trees/proxy.h | 2 -- cc/trees/proxy_impl.cc | 16 +--------------- cc/trees/proxy_impl.h | 2 -- cc/trees/proxy_main.cc | 7 ------- cc/trees/proxy_main.h | 1 - cc/trees/single_thread_proxy.h | 1 - content/renderer/compositor/layer_tree_view.cc | 4 ---- content/renderer/compositor/layer_tree_view.h | 1 - 11 files changed, 1 insertion(+), 43 deletions(-) commit e00f5d872ad856f8882c730a06ca212fab5b9904 Author: sczs <sczs@chromium.org> Date: Mon Mar 18 20:09:51 2019 +0000 [ios] InfobarBanner UI tweaks - Makes the drop shadow more prominent. - Fades in the banner during its presentation animation. Bug: 911864 Change-Id: Ie43af0862e428872100456317afcd53c2ccd259c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526800 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641742} .../browser/ui/infobars/banners/infobar_banner_view_controller.mm | 6 +++--- .../browser/ui/infobars/presentation/infobar_banner_animator.mm | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) commit c160aed58b050d7501852f3a60952c84b7aed2d0 Author: David Bokan <bokan@chromium.org> Date: Mon Mar 18 20:06:51 2019 +0000 Fix Spatial Navigation Looping NodeRectInRootFrame returns the bounding box of a given node in root frame coordinates. This is used to intersect with the root frame rect to determine when an element is on or off screen. Unfortunately, in some cases the bounding box returned by ContainerNode::BoundingBox() is empty (but with location). This leads to false-positives when checking if an element is offscreen causing spatial navigation to start the search from the viewport's top, trapping the user in a loop. BoundingBox calls LayoutObject::AbsoluteBoundingBoxRectHelper. This method uses the upper-left and lower right corner of the first and last child of the node. In the provided test case, this fails as the first child is positioned way to the right of the last child (text node) and clipped. This results in an empty rect being returned. This CL fixes the issue by simply ensuring the rect has some size so that the location (which should be approximately correct) is still used. I tried using the AbsoluteBoundingBoxRect instead which handles this case correctly but broke the snav-imagemap-overlapped-areas.html test. It appears to not correctly compute bounding boxes for image elements inside an anchor (for e.g.). Bug: 920578 Change-Id: I059ea0d91b08be86d001876725a667c38f01fa78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527162 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641741} .../blink/renderer/core/page/spatial_navigation.cc | 12 +++- .../snav-keyboard-scrollers-search-origin-bug.html | 69 ++++++++++++++++++++++ 2 files changed, 78 insertions(+), 3 deletions(-) commit 6a1297e45f59190121cd4b43be7fc96eb4196506 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 20:05:24 2019 +0000 Roll src/third_party/depot_tools efe902b20b6a..b542cca26697 (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/efe902b20b6a..b542cca26697 git log efe902b20b6a..b542cca26697 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 raphael.kubo.da.costa@intel.com git_test_utils: Copy os.environ in get_git_commit_env() Created with: gclient setdep -r src/third_party/depot_tools@b542cca26697 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ie4b30987a35939f3256e3636af456a9db5587f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529151 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641740} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eff4bc6dd37a296e2a9b1ea44d21b1797178e46f Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Mar 18 20:04:23 2019 +0000 Do not check if reporting has started. The overview animation can continue from the previous one, so it shouldn't check if it's started. Bug: 923159 Test: none Change-Id: Iec70a1ffff8a070073fe887c3a594c9577a695d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526745 Reviewed-by: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#641739} ash/app_list/presenter/app_list_presenter_impl.cc | 11 ----------- 1 file changed, 11 deletions(-) commit 739786a9677f1de5506abc794d035e1d92a7ab56 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Mon Mar 18 20:01:22 2019 +0000 Roll src-internal 28645ae1d8fb..b97f27935ca1 (5 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/28645ae1d8fb..b97f27935ca1 Created with: gclient setdep -r src-internal@b97f27935ca1 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:942176 TBR=rogerta@chromium.org,yoichio@chromium.org,finnur@chromium.org,atotic@chromium.org,nicolaso@chromium.org Change-Id: Ie1ffd0425e39406e673047c2d8c776c04d2b3dd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528850 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641738} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7feadb2d0b65a8d09beee807cd48af727b0260c4 Author: dpapad <dpapad@chromium.org> Date: Mon Mar 18 19:58:01 2019 +0000 Replace i18n-values with $i18n{} mechanism in chrome://slow debug page. Also minor cleanups: - Remove invalid width=100% HTML attribute - Remove unnecessary CSS classes. - Remove unnecessary <script> dependencies - Remove unnecessary usage of Grit's flattenhtml="true" - Add compress="gzip" for chrome://slow resources. Bug: 677338 Change-Id: I1879e414e845809e2d778a23961e379c9a2b74a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526814 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641737} chrome/browser/browser_resources.grd | 7 +++---- chrome/browser/resources/chromeos/slow.html | 20 ++++++++------------ chrome/browser/ui/webui/chromeos/slow_ui.cc | 3 ++- 3 files changed, 13 insertions(+), 17 deletions(-) commit ce0a3246c81341897a41f789f777999e7ccf616d Author: David Black <dmblack@google.com> Date: Mon Mar 18 19:56:51 2019 +0000 Add unique prefix to Assistant alarm/timer notifications. When we uprev the new Alarm/Timer APIs from LibAssistant, alarm/timer IDs are expected to be of the form "1"..."n". This is not unique enough to be used directly as notification ID without risking collision. To address this, we prefix alarm/timer notifications with a statically defined string sequence that is (hopefully) unique. This notification ID, not the true alarm/timer ID, is used when creating or checking for the existence of alarm/timer notifications. Bug: b:128035835 Change-Id: I416c89f1e852da3a82d7aaf08d2b52ad2dc32177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521273 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641736} ash/assistant/assistant_alarm_timer_controller.cc | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) commit cf3ea8cfbd1d09699fbfccf340152a5e2f0a2aee Author: David Black <dmblack@google.com> Date: Mon Mar 18 19:56:45 2019 +0000 Renames Assistant's BaseLogoView to LogoView. This is the second part of an effort to perform the following rename: LogoView --> LogoViewImpl BaseLogoView --> LogoView The first part of the effort was reviewed in: https://chromium-review.googlesource.com/c/chromium/src/+/1521590 Bug: b:b:111571925 Change-Id: I280002fe89d68bb337583528da4bb52070ba3452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524674 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641735} ash/app_list/views/assistant/dialog_plate.cc | 6 +-- ash/app_list/views/assistant/dialog_plate.h | 4 +- ash/assistant/ui/BUILD.gn | 4 +- ash/assistant/ui/assistant_mini_view.cc | 6 +-- ash/assistant/ui/dialog_plate/mic_view.cc | 45 +++++++++++----------- ash/assistant/ui/dialog_plate/mic_view.h | 8 ++-- .../logo_view/{base_logo_view.cc => logo_view.cc} | 10 ++--- .../ui/logo_view/{base_logo_view.h => logo_view.h} | 16 ++++---- ash/assistant/ui/logo_view/logo_view_impl.cc | 12 +++--- ash/assistant/ui/logo_view/logo_view_impl.h | 6 +-- .../ui/main_stage/assistant_header_view.cc | 6 +-- .../ui/main_stage/assistant_header_view.h | 4 +- 12 files changed, 64 insertions(+), 63 deletions(-) commit 42808cce55a8f6155d967af255a19f2b72e4c5b5 Author: kylechar <kylechar@chromium.org> Date: Mon Mar 18 19:49:25 2019 +0000 Call SetActiveURL() from InProcessCommandBuffer. With OOP-D the display compositor context was never setting the active URL. The "active URL" is really just a string added as crash key to help diagnose GPU process crashes. Implement this functionality for InProcessCommandBuffer for OOP-D display compositor. Add ContextUrl to hold GURL + hash used for setting active URL. Also move the logic to set the crash key into a static function in ContextUrl to avoid virtual function calls. Bug: 941806 Change-Id: I294f8247e50544934a1a2eb1ef77a3bcac00d50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524867 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641734} .../viz_process_context_provider.cc | 5 ++- components/viz/service/gl/gpu_service_impl.cc | 9 ----- components/viz/service/gl/gpu_service_impl.h | 1 - gpu/ipc/gl_in_process_context.cc | 3 +- gpu/ipc/in_process_command_buffer.cc | 14 ++++++- gpu/ipc/in_process_command_buffer.h | 9 ++++- gpu/ipc/raster_in_process_context.cc | 3 +- gpu/ipc/service/BUILD.gn | 2 + gpu/ipc/service/command_buffer_stub.cc | 44 ++++++++-------------- gpu/ipc/service/command_buffer_stub.h | 12 +++--- gpu/ipc/service/context_url.cc | 33 ++++++++++++++++ gpu/ipc/service/context_url.h | 38 +++++++++++++++++++ gpu/ipc/service/gles2_command_buffer_stub.cc | 4 +- gpu/ipc/service/gpu_channel_manager_delegate.h | 3 -- gpu/ipc/service/gpu_channel_test_common.cc | 2 +- gpu/ipc/service/raster_command_buffer_stub.cc | 9 ++--- gpu/ipc/service/webgpu_command_buffer_stub.cc | 4 +- gpu/ipc/webgpu_in_process_context.cc | 3 +- 18 files changed, 133 insertions(+), 65 deletions(-) commit 343d8acc0594186efabe62f7641acf4da438ddd9 Author: Staphany Park <staphany@chromium.org> Date: Mon Mar 18 19:48:01 2019 +0000 Roll src/third_party/googletest/src/ efecb0bfa..8b6d3f9c4 (5 commits) https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/efecb0bfa687..8b6d3f9c4a77 $ git log efecb0bfa..8b6d3f9c4 --date=short --no-merges --format='%ad %ae %s' 2019-03-04 absl-team Googletest export 2019-03-04 absl-team Googletest export 2019-02-28 absl-team Googletest export 2019-02-26 absl-team Googletest export 2019-03-01 carlo Minor build system fixes. Created with: roll-dep src/third_party/googletest/src Change-Id: I8d79d6846ef8ebb8e6f62c32364fff6800f60ab2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527336 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#641733} DEPS | 2 +- third_party/googletest/README.chromium | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit d03101846af0aa638f1aa75e33336047d388be39 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Mar 18 19:44:52 2019 +0000 Add COMPONENT for //services/net Useful for binary size attribution Change-Id: Ic17fe16c30e3a09995ea8732cabbf9a6849c93cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529125 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641732} services/network/OWNERS | 2 ++ 1 file changed, 2 insertions(+) commit 60874868817c4d4369d75f371a45e6ee1b07e152 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Mon Mar 18 19:41:08 2019 +0000 Revert "Remove unnecessary looping over all root windows" This reverts commit 822d38eacde7849678cc7cca74b75d0c5f4ed773. Reason for revert: Breaks window magnetism when dragging to an external display. Original change's description: > Remove unnecessary looping over all root windows > > We don't need to check magnitism between windows > on different roots/displays. We should just use > the same root of the window being dragged. > > BUG=942728 > > Change-Id: Iffbdcc9fef29c84fe090a8c50dde88e4a387dc2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526632 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641370} TBR=oshima@chromium.org,afakhry@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 942728 Change-Id: If557ff47c288dd3b091aa2a80c81b7b0cd66481f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529204 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#641731} ash/wm/workspace/workspace_window_resizer.cc | 36 ++++++++++++++-------------- 1 file changed, 18 insertions(+), 18 deletions(-) commit a621903d53cf5e8751ddbfbd51a55495b9f2177d Author: Avi Drissman <avi@chromium.org> Date: Mon Mar 18 19:39:50 2019 +0000 Convert to modern JSONReader Value usage in transport_security_state_unittest. BUG=925165 Change-Id: I0d2689e26f2421f0c56a3e8601e11288e5359907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526606 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Matt Mueller <mattm@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641730} net/http/transport_security_state_unittest.cc | 71 +++++++++++++-------------- 1 file changed, 35 insertions(+), 36 deletions(-) commit b38e0fd839dd2d368c221bf2f1555eeec4377903 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Mon Mar 18 19:35:38 2019 +0000 [TaskScheduler]: Implement simplified TaskSource. This CL implements TaskSource and derives Sequence from it with minimal changes. To allow incremental changes: - PriorityQueue still uses Sequence. This change will be done as a follow-up and is mostly mechanical. - TaskSource supports only 1 concurrent worker, so registration logic is simplified and Scheduler mostly unchanged. Change-Id: Ie19833235197e3c4c350b803878be8b546641325 Bug: 839091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460609 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#641729} base/BUILD.gn | 3 + .../platform_native_worker_pool_win.cc | 4 +- base/task/task_scheduler/priority_queue.cc | 7 +- .../scheduler_single_thread_task_runner_manager.cc | 4 +- base/task/task_scheduler/scheduler_worker_pool.cc | 11 +- .../task_scheduler/scheduler_worker_unittest.cc | 2 +- base/task/task_scheduler/sequence.cc | 74 ++++----- base/task/task_scheduler/sequence.h | 72 ++------- base/task/task_scheduler/sequence_unittest.cc | 26 ++-- base/task/task_scheduler/task_source.cc | 101 +++++++++++++ base/task/task_scheduler/task_source.h | 168 +++++++++++++++++++++ base/task/task_scheduler/task_source_unittest.cc | 77 ++++++++++ base/task/task_scheduler/task_tracker.cc | 9 +- 13 files changed, 414 insertions(+), 144 deletions(-) commit d8abfbe952b96b832856004ba52987c94c123114 Author: Jonathan Backer <backer@chromium.org> Date: Mon Mar 18 19:34:53 2019 +0000 Copy error over after glCopySubTexture ANGLE does the validation if passthrough is enabled, so copy over the error state to expose to client. Bug: 942658 Change-Id: I16c657bba1603849da3882f4f19575c78bb8f1f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528793 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#641728} gpu/command_buffer/service/raster_decoder.cc | 1 + 1 file changed, 1 insertion(+) commit f56c096a76665f85b620b2d5911d05ca9c76dcf7 Author: Hongchan Choi <hongchan@chromium.org> Date: Mon Mar 18 19:33:51 2019 +0000 Remove redundant codes for Autoplay from BaseAudioContext Bug: 942666 Change-Id: I6160b61308f171abdcc01fa23f219a26c3c97de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526482 Reviewed-by: Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641727} .../blink/renderer/modules/webaudio/base_audio_context.cc | 1 - third_party/blink/renderer/modules/webaudio/base_audio_context.h | 9 +++------ 2 files changed, 3 insertions(+), 7 deletions(-) commit 6c60031bead34f7557972a7207da5dbf561041d4 Author: Daniele Castagna <dcastagna@chromium.org> Date: Mon Mar 18 19:33:45 2019 +0000 exo: Align texture target with SharedImages Exo currently assumes all the dma-buf backed GpuMemoryBuffer should use TEXTURE_EXTERNAL_OES as texture target. This CL removes that assumptions and aligns the texture target to what SharedImages use. Change-Id: I9165e1d80a7ef29f03eb5e92eb02ab4cf9e7d0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527326 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641726} components/exo/display.cc | 6 +++++- gpu/command_buffer/common/gpu_memory_buffer_support.cc | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) commit 5cfbe4d23a071904244c2914b5777aad1c470a8b Author: James Cook <jamescook@chromium.org> Date: Mon Mar 18 19:32:40 2019 +0000 Move chromeos JS browser tests to chromeos section in BUILD.gn Then remove GEN("#if defined(OS_CHROMEOS)") blocks. This should slightly reduce the amount of generated C++ test code on non-Chrome OS platforms. Bug: none Change-Id: I5fbecf575babd0694118e7590030941054900d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524836 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641725} .../ui/webui/chromeos/set_time_ui_browsertest.js | 6 +----- chrome/test/data/webui/BUILD.gn | 20 ++++++++++---------- .../multidevice_setup_browsertest.js | 6 +----- .../settings/a11y/manage_accessibility_a11y_test.js | 6 +----- .../webui/settings/a11y/manage_profile_a11y_test.js | 6 +----- .../webui/settings/a11y/multidevice_a11y_test.js | 6 +----- .../settings/a11y/multidevice_features_a11y_test.js | 6 +----- .../data/webui/settings/a11y/sign_out_a11y_test.js | 12 +++++------- .../webui/settings/a11y/tts_subpage_a11y_test.js | 6 +----- 9 files changed, 22 insertions(+), 52 deletions(-) commit a36fe0bcbda8b2718cd8b9bc72a078afe29df477 Author: Jacob Dufault <jdufault@google.com> Date: Mon Mar 18 19:32:36 2019 +0000 cros: Remove ScreenContext usage in UpdateScreen. Bug: 926511 Change-Id: I0be2550a23984481135a999fa989e2bd33d4c078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506661 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641724} .../chromeos/login/screens/mock_update_screen.h | 9 ++ .../chromeos/login/screens/update_screen.cc | 125 ++++++++++----------- .../browser/chromeos/login/screens/update_view.h | 10 ++ .../resources/chromeos/login/oobe_screen_update.js | 93 +++++---------- .../webui/chromeos/login/update_screen_handler.cc | 73 ++++++++---- .../webui/chromeos/login/update_screen_handler.h | 8 ++ 6 files changed, 165 insertions(+), 153 deletions(-) commit 7c9ef91abf1f7feeca6bf891b73b2c7ffd7c3c0d Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Mon Mar 18 19:27:32 2019 +0000 Fixed build with disable_brotli_filter=True I have been working on the issue with https://ci.chromium.org/p/chrome/builders/ci/ios-web-view-canary-debug-device/7 ERROR at //net/socket/ssl_client_socket_impl.cc:64:11: Include not allowed. #include "third_party/brotli/include/brotli/decode.h" ^----------------------------------------- It is not in any dependency of //net:net The include file is in the target(s): //third_party/brotli:headers which should somehow be reachable. Bug: 942672 Change-Id: If92f904984223eef0d431f990228092ebbadf594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526630 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#641723} net/BUILD.gn | 2 ++ 1 file changed, 2 insertions(+) commit dbe6eca48eb5a8352bd336eb0fde2d0824e19b1b Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Mon Mar 18 19:26:28 2019 +0000 mojo: Fix cfi-icall failure Control Flow Integrity indirect call checking [1] verifies that indirect calls are only made to functions defined with a type signature that matches the function pointer type. CFI-icall as it is used in Chrome only works for functions that address-taken in the same DSO as it is checked. However, the function pointer in InvokeWatchCallback can be from another DSO, requiring CFI-icall to be disabled for this function for now. [1] https://www.chromium.org/developers/testing/control-flow-integrity Bug: 941469 Change-Id: I19add8104b6ed3c1691e256c6ebbcdb6a6bba272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524713 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641722} mojo/core/watcher_dispatcher.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 40d7ea800e202c215bf4bcc0a0991c1d6ca6c09b Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Mon Mar 18 19:22:54 2019 +0000 [Payment Request][Android] Deflake integration tests. Bug: 931203 Change-Id: I7410ca7a5a841464634711b8d920ec21a3dda7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521285 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Auto-Submit: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641721} .../browser/payments/PaymentRequestAbortTest.java | 6 ++++++ .../payments/PaymentRequestBillingAddressTest.java | 6 ++++++ .../PaymentRequestBillingAddressWithoutPhoneTest.java | 6 ++++++ .../PaymentRequestCanMakePaymentGooglePayTest.java | 6 ++++++ .../PaymentRequestCanMakePaymentMetricsTest.java | 6 ++++++ .../PaymentRequestCanMakePaymentQueryNoCardTest.java | 6 ++++++ .../PaymentRequestCanMakePaymentQueryTest.java | 6 ++++++ .../PaymentRequestCardEditorAutoAdvanceTest.java | 6 ++++++ ...ymentRequestContactDetailsAndFreeShippingTest.java | 6 ++++++ .../payments/PaymentRequestContactDetailsTest.java | 6 ++++++ .../browser/payments/PaymentRequestDebitTest.java | 6 ++++++ .../payments/PaymentRequestDontHaveDebitTest.java | 6 ++++++ ...ntRequestDynamicShippingMultipleAddressesTest.java | 6 ++++++ ...aymentRequestDynamicShippingSingleAddressTest.java | 6 ++++++ .../PaymentRequestEmailAndFreeShippingTest.java | 6 ++++++ .../payments/PaymentRequestEmailAndPhoneTest.java | 6 ++++++ .../browser/payments/PaymentRequestEmailTest.java | 6 ++++++ .../payments/PaymentRequestEmptyUpdateTest.java | 6 ++++++ .../payments/PaymentRequestExpiredLocalCardTest.java | 6 ++++++ .../PaymentRequestExtraShippingOptionsTest.java | 6 ++++++ .../payments/PaymentRequestFailCompleteTest.java | 19 +++++++++++++++++-- .../payments/PaymentRequestFieldTrialTest.java | 6 ++++++ .../payments/PaymentRequestFreeShippingTest.java | 6 ++++++ .../chrome/browser/payments/PaymentRequestIdTest.java | 6 ++++++ ...stIncompleteContactDetailsAndFreeShippingTest.java | 6 ++++++ .../PaymentRequestIncompleteContactDetailsTest.java | 6 ++++++ .../payments/PaymentRequestIncompleteEmailTest.java | 6 ++++++ .../payments/PaymentRequestIncompletePhoneTest.java | 6 ++++++ .../PaymentRequestIncompleteServerCardTest.java | 6 ++++++ .../payments/PaymentRequestJourneyLoggerTest.java | 6 ++++++ .../browser/payments/PaymentRequestMetricsTest.java | 6 ++++++ .../PaymentRequestMultipleContactDetailsTest.java | 6 ++++++ .../PaymentRequestNameAndFreeShippingTest.java | 6 ++++++ .../browser/payments/PaymentRequestNameTest.java | 6 ++++++ .../payments/PaymentRequestNoShippingTest.java | 6 ++++++ .../payments/PaymentRequestNoUpdateWithTest.java | 6 ++++++ ...equestPaymentAppAndBasicCardWithModifiersTest.java | 6 ++++++ .../PaymentRequestPaymentAppAndCardsTest.java | 6 ++++++ ...ymentRequestPaymentAppCanMakePaymentQueryTest.java | 6 ++++++ .../payments/PaymentRequestPaymentAppTest.java | 6 ++++++ .../PaymentRequestPaymentAppUiSkipPreloadTest.java | 6 ++++++ .../payments/PaymentRequestPaymentAppUiSkipTest.java | 6 ++++++ .../PaymentRequestPaymentAppsSortingTest.java | 6 ++++++ .../PaymentRequestPaymentMethodIdentifierTest.java | 6 ++++++ .../PaymentRequestPhoneAndFreeShippingTest.java | 6 ++++++ .../browser/payments/PaymentRequestPhoneTest.java | 6 ++++++ .../PaymentRequestRemoveBillingAddressTest.java | 6 ++++++ .../browser/payments/PaymentRequestRetryTest.java | 6 ++++++ .../payments/PaymentRequestServerCardTest.java | 6 ++++++ .../PaymentRequestServiceWorkerPaymentAppTest.java | 6 ++++++ .../PaymentRequestShippingAddressAndOptionTest.java | 6 ++++++ .../PaymentRequestShippingAddressChangeTest.java | 6 ++++++ .../browser/payments/PaymentRequestShowTwiceTest.java | 6 ++++++ .../browser/payments/PaymentRequestTabTest.java | 6 ++++++ .../browser/payments/PaymentRequestTestRule.java | 12 +++++++++--- .../payments/PaymentRequestUpdateWithTest.java | 6 ++++++ .../browser/payments/PaymentRequestUseStatsTest.java | 6 ++++++ 57 files changed, 356 insertions(+), 5 deletions(-) commit c56563037b00caa0ec25789afc7fe8242d451e04 Author: Alexei Filippov <alph@chromium.org> Date: Mon Mar 18 19:21:22 2019 +0000 [heap profiler] Do not try to collect sample when TLS is destroyed CaptureStack on Android needs TLS access. Other platforms do also use TLS for AllocationContext fetch. Do not try to collect a sample if TLS has been destroyed. BUG=939503 Change-Id: Ic7b5b9240b5c0a4dab1aa2db0c4883056db78168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528010 Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#641720} .../heap_profiling/public/cpp/sampling_profiler_wrapper.cc | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) commit 2ca01526fdab436656c6fd840fa0d2d4f0caa7c4 Author: Sahel Sharify <sahel@chromium.org> Date: Mon Mar 18 19:18:12 2019 +0000 Do not coalesce wheel with phaseBegan to wheel with phaseEnded. If no element in the scrolling chain is not scrollable in the given direction (delta_hints) on GSB we latch to the viewport. This is not user friendly on platforms that do not have any scroll affordance animations (e.g. Windows) since if the user changes the scrolling direction and an element in the chain is actually scrollable in the new direction, the user expects it to scroll and has no idea that we have latched to the (possibly unscrollable) viewport for the rest of the scroll sequence. To address the issue for timer based wheel scroll sequence we end the sequence and start a new one upon arrival of a wheel event with different delta directions if no GSU has been consumed since the beginning of the sequence. This cl ensures that the GSE/GSB generated for breaking the latching seqeunce are not coalesced with each other. Bug: 882998 Change-Id: Icf703c935475fffd69b899c59abc03ec1b548784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524703 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641719} ui/events/blink/blink_event_util.cc | 31 +++++++--------------------- ui/events/blink/blink_event_util_unittest.cc | 17 ++++++++------- 2 files changed, 18 insertions(+), 30 deletions(-) commit 9018debab96822aeb15497d413b32d1a731fd369 Author: Alex Clarke <alexclarke@chromium.org> Date: Mon Mar 18 19:17:34 2019 +0000 Prioritize UI thread navigation tasks behind a feature flag. This is intended to make initial startup faster although it will always on since prioritizing navigation in general seems a good idea. The initial effect isn't expected to be huge since way more tasks need annotation to make real inroads into startup performance. Bug: 863341 Change-Id: I6c3c5308fefdec51f86d34ac049312ab0e302b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511423 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641718} content/browser/scheduler/browser_ui_thread_scheduler.cc | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) commit 175f4901797a8e712b7a05d9fd6e25a91e3c562f Author: Nicolás Peña Moreno <npm@chromium.org> Date: Mon Mar 18 19:15:53 2019 +0000 Remove ExpectedQueueingTime by FrameStatus Bug: 919719 Change-Id: I5031fc033c622ce975362790718e79555bda8345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526384 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641717} .../main_thread/main_thread_scheduler_impl.cc | 19 +- .../main_thread/main_thread_scheduler_impl.h | 3 - .../main_thread/queueing_time_estimator.cc | 57 +--- .../main_thread/queueing_time_estimator.h | 12 +- .../queueing_time_estimator_unittest.cc | 360 +++------------------ .../test/queueing_time_estimator_perf_test.cc | 2 +- .../test/test_queueing_time_estimator_client.cc | 68 ---- .../test/test_queueing_time_estimator_client.h | 9 - tools/metrics/histograms/histograms.xml | 6 + 9 files changed, 51 insertions(+), 485 deletions(-) commit 6f5e64c3d61264c1235d8b5084807062a39b3463 Author: Victor Costan <pwnall@chromium.org> Date: Mon Mar 18 19:14:48 2019 +0000 sqlite: Remove VFS patch. This CL removes patches/0001-Modify-default-VFS-to-support-WebDatabase.patch, which was previously needed to run SQLite in the renderer process, for WebSQL. https://crrev.com/c/1438818 implemented a custom VFS for WebSQL, removing the need to patch SQLite's VFS implementation. Bug: 925739 Change-Id: I9a0106c37926b2ce5a0ea61de93cf8a324b3a24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527866 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by: Chris Mumford <cmumford@google.com> Reviewed-by: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641716} third_party/sqlite/amalgamation/rename_exports.h | 144 ++++++++--------- third_party/sqlite/amalgamation/sqlite3.c | 84 +--------- third_party/sqlite/amalgamation/sqlite3.h | 23 --- ...Modify-default-VFS-to-support-WebDatabase.patch | 179 --------------------- ...e-supporting-recovery-of-corrupted-datab.patch} | 5 +- ...ll.c-helpers-to-load-Chromium-s-ICU-data.patch} | 4 +- ...003-fts3-Disable-fts3_tokenizer-and-fts4.patch} | 4 +- ...-compilation-with-SQLITE_OMIT_WINDOWFUNC.patch} | 4 +- ...-dbfuzz2.c-compilation-errors-on-Windows.patch} | 4 +- ...-buffer-overflow-in-vdbeRecordCompareInt.patch} | 4 +- ...-fix-heap-buffer-overflow-in-cellsizeptr.patch} | 4 +- ...> 0008-fix-integer-overflow-in-checkList.patch} | 4 +- ...eap-use-after-free-in-releasePageNotNull.patch} | 4 +- third_party/sqlite/src/src/os_unix.c | 51 ------ third_party/sqlite/src/src/os_win.c | 8 - third_party/sqlite/src/src/sqlite.h.in | 23 --- 16 files changed, 91 insertions(+), 458 deletions(-) commit 76a6017c77069cd5b3deb6efb071de6ae17b43dd Author: Peter Kasting <pkasting@chromium.org> Date: Mon Mar 18 19:14:05 2019 +0000 Misc. cleanup: * AddChildViewAt() -> AddChildView() where possible * Flatten nested conditionals * Improve comments * Minimize variable lifetime * Use DCHECK_IS_ON where appropriate * Use temps to reduce repetition * Prefer child_at() to GetIndexOf() where possible, for performance (also ease of changing to direct vector access APIs later) * Init variables as const * Use type alias where appropriate * NULL -> nullptr * Prefer (actual, expected) in DCHECK inequalities * RemoveMenuItemAt(): push pointer before removing; matches RemoveAllMenuItems() * Remove unnecessary qualifiers * Function names have () in comments * Prefer assignment-init to construction-init for simple inits * Use cbegin()/cend() explicitly for clarity * Avoid double-negative conditionals * Reorder code to reduce unnecessary work Bug: none Change-Id: If4a44ec9e3f02e7e4fd42a71fd4b15bb7bd30498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526563 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641715} .../notification_swipe_control_view.cc | 2 +- ash/system/network/network_list.cc | 10 +++---- .../ui/views/bookmarks/bookmark_bar_view.cc | 5 ++-- chrome/browser/ui/views/find_bar_view.cc | 15 +++++----- .../frame/browser_non_client_frame_view_ash.cc | 13 ++++----- chrome/browser/ui/views/infobars/infobar_view.cc | 2 +- .../views/omnibox/omnibox_popup_contents_view.cc | 2 +- chrome/browser/ui/views/tabs/tab_strip.cc | 8 ++---- components/ui_devtools/ui_element.h | 32 ++++++++++++---------- ui/views/controls/menu/menu_item_view.cc | 12 ++++---- ui/views/view.cc | 22 +++++++++------ ui/views/view.h | 26 +++++++++--------- ui/views/view_unittest.cc | 25 +++++++++-------- ui/views/window/non_client_view.cc | 5 ++-- 14 files changed, 91 insertions(+), 88 deletions(-) commit 183fabef2e80816b935df33c8b085721035aba73 Author: Matthew Jones <mdjones@chromium.org> Date: Mon Mar 18 19:12:07 2019 +0000 Add TouchlessUiController This patch adds the TouchlessUiController class that is created through AppHooks. The class defines an interface for downstream classes to implement. Bug: 930785 Change-Id: I9ea09d6a064d36d38cc024249724ae57d8d10551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1483392 Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#641714} .../src/org/chromium/chrome/browser/AppHooks.java | 9 +++++++++ chrome/android/java_sources.gni | 6 +++++- .../browser/touchless/TouchlessUiController.java | 10 ++++++++++ .../chrome/browser/touchless/NoTouchActivity.java | 14 +++++++++++++- .../browser/touchless/TouchlessUiController.java | 22 ++++++++++++++++++++++ 5 files changed, 59 insertions(+), 2 deletions(-) commit 8545fb3d07bdd6e0281e7aa5d72f79b63556305a Author: Johannes Henkel <johannes@chromium.org> Date: Mon Mar 18 19:11:56 2019 +0000 Looks like these tests pass on my box, on Linux, with this flag. So I think it's ok to remove the lines. Bug:942517 Change-Id: Ia74812fcd2df55af77bbfb36290918cb87e3d765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529193 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#641713} third_party/blink/web_tests/TestExpectations | 3 --- 1 file changed, 3 deletions(-) commit cda0bbd9d131809f8877f5084e080e9386dbee78 Author: Charlene Yan <cyan@chromium.org> Date: Mon Mar 18 19:10:02 2019 +0000 Fix unwanted underline on three dot menu. This is due to an incorrect heuristic for showing keyboard menu hints from menu_runner_impl.cc which checks if the button is currently focused. Added a new run type based on whether or not the event that triggered the app menu is a key event. Bug: 928678 Change-Id: I6df9159e9a63dedcfa5115fa9ddbfcbd86759d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516777 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#641712} .../ui/views/frame/hosted_app_menu_button.cc | 4 +- .../views/media_router/app_menu_test_api_views.cc | 2 +- chrome/browser/ui/views/toolbar/app_menu.cc | 3 + chrome/browser/ui/views/toolbar/app_menu.h | 5 + .../ui/views/toolbar/browser_app_menu_button.cc | 16 +-- .../ui/views/toolbar/browser_app_menu_button.h | 6 +- chrome/browser/ui/views/toolbar/toolbar_view.cc | 3 +- ui/views/BUILD.gn | 2 + ui/views/controls/menu/menu_item_view_unittest.cc | 26 ++--- ui/views/controls/menu/menu_runner.h | 3 + ui/views/controls/menu/menu_runner_impl.cc | 7 +- ui/views/controls/menu/menu_runner_impl.h | 2 +- ui/views/controls/menu/menu_runner_unittest.cc | 117 ++++++++++++--------- ui/views/controls/menu/test_menu_item_view.cc | 16 +++ ui/views/controls/menu/test_menu_item_view.h | 34 ++++++ 15 files changed, 159 insertions(+), 87 deletions(-) commit 654bddaf1f6b3481ee196f6d2a8cba779674718c Author: Dave Tapuska <dtapuska@chromium.org> Date: Mon Mar 18 19:05:46 2019 +0000 Media controls - Hide popup menu when exiting fullscreen Previously when exiting fullscreen we might adjust the scroll offset. We no longer do that so a kScroll event isn't dispatched to hide the popup menu. Hide the popup menu in the fullscreen exited event. BUG=941979 Change-Id: I8a14a6732d836702f0da8b2608603d2fc726f80e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524871 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#641711} third_party/blink/renderer/modules/media_controls/media_controls_impl.cc | 1 + 1 file changed, 1 insertion(+) commit 3780194b8b7949a0371285fba0013b1e39004c9f Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 18 19:03:49 2019 +0000 flags: assign upcoming-ui-features The plan is to just allow this flag to expire. Bug: None Change-Id: I1dc6dcf008de71d852666a9ad79469343f008dc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529199 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641710} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5f5ee515ff92bfbece2e840623a90a272404a9cb Author: Mike Reed <reed@google.com> Date: Mon Mar 18 19:02:13 2019 +0000 Skip alloc by placing SkiaPaintCanvas on stack Partial land of https://chromium-review.googlesource.com/c/chromium/src/+/1476977 Change-Id: Ib2ba65e026db6429c88d64141334fcfcdc440d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529071 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#641709} third_party/blink/renderer/core/layout/shapes/shape.cc | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) commit 5e668fda5b7d036c28ef75fbaec110cd1fc672ee Author: Khushal <khushalsagar@chromium.org> Date: Mon Mar 18 18:56:53 2019 +0000 ui/android: Missed adding observer in previous change. R=ericrk@chromium.org Bug: 937031 Change-Id: I0413728e3b18a6e807050137ec2428b52efe644a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525451 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#641708} ui/android/java/src/org/chromium/ui/base/WindowAndroid.java | 1 + 1 file changed, 1 insertion(+) commit bb2b81301e26b85dcd77764efc5be3c6ac21f5f7 Author: Daniel Rubery <drubery@chromium.org> Date: Mon Mar 18 18:56:01 2019 +0000 Set several MacOS file types to show platform warnings on download Although we are sending FULL_PINGs for each of these file types, it's probably useful to show platform warnings since the SB backend will not be able to evaluate most of these. Bug: 854877, 854855, 854838, 854808 Change-Id: Ib3f83626d0e4af281c8c9a89d1b7424110a597fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526602 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641707} .../safe_browsing/download_file_types.asciipb | 99 ++++++++++++++++++++-- .../download/internal/common/download_stats.cc | 84 +++++++++--------- tools/metrics/histograms/enums.xml | 16 ++++ 3 files changed, 153 insertions(+), 46 deletions(-) commit 68704c3addb0473bb13e08495a3de452b2b083df Author: Evan Stade <estade@chromium.org> Date: Mon Mar 18 18:55:25 2019 +0000 Move test method from PowerManagerClient to FakePowerManagerClient Bug: 644348 Change-Id: I420883c7ce6e61783fd56fd94e044f5e59291b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526485 Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#641706} ash/system/power/power_event_observer_unittest.cc | 111 +++++++++++---------- .../power/extension_event_observer_unittest.cc | 38 +++---- chromeos/dbus/power/fake_power_manager_client.cc | 4 - chromeos/dbus/power/fake_power_manager_client.h | 4 +- chromeos/dbus/power/power_manager_client.cc | 6 +- chromeos/dbus/power/power_manager_client.h | 4 - chromeos/disks/suspend_unmount_manager_unittest.cc | 6 +- chromeos/system/dark_resume_controller_unittest.cc | 12 ++- components/arc/power/arc_power_bridge_unittest.cc | 6 +- 9 files changed, 96 insertions(+), 95 deletions(-) commit a14701dedc01a50b18f2c49b98c6ac57b3478fd0 Author: Caroline Rising <corising@chromium.org> Date: Mon Mar 18 18:54:55 2019 +0000 Add two additional flag options for a user study on the tab hover cards feature. A user study is planned to gather opinions of trigger delay timings for tab hover cards. This cl adds "Enabled B" and "Enabled C" flag options that correspond to different delay times. This will be removed after the study ends. Bug: 910739 Change-Id: I0c29cb18d653c8dbf661d6c6372309b270308d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524530 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#641705} chrome/browser/about_flags.cc | 14 ++++++- chrome/browser/browser_features.cc | 3 ++ chrome/browser/browser_features.h | 1 + .../ui/views/tabs/tab_hover_card_bubble_view.cc | 48 ++++++++++++++++++---- .../ui/views/tabs/tab_hover_card_bubble_view.h | 16 ++++---- 5 files changed, 66 insertions(+), 16 deletions(-) commit 1e54a806a6a5dc77fffd9b9ebab6aeaf18f74fef Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Mon Mar 18 18:53:16 2019 +0000 Update V8 to version 7.5.62. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9157bb60..36585c1b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5cbb56bc8f9616a784c5ab916764c500af89bb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525319 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641704} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 69a63e246d4b70b937ad4317fe022e6cdea1e750 Author: Chris Lu <thegreenfrog@chromium.org> Date: Mon Mar 18 18:51:59 2019 +0000 [ios] Clear findInPage Namespace Clears findInPage JavaScript namespace in //ios/chrome/browser to ensure there are no collisions with //ios/web JavaScript. Bug: 919685 Change-Id: Ib7c23855fc104e2afaab9cd7b5d5fef12ea3a2f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515650 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Reviewed-by: Yi Su <mrsuyi@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641703} ios/chrome/browser/find_in_page/resources/find_in_page.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) commit ef9ee16fe2d7cdd3e11dab6fc100cd481fa057c8 Author: v.paturi <v.paturi@samsung.com> Date: Mon Mar 18 18:49:43 2019 +0000 Add support for classification of image sprites in dark mode. To generate the bitmap for sprite images the location of the images cannot be assumed to be (0,0) which is the current scenario. Instead the source rectangle of the image should be used for getting the correct bitmap of the image. In the case of image sprites, a single image object has to hold the classifications of all the images that it contains. Having a single DarkModeClassification object will wrongly give the classification of the first image that is classified to all the images of the sprite. So instead use the location of source rect of the image as a key for a map which stores the classifications. Bug: None Change-Id: I52487bb511bd5ed9c847cb381e537610f7a420f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514437 Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#641702} .../graphics/dark_mode_image_classifier.cc | 41 +++++++++++----- .../platform/graphics/dark_mode_image_classifier.h | 18 +++++-- .../graphics/dark_mode_image_classifier_test.cc | 56 +++++++++++++++++++++- .../renderer/platform/graphics/graphics_context.cc | 8 ++-- .../renderer/platform/graphics/graphics_context.h | 3 +- .../blink/renderer/platform/graphics/image.cc | 27 ++++++++++- .../blink/renderer/platform/graphics/image.h | 17 ++++--- 7 files changed, 137 insertions(+), 33 deletions(-) commit f356e06a325a2964d17c3dfd021c7b7355bbc417 Author: Ryan Sturm <ryansturm@chromium.org> Date: Mon Mar 18 18:48:01 2019 +0000 Removing Page capping feature and code Page Load capping is not being launched, so the code should be removed. I am leaving the content/ level code in case there is use for it somewhere, but the code related to data tracking, triggering and UI is not useful. Bug: 909916 Change-Id: If72b4040f5b6e058ce6d3b4b6bc8a3e2a2ce49bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493257 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#641701} chrome/browser/BUILD.gn | 12 - .../chrome_browsing_data_remover_delegate.cc | 11 - .../chrome_data_use_ascriber.cc | 5 - .../chrome_data_use_ascriber.h | 3 - .../chrome_page_load_capping_features.cc | 17 - .../chrome_page_load_capping_features.h | 20 - .../page_load_capping_blacklist.cc | 93 --- .../page_load_capping_blacklist.h | 60 -- .../page_load_capping_blacklist_unittest.cc | 233 ------- .../page_load_capping_browsertest.cc | 509 --------------- .../page_load_capping_infobar_delegate.cc | 191 ------ .../page_load_capping_infobar_delegate.h | 81 --- .../page_load_capping_infobar_delegate_unittest.cc | 113 ---- .../page_load_capping/page_load_capping_service.cc | 55 -- .../page_load_capping/page_load_capping_service.h | 53 -- .../page_load_capping_service_factory.cc | 41 -- .../page_load_capping_service_factory.h | 42 -- chrome/browser/infobars/infobars_browsertest.cc | 11 - .../page_capping_page_load_metrics_observer.cc | 374 ----------- .../page_capping_page_load_metrics_observer.h | 174 ----- ..._capping_page_load_metrics_observer_unittest.cc | 726 --------------------- .../page_load_metrics_initialize.cc | 3 - chrome/browser/profiles/profile_impl.cc | 12 +- chrome/test/BUILD.gn | 4 - .../data/data_use_measurement/page_capping.html | 7 - components/infobars/core/infobar_delegate.h | 2 +- tools/metrics/histograms/histograms.xml | 9 + tools/metrics/ukm/ukm.xml | 3 + 28 files changed, 21 insertions(+), 2843 deletions(-) commit 1cdd1097347121a209344c0e2c947530a1f41783 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Mon Mar 18 18:44:54 2019 +0000 Remove instrumentation for bug 880741 Bug https://crbug.com/880741 is fixed. This removes the instrumentation previously added. Bug: 880741 Change-Id: I86ad66aa02dc470b7bcf26c697196d7eda369e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528186 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641700} content/browser/frame_host/navigation_handle_impl.cc | 10 +--------- content/browser/frame_host/navigation_request.cc | 10 ---------- 2 files changed, 1 insertion(+), 19 deletions(-) commit 5e4ec2489fb091b79055fe8748530fb82b76becb Author: Patrick Noland <pnoland@chromium.org> Date: Mon Mar 18 18:41:40 2019 +0000 [Chromeshine] Hook up in-memory components to persistence This CL makes a large number changes to account for the fact that UsageStatsService operations are now async. The major upshot is that promises are used instead of actual values. If data has been loaded, then promises are fulfilled immediately. Otherwise, they're fulfilled once the database is loaded. There is a corresponding downstream change that adjusts UsageStatsBrowserService to account for this. There are also a couple bug fixes; usage stats database needs to split its databases into different folders, so that is fixed. Bug: 939456 Change-Id: I0869318b5733ea6cb496af31224c6e9c93030fb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509103 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#641699} .../chrome/browser/usage_stats/EventTracker.java | 10 +- .../browser/usage_stats/PageViewObserver.java | 31 +-- .../browser/usage_stats/SuspensionTracker.java | 6 +- .../chrome/browser/usage_stats/TokenTracker.java | 16 +- .../browser/usage_stats/UsageStatsService.java | 271 +++++++++++++++++++-- .../browser/usage_stats/EventTrackerTest.java | 3 +- .../browser/usage_stats/PageViewObserverTest.java | 96 +++++--- .../android/usage_stats/usage_stats_database.cc | 32 +-- 8 files changed, 371 insertions(+), 94 deletions(-) commit 35d5999dcbba26b0ed26803cfeeeb5c8aee35840 Author: Lan Wei <lanwei@chromium.org> Date: Mon Mar 18 18:41:19 2019 +0000 Add pause to wait for scroll stop in WPT pointerevent touch test In order to run the web-platform-tests automatically, we will use testdriver Action API in all the wpt to simulate inputs. Here we are changing some pointerevent touch input tests which are doing scrolling. We are using "pause" action in the action sequence to wait for the scroll to stop to avoid fling and the memory leak. Bug: 606367 Change-Id: Ic55144000c710789639e0996a3a3fab5ce3bdd42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503899 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641698} ....html => pointerevent_pointercancel_touch.html} | 12 ++++++++ .../wpt/pointerevents/pointerevent_support.js | 33 ++++++++++++++++++++++ ...revent_pointercancel_touch-manual-automation.js | 7 ----- 3 files changed, 45 insertions(+), 7 deletions(-) commit 3b8ce2681f0958a4403daaf34a972cf235a50bad Author: bsheedy <bsheedy@chromium.org> Date: Mon Mar 18 18:40:33 2019 +0000 Support VR perf tests on Windows Adds support for running the existing VR Telemetry benchmarks on Windows. Currently only supports the Oculus runtime, which requires special hardware and software to be installed, but additional runtime support will be added in follow-up CLs. Bug: 939178 Change-Id: I71056b1da9aa07a374602757f5ddfafcfc972316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521797 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#641697} BUILD.gn | 6 +- tools/perf/contrib/vr_benchmarks/BUILD.gn | 32 ++-- .../vr_benchmarks/desktop_runtimes/__init__.py | 0 .../vr_benchmarks/desktop_runtimes/base_runtime.py | 39 ++++ .../desktop_runtimes/oculus_runtimes.py | 64 +++++++ .../desktop_runtimes/openvr_runtimes.py | 21 +++ .../vr_benchmarks/desktop_runtimes/wmr_runtimes.py | 23 +++ .../vr_benchmarks/shared_android_vr_page_state.py | 206 -------------------- .../contrib/vr_benchmarks/shared_vr_page_state.py | 210 +++++++++++++++++++++ tools/perf/contrib/vr_benchmarks/vr_benchmarks.py | 50 +++-- .../vr_benchmarks/vr_browsing_mode_pages.py | 4 +- tools/perf/contrib/vr_benchmarks/vr_sample_page.py | 5 +- .../perf/contrib/vr_benchmarks/webvr_wpr_pages.py | 4 +- 13 files changed, 420 insertions(+), 244 deletions(-) commit 30f1e55536b14ed1d4b52ea4a04e0b0aeefd1fef Author: Alexander Timin <altimin@chromium.org> Date: Mon Mar 18 18:38:04 2019 +0000 [scheduler] Replace OnActiveConnectionCreated with RegisterFeature Generalise active connection detection mechanism. It will be used to detect the presence of bfcache-related features and will continue to exempt pages with active connections from throttling. R=haraken@chromium.org BUG=933147 Change-Id: If8aecb95fc4650e0fcc0d7c047b334a794d60cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508463 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641696} .../peerconnection/adapters/ice_transport_proxy.cc | 5 +- .../peerconnection/adapters/ice_transport_proxy.h | 4 +- .../modules/peerconnection/rtc_peer_connection.cc | 10 ++-- .../modules/peerconnection/rtc_peer_connection.h | 4 +- .../modules/websockets/websocket_channel_impl.cc | 15 +++--- .../modules/websockets/websocket_channel_impl.h | 4 +- .../blink/renderer/platform/scheduler/BUILD.gn | 1 + third_party/blink/renderer/platform/scheduler/DEPS | 1 + .../scheduler/common/frame_or_worker_scheduler.cc | 32 ++++++++++++ .../scheduler/main_thread/frame_scheduler_impl.cc | 34 ++++++------- .../scheduler/main_thread/frame_scheduler_impl.h | 23 +++------ .../main_thread/page_scheduler_impl_unittest.cc | 8 +-- .../scheduler/public/frame_or_worker_scheduler.h | 58 +++++++++++++++++----- .../platform/scheduler/public/scheduling_policy.h | 48 ++++++++++++++++++ .../platform/scheduler/public/worker_scheduler.h | 7 ++- .../platform/scheduler/test/fake_frame_scheduler.h | 7 +-- .../test/renderer_scheduler_test_support.cc | 7 +-- .../platform/scheduler/worker/worker_scheduler.cc | 11 ++-- 18 files changed, 200 insertions(+), 79 deletions(-) commit fdbc8beebe3e89c3e7c1a9ca2d6b039ba784fca4 Author: Maks Orlovich <morlovich@chromium.org> Date: Mon Mar 18 18:34:52 2019 +0000 Pass in full Options to SetCanonicalCookieAsync This will be used to check whether same site cookies are being set in the proper context. This change alters all the callsites to include whether it should be trusted to set such cookies or not, so it's not a simple/mechanical transformation. (The old bool for httponly gets passed inside the options object as well, like it would be for the get). Bug: 837412 Change-Id: Ie7faf4e7cbc80706720e6ad20f6a46c759621f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1471244 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641695} android_webview/browser/cookie_manager.cc | 6 +-- .../browser/net/aw_cookie_store_wrapper.cc | 12 ++--- .../browser/net/aw_cookie_store_wrapper.h | 2 +- .../aw_cookie_manager_wrapper.cc | 4 +- .../aw_cookie_manager_wrapper.h | 2 +- .../android/cookies/cookies_fetcher_util.cc | 8 ++- .../browsing_data_cookie_helper_unittest.cc | 40 +++++++-------- .../browsing_data_remover_browsertest.cc | 4 +- ...rome_browsing_data_remover_delegate_unittest.cc | 8 +-- .../counters/site_data_counting_helper_unittest.cc | 4 +- .../android_sms_app_setup_controller_impl.cc | 10 +++- ...droid_sms_app_setup_controller_impl_unittest.cc | 22 +++++--- chrome/browser/chromeos/login/profile_auth_data.cc | 7 ++- .../chromeos/login/profile_auth_data_unittest.cc | 8 +-- .../chromeos/login/webview_login_browsertest.cc | 2 +- .../api/browsing_data/browsing_data_test.cc | 4 +- .../browser/extensions/api/cookies/cookies_api.cc | 6 ++- .../extensions/extension_service_unittest.cc | 2 +- .../net/chrome_network_service_browsertest.cc | 2 +- .../profile_resetter_browsertest.cc | 4 +- .../ui/webui/chromeos/login/gaia_screen_handler.cc | 9 +++- .../core/browser/gaia_cookie_manager_service.cc | 7 ++- .../clear_site_data_handler_browsertest.cc | 7 +-- .../cookie_store/cookie_store_manager_unittest.cc | 4 +- .../devtools_url_interceptor_request_job.cc | 6 +-- .../devtools/devtools_url_loader_interceptor.cc | 2 +- .../browser/devtools/protocol/network_handler.cc | 21 ++++++-- .../frame_host/render_frame_message_filter.cc | 7 ++- content/public/test/browser_test_utils.cc | 8 +-- .../gaia_auth_fetcher_ios_ns_url_session_bridge.mm | 7 ++- ..._fetcher_ios_ns_url_session_bridge_unittests.mm | 6 ++- ios/net/cookies/cookie_store_ios.h | 2 +- ios/net/cookies/cookie_store_ios.mm | 4 +- ios/net/cookies/cookie_store_ios_persistent.h | 2 +- ios/net/cookies/cookie_store_ios_persistent.mm | 4 +- net/cookies/cookie_monster.cc | 17 +++---- net/cookies/cookie_monster.h | 14 ++--- net/cookies/cookie_monster_unittest.cc | 8 +-- net/cookies/cookie_options.h | 2 +- net/cookies/cookie_store.h | 12 +++-- net/cookies/cookie_store_test_helpers.cc | 4 +- net/cookies/cookie_store_test_helpers.h | 2 +- net/cookies/cookie_store_unittest.h | 10 +++- net/url_request/url_request_http_job.cc | 4 ++ services/network/cookie_manager.cc | 4 +- services/network/cookie_manager.h | 2 +- services/network/cookie_manager_unittest.cc | 10 +++- services/network/network_context_unittest.cc | 5 +- services/network/public/cpp/cookie_manager.typemap | 2 +- .../public/cpp/cookie_manager_mojom_traits.cc | 24 ++++----- .../public/cpp/cookie_manager_mojom_traits.h | 8 +-- .../cpp/cookie_manager_mojom_traits_unittest.cc | 59 +++++++++++++++++++++- services/network/public/mojom/cookie_manager.mojom | 19 ++++--- services/network/restricted_cookie_manager.cc | 8 ++- .../network/restricted_cookie_manager_unittest.cc | 5 +- services/network/test/test_cookie_manager.cc | 2 +- services/network/test/test_cookie_manager.h | 2 +- 57 files changed, 319 insertions(+), 157 deletions(-) commit e6bccc145108480a9d051b7832d1bbe99d31a286 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Mar 18 18:29:27 2019 +0000 [Background Sync] Remove experimental flag from test. Background Sync is no longer experimental. With this change, the browser tests will no longer set the "Experimental Web Platform Features" flag. Bug: 932591 Change-Id: I4468e7510a1dcaf8825e9a39265e04bc303f5f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529051 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#641694} content/browser/background_sync/background_sync_browsertest.cc | 8 -------- 1 file changed, 8 deletions(-) commit a38bbf6a13f8c94f5f8ac093b46ef16b0a559673 Author: Eric Stevenson <estevenson@chromium.org> Date: Mon Mar 18 18:28:11 2019 +0000 Reland "Trichrome: Remove webview deps from trichrome_chrome_apk." This reverts commit 627a3616496ca978371267305499c77d02011222. Reason for revert: Fixed v8 64 bit issues by adding secondary ABI targets. This CL removes Java deps, some Java resource deps, Webview's locale pak files and other assets from TrichromeChrome.apk. Bug: 932253 Change-Id: I34ea5f24c371053ca6edbcb60f1ce637aaaa078f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526188 Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641693} chrome/android/BUILD.gn | 77 +++++++++++++++--- chrome/android/chrome_public_apk_tmpl.gni | 127 +++++++++++++++++------------- 2 files changed, 138 insertions(+), 66 deletions(-) commit b14d4171305e7fdfbf25a1591961ffebfb552c1d Author: David Black <dmblack@google.com> Date: Mon Mar 18 18:27:45 2019 +0000 Reset Assistant query view when necessary. When Assistant UI is closed, we need to reset the query view to empty as AssistantMainStage is not necessarily being destroyed. We also need to handle the case where an interaction is cancelled (e.g. if the user taps the mic partway through a dictation). In such situations, the query view should restore the previous committed query. Bug: b:128712891 Change-Id: I61c8e05496efd69739fbd60c60f947bccaad2807 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526815 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#641692} ash/app_list/views/assistant/assistant_main_stage.cc | 10 ++++++++++ ash/app_list/views/assistant/assistant_main_stage.h | 1 + 2 files changed, 11 insertions(+) commit a37624bccf96585afb2ee4665b63a6a42163db45 Author: Tina Wang <tinazwang@chromium.org> Date: Mon Mar 18 18:27:06 2019 +0000 [Self Share] Add confirmation notification when user successfully send tab to other devices Add a transient notification to tell the user that the tab is successfully shared. Bug: 941177 Change-Id: I8ede1448c9bd3a4eabea2ae234f08640abc0c1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518899 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#641691} .../desktop_notification_handler.cc | 25 +++++++++++++++++++--- .../desktop_notification_handler.h | 7 ++++++ .../send_tab_to_self/send_tab_to_self_util.cc | 13 ++++++++--- ui/strings/ui_strings.grd | 3 +++ ..._SEND_TAB_TO_SELF_CONFIRMATION_SUCCESS.png.sha1 | 1 + 5 files changed, 43 insertions(+), 6 deletions(-) commit 20c67bc72b6d39483a57e0f2265df6341a1b1b10 Author: Francois Doray <fdoray@chromium.org> Date: Mon Mar 18 18:26:22 2019 +0000 Document attempt to get rid of the macros in WebContentsUserData. Bug: 589840 Change-Id: I267eaaeb7ff30dd57acce5727d601d114b780b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528471 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641690} content/public/browser/web_contents_user_data.h | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) commit 653fcfdc69477c441c8e0105223fbba4eadb3e8d Author: Mason Freed <masonfreed@chromium.org> Date: Mon Mar 18 18:23:49 2019 +0000 Added ability to scale empty rects, and scale rects to zero. Previous to this CL, the SkRRect backing for gfx::RRectF would not allow scaling rects to zero, or scaling empty rects by any factor. With this CL, both operations are supported and tested. Bug: 497522 Change-Id: I2766d92502954ddbc052a3bb3d29f8f07de201d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525055 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#641689} ui/gfx/rrect_f.cc | 27 ++++++++++++++++++ ui/gfx/rrect_f.h | 5 +--- ui/gfx/rrect_f_unittest.cc | 69 +++++++++++++++++++++++++++++----------------- 3 files changed, 72 insertions(+), 29 deletions(-) commit 1c4ea009940dbca7b3087e1123631a3907ab0b84 Author: Andrew Grieve <agrieve@chromium.org> Date: Mon Mar 18 18:14:07 2019 +0000 Android: Make proguard deobfuscation more careful about false-positives Language tags look like class names. Bug: 938270 Change-Id: I242104be127e450cae4690bc6e76245ad672196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526166 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Reviewed-by: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#641688} .../java/org/chromium/build/FlushingReTrace.java | 21 +++-- build/android/stacktrace/java_deobfuscate_test.py | 104 +++++++++++---------- 2 files changed, 65 insertions(+), 60 deletions(-) commit 672589c7a6d00236c0a249b8d8bce9f49d111831 Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Mar 18 18:04:47 2019 +0000 Move chromeos/dbus/session_manager_client to subdir Note: The subdir is 'session_manager' instead of the shorter 'session' to reduce any confusion with components/sessions and to match components/session_manager (and the process name). Purely mechanical move in preparation for extracting SessionManagerClient from DBusThreadManager: ./tools/git/move_source_file.py chromeos/dbus/session_manager_client.cc chromeos/dbus/session_manager ./tools/git/move_source_file.py chromeos/dbus/session_manager_client.h chromeos/dbus/session_manager ./tools/git/move_source_file.py chromeos/dbus/fake_session_manager_client.cc chromeos/dbus/session_manager/ ./tools/git/move_source_file.py chromeos/dbus/fake_session_manager_client.h chromeos/dbus/session_manager/ Bug: 644350 For bulk mechanical changes: TBR=sky@chromium.org Change-Id: I6c831b3cabc38dcf167056fe5016a761cde9a6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526312 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641687} .../api/arc_apps_private/arc_apps_private_apitest.cc | 2 +- .../browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc | 2 +- .../arc/arc_play_store_enabled_preference_handler_unittest.cc | 2 +- chrome/browser/chromeos/arc/arc_session_manager.cc | 2 +- chrome/browser/chromeos/arc/arc_session_manager.h | 2 +- chrome/browser/chromeos/arc/arc_session_manager_unittest.cc | 2 +- .../arc/boot_phase_monitor/arc_boot_phase_monitor_bridge.cc | 2 +- .../boot_phase_monitor/arc_boot_phase_monitor_bridge_unittest.cc | 2 +- chrome/browser/chromeos/child_accounts/screen_time_controller.cc | 2 +- chrome/browser/chromeos/chrome_browser_main_chromeos.cc | 2 +- .../chromeos/extensions/autotest_private/autotest_private_api.cc | 2 +- chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc | 2 +- chrome/browser/chromeos/login/chrome_restart_request.cc | 2 +- chrome/browser/chromeos/login/crash_restore_browsertest.cc | 4 ++-- chrome/browser/chromeos/login/existing_user_controller.cc | 2 +- .../chromeos/login/existing_user_controller_browsertest.cc | 2 +- chrome/browser/chromeos/login/lock/screen_locker.cc | 2 +- chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc | 2 +- chrome/browser/chromeos/login/reset_browsertest.cc | 2 +- chrome/browser/chromeos/login/saml/saml_browsertest.cc | 4 ++-- chrome/browser/chromeos/login/screens/demo_setup_screen.cc | 2 +- chrome/browser/chromeos/login/screens/error_screen.cc | 2 +- .../browser/chromeos/login/screens/network_screen_browsertest.cc | 2 +- chrome/browser/chromeos/login/screens/reset_screen.cc | 2 +- chrome/browser/chromeos/login/session/chrome_session_manager.cc | 2 +- chrome/browser/chromeos/login/session/user_session_manager.cc | 2 +- chrome/browser/chromeos/login/session/user_session_manager.h | 2 +- chrome/browser/chromeos/login/ui/login_display_host_webui.cc | 2 +- chrome/browser/chromeos/login/ui/login_display_host_webui.h | 2 +- chrome/browser/chromeos/login/ui/login_display_mojo.cc | 2 +- chrome/browser/chromeos/login/ui/webui_login_view.cc | 2 +- .../chromeos/login/users/avatar/user_image_manager_browsertest.cc | 4 ++-- .../browser/chromeos/login/users/wallpaper_policy_browsertest.cc | 4 ++-- chrome/browser/chromeos/login/webview_login_browsertest.cc | 2 +- chrome/browser/chromeos/login/wizard_controller.cc | 2 +- chrome/browser/chromeos/login/wizard_controller_browsertest.cc | 2 +- chrome/browser/chromeos/note_taking_helper_unittest.cc | 2 +- .../browser/chromeos/ownership/owner_settings_service_chromeos.h | 2 +- chrome/browser/chromeos/policy/affiliation_test_helper.cc | 4 ++-- .../policy/component_active_directory_policy_browsertest.cc | 2 +- .../chromeos/policy/component_active_directory_policy_retriever.h | 2 +- .../component_active_directory_policy_retriever_unittest.cc | 4 ++-- .../policy/component_active_directory_policy_service_unittest.cc | 2 +- chrome/browser/chromeos/policy/device_cloud_policy_browsertest.cc | 2 +- .../policy/device_cloud_policy_manager_chromeos_unittest.cc | 2 +- .../browser/chromeos/policy/device_local_account_browsertest.cc | 2 +- .../chromeos/policy/device_local_account_policy_service.cc | 2 +- .../browser/chromeos/policy/device_local_account_policy_store.h | 2 +- chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc | 2 +- .../chromeos/policy/display_resolution_handler_browsertest.cc | 4 ++-- .../policy/display_rotation_default_handler_browsertest.cc | 4 ++-- chrome/browser/chromeos/policy/power_policy_browsertest.cc | 2 +- chrome/browser/chromeos/policy/pre_signin_policy_fetcher.h | 2 +- .../browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc | 2 +- chrome/browser/chromeos/policy/server_backed_state_keys_broker.cc | 2 +- .../chromeos/policy/server_backed_state_keys_broker_unittest.cc | 2 +- .../chromeos/policy/signin_profile_apps_policy_browsertest.cc | 2 +- .../chromeos/policy/site_isolation_flag_handling_browsertest.cc | 2 +- chrome/browser/chromeos/policy/user_affiliation_browsertest.cc | 4 ++-- chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.h | 2 +- .../chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc | 2 +- .../chromeos/settings/device_oauth2_token_service_unittest.cc | 2 +- chrome/browser/chromeos/settings/device_settings_service.h | 2 +- chrome/browser/chromeos/settings/device_settings_test_helper.h | 2 +- .../browser/chromeos/settings/scoped_cros_settings_test_helper.h | 2 +- chrome/browser/chromeos/settings/session_manager_operation.h | 2 +- chrome/browser/chromeos/shutdown_policy_browsertest.cc | 4 ++-- chrome/browser/chromeos/system/device_disabling_browsertest.cc | 4 ++-- .../browser/chromeos/system/device_disabling_manager_unittest.cc | 2 +- .../enterprise_device_attributes_apitest.cc | 2 +- .../extensions/api/platform_keys/platform_keys_test_base.cc | 4 ++-- chrome/browser/lifetime/termination_notification.cc | 2 +- chrome/browser/ui/ash/session_controller_client.cc | 2 +- chrome/browser/ui/ash/system_tray_client.cc | 2 +- .../ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc | 2 +- chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc | 2 +- chromeos/components/proximity_auth/screenlock_bridge.cc | 2 +- chromeos/dbus/BUILD.gn | 8 ++++---- chromeos/dbus/dbus_clients_common.cc | 2 +- chromeos/dbus/dbus_thread_manager.cc | 2 +- chromeos/dbus/fake_auth_policy_client.cc | 2 +- chromeos/dbus/fake_auth_policy_client.h | 2 +- chromeos/dbus/fake_auth_policy_client_unittest.cc | 2 +- .../dbus/{ => session_manager}/fake_session_manager_client.cc | 2 +- chromeos/dbus/{ => session_manager}/fake_session_manager_client.h | 8 ++++---- chromeos/dbus/{ => session_manager}/session_manager_client.cc | 4 ++-- chromeos/dbus/{ => session_manager}/session_manager_client.h | 6 +++--- chromeos/login/auth/login_performer.cc | 2 +- components/arc/arc_client_adapter.h | 2 +- components/arc/arc_container_client_adapter.cc | 2 +- components/arc/arc_session_impl_unittest.cc | 2 +- components/arc/arc_session_runner_unittest.cc | 2 +- components/arc/arc_util.cc | 2 +- components/arc/arc_vm_client_adapter.cc | 4 ++-- components/arc/metrics/arc_metrics_service.cc | 2 +- components/arc/metrics/arc_metrics_service_unittest.cc | 2 +- ui/base/idle/DEPS | 2 +- ui/base/idle/idle_chromeos.cc | 2 +- 98 files changed, 120 insertions(+), 120 deletions(-) commit b92e241e3995122443f18086167a879515c99664 Author: Mugdha Lakhani <nator@chromium.org> Date: Mon Mar 18 18:04:33 2019 +0000 [Background Sync] Remove more instances of raw new. This CL weeds out more instances of raw new and replaces them with std::make_unique<>, wherever appropriate, per this guideline: https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#use-and-instead-of-bare In one instance, there's no need of a pointer, so it's been removed. Bug: 932591 Change-Id: I0b99d8ebc468bd7c496b7d50844f46fea2d68b44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529090 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#641686} .../background_sync_controller_impl_unittest.cc | 9 +++++---- .../browser/background_sync/background_sync_browsertest.cc | 4 ++-- .../background_sync_service_impl_unittest.cc | 13 ++++++------- 3 files changed, 13 insertions(+), 13 deletions(-) commit 4c1c5d88225c2603c522b0ed5a31b07a9e127270 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Mon Mar 18 18:02:48 2019 +0000 Add temporary instrumentation into NavigationRequest::BeginNavigation(). This checks AT RUNTIME that no NavigationURLLoader is associated with the NavigationRequest when BeginNavigation is called. In particular, the path RestartNavigationAsCrossDocument looks suspicious to me. This is temporary, it will be removed when the bug will be closed. Bug: 936962 Change-Id: I9acb1bc3b22de2aa4a9f7465ae82d9d28134e51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528234 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641685} content/browser/frame_host/navigation_request.cc | 11 +++++++++++ 1 file changed, 11 insertions(+) commit 93b262693d44d890084d6133e0e9055c209f6147 Author: Olivier Robin <olivierrobin@chromium.org> Date: Mon Mar 18 18:01:02 2019 +0000 Fetch gn based on the host OS. https://chromium-review.googlesource.com/c/chromium/src/+/1519726 changed the way gn is downloaded. Fix the conditions to download gn based on the host OS instead of the target OS Bug: 855791 Change-Id: Ib44c6268b60fad18ab5f69db1415c88e77e8806f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526276 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#641684} DEPS | 6 +++--- buildtools/DEPS | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) commit 4fb580e5d9da62da083358f3347952b3171feefa Author: Khushal <khushalsagar@chromium.org> Date: Mon Mar 18 17:58:20 2019 +0000 ui/gl: Fix some assumptions around TransactionAcks in SurfaceControl. This change fixes a couple of incorrect assumptions we were making with respect to the behaviour of transaction acks on SurfaceControl. TBR=nyquist@chromium.org R=piman@chromium.org Change-Id: I4c1997997c158e99eca17b013ed9db8d9776ef1b Bug: 942614 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526638 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#641683} base/android/scoped_hardware_buffer_fence_sync.h | 4 +- media/gpu/BUILD.gn | 1 - media/gpu/android/image_reader_gl_owner.cc | 19 +------ ui/gl/gl_image_ahardwarebuffer.cc | 65 +++++++++++++++--------- ui/gl/gl_image_ahardwarebuffer.h | 4 ++ ui/gl/gl_surface_egl_surface_control.cc | 37 ++++++++++++-- ui/gl/gl_surface_egl_surface_control.h | 3 ++ ui/gl/gl_utils.cc | 19 +++++++ ui/gl/gl_utils.h | 10 ++++ 9 files changed, 113 insertions(+), 49 deletions(-) commit ac106e829a0bdf16928b9c11969fb4151b1fbd39 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 17:56:34 2019 +0000 Roll Fuchsia SDK from 37d4d95da14b to 3e59cb1001cf The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id4239571b9b60b8cc34ef86d7d8df98c4c632cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526820 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641682} build/fuchsia/linux.sdk.sha1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0dc61dd993b9fe92a45cccf96e9808c46d17ed4f Author: Robbie Gibson <rkgibson@google.com> Date: Mon Mar 18 17:53:15 2019 +0000 [iOS] Prevent empty omnibox popup from opening on incognito pages Before, the call to [self.omniboxPopupCoordinator openPopup] in the location bar coordinator would always add the popup, under the assumption that there would always be at least one suggestion (the current page's URL). However, on incognito pages (both NTP and regular pages), this doesn't appear and there are no suggestions, so the popup appears, but is blank. Instead of manually ordering the popup to appear or disappear, we can use the popup's intrinsic content size, which is already how the popup is being sized on iPad. Thus, when we were ordering the popup to appear or collapse, we can instead just update the display status. Bug: 933133 Change-Id: I11d3dff55f1a2f13daad259370e81df6ad7cc55a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514573 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641681} .../ui/location_bar/location_bar_coordinator.mm | 6 +-- .../ui/omnibox/popup/omnibox_popup_coordinator.h | 9 +++-- .../ui/omnibox/popup/omnibox_popup_coordinator.mm | 12 +++--- .../ui/omnibox/popup/omnibox_popup_mediator.mm | 12 +----- .../ui/omnibox/popup/omnibox_popup_presenter.h | 12 +++--- .../ui/omnibox/popup/omnibox_popup_presenter.mm | 46 ++++++++++++---------- .../ui/omnibox/popup/self_sizing_table_view.mm | 7 +++- 7 files changed, 53 insertions(+), 51 deletions(-) commit 76cabcd5e570b7df49e2d37ac71249dfd4da7e2c Author: Marc Treib <treib@chromium.org> Date: Mon Mar 18 17:51:34 2019 +0000 Migrate PeopleHandlerTest to MockSyncService ...from ProfileSyncServiceMock, which is an antipattern. Bug: 910518 Change-Id: Ice6b8370077738d2c6f55904ecb036326761480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525921 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641680} .../ui/webui/settings/people_handler_unittest.cc | 385 ++++++++++++--------- 1 file changed, 215 insertions(+), 170 deletions(-) commit de3aaaa86fe22eb16e05c904ab13bd09c35462f3 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Mon Mar 18 17:50:13 2019 +0000 views_bridge_mac: migrate off deprecated NSAccessibility API This change is pretty simple because there are no uses of these APIs and only two overrides of deprecated methods: * BridgedContentView now supports accessibilityChildren directly * NativeWidgetMacNSWindow now supports accessibilityTitle directly In informal testing, browser windows and controls seem to still be navigable using VoiceOver. Bug: 386671 Change-Id: I46593b863603a4c2155cfd19859ea09401182c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528470 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#641679} ui/views_bridge_mac/bridged_content_view.mm | 15 +++++++-------- ui/views_bridge_mac/native_widget_mac_nswindow.mm | 21 +++++++++------------ 2 files changed, 16 insertions(+), 20 deletions(-) commit 83ef1761a06fda4d6b4890aebc344d9187af8e13 Author: Friedrich Horschig <fhorschig@chromium.org> Date: Mon Mar 18 17:48:43 2019 +0000 [Mfill Android] Move mediator properties into model With this CL, the state of the filling components are stored in a PropertyModel to generalize some behaviors. This is the base to structure new states for showing the accessory without keyboard. Bug: 932124 Change-Id: Ie75a15e99bdd3aae13615f20af1856cbf98fb48a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520493 Reviewed-by: Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#641678} .../KeyboardAccessoryCoordinator.java | 2 +- .../keyboard_accessory/ManualFillingMediator.java | 169 ++++++++++++++------- .../ManualFillingProperties.java | 43 ++++++ chrome/android/java_sources.gni | 1 + .../KeyboardAccessoryControllerTest.java | 10 +- 5 files changed, 165 insertions(+), 60 deletions(-) commit 11f6ef48fc13d66e9189d186dd1016431d8d8354 Author: David Bokan <bokan@chromium.org> Date: Mon Mar 18 17:47:27 2019 +0000 Immediately complete synthetic gestures in VR In https://crrev.com/b37e23cbd52ba447ab89c6d18f4ea0ecdc3fa5c0 I landed a change to force synthetic gestures to cause a full redraw and wait for the resulting CompositorFrame to be presented before invoking the completion callback. This patch broke VR telemetry. We never receive the presentation notification so synthetic gestures never complete and cause the tests to hang and timeout. This CL causes synthetic gestures to complete without causing the redraw and waiting for frame presentation if we're in VR mode. This was the behavior prior to my change and gets the waterfall back to a green state. I'll investigate a correct long term fix in a followup. Bug: 940063 Change-Id: I6f6b9e9a5b9e369a1ec010cba93a1d952d3d0a18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525150 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641677} content/renderer/input/widget_input_handler_manager.cc | 8 +++++--- content/renderer/render_view_impl.cc | 9 +++++++++ content/renderer/render_view_impl.h | 1 + content/renderer/render_widget_delegate.h | 4 ++++ content/renderer/render_widget_unittest.cc | 1 + 5 files changed, 20 insertions(+), 3 deletions(-) commit cd76eecb233352eac8fec48cfc65a5b91bc0e3a9 Author: Staphany Park <staphany@chromium.org> Date: Mon Mar 18 17:46:49 2019 +0000 AppCache: Remove command-line flags for default quota and disk size. Bug: 895825 Change-Id: Ic44559eff351a0efec8b807f973af6e356a2e293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528001 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#641676} content/browser/appcache/appcache_storage_impl.cc | 36 +++-------------------- content/public/common/content_switches.cc | 11 ------- content/public/common/content_switches.h | 2 -- 3 files changed, 4 insertions(+), 45 deletions(-) commit 639cd9b85f915e43af896a33d4b83420e912f5a7 Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Mon Mar 18 17:44:43 2019 +0000 Use UmaHistogramLongTimes to log the WMI::AddEnum call duration Bug: 939092 Change-Id: I630a0497925d30d0419d0c58b10d921f6ab1dc28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525178 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#641675} .../browser/performance_monitor/wmi_refresher.cc | 9 ++++---- tools/metrics/histograms/histograms.xml | 26 ++++++++++++++++++++++ 2 files changed, 31 insertions(+), 4 deletions(-) commit af050df6dec15b4067600be3253d2ee649c50f34 Author: Will Cassella <cassew@google.com> Date: Mon Mar 18 17:43:38 2019 +0000 Update CSS properties for immersive-mode media controls The volume-control-container element has CSS properties which were not override for the immersive video player with slightly smaller controls. Also, the modern media controls interfere with the custom immersive-mode styling, so the hover-background elements for that have been hidden. Bug: 918648 Change-Id: I755a3fcf8ec653d0d2693c0e4cc197587cd3126e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526675 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#641674} .../media_controls/resources/modernMediaControls.css | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit 59ab43804d04f3d3ceaebf416dffffecd72da970 Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Mon Mar 18 17:42:44 2019 +0000 [LayoutNG] Remove unused geometry structs. As above. This should have no behaviour change. Change-Id: I78cad0b91877f736bcb7432a8e0a38e2f017f724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525318 Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641673} third_party/blink/renderer/core/BUILD.gn | 1 - third_party/blink/renderer/core/layout/BUILD.gn | 4 -- .../layout/ng/geometry/ng_physical_location.cc | 24 ----------- .../core/layout/ng/geometry/ng_physical_location.h | 31 -------------- .../core/layout/ng/geometry/ng_physical_rect.cc | 36 ---------------- .../core/layout/ng/geometry/ng_physical_rect.h | 47 --------------------- .../layout/ng/geometry/ng_physical_rect_test.cc | 49 ---------------------- 7 files changed, 192 deletions(-) commit ddf5eb65fb2b28df40e917997b553bd785cd537a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Mon Mar 18 17:41:59 2019 +0000 Roll src/third_party/swiftshader c2bb50b73101..1cef4e693fc3 (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/c2bb50b73101..1cef4e693fc3 git log c2bb50b73101..1cef4e693fc3 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 sugoi@google.com Allow null dispatchable objects 2019-03-18 capn@google.com Copy kokoro folder to tests/kokoro 2019-03-18 capn@google.com Fix Travis CI build 2019-03-18 bclayton@google.com Reintroduce "VkDebug: Update macros to address issues in b/127433389" Created with: gclient setdep -r src/third_party/swiftshader@1cef4e693fc3 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I4bed4d491d3a23bebb3b552d3580170193aa80a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528514 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641672} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd12cbbe661d209689a748c1e2cd889d6eab3e90 Author: Min Chen <minch@google.com> Date: Mon Mar 18 17:41:27 2019 +0000 Add a11y alert for entering/exiting full screen workspace state. Bug: 126849 Change-Id: I8de16c1d3f08c3d1be42068344a0f64a34ca7d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516776 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#641671} ash/accelerators/accelerator_commands_unittest.cc | 7 --- .../accessibility_controller_enums.mojom | 9 +++- ash/shelf/shelf_layout_manager.cc | 20 ++++++++ ash/shelf/shelf_layout_manager.h | 11 +++++ ash/shelf/shelf_layout_manager_unittest.cc | 53 ++++++++++++++++++++++ chrome/app/generated_resources.grd | 6 +++ ...ERT_WORKSPACE_FULLSCREEN_STATE_ENTERED.png.sha1 | 1 + ...LERT_WORKSPACE_FULLSCREEN_STATE_EXITED.png.sha1 | 1 + .../accessibility_controller_client.cc | 6 +++ 9 files changed, 106 insertions(+), 8 deletions(-) commit fdd984c20a5d977a13ff223edfee3a887fee7dde Author: Josh Nohle <nohle@google.com> Date: Mon Mar 18 17:32:27 2019 +0000 Move CryptAuthEnrollmentManager::RegisterPrefs() to implementation Because only the enrollment manager implementation, and not the base class, uses prefs, the static registration function should reside in the implementation files. Bug: 899080 Change-Id: Ie3712286893cec94470148ddb3cb43d4b4d14b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528476 Auto-Submit: Josh Nohle <nohle@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#641670} .../device_sync/cryptauth_enrollment_manager.cc | 17 ----------------- .../services/device_sync/cryptauth_enrollment_manager.h | 5 ----- .../device_sync/cryptauth_enrollment_manager_impl.cc | 15 +++++++++++++++ .../device_sync/cryptauth_enrollment_manager_impl.h | 4 ++++ .../cryptauth_enrollment_manager_impl_unittest.cc | 6 +++--- chromeos/services/device_sync/device_sync_impl.cc | 2 +- 6 files changed, 23 insertions(+), 26 deletions(-) commit b09a39ea5beb50cb5deb8f927c5241f5435932cf Author: Sami Kyostila <skyostil@chromium.org> Date: Mon Mar 18 17:26:57 2019 +0000 SequenceManager: Remove old crash keys Remove the old filename-based crash keys in favor of the address-based async stack trace crash key as the latter is much more efficient to record. To symbolize these crash keys, use the crsym/ tool (Googlers only). strings. Sample reports: 2ed1e0ebbf79045a (Android), dffdce7a5580f7e4 (Windows) Bug: 897751 Change-Id: I9e33e27459da079e8a78272c43dbe2a0b701acab Test: Checked that symbolization yields the same information as the old Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528610 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641669} base/task/sequence_manager/sequence_manager.h | 4 +--- base/task/sequence_manager/sequence_manager_impl.cc | 17 ++--------------- base/task/sequence_manager/sequence_manager_impl.h | 4 +--- .../sequence_manager/sequence_manager_impl_unittest.cc | 7 +------ .../browser/scheduler/browser_ui_thread_scheduler.cc | 4 +--- .../main_thread/main_thread_scheduler_helper.cc | 4 +--- 6 files changed, 7 insertions(+), 33 deletions(-) commit 6e879bddeb9e06ba6a8d62d523055d6574537f6b Author: Matt Menke <mmenke@chromium.org> Date: Mon Mar 18 17:26:04 2019 +0000 Use a single global constant priority for proxy tunnels over H2/QUIC. Previously, we'd use the priority of the first request to use a tunnel for the entire tunnel, as long as the tunnel existed. This could result in a HIGHEST priority tunnel later being used solely for low priority requests, for vice versa. This CL just uses a default priority for all proxy tunnels. We could reprioritize tunnels according to the highest priority request using them at any time. This might give better real-world performance, but it leaks more metadata to proxies. Bug: 898526 (940848 gets honorable mention) Change-Id: If140af0213f93673c7e0f9490f6d7e4d9f81978f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525174 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#641668} net/http/http_network_transaction_unittest.cc | 42 +++++++++----- net/http/http_proxy_client_socket_pool_unittest.cc | 7 ++- net/http/http_proxy_connect_job.cc | 19 +++--- net/http/http_proxy_connect_job.h | 7 +++ net/http/http_proxy_connect_job_unittest.cc | 47 +++++++++------ net/quic/quic_network_transaction_unittest.cc | 67 +++++++++++++--------- .../transport_client_socket_pool_unittest.cc | 8 +-- net/spdy/spdy_network_transaction_unittest.cc | 16 ++++-- 8 files changed, 133 insertions(+), 80 deletions(-) commit fdcb7460d72316b03a1a1194ab561a53dadf565b Author: Peng Huang <penghuang@chromium.org> Date: Mon Mar 18 17:25:51 2019 +0000 Support write access for ExternalVkImageSkiaRepresentation This CL also improves the ExternalVkImageSkiaRepresentation by avoiding using vkQueueWaitIdle. Bug: 932214,932260,932614 Change-Id: If40687586d39152b548eb5ee288a05e7c456337a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518752 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#641667} .../service/external_vk_image_backing.cc | 110 ++++------ .../service/external_vk_image_backing.h | 38 ++-- .../service/external_vk_image_gl_representation.cc | 119 +++++------ .../service/external_vk_image_gl_representation.h | 30 ++- .../external_vk_image_skia_representation.cc | 221 +++++++++++++-------- .../external_vk_image_skia_representation.h | 19 +- gpu/command_buffer/service/shared_image_factory.cc | 84 ++++---- gpu/command_buffer/service/shared_image_factory.h | 6 +- .../android/vulkan_implementation_android.cc | 61 ------ gpu/vulkan/android/vulkan_implementation_android.h | 6 - gpu/vulkan/generate_bindings.py | 2 +- gpu/vulkan/vulkan_function_pointers.cc | 10 +- gpu/vulkan/vulkan_function_pointers.h | 6 +- gpu/vulkan/vulkan_implementation.cc | 80 +++++++- gpu/vulkan/vulkan_implementation.h | 26 ++- gpu/vulkan/x/vulkan_implementation_x11.cc | 4 +- 16 files changed, 433 insertions(+), 389 deletions(-) commit 68f0ba5c326efe9d3ef77fd07a8d9056b78c36fc Author: Tommy C. Li <tommycli@chromium.org> Date: Mon Mar 18 17:24:10 2019 +0000 Docs: Add How to Write Cross-Platform UI doc Change-Id: Ic1d89de8dd642e932b7917bea06dc1656aa8f539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516075 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#641666} docs/cross_platform_ui.md | 80 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) commit 9d0fcece926434a474a5b6ec466039557bf17590 Author: Michael Lippautz <mlippautz@chromium.org> Date: Mon Mar 18 17:23:30 2019 +0000 heap: Remove infra to track stack frame depth Oilpan switched to non-eager tracing of objects recently. This removes the now unused infra to track stack frame depth. Bug: 933333 Change-Id: I8d75b6219cff838d20c8be5b71d62a85b005e339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524491 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641665} third_party/blink/renderer/platform/heap/BUILD.gn | 2 - third_party/blink/renderer/platform/heap/heap.h | 4 - .../blink/renderer/platform/heap/heap_allocator.h | 5 - .../blink/renderer/platform/heap/heap_page.cc | 5 - .../blink/renderer/platform/heap/heap_test.cc | 49 ---------- .../platform/heap/incremental_marking_test.cc | 5 - .../renderer/platform/heap/marking_visitor.cc | 4 - .../renderer/platform/heap/stack_frame_depth.cc | 65 ------------- .../renderer/platform/heap/stack_frame_depth.h | 107 --------------------- .../blink/renderer/platform/heap/thread_state.cc | 5 - .../blink/renderer/platform/heap/trace_traits.h | 1 - 11 files changed, 252 deletions(-) commit 4376bae7a7c9d63fad28b5b227aeae03235475c5 Author: Eric Seckler <eseckler@chromium.org> Date: Mon Mar 18 17:22:30 2019 +0000 tracing: Reword developer options hint TBR=twellington@chromium.org Change-Id: I0ef49a607322d7da41356d0b500debb41461d5b8 Bug: 942902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527537 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#641664} chrome/android/java/res/xml/developer_preferences.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4b3b399c9532e9993708ff9d8b4b58249abece03 Author: Li Lin <llin@chromium.org> Date: Mon Mar 18 17:21:05 2019 +0000 Handle audio focus for internal media player. libassistant only request audio focus with output type STREAM_MEDIA at the end of ReleaseFocusForStream. We would like to request audio focus when the internal media player is playing. In this CL: - When the internal media player start audio playback with audio output type STREAM_MEDIA, we explicitly acquire audio focus. - When the internal media player stop audio playback with audio output type STREAM_MEDIA, we explicitly abandon audio focus if necessary. Bug: b:123718677 Test: Manual Change-Id: Ia30e685d7ed2186145140c38ae8526db5284a7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506554 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641663} .../media_session/assistant_media_session.cc | 6 ++++- .../media_session/assistant_media_session.h | 4 ++++ .../platform/audio_output_provider_impl.cc | 27 ++++++++++++++++++++-- .../platform/audio_output_provider_impl.h | 1 + 4 files changed, 35 insertions(+), 3 deletions(-) commit 15746b4f534f87218a44c5ad23122a28df6954d9 Author: Parastoo Geranmayeh <parastoog@google.com> Date: Mon Mar 18 17:19:00 2019 +0000 [AF] Empty country/filling forms/invalid address fields Currently if a field is invalid, and we are using the client validation feature, the field will not get autofilled. According to the current validation logic, if country is empty, all the address fields would be considered as invalid. This is not good as we may have many valid profiles where the country is empty. Therefore, we are going to have an exception here and have the address fields autofilled, if the country is empty. The suggestions would not change as the validation only changes their order, and is not as aggressive. Change-Id: I479dd9dd853032e309679c4bcaf2b117bb29d3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524677 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#641662} components/autofill/core/browser/field_filler.cc | 21 ++++++++------ .../autofill/core/browser/field_filler_unittest.cc | 32 ++++++++++++++++++++++ 2 files changed, 45 insertions(+), 8 deletions(-) commit db141987f8fb0798139ed5abb539c42ccadc4be0 Author: Lily Chen <chlily@chromium.org> Date: Mon Mar 18 17:18:49 2019 +0000 Reland "NEL: Add SQLitePersistentReportingAndNELStore" This is a reland of 8c66199b51cc1f2c52f1b206823bc9054d6fa1bb. Fixes use of uninitialized |num_pending_|. Original change's description: > This CL adds SQLitePersistentReportingAndNELStore which persists > NEL policies to disk in a SQLite database. It will eventually also store > Reporting clients and reports. > > The code is based on that of the SQLitePersistentCookieStore. > > It is not hooked up to anything yet (just unittests). > > Bug: 895821 > Change-Id: I99ea14ace6f9b7fecd6075b1be98647db80d2bcb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504493 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641361} Bug: 942889, 895821 Change-Id: I679d6713a295715a3a08206f61c91cf58adcd0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528474 Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#641661} net/BUILD.gn | 13 + .../sqlite_persistent_reporting_and_nel_store.cc | 568 +++++++++++++++++++++ .../sqlite_persistent_reporting_and_nel_store.h | 62 +++ ..._persistent_reporting_and_nel_store_unittest.cc | 339 ++++++++++++ .../network_error_logging_service.cc | 55 +- .../network_error_logging_service.h | 54 ++ 6 files changed, 1057 insertions(+), 34 deletions(-) commit 24f1e17713076998ecc71fe550bec576b3bbf9ae Author: Stepan Khapugin <stkhapugin@chromium.org> Date: Mon Mar 18 17:16:56 2019 +0000 🦁 Split omnibox popup view controller into new and legacy. Creates a new OmniboxPopupBaseViewController class. Renames existing OmniboxPopupViewController class to OPLegacyVC. Updates all current usage of OPVC to OPLegacyVC. Bug: none Test: none Change-Id: I67338edce43431be0cd2b7dc9aabe91fcfc8c253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511356 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641660} ios/chrome/browser/ui/omnibox/popup/BUILD.gn | 6 ++-- .../popup/omnibox_popup_base_view_controller.h | 13 +++++++++ .../popup/omnibox_popup_base_view_controller.mm | 12 ++++++++ .../ui/omnibox/popup/omnibox_popup_coordinator.mm | 7 +++-- ...er.h => omnibox_popup_legacy_view_controller.h} | 15 +++++----- ....mm => omnibox_popup_legacy_view_controller.mm} | 33 ++++++++++++---------- .../omnibox_popup_view_controller_unittest.mm | 6 ++-- .../ui/omnibox/popup/omnibox_popup_view_ios.h | 2 +- .../sc_omnibox_popup_container_view_controller.h | 8 ++++-- .../sc_omnibox_popup_container_view_controller.mm | 4 +-- .../omnibox_popup/sc_omnibox_popup_coordinator.mm | 7 +++-- 11 files changed, 74 insertions(+), 39 deletions(-) commit 303dd795ed558fbb95c21ebdf11f98c0bbf8023f Author: Alexei Filippov <alph@chromium.org> Date: Mon Mar 18 17:15:08 2019 +0000 DevTools: Limit the script sources size retained solely by debugger. BUG=v8:8988 Change-Id: I0a0cc3b95814656de1a602cc31bca2fe726dae79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522193 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641659} third_party/blink/renderer/devtools/front_end/sdk/DebuggerModel.js | 6 +++++- .../http/tests/devtools/profiler/agents-disabled-check-expected.txt | 2 +- .../devtools/service-workers/service-worker-agents-expected.txt | 6 ++++++ 3 files changed, 12 insertions(+), 2 deletions(-) commit 0e03fcf2648bc8e84402a7099a143d815165ff64 Author: Karen Qian <karenqian@google.com> Date: Mon Mar 18 17:11:09 2019 +0000 Added perfetto test suite to Linux, Mac, and Windows bots. Added perfetto unittests to Linux, Mac, and Windows bots. Removed tests from Android bots because they were failing. Reland of https://crrev.com/c/1468261 with a few adjustments. Bug: 931138 Change-Id: Ic4e844f0008e5a267ee28db627c3c4086e0fdfbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524528 Commit-Queue: Karen Qian <karenqian@google.com> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#641658} testing/buildbot/chromium.chromiumos.json | 12 ++ testing/buildbot/chromium.clang.json | 191 +++++++++++++++++++++++++ testing/buildbot/chromium.fyi.json | 78 ++++++++++ testing/buildbot/chromium.linux.json | 41 ++++++ testing/buildbot/chromium.mac.json | 60 ++++++++ testing/buildbot/chromium.memory.json | 83 +++++++++++ testing/buildbot/chromium.win.json | 42 ++++++ testing/buildbot/test_suite_exceptions.pyl | 16 +++ testing/buildbot/test_suites.pyl | 1 + testing/buildbot/tryserver.chromium.linux.json | 7 + 10 files changed, 531 insertions(+) commit 29a3c6da7c63a97559688ea0781f059b67e87159 Author: David Bokan <bokan@chromium.org> Date: Mon Mar 18 17:09:08 2019 +0000 [SpatNav] Escape should blur any focused element In focusless spat-nav mode, escape will blur a focused element so the user can bo back to moving interest around. A common pattern is for the page to move focus to an inner input element when clicked. Currently, the implementation will blur the focused element on escape only if it's also interested. An alternative fix here would be to listen to focus changes and move interest as well. That's a larger change and it's not clear it's desirable. This CL simply removes the restriction that the focused element must be interested; the escape key will blur any focused element. Bug: 942110 Change-Id: I0379bb3272b154f88a749453a41dbe9eadce4c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526484 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641657} .../core/page/spatial_navigation_controller.cc | 12 ++++- .../core/page/spatial_navigation_controller.h | 2 + .../snav-focusless-escape-uninterested-focus.html | 54 ++++++++++++++++++++++ 3 files changed, 66 insertions(+), 2 deletions(-) commit 7b1549d626646b93044f8f6e06ac747e3e386edb Author: Leonard Grey <lgrey@chromium.org> Date: Mon Mar 18 17:08:54 2019 +0000 Update dark omnibox result URL color Bug: 929725 Change-Id: I91a2260c745a3d754f4b967cc354d3abc078434a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1459522 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#641656} chrome/browser/ui/omnibox/omnibox_theme.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Updated tag 'tree_truth' (was 5a226fb2daed)