Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 45725 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918568635120181104 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itdqmT6a/luci_context.333123436 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm99-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43ae1144fad89f11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: c523e74080569b1df4f16d0baf83f0d2d39a7bb8 Force numlock to be on when sending modifier state to sommelier Nicholas Hollingum, Tue Mar 19 07:15:01 2019 +0000 14c3d65268d1abaff1f8dd4f8a609611916b94a0 Revert "Mark DepthCapture_depthStreamToR32FloatTexture as flaky on win7" Aleksandar Stojiljkovic, Tue Mar 19 07:14:51 2019 +0000 4a56fac6871e984af14c7374de3345bb504b1aaf Fix a crash bug in ArcSelectFilesHandler Satoshi Niwa, Tue Mar 19 07:08:47 2019 +0000 0cc0d519d44114a61fb9ee9231850f2588741d7b cros: Add Attestation enrollment browser test. Roman Sorokin, Tue Mar 19 07:02:24 2019 +0000 ef02d41b19e5c2cf79f35a588b72d2f5ebbb9fcc Allows any USB device with an ADB interface to connect to a VM. Nicholas Verne, Tue Mar 19 06:42:34 2019 +0000 ebc4ba22f6f1dac3dceddbc5cc5aad966fe431a2 Disable flaky DriveIntegrationServiceTest.ServiceInstanceIdentity Yoichi Osato, Tue Mar 19 06:22:19 2019 +0000 fc679db8fe81512852e1671bc9133c4401a46ae1 Fix the retrieval of DwmIsCompositionEnabled. Cliff Smolinsky, Tue Mar 19 06:05:32 2019 +0000 d824c424bbf0a68d406a938d4ea91c8bf3cf9e93 Disable lock screen notification yoshiki iguchi, Tue Mar 19 06:00:49 2019 +0000 8434953afa9590b4e38999e06283e1f7ecbb01f0 CrostiniSharePath small fixes Joel Hockey, Tue Mar 19 05:55:18 2019 +0000 d48cc9e26fa6e5a18dd26066eebe3d301516bdfc Changing "Clear browsing data..." button ripple color Sinan Sahin, Tue Mar 19 05:52:07 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit c523e74080569b1df4f16d0baf83f0d2d39a7bb8 Author: Nicholas Hollingum <hollingum@google.com> Date: Tue Mar 19 07:15:01 2019 +0000 Force numlock to be on when sending modifier state to sommelier linux apps decide how to interpret numpad keys based on the modifier flags. CrOS is designed so that numlock is a vestigial key (c.f. crbug.com/212491#c19 ), but the implementation has that bit in the mask as always off, despite that the behaviour is always on. This fix hard-codes that the modifier sent to linux will always say numlock is on. Bug: 937102 Change-Id: Iffe91b180ad22de0d303ec404df30efc73ffc93b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525241 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#641825} components/exo/wayland/wayland_keyboard_delegate.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 14c3d65268d1abaff1f8dd4f8a609611916b94a0 Author: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Date: Tue Mar 19 07:14:51 2019 +0000 Revert "Mark DepthCapture_depthStreamToR32FloatTexture as flaky on win7" This reverts commit 3f20eab38b0dd358f0500bd7c0d3dc2c45e08e79. Reason for revert: flakiness resolved by commit https://chromium.googlesource.com/chromium/src/+/2fd69c0ac9f0326af2c698511f66db61dfeb6864 Original change's description: > Mark DepthCapture_depthStreamToR32FloatTexture as flaky on win7 > > TBR=riajiang@chromium.org > > Bug: 937134 > Change-Id: I01fa4a4023a778f40a72c9f035b30270d969bb0a > Reviewed-on: https://chromium-review.googlesource.com/c/1495973 > Reviewed-by: Yi Gu <yigu@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#636842} TBR=yigu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 937134 Change-Id: Iab3b7274c8d12220db02d25dc9c457ea50fe2d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526269 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com> Cr-Commit-Position: refs/heads/master@{#641824} content/test/gpu/gpu_tests/depth_capture_expectations.py | 2 -- 1 file changed, 2 deletions(-) commit 4a56fac6871e984af14c7374de3345bb504b1aaf Author: Satoshi Niwa <niwa@google.com> Date: Tue Mar 19 07:08:47 2019 +0000 Fix a crash bug in ArcSelectFilesHandler Don't let chrome crash when GetFileSelectorElements/OnFileSelectorEvent gets called after SelectFileDialog is already closed BUG=b:128261768 TEST=Manualy check that chrome doesn't crash Change-Id: I32b98c280cfe0e472d4df28d08724ffc1e9129c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527943 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Reviewed-by: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#641823} chrome/browser/chromeos/arc/fileapi/arc_select_files_handler.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 0cc0d519d44114a61fb9ee9231850f2588741d7b Author: Roman Sorokin <rsorokin@chromium.org> Date: Tue Mar 19 07:02:24 2019 +0000 cros: Add Attestation enrollment browser test. cryptohome and CA network communication is mocked. Also fixes waiting for js ready in OOBE - it waits for assets loading. Also fixes certificate_based_register handling in policy_testserver.py Bug: 934224, 912704 Change-Id: Ic5816376e218436c6a2595759fa1bc9dd1b730ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523099 Reviewed-by: Pavol Marko <pmarko@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641822} .../enrollment_local_policy_server_browsertest.cc | 34 ++++++++++++++++++---- .../login/test/local_policy_test_server_mixin.cc | 4 +++ .../policy/device_cloud_policy_initializer.cc | 5 ++++ .../policy/device_cloud_policy_initializer.h | 2 ++ chrome/browser/policy/test/policy_testserver.py | 14 +++++++-- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 26 +++++++++++++---- chrome/browser/ui/webui/chromeos/login/oobe_ui.h | 8 +++++ .../core/common/cloud/cloud_policy_client.cc | 4 ++- 8 files changed, 82 insertions(+), 15 deletions(-) commit ef02d41b19e5c2cf79f35a588b72d2f5ebbb9fcc Author: Nicholas Verne <nverne@chromium.org> Date: Tue Mar 19 06:42:34 2019 +0000 Allows any USB device with an ADB interface to connect to a VM. Some Samsung phones have multiple USB interfaces, the presence of which formerly suppressed our notification on Add. The notifications are no longer suppressed, nor are ADB-supporting devices blocked from sharing with a VM. Bug: 943429 Change-Id: I203d80d38529010bb8ddb1e7427db3dd0620537e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530215 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641821} chrome/browser/chromeos/usb/cros_usb_detector.cc | 33 ++++++++-- chrome/browser/chromeos/usb/cros_usb_detector.h | 6 ++ .../chromeos/usb/cros_usb_detector_unittest.cc | 73 +++++++++++++++++----- 3 files changed, 92 insertions(+), 20 deletions(-) commit ebc4ba22f6f1dac3dceddbc5cc5aad966fe431a2 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Mar 19 06:22:19 2019 +0000 Disable flaky DriveIntegrationServiceTest.ServiceInstanceIdentity It is flaky on chromeos. See the bug for detail. TBR=hashimoto@chromium.org Bug: 943376 Change-Id: I6b39c06c077d66d6299deab79221d1fb52eb6344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529496 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Auto-Submit: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#641820} chrome/browser/chromeos/drive/drive_integration_service_unittest.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit fc679db8fe81512852e1671bc9133c4401a46ae1 Author: Cliff Smolinsky <cliffsmo@microsoft.com> Date: Tue Mar 19 06:05:32 2019 +0000 Fix the retrieval of DwmIsCompositionEnabled. Calling DwmIsCompositionEnabled has a non-neglible perf impact so on Win8+ we just return true since the API is guaranteed to return true. In addition, the code didn't properly check the return value of the call and therefore it could have accessed uninitialized memory, so this change adds an important SUCCEEDED call when the API is called. Bug: 942258,942165 Change-Id: I21f75ad1e756f0f5b92e7c35f69b5ba07595e5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525441 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#641819} ui/base/win/shell.cc | 14 ++++++++++++-- ui/base/win/shell.h | 7 ++++++- ui/views/win/hwnd_message_handler.cc | 10 ++-------- 3 files changed, 20 insertions(+), 11 deletions(-) commit d824c424bbf0a68d406a938d4ea91c8bf3cf9e93 Author: yoshiki iguchi <yoshiki@chromium.org> Date: Tue Mar 19 06:00:49 2019 +0000 Disable lock screen notification We have decided not to ship this at least for M74, so this CL disables it by default. I will merge this to the M74 branch as well. R=​tengs@chromium.org CC=​tetsui@chromium.org, sarakato@chromium.org TBR=oshima@chromium.org Bug: 943423 Change-Id: Iad61f219b2b4f9b5f2561b68ddeb28a9dadb3266 Test: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530213 Reviewed-by: Tim Song <tengs@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Auto-Submit: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#641818} ash/public/cpp/ash_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8434953afa9590b4e38999e06283e1f7ecbb01f0 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Mar 19 05:55:18 2019 +0000 CrostiniSharePath small fixes Use const ref for strings in all functions. Fix set_mount_event_seneschal_callback_for_testing to match style guide. Change were made as part of adding FileWatchers to unshare when paths are deleted but have been split into separate CL. Bug: 933564 Change-Id: I250c22449b1d2d51c4333ac4c4b13f840f3eb421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530211 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641817} .../chromeos/crostini/crostini_share_path.cc | 29 +++++++++++----------- .../chromeos/crostini/crostini_share_path.h | 12 ++++----- .../crostini/crostini_share_path_unittest.cc | 8 +++--- 3 files changed, 25 insertions(+), 24 deletions(-) commit d48cc9e26fa6e5a18dd26066eebe3d301516bdfc Author: Sinan Sahin <sinansahin@google.com> Date: Tue Mar 19 05:52:07 2019 +0000 Changing "Clear browsing data..." button ripple color Bug: 934886 Change-Id: Ibe5a2332219c6736a653e97a21a0f130afcb53a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529675 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#641816} ui/android/java/res/color/text_button_ripple_color.xml | 8 ++++---- ui/android/java/res/values/colors.xml | 3 +++ ui/android/java/res_night/values-night/colors.xml | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) commit 4cd379370dfa7db2a49bcebe0abb6935b6bde02d Author: Karan Bhatia <karandeepb@chromium.org> Date: Tue Mar 19 05:31:32 2019 +0000 Docserver: Bump version. Update docserver version to ensure multi-device docs changes are reflected. BUG=None TBR=rdevlin.cronin@chromium.org Change-Id: Id84f7bc04abc1758f65bec3b793741cbfda65224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529442 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#641815} chrome/common/extensions/docs/server2/app.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f9f6c22dcd9a16da1dd433c229b3797a84229d88 Author: Austin Eng <enga@chromium.org> Date: Tue Mar 19 05:31:10 2019 +0000 Skip WebGPU tests on Linux AMD WebGPU tests are failing on Linux FYI Release (AMD R7 240). Skipped tests are still considered as test failures. Change GTEST_SKIP() to an early return. Bug: 941685 Change-Id: I98238456c30d7fa2a9816a5809e85155a78e8892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529297 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641814} gpu/command_buffer/tests/webgpu_fence_unittest.cc | 12 ++++++++---- gpu/command_buffer/tests/webgpu_test.cc | 3 ++- 2 files changed, 10 insertions(+), 5 deletions(-) commit 65dfc9333406a44ab4b90543abb1dd28caeba3ee Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Mar 19 05:23:47 2019 +0000 Removed TestServiceManagerContext from FileManagerPathUtilTests Removed TestServiceManagerContext from ExtractMountNameFileSystemNameFullPath and ConvertFileSystemURLToPathInsideCrostini since they don't require it. TestServiceManagerContext is causing flakes for ExtractMountNameFileSystemNameFullPath. The network thread that it spawns is putting work on the queue just as TestBrowserThreadBundle is closing down and violating checks. Bug: 942371 Change-Id: Idc5ec2bfd807a4bdc9f0f0e978bf1434f80034c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529891 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#641813} chrome/browser/chromeos/file_manager/path_util_unittest.cc | 2 -- 1 file changed, 2 deletions(-) commit 5fd8949a37ac9ebcb950d5c331c1b484b697322d Author: Darren Shen <shend@chromium.org> Date: Tue Mar 19 04:49:50 2019 +0000 chromeos: Whitelist input method prefs for virtual keyboard. We want to eventually write tests that test multiple languages. The list of available input methods are controlled by the 'settings.language.preload_engines' pref, so we'll whitelist it so that Tast tests can set them. Bug: 879073 Change-Id: Ia8c315d9bacb267f3f8a77790aeb73f18d78e56f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525582 Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#641812} .../chromeos/extensions/autotest_private/autotest_private_api.cc | 3 +++ 1 file changed, 3 insertions(+) commit 0ede8368a230f4689490ba21aee992bfe8a3e0b4 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Mar 19 04:45:34 2019 +0000 [iOS][Translate] Adds EarlGrey tests for the new translate infobar (part 1) Adds tests for: 1. show/hide feature in fullscreen mode and dismissal. 2. translation and revertion (incl. incognito mode). 3. In navigation translation. 4. changing source and target languages. 5. Always translate. Bug: 910994 Change-Id: I0bee5714a309e0457d1fadcf470262e6cd9e9ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518247 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641811} ios/chrome/browser/translate/BUILD.gn | 2 + ios/chrome/browser/translate/translate_egtest.mm | 592 ++++++++++++++++++++- .../ui/translate/translate_infobar_coordinator.h | 5 + .../ui/translate/translate_infobar_coordinator.mm | 12 +- .../browser/ui/translate/translate_infobar_view.h | 3 + .../browser/ui/translate/translate_infobar_view.mm | 3 + 6 files changed, 591 insertions(+), 26 deletions(-) commit 495fa19d19763030b152b3988729a48939c37f49 Author: Yoichi Osato <yoichio@chromium.org> Date: Tue Mar 19 04:36:39 2019 +0000 Revert "Photo Picker: Convert filePaths to URIs." This reverts commit a8e2801b69c05f0109b50ec8d6513356bd982203. Reason for revert: Findit suspects this CL with 100% confidence Original change's description: > Photo Picker: Convert filePaths to URIs. > > Bug: 905257, 656015 > Change-Id: I903872fdb0d0ff59db61db427809893c5773e98e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524262 > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641556} TBR=finnur@chromium.org,twellington@chromium.org Change-Id: I45da2b58bd8ff9c5b12d69d160afaf19b26beec6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905257, 656015, 942625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530370 Reviewed-by: Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#641810} .../browser/photo_picker/DecoderServiceHost.java | 65 ++++++++--------- .../browser/photo_picker/FileEnumWorkerTask.java | 85 ++++++++++------------ .../browser/photo_picker/PhotoPickerDialog.java | 3 +- .../chrome/browser/photo_picker/PickerBitmap.java | 26 +++---- .../photo_picker/PickerBitmapViewHolder.java | 13 ++-- .../browser/photo_picker/PickerCategoryView.java | 11 ++- .../photo_picker/PhotoPickerDialogTest.java | 25 +++---- .../src/org/chromium/ui/PhotoPickerListener.java | 3 +- .../src/org/chromium/ui/base/SelectFileDialog.java | 20 ++++- 9 files changed, 124 insertions(+), 127 deletions(-) commit dfbd0e55870faded1679a1c6d2eb56774d593690 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 04:02:05 2019 +0000 Roll Fuchsia SDK from 3e59cb1001cf to 032385d9bec7 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib9ea500fdb8337d11f6e6841611ed38f0c1bdbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529156 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641809} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e65c2890667dd6e1ea1fb5696f873df9d7cb52ce Author: Pedro Amaral <amaralp@chromium.org> Date: Tue Mar 19 03:53:32 2019 +0000 Fixing NTP logo top margin The default NTP logo top margin is 26dp and I had been setting it to 0. This CL fixes that. Bug: 943074 Change-Id: I2212c3dc20431315bfd66a84e127707310061077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529850 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#641808} chrome/android/java/res/layout/new_tab_page_layout.xml | 2 +- chrome/android/java/res/values/dimens.xml | 1 + chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) commit 8cd4e8cdd633e63354d6249c082043e287ed6473 Author: Wez <wez@chromium.org> Date: Tue Mar 19 03:40:15 2019 +0000 [Fuchsia] Migrate ApplicationConfigManager from using struct to table. Returning a table will allow new fields to be added without breaking existing clients in future. Bug: 914610 Change-Id: I88544844e394c6524fc130544299221be1c948e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529722 Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#641807} fuchsia/fidl/cast/application_config.fidl | 13 +++++++------ fuchsia/runners/cast/cast_runner.cc | 11 ++++++----- fuchsia/runners/cast/cast_runner.h | 2 +- fuchsia/runners/cast/fake_application_config_manager.cc | 11 +++++------ 4 files changed, 19 insertions(+), 18 deletions(-) commit 1476a0bfe4f8455c4657e901d76b1c4ac9e1f71c Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Tue Mar 19 03:12:21 2019 +0000 Updating trunk VERSION from 3738.0 to 3739.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Ifb1d14cb4ec4129371c1bd10d30436581545b5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529651 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#641806} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7c8a9e2934de72f274034ea32875b9a780387676 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Mar 19 03:10:15 2019 +0000 JS clang format ui/file_manager/file_manager/background/ Bug: 778674 Change-Id: Ib7c1baa98135cab762dd43cd8da7bccbfadd87c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528024 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#641805} .../background/js/app_window_wrapper.js | 18 +- .../file_manager/background/js/background.js | 113 ++-- .../file_manager/background/js/background_base.js | 48 +- .../file_manager/background/js/device_handler.js | 118 ++-- .../background/js/device_handler_unittest.js | 50 +- .../background/js/drive_sync_handler.js | 30 +- .../file_manager/background/js/duplicate_finder.js | 103 ++- .../background/js/duplicate_finder_unittest.js | 26 +- .../background/js/file_operation_handler.js | 86 ++- .../background/js/file_operation_manager.js | 117 ++-- .../js/file_operation_manager_unittest.js | 510 +++++++------- .../background/js/file_operation_util.js | 736 ++++++++++----------- .../file_manager/background/js/import_history.js | 492 +++++++------- .../background/js/import_history_unittest.js | 310 ++++----- .../file_manager/background/js/launcher.js | 12 +- .../file_manager/background/js/launcher_search.js | 6 +- .../background/js/media_import_handler.js | 146 ++-- .../background/js/media_import_handler_unittest.js | 98 ++- .../file_manager/background/js/media_scanner.js | 220 +++--- .../background/js/media_scanner_unittest.js | 140 ++-- .../background/js/mock_media_scanner.js | 31 +- .../background/js/mock_volume_manager.js | 64 +- .../file_manager/background/js/progress_center.js | 6 +- .../background/js/runtime_loaded_test_util.js | 156 ++--- .../file_manager/background/js/task_queue.js | 10 +- .../background/js/task_queue_unittest.js | 94 ++- .../background/js/test_import_history.js | 33 +- .../file_manager/background/js/test_util.js | 149 +++-- .../file_manager/background/js/test_util_base.js | 126 ++-- .../background/js/volume_manager_impl.js | 145 ++-- .../background/js/volume_manager_unittest.js | 128 ++-- .../background/js/volume_manager_util.js | 3 +- 32 files changed, 2073 insertions(+), 2251 deletions(-) commit effa4f2579e13d25556dac5a83300fb64a547768 Author: Theresa <twellington@chromium.org> Date: Tue Mar 19 03:07:38 2019 +0000 Attempt to deflake ExampleUiCaptureTest Directly enter overview mode rather than trying to tap the tab switcher button. BUG=924128 Change-Id: Id92e059ebf68166e69188a079142570cb8cb67d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529682 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#641804} .../src/org/chromium/chrome/browser/ExampleUiCaptureTest.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) commit 09d9018225e023680c2dc4c1c1841aa9e0b8fd86 Author: Kuo-Hsin Yang <vovoy@chromium.org> Date: Tue Mar 19 02:33:04 2019 +0000 Disable system_health.memory_desktop/browse:news:hackernews:2018 Disable the test on Chrome OS because it's flaky. Bug: 942952 Change-Id: I843f8cf786ceccbfc5bb8e3b66606c894ab4e99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528127 Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#641803} tools/perf/expectations.config | 1 + 1 file changed, 1 insertion(+) commit 03549cb3eb3423e03496109c61a65e2bd20e58f3 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue Mar 19 02:32:41 2019 +0000 Revert "Looks like these tests pass on my box, on Linux, with this flag." This reverts commit 8545fb3d07bdd6e0281e7aa5d72f79b63556305a. Reason for revert: These tests are still failing on Linux Tests (dbg)(1): https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/79043 Original change's description: > Looks like these tests pass on my box, on Linux, with this flag. > So I think it's ok to remove the lines. > > Bug:942517 > > Change-Id: Ia74812fcd2df55af77bbfb36290918cb87e3d765 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529193 > Commit-Queue: Johannes Henkel <johannes@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641713} TBR=caseq@chromium.org,johannes@chromium.org Change-Id: Id9081bb5454ff16abd24a1255081df320105b4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530171 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#641802} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit d0310b0c0221e3f44da813443ca11c9869620cb4 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Mar 19 02:22:25 2019 +0000 Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient. Bug: 942782 Change-Id: Ia2971348153d54cd87a48e8045efc9d31948db8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529354 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#641801} chrome/browser/chromeos/network_change_manager_client.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 8eecee458153e0a0537209788b68832d5d915af7 Author: Eliot Courtney <edcourtney@google.com> Date: Tue Mar 19 01:51:55 2019 +0000 Plumb transparent values for MUS. This is a follow-up fix to https://crrev.com/c/1504599. The occlusion tracker also uses the transparent flag on each window to decide if it can affect occlusion. Plumb this value through, and set the layer draw type property for each remote layer. This will let the occlusion tracker function the same for remote windows as it does for local. Bug: 937323 Test: Bug 908629 does not regress. Test: Android window can be occluded by Browser window in SPM. Test: Added unit test Change-Id: Ib7875355346563b2c83447bf8b685d58130ab74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506061 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#641800} services/ws/public/mojom/window_manager.mojom | 6 ++-- services/ws/public/mojom/window_tree.mojom | 3 ++ services/ws/window_service.cc | 2 +- services/ws/window_tree.cc | 23 ++++++++++++ services/ws/window_tree.h | 5 +++ services/ws/window_tree_unittest.cc | 6 ++-- ui/aura/client/aura_constants.cc | 2 +- ui/aura/client/aura_constants.h | 10 +++--- ui/aura/local/window_port_local.cc | 2 ++ ui/aura/local/window_port_local.h | 1 + ui/aura/mus/in_flight_change.cc | 2 ++ ui/aura/mus/in_flight_change.h | 1 + ui/aura/mus/property_converter.cc | 4 +-- ui/aura/mus/window_port_mus.cc | 13 +++++++ ui/aura/mus/window_port_mus.h | 4 +++ ui/aura/mus/window_tree_client.cc | 13 ++++++- ui/aura/mus/window_tree_client.h | 1 + ui/aura/test/mus/test_window_tree.cc | 6 ++++ ui/aura/test/mus/test_window_tree.h | 3 ++ ui/aura/window.cc | 4 +++ ui/aura/window_port.h | 1 + ui/aura/window_port_for_shutdown.cc | 2 ++ ui/aura/window_port_for_shutdown.h | 1 + ui/views/mus/desktop_window_tree_host_mus.cc | 11 ------ .../mus/desktop_window_tree_host_mus_unittest.cc | 42 ++++++++-------------- 25 files changed, 111 insertions(+), 57 deletions(-) commit e62e8c4249b89b9c6f002d4cddb536d5db8ac067 Author: John Budorick <jbudorick@chromium.org> Date: Tue Mar 19 01:49:32 2019 +0000 Disable a batch of flaky layout tests. These are all contributing to webkit_layout_tests' high flake rate on Win7 Tests (1) and thus likely win7-rel. Bug: 934818,941482,943390,943388 No-Try: true Tbr: ksakamoto@chromium.org Change-Id: I9c2f6df6c8504bd08ca94b28413e3d645d774134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530120 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641799} third_party/blink/web_tests/TestExpectations | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit e38dfa276d9b31d8f4ebc314a457e9ba1653eb25 Author: Min Chen <minch@google.com> Date: Tue Mar 19 01:46:24 2019 +0000 Animate only top window during mode transition. Add EnterAnimtionType{DEFAULT, IMMEDIATE, STEP_END} in WindowState::State to track the bounds update animation for entering current State. Used to do corresponding animation for top window and others during transition. Two exceptions: 1. Keep the current animation if leaving tablet mode from overview, since still need to do more investigation for windows' transform animation and update bounds animation in this case. And to confirm with UX for the expect behavior as well. 2. We allow_set_bounds_direct for arc windows. This make arc windows will not be handled by TabletModeWindowState. And we don't go through Detach and Attach for arc window during mode change. This cl doesn't include arc windows first. Bug: 916331 Change-Id: If187798a950f62705b0c4e9db5e7229a78f567ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490503 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#641798} ash/wm/default_state.cc | 35 ++++++++++++++---------- ash/wm/tablet_mode/tablet_mode_controller.cc | 1 + ash/wm/tablet_mode/tablet_mode_window_manager.cc | 25 +++++++++++------ ash/wm/tablet_mode/tablet_mode_window_manager.h | 16 +++++++---- ash/wm/tablet_mode/tablet_mode_window_state.cc | 22 +++++++++++++-- ash/wm/tablet_mode/tablet_mode_window_state.h | 5 +++- ash/wm/window_state.h | 14 ++++++++++ 7 files changed, 85 insertions(+), 33 deletions(-) commit ca4568c9b61cffd89ace1fdba90fc4db1901d058 Author: David Black <dmblack@google.com> Date: Tue Mar 19 01:23:20 2019 +0000 Fix Assistant embedded UI dialog plate and thinking dot dimensions. Currently the thinking dots are being clipped in embedded Assistant UI and the dialog plate dimension is incorrect because it fails to account for the padding around the horizontal seperator. This CL: - Increases the size of the progress indicator so that the thinking dots are not clipped. - Modifies the vertical padding of the dialog plate so that it has the appearance of being 56dp tall even though a portion of that height is actually coming from the padding around the horizontal separator/ progress indicator views. Before: https://drive.google.com/open?id=1CSOiJoXIB0DSG7l3Mvf4Fj1-qQ9WwJCo After: https://drive.google.com/open?id=1CL2K6kTGTJ7SCm13WDea8ytz_7-4iSO4 Bug: b:128857878 Change-Id: I0ab4bbce7883a12c1d92d1dcd0e80478c008453f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529677 Commit-Queue: David Black <dmblack@google.com> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641797} .../views/assistant/assistant_main_stage.cc | 17 +++---- ash/app_list/views/assistant/dialog_plate.cc | 12 +++-- ash/app_list/views/assistant/dialog_plate.h | 1 - .../ui/main_stage/assistant_progress_indicator.cc | 52 +++++++++++++++------- .../ui/main_stage/assistant_progress_indicator.h | 2 + 5 files changed, 49 insertions(+), 35 deletions(-) commit 8f3a2cb4c540e64c97a801eff1e52268a104f3fc Author: Donn Denman <donnd@chromium.org> Date: Tue Mar 19 01:01:48 2019 +0000 [TTS] Refactor: java ResolvedSearchTerm immutable. Adds an encapsulation of the server response into a new immutable java class: ResolvedSearchTerm. We have a native encapsulation of this but nothing on the Java side. It would be even better to have the Java and native classes linked, but I'm not sure how to do that or if it's worth it. Bug=942663 Change-Id: I6492b63f7b74787d493b2c2aee2db59129881cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526402 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641796} .../contextualsearch/ContextualSearchManager.java | 57 +++-- .../ContextualSearchNetworkCommunicator.java | 30 +-- .../contextualsearch/ResolvedSearchTerm.java | 167 +++++++++++++ chrome/android/java_sources.gni | 1 + .../ContextualSearchFakeServer.java | 268 ++++++++++++--------- .../ContextualSearchManagerTest.java | 69 +----- 6 files changed, 362 insertions(+), 230 deletions(-) commit 550671a28c9a2bf536af574653c1733a15b87201 Author: Lan Wei <lanwei@chromium.org> Date: Tue Mar 19 00:59:24 2019 +0000 Transfer user activation in browser and renderer side This change is to implement this API: https://mustaqahmed.github.io/user-activation-delegation/ This Cl transfers user activation state in the frame tree in browser when |transfer_user_activation| is true, and target's renderer, the following CL will transfer user activation in other (non-source non-destination) renderers. Bug: 928838 Change-Id: I4f07a056616cf2628163d1a059c99923a80789fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518402 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#641795} content/browser/frame_host/frame_tree_node.cc | 7 +++++++ content/browser/frame_host/frame_tree_node.h | 3 +++ content/browser/frame_host/render_frame_proxy_host.cc | 10 ++++++++++ .../common/messaging/transferable_message_struct_traits.cc | 1 + .../blink/public/mojom/messaging/transferable_message.mojom | 3 +++ third_party/blink/renderer/core/frame/dom_window.cc | 4 ++-- third_party/blink/renderer/core/frame/web_local_frame_impl.cc | 11 +++++++++++ .../messaging/blink_transferable_message_struct_traits.cc | 1 + 8 files changed, 38 insertions(+), 2 deletions(-) commit 61ae0931da3c6779e6f7b3397dabe17f1c43baeb Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Mar 19 00:54:35 2019 +0000 [Files app] Add ARIA landmarks for file list and top bar Files app already have landmark "navigation" for directory tree on the right hand side. This CL adds 2 more landmarks "contentinfo" for the top bar that has the breadcrumbs and additional actions like delete. And "main" for the file list on the right hand side. ARIA landmark helps users to quickly navigate through those sections with "Search + ;" shortcut. Change-Id: I70e9c29538d44a5c5a499d7608549df17321bc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527915 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641794} ui/file_manager/file_manager/main.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 5bf43a6528d5e46ff4293ec6a64c8946861f8904 Author: John Budorick <jbudorick@chromium.org> Date: Tue Mar 19 00:43:50 2019 +0000 Remove blink_unittests from Win7 bots. No-Try: true Tbr: martiniss@chromium.org Bug: 943372 Change-Id: I992884e57f3d567c966853fd57ad8a845e637d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529887 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641793} testing/buildbot/chromium.win.json | 14 -------------- testing/buildbot/test_suite_exceptions.pyl | 5 +++++ 2 files changed, 5 insertions(+), 14 deletions(-) commit d0a6697395961603d8a3e110f77ccb4e22305c5c Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Mar 19 00:43:41 2019 +0000 [Files app] Add page title and body aria-label Add page title to have the application name (translated). This fixes Chromevox reading Files app startup as "WebContents WebContents...", instead it will read "WebContents Files...". Add body aria-label. This fixes when the focus is forced to body like when closing some dialogs Chromevox was reading the whole content of Files app, which doesn't make sense, now it will read "Files" or its translated term. Change-Id: I8566bae97b91b51ea09a2571047bc3790d29f385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528125 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641792} ui/file_manager/file_manager/main.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit a9b401a3b9b9f9ed5099eff7a511856b7c7d427c Author: Yuwei Huang <yuweih@chromium.org> Date: Tue Mar 19 00:19:06 2019 +0000 [remoting][FTL] Fix race condition in GrpcAsyncDispatcher This CL: * Moves the GrpcAsyncCallData initialization code (which enqueues them into the completion queue) out of their constructors, and call them within RegisterRpcData() that is guarded by lock. Previously GrpcAsyncCallData enqueues itself to CQ before it is added to |pending_rpcs_|. If the response comes quick enough then the dispatcher might get a call data that has not been enqueued into |pending_rpcs_|. * Makes it silently drop pending RPCs when the dispatcher or the ScopedGrpcServerStream is destroyed, rather than feeding them with CANCELLED status. It's generally not useful to report CANCELLED when the RPC is explicitly canceled by the user, and can cause concurrency problems when the caller receives a CANCELLED status from a previously closed ScopedGrpcServerStream. Bug: 927962 Change-Id: I7f6373b1cf9ff5fb9fd6d63f7583e1c1fb388d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516029 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#641791} remoting/signaling/grpc_support/BUILD.gn | 1 + remoting/signaling/grpc_support/README.md | 40 ++---- .../signaling/grpc_support/grpc_async_call_data.cc | 24 +++- .../signaling/grpc_support/grpc_async_call_data.h | 29 +++- .../grpc_support/grpc_async_dispatcher.cc | 2 +- .../signaling/grpc_support/grpc_async_dispatcher.h | 31 ++-- .../grpc_support/grpc_async_dispatcher_unittest.cc | 158 +++++++++++++-------- .../grpc_async_server_streaming_call_data.cc | 19 ++- .../grpc_async_server_streaming_call_data.h | 32 +++-- .../grpc_support/grpc_async_unary_call_data.h | 36 ++++- remoting/signaling/grpc_support/grpc_test_util.h | 12 +- 11 files changed, 245 insertions(+), 139 deletions(-) commit 9c931a2802a5ff9f8db610390eb8258634be1698 Author: Luciano Pacheco <lucmult@chromium.org> Date: Tue Mar 19 00:15:53 2019 +0000 Add context menu test for Media View Add 3 new volumes for integration test: audio, images and videos to emulate the Media View roots. Add a test command to mount these 3 volumes together. Change-Id: I9468aaf40be337d73b5018f8b2ea172d1e9c8136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513999 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#641790} .../file_manager/file_manager_browsertest.cc | 10 ++ .../file_manager/file_manager_browsertest_base.cc | 103 +++++++++++++++++---- .../file_manager/file_manager_browsertest_base.h | 8 ++ .../chromeos/file_manager/volume_manager.cc | 8 ++ .../browser/chromeos/file_manager/volume_manager.h | 19 ++-- .../file_manager/directory_tree_context_menu.js | 55 +++++++++++ 6 files changed, 181 insertions(+), 22 deletions(-) commit c6cf928b6c820cb2d09747cdf32397f8c20dac43 Author: Pedro Amaral <amaralp@chromium.org> Date: Mon Mar 18 23:52:41 2019 +0000 The incognito app theme for the Grid Tab Switcher should be dark Bug: 942764 Change-Id: I02b3b307b80b8f3331de4aa20b7da51d977693e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526747 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641789} .../chromium/chrome/browser/toolbar/AppThemeColorProvider.java | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) commit 4cae7b0e9833f493676a6818ab115cd349de747c Author: Aleks Totic <atotic@chromium.org> Date: Mon Mar 18 23:50:50 2019 +0000 Revert "Copy error over after glCopySubTexture" This reverts commit d8abfbe952b96b832856004ba52987c94c123114. Reason for revert: https://crbug.com/943355 Test failure at https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8918609622124607600/+/steps/angle_unittests_on__nvidia-quadro-p400-win10-stable__GPU_on_Windows_on_Windows-10/0/logs/Deterministic_failure:_TextureFunctionTest.NonConstantOffset__status_FAILURE_/0 Original change's description: > Copy error over after glCopySubTexture > > ANGLE does the validation if passthrough is enabled, so copy over the > error state to expose to client. > > Bug: 942658 > Change-Id: I16c657bba1603849da3882f4f19575c78bb8f1f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528793 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Jonathan Backer <backer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641728} TBR=backer@chromium.org,piman@chromium.org Change-Id: I2bba737fcfdf11414538a9628258d9cf54ca6b1c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529872 Reviewed-by: Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#641788} gpu/command_buffer/service/raster_decoder.cc | 1 - 1 file changed, 1 deletion(-) commit 2d4991ecbdf8da38fd5473359de13171e20feac9 Author: Marcin Wiącek <marcin@mwiacek.com> Date: Mon Mar 18 23:40:26 2019 +0000 Remove unnecessary enum inside FirstRunTest.java BUG=919666 Change-Id: I73949aaa0a66df3c6ca9f44caccfd60669c266d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526189 Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#641787} .../org/chromium/chrome/browser/sync/FirstRunTest.java | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) Updated tag 'tree_truth' (was e7bbfa1fbc89)