Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 55814 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: em1 INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LANG: en_US.UTF-8 LANGUAGE: en_US: LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918537712723199760 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGICAL: em1 LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/ittHt3yW/luci_context.940774895 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot METHOD: dhcp NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 2 SWARMING_BOT_ID: build4-b9 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43afd33f8245bb11 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t UPSTART_EVENTS: local-filesystems net-device-up UPSTART_INSTANCE: UPSTART_JOB: swarming USER: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython XDG_RUNTIME_DIR: /run/user/1000 XDG_SESSION_ID: c1 _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 2814fb7d2b44cbddd0f34dcaa22d1b01794ea0e1 Reland "[serial] Remove all code from Android Blink build" Reilly Grant, Tue Mar 19 17:04:46 2019 +0000 b95d2d4612ef10f1e9043d77e125435a9b1f531e DBus: Update PowerManagerClient to new pattern Steven Bennetts, Tue Mar 19 17:03:49 2019 +0000 3888a7dc6e47ebfc0ff36d11aef570013264b110 Run clang-tidy modernize-use-nullptr on //ui/views Robert Liao, Tue Mar 19 17:03:15 2019 +0000 e0775cd011fa416787523a9a3e934dc643675212 [iOS] Disabling UseNSURLSessionForGaiaSigninRequests flag by default Jérôme Lebel, Tue Mar 19 17:02:43 2019 +0000 bee45abe49cd5b3c8252970f48fc21468c9ac37b [Media Notification] Add source icon Becca Hughes, Tue Mar 19 17:02:10 2019 +0000 9b6bab205ab0a9e2d6ecc6c57d13f057f12f83eb Remove WindowTreeClient::OnWindowOpacityChanged Jun Mukai, Tue Mar 19 17:01:14 2019 +0000 c6b3edf7d56fa16189b6df48833f7c03aa46364f SocketPools: group_name to GroupId conversion part 3. Matt Menke, Tue Mar 19 17:00:39 2019 +0000 1b9a5fe80e8036e01eba73bc569d32dd773d6338 Roll src/third_party/angle 38e282570676..9b050f846a06 (7 commits) chromium-autoroll, Tue Mar 19 16:57:42 2019 +0000 1d0457b0ab00c9eee98948eee48ae12b334c9e5e Upstreaming some proguard flags which R8 supports Sam Maier, Tue Mar 19 16:56:54 2019 +0000 834cae0c315b887b6c9391deb257790910c4c116 Adjust drag_offset when the moving window bounds is adjusted Jun Mukai, Tue Mar 19 16:56:04 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 2814fb7d2b44cbddd0f34dcaa22d1b01794ea0e1 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Mar 19 17:04:46 2019 +0000 Reland "[serial] Remove all code from Android Blink build" This reverts commit e4f4664139bfa9511c6b90c14826feb3a73d814a. Reason for revert: Build failure fixed. Original change's description: > Revert "[serial] Remove all code from Android Blink build" > > This reverts commit 5cd5e69c82a5018288f282fb6d918ed0ce6e0f27. > > Reason for revert: Failure on android-rel. > > Original change's description: > > [serial] Remove all code from Android Blink build > > > > This reverts r629504 and instead removes all of the Serial API code from > > the Blink build on Android to further reduce binary size. > > > > Bug: 884928 > > Change-Id: I02cd550753d8020b6f8d796d576ca70caf378e39 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497363 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637439} > > TBR=kenrb@chromium.org,reillyg@chromium.org,haraken@chromium.org > > Change-Id: I2ff8c789992ceabfdaa856ec9c0bd6fae268fca0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 884928 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500939 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637453} TBR=kenrb@chromium.org,reillyg@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884928 Change-Id: I6b5d786589c28debac3e2ba8ff4b4f1a174b7bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526750 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642034} chrome/browser/chrome_content_browser_client.cc | 2 +- .../browser/frame_host/render_frame_host_impl.h | 3 +- third_party/blink/public/mojom/BUILD.gn | 5 +++- .../blink/public/platform/web_runtime_features.h | 1 - third_party/blink/renderer/modules/BUILD.gn | 5 +++- .../blink/renderer/modules/modules_idl_files.gni | 32 ++++++++++++++++++---- third_party/blink/renderer/modules/serial/BUILD.gn | 4 +++ .../platform/exported/web_runtime_features.cc | 4 --- 8 files changed, 41 insertions(+), 15 deletions(-) commit b95d2d4612ef10f1e9043d77e125435a9b1f531e Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Mar 19 17:03:49 2019 +0000 DBus: Update PowerManagerClient to new pattern This replaces calls to: chromeos::PowerManagerClient::Initialize(nullptr) with: chromeos::PowerManagerClient::InitializeFake() For mechanical changes: TBR=sky@chromium.org Bug: 647367 Change-Id: I1991255f98405f9a5fe1dd25cd9ab67754bd37c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518908 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#642033} ash/ash_service.cc | 5 ++--- .../detachable_base_handler_unittest.cc | 2 +- ash/display/projecting_observer_unittest.cc | 2 +- ash/system/power/power_status_unittest.cc | 2 +- ash/test/ash_test_helper.cc | 2 +- .../arc/arc_migration_guide_notification_unittest.cc | 2 +- .../chromeos/arc/arc_session_manager_unittest.cc | 2 +- .../event_based_status_reporting_service_unittest.cc | 2 +- .../usage_time_state_notifier_unittest.cc | 2 +- chrome/browser/chromeos/dbus/dbus_helper.cc | 5 ++--- .../chromeos/file_manager/volume_manager_unittest.cc | 2 +- .../network_change_manager_client_unittest.cc | 2 +- .../app_install_event_log_collector_unittest.cc | 4 ++-- .../policy/app_install_event_logger_unittest.cc | 3 ++- .../policy/device_status_collector_browsertest.cc | 5 ++--- .../chromeos/policy/status_uploader_unittest.cc | 2 +- .../power/auto_screen_brightness/adapter_unittest.cc | 2 +- .../brightness_monitor_impl_unittest.cc | 2 +- .../metrics_reporter_unittest.cc | 2 +- .../power/extension_event_observer_unittest.cc | 2 +- .../adaptive_screen_brightness_manager_unittest.cc | 2 +- .../power/ml/idle_event_notifier_unittest.cc | 2 +- .../power/ml/user_activity_manager_unittest.cc | 2 +- .../chromeos/power/power_data_collector_unittest.cc | 2 +- .../power/power_metrics_reporter_unittest.cc | 2 +- .../chromeos/power/renderer_freezer_unittest.cc | 2 +- .../chromeos/settings/device_settings_test_helper.cc | 4 ++-- .../system/automatic_reboot_manager_unittest.cc | 2 +- .../chromeos/tether/tether_service_unittest.cc | 2 +- .../chrome_metrics_service_client_unittest.cc | 4 ++-- .../metrics/chromeos_metrics_provider_unittest.cc | 2 +- .../perf/profile_provider_chromeos_unittest.cc | 8 ++++---- .../test/view_event_test_platform_part_chromeos.cc | 2 +- .../encryption_migration_screen_handler_unittest.cc | 5 +---- .../proximity_auth/unlock_manager_impl_unittest.cc | 4 ++-- chromeos/dbus/native_timer_unittest.cc | 2 +- chromeos/dbus/power/fake_power_manager_client.cc | 15 ++++++++------- chromeos/dbus/power/fake_power_manager_client.h | 5 +++-- chromeos/dbus/power/power_manager_client.cc | 20 ++++++++++++-------- chromeos/dbus/power/power_manager_client.h | 14 ++++++++++---- .../dbus/power/power_policy_controller_unittest.cc | 2 +- chromeos/disks/disk_mount_manager_unittest.cc | 2 +- .../platform/power_manager_provider_impl_unittest.cc | 2 +- chromeos/services/assistant/service_unittest.cc | 2 +- chromeos/system/dark_resume_controller_unittest.cc | 2 +- .../arc/metrics/arc_metrics_service_unittest.cc | 2 +- components/arc/power/arc_power_bridge_unittest.cc | 2 +- components/arc/timer/arc_timer_bridge_unittest.cc | 2 +- .../system_power_source_api_unittest.cc | 2 +- extensions/shell/browser/shell_browser_main_parts.cc | 9 +++++++-- .../shell_desktop_controller_aura_unittest.cc | 2 +- media/capture/video/video_capture_device_unittest.cc | 2 +- 52 files changed, 98 insertions(+), 86 deletions(-) commit 3888a7dc6e47ebfc0ff36d11aef570013264b110 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:03:15 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 This CL was uploaded by git cl split. TBR=sadrul@chromium.org Change-Id: Ie9e8876a0053b1fbded992be9aef15ad3d11a3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529881 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642032} ui/views/button_drag_utils.cc | 5 +- ui/views/controls/button/image_button.cc | 2 +- ui/views/controls/button/image_button_unittest.cc | 12 +- ui/views/controls/button/radio_button.cc | 4 +- ui/views/controls/link.cc | 2 +- .../controls/menu/display_change_listener_aura.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 54 +++--- ui/views/controls/menu/menu_delegate.cc | 2 +- ui/views/controls/menu/menu_host_root_view.cc | 2 +- ui/views/controls/menu/menu_host_root_view.h | 2 +- ui/views/controls/menu/menu_item_view.cc | 32 ++-- .../controls/menu/menu_model_adapter_unittest.cc | 21 ++- ui/views/controls/menu/menu_runner_impl.cc | 2 +- ui/views/controls/menu/submenu_view.cc | 16 +- ui/views/controls/message_box_view.cc | 8 +- ui/views/controls/native/native_view_host.cc | 9 +- ui/views/controls/native/native_view_host_aura.cc | 10 +- .../controls/native/native_view_host_unittest.cc | 8 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/scroll_view_unittest.cc | 24 +-- ui/views/controls/scrollbar/scroll_bar.cc | 5 +- ui/views/controls/slider_unittest.cc | 19 +- ui/views/controls/table/table_header.cc | 2 +- ui/views/controls/table/table_header.h | 2 +- ui/views/controls/table/table_view.cc | 12 +- ui/views/controls/table/table_view_unittest.cc | 20 +- ui/views/controls/table/test_table_model.cc | 4 +- ui/views/controls/tree/tree_view.cc | 51 +++--- ui/views/controls/tree/tree_view_unittest.cc | 8 +- ui/views/corewm/cursor_height_provider_win.cc | 10 +- .../corewm/desktop_capture_controller_unittest.cc | 8 +- ui/views/corewm/tooltip_aura.cc | 13 +- ui/views/corewm/tooltip_controller.cc | 32 ++-- ui/views/corewm/tooltip_controller_unittest.cc | 24 +-- ui/views/corewm/tooltip_win.cc | 22 +-- ui/views/examples/examples_window.cc | 4 +- .../examples/examples_with_content_main_exe.cc | 4 +- ui/views/examples/label_example.cc | 13 +- ui/views/examples/multiline_example.cc | 10 +- ui/views/examples/scroll_view_example.cc | 2 +- ui/views/examples/slider_example.cc | 5 +- ui/views/examples/tabbed_pane_example.cc | 4 +- ui/views/examples/table_example.cc | 5 +- ui/views/examples/webview_example.cc | 5 +- ui/views/examples/widget_example.cc | 7 +- ui/views/focus/focus_manager_unittest.cc | 12 +- ui/views/focus/focus_traversal_unittest.cc | 36 ++-- ui/views/mouse_watcher.h | 2 +- ui/views/test/test_widget_observer.cc | 2 +- ui/views/test/test_widget_observer.h | 2 +- ui/views/test/views_test_helper.cc | 2 +- ui/views/view.cc | 4 +- ui/views/view.h | 5 +- ui/views/view_model.h | 2 +- ui/views/view_targeter.cc | 10 +- ui/views/view_targeter_delegate.cc | 4 +- ui/views/view_targeter_unittest.cc | 26 +-- ui/views/view_unittest.cc | 204 ++++++++++----------- .../desktop_aura/desktop_drag_drop_client_win.cc | 2 +- .../desktop_aura/desktop_focus_rules_unittest.cc | 2 +- .../desktop_aura/desktop_native_widget_aura.cc | 53 +++--- .../desktop_native_widget_aura_unittest.cc | 22 +-- ui/views/widget/desktop_aura/desktop_screen_win.cc | 7 +- .../desktop_aura/desktop_window_tree_host_win.cc | 11 +- ui/views/widget/desktop_widget_unittest.cc | 2 +- ui/views/widget/drop_helper.cc | 15 +- ui/views/widget/native_widget_aura.cc | 24 +-- ui/views/widget/root_view.cc | 66 +++---- ui/views/widget/root_view_targeter.cc | 6 +- ui/views/widget/root_view_unittest.cc | 9 +- ui/views/widget/tooltip_manager_aura.cc | 6 +- ui/views/widget/widget.cc | 22 +-- ui/views/widget/widget.h | 2 +- ui/views/widget/widget_delegate.cc | 4 +- ui/views/widget/widget_deletion_observer.cc | 2 +- ui/views/widget/widget_deletion_observer.h | 2 +- ui/views/widget/widget_interactive_uitest.cc | 24 +-- ui/views/widget/widget_unittest.cc | 50 +++-- ui/views/widget/window_reorderer.cc | 4 +- ui/views/widget/window_reorderer_unittest.cc | 2 +- ui/views/win/fullscreen_handler.cc | 8 +- ui/views/win/hwnd_message_handler.cc | 84 ++++----- ui/views/win/hwnd_util_aurawin.cc | 11 +- ui/views/win/scoped_fullscreen_visibility.cc | 8 +- ui/views/window/client_view.cc | 4 +- ui/views/window/custom_frame_view.cc | 25 ++- ui/views/window/dialog_client_view_unittest.cc | 16 +- ui/views/window/dialog_delegate.cc | 12 +- ui/views/window/window_button_order_provider.cc | 2 +- 89 files changed, 652 insertions(+), 676 deletions(-) commit e0775cd011fa416787523a9a3e934dc643675212 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Mar 19 17:02:43 2019 +0000 [iOS] Disabling UseNSURLSessionForGaiaSigninRequests flag by default Gaia auth fetcher using NSURLSession makes issue for gmail.com to detect with the user is signed out. Bug: 939508 Change-Id: Ib2f9e8f99e66d2faf8b8c5b51dfa8c1783451ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530902 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#642031} ios/chrome/browser/signin/feature_flags.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit bee45abe49cd5b3c8252970f48fc21468c9ac37b Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Mar 19 17:02:10 2019 +0000 [Media Notification] Add source icon Add a new kSourceIcon image type that will be used for the icon associated with the source of the media session (e.g. app icon). Adds code to display it on the media notification. BUG=928369 Change-Id: I0a2979e9154d29f361373726e5ae1ca7799d1187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524031 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#642030} ash/media/media_notification_item.cc | 24 +++++++++++++++--- ash/media/media_notification_item.h | 5 ++++ ash/media/media_notification_view.cc | 9 +++++++ ash/media/media_notification_view.h | 1 + ash/media/media_notification_view_unittest.cc | 29 ++++++++++++++++++++++ .../media_session/public/mojom/media_session.mojom | 5 +++- .../views/notification_header_view.cc | 4 +++ ui/message_center/views/notification_header_view.h | 2 ++ 8 files changed, 74 insertions(+), 5 deletions(-) commit 9b6bab205ab0a9e2d6ecc6c57d13f057f12f83eb Author: Jun Mukai <mukai@chromium.org> Date: Tue Mar 19 17:01:14 2019 +0000 Remove WindowTreeClient::OnWindowOpacityChanged This is not used actually (nobody calls this method), and actually this is not necessary at all. Simply removing it. Bug: 940533 Test: build passes Change-Id: I3bb3a588db35f68e4a6b1692ca9af31ffb3069e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529631 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642029} content/renderer/mus/renderer_window_tree_client.cc | 3 --- content/renderer/mus/renderer_window_tree_client.h | 2 -- services/ws/public/mojom/window_tree.mojom | 3 --- services/ws/test_change_tracker.cc | 12 ------------ services/ws/test_change_tracker.h | 3 --- services/ws/test_window_tree_client.cc | 5 ----- services/ws/test_window_tree_client.h | 2 -- services/ws/window_tree_client_unittest.cc | 4 ---- ui/aura/mus/in_flight_change.cc | 18 ------------------ ui/aura/mus/in_flight_change.h | 15 --------------- ui/aura/mus/window_mus.h | 1 - ui/aura/mus/window_port_mus.cc | 4 ---- ui/aura/mus/window_port_mus.h | 1 - ui/aura/mus/window_tree_client.cc | 13 ------------- ui/aura/mus/window_tree_client.h | 2 -- 15 files changed, 88 deletions(-) commit c6b3edf7d56fa16189b6df48833f7c03aa46364f Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 17:00:39 2019 +0000 SocketPools: group_name to GroupId conversion part 3. This CL makes client_socket_pool_base_unittest use GroupIds instead of group names. Bug: 533571 Change-Id: I2d3e1d792f1cf21d9af16b812422b3a942a26a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526167 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642028} net/socket/client_socket_pool_base_unittest.cc | 1872 ++++++++++++------------ 1 file changed, 975 insertions(+), 897 deletions(-) commit 1b9a5fe80e8036e01eba73bc569d32dd773d6338 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 16:57:42 2019 +0000 Roll src/third_party/angle 38e282570676..9b050f846a06 (7 commits) https://chromium.googlesource.com/angle/angle.git/+log/38e282570676..9b050f846a06 git log 38e282570676..9b050f846a06 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 jiajia.qin@intel.com Fix that 0 is a valid memory barrier 2019-03-18 syoussefi@chromium.org Prefix glmark2 perf results with glmark2_ 2019-03-18 agrieve@chromium.org Add COMPONENT to OWNERS 2019-03-18 syoussefi@chromium.org Add missing entries in texture load functions map 2019-03-18 jonahr@google.com gl_VertexID is incorrect if offset argument to glDrawArrays is non-zero 2019-03-18 jmadill@chromium.org Add a helper script for triggering tests on swarming. 2019-03-18 syoussefi@chromium.org Add instructions on how to run ANGLE under RenderDoc Created with: gclient setdep -r src/third_party/angle@9b050f846a06 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I464840e78b47b165ab42093e6f8a7e13ebc83811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529935 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642027} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1d0457b0ab00c9eee98948eee48ae12b334c9e5e Author: Sam Maier <smaier@chromium.org> Date: Tue Mar 19 16:56:54 2019 +0000 Upstreaming some proguard flags which R8 supports Bug: 942668 Change-Id: Ib54a09e087975d61dba5ba0324fd89ed831231a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527877 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#642026} build/android/gyp/proguard.py | 46 +++++++++++++++------- build/config/android/rules.gni | 22 +++++++++-- chrome/android/BUILD.gn | 4 ++ .../monochrome_public_apk.proguard_flags.expected | 28 +++++++++++++ chrome/android/java/proguard.flags | 21 ++++++++++ 5 files changed, 103 insertions(+), 18 deletions(-) commit 834cae0c315b887b6c9391deb257790910c4c116 Author: Jun Mukai <mukai@chromium.org> Date: Tue Mar 19 16:56:04 2019 +0000 Adjust drag_offset when the moving window bounds is adjusted When tab-dragging causes to move the dragged window, the initial bounds is created as CreateBrowserForDrag(), and drag_offset is computed at this point. However sometimes AdjustBrowserAndTabBoundsForDrag() can be called, which changes the browser's position slightly, yet drag-offset stays same. This causes the inconsistency between the expected window position and offset, and so the reported troubles happen. AdjustBrowserAndTabBoundsForDrag() should take the current drag_offset, and when bounds is adjusted, it should also recompute the drag_offset. Bug: 942238 Test: new cases in interactive_ui_tests Change-Id: I1f929b27d12f32edf2861706f09b621c66bebd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526601 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642025} .../browser/ui/views/tabs/tab_drag_controller.cc | 18 ++--- chrome/browser/ui/views/tabs/tab_drag_controller.h | 4 ++ .../tabs/tab_drag_controller_interactive_uitest.cc | 78 ++++++++++++++++++++++ 3 files changed, 92 insertions(+), 8 deletions(-) commit fc77d1fe0125345699914259c491f8829d951ecb Author: Matt Mueller <mattm@chromium.org> Date: Tue Mar 19 16:52:58 2019 +0000 Remove public-key-pins from non-cachable headers list. HPKP support was removed in 230996f1 (m72). Bug: 893055 Change-Id: I10ac6d8c7420b5017d453246aa6eb4d2bfd43eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521788 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642024} net/http/http_response_headers.cc | 10 +++------- net/http/http_response_headers_unittest.cc | 5 +---- 2 files changed, 4 insertions(+), 11 deletions(-) commit 1d52abab07ca3f3685986a2770a8d80cd7294ac3 Author: Maksim Moskvitin <mmoskvitin@google.com> Date: Tue Mar 19 16:52:10 2019 +0000 [Sync:USS] Extract KeystoreKeysHandler interface KeystoreKeysHandler interface is a small interface that allows handling of Nigori keystore keys. It was a part of NigoriHandler. Extraction allows coexistence of USS and directory Nigori implementation. Directory transactions which used to be arguments of extracted methods are created now inside directory implementation (SyncEncryptionHandlerImpl). Bug: 922900 Change-Id: I46c9c7f3031ad389195d49a5d8f60fc0fbee227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528611 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642023} components/sync/BUILD.gn | 1 + components/sync/engine_impl/DEPS | 1 + .../sync/engine_impl/get_updates_processor.cc | 22 +- components/sync/engine_impl/model_type_registry.cc | 9 +- components/sync/engine_impl/model_type_registry.h | 15 +- .../engine_impl/model_type_registry_unittest.cc | 2 +- .../engine_impl/sync_encryption_handler_impl.cc | 15 +- .../engine_impl/sync_encryption_handler_impl.h | 17 +- .../sync_encryption_handler_impl_unittest.cc | 324 +++++++++------------ components/sync/engine_impl/sync_manager_impl.cc | 2 +- .../engine_impl/sync_scheduler_impl_unittest.cc | 3 +- components/sync/engine_impl/syncer_unittest.cc | 27 +- components/sync/nigori/keystore_keys_handler.h | 35 +++ components/sync/syncable/nigori_handler.h | 17 -- components/sync/syncable/test_user_share.cc | 4 + components/sync/syncable/test_user_share.h | 8 + .../sync/test/engine/test_directory_setter_upper.h | 2 + .../sync/test/fake_sync_encryption_handler.cc | 6 +- .../sync/test/fake_sync_encryption_handler.h | 13 +- 19 files changed, 252 insertions(+), 271 deletions(-) commit b77882136ef62f12516bb79b89a7f72bcb06af95 Author: liberato@chromium.org <liberato@chromium.org> Date: Tue Mar 19 16:51:51 2019 +0000 Roll src/third_party/ffmpeg/ 7e1e8a4f7..f5b197fe6 (2 commits) https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/7e1e8a4f7df4..f5b197fe6699 $ git log 7e1e8a4f7..f5b197fe6 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 liberato Updated patches file. 2019-03-04 liberato Check return value of avio_read(). Created with: roll-dep src/third_party/ffmpeg Bug: 937663 Change-Id: Ic9730b4a8e4c1da057e1adf65fe4b8ef48f123f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529112 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#642022} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 538130e33c4936fa7ec68adb61210b6ef50b90e0 Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Mar 19 16:50:36 2019 +0000 [Background Sync] Remove unnecessary logging. This removes some unused logging, per guidelines here: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#logging Bug: 932591 Change-Id: I6f99412b7834716e5a13ab6f83c80bd09f2967ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528536 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#642021} content/browser/background_sync/background_sync_manager.cc | 4 ---- 1 file changed, 4 deletions(-) commit a0125b0d47d4c64e095861939779c3fd000c2f8e Author: Martin Robinson <mrobinson@igalia.com> Date: Tue Mar 19 16:50:19 2019 +0000 Fix lint errors in accessibility code This makes it easier to spot problems when using "git cl lint." Bug: 942472 Change-Id: I4283db3a8bb13f87e9fd30aef55f818b51d11493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524276 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#642020} .../accessibility/browser_accessibility_com_win.cc | 39 +++++++++++----------- .../accessibility/browser_accessibility_com_win.h | 36 ++++++++++---------- .../platform/ax_platform_node_auralinux.cc | 4 +-- 3 files changed, 39 insertions(+), 40 deletions(-) commit 4585663b43ffb02972f002764c9e8d2bb70ae61a Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 16:48:47 2019 +0000 Allow .pydeps files to detect use of vpython Switches test_runner.py and run_py_tests.py to run using vpython. Their use of "psutil" makes me think this is necessary (plus the breakage in bug 930538). Bug: 930752, 930538 Change-Id: Iacdb517aa0fc7c1f799b1cd5105fa16a4c59cd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464639 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#642019} build/android/test_runner.py | 2 +- build/print_python_deps.py | 19 ++++++++++++++----- chrome/test/chromedriver/test/run_py_tests.py | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) commit d7ccf26595db8a0501b2917e7cdfd497ba1589ba Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Mar 19 16:47:35 2019 +0000 Roll src-internal 6abdbc905c14..3fe9205c384b (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6abdbc905c14..3fe9205c384b Created with: gclient setdep -r src-internal@3fe9205c384b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I3df1d4c0f2de0130de6ca636842554cc28265b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530124 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642018} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 035b9917093b752a8bc3e1e5f0a55f28877e535f Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Mar 19 16:47:27 2019 +0000 [LevelDBScopes] Improving testing & factory classes There isn't a great way to 'shut down' a leveldb instance if it is being used on multiple threads, and there isn't a great way to supply a mock database. This patch adds both of those things. Bug: 862456 Change-Id: I84ed0d1ef2ca77a2058945bebc6e03dadcb9fd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521436 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642017} .../indexed_db/indexed_db_leveldb_operations.cc | 12 +- .../indexed_db_tombstone_sweeper_unittest.cc | 2 +- .../indexed_db/leveldb/fake_leveldb_factory.cc | 182 ++++++++++++++++++++- .../indexed_db/leveldb/fake_leveldb_factory.h | 37 ++++- content/browser/indexed_db/leveldb/leveldb_env.cc | 38 +++-- content/browser/indexed_db/leveldb/leveldb_env.h | 51 ++++-- .../indexed_db/leveldb/leveldb_env_unittest.cc | 2 +- .../leveldb/leveldb_transaction_unittest.cc | 2 +- .../browser/indexed_db/leveldb/leveldb_unittest.cc | 2 +- content/browser/indexed_db/scopes/leveldb_state.cc | 23 ++- content/browser/indexed_db/scopes/leveldb_state.h | 32 +++- 11 files changed, 321 insertions(+), 62 deletions(-) commit 6959858eb5c5deb2776ddc8e46a8f40beaa91858 Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 16:42:48 2019 +0000 SocketPools: group_name to GroupId conversion part 2. This CL makes most net unit tests of the SocketPool layer use GroupIds instead of group name. The exceptions are tests that mock out socket pools themselves, as this CL is still relying on implicit GroupId to std::string conversion. Bug: 533571 Change-Id: Ie46e23e5e76e68e56652739bb51ba18226de5ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526162 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642016} net/http/http_proxy_client_socket_pool_unittest.cc | 22 ++++---- net/spdy/spdy_session_unittest.cc | 60 ++++++++++++---------- net/spdy/spdy_test_util_common.cc | 4 +- .../http_with_dns_over_https_unittest.cc | 7 +-- .../websocket_basic_stream_adapters_test.cc | 6 +-- net/websockets/websocket_basic_stream_test.cc | 5 +- ...ebsocket_handshake_stream_create_helper_test.cc | 6 ++- 7 files changed, 61 insertions(+), 49 deletions(-) commit fc6ddb2216dd6a986a3d632bdaa0038dd1254d37 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 19 16:41:07 2019 +0000 [iOS] Remove/rename todo 894791 This CL removes or change the bug numbers associated with the todo previously linking to crbug.com/894791. It allows us to close the bug and have more precises bugs with the todo. Bug: 894791 Change-Id: Id53cc1e1ea11af23d016996dd17ff7876125d2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529068 Reviewed-by: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#642015} .../settings/password/password_details_table_view_controller+testing.h | 2 +- ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm | 1 - ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) commit d678615b41f85728f312102f8c00ef930dbcea6b Author: Mark Cogan <marq@google.com> Date: Tue Mar 19 16:39:21 2019 +0000 [iOS] Remove @optional from LocationBarGenericCoordinator This CL resolves the TODO in LocationBarGenericCoordinator, removing the @optional marker from that protocol, since all call sites treat those methods as being non-optional. Bug: 831506 Change-Id: Ibde0ca1d44ec355b7845f57f572f062114d7fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530762 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642014} ios/chrome/browser/ui/location_bar/location_bar_generic_coordinator.h | 4 ---- 1 file changed, 4 deletions(-) commit 55907936f4def4467fc70a71e3160df5af9f5630 Author: sczs <sczs@chromium.org> Date: Tue Mar 19 16:34:59 2019 +0000 [iOS]Animates locationBarView leading button alpha for Fullscreen Bug: 911864 Change-Id: Ied21b2719bc4e133ab6f45dfe38cfa7129703607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529749 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#642013} ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm | 3 +++ 1 file changed, 3 insertions(+) commit 0734416591140b1370b7bd5837746eddb146d863 Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 16:34:00 2019 +0000 SocketPools: group_name to GroupId conversion part 1. Introduce ClientSocketPool::GroupId class, to replace string group_names. This CL does not make ClientSocketPool take GroupIds as an argument, instead it uses an implicit GroupId to string conversion, and updates some tests and ClientSocketPoolManager to pass in GroupIds to APIs that take in string group_names. Updating consumers first because conversion from GroupId to std::string is simpler than the other way around. The implicit conversion operator will be removed in a followup CL in which the SocketPools themselves are updated to take GroupIds, after all consumers have been converted. Bug: 533571 Change-Id: I013a23ae9211ac3d038f41abd13d0de42a229611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524977 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642012} net/BUILD.gn | 1 + net/socket/client_socket_pool.cc | 46 ++++ net/socket/client_socket_pool.h | 66 +++++ net/socket/client_socket_pool_manager.cc | 27 +- net/socket/client_socket_pool_unittest.cc | 124 +++++++++ net/socket/socket_test_util.h | 22 ++ .../transport_client_socket_pool_unittest.cc | 289 ++++++++++++--------- ...socket_transport_client_socket_pool_unittest.cc | 241 ++++++++--------- 8 files changed, 561 insertions(+), 255 deletions(-) commit 4f123ff27bd3ca8f6544844b3e33df3569366b2e Author: Clemens Arbesser <arbesser@google.com> Date: Tue Mar 19 16:33:55 2019 +0000 [Autofill Assistant] Removed default case from action switch/case. This ensures that compilation will fail if new actions are added to the proto but not to the switch-case. Bug: 806868 Change-Id: Iac64fc3f4cb9a9f4490998a911a6170db6ddd551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528973 Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#642011} .../autofill_assistant/browser/protocol_utils.cc | 54 ++++++++++++---------- 1 file changed, 30 insertions(+), 24 deletions(-) commit a6c40fb646207add8b1d4260c20d506fb9dcdbbe Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 16:32:12 2019 +0000 Android: Include missing classes in ClassPathValidator failures It was already possible to find this by running in verbose mode, but this should make it easier for bot messages. Removed the failure count because it didn't actually count the number of missing classes nor the number of missing jars (but rather how many classes failed to load). Example output: Direct classpath is incomplete. To fix, add GN deps on the target(s) that provide: * gen/base/base_java.javac.jar * org.chromium.base.Log (needed by org.chromium.chrome.browser.media.RouterTestUtils$1 and 1 more) * org.chromium.base.ThreadUtils (needed by org.chromium.chrome.browser.customtabs.CustomTabsTestUtils and 1 more) * gen/third_party/android_deps/com_android_support_support_fragment_java/classes.jar * android.support.v4.app.DialogFragment (needed by org.chromium.chrome.browser.media.RouterTestUtils) * gen/third_party/junit/junit.javac.jar * org.junit.Assert (needed by org.chromium.chrome.browser.customtabs.CustomTabActivityTestRule and 1 more) * org.junit.runners.model.Statement (needed by org.chromium.chrome.browser.webapps.WebappActivityTestRule$1) Bug: 898251 Change-Id: Ib254fa5aa19c637cee96f604bb4aba018998f44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529440 Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642010} .../org/chromium/bytecode/ByteCodeProcessor.java | 40 +++++++++++++++++++--- .../org/chromium/bytecode/ClassPathValidator.java | 36 +++++++++++++------ 2 files changed, 60 insertions(+), 16 deletions(-) Updated tag 'tree_truth' (was 0370210479bd)