Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 33647 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918535813413845584 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itaQK8LM/luci_context.586166726 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2480-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43afeee5e5628811 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 02565d7d938fc166b80c8f3c66696c748496c20c Replace View::has_children() with children().empty(). Peter Kasting, Tue Mar 19 18:00:11 2019 +0000 8d032ba569264d4e3a6bd03ee034243759a9380b DevTools: fix persistent overlay highlight in context selector Erik Luo, Tue Mar 19 17:58:40 2019 +0000 e9fea05a2bbd5e526084d781af698b42ae543525 Use per-frame task runners at WebView Plugin Hajime Hoshi, Tue Mar 19 17:54:32 2019 +0000 34baef4cd0ee77351a5f81404fbacf8ce7c38358 Add check for RenderWidgetHostDelegate before making a call Malay Keshav, Tue Mar 19 17:54:14 2019 +0000 236a10389b753de59590834048c5f794d9afefee Remove obsolete field trial checks. Alexei Svitkine, Tue Mar 19 17:53:09 2019 +0000 8f18c402976dd72bf63a0f83932fc8652fad6d0e Remove ios/web/public/block_types.h Eugene But, Tue Mar 19 17:53:06 2019 +0000 1f97a46216f2c58dbf74bc6f5754e8ba4d9348b5 Make sure all queues are shutdown before deleting SequenceManager Carlos Caballero, Tue Mar 19 17:51:10 2019 +0000 eebd15c888637b837409f00a79ac27f5c49917fa Delete ios_chrome_profile_sync_test_util.h/cc Marc Treib, Tue Mar 19 17:50:18 2019 +0000 7f68556f35e923f89180110a2850b521750a4431 Add platform tags in WebGLConformanceIntegrationTest Rakib M. Hasan, Tue Mar 19 17:50:04 2019 +0000 390285e6b3e0b4a83386f3b0d3d2a9ccfbf1603b Update bulk entries in HSTS preload list Nick Harper, Tue Mar 19 17:49:11 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 02565d7d938fc166b80c8f3c66696c748496c20c Author: Peter Kasting <pkasting@chromium.org> Date: Tue Mar 19 18:00:11 2019 +0000 Replace View::has_children() with children().empty(). These have the opposite meaning, so callers have to be negated. Bug: 940135 Change-Id: I99f01b8a6f05b1ba0b031d4cb4e573dce9ba54ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526668 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642076} ash/app_list/views/search_result_answer_card_view.cc | 2 +- ash/app_list/views/search_result_list_view.cc | 2 +- ash/app_list/views/search_result_view.cc | 4 ++-- ash/assistant/ui/main_stage/ui_element_container_view.cc | 2 +- .../shortcut_viewer/views/keyboard_shortcut_item_view.cc | 6 +++--- .../shortcut_viewer/views/keyboard_shortcut_view.cc | 4 ++-- ash/login/ui/login_test_utils.cc | 2 +- .../ui/views/apps/app_info_dialog/app_info_dialog_views.cc | 7 ++++--- .../views/apps/app_info_dialog/app_info_permissions_panel.cc | 2 +- chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc | 2 +- .../ui/views/autofill/local_card_migration_dialog_view.cc | 2 +- .../views/autofill/local_card_migration_error_dialog_view.cc | 2 +- .../ui/views/desktop_capture/desktop_media_list_view.cc | 2 +- chrome/browser/ui/views/page_info/page_info_bubble_view.cc | 2 +- chrome/browser/ui/views/payments/editor_view_controller.cc | 2 +- .../ui/views/payments/payment_request_item_list_unittest.cc | 2 +- chrome/browser/ui/views/test/view_event_test_base.cc | 2 +- chrome/browser/ui/views/touch_selection_menu_chromeos.cc | 3 +-- .../ui/views/webauthn/authenticator_request_dialog_view.cc | 2 +- .../viz/service/frame_sinks/frame_sink_manager_impl.cc | 4 ++-- components/viz/service/frame_sinks/frame_sink_manager_impl.h | 1 - ui/message_center/views/notification_view_md.cc | 5 +++-- ui/views/accessibility/ax_aura_obj_cache.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 6 +++--- ui/views/controls/menu/menu_item_view.cc | 4 ++-- ui/views/controls/menu/submenu_view.cc | 2 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/styled_label_unittest.cc | 12 ++++++------ ui/views/focus/focus_search.cc | 12 ++++-------- ui/views/layout/fill_layout.cc | 6 +++--- ui/views/view.h | 7 ++----- ui/views/view_unittest.cc | 4 ++-- ui/views/widget/root_view.cc | 4 ++-- ui/views/widget/root_view_unittest.cc | 4 ++-- 34 files changed, 60 insertions(+), 67 deletions(-) commit 8d032ba569264d4e3a6bd03ee034243759a9380b Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 17:58:40 2019 +0000 DevTools: fix persistent overlay highlight in context selector ConsoleContextSelector calls HideHighlight, then HighlightFrame. If the frame cannot be highlighted (e.g. top frame), it cancels the pending hide call. This CL makes backend calls highlight*() hide the overlay when they fail to highlight anything. Bug: 936793 Change-Id: I95c6e396665966738453db28588f47786d10439a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497341 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642075} .../blink/renderer/core/inspector/inspector_overlay_agent.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit e9fea05a2bbd5e526084d781af698b42ae543525 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Mar 19 17:54:32 2019 +0000 Use per-frame task runners at WebView Plugin This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found actual cases that JavaScript is executed: browser_tests --gtest_filter=PluginPowerSaverBrowserTest.RunAllFlashInAllowMode Bug: 870606 Change-Id: If5dfe70184fd568ae42dec3c00229121660452b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529894 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642074} components/plugins/renderer/webview_plugin.cc | 12 +++++++----- components/plugins/renderer/webview_plugin.h | 2 ++ 2 files changed, 9 insertions(+), 5 deletions(-) commit 34baef4cd0ee77351a5f81404fbacf8ce7c38358 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Mar 19 17:54:14 2019 +0000 Add check for RenderWidgetHostDelegate before making a call This patch adds a check for |delegate_| before a function invocation to avoid crashes. When the WebContentsImpl is destroyed it triggers the loading of tabs. It may happen that a tab for which the WebContentsimpl has already been destroyed is loaded. This leads to a new surface being embedded. FrameEvictor is also activated to release frames to relieve memory pressure. In doing so, it may attempt to release frame associated with the WebContentsImpl that is already destroyed thus leading to a crash. Bug: 931827 Change-Id: Ic9905f8249b8cd72501e3b5ff94ab135a93aae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529198 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#642073} content/browser/renderer_host/render_widget_host_impl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 236a10389b753de59590834048c5f794d9afefee Author: Alexei Svitkine <asvitkine@chromium.org> Date: Tue Mar 19 17:53:09 2019 +0000 Remove obsolete field trial checks. These trials have long expired, so remove the corresponding client side logic. Bug: None Change-Id: I690a40cd090f4f5e69d3c8dfdf9d934fb7ee90c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528975 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#642072} .../extensions/extension_message_bubble_factory.cc | 26 ++-------------------- testing/variations/fieldtrial_testing_config.json | 12 ---------- 2 files changed, 2 insertions(+), 36 deletions(-) commit 8f18c402976dd72bf63a0f83932fc8652fad6d0e Author: Eugene But <eugenebut@chromium.org> Date: Tue Mar 19 17:53:06 2019 +0000 Remove ios/web/public/block_types.h This header has a single typedef of a block which is mostly used in deprecated files. Typedef itself does not make code more readable, because the type name does not convey any information about block return type and arguments. Per Style Guide the code should be optimized for reader, not for writer: http://go/objc-style#optimize-for-the-reader-not-the-writer Bug: 942244 Change-Id: I9fcd09a2a990e32450f98ec55455508bf919a72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527208 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642071} ios/chrome/browser/ui/browser_view_controller.mm | 2 +- .../ui/static_content/static_html_native_content.mm | 2 +- .../ui/static_content/static_html_view_controller.h | 3 +-- .../static_content/static_html_view_controller.mm | 2 +- ios/chrome/test/earl_grey/chrome_matchers.mm | 1 - ios/web/interstitials/web_interstitial_impl.h | 11 ++++++----- ios/web/interstitials/web_interstitial_impl.mm | 2 +- ios/web/public/BUILD.gn | 1 - ios/web/public/block_types.h | 21 --------------------- ios/web/public/test/earl_grey/js_test_util.mm | 2 +- .../test/fakes/crw_test_js_injection_receiver.mm | 2 +- .../web_state/js/crw_js_injection_evaluator.h | 4 +--- .../public/web_state/js/crw_js_injection_manager.h | 2 +- ios/web/public/web_state/ui/crw_native_content.h | 3 +-- ios/web/web_state/js/crw_js_injection_manager.mm | 2 +- ios/web/web_state/js/crw_js_injection_receiver.mm | 2 +- ios/web/web_state/ui/crw_context_menu_controller.h | 2 -- ios/web/web_state/ui/crw_context_menu_controller.mm | 4 ++-- ios/web/web_state/ui/crw_web_controller.h | 5 ++++- ios/web/web_state/ui/crw_web_controller.mm | 4 ++-- ios/web/web_state/ui/web_view_js_utils.h | 4 +--- ios/web/web_state/ui/web_view_js_utils.mm | 2 +- 22 files changed, 28 insertions(+), 55 deletions(-) Updated tag 'tree_truth' (was 1f97a46216f2)