Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 42937 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: em1 INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LANG: en_US.UTF-8 LANGUAGE: en_US: LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918532844795547872 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGICAL: em1 LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itKyloQI/luci_context.488980247 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot METHOD: dhcp NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 2 SWARMING_BOT_ID: build4-b9 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43b01a163a877611 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t UPSTART_EVENTS: local-filesystems net-device-up UPSTART_INSTANCE: UPSTART_JOB: swarming USER: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython XDG_RUNTIME_DIR: /run/user/1000 XDG_SESSION_ID: c1 _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 53ed26b450a374367e4cc7591a54fff48bb85b05 Timeline frontend should not crash on tracks without threads. Zoe Clifford, Tue Mar 19 18:20:09 2019 +0000 bd16e773ca9b1248ba8938f54b5e24f56d920e42 Remove SQliteChannelIDStore. David Benjamin, Tue Mar 19 18:17:45 2019 +0000 a1ef75095030c4eedc75e44269eb9c6b7302c88b IndexedDB: Merge IndexedDBDispatcherHost and IDBSequenceHelper Chase Phillips, Tue Mar 19 18:17:17 2019 +0000 9c1cf648c021a2253c36c333554362177f5f5a38 Roll src/third_party/chromite cbcd56c13ecf..fcbfd4ea485a (1 commits) chromium-autoroll, Tue Mar 19 18:16:37 2019 +0000 2fa83e99ad8f18739995c416fd71e8e2ae4beb16 Suppress two canvas layout tests to allow small image changes after Skia roll. Brian Salomon, Tue Mar 19 18:15:44 2019 +0000 75f1baa3ee16f394689280b781efeddcfc321e98 aw: Always allow webgl in blink Bo Liu, Tue Mar 19 18:09:08 2019 +0000 9e3b6b9a7115e354f61e9ed87a9caa58248ef6e4 [Touchless] onSurfaceOpened() on NTP load. Sky Malice, Tue Mar 19 18:08:26 2019 +0000 82935584ada04cbe8941abdac1f681a9704289d6 Introduce SimpleDownloadManager to support reduced mode Min Qin, Tue Mar 19 18:05:04 2019 +0000 02565d7d938fc166b80c8f3c66696c748496c20c Replace View::has_children() with children().empty(). Peter Kasting, Tue Mar 19 18:00:11 2019 +0000 8d032ba569264d4e3a6bd03ee034243759a9380b DevTools: fix persistent overlay highlight in context selector Erik Luo, Tue Mar 19 17:58:40 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 53ed26b450a374367e4cc7591a54fff48bb85b05 Author: Zoe Clifford <zoeclifford@chromium.org> Date: Tue Mar 19 18:20:09 2019 +0000 Timeline frontend should not crash on tracks without threads. This edge-case is hit on profiles generated by headless chrome: * These traces hit the "generic" codepath because the tracing handler is started through browser_devtools_agent_host, without a frame tree node. * In TimelineModel.js _processEvent will ensure the Timings track exists, but will not associate a thread with it. This change fixes the crash and allows these types of profiles to load but isn't perfect because the Timings track will not be shown in this situation. I tried to get the Timings track to show up but wasn't familiar enough with the code to get it working. Bug: 943361 Change-Id: Iedfcf93d65a9a8cb31df20710aa19c7c967217f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529877 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642084} .../front_end/timeline/TimelineFlameChartDataProvider.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit bd16e773ca9b1248ba8938f54b5e24f56d920e42 Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 19 18:17:45 2019 +0000 Remove SQliteChannelIDStore. This entirely unused. Bug: 875053 Change-Id: I7710c3fa54b390edbca1d8a77d9c28ad73be3fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529689 Reviewed-by: Nick Harper <nharper@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642083} net/BUILD.gn | 3 - net/extras/sqlite/sqlite_channel_id_store.cc | 615 --------------------- net/extras/sqlite/sqlite_channel_id_store.h | 62 --- .../sqlite/sqlite_channel_id_store_unittest.cc | 611 -------------------- services/network/network_context.cc | 1 - 5 files changed, 1292 deletions(-) commit a1ef75095030c4eedc75e44269eb9c6b7302c88b Author: Chase Phillips <cmp@chromium.org> Date: Tue Mar 19 18:17:17 2019 +0000 IndexedDB: Merge IndexedDBDispatcherHost and IDBSequenceHelper These classes were originally separate because IndexedDBDispatcherHost lived on the IO thread while IDBSequenceHelper lived on the IDB task runner. After commit 77bf9a9 / https://crrev.com/c/1405718, IndexedDBDispatcherHost moved to live on the IDB task runner, so we can now merge them together. Bug: 717812 Change-Id: Iffc999a17ef562a2c93c139e100a3ece696ce4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526801 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642082} .../indexed_db/indexed_db_dispatcher_host.cc | 145 +++------------------ .../indexed_db/indexed_db_dispatcher_host.h | 2 - 2 files changed, 21 insertions(+), 126 deletions(-) commit 9c1cf648c021a2253c36c333554362177f5f5a38 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 18:16:37 2019 +0000 Roll src/third_party/chromite cbcd56c13ecf..fcbfd4ea485a (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/cbcd56c13ecf..fcbfd4ea485a git log cbcd56c13ecf..fcbfd4ea485a --date=short --no-merges --format='%ad %ae %s' 2019-03-19 nednguyen@google.com dependency: fix bug that causes dependency source paths to be incorrect Created with: gclient setdep -r src/third_party/chromite@fcbfd4ea485a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Idc090c9787a817bbe98b2c905c2f063517d6e609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530158 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642081} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fa83e99ad8f18739995c416fd71e8e2ae4beb16 Author: Brian Salomon <bsalomon@google.com> Date: Tue Mar 19 18:15:44 2019 +0000 Suppress two canvas layout tests to allow small image changes after Skia roll. Linear gradients have slight differences. Bug: 938592 Change-Id: Ia78725689edeea0735b588f9d4ed7b35a7c333bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529190 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#642080} third_party/blink/web_tests/TestExpectations | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 75f1baa3ee16f394689280b781efeddcfc321e98 Author: Bo Liu <boliu@chromium.org> Date: Tue Mar 19 18:09:08 2019 +0000 aw: Always allow webgl in blink Always allow webgl. Webview always requires access to the GPU even if it only does software draws. WebGL will not show up in software draw so there is no more brokeness for user. This makes it easier for apps that want to start running webgl content before webview is first attached. Change-Id: I24bb20dadf1453a00f3ec9cb08a77483972c7c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529658 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#642079} android_webview/browser/aw_settings.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 9e3b6b9a7115e354f61e9ed87a9caa58248ef6e4 Author: Sky Malice <skym@chromium.org> Date: Tue Mar 19 18:08:26 2019 +0000 [Touchless] onSurfaceOpened() on NTP load. This essentially copies what NewTabPage.java does, invoking this method near the end of its constructor, and after refreshSuggestions(). This change results in an article fetch being properly triggered when the NTP is opened. Without this, no fetch is made initial load. Bug: 937418 Change-Id: I43319cd37ec0586240bae50481ef9c77be7386ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526298 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642078} .../src/org/chromium/chrome/browser/touchless/TouchlessNewTabPage.java | 1 + 1 file changed, 1 insertion(+) commit 82935584ada04cbe8941abdac1f681a9704289d6 Author: Min Qin <qinmin@chromium.org> Date: Tue Mar 19 18:05:04 2019 +0000 Introduce SimpleDownloadManager to support reduced mode Bug: 942770 Change-Id: I780f7a863c519cd9a2fc885c29df8fc20786b917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526686 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642077} components/download/internal/common/BUILD.gn | 1 + .../common/simple_download_manager_coordinator.cc | 46 +++++++++++++++++ components/download/public/common/BUILD.gn | 2 + .../public/common/simple_download_manager.h | 58 ++++++++++++++++++++++ .../common/simple_download_manager_coordinator.h | 54 ++++++++++++++++++++ 5 files changed, 161 insertions(+) commit 02565d7d938fc166b80c8f3c66696c748496c20c Author: Peter Kasting <pkasting@chromium.org> Date: Tue Mar 19 18:00:11 2019 +0000 Replace View::has_children() with children().empty(). These have the opposite meaning, so callers have to be negated. Bug: 940135 Change-Id: I99f01b8a6f05b1ba0b031d4cb4e573dce9ba54ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526668 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642076} ash/app_list/views/search_result_answer_card_view.cc | 2 +- ash/app_list/views/search_result_list_view.cc | 2 +- ash/app_list/views/search_result_view.cc | 4 ++-- ash/assistant/ui/main_stage/ui_element_container_view.cc | 2 +- .../shortcut_viewer/views/keyboard_shortcut_item_view.cc | 6 +++--- .../shortcut_viewer/views/keyboard_shortcut_view.cc | 4 ++-- ash/login/ui/login_test_utils.cc | 2 +- .../ui/views/apps/app_info_dialog/app_info_dialog_views.cc | 7 ++++--- .../views/apps/app_info_dialog/app_info_permissions_panel.cc | 2 +- chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc | 2 +- .../ui/views/autofill/local_card_migration_dialog_view.cc | 2 +- .../views/autofill/local_card_migration_error_dialog_view.cc | 2 +- .../ui/views/desktop_capture/desktop_media_list_view.cc | 2 +- chrome/browser/ui/views/page_info/page_info_bubble_view.cc | 2 +- chrome/browser/ui/views/payments/editor_view_controller.cc | 2 +- .../ui/views/payments/payment_request_item_list_unittest.cc | 2 +- chrome/browser/ui/views/test/view_event_test_base.cc | 2 +- chrome/browser/ui/views/touch_selection_menu_chromeos.cc | 3 +-- .../ui/views/webauthn/authenticator_request_dialog_view.cc | 2 +- .../viz/service/frame_sinks/frame_sink_manager_impl.cc | 4 ++-- components/viz/service/frame_sinks/frame_sink_manager_impl.h | 1 - ui/message_center/views/notification_view_md.cc | 5 +++-- ui/views/accessibility/ax_aura_obj_cache.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 6 +++--- ui/views/controls/menu/menu_item_view.cc | 4 ++-- ui/views/controls/menu/submenu_view.cc | 2 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/styled_label_unittest.cc | 12 ++++++------ ui/views/focus/focus_search.cc | 12 ++++-------- ui/views/layout/fill_layout.cc | 6 +++--- ui/views/view.h | 7 ++----- ui/views/view_unittest.cc | 4 ++-- ui/views/widget/root_view.cc | 4 ++-- ui/views/widget/root_view_unittest.cc | 4 ++-- 34 files changed, 60 insertions(+), 67 deletions(-) commit 8d032ba569264d4e3a6bd03ee034243759a9380b Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 17:58:40 2019 +0000 DevTools: fix persistent overlay highlight in context selector ConsoleContextSelector calls HideHighlight, then HighlightFrame. If the frame cannot be highlighted (e.g. top frame), it cancels the pending hide call. This CL makes backend calls highlight*() hide the overlay when they fail to highlight anything. Bug: 936793 Change-Id: I95c6e396665966738453db28588f47786d10439a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497341 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642075} .../blink/renderer/core/inspector/inspector_overlay_agent.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit e9fea05a2bbd5e526084d781af698b42ae543525 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Mar 19 17:54:32 2019 +0000 Use per-frame task runners at WebView Plugin This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found actual cases that JavaScript is executed: browser_tests --gtest_filter=PluginPowerSaverBrowserTest.RunAllFlashInAllowMode Bug: 870606 Change-Id: If5dfe70184fd568ae42dec3c00229121660452b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529894 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642074} components/plugins/renderer/webview_plugin.cc | 12 +++++++----- components/plugins/renderer/webview_plugin.h | 2 ++ 2 files changed, 9 insertions(+), 5 deletions(-) commit 34baef4cd0ee77351a5f81404fbacf8ce7c38358 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Mar 19 17:54:14 2019 +0000 Add check for RenderWidgetHostDelegate before making a call This patch adds a check for |delegate_| before a function invocation to avoid crashes. When the WebContentsImpl is destroyed it triggers the loading of tabs. It may happen that a tab for which the WebContentsimpl has already been destroyed is loaded. This leads to a new surface being embedded. FrameEvictor is also activated to release frames to relieve memory pressure. In doing so, it may attempt to release frame associated with the WebContentsImpl that is already destroyed thus leading to a crash. Bug: 931827 Change-Id: Ic9905f8249b8cd72501e3b5ff94ab135a93aae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529198 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#642073} content/browser/renderer_host/render_widget_host_impl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 236a10389b753de59590834048c5f794d9afefee Author: Alexei Svitkine <asvitkine@chromium.org> Date: Tue Mar 19 17:53:09 2019 +0000 Remove obsolete field trial checks. These trials have long expired, so remove the corresponding client side logic. Bug: None Change-Id: I690a40cd090f4f5e69d3c8dfdf9d934fb7ee90c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528975 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#642072} .../extensions/extension_message_bubble_factory.cc | 26 ++-------------------- testing/variations/fieldtrial_testing_config.json | 12 ---------- 2 files changed, 2 insertions(+), 36 deletions(-) commit 8f18c402976dd72bf63a0f83932fc8652fad6d0e Author: Eugene But <eugenebut@chromium.org> Date: Tue Mar 19 17:53:06 2019 +0000 Remove ios/web/public/block_types.h This header has a single typedef of a block which is mostly used in deprecated files. Typedef itself does not make code more readable, because the type name does not convey any information about block return type and arguments. Per Style Guide the code should be optimized for reader, not for writer: http://go/objc-style#optimize-for-the-reader-not-the-writer Bug: 942244 Change-Id: I9fcd09a2a990e32450f98ec55455508bf919a72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527208 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642071} ios/chrome/browser/ui/browser_view_controller.mm | 2 +- .../ui/static_content/static_html_native_content.mm | 2 +- .../ui/static_content/static_html_view_controller.h | 3 +-- .../static_content/static_html_view_controller.mm | 2 +- ios/chrome/test/earl_grey/chrome_matchers.mm | 1 - ios/web/interstitials/web_interstitial_impl.h | 11 ++++++----- ios/web/interstitials/web_interstitial_impl.mm | 2 +- ios/web/public/BUILD.gn | 1 - ios/web/public/block_types.h | 21 --------------------- ios/web/public/test/earl_grey/js_test_util.mm | 2 +- .../test/fakes/crw_test_js_injection_receiver.mm | 2 +- .../web_state/js/crw_js_injection_evaluator.h | 4 +--- .../public/web_state/js/crw_js_injection_manager.h | 2 +- ios/web/public/web_state/ui/crw_native_content.h | 3 +-- ios/web/web_state/js/crw_js_injection_manager.mm | 2 +- ios/web/web_state/js/crw_js_injection_receiver.mm | 2 +- ios/web/web_state/ui/crw_context_menu_controller.h | 2 -- ios/web/web_state/ui/crw_context_menu_controller.mm | 4 ++-- ios/web/web_state/ui/crw_web_controller.h | 5 ++++- ios/web/web_state/ui/crw_web_controller.mm | 4 ++-- ios/web/web_state/ui/web_view_js_utils.h | 4 +--- ios/web/web_state/ui/web_view_js_utils.mm | 2 +- 22 files changed, 28 insertions(+), 55 deletions(-) commit 1f97a46216f2c58dbf74bc6f5754e8ba4d9348b5 Author: Carlos Caballero <carlscab@google.com> Date: Tue Mar 19 17:51:10 2019 +0000 Make sure all queues are shutdown before deleting SequenceManager In the near future it will be an error to delete a SequenceManager instance for which there still exist active TaskQueues. This patch makes sure that schedulers will be fine with said change. https://docs.google.com/document/d/1KZJt7pifMaiaz1xDO313VW3I4gKAsInJXC00FifBX00 Bug: 891670 Change-Id: I95ad184c4803e8c141838b637cabcf450ffe4fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530772 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#642070} .../main_thread/frame_scheduler_impl_unittest.cc | 38 ++++++----- .../main_thread_scheduler_impl_unittest.cc | 2 + .../main_thread/page_scheduler_impl_unittest.cc | 77 ++++++++++++---------- 3 files changed, 64 insertions(+), 53 deletions(-) commit eebd15c888637b837409f00a79ac27f5c49917fa Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 17:50:18 2019 +0000 Delete ios_chrome_profile_sync_test_util.h/cc It provided helpers to ease construction of a ProfileSyncServiceMock, but it's now unused. Bug: 910518 Change-Id: I0fc1095287db2ee65fa108c928682e9a8da16da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529061 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642069} ios/chrome/browser/sync/BUILD.gn | 5 --- .../sync/ios_chrome_profile_sync_test_util.cc | 41 ---------------------- .../sync/ios_chrome_profile_sync_test_util.h | 30 ---------------- 3 files changed, 76 deletions(-) Updated tag 'tree_truth' (was 7f68556f35e9)