Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 33931 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918530638297022992 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itPT1L7B/luci_context.441755332 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2384-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43b03a3213d99811 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 37511ad65414d7d7fd43d4620bc2f7fb91e8b2be Use webview provider for shell layout and ui webview tests. Andrew Luo, Tue Mar 19 19:15:58 2019 +0000 05f9b4c02be51e3bc0881b1e6d7039cc5f4707a2 Eliminated remaining uses of [LegacyInterfaceTypeChecking] Allison Pastewka, Tue Mar 19 19:15:17 2019 +0000 c5335225660544666a28adf7f05e20d9521929ae Disable flaky test on mac Stephen Martinis, Tue Mar 19 19:13:17 2019 +0000 e237674c1a6b1e33171eb6aafd66eec775bff618 [scheduler] Ui thread task posting API changes. Karolina Soltys, Tue Mar 19 19:09:38 2019 +0000 22bfe6006e3fa913d6d9b0b09261218d979249c3 Fix tests that change ECT to use feature params rajendrant, Tue Mar 19 19:08:28 2019 +0000 178dc2bcb8d531664d774d662ba7c15e2662332c [AW NS] Update WATCHLIST with android_webview_network_service Tim Volodine, Tue Mar 19 19:07:22 2019 +0000 d66fa340bef0110a8ded284168169c633d8bebb7 Check that mainframes don't fail to be swapped in. danakj, Tue Mar 19 19:06:37 2019 +0000 4b5aca3cb861662fc0ec73815ddd1215e7bcadfc UIA: Re-enable event tests Ian Prest, Tue Mar 19 19:05:02 2019 +0000 b7cc89dae3bb683f5eaa3bd6c5bd56522f4eaa06 Roll src/third_party/perfetto 69d721a1be6d..21ad4d87826e (1 commits) chromium-autoroll, Tue Mar 19 19:03:24 2019 +0000 840358c8c01458b86e65745831da23d84b72375b Roll src/net/third_party/quiche/src/ f08778a58..d5d13c2a8 (20 commits) Ryan Hamilton, Tue Mar 19 19:00:35 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 37511ad65414d7d7fd43d4620bc2f7fb91e8b2be Author: Andrew Luo <aluo@chromium.org> Date: Tue Mar 19 19:15:58 2019 +0000 Use webview provider for shell layout and ui webview tests. This prepares the way to switch webview test bots to use swarmed devices. Bug: 814405 Change-Id: Ic6c1f2b713392b3ed80b26dae1a5571de648914d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526809 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642127} android_webview/tools/automated_ui_tests/BUILD.gn | 1 + testing/buildbot/gn_isolate_map.pyl | 8 ++++++++ 2 files changed, 9 insertions(+) commit 05f9b4c02be51e3bc0881b1e6d7039cc5f4707a2 Author: Allison Pastewka <alpastew@microsoft.com> Date: Tue Mar 19 19:15:17 2019 +0000 Eliminated remaining uses of [LegacyInterfaceTypeChecking] Removed [LegacyInterfaceTypeChecking] from the two remaining idls, RTCPeerConnection-getStats and FormData. Updated the relevant tests to match the new behavior. Seeing as how [LegacyInterfaceTypeChecking] is no longer being used, I removed the extended attribute from IDLExtendedAttributes.md and IDLExtendedAttributes.txt. Bug: 561338 Change-Id: I4783348f485932f08c86ddb58efb6cb713fd5fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507237 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Allison Pastewka <alpastew@microsoft.com> Cr-Commit-Position: refs/heads/master@{#642126} .../renderer/bindings/IDLExtendedAttributes.md | 1 - .../renderer/bindings/IDLExtendedAttributes.txt | 1 - .../renderer/bindings/scripts/v8_attributes.py | 9 +- .../renderer/bindings/scripts/v8_interface.py | 8 +- .../blink/renderer/bindings/scripts/v8_methods.py | 8 +- .../renderer/bindings/scripts/v8_utilities.py | 6 - .../bindings/tests/idls/core/test_interface.idl | 3 - .../bindings/tests/idls/core/test_object.idl | 6 - .../tests/results/core/v8_test_interface.cc | 61 ------ .../tests/results/core/v8_test_interface.h | 3 - .../bindings/tests/results/core/v8_test_object.cc | 223 --------------------- .../bindings/tests/results/core/v8_test_object.h | 10 - .../blink/renderer/core/html/forms/form_data.cc | 4 - .../blink/renderer/core/html/forms/form_data.idl | 6 +- .../modules/peerconnection/rtc_peer_connection.idl | 2 +- .../external/wpt/xhr/FormData-append.html | 8 + .../external/wpt/xhr/formdata-expected.txt | 10 - .../web_tests/external/wpt/xhr/formdata-set.htm | 8 + .../blink/web_tests/external/wpt/xhr/formdata.htm | 2 +- ...RTCPeerConnection-getStats-overrides.https.html | 5 +- .../RTCPeerConnection-stats-expected.txt | 9 - .../peerconnection/RTCPeerConnection-stats.html | 10 +- 22 files changed, 29 insertions(+), 374 deletions(-) commit c5335225660544666a28adf7f05e20d9521929ae Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Mar 19 19:13:17 2019 +0000 Disable flaky test on mac No-Try: True Tbr: mmentovai Bug: 943669 Change-Id: Iee3cbda469cbdeab7e542bcd566adbb45c0388ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531280 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#642125} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit e237674c1a6b1e33171eb6aafd66eec775bff618 Author: Karolina Soltys <ksolt@chromium.org> Date: Tue Mar 19 19:09:38 2019 +0000 [scheduler] Ui thread task posting API changes. As part of an ongoing effort to migrate all Java task posting to PostTask, we are deprecating the alternative methods used at the moment and providing PostTask-based alternatives. We are also providing a workaround for call sites which can't import content. In order for this to work, we are adding ThreadUtils initialisation to an early stage in the initialisation of Chrome. Bug: 863341 Change-Id: Ie1594a36803dd3b43480098a24e6fbd3e34c5c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518513 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642124} .../java/src/org/chromium/base/ThreadUtils.java | 53 ++++++++ .../java/src/org/chromium/base/task/PostTask.java | 34 +++++ content/public/android/BUILD.gn | 2 - .../content/browser/BrowserThreadUtilsImpl.java | 148 --------------------- .../content_public/browser/BrowserThreadUtils.java | 109 --------------- .../browser/scheduler/UiThreadSchedulerTest.java | 18 +++ .../browser/test/util/TestThreadUtils.java | 8 +- 7 files changed, 109 insertions(+), 263 deletions(-) commit 22bfe6006e3fa913d6d9b0b09261218d979249c3 Author: rajendrant <rajendrant@chromium.org> Date: Tue Mar 19 19:08:28 2019 +0000 Fix tests that change ECT to use feature params NQE has been converted to a feature in the below CL. So use that for the tests. http://crrev.com/c/1516433 Bug: 940943 Change-Id: Ib9a8c810fea23a63e7f119c474936afeb95037d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531100 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#642123} tools/chrome_proxy/webdriver/lite_page.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit 178dc2bcb8d531664d774d662ba7c15e2662332c Author: Tim Volodine <timvolodine@chromium.org> Date: Tue Mar 19 19:07:22 2019 +0000 [AW NS] Update WATCHLIST with android_webview_network_service Create android_webview_network_service watchlist and add myself. This watches network service specific files for android webview. BUG=841556 TBR=tobiasjs@chromium.org Change-Id: Iceb146e4aabed205ca8998910573ef65321c2006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530904 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#642122} WATCHLISTS | 4 ++++ 1 file changed, 4 insertions(+) commit d66fa340bef0110a8ded284168169c633d8bebb7 Author: danakj <danakj@chromium.org> Date: Tue Mar 19 19:06:37 2019 +0000 Check that mainframes don't fail to be swapped in. There's no error reporting to the browser if this happened and then they would disagree on the state of the RenderFrame. R=dcheng@chromium.org Bug: 939262 Change-Id: I73d0bfa7a8e89424820d396d04c7c2af7e3bc7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529620 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642121} content/renderer/render_frame_impl.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 4b5aca3cb861662fc0ec73815ddd1215e7bcadfc Author: Ian Prest <iapres@microsoft.com> Date: Tue Mar 19 19:05:02 2019 +0000 UIA: Re-enable event tests A recent change to the AccessibilityTreeFormatter changed the filename pattern for UIA test expectation files (from "-win-uia.txt" to "-uia-win.txt"). However, the change didn't rename the expectation files for *event* tests, so the event tests were inadvertantly disabled. 1. Renamed the event-test expectation files to match the new pattern. -- Similarly, change any filter rules (@WIN-DENY, etc.) in the HTML files to match the new pattern. 2. This exposed a crash in the AccessibilityTreeFormatter on Win7 since we are now dumping some new trees. -- We were requesting *all* properties, and UIA on Win7 was crashing when requesting `LegacyIAccessibleSelection` (on a <SELECT> element). -- The solution is to request only a subset of all properties. -- The list currently contains *all* properties, except (1) properties like `ProcessId` and `RuntimeId`, which are system specific and shouldn't be in a dump file; and (2) the `LegacyIAccessible` properties, which are proven problematic on Win7 and which we don't expose anyway. -- Also removed were properties that are going to be dumped as part of a pattern (see CL:1521468). 3. A few expectation files needed to be remastered, having diverged slightly during the time the tests were disabled. Bug: 928949 Change-Id: I1aa42a9b42882b368ef590035ea926b106c3712c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518411 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#642120} .../accessibility_tree_formatter_uia_win.cc | 167 ++++++++++++++++++++- .../accessibility_tree_formatter_uia_win.h | 3 +- ...-win-uia.txt => add-alert-expected-uia-win.txt} | 0 .../test/data/accessibility/event/add-alert.html | 3 +- ...> aria-combo-box-collapse-expected-uia-win.txt} | 0 ...-combo-box-delay-add-list-expected-uia-win.txt} | 0 .../aria-combo-box-expand-expected-uia-win.txt | 2 + ...t => aria-combo-box-focus-expected-uia-win.txt} | 0 .../aria-combo-box-focus-expected-win-uia.txt | 1 - .../event/aria-combo-box-next-expected-uia-win.txt | 2 + .../event/aria-combo-box-next-expected-win-uia.txt | 1 - ...-uia.txt => listbox-focus-expected-uia-win.txt} | 0 .../event/listbox-next-expected-uia-win.txt | 2 + .../event/listbox-next-expected-win-uia.txt | 1 - .../event/listbox-next-expected-win.txt | 2 +- ...uia.txt => menulist-focus-expected-uia-win.txt} | 0 ...rt-validity-invalid-field-expected-uia-win.txt} | 0 .../event/report-validity-invalid-field.html | 3 +- ...in-uia.txt => tbody-focus-expected-uia-win.txt} | 0 ...in-uia.txt => tfoot-focus-expected-uia-win.txt} | 0 ...in-uia.txt => thead-focus-expected-uia-win.txt} | 0 21 files changed, 176 insertions(+), 11 deletions(-) commit b7cc89dae3bb683f5eaa3bd6c5bd56522f4eaa06 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 19:03:24 2019 +0000 Roll src/third_party/perfetto 69d721a1be6d..21ad4d87826e (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/69d721a1be6d..21ad4d87826e git log 69d721a1be6d..21ad4d87826e --date=short --no-merges --format='%ad %ae %s' 2019-03-19 fmayer@google.com Merge "Make Android tests happy" Created with: gclient setdep -r src/third_party/perfetto@21ad4d87826e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0f90285613ef3e86f5260e2acf34c640109a7298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530157 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642119} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 840358c8c01458b86e65745831da23d84b72375b Author: Ryan Hamilton <rch@chromium.org> Date: Tue Mar 19 19:00:35 2019 +0000 Roll src/net/third_party/quiche/src/ f08778a58..d5d13c2a8 (20 commits) https://quiche.googlesource.com/quiche.git/+log/f08778a58e71..d5d13c2a81b5 $ git log f08778a58..d5d13c2a8 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 rch Use std::string instead of string in a few places in QUIC to permit chrome merge. 2019-03-18 quiche-dev Add a Context class to simplify ProcessClientHello 2019-03-18 quiche-dev Change some methods in QuicSpdyStream from public to protected. 2019-03-17 quiche-dev gfe-relnote: In QUIC, validate packet number post decryption. Protected by quic_validate_packet_number_post_decryption. 2019-03-16 bnc Improve handing of frames with empty payload in HttpDecoder. 2019-03-15 quiche-dev Rename ENCRYPTION_NONE to ENCRYPTION_INITIAL 2019-03-15 quiche-dev Remove an unused argument 2019-03-15 quiche-dev Make ClientDemandsX509Proof a free function 2019-03-15 quiche-dev gfe-relnote: In QUIC, put packet number validation in a standalone function. No functional refactoring change. Not protected. 2019-03-15 quiche-dev gfe-relnote: In QUIC, add unused HANDSHAKE encryption level. No functional change expected, not protected. 2019-03-15 quiche-dev Remove an unused asynchronous jump 2019-03-15 quiche-dev Make CryptoUtils::HashHandshakeMessage return by value 2019-03-14 quiche-dev Uniquify QuicCryptoServerConfig::Add[Default]Config 2019-03-14 quiche-dev Remove unused arguments 2019-03-14 quiche-dev Allow variable length connection IDs in v99 2019-03-14 bnc Minor QuicSimpleServerSessionServerPushTest refactor. 2019-03-14 quiche-dev Split KeyExchange into synchronous and asynchronous variants 2019-03-14 quiche-dev Uniquify ChannelIDSource handling 2019-03-14 quiche-dev Fix a msan error because of uninitialized test diversification nonce. 2019-03-14 quiche-dev Convert CryptoFramer::ConstructHandshakeMessage to return unique_ptr Created with: roll-dep src/net/third_party/quiche/src Roll src/third_party/quic_trace/src/ fe1b25874..9aaca5b48 (22 commits) https://chromium.googlesource.com/external/github.com/google/quic-trace.git/+log/fe1b2587410c..9aaca5b4862a $ git log fe1b25874..9aaca5b48 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 rch In QUIC, add unused HANDSHAKE encryption level. 2019-03-13 vasilvv Update quic_trace to use a more recent version of protobuf 2019-02-20 jri.ietf Show offsets for STREAM frames 2019-01-10 vasilvv Add missing dependencies 2019-01-10 vasilvv Migrate quic_trace to use Swisstable 2019-01-09 vasilvv Sort events in the trace before processing it 2018-12-28 vasilvv Reduce the nesting in the code by reordering clauses 2018-12-12 vasilvv Add a support for JSON representation of the trace. 2018-10-30 vasilvv Update glew code 2018-08-25 vasilvv Add fields to mark TLPs and RTOs 2018-09-10 vasilvv Update documentation and add an example trace (#4) 2018-09-10 vasilvv Add high-DPI support for Linux and OS X 2018-09-06 vasilvv Clean up the logic for rescaling the trace 2018-09-07 vasilvv Add support for Mac OS X 2018-09-07 vasilvv Minor C++ cleanups required to build the renderer on OS X 2018-09-07 vasilvv Ensure trace renderer is compatible with OpenGL 3.3 core 2018-09-05 vasilvv Make freetype statically linked 2018-09-05 vasilvv Fix GL_KHR_debug feature check 2018-09-05 vasilvv Add .gitignore 2018-09-05 vasilvv Remove a leftover LOG line that's normally not useful 2018-09-05 vasilvv Make certain implicit dependencies explicit 2018-09-05 vasilvv Initial export of OpenGL-based QUIC trace renderer Created with: roll-dep src/third_party/quic_trace/src Change-Id: I287edfd9be3c002d16f9db4e709af19828475edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529635 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#642118} DEPS | 4 ++-- net/BUILD.gn | 1 + net/quic/quic_chromium_client_session_test.cc | 2 +- net/quic/quic_flags_list.h | 5 +++++ net/quic/quic_test_packet_maker.cc | 14 +++++++------- 5 files changed, 16 insertions(+), 10 deletions(-) commit cf2872d7b1fa6c0132ea9917ddf78efc4ff4bc54 Author: Robert Ogden <robertogden@chromium.org> Date: Tue Mar 19 18:59:37 2019 +0000 Consolidate usage of prefs::kDataSaverEnabled in CCBC One of several CLs to clean up usage of this pref. Bug: 934399 Change-Id: Iec7f2f5fe250ae37af8082537069a5312106dc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529660 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#642117} chrome/browser/chrome_content_browser_client.cc | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) commit d7f6fea29f1c5396b3b171bbf40318e4152fac14 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 18:59:11 2019 +0000 Add templates to share file system callbacks implementations This is a follow up CL of crrev.com/c/1525102 that aims at sharing the same template functions among most of the wrapper callback classes in t_p/b/renderer/modules/filesystem/file_system_callbacks.h. There will still be need for other helper template functions, eg for promises, but those will be added on demand (see crrev.com/c/1528394). R=mek@chromium.org CC=​​dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: Id0bced0c7ea71984b5e2b1d162cc21be891e1ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528391 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#642116} .../blink/renderer/modules/filesystem/BUILD.gn | 1 + .../modules/filesystem/async_callback_helper.h | 53 ++++++++++++++++++++++ .../blink/renderer/modules/filesystem/entry.cc | 24 ++-------- 3 files changed, 59 insertions(+), 19 deletions(-) commit 1dc5707c53559c476c455b993c2704107e71bf47 Author: dpapad <dpapad@chromium.org> Date: Tue Mar 19 18:58:30 2019 +0000 WebUI cleanup: Remove i18n_template.js from Desktop builds. This file is no longer used anywhere else other than ChromeOS. Also delete IDR_WEBUI_JS_I18N_TEMPLATE_PROCESS from webui_resources.grd since this file is already inlined with GRIT in the only place where it is used. display "This site can’t be reached" Bug: 677338 Test: Visit chrome://resources/js/i18n_template.js on Desktop. Should Change-Id: I7fca116e356611d87c049a4a1832d46f9a24783c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525465 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#642115} android_webview/ui/grit_resources_whitelist.txt | 1 - ui/webui/resources/webui_resources.grd | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) commit fca3ec75eaa93b7d613618a6006f95168ee920f8 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Mar 19 18:57:43 2019 +0000 WS: CrashInFlightChange dump window name and location Dump window name and CrashInFlightChange creation site with the fatal log. Bug: 940620 Change-Id: I4645986a47a1c495b3279bc2fa07d24487ccda89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529691 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642114} ui/aura/mus/in_flight_change.cc | 21 ++++++++++---- ui/aura/mus/in_flight_change.h | 7 ++++- ui/aura/mus/window_tree_client.cc | 45 ++++++++++++++++++------------ ui/aura/mus/window_tree_client_unittest.cc | 29 +++++++++++++++++++ 4 files changed, 77 insertions(+), 25 deletions(-) commit d6fb7b395023c734d2c37d2147ed76a5d19f1041 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Mar 19 18:56:46 2019 +0000 Fix issues with shadow buffer readback in the passthrough decoder. - Buffers were read back using the client ID instead of service ID. - Buffer ID was not validated in SetReadbackBufferShadowAllocationINTERNAL - Pending readbacks were not removed on buffer deletion once they were already associated with a query. BUG=941930 Change-Id: I6220cd0f96be23113dd0e9bd6dc56dee8e49a137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525996 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#642113} .../service/gles2_cmd_decoder_passthrough.cc | 14 +++++++++++++- .../service/gles2_cmd_decoder_passthrough_doers.cc | 9 +++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) commit 73fa2b382ee2b2c3b29cbba9194d19cf372cdb26 Author: Lan Wei <lanwei@chromium.org> Date: Tue Mar 19 18:56:37 2019 +0000 [wpt] Fix actionsWithKeyPressed.html.ini actionsWithKeyPressed.html test does not work on both Firefox and Safari, so I change actionsWithKeyPressed.html.ini to skip both browsers. Bug: chromedriver:1897 Change-Id: I86fb1507cf86f2fe209414615b8ea73834456202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529624 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#642112} .../infrastructure/testdriver/actions/actionsWithKeyPressed.html.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3dab6e44bca75848bd78be1482e717e49c08dfc7 Author: danakj <danakj@chromium.org> Date: Tue Mar 19 18:55:38 2019 +0000 Check that mainframes don't fail to be swapped out. When this fails the proxy is deleted but the RenderFrame of the speculative frame would be left in a shutting down state would not delete the RenderFrame in the renderer. R=dcheng@chromium.org Bug: 939262 Change-Id: I38947b3471a2ba510d59f6132d286376473ba787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529165 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642111} content/renderer/render_frame_impl.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 4230b400e564fe3d1578721216231bec7bb6de7d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 19 18:55:34 2019 +0000 Update V8 to version 7.5.72. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d2a2a23..93306f1d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d36dee3652f90e5f03f030143ee699cab1c88e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531000 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642110} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4aa582bf9250d069c855aa1101a9056426a4d2eb Author: Reilly Grant <reillyg@chromium.org> Date: Tue Mar 19 18:52:24 2019 +0000 [sensors] Add fallback for linear accelerometer on Android This changes adds a sensor fusion fallback on Android when there is no platform sensor for TYPE_LINEAR_ACCELEROMETER but TYPE_ACCELEROMETER is still available. Bug: 943275 Change-Id: I29fb26e10338b6956e5f331346f39ec119781187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529671 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642109} services/device/generic_sensor/README.md | 6 ++++- .../platform_sensor_provider_android.cc | 31 ++++++++++++++++++++++ .../platform_sensor_provider_android.h | 3 +++ 3 files changed, 39 insertions(+), 1 deletion(-) commit 4a5fd8a10c9be47c4fea6187998f74ce5a2f96d9 Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 18:52:02 2019 +0000 PeopleHandler: Also SetSyncRequested when confirming Sync Typically SyncRequested is already set at this point, but if a dashboard reset happened while the settings page was open, then it was cleared in the meantime. (That's a more likely situation than it might seem, because the Sync dashboard is linked from the settings page.) If we don't SetSyncRequested in this case, then Sync won't actually become active again, even though the user just pressed "Confirm". It would only become active once they open the settings again. This is only relevant for situations where sign-out isn't possible, i.e. on ChromeOS or for managed (enterprise) users on desktop, since otherwise a dashboard reset also signs out the user. Bug: 936886 Change-Id: I196c3471176b3a958ad7e6b60751e558dd5dd740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530765 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#642108} chrome/browser/ui/webui/settings/people_handler.cc | 16 ++- chrome/browser/ui/webui/settings/people_handler.h | 4 + .../ui/webui/settings/people_handler_unittest.cc | 122 ++++++++++++++++++++- 3 files changed, 140 insertions(+), 2 deletions(-) commit 05d92ba683b38d95a51d7fba8f58d9dfe7584c2f Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Mar 19 18:51:18 2019 +0000 [Tab Groups] Do not call RemoveFromGroup before adding tabs to groups. To support crrev.com/c/1476146, this patch removes calls to RemoveFromGroup from AddToNewGroup and AddToExistingGroup. This will allow the eventual TabStripModelChange::Delta to contain both the old group and the new group by giving MoveTabsIntoGroup enough context to populate those fields. Also moves MoveTabsIntoGroup, UngroupTab, and SetTabsPinned to be in the same order as in the header file. Bug: 905491 Change-Id: I87afbcd7710cb3245ae06631c00e7d835f30435c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526741 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#642107} chrome/browser/ui/tabs/tab_strip_model.cc | 205 +++++++++++---------- chrome/browser/ui/tabs/tab_strip_model.h | 14 +- chrome/browser/ui/tabs/tab_strip_model_unittest.cc | 48 +++-- 3 files changed, 150 insertions(+), 117 deletions(-) commit fc09013b02eb912985afcfb3119ca839d700a9f1 Author: khmel@chromium.org <khmel@chromium.org> Date: Tue Mar 19 18:50:58 2019 +0000 app_list: Prevent sending updates over destroyed mojo channel This observes profile deletion prevents communication over AppListController. ChromeAppListModelUpdater has longer live scope than AppListClientImpl and using pointers owned by AppListClientImpl is not safe on deletion TEST=Simulate crash condition and make sure app is not loaded. BUG=936665 Change-Id: Ib07861ac8b98a39af7d538659883ddbfe48f7607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529633 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642106} chrome/browser/ui/app_list/app_list_client_impl.cc | 3 +++ chrome/browser/ui/app_list/chrome_app_list_model_updater.cc | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) commit c7f408732775a3d5199ff31f6c59b6f25cf6b68a Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 19 18:48:11 2019 +0000 Enable TLS 1.3 for Chrome extensions. This flips the default and adds "tls1.3" as a supported value of the tlsVersion.{min,max} settings. Bug: 904470 Change-Id: I75b1f777124e764b357bc81c9f4aea8ba53abee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529126 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642105} .../extensions/api/socket/tls_socket_unittest.cc | 48 ++++++++++++++++++---- extensions/browser/api/socket/tcp_socket.cc | 7 +++- extensions/common/api/socket.idl | 3 +- extensions/common/api/sockets_tcp.idl | 3 +- 4 files changed, 50 insertions(+), 11 deletions(-) commit 518b98f4e934f23aec8c3867bb9595d3eb0902b3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 18:43:50 2019 +0000 Roll src/third_party/depot_tools d2b0c2ae17fe..1c21d7cb523d (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2b0c2ae17fe..1c21d7cb523d git log d2b0c2ae17fe..1c21d7cb523d --date=short --no-merges --format='%ad %ae %s' 2019-03-19 tikuta@chromium.org [bot_update] show git protocol version 2019-03-19 raul@tambre.ee Make fetch compatible with Python 3 Created with: gclient setdep -r src/third_party/depot_tools@1c21d7cb523d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875453,chromium:939847 TBR=agable@chromium.org Change-Id: Id22d321d69c4973c8bee2f4251a09e9a4775e927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530155 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642104} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 43ab8952a0148aa9a82d459bf1ae6664dba389ec Author: Finnur Thorarinsson <finnur@chromium.org> Date: Tue Mar 19 18:43:33 2019 +0000 Photo Picker: Convert filePaths to URIs. (A reland of the original patch, with just a small fix to the test) https://chromium-review.googlesource.com/c/chromium/src/+/1524262 (Original) TBR=twellington Bug: 905257, 656015 Change-Id: Ibe999a7ad65ba531170f8b4c9f2503f5d66bc9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530986 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#642103} .../browser/photo_picker/DecoderServiceHost.java | 65 +++++++++-------- .../browser/photo_picker/FileEnumWorkerTask.java | 85 ++++++++++++---------- .../browser/photo_picker/PhotoPickerDialog.java | 3 +- .../chrome/browser/photo_picker/PickerBitmap.java | 26 ++++--- .../photo_picker/PickerBitmapViewHolder.java | 13 ++-- .../browser/photo_picker/PickerCategoryView.java | 11 +-- .../photo_picker/PhotoPickerDialogTest.java | 25 ++++--- .../src/org/chromium/ui/PhotoPickerListener.java | 3 +- .../src/org/chromium/ui/base/SelectFileDialog.java | 20 +---- 9 files changed, 127 insertions(+), 124 deletions(-) commit 0fe22e7ba699be603148b340d67507644637a825 Author: Charlene Yan <cyan@chromium.org> Date: Tue Mar 19 18:40:45 2019 +0000 Set SHOULD_SHOW_MNEMONICS flags on the 3 Dot Menu Button on the toolbar to show mnemonics on key press. Forgot to set the flag to actually show mnemonics on toolbar_view. Also removing AppMenu::RunFlags enum and using MenuRunner::RunTypes instead. Bug: 928678 Change-Id: I728553016ad1f399fe6f4daffd2cf4043ff8cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529752 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#642102} .../ui/views/frame/hosted_app_menu_button.cc | 5 +++-- .../views/media_router/app_menu_test_api_views.cc | 2 +- chrome/browser/ui/views/toolbar/app_menu.cc | 6 +++--- chrome/browser/ui/views/toolbar/app_menu.h | 21 ++++++--------------- .../ui/views/toolbar/browser_app_menu_button.cc | 6 +++--- chrome/browser/ui/views/toolbar/toolbar_view.cc | 4 +++- ui/views/controls/menu/menu_runner.h | 2 ++ 7 files changed, 21 insertions(+), 25 deletions(-) commit ed636210923809b21892c310d06ad9349b05a8a6 Author: Jeremy Klein <jlklein@google.com> Date: Tue Mar 19 18:40:02 2019 +0000 Add the pii-free name to RemoteDevice. Propagating this new field from ExternalDeviceInfo into RemoteDevice and RemoteDeviceRef so that it can be used when populating the UMA proto fields. Bug: b/123091364 Test: Manual and Unit Tests Change-Id: Ifb90abe02958e495e1c2fa91010b04e8ddd16682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530192 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#642101} .../login/easy_unlock/easy_unlock_service_signin_chromeos.cc | 3 ++- .../multidevice/debug_webui/proximity_auth_webui_handler.cc | 3 +++ .../multidevice/debug_webui/resources/proximity_auth.html | 4 ++++ .../multidevice/debug_webui/resources/proximity_auth.js | 2 ++ .../components/multidevice/mojom/multidevice_mojom_traits.cc | 9 +++++++++ .../components/multidevice/mojom/multidevice_mojom_traits.h | 2 ++ .../multidevice/mojom/multidevice_mojom_traits_unittest.cc | 2 ++ chromeos/components/multidevice/mojom/multidevice_types.mojom | 3 +++ chromeos/components/multidevice/remote_device.cc | 3 +++ chromeos/components/multidevice/remote_device.h | 2 ++ chromeos/components/multidevice/remote_device_ref.h | 3 +++ chromeos/components/multidevice/remote_device_ref_unittest.cc | 5 +++-- chromeos/components/multidevice/remote_device_test_util.cc | 10 +++++++++- chromeos/components/multidevice/remote_device_test_util.h | 1 + chromeos/services/device_sync/remote_device_loader.cc | 6 +++--- chromeos/services/device_sync/remote_device_loader_unittest.cc | 5 +++++ 16 files changed, 56 insertions(+), 7 deletions(-) commit 3fa3231e864cdbcd6572e8514f6050c43b28ce7f Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 18:39:33 2019 +0000 Revert "Allow .pydeps files to detect use of vpython" This reverts commit 4585663b43ffb02972f002764c9e8d2bb70ae61a. Reason for revert: Breaking presubmit bots. Original change's description: > Allow .pydeps files to detect use of vpython > > Switches test_runner.py and run_py_tests.py to run using vpython. Their > use of "psutil" makes me think this is necessary (plus the breakage in > bug 930538). > > Bug: 930752, 930538 > Change-Id: Iacdb517aa0fc7c1f799b1cd5105fa16a4c59cd7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464639 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642019} TBR=dpranke@chromium.org,agrieve@chromium.org,jbudorick@chromium.org Change-Id: I8bd6b95aec6e22c0be2152137f4d9db11477c75f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930752, 930538, 943654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531112 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642100} build/android/test_runner.py | 2 +- build/print_python_deps.py | 19 +++++-------------- chrome/test/chromedriver/test/run_py_tests.py | 2 +- 3 files changed, 7 insertions(+), 16 deletions(-) commit 0b691aae54efc55ac98738e484429137ee7df59a Author: Clemens Hammacher <clemensh@chromium.org> Date: Tue Mar 19 18:38:55 2019 +0000 Add "v8.wasm" trace event category This category exists since a long time, but it was never listed in the builtin categories. In the past it showed up eventually anyway, but this seems to have changed. In any case, listing it here provides a better user experience because the category will just always be there. R=ahaas@chromium.org, oysteine@chromium.org Change-Id: I156b00667e2575459c28f412f6921e8d3b5f6a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528535 Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#642099} base/trace_event/builtin_categories.h | 1 + 1 file changed, 1 insertion(+) commit b84c3494d916dcc5fe29dd373231b01a34bccc66 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Tue Mar 19 18:38:27 2019 +0000 Make SimpleKeyedServiceFactory thread safe. crbug.com/701326 is a problem (being worked on) in BrowserContext factories, but Simple factories are not restricted by the preexisting usages in different threads. The DCHECKs can, therefore, just be introduced. There is already an override of GetKeyToUse() which does not perform the check, this CL fixes that and future problems. Change-Id: I160ada8a1edaccd0686794c0d018e768c54d4259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529576 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#642098} components/keyed_service/core/simple_keyed_service_factory.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 46d4e277a9da928e57f40a9f5c449fb871e55f9a Author: Koji Ishii <kojii@chromium.org> Date: Tue Mar 19 18:37:13 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 16857 16860 16868 16875 16880 16891 16902 16911 16921 16932 16938 16944 16948 16952 3 lines were removed and 7 lines were deflaked by consecutive results since 16868. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I0587b135252c0b84cbff7590574f90ce3663411f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524813 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#642097} .../FlagExpectations/enable-blink-features=LayoutNG | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) commit 25b50fc82ed5d17957f6aeacecd711ce3faab175 Author: siyua <siyua@chromium.org> Date: Tue Mar 19 18:36:10 2019 +0000 [Paradise] Add fieldtrial testing config for experiment enabling local card migration flow for non-sync users. Feature flag added here: https://cs.chromium.org/chromium/src/components/autofill/core/common/autofill_features.cc?l=103-107&rcl=39586ceb77b77e4ccc44d77828c52c5e0da3ca31 Bug: 897998 Change-Id: I8679e9fd09779c918b37b81c2040858e124ff835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529521 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#642096} testing/variations/fieldtrial_testing_config.json | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) commit e2bdf317fa7d9558f38413d234e9859f29078a39 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Mar 19 18:35:49 2019 +0000 [Payment Request][Android] Add back the organization field. Before this patch, the browser payment sheet for W3C Payment Request API did not display the organization field, which is required for the W3C Payment Request spec: https://w3c.github.io/payment-request/#dom-paymentaddress This patch replaces the "show email address" boolean in the address editor with a "purpose" enum with one of three values: - Purpose.PAYMENT_REQUEST: - Show organization, if required by country formatting rules. - Don't show email. - Purpose.AUTOFILL_SETTINGS: - Show organization, if required by country formatting rules and the "autofill company field" feature is enabled. - Show email. - Purpose.AUTOFILL_ASSISTANT: Same rules as the previous (for now). After this patch, the browser payment sheet for W3C Payment Request API shows the organization field. Bug: 941179 Change-Id: Ia08637c8a3da1661244cb84492209ff4f189504d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529357 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#642095} .../payment/AutofillAssistantPaymentRequest.java | 5 +- .../chrome/browser/payments/AddressEditor.java | 62 ++++++++++++++-------- .../browser/payments/PaymentRequestImpl.java | 4 +- .../autofill/AutofillProfileEditorPreference.java | 2 +- .../payments/PaymentRequestBillingAddressTest.java | 46 +++++----------- ...ymentRequestBillingAddressWithoutPhoneTest.java | 14 ++--- .../PaymentRequestEmailAndFreeShippingTest.java | 16 ++---- .../payments/PaymentRequestFreeShippingTest.java | 39 ++++---------- ...ncompleteContactDetailsAndFreeShippingTest.java | 31 +++-------- .../payments/PaymentRequestJourneyLoggerTest.java | 15 ++---- .../payments/PaymentRequestNoShippingTest.java | 28 +++------- ...PaymentRequestShippingAddressAndOptionTest.java | 20 ++----- chrome/browser/android/preferences/autofill/OWNERS | 1 + .../autofill/autofill_profile_bridge.cc | 7 +-- 14 files changed, 101 insertions(+), 189 deletions(-) commit 0f4fde4208b2f4e19a7b5d92ee98dfb57873bfda Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Mar 19 18:35:44 2019 +0000 [Perf Waterfall] Disable reference builds on Mac TBR=jbudorick@chromium.org Bug: 940075 Change-Id: Ibb863ac8c33d0f4057e0df78819893d8c0668d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531106 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#642094} testing/buildbot/chromium.perf.json | 2 -- tools/perf/core/perf_data_generator.py | 8 ++++++-- 2 files changed, 6 insertions(+), 4 deletions(-) commit df31273ec872f5f578b4fe92747c7f663c7154a2 Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 18:34:43 2019 +0000 DevTools: optimize Styles sidebar for reading property values SSP UI changes - Curly brace, Source link color less dark - Source links are more aggressively truncated - "Inherited from" separators have less noise Screenshot: https://imgur.com/a/SwpWkGs Bug: 929536 Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642093} .../front_end/elements/StylesSidebarPane.js | 7 ++- .../front_end/elements/stylesSidebarPane.css | 29 +++++++----- .../elements/elements-panel-styles-expected.txt | 26 +++++------ ...ate-styles-sidebar-with-arrow-keys-expected.txt | 10 ++--- .../elements/styles-1/commit-selector-expected.txt | 6 +-- .../styles-1/cssom-media-insert-crash-expected.txt | 4 +- ...isable-property-workingcopy-update-expected.txt | 4 +- .../styles-1/dynamic-style-tag-expected.txt | 12 ++--- .../elements/styles-1/edit-media-text-expected.txt | 12 ++--- .../styles-1/empty-background-url-expected.txt | 2 +- .../elements/styles-2/add-import-rule-expected.txt | 4 +- .../cssom-shorthand-important-expected.txt | 2 +- .../styles-2/force-pseudo-state-expected.txt | 8 ++-- .../styles-2/inactive-properties-expected.txt | 4 +- .../inherited-mixed-case-properties-expected.txt | 2 +- .../styles-2/inject-stylesheet-expected.txt | 24 +++++----- .../elements/styles-2/keyframes-rules-expected.txt | 2 +- .../styles-2/lazy-computed-style-expected.txt | 40 ++++++++--------- .../elements/styles-2/media-emulation-expected.txt | 12 ++--- .../elements/styles-2/media-queries-expected.txt | 2 +- .../styles-2/media-using-same-url-expected.txt | 4 +- .../elements/styles-2/parse-comments-expected.txt | 4 +- .../elements/styles-2/parse-utf8-bom-expected.txt | 2 +- ...rm-undo-perform-of-mergable-action-expected.txt | 8 ++-- .../elements/styles-2/pseudo-elements-expected.txt | 8 ++-- .../styles-2/region-style-crash-expected.txt | 4 +- ...omputed-properties-retain-expanded-expected.txt | 8 ++-- .../elements/styles-3/selector-list-expected.txt | 8 ++-- .../styles-3/shadow-dom-rules-expected.txt | 2 +- ...tyle-rule-from-imported-stylesheet-expected.txt | 4 +- .../styles-add-new-rule-to-stylesheet-expected.txt | 2 +- .../styles-3/styles-computed-trace-expected.txt | 52 +++++++++++----------- .../styles-cssom-important-property-expected.txt | 2 +- ...sable-property-after-selector-edit-expected.txt | 2 +- .../styles-3/styles-variables-expected.txt | 22 ++++----- ...s-do-not-detach-sourcemap-on-edits-expected.txt | 12 ++--- ...s-edit-property-after-invalid-rule-expected.txt | 4 +- .../elements/styles-4/styles-iframe-expected.txt | 2 +- .../styles-inherited-same-source-expected.txt | 2 +- .../styles-4/styles-keyframes-expected.txt | 20 ++++----- .../styles-overloaded-shorthand-expected.txt | 6 +-- .../styles-overriden-properties-expected.txt | 6 +-- .../styles-properties-overload-expected.txt | 6 +-- .../styles-4/styles-source-lines-expected.txt | 8 ++-- .../styles-source-lines-inline-expected.txt | 2 +- .../styles-source-lines-recovery-expected.txt | 6 +-- .../styles-4/styles-update-links-1-expected.txt | 28 ++++++------ .../styles-4/styles-update-links-2-expected.txt | 14 +++--- .../styles-4/styles-update-links-3-expected.txt | 14 +++--- .../styles-4/styles-update-links-4-expected.txt | 6 +-- .../styles-4/undo-add-property-expected.txt | 24 +++++----- .../cancel-upon-invalid-property-expected.txt | 4 +- .../styles/selector-line-deprecated-expected.txt | 2 +- .../elements/styles/selector-line-expected.txt | 2 +- ...r-line-sourcemap-header-deprecated-expected.txt | 2 +- .../selector-line-sourcemap-header-expected.txt | 2 +- .../styles/show-all-properties-expected.txt | 4 +- .../styles-parse-invalid-properties-expected.txt | 4 +- .../undo-after-cancelled-editing-expected.txt | 6 +-- .../styles/undo-change-property-expected.txt | 8 ++-- .../styles/undo-set-selector-text-expected.txt | 8 ++-- .../devtools/startup/shadow-dom-rules-expected.txt | 2 +- 62 files changed, 278 insertions(+), 270 deletions(-) commit 5e9ef89acc99c1a10bfc49441da4d4291f1ab038 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Mar 19 18:34:40 2019 +0000 Add rmcelrath to network service OWNERS. Change-Id: I6f9c2a73d5901b15e7a0425b7342dd8076cd1b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529084 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#642092} services/network/OWNERS | 1 + 1 file changed, 1 insertion(+) commit 7f6544740fd672dc310e28b5bc7d5f25d69badf2 Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Tue Mar 19 18:33:36 2019 +0000 Add the base class for the new memory pressure monitor. This doesn't do anything yet, it's simply the base classes for the new memory pressure monitor. Bug: 771478 Change-Id: I83e65b3128f7eb9634d3ce15a4ef45232a57971c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518925 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#642091} chrome/browser/BUILD.gn | 4 ++ chrome/browser/memory/memory_pressure_monitor.cc | 52 +++++++++++++++++++ chrome/browser/memory/memory_pressure_monitor.h | 60 ++++++++++++++++++++++ .../browser/memory/memory_pressure_monitor_win.cc | 15 ++++++ .../browser/memory/memory_pressure_monitor_win.h | 30 +++++++++++ 5 files changed, 161 insertions(+) commit 7660d34c2fe47eca6bac6b4ec9f8f95ee164bf4d Author: Jao-ke Chin-Lee <jchinlee@chromium.org> Date: Tue Mar 19 18:33:29 2019 +0000 Barcode Detection Mac: Query Vision library for supported formats. The Vision library supports variants of various barcode formats, so convert those to the appropriate mojom BarcodeFormat. BUG=925167 Change-Id: I174cae68069e016262839fb4c1616f5a146568d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516024 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642090} services/shape_detection/BUILD.gn | 2 + .../shape_detection/barcode_detection_impl_mac.h | 6 + .../shape_detection/barcode_detection_impl_mac.mm | 6 + .../barcode_detection_impl_mac_unittest.mm | 10 -- .../barcode_detection_impl_mac_vision.h | 6 + .../barcode_detection_impl_mac_vision.mm | 42 +++++- .../barcode_detection_impl_mac_vision_api.h | 35 +++++ .../barcode_detection_impl_mac_vision_api.mm | 44 +++++++ .../barcode_detection_provider_mac.h | 10 ++ .../barcode_detection_provider_mac.mm | 40 ++++-- .../barcode_detection_provider_mac_unittest.mm | 145 ++++++++++++++++++--- 11 files changed, 298 insertions(+), 48 deletions(-) commit 82ca50e8b472113becc801a3957cff84f169ab8c Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 18:31:46 2019 +0000 DevTools: dedupe similar UA rules with the same selector Screenshot: https://imgur.com/a/CtwvB1a Bug: 929536 Change-Id: I40154e9c5896c61130de3635232259c89ef3ef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519450 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642089} .../devtools/front_end/sdk/CSSMatchedStyles.js | 77 ++++++++++++++++++---- 1 file changed, 63 insertions(+), 14 deletions(-) commit 65fbd9f55d3ecfa38d8c55d4e14746c15ca58c44 Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 18:31:16 2019 +0000 DevTools: easier text selection in SSP via drag Selecting text is important to copy/paste styles from Elements panel. This CL improves a common case that often results in poor selection. In the future, 'user-select: contain' may address this. Screenshot: https://imgur.com/a/hMlsY5C Bug: 929536 Change-Id: I23f7b1a53ad501b491017887feaab63ead2c3705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1412354 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642088} .../devtools/front_end/elements/ElementsPanel.js | 53 ++++++++++++++++++++++ .../renderer/devtools/front_end/ui/splitWidget.css | 4 ++ 2 files changed, 57 insertions(+) commit 9a66d1c45bc87e665b626631ad9f151c82cffa2d Author: siyua <siyua@chromium.org> Date: Tue Mar 19 18:26:56 2019 +0000 [Paradise] Add flag for experiment enabling migration flow for non-sync users Bug: 897998 Change-Id: I14c5c8f86188808933798b7b7d39ffebff0ca323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529577 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#642087} chrome/browser/about_flags.cc | 8 ++++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 4 ++++ 5 files changed, 26 insertions(+) commit a896f66317d0090b468664581b071bc4ac1c1d62 Author: Dan Beam <dbeam@chromium.org> Date: Tue Mar 19 18:26:39 2019 +0000 Navi: fix gzip issues, take 2 Record all resources for which we have gzip info, whether the resource is actually gzipped or not. For unknown resources, match the default resource (welcome.html), which is gzipped. "preview-background.jpg" is a dynamic path that fetches a background from the network. It must also be excluded as IsGzipped() is currently called before requests start in URLDataManagerBackend::StartRequest(). Also adds a quick unit test. R=hcarmona@chromium.org BUG=942977 Change-Id: Iadd1ebedc067ce2d86de5918dcd4fcda55f28c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530012 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#642086} chrome/browser/ui/webui/welcome/welcome_ui.cc | 54 ++++++++++++---------- chrome/browser/ui/webui/welcome/welcome_ui.h | 4 ++ .../ui/webui/welcome/welcome_ui_unittest.cc | 27 +++++++++++ chrome/test/BUILD.gn | 2 + 4 files changed, 63 insertions(+), 24 deletions(-) commit efd59e71af1ebe732468d47a0c50b8fa18455d7b Author: Matt Wolenetz <wolenetz@chromium.org> Date: Tue Mar 19 18:24:25 2019 +0000 MSE - WebM: Fix default duration precision capping Sub-microsecond timescales previously could result in incorrect results that fail the assumption that the result must either be kNoTimestamp or at least 1 microsecond. BUG=937846 TEST=WebMTracksParserTest.PrecisionCapping (plus no local regression of existing media_unittests) Change-Id: I2519f23a730e5ddca4dca2a30d749e7484c3cb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529699 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642085} media/formats/webm/webm_cluster_parser.cc | 4 +- media/formats/webm/webm_cluster_parser.h | 2 +- media/formats/webm/webm_info_parser.cc | 19 +++---- media/formats/webm/webm_info_parser.h | 4 +- media/formats/webm/webm_stream_parser.cc | 9 ++-- media/formats/webm/webm_tracks_parser.cc | 41 ++++++++------- media/formats/webm/webm_tracks_parser.h | 19 +++++-- media/formats/webm/webm_tracks_parser_unittest.cc | 64 +++++++++++++++++++---- 8 files changed, 110 insertions(+), 52 deletions(-) commit 53ed26b450a374367e4cc7591a54fff48bb85b05 Author: Zoe Clifford <zoeclifford@chromium.org> Date: Tue Mar 19 18:20:09 2019 +0000 Timeline frontend should not crash on tracks without threads. This edge-case is hit on profiles generated by headless chrome: * These traces hit the "generic" codepath because the tracing handler is started through browser_devtools_agent_host, without a frame tree node. * In TimelineModel.js _processEvent will ensure the Timings track exists, but will not associate a thread with it. This change fixes the crash and allows these types of profiles to load but isn't perfect because the Timings track will not be shown in this situation. I tried to get the Timings track to show up but wasn't familiar enough with the code to get it working. Bug: 943361 Change-Id: Iedfcf93d65a9a8cb31df20710aa19c7c967217f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529877 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642084} .../front_end/timeline/TimelineFlameChartDataProvider.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit bd16e773ca9b1248ba8938f54b5e24f56d920e42 Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 19 18:17:45 2019 +0000 Remove SQliteChannelIDStore. This entirely unused. Bug: 875053 Change-Id: I7710c3fa54b390edbca1d8a77d9c28ad73be3fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529689 Reviewed-by: Nick Harper <nharper@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642083} net/BUILD.gn | 3 - net/extras/sqlite/sqlite_channel_id_store.cc | 615 --------------------- net/extras/sqlite/sqlite_channel_id_store.h | 62 --- .../sqlite/sqlite_channel_id_store_unittest.cc | 611 -------------------- services/network/network_context.cc | 1 - 5 files changed, 1292 deletions(-) commit a1ef75095030c4eedc75e44269eb9c6b7302c88b Author: Chase Phillips <cmp@chromium.org> Date: Tue Mar 19 18:17:17 2019 +0000 IndexedDB: Merge IndexedDBDispatcherHost and IDBSequenceHelper These classes were originally separate because IndexedDBDispatcherHost lived on the IO thread while IDBSequenceHelper lived on the IDB task runner. After commit 77bf9a9 / https://crrev.com/c/1405718, IndexedDBDispatcherHost moved to live on the IDB task runner, so we can now merge them together. Bug: 717812 Change-Id: Iffc999a17ef562a2c93c139e100a3ece696ce4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526801 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642082} .../indexed_db/indexed_db_dispatcher_host.cc | 145 +++------------------ .../indexed_db/indexed_db_dispatcher_host.h | 2 - 2 files changed, 21 insertions(+), 126 deletions(-) commit 9c1cf648c021a2253c36c333554362177f5f5a38 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 18:16:37 2019 +0000 Roll src/third_party/chromite cbcd56c13ecf..fcbfd4ea485a (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/cbcd56c13ecf..fcbfd4ea485a git log cbcd56c13ecf..fcbfd4ea485a --date=short --no-merges --format='%ad %ae %s' 2019-03-19 nednguyen@google.com dependency: fix bug that causes dependency source paths to be incorrect Created with: gclient setdep -r src/third_party/chromite@fcbfd4ea485a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Idc090c9787a817bbe98b2c905c2f063517d6e609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530158 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642081} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fa83e99ad8f18739995c416fd71e8e2ae4beb16 Author: Brian Salomon <bsalomon@google.com> Date: Tue Mar 19 18:15:44 2019 +0000 Suppress two canvas layout tests to allow small image changes after Skia roll. Linear gradients have slight differences. Bug: 938592 Change-Id: Ia78725689edeea0735b588f9d4ed7b35a7c333bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529190 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#642080} third_party/blink/web_tests/TestExpectations | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 75f1baa3ee16f394689280b781efeddcfc321e98 Author: Bo Liu <boliu@chromium.org> Date: Tue Mar 19 18:09:08 2019 +0000 aw: Always allow webgl in blink Always allow webgl. Webview always requires access to the GPU even if it only does software draws. WebGL will not show up in software draw so there is no more brokeness for user. This makes it easier for apps that want to start running webgl content before webview is first attached. Change-Id: I24bb20dadf1453a00f3ec9cb08a77483972c7c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529658 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#642079} android_webview/browser/aw_settings.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) Updated tag 'tree_truth' (was 9e3b6b9a7115)