Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 45109 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918527434908137488 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itEACc12/luci_context.993017489 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 1 SUDO_COMMAND: /usr/bin/python /b/s/swarming_bot.zip start_bot SUDO_GID: 0 SUDO_UID: 0 SUDO_USER: root SWARMING_BOT_ID: trusty-webrtc-d2a17ac3-us-central1-b-t6k2 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43b068cf59f70911 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: f340cedae45e370059e9d9b0f79d931b78a085e9 [Autofill] Add action metrics for Clear Form option Fabio Tirelo, Tue Mar 19 20:12:44 2019 +0000 630c0fa3a553c1e2db5481455fdb5d5880ea0932 [vr] Add all GVR classes Tibor Goldschwendt, Tue Mar 19 20:10:37 2019 +0000 2052c4655f70989169170c15c68079dc09b5131e [DL]: Fix display lock composited layer paint bug. Vladimir Levin, Tue Mar 19 20:09:47 2019 +0000 04c2389a9c5fde4067d2951d09bb99a562dc2664 SQLitePersistentReportingAndNELStore: Change timestamps to microseconds Lily Chen, Tue Mar 19 20:09:33 2019 +0000 60db5c7bc98bfa9193d43e67a00184b3e6fe0282 cups_printing: Open CUPS printing help page from error toast Bailey Berro, Tue Mar 19 20:08:27 2019 +0000 23b36028c7cfbd3eabf9954a419235de9b34b76d [vr] Add GVR's LegacyVrParamsProvider Tibor Goldschwendt, Tue Mar 19 20:02:31 2019 +0000 e2f5b4576854be85ff585277deeb38d63a52d369 Roll src/third_party/angle 9b050f846a06..4bcba62aba7b (1 commits) chromium-autoroll, Tue Mar 19 19:54:42 2019 +0000 b50f4d18b0b0cffed6612eed2505260f4e9768d9 Rename updating hover without timer related flags Lan Wei, Tue Mar 19 19:52:19 2019 +0000 eb7762a96018b9424e216034ab6c2e7825d6b10d CacheStorage: Fix tracing id bit mask. Ben Kelly, Tue Mar 19 19:50:56 2019 +0000 f944c0d1894f675b3d779723528b6211a6784400 Migrate FileSystemCallbacks to use simple success/failure callbacks Antonio Gomes, Tue Mar 19 19:48:49 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit f340cedae45e370059e9d9b0f79d931b78a085e9 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Mar 19 20:12:44 2019 +0000 [Autofill] Add action metrics for Clear Form option Bug: 943309 Change-Id: I037ea19e08a98550a131c167c006faf709869a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529696 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642148} .../core/browser/autofill_external_delegate.cc | 1 + .../autofill/core/browser/autofill_metrics.cc | 5 + .../autofill/core/browser/autofill_metrics.h | 3 + .../core/browser/autofill_metrics_unittest.cc | 130 ++++++++++++++------- tools/metrics/actions/actions.xml | 8 ++ 5 files changed, 108 insertions(+), 39 deletions(-) commit 630c0fa3a553c1e2db5481455fdb5d5880ea0932 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Mar 19 20:10:37 2019 +0000 [vr] Add all GVR classes We had ommitted a number of GVR classes due to binary size constraints. This caused NoClassDefFoundException such as crbug/913413. GVR Java is now part of the VR DFM, thus, binary size is not as big of a concern anymore. Bug: 913413 Change-Id: I8f706b4c003437b06b70215f9615f03103ac7db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531104 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642147} third_party/gvr-android-sdk/BUILD.gn | 64 ------------------------------------ 1 file changed, 64 deletions(-) commit 2052c4655f70989169170c15c68079dc09b5131e Author: Vladimir Levin <vmpstr@chromium.org> Date: Tue Mar 19 20:09:47 2019 +0000 [DL]: Fix display lock composited layer paint bug. Sometimes, we don't go through the PaintLayerPainter::Paint() function and instead call ::PaintContents directly, such as the case in a composited layer. In this situation, we weren't preventing paint from happening (and effectively didn't clear the painted output) of a display locked element. This patch fixes this and moves the "stop paint" call to PaintLayerContents instead. R=chrishtr@chromium.org Bug: 882663 Change-Id: Ia6087115480f34e5a78879408819eff0a6b5f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531007 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642146} .../renderer/core/paint/paint_layer_painter.cc | 14 ++++---- .../acquire-on-composited-layer-expected.html | 3 ++ .../acquire-on-composited-layer.html | 37 ++++++++++++++++++++++ 3 files changed, 47 insertions(+), 7 deletions(-) commit 04c2389a9c5fde4067d2951d09bb99a562dc2664 Author: Lily Chen <chlily@chromium.org> Date: Tue Mar 19 20:09:33 2019 +0000 SQLitePersistentReportingAndNELStore: Change timestamps to microseconds This changes the times stored in the database from milliseconds since Windows epoch, to microseconds since Windows epoch, in order to be more consistent with how times are stored in other places. Bug: 895821 Change-Id: I0de9f3c7d387a514d53b43531d0ce7786deb46ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531160 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#642145} .../sqlite_persistent_reporting_and_nel_store.cc | 40 +++++++++++----------- ..._persistent_reporting_and_nel_store_unittest.cc | 12 +++---- 2 files changed, 26 insertions(+), 26 deletions(-) commit 60db5c7bc98bfa9193d43e67a00184b3e6fe0282 Author: Bailey Berro <baileyberro@chromium.org> Date: Tue Mar 19 20:08:27 2019 +0000 cups_printing: Open CUPS printing help page from error toast - Fixes bug where "Get Help" button on printing error toast did not do anything. Bug: 900626 Change-Id: Ic49549e0d0f1c012c287a9e63d9b4b162ee502d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529389 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#642144} .../chromeos/printing/cups_print_job_notification.cc | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) commit 23b36028c7cfbd3eabf9954a419235de9b34b76d Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Mar 19 20:02:31 2019 +0000 [vr] Add GVR's LegacyVrParamsProvider We have seen a number of crashes that are due to that class not being available. Bug: 913413 Change-Id: I59e0e2e22bc0f5ada1aaf47d4271816cd010bd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531110 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#642143} third_party/gvr-android-sdk/BUILD.gn | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e2f5b4576854be85ff585277deeb38d63a52d369 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 19:54:42 2019 +0000 Roll src/third_party/angle 9b050f846a06..4bcba62aba7b (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/9b050f846a06..4bcba62aba7b git log 9b050f846a06..4bcba62aba7b --date=short --no-merges --format='%ad %ae %s' 2019-03-19 jonahr@google.com Add Android device name, version, manufacturer to gpu_info_util Created with: gclient setdep -r src/third_party/angle@4bcba62aba7b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I6a65131036f6340941d5c22797570ec58cfea47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530168 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642142} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b50f4d18b0b0cffed6612eed2505260f4e9768d9 Author: Lan Wei <lanwei@chromium.org> Date: Tue Mar 19 19:52:19 2019 +0000 Rename updating hover without timer related flags There are two flags we need to update hover without timer, one is to update hover after scroll ends, the other one is to update hover after layout changes at the begin frame. Bug: 877132 Change-Id: I216b82d9e238b5dcc1444665dfa01f73a9f17bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526812 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#642141} content/child/runtime_features.cc | 10 ++++++---- .../blink/public/platform/web_runtime_features.h | 6 ++++-- .../blink/renderer/core/exported/web_view_impl.cc | 2 +- third_party/blink/renderer/core/input/event_handler.cc | 2 +- .../blink/renderer/core/input/event_handler_test.cc | 2 +- .../blink/renderer/core/input/mouse_event_manager.cc | 5 +++-- .../blink/renderer/core/input/scroll_manager.cc | 2 +- .../renderer/platform/exported/web_runtime_features.cc | 18 ++++++++++-------- .../renderer/platform/runtime_enabled_features.json5 | 16 ++++++++-------- .../no-mouse-cursor-update-after-layout-change.html | 2 +- .../events/no_hover_update_after_layout_change.html | 4 ++-- .../fast/scrolling/no-hover-during-scroll.html | 2 +- ui/events/blink/blink_features.cc | 9 +++++---- ui/events/blink/blink_features.h | 4 ++-- 14 files changed, 46 insertions(+), 38 deletions(-) commit eb7762a96018b9424e216034ab6c2e7825d6b10d Author: Ben Kelly <wanderview@chromium.org> Date: Tue Mar 19 19:50:56 2019 +0000 CacheStorage: Fix tracing id bit mask. Bug: 927538 Change-Id: I166ccaa795736e96127aa2dc0526b2650cfeb0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526464 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642140} third_party/blink/common/cache_storage/cache_storage_utils.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f944c0d1894f675b3d779723528b6211a6784400 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 19:48:49 2019 +0000 Migrate FileSystemCallbacks to use simple success/failure callbacks This CL is a continuation of the effort to simplify the callbacks implementation in t_p/b/renderer/modules/filesystem/file_system_callbacks.h At this time, FileSystemCallbacks wrapper class is migrated to use simple (BindOnce) callbacks, one for success, another for failure. R=mek@chromium.org CC=dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: I8fae7534be65f992b8b2c5a47cc08a6ab1192502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529470 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#642139} .../modules/filesystem/async_callback_helper.h | 1 + .../renderer/modules/filesystem/dom_file_system.cc | 5 +++ .../renderer/modules/filesystem/dom_file_system.h | 3 ++ .../modules/filesystem/dom_window_file_system.cc | 13 +++--- .../modules/filesystem/file_system_callbacks.cc | 47 +++++----------------- .../modules/filesystem/file_system_callbacks.h | 40 +++++------------- .../filesystem/file_system_directory_handle.cc | 9 +++-- .../filesystem/worker_global_scope_file_system.cc | 23 ++++++++--- 8 files changed, 62 insertions(+), 79 deletions(-) commit 0e6d6bf816c17b290e3fb56f7abb50f7034d2a73 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 19 19:47:45 2019 +0000 gpu: Invalidate channel map first to fix reentracy issues Clearing the channel map in DestroyAllChannels can re-enter into GpuChannelManager via LoseAllContexts from ~GpuChannel causing a use-after-free crash. Bug: 942954 Change-Id: Iaf5f64ec3f96f2b5948cd6080c701c1107bd5b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529342 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#642138} gpu/ipc/service/gpu_channel_manager.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 67140f6cd8a5c4b035727b6bebf591cc5d77f6fc Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 19 19:47:20 2019 +0000 Add temporary CHECK for debugging Bug: 890227 Change-Id: I92bbe90024245fde91a977402f950909f2e8b00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529690 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#642137} gpu/ipc/service/direct_composition_surface_win.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 64ca4aaa30ed664a2612824d3fbe1aaf0479b3ee Author: Livvie Lin <livvielin@chromium.org> Date: Tue Mar 19 19:46:04 2019 +0000 Change security style for HTTP and secure origins Insecure origins in the sidebar will now show a red triangle icon rather than a red circle. Some HTTP origins, specifically for optionally blockable mixed content, still show a red circle (will be updated in a follow-up cl). Secure origins will now show the secure (green square) style. Bug: 936669 Change-Id: I10efe286029379bbadbbb8c309b64eb706b8851c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496521 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#642136} .../browser/devtools/protocol/network_handler.cc | 10 ++++- content/renderer/loader/web_url_loader_impl.cc | 8 +++- .../devtools/front_end/security/SecurityPanel.js | 7 ++++ ...iew-noncryptographic-secure-origin-expected.txt | 43 ++++++++++++++++++++++ .../origin-view-noncryptographic-secure-origin.js | 21 +++++++++++ .../origin-view-then-interstitial-expected.txt | 6 +-- .../security/origin-view-then-interstitial.js | 6 +-- 7 files changed, 92 insertions(+), 9 deletions(-) commit b25cc86db66c4d1bd0462d54ec8aadaa60c6c9b1 Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Mar 19 19:44:05 2019 +0000 Remove "DragTabsInTabletMode" feature flag. The feature has been launched for a while. Bug: 823769 Change-Id: I240838fb5382a9f73d30b08204736cd8d87696f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529584 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642135} ash/public/cpp/ash_features.cc | 3 --- ash/public/cpp/ash_features.h | 5 ----- chrome/browser/ui/views/tabs/tab_drag_controller.cc | 16 +++------------- 3 files changed, 3 insertions(+), 21 deletions(-) commit fbfbd7a65b0397a9979a307f5d189270ac6b3f8b Author: Erik Chen <erikchen@chromium.org> Date: Tue Mar 19 19:39:28 2019 +0000 Add bsep and tbergquist as OWNERS of chrome/browser/ui/tabs. Change-Id: I0a72db0eb8d7e6349f543760da89391e1c1c9d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529586 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#642134} chrome/browser/ui/tabs/OWNERS | 2 ++ 1 file changed, 2 insertions(+) commit 3c26f82483274f75b32bc7b88368b1ebfc4694a2 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 19:36:30 2019 +0000 Migrate EntryCallbacks to use simple success/failure callbacks This CL is a continuation of the effort to simplify the callbacks implementation in t_p/b/renderer/modules/filesystem/file_system_callbacks.h At this time, EntryCallbacks wrapper classes are migrated to use simple (BindOnce) callbacks, one for success, another for failure. R=mek@chromium.org CC=dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: I1591aed86ea379a511f985534b914cd1797911d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528394 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#642133} .../modules/filesystem/async_callback_helper.h | 24 +++++++- .../renderer/modules/filesystem/directory_entry.cc | 25 +++++--- .../modules/filesystem/directory_entry_sync.cc | 25 ++++++-- .../renderer/modules/filesystem/dom_file_system.cc | 14 +++++ .../renderer/modules/filesystem/dom_file_system.h | 4 ++ .../modules/filesystem/dom_file_system_base.cc | 69 ++++++++++++---------- .../modules/filesystem/dom_file_system_base.h | 23 ++++---- .../modules/filesystem/dom_file_system_sync.cc | 5 ++ .../modules/filesystem/dom_file_system_sync.h | 1 + .../modules/filesystem/dom_window_file_system.cc | 19 +++--- .../blink/renderer/modules/filesystem/entry.cc | 34 +++++++---- .../renderer/modules/filesystem/entry_sync.cc | 22 +++++-- .../modules/filesystem/file_system_base_handle.cc | 34 +++++++---- .../modules/filesystem/file_system_callbacks.cc | 27 +++------ .../modules/filesystem/file_system_callbacks.h | 23 ++++---- .../filesystem/file_system_directory_handle.cc | 24 +++++--- 16 files changed, 243 insertions(+), 130 deletions(-) commit 787ecc9dac9b8cadd25e474ffb51bca7051b61ab Author: John Williams <jrw@google.com> Date: Tue Mar 19 19:34:43 2019 +0000 [Cast MRP] Implement PresentationConnection close. When Cast MRP receives a DidClose() call from a PresentationConnection in a controlling frame in Blink, it will remove the associated client from the ongoing Cast activity. This replaces the MediaRouteProvider::DetachRoute() API. Also updated the CloseConnection() call to use DidClose instead of DidChangeState, as calling the latter with CLOSED will result in DCHECK. Bug: 809249 Change-Id: I05c2bd447b3cc0ffe2f773bed41dc2cf618cf537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1432672 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642132} .../router/providers/cast/cast_activity_manager.cc | 64 +++++++++++++--------- .../router/providers/cast/cast_activity_manager.h | 4 ++ .../cast/cast_activity_manager_unittest.cc | 5 +- .../providers/cast/cast_internal_message_util.h | 3 + .../providers/cast/cast_media_route_provider.cc | 4 ++ 5 files changed, 52 insertions(+), 28 deletions(-) commit fe66e1a32cbc08e2f5dd18b3190aba2bdf2f2536 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Tue Mar 19 19:29:44 2019 +0000 Roll src/tools/swarming_client/ 7a61cf37d..aa60736ad (3 commits) https://chromium.googlesource.com/infra/luci/client-py.git/+log/7a61cf37d6a0..aa60736aded9 $ git log 7a61cf37d..aa60736ad --date=short --no-merges --format='%ad %ae %s' 2019-03-14 iannucci [libs/logdog] Small tweaks and add fileno to BasicStream. 2019-03-14 maruel [client] Delete run_isolated.zip support 2019-03-04 iannucci [logdog_client] Add $LOGDOG_NAMESPACE to allow transparent logdog client nesting. Created with: roll-dep src/tools/swarming_client R=jchinlee@chromium.org Change-Id: If46f4b2d551a783acd10371e1c542be2dbfd805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529665 Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642131} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d5ade6542f4d07feb03dbb8dc78b9214d11e38c Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Mar 19 19:24:32 2019 +0000 [modules] Add autogenerated module class Bug: 925528 Change-Id: I144839685ad4246cec990b8289fbdac9144286e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515608 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642130} chrome/android/BUILD.gn | 2 + .../chrome/browser/vr/VrDelegateFallback.java | 4 +- .../chrome/browser/vr/VrDelegateProvider.java | 3 + .../chrome/browser/vr/VrDelegateProviderImpl.java | 2 +- .../chrome/browser/vr/VrModuleProvider.java | 29 ++--- components/module_installer/android/BUILD.gn | 18 +++ .../components/module_installer/Module.java | 77 ++++++++++++ .../module_installer/ModuleInterface.java | 23 ++++ .../module_installer/ModuleInterfaceProcessor.java | 135 +++++++++++++++++++++ 9 files changed, 269 insertions(+), 24 deletions(-) commit 0924270eeaf293d4304db5cc5fdcd04168988d35 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Tue Mar 19 19:22:56 2019 +0000 [Autofill Assistant] PR ScrollView now plays nicely with bottom bar children. Before this change, the Payment Request ScrollView would occupy as much space as possible and would thus hide the carousel. This is because the ScrollView was not a sibling of the carousel and the other bottom bar children. This CL ensures that the AssistantPaymentRequestCoordinator view is the FadingEdgeScrollView that was used in PR. This means that the whole UI view is now scrollable (including Terms & Conditions and the privacy notice). Screenshots: - Before: https://screenshot.googleplex.com/REcUPgHMB1O.png - After: https://screenshot.googleplex.com/OnGWK6soYmb.png Bug: b/128673525 Change-Id: Id035897a6638c85207e5d3c9ce8c6cca936f87da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530764 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#642129} .../layout/autofill_assistant_payment_request.xml | 26 +++++++--------------- .../AssistantPaymentRequestCoordinator.java | 14 ++++++++++-- .../payment/PaymentRequestUI.java | 17 +++++--------- 3 files changed, 25 insertions(+), 32 deletions(-) commit d1f53769a890a25b0f9dafb85700ac32c5883380 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Mar 19 19:22:49 2019 +0000 Revert "WS: CrashInFlightChange dump window name and location" This reverts commit fca3ec75eaa93b7d613618a6006f95168ee920f8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 642114 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZjYTNlYzc1ZWFhOTNiN2Q2MTM2MThhNjAwNmY5NTE2OGVlOTIwZjgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64/61125 Sample Failed Step: compile Original change's description: > WS: CrashInFlightChange dump window name and location > > Dump window name and CrashInFlightChange creation site with > the fatal log. > > Bug: 940620 > Change-Id: I4645986a47a1c495b3279bc2fa07d24487ccda89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529691 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642114} Change-Id: I0acf34f8aa460f82b935f8c196fa0ffc3396a480 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531119 Cr-Commit-Position: refs/heads/master@{#642128} ui/aura/mus/in_flight_change.cc | 21 ++++---------- ui/aura/mus/in_flight_change.h | 7 +---- ui/aura/mus/window_tree_client.cc | 45 ++++++++++++------------------ ui/aura/mus/window_tree_client_unittest.cc | 29 ------------------- 4 files changed, 25 insertions(+), 77 deletions(-) commit 37511ad65414d7d7fd43d4620bc2f7fb91e8b2be Author: Andrew Luo <aluo@chromium.org> Date: Tue Mar 19 19:15:58 2019 +0000 Use webview provider for shell layout and ui webview tests. This prepares the way to switch webview test bots to use swarmed devices. Bug: 814405 Change-Id: Ic6c1f2b713392b3ed80b26dae1a5571de648914d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526809 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642127} android_webview/tools/automated_ui_tests/BUILD.gn | 1 + testing/buildbot/gn_isolate_map.pyl | 8 ++++++++ 2 files changed, 9 insertions(+) commit 05f9b4c02be51e3bc0881b1e6d7039cc5f4707a2 Author: Allison Pastewka <alpastew@microsoft.com> Date: Tue Mar 19 19:15:17 2019 +0000 Eliminated remaining uses of [LegacyInterfaceTypeChecking] Removed [LegacyInterfaceTypeChecking] from the two remaining idls, RTCPeerConnection-getStats and FormData. Updated the relevant tests to match the new behavior. Seeing as how [LegacyInterfaceTypeChecking] is no longer being used, I removed the extended attribute from IDLExtendedAttributes.md and IDLExtendedAttributes.txt. Bug: 561338 Change-Id: I4783348f485932f08c86ddb58efb6cb713fd5fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507237 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Allison Pastewka <alpastew@microsoft.com> Cr-Commit-Position: refs/heads/master@{#642126} .../renderer/bindings/IDLExtendedAttributes.md | 1 - .../renderer/bindings/IDLExtendedAttributes.txt | 1 - .../renderer/bindings/scripts/v8_attributes.py | 9 +- .../renderer/bindings/scripts/v8_interface.py | 8 +- .../blink/renderer/bindings/scripts/v8_methods.py | 8 +- .../renderer/bindings/scripts/v8_utilities.py | 6 - .../bindings/tests/idls/core/test_interface.idl | 3 - .../bindings/tests/idls/core/test_object.idl | 6 - .../tests/results/core/v8_test_interface.cc | 61 ------ .../tests/results/core/v8_test_interface.h | 3 - .../bindings/tests/results/core/v8_test_object.cc | 223 --------------------- .../bindings/tests/results/core/v8_test_object.h | 10 - .../blink/renderer/core/html/forms/form_data.cc | 4 - .../blink/renderer/core/html/forms/form_data.idl | 6 +- .../modules/peerconnection/rtc_peer_connection.idl | 2 +- .../external/wpt/xhr/FormData-append.html | 8 + .../external/wpt/xhr/formdata-expected.txt | 10 - .../web_tests/external/wpt/xhr/formdata-set.htm | 8 + .../blink/web_tests/external/wpt/xhr/formdata.htm | 2 +- ...RTCPeerConnection-getStats-overrides.https.html | 5 +- .../RTCPeerConnection-stats-expected.txt | 9 - .../peerconnection/RTCPeerConnection-stats.html | 10 +- 22 files changed, 29 insertions(+), 374 deletions(-) commit c5335225660544666a28adf7f05e20d9521929ae Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Mar 19 19:13:17 2019 +0000 Disable flaky test on mac No-Try: True Tbr: mmentovai Bug: 943669 Change-Id: Iee3cbda469cbdeab7e542bcd566adbb45c0388ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531280 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#642125} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit e237674c1a6b1e33171eb6aafd66eec775bff618 Author: Karolina Soltys <ksolt@chromium.org> Date: Tue Mar 19 19:09:38 2019 +0000 [scheduler] Ui thread task posting API changes. As part of an ongoing effort to migrate all Java task posting to PostTask, we are deprecating the alternative methods used at the moment and providing PostTask-based alternatives. We are also providing a workaround for call sites which can't import content. In order for this to work, we are adding ThreadUtils initialisation to an early stage in the initialisation of Chrome. Bug: 863341 Change-Id: Ie1594a36803dd3b43480098a24e6fbd3e34c5c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518513 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642124} .../java/src/org/chromium/base/ThreadUtils.java | 53 ++++++++ .../java/src/org/chromium/base/task/PostTask.java | 34 +++++ content/public/android/BUILD.gn | 2 - .../content/browser/BrowserThreadUtilsImpl.java | 148 --------------------- .../content_public/browser/BrowserThreadUtils.java | 109 --------------- .../browser/scheduler/UiThreadSchedulerTest.java | 18 +++ .../browser/test/util/TestThreadUtils.java | 8 +- 7 files changed, 109 insertions(+), 263 deletions(-) commit 22bfe6006e3fa913d6d9b0b09261218d979249c3 Author: rajendrant <rajendrant@chromium.org> Date: Tue Mar 19 19:08:28 2019 +0000 Fix tests that change ECT to use feature params NQE has been converted to a feature in the below CL. So use that for the tests. http://crrev.com/c/1516433 Bug: 940943 Change-Id: Ib9a8c810fea23a63e7f119c474936afeb95037d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531100 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#642123} tools/chrome_proxy/webdriver/lite_page.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) Updated tag 'tree_truth' (was 178dc2bcb8d5)