Back to build
Raw log | Switch to full mode | Login

/b/s/w/ir/cache/builder/src/build/tree_truth.sh /b/s/w/ir/cache/builder/src src in dir /b/s/w/ir/k: allow_subannotations: False cmd: ['/b/s/w/ir/cache/builder/src/build/tree_truth.sh', '/b/s/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/s/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/s/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 45106 DOCKER_CONFIG: /b/s/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/s/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: em1 INFRA_GIT_WRAPPER_HOME: /b/s/w/ir/tmp/git_home_task LANG: en_US.UTF-8 LANGUAGE: en_US: LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918525907478195744 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/s/w/ir/tmp/ld.sock LOGICAL: em1 LOGNAME: chrome-bot LUCI_CONTEXT: /b/s/w/itOeHgmg/luci_context.648604100 MAC_CHROMIUM_TMPDIR: /b/s/w/ir/tmp/t MAIL: /var/mail/chrome-bot METHOD: dhcp NO_GCE_CHECK: False PATH: /b/s/w/ir/cipd_bin_packages:/b/s/w/ir/cipd_bin_packages/bin:/b/s/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games PWD: /b/s/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 SHELL: /bin/bash SHLVL: 2 SWARMING_BOT_ID: build3-b9 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43b07f0b23843011 TEMP: /b/s/w/ir/tmp/t TEMPDIR: /b/s/w/ir/tmp/t TERM: linux TMP: /b/s/w/ir/tmp/t TMPDIR: /b/s/w/ir/tmp/t UPSTART_EVENTS: local-filesystems net-device-up UPSTART_INSTANCE: UPSTART_JOB: swarming USER: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/s/w/ir/cache/vpython XDG_RUNTIME_DIR: /run/user/1000 XDG_SESSION_ID: c1 _: /b/s/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: f340cedae45e370059e9d9b0f79d931b78a085e9 [Autofill] Add action metrics for Clear Form option Fabio Tirelo, Tue Mar 19 20:12:44 2019 +0000 630c0fa3a553c1e2db5481455fdb5d5880ea0932 [vr] Add all GVR classes Tibor Goldschwendt, Tue Mar 19 20:10:37 2019 +0000 2052c4655f70989169170c15c68079dc09b5131e [DL]: Fix display lock composited layer paint bug. Vladimir Levin, Tue Mar 19 20:09:47 2019 +0000 04c2389a9c5fde4067d2951d09bb99a562dc2664 SQLitePersistentReportingAndNELStore: Change timestamps to microseconds Lily Chen, Tue Mar 19 20:09:33 2019 +0000 60db5c7bc98bfa9193d43e67a00184b3e6fe0282 cups_printing: Open CUPS printing help page from error toast Bailey Berro, Tue Mar 19 20:08:27 2019 +0000 23b36028c7cfbd3eabf9954a419235de9b34b76d [vr] Add GVR's LegacyVrParamsProvider Tibor Goldschwendt, Tue Mar 19 20:02:31 2019 +0000 e2f5b4576854be85ff585277deeb38d63a52d369 Roll src/third_party/angle 9b050f846a06..4bcba62aba7b (1 commits) chromium-autoroll, Tue Mar 19 19:54:42 2019 +0000 b50f4d18b0b0cffed6612eed2505260f4e9768d9 Rename updating hover without timer related flags Lan Wei, Tue Mar 19 19:52:19 2019 +0000 eb7762a96018b9424e216034ab6c2e7825d6b10d CacheStorage: Fix tracing id bit mask. Ben Kelly, Tue Mar 19 19:50:56 2019 +0000 f944c0d1894f675b3d779723528b6211a6784400 Migrate FileSystemCallbacks to use simple success/failure callbacks Antonio Gomes, Tue Mar 19 19:48:49 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit f340cedae45e370059e9d9b0f79d931b78a085e9 Author: Fabio Tirelo <ftirelo@chromium.org> Date: Tue Mar 19 20:12:44 2019 +0000 [Autofill] Add action metrics for Clear Form option Bug: 943309 Change-Id: I037ea19e08a98550a131c167c006faf709869a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529696 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642148} .../core/browser/autofill_external_delegate.cc | 1 + .../autofill/core/browser/autofill_metrics.cc | 5 + .../autofill/core/browser/autofill_metrics.h | 3 + .../core/browser/autofill_metrics_unittest.cc | 130 ++++++++++++++------- tools/metrics/actions/actions.xml | 8 ++ 5 files changed, 108 insertions(+), 39 deletions(-) commit 630c0fa3a553c1e2db5481455fdb5d5880ea0932 Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Mar 19 20:10:37 2019 +0000 [vr] Add all GVR classes We had ommitted a number of GVR classes due to binary size constraints. This caused NoClassDefFoundException such as crbug/913413. GVR Java is now part of the VR DFM, thus, binary size is not as big of a concern anymore. Bug: 913413 Change-Id: I8f706b4c003437b06b70215f9615f03103ac7db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531104 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642147} third_party/gvr-android-sdk/BUILD.gn | 64 ------------------------------------ 1 file changed, 64 deletions(-) commit 2052c4655f70989169170c15c68079dc09b5131e Author: Vladimir Levin <vmpstr@chromium.org> Date: Tue Mar 19 20:09:47 2019 +0000 [DL]: Fix display lock composited layer paint bug. Sometimes, we don't go through the PaintLayerPainter::Paint() function and instead call ::PaintContents directly, such as the case in a composited layer. In this situation, we weren't preventing paint from happening (and effectively didn't clear the painted output) of a display locked element. This patch fixes this and moves the "stop paint" call to PaintLayerContents instead. R=chrishtr@chromium.org Bug: 882663 Change-Id: Ia6087115480f34e5a78879408819eff0a6b5f3a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531007 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642146} .../renderer/core/paint/paint_layer_painter.cc | 14 ++++---- .../acquire-on-composited-layer-expected.html | 3 ++ .../acquire-on-composited-layer.html | 37 ++++++++++++++++++++++ 3 files changed, 47 insertions(+), 7 deletions(-) commit 04c2389a9c5fde4067d2951d09bb99a562dc2664 Author: Lily Chen <chlily@chromium.org> Date: Tue Mar 19 20:09:33 2019 +0000 SQLitePersistentReportingAndNELStore: Change timestamps to microseconds This changes the times stored in the database from milliseconds since Windows epoch, to microseconds since Windows epoch, in order to be more consistent with how times are stored in other places. Bug: 895821 Change-Id: I0de9f3c7d387a514d53b43531d0ce7786deb46ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531160 Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#642145} .../sqlite_persistent_reporting_and_nel_store.cc | 40 +++++++++++----------- ..._persistent_reporting_and_nel_store_unittest.cc | 12 +++---- 2 files changed, 26 insertions(+), 26 deletions(-) commit 60db5c7bc98bfa9193d43e67a00184b3e6fe0282 Author: Bailey Berro <baileyberro@chromium.org> Date: Tue Mar 19 20:08:27 2019 +0000 cups_printing: Open CUPS printing help page from error toast - Fixes bug where "Get Help" button on printing error toast did not do anything. Bug: 900626 Change-Id: Ic49549e0d0f1c012c287a9e63d9b4b162ee502d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529389 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Auto-Submit: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#642144} .../chromeos/printing/cups_print_job_notification.cc | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) commit 23b36028c7cfbd3eabf9954a419235de9b34b76d Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Mar 19 20:02:31 2019 +0000 [vr] Add GVR's LegacyVrParamsProvider We have seen a number of crashes that are due to that class not being available. Bug: 913413 Change-Id: I59e0e2e22bc0f5ada1aaf47d4271816cd010bd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531110 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#642143} third_party/gvr-android-sdk/BUILD.gn | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e2f5b4576854be85ff585277deeb38d63a52d369 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 19:54:42 2019 +0000 Roll src/third_party/angle 9b050f846a06..4bcba62aba7b (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/9b050f846a06..4bcba62aba7b git log 9b050f846a06..4bcba62aba7b --date=short --no-merges --format='%ad %ae %s' 2019-03-19 jonahr@google.com Add Android device name, version, manufacturer to gpu_info_util Created with: gclient setdep -r src/third_party/angle@4bcba62aba7b The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I6a65131036f6340941d5c22797570ec58cfea47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530168 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642142} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b50f4d18b0b0cffed6612eed2505260f4e9768d9 Author: Lan Wei <lanwei@chromium.org> Date: Tue Mar 19 19:52:19 2019 +0000 Rename updating hover without timer related flags There are two flags we need to update hover without timer, one is to update hover after scroll ends, the other one is to update hover after layout changes at the begin frame. Bug: 877132 Change-Id: I216b82d9e238b5dcc1444665dfa01f73a9f17bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526812 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#642141} content/child/runtime_features.cc | 10 ++++++---- .../blink/public/platform/web_runtime_features.h | 6 ++++-- .../blink/renderer/core/exported/web_view_impl.cc | 2 +- third_party/blink/renderer/core/input/event_handler.cc | 2 +- .../blink/renderer/core/input/event_handler_test.cc | 2 +- .../blink/renderer/core/input/mouse_event_manager.cc | 5 +++-- .../blink/renderer/core/input/scroll_manager.cc | 2 +- .../renderer/platform/exported/web_runtime_features.cc | 18 ++++++++++-------- .../renderer/platform/runtime_enabled_features.json5 | 16 ++++++++-------- .../no-mouse-cursor-update-after-layout-change.html | 2 +- .../events/no_hover_update_after_layout_change.html | 4 ++-- .../fast/scrolling/no-hover-during-scroll.html | 2 +- ui/events/blink/blink_features.cc | 9 +++++---- ui/events/blink/blink_features.h | 4 ++-- 14 files changed, 46 insertions(+), 38 deletions(-) commit eb7762a96018b9424e216034ab6c2e7825d6b10d Author: Ben Kelly <wanderview@chromium.org> Date: Tue Mar 19 19:50:56 2019 +0000 CacheStorage: Fix tracing id bit mask. Bug: 927538 Change-Id: I166ccaa795736e96127aa2dc0526b2650cfeb0ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526464 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642140} third_party/blink/common/cache_storage/cache_storage_utils.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f944c0d1894f675b3d779723528b6211a6784400 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 19:48:49 2019 +0000 Migrate FileSystemCallbacks to use simple success/failure callbacks This CL is a continuation of the effort to simplify the callbacks implementation in t_p/b/renderer/modules/filesystem/file_system_callbacks.h At this time, FileSystemCallbacks wrapper class is migrated to use simple (BindOnce) callbacks, one for success, another for failure. R=mek@chromium.org CC=dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: I8fae7534be65f992b8b2c5a47cc08a6ab1192502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529470 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#642139} .../modules/filesystem/async_callback_helper.h | 1 + .../renderer/modules/filesystem/dom_file_system.cc | 5 +++ .../renderer/modules/filesystem/dom_file_system.h | 3 ++ .../modules/filesystem/dom_window_file_system.cc | 13 +++--- .../modules/filesystem/file_system_callbacks.cc | 47 +++++----------------- .../modules/filesystem/file_system_callbacks.h | 40 +++++------------- .../filesystem/file_system_directory_handle.cc | 9 +++-- .../filesystem/worker_global_scope_file_system.cc | 23 ++++++++--- 8 files changed, 62 insertions(+), 79 deletions(-) commit 0e6d6bf816c17b290e3fb56f7abb50f7034d2a73 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 19 19:47:45 2019 +0000 gpu: Invalidate channel map first to fix reentracy issues Clearing the channel map in DestroyAllChannels can re-enter into GpuChannelManager via LoseAllContexts from ~GpuChannel causing a use-after-free crash. Bug: 942954 Change-Id: Iaf5f64ec3f96f2b5948cd6080c701c1107bd5b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529342 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#642138} gpu/ipc/service/gpu_channel_manager.cc | 4 ++++ 1 file changed, 4 insertions(+) commit 67140f6cd8a5c4b035727b6bebf591cc5d77f6fc Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Tue Mar 19 19:47:20 2019 +0000 Add temporary CHECK for debugging Bug: 890227 Change-Id: I92bbe90024245fde91a977402f950909f2e8b00a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529690 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#642137} gpu/ipc/service/direct_composition_surface_win.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 64ca4aaa30ed664a2612824d3fbe1aaf0479b3ee Author: Livvie Lin <livvielin@chromium.org> Date: Tue Mar 19 19:46:04 2019 +0000 Change security style for HTTP and secure origins Insecure origins in the sidebar will now show a red triangle icon rather than a red circle. Some HTTP origins, specifically for optionally blockable mixed content, still show a red circle (will be updated in a follow-up cl). Secure origins will now show the secure (green square) style. Bug: 936669 Change-Id: I10efe286029379bbadbbb8c309b64eb706b8851c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496521 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#642136} .../browser/devtools/protocol/network_handler.cc | 10 ++++- content/renderer/loader/web_url_loader_impl.cc | 8 +++- .../devtools/front_end/security/SecurityPanel.js | 7 ++++ ...iew-noncryptographic-secure-origin-expected.txt | 43 ++++++++++++++++++++++ .../origin-view-noncryptographic-secure-origin.js | 21 +++++++++++ .../origin-view-then-interstitial-expected.txt | 6 +-- .../security/origin-view-then-interstitial.js | 6 +-- 7 files changed, 92 insertions(+), 9 deletions(-) commit b25cc86db66c4d1bd0462d54ec8aadaa60c6c9b1 Author: Xiaoqian Dai <xdai@chromium.org> Date: Tue Mar 19 19:44:05 2019 +0000 Remove "DragTabsInTabletMode" feature flag. The feature has been launched for a while. Bug: 823769 Change-Id: I240838fb5382a9f73d30b08204736cd8d87696f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529584 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642135} ash/public/cpp/ash_features.cc | 3 --- ash/public/cpp/ash_features.h | 5 ----- chrome/browser/ui/views/tabs/tab_drag_controller.cc | 16 +++------------- 3 files changed, 3 insertions(+), 21 deletions(-) commit fbfbd7a65b0397a9979a307f5d189270ac6b3f8b Author: Erik Chen <erikchen@chromium.org> Date: Tue Mar 19 19:39:28 2019 +0000 Add bsep and tbergquist as OWNERS of chrome/browser/ui/tabs. Change-Id: I0a72db0eb8d7e6349f543760da89391e1c1c9d48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529586 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#642134} chrome/browser/ui/tabs/OWNERS | 2 ++ 1 file changed, 2 insertions(+) commit 3c26f82483274f75b32bc7b88368b1ebfc4694a2 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 19:36:30 2019 +0000 Migrate EntryCallbacks to use simple success/failure callbacks This CL is a continuation of the effort to simplify the callbacks implementation in t_p/b/renderer/modules/filesystem/file_system_callbacks.h At this time, EntryCallbacks wrapper classes are migrated to use simple (BindOnce) callbacks, one for success, another for failure. R=mek@chromium.org CC=dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: I1591aed86ea379a511f985534b914cd1797911d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528394 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#642133} .../modules/filesystem/async_callback_helper.h | 24 +++++++- .../renderer/modules/filesystem/directory_entry.cc | 25 +++++--- .../modules/filesystem/directory_entry_sync.cc | 25 ++++++-- .../renderer/modules/filesystem/dom_file_system.cc | 14 +++++ .../renderer/modules/filesystem/dom_file_system.h | 4 ++ .../modules/filesystem/dom_file_system_base.cc | 69 ++++++++++++---------- .../modules/filesystem/dom_file_system_base.h | 23 ++++---- .../modules/filesystem/dom_file_system_sync.cc | 5 ++ .../modules/filesystem/dom_file_system_sync.h | 1 + .../modules/filesystem/dom_window_file_system.cc | 19 +++--- .../blink/renderer/modules/filesystem/entry.cc | 34 +++++++---- .../renderer/modules/filesystem/entry_sync.cc | 22 +++++-- .../modules/filesystem/file_system_base_handle.cc | 34 +++++++---- .../modules/filesystem/file_system_callbacks.cc | 27 +++------ .../modules/filesystem/file_system_callbacks.h | 23 ++++---- .../filesystem/file_system_directory_handle.cc | 24 +++++--- 16 files changed, 243 insertions(+), 130 deletions(-) commit 787ecc9dac9b8cadd25e474ffb51bca7051b61ab Author: John Williams <jrw@google.com> Date: Tue Mar 19 19:34:43 2019 +0000 [Cast MRP] Implement PresentationConnection close. When Cast MRP receives a DidClose() call from a PresentationConnection in a controlling frame in Blink, it will remove the associated client from the ongoing Cast activity. This replaces the MediaRouteProvider::DetachRoute() API. Also updated the CloseConnection() call to use DidClose instead of DidChangeState, as calling the latter with CLOSED will result in DCHECK. Bug: 809249 Change-Id: I05c2bd447b3cc0ffe2f773bed41dc2cf618cf537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1432672 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642132} .../router/providers/cast/cast_activity_manager.cc | 64 +++++++++++++--------- .../router/providers/cast/cast_activity_manager.h | 4 ++ .../cast/cast_activity_manager_unittest.cc | 5 +- .../providers/cast/cast_internal_message_util.h | 3 + .../providers/cast/cast_media_route_provider.cc | 4 ++ 5 files changed, 52 insertions(+), 28 deletions(-) commit fe66e1a32cbc08e2f5dd18b3190aba2bdf2f2536 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Tue Mar 19 19:29:44 2019 +0000 Roll src/tools/swarming_client/ 7a61cf37d..aa60736ad (3 commits) https://chromium.googlesource.com/infra/luci/client-py.git/+log/7a61cf37d6a0..aa60736aded9 $ git log 7a61cf37d..aa60736ad --date=short --no-merges --format='%ad %ae %s' 2019-03-14 iannucci [libs/logdog] Small tweaks and add fileno to BasicStream. 2019-03-14 maruel [client] Delete run_isolated.zip support 2019-03-04 iannucci [logdog_client] Add $LOGDOG_NAMESPACE to allow transparent logdog client nesting. Created with: roll-dep src/tools/swarming_client R=jchinlee@chromium.org Change-Id: If46f4b2d551a783acd10371e1c542be2dbfd805a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529665 Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642131} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6d5ade6542f4d07feb03dbb8dc78b9214d11e38c Author: Tibor Goldschwendt <tiborg@chromium.org> Date: Tue Mar 19 19:24:32 2019 +0000 [modules] Add autogenerated module class Bug: 925528 Change-Id: I144839685ad4246cec990b8289fbdac9144286e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515608 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642130} chrome/android/BUILD.gn | 2 + .../chrome/browser/vr/VrDelegateFallback.java | 4 +- .../chrome/browser/vr/VrDelegateProvider.java | 3 + .../chrome/browser/vr/VrDelegateProviderImpl.java | 2 +- .../chrome/browser/vr/VrModuleProvider.java | 29 ++--- components/module_installer/android/BUILD.gn | 18 +++ .../components/module_installer/Module.java | 77 ++++++++++++ .../module_installer/ModuleInterface.java | 23 ++++ .../module_installer/ModuleInterfaceProcessor.java | 135 +++++++++++++++++++++ 9 files changed, 269 insertions(+), 24 deletions(-) commit 0924270eeaf293d4304db5cc5fdcd04168988d35 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Tue Mar 19 19:22:56 2019 +0000 [Autofill Assistant] PR ScrollView now plays nicely with bottom bar children. Before this change, the Payment Request ScrollView would occupy as much space as possible and would thus hide the carousel. This is because the ScrollView was not a sibling of the carousel and the other bottom bar children. This CL ensures that the AssistantPaymentRequestCoordinator view is the FadingEdgeScrollView that was used in PR. This means that the whole UI view is now scrollable (including Terms & Conditions and the privacy notice). Screenshots: - Before: https://screenshot.googleplex.com/REcUPgHMB1O.png - After: https://screenshot.googleplex.com/OnGWK6soYmb.png Bug: b/128673525 Change-Id: Id035897a6638c85207e5d3c9ce8c6cca936f87da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530764 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#642129} .../layout/autofill_assistant_payment_request.xml | 26 +++++++--------------- .../AssistantPaymentRequestCoordinator.java | 14 ++++++++++-- .../payment/PaymentRequestUI.java | 17 +++++--------- 3 files changed, 25 insertions(+), 32 deletions(-) commit d1f53769a890a25b0f9dafb85700ac32c5883380 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Tue Mar 19 19:22:49 2019 +0000 Revert "WS: CrashInFlightChange dump window name and location" This reverts commit fca3ec75eaa93b7d613618a6006f95168ee920f8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 642114 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ZjYTNlYzc1ZWFhOTNiN2Q2MTM2MThhNjAwNmY5NTE2OGVlOTIwZjgM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Fuchsia%20ARM64/61125 Sample Failed Step: compile Original change's description: > WS: CrashInFlightChange dump window name and location > > Dump window name and CrashInFlightChange creation site with > the fatal log. > > Bug: 940620 > Change-Id: I4645986a47a1c495b3279bc2fa07d24487ccda89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529691 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642114} Change-Id: I0acf34f8aa460f82b935f8c196fa0ffc3396a480 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 940620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531119 Cr-Commit-Position: refs/heads/master@{#642128} ui/aura/mus/in_flight_change.cc | 21 ++++---------- ui/aura/mus/in_flight_change.h | 7 +---- ui/aura/mus/window_tree_client.cc | 45 ++++++++++++------------------ ui/aura/mus/window_tree_client_unittest.cc | 29 ------------------- 4 files changed, 25 insertions(+), 77 deletions(-) commit 37511ad65414d7d7fd43d4620bc2f7fb91e8b2be Author: Andrew Luo <aluo@chromium.org> Date: Tue Mar 19 19:15:58 2019 +0000 Use webview provider for shell layout and ui webview tests. This prepares the way to switch webview test bots to use swarmed devices. Bug: 814405 Change-Id: Ic6c1f2b713392b3ed80b26dae1a5571de648914d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526809 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642127} android_webview/tools/automated_ui_tests/BUILD.gn | 1 + testing/buildbot/gn_isolate_map.pyl | 8 ++++++++ 2 files changed, 9 insertions(+) commit 05f9b4c02be51e3bc0881b1e6d7039cc5f4707a2 Author: Allison Pastewka <alpastew@microsoft.com> Date: Tue Mar 19 19:15:17 2019 +0000 Eliminated remaining uses of [LegacyInterfaceTypeChecking] Removed [LegacyInterfaceTypeChecking] from the two remaining idls, RTCPeerConnection-getStats and FormData. Updated the relevant tests to match the new behavior. Seeing as how [LegacyInterfaceTypeChecking] is no longer being used, I removed the extended attribute from IDLExtendedAttributes.md and IDLExtendedAttributes.txt. Bug: 561338 Change-Id: I4783348f485932f08c86ddb58efb6cb713fd5fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507237 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Reviewed-by: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Allison Pastewka <alpastew@microsoft.com> Cr-Commit-Position: refs/heads/master@{#642126} .../renderer/bindings/IDLExtendedAttributes.md | 1 - .../renderer/bindings/IDLExtendedAttributes.txt | 1 - .../renderer/bindings/scripts/v8_attributes.py | 9 +- .../renderer/bindings/scripts/v8_interface.py | 8 +- .../blink/renderer/bindings/scripts/v8_methods.py | 8 +- .../renderer/bindings/scripts/v8_utilities.py | 6 - .../bindings/tests/idls/core/test_interface.idl | 3 - .../bindings/tests/idls/core/test_object.idl | 6 - .../tests/results/core/v8_test_interface.cc | 61 ------ .../tests/results/core/v8_test_interface.h | 3 - .../bindings/tests/results/core/v8_test_object.cc | 223 --------------------- .../bindings/tests/results/core/v8_test_object.h | 10 - .../blink/renderer/core/html/forms/form_data.cc | 4 - .../blink/renderer/core/html/forms/form_data.idl | 6 +- .../modules/peerconnection/rtc_peer_connection.idl | 2 +- .../external/wpt/xhr/FormData-append.html | 8 + .../external/wpt/xhr/formdata-expected.txt | 10 - .../web_tests/external/wpt/xhr/formdata-set.htm | 8 + .../blink/web_tests/external/wpt/xhr/formdata.htm | 2 +- ...RTCPeerConnection-getStats-overrides.https.html | 5 +- .../RTCPeerConnection-stats-expected.txt | 9 - .../peerconnection/RTCPeerConnection-stats.html | 10 +- 22 files changed, 29 insertions(+), 374 deletions(-) commit c5335225660544666a28adf7f05e20d9521929ae Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Mar 19 19:13:17 2019 +0000 Disable flaky test on mac No-Try: True Tbr: mmentovai Bug: 943669 Change-Id: Iee3cbda469cbdeab7e542bcd566adbb45c0388ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531280 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#642125} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit e237674c1a6b1e33171eb6aafd66eec775bff618 Author: Karolina Soltys <ksolt@chromium.org> Date: Tue Mar 19 19:09:38 2019 +0000 [scheduler] Ui thread task posting API changes. As part of an ongoing effort to migrate all Java task posting to PostTask, we are deprecating the alternative methods used at the moment and providing PostTask-based alternatives. We are also providing a workaround for call sites which can't import content. In order for this to work, we are adding ThreadUtils initialisation to an early stage in the initialisation of Chrome. Bug: 863341 Change-Id: Ie1594a36803dd3b43480098a24e6fbd3e34c5c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518513 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642124} .../java/src/org/chromium/base/ThreadUtils.java | 53 ++++++++ .../java/src/org/chromium/base/task/PostTask.java | 34 +++++ content/public/android/BUILD.gn | 2 - .../content/browser/BrowserThreadUtilsImpl.java | 148 --------------------- .../content_public/browser/BrowserThreadUtils.java | 109 --------------- .../browser/scheduler/UiThreadSchedulerTest.java | 18 +++ .../browser/test/util/TestThreadUtils.java | 8 +- 7 files changed, 109 insertions(+), 263 deletions(-) commit 22bfe6006e3fa913d6d9b0b09261218d979249c3 Author: rajendrant <rajendrant@chromium.org> Date: Tue Mar 19 19:08:28 2019 +0000 Fix tests that change ECT to use feature params NQE has been converted to a feature in the below CL. So use that for the tests. http://crrev.com/c/1516433 Bug: 940943 Change-Id: Ib9a8c810fea23a63e7f119c474936afeb95037d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531100 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#642123} tools/chrome_proxy/webdriver/lite_page.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit 178dc2bcb8d531664d774d662ba7c15e2662332c Author: Tim Volodine <timvolodine@chromium.org> Date: Tue Mar 19 19:07:22 2019 +0000 [AW NS] Update WATCHLIST with android_webview_network_service Create android_webview_network_service watchlist and add myself. This watches network service specific files for android webview. BUG=841556 TBR=tobiasjs@chromium.org Change-Id: Iceb146e4aabed205ca8998910573ef65321c2006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530904 Reviewed-by: Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#642122} WATCHLISTS | 4 ++++ 1 file changed, 4 insertions(+) commit d66fa340bef0110a8ded284168169c633d8bebb7 Author: danakj <danakj@chromium.org> Date: Tue Mar 19 19:06:37 2019 +0000 Check that mainframes don't fail to be swapped in. There's no error reporting to the browser if this happened and then they would disagree on the state of the RenderFrame. R=dcheng@chromium.org Bug: 939262 Change-Id: I73d0bfa7a8e89424820d396d04c7c2af7e3bc7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529620 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642121} content/renderer/render_frame_impl.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit 4b5aca3cb861662fc0ec73815ddd1215e7bcadfc Author: Ian Prest <iapres@microsoft.com> Date: Tue Mar 19 19:05:02 2019 +0000 UIA: Re-enable event tests A recent change to the AccessibilityTreeFormatter changed the filename pattern for UIA test expectation files (from "-win-uia.txt" to "-uia-win.txt"). However, the change didn't rename the expectation files for *event* tests, so the event tests were inadvertantly disabled. 1. Renamed the event-test expectation files to match the new pattern. -- Similarly, change any filter rules (@WIN-DENY, etc.) in the HTML files to match the new pattern. 2. This exposed a crash in the AccessibilityTreeFormatter on Win7 since we are now dumping some new trees. -- We were requesting *all* properties, and UIA on Win7 was crashing when requesting `LegacyIAccessibleSelection` (on a <SELECT> element). -- The solution is to request only a subset of all properties. -- The list currently contains *all* properties, except (1) properties like `ProcessId` and `RuntimeId`, which are system specific and shouldn't be in a dump file; and (2) the `LegacyIAccessible` properties, which are proven problematic on Win7 and which we don't expose anyway. -- Also removed were properties that are going to be dumped as part of a pattern (see CL:1521468). 3. A few expectation files needed to be remastered, having diverged slightly during the time the tests were disabled. Bug: 928949 Change-Id: I1aa42a9b42882b368ef590035ea926b106c3712c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518411 Commit-Queue: Ian Prest <iapres@microsoft.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#642120} .../accessibility_tree_formatter_uia_win.cc | 167 ++++++++++++++++++++- .../accessibility_tree_formatter_uia_win.h | 3 +- ...-win-uia.txt => add-alert-expected-uia-win.txt} | 0 .../test/data/accessibility/event/add-alert.html | 3 +- ...> aria-combo-box-collapse-expected-uia-win.txt} | 0 ...-combo-box-delay-add-list-expected-uia-win.txt} | 0 .../aria-combo-box-expand-expected-uia-win.txt | 2 + ...t => aria-combo-box-focus-expected-uia-win.txt} | 0 .../aria-combo-box-focus-expected-win-uia.txt | 1 - .../event/aria-combo-box-next-expected-uia-win.txt | 2 + .../event/aria-combo-box-next-expected-win-uia.txt | 1 - ...-uia.txt => listbox-focus-expected-uia-win.txt} | 0 .../event/listbox-next-expected-uia-win.txt | 2 + .../event/listbox-next-expected-win-uia.txt | 1 - .../event/listbox-next-expected-win.txt | 2 +- ...uia.txt => menulist-focus-expected-uia-win.txt} | 0 ...rt-validity-invalid-field-expected-uia-win.txt} | 0 .../event/report-validity-invalid-field.html | 3 +- ...in-uia.txt => tbody-focus-expected-uia-win.txt} | 0 ...in-uia.txt => tfoot-focus-expected-uia-win.txt} | 0 ...in-uia.txt => thead-focus-expected-uia-win.txt} | 0 21 files changed, 176 insertions(+), 11 deletions(-) commit b7cc89dae3bb683f5eaa3bd6c5bd56522f4eaa06 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 19:03:24 2019 +0000 Roll src/third_party/perfetto 69d721a1be6d..21ad4d87826e (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/69d721a1be6d..21ad4d87826e git log 69d721a1be6d..21ad4d87826e --date=short --no-merges --format='%ad %ae %s' 2019-03-19 fmayer@google.com Merge "Make Android tests happy" Created with: gclient setdep -r src/third_party/perfetto@21ad4d87826e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0f90285613ef3e86f5260e2acf34c640109a7298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530157 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642119} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 840358c8c01458b86e65745831da23d84b72375b Author: Ryan Hamilton <rch@chromium.org> Date: Tue Mar 19 19:00:35 2019 +0000 Roll src/net/third_party/quiche/src/ f08778a58..d5d13c2a8 (20 commits) https://quiche.googlesource.com/quiche.git/+log/f08778a58e71..d5d13c2a81b5 $ git log f08778a58..d5d13c2a8 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 rch Use std::string instead of string in a few places in QUIC to permit chrome merge. 2019-03-18 quiche-dev Add a Context class to simplify ProcessClientHello 2019-03-18 quiche-dev Change some methods in QuicSpdyStream from public to protected. 2019-03-17 quiche-dev gfe-relnote: In QUIC, validate packet number post decryption. Protected by quic_validate_packet_number_post_decryption. 2019-03-16 bnc Improve handing of frames with empty payload in HttpDecoder. 2019-03-15 quiche-dev Rename ENCRYPTION_NONE to ENCRYPTION_INITIAL 2019-03-15 quiche-dev Remove an unused argument 2019-03-15 quiche-dev Make ClientDemandsX509Proof a free function 2019-03-15 quiche-dev gfe-relnote: In QUIC, put packet number validation in a standalone function. No functional refactoring change. Not protected. 2019-03-15 quiche-dev gfe-relnote: In QUIC, add unused HANDSHAKE encryption level. No functional change expected, not protected. 2019-03-15 quiche-dev Remove an unused asynchronous jump 2019-03-15 quiche-dev Make CryptoUtils::HashHandshakeMessage return by value 2019-03-14 quiche-dev Uniquify QuicCryptoServerConfig::Add[Default]Config 2019-03-14 quiche-dev Remove unused arguments 2019-03-14 quiche-dev Allow variable length connection IDs in v99 2019-03-14 bnc Minor QuicSimpleServerSessionServerPushTest refactor. 2019-03-14 quiche-dev Split KeyExchange into synchronous and asynchronous variants 2019-03-14 quiche-dev Uniquify ChannelIDSource handling 2019-03-14 quiche-dev Fix a msan error because of uninitialized test diversification nonce. 2019-03-14 quiche-dev Convert CryptoFramer::ConstructHandshakeMessage to return unique_ptr Created with: roll-dep src/net/third_party/quiche/src Roll src/third_party/quic_trace/src/ fe1b25874..9aaca5b48 (22 commits) https://chromium.googlesource.com/external/github.com/google/quic-trace.git/+log/fe1b2587410c..9aaca5b4862a $ git log fe1b25874..9aaca5b48 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 rch In QUIC, add unused HANDSHAKE encryption level. 2019-03-13 vasilvv Update quic_trace to use a more recent version of protobuf 2019-02-20 jri.ietf Show offsets for STREAM frames 2019-01-10 vasilvv Add missing dependencies 2019-01-10 vasilvv Migrate quic_trace to use Swisstable 2019-01-09 vasilvv Sort events in the trace before processing it 2018-12-28 vasilvv Reduce the nesting in the code by reordering clauses 2018-12-12 vasilvv Add a support for JSON representation of the trace. 2018-10-30 vasilvv Update glew code 2018-08-25 vasilvv Add fields to mark TLPs and RTOs 2018-09-10 vasilvv Update documentation and add an example trace (#4) 2018-09-10 vasilvv Add high-DPI support for Linux and OS X 2018-09-06 vasilvv Clean up the logic for rescaling the trace 2018-09-07 vasilvv Add support for Mac OS X 2018-09-07 vasilvv Minor C++ cleanups required to build the renderer on OS X 2018-09-07 vasilvv Ensure trace renderer is compatible with OpenGL 3.3 core 2018-09-05 vasilvv Make freetype statically linked 2018-09-05 vasilvv Fix GL_KHR_debug feature check 2018-09-05 vasilvv Add .gitignore 2018-09-05 vasilvv Remove a leftover LOG line that's normally not useful 2018-09-05 vasilvv Make certain implicit dependencies explicit 2018-09-05 vasilvv Initial export of OpenGL-based QUIC trace renderer Created with: roll-dep src/third_party/quic_trace/src Change-Id: I287edfd9be3c002d16f9db4e709af19828475edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529635 Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#642118} DEPS | 4 ++-- net/BUILD.gn | 1 + net/quic/quic_chromium_client_session_test.cc | 2 +- net/quic/quic_flags_list.h | 5 +++++ net/quic/quic_test_packet_maker.cc | 14 +++++++------- 5 files changed, 16 insertions(+), 10 deletions(-) commit cf2872d7b1fa6c0132ea9917ddf78efc4ff4bc54 Author: Robert Ogden <robertogden@chromium.org> Date: Tue Mar 19 18:59:37 2019 +0000 Consolidate usage of prefs::kDataSaverEnabled in CCBC One of several CLs to clean up usage of this pref. Bug: 934399 Change-Id: Iec7f2f5fe250ae37af8082537069a5312106dc78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529660 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#642117} chrome/browser/chrome_content_browser_client.cc | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) commit d7f6fea29f1c5396b3b171bbf40318e4152fac14 Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 18:59:11 2019 +0000 Add templates to share file system callbacks implementations This is a follow up CL of crrev.com/c/1525102 that aims at sharing the same template functions among most of the wrapper callback classes in t_p/b/renderer/modules/filesystem/file_system_callbacks.h. There will still be need for other helper template functions, eg for promises, but those will be added on demand (see crrev.com/c/1528394). R=mek@chromium.org CC=​​dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: Id0bced0c7ea71984b5e2b1d162cc21be891e1ca3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528391 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#642116} .../blink/renderer/modules/filesystem/BUILD.gn | 1 + .../modules/filesystem/async_callback_helper.h | 53 ++++++++++++++++++++++ .../blink/renderer/modules/filesystem/entry.cc | 24 ++-------- 3 files changed, 59 insertions(+), 19 deletions(-) commit 1dc5707c53559c476c455b993c2704107e71bf47 Author: dpapad <dpapad@chromium.org> Date: Tue Mar 19 18:58:30 2019 +0000 WebUI cleanup: Remove i18n_template.js from Desktop builds. This file is no longer used anywhere else other than ChromeOS. Also delete IDR_WEBUI_JS_I18N_TEMPLATE_PROCESS from webui_resources.grd since this file is already inlined with GRIT in the only place where it is used. display "This site can’t be reached" Bug: 677338 Test: Visit chrome://resources/js/i18n_template.js on Desktop. Should Change-Id: I7fca116e356611d87c049a4a1832d46f9a24783c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525465 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#642115} android_webview/ui/grit_resources_whitelist.txt | 1 - ui/webui/resources/webui_resources.grd | 7 +++---- 2 files changed, 3 insertions(+), 5 deletions(-) commit fca3ec75eaa93b7d613618a6006f95168ee920f8 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Mar 19 18:57:43 2019 +0000 WS: CrashInFlightChange dump window name and location Dump window name and CrashInFlightChange creation site with the fatal log. Bug: 940620 Change-Id: I4645986a47a1c495b3279bc2fa07d24487ccda89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529691 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642114} ui/aura/mus/in_flight_change.cc | 21 ++++++++++---- ui/aura/mus/in_flight_change.h | 7 ++++- ui/aura/mus/window_tree_client.cc | 45 ++++++++++++++++++------------ ui/aura/mus/window_tree_client_unittest.cc | 29 +++++++++++++++++++ 4 files changed, 77 insertions(+), 25 deletions(-) commit d6fb7b395023c734d2c37d2147ed76a5d19f1041 Author: Geoff Lang <geofflang@chromium.org> Date: Tue Mar 19 18:56:46 2019 +0000 Fix issues with shadow buffer readback in the passthrough decoder. - Buffers were read back using the client ID instead of service ID. - Buffer ID was not validated in SetReadbackBufferShadowAllocationINTERNAL - Pending readbacks were not removed on buffer deletion once they were already associated with a query. BUG=941930 Change-Id: I6220cd0f96be23113dd0e9bd6dc56dee8e49a137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525996 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#642113} .../service/gles2_cmd_decoder_passthrough.cc | 14 +++++++++++++- .../service/gles2_cmd_decoder_passthrough_doers.cc | 9 +++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) commit 73fa2b382ee2b2c3b29cbba9194d19cf372cdb26 Author: Lan Wei <lanwei@chromium.org> Date: Tue Mar 19 18:56:37 2019 +0000 [wpt] Fix actionsWithKeyPressed.html.ini actionsWithKeyPressed.html test does not work on both Firefox and Safari, so I change actionsWithKeyPressed.html.ini to skip both browsers. Bug: chromedriver:1897 Change-Id: I86fb1507cf86f2fe209414615b8ea73834456202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529624 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#642112} .../infrastructure/testdriver/actions/actionsWithKeyPressed.html.ini | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3dab6e44bca75848bd78be1482e717e49c08dfc7 Author: danakj <danakj@chromium.org> Date: Tue Mar 19 18:55:38 2019 +0000 Check that mainframes don't fail to be swapped out. When this fails the proxy is deleted but the RenderFrame of the speculative frame would be left in a shutting down state would not delete the RenderFrame in the renderer. R=dcheng@chromium.org Bug: 939262 Change-Id: I38947b3471a2ba510d59f6132d286376473ba787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529165 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642111} content/renderer/render_frame_impl.cc | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) commit 4230b400e564fe3d1578721216231bec7bb6de7d Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 19 18:55:34 2019 +0000 Update V8 to version 7.5.72. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7d2a2a23..93306f1d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7d36dee3652f90e5f03f030143ee699cab1c88e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531000 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642110} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4aa582bf9250d069c855aa1101a9056426a4d2eb Author: Reilly Grant <reillyg@chromium.org> Date: Tue Mar 19 18:52:24 2019 +0000 [sensors] Add fallback for linear accelerometer on Android This changes adds a sensor fusion fallback on Android when there is no platform sensor for TYPE_LINEAR_ACCELEROMETER but TYPE_ACCELEROMETER is still available. Bug: 943275 Change-Id: I29fb26e10338b6956e5f331346f39ec119781187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529671 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642109} services/device/generic_sensor/README.md | 6 ++++- .../platform_sensor_provider_android.cc | 31 ++++++++++++++++++++++ .../platform_sensor_provider_android.h | 3 +++ 3 files changed, 39 insertions(+), 1 deletion(-) commit 4a5fd8a10c9be47c4fea6187998f74ce5a2f96d9 Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 18:52:02 2019 +0000 PeopleHandler: Also SetSyncRequested when confirming Sync Typically SyncRequested is already set at this point, but if a dashboard reset happened while the settings page was open, then it was cleared in the meantime. (That's a more likely situation than it might seem, because the Sync dashboard is linked from the settings page.) If we don't SetSyncRequested in this case, then Sync won't actually become active again, even though the user just pressed "Confirm". It would only become active once they open the settings again. This is only relevant for situations where sign-out isn't possible, i.e. on ChromeOS or for managed (enterprise) users on desktop, since otherwise a dashboard reset also signs out the user. Bug: 936886 Change-Id: I196c3471176b3a958ad7e6b60751e558dd5dd740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530765 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#642108} chrome/browser/ui/webui/settings/people_handler.cc | 16 ++- chrome/browser/ui/webui/settings/people_handler.h | 4 + .../ui/webui/settings/people_handler_unittest.cc | 122 ++++++++++++++++++++- 3 files changed, 140 insertions(+), 2 deletions(-) commit 05d92ba683b38d95a51d7fba8f58d9dfe7584c2f Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Mar 19 18:51:18 2019 +0000 [Tab Groups] Do not call RemoveFromGroup before adding tabs to groups. To support crrev.com/c/1476146, this patch removes calls to RemoveFromGroup from AddToNewGroup and AddToExistingGroup. This will allow the eventual TabStripModelChange::Delta to contain both the old group and the new group by giving MoveTabsIntoGroup enough context to populate those fields. Also moves MoveTabsIntoGroup, UngroupTab, and SetTabsPinned to be in the same order as in the header file. Bug: 905491 Change-Id: I87afbcd7710cb3245ae06631c00e7d835f30435c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526741 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#642107} chrome/browser/ui/tabs/tab_strip_model.cc | 205 +++++++++++---------- chrome/browser/ui/tabs/tab_strip_model.h | 14 +- chrome/browser/ui/tabs/tab_strip_model_unittest.cc | 48 +++-- 3 files changed, 150 insertions(+), 117 deletions(-) commit fc09013b02eb912985afcfb3119ca839d700a9f1 Author: khmel@chromium.org <khmel@chromium.org> Date: Tue Mar 19 18:50:58 2019 +0000 app_list: Prevent sending updates over destroyed mojo channel This observes profile deletion prevents communication over AppListController. ChromeAppListModelUpdater has longer live scope than AppListClientImpl and using pointers owned by AppListClientImpl is not safe on deletion TEST=Simulate crash condition and make sure app is not loaded. BUG=936665 Change-Id: Ib07861ac8b98a39af7d538659883ddbfe48f7607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529633 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642106} chrome/browser/ui/app_list/app_list_client_impl.cc | 3 +++ chrome/browser/ui/app_list/chrome_app_list_model_updater.cc | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) commit c7f408732775a3d5199ff31f6c59b6f25cf6b68a Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 19 18:48:11 2019 +0000 Enable TLS 1.3 for Chrome extensions. This flips the default and adds "tls1.3" as a supported value of the tlsVersion.{min,max} settings. Bug: 904470 Change-Id: I75b1f777124e764b357bc81c9f4aea8ba53abee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529126 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642105} .../extensions/api/socket/tls_socket_unittest.cc | 48 ++++++++++++++++++---- extensions/browser/api/socket/tcp_socket.cc | 7 +++- extensions/common/api/socket.idl | 3 +- extensions/common/api/sockets_tcp.idl | 3 +- 4 files changed, 50 insertions(+), 11 deletions(-) commit 518b98f4e934f23aec8c3867bb9595d3eb0902b3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 18:43:50 2019 +0000 Roll src/third_party/depot_tools d2b0c2ae17fe..1c21d7cb523d (2 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d2b0c2ae17fe..1c21d7cb523d git log d2b0c2ae17fe..1c21d7cb523d --date=short --no-merges --format='%ad %ae %s' 2019-03-19 tikuta@chromium.org [bot_update] show git protocol version 2019-03-19 raul@tambre.ee Make fetch compatible with Python 3 Created with: gclient setdep -r src/third_party/depot_tools@1c21d7cb523d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:875453,chromium:939847 TBR=agable@chromium.org Change-Id: Id22d321d69c4973c8bee2f4251a09e9a4775e927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530155 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642104} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 43ab8952a0148aa9a82d459bf1ae6664dba389ec Author: Finnur Thorarinsson <finnur@chromium.org> Date: Tue Mar 19 18:43:33 2019 +0000 Photo Picker: Convert filePaths to URIs. (A reland of the original patch, with just a small fix to the test) https://chromium-review.googlesource.com/c/chromium/src/+/1524262 (Original) TBR=twellington Bug: 905257, 656015 Change-Id: Ibe999a7ad65ba531170f8b4c9f2503f5d66bc9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530986 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#642103} .../browser/photo_picker/DecoderServiceHost.java | 65 +++++++++-------- .../browser/photo_picker/FileEnumWorkerTask.java | 85 ++++++++++++---------- .../browser/photo_picker/PhotoPickerDialog.java | 3 +- .../chrome/browser/photo_picker/PickerBitmap.java | 26 ++++--- .../photo_picker/PickerBitmapViewHolder.java | 13 ++-- .../browser/photo_picker/PickerCategoryView.java | 11 +-- .../photo_picker/PhotoPickerDialogTest.java | 25 ++++--- .../src/org/chromium/ui/PhotoPickerListener.java | 3 +- .../src/org/chromium/ui/base/SelectFileDialog.java | 20 +---- 9 files changed, 127 insertions(+), 124 deletions(-) commit 0fe22e7ba699be603148b340d67507644637a825 Author: Charlene Yan <cyan@chromium.org> Date: Tue Mar 19 18:40:45 2019 +0000 Set SHOULD_SHOW_MNEMONICS flags on the 3 Dot Menu Button on the toolbar to show mnemonics on key press. Forgot to set the flag to actually show mnemonics on toolbar_view. Also removing AppMenu::RunFlags enum and using MenuRunner::RunTypes instead. Bug: 928678 Change-Id: I728553016ad1f399fe6f4daffd2cf4043ff8cc36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529752 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#642102} .../ui/views/frame/hosted_app_menu_button.cc | 5 +++-- .../views/media_router/app_menu_test_api_views.cc | 2 +- chrome/browser/ui/views/toolbar/app_menu.cc | 6 +++--- chrome/browser/ui/views/toolbar/app_menu.h | 21 ++++++--------------- .../ui/views/toolbar/browser_app_menu_button.cc | 6 +++--- chrome/browser/ui/views/toolbar/toolbar_view.cc | 4 +++- ui/views/controls/menu/menu_runner.h | 2 ++ 7 files changed, 21 insertions(+), 25 deletions(-) commit ed636210923809b21892c310d06ad9349b05a8a6 Author: Jeremy Klein <jlklein@google.com> Date: Tue Mar 19 18:40:02 2019 +0000 Add the pii-free name to RemoteDevice. Propagating this new field from ExternalDeviceInfo into RemoteDevice and RemoteDeviceRef so that it can be used when populating the UMA proto fields. Bug: b/123091364 Test: Manual and Unit Tests Change-Id: Ifb90abe02958e495e1c2fa91010b04e8ddd16682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530192 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#642101} .../login/easy_unlock/easy_unlock_service_signin_chromeos.cc | 3 ++- .../multidevice/debug_webui/proximity_auth_webui_handler.cc | 3 +++ .../multidevice/debug_webui/resources/proximity_auth.html | 4 ++++ .../multidevice/debug_webui/resources/proximity_auth.js | 2 ++ .../components/multidevice/mojom/multidevice_mojom_traits.cc | 9 +++++++++ .../components/multidevice/mojom/multidevice_mojom_traits.h | 2 ++ .../multidevice/mojom/multidevice_mojom_traits_unittest.cc | 2 ++ chromeos/components/multidevice/mojom/multidevice_types.mojom | 3 +++ chromeos/components/multidevice/remote_device.cc | 3 +++ chromeos/components/multidevice/remote_device.h | 2 ++ chromeos/components/multidevice/remote_device_ref.h | 3 +++ chromeos/components/multidevice/remote_device_ref_unittest.cc | 5 +++-- chromeos/components/multidevice/remote_device_test_util.cc | 10 +++++++++- chromeos/components/multidevice/remote_device_test_util.h | 1 + chromeos/services/device_sync/remote_device_loader.cc | 6 +++--- chromeos/services/device_sync/remote_device_loader_unittest.cc | 5 +++++ 16 files changed, 56 insertions(+), 7 deletions(-) commit 3fa3231e864cdbcd6572e8514f6050c43b28ce7f Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 18:39:33 2019 +0000 Revert "Allow .pydeps files to detect use of vpython" This reverts commit 4585663b43ffb02972f002764c9e8d2bb70ae61a. Reason for revert: Breaking presubmit bots. Original change's description: > Allow .pydeps files to detect use of vpython > > Switches test_runner.py and run_py_tests.py to run using vpython. Their > use of "psutil" makes me think this is necessary (plus the breakage in > bug 930538). > > Bug: 930752, 930538 > Change-Id: Iacdb517aa0fc7c1f799b1cd5105fa16a4c59cd7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464639 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642019} TBR=dpranke@chromium.org,agrieve@chromium.org,jbudorick@chromium.org Change-Id: I8bd6b95aec6e22c0be2152137f4d9db11477c75f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930752, 930538, 943654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531112 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642100} build/android/test_runner.py | 2 +- build/print_python_deps.py | 19 +++++-------------- chrome/test/chromedriver/test/run_py_tests.py | 2 +- 3 files changed, 7 insertions(+), 16 deletions(-) commit 0b691aae54efc55ac98738e484429137ee7df59a Author: Clemens Hammacher <clemensh@chromium.org> Date: Tue Mar 19 18:38:55 2019 +0000 Add "v8.wasm" trace event category This category exists since a long time, but it was never listed in the builtin categories. In the past it showed up eventually anyway, but this seems to have changed. In any case, listing it here provides a better user experience because the category will just always be there. R=ahaas@chromium.org, oysteine@chromium.org Change-Id: I156b00667e2575459c28f412f6921e8d3b5f6a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528535 Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#642099} base/trace_event/builtin_categories.h | 1 + 1 file changed, 1 insertion(+) commit b84c3494d916dcc5fe29dd373231b01a34bccc66 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Tue Mar 19 18:38:27 2019 +0000 Make SimpleKeyedServiceFactory thread safe. crbug.com/701326 is a problem (being worked on) in BrowserContext factories, but Simple factories are not restricted by the preexisting usages in different threads. The DCHECKs can, therefore, just be introduced. There is already an override of GetKeyToUse() which does not perform the check, this CL fixes that and future problems. Change-Id: I160ada8a1edaccd0686794c0d018e768c54d4259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529576 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#642098} components/keyed_service/core/simple_keyed_service_factory.cc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 46d4e277a9da928e57f40a9f5c449fb871e55f9a Author: Koji Ishii <kojii@chromium.org> Date: Tue Mar 19 18:37:13 2019 +0000 [auto] Update FlagExpectations for LayoutNG Following bot results are included. 16857 16860 16868 16875 16880 16891 16902 16911 16921 16932 16938 16944 16948 16952 3 lines were removed and 7 lines were deflaked by consecutive results since 16868. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I0587b135252c0b84cbff7590574f90ce3663411f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524813 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#642097} .../FlagExpectations/enable-blink-features=LayoutNG | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) commit 25b50fc82ed5d17957f6aeacecd711ce3faab175 Author: siyua <siyua@chromium.org> Date: Tue Mar 19 18:36:10 2019 +0000 [Paradise] Add fieldtrial testing config for experiment enabling local card migration flow for non-sync users. Feature flag added here: https://cs.chromium.org/chromium/src/components/autofill/core/common/autofill_features.cc?l=103-107&rcl=39586ceb77b77e4ccc44d77828c52c5e0da3ca31 Bug: 897998 Change-Id: I8679e9fd09779c918b37b81c2040858e124ff835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529521 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#642096} testing/variations/fieldtrial_testing_config.json | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) commit e2bdf317fa7d9558f38413d234e9859f29078a39 Author: Rouslan Solomakhin <rouslan@chromium.org> Date: Tue Mar 19 18:35:49 2019 +0000 [Payment Request][Android] Add back the organization field. Before this patch, the browser payment sheet for W3C Payment Request API did not display the organization field, which is required for the W3C Payment Request spec: https://w3c.github.io/payment-request/#dom-paymentaddress This patch replaces the "show email address" boolean in the address editor with a "purpose" enum with one of three values: - Purpose.PAYMENT_REQUEST: - Show organization, if required by country formatting rules. - Don't show email. - Purpose.AUTOFILL_SETTINGS: - Show organization, if required by country formatting rules and the "autofill company field" feature is enabled. - Show email. - Purpose.AUTOFILL_ASSISTANT: Same rules as the previous (for now). After this patch, the browser payment sheet for W3C Payment Request API shows the organization field. Bug: 941179 Change-Id: Ia08637c8a3da1661244cb84492209ff4f189504d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529357 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by: Ganggui Tang <gogerald@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#642095} .../payment/AutofillAssistantPaymentRequest.java | 5 +- .../chrome/browser/payments/AddressEditor.java | 62 ++++++++++++++-------- .../browser/payments/PaymentRequestImpl.java | 4 +- .../autofill/AutofillProfileEditorPreference.java | 2 +- .../payments/PaymentRequestBillingAddressTest.java | 46 +++++----------- ...ymentRequestBillingAddressWithoutPhoneTest.java | 14 ++--- .../PaymentRequestEmailAndFreeShippingTest.java | 16 ++---- .../payments/PaymentRequestFreeShippingTest.java | 39 ++++---------- ...ncompleteContactDetailsAndFreeShippingTest.java | 31 +++-------- .../payments/PaymentRequestJourneyLoggerTest.java | 15 ++---- .../payments/PaymentRequestNoShippingTest.java | 28 +++------- ...PaymentRequestShippingAddressAndOptionTest.java | 20 ++----- chrome/browser/android/preferences/autofill/OWNERS | 1 + .../autofill/autofill_profile_bridge.cc | 7 +-- 14 files changed, 101 insertions(+), 189 deletions(-) commit 0f4fde4208b2f4e19a7b5d92ee98dfb57873bfda Author: Caleb Rouleau <crouleau@chromium.org> Date: Tue Mar 19 18:35:44 2019 +0000 [Perf Waterfall] Disable reference builds on Mac TBR=jbudorick@chromium.org Bug: 940075 Change-Id: Ibb863ac8c33d0f4057e0df78819893d8c0668d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531106 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#642094} testing/buildbot/chromium.perf.json | 2 -- tools/perf/core/perf_data_generator.py | 8 ++++++-- 2 files changed, 6 insertions(+), 4 deletions(-) commit df31273ec872f5f578b4fe92747c7f663c7154a2 Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 18:34:43 2019 +0000 DevTools: optimize Styles sidebar for reading property values SSP UI changes - Curly brace, Source link color less dark - Source links are more aggressively truncated - "Inherited from" separators have less noise Screenshot: https://imgur.com/a/SwpWkGs Bug: 929536 Change-Id: I43b2252998f7d723b8ec88f0e908e751fe150c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460448 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642093} .../front_end/elements/StylesSidebarPane.js | 7 ++- .../front_end/elements/stylesSidebarPane.css | 29 +++++++----- .../elements/elements-panel-styles-expected.txt | 26 +++++------ ...ate-styles-sidebar-with-arrow-keys-expected.txt | 10 ++--- .../elements/styles-1/commit-selector-expected.txt | 6 +-- .../styles-1/cssom-media-insert-crash-expected.txt | 4 +- ...isable-property-workingcopy-update-expected.txt | 4 +- .../styles-1/dynamic-style-tag-expected.txt | 12 ++--- .../elements/styles-1/edit-media-text-expected.txt | 12 ++--- .../styles-1/empty-background-url-expected.txt | 2 +- .../elements/styles-2/add-import-rule-expected.txt | 4 +- .../cssom-shorthand-important-expected.txt | 2 +- .../styles-2/force-pseudo-state-expected.txt | 8 ++-- .../styles-2/inactive-properties-expected.txt | 4 +- .../inherited-mixed-case-properties-expected.txt | 2 +- .../styles-2/inject-stylesheet-expected.txt | 24 +++++----- .../elements/styles-2/keyframes-rules-expected.txt | 2 +- .../styles-2/lazy-computed-style-expected.txt | 40 ++++++++--------- .../elements/styles-2/media-emulation-expected.txt | 12 ++--- .../elements/styles-2/media-queries-expected.txt | 2 +- .../styles-2/media-using-same-url-expected.txt | 4 +- .../elements/styles-2/parse-comments-expected.txt | 4 +- .../elements/styles-2/parse-utf8-bom-expected.txt | 2 +- ...rm-undo-perform-of-mergable-action-expected.txt | 8 ++-- .../elements/styles-2/pseudo-elements-expected.txt | 8 ++-- .../styles-2/region-style-crash-expected.txt | 4 +- ...omputed-properties-retain-expanded-expected.txt | 8 ++-- .../elements/styles-3/selector-list-expected.txt | 8 ++-- .../styles-3/shadow-dom-rules-expected.txt | 2 +- ...tyle-rule-from-imported-stylesheet-expected.txt | 4 +- .../styles-add-new-rule-to-stylesheet-expected.txt | 2 +- .../styles-3/styles-computed-trace-expected.txt | 52 +++++++++++----------- .../styles-cssom-important-property-expected.txt | 2 +- ...sable-property-after-selector-edit-expected.txt | 2 +- .../styles-3/styles-variables-expected.txt | 22 ++++----- ...s-do-not-detach-sourcemap-on-edits-expected.txt | 12 ++--- ...s-edit-property-after-invalid-rule-expected.txt | 4 +- .../elements/styles-4/styles-iframe-expected.txt | 2 +- .../styles-inherited-same-source-expected.txt | 2 +- .../styles-4/styles-keyframes-expected.txt | 20 ++++----- .../styles-overloaded-shorthand-expected.txt | 6 +-- .../styles-overriden-properties-expected.txt | 6 +-- .../styles-properties-overload-expected.txt | 6 +-- .../styles-4/styles-source-lines-expected.txt | 8 ++-- .../styles-source-lines-inline-expected.txt | 2 +- .../styles-source-lines-recovery-expected.txt | 6 +-- .../styles-4/styles-update-links-1-expected.txt | 28 ++++++------ .../styles-4/styles-update-links-2-expected.txt | 14 +++--- .../styles-4/styles-update-links-3-expected.txt | 14 +++--- .../styles-4/styles-update-links-4-expected.txt | 6 +-- .../styles-4/undo-add-property-expected.txt | 24 +++++----- .../cancel-upon-invalid-property-expected.txt | 4 +- .../styles/selector-line-deprecated-expected.txt | 2 +- .../elements/styles/selector-line-expected.txt | 2 +- ...r-line-sourcemap-header-deprecated-expected.txt | 2 +- .../selector-line-sourcemap-header-expected.txt | 2 +- .../styles/show-all-properties-expected.txt | 4 +- .../styles-parse-invalid-properties-expected.txt | 4 +- .../undo-after-cancelled-editing-expected.txt | 6 +-- .../styles/undo-change-property-expected.txt | 8 ++-- .../styles/undo-set-selector-text-expected.txt | 8 ++-- .../devtools/startup/shadow-dom-rules-expected.txt | 2 +- 62 files changed, 278 insertions(+), 270 deletions(-) commit 5e9ef89acc99c1a10bfc49441da4d4291f1ab038 Author: Robbie McElrath <rmcelrath@chromium.org> Date: Tue Mar 19 18:34:40 2019 +0000 Add rmcelrath to network service OWNERS. Change-Id: I6f9c2a73d5901b15e7a0425b7342dd8076cd1b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529084 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#642092} services/network/OWNERS | 1 + 1 file changed, 1 insertion(+) commit 7f6544740fd672dc310e28b5bc7d5f25d69badf2 Author: Sebastien Marchand <sebmarchand@chromium.org> Date: Tue Mar 19 18:33:36 2019 +0000 Add the base class for the new memory pressure monitor. This doesn't do anything yet, it's simply the base classes for the new memory pressure monitor. Bug: 771478 Change-Id: I83e65b3128f7eb9634d3ce15a4ef45232a57971c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518925 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#642091} chrome/browser/BUILD.gn | 4 ++ chrome/browser/memory/memory_pressure_monitor.cc | 52 +++++++++++++++++++ chrome/browser/memory/memory_pressure_monitor.h | 60 ++++++++++++++++++++++ .../browser/memory/memory_pressure_monitor_win.cc | 15 ++++++ .../browser/memory/memory_pressure_monitor_win.h | 30 +++++++++++ 5 files changed, 161 insertions(+) commit 7660d34c2fe47eca6bac6b4ec9f8f95ee164bf4d Author: Jao-ke Chin-Lee <jchinlee@chromium.org> Date: Tue Mar 19 18:33:29 2019 +0000 Barcode Detection Mac: Query Vision library for supported formats. The Vision library supports variants of various barcode formats, so convert those to the appropriate mojom BarcodeFormat. BUG=925167 Change-Id: I174cae68069e016262839fb4c1616f5a146568d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516024 Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642090} services/shape_detection/BUILD.gn | 2 + .../shape_detection/barcode_detection_impl_mac.h | 6 + .../shape_detection/barcode_detection_impl_mac.mm | 6 + .../barcode_detection_impl_mac_unittest.mm | 10 -- .../barcode_detection_impl_mac_vision.h | 6 + .../barcode_detection_impl_mac_vision.mm | 42 +++++- .../barcode_detection_impl_mac_vision_api.h | 35 +++++ .../barcode_detection_impl_mac_vision_api.mm | 44 +++++++ .../barcode_detection_provider_mac.h | 10 ++ .../barcode_detection_provider_mac.mm | 40 ++++-- .../barcode_detection_provider_mac_unittest.mm | 145 ++++++++++++++++++--- 11 files changed, 298 insertions(+), 48 deletions(-) commit 82ca50e8b472113becc801a3957cff84f169ab8c Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 18:31:46 2019 +0000 DevTools: dedupe similar UA rules with the same selector Screenshot: https://imgur.com/a/CtwvB1a Bug: 929536 Change-Id: I40154e9c5896c61130de3635232259c89ef3ef43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519450 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642089} .../devtools/front_end/sdk/CSSMatchedStyles.js | 77 ++++++++++++++++++---- 1 file changed, 63 insertions(+), 14 deletions(-) commit 65fbd9f55d3ecfa38d8c55d4e14746c15ca58c44 Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 18:31:16 2019 +0000 DevTools: easier text selection in SSP via drag Selecting text is important to copy/paste styles from Elements panel. This CL improves a common case that often results in poor selection. In the future, 'user-select: contain' may address this. Screenshot: https://imgur.com/a/hMlsY5C Bug: 929536 Change-Id: I23f7b1a53ad501b491017887feaab63ead2c3705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1412354 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642088} .../devtools/front_end/elements/ElementsPanel.js | 53 ++++++++++++++++++++++ .../renderer/devtools/front_end/ui/splitWidget.css | 4 ++ 2 files changed, 57 insertions(+) commit 9a66d1c45bc87e665b626631ad9f151c82cffa2d Author: siyua <siyua@chromium.org> Date: Tue Mar 19 18:26:56 2019 +0000 [Paradise] Add flag for experiment enabling migration flow for non-sync users Bug: 897998 Change-Id: I14c5c8f86188808933798b7b7d39ffebff0ca323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529577 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#642087} chrome/browser/about_flags.cc | 8 ++++++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 4 ++++ 5 files changed, 26 insertions(+) commit a896f66317d0090b468664581b071bc4ac1c1d62 Author: Dan Beam <dbeam@chromium.org> Date: Tue Mar 19 18:26:39 2019 +0000 Navi: fix gzip issues, take 2 Record all resources for which we have gzip info, whether the resource is actually gzipped or not. For unknown resources, match the default resource (welcome.html), which is gzipped. "preview-background.jpg" is a dynamic path that fetches a background from the network. It must also be excluded as IsGzipped() is currently called before requests start in URLDataManagerBackend::StartRequest(). Also adds a quick unit test. R=hcarmona@chromium.org BUG=942977 Change-Id: Iadd1ebedc067ce2d86de5918dcd4fcda55f28c90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530012 Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#642086} chrome/browser/ui/webui/welcome/welcome_ui.cc | 54 ++++++++++++---------- chrome/browser/ui/webui/welcome/welcome_ui.h | 4 ++ .../ui/webui/welcome/welcome_ui_unittest.cc | 27 +++++++++++ chrome/test/BUILD.gn | 2 + 4 files changed, 63 insertions(+), 24 deletions(-) commit efd59e71af1ebe732468d47a0c50b8fa18455d7b Author: Matt Wolenetz <wolenetz@chromium.org> Date: Tue Mar 19 18:24:25 2019 +0000 MSE - WebM: Fix default duration precision capping Sub-microsecond timescales previously could result in incorrect results that fail the assumption that the result must either be kNoTimestamp or at least 1 microsecond. BUG=937846 TEST=WebMTracksParserTest.PrecisionCapping (plus no local regression of existing media_unittests) Change-Id: I2519f23a730e5ddca4dca2a30d749e7484c3cb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529699 Reviewed-by: Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642085} media/formats/webm/webm_cluster_parser.cc | 4 +- media/formats/webm/webm_cluster_parser.h | 2 +- media/formats/webm/webm_info_parser.cc | 19 +++---- media/formats/webm/webm_info_parser.h | 4 +- media/formats/webm/webm_stream_parser.cc | 9 ++-- media/formats/webm/webm_tracks_parser.cc | 41 ++++++++------- media/formats/webm/webm_tracks_parser.h | 19 +++++-- media/formats/webm/webm_tracks_parser_unittest.cc | 64 +++++++++++++++++++---- 8 files changed, 110 insertions(+), 52 deletions(-) commit 53ed26b450a374367e4cc7591a54fff48bb85b05 Author: Zoe Clifford <zoeclifford@chromium.org> Date: Tue Mar 19 18:20:09 2019 +0000 Timeline frontend should not crash on tracks without threads. This edge-case is hit on profiles generated by headless chrome: * These traces hit the "generic" codepath because the tracing handler is started through browser_devtools_agent_host, without a frame tree node. * In TimelineModel.js _processEvent will ensure the Timings track exists, but will not associate a thread with it. This change fixes the crash and allows these types of profiles to load but isn't perfect because the Timings track will not be shown in this situation. I tried to get the Timings track to show up but wasn't familiar enough with the code to get it working. Bug: 943361 Change-Id: Iedfcf93d65a9a8cb31df20710aa19c7c967217f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529877 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642084} .../front_end/timeline/TimelineFlameChartDataProvider.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) commit bd16e773ca9b1248ba8938f54b5e24f56d920e42 Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 19 18:17:45 2019 +0000 Remove SQliteChannelIDStore. This entirely unused. Bug: 875053 Change-Id: I7710c3fa54b390edbca1d8a77d9c28ad73be3fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529689 Reviewed-by: Nick Harper <nharper@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642083} net/BUILD.gn | 3 - net/extras/sqlite/sqlite_channel_id_store.cc | 615 --------------------- net/extras/sqlite/sqlite_channel_id_store.h | 62 --- .../sqlite/sqlite_channel_id_store_unittest.cc | 611 -------------------- services/network/network_context.cc | 1 - 5 files changed, 1292 deletions(-) commit a1ef75095030c4eedc75e44269eb9c6b7302c88b Author: Chase Phillips <cmp@chromium.org> Date: Tue Mar 19 18:17:17 2019 +0000 IndexedDB: Merge IndexedDBDispatcherHost and IDBSequenceHelper These classes were originally separate because IndexedDBDispatcherHost lived on the IO thread while IDBSequenceHelper lived on the IDB task runner. After commit 77bf9a9 / https://crrev.com/c/1405718, IndexedDBDispatcherHost moved to live on the IDB task runner, so we can now merge them together. Bug: 717812 Change-Id: Iffc999a17ef562a2c93c139e100a3ece696ce4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526801 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#642082} .../indexed_db/indexed_db_dispatcher_host.cc | 145 +++------------------ .../indexed_db/indexed_db_dispatcher_host.h | 2 - 2 files changed, 21 insertions(+), 126 deletions(-) commit 9c1cf648c021a2253c36c333554362177f5f5a38 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 18:16:37 2019 +0000 Roll src/third_party/chromite cbcd56c13ecf..fcbfd4ea485a (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/cbcd56c13ecf..fcbfd4ea485a git log cbcd56c13ecf..fcbfd4ea485a --date=short --no-merges --format='%ad %ae %s' 2019-03-19 nednguyen@google.com dependency: fix bug that causes dependency source paths to be incorrect Created with: gclient setdep -r src/third_party/chromite@fcbfd4ea485a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Idc090c9787a817bbe98b2c905c2f063517d6e609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530158 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642081} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 2fa83e99ad8f18739995c416fd71e8e2ae4beb16 Author: Brian Salomon <bsalomon@google.com> Date: Tue Mar 19 18:15:44 2019 +0000 Suppress two canvas layout tests to allow small image changes after Skia roll. Linear gradients have slight differences. Bug: 938592 Change-Id: Ia78725689edeea0735b588f9d4ed7b35a7c333bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529190 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#642080} third_party/blink/web_tests/TestExpectations | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 75f1baa3ee16f394689280b781efeddcfc321e98 Author: Bo Liu <boliu@chromium.org> Date: Tue Mar 19 18:09:08 2019 +0000 aw: Always allow webgl in blink Always allow webgl. Webview always requires access to the GPU even if it only does software draws. WebGL will not show up in software draw so there is no more brokeness for user. This makes it easier for apps that want to start running webgl content before webview is first attached. Change-Id: I24bb20dadf1453a00f3ec9cb08a77483972c7c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529658 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#642079} android_webview/browser/aw_settings.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 9e3b6b9a7115e354f61e9ed87a9caa58248ef6e4 Author: Sky Malice <skym@chromium.org> Date: Tue Mar 19 18:08:26 2019 +0000 [Touchless] onSurfaceOpened() on NTP load. This essentially copies what NewTabPage.java does, invoking this method near the end of its constructor, and after refreshSuggestions(). This change results in an article fetch being properly triggered when the NTP is opened. Without this, no fetch is made initial load. Bug: 937418 Change-Id: I43319cd37ec0586240bae50481ef9c77be7386ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526298 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642078} .../src/org/chromium/chrome/browser/touchless/TouchlessNewTabPage.java | 1 + 1 file changed, 1 insertion(+) commit 82935584ada04cbe8941abdac1f681a9704289d6 Author: Min Qin <qinmin@chromium.org> Date: Tue Mar 19 18:05:04 2019 +0000 Introduce SimpleDownloadManager to support reduced mode Bug: 942770 Change-Id: I780f7a863c519cd9a2fc885c29df8fc20786b917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526686 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642077} components/download/internal/common/BUILD.gn | 1 + .../common/simple_download_manager_coordinator.cc | 46 +++++++++++++++++ components/download/public/common/BUILD.gn | 2 + .../public/common/simple_download_manager.h | 58 ++++++++++++++++++++++ .../common/simple_download_manager_coordinator.h | 54 ++++++++++++++++++++ 5 files changed, 161 insertions(+) commit 02565d7d938fc166b80c8f3c66696c748496c20c Author: Peter Kasting <pkasting@chromium.org> Date: Tue Mar 19 18:00:11 2019 +0000 Replace View::has_children() with children().empty(). These have the opposite meaning, so callers have to be negated. Bug: 940135 Change-Id: I99f01b8a6f05b1ba0b031d4cb4e573dce9ba54ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526668 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642076} ash/app_list/views/search_result_answer_card_view.cc | 2 +- ash/app_list/views/search_result_list_view.cc | 2 +- ash/app_list/views/search_result_view.cc | 4 ++-- ash/assistant/ui/main_stage/ui_element_container_view.cc | 2 +- .../shortcut_viewer/views/keyboard_shortcut_item_view.cc | 6 +++--- .../shortcut_viewer/views/keyboard_shortcut_view.cc | 4 ++-- ash/login/ui/login_test_utils.cc | 2 +- .../ui/views/apps/app_info_dialog/app_info_dialog_views.cc | 7 ++++--- .../views/apps/app_info_dialog/app_info_permissions_panel.cc | 2 +- chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc | 2 +- .../ui/views/autofill/local_card_migration_dialog_view.cc | 2 +- .../views/autofill/local_card_migration_error_dialog_view.cc | 2 +- .../ui/views/desktop_capture/desktop_media_list_view.cc | 2 +- chrome/browser/ui/views/page_info/page_info_bubble_view.cc | 2 +- chrome/browser/ui/views/payments/editor_view_controller.cc | 2 +- .../ui/views/payments/payment_request_item_list_unittest.cc | 2 +- chrome/browser/ui/views/test/view_event_test_base.cc | 2 +- chrome/browser/ui/views/touch_selection_menu_chromeos.cc | 3 +-- .../ui/views/webauthn/authenticator_request_dialog_view.cc | 2 +- .../viz/service/frame_sinks/frame_sink_manager_impl.cc | 4 ++-- components/viz/service/frame_sinks/frame_sink_manager_impl.h | 1 - ui/message_center/views/notification_view_md.cc | 5 +++-- ui/views/accessibility/ax_aura_obj_cache.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 6 +++--- ui/views/controls/menu/menu_item_view.cc | 4 ++-- ui/views/controls/menu/submenu_view.cc | 2 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/styled_label_unittest.cc | 12 ++++++------ ui/views/focus/focus_search.cc | 12 ++++-------- ui/views/layout/fill_layout.cc | 6 +++--- ui/views/view.h | 7 ++----- ui/views/view_unittest.cc | 4 ++-- ui/views/widget/root_view.cc | 4 ++-- ui/views/widget/root_view_unittest.cc | 4 ++-- 34 files changed, 60 insertions(+), 67 deletions(-) commit 8d032ba569264d4e3a6bd03ee034243759a9380b Author: Erik Luo <luoe@chromium.org> Date: Tue Mar 19 17:58:40 2019 +0000 DevTools: fix persistent overlay highlight in context selector ConsoleContextSelector calls HideHighlight, then HighlightFrame. If the frame cannot be highlighted (e.g. top frame), it cancels the pending hide call. This CL makes backend calls highlight*() hide the overlay when they fail to highlight anything. Bug: 936793 Change-Id: I95c6e396665966738453db28588f47786d10439a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497341 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#642075} .../blink/renderer/core/inspector/inspector_overlay_agent.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) commit e9fea05a2bbd5e526084d781af698b42ae543525 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Mar 19 17:54:32 2019 +0000 Use per-frame task runners at WebView Plugin This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found actual cases that JavaScript is executed: browser_tests --gtest_filter=PluginPowerSaverBrowserTest.RunAllFlashInAllowMode Bug: 870606 Change-Id: If5dfe70184fd568ae42dec3c00229121660452b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529894 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642074} components/plugins/renderer/webview_plugin.cc | 12 +++++++----- components/plugins/renderer/webview_plugin.h | 2 ++ 2 files changed, 9 insertions(+), 5 deletions(-) commit 34baef4cd0ee77351a5f81404fbacf8ce7c38358 Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Mar 19 17:54:14 2019 +0000 Add check for RenderWidgetHostDelegate before making a call This patch adds a check for |delegate_| before a function invocation to avoid crashes. When the WebContentsImpl is destroyed it triggers the loading of tabs. It may happen that a tab for which the WebContentsimpl has already been destroyed is loaded. This leads to a new surface being embedded. FrameEvictor is also activated to release frames to relieve memory pressure. In doing so, it may attempt to release frame associated with the WebContentsImpl that is already destroyed thus leading to a crash. Bug: 931827 Change-Id: Ic9905f8249b8cd72501e3b5ff94ab135a93aae62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529198 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#642073} content/browser/renderer_host/render_widget_host_impl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 236a10389b753de59590834048c5f794d9afefee Author: Alexei Svitkine <asvitkine@chromium.org> Date: Tue Mar 19 17:53:09 2019 +0000 Remove obsolete field trial checks. These trials have long expired, so remove the corresponding client side logic. Bug: None Change-Id: I690a40cd090f4f5e69d3c8dfdf9d934fb7ee90c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528975 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#642072} .../extensions/extension_message_bubble_factory.cc | 26 ++-------------------- testing/variations/fieldtrial_testing_config.json | 12 ---------- 2 files changed, 2 insertions(+), 36 deletions(-) commit 8f18c402976dd72bf63a0f83932fc8652fad6d0e Author: Eugene But <eugenebut@chromium.org> Date: Tue Mar 19 17:53:06 2019 +0000 Remove ios/web/public/block_types.h This header has a single typedef of a block which is mostly used in deprecated files. Typedef itself does not make code more readable, because the type name does not convey any information about block return type and arguments. Per Style Guide the code should be optimized for reader, not for writer: http://go/objc-style#optimize-for-the-reader-not-the-writer Bug: 942244 Change-Id: I9fcd09a2a990e32450f98ec55455508bf919a72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527208 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642071} ios/chrome/browser/ui/browser_view_controller.mm | 2 +- .../ui/static_content/static_html_native_content.mm | 2 +- .../ui/static_content/static_html_view_controller.h | 3 +-- .../static_content/static_html_view_controller.mm | 2 +- ios/chrome/test/earl_grey/chrome_matchers.mm | 1 - ios/web/interstitials/web_interstitial_impl.h | 11 ++++++----- ios/web/interstitials/web_interstitial_impl.mm | 2 +- ios/web/public/BUILD.gn | 1 - ios/web/public/block_types.h | 21 --------------------- ios/web/public/test/earl_grey/js_test_util.mm | 2 +- .../test/fakes/crw_test_js_injection_receiver.mm | 2 +- .../web_state/js/crw_js_injection_evaluator.h | 4 +--- .../public/web_state/js/crw_js_injection_manager.h | 2 +- ios/web/public/web_state/ui/crw_native_content.h | 3 +-- ios/web/web_state/js/crw_js_injection_manager.mm | 2 +- ios/web/web_state/js/crw_js_injection_receiver.mm | 2 +- ios/web/web_state/ui/crw_context_menu_controller.h | 2 -- ios/web/web_state/ui/crw_context_menu_controller.mm | 4 ++-- ios/web/web_state/ui/crw_web_controller.h | 5 ++++- ios/web/web_state/ui/crw_web_controller.mm | 4 ++-- ios/web/web_state/ui/web_view_js_utils.h | 4 +--- ios/web/web_state/ui/web_view_js_utils.mm | 2 +- 22 files changed, 28 insertions(+), 55 deletions(-) commit 1f97a46216f2c58dbf74bc6f5754e8ba4d9348b5 Author: Carlos Caballero <carlscab@google.com> Date: Tue Mar 19 17:51:10 2019 +0000 Make sure all queues are shutdown before deleting SequenceManager In the near future it will be an error to delete a SequenceManager instance for which there still exist active TaskQueues. This patch makes sure that schedulers will be fine with said change. https://docs.google.com/document/d/1KZJt7pifMaiaz1xDO313VW3I4gKAsInJXC00FifBX00 Bug: 891670 Change-Id: I95ad184c4803e8c141838b637cabcf450ffe4fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530772 Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#642070} .../main_thread/frame_scheduler_impl_unittest.cc | 38 ++++++----- .../main_thread_scheduler_impl_unittest.cc | 2 + .../main_thread/page_scheduler_impl_unittest.cc | 77 ++++++++++++---------- 3 files changed, 64 insertions(+), 53 deletions(-) commit eebd15c888637b837409f00a79ac27f5c49917fa Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 17:50:18 2019 +0000 Delete ios_chrome_profile_sync_test_util.h/cc It provided helpers to ease construction of a ProfileSyncServiceMock, but it's now unused. Bug: 910518 Change-Id: I0fc1095287db2ee65fa108c928682e9a8da16da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529061 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642069} ios/chrome/browser/sync/BUILD.gn | 5 --- .../sync/ios_chrome_profile_sync_test_util.cc | 41 ---------------------- .../sync/ios_chrome_profile_sync_test_util.h | 30 ---------------- 3 files changed, 76 deletions(-) commit 7f68556f35e923f89180110a2850b521750a4431 Author: Rakib M. Hasan <rmhasan@google.com> Date: Tue Mar 19 17:50:04 2019 +0000 Add platform tags in WebGLConformanceIntegrationTest Add tags for asan/no-asan, and the WebGL version, to the tags returned by GpuIntegrationTest. Also makes sure that underscores are replaced with dashes in all tags returned by GetPlatformTags. Bug: chromium:698902 Change-Id: I4a30c345723469d1e9b376a6c7beb34c933a7db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529197 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#642068} content/test/gpu/gpu_tests/gpu_integration_test.py | 2 +- .../gpu/gpu_tests/gpu_integration_test_unittest.py | 47 +++++++++++++++++++--- .../webgl_conformance_integration_test.py | 8 ++++ 3 files changed, 51 insertions(+), 6 deletions(-) commit 390285e6b3e0b4a83386f3b0d3d2a9ccfbf1603b Author: Nick Harper <nharper@chromium.org> Date: Tue Mar 19 17:49:11 2019 +0000 Update bulk entries in HSTS preload list TBR=bnc@chromium.org Change-Id: If23bd6e60835bb9d99cb64f7427a659164ab19d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526540 Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#642067} net/http/transport_security_state_static.json | 447 ++++++++++++++++++++++++-- 1 file changed, 422 insertions(+), 25 deletions(-) commit 7fc170be0ab4e23f2277a7e0aa82b017f7e66bbb Author: Sammie Quon <sammiequon@google.com> Date: Tue Mar 19 17:48:57 2019 +0000 shelf: Fix bug with swipes triggering the back button. It happens because swipes may send out TAP_DOWN events which create a key down back event. But the key down back event is the one that triggers the browser to go back, so change to only simulate a key down event on a tap or mouse release event. Test: manual Bug: 943154 Change-Id: Id0e8f575b3646d14e1eb39a9b5c98f64dfd874cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529543 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#642066} ash/shelf/back_button.cc | 35 +++++++---------------------------- ash/shelf/back_button.h | 9 +++++---- ash/shelf/back_button_unittest.cc | 12 ++++++++---- 3 files changed, 20 insertions(+), 36 deletions(-) commit 70bd2295c22c984453e5facf89f811b305fed184 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 17:47:06 2019 +0000 Roll src/third_party/swiftshader 24cb99d44e9c..0e712410582f (4 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/24cb99d44e9c..0e712410582f git log 24cb99d44e9c..0e712410582f --date=short --no-merges --format='%ad %ae %s' 2019-03-19 chrisforbes@google.com Add support for OpUndef 2019-03-19 bclayton@google.com Regres: Categorize crashes caused by debug macros 2019-03-19 bclayton@google.com Regres: Fix priority boost for +2 code review. 2019-03-19 bclayton@google.com Regres: Don't attempt to build failing changes forever. Created with: gclient setdep -r src/third_party/swiftshader@0e712410582f The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I597c69d0aea772788420c8a25b53ecf26a856abd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530024 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642065} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a5e5273248c12ea7edcdfa076bbd4d45d8b69f02 Author: John Delaney <johnidel@chromium.org> Date: Tue Mar 19 17:46:14 2019 +0000 Remove resource map from PageLoadMetricsTestWaiter We currently maintain this resource map so that tests can define their own Testwaiter and wait on different conditions. This code is confusing and the same functionality can be achieved without holding all resources loaded by the page in a map. Bug: 943598 Change-Id: If11f599079d85875b5b368f7a2021daf45765a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529183 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#642064} .../ads_page_load_metrics_observer_browsertest.cc | 19 +++++++++++-------- .../page_load_metrics_test_waiter.cc | 9 +-------- .../page_load_metrics/page_load_metrics_test_waiter.h | 15 +++++++-------- 3 files changed, 19 insertions(+), 24 deletions(-) commit 268f60b33b2637aa5fbf452cb9aad1f4cf834a0b Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 17:45:40 2019 +0000 Add COMPONENT to //ui/compositor Useful for binary size attribution (amongst other things) Change-Id: Id167b1c5d22811d48265b69b9f05c97b881ff75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529122 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642063} ui/compositor/OWNERS | 2 ++ 1 file changed, 2 insertions(+) commit c61978e0eff40bb3a70a961a26c50aa1907ba7a4 Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Mar 19 17:44:24 2019 +0000 Move chromeos/dbus/*cryptohome* to chromoes/dbus/cryptohome This is just a mechanical move in preparation for extracting CryptohomeClient from DBusThreadManager ./tools/git/move_source_file.py chromeos/dbus/cryptohome_client.cc chromeos/dbus/cryptohome ./tools/git/move_source_file.py chromeos/dbus/cryptohome_client.h chromeos/dbus/cryptohome ./tools/git/move_source_file.py chromeos/dbus/fake_cryptohome_client.cc chromeos/dbus/cryptohome ./tools/git/move_source_file.py chromeos/dbus/fake_cryptohome_client.h chromeos/dbus/cryptohome ./tools/git/move_source_file.py chromeos/dbus/fake_cryptohome_client_unittest.cc chromeos/dbus/cryptohome ./tools/git/move_source_file.py chromeos/dbus/attestation_constants.cc chromeos/dbus/constants/ ./tools/git/move_source_file.py chromeos/dbus/attestation_constants.h chromeos/dbus/constants/ For mechanical move: TBR=sky@chromium.org Bug: 647367 Change-Id: I5b5d7c8de1c5f4ab4fdfc83f0f71e4165c2ba8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529680 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#642062} .../chrome_browsing_data_remover_delegate.cc | 4 +-- ...rome_browsing_data_remover_delegate_unittest.cc | 2 +- .../chromeos/app_mode/arc/arc_kiosk_app_manager.cc | 2 +- .../chromeos/app_mode/kiosk_profile_loader.cc | 2 +- ...rectory_enrollment_token_fetcher_browsertest.cc | 2 +- .../chromeos/attestation/attestation_ca_client.h | 2 +- .../attestation/attestation_policy_browsertest.cc | 2 +- .../attestation/attestation_policy_observer.cc | 2 +- .../attestation/attestation_policy_observer.h | 2 +- .../attestation_policy_observer_unittest.cc | 2 +- .../attestation/enrollment_policy_observer.cc | 2 +- .../attestation/enrollment_policy_observer.h | 2 +- .../enrollment_policy_observer_unittest.cc | 2 +- .../attestation/platform_verification_flow.cc | 2 +- .../attestation/platform_verification_flow.h | 2 +- .../platform_verification_flow_unittest.cc | 2 +- .../chromeos/chrome_browser_main_chromeos.cc | 2 +- .../quick_unlock_private_api_unittest.cc | 2 +- .../login/active_directory_login_browsertest.cc | 2 +- .../auth/cryptohome_authenticator_unittest.cc | 2 +- .../login/auto_launched_kiosk_browsertest.cc | 2 +- .../chromeos/login/crash_restore_browsertest.cc | 2 +- .../login/demo_mode/demo_mode_resources_remover.h | 2 +- .../demo_mode_resources_remover_unittest.cc | 2 +- .../easy_unlock/easy_unlock_get_keys_operation.cc | 2 +- .../login/enrollment/auto_enrollment_controller.cc | 2 +- .../chromeos/login/enrollment/enrollment_screen.cc | 2 +- chrome/browser/chromeos/login/kiosk_browsertest.cc | 2 +- .../quick_unlock/pin_migration_browsertest.cc | 2 +- .../chromeos/login/saml/saml_browsertest.cc | 4 +-- .../browser/chromeos/login/screens/eula_screen.cc | 2 +- .../login/screens/user_selection_screen.cc | 2 +- .../screens/user_selection_screen_browsertest.cc | 2 +- .../chromeos/login/session/user_session_manager.cc | 2 +- .../users/avatar/user_image_manager_browsertest.cc | 2 +- .../login/users/wallpaper_policy_browsertest.cc | 2 +- .../login/wizard_controller_browsertest.cc | 2 +- .../chromeos/policy/affiliation_test_helper.cc | 2 +- .../policy/browser_policy_connector_chromeos.cc | 2 +- .../policy/cached_policy_key_loader_chromeos.cc | 2 +- .../cached_policy_key_loader_chromeos_unittest.cc | 2 +- ...omponent_active_directory_policy_browsertest.cc | 2 +- ...evice_cloud_policy_manager_chromeos_unittest.cc | 2 +- .../device_cloud_policy_store_chromeos_unittest.cc | 2 +- .../chromeos/policy/device_status_collector.cc | 2 +- .../chromeos/policy/device_status_collector.h | 2 +- .../display_resolution_handler_browsertest.cc | 4 +-- ...display_rotation_default_handler_browsertest.cc | 4 +-- .../chromeos/policy/dm_token_storage_unittest.cc | 2 +- .../chromeos/policy/enrollment_handler_chromeos.h | 2 +- .../chromeos/policy/power_policy_browsertest.cc | 2 +- .../chromeos/policy/pre_signin_policy_fetcher.cc | 2 +- .../policy/pre_signin_policy_fetcher_unittest.cc | 4 +-- .../policy/user_affiliation_browsertest.cc | 4 +-- .../user_cloud_policy_store_chromeos_unittest.cc | 2 +- chrome/browser/chromeos/profiles/profile_helper.cc | 2 +- .../device_oauth2_token_service_unittest.cc | 2 +- .../chromeos/settings/device_settings_provider.cc | 2 +- .../browser/chromeos/ui/low_disk_notification.cc | 2 +- chrome/browser/chromeos/ui/low_disk_notification.h | 2 +- .../chromeos/ui/low_disk_notification_unittest.cc | 2 +- .../enterprise_platform_keys_api_unittest.cc | 4 +-- .../enterprise_platform_keys_private_api.cc | 4 +-- .../enterprise_platform_keys_private_api.h | 4 +-- ...nterprise_platform_keys_private_api_unittest.cc | 4 +-- .../networking_private_chromeos_apitest.cc | 2 +- .../policy/cloud/cloud_policy_browsertest.cc | 2 +- chrome/browser/profiles/profile_io_data.cc | 2 +- chrome/browser/profiles/profile_manager.cc | 2 +- .../ui/webui/chromeos/cryptohome_web_ui_handler.cc | 2 +- .../login/enable_debugging_screen_handler.cc | 2 +- .../login/encryption_migration_screen_handler.cc | 2 +- .../login/encryption_migration_screen_handler.h | 2 +- ...encryption_migration_screen_handler_unittest.cc | 2 +- .../settings/chromeos/device_storage_handler.cc | 2 +- chromeos/attestation/attestation_flow.cc | 2 +- chromeos/attestation/attestation_flow.h | 2 +- chromeos/attestation/attestation_flow_unittest.cc | 2 +- chromeos/cryptohome/async_method_caller.cc | 2 +- chromeos/cryptohome/async_method_caller.h | 4 +-- chromeos/cryptohome/homedir_methods.h | 2 +- chromeos/cryptohome/system_salt_getter.cc | 2 +- chromeos/cryptohome/system_salt_getter_unittest.cc | 2 +- chromeos/dbus/BUILD.gn | 14 ++++---- .../dbus/{ => constants}/attestation_constants.cc | 2 +- .../dbus/{ => constants}/attestation_constants.h | 6 ++-- .../dbus/{ => cryptohome}/cryptohome_client.cc | 37 ++++++++-------------- chromeos/dbus/{ => cryptohome}/cryptohome_client.h | 11 +++---- .../{ => cryptohome}/fake_cryptohome_client.cc | 2 +- .../dbus/{ => cryptohome}/fake_cryptohome_client.h | 12 +++---- .../fake_cryptohome_client_unittest.cc | 2 +- chromeos/dbus/dbus_clients_common.cc | 4 +-- chromeos/dbus/dbus_thread_manager.cc | 2 +- chromeos/dbus/fake_auth_policy_client.cc | 2 +- chromeos/dbus/fake_auth_policy_client_unittest.cc | 2 +- .../session_manager/fake_session_manager_client.cc | 2 +- .../dbus/session_manager/session_manager_client.cc | 2 +- chromeos/dbus/util/tpm_util.cc | 2 +- chromeos/dbus/util/version_loader.cc | 2 +- chromeos/dbus/util/version_loader.h | 2 +- .../login/auth/authpolicy_login_helper_unittest.cc | 2 +- chromeos/login/auth/cryptohome_authenticator.cc | 2 +- chromeos/login/auth/extended_authenticator_impl.cc | 2 +- chromeos/login/auth/stub_authenticator.cc | 2 +- chromeos/tpm/install_attributes.h | 2 +- chromeos/tpm/install_attributes_unittest.cc | 2 +- chromeos/tpm/tpm_password_fetcher.cc | 2 +- chromeos/tpm/tpm_token_info_getter.cc | 2 +- chromeos/tpm/tpm_token_info_getter.h | 2 +- chromeos/tpm/tpm_token_info_getter_unittest.cc | 4 +-- chromeos/tpm/tpm_token_loader.h | 2 +- components/arc/disk_quota/arc_disk_quota_bridge.cc | 2 +- 112 files changed, 154 insertions(+), 166 deletions(-) commit 2c6f3da1f23646496a455b0b48f41397d1defcde Author: Richard Baranyi <lordprotector@gmail.com> Date: Tue Mar 19 17:43:57 2019 +0000 [Windows Sandbox] Remove SANDBOX_INERT flag Flag SANDBOX_INERT is ignored now on patched systems unless you run as LocalSystem or TrustedInstaller so it doesn't make sense to use it anymore. Bug: 943542 Change-Id: I4f2e2aa4bf17eb9fb293070c694508069472265c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524047 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#642061} sandbox/win/src/restricted_token.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 252ffae9df7cad821f463615f41d6df9ac11ca7e Author: Steven Bingler <bingler@chromium.org> Date: Tue Mar 19 17:43:16 2019 +0000 Standardizing disk cache type access on GetCacheType(). Removed cache_type() and replaced uses with GetCacheType(). Bug: 718558 Change-Id: Ia4c27810ff644c932c848ddd9bb0ea26684d9cd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518238 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#642060} .../cache_storage/cache_storage_cache_unittest.cc | 7 ++- net/disk_cache/backend_unittest.cc | 21 +++++---- net/disk_cache/blockfile/backend_impl.cc | 51 ++++++++++------------ net/disk_cache/blockfile/backend_impl.h | 11 +---- net/disk_cache/blockfile/histogram_macros.h | 2 +- net/disk_cache/disk_cache.cc | 6 +-- net/disk_cache/disk_cache.h | 6 ++- net/disk_cache/disk_cache_test_base.cc | 9 ++-- net/disk_cache/disk_cache_test_util.cc | 3 +- net/disk_cache/memory/mem_backend_impl.cc | 7 +-- net/disk_cache/memory/mem_backend_impl.h | 1 - net/disk_cache/simple/simple_backend_impl.cc | 26 +++++------ net/disk_cache/simple/simple_backend_impl.h | 3 -- net/http/mock_http_cache.cc | 7 +-- net/http/mock_http_cache.h | 1 - net/tools/crash_cache/crash_cache.cc | 5 +-- net/tools/stress_cache/stress_cache.cc | 2 +- 17 files changed, 72 insertions(+), 96 deletions(-) commit a5a09efa522fdb46d4b10e32e983a69799392315 Author: Dana Fried <dfried@chromium.org> Date: Tue Mar 19 17:42:52 2019 +0000 Move tab_renderer_data into c/b/ui/BUILD.gn Because (for historical reasons) the file was in the very small c/b/ui/views DLL, it could not access the default constructors or destructors of any types in c/b/ui/views that were not in that DLL. This would have made it impossible to, for example, share thumbnail image data between a tab helper and the preview display in a flipbook or hover card (adding a non-trivial member to the struct of a data type defined in c/b/ui/BUILD.gn would cause linker errors). Since the only files that depend on tab_renderer_data are in c/b/ui/BUILD.gn, it should be moved to that package along with many of the other existing files in c/b/ui/views/tabs which are already there. Bug: 928954 Change-Id: If32406bb3363ffbb96fbea60e50a8452217f6a29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529294 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#642059} chrome/browser/ui/BUILD.gn | 2 ++ chrome/browser/ui/views/BUILD.gn | 2 -- chrome/browser/ui/views/tabs/tab_renderer_data.h | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) commit 971289c5eb7677a95676cb732e375c0994168e03 Author: Ria Jiang <riajiang@chromium.org> Date: Tue Mar 19 17:42:10 2019 +0000 Suppress shader-with-non-reserved-words on Mac NVIDIA. Bug: 929009 Change-Id: Ia428afea39e216e317bc712d1ad410c7f6d23f50 Tbr: kbr@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530152 Reviewed-by: Ria Jiang <riajiang@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#642058} content/test/gpu/gpu_tests/webgl_conformance_expectations.py | 2 ++ 1 file changed, 2 insertions(+) commit c61fa0660083195e5f9a84c89f57799eea838033 Author: Mihai Sardarescu <msarda@chromium.org> Date: Tue Mar 19 17:41:38 2019 +0000 [unified-consent] Contextual suggestions is enable iff anonymized URL-keyed data collection is enabled. Activity and interactions was removed from the unified consent feature. So contextual suggestions (aka Explore on Content) should be enabled iff anonymized URL-keyed data collection is enabled. This CL also removes the Android java API ProfileSyncService.isUrlKeyedDataCollectionEnabled as it is now obsolete and it uses the UnifiedConsentBridge API. Bug: 943603 Change-Id: I5a7f3f8ea40ad5e3d7a7425e18abea1649b751ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529057 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#642057} .../ContextualSuggestionsEnabledStateUtils.java | 5 ++--- .../ContextualSuggestionsPreference.java | 5 ++--- .../chrome/browser/sync/ProfileSyncService.java | 14 -------------- .../EnabledStateMonitorTest.java | 19 ++----------------- chrome/browser/sync/profile_sync_service_android.cc | 21 --------------------- 5 files changed, 6 insertions(+), 58 deletions(-) commit 10268bd0cf3c118c33e4f784679c75a59ba3b661 Author: Alexei Filippov <alph@chromium.org> Date: Tue Mar 19 17:40:05 2019 +0000 DevTools: Do not crash in Runtime.evaluate on provisional frames. Report a DevTools protocol error instead. This is a temporary fix until provisional frames concept is removed. BUG=897816,578349 Change-Id: I88005df96d3aa31743d8aa543aec0e34516cb9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529871 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642056} .../renderer/bindings/core/v8/local_window_proxy.cc | 2 -- .../renderer/core/inspector/main_thread_debugger.cc | 16 ++++++++++++++-- 2 files changed, 14 insertions(+), 4 deletions(-) commit 438ba15241539e4af7db27e1de3b3ea9d8db4ce4 Author: Peter E Conn <peconn@chromium.org> Date: Tue Mar 19 17:39:34 2019 +0000 ✨ Move lifecycle UMA recording out of CustomTabActivity. Move UMA out of CustomTabActivity's lifecycle methods (such as onResumeWithNative) and into a separate class. Bug: 916539 Change-Id: I9fd530b25bae324e11faecacf743c2da712dd3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530862 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#642055} .../browser/customtabs/CustomTabActivity.java | 69 +------------ .../CustomTabActivityLifecycleUmaTracker.java | 115 +++++++++++++++++++++ .../CustomTabActivityComponent.java | 2 + chrome/android/java_sources.gni | 1 + 4 files changed, 119 insertions(+), 68 deletions(-) commit 5b5ffbc598e896b14ad4925b41e69f2fde4248cd Author: Karolina Soltys <ksolt@chromium.org> Date: Tue Mar 19 17:37:45 2019 +0000 [scheduler] Disabling flaky test. Disabling NativePostTaskTest#testCreateTaskRunnerMigrationToNative TBR=boliu@chromium.org Bug: 938316 Change-Id: Id249cbabf3c7b6cb65e774641f68dd1db4920ba5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530846 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Karolina Soltys <ksolt@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Karolina Soltys <ksolt@chromium.org> Auto-Submit: Karolina Soltys <ksolt@chromium.org> Cr-Commit-Position: refs/heads/master@{#642054} .../src/org/chromium/content/browser/scheduler/NativePostTaskTest.java | 2 ++ 1 file changed, 2 insertions(+) commit 5f570d91dcf55fae84b650bb670242902258ee64 Author: Xiaocheng Hu <xiaochengh@chromium.org> Date: Tue Mar 19 17:35:44 2019 +0000 Add test cases of caret movement out of inline block into parent block Bug: 894651 Change-Id: I8fd20e81813ac731fdc9fff5a99da85606be6b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526711 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#642053} third_party/blink/web_tests/TestExpectations | 3 + .../move_out_of_inline_block_multiline.html | 399 +++++++++++++++++++++ .../move_out_of_inline_block_nested.html | 101 ++++++ .../move_out_of_inline_block_one_line.html | 109 ++++++ 4 files changed, 612 insertions(+) commit dc23f1f922899349f0f6e543cc7c6c487944497d Author: Scott Violet <sky@chromium.org> Date: Tue Mar 19 17:35:41 2019 +0000 chromeos: disables VolumeManagerTest.CompletedFailed It's flaky and has been flaky for a while. BUG=943570 TEST=test only change TBR=hidehiko@chromium.org Change-Id: I0a273acf2291a410aaecba543385e6c3131da36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531003 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642052} chrome/browser/chromeos/file_manager/volume_manager_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 54ad0d3a431fdf989871039f230ef26cde72f5b3 Author: behdad <behdadb@chromium.org> Date: Tue Mar 19 17:28:55 2019 +0000 removed desktop_gpu_raster test cases of mobile Bug: chromium:941229 Change-Id: If387154f08f417dcd4ee7547ddcaac5bb81789fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529572 Reviewed-by: Victor Miura <vmiura@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#642051} tools/perf/page_sets/rendering/rendering_stories.py | 11 ----------- 1 file changed, 11 deletions(-) commit 1f5c90bd267d60e863b713e8ad8647f6ce3a1f88 Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Tue Mar 19 17:28:07 2019 +0000 [SendTabToSelf] remove expired sync entries after 10 days. Bug: 910390 Change-Id: Iad49c4b2d7d45374e1959006fb1f88bd34322fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1474791 Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642050} .../single_client_send_tab_to_self_sync_test.cc | 9 ++- .../send_tab_to_self/send_tab_to_self_bridge.cc | 38 +++++++++--- .../send_tab_to_self/send_tab_to_self_bridge.h | 3 + .../send_tab_to_self_bridge_unittest.cc | 67 +++++++++++++++++++++- .../send_tab_to_self/send_tab_to_self_entry.cc | 6 ++ .../send_tab_to_self/send_tab_to_self_entry.h | 5 ++ .../send_tab_to_self_entry_unittest.cc | 11 ++++ 7 files changed, 127 insertions(+), 12 deletions(-) commit b07eadd3c3b5b919591c34e5cbf223a11eebfba6 Author: Eric Stevenson <estevenson@chromium.org> Date: Tue Mar 19 17:27:49 2019 +0000 crashpad_stackwalker: Check for missing minidump_stackwalk. Error out early since the script will fail without it. Change-Id: I2f569e91f4b29269ebc7ae9f0c1542c218c3303a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529164 Auto-Submit: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#642049} build/android/stacktrace/crashpad_stackwalker.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit 4b99acf55329803611ce2e8e31388fc1f8388eb2 Author: Sergey Ulanov <sergeyu@chromium.org> Date: Tue Mar 19 17:27:02 2019 +0000 [Fuchsia] Fix blink layoyut tests to avoid 'pm install' dependency Blink layout tests were not running properly after `pm install` command was removed. Added move package installation logic from run_pacakge.py to Target class and update layout tests runner to call target.InstallPackage() instead of running `pm install`. Also removed invalid Fuchsia-specific test expectations that were added since the test started failing. Change-Id: I86ad072d0725042f695b84a48ef132b65d32b963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526692 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642048} build/fuchsia/run_package.py | 140 ++------------------ build/fuchsia/target.py | 134 +++++++++++++++++++ .../blink/tools/blinkpy/web_tests/port/fuchsia.py | 21 +-- .../fuchsia/editing/selection/4402375-expected.png | Bin 36870 -> 0 bytes .../interfaces/Animatable/animate-expected.txt | 144 --------------------- .../Animatable/getAnimations-expected.txt | 19 --- .../interfaces/Document/getAnimations-expected.txt | 9 -- .../transformed-progress-expected.txt | 35 ----- .../text-decoration-style-expected.png | Bin 21086 -> 0 bytes .../text-decoration-style-inherit-expected.png | Bin 112020 -> 0 bytes ...ext-decoration-style-inherit-links-expected.png | Bin 48785 -> 0 bytes ...erit-not-propagated-by-out-of-flow-expected.png | Bin 15177 -> 0 bytes ...on-style-inherit-simple-underlines-expected.png | Bin 24532 -> 0 bytes .../fast/text/stroking-decorations-expected.png | Bin 88950 -> 0 bytes .../collapsing_borders/bug41262-3-expected.png | Bin 41405 -> 0 bytes .../transforms/transformed-caret-expected.png | Bin 29602 -> 0 bytes 16 files changed, 148 insertions(+), 354 deletions(-) commit 0e52b68ce225475ea4a562623776efa615810f02 Author: Martin Robinson <mrobinson@igalia.com> Date: Tue Mar 19 17:26:41 2019 +0000 Move hypertext_ member to AXPlatformNodeBsae These classes will soon share a good deal of code that reads this member variable. This change eliminates the duplicate member that exists in the subclasses Bug: 866338 Change-Id: I2b4825f511c94754be618d1ddcaaffc20e8473c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524299 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#642047} .../accessibility/browser_accessibility_com_win.cc | 2 +- .../platform/ax_platform_node_auralinux.cc | 2 +- .../platform/ax_platform_node_auralinux.h | 2 -- ui/accessibility/platform/ax_platform_node_base.cc | 33 +++++++++++----------- ui/accessibility/platform/ax_platform_node_base.h | 4 ++- ui/accessibility/platform/ax_platform_node_win.h | 1 - 6 files changed, 21 insertions(+), 23 deletions(-) commit 6d9759b584e6c7b9a4ccddd28078f90771300ecd Author: Malay Keshav <malaykeshav@chromium.org> Date: Tue Mar 19 17:24:11 2019 +0000 Plumb fast rounded corner to surface aggregator via shared quad state This patch plumbs the fast rounded corner flag to the surface aggregator via the shared quad state. It is then used while deciding whether to merge the quad list of a surface with the target render pass or not. The extra conditions added when merging render passses are: 1. The surface aggregator will now merge the quad list of a surface iff it does not have a roudned corner being applied to it. 2. The surface aggregator will merge the quad list of a surface with fast rounded corner iff none of the quads in its root render pass have rounded corner of their own. Bug: 903486 Change-Id: I36d3918a6ac8a004d33f3ed471cd1adcefd69222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524717 Reviewed-by: weiliangc <weiliangc@chromium.org> Reviewed-by: enne <enne@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#642046} cc/layers/layer_impl.cc | 2 + cc/trees/draw_property_utils.cc | 32 ++- components/viz/common/quads/shared_quad_state.h | 4 + .../viz/service/display/surface_aggregator.cc | 123 +++++++---- .../viz/service/display/surface_aggregator.h | 52 +++-- .../service/display/surface_aggregator_unittest.cc | 230 +++++++++++++++++++-- 6 files changed, 365 insertions(+), 78 deletions(-) commit 50545174785583180ff86a39aeaacbe5b4f9951e Author: Regan Hsu <hsuregan@chromium.org> Date: Tue Mar 19 17:23:09 2019 +0000 [CrOS Settings Languages] Remove unnecessary separator line in dialog box Currently there is an unnecessary separator between the checkboxes and buttons present on the dialog box when hovering over the single language. This CL removes that separator, and reveals iff there is more than 1 selected language. Bug: 927667 Change-Id: I6907b2d88386105320872849c41c70f5c2a613fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524333 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#642045} .../resources/settings/languages_page/languages_page.html | 4 ++-- .../resources/settings/languages_page/languages_page.js | 11 +++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) commit c4936870d09978fc0f67f4f92550e65df502f707 Author: Aran Gilman <gilmanmh@google.com> Date: Tue Mar 19 17:23:04 2019 +0000 Add Dark Mode web tests for inverting pages based on background color. Bug: 925949 Change-Id: Ie6042612b107874f984a0ae03794ec235b3e6cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510114 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#642044} third_party/blink/web_tests/VirtualTestSuites | 10 ++++++++++ .../page-policy-all/background-dark-color-expected.png | Bin 0 -> 2840 bytes .../dark-mode/page-policy-all/background-dark-color.html | 2 ++ .../page-policy-all/background-light-color-expected.png | Bin 0 -> 2840 bytes .../page-policy-all/background-light-color.html | 3 +++ .../background-invert-expected.png | Bin 0 -> 2840 bytes .../page-policy-background/background-invert.html | 3 +++ .../background-noinvert-expected.png | Bin 0 -> 2840 bytes .../page-policy-background/background-noinvert.html | 2 ++ .../dark-mode/paint/dark-mode/page-policy-all/README.txt | 3 +++ .../page-policy-all/background-dark-color-expected.png | Bin 0 -> 2841 bytes .../page-policy-all/background-light-color-expected.png | Bin 0 -> 2841 bytes .../paint/dark-mode/page-policy-background/README.txt | 3 +++ .../background-invert-expected.png | Bin 0 -> 2841 bytes 14 files changed, 26 insertions(+) commit 8c420304ecdcd9e1f0b64217aac7da661d691d08 Author: John Budorick <jbudorick@chromium.org> Date: Tue Mar 19 17:22:01 2019 +0000 Run the cronet gtests on the luci ASAN cronet builder. Uses the new run_with_asan wrapper to ensure devices correctly run the ASAN setup/teardown logic. Bug: 861983 Change-Id: I3dce602000d08576b23fb0f55a6887d892db0928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529088 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#642043} testing/buildbot/chromium.android.json | 54 +++++++++++++++++++++++++++++----- testing/buildbot/waterfalls.pyl | 12 ++------ tools/mb/mb.py | 5 +++- 3 files changed, 53 insertions(+), 18 deletions(-) commit f6edce75c4796a082b3f62cbb801d4f602554967 Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 17:21:56 2019 +0000 SocketPools: group_name to GroupId conversion part 4 (last part). Make ClientSocketPool methods take GroupIds instead of string group names, and remove implicit conversion from GroupId to std::string. This is part of an effort to merge ClientSocketPool::SocketParams and group names / GroupIds. Bug: 533571 Change-Id: I8a4548b1ed55070fe55449e8eac36be9768481f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525991 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642042} net/http/http_network_transaction_unittest.cc | 186 ++++++++++++--------- net/http/http_stream_factory_unittest.cc | 54 +++--- net/log/net_log_event_type_list.h | 12 +- net/socket/client_socket_handle.cc | 16 +- net/socket/client_socket_handle.h | 20 +-- net/socket/client_socket_pool.h | 31 ++-- net/socket/client_socket_pool_base.cc | 158 ++++++++--------- net/socket/client_socket_pool_base.h | 135 ++++++++------- net/socket/client_socket_pool_base_unittest.cc | 142 ++++++++++++---- net/socket/client_socket_pool_manager.cc | 4 +- net/socket/client_socket_pool_unittest.cc | 4 + net/socket/socket_test_util.cc | 16 +- net/socket/socket_test_util.h | 29 +--- net/socket/transport_client_socket_pool.cc | 57 ++++--- net/socket/transport_client_socket_pool.h | 18 +- .../websocket_transport_client_socket_pool.cc | 45 ++--- .../websocket_transport_client_socket_pool.h | 20 ++- 17 files changed, 540 insertions(+), 407 deletions(-) commit 23f8cd770427d121023f905c800c79ab013d503a Author: Jeffrey Cohen <jeffreycohen@chromium.org> Date: Tue Mar 19 17:17:28 2019 +0000 [SendTabToSelf] convert STTS bridge into a HistoryObserver. This change reverts a previous change to move getting navigation timestamps back to the clients instead of the bridge. To accomplish that it also adds a Timestamp to Navigation Entries on Android. Bug: 938102 Change-Id: I58cd00e674182425da64289d377c9ba298918bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506601 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#642041} .../chromium/chrome/browser/NavigationPopup.java | 2 +- .../SendTabToSelfAndroidBridge.java | 30 +++++++-------- .../SendTabToSelfShareActivity.java | 11 +++++- .../chrome/browser/NavigationPopupTest.java | 8 ++-- .../GoogleSearchRestrictionTest.java | 20 +++++----- .../customtabs/CloseButtonNavigatorTest.java | 2 +- .../SendTabToSelfAndroidBridgeTest.java | 4 +- .../send_tab_to_self_android_bridge.cc | 6 ++- .../send_tab_to_self/send_tab_to_self_util.cc | 15 ++++++-- .../send_tab_to_self_util_unittest.cc | 26 +++++++++---- .../sync/send_tab_to_self_sync_service_factory.cc | 8 +++- .../two_client_send_tab_to_self_sync_test.cc | 30 ++++++++++++--- components/send_tab_to_self/BUILD.gn | 2 + components/send_tab_to_self/DEPS | 1 + .../send_tab_to_self/send_tab_to_self_bridge.cc | 43 ++++++++++++++++++---- .../send_tab_to_self/send_tab_to_self_bridge.h | 23 ++++++++++-- .../send_tab_to_self_bridge_unittest.cc | 13 ++++--- .../send_tab_to_self/send_tab_to_self_model.h | 8 ++-- .../send_tab_to_self_sync_service.cc | 8 +++- .../send_tab_to_self_sync_service.h | 7 +++- .../frame_host/navigation_controller_android.cc | 3 +- .../framehost/NavigationControllerImpl.java | 7 ++-- .../content_public/browser/NavigationEntry.java | 11 +++++- 23 files changed, 205 insertions(+), 83 deletions(-) commit 8193e406097c3ade04517d7708902f4508b2c706 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:11:56 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 This CL was uploaded by git cl split. TBR=msw@chromium.org Change-Id: I3a492c8d0fa2e9f38a20efa8ba6ffb7ce8287ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529882 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642040} ui/views/controls/tabbed_pane/tabbed_pane.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a4ffdc187dee12ccf0599c048953128c914542a7 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:09:42 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 This CL was uploaded by git cl split. TBR=pkasting@chromium.org Change-Id: Ifcc02b3652a2d4de2c6442e8fd0159857eee5681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529856 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642039} ui/views/controls/textfield/textfield.cc | 7 +-- .../controls/textfield/textfield_model_unittest.cc | 52 +++++++++++----------- ui/views/controls/textfield/textfield_unittest.cc | 34 +++++++------- 3 files changed, 47 insertions(+), 46 deletions(-) commit e7ced9b5aeb0f3deb44cec9f16380cb577657bd3 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:09:37 2019 +0000 Run clang-tidy google-readability-namespace-comments on //ui/views This is a run of run-clang-tidy.py -checks="-*,google-readability-namespace-comments" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sky@chromium.org Change-Id: I7450edba832190b3b4d4c4b0aa297865a29905aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529857 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642038} ui/views/button_drag_utils.h | 2 +- ui/views/controls/button/image_button_factory.cc | 2 +- ui/views/controls/button/image_button_factory_unittest.cc | 2 +- ui/views/controls/focus_ring.h | 2 +- ui/views/controls/menu/menu_controller_delegate.h | 2 +- ui/views/controls/table/table_grouper.h | 2 +- ui/views/test/combobox_test_api.cc | 4 ++-- ui/views/test/menu_runner_test_api.cc | 4 ++-- ui/views/test/widget_test_unittest.cc | 2 +- ui/views/views_test_suite.h | 2 +- ui/views/widget/widget_unittest.cc | 4 ++-- ui/views/win/hwnd_util.h | 2 +- 12 files changed, 15 insertions(+), 15 deletions(-) commit ecdab062619a35c079ae341bfb2d9b1fa9faab02 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:08:27 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 This CL was uploaded by git cl split. TBR=aleventhal@chromium.org Change-Id: I189a43a82b012e07a22a3b8695dfd35298aa71f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529914 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642037} ui/views/accessibility/ax_root_obj_wrapper.cc | 2 +- ui/views/accessibility/ax_system_caret_win_interactive_uitest.cc | 6 +++--- ui/views/accessibility/ax_virtual_view_unittest.cc | 2 +- ui/views/accessibility/view_ax_platform_node_delegate_unittest.cc | 2 +- .../accessibility/view_ax_platform_node_delegate_win_unittest.cc | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) commit 5a2cbe8524808aeca1956f57ea67c76b93c6b73e Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:08:13 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 TBR=sadrul@chromium.org This CL was uploaded by git cl split. R=sadrul@chromium.org Change-Id: I81a954e6e1032d4eb883e437e4416bb8a72d635f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529880 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642036} ui/views/controls/webview/webview.cc | 5 ++--- ui/views/controls/webview/webview_unittest.cc | 10 +++++----- 2 files changed, 7 insertions(+), 8 deletions(-) commit a8cf6e1ca5839ad622ab57cbbdffa95d6f2bd55d Author: Brian Sheedy <bsheedy@chromium.org> Date: Tue Mar 19 17:05:54 2019 +0000 Update VR RenderTest Goldens Updates most of the VR RenderTest goldens after the tests started failing due to what looks like slightly different antialiasing behavior. TBR=billorr@chromium.org Bug: 943246 Change-Id: I5c8660ce48b5a69d5d8c1aa377cc25ced99d5b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529129 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#642035} ...st.js_modal_view_vr_confirm_canceled_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...st.js_modal_view_vr_confirm_canceled_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...st.js_modal_view_vr_prompt_submitted_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...st.js_modal_view_vr_prompt_submitted_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...est.camera_permission_prompt_granted_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...est.camera_permission_prompt_granted_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...t.location_permission_prompt_granted_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...t.location_permission_prompt_granted_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...icrophone_permission_indicator_hover_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...icrophone_permission_indicator_hover_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...permission_indicator_hover_incognito_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...permission_indicator_hover_incognito_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...ermission_indicator_hover_reposition_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...ermission_indicator_hover_reposition_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...microphone_permission_prompt_granted_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...microphone_permission_prompt_granted_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ..._permission_prompt_incognito_granted_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ..._permission_prompt_incognito_granted_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ..._permission_prompt_incognito_visible_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ..._permission_prompt_incognito_visible_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...permission_prompt_reposition_granted_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...permission_prompt_reposition_granted_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...permission_prompt_reposition_visible_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...permission_prompt_reposition_visible_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...rowserNativeUiTest.back_button_hover_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...rowserNativeUiTest.back_button_hover_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...veUiTest.back_button_hover_incognito_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...veUiTest.back_button_hover_incognito_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...rowserNativeUiTest.data_url_emphasis_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...rowserNativeUiTest.data_url_emphasis_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...rowserNativeUiTest.file_url_emphasis_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...rowserNativeUiTest.file_url_emphasis_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...UiTest.overflow_menu_hover_incognito_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...UiTest.overflow_menu_hover_incognito_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...rowserNativeUiTest.reposition_bar_keyboard_open.Pixel_XL-25.png.sha1 | 2 +- ...rowserNativeUiTest.reposition_bar_keyboard_open.Pixel_XL-26.png.sha1 | 2 +- ...rBrowserNativeUiTest.repositioned_overflow_menu.Pixel_XL-25.png.sha1 | 2 +- ...rBrowserNativeUiTest.repositioned_overflow_menu.Pixel_XL-26.png.sha1 | 2 +- .../VrBrowserNativeUiTest.scroll_resizing.Pixel_XL-25.png.sha1 | 2 +- .../VrBrowserNativeUiTest.scroll_resizing.Pixel_XL-26.png.sha1 | 2 +- ...wserNativeUiTest.security_icon_hover_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...wserNativeUiTest.security_icon_hover_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...UiTest.security_icon_hover_incognito_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...UiTest.security_icon_hover_incognito_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...rBrowserNativeUiTest.suggestion_clicking_bottom.Pixel_XL-25.png.sha1 | 2 +- ...rBrowserNativeUiTest.suggestion_clicking_bottom.Pixel_XL-26.png.sha1 | 2 +- .../VrBrowserNativeUiTest.suggestion_clicking_left.Pixel_XL-25.png.sha1 | 2 +- .../VrBrowserNativeUiTest.suggestion_clicking_left.Pixel_XL-26.png.sha1 | 2 +- ...VrBrowserNativeUiTest.suggestion_clicking_right.Pixel_XL-25.png.sha1 | 2 +- ...VrBrowserNativeUiTest.suggestion_clicking_right.Pixel_XL-26.png.sha1 | 2 +- .../VrBrowserNativeUiTest.suggestion_clicking_top.Pixel_XL-25.png.sha1 | 2 +- .../VrBrowserNativeUiTest.suggestion_clicking_top.Pixel_XL-26.png.sha1 | 2 +- ...rBrowserNativeUiTest.suggestion_hovering_middle.Pixel_XL-25.png.sha1 | 2 +- ...rBrowserNativeUiTest.suggestion_hovering_middle.Pixel_XL-26.png.sha1 | 2 +- .../VrBrowserNativeUiTest.suggestion_hovering_top.Pixel_XL-25.png.sha1 | 2 +- .../VrBrowserNativeUiTest.suggestion_hovering_top.Pixel_XL-26.png.sha1 | 2 +- .../VrBrowserNativeUiTest.url_bar_hover_browser_ui.Pixel_XL-25.png.sha1 | 2 +- .../VrBrowserNativeUiTest.url_bar_hover_browser_ui.Pixel_XL-26.png.sha1 | 2 +- ...NativeUiTest.url_bar_hover_incognito_browser_ui.Pixel_XL-25.png.sha1 | 2 +- ...NativeUiTest.url_bar_hover_incognito_browser_ui.Pixel_XL-26.png.sha1 | 2 +- 60 files changed, 60 insertions(+), 60 deletions(-) commit 2814fb7d2b44cbddd0f34dcaa22d1b01794ea0e1 Author: Reilly Grant <reillyg@chromium.org> Date: Tue Mar 19 17:04:46 2019 +0000 Reland "[serial] Remove all code from Android Blink build" This reverts commit e4f4664139bfa9511c6b90c14826feb3a73d814a. Reason for revert: Build failure fixed. Original change's description: > Revert "[serial] Remove all code from Android Blink build" > > This reverts commit 5cd5e69c82a5018288f282fb6d918ed0ce6e0f27. > > Reason for revert: Failure on android-rel. > > Original change's description: > > [serial] Remove all code from Android Blink build > > > > This reverts r629504 and instead removes all of the Serial API code from > > the Blink build on Android to further reduce binary size. > > > > Bug: 884928 > > Change-Id: I02cd550753d8020b6f8d796d576ca70caf378e39 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497363 > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#637439} > > TBR=kenrb@chromium.org,reillyg@chromium.org,haraken@chromium.org > > Change-Id: I2ff8c789992ceabfdaa856ec9c0bd6fae268fca0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 884928 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500939 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#637453} TBR=kenrb@chromium.org,reillyg@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 884928 Change-Id: I6b5d786589c28debac3e2ba8ff4b4f1a174b7bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526750 Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#642034} chrome/browser/chrome_content_browser_client.cc | 2 +- .../browser/frame_host/render_frame_host_impl.h | 3 +- third_party/blink/public/mojom/BUILD.gn | 5 +++- .../blink/public/platform/web_runtime_features.h | 1 - third_party/blink/renderer/modules/BUILD.gn | 5 +++- .../blink/renderer/modules/modules_idl_files.gni | 32 ++++++++++++++++++---- third_party/blink/renderer/modules/serial/BUILD.gn | 4 +++ .../platform/exported/web_runtime_features.cc | 4 --- 8 files changed, 41 insertions(+), 15 deletions(-) commit b95d2d4612ef10f1e9043d77e125435a9b1f531e Author: Steven Bennetts <stevenjb@chromium.org> Date: Tue Mar 19 17:03:49 2019 +0000 DBus: Update PowerManagerClient to new pattern This replaces calls to: chromeos::PowerManagerClient::Initialize(nullptr) with: chromeos::PowerManagerClient::InitializeFake() For mechanical changes: TBR=sky@chromium.org Bug: 647367 Change-Id: I1991255f98405f9a5fe1dd25cd9ab67754bd37c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518908 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#642033} ash/ash_service.cc | 5 ++--- .../detachable_base_handler_unittest.cc | 2 +- ash/display/projecting_observer_unittest.cc | 2 +- ash/system/power/power_status_unittest.cc | 2 +- ash/test/ash_test_helper.cc | 2 +- .../arc/arc_migration_guide_notification_unittest.cc | 2 +- .../chromeos/arc/arc_session_manager_unittest.cc | 2 +- .../event_based_status_reporting_service_unittest.cc | 2 +- .../usage_time_state_notifier_unittest.cc | 2 +- chrome/browser/chromeos/dbus/dbus_helper.cc | 5 ++--- .../chromeos/file_manager/volume_manager_unittest.cc | 2 +- .../network_change_manager_client_unittest.cc | 2 +- .../app_install_event_log_collector_unittest.cc | 4 ++-- .../policy/app_install_event_logger_unittest.cc | 3 ++- .../policy/device_status_collector_browsertest.cc | 5 ++--- .../chromeos/policy/status_uploader_unittest.cc | 2 +- .../power/auto_screen_brightness/adapter_unittest.cc | 2 +- .../brightness_monitor_impl_unittest.cc | 2 +- .../metrics_reporter_unittest.cc | 2 +- .../power/extension_event_observer_unittest.cc | 2 +- .../adaptive_screen_brightness_manager_unittest.cc | 2 +- .../power/ml/idle_event_notifier_unittest.cc | 2 +- .../power/ml/user_activity_manager_unittest.cc | 2 +- .../chromeos/power/power_data_collector_unittest.cc | 2 +- .../power/power_metrics_reporter_unittest.cc | 2 +- .../chromeos/power/renderer_freezer_unittest.cc | 2 +- .../chromeos/settings/device_settings_test_helper.cc | 4 ++-- .../system/automatic_reboot_manager_unittest.cc | 2 +- .../chromeos/tether/tether_service_unittest.cc | 2 +- .../chrome_metrics_service_client_unittest.cc | 4 ++-- .../metrics/chromeos_metrics_provider_unittest.cc | 2 +- .../perf/profile_provider_chromeos_unittest.cc | 8 ++++---- .../test/view_event_test_platform_part_chromeos.cc | 2 +- .../encryption_migration_screen_handler_unittest.cc | 5 +---- .../proximity_auth/unlock_manager_impl_unittest.cc | 4 ++-- chromeos/dbus/native_timer_unittest.cc | 2 +- chromeos/dbus/power/fake_power_manager_client.cc | 15 ++++++++------- chromeos/dbus/power/fake_power_manager_client.h | 5 +++-- chromeos/dbus/power/power_manager_client.cc | 20 ++++++++++++-------- chromeos/dbus/power/power_manager_client.h | 14 ++++++++++---- .../dbus/power/power_policy_controller_unittest.cc | 2 +- chromeos/disks/disk_mount_manager_unittest.cc | 2 +- .../platform/power_manager_provider_impl_unittest.cc | 2 +- chromeos/services/assistant/service_unittest.cc | 2 +- chromeos/system/dark_resume_controller_unittest.cc | 2 +- .../arc/metrics/arc_metrics_service_unittest.cc | 2 +- components/arc/power/arc_power_bridge_unittest.cc | 2 +- components/arc/timer/arc_timer_bridge_unittest.cc | 2 +- .../system_power_source_api_unittest.cc | 2 +- extensions/shell/browser/shell_browser_main_parts.cc | 9 +++++++-- .../shell_desktop_controller_aura_unittest.cc | 2 +- media/capture/video/video_capture_device_unittest.cc | 2 +- 52 files changed, 98 insertions(+), 86 deletions(-) commit 3888a7dc6e47ebfc0ff36d11aef570013264b110 Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 17:03:15 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 This CL was uploaded by git cl split. TBR=sadrul@chromium.org Change-Id: Ie9e8876a0053b1fbded992be9aef15ad3d11a3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529881 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#642032} ui/views/button_drag_utils.cc | 5 +- ui/views/controls/button/image_button.cc | 2 +- ui/views/controls/button/image_button_unittest.cc | 12 +- ui/views/controls/button/radio_button.cc | 4 +- ui/views/controls/link.cc | 2 +- .../controls/menu/display_change_listener_aura.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 54 +++--- ui/views/controls/menu/menu_delegate.cc | 2 +- ui/views/controls/menu/menu_host_root_view.cc | 2 +- ui/views/controls/menu/menu_host_root_view.h | 2 +- ui/views/controls/menu/menu_item_view.cc | 32 ++-- .../controls/menu/menu_model_adapter_unittest.cc | 21 ++- ui/views/controls/menu/menu_runner_impl.cc | 2 +- ui/views/controls/menu/submenu_view.cc | 16 +- ui/views/controls/message_box_view.cc | 8 +- ui/views/controls/native/native_view_host.cc | 9 +- ui/views/controls/native/native_view_host_aura.cc | 10 +- .../controls/native/native_view_host_unittest.cc | 8 +- ui/views/controls/scroll_view.cc | 2 +- ui/views/controls/scroll_view_unittest.cc | 24 +-- ui/views/controls/scrollbar/scroll_bar.cc | 5 +- ui/views/controls/slider_unittest.cc | 19 +- ui/views/controls/table/table_header.cc | 2 +- ui/views/controls/table/table_header.h | 2 +- ui/views/controls/table/table_view.cc | 12 +- ui/views/controls/table/table_view_unittest.cc | 20 +- ui/views/controls/table/test_table_model.cc | 4 +- ui/views/controls/tree/tree_view.cc | 51 +++--- ui/views/controls/tree/tree_view_unittest.cc | 8 +- ui/views/corewm/cursor_height_provider_win.cc | 10 +- .../corewm/desktop_capture_controller_unittest.cc | 8 +- ui/views/corewm/tooltip_aura.cc | 13 +- ui/views/corewm/tooltip_controller.cc | 32 ++-- ui/views/corewm/tooltip_controller_unittest.cc | 24 +-- ui/views/corewm/tooltip_win.cc | 22 +-- ui/views/examples/examples_window.cc | 4 +- .../examples/examples_with_content_main_exe.cc | 4 +- ui/views/examples/label_example.cc | 13 +- ui/views/examples/multiline_example.cc | 10 +- ui/views/examples/scroll_view_example.cc | 2 +- ui/views/examples/slider_example.cc | 5 +- ui/views/examples/tabbed_pane_example.cc | 4 +- ui/views/examples/table_example.cc | 5 +- ui/views/examples/webview_example.cc | 5 +- ui/views/examples/widget_example.cc | 7 +- ui/views/focus/focus_manager_unittest.cc | 12 +- ui/views/focus/focus_traversal_unittest.cc | 36 ++-- ui/views/mouse_watcher.h | 2 +- ui/views/test/test_widget_observer.cc | 2 +- ui/views/test/test_widget_observer.h | 2 +- ui/views/test/views_test_helper.cc | 2 +- ui/views/view.cc | 4 +- ui/views/view.h | 5 +- ui/views/view_model.h | 2 +- ui/views/view_targeter.cc | 10 +- ui/views/view_targeter_delegate.cc | 4 +- ui/views/view_targeter_unittest.cc | 26 +-- ui/views/view_unittest.cc | 204 ++++++++++----------- .../desktop_aura/desktop_drag_drop_client_win.cc | 2 +- .../desktop_aura/desktop_focus_rules_unittest.cc | 2 +- .../desktop_aura/desktop_native_widget_aura.cc | 53 +++--- .../desktop_native_widget_aura_unittest.cc | 22 +-- ui/views/widget/desktop_aura/desktop_screen_win.cc | 7 +- .../desktop_aura/desktop_window_tree_host_win.cc | 11 +- ui/views/widget/desktop_widget_unittest.cc | 2 +- ui/views/widget/drop_helper.cc | 15 +- ui/views/widget/native_widget_aura.cc | 24 +-- ui/views/widget/root_view.cc | 66 +++---- ui/views/widget/root_view_targeter.cc | 6 +- ui/views/widget/root_view_unittest.cc | 9 +- ui/views/widget/tooltip_manager_aura.cc | 6 +- ui/views/widget/widget.cc | 22 +-- ui/views/widget/widget.h | 2 +- ui/views/widget/widget_delegate.cc | 4 +- ui/views/widget/widget_deletion_observer.cc | 2 +- ui/views/widget/widget_deletion_observer.h | 2 +- ui/views/widget/widget_interactive_uitest.cc | 24 +-- ui/views/widget/widget_unittest.cc | 50 +++-- ui/views/widget/window_reorderer.cc | 4 +- ui/views/widget/window_reorderer_unittest.cc | 2 +- ui/views/win/fullscreen_handler.cc | 8 +- ui/views/win/hwnd_message_handler.cc | 84 ++++----- ui/views/win/hwnd_util_aurawin.cc | 11 +- ui/views/win/scoped_fullscreen_visibility.cc | 8 +- ui/views/window/client_view.cc | 4 +- ui/views/window/custom_frame_view.cc | 25 ++- ui/views/window/dialog_client_view_unittest.cc | 16 +- ui/views/window/dialog_delegate.cc | 12 +- ui/views/window/window_button_order_provider.cc | 2 +- 89 files changed, 652 insertions(+), 676 deletions(-) commit e0775cd011fa416787523a9a3e934dc643675212 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Mar 19 17:02:43 2019 +0000 [iOS] Disabling UseNSURLSessionForGaiaSigninRequests flag by default Gaia auth fetcher using NSURLSession makes issue for gmail.com to detect with the user is signed out. Bug: 939508 Change-Id: Ib2f9e8f99e66d2faf8b8c5b51dfa8c1783451ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530902 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#642031} ios/chrome/browser/signin/feature_flags.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit bee45abe49cd5b3c8252970f48fc21468c9ac37b Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Mar 19 17:02:10 2019 +0000 [Media Notification] Add source icon Add a new kSourceIcon image type that will be used for the icon associated with the source of the media session (e.g. app icon). Adds code to display it on the media notification. BUG=928369 Change-Id: I0a2979e9154d29f361373726e5ae1ca7799d1187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524031 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#642030} ash/media/media_notification_item.cc | 24 +++++++++++++++--- ash/media/media_notification_item.h | 5 ++++ ash/media/media_notification_view.cc | 9 +++++++ ash/media/media_notification_view.h | 1 + ash/media/media_notification_view_unittest.cc | 29 ++++++++++++++++++++++ .../media_session/public/mojom/media_session.mojom | 5 +++- .../views/notification_header_view.cc | 4 +++ ui/message_center/views/notification_header_view.h | 2 ++ 8 files changed, 74 insertions(+), 5 deletions(-) commit 9b6bab205ab0a9e2d6ecc6c57d13f057f12f83eb Author: Jun Mukai <mukai@chromium.org> Date: Tue Mar 19 17:01:14 2019 +0000 Remove WindowTreeClient::OnWindowOpacityChanged This is not used actually (nobody calls this method), and actually this is not necessary at all. Simply removing it. Bug: 940533 Test: build passes Change-Id: I3bb3a588db35f68e4a6b1692ca9af31ffb3069e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529631 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642029} content/renderer/mus/renderer_window_tree_client.cc | 3 --- content/renderer/mus/renderer_window_tree_client.h | 2 -- services/ws/public/mojom/window_tree.mojom | 3 --- services/ws/test_change_tracker.cc | 12 ------------ services/ws/test_change_tracker.h | 3 --- services/ws/test_window_tree_client.cc | 5 ----- services/ws/test_window_tree_client.h | 2 -- services/ws/window_tree_client_unittest.cc | 4 ---- ui/aura/mus/in_flight_change.cc | 18 ------------------ ui/aura/mus/in_flight_change.h | 15 --------------- ui/aura/mus/window_mus.h | 1 - ui/aura/mus/window_port_mus.cc | 4 ---- ui/aura/mus/window_port_mus.h | 1 - ui/aura/mus/window_tree_client.cc | 13 ------------- ui/aura/mus/window_tree_client.h | 2 -- 15 files changed, 88 deletions(-) commit c6b3edf7d56fa16189b6df48833f7c03aa46364f Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 17:00:39 2019 +0000 SocketPools: group_name to GroupId conversion part 3. This CL makes client_socket_pool_base_unittest use GroupIds instead of group names. Bug: 533571 Change-Id: I2d3e1d792f1cf21d9af16b812422b3a942a26a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526167 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642028} net/socket/client_socket_pool_base_unittest.cc | 1872 ++++++++++++------------ 1 file changed, 975 insertions(+), 897 deletions(-) commit 1b9a5fe80e8036e01eba73bc569d32dd773d6338 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 16:57:42 2019 +0000 Roll src/third_party/angle 38e282570676..9b050f846a06 (7 commits) https://chromium.googlesource.com/angle/angle.git/+log/38e282570676..9b050f846a06 git log 38e282570676..9b050f846a06 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 jiajia.qin@intel.com Fix that 0 is a valid memory barrier 2019-03-18 syoussefi@chromium.org Prefix glmark2 perf results with glmark2_ 2019-03-18 agrieve@chromium.org Add COMPONENT to OWNERS 2019-03-18 syoussefi@chromium.org Add missing entries in texture load functions map 2019-03-18 jonahr@google.com gl_VertexID is incorrect if offset argument to glDrawArrays is non-zero 2019-03-18 jmadill@chromium.org Add a helper script for triggering tests on swarming. 2019-03-18 syoussefi@chromium.org Add instructions on how to run ANGLE under RenderDoc Created with: gclient setdep -r src/third_party/angle@9b050f846a06 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I464840e78b47b165ab42093e6f8a7e13ebc83811 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529935 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642027} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1d0457b0ab00c9eee98948eee48ae12b334c9e5e Author: Sam Maier <smaier@chromium.org> Date: Tue Mar 19 16:56:54 2019 +0000 Upstreaming some proguard flags which R8 supports Bug: 942668 Change-Id: Ib54a09e087975d61dba5ba0324fd89ed831231a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527877 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#642026} build/android/gyp/proguard.py | 46 +++++++++++++++------- build/config/android/rules.gni | 22 +++++++++-- chrome/android/BUILD.gn | 4 ++ .../monochrome_public_apk.proguard_flags.expected | 28 +++++++++++++ chrome/android/java/proguard.flags | 21 ++++++++++ 5 files changed, 103 insertions(+), 18 deletions(-) commit 834cae0c315b887b6c9391deb257790910c4c116 Author: Jun Mukai <mukai@chromium.org> Date: Tue Mar 19 16:56:04 2019 +0000 Adjust drag_offset when the moving window bounds is adjusted When tab-dragging causes to move the dragged window, the initial bounds is created as CreateBrowserForDrag(), and drag_offset is computed at this point. However sometimes AdjustBrowserAndTabBoundsForDrag() can be called, which changes the browser's position slightly, yet drag-offset stays same. This causes the inconsistency between the expected window position and offset, and so the reported troubles happen. AdjustBrowserAndTabBoundsForDrag() should take the current drag_offset, and when bounds is adjusted, it should also recompute the drag_offset. Bug: 942238 Test: new cases in interactive_ui_tests Change-Id: I1f929b27d12f32edf2861706f09b621c66bebd83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526601 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642025} .../browser/ui/views/tabs/tab_drag_controller.cc | 18 ++--- chrome/browser/ui/views/tabs/tab_drag_controller.h | 4 ++ .../tabs/tab_drag_controller_interactive_uitest.cc | 78 ++++++++++++++++++++++ 3 files changed, 92 insertions(+), 8 deletions(-) commit fc77d1fe0125345699914259c491f8829d951ecb Author: Matt Mueller <mattm@chromium.org> Date: Tue Mar 19 16:52:58 2019 +0000 Remove public-key-pins from non-cachable headers list. HPKP support was removed in 230996f1 (m72). Bug: 893055 Change-Id: I10ac6d8c7420b5017d453246aa6eb4d2bfd43eb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521788 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642024} net/http/http_response_headers.cc | 10 +++------- net/http/http_response_headers_unittest.cc | 5 +---- 2 files changed, 4 insertions(+), 11 deletions(-) commit 1d52abab07ca3f3685986a2770a8d80cd7294ac3 Author: Maksim Moskvitin <mmoskvitin@google.com> Date: Tue Mar 19 16:52:10 2019 +0000 [Sync:USS] Extract KeystoreKeysHandler interface KeystoreKeysHandler interface is a small interface that allows handling of Nigori keystore keys. It was a part of NigoriHandler. Extraction allows coexistence of USS and directory Nigori implementation. Directory transactions which used to be arguments of extracted methods are created now inside directory implementation (SyncEncryptionHandlerImpl). Bug: 922900 Change-Id: I46c9c7f3031ad389195d49a5d8f60fc0fbee227f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528611 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#642023} components/sync/BUILD.gn | 1 + components/sync/engine_impl/DEPS | 1 + .../sync/engine_impl/get_updates_processor.cc | 22 +- components/sync/engine_impl/model_type_registry.cc | 9 +- components/sync/engine_impl/model_type_registry.h | 15 +- .../engine_impl/model_type_registry_unittest.cc | 2 +- .../engine_impl/sync_encryption_handler_impl.cc | 15 +- .../engine_impl/sync_encryption_handler_impl.h | 17 +- .../sync_encryption_handler_impl_unittest.cc | 324 +++++++++------------ components/sync/engine_impl/sync_manager_impl.cc | 2 +- .../engine_impl/sync_scheduler_impl_unittest.cc | 3 +- components/sync/engine_impl/syncer_unittest.cc | 27 +- components/sync/nigori/keystore_keys_handler.h | 35 +++ components/sync/syncable/nigori_handler.h | 17 -- components/sync/syncable/test_user_share.cc | 4 + components/sync/syncable/test_user_share.h | 8 + .../sync/test/engine/test_directory_setter_upper.h | 2 + .../sync/test/fake_sync_encryption_handler.cc | 6 +- .../sync/test/fake_sync_encryption_handler.h | 13 +- 19 files changed, 252 insertions(+), 271 deletions(-) commit b77882136ef62f12516bb79b89a7f72bcb06af95 Author: liberato@chromium.org <liberato@chromium.org> Date: Tue Mar 19 16:51:51 2019 +0000 Roll src/third_party/ffmpeg/ 7e1e8a4f7..f5b197fe6 (2 commits) https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/7e1e8a4f7df4..f5b197fe6699 $ git log 7e1e8a4f7..f5b197fe6 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 liberato Updated patches file. 2019-03-04 liberato Check return value of avio_read(). Created with: roll-dep src/third_party/ffmpeg Bug: 937663 Change-Id: Ic9730b4a8e4c1da057e1adf65fe4b8ef48f123f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529112 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#642022} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 538130e33c4936fa7ec68adb61210b6ef50b90e0 Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Mar 19 16:50:36 2019 +0000 [Background Sync] Remove unnecessary logging. This removes some unused logging, per guidelines here: https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md#logging Bug: 932591 Change-Id: I6f99412b7834716e5a13ab6f83c80bd09f2967ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528536 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#642021} content/browser/background_sync/background_sync_manager.cc | 4 ---- 1 file changed, 4 deletions(-) commit a0125b0d47d4c64e095861939779c3fd000c2f8e Author: Martin Robinson <mrobinson@igalia.com> Date: Tue Mar 19 16:50:19 2019 +0000 Fix lint errors in accessibility code This makes it easier to spot problems when using "git cl lint." Bug: 942472 Change-Id: I4283db3a8bb13f87e9fd30aef55f818b51d11493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524276 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#642020} .../accessibility/browser_accessibility_com_win.cc | 39 +++++++++++----------- .../accessibility/browser_accessibility_com_win.h | 36 ++++++++++---------- .../platform/ax_platform_node_auralinux.cc | 4 +-- 3 files changed, 39 insertions(+), 40 deletions(-) commit 4585663b43ffb02972f002764c9e8d2bb70ae61a Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 16:48:47 2019 +0000 Allow .pydeps files to detect use of vpython Switches test_runner.py and run_py_tests.py to run using vpython. Their use of "psutil" makes me think this is necessary (plus the breakage in bug 930538). Bug: 930752, 930538 Change-Id: Iacdb517aa0fc7c1f799b1cd5105fa16a4c59cd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1464639 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#642019} build/android/test_runner.py | 2 +- build/print_python_deps.py | 19 ++++++++++++++----- chrome/test/chromedriver/test/run_py_tests.py | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) commit d7ccf26595db8a0501b2917e7cdfd497ba1589ba Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Mar 19 16:47:35 2019 +0000 Roll src-internal 6abdbc905c14..3fe9205c384b (6 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6abdbc905c14..3fe9205c384b Created with: gclient setdep -r src-internal@3fe9205c384b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I3df1d4c0f2de0130de6ca636842554cc28265b8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530124 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#642018} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 035b9917093b752a8bc3e1e5f0a55f28877e535f Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Mar 19 16:47:27 2019 +0000 [LevelDBScopes] Improving testing & factory classes There isn't a great way to 'shut down' a leveldb instance if it is being used on multiple threads, and there isn't a great way to supply a mock database. This patch adds both of those things. Bug: 862456 Change-Id: I84ed0d1ef2ca77a2058945bebc6e03dadcb9fd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521436 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642017} .../indexed_db/indexed_db_leveldb_operations.cc | 12 +- .../indexed_db_tombstone_sweeper_unittest.cc | 2 +- .../indexed_db/leveldb/fake_leveldb_factory.cc | 182 ++++++++++++++++++++- .../indexed_db/leveldb/fake_leveldb_factory.h | 37 ++++- content/browser/indexed_db/leveldb/leveldb_env.cc | 38 +++-- content/browser/indexed_db/leveldb/leveldb_env.h | 51 ++++-- .../indexed_db/leveldb/leveldb_env_unittest.cc | 2 +- .../leveldb/leveldb_transaction_unittest.cc | 2 +- .../browser/indexed_db/leveldb/leveldb_unittest.cc | 2 +- content/browser/indexed_db/scopes/leveldb_state.cc | 23 ++- content/browser/indexed_db/scopes/leveldb_state.h | 32 +++- 11 files changed, 321 insertions(+), 62 deletions(-) commit 6959858eb5c5deb2776ddc8e46a8f40beaa91858 Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 16:42:48 2019 +0000 SocketPools: group_name to GroupId conversion part 2. This CL makes most net unit tests of the SocketPool layer use GroupIds instead of group name. The exceptions are tests that mock out socket pools themselves, as this CL is still relying on implicit GroupId to std::string conversion. Bug: 533571 Change-Id: Ie46e23e5e76e68e56652739bb51ba18226de5ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526162 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642016} net/http/http_proxy_client_socket_pool_unittest.cc | 22 ++++---- net/spdy/spdy_session_unittest.cc | 60 ++++++++++++---------- net/spdy/spdy_test_util_common.cc | 4 +- .../http_with_dns_over_https_unittest.cc | 7 +-- .../websocket_basic_stream_adapters_test.cc | 6 +-- net/websockets/websocket_basic_stream_test.cc | 5 +- ...ebsocket_handshake_stream_create_helper_test.cc | 6 ++- 7 files changed, 61 insertions(+), 49 deletions(-) commit fc6ddb2216dd6a986a3d632bdaa0038dd1254d37 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 19 16:41:07 2019 +0000 [iOS] Remove/rename todo 894791 This CL removes or change the bug numbers associated with the todo previously linking to crbug.com/894791. It allows us to close the bug and have more precises bugs with the todo. Bug: 894791 Change-Id: Id53cc1e1ea11af23d016996dd17ff7876125d2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529068 Reviewed-by: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#642015} .../settings/password/password_details_table_view_controller+testing.h | 2 +- ios/chrome/browser/ui/table_view/cells/table_view_text_item.mm | 1 - ios/chrome/browser/ui/table_view/chrome_table_view_controller_test.mm | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) commit d678615b41f85728f312102f8c00ef930dbcea6b Author: Mark Cogan <marq@google.com> Date: Tue Mar 19 16:39:21 2019 +0000 [iOS] Remove @optional from LocationBarGenericCoordinator This CL resolves the TODO in LocationBarGenericCoordinator, removing the @optional marker from that protocol, since all call sites treat those methods as being non-optional. Bug: 831506 Change-Id: Ibde0ca1d44ec355b7845f57f572f062114d7fb10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530762 Auto-Submit: Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#642014} ios/chrome/browser/ui/location_bar/location_bar_generic_coordinator.h | 4 ---- 1 file changed, 4 deletions(-) commit 55907936f4def4467fc70a71e3160df5af9f5630 Author: sczs <sczs@chromium.org> Date: Tue Mar 19 16:34:59 2019 +0000 [iOS]Animates locationBarView leading button alpha for Fullscreen Bug: 911864 Change-Id: Ied21b2719bc4e133ab6f45dfe38cfa7129703607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529749 Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#642013} ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm | 3 +++ 1 file changed, 3 insertions(+) commit 0734416591140b1370b7bd5837746eddb146d863 Author: Matt Menke <mmenke@chromium.org> Date: Tue Mar 19 16:34:00 2019 +0000 SocketPools: group_name to GroupId conversion part 1. Introduce ClientSocketPool::GroupId class, to replace string group_names. This CL does not make ClientSocketPool take GroupIds as an argument, instead it uses an implicit GroupId to string conversion, and updates some tests and ClientSocketPoolManager to pass in GroupIds to APIs that take in string group_names. Updating consumers first because conversion from GroupId to std::string is simpler than the other way around. The implicit conversion operator will be removed in a followup CL in which the SocketPools themselves are updated to take GroupIds, after all consumers have been converted. Bug: 533571 Change-Id: I013a23ae9211ac3d038f41abd13d0de42a229611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524977 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642012} net/BUILD.gn | 1 + net/socket/client_socket_pool.cc | 46 ++++ net/socket/client_socket_pool.h | 66 +++++ net/socket/client_socket_pool_manager.cc | 27 +- net/socket/client_socket_pool_unittest.cc | 124 +++++++++ net/socket/socket_test_util.h | 22 ++ .../transport_client_socket_pool_unittest.cc | 289 ++++++++++++--------- ...socket_transport_client_socket_pool_unittest.cc | 241 ++++++++--------- 8 files changed, 561 insertions(+), 255 deletions(-) commit 4f123ff27bd3ca8f6544844b3e33df3569366b2e Author: Clemens Arbesser <arbesser@google.com> Date: Tue Mar 19 16:33:55 2019 +0000 [Autofill Assistant] Removed default case from action switch/case. This ensures that compilation will fail if new actions are added to the proto but not to the switch-case. Bug: 806868 Change-Id: Iac64fc3f4cb9a9f4490998a911a6170db6ddd551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528973 Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#642011} .../autofill_assistant/browser/protocol_utils.cc | 54 ++++++++++++---------- 1 file changed, 30 insertions(+), 24 deletions(-) commit a6c40fb646207add8b1d4260c20d506fb9dcdbbe Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 16:32:12 2019 +0000 Android: Include missing classes in ClassPathValidator failures It was already possible to find this by running in verbose mode, but this should make it easier for bot messages. Removed the failure count because it didn't actually count the number of missing classes nor the number of missing jars (but rather how many classes failed to load). Example output: Direct classpath is incomplete. To fix, add GN deps on the target(s) that provide: * gen/base/base_java.javac.jar * org.chromium.base.Log (needed by org.chromium.chrome.browser.media.RouterTestUtils$1 and 1 more) * org.chromium.base.ThreadUtils (needed by org.chromium.chrome.browser.customtabs.CustomTabsTestUtils and 1 more) * gen/third_party/android_deps/com_android_support_support_fragment_java/classes.jar * android.support.v4.app.DialogFragment (needed by org.chromium.chrome.browser.media.RouterTestUtils) * gen/third_party/junit/junit.javac.jar * org.junit.Assert (needed by org.chromium.chrome.browser.customtabs.CustomTabActivityTestRule and 1 more) * org.junit.runners.model.Statement (needed by org.chromium.chrome.browser.webapps.WebappActivityTestRule$1) Bug: 898251 Change-Id: Ib254fa5aa19c637cee96f604bb4aba018998f44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529440 Reviewed-by: Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#642010} .../org/chromium/bytecode/ByteCodeProcessor.java | 40 +++++++++++++++++++--- .../org/chromium/bytecode/ClassPathValidator.java | 36 +++++++++++++------ 2 files changed, 60 insertions(+), 16 deletions(-) commit 0370210479bd7d6d9375052bee86760e369decb9 Author: Peng Huang <penghuang@chromium.org> Date: Tue Mar 19 16:31:28 2019 +0000 WebView: Add Vulkan direct draw mode In Vulkan direct mode, we will use Vulkan API to render the frame directly. Known issues: * SharedImage doesn't support sharing AHB cross Vulkan devices. * SkiaOutputSurfaceImpl doesn't work. It is still using Vulkan swap chain. Bug: 939842 Change-Id: Ic399193c886e574044f1308f86be70b5cbaeea09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515413 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#642009} android_webview/browser/gfx/aw_draw_fn_impl.cc | 331 ++++++++++++++------- android_webview/browser/gfx/aw_draw_fn_impl.h | 43 ++- .../browser/gfx/aw_vulkan_context_provider.cc | 1 + .../browser/gfx/aw_vulkan_context_provider.h | 2 +- android_webview/browser/gfx/hardware_renderer.cc | 23 +- android_webview/browser/gfx/hardware_renderer.h | 5 +- android_webview/browser/gfx/surfaces_instance.cc | 24 +- android_webview/browser/gfx/surfaces_instance.h | 9 +- android_webview/common/aw_switches.cc | 3 + android_webview/common/aw_switches.h | 1 + .../skia_output_surface_impl_non_ddl.cc | 118 +++++--- .../skia_output_surface_impl_non_ddl.h | 10 + 12 files changed, 393 insertions(+), 177 deletions(-) commit 636083fe8dfd36a2e1d4133b0c9c175a6eac1650 Author: Oystein Eftevaag <oysteine@google.com> Date: Tue Mar 19 16:30:58 2019 +0000 Tracing: Stop tracing if tracing service disconnects. This normally happens if the utility process that runs the service gets killed; if we're tracing when this happens, we stop tracing or we'll eventually run out of buffer space and stall. Also: Match PerfettoTracingCoordinator::StopTracing semantics on duplicate calls match the legacy Coordinator::StopTracing semantics; some devtools tests are relying on this. R=ssid@chromium.org Bug: 941472,943048 Change-Id: I77206bd57f98922dc5ff5fce2971bd842ece241a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526425 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#642008} content/browser/tracing/tracing_controller_impl.cc | 6 +----- services/tracing/perfetto/perfetto_tracing_coordinator.cc | 12 +++++++++++- services/tracing/public/cpp/base_agent.cc | 8 ++++++++ 3 files changed, 20 insertions(+), 6 deletions(-) commit f80452bd89c92a28a9e911bb8f44af000ba51991 Author: Oystein Eftevaag <oysteine@google.com> Date: Tue Mar 19 16:30:22 2019 +0000 Background tracing: Refactored active scenario into separate class Cleaned up the BackgroundTracingManager and prepared it for Perfetto support by moving all of the state related to an ongoing tracing scenario into a separate class. Also removed an unused feature to enable/disable Blink features in a background tracing config. TBR=nasko@chromium.org Change-Id: I1f218b1eb4dd93f89d4be4f2651bbf921259b0e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525471 Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#642007} .../tracing/chrome_tracing_delegate_browsertest.cc | 16 + content/browser/BUILD.gn | 2 + .../tracing/background_tracing_active_scenario.cc | 408 +++++++++++++ .../tracing/background_tracing_active_scenario.h | 92 +++ .../tracing/background_tracing_config_impl.cc | 105 +++- .../tracing/background_tracing_config_impl.h | 14 +- .../tracing/background_tracing_config_unittest.cc | 34 -- .../background_tracing_manager_browsertest.cc | 250 ++------ .../tracing/background_tracing_manager_impl.cc | 636 ++++----------------- .../tracing/background_tracing_manager_impl.h | 108 ++-- .../public/browser/background_tracing_manager.h | 2 - 11 files changed, 812 insertions(+), 855 deletions(-) commit ac2a8b89953efa6d717c2e8be95881e24d0a0011 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Mar 19 16:29:23 2019 +0000 [iOS][Translate] Fixes bugs with new translate infobar auto-never translate 1. Denied count was being incremented via TranslateInfoBarDelegate::InfoBarDismissed before the check for auto never translate which resulted in fewer tries needed to activate it. 2. Infobar was not being dismissed if the user pressed "Undo" on the auto never translate notification snackbar. TBR=anthonyvd@ Bug: 943553,910994 Change-Id: I7692f5ea5b7ca8b0abbefcefb4a451821b4d7583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529178 Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#642006} ios/chrome/browser/translate/translate_infobar_controller.mm | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit de85a97ece53d5b8a10b380504c811f2f91d4bfa Author: David Benjamin <davidben@chromium.org> Date: Tue Mar 19 16:25:50 2019 +0000 Remove Channel ID flags. This gets them out of SSLConfig and HttpNetworkSession::Params. One less thing to worry about in upcoming socket pool work. Bug: 875053 Change-Id: I38bdfaf8fd1e1f5355e5f2b48a906ba0ff5d407e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529587 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by: Nick Harper <nharper@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#642005} net/http/http_network_session.cc | 7 ---- net/http/http_network_session.h | 3 -- net/http/http_network_transaction_ssl_unittest.cc | 17 -------- net/http/http_stream_factory_job.cc | 4 -- net/http/http_stream_factory_unittest.cc | 47 ----------------------- net/socket/ssl_server_socket_unittest.cc | 1 - net/ssl/ssl_config.cc | 1 - net/ssl/ssl_config.h | 2 - net/ssl/ssl_config_service.cc | 8 ++-- net/ssl/ssl_config_service.h | 1 - 10 files changed, 4 insertions(+), 87 deletions(-) commit 5fed565cbe100211c675a403eb0f713dd77b8ecc Author: Katie D <katie@chromium.org> Date: Tue Mar 19 16:20:45 2019 +0000 Remove trailing whitespace and punctuation in image annotation strings. Bug: 905419 Change-Id: I20a46bd21e0d9ea91dbb6a067290ca494afeffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516652 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#642004} .../accessibility/image_annotation_browsertest.cc | 13 +++++++++++-- content/renderer/accessibility/ax_image_annotator.cc | 18 +++++++++++++++--- 2 files changed, 26 insertions(+), 5 deletions(-) commit 722749381fab9c11055e9f34bbb4da2b1aeb5ab6 Author: Collin Baker <collinbaker@chromium.org> Date: Tue Mar 19 16:18:45 2019 +0000 Explicitly track reason for View layer painting Previously, the reason for a View painting to a layer was implicit based on the presence of a layer and the flag paint_to_layer_ (which was used with different semantics in different places). This explicitly keeps track of the reason for painting to a layer with flags, and centralizes the code for creating and destroying layers based on these flags. This is in preparation for InstallableInkDrops which will add yet another reason for a View to implicitly paint to a layer. This also fixes an apparent bug where setting an identity transform on a View after calling SetPaintToLayer() would cause the layer to be improperly destroyed. Bug: 931964 Change-Id: I5fa56d04bfa79b44a92429fb0307dc470ab8dff2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525011 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642003} ui/views/view.cc | 45 ++++++++++++++++++++++------------ ui/views/view.h | 16 +++++++++--- ui/views/view_unittest.cc | 62 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 103 insertions(+), 20 deletions(-) commit 9f1465fc2d48f0b57fcd3bddc9da45946c97fe5d Author: rbpotter <rbpotter@chromium.org> Date: Tue Mar 19 16:17:35 2019 +0000 Custom Margins: Default to 0 for missing values Tolerate non-existent custom margins values in C++, by setting the margin field to 0 if it does not exist. This will prevent the crashes in the linked bug, and is safer than merging larger changes to the Print Preview JS that will prevent this from happening. This is a short term workaround; we will change this back to a stricter check after landing larger changes in Print Preview JS to prevent bad custom margin values from being sent. Bug: 942211 Change-Id: I978fdf65519efc0d6a0d6379c2266e330908fc0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529314 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#642002} printing/print_settings_conversion.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 285c0a320262d72c4861686c0e670e2db0c90a26 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Mar 19 16:16:56 2019 +0000 flags: assign enable-content-suggestions-thumbnail-dominant-color Bug: None Change-Id: I6fc88ea908bc839fa6b5bd2fb483a2f817e83afb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529923 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#642001} chrome/browser/flag-metadata.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3dfc1a20e8cfe6f0450cea1dcb2623886e1c238c Author: Henrik Grunell <grunell@chromium.org> Date: Tue Mar 19 16:16:09 2019 +0000 Update WebRTC text logging histogram enum. Bug: None Change-Id: Ia1a8eb74c38f461330db57c8e998cfd6667d5fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529001 Reviewed-by: Oskar Sundbom <ossu@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#642000} tools/metrics/histograms/enums.xml | 1 + 1 file changed, 1 insertion(+) commit 95f379aedb17b6853921118597a499abfd9c3872 Author: Colin Blundell <blundell@chromium.org> Date: Tue Mar 19 16:15:43 2019 +0000 IdentityManager: Remove legacy API call from InlineLoginHandlerImpl InlineLoginHandlerImpl seeds account info with IdentityManager without actually adding the account. This is a legacy API surface that was added during the transition to IdentityManager, but is not a long-term supported usage mode. This call is in fact unnecessary (thanks to droger@ for the below reasoning): "There are two cases here: UNLOCK (which is a reauth, line 390) and FORCED_SIGNIN which is a new signin (line 413). In the UNLOCK case, the call to AddOrUpdateAccount() below (line 391) is only there to update the token. The account should already been known to Chrome. In the FORCED_SIGNIN case, which is the "else" clause on line 413, the account will be added in the CreateSyncStarter() method (line 459) unless we are in the edge case where the user doesn't confirm the untrusted signin (line 435). In this edge case, there may be a difference in behavior: in the existing code, the account remains in Chrome but has no token. If we just delete the code, the account is not present in Chrome in any fashion. I think the latter is what we want." This reasoning is particularly compelling when considering the fact that IdentityManager by design does not even expose accounts that are seeded but have no refresh token (i.e., there is no way for clients of IdentityManager to see these accounts). Change-Id: I0528395282083f43b06bb65ba44066a40bc922d7 Bug: 922026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524490 Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Owen Min <zmin@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641999} chrome/browser/ui/webui/signin/inline_login_handler_impl.cc | 6 ------ 1 file changed, 6 deletions(-) commit f00eff0e3a719d266e8e92f2fbb3199200f3dce3 Author: Tarun Bansal <tbansal@chromium.org> Date: Tue Mar 19 16:15:05 2019 +0000 Rename enum name in PrerenderManagerMode Rename the name of the enum in PrerenderManagerMode. The CL makes no functional changes. Rename the variable to explicitly Mark the mode as DEPRECATED since this mode is no longer supported. Change-Id: I763aeaa3ec4b5c25fd7514c48d33ebd23e922dd1 Bug: 755921 TBR: rdevlin.cronin@chromium.org,fdoray@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1493300 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641998} .../browser/extensions/activity_log/activity_log_browsertest.cc | 2 +- chrome/browser/extensions/activity_log/activity_log_unittest.cc | 2 +- .../extensions/bookmark_app_navigation_throttle_browsertest.cc | 2 +- chrome/browser/prerender/prerender_browsertest.cc | 2 +- chrome/browser/prerender/prerender_manager.cc | 8 +++++--- chrome/browser/prerender/prerender_manager.h | 2 +- chrome/browser/resource_coordinator/tab_load_tracker_unittest.cc | 2 +- 7 files changed, 11 insertions(+), 9 deletions(-) commit f77105925af12c907751883a4a858f1609522760 Author: Niels Möller <nisse@chromium.org> Date: Tue Mar 19 16:14:38 2019 +0000 Use webrtc::VideoFrameType rather than webrtc::FrameType Intended to enable landing of https://webrtc-review.googlesource.com/c/src/+/126225 Bug: webrtc:5876 Change-Id: Ib6ecc94d5af7e7fe1588a2c229872e41ffcc64f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526273 Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Niels Möller <nisse@chromium.org> Cr-Commit-Position: refs/heads/master@{#641997} content/renderer/media/webrtc/rtc_video_decoder.cc | 11 +++++------ content/renderer/media/webrtc/rtc_video_decoder_adapter.cc | 2 +- .../media/webrtc/rtc_video_decoder_adapter_unittest.cc | 2 +- content/renderer/media/webrtc/rtc_video_decoder_unittest.cc | 8 ++++---- content/renderer/media/webrtc/rtc_video_encoder.cc | 10 ++++++---- remoting/protocol/webrtc_dummy_video_encoder.cc | 5 +++-- 6 files changed, 20 insertions(+), 18 deletions(-) commit 21bb0bf0f215f443db55a418ee181187c73c0cf8 Author: David Bertoni <dbertoni@chromium.org> Date: Tue Mar 19 16:14:00 2019 +0000 [Extensions] Context menu tests cleanup. Change all context meny browser tests to use "scripts" instead of "page" for "background" to match the service worker tests. We will eventually unify these two sets of tests by generating a manifest file on the fly with the appropriate key to run either a background page-based or service worker-based test. All uses of window.onload were removed, since service workers don't have a window object. Bug: 939664 Change-Id: I5d793f19c3bf939a0c151b4833e0128c964bc6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521710 Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#641996} .../extensions/context_menus/checkboxes/test.js | 16 ++++----- .../context_menus/enabled/background.html | 6 ---- .../extensions/context_menus/enabled/manifest.json | 4 +-- .../context_menus/frames/background.html | 1 - .../extensions/context_menus/frames/manifest.json | 4 +-- .../data/extensions/context_menus/frames/test.js | 39 +++++++++++----------- .../context_menus/incognito/background.html | 1 - .../context_menus/incognito/manifest.json | 4 +-- .../extensions/context_menus/incognito/test.js | 14 ++++---- .../context_menus/long_title/background.html | 1 - .../context_menus/long_title/manifest.json | 4 +-- .../extensions/context_menus/long_title/test.js | 22 ++++++------ .../extensions/context_menus/onclick_null/test.js | 16 ++++----- .../context_menus/patterns/background.html | 1 - .../context_menus/patterns/manifest.json | 4 +-- .../extensions/context_menus/patterns/test.html | 5 --- .../data/extensions/context_menus/patterns/test.js | 30 ++++++++--------- .../extensions/context_menus/radio_check/test.js | 24 ++++++------- .../context_menus/simple/background.html | 1 - .../extensions/context_menus/simple/manifest.json | 4 +-- .../data/extensions/context_menus/simple/test.js | 14 ++++---- .../context_menus/target_urls/background.html | 1 - .../context_menus/target_urls/manifest.json | 4 +-- .../extensions/context_menus/target_urls/test.js | 17 +++++----- .../context_menus/top_level/multi4/background.js | 20 +++++------ .../context_menus/top_level/multi5/background.js | 20 +++++------ .../context_menus/top_level/single1/background.js | 12 +++---- .../context_menus/top_level/single2/background.js | 12 +++---- .../context_menus/top_level/single3/background.js | 12 +++---- 29 files changed, 127 insertions(+), 186 deletions(-) commit f73736c9ed0fdafeb367cde2fe95702797a1c6d0 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Mar 19 16:13:33 2019 +0000 Add children() and FindChild() methods to View. Make use of these in a few places to reduce use of index-based APIs or improve efficiency. Bug: 940135, 942969 Change-Id: I879bec72ed25bfb2b2a1ee508fb798f76124f72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526628 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641995} ash/app_list/views/apps_grid_view_unittest.cc | 12 ++++---- .../views/bookmarks/bookmark_bar_view_unittest.cc | 20 ++++++------- .../ui/views/frame/browser_view_unittest.cc | 16 +++++----- chrome/browser/ui/views/infobars/infobar_view.cc | 3 +- chrome/browser/ui/views/tabs/tab_strip_unittest.cc | 2 +- ui/views/controls/menu/menu_controller.cc | 34 +++++++++++++--------- ui/views/controls/menu/menu_item_view.cc | 4 +-- ui/views/view.cc | 6 +++- ui/views/view.h | 8 +++++ ui/views/view_unittest.cc | 5 ++-- 10 files changed, 63 insertions(+), 47 deletions(-) commit 440e6f56d8a8a86400a7c01ddcd7dc2a8ea027a8 Author: kdillon <kdillon@chromium.org> Date: Tue Mar 19 16:12:52 2019 +0000 Removing redundant tests from fast/workers. Removing redundant tests created by this cl: https://chromium-review.googlesource.com/c/chromium/src/+/1412827 These tests have equivalents in external/wpt/workers. Bug: 795636 Change-Id: I274cd39d51d71ace07e630da2cec59c1d10e9a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529747 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#641994} .../fast/workers/resources/worker-location.js | 34 ---------------------- .../fast/workers/resources/worker-navigator.js | 31 -------------------- .../resources/worker-replace-global-constructor.js | 24 --------------- .../fast/workers/resources/worker-replace-self.js | 24 --------------- .../fast/workers/worker-location-expected.txt | 16 ---------- .../web_tests/fast/workers/worker-location.html | 8 ----- .../fast/workers/worker-navigator-expected.txt | 13 --------- .../web_tests/fast/workers/worker-navigator.html | 6 ---- .../worker-replace-global-constructor-expected.txt | 5 ---- .../workers/worker-replace-global-constructor.html | 7 ----- .../fast/workers/worker-replace-self-expected.txt | 6 ---- .../fast/workers/worker-replace-self.html | 6 ---- 12 files changed, 180 deletions(-) commit 3aec8ba82a4859ba5a750888c21e045db5d55bd1 Author: Robbie Gibson <rkgibson@google.com> Date: Tue Mar 19 16:12:27 2019 +0000 Fix Search-by-image crash when given a nil image/data My thought was that ResizedImageForSearchByImage should be fine with an empty image. If, on iOS, it's passed a non-empty image with no UIImage representation, that will still crash, but is probably ok (although if that's what DCHECK should be used for, let me know). Bug: 943145 Change-Id: If617822090273af64a757666a09afa8a4e4861d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530761 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#641993} ios/chrome/browser/ui/browser_view_controller.mm | 7 +++++++ ui/gfx/image/image_util_ios.mm | 3 +++ 2 files changed, 10 insertions(+) commit 0d27b5ac5f5e1fd310ffd825de0938cebc797654 Author: Céline O'Neil <celineo@google.com> Date: Tue Mar 19 16:11:47 2019 +0000 Add fuzzing support for TileDrawQuads. Allocate and map memory for bitmaps associated with TileDrawQuads, and fuzz them in a similar manner to SolidColorDrawQuads. Will not include a quad in the RenderPass if its associated bitmap does not fit in memory (currently capped at 1 GiB additional allocated memory per CompositorFrame/fuzz iteration). R=kylechar@chromium.org Bug: 923088 Change-Id: I3029bc2923cdfe6776a2c9bb5073c0f529e7dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515712 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Ria Jiang <riajiang@chromium.org> Commit-Queue: Céline O'Neil <celineo@google.com> Cr-Commit-Position: refs/heads/master@{#641992} .../compositor_frame_fuzzer.cc | 7 +- .../compositor_frame_fuzzer.proto | 31 ++++- .../compositor_frame_fuzzer_util.cc | 125 ++++++++++++++++++--- .../compositor_frame_fuzzer_util.h | 35 +++++- .../fuzzer_browser_process.cc | 15 ++- .../fuzzer_browser_process.h | 9 +- .../1_quad_renderpass.asciipb | 2 +- .../2_quad_renderpass.asciipb | 20 +++- ...or_tiled_background_with_2_quads_on_top.asciipb | 48 ++++++-- 9 files changed, 256 insertions(+), 36 deletions(-) commit 356c950d2834fc1dfc31cf6af6cea58c894d8df9 Author: Robert Ogden <robertogden@chromium.org> Date: Tue Mar 19 16:11:22 2019 +0000 Remove usage of prefs::kDataSaverEnabled in DRPBrowserTest One of several CLs to clean up usage of this pref. Bug: 934399 Change-Id: I4c1f08c52a0e6ef1a89699ddef269945eac8e431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529732 Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#641991} .../data_reduction_proxy/data_reduction_proxy_browsertest.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit 437b934cf97fc7e8e584cfbc290a66a9578ebc49 Author: Darwin Huang <huangdarwin@chromium.org> Date: Tue Mar 19 16:10:44 2019 +0000 Async Clipboard: Use kUserInteraction TaskRunner Use a kUserInteraction is a more specific and appropriate TaskType than the current kMiscPlatformAPI. DataTransfer uses kUserInteraction, and many Async Clipboard API calls may require user interaction. Bug: 941835 Change-Id: Ib5ffcd27c36e41228ffd41f421066f41a6278bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529745 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#641990} third_party/blink/renderer/modules/clipboard/clipboard_promise.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 31246215ab490e90247588fb6244e055e414b0ba Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Tue Mar 19 16:10:17 2019 +0000 [TaskScheduler]: Implement ExecutionEnvironment. In order to use TaskSource from TaskTracker instead of Sequence, the sequence specific data must be encoded in a new struct ExecutionEnvironment and returned from a virtual method. Bug: 839091 Change-Id: I64d06c540a1eb9a7f25036ee73e7a34f024f1dbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524523 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#641989} base/task/task_scheduler/sequence.cc | 4 ++++ base/task/task_scheduler/sequence.h | 2 ++ base/task/task_scheduler/task_source.h | 9 +++++++++ base/task/task_scheduler/task_source_unittest.cc | 2 ++ base/task/task_scheduler/task_tracker.cc | 19 ++++++++++++++----- 5 files changed, 31 insertions(+), 5 deletions(-) commit fe74f232acfcdb2dc31e7dc56383345612c8e1b9 Author: Mei Liang <meiliang@chromium.org> Date: Tue Mar 19 16:09:36 2019 +0000 Add user actions for Tab UI component This CL adds the following user actions for all Tab UI components: * Creation * TabGroup.Created.TabSwitcher * TabGroup.Created.OpenInNewTab * TabGroup.Created.DeveloperRequestNewTab * Switching * MobileTabSwitched.TabStrip * MobileTabSwitched.TabGroupSheet * New Tab * MobileNewTabOpened.TabStrip * MobileNewTabOpened.TabGridSheet * Closing * MobileClosedTab.TabStrip * MobileClosedTab.TabGridSheet * Expanding/collapsing sheet * TabGroup.ExpandedFromStrip * TabGroup.MinimizedFromGrid * Extract: * LinkOpenedInNewTab * MobileTabReturnedToCurrentTab.TabGridSheet * GridTabSwitcher * MobileTabReturnedToCurrentTab.GridTabSwitcher * MobileClosedTab.GridTabSwitcher * MobileTabSwitched.GridTabSwitcher Note: Undo is not recorded yet. Bug: 942784 Change-Id: I50e812f3c07bf9f7572426a5173b9053b515fd64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1513207 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#641988} .../tab_management/GridTabSwitcherCoordinator.java | 3 +- .../tab_management/GridTabSwitcherMediator.java | 2 + .../tab_management/TabGridSheetCoordinator.java | 4 +- .../tasks/tab_management/TabGridSheetMediator.java | 6 ++ .../tab_management/TabGroupUiCoordinator.java | 3 +- .../tasks/tab_management/TabGroupUiMediator.java | 3 + .../tasks/tab_management/TabListCoordinator.java | 17 +++- .../tasks/tab_management/TabListMediator.java | 40 ++++++++-- .../tab_management/TabListMediatorUnitTest.java | 4 +- .../browser/tab/TabContextMenuItemDelegate.java | 1 + .../browser/tab/TabWebContentsDelegateAndroid.java | 21 ++++- .../tab_groups/LayoutTabGroupCreationButton.java | 2 + .../tasks/tabgroup/TabGroupModelFilter.java | 6 ++ tools/metrics/actions/actions.xml | 91 ++++++++++++++++++++-- tools/metrics/histograms/histograms.xml | 10 ++- 15 files changed, 189 insertions(+), 24 deletions(-) commit e3276a6c2b3feb4f6d1da94edf07dfa445514ae8 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Mar 19 16:09:11 2019 +0000 flags: remove save-page-as-mhtml We'll retain the switch for developer use. See offline-dev: https://groups.google.com/a/chromium.org/d/msg/offline-dev/qO1B8kkWkoM/kO30ODfRBgAJ Bug: 120416 Change-Id: Id4d9a5b5c908d2f47b2c667ea5724101e3ed7094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529254 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#641987} chrome/browser/about_flags.cc | 4 ---- chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 5 ----- chrome/browser/flag_descriptions.h | 3 --- 4 files changed, 17 deletions(-) commit 53dbffd08643dd1f80da499da3ab5a3a09c0b701 Author: Harald Alvestrand <hta@chromium.org> Date: Tue Mar 19 16:08:30 2019 +0000 Add SctpTransport API This exposes the "sctp" attribute on an RTCPeerConnection, with the RTCSctpTransport type, and plumbs the surfacing of connection creation and state changes up from the webrtc layer to the Blink layer. Specification: http://w3c.github.io/webrtc-pc/#rtcsctptransport-interface Bug: chromium:818643 Change-Id: I77ad2eddcddfabd018e62ef8c5c73cfbe77ab74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491436 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#641986} .../media/webrtc/mock_peer_connection_impl.h | 3 + .../mock_web_rtc_peer_connection_handler_client.h | 2 + .../media/webrtc/rtc_peer_connection_handler.cc | 24 ++- .../media/webrtc/rtc_peer_connection_handler.h | 2 + .../media/webrtc/transceiver_state_surfacer.cc | 24 +++ .../media/webrtc/transceiver_state_surfacer.h | 5 + .../webrtc/transceiver_state_surfacer_unittest.cc | 54 ++++++- .../webrtc/webrtc_set_description_observer.cc | 6 +- .../media/webrtc/webrtc_set_description_observer.h | 1 + .../web_rtc_peer_connection_handler_client.h | 10 ++ third_party/blink/renderer/modules/BUILD.gn | 1 + .../modules/event_target_modules_names.json5 | 1 + .../blink/renderer/modules/modules_idl_files.gni | 1 + .../blink/renderer/modules/peerconnection/BUILD.gn | 4 + .../adapters/sctp_transport_proxy.cc | 72 +++++++++ .../peerconnection/adapters/sctp_transport_proxy.h | 83 ++++++++++ .../adapters/web_rtc_cross_thread_copier.h | 7 + .../modules/peerconnection/rtc_dtls_transport.cc | 12 -- .../peerconnection/rtc_ice_transport_test.h | 2 +- .../modules/peerconnection/rtc_peer_connection.cc | 30 ++++ .../modules/peerconnection/rtc_peer_connection.h | 4 + .../modules/peerconnection/rtc_peer_connection.idl | 1 + .../modules/peerconnection/rtc_sctp_transport.cc | 175 +++++++++++++++++++++ .../modules/peerconnection/rtc_sctp_transport.h | 78 +++++++++ .../modules/peerconnection/rtc_sctp_transport.idl | 23 +++ .../peerconnection/rtc_sctp_transport_test.cc | 76 +++++++++ .../platform/runtime_enabled_features.json5 | 5 + ...tlsTransport-getRemoteCertificates-expected.txt | 2 +- .../wpt/webrtc/RTCIceTransport-expected.txt | 4 +- .../RTCPeerConnection-connectionState-expected.txt | 2 +- ...onnection-iceConnectionState.https-expected.txt | 2 +- ...TCPeerConnection-iceGatheringState-expected.txt | 2 +- .../wpt/webrtc/RTCSctpTransport-constructor.html | 4 +- .../RTCSctpTransport-maxMessageSize-expected.txt | 10 +- .../webrtc/idlharness.https.window-expected.txt | 86 +++++----- ...tlsTransport-getRemoteCertificates-expected.txt | 4 + .../wpt/webrtc/RTCIceTransport-expected.txt | 5 + .../RTCPeerConnection-connectionState-expected.txt | 7 + ...onnection-iceConnectionState.https-expected.txt | 2 +- ...TCPeerConnection-iceGatheringState-expected.txt | 6 + .../RTCSctpTransport-constructor-expected.txt | 4 +- .../webrtc/idlharness.https.window-expected.txt | 30 ++-- .../global-interface-listing-expected.txt | 11 ++ 43 files changed, 789 insertions(+), 98 deletions(-) commit 57e25d99aea7428fb51c8fffa2db054fb25bc4a8 Author: Kent Tamura <tkent@chromium.org> Date: Tue Mar 19 16:08:06 2019 +0000 Remove unimplemented -webkit-appearance keywords This CL removes the following keywords: * button-bevel * caret * listitem * media-controls-background * media-controls-fullscreen-background * media-current-time-display * media-enter-fullscreen-button * media-exit-fullscreen-button * media-mute-button * media-overlay-play-button * media-play-button * media-time-remaining-display * media-toggle-closed-captions-button * media-volume-slider-container * menulist-textfield * menulist-text * progress-bar-value They have been deprecated since M74. New FAIL lines in appearance-cssom-001-expected.txt are expected. We'll update the css-ui specification and tests after the removal. Intent thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ldH_uIfk_QE Bug: 936301 Change-Id: Ieda1a34a5fd7db9e4e4e7c473e6b0ccf90b8db16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529972 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641985} .../public/mojom/web_feature/web_feature.mojom | 17 -------- .../core/css/css_primitive_value_mappings.h | 51 ---------------------- .../renderer/core/css/css_value_keywords.json5 | 17 -------- .../core/css/parser/css_property_parser_helpers.cc | 43 ------------------ .../blink/renderer/core/frame/deprecation.cc | 35 --------------- .../blink/renderer/core/paint/theme_painter.cc | 10 ----- third_party/blink/renderer/platform/theme_types.h | 19 +------- .../css/css-ui/appearance-cssom-001-expected.txt | 38 ++++++++-------- tools/metrics/histograms/enums.xml | 39 +++++++++-------- 9 files changed, 42 insertions(+), 227 deletions(-) commit 5bd0532db34c3f46ec99c0f046c82d29efe53e66 Author: Avi Drissman <avi@chromium.org> Date: Tue Mar 19 16:07:25 2019 +0000 Don't send IPC replies through dead frames. This is a followup to https://crrev.com/c/1512658 . Bug: 870606 Change-Id: Ic73e1e943baeb9987cfb1caf57f8318fb0aec92f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529472 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#641984} content/renderer/render_frame_impl.cc | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) commit ef6a8f83c9c79e7dd8e6f0af62cdd9e57b11feba Author: Robert Ogden <robertogden@chromium.org> Date: Tue Mar 19 16:07:03 2019 +0000 Remove usage of prefs::kDataSaverEnabled in DataUseMeasurementBT One of several CLs to clean up usage of this pref. Bug: 934399 Change-Id: I9dc51cfa66a88c4ab917e2ae8f03ffdcdb4455bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529794 Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#641983} .../data_use_measurement/data_use_measurement_browsertest.cc | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) commit 97d97abe481dbbe06aac43255c6c16c9129bdde4 Author: Natalie Chouinard <chouinard@chromium.org> Date: Tue Mar 19 16:06:18 2019 +0000 [Chromeshine] Make test-only constructor protected Make the UsageStatsDatabase test-only constructor protected as per the style guide. Previously part of larger abandoned CL: https://crrev.com/c/1525186 Bug: 918983 Change-Id: I75ab7aee25003708e3b500d20f6de25acf16a505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529547 Reviewed-by: Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641982} chrome/browser/android/usage_stats/usage_stats_database.cc | 1 - chrome/browser/android/usage_stats/usage_stats_database.h | 13 +++++++------ .../android/usage_stats/usage_stats_database_unittest.cc | 13 ++++++++++++- 3 files changed, 19 insertions(+), 8 deletions(-) commit 1ffd37c876b2d19cdcfa984c9b9c8b258addfbe6 Author: Joe DeBlasio <jdeblasio@chromium.org> Date: Tue Mar 19 16:05:56 2019 +0000 Lookalikes: Remove reliance on NTP hiding URL This CL removes part of a lookalike URL warning test that verified that the contents of the omnibox was hidden when visiting a NTP. This is not reliable behavior on Windows release builds (possibly due to http://crbug.com/624410). The Lookalike test only had the clause out of an abundance of caution, and still verifies the desired behavior, so it is safe to remove. Change-Id: I808813fd32aea71e23992aa80db22bfcacb84809 Bug: 943069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529950 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#641981} .../lookalikes/lookalike_url_navigation_throttle_browsertest.cc | 4 ---- 1 file changed, 4 deletions(-) commit 8b32abcef6cfb769ca1efaffa361f70edd75df25 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Mar 19 16:05:12 2019 +0000 CORB allowlist additions - 2019-03-18. Bug: 942818 Bug: 943125 Bug: 943124 Bug: 942446 Bug: 943147 Change-Id: I99a2e1ec2403096754a53ad40200e3bbca398559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526535 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#641980} extensions/browser/url_loader_factory_manager.cc | 5 +++++ 1 file changed, 5 insertions(+) commit a3d329821c86c38013e05e886289be0fb49f950a Author: Robert Sesek <rsesek@chromium.org> Date: Tue Mar 19 16:04:49 2019 +0000 Weak link MediaPlayer.framework in //ui/base/now_playing. This framework is only available on 10.12+, and the normal framework dependency is causing Chrome on macOS 10.10 and 10.11 to crash on launch. Bug: 943299 Change-Id: Ida122e7b339835ac67f20c25880e2e74c4f878b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529924 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641979} ui/base/now_playing/BUILD.gn | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) commit 8bbaff7e8f8780c9179415ba72c851d434984ea2 Author: Antoine Labour <piman@chromium.org> Date: Tue Mar 19 16:04:07 2019 +0000 Allow R_8 and RG_88 buffers to use GL_TEXTURE_2D Bug: 939977 Change-Id: Ica5225b4dc276cb2d45681d4f8eb221804441887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529343 Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#641978} gpu/command_buffer/common/gpu_memory_buffer_support.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit d0d63ae12f6ee3b0076da1a1b026370593792953 Author: khmel@chromium.org <khmel@chromium.org> Date: Tue Mar 19 16:03:42 2019 +0000 arc: Use two bands to display Chrome rendering events. Swapping buffers implies asyncronous concept, that means set of events generated for one frame may overlap with set of events of the previous frame. In this case events displayed on one band are hard to read. BUG=b:122555793 TEST=Locally + unit tests Change-Id: Iae894d6f8655a373d46c9f5fc89e4f44d359fbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525269 Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yury Khmel <khmel@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641977} .../arc/tracing/arc_tracing_graphics_model.cc | 76 +++++++++++++++++----- .../arc/tracing/arc_tracing_graphics_model.h | 7 +- .../arc/tracing/arc_tracing_model_unittest.cc | 22 ++++--- .../arc_graphics_tracing/arc_graphics_tracing.css | 1 + .../arc_graphics_tracing_ui.js | 8 ++- .../gm_bad_no_view_buffers.json | 2 +- .../arc_graphics_tracing/gm_bad_no_view_desc.json | 2 +- .../gm_bad_wrong_timestamp.json | 2 +- chrome/test/data/arc_graphics_tracing/gm_good.json | 2 +- 9 files changed, 86 insertions(+), 36 deletions(-) commit 702eaec14be3b25c6c62c5d21de43c9d304fae79 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 16:03:03 2019 +0000 Roll src/third_party/glslang/src b184e41a0637..5efb004d5960 (4 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b184e41a0637..5efb004d5960 git log b184e41a0637..5efb004d5960 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 johnkslang@users.noreply.github.com Merge pull request #1711 from demett-brcm/avoid-undefined-behaviour 2019-03-19 lrhedge@gmail.com GLSL: Fix tessellation control shader bounding box support. (#1730) 2019-03-18 johnkslang@users.noreply.github.com Merge pull request #1733 from null77/fix-msvc-warn 2019-03-18 johnkslang@users.noreply.github.com Merge pull request #1731 from godlikepanos/master Created with: gclient setdep -r src/third_party/glslang/src@5efb004d5960 The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I9af1503857e25d37a47c5408b06996103eb18d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529160 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641976} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bd0fe31670b1f52714716ddd7e51580a57f9daaa Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Mar 19 16:02:36 2019 +0000 Fixed a crash in OpenDownload from notifications Since DownloadManagerService native is not initialized before activity is launched, it crashes when we open a download from notifications. Fixed it as well as changed the new path to use DownloadUtils and be independent of download item. Bug: 941966 Change-Id: I551c279606e7a3acd22202f1d6026e37f6b1ba76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527207 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#641975} .../chrome/browser/download/DownloadUtils.java | 11 +++++++++ .../android/download/download_manager_service.cc | 3 +++ chrome/browser/android/download/download_utils.cc | 28 ++++++++++++++++++---- chrome/browser/android/download/download_utils.h | 5 ++++ .../download/chrome_download_manager_delegate.cc | 7 ++---- 5 files changed, 45 insertions(+), 9 deletions(-) commit ef777c5264a38823a15b671943825cd28a2f85dd Author: Andrey Kosyakov <caseq@chromium.org> Date: Tue Mar 19 16:01:58 2019 +0000 Remove ClientRedirectPolicy param from LocalFrame::Reload(), assume it's always a client redirect Change-Id: I87d49666cf5107c9398cb2c4637986d14039ab5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529756 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#641974} third_party/blink/renderer/core/frame/history.cc | 3 +-- third_party/blink/renderer/core/frame/local_frame.cc | 17 +++++++---------- third_party/blink/renderer/core/frame/local_frame.h | 2 +- third_party/blink/renderer/core/frame/location.cc | 3 +-- third_party/blink/renderer/core/testing/internals.cc | 3 +-- .../blink/renderer/modules/plugins/dom_plugin_array.cc | 6 ++---- 6 files changed, 13 insertions(+), 21 deletions(-) commit 9341ba57a12081eb60cb0237b2b5e164b399e6a5 Author: Jesse Doherty <jwd@chromium.org> Date: Tue Mar 19 16:01:26 2019 +0000 Migarte UKM client id to a Uint64 pref. Bug: 922697 Change-Id: If4ea9aca02ebcdbf8e6c3bfc0c4f798c017010b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524659 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#641973} components/ukm/ukm_service.cc | 28 ++++++++++++++++++++++------ components/ukm/ukm_service_unittest.cc | 10 ++++++++++ tools/metrics/histograms/histograms.xml | 10 ++++++++++ 3 files changed, 42 insertions(+), 6 deletions(-) commit 32545db2f7a8925a26ceb5337792c16cfe735974 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Tue Mar 19 16:00:53 2019 +0000 [iOS][MF] Hide card holder and card number if empty Change-Id: I96111e65c97e770f388df34e5801f8a30f413129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530763 Reviewed-by: David Jean <djean@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#641972} .../autofill/manual_fill/manual_fill_card_cell.mm | 46 ++++++++++++++++++---- 1 file changed, 39 insertions(+), 7 deletions(-) commit ffb79e4a5cbb7ed821aff52e39f02e2e8e2e07f5 Author: Alexander Timin <altimin@chromium.org> Date: Tue Mar 19 16:00:18 2019 +0000 [scheduler] Add "disable back-forward cache" policy Add a policy to disable bfcache and use it for WebRTC and WebSocket. R=haraken@chromium.org CC=skyostil@chromium.org BUG=933147 Change-Id: I13ae4f098de802a952e3f2807b88694874392e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526186 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641971} .../scheduler/scheduler_affecting_features_test.cc | 14 ++++++++ .../peerconnection/adapters/ice_transport_proxy.cc | 3 +- .../modules/peerconnection/rtc_peer_connection.cc | 3 +- .../modules/websockets/websocket_channel_impl.cc | 3 +- .../scheduler/main_thread/frame_scheduler_impl.cc | 39 +++++++++++++++++++++- .../scheduler/main_thread/frame_scheduler_impl.h | 17 +++++++++- .../scheduler/main_thread/page_scheduler_impl.cc | 12 +++++++ .../scheduler/main_thread/page_scheduler_impl.h | 2 ++ .../main_thread/page_scheduler_impl_unittest.cc | 37 ++++++++++++++++++++ .../platform/scheduler/public/page_scheduler.h | 8 +++++ .../platform/scheduler/public/scheduling_policy.h | 7 +++- .../platform/scheduler/test/fake_page_scheduler.h | 4 +++ .../test/renderer_scheduler_test_support.cc | 4 +++ 13 files changed, 147 insertions(+), 6 deletions(-) commit 44e2417f29ed03d9bb4cf317f0068d83a0e3fa5e Author: Robert Flack <flackr@chromium.org> Date: Tue Mar 19 15:59:48 2019 +0000 Remove special behavior for setting timing of transitions. As a result of creating transitions as 2-keyframe animations with a start delay they no longer require special case behavior for updating the timing from devtools. Bug: 935027,935802 Change-Id: I2acd486f9e571aef4a39ebe382c437496f18c99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524427 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#641970} .../core/inspector/inspector_animation_agent.cc | 36 ++++------------------ third_party/blink/web_tests/TestExpectations | 2 -- 2 files changed, 6 insertions(+), 32 deletions(-) commit 20c24a2adea587e81125be5a8c0aa6349997a45e Author: Yao Xiao <yaoxia@chromium.org> Date: Tue Mar 19 15:59:13 2019 +0000 Remove blink download_stats.h/.cc The original purpose of this metrics was to help with the intervention of "downloads in sandbox iframe" and "downloads in ad frame". We feel the UseCounter is sufficient and don't find this UMA/UKM very useful. Besides, recently there was scope change of the intervention for navigation resulted download, that we not only want to block "download in the iframe", but also "download initiated from OR occurs in the iframe". With that forthcoming change, the UMA/UKM would be inaccurate anyway. Therefore, just remove this metrics. Subsequent CLs will address other issues with the scope change. Change-Id: I0cda190930b0e988292d73860e5b82daf7dc2855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528477 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#641969} .../ad_metrics/ads_page_load_metrics_observer.cc | 22 ---- .../ads_page_load_metrics_observer_browsertest.cc | 112 +++++---------------- third_party/blink/common/BUILD.gn | 1 - .../blink/common/download/download_stats.cc | 63 ------------ third_party/blink/public/common/BUILD.gn | 1 - .../blink/public/common/download/download_stats.h | 81 --------------- .../renderer/core/html/html_anchor_element.cc | 27 ----- tools/metrics/histograms/enums.xml | 6 ++ tools/metrics/histograms/histograms.xml | 6 ++ tools/metrics/ukm/ukm.xml | 6 ++ 10 files changed, 41 insertions(+), 284 deletions(-) commit e80cba8f5a3dce88c9aff847e032d5f9d1f80f02 Author: Yashar Dabiran <yashard@google.com> Date: Tue Mar 19 15:58:45 2019 +0000 [REFACTOR] Use enum for origin trials features instead of strings. This CL is parts of the efforts to move the origin trials feature check to |renderer/platform/runtime_enabled_features.h|. The design doc for the change: https://docs.google.com/document/d/1Qog5qwZ-6Rfx10AKkJxN-LrwhCw_GJ1xdLoQSnpsT1Q/ Two main changes are made in this CL: - Define the OriginTrialsFeature enum (in "runtime_enabled_features.h") and replace the usage of <feature>TrialName strings (defined in "origin_trials.h") with the enum values. - Change how trials and OT features are handled throughout the code. Summary of how the origin trials mechanism works now: Upon the arrival of a trial token, the trial name (defined in the token) is converted to a set of features (origin_trials::FeaturesForTrial()) and those features are added to the enabled features set. The availability of each feature is checked by using OriginTrialContext.IsFeatureEnabled() (previously named IsTrialEnabled()). The only mechanism that works with the trial names and can enable features is the OriginTrialContext class. Change-Id: I557771ff88c7c378f999210f7fd5bf539203ede6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516072 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Yashar Dabiran <yashard@google.com> Cr-Commit-Position: refs/heads/master@{#641968} third_party/blink/public/web/web_origin_trials.h | 2 + .../scripts/generate_origin_trial_features.py | 3 +- .../origin_trial_features_for_core.cc.tmpl | 33 ++++---- .../origin_trial_features_for_modules.cc.tmpl | 33 ++++---- .../results/core/origin_trial_features_for_core.cc | 31 ++++--- .../modules/origin_trial_features_for_modules.cc | 3 +- .../renderer/build/scripts/make_origin_trials.py | 17 +++- .../build/scripts/templates/origin_trials.cc.tmpl | 97 ++++++++++++++-------- .../build/scripts/templates/origin_trials.h.tmpl | 19 +++-- .../templates/runtime_enabled_features.h.tmpl | 11 +++ .../scripts/templates/web_origin_trials.cc.tmpl | 25 ++++-- .../blink/renderer/core/loader/document_loader.cc | 6 +- .../core/origin_trials/origin_trial_context.cc | 38 +++++---- .../core/origin_trials/origin_trial_context.h | 13 +-- .../origin_trials/origin_trial_context_test.cc | 26 +++--- .../core/testing/v8/web_core_test_support.cc | 44 +++++----- .../platform/bindings/origin_trial_features.cc | 5 +- .../platform/bindings/origin_trial_features.h | 5 +- 18 files changed, 254 insertions(+), 157 deletions(-) commit b8d27aa289ca0e2cf3f6a277745dc47a7669a69a Author: Darwin Huang <huangdarwin@chromium.org> Date: Tue Mar 19 15:58:07 2019 +0000 Clipboard: Create *NoCommit write functions All write functions should be *NoCommit, to allow for more customizable writes of multiple data types to the system clipboard in the future. Bug: 941085 Change-Id: Ie1c462f7ab4aca614285272ed78691f224cbba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529919 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#641967} .../renderer/core/clipboard/system_clipboard.cc | 26 ++++++++++++++++++---- .../renderer/core/clipboard/system_clipboard.h | 8 +++++++ 2 files changed, 30 insertions(+), 4 deletions(-) commit 37edd93aed01463d2c4519d1710645cd177c1c4c Author: Alexandre Frechette <frechette@chromium.org> Date: Tue Mar 19 15:57:20 2019 +0000 Moving blocked languages to language component. Change-Id: Idc8bcb92d4ca17532df631fba64a24412cf75265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508776 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641966} .../extensions/api/settings_private/prefs_util.cc | 2 +- chrome/browser/prefs/browser_prefs.cc | 2 +- .../translate_internals_handler.cc | 2 +- components/language/DEPS | 1 + components/language/core/browser/BUILD.gn | 3 + components/language/core/browser/language_prefs.cc | 88 +++++++++++- components/language/core/browser/language_prefs.h | 41 +++++- .../core/browser/language_prefs_unittest.cc | 155 +++++++++++++++++++++ components/language/core/browser/pref_names.cc | 3 + components/language/core/browser/pref_names.h | 2 + .../browser/mock_translate_infobar_delegate.cc | 1 + .../core/browser/mock_translate_infobar_delegate.h | 1 + .../core/browser/translate_manager_unittest.cc | 8 +- .../translate/core/browser/translate_prefs.cc | 63 ++------- .../translate/core/browser/translate_prefs.h | 20 ++- .../core/browser/translate_prefs_unittest.cc | 49 +++---- .../core/browser/translate_ui_delegate_unittest.cc | 18 ++- ios/chrome/browser/prefs/browser_prefs.mm | 2 +- ios/chrome/browser/translate/BUILD.gn | 1 + .../translate_table_view_controller_unittest.mm | 6 +- ios/web_view/internal/web_view_browser_state.mm | 2 +- 21 files changed, 356 insertions(+), 114 deletions(-) commit b8237c0019190ec231ef8a97275470241e60bc84 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:57:02 2019 +0000 Roll src/third_party/perfetto 7b0c9453e8d3..69d721a1be6d (7 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/7b0c9453e8d3..69d721a1be6d git log 7b0c9453e8d3..69d721a1be6d --date=short --no-merges --format='%ad %ae %s' 2019-03-19 treehugger-gerrit@google.com Merge "heapprofd tests: pretend cuttlefish works (and re-enable cts everywhere)" 2019-03-19 treehugger-gerrit@google.com Merge "tests: Update ASAN failure expectation for chromium." 2019-03-19 skyostil@google.com Merge "SliceTracker: Ignore closing non-existent slices" 2019-03-19 primiano@google.com Merge "Make MSAN happy." 2019-03-19 primiano@google.com Merge "Add component & team to OWNERS" 2019-03-19 primiano@google.com Merge "heapprofd test: fix typo (should re-enable fork mode tests)" 2019-03-18 rsavitski@google.com Merge "UnixTaskRunner.Quit: keep holding lock while notifying to prevent race" Created with: gclient setdep -r src/third_party/perfetto@69d721a1be6d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1113dceaac7d2918a375727633f23bbc3e433bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529326 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641965} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e919c9f3ddd9f46590e8086238b92be1ae294d92 Author: Carlos Caballero <carlscab@google.com> Date: Tue Mar 19 15:56:16 2019 +0000 Partial revert of https://crrev.com/c/1525932 Pinpoint job shows that the regression is gone. https://pinpoint-dot-chromeperf.appspot.com/job/169de9eaf40000 Bug: 943465 Change-Id: I9da5bf97eb4a3c5036d5583ef294b91fcb407f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529281 Reviewed-by: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#641964} .../renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc | 1 - 1 file changed, 1 deletion(-) commit 610af81fa4f044005f3cfbff6f315e3fb4e64e4b Author: Mike Wasserman <msw@chromium.org> Date: Tue Mar 19 15:55:56 2019 +0000 Allow a wider range of cursor device scale factors Otherwise, values derived from WebCursor can break message pipes. https://cs.chromium.org/chromium/src/content/common/cursors/webcursor_ozone.cc?l=58 Bug: 942233 Test: Cropping an image doesn't cause ChromeOS to become unresposive. Change-Id: I63c8cb9777a0b9efa73c297ef0a4d0ed6fa28d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529388 Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#641963} ui/base/mojo/cursor_struct_traits.cc | 7 ++----- ui/base/mojo/cursor_struct_traits_unittest.cc | 13 +++++++++++++ 2 files changed, 15 insertions(+), 5 deletions(-) commit 16dcf83e1949cd0bc34cd72da85bc04784d76d7d Author: Liquan(Max) Gu <maxlg@chromium.org> Date: Tue Mar 19 15:55:11 2019 +0000 [FCP++] Fix histogram name The histogram PageLoad.Experimental.PaintTiming.NavigationToLargestContentPaintAllFrames has a bug in its name, it should be PageLoad.Experimental.PaintTiming.NavigationToLargestContentPaint.AllFrames. (a dot is added before AllFrames). Bug: 934318 Change-Id: Ieb573efc816e2b6f8e465c7154929fc1a024f618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526819 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#641962} tools/metrics/histograms/histograms.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c1fc4acac98a16c16292f1729042e5b0c2a6e016 Author: Patrick Noland <pnoland@chromium.org> Date: Tue Mar 19 15:54:47 2019 +0000 [Chromeshine] Add client for interacting with Digital Wellbeing This change is mostly mechanical; the actual logic for making requests will go downstream. Bug: 926188 Change-Id: I3655646957041d1f10218cf39ba51c44562c0d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516041 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#641961} .../src/org/chromium/chrome/browser/AppHooks.java | 8 +++ .../usage_stats/DigitalWellbeingClient.java | 68 ++++++++++++++++++++++ .../browser/usage_stats/UsageStatsService.java | 12 +++- chrome/android/java_sources.gni | 1 + 4 files changed, 88 insertions(+), 1 deletion(-) commit aeb238cd454d0ebb0ec1652098d16762f290a384 Author: Hector Carmona <hcarmona@chromium.org> Date: Tue Mar 19 15:54:04 2019 +0000 Navi: Enable Dark mode for onboarding workflow. Screencast in bug. Bug: 936922 Change-Id: I4877dac53000ba42ffbaa276161c1a61eb463e0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522341 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641960} .../onboarding_welcome/email/nux_email.html | 2 +- .../google_apps/nux_google_apps.html | 2 +- .../ntp_background/nux_ntp_background.html | 2 +- .../onboarding_welcome_resources.grd | 4 +++ .../set_as_default/nux_set_as_default.html | 4 +-- .../shared/action_link_style_css.html | 4 +-- .../shared/chooser_shared_css.html | 26 ++++++++++--------- .../onboarding_welcome/shared/navi_colors_css.html | 30 ++++++++++++++++++++++ .../shared/splash_pages_shared_css.html | 8 +++--- .../welcome/onboarding_welcome/welcome.html | 11 ++++++-- 10 files changed, 69 insertions(+), 24 deletions(-) commit 2e6734404933d0bc9b56f2a9d64385a09dc9854b Author: Andrey Kosyakov <caseq@chromium.org> Date: Tue Mar 19 15:53:43 2019 +0000 DevTools: fix LoadNetworkResource() for file:// URLs with NetworkService on Bug: 941697 Change-Id: Ia9de63f9a5cff1516962dff0ed785f5c26b6b833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525270 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#641959} .../devtools/devtools_sanity_browsertest.cc | 11 ++++++++++- chrome/browser/devtools/devtools_ui_bindings.cc | 23 ++++++++++++++++++---- .../blink/renderer/devtools/front_end/Tests.js | 4 +++- 3 files changed, 32 insertions(+), 6 deletions(-) commit 58c539fd97ad71e349b50c75cc1faf4031484f0f Author: Maksim Moskvitin <mmoskvitin@google.com> Date: Tue Mar 19 15:52:58 2019 +0000 [Sync:USS] Introduce ModelTypeController logic for Nigori Bug: 922900,943019 Change-Id: I32f22d6b42b829a8e2ad95e1ded38bdc16bb4bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526043 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#641958} components/browser_sync/profile_sync_service.cc | 21 +++++++++++++++++++++ .../sync/driver/glue/sync_backend_host_core.cc | 8 ++++++++ .../sync/driver/glue/sync_backend_host_core.h | 3 +++ components/sync/driver/glue/sync_engine_impl.cc | 10 ++++++++++ components/sync/driver/glue/sync_engine_impl.h | 2 ++ components/sync/engine/fake_sync_engine.cc | 6 ++++++ components/sync/engine/fake_sync_engine.h | 3 +++ components/sync/engine/mock_sync_engine.h | 3 +++ components/sync/engine/sync_engine.h | 5 +++++ components/sync/engine/sync_engine_switches.cc | 4 ++++ components/sync/engine/sync_engine_switches.h | 2 ++ 11 files changed, 67 insertions(+) commit 549baabb2080ad99394959c86d6a11ee6b778aee Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Mar 19 15:52:40 2019 +0000 Move ViewHostMsg_OnGotoEntryAtOffset to FrameHostMsg_OnGotoEntryAtOffset In order to add metrics to calculate top level navigations from iframes that are sandboxed frame's navigation source needs to be conveyed to the browser. The easiest way to do this is to move the API to the frame API. No behavioural changes intended. BUG=705583 Change-Id: I2ae2ffa45d1a488b7c43177d07b8768e8dbb2106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524416 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#641957} content/browser/frame_host/navigation_controller_impl_unittest.cc | 7 ++++--- content/browser/frame_host/navigation_request.cc | 2 +- content/browser/navigation_browsertest.cc | 2 +- content/browser/web_contents/web_contents_impl.cc | 4 ++-- content/browser/web_contents/web_contents_impl.h | 2 +- content/common/frame_messages.h | 7 +++++++ content/common/swapped_out_messages.cc | 2 -- content/common/view_messages.h | 6 ------ content/renderer/render_frame_impl.cc | 7 +++++++ content/renderer/render_frame_impl.h | 1 + content/renderer/render_view_impl.cc | 2 -- content/renderer/render_view_impl.h | 2 +- third_party/blink/public/web/web_local_frame_client.h | 6 ++++++ third_party/blink/public/web/web_view_client.h | 6 ------ .../blink/renderer/core/exported/local_frame_client_impl.cc | 6 +++--- 15 files changed, 34 insertions(+), 28 deletions(-) commit e1642efa6cc724d45aaf0c4cbc274f5de35bb643 Author: David Bertoni <dbertoni@chromium.org> Date: Tue Mar 19 15:51:51 2019 +0000 [Extensions] base::Bind --> base::BindRepeating cleanup. Bug: 714018 Change-Id: Ifd5c594452ced91b51bc464998cef9d9faaf7444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529533 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#641956} .../api/web_request/web_request_api_unittest.cc | 103 +++++++++------------ 1 file changed, 46 insertions(+), 57 deletions(-) commit 37a28555b68bd2fd1a3c07f5310dde13c2d999cd Author: Chris Mumford <cmumford@google.com> Date: Tue Mar 19 15:51:34 2019 +0000 Disable failing photo picker tests. Two tests in chrome_public_test_apk are failing and are preventing other CL's from landing. Disabling to unblock development. Disabling: org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testMultiSelectionPhoto org.chromium.chrome.browser.photo_picker.PhotoPickerDialogTest#testSingleSelectionPhot TBR=twellington@chromium.org Bug: 941488 Change-Id: I8aadbbb3c412dd5e6bc0e006ae24ce1d45b99481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529379 Reviewed-by: Chris Mumford <cmumford@google.com> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#641955} .../chromium/chrome/browser/photo_picker/PhotoPickerDialogTest.java | 3 +++ 1 file changed, 3 insertions(+) commit 2771b9055d7aa4c88d5716ca33e4c36056d25671 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Tue Mar 19 15:50:46 2019 +0000 Fixed a crash in rename downloads Bug: 942878 Change-Id: Id79251ac0de3a1e5fb91943a3e83ed28a0060b05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526616 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641954} chrome/browser/download/download_offline_content_provider.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eb138693980bd6170d66eef6b033b5c9d014630d Author: Caroline Rising <corising@chromium.org> Date: Tue Mar 19 15:50:29 2019 +0000 Add a fade in and fade out delay for Tab Hover Cards. Also adjust the max tab hover card delay time. Bug: 910739 Change-Id: Ie6b48176091f0c0da90b46cda13ad96ff8ec0e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516877 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#641953} .../ui/views/tabs/tab_hover_card_bubble_view.cc | 115 ++++++++++++++++++++- .../ui/views/tabs/tab_hover_card_bubble_view.h | 11 +- .../tabs/tab_hover_card_bubble_view_browsertest.cc | 4 +- chrome/browser/ui/views/tabs/tab_strip.cc | 2 +- 4 files changed, 124 insertions(+), 8 deletions(-) commit 55ea90511e8804ead7a1660a321a3c00cd899f34 Author: Alex Cooper <alcooper@chromium.org> Date: Tue Mar 19 15:49:39 2019 +0000 Fix crash when tearing down Windows Mixed Reality render loop Something in Windows.Perception.Stubs does not appear to be torn down cleanly if we've started a session/render loop. This appears to hit on the last time that we attempt to RoUninitialize the COM thread. However, given the crash we are now no longer uninitializing COM during the destruction of the MixedRealityDeviceStatics, which should be the longest lived object accessing the COM thread. This change also adds a missing destruction for an outstanding object when we stop the runtime on the render loop to ensure that COM objects are properly destructed in the right order. This has the side effect of fixing 942173 as well. Bug: 941710,942173 Change-Id: I748c22fe24e8424a00d020c3713fbb84c32683c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529515 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641952} chrome/services/isolated_xr_device/xr_runtime_provider.cc | 8 +++++++- device/vr/windows_mixed_reality/mixed_reality_renderloop.cc | 1 + device/vr/windows_mixed_reality/mixed_reality_statics.cc | 11 ++++++----- 3 files changed, 14 insertions(+), 6 deletions(-) commit c5ab92ad794d542f2883a2794b57f0a890cb574a Author: Matthew Cary <mattcary@chromium.org> Date: Tue Mar 19 15:49:24 2019 +0000 Orderfile: fix typo in split flow. Bug: 908406 Change-Id: I4bb245ae7da15be90a89c11ca67320daa3f0edff TBR: pasko@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530845 Reviewed-by: Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#641951} tools/cygprofile/orderfile_generator_backend.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 09fe2b2727e0dde3b4146fc96b3a9aaa588eb772 Author: Kent Tamura <tkent@chromium.org> Date: Tue Mar 19 15:48:33 2019 +0000 Add a UseCounter for listened 'search' events Bug: 690143 Change-Id: Ie200f5d11b043db1681f2c40ccb99b92376faabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529980 Reviewed-by: Hayato Ito <hayato@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641950} third_party/blink/public/mojom/web_feature/web_feature.mojom | 1 + third_party/blink/renderer/core/dom/events/event_target.cc | 3 +++ tools/metrics/histograms/enums.xml | 1 + 3 files changed, 5 insertions(+) commit 439089828e0eee13eb4d736773a9fac49c3db391 Author: Scott Violet <sky@chromium.org> Date: Tue Mar 19 15:48:19 2019 +0000 chromeos: make FocusSynchronizer clear focused_window_ SetFocusFromServer(nullptr) was not resetting focused_window_. This meant that if focus did change back to the previously focused window it would be processed correctly. BUG=941418 TEST=covered by tests Change-Id: I2388032c80feb5828426c1028105e67084c75e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529110 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#641949} ui/aura/mus/focus_synchronizer.cc | 1 + ui/aura/mus/focus_synchronizer_unittest.cc | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+) commit ca01301081170211258500518f854f09cec5c88d Author: Tommy Steimel <steimel@chromium.org> Date: Tue Mar 19 15:47:29 2019 +0000 [Media Controls] Properly handle page zoom when checking doubletap This CL updates the doubletap logic in MediaControlsImpl to take page zoom into account when determining whether a tap was on the left or right side. This fixes an issue where doubletaps on the left side of videos on zoomed pages were sometimes being treated as right-side taps. Bug: 942462 Change-Id: I601fef21f73df7028ca1b495b1a7d4f8a770a8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526803 Reviewed-by: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641948} .../modules/media_controls/media_controls_impl.cc | 4 + .../media_controls/media_controls_impl_test.cc | 88 ++++++++++++++++++++++ 2 files changed, 92 insertions(+) commit cef201067b1ba067b4680446cbe3dc1c82de1a24 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Mar 19 15:47:13 2019 +0000 Avoid painting empty display items for decoration backgrounds Empty display items are bad for paint performance. We should try to avoid them while keeping code before UseCachedDrawingIfPossible as fast as possible. Refactor BoxDecorationData to enclose more box decoration conditions in an efficient way, and add ShouldPaint() to let the caller early return if there is no box decoration to paint, to avoid empty display items. Pinpoint showed overall progressions of paint performance: https://pinpoint-dot-chromeperf.appspot.com/job/1697be5af40000 https://pinpoint-dot-chromeperf.appspot.com/job/15e4991cf40000 Bug: 940657 Change-Id: I0b035e4fc400644d6c0c73252ae0bca2988fd1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517273 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#641947} third_party/blink/renderer/core/BUILD.gn | 1 + .../blink/renderer/core/layout/layout_box.cc | 2 + .../blink/renderer/core/layout/layout_box_test.cc | 11 ++ .../blink/renderer/core/layout/layout_object.h | 18 ++++ .../blink/renderer/core/layout/layout_table.cc | 5 + .../renderer/core/layout/layout_table_cell.cc | 3 + .../renderer/core/layout/layout_table_cell_test.cc | 29 ++++++ .../renderer/core/layout/layout_table_test.cc | 17 +++ .../renderer/core/paint/box_decoration_data.cc | 75 +++---------- .../renderer/core/paint/box_decoration_data.h | 116 +++++++++++++++++---- .../core/paint/box_model_object_painter.cc | 53 ++++------ .../renderer/core/paint/box_model_object_painter.h | 3 - .../blink/renderer/core/paint/box_painter.cc | 100 +++++++++--------- .../blink/renderer/core/paint/box_painter_test.cc | 36 +++++++ .../blink/renderer/core/paint/fieldset_painter.cc | 38 ++++--- .../core/paint/ng/ng_box_fragment_painter.cc | 75 +++++++------ .../renderer/core/paint/ng/ng_fieldset_painter.cc | 67 ++++++------ .../renderer/core/paint/table_cell_painter.cc | 77 ++++++-------- .../renderer/core/paint/table_painter_test.cc | 27 +++++ .../blink/renderer/core/paint/view_painter.cc | 9 +- .../blink/renderer/core/paint/view_painter_test.cc | 20 ++-- .../enable-blink-features=CompositeAfterPaint | 6 +- .../body-background-skipped-expected.txt | 5 - .../fixed-body-background-positioned-expected.txt | 3 +- ...d.txt => become-overlapped-iframe-expected.txt} | 39 ++++--- .../iframes/composited-parent-iframe-expected.txt | 4 +- ...connect-compositing-iframe-delayed-expected.txt | 4 +- .../connect-compositing-iframe-expected.txt | 4 +- .../connect-compositing-iframe2-expected.txt | 4 +- .../connect-compositing-iframe3-expected.txt | 4 +- .../iframes/enter-compositing-iframe-expected.txt | 4 +- .../compositing/iframes/iframe-resize-expected.txt | 4 +- .../iframes/iframe-size-from-zero-expected.txt | 4 +- .../iframes/overlapped-iframe-expected.txt | 4 +- .../compositing/iframes/resizer-expected.txt | 73 +++++++++++++ .../fast/multicol/composited-layer-expected.txt | 16 --- ...nt-background-html-resize-overflow-expected.txt | 2 +- ...ground-attachment-local-composited-expected.txt | 5 - ...t-repaint-after-compositing-update-expected.txt | 23 ++++ .../destroy-composited-scrollbar-expected.txt | 2 +- ...radient-background-scroll-repaint-expected.txt} | 5 - ...local-background-text-color-change-expected.txt | 5 - .../repaint-during-scroll-with-zoom-expected.txt | 61 +++++++++++ ...lection-within-composited-scroller-expected.txt | 5 - ...ackground-image-paint-invalidation-expected.txt | 5 - ...nt-background-html-resize-overflow-expected.txt | 2 +- ...-gradient-background-scroll-repaint-iframe.html | 10 ++ .../resources/iframe-scroll-repaint-iframe.html | 2 +- ...gradient-background-scroll-repaint-expected.txt | 29 ++++++ .../iframe-gradient-background-scroll-repaint.html | 2 + .../scroll/iframe-scroll-repaint-expected.txt | 9 +- .../invalidation/scroll/iframe-scroll-repaint.html | 4 - .../repaint-during-scroll-with-zoom-expected.txt | 10 +- .../repaint-during-scroll-with-zoom-expected.txt | 39 +++++++ .../repaint-during-scroll-with-zoom-expected.txt | 39 +++++++ 55 files changed, 798 insertions(+), 421 deletions(-) commit 84b12fc2af43f7d5e637d3d51e349655809fbb8a Author: shrekshao <shrekshao@google.com> Date: Tue Mar 19 15:46:25 2019 +0000 Implement the 'powerPreference' canvas context attribute Ported from Electron, originally added in https://github.com/electron/libchromiumcontent/pull/296 This implements the standard described at https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.2.1 Added one line on top of https://chromium-review.googlesource.com/c/chromium/src/+/1343522/ Bug: 681341 Change-Id: Ia163a0929a1cfd831c1ad291c47a0d5f8b5684c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526309 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641946} content/renderer/renderer_blink_platform_impl.cc | 6 ++++-- third_party/blink/public/platform/platform.h | 1 + .../core/html/canvas/canvas_context_creation_attributes_core.h | 1 + .../htmlcanvas/canvas_context_creation_attributes_helpers.cc | 1 + .../htmlcanvas/canvas_context_creation_attributes_module.idl | 7 +++++++ .../renderer/modules/webgl/webgl_context_attribute_helpers.cc | 2 ++ .../blink/renderer/modules/webgl/webgl_context_attributes.idl | 7 +++++++ 7 files changed, 23 insertions(+), 2 deletions(-) commit 2dbf88c0ad6e4fa91b9350200cd0a0f01c114ab0 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 15:46:09 2019 +0000 Android: Fix proguard / manifest diff error messages having extra newlines Noticed this in https://ci.chromium.org/p/chromium/builders/try/android-binary-size/185090 Change-Id: I37f4ec975fccf7f7e4896400f375805abc4b1685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529885 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#641945} build/android/gyp/util/diff_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ed0e2fb7b7da56c2adf30c3d222ab6388337afe Author: Peter Kasting <pkasting@chromium.org> Date: Tue Mar 19 15:45:21 2019 +0000 Convert InitFocusSiblings() from before-insert to after-insert. This allows for later conversion of ReorderChildView() to use std::rotate(). For convenience of that, also changes the interface to use an iterator. This also shortens the implementation by using temps and collapsing together the actual setting of all the focus siblings into one block. Bug: none Change-Id: I9b5001c5bfc26d1d91e337962783db6ba34dcec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526313 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641944} ui/views/view.cc | 85 ++++++++++++++++++++++++-------------------------------- ui/views/view.h | 6 ++-- 2 files changed, 40 insertions(+), 51 deletions(-) commit 0f70a9bf9c7c34edfbbfdd39af8691bdb6fd209c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:45:04 2019 +0000 Roll src/third_party/swiftshader 1cef4e693fc3..24cb99d44e9c (5 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/1cef4e693fc3..24cb99d44e9c git log 1cef4e693fc3..24cb99d44e9c --date=short --no-merges --format='%ad %ae %s' 2019-03-19 capn@google.com Fix mipmap generation on undefined cube texture 2019-03-19 capn@google.com Use C++11 std::swap() 2019-03-19 swiftshader.regress@gmail.com Regres: Update test lists @ bbf5cf1e 2019-03-18 chrisforbes@google.com Wire up sample mask correctly 2019-03-18 chrisforbes@google.com Tidy stencil state handling Created with: gclient setdep -r src/third_party/swiftshader@24cb99d44e9c The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118386749,chromium:b/128715612 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I14c171af16b86036056f0fb03f1b9d23eb062dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530452 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641943} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 507a31fdc486f1013a126a20a7f6bb9cca153058 Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 15:44:16 2019 +0000 Delete chrome/browser/sync/profile_sync_test_util.h/cc These were mostly helping with the creation of a ProfileSyncServiceMock, but that isn't used anymore. A few places still included them, but didn't actually use them. Bug: 910518 Change-Id: I7226b450a83b89c8177f0486e1860e277c92f190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529276 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#641942} chrome/browser/BUILD.gn | 2 - chrome/browser/sync/profile_sync_test_util.cc | 67 ---------------------- chrome/browser/sync/profile_sync_test_util.h | 48 ---------------- .../sync/test/integration/autofill_helper.cc | 1 - .../browser/sync/test/integration/wallet_helper.cc | 1 - .../unified_consent/unified_consent_browsertest.cc | 1 - 6 files changed, 120 deletions(-) commit 5bafd05505636f1e55f42989e30cdcc8f13c027f Author: Lowell Manners <lowell@chromium.org> Date: Tue Mar 19 15:43:59 2019 +0000 Update IdentityManager to own SigninManager. With this change, SigninManager is now constructed only when creating an IdentityManager (in Chrome and iOS IdentityManager factories), eliminating the need for SigninManager factories. Part of internalizing all of IdentityManager's dependencies: http://doc/1bkN6o55cow55Izu0BfPxVWNgJBof0XHnQ9171omwFgo#heading=h.uz327n738tg8 Change-Id: I9679723e9beb8566077fd1dbfcc1879555184730 Bug: 939372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514792 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641941} chrome/browser/BUILD.gn | 2 - chrome/browser/signin/identity_manager_factory.cc | 79 ++++++++++++--- chrome/browser/signin/identity_manager_factory.h | 2 + .../identity_test_environment_profile_adaptor.cc | 2 - chrome/browser/signin/signin_manager_factory.cc | 108 --------------------- chrome/browser/signin/signin_manager_factory.h | 59 ----------- ios/chrome/browser/signin/BUILD.gn | 2 - .../browser/signin/identity_manager_factory.cc | 60 +++++++++--- .../browser/signin/identity_manager_factory.h | 2 + ...est_environment_chrome_browser_state_adaptor.cc | 2 - .../browser/signin/signin_manager_factory.cc | 79 --------------- ios/chrome/browser/signin/signin_manager_factory.h | 49 ---------- ios/web_view/BUILD.gn | 2 - ios/web_view/internal/DEPS | 1 - .../signin/web_view_identity_manager_factory.h | 4 +- .../signin/web_view_identity_manager_factory.mm | 72 +++++++++++--- .../signin/web_view_signin_manager_factory.h | 52 ---------- .../signin/web_view_signin_manager_factory.mm | 94 ------------------ services/identity/public/cpp/identity_manager.cc | 7 +- services/identity/public/cpp/identity_manager.h | 19 +++- .../public/cpp/identity_manager_unittest.cc | 87 ++++++++--------- .../public/cpp/identity_test_environment.cc | 77 +++++++-------- .../public/cpp/identity_test_environment.h | 11 ++- 23 files changed, 283 insertions(+), 589 deletions(-) commit ce31b4b95ac44c3eedf6b257418e694dc6176bc9 Author: Robert Kaplow <rkaplow@chromium.org> Date: Tue Mar 19 15:43:11 2019 +0000 Use UKM Source Ids for Translate This allows us to remove more usage of the old API. Also some lint cleanups Bug: 754895 Change-Id: Ib352360418559829392661cf30f34edf577e7e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521594 Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#641940} components/translate/content/browser/BUILD.gn | 1 + components/translate/content/browser/DEPS | 2 + .../content/browser/content_translate_driver.cc | 7 ++ .../content/browser/content_translate_driver.h | 2 + components/translate/core/browser/BUILD.gn | 2 + .../core/browser/mock_translate_driver.cc | 6 ++ .../translate/core/browser/mock_translate_driver.h | 2 + .../translate/core/browser/mock_translate_ranker.h | 6 +- .../translate/core/browser/translate_driver.h | 4 + .../translate/core/browser/translate_manager.cc | 4 +- .../translate/core/browser/translate_ranker.h | 7 +- .../core/browser/translate_ranker_impl.cc | 26 +++---- .../translate/core/browser/translate_ranker_impl.h | 14 ++-- .../core/browser/translate_ranker_impl_unittest.cc | 87 +++++++++++----------- components/translate/ios/browser/BUILD.gn | 1 + components/translate/ios/browser/DEPS | 1 + .../translate/ios/browser/ios_translate_driver.h | 1 + .../translate/ios/browser/ios_translate_driver.mm | 5 ++ 18 files changed, 106 insertions(+), 72 deletions(-) commit 86dcc70d0eb9c2df29d17e62577298b0b0512920 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Tue Mar 19 15:42:54 2019 +0000 [Extensions Bindings] Remove RequestSender RequestSender's functionality has been replaced with native bindings (predominantly in the form of APIRequestHandler). Remove the old RequestSender and all traces of it (e.g., ScriptContext's subclassing). Bug: 938998 Change-Id: I3940529fa575c4d94fb8ce08499cfe9c892e0732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525184 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641939} extensions/renderer/BUILD.gn | 2 - extensions/renderer/dispatcher.cc | 1 - extensions/renderer/request_sender.cc | 156 -------------------------------- extensions/renderer/request_sender.h | 94 ------------------- extensions/renderer/script_context.cc | 34 ------- extensions/renderer/script_context.h | 13 +-- extensions/renderer/set_icon_natives.cc | 1 - 7 files changed, 2 insertions(+), 299 deletions(-) commit a67d0f79b686f8468d6f51d03ae0304d21934a0f Author: Alexander Timin <altimin@chromium.org> Date: Tue Mar 19 15:42:03 2019 +0000 [scheduler] Rename active connection-related things. As a part of the generalisation of the scheduler feature notification mechanism, rename all OnActiveConnectionCreated to the match the policy: DisableAggressiveThrottling() and such. R=skyostil@chromium.org CC=haraken@chromium.org BUG=933147 Change-Id: Ieb96e45ae81bc643cf75aecd183bc24f20efdf6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526184 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641938} third_party/blink/renderer/core/BUILD.gn | 2 +- ...est.cc => scheduler_affecting_features_test.cc} | 25 +++++++----- .../scheduler/main_thread/frame_scheduler_impl.cc | 45 ++++++++++++---------- .../scheduler/main_thread/frame_scheduler_impl.h | 15 +++++--- .../scheduler/main_thread/page_scheduler_impl.cc | 27 +++++++------ .../scheduler/main_thread/page_scheduler_impl.h | 12 +++--- .../platform/scheduler/public/page_scheduler.h | 2 +- .../platform/scheduler/test/fake_page_scheduler.h | 4 +- .../test/renderer_scheduler_test_support.cc | 4 +- 9 files changed, 77 insertions(+), 59 deletions(-) commit 0288b22170bbe0f9fd6654415cf79d6f09732b4a Author: Dave Tapuska <dtapuska@chromium.org> Date: Tue Mar 19 15:41:47 2019 +0000 Fix flakiness in SWR fetch test when running lots of jobs. Hold the stash lock on the server while updating the server stash to avoid races between the SWR and the query requests. BUG=943095 Change-Id: Ic93faa7479ebe16a15390fd292efcb1bc87d7e8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529161 Reviewed-by: Adam Rice <ricea@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#641937} third_party/blink/web_tests/TestExpectations | 3 --- .../wpt/fetch/stale-while-revalidate/stale-css.py | 22 ++++++++++++-------- .../fetch/stale-while-revalidate/stale-image.py | 23 +++++++++++++-------- .../fetch/stale-while-revalidate/stale-script.py | 24 +++++++++++++--------- 4 files changed, 41 insertions(+), 31 deletions(-) commit 0448a24eda919b77a88c42063148be06f61a47ed Author: Monica Salama <msalama@google.com> Date: Tue Mar 19 15:40:56 2019 +0000 Android: Added more precision to native code's resident memory metric. Native code is roughly ~40MB on android. Changing the buckets to be in range [1, 100] MB gives more precison to the samples. Bug: 866396 Change-Id: Iecc9725dd2ee65fb77716530506baee92168cdbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524298 Reviewed-by: Benoit L <lizeb@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Monica Basta <msalama@google.com> Cr-Commit-Position: refs/heads/master@{#641936} .../browser/metrics/process_memory_metrics_emitter.cc | 8 +++++--- .../metrics/process_memory_metrics_emitter_unittest.cc | 4 ++-- tools/metrics/histograms/histograms.xml | 17 +++++++++++++++++ 3 files changed, 24 insertions(+), 5 deletions(-) commit ddcdbef4966de8c02919e76ba9b8862ece1d8624 Author: Siye Liu <siliu@microsoft.com> Date: Tue Mar 19 15:40:43 2019 +0000 Enable TSF support on Windows by default. Bug: 657623 Change-Id: I38a1438a8807016716c07fbf6b86d9fd76caf583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525676 Reviewed-by: Lan Wei <lanwei@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#641935} ui/base/ui_base_features.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 824740ccd8eb69cee864a4504bb5fb34a4c00cba Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:39:52 2019 +0000 Roll src/third_party/SPIRV-Tools/src 2ac348b5c0a5..e1a76269b649 (3 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2ac348b5c0a5..e1a76269b649 git log 2ac348b5c0a5..e1a76269b649 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 greg@lunarg.com Bindless Validation: Descriptor Initialization Check (#2419) 2019-03-18 alanbaker@google.com Reverting commit da5a780ff9fff7e226ca84728075adabc4d1608c 2019-03-18 sarahmashay@google.com Variable pointers cannot be an operand to OpArrayLength Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e1a76269b649 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I50e5b43a323ce11cd1d0410e01fff148d31ed858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529934 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641934} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 56d91576b15ba5e7fc159e770ffa83facb61a2e1 Author: Saman Sami <samans@chromium.org> Date: Tue Mar 19 15:39:37 2019 +0000 Don't skip activation dependency when SurfaceRange start=end SurfaceRange::start doesn't necessarily indicate an existing surface, so the activation dependency shouldn't be dropped when start=end. Bug: 942493 Change-Id: I05ef978bac4a6d6cd2b717fb78685603ac56b5df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525308 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#641933} cc/layers/surface_layer_impl.cc | 2 +- cc/layers/surface_layer_impl_unittest.cc | 9 ++------- 2 files changed, 3 insertions(+), 8 deletions(-) commit 17a024db96fc86e85f59d1c909339412e2ba8a23 Author: Khushal <khushalsagar@chromium.org> Date: Tue Mar 19 15:38:47 2019 +0000 testing/config: Enable fieldtrial testing for SurfaceControl. Enable SurfaceControl on android for fieldtrial testing. R=rkaplow@chromium.org Bug: 889328 Change-Id: I601ecba93d97c912b8c4177cbe09e99f7e3327fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529202 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#641932} testing/variations/fieldtrial_testing_config.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit a8198ef66a2be65fbf12728cf86a383dd7b856e8 Author: Robert Ogden <robertogden@chromium.org> Date: Tue Mar 19 15:38:32 2019 +0000 Update comment on prefs::kDataSaverEnabled One of several CLs to clean up usage of this pref. Bug: 934399 Change-Id: I982490161d50982cb9153072907b38202a191e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529694 Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#641931} chrome/common/pref_names.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 6460edfe7b5521b975187c348a1044e83d57c2c1 Author: Andrew Grieve <agrieve@chromium.org> Date: Tue Mar 19 15:37:41 2019 +0000 Android: Write build_vars.txt using a list of lines (refactor) Change-Id: Ia890a3ba83c7c825d1a68e08cabf210444b54bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526483 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#641930} build/android/BUILD.gn | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-) commit cf2e43d691da452e3eb423c4840106693c650cba Author: Daniel Bratell <bratell@opera.com> Date: Tue Mar 19 15:37:28 2019 +0000 [jumbo] Restrict it to one content::Status alias browser/indexed_db pulls leveldb::Status into content with "using" (i.e. creates a content::Status -> leveldb::Status alias). When devtools tries to do the same with inspector_protocol_encoding::Status some extreme jumbo builds sees the conflict and refuses to compile the code. Since inspector_protocol_encoding::Status is only used twice, inlining it seems pretty straightforward. Change-Id: I8b2fc585bba2f336cd5d910b4505a681ff9d9a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524355 Reviewed-by: Johannes Henkel <johannes@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#641929} content/browser/devtools/devtools_session_encoding.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 82efddec47061c7136b4fe76294be31a2cfb1a95 Author: Nico Weber <thakis@chromium.org> Date: Tue Mar 19 15:36:38 2019 +0000 Disable TextureFunctionTest.NonConstantOffset on win gpu fyi bots for a bit. Bug: 943140 Change-Id: I0ba9ef377ced18e5ccce6d0eabe86fae63be8a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529180 Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641928} testing/buildbot/chromium.gpu.fyi.json | 3 ++- testing/buildbot/chromium.gpu.json | 3 ++- testing/buildbot/test_suite_exceptions.pyl | 12 ++++++++++++ 3 files changed, 16 insertions(+), 2 deletions(-) commit ffe5a6c81108bddeeb14a37e4be2d33eeba31cab Author: Alan Cutter <alancutter@chromium.org> Date: Tue Mar 19 15:36:35 2019 +0000 Record user action of clicking on the PWA install icon Bug: 907351 Change-Id: Iad7d1a08eb67be51da82b9e06abd60cddc540203 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528025 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#641927} chrome/browser/ui/views/page_action/pwa_install_view.cc | 5 ++++- tools/metrics/actions/actions.xml | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) commit b411a56d71990653663e9a6cf2fba884887d23c0 Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 15:36:22 2019 +0000 PeopleHandler: grab/release sync_blocker in OnPrimaryAccountSet/Cleared This resolves a spurious temporary "ERROR" showing up in the avatar menu when going through the advanced Sync settings setup flow. This issue was previously partially fixed for crbug.com/738789, but it still occurred if a chrome://settings tab was already open when starting the Sync setup flow. Bug: 928696 Change-Id: Ib704e2972c507cc74cc548d47d2fcf84d45f30e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520494 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641926} chrome/browser/ui/webui/settings/people_handler.cc | 15 +++++++++++---- chrome/browser/ui/webui/settings/people_handler.h | 2 +- 2 files changed, 12 insertions(+), 5 deletions(-) commit 3e53042b02801af380d6fdb07a9ac00ba343aab2 Author: Alex Newcomer <newcomer@chromium.org> Date: Tue Mar 19 15:35:25 2019 +0000 Cros: Enable users to move apps via keyboard shortcut Control + arrow should let users move apps in the app grid. Only support the top level app grid for now, folder support will be added later. Bug: 887996 Change-Id: Ic23805b43e91f15021d002d19e3779d4a8a50580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497126 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641925} ash/app_list/app_list_metrics.h | 11 +- ash/app_list/app_list_util.cc | 4 + ash/app_list/app_list_util.h | 3 + ash/app_list/paged_view_structure.cc | 6 + ash/app_list/paged_view_structure.h | 9 +- ash/app_list/pagination_model.h | 4 +- ash/app_list/views/app_list_view.cc | 5 +- ash/app_list/views/apps_grid_view.cc | 202 +++++++++-- ash/app_list/views/apps_grid_view.h | 31 +- ash/app_list/views/apps_grid_view_unittest.cc | 385 +++++++++++++++++++++ ash/app_list/views/test/apps_grid_view_test_api.cc | 8 + ash/app_list/views/test/apps_grid_view_test_api.h | 6 + tools/metrics/histograms/enums.xml | 6 +- 13 files changed, 642 insertions(+), 38 deletions(-) commit 2cc35439ca0d844705369babe6e5d243d90ce38e Author: Peter E Conn <peconn@chromium.org> Date: Tue Mar 19 15:35:15 2019 +0000 🤝 Remove PersistentNotificationController. Bug: 928321 Change-Id: I4121c86a7d63ae6572620fcb3d206d91359f5d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1451983 Reviewed-by: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#641924} .../BrowserSessionContentHandler.java | 5 - .../BrowserSessionContentUtils.java | 34 +--- .../TrustedWebActivityModel.java | 14 +- .../PersistentNotificationController.java | 97 ---------- .../view/PersistentNotificationView.java | 197 --------------------- .../browser/customtabs/CustomTabActivity.java | 7 - .../notifications/NotificationConstants.java | 3 +- .../java/strings/android_chrome_strings.grd | 3 - chrome/android/java_sources.gni | 2 - 9 files changed, 4 insertions(+), 358 deletions(-) commit 871d5b867f3ef17f2aecd1142a4024540025415f Author: Hitoshi Yoshida <peria@chromium.org> Date: Tue Mar 19 15:34:19 2019 +0000 IDL compiler: Define classes for public APIs This CL defines public API classes designed in https://docs.google.com/document/d/1ZPuPWjBSQVfVeJYptk7dYg1OAxx89-kwHz6oJlZGA5o/edit?usp=sharing and they're not in use at the moment. This CL also adds .style.yapf to reformat python files under t/b/r/bindings/scripts/web_idl/. Bug: 839389 Change-Id: I9ae82c38d5541007df0fb40aef370cf7a980bc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1436779 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641923} .../renderer/bindings/scripts/web_idl/.style.yapf | 3 + .../renderer/bindings/scripts/web_idl/argument.py | 60 +- .../renderer/bindings/scripts/web_idl/attribute.py | 57 +- .../bindings/scripts/web_idl/callback_function.py | 37 +- .../bindings/scripts/web_idl/callback_interface.py | 59 +- .../renderer/bindings/scripts/web_idl/common.py | 120 ++++ .../renderer/bindings/scripts/web_idl/constant.py | 48 +- .../bindings/scripts/web_idl/constructor.py | 78 +++ .../bindings/scripts/web_idl/dictionary.py | 93 ++-- .../bindings/scripts/web_idl/enumeration.py | 31 +- .../renderer/bindings/scripts/web_idl/exposure.py | 42 ++ .../bindings/scripts/web_idl/extended_attribute.py | 150 +++-- .../bindings/scripts/web_idl/idl_database.py | 63 +++ .../bindings/scripts/web_idl/idl_definition.py | 66 +++ .../bindings/scripts/web_idl/idl_member.py | 18 + .../renderer/bindings/scripts/web_idl/idl_types.py | 611 +++++++++++++-------- .../renderer/bindings/scripts/web_idl/includes.py | 27 + .../renderer/bindings/scripts/web_idl/interface.py | 299 ++++++---- .../renderer/bindings/scripts/web_idl/namespace.py | 53 +- .../renderer/bindings/scripts/web_idl/operation.py | 86 +-- .../renderer/bindings/scripts/web_idl/typedef.py | 28 +- .../renderer/bindings/scripts/web_idl/values.py | 37 ++ 22 files changed, 1331 insertions(+), 735 deletions(-) commit 448e4fd532da16424fc2e5a1216c9b07f07aed33 Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Mar 19 15:33:50 2019 +0000 Fix offline pages src inlining Previous implementation only handled src="..." but pages like wikipedia use srcset="...; ..." As the filenames are 32 hex characters, it is safe to just replace every occurrences in the page. Bug: 943529 Change-Id: I2ec8ee064c91f42eb2a62fb0b8fcffe010de1226 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530880 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641922} ios/chrome/browser/reading_list/offline_page_tab_helper.mm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) commit 90ddf42811a15e47704940932699667f3891f521 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Tue Mar 19 15:33:14 2019 +0000 Update V8 to version 7.5.64. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/36585c1b..7d2a2a23 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If80a3b558fed6d61cff4d09910820803c69181a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529295 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641921} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 77b17dc48f0d14f1f69dd428d4c3b949983782c2 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Mar 19 15:32:45 2019 +0000 Introduce DeprecatedDefaultTaskRunner and use it at WidgetInputHandlerImpl For bfcache, we plan to forbid V8 execution on per-thread task runners. Now WidgetInputHandlerImpl's mojo binding should use a per-frame task runner, but it is not easy to replace it so far. Instead of replacing, this CL make WidgetInput use DeprecatedDefaultTaskRunner as a temporary hack. This CL introduces WebThreadScheduler::DeprecatedDefaultTaskRunner that now returns the same default task runner and we plan to make it return the different task runner/queue later. This is intended to be used where the task runner should be per-frame but is hard to be replaced. Originally ThreadScheduler::DeprecatedDefaultTaskRunner has existed for the same purpose, and this CL adds WebThreadScheduler:: DeprecatedDefaultTaskRunner for uses external to Blink. Bug: 870606, 913912 Change-Id: I234f37cc79da69828150d17b6b7efafdc394341d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527909 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#641920} .../renderer/input/widget_input_handler_impl.cc | 16 ++++++++++++++-- .../platform/scheduler/web_thread_scheduler.h | 6 ++++++ .../blink/renderer/platform/scheduler/BUILD.gn | 1 - .../scheduler/common/thread_scheduler_impl.cc | 22 ---------------------- .../scheduler/common/thread_scheduler_impl.h | 7 ++----- .../scheduler/common/web_thread_scheduler.cc | 6 ++++++ .../main_thread/main_thread_scheduler_helper.cc | 9 +++++++++ .../main_thread/main_thread_scheduler_helper.h | 1 + .../main_thread/main_thread_scheduler_impl.cc | 5 +++++ .../main_thread/main_thread_scheduler_impl.h | 2 ++ .../worker/non_main_thread_scheduler_impl.cc | 5 +++++ .../worker/non_main_thread_scheduler_impl.h | 3 +++ 12 files changed, 53 insertions(+), 30 deletions(-) commit 2997b01fa845967dfde9fc23c0005b0b2841d4bd Author: Vikas Soni <vikassoni@chromium.org> Date: Tue Mar 19 15:32:06 2019 +0000 SkiaRenderer: Add support to draw STREAM_VIDEO_CONTENT quads. This CL adds support to draw STREAM_VIDEO_CONTENT quads. Bug: 900963 Change-Id: If7a3db67897701be3a2a9ba58cc5a2156fdbd96f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529527 Reviewed-by: Peng Huang <penghuang@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#641919} components/viz/service/display/skia_renderer.cc | 25 ++++++++++++++++++++++++- components/viz/service/display/skia_renderer.h | 1 + 2 files changed, 25 insertions(+), 1 deletion(-) commit 8b2cca04405b9dc6bdbe82675d73066073db6f6f Author: Mario Sanchez Prada <mario@igalia.com> Date: Tue Mar 19 15:31:42 2019 +0000 Migrate //content/browser/service_worker to net::CompletionOnceCallback Replace usage of net::CompletionCallback as well as replace usages of base::Bind() with base::BindOnce(). Bug: 807724 Change-Id: If81e460116921a57d160d16d5c33a98804185edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528189 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641918} .../service_worker/service_worker_cache_writer.cc | 18 ++++++++++-------- .../browser/service_worker/service_worker_storage.cc | 5 +++-- 2 files changed, 13 insertions(+), 10 deletions(-) commit 8fd5d9a5f649b5914acc3dca5eda3d821199a7a8 Author: Stephen McGruer <smcgruer@chromium.org> Date: Tue Mar 19 15:30:58 2019 +0000 Correctly specify CSS Transition timing functions on the effect Previously they were specified on the start_keyframe because we didn't want the delay keyframe to be affected by the timing function. Now that the delay keyframe has been removed (https://crrev.com/fde1ecb), the timing function can be left on the effect. Fixing this also requires changing the time calculation in the 'transitioncancel' event firer code. Previously this was calculated from the transformed-progress[0] multiplied by the iteration duration[1]. However the transformed-progress includes the timing function, and the spec actually says to use[2]: "The active time of the animation at the moment it was cancelled calculated using a fill mode of both." Finally, this change fixes re-targeting of in-flight transitions, which previously only worked properly for linear transitions. [0]: https://drafts.csswg.org/web-animations-1/#calculating-the-transformed-progress [1]: https://drafts.csswg.org/web-animations-1/#iteration-duration [2]: https://drafts.csswg.org/css-transitions-2/#event-dispatch Bug: 934709 Change-Id: I73545795e1aa5b009461fea6f610c145262058c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526481 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641917} .../blink/renderer/core/animation/animation_effect.h | 1 + .../renderer/core/animation/css/css_animations.cc | 19 +++++++++---------- .../core/inspector/inspector_animation_agent.cc | 20 +++----------------- .../animations/reverse-transition-with-easing.html | 6 +++--- 4 files changed, 16 insertions(+), 30 deletions(-) commit 1fcfd3fed3a585ae8558f39f75389667766cb54f Author: Robert Liao <robliao@chromium.org> Date: Tue Mar 19 15:30:37 2019 +0000 Run clang-tidy modernize-use-nullptr on //ui/views This is a run of run-clang-tidy.py -checks="-*,modernize-use-nullptr" -header-filter=ui/views/* \\src\\ui\\views\\ BUG=940732 This CL was uploaded by git cl split. TBR=msw@chromium.org Change-Id: I2b4e689ffb1d82bcd11942fef29c4ae499f7e497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529915 Reviewed-by: Robert Liao <robliao@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#641916} ui/views/bubble/bubble_dialog_delegate_view.cc | 8 ++++---- ui/views/bubble/bubble_dialog_delegate_view_unittest.cc | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) commit aeafee7af732574e87eaa36621d1c54cfe112d49 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 19 15:29:54 2019 +0000 Remove AudioNodeOutput::Create in modules/webaudio As advised in [1], this CL removes unnecessary AudioNodeOutput::Create() in //third_party/blink/renderer/modules/webaudio and make their constructors public, then make the callers use std::make_unique<AudioNodeOutput> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I57563c56a93be475b6368d13c528d8e247e4f556 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524819 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641915} third_party/blink/renderer/modules/webaudio/audio_node.cc | 5 +++-- .../blink/renderer/modules/webaudio/audio_node_input.cc | 4 ---- third_party/blink/renderer/modules/webaudio/audio_node_input.h | 4 +--- .../blink/renderer/modules/webaudio/audio_node_input_test.cc | 8 ++++---- .../blink/renderer/modules/webaudio/audio_node_output.cc | 10 ++-------- .../blink/renderer/modules/webaudio/audio_node_output.h | 5 ++--- 6 files changed, 12 insertions(+), 24 deletions(-) commit c7d6ea2241d3334cb748fa298153f49df20f6e74 Author: dstockwell <dstockwell@google.com> Date: Tue Mar 19 15:29:31 2019 +0000 pdf: Fix anchor navigation This was a regression introduced by the refactor in [1]. This is a quick fix, a proper API and type checking will be added later. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1368845 Bug: 943340 Change-Id: I88369022671d5a44dcca9b0be0a76da486fcf2a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529973 Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641914} chrome/browser/resources/pdf/pdf_viewer.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 13330ec99e9b599a060b6808075ebaaec139569e Author: Tim Song <tengs@chromium.org> Date: Tue Mar 19 15:28:51 2019 +0000 Notifications: Allow removing non-visible notifications in MessageCenter. Currently, MessageCenter::RemoveNotification() only removes "visible" notifications. In multi-user mode (and other scenarios), notifications for non-active users are blocked and not "visible". When Android dismisses an ARC notification from a non-active user, the corresponding MessageCenter notification is not properly removed. Accessing the invalid notification will result in a crash. BUG=940060 TEST=new unit test, verified bug does not repro Change-Id: Ic6688b4d7137777d7b77dc07a823681927975dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530476 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#641913} .../arc/arc_notification_delegate.cc | 2 +- ui/message_center/message_center_impl.cc | 2 +- ui/message_center/message_center_impl_unittest.cc | 22 ++++++++++++++++++++++ 3 files changed, 24 insertions(+), 2 deletions(-) commit 18bafcb1b62cdd3dbcbb68dacd1927bfbee506ee Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:28:24 2019 +0000 Roll src/third_party/dawn fef613365afe..54e4d47db491 (1 commits) https://dawn.googlesource.com/dawn.git/+log/fef613365afe..54e4d47db491 git log fef613365afe..54e4d47db491 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 jiawei.shao@intel.com Add check on the sample count between render pipeline and render pass Created with: gclient setdep -r src/third_party/dawn@54e4d47db491 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iae530f60828658809a6b7a724b875cb1f8c70f2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530150 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641912} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bf696a84449c24591b51c7310ca059e9d960a129 Author: Alexey Baskakov <loyso@chromium.org> Date: Tue Mar 19 15:27:47 2019 +0000 WebApp: Use abstract web_app::InstallManager instead of BookmarkAppHelper. Let BookmarkAppInstallManager implementation wraps BookmarkAppHelper calls for ApkWebAppInstaller (Arc++-initiated installations). Bug: 915043 Change-Id: I0880fc232921e5c1ce7bf4b9001803cb40839a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519347 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#641911} .../browser/chromeos/apps/apk_web_app_installer.cc | 94 ++++++++------- .../browser/chromeos/apps/apk_web_app_installer.h | 33 +++--- .../apps/apk_web_app_installer_unittest.cc | 25 ++-- .../browser/chromeos/apps/apk_web_app_service.cc | 13 ++- chrome/browser/chromeos/apps/apk_web_app_service.h | 11 +- .../web_applications/bookmark_apps/BUILD.gn | 1 + .../bookmark_apps/bookmark_app_install_manager.cc | 84 +++++++++++--- .../bookmark_apps/bookmark_app_install_manager.h | 13 ++- .../bookmark_app_install_manager_unittest.cc | 126 +++++++++++++++++++++ .../browser/web_applications/components/BUILD.gn | 2 + .../web_applications/components/install_manager.cc | 28 +++++ .../web_applications/components/install_manager.h | 24 +++- .../components/install_manager_observer.h | 20 ++++ .../components/web_app_constants.h | 3 +- .../web_applications/web_app_install_manager.cc | 9 ++ .../web_applications/web_app_install_manager.h | 5 + .../browser/web_applications/web_app_provider.cc | 9 +- tools/metrics/histograms/enums.xml | 1 + 18 files changed, 405 insertions(+), 96 deletions(-) commit 718b7e702950f534284bf7ebda22d4d5d667e43c Author: Antonio Gomes <tonikitoo@igalia.com> Date: Tue Mar 19 15:27:21 2019 +0000 Rework modules/filesystem's MetadataCallbacks callbacks' mechanism Currently, the various classes in file_system_callbacks.h (namely MetadataCallbacks, VoidCallbacks, EntryCallbacks, et al) rely on a relatively complex mechanism for getting their success/error completion callbacks dispatched. This CL is a first of a series of N CLs that aims at simplifying this mechanism. The basic idea is to switch the current implementation each wrapper callback class has by a pair of two OnceCallback instances, one for success, another for error. The class that is switched over in this CL is MetadataCallbacks. No functionality change is expected, so no new tests. Note that it could be possible as part of this CL to eliminate MetadataCallbacks completely, and just invoke the completion callbacks from FileSystemDispatcher class directly. However, for the sake of preserving the existing behavior where the MetadataCallbacks wrapper class calls DOMFileSystemBase::AddPendingCallbacks and ::RemovePendingCallbacks when it is created and destroyed respectively, this change is not done at this pass yet. Planned follow ups: - Implement a way to avoid code duplication when constructing the functors. - Implement a way to preserve the existing behavior that wrapper callback classes call DOMFileSystemBase::AddPendingCallbacks and ::RemovePendingCallbacks when created and destroyed respectively. - Eliminate MetadataCallbacks class completely and invoke its success and error callbacks from FileSystemDispatcher directly. - Switch other wrapper callback classes to simple success/error callbacks approach. R=mek@chromium.org CC=​​dgozman@chromium.org,blink-reviews-vendor@chromium.org BUG=933878 Change-Id: Ib3b036549de98728fbd276601db972dc389048c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525102 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#641910} .../modules/filesystem/dom_file_system_base.cc | 6 ++--- .../modules/filesystem/dom_file_system_base.h | 4 +-- .../blink/renderer/modules/filesystem/entry.cc | 28 ++++++++++++++++--- .../renderer/modules/filesystem/entry_sync.cc | 12 +++++++-- .../modules/filesystem/file_system_callbacks.cc | 29 +++++++------------- .../modules/filesystem/file_system_callbacks.h | 31 ++++++++-------------- .../modules/filesystem/sync_callback_helper.h | 12 +++++++++ 7 files changed, 72 insertions(+), 50 deletions(-) commit 5ac45fd86d7d39bc9f1934f5548392a87ec03097 Author: David Bienvenu <davidbienvenu@chromium.org> Date: Tue Mar 19 15:26:39 2019 +0000 Fix GlassBrowserFrameView::GetMinimumSize after restore from maximize BrowserViewLayout::GetMinimumSize takes into account whether the tab strip is visible so GlassBrowserFrameView doesn't need this calculation, which is wrong in some cases anyway. See bug for more details about when it's wrong. Bug: 933124 Change-Id: I05d157b758c8d818954c865cd2c73b3669ac8a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529650 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#641909} chrome/browser/ui/views/frame/glass_browser_frame_view.cc | 9 --------- 1 file changed, 9 deletions(-) commit bfc64237b12fe6a44fd4483a61d244cc3cd08530 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 19 15:26:15 2019 +0000 Remove TransformationMatrix::Create(...) in platform/transforms As advised in [1], this CL removes unnecessary TransformationMatrix::Create(...) in //third_party/blink/renderer/platform/transform and make it's constructor public, then make the callers use std::make_unique<TransformationMatrix> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I5be85eca16ff02c2c18faa1718829d1bc0ade855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530250 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641908} .../renderer/core/geometry/dom_matrix_read_only.cc | 2 +- .../renderer/core/geometry/dom_matrix_read_only.h | 8 ++--- .../renderer/core/layout/layout_geometry_map.cc | 2 +- .../blink/renderer/core/paint/paint_layer.cc | 2 +- .../modules/xr/xr_bounded_reference_space.cc | 4 +-- third_party/blink/renderer/modules/xr/xr_frame.cc | 15 ++++----- .../blink/renderer/modules/xr/xr_frame_provider.cc | 2 +- third_party/blink/renderer/modules/xr/xr_ray.cc | 2 +- .../renderer/modules/xr/xr_reference_space.cc | 2 +- .../renderer/modules/xr/xr_rigid_transform.cc | 8 ++--- .../renderer/modules/xr/xr_rigid_transform_test.cc | 6 ++-- .../blink/renderer/modules/xr/xr_session.cc | 16 +++++----- .../modules/xr/xr_stationary_reference_space.cc | 12 ++++---- .../modules/xr/xr_unbounded_reference_space.cc | 2 +- third_party/blink/renderer/modules/xr/xr_utils.cc | 2 +- third_party/blink/renderer/modules/xr/xr_view.cc | 13 ++++---- .../platform/transforms/transform_state.cc | 9 +++--- .../renderer/platform/transforms/transform_state.h | 2 +- .../platform/transforms/transformation_matrix.h | 36 ---------------------- 19 files changed, 56 insertions(+), 89 deletions(-) commit c774ca6aea9ed24cb6b21f1d229e847197564813 Author: Leo Zhang <googleo@chromium.org> Date: Tue Mar 19 15:25:31 2019 +0000 Extend 3 months for M17N metrics. We launched this feature late due to some reviews. Bug: 888885, 938030 Change-Id: I7ab1bd93655f061c7c18ea946107e7dd28d7d24c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528023 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#641907} tools/metrics/histograms/histograms.xml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit b74c8a8d55a5cf2d02a2021ad45e8137395d99d8 Author: Robert Sesek <rsesek@chromium.org> Date: Tue Mar 19 15:25:10 2019 +0000 [Mac] Convert the task manager layout to code, rather than a XIB. This says goodbye to the last shipped XIB in Chrome. Change-Id: I42399f1e689f46fe099d080d3ae8d556133fe204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529700 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641906} chrome/BUILD.gn | 1 - chrome/app/nibs/BUILD.gn | 35 ------- chrome/app/nibs/OWNERS | 1 - chrome/app/nibs/PRESUBMIT.py | 93 ----------------- chrome/app/nibs/TaskManager.xib | 108 -------------------- chrome/app/nibs/generate_localizer.py | 151 ---------------------------- chrome/browser/ui/BUILD.gn | 3 - chrome/browser/ui/cocoa/task_manager_mac.h | 11 +- chrome/browser/ui/cocoa/task_manager_mac.mm | 99 +++++++++++++++--- chrome/browser/ui/cocoa/ui_localizer.h | 34 ------- chrome/browser/ui/cocoa/ui_localizer.mm | 101 ------------------- 11 files changed, 91 insertions(+), 546 deletions(-) commit 31221495ed6e4ba110d9dfc072a5f4af9e23403b Author: Marc Treib <treib@chromium.org> Date: Tue Mar 19 15:24:05 2019 +0000 Expose SyncService::RequiresClientUpgrade to Java ...and use it to replace the unnecessarily-broad getProtocolErrorClientAction. This is a direct followup to https://crrev.com/c/1523095. Bug: 940437 Change-Id: Iecb5c9fc7a1cddf2b72197f2ea01994d9274cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528571 Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#641905} .../browser/preferences/SyncAndServicesPreferences.java | 4 +--- .../chrome/browser/preferences/SyncPreferenceUtils.java | 4 +--- .../org/chromium/chrome/browser/sync/ProfileSyncService.java | 11 +++-------- .../chrome/browser/sync/ui/SyncCustomizationFragment.java | 4 +--- chrome/browser/sync/profile_sync_service_android.cc | 9 ++------- chrome/browser/sync/profile_sync_service_android.h | 4 +--- components/sync/android/BUILD.gn | 1 - components/sync/protocol/sync_protocol_error.h | 5 ++--- 8 files changed, 11 insertions(+), 31 deletions(-) commit c1bf3f80d67101b19b8cd8fffb47e6e0dcf3f896 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Tue Mar 19 15:23:23 2019 +0000 Add PIN code to print ticket. Bug: 848942 Change-Id: Ie5a1060c728f5d1e0dc56603b8950abe3f9e692c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477234 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#641904} .../browser/resources/print_preview/new/model.js | 6 ++ chrome/test/data/webui/print_preview/model_test.js | 74 +++++++++++++++------- printing/backend/cups_ipp_util.h | 4 ++ printing/print_job_constants.cc | 3 + printing/print_job_constants.h | 1 + printing/print_settings.h | 6 ++ printing/print_settings_conversion.cc | 4 ++ printing/print_settings_conversion_unittest.cc | 6 +- printing/printing_context_chromeos.cc | 4 ++ 9 files changed, 83 insertions(+), 25 deletions(-) commit 7a16ff96fc19003debf002c8d7505b1d0799376a Author: Stephen Nusko <nuskos@chromium.org> Date: Tue Mar 19 15:22:35 2019 +0000 Reserve on the first call to OnTraceBack rather in the construction of the JSONTraceExporter. This prevents the memory from being reserved while the trace is ongoing. Allowing it not to be counted in the memory regression perf tests. Bug: crbug/941079 Change-Id: Id356f9a3dcb76b67bda9a65c23a70367538df324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529279 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#641903} services/tracing/perfetto/json_trace_exporter.cc | 15 ++++++++++----- services/tracing/perfetto/json_trace_exporter.h | 2 ++ 2 files changed, 12 insertions(+), 5 deletions(-) commit bf13aa292ca2112c18e0986eaa5e2c3b25b43dc0 Author: Takashi Toyoshima <toyoshim@chromium.org> Date: Tue Mar 19 15:22:14 2019 +0000 OOR-CORS: Update TestExpectations for Slow tests A test under the virtual/outofblink-cors/ was marked as [ Pass Failure ], but the original test suite was marked as [ Slow ]. So, let me remove the test specific expectation, and mark the group as Slow with a relvant crbug link. Bug: 516319, 940136 Change-Id: I233417bac135bb59cb389e8e7e07dd5573ae809b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529506 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#641902} third_party/blink/web_tests/SlowTests | 1 + third_party/blink/web_tests/TestExpectations | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) commit 2039e5ab4650c1e5fddd4699a80b84a65653b321 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Mar 19 15:21:28 2019 +0000 service worker: ServiceWorkerRequestHandler is only for main resources. Remove dead code following the launch of S13nServiceWorker. Bug: 926114 Change-Id: Ib3524fa81e2f68c76e81f64f85344ea2ca0d54d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530216 Auto-Submit: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#641901} .../browser/loader/navigation_url_loader_impl.cc | 2 +- .../service_worker_controllee_request_handler.cc | 55 +++++----------------- .../service_worker_controllee_request_handler.h | 11 +---- .../service_worker/service_worker_provider_host.cc | 22 ++++----- .../service_worker_request_handler.cc | 5 +- .../service_worker_request_handler.h | 7 +-- .../service_worker_request_handler_unittest.cc | 2 +- .../service_worker/service_worker_version.cc | 5 -- .../service_worker/service_worker_version.h | 4 -- 9 files changed, 27 insertions(+), 86 deletions(-) commit dab334ece7896a82d200a47b0d844f68bce0b3f4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:21:08 2019 +0000 Roll src/third_party/depot_tools b542cca26697..d2b0c2ae17fe (4 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b542cca26697..d2b0c2ae17fe git log b542cca26697..d2b0c2ae17fe --date=short --no-merges --format='%ad %ae %s' 2019-03-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-18 veranika@google.com windows_sdk module: yield paths to provided SDK directories 2019-03-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d2b0c2ae17fe The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib916856081fdd774af753bf0cfad268d3913a462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529159 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641900} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 539b87585c4211337eee0e3570d4ce14aa23e464 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 19 15:20:23 2019 +0000 Remove WebThreadSupportingGC::Create() in blink's platform As advised in [1], this CL removes unnecessary WebThreadSupportingGC::Create() in //third_party/blink/renderer/platform and make it's constructor public, then make the callers use std::make_unique<WebThreadSupportingGC> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I9530b2841aa317ec87762ca72d86dd6d159b8174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529979 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641899} .../blink/renderer/core/css/cssom/cross_thread_style_value_test.cc | 6 +++--- .../core/css/cssom/paint_worklet_style_property_map_test.cc | 2 +- .../blink/renderer/core/css/threaded/multi_threaded_test_util.h | 2 +- third_party/blink/renderer/core/workers/worker_backing_thread.cc | 2 +- third_party/blink/renderer/modules/webdatabase/database_thread.cc | 2 +- third_party/blink/renderer/platform/web_thread_supporting_gc.cc | 5 ----- third_party/blink/renderer/platform/web_thread_supporting_gc.h | 5 +---- 7 files changed, 8 insertions(+), 16 deletions(-) commit 63b0011936213207438179d4ac54c716f3b81216 Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 19 15:20:01 2019 +0000 Change unsigned long to uint32_t/uint64_t in third_party/blink/ related Resources - unsigned long -> uint64_t for the request identifier to make a consistency with indentifier's type in //net - unsigned long -> uint32_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: Iaa1a56956b3d2f62c000fd682212d5812f711856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528130 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641898} third_party/blink/public/web/web_view.h | 2 +- .../renderer/bindings/core/v8/script_streamer.h | 4 +- .../exported/web_associated_url_loader_impl.cc | 8 ++-- .../blink/renderer/core/exported/web_view_impl.cc | 2 +- .../blink/renderer/core/exported/web_view_impl.h | 2 +- .../blink/renderer/core/fetch/fetch_manager.cc | 10 ++--- .../blink/renderer/core/frame/frame_console.cc | 4 +- .../blink/renderer/core/frame/frame_console.h | 4 +- .../renderer/core/inspector/console_message.cc | 2 +- .../renderer/core/inspector/console_message.h | 2 +- .../renderer/core/inspector/identifiers_factory.cc | 4 +- .../renderer/core/inspector/identifiers_factory.h | 4 +- .../core/inspector/inspector_network_agent.cc | 48 +++++++++++----------- .../core/inspector/inspector_network_agent.h | 46 ++++++++++----------- .../core/inspector/inspector_trace_events.cc | 28 ++++++------- .../core/inspector/inspector_trace_events.h | 26 ++++++------ .../blink/renderer/core/loader/document_loader.cc | 2 +- .../blink/renderer/core/loader/document_loader.h | 4 +- .../renderer/core/loader/frame_fetch_context.cc | 18 ++++---- .../renderer/core/loader/frame_fetch_context.h | 17 ++++---- .../blink/renderer/core/loader/progress_tracker.cc | 9 ++-- .../blink/renderer/core/loader/progress_tracker.h | 10 ++--- .../renderer/core/loader/threadable_loader.cc | 4 +- .../blink/renderer/core/loader/threadable_loader.h | 3 +- .../core/loader/threadable_loader_client.h | 4 +- .../renderer/core/loader/threadable_loader_test.cc | 5 +-- .../renderer/core/loader/worker_fetch_context.cc | 12 +++--- .../renderer/core/loader/worker_fetch_context.h | 12 +++--- .../blink/renderer/core/probe/core_probes.pidl | 42 +++++++++---------- .../core/workers/worker_classic_script_loader.cc | 4 +- .../core/workers/worker_classic_script_loader.h | 8 ++-- .../core/xmlhttprequest/xml_http_request.cc | 4 +- .../core/xmlhttprequest/xml_http_request.h | 4 +- .../background_fetch_icon_loader.cc | 5 +-- .../background_fetch_icon_loader.h | 2 +- .../renderer/modules/eventsource/event_source.cc | 4 +- .../renderer/modules/eventsource/event_source.h | 6 +-- .../modules/netinfo/network_information.cc | 4 +- .../renderer/modules/netinfo/network_information.h | 4 +- .../modules/netinfo/testing/internals_net_info.cc | 2 +- .../modules/netinfo/testing/internals_net_info.h | 2 +- .../notifications/notification_image_loader.cc | 5 +-- .../notifications/notification_image_loader.h | 2 +- .../notification_image_loader_test.cc | 2 +- .../websockets/inspector_websocket_events.cc | 4 +- .../websockets/inspector_websocket_events.h | 4 +- .../modules/websockets/websocket_channel_impl.h | 2 +- .../platform/loader/fetch/fetch_context.cc | 18 ++++---- .../renderer/platform/loader/fetch/fetch_context.h | 17 ++++---- .../renderer/platform/loader/fetch/resource.cc | 6 +-- .../renderer/platform/loader/fetch/resource.h | 6 +-- .../platform/loader/fetch/resource_fetcher.cc | 8 ++-- .../platform/loader/fetch/resource_fetcher.h | 6 +-- .../platform/loader/fetch/unique_identifier.cc | 4 +- .../platform/loader/fetch/unique_identifier.h | 2 +- .../platform/loader/testing/mock_fetch_context.h | 2 +- .../platform/network/network_state_notifier.cc | 2 +- .../platform/network/network_state_notifier.h | 4 +- .../renderer/platform/probe/platform_probes.pidl | 2 +- 59 files changed, 237 insertions(+), 246 deletions(-) commit 701c6e1bf1c1814e2e68d127efcb24e82beae2e5 Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Mar 19 15:19:18 2019 +0000 translate: Use a per-frame task runner at TranslateHelper This CL switches task runners at several places from per-thread to per-frame. The purpose of this change is to make it possible to freeze tasks for bfcache. We found an actual case that JavaScript is executed: browser_tests --gtest_filter=DevToolsSanityTest.TestDeviceEmulation Bug: 870606 Change-Id: Icac06c7f7f58dd981bfe392177a715906800795d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530372 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641897} components/translate/content/renderer/translate_helper.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit 977893e0673a46c3d5cf9fbd91b3da7387eb18fd Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 19 15:18:55 2019 +0000 Use Format macro, String::Number and std::to_string instead of type casting - not use of type casting - unsigned long -> uint64_t - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: Ifffafc003aad855a97defef60f849ebf4a5b1e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529497 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641896} .../renderer/core/frame/local_frame_ukm_aggregator.cc | 19 +++++++++---------- third_party/blink/renderer/platform/heap/heap.cc | 3 +-- third_party/blink/renderer/platform/heap/heap_page.cc | 8 +++----- .../platform/partition_alloc_memory_dump_provider.cc | 9 +++++---- 4 files changed, 18 insertions(+), 21 deletions(-) commit 778f81f250f6d41b0d9fefa8ff5be879ca34b3e3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:18:14 2019 +0000 Roll src/third_party/skia 4a20dbeaf31a..6caab2161079 (27 commits) https://skia.googlesource.com/skia.git/+log/4a20dbeaf31a..6caab2161079 git log 4a20dbeaf31a..6caab2161079 --date=short --no-merges --format='%ad %ae %s' 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 289a576d337a..b8c63935328f (1 commits) 2019-03-19 robertphillips@google.com Have DM's "--pr ~*" processing start from the default list of path renderers 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 eb986426cd6d..9b050f846a06 (1 commits) 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader bbf5cf1e4762..289a576d337a (1 commits) 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-19 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-03-19 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 cda4383919b9..eb986426cd6d (5 commits) 2019-03-19 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-18 brianosman@google.com Fix the preallocated size of string arrays in GrGLSLShaderBuilder 2019-03-18 halcanary@google.com Docs: Give documentation examples better names 2019-03-18 kjlubick@google.com Add SkSL2Pipeline fuzzer 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1bd9e2f80b9a..bbf5cf1e4762 (1 commits) 2019-03-18 brianosman@google.com Remove unused variant of compileAndAttachShaders 2019-03-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-18 mtklein@google.com SkScan_AAAPath style and refactoring 2019-03-18 jvanverth@google.com Fix more failing tests on Metal. 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 1cef4e693fc3..1bd9e2f80b9a (1 commits) 2019-03-18 khushalsagar@chromium.org remote fonts: Make DiscardableManager for tests thread-safe. 2019-03-18 bsalomon@google.com Revert "Revert "Change promise image contract to for when Release and Done are called."" 2019-03-18 benjaminwagner@google.com Revert "Omit some SKPs that seem to cause GalaxyS9 to crash." 2019-03-18 kjlubick@google.com Break out GrGLAssembleInterface into a few files 2019-03-18 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-03-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 38e282570676..cda4383919b9 (1 commits) 2019-03-18 mtklein@google.com don't bother passing lowp kernels dummy unnamed variables 2019-03-18 mtklein@google.com limit n7/np to main thread Created with: gclient setdep -r src/third_party/skia@6caab2161079 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I9410e6979d2bf922edf481ffe88b9ea5bd6f7b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530453 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641895} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 11adcd75d0d7806fd97f140e708831b0dd9bcc10 Author: Andy Paicu <andypaicu@chromium.org> Date: Tue Mar 19 15:17:50 2019 +0000 Parse first-party-sets and save the result in the origin_policy This does nothing else besides parsing the "first-party-set" entry in the manifest and saving it into an origin_policy. The entire thing is behind the OriginPolicy feature flag so I did not see a reason to add any other flag. Also added tests. Bug: 943144 Change-Id: I673d6bfc05bba8e72e320c339dabfa4ee27c576f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528574 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#641894} .../common/origin_policy/origin_policy_parser.cc | 38 +++++- .../common/origin_policy/origin_policy_parser.h | 2 + .../common/origin_policy/origin_policy_unittest.cc | 142 +++++++++++++++++++++ .../public/common/origin_policy/origin_policy.h | 8 ++ 4 files changed, 189 insertions(+), 1 deletion(-) commit 45e1e89936f153817ff4dd01d6ea689e7ed8c8f1 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Tue Mar 19 15:17:06 2019 +0000 [layoutng] Minor optimizations Inlining, and combines setting width and height so that we only need to call SizeChanged once. Change-Id: I168337ac625e37eb2f586c804ec304e1ba4c3fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529796 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#641893} .../blink/renderer/core/layout/ng/ng_block_node.cc | 27 ++++++++++++++-------- .../layout/ng/ng_container_fragment_builder.cc | 6 ----- .../core/layout/ng/ng_container_fragment_builder.h | 5 +++- 3 files changed, 21 insertions(+), 17 deletions(-) commit 84732f0f5e2a4522b3fe9ff18aa2c3a6928f8658 Author: Kent Tamura <tkent@chromium.org> Date: Tue Mar 19 15:16:45 2019 +0000 custom-elements: An exception message from define() should mention the custom element name. Old: this name has already been used with this registry New: the name "my-element" has already been used with this registry Change-Id: I1d50ee3b79c0bd1e042421dd20b2fc199a6ac3ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529495 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#641892} third_party/blink/renderer/core/html/custom/custom_element_registry.cc | 2 +- .../external/wpt/custom-elements/CustomElementRegistry-expected.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 294bdb9b86e64526ab8a205ecd7f6fb61d3a8832 Author: Dmitry Gozman <dgozman@chromium.org> Date: Tue Mar 19 15:15:59 2019 +0000 Plumb WebDocumentLoader to CreateApplicationCacheHost This is a preparation to remove provisional document loader. Since this method actually uses the about-to-commit loader, we should plumb it through. This corresponds to the step 8.d form the doc linked to the bug. Bug: 855189 Change-Id: Ia3f821d7a3aa0f183c4130ac3fab5545b7830ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1450264 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#641891} content/renderer/render_frame_impl.cc | 7 +++---- content/renderer/render_frame_impl.h | 1 + third_party/blink/public/web/web_local_frame_client.h | 1 + .../blink/renderer/core/exported/local_frame_client_impl.cc | 4 +++- third_party/blink/renderer/core/exported/local_frame_client_impl.h | 1 + third_party/blink/renderer/core/exported/worker_shadow_page.cc | 1 + third_party/blink/renderer/core/exported/worker_shadow_page.h | 1 + third_party/blink/renderer/core/frame/local_frame_client.h | 1 + .../blink/renderer/core/loader/appcache/application_cache_host.cc | 5 +++-- .../blink/renderer/core/loader/appcache/application_cache_host.h | 4 +++- third_party/blink/renderer/core/loader/document_loader.cc | 6 ++++-- third_party/blink/renderer/core/loader/empty_clients.cc | 1 + third_party/blink/renderer/core/loader/empty_clients.h | 1 + 13 files changed, 24 insertions(+), 10 deletions(-) commit 4ee817f702430606f0ef3c8f5123c3859a26fd20 Author: Mike Wasserman <msw@chromium.org> Date: Tue Mar 19 15:15:37 2019 +0000 Fix a reentrancy crash when closing the status bubble Widget::CloseNow sends windows messages to Chrome. This can cause reentrancy into StatusBubble code. Avoid crashes due to member destruction ordering. Bug: 943128 Test: No reentrancy crashes closing the status bubble. Change-Id: I3bb76712c87e2a30e3b33e28a35a4efa76da8d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529123 Reviewed-by: Evan Stade <estade@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#641890} chrome/browser/ui/views/status_bubble_views.cc | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) commit 8aa018bcacc1accd94c6ba47e14bf08f7cc52ca9 Author: Peter Kasting <pkasting@chromium.org> Date: Tue Mar 19 15:14:54 2019 +0000 Make AddChildView() match AddChildViewAt() re: views already parented to |this|. Currently, if you call AddChildView[At]() with an already-parented view, it moves the view to be parented to |this| and places it at the desired index (at the end, in the case of AddChildView()). The exception is AddChildView() when the parent is |this|; in that case the function currently no-ops. This change makes it equivalent to calling ReorderChildView(v, -1), which means there are no behavior exceptions. Long-term, a better behavior for these functions is probably to DCHECK that the supplied child is not parented (since that behavior doesn't play nicely with APIs that transfer ownership to the parent view), but this at least makes that conversion only need to change one place and not two. I did not check if this had behavioral effects. IMO the old behavior was obscure and if callers were explicitly relying on it _not_ moving a view to the end, they shouldn't have been calling AddChildView() to begin with (call nothing or call AddChildViewAt() and pass the index you want). Bug: 942298 Change-Id: I1d3a95a9f7827cd84a1c569b68b947c849c9e4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526311 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#641889} ui/views/view.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) commit b5a6bccb87e88c258c48e99471deb04b563448d9 Author: Egor Pasko <pasko@chromium.org> Date: Tue Mar 19 15:14:31 2019 +0000 crashpad_stackwalker: Allow running from any $PWD I only tested crashpad_stackwalker from chrome-src as a working directory, but the bots may use a different working directory. Construct the path as relative to the script path. Bug: 925453 Change-Id: I0840d0c7f8ecc4e743ca787595c12fdccaf21fe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529270 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#641888} build/android/stacktrace/crashpad_stackwalker.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) commit 8a9128021a38ad5b3a08d63ea01a0818c4fa9f53 Author: Jan Krcal <jkrcal@chromium.org> Date: Tue Mar 19 15:13:31 2019 +0000 [AF Profile Sync] Commit changes to WebDB on remote update This CL adds the missing commit call to the autofill_profile sync bridge. The open transaction is normally closed on shutdown but it does not get closed on Android when the process gets killed. This situation was never dealt with in any of the autofill sync code. This CL is thus part of a series of CLs fixing this in all autofill data types (started by CL 1526262). Bug: 942435 Change-Id: Ie95edaaa815897767a4ed0216cc6fdbe1d7d2448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524349 Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#641887} .../webdata/autofill_profile_sync_bridge.cc | 14 ++++++- .../autofill_profile_sync_bridge_unittest.cc | 47 ++++++++++++++++++++++ 2 files changed, 59 insertions(+), 2 deletions(-) commit a8ddfde5071f182c11adcbe1060a93b3332c92e7 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Tue Mar 19 15:13:26 2019 +0000 OnionSoup: Apply testharness.js for tests in animations/prefixed. This CL removes js-test.js and dumpAsText and applies testharness.js for test files which don't use 'animation-test-helpers.js' in animations/prefixed. The rest of the tests using 'animation-test-helpers.js' from animations/prefixed will be followed up with updating 'animation-test-helpers.js'. Bug: 936364 Change-Id: If9f21478608632b96b920c4842f8df12635688ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525789 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#641886} .../animation-events-prefixed-01-expected.txt | 2 - .../prefixed/animation-events-prefixed-01.html | 107 ++++++++--------- .../animation-events-prefixed-02-expected.txt | 2 - .../prefixed/animation-events-prefixed-02.html | 130 +++++++++------------ .../animation-events-prefixed-03-expected.txt | 2 - .../prefixed/animation-events-prefixed-03.html | 118 +++++++++---------- .../animation-events-prefixed-04-expected.txt | 4 - .../prefixed/animation-events-prefixed-04.html | 67 +++++------ .../animation-events-unprefixed-01-expected.txt | 2 - .../prefixed/animation-events-unprefixed-01.html | 117 +++++++++---------- .../animation-events-unprefixed-02-expected.txt | 2 - .../prefixed/animation-events-unprefixed-02.html | 103 ++++++++-------- .../animation-events-unprefixed-03-expected.txt | 2 - .../prefixed/animation-events-unprefixed-03.html | 111 +++++++++--------- .../animation-events-unprefixed-04-expected.txt | 4 - .../prefixed/animation-events-unprefixed-04.html | 67 +++++------ ...imation-inherit-initial-unprefixed-expected.txt | 38 ------ .../animation-inherit-initial-unprefixed.html | 85 +++++++------- .../animation-shorthand-prefixed-expected.txt | 71 ----------- .../prefixed/animation-shorthand-prefixed.html | 106 ++++++++--------- .../animation-shorthand-unprefixed-expected.txt | 71 ----------- .../prefixed/animation-shorthand-unprefixed.html | 100 ++++++++-------- .../keyframes-cssom-prefixed-02-expected.txt | 24 ---- .../prefixed/keyframes-cssom-prefixed-02.html | 103 ++++++++-------- .../keyframes-cssom-unprefixed-02-expected.txt | 24 ---- .../prefixed/keyframes-cssom-unprefixed-02.html | 102 ++++++++-------- 26 files changed, 611 insertions(+), 953 deletions(-) commit 72e0589e416e143aef0a54ae633615978f363ff3 Author: Nico Weber <thakis@chromium.org> Date: Tue Mar 19 15:12:25 2019 +0000 Roll clang 355581:356356. Ran `tools/clang/scripts/upload_revision.py 356356`. Bug: 941969 Change-Id: I8623b8bc6754e9907d66788f53d203b3bce0485d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528472 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641885} tools/clang/scripts/update.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4d9f108d023235690124fd3081cac4cf91b1268b Author: David Roger <droger@chromium.org> Date: Tue Mar 19 15:12:20 2019 +0000 [signin] Remove support for REAUTH response in X-Chrome-Connected headers This header is no longer sent by Gaia. Change-Id: I4b3c9a293ca6be1061785f112e77da8e435103d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1514712 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#641884} chrome/browser/profiles/profile_metrics.cc | 10 ---------- .../signin/core/browser/chrome_connected_header_helper.cc | 2 -- components/signin/core/browser/signin_header_helper.h | 1 - .../signin/core/browser/signin_header_helper_unittest.cc | 9 +++++---- components/signin/ios/browser/account_consistency_service.mm | 1 - tools/metrics/histograms/histograms.xml | 6 +++++- 6 files changed, 10 insertions(+), 19 deletions(-) commit d998539fbd8b8beacd48432335e683f73d0603ed Author: Jared Saul <jsaul@google.com> Date: Tue Mar 19 15:11:17 2019 +0000 [Autofill] Split autofill_payments_features from autofill_features Also adds jsaul@ as OWNERS for autofill_payments_features.* Bug: 940042 Change-Id: I0f850e3b80c77c30418b97dc66381e6885883af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519495 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#641883} chrome/browser/about_flags.cc | 1 + .../chrome_browsing_data_remover_delegate.cc | 1 + chrome/browser/ui/autofill/autofill_ui_util.cc | 2 +- .../local_card_migration_bubble_controller_impl.cc | 1 + .../local_card_migration_dialog_controller_impl.cc | 1 + .../autofill/save_card_bubble_controller_impl.cc | 1 + ...save_card_bubble_controller_impl_browsertest.cc | 1 + .../save_card_bubble_controller_impl_unittest.cc | 1 + .../autofill/local_card_migration_browsertest.cc | 1 + .../autofill/save_card_bubble_views_browsertest.cc | 1 + .../views/autofill/save_card_offer_bubble_views.cc | 1 + chrome/browser/ui/views/frame/browser_view.cc | 2 +- .../ui/views/location_bar/location_bar_view.cc | 2 +- chrome/browser/ui/views/toolbar/toolbar_view.cc | 2 +- .../md_settings_localized_strings_provider.cc | 1 + .../autofill/core/browser/autofill_experiments.cc | 1 + .../core/browser/autofill_experiments_unittest.cc | 1 + .../core/browser/autofill_external_delegate.cc | 2 +- .../browser/autofill_external_delegate_unittest.cc | 1 + .../autofill/core/browser/autofill_manager.cc | 1 + .../core/browser/autofill_manager_unittest.cc | 1 + .../autofill/core/browser/form_data_importer.cc | 1 + .../core/browser/form_data_importer_unittest.cc | 1 + .../browser/payments/credit_card_save_manager.cc | 1 + .../payments/credit_card_save_manager_unittest.cc | 1 + .../payments/local_card_migration_manager.cc | 1 + .../local_card_migration_manager_unittest.cc | 1 + .../core/browser/payments/payments_client.cc | 1 + .../browser/payments/payments_client_unittest.cc | 1 + .../core/browser/payments/payments_util.cc | 1 + .../browser/payments/payments_util_unittest.cc | 1 + .../payments/test_local_card_migration_manager.cc | 2 +- components/autofill/core/common/BUILD.gn | 2 + components/autofill/core/common/OWNERS | 2 + .../autofill/core/common/autofill_features.cc | 158 ------------------ .../autofill/core/common/autofill_features.h | 69 -------- .../core/common/autofill_payments_features.cc | 180 +++++++++++++++++++++ .../core/common/autofill_payments_features.h | 90 +++++++++++ ios/chrome/browser/about_flags.mm | 1 + .../browsing_data/browsing_data_remover_impl.mm | 2 +- .../ui/autofill/save_card_infobar_egtest.mm | 2 +- 41 files changed, 309 insertions(+), 235 deletions(-) commit 1e398f477abfa89b15c523ad7de23a0cd0247aed Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Tue Mar 19 15:11:13 2019 +0000 Remove TracedValue::Create() in platform/instrumentation As advised in [1], this CL removes unnecessary TracedValue::Create() in //third_party/blink/renderer/platform/instrumentation and make it's constructor public, then make the callers use std::make_unique<TracedValue> instead of it's Create() factory function. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic5cb95378384c0d0eea65d12e4607587438543cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529978 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#641882} .../core/css/invalidation/invalidation_set.cc | 2 +- .../core/css/resolver/style_resolver_stats.cc | 2 +- .../blink/renderer/core/frame/local_frame_view.cc | 2 +- .../core/inspector/inspector_trace_events.cc | 92 +++++++++++----------- .../blink/renderer/core/layout/jank_tracker.cc | 2 +- .../blink/renderer/core/layout/layout_analyzer.cc | 2 +- .../renderer/core/layout/traced_layout_object.cc | 2 +- .../renderer/core/loader/document_load_timing.cc | 2 +- .../blink/renderer/core/loader/frame_loader.cc | 2 +- .../core/paint/image_paint_timing_detector.cc | 4 +- .../core/paint/text_paint_timing_detector.cc | 2 +- .../core/script/html_parser_script_runner.cc | 2 +- .../renderer/core/timing/performance_timing.cc | 2 +- .../cache_storage/cache_storage_trace_utils.cc | 18 ++--- .../websockets/inspector_websocket_events.cc | 4 +- .../platform/bindings/runtime_call_stats.cc | 2 +- .../instrumentation/tracing/traced_value.cc | 4 - .../instrumentation/tracing/traced_value.h | 5 +- .../instrumentation/tracing/traced_value_test.cc | 8 +- .../platform/loader/fetch/resource_fetcher.cc | 6 +- .../platform/loader/fetch/resource_loader.cc | 2 +- .../platform/probe/platform_trace_events_agent.cc | 2 +- 22 files changed, 81 insertions(+), 88 deletions(-) commit e8907061ff222d8350522c80c0757f95aaf0a262 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Tue Mar 19 15:10:13 2019 +0000 Replace CHECK by DumpWithoutCrashing in NavigationRequest. The root cause of https://crbug.com/936962 hasn't been found yet. It fails because of a 'CHECK'. This CL replaces it by a DumpWithoutCrashing. The goal is to avoid bothering M74 beta users with browser crashes. Of course, a solution to this bug must be found in the meantime. This is intented to be merged into M74. Bug: 936962 Change-Id: Ie47971aeaaf730f17a3060bc440338be0eebe412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528231 Reviewed-by: Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#641881} content/browser/frame_host/navigation_request.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) commit b525fba9124253dedf24842c1fd42650425ae91e Author: Alexander Hendrich <hendrich@chromium.org> Date: Tue Mar 19 15:10:09 2019 +0000 Revert "Reland "[blink] Remove old script streamer thread"" This reverts commit 9d9114047e6e54a39cfac51c6e2f39877227bb50. Reason for revert: Test is still flaky, see bug comment #149 Original change's description: > Reland "[blink] Remove old script streamer thread" > > This is a reland of 96c748b0b0e61d207ef1d3bd70238b3443179b77 > > Robustified the flaky test by using TestingPlatformSupportWithMockScheduler > to run the scheduler until exhaustion (fun fact, seems that the live version > of the script streaming wasn't being tested by this unit test :/ ) > > Original change's description: > > [blink] Remove old script streamer thread > > > > The script streamer thread has now been replaced with posting tasks to > > the scheduler, so remove the flag picking between the two options and > > the dedicated streaming thread itself. > > > > Also, remove the streaming task re-posting now that the blocking/ > > non-blocking worker pools are merged. > > > > Bug: 874080 > > Change-Id: Ib9dabb91deddcc616d4edfe5efb13d8e584c0691 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503420 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Reviewed-by: Steven Holte <holte@chromium.org> > > Reviewed-by: Kentaro Hara <haraken@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638031} > > TBR=mlippautz@chromium.org,holte@chromium.org,haraken@chromium.org,kinuko@chromium.org > > Bug: 874080 > Change-Id: I5be59d64fc2d6074094ce57cf884bcd0bdffd3ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507874 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638553} TBR=kinuko@chromium.org,haraken@chromium.org,holte@chromium.org,mlippautz@chromium.org,altimin@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874080 Change-Id: I62004a728ba1a85602aa83afe219b7265739d29d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529069 Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641880} content/child/runtime_features.cc | 3 + content/public/common/content_features.cc | 4 + content/public/common/content_features.h | 1 + testing/variations/fieldtrial_testing_config.json | 19 +++++ .../blink/public/platform/web_runtime_features.h | 1 + .../blink/public/platform/web_thread_type.h | 2 +- third_party/blink/renderer/bindings/bindings.gni | 2 + .../renderer/bindings/core/v8/script_streamer.cc | 88 ++++++++++++++++++--- .../renderer/bindings/core/v8/script_streamer.h | 9 ++- .../bindings/core/v8/script_streamer_test.cc | 18 +++-- .../bindings/core/v8/script_streamer_thread.cc | 90 ++++++++++++++++++++++ .../bindings/core/v8/script_streamer_thread.h | 60 +++++++++++++++ .../blink/renderer/core/core_initializer.cc | 2 + .../platform/exported/web_runtime_features.cc | 4 + .../platform/runtime_enabled_features.json5 | 3 + .../platform/scheduler/common/metrics_helper.cc | 1 + .../blink/renderer/platform/web_thread_type.cc | 2 + tools/metrics/histograms/enums.xml | 2 +- 18 files changed, 292 insertions(+), 19 deletions(-) commit 6151b8e5307b1a753b7955b7f16b80ae7854fe45 Author: Scott Violet <sky@chromium.org> Date: Tue Mar 19 15:09:05 2019 +0000 chromeos: gets mirroring in overview mode working with hidden windows Specifically for the single-process-mash case. In overview mode it's possible for many of the windows to be hidden. In this mode we still want to see the content, so kMirrorWindowList was added. kMirrorWindowList basically forces WebContentsViewAura to treat the content as visible, even though the window isn't actually visible. This won't work in mash because WebContentsViewAura and ash will eventually be in separate processes. This patch provides an alternative to kMirrorWindowList that will eventually replace kMirrorWindowList. In particular, two things are necessary to get the same functionality: 1. The remote client has to think the window is visible, otherwise the compositor in the remote client won't generate any frames. To enable this the window-service gets functionality such that ash can force the client to think the window is visible regardless of local state. I experimented with making the windows in ash visible, but this has a much worse set of problems. 2. Occlusion tracker gets the ability to have a window forced visible. This way the remote client thinks its windows are not occluded, which is important for the WebContentViewAura. I am not removing kMirrorWindowList in this patch as I hope to merge this. BUG=936674 TEST=covered by tests Change-Id: I7d853dd31fd5f23292b45b09164e75aea196ee24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512664 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#641879} ash/wm/non_client_frame_controller.h | 4 + ash/wm/window_mirror_view.cc | 43 ++++++++ ash/wm/window_mirror_view.h | 25 ++++- ash/wm/window_mirror_view_unittest.cc | 57 ++++++++++ services/ws/client_root.cc | 40 +++++-- services/ws/client_root.h | 21 +++- services/ws/client_root_test_helper.cc | 4 + services/ws/client_root_test_helper.h | 2 + services/ws/client_root_unittest.cc | 35 +++++- services/ws/proxy_window.h | 3 + services/ws/top_level_proxy_window.h | 27 +++++ services/ws/top_level_proxy_window_impl.cc | 17 +++ services/ws/top_level_proxy_window_impl.h | 9 ++ services/ws/window_tree.cc | 8 +- ui/aura/env.cc | 12 ++- ui/aura/env_observer.h | 9 +- ui/aura/window_occlusion_tracker.cc | 156 ++++++++++++++++++++------- ui/aura/window_occlusion_tracker.h | 72 ++++++++++--- ui/aura/window_occlusion_tracker_unittest.cc | 100 ++++++++++++++++- 19 files changed, 570 insertions(+), 74 deletions(-) commit 8340fb7cfb2cd8d423f2c290f6997a7a62c7e23a Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:09:02 2019 +0000 Roll src/third_party/chromite f9f298eb11ce..cbcd56c13ecf (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/f9f298eb11ce..cbcd56c13ecf git log f9f298eb11ce..cbcd56c13ecf --date=short --no-merges --format='%ad %ae %s' 2019-03-18 cjmcdonald@chromium.org chromeos_config: Set Samus Chrome PFQ to CHROME_PFQ_TYPE Created with: gclient setdep -r src/third_party/chromite@cbcd56c13ecf The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ifec6baa3b8f28e06803cacc93c57f0999a8e5664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529455 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641878} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 778a8a7ef7e3a1800f5e85cd44077fcc3b274a16 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:08:00 2019 +0000 Roll src/third_party/pdfium bcb9892d16d3..3d3dcdff38a6 (8 commits) https://pdfium.googlesource.com/pdfium.git/+log/bcb9892d16d3..3d3dcdff38a6 git log bcb9892d16d3..3d3dcdff38a6 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 thestig@chromium.org Simplify a call in CXFA_ImageRenderer::Start(). 2019-03-18 thestig@chromium.org Encapsulate CPDF_FontEncoding. 2019-03-18 tsepez@chromium.org Use span<>/size_t in GetNumTrailingLimit(). 2019-03-18 tsepez@chromium.org Get rid of some needless pointer arithmetic in GenerateFileID(). 2019-03-18 tsepez@chromium.org Use lengths from span where possible rather than from string. 2019-03-18 tsepez@chromium.org Fix OOB CHECK() in CFGAS_StringFormatter::FormatNum() 2019-03-18 thestig@chromium.org Write out the font encoding in CPDF_PageContentGenerator::ProcessText(). 2019-03-18 tsepez@chromium.org Check for zero-length strings in CXFA_NodeHelper::CreateNode(). Created with: gclient setdep -r src/third_party/pdfium@3d3dcdff38a6 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:942449,chromium:932401 TBR=dsinclair@chromium.org Change-Id: I9cc4903108932d3212140a4898b20a9bbbe9d079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529155 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641877} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 28868ed9bab7b26b8bd3530e00ead5effdff7178 Author: Brandon Jones <bajones@chromium.org> Date: Tue Mar 19 15:07:57 2019 +0000 Add inverse() method to XRRigidTransform Bug: 939613 Change-Id: If84f53a0a96e471b8270f740c568190a03647e57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1515647 Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#641876} .../renderer/modules/xr/xr_rigid_transform.cc | 4 + .../blink/renderer/modules/xr/xr_rigid_transform.h | 1 + .../renderer/modules/xr/xr_rigid_transform.idl | 2 + .../wpt/webxr/idlharness.https.window-expected.txt | 4 +- .../wpt/webxr/xrRigidTransform_inverse.https.html | 108 +++++++++++++++++++++ .../global-interface-listing-expected.txt | 1 + 6 files changed, 118 insertions(+), 2 deletions(-) commit d3eb6c03d445b503d4219097c35ac48611de8aac Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Tue Mar 19 15:06:53 2019 +0000 flags: assign enable-network-logging-to-file Bug: None Change-Id: Idf8e405513e91c4bed3b3c640c7f8a0890332635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529255 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#641875} chrome/browser/flag-metadata.json | 6 ++++-- chrome/browser/flag-never-expire-list.json | 1 + 2 files changed, 5 insertions(+), 2 deletions(-) commit 8cc859f00ffeab9d4ca0d819c32c4e1c7a978556 Author: Nikita Podguzov <nikitapodguzov@chromium.org> Date: Tue Mar 19 15:06:32 2019 +0000 Print Preview: Add PIN value setting in Print Preview page logic. This change doesn't involve any user visible interface changes. Bug: 848942 Change-Id: I795b5a42f506e410f20af970bbf96cf490e4d4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1477254 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#641874} .../browser/resources/print_preview/new/model.js | 26 +++++++++++++++------- .../print_preview/new/settings_behavior.js | 1 + .../model_settings_availability_test.js | 20 +++++++++++++++++ 3 files changed, 39 insertions(+), 8 deletions(-) commit ec0d93d4acf77587a0284d5213a100ba3fb7e629 Author: Theresa <twellington@chromium.org> Date: Tue Mar 19 15:05:37 2019 +0000 Disable InterestFeedContentSuggestions for testing A number of bots are frequently timing out when trying to start up Chrome on the NTP. It appears that the Feed loading spinner is showing which might be the cause (activity never enters idle). Disable InterestFeedContentSuggestions in fieldtrial_testing_config.json to see if that greens up the bots. We have a number of tests that explicitly enable InterestFeedContentSuggestions so we will still have test coverage. BUG=942625 Change-Id: Iac4ab77e766d886da7706528b18cfee5b621376b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529738 Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#641873} testing/variations/fieldtrial_testing_config.json | 6 ++++++ 1 file changed, 6 insertions(+) commit 363d5ef64599940fdf87a4f1cc0775590c427c8d Author: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Date: Tue Mar 19 15:05:28 2019 +0000 Telemetry: step 1 of removing redundant metrics There are some code in renderingMetric for computing metrics that are available as an UMA metric, too. Now that we can use UMA histograms in Telemetry (crbug.com/927067), there is no need to have two implementations for those metrics (one in the chromium repo and one in the catapult repo), that can potentially get out of sync. So, 1. This CL adds Event.Latency.ScrollUpdate.Touch.TimeToScrollUpdateSwapBegin4 and Event.Latency.ScrollBegin.Touch.TimeToScrollUpdateSwapBegin4 to benchmarks that use renderingMetric. 2. Next, we will change perf dashboard alert configurations to use the above-mentioned UMA metrics instead of input_event_latency and first_gesture_scroll_update_latency. 3. We will delete the catapult code for computing input_event_latency and first_gesture_scroll_update_latency (crrev.com/c/1526202). To see that the UMA versions and the Catapult versions have very similar values you can check the rendering.{desktop, mobile} benchmarks that have had both versions for a while now. E.g: https://v2spa-dot-chromeperf.appspot.com/#session=95f926ce50a834326541dfee68bcc5b0ec04fbf12a1b9b77794ece90a63a20bb BUG=943559 Change-Id: Ia47ac69e97748cc17eebb648336b2d54733f2ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526165 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Ravi Mistry <rmistry@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#641872} tools/perf/benchmarks/smoothness.py | 5 ++++- tools/perf/contrib/cluster_telemetry/rendering_ct.py | 5 ++++- tools/perf/contrib/cluster_telemetry/repaint.py | 5 ++++- tools/perf/contrib/cros_benchmarks/ui_smoothness_bench.py | 5 ++++- tools/perf/contrib/vr_benchmarks/vr_benchmarks.py | 5 ++++- 5 files changed, 20 insertions(+), 5 deletions(-) commit 2d03b5b49af582ba9eb639653651be451974e1d4 Author: Carlos Caballero <carlscab@google.com> Date: Tue Mar 19 15:04:30 2019 +0000 Reduce scope of lock in TaskQueueImpl We can safely reduce the scope of the lock given that task_poster_->ShutdownAndWaitForZeroOperations() will make sure that there will be no more post task calls. This also addresses a CHECK fail that would happen if the unregister would trigger a ScheduleWork, as we would hold the any_thread_lock_ in TaskQueueImpl during the ScheduleWork call. Bug: 943009 Change-Id: I633676ead5f81d41f5a1c7defc31bb507c53f377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529093 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Alexander Timin <altimin@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#641871} .../sequence_manager_impl_unittest.cc | 20 ++++++++++++++++++++ base/task/sequence_manager/task_queue_impl.cc | 20 +++++++++----------- 2 files changed, 29 insertions(+), 11 deletions(-) commit 4197d3af6e42aa72076d6051153a644f3df62dd5 Author: Raul Tambre <raul@tambre.ee> Date: Tue Mar 19 15:04:20 2019 +0000 Improve Python 3 support in build scripts The changes are to allow build files to be generated using Python 3 on Windows. The scripts still work with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I52c912c624660c7a46c05f8f36871744abd7b8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521487 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#641870} build/compute_build_timestamp.py | 4 ++- build/download_nacl_toolchains.py | 12 ++++--- build/get_landmines.py | 59 ++++++++++++++++++--------------- build/gn_helpers.py | 9 +++-- build/toolchain/get_concurrent_links.py | 6 ++-- build/toolchain/get_cpu_count.py | 4 ++- build/toolchain/win/setup_toolchain.py | 26 ++++++++------- build/util/lastchange.py | 8 +++-- build/util/version.gni | 2 +- build/util/version.py | 22 +++++++----- build/vs_toolchain.py | 20 +++++------ build/win/use_ansi_codes.py | 4 ++- build/win_is_xtree_patched.py | 4 ++- 13 files changed, 105 insertions(+), 75 deletions(-) commit 511937931ee51499fee5e66cbadea209b0daaa94 Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 19 15:03:24 2019 +0000 Change unsigned long to uint32_t in third_party/blink/public/platform/web_content_decryption_module_result.h - unsigned long -> uint32_t - no logic change - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: I5877bf2e5bb51dcf63cfa12cd7818a642d6d20de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529976 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641869} .../blink/public/platform/web_content_decryption_module_result.h | 2 +- .../modules/encryptedmedia/content_decryption_module_result_promise.cc | 2 +- .../modules/encryptedmedia/content_decryption_module_result_promise.h | 2 +- .../modules/encryptedmedia/html_media_element_encrypted_media.cc | 2 +- third_party/blink/renderer/modules/encryptedmedia/media_keys.cc | 2 +- third_party/blink/renderer/platform/content_decryption_module_result.h | 2 +- .../renderer/platform/exported/web_content_decryption_module_result.cc | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) commit 97c010ca6e9b15bc2faa59b7d9787b383e6ba7f4 Author: Tim Volodine <timvolodine@chromium.org> Date: Tue Mar 19 15:03:15 2019 +0000 [AW NS] Rename directory to network_service/ and move network service related files there Rename android_webview/browser/net_network_service/ directory to android_webview/browser/network_service/. Move network service (NS) related files to their own location in android_webview/browser/network_service/, together with the other NS related files. This provides a clearer code separation/ownership and simplifies non-NS code cleanup later. BUG=940950,841556 Cq-Include-Trybots: luci.chromium.try:android_mojo Change-Id: I94c3e981f9c558e2c7ec61213d2751e6316276a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1517908 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#641868} android_webview/BUILD.gn | 20 ++++++++++---------- android_webview/browser/aw_content_browser_client.cc | 8 ++++---- android_webview/browser/cookie_manager.cc | 2 +- .../browser/net/aw_url_request_context_getter.cc | 2 +- .../{net_network_service => network_service}/OWNERS | 0 .../android_stream_reader_url_loader.cc | 2 +- .../android_stream_reader_url_loader.h | 6 +++--- .../android_stream_reader_url_loader_unittest.cc | 2 +- .../aw_cookie_manager_wrapper.cc | 2 +- .../aw_cookie_manager_wrapper.h | 6 +++--- .../aw_proxying_url_loader_factory.cc | 7 +++---- .../aw_proxying_url_loader_factory.h | 6 +++--- .../{ => network_service}/aw_url_loader_throttle.cc | 2 +- .../{ => network_service}/aw_url_loader_throttle.h | 6 +++--- .../browser/{ => network_service}/net_helpers.cc | 2 +- .../browser/{ => network_service}/net_helpers.h | 6 +++--- .../aw_resource_dispatcher_host_delegate.cc | 2 +- android_webview/test/BUILD.gn | 2 +- 18 files changed, 41 insertions(+), 42 deletions(-) commit 3b6a0ae7cf7906a447d2df79a475c6d9ae49c92f Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 19 15:02:17 2019 +0000 Change unsigned long to size_t in third_party/blink/public/platform/fonts/ - unsigned long -> size_t to - no logic change - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: I49b697f69df8406d86c0be2b7a69dddb58991698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530218 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641867} third_party/blink/renderer/platform/fonts/script_run_iterator_test.cc | 2 +- third_party/blink/renderer/platform/fonts/shaping/run_segmenter_test.cc | 2 +- third_party/blink/renderer/platform/fonts/small_caps_iterator_test.cc | 2 +- third_party/blink/renderer/platform/fonts/symbols_iterator_test.cc | 2 +- third_party/blink/renderer/platform/fonts/vdmx_parser.cc | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) commit 10a47b715e40a58511f59e5d22753d0501ec2226 Author: Clemens Hammacher <clemensh@chromium.org> Date: Tue Mar 19 15:02:10 2019 +0000 Move failing wasm wpt tests to own bug R=ahaas@chromium.org Bug: chromium:943487 Change-Id: I6b945477d21f4b7c2ebe163c3b283924c320100d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529060 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#641866} third_party/blink/web_tests/TestExpectations | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) commit eb151697bfcffc015b8151a1f63ee9e5168db73c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 15:01:11 2019 +0000 Roll src/native_client 1ed9878b8eb6..7d24fb15d81f (1 commits) https://chromium.googlesource.com/native_client/src/native_client.git/+log/1ed9878b8eb6..7d24fb15d81f git log 1ed9878b8eb6..7d24fb15d81f --date=short --no-merges --format='%ad %ae %s' 2019-03-18 yliuyliu@google.com Change Android SDK path to third_party/android_sdk/public Created with: gclient setdep -r src/native_client@7d24fb15d81f The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:659808 TBR=mseaborn@chromium.org Change-Id: I71412cb4696b2f68ad4a76791bf4eb086b1b6974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529469 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641865} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 53bf4eade06a201cc26bf076bc9d582a1878517b Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Mar 19 15:01:03 2019 +0000 [iOS] Manage sync needs to be disabled when sync is disabled Adding a property for manage sync item. The item is updated when the sync state changes (the item is disabled when needed). Screenshots: Enabled: https://drive.google.com/open?id=1-aJgxJsRWoLoKUq1y6oTMiKV8NsrIZCl Disabled: https://drive.google.com/open?id=19ui2hOQ2wjIJ8LG6XIRPdDLqPSMhVA8A Bug: 941757 Change-Id: Iec3edd776eb1cd31a4df7cde4759097229095c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529098 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641864} .../google_services_settings_mediator.mm | 41 ++++++++++++++++------ 1 file changed, 30 insertions(+), 11 deletions(-) commit 259e889be2fdc85139675a69694ea9c8e7a74951 Author: Paul Jensen <pauljensen@chromium.org> Date: Tue Mar 19 15:00:06 2019 +0000 [Cronet] include junit in cronet_tests_java.jar Tests rely on this, so we need to include it in the test jar. Change-Id: I815e3c48e9a6b338cbcbfe2e4d9e3a7dc7cf33d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529256 Commit-Queue: Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Auto-Submit: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#641863} components/cronet/android/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 46418668743dd8ed4d28e1f3a1afecc93d1e4466 Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Tue Mar 19 14:59:58 2019 +0000 Roll src-internal b97f27935ca1..6abdbc905c14 (41 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b97f27935ca1..6abdbc905c14 Created with: gclient setdep -r src-internal@6abdbc905c14 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:942176,chromium:942176,chromium:891734,chromium:942704 TBR=ksakamoto@chromium.org,mmentovai@chromium.org,carlosk@chromium.org,hendrich@chromium.org Change-Id: I335f6637c838515d3aeaac0cd14300ef96a26cad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529323 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641862} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 113d907a298030fd23afe07dd16086f1bfb1b4a5 Author: Rakina Zata Amni <rakina@chromium.org> Date: Tue Mar 19 14:59:00 2019 +0000 Make <select multiple> element not skipped for find-in-page We skip <select> elements, but mistakenly also skip <select multiple> that previously works with find-in-page. Bug: 943195 Change-Id: I65a6ccbef03907ef20b1c98949a4c0a2f2f033e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529892 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641861} third_party/blink/renderer/core/editing/finder/find_buffer.cc | 8 +++++--- .../blink/renderer/core/editing/finder/find_buffer_test.cc | 11 +++++++++++ 2 files changed, 16 insertions(+), 3 deletions(-) commit a8a1edd3c11faca1a5660e8da10d3abbca595d0f Author: dstockwell <dstockwell@google.com> Date: Tue Mar 19 14:58:51 2019 +0000 pdf: Temporary workaround for races using the Ink API The Ink engine can drop our requested changes when the canvas is being initialized or re-initialized when rotated in low-latency mode. Waiting for the next task is sufficient for the host to win the race. Working with the Ink team to make changes to remove the need for deferring these commands. Bug: 939230 Change-Id: I2b4c89f502e6df22f412838049670ad412ff1c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525247 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#641860} .../resources/pdf/elements/viewer-ink-host/viewer-ink-host.js | 6 +++--- chrome/browser/resources/pdf/ink/ink_api.js | 7 ++++++- 2 files changed, 9 insertions(+), 4 deletions(-) commit a2ccf50834677be4f1782d1425afcbbae15d908c Author: Miyoung Shin <myid.shin@igalia.com> Date: Tue Mar 19 14:57:53 2019 +0000 Change unsigned long/unsigned to uint32_t in third_party/blink/public/platform/web_database_observer.h - unsigned long/unsigned -> uint32_t to make a consistency with WebIDL's unsigned long - Reference: https://google.github.io/styleguide/cppguide.html#Integer_Types Bug: 930252 Change-Id: I861a11d201115ce3ae48f9584510b1ffd9fd506a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529893 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641859} content/renderer/web_database_observer_impl.cc | 2 +- content/renderer/web_database_observer_impl.h | 2 +- third_party/blink/public/platform/web_database_observer.h | 2 +- third_party/blink/renderer/modules/webdatabase/database.cc | 4 ++-- third_party/blink/renderer/modules/webdatabase/database.h | 6 +++--- third_party/blink/renderer/modules/webdatabase/database_manager.cc | 4 ++-- third_party/blink/renderer/modules/webdatabase/database_manager.h | 4 ++-- .../blink/renderer/modules/webdatabase/dom_window_web_database.cc | 4 ++-- .../blink/renderer/modules/webdatabase/dom_window_web_database.h | 4 ++-- 9 files changed, 16 insertions(+), 16 deletions(-) commit 20db80c4fa87aa46d590454fe230d3677ec6856a Author: Meng-Huan Yu <menghuan@chromium.org> Date: Tue Mar 19 14:57:44 2019 +0000 chromeos: Add UMA for cryptohomed to measure incoming queue time In CL:1488516, we add UMA to measure inqueue time of the async dbus call at server side. BUG=920850, b:124719803 Change-Id: Iab50fe411302bbd73fc348e9798be59695b547d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488409 Commit-Queue: Meng-Huan Yu <menghuan@chromium.org> Auto-Submit: Meng-Huan Yu <menghuan@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#641858} tools/metrics/histograms/histograms.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) commit f64f8a047091bcf7f6d84be356522577c723b676 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Tue Mar 19 14:56:45 2019 +0000 Roll src/third_party/catapult d8c847c11680..93bbf937f838 (2 commits) https://chromium.googlesource.com/catapult.git/+log/d8c847c11680..93bbf937f838 git log d8c847c11680..93bbf937f838 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 dberris@chromium.org Use ijson for proper incremental parsing 2019-03-18 dberris@chromium.org Add ijson to third_party Created with: gclient setdep -r src/third_party/catapult@93bbf937f838 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:941888,chromium:942368,chromium:941888,chromium:942368 TBR=sullivan@chromium.org Change-Id: Ib68e6c5463b5c865fa48b9301268bd842885d933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529611 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641857} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 61bf28babca508a868e18ffe78f5fdbc9afde78f Author: Nick Diego Yamane <nickdiego@igalia.com> Date: Tue Mar 19 14:56:37 2019 +0000 Move CreatePipe function into //base/files/file_util.h Currently, basic pipe file descriptors creation function implementation is replicated in different parts of the code base (e.g: zygote/linux, components/exo, ozone/wayland, etc). This CL moves and unify them into //base/files/file_util.h, making it reusable throughout the code base thus reducing redundancy. Bug: 578890 Change-Id: I9ce62d8da8fcf39384f2b9b4df9deb657e457a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506712 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by: Daniele Castagna <dcastagna@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Maksim Sisov <msisov@igalia.com> Reviewed-by: Ricky Liang <jcliang@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#641856} base/files/file_util.h | 10 ++++++++++ base/files/file_util_posix.cc | 11 +++++++++++ components/arc/arc_session_impl.cc | 19 ++----------------- components/exo/data_offer_unittest.cc | 22 ++++++++-------------- components/exo/data_source.cc | 10 ++-------- .../video/chromeos/camera_hal_dispatcher_impl.cc | 19 ++----------------- services/service_manager/zygote/zygote_linux.cc | 9 +-------- ui/ozone/platform/wayland/test/test_data_source.cc | 9 +-------- ui/ozone/platform/wayland/wayland_data_offer.cc | 10 ++-------- 9 files changed, 39 insertions(+), 80 deletions(-) commit c2fb2e8ff77fddd651873b3c0088333706c7dc92 Author: John Budorick <jbudorick@chromium.org> Date: Tue Mar 19 14:53:15 2019 +0000 Drop win7-rel to a 10% CQ experiment. The bot was unable to recover overnight. Removing it from the CQ to allow it to do so & allow us to fix any remaining issues affecting its cycle time. Bug: 943372 Change-Id: I52bbfba7fc0d266ebd7dd364bd4b5eea84d8df18 Tbr: martiniss@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529619 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#641855} docs/infra/cq_builders.md | 6 ++++-- infra/config/commit-queue.cfg | 8 +++++--- 2 files changed, 9 insertions(+), 5 deletions(-) commit d45d88cf3d69928d8fe026bc88aa3d7a25853937 Author: Robert Sesek <rsesek@chromium.org> Date: Tue Mar 19 14:14:30 2019 +0000 Add a new LPM fuzzer for Mach message servers. This fuzzer tool allows modeling the complex Mach IPC structures, including the generation and transfer of port rights. It also adds a build rule to convert textproto to binarypb, so that the seed corpus for these fuzzers can be human-editable/readable. Adds a simple fuzzer for the MachPortRendezvousServer. Bug: 932175 Change-Id: I909e4a8bac802ea1d4d73d26fcb0834803324360 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526561 Reviewed-by: Mark Mentovai <mark@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641854} base/BUILD.gn | 36 +++++ base/mac/mach_port_rendezvous.h | 1 + base/mac/mach_port_rendezvous_fuzzer.cc | 51 ++++++ .../mach_port_rendezvous_fuzz/dead_name.textproto | 3 + .../data/mach_port_rendezvous_fuzz/send.textproto | 3 + testing/libfuzzer/fuzzers/mach/BUILD.gn | 24 +++ testing/libfuzzer/fuzzers/mach/mach_message.proto | 61 ++++++++ .../fuzzers/mach/mach_message_converter.cc | 171 +++++++++++++++++++++ .../fuzzers/mach/mach_message_converter.h | 62 ++++++++ third_party/protobuf/proto_library.gni | 70 +++++++++ tools/protoc_wrapper/protoc_convert.py | 30 ++++ 11 files changed, 512 insertions(+) commit e14c6808f487c5bd12962b437433597a7ef31ec5 Author: Takuto Ikuta <tikuta@chromium.org> Date: Tue Mar 19 14:13:16 2019 +0000 [buildtools] update .gitignore for CIPD Bug: 855791 Change-Id: Id4d8c98953d40635b8f1784ac5b147f932a2e42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530371 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#641853} buildtools/.gitignore | 3 +++ 1 file changed, 3 insertions(+) commit 88ab318d915dfd1c3ff01157f7093ef9745aa002 Author: Adam Langley <agl@chromium.org> Date: Tue Mar 19 14:01:02 2019 +0000 Add Settings UI for security keys. This change adds webui to drive PIN operations on security keys. (Specifically setting PINs, changing PINs, and resettting devices.) BUG=870892 Change-Id: I9c0e5e4f816728acc38f10660b301bd07abc49ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460413 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#641852} chrome/app/settings_strings.grdp | 89 +++++ .../resources/settings/privacy_page/BUILD.gn | 36 ++ .../settings/privacy_page/privacy_page.html | 20 + .../settings/privacy_page/privacy_page.js | 14 + .../privacy_page/security_keys_browser_proxy.html | 1 + .../privacy_page/security_keys_browser_proxy.js | 89 +++++ .../privacy_page/security_keys_reset_dialog.html | 60 +++ .../privacy_page/security_keys_reset_dialog.js | 122 ++++++ .../privacy_page/security_keys_set_pin_dialog.html | 108 +++++ .../privacy_page/security_keys_set_pin_dialog.js | 332 ++++++++++++++++ .../privacy_page/security_keys_subpage.html | 38 ++ .../settings/privacy_page/security_keys_subpage.js | 46 +++ chrome/browser/resources/settings/route.js | 4 + .../resources/settings/settings_resources.grd | 24 ++ .../md_settings_localized_strings_provider.cc | 46 +++ .../data/webui/settings/cr_settings_browsertest.js | 26 ++ .../webui/settings/security_keys_subpage_test.js | 436 +++++++++++++++++++++ 17 files changed, 1491 insertions(+) commit eb5bc901a3fc4f2d93d8d9f9c55511eef0963e50 Author: Stephen Martinis <martiniss@chromium.org> Date: Tue Mar 19 13:51:37 2019 +0000 Remove todos for CQ bots Bug: 888810 Change-Id: I26f179447488b464df3273b73c5b0d5933e321ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529735 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#641851} tools/mb/mb_config.pyl | 9 --------- 1 file changed, 9 deletions(-) commit 4ec376e1d196a46c50adb06ec801dfc3dfb525dd Author: Alexander Hendrich <hendrich@chromium.org> Date: Tue Mar 19 13:39:22 2019 +0000 Revert "Store the current SequenceManagerImpl instance in TLS" This reverts commit 426952a6d28d89caed29b48ef4455a79f1c0d964. Reason for revert: Causes builder Mac10.12 Tests to fail. See bug 943537 Original change's description: > Store the current SequenceManagerImpl instance in TLS > > Now that the backend for MessageLoop is always a SequenceManager it no > longer makes sense to have the TLS logic in MessageLoopCurrent. > > Eventually MessageLoopBase will disappear completely and > MessageLoopCurrent will use the API exposed by SequenceManager. This > patch is a step in that direction. > > Bug: 891670 > Change-Id: I24a76ded54fcf4b95bc8192ce0fe413aaeee162d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497074 > Commit-Queue: Carlos Caballero <carlscab@google.com> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641834} TBR=gab@chromium.org,skyostil@chromium.org,altimin@chromium.org,carlscab@google.com Change-Id: I64971722513c63385aea97d61b5c4ddba267faa7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891670, 943537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530841 Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641850} base/message_loop/message_loop_current.cc | 45 +++++++++++++++------- base/message_loop/message_loop_current.h | 17 +++++++- .../task/sequence_manager/sequence_manager_impl.cc | 33 +++------------- base/task/sequence_manager/sequence_manager_impl.h | 6 --- 4 files changed, 52 insertions(+), 49 deletions(-) commit 1c52e55fbce0bd6529752cf1e59a8cc27d1d3605 Author: Karolina Soltys <ksolt@chromium.org> Date: Tue Mar 19 13:36:46 2019 +0000 [scheduler] Migrating chrome/browser/ to PostTask.runOrPostTask. Bug: 863341 Change-Id: I593f394db9984021772191cc713928f662ed9987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1494886 Commit-Queue: Karolina Soltys <ksolt@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#641849} .../chrome/browser/feed/FeedRefreshTask.java | 6 ++- .../chrome/browser/ChromeBackgroundService.java | 58 +++++++++++----------- .../browser/SSLClientCertificateRequest.java | 6 ++- .../bookmarkswidget/BookmarkWidgetService.java | 34 +++++-------- .../browseractions/BrowserActionActivity.java | 19 +++---- .../BrowserActionsTabModelSelector.java | 3 +- .../browser/browserservices/OriginVerifier.java | 10 ++-- .../chrome/browser/customtabs/ClientManager.java | 6 ++- .../browser/customtabs/CustomTabActivity.java | 15 ++---- .../browser/customtabs/CustomTabsConnection.java | 3 +- .../browser/externalauth/ExternalAuthUtils.java | 5 +- .../browser/init/ProcessInitializationHandler.java | 9 ++-- .../browser/notifications/NotificationService.java | 11 ++-- .../chrome/browser/ntp/RecentTabsManager.java | 5 +- .../chrome/browser/omaha/OmahaService.java | 16 +++--- .../browser/photo_picker/DecoderServiceHost.java | 36 +++++++------- .../browser/services/AccountsChangedReceiver.java | 16 +++--- .../services/gcm/ChromeGcmListenerService.java | 23 ++++----- .../chrome/browser/signin/SyncPromoView.java | 5 +- .../chrome/browser/sync/SyncController.java | 9 ++-- .../browser/tabmodel/TabPersistentStore.java | 2 +- .../browser/upgrade/UpgradeIntentService.java | 38 +++++++------- 22 files changed, 155 insertions(+), 180 deletions(-) commit c1e047cc0064e97c719dcfc1c9c6717881e00716 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Tue Mar 19 13:25:29 2019 +0000 webrtc wpt: fix use of helper function BUG=none Change-Id: Idbf28db20f40284babed334852e164931ad33ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529271 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#641848} .../external/wpt/webrtc/RTCIceConnectionState-candidate-pair.https.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7f9746a495b28160932d1d3a1190a3d00603c254 Author: Leszek Swirski <leszeks@chromium.org> Date: Tue Mar 19 13:04:33 2019 +0000 [BlinkGenPropertyTrees] Re-add element id failure expectation The fixed-position-in-fixed-overflow.html web test can still occasionally fail, for example due to scheduling changes in https://crrev.com/c/1477260. This reverts part of commit 0353702a316445d8da0efd9db7a75c7534dd96c0. Bug: 913170 Change-Id: Id2ec607a4bdbbd3df4f35f202430416e839fb971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527540 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641847} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 71558ba1aeff065443b6663f8a2986dba41715d1 Author: 3su6n15k.default@developer.gserviceaccount.com <3su6n15k.default@developer.gserviceaccount.com> Date: Tue Mar 19 13:03:26 2019 +0000 Automated Commit: LKGM 11951.0.0 for chromeos. BUG=762641 TBR=jdufault@google.com Change-Id: Ie976b40b0ec1f4082beab05bca7937987cd84be2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529478 Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#641846} chromeos/CHROMEOS_LKGM | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 67ddc9156cd81ff54ea12de8b0c6443f489d7732 Author: Jordan Demeulenaere <jdemeulenaere@google.com> Date: Tue Mar 19 12:56:35 2019 +0000 [Autofill Assistant] Disable the carousels measurement cache. Before this CL, when a carousel was pushed outside of the view port and then brought back, it would not recompute its size and would be invisible. This CL invalidates the measurement cache of the carousels layout manager to work around that bug. After this CL, the carousel is correctly shown when brought back into the view port. Bug: 128679161 Change-Id: I01ee7ae8cd80ba64ecba4780bd55cc32d2a6e284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529277 Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Auto-Submit: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#641845} .../autofill_assistant/carousel/AssistantCarouselCoordinator.java | 4 ++++ 1 file changed, 4 insertions(+) commit 15834a16c1ab54a6fed49d10aedcced299bbfcd0 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Mar 19 12:46:33 2019 +0000 [iOS] Should close Manage sync settings when sync is disabbled Adding observer of the Manage sync settings to the sync service. If the sync is disabled by the enterprise policy, the Manage sync settings has to close itself. This can happens right after sign-in or right after starting the app. Bug: 937118 Change-Id: I4d8adac46472a3543969969283023146c8b559d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1508283 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641844} .../manage_sync_settings_coordinator.mm | 64 ++++++++++++---------- 1 file changed, 35 insertions(+), 29 deletions(-) commit 9ed84473c251388c7fa5d83bd8601cd24cbe3883 Author: Jérôme Lebel <jlebel@chromium.org> Date: Tue Mar 19 12:35:51 2019 +0000 [iOS] Fix to test for enterprise policy reason to disable sync ProfileSyncService::GetDisableReasons() returns a flag, so a binary mask should be used to test for the enterprise policy. Bug introduced with: crrev.com/c/1509412 crrev.com/c/1508262 Bug: 937118 Change-Id: I2b9a409d89ce67f249c3b4030658002cd5fd6516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529106 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#641843} .../ui/settings/google_services/google_services_settings_mediator.mm | 4 ++-- ios/chrome/browser/ui/settings/settings_table_view_controller.mm | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) commit 7d36fb03e01f024dc4daba822e953c79eb0dfa95 Author: Mathias Carlen <mcarlen@chromium.org> Date: Tue Mar 19 12:30:54 2019 +0000 [Autofill Assistant] Add ShowInfoBox to the set of actions. Before this path a ShowInfoBox was not added to the list of actions to execute. This patch adds the missing case statement to do that. We are discussing ways of finding these issues at compile time since the default case may not be strictly needed in this case. Bug: b/125291252 Change-Id: I573834c307c341bd3bec9524140bbddc2883df38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529278 Reviewed-by: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#641842} components/autofill_assistant/browser/protocol_utils.cc | 5 +++++ 1 file changed, 5 insertions(+) commit 3ca41ca8de5c55c38d0e0d67e984893d1c88e205 Author: Eric Seckler <eseckler@chromium.org> Date: Tue Mar 19 12:20:45 2019 +0000 Manually roll third_party/perfetto to 7b0c9453e8d3. Cloned from crrev.com/c/1528281. Also updates chromium consumers. Submitting with NOTRY=true since the only missing try bot is win7-rel, which was failing for other reasons and is now broken due to crbug.com/943411. Roll src/third_party/perfetto eff66d82dc0d..7b0c9453e8d3 (13 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/eff66d82dc0d..7b0c9453e8d3 git log eff66d82dc0d..7b0c9453e8d3 --date=short --no-merges --format='%ad %ae %s' 2019-03-18 eseckler@google.com service: Add support for ObservableEvents. 2019-03-18 rsavitski@google.com Merge "ParseTypedFtraceToRaw: skip invalid proto field ids when decoding args" 2019-03-18 eseckler@google.com Merge "service: Mark instances as stopped correctly on unregistering source." 2019-03-18 rsavitski@google.com Merge "heapprofd: remove Client.FreePage nesting, and try to make names more consistent" 2019-03-18 lalitm@google.com trace_processor: support span left join for mixed partitioned tables 2019-03-18 lalitm@google.com trace_processor: add support for left joins in no partition mode 2019-03-18 eseckler@google.com build: Only include traced service tests in android/standalone builds. 2019-03-16 primiano@google.com Merge "ftrace: add header_page and trace_marker fallbacks for user builds" 2019-03-15 fmayer@google.com Add lazy startup producer class to traced. 2019-03-15 primiano@google.com Merge "Fix android x86 build config" 2019-03-15 eseckler@google.com Merge "service/producer: Track data source instance state, notify on start" 2019-03-15 hjd@google.com Merge "traced_probes: Workaround atrace bug when stdin is closed" 2019-03-15 rsavitski@google.com Merge "Fix unwinding with NO_DEXFILE_SUPPORT." Created with: gclient setdep -r src/third_party/perfetto@7b0c9453e8d3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:127948038,chromium:126724929 TBR=perfetto-bugs@google.com NOTRY=true Change-Id: Ib43df3fc94004be27699d128fa2a131823a34810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528951 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#641841} DEPS | 2 +- services/tracing/perfetto/consumer_host.h | 1 + services/tracing/perfetto/perfetto_tracing_coordinator.cc | 2 ++ services/tracing/perfetto/test_utils.h | 1 + 4 files changed, 5 insertions(+), 1 deletion(-) commit 86a226e6eb899fdc0fdd68fa56c6ebcb4fd276db Author: Matthew Cary <mattcary@chromium.org> Date: Tue Mar 19 12:17:44 2019 +0000 Orderfile: split commit step to second run of orderfile generator. Bug: 908406 Change-Id: I8b9669452a747d32926727d95911fa9522bf7b70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524048 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#641840} tools/cygprofile/orderfile_generator_backend.py | 97 ++++++++++++++++++++++--- 1 file changed, 86 insertions(+), 11 deletions(-) commit 94aaefbb3e02a26c1953aaa046a6794f5208afe1 Author: Joel Hockey <joelhockey@chromium.org> Date: Tue Mar 19 11:37:45 2019 +0000 Try and debug flakes in ExtractMountNameFileSystemNameFullPath tests Bug: 942371 Change-Id: I8364196af047263086580c11e7db5188ac6915bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530317 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#641839} .../browser/chromeos/file_manager/path_util_unittest.cc | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) commit 44e2776d6a6e7babb9e6ea47ecb6bf762f88abb2 Author: Stephane Zermatten <szermatt@chromium.org> Date: Tue Mar 19 11:24:41 2019 +0000 [Autofill Assistant] Don't show UI after moving tabs when feature is off Before this change with tab-switching turned off if a script was running when the user chose "Open in Chrome" from CCT, the UI would move from CCT to a normal tab, even with the tab-switching feature turned off. What should instead have happened is AA shutting down. However, AA takes a while to shut down when a script is running, This patch prevents the UI from showing again on the new tab, after it's been taken out of CCT. It also forces prompt and PR actions to terminate immediately. Bug: b/128666286 Change-Id: Ie89f7062e480322b45132ff44ee3f8b1cdb1b9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524359 Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#641838} .../browser/actions/action_delegate.h | 7 ++++++- .../browser/actions/mock_action_delegate.h | 4 +++- .../browser/actions/prompt_action.cc | 14 ++++++++++++- .../browser/actions/prompt_action.h | 1 + .../browser/actions/prompt_action_unittest.cc | 22 ++++++++++++++++++-- .../autofill_assistant/browser/controller.cc | 24 +++++++++++++++++++++- components/autofill_assistant/browser/controller.h | 1 + .../browser/controller_unittest.cc | 5 +++++ .../browser/fake_script_executor_delegate.cc | 3 +++ .../browser/fake_script_executor_delegate.h | 1 + .../autofill_assistant/browser/script_executor.cc | 18 +++++++++++++++- .../autofill_assistant/browser/script_executor.h | 7 ++++++- .../browser/script_executor_delegate.h | 1 + 13 files changed, 100 insertions(+), 8 deletions(-) commit 1fd75367da0cb84cf8d6e96459e1d19d906386f1 Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Mar 19 11:13:54 2019 +0000 Reenable RL tests for slim-nav They should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1524264 and https://chromium-review.googlesource.com/c/chromium/src/+/1524263 Bug: 942025 Change-Id: Ibccdf59e103825ddcfb41751629b8017ea9b7fe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526183 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641837} ios/chrome/browser/ui/reading_list/reading_list_egtest.mm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 5b10fd3e6d773da3ad762ccf0bce54f7f892ef55 Author: Egor Pasko <pasko@chromium.org> Date: Tue Mar 19 10:47:17 2019 +0000 custom-tabs-client: Remove pasko from OWNERS Justification: as in http://crrev.com/c/1529410/ Change-Id: I00ce8b2e800484f05945cb483b90decc198fedbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529054 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#641836} third_party/custom_tabs_client/OWNERS | 1 - third_party/custom_tabs_client/README.chromium | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) commit 822824e79e9e736c6ce8abbc34ae60b5f56bb0eb Author: Huanzhong Huang <huanzhong@google.com> Date: Tue Mar 19 10:36:13 2019 +0000 [iOS] Change "Clear Browsing Data" button to a toolbar button - This change is behind the new-clear-browsing-data-ui flag. - Make the CBD button (in TableView) a toolbar button to conform to the new design. Bug: 935346 Change-Id: I25487b9f5f191f51cc2db020f45105997d7810ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520604 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#641835} .../clear_browsing_data_manager.h | 11 +++ .../clear_browsing_data_manager.mm | 97 ++++++++++++++++------ .../clear_browsing_data_table_view_controller.mm | 70 +++++++++++++--- 3 files changed, 142 insertions(+), 36 deletions(-) commit 426952a6d28d89caed29b48ef4455a79f1c0d964 Author: Carlos Caballero <carlscab@google.com> Date: Tue Mar 19 10:26:40 2019 +0000 Store the current SequenceManagerImpl instance in TLS Now that the backend for MessageLoop is always a SequenceManager it no longer makes sense to have the TLS logic in MessageLoopCurrent. Eventually MessageLoopBase will disappear completely and MessageLoopCurrent will use the API exposed by SequenceManager. This patch is a step in that direction. Bug: 891670 Change-Id: I24a76ded54fcf4b95bc8192ce0fe413aaeee162d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497074 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#641834} base/message_loop/message_loop_current.cc | 45 +++++++--------------- base/message_loop/message_loop_current.h | 17 +------- .../task/sequence_manager/sequence_manager_impl.cc | 33 +++++++++++++--- base/task/sequence_manager/sequence_manager_impl.h | 6 +++ 4 files changed, 49 insertions(+), 52 deletions(-) commit 8b117204c1db660563bf8da0531fcdc5c1f4dbe4 Author: Yi Su <mrsuyi@chromium.org> Date: Tue Mar 19 10:16:56 2019 +0000 Add feature flag kDisplaySearchEngineFavicon. Add the feature flag for displaying search engine favicons in Settings. Bug: 937057 Change-Id: I2f9ddbbea1adabe8eb6da33e8bce0a40bde34f04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529053 Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641833} ios/chrome/browser/about_flags.mm | 4 ++++ ios/chrome/browser/ios_chrome_flag_descriptions.cc | 5 +++++ ios/chrome/browser/ios_chrome_flag_descriptions.h | 5 +++++ ios/chrome/browser/ui/ui_feature_flags.cc | 3 +++ ios/chrome/browser/ui/ui_feature_flags.h | 3 +++ 5 files changed, 20 insertions(+) commit 9216669ee959343c9314f794d14cef91a959bf48 Author: Yi Su <mrsuyi@chromium.org> Date: Tue Mar 19 10:12:37 2019 +0000 Remove kCustomSearchEngines flag. The feature "Custom Search Engines" has been launched in M72, so the feature flag kCustomSearchEngines can be removed now. Bug: 433824 Change-Id: I213767cdc4a4e48b95f27da79385d8b0be45caee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528630 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#641832} ios/chrome/browser/BUILD.gn | 1 - ios/chrome/browser/about_flags.mm | 4 ---- ios/chrome/browser/ios_chrome_flag_descriptions.cc | 4 ---- ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 ---- ios/chrome/browser/search_engines/BUILD.gn | 12 ------------ ios/chrome/browser/search_engines/feature_flags.cc | 8 -------- ios/chrome/browser/search_engines/feature_flags.h | 13 ------------- ios/chrome/browser/tabs/BUILD.gn | 1 - ios/chrome/browser/tabs/tab_helper_util.mm | 3 --- 9 files changed, 50 deletions(-) commit 55059aa5918da8dc624e2d70e400b926cb9e500b Author: Robbie Gibson <rkgibson@google.com> Date: Tue Mar 19 10:09:38 2019 +0000 Remove contents text for clipboard image match The copywriters thought that this text wasn't actually necessary. Bug: 943071 Change-Id: Idbc182da6a2108a4ac18366a5a5187352d408973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527538 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#641831} components/omnibox/browser/clipboard_provider.cc | 6 ------ components/omnibox_strings.grdp | 3 --- 2 files changed, 9 deletions(-) commit 330d2c27dd092584bbca492b395eb081d98de63d Author: Bo Liu <boliu@chromium.org> Date: Tue Mar 19 09:24:14 2019 +0000 aw: Set enable/disable feature once Previous implementation appended a new --enable-feature or --disable-feature switch for every hard coded feature. Command line argv turned out to be append only, even though there is a remove switch method. Change to a scoped class and append each at most only one. Change-Id: Ic0243d69bf23038c17a31a76f32ff2a88505028c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526746 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#641830} android_webview/BUILD.gn | 4 +- android_webview/browser/command_line_helper.cc | 65 ---------- android_webview/browser/command_line_helper.h | 32 ----- .../browser/command_line_helper_unittest.cc | 134 --------------------- .../browser/scoped_add_feature_flags.cc | 50 ++++++++ android_webview/browser/scoped_add_feature_flags.h | 40 ++++++ android_webview/lib/aw_main_delegate.cc | 55 ++++----- android_webview/test/BUILD.gn | 1 - 8 files changed, 118 insertions(+), 263 deletions(-) commit 70b81ba6edfed39a940f780ac477a962c8cb5d07 Author: Alexander Hendrich <hendrich@chromium.org> Date: Tue Mar 19 09:07:20 2019 +0000 Revert "cros: Add Attestation enrollment browser test." This reverts commit 0cc0d519d44114a61fb9ee9231850f2588741d7b. Reason for revert: multiple browser tests failing on chromeos. Speculatively reverting this CL as possible culprit. See crbug.com/943473 Original change's description: > cros: Add Attestation enrollment browser test. > > cryptohome and CA network communication is mocked. > > Also fixes waiting for js ready in OOBE - it waits for assets > loading. > Also fixes certificate_based_register handling in > policy_testserver.py > > Bug: 934224, 912704 > Change-Id: Ic5816376e218436c6a2595759fa1bc9dd1b730ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523099 > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641822} TBR=rsorokin@chromium.org,jdufault@chromium.org,pmarko@chromium.org Change-Id: I79194e7f2492588057cdd29fad0f9057eb92a9e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934224, 912704, 943473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529100 Reviewed-by: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#641829} .../enrollment_local_policy_server_browsertest.cc | 34 ++++------------------ .../login/test/local_policy_test_server_mixin.cc | 4 --- .../policy/device_cloud_policy_initializer.cc | 5 ---- .../policy/device_cloud_policy_initializer.h | 2 -- chrome/browser/policy/test/policy_testserver.py | 14 ++------- chrome/browser/ui/webui/chromeos/login/oobe_ui.cc | 26 ++++------------- chrome/browser/ui/webui/chromeos/login/oobe_ui.h | 8 ----- .../core/common/cloud/cloud_policy_client.cc | 4 +-- 8 files changed, 15 insertions(+), 82 deletions(-) commit b43fcb8ffd3c6a8690f07afc316e29a83b634a85 Author: Gauthier Ambard <gambard@chromium.org> Date: Tue Mar 19 08:38:03 2019 +0000 [iOS][web] Group navigation methods in CRWWebController This CL groups the navigation and load methods in CRWWebController. Bug: 938255 Change-Id: Ib6110eb7aa93d40b8cfccd3a2ef16c9425602005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526182 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#641828} ios/web/web_state/ui/crw_web_controller.mm | 644 ++++++++++++++--------------- 1 file changed, 313 insertions(+), 331 deletions(-) commit 00408c5824726a2bdbef75f753e45f29dac1eed1 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue Mar 19 08:04:42 2019 +0000 Revert "Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient." This reverts commit d0310b0c0221e3f44da813443ca11c9869620cb4. Reason for revert: speculative revert to see if this fixes http://crbug.com/943459 Original change's description: > Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient. > > Bug: 942782 > Change-Id: Ia2971348153d54cd87a48e8045efc9d31948db8a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529354 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#641801} TBR=stevenjb@chromium.org,rmcelrath@chromium.org Change-Id: I50d5cd5459b33a8c5ee825db0de5e1db78eda457 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942782,943459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529502 Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#641827} chrome/browser/chromeos/network_change_manager_client.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit 37247cc91bffdc95e4ea208fea1c5c02b354a33c Author: Michael Lippautz <mlippautz@chromium.org> Date: Tue Mar 19 07:55:23 2019 +0000 unified-heap: Avoid stand-alone Blink idle GCs V8 has a mechanism for idle GCs that also triggers Blink collection with unified heap. There is no reason to schedule stand-alone Blink idle GCs based on fixed memory heuristics. Depending on workload this reduces GC pressure of ~10-25% on Blink which amounts to ~5-15% with unified heap. Local testing shows no significant regression in memory. Bug: 843903 Change-Id: I49ca889ae92ca3b45181fa9fe5468b9ffab5f67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1528671 Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#641826} third_party/blink/renderer/platform/heap/thread_state.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Updated tag 'tree_truth' (was c523e7408056)