Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 40254 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918521340502358928 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/ithRtU1K/luci_context.944956521 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2475-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43b0c17ec9ef9911 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: c656dcba79fca40aa5ea661643c89f061f7735a6 [BlinkGenPropertyTrees] Paint frame overlay in correct property tree state Xianzhu Wang, Tue Mar 19 21:23:13 2019 +0000 0c60ad5a536022b5c96a018747f9192dfbea19c6 tablet: Adjust what happens when you drag a snapped window from the top. Avery Musbach, Tue Mar 19 21:22:51 2019 +0000 e5690b8acc7016cd4ff0dddc2f5a75186f253b35 Remove null check for LayerTreeView from RenderFrameImpl danakj, Tue Mar 19 21:21:09 2019 +0000 c4865b233dea0080b4b6b51d0bd479493ac08ecb Reland "WS: CrashInFlightChange dump window name and location" Xiyuan Xia, Tue Mar 19 21:20:10 2019 +0000 97ad1ab351b61ac2e59b782ee57be1a0a7b51dd8 Add a NOTREACHED() in PrintRenderFrameHelper::UpdatePrintSettings(). Lei Zhang, Tue Mar 19 21:20:00 2019 +0000 6ab637ab801ea004ee0ac7912568008737b9261b [Autofill] Move Payments/Autofill classes in components/autofill/core/browser/ui into payments/ subfolder Jared Saul, Tue Mar 19 21:18:10 2019 +0000 6749305bec934f3f3ed5de45d2c542f139d90641 Reland 641728 (d8abfbe): Copy error over after glCopySubTexture Jonathan Backer, Tue Mar 19 21:17:02 2019 +0000 66f3cee814d489760f5fadd111d097ea251e729b [Fuchsia] Updated build instructions to handle .gclient syntax Sharon Yang, Tue Mar 19 21:16:52 2019 +0000 53476206d5ea2aff4250390b8bebd144bd1de385 Network Service: Move FinalizingMetricsLogRecord to NetworkMetricsProvider Jun Cai, Tue Mar 19 21:08:44 2019 +0000 93825368489a3d27bc9ffd05b3bfc245f84a6f57 [BlinkGenPropertyTrees] Stop setting three cc::Layer positioning values Philip Rogers, Tue Mar 19 21:06:21 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit c656dcba79fca40aa5ea661643c89f061f7735a6 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Mar 19 21:23:13 2019 +0000 [BlinkGenPropertyTrees] Paint frame overlay in correct property tree state Frame overlays should use the device emulation transform node if exists as the transform state. Because the node is ready only after PrePaint, we need to let frame overlays update graphics layer status at the end of PrePaint, instead of previously unclear (maybe during layout, or paint etc.) Bug: 934300 Change-Id: Ic6e2fe5d29f444dba1a3bf206ffa1775df4adc3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525199 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#642184} .../core/exported/web_dev_tools_agent_impl.cc | 4 +- .../core/exported/web_dev_tools_agent_impl.h | 2 +- .../blink/renderer/core/frame/frame_overlay.cc | 79 +++++++++------------ .../blink/renderer/core/frame/frame_overlay.h | 14 ++-- .../renderer/core/frame/frame_overlay_test.cc | 61 ++++++++++++++-- .../blink/renderer/core/frame/local_frame.cc | 23 ++---- .../blink/renderer/core/frame/local_frame.h | 2 +- .../blink/renderer/core/frame/local_frame_view.cc | 38 +++------- .../renderer/core/frame/web_local_frame_impl.cc | 4 +- .../renderer/core/frame/web_local_frame_impl.h | 2 +- .../core/inspector/inspector_overlay_agent.cc | 57 +++++++-------- .../core/inspector/inspector_overlay_agent.h | 6 +- .../renderer/core/page/validation_message_client.h | 2 +- .../core/page/validation_message_client_impl.cc | 12 ++-- .../core/page/validation_message_client_impl.h | 2 +- .../page/validation_message_overlay_delegate.cc | 43 +++++------ .../paint/compositing/paint_layer_compositor.cc | 19 ++--- .../core/paint/paint_property_tree_printer.cc | 1 + third_party/blink/renderer/core/testing/DEPS | 3 + .../blink/renderer/core/testing/internals.cc | 18 +++++ .../blink/renderer/core/testing/internals.h | 2 + .../blink/renderer/core/testing/internals.idl | 3 + .../enable-blink-features=CompositeAfterPaint | 1 + .../validation-bubble-appearance-edge-expected.txt | 1 - .../forms/validation-bubble-appearance-edge.html | 7 -- .../forms/validation-bubble-appearance-escape.html | 12 +--- ...alidation-bubble-appearance-iframe-expected.txt | 1 - .../forms/validation-bubble-appearance-iframe.html | 8 --- ...alidation-bubble-appearance-rtl-ui-expected.txt | 1 - .../forms/validation-bubble-appearance-rtl-ui.html | 7 -- .../validation-bubble-device-emulation-change.html | 24 +++++++ .../forms/validation-bubble-device-emulation.html | 10 +++ ...alidation-bubble-appearance-escape-expected.png | Bin 0 -> 5906 bytes ...ion-bubble-device-emulation-change-expected.png | Bin 0 -> 22065 bytes ...validation-bubble-device-emulation-expected.png | Bin 0 -> 22065 bytes ...alidation-bubble-appearance-escape-expected.png | Bin 0 -> 5906 bytes ...ion-bubble-device-emulation-change-expected.png | Bin 0 -> 22065 bytes ...validation-bubble-device-emulation-expected.png | Bin 0 -> 22065 bytes ...alidation-bubble-appearance-escape-expected.png | Bin 0 -> 4647 bytes ...ion-bubble-device-emulation-change-expected.png | Bin 0 -> 9621 bytes ...validation-bubble-device-emulation-expected.png | Bin 0 -> 9621 bytes ...alidation-bubble-appearance-escape-expected.png | Bin 0 -> 4649 bytes ...ion-bubble-device-emulation-change-expected.png | Bin 0 -> 9631 bytes ...validation-bubble-device-emulation-expected.png | Bin 0 -> 9631 bytes ...alidation-bubble-appearance-escape-expected.png | Bin 0 -> 4432 bytes ...ion-bubble-device-emulation-change-expected.png | Bin 0 -> 9048 bytes ...validation-bubble-device-emulation-expected.png | Bin 0 -> 9048 bytes 47 files changed, 240 insertions(+), 229 deletions(-) commit 0c60ad5a536022b5c96a018747f9192dfbea19c6 Author: Avery Musbach <amusbach@chromium.org> Date: Tue Mar 19 21:22:51 2019 +0000 tablet: Adjust what happens when you drag a snapped window from the top. BEFORE: 1. In split view, when you drag a window from the top, it will snap to one side or the other, unless you fling toward the opposite side or you drag onto the drop target. 2. In split view, the preview area never appears while you drag a window from the top. AFTER: 1. In split view, consistent with when split view is not active, you can drag a window from the top and drop it into overview. 2. The preview area behavior (including animations) in split view is consistent between when you drag a window from the top and when you drag a window from overview. The drop target (which only appears when you drag a window from the top, as Issue 940710 has not yet been addressed) is not shown when the preview area is shown; this behavior is consistent with when split view is not active. Test: ash_unittests SplitView*Test.* Bug: 878294 Bug: 940708 Change-Id: I5294982155b169e385b80f526c2abbabea4712ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518414 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#642183} ash/wm/overview/overview_grid.cc | 73 ++++++----- ash/wm/splitview/split_view_controller_unittest.cc | 140 ++++++++++++++------- .../tablet_mode_browser_window_drag_delegate.cc | 45 +++---- .../tablet_mode_window_drag_delegate.cc | 73 +++-------- ash/wm/workspace/workspace_window_resizer.cc | 8 +- 5 files changed, 171 insertions(+), 168 deletions(-) commit e5690b8acc7016cd4ff0dddc2f5a75186f253b35 Author: danakj <danakj@chromium.org> Date: Tue Mar 19 21:21:09 2019 +0000 Remove null check for LayerTreeView from RenderFrameImpl The LayerTreeView would be null only if the RenderWidget was closed. That shouldn't be the case while there is a RenderFrame using it (bug 939262)! But if there is let's hear about it. R=dcheng@chromium.org Bug: 939262 Change-Id: I7c234d853451d7b005c369327bb3c82fc1e4d65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531001 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#642182} content/renderer/render_frame_impl.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) commit c4865b233dea0080b4b6b51d0bd479493ac08ecb Author: Xiyuan Xia <xiyuan@chromium.org> Date: Tue Mar 19 21:20:10 2019 +0000 Reland "WS: CrashInFlightChange dump window name and location" This is a reland of fca3ec75eaa93b7d613618a6006f95168ee920f8 Original change's description: > WS: CrashInFlightChange dump window name and location > > Dump window name and CrashInFlightChange creation site with > the fatal log. > > Bug: 940620 > Change-Id: I4645986a47a1c495b3279bc2fa07d24487ccda89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529691 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642114} Bug: 940620 Change-Id: I78a6b307497eddc93facd917001dccb5664d0b46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531171 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#642181} ui/aura/mus/in_flight_change.cc | 21 +++++++++---- ui/aura/mus/in_flight_change.h | 7 ++++- ui/aura/mus/window_tree_client.cc | 47 ++++++++++++++++++------------ ui/aura/mus/window_tree_client_unittest.cc | 29 ++++++++++++++++++ 4 files changed, 78 insertions(+), 26 deletions(-) commit 97ad1ab351b61ac2e59b782ee57be1a0a7b51dd8 Author: Lei Zhang <thestig@chromium.org> Date: Tue Mar 19 21:20:00 2019 +0000 Add a NOTREACHED() in PrintRenderFrameHelper::UpdatePrintSettings(). The renderer should never receive an empty settings dictionary. Mark the code path that handles this as NOTREACHED(), as an intermediate step towards removing the code path entirely. Also move some variable declaration closer to where they are used. Change-Id: Iba26732d214b611d84222923a981bb8f29f0efb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529634 Reviewed-by: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#642180} .../printing/renderer/print_render_frame_helper.cc | 15 ++++++++++----- .../test/print_render_frame_helper_browsertest.cc | 16 ---------------- 2 files changed, 10 insertions(+), 21 deletions(-) commit 6ab637ab801ea004ee0ac7912568008737b9261b Author: Jared Saul <jsaul@google.com> Date: Tue Mar 19 21:18:10 2019 +0000 [Autofill] Move Payments/Autofill classes in components/autofill/core/browser/ui into payments/ subfolder Additionally gives OWNERS of these files to jsaul@. Bug: 940042 Change-Id: Iea98d179bd18d6b6b554f3fdefc950b08254a141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525488 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#642179} .../card_expiration_date_fix_flow_view_android.cc | 2 +- .../autofill/card_name_fix_flow_view_android.cc | 2 +- .../autofill/card_unmask_prompt_view_android.cc | 2 +- .../autofill/card_unmask_prompt_view_android.h | 2 +- .../card_unmask_prompt_view_browsertest.cc | 4 +- .../browser/ui/autofill/chrome_autofill_client.cc | 6 +-- .../browser/ui/autofill/chrome_autofill_client.h | 4 +- .../local_card_migration_bubble_controller_impl.h | 2 +- .../local_card_migration_dialog_controller_impl.h | 2 +- .../ui/autofill/save_card_bubble_controller_impl.h | 2 +- .../ui/views/autofill/card_unmask_prompt_views.cc | 2 +- .../ui/views/autofill/card_unmask_prompt_views.h | 2 +- .../autofill/local_card_migration_bubble_views.cc | 2 +- .../autofill/local_card_migration_bubble_views.h | 2 +- .../autofill/local_card_migration_dialog_view.h | 2 +- .../local_card_migration_error_dialog_view.h | 2 +- .../ui/views/autofill/save_card_bubble_views.cc | 2 +- .../ui/views/autofill/save_card_bubble_views.h | 2 +- .../views/autofill/save_card_offer_bubble_views.cc | 2 +- components/autofill/core/browser/BUILD.gn | 24 +++++------ .../autofill/core/browser/ui/{ => payments}/DEPS | 0 .../autofill/core/browser/ui/payments/OWNERS | 1 + ...xpiration_date_fix_flow_view_delegate_mobile.cc | 2 +- ...expiration_date_fix_flow_view_delegate_mobile.h | 6 +-- .../card_name_fix_flow_view_delegate_mobile.cc | 2 +- .../card_name_fix_flow_view_delegate_mobile.h | 7 ++- .../{ => payments}/card_unmask_prompt_controller.h | 6 +-- .../card_unmask_prompt_controller_impl.cc | 14 +++--- .../card_unmask_prompt_controller_impl.h | 13 +++--- .../card_unmask_prompt_controller_impl_unittest.cc | 50 +++++++++------------- .../ui/{ => payments}/card_unmask_prompt_view.h | 6 +-- .../local_card_migration_bubble_controller.h | 6 +-- .../local_card_migration_dialog_controller.h | 6 +-- .../{ => payments}/save_card_bubble_controller.h | 6 +-- .../ui/autofill/card_unmask_prompt_view_bridge.h | 2 +- .../ui/autofill/card_unmask_prompt_view_bridge.mm | 2 +- .../ui/autofill/chrome_autofill_client_ios.h | 2 +- .../ui/autofill/chrome_autofill_client_ios.mm | 2 +- .../browser/ui/payments/full_card_requester.h | 2 +- .../internal/autofill/cwv_credit_card_verifier.mm | 4 +- 40 files changed, 100 insertions(+), 109 deletions(-) commit 6749305bec934f3f3ed5de45d2c542f139d90641 Author: Jonathan Backer <backer@chromium.org> Date: Tue Mar 19 21:17:02 2019 +0000 Reland 641728 (d8abfbe): Copy error over after glCopySubTexture ANGLE does the validation if passthrough is enabled, so copy over the error state to expose to client. Bug: 942658 Change-Id: Ie559357f8ffa4b922b8b312ca4602939aade5c9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531015 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642178} gpu/command_buffer/service/raster_decoder.cc | 1 + 1 file changed, 1 insertion(+) commit 66f3cee814d489760f5fadd111d097ea251e729b Author: Sharon Yang <yangsharon@chromium.org> Date: Tue Mar 19 21:16:52 2019 +0000 [Fuchsia] Updated build instructions to handle .gclient syntax Added details explicitly stating that syntax in .gclient files should not have trailing commas or commas between top level statements. Change-Id: Ic6b6041f674a9963e5860af8dbf2f8ffc0cc1564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525195 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#642177} docs/fuchsia_build_instructions.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) commit 53476206d5ea2aff4250390b8bebd144bd1de385 Author: Jun Cai <juncai@chromium.org> Date: Tue Mar 19 21:08:44 2019 +0000 Network Service: Move FinalizingMetricsLogRecord to NetworkMetricsProvider This CL cleans up FinalizingMetricsLogRecord() and moves it to NetworkMetricsProvider. Bug: 883557 Change-Id: I8eaad1c3993179da5120d154e68c5682e10f424f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1437954 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#642176} components/metrics/net/network_metrics_provider.cc | 47 +++++++++++++++++++++- components/metrics/net/network_metrics_provider.h | 5 +++ net/android/network_change_notifier_android.cc | 15 ------- net/android/network_change_notifier_android.h | 3 -- net/base/network_change_notifier.cc | 29 ------------- net/base/network_change_notifier.h | 13 ------ 6 files changed, 51 insertions(+), 61 deletions(-) Updated tag 'tree_truth' (was 93825368489a)