Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 36520 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918358125383086672 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itBa7DXC/luci_context.844647271 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2420-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43ba08964d244011 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 7944ca17fb6416e7df83a5de8ec75559c79ca8cc DevTools: Network - Request response doesn't render contents with no mimeType Mike Jackson, Thu Mar 21 17:03:42 2019 +0000 30207c4a9a76ce6d601dee8a25e25b83f95dd8fb Do not add placeholder if page is already loaded. Mike Dougherty, Thu Mar 21 17:02:47 2019 +0000 c3d2cb19e51c797e9c043ab43ecf073ef36649b2 [scheduler] Migrating some more browser tests to TestThreadUtils. Karolina Soltys, Thu Mar 21 17:01:58 2019 +0000 873568ce3d22d103de73ddbe0439effc58babe14 Implement ITextProvider::RangeFromChild Alison Maher, Thu Mar 21 17:01:00 2019 +0000 f7ff3f3af444c48b23dd6867b745c59731f352ed Delete TreeView::CreateParentIfNecessary and add TreeView::CreateScrollViewWithTree(). Allen Bauer, Thu Mar 21 16:59:52 2019 +0000 cbc56e99e31f303e87ac5ef9122ea3e6c798da37 Rename cups_add_printer_dialog_util to cups_printer_dialog_util Jimmy Gong, Thu Mar 21 16:57:36 2019 +0000 0a2c5737033a1cb6c4572bbd3223b82b046adb89 Make the ModuleDatabase fully sequence-affine Patrick Monette, Thu Mar 21 16:57:31 2019 +0000 19431fe6d7a82a96e15008421946f4fbeddeb005 Fix misplaced text for discovering printers Jimmy Gong, Thu Mar 21 16:54:18 2019 +0000 e10b0f92ad15466af1a49eb80120fb91272bf3c9 [Autofill] Added focused field type as a formatter data member. Caitlin Fischer, Thu Mar 21 16:53:46 2019 +0000 c01ac7a9d2ae1943d966f0cdaea20124e9242eba Put GamepadHand enum behind the related flag David Dorwin, Thu Mar 21 16:50:22 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 7944ca17fb6416e7df83a5de8ec75559c79ca8cc Author: Mike Jackson <mjackson@microsoft.com> Date: Thu Mar 21 17:03:42 2019 +0000 DevTools: Network - Request response doesn't render contents with no mimeType If a network request is blocked or cancelled, the mimeType field remains 'undefined' because the 'responseReceived' event is never raised. If a user then clicks on this blocked/cancelled network request in the network tool, any attempt to view the Response will result in a white window, instead of 'Failed to load response data'. This occurs because the RequestResponseView assumes that a mimeType is present, and consequently throws a JS exception: Cannot read property 'startsWith' of undefined shell.js:720:43 Function.fromMimeType network_module.js:785:114 Function._hasTextContent network_module.js:792:97 Function.sourceViewForRequest network_module.js:798:91 async Network.RequestResponseView.createPreview network_module.js:797:40 async Network.RequestResponseView.showPreview The fix here is to update _hasTextContent, so that the call into fromMimeType always has a valid string. I've also updated the JSDoc comment to indicate that a string is required and not nullable. Change-Id: Ib6e89ef6f7cc45387cb25a7c10e01432f8855199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533052 Auto-Submit: Mike Jackson <mjackson@microsoft.com> Reviewed-by: Joel Einbinder <einbinder@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#642980} .../devtools/front_end/common/ResourceType.js | 2 +- .../front_end/network/RequestResponseView.js | 2 +- .../failed-request-response-mimetype-expected.txt | 8 +++++ .../network/failed-request-response-mimetype.js | 38 ++++++++++++++++++++++ 4 files changed, 48 insertions(+), 2 deletions(-) commit 30207c4a9a76ce6d601dee8a25e25b83f95dd8fb Author: Mike Dougherty <michaeldo@chromium.org> Date: Thu Mar 21 17:02:47 2019 +0000 Do not add placeholder if page is already loaded. Bug: 943038 Change-Id: I61cc89ad0539b5285f081d156da459ca93395f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532726 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642979} .../browser/web/page_placeholder_tab_helper.h | 3 +++ .../browser/web/page_placeholder_tab_helper.mm | 30 ++++++++++++---------- 2 files changed, 20 insertions(+), 13 deletions(-) commit c3d2cb19e51c797e9c043ab43ecf073ef36649b2 Author: Karolina Soltys <ksolt@chromium.org> Date: Thu Mar 21 17:01:58 2019 +0000 [scheduler] Migrating some more browser tests to TestThreadUtils. Another mass-migration; roughly half of browser test files. Bug: 863341 Change-Id: I9d7748367643ad80def56f0f61937ac2f841e7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532561 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#642978} .../chrome/browser/ActivityTabProviderTest.java | 18 +-- .../chrome/browser/BluetoothChooserDialogTest.java | 40 +++--- .../chrome/browser/ChromeActivityTest.java | 22 ++- .../chrome/browser/ChromeHttpAuthHandlerTest.java | 8 +- .../chromium/chrome/browser/CopylessPasteTest.java | 6 +- .../chrome/browser/ItemChooserDialogTest.java | 56 ++++---- .../chrome/browser/JavaScriptEvalChromeTest.java | 6 +- .../org/chromium/chrome/browser/NavigateTest.java | 10 +- .../browser/NavigationBarColorControllerTest.java | 6 +- .../chrome/browser/NavigationPopupTest.java | 21 +-- .../chromium/chrome/browser/OSKOverscrollTest.java | 4 +- .../chrome/browser/PowerBroadcastReceiverTest.java | 6 +- .../org/chromium/chrome/browser/PrerenderTest.java | 4 +- .../chromium/chrome/browser/SafeBrowsingTest.java | 4 +- .../chrome/browser/SelectFileDialogTest.java | 8 +- .../browser/ServicificationBackgroundService.java | 33 ++--- .../chromium/chrome/browser/ShareIntentTest.java | 9 +- .../chrome/browser/SmartClipProviderTest.java | 8 +- .../chrome/browser/SubresourceFilterTest.java | 33 ++--- .../chromium/chrome/browser/TabObserverTest.java | 6 +- .../src/org/chromium/chrome/browser/TabTest.java | 15 +- .../org/chromium/chrome/browser/TabThemeTest.java | 7 +- .../browser/TabsOpenedFromExternalAppTest.java | 31 ++-- .../src/org/chromium/chrome/browser/TabsTest.java | 45 +++--- .../org/chromium/chrome/browser/UrlSchemeTest.java | 4 +- .../chrome/browser/UsbChooserDialogTest.java | 6 +- .../chromium/chrome/browser/WarmupManagerTest.java | 9 +- .../browser/accessibility/FontSizePrefsTest.java | 22 +-- .../ManualFillingIntegrationTest.java | 3 +- .../browser/bookmarks/BookmarkBridgeTest.java | 24 ++-- .../browser/bookmarks/BookmarkModelTest.java | 33 ++--- .../BookmarkPersonalizedSigninPromoTest.java | 6 +- .../chrome/browser/bookmarks/BookmarkTest.java | 82 +++++------ .../browseractions/BrowserActionActivityTest.java | 93 +++++------- .../browserservices/OriginVerifierTest.java | 21 ++- .../browserservices/TrustedWebActivityTest.java | 6 +- .../BrowsingDataRemoverIntegrationTest.java | 49 +++---- .../compositor/layouts/LayoutManagerTest.java | 17 +-- .../compositor/overlays/strip/TabStripTest.java | 47 +++--- .../contacts_picker/ContactsPickerDialogTest.java | 11 +- .../browser/contextmenu/ContextMenuTest.java | 6 +- .../contextmenu/TabularContextMenuUiTest.java | 19 +-- .../EnabledStateMonitorTest.java | 12 +- .../ContextualSearchManagerTest.java | 115 +++++---------- .../ContextualSearchTapEventTest.java | 83 ++++------- .../crash/PureJavaExceptionReporterTest.java | 4 +- .../chrome/browser/crypto/CipherFactoryTest.java | 14 +- .../display_cutout/DisplayCutoutTestRule.java | 9 +- .../dom_distiller/DistilledPagePrefsTest.java | 34 ++--- .../browser/download/DownloadActivityTest.java | 12 +- .../ExploreSitesBridgeExperimentalTest.java | 26 ++-- .../explore_sites/ExploreSitesPageTest.java | 5 +- .../browser/externalnav/UrlOverridingTest.java | 4 +- .../feature_engagement/ScreenshotMonitorTest.java | 12 +- .../ScreenshotTabObserverTest.java | 12 +- .../browser/feedback/ConnectivityCheckerTest.java | 18 +-- .../browser/feedback/ConnectivityTaskTest.java | 44 +++--- .../browser/fullscreen/FullscreenManagerTest.java | 41 +++--- .../fullscreen/FullscreenManagerTestUtils.java | 9 +- .../hardware_acceleration/ToastHWATest.java | 16 +-- .../browser/hardware_acceleration/Utils.java | 29 ++-- .../browser/history/HistoryActivityTest.java | 160 ++++++--------------- .../chrome/browser/history/HistoryAdapterTest.java | 16 +-- .../IncognitoNotificationServiceTest.java | 34 ++--- .../incognito/IncognitoTabLauncherTest.java | 4 +- .../browser/infobar/InfoBarAppearanceTest.java | 22 +-- .../browser/infobar/InfoBarContainerTest.java | 21 ++- .../chrome/browser/infobar/InfoBarTest.java | 120 +++++++--------- .../infobar/PermissionUpdateInfobarTest.java | 24 ++-- .../chrome/browser/init/ChainedTasksTest.java | 20 +-- .../browser/init/ChromeBrowserInitializerTest.java | 12 +- .../input/SelectPopupOtherContentViewTest.java | 25 ++-- .../instantapps/InstantAppsHandlerTest.java | 49 +++---- .../jsdialog/JavascriptAppModalDialogTest.java | 8 +- .../jsdialog/JavascriptTabModalDialogTest.java | 10 +- .../DefaultSearchEngineDialogHelperUtils.java | 29 ++-- .../locale/DefaultSearchEnginePromoDialogTest.java | 53 +++---- .../browser/locale/LocaleManagerReferralTest.java | 64 ++++----- .../chrome/browser/locale/LocaleManagerTest.java | 26 ++-- .../media/ui/PictureInPictureControllerTest.java | 5 +- .../MainIntentBehaviorMetricsIntegrationTest.java | 49 ++----- .../browser/metrics/PageLoadMetricsTest.java | 14 +- .../browser/metrics/StartupLoadingMetricsTest.java | 6 +- .../chromium/chrome/browser/metrics/UkmTest.java | 42 +++--- .../browser/modaldialog/ModalDialogTestUtils.java | 10 +- .../browser/modaldialog/ModalDialogViewTest.java | 32 +++-- .../multiwindow/MultiWindowIntegrationTest.java | 29 ++-- .../browser/multiwindow/MultiWindowTestHelper.java | 21 ++- .../NotificationPlatformBridgeTest.java | 21 +-- .../notifications/NotificationTestRule.java | 15 +- .../channels/SiteChannelsManagerTest.java | 5 +- .../browser/omaha/UpdateMenuItemHelperTest.java | 4 +- .../browser/page_info/ConnectionInfoPopupTest.java | 12 +- .../browser/page_info/PageInfoControllerTest.java | 6 +- .../PasswordGenerationDialogTest.java | 9 +- .../browser/permissions/PermissionTestRule.java | 12 +- .../photo_picker/PhotoPickerDialogTest.java | 11 +- .../browser/policy/CombinedPolicyProviderTest.java | 15 +- .../prerender/ExternalPrerenderHandlerTest.java | 25 ++-- .../browser/printing/PrintingControllerTest.java | 18 +-- .../chrome/browser/provider/ProviderTestRule.java | 13 +- .../browser/push_messaging/PushMessagingTest.java | 51 +++---- .../search_engines/TemplateUrlServiceTest.java | 78 +++++----- .../TemplateUrlServiceTestUtils.java | 4 +- .../browser/searchwidget/SearchActivityTest.java | 22 +-- .../searchwidget/SearchWidgetProviderTest.java | 122 ++++++---------- .../SendTabToSelfShareActivityTest.java | 31 ++-- .../shape_detection/ShapeDetectionTest.java | 17 +-- .../ShareMenuActionHandlerIntegrationTest.java | 4 +- .../browser/share/ShareMenuActionHandlerTest.java | 5 +- .../signin/OAuth2TokenServiceIntegrationTest.java | 40 +++--- .../chromium/chrome/browser/signin/SigninTest.java | 16 ++- .../snackbar/undo/UndoBarControllerTest.java | 24 ++-- .../browser/toolbar/LocationBarModelTest.java | 6 +- .../chrome/browser/toolbar/ToolbarTest.java | 18 +-- .../chrome/browser/toolbar/top/BrandColorTest.java | 41 +++--- .../chrome/browser/util/FeatureUtilitiesTest.java | 17 +-- .../browser/webapps/WebappSplashScreenTest.java | 15 +- .../webapps/WebappSplashScreenThemeColorTest.java | 3 +- 119 files changed, 1201 insertions(+), 1747 deletions(-) Updated tag 'tree_truth' (was 873568ce3d22)