Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 37467 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918355698189077840 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itaus6pF/luci_context.471913336 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2480-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43ba2be950db9411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: a4a3803370f84ecf8e1f1b3ad9b760acd7715884 Updating the "Add address" page colors Sinan Sahin, Thu Mar 21 17:42:38 2019 +0000 520b0ae7823ceb4bdec52a3de747b52e03964948 [Mac] Initial implementation of immersive fullscreen. Sidney San Martín, Thu Mar 21 17:42:24 2019 +0000 3558536963b742d80967cc7180214bfa170a894e Remove old previously fixed TODOs. Mike Dougherty, Thu Mar 21 17:36:54 2019 +0000 14149a9470318c6d6ca68a00f82bcfc618dbae59 Print Preview: Refactor settings behavior and print preview model rbpotter, Thu Mar 21 17:35:50 2019 +0000 fa2eff839b55dd0816baa35ba8955dada5f9bf03 [Media Notification] Tweak layout Becca Hughes, Thu Mar 21 17:35:04 2019 +0000 246f73d978ddacde64dcbdc68d7e32aca3701f4e [Autofill Assistant] Fix issue with highlighted area staying at the wrong y offset after a fling. Stephane Zermatten, Thu Mar 21 17:34:45 2019 +0000 02aeec31042ec042f48263e0649ef0a56270214b Add deprecation warning message about remove_webcore_debug_symbols James Cook, Thu Mar 21 17:31:35 2019 +0000 de82ee6feba2309056fd20122131b0f571fd9836 tablet: Carry over snapped windows from desktop to tablet for all users. Avery Musbach, Thu Mar 21 17:30:03 2019 +0000 32fed5d1d470900fa3f83d931aaf6baec68a769f Roll src/third_party/SPIRV-Tools/src 1f60f9896468..2d52cbee4901 (1 commits) chromium-autoroll, Thu Mar 21 17:27:50 2019 +0000 f79fa955593d822c5c4e82e4dd21d27df59b24eb Assign remaining content-suggestion flags Natalie Chouinard, Thu Mar 21 17:27:46 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit a4a3803370f84ecf8e1f1b3ad9b760acd7715884 Author: Sinan Sahin <sinansahin@google.com> Date: Thu Mar 21 17:42:38 2019 +0000 Updating the "Add address" page colors Bug: 934591 Change-Id: Ibb61a257f163f66159044a0f0a33ca0b037bd753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533223 Reviewed-by: Becky Zhou <huayinz@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#643001} chrome/android/java/res/layout/payments_request_editor_textview.xml | 4 +++- chrome/android/java/res/values/colors.xml | 4 ---- chrome/android/java/res_night/values-night/colors.xml | 2 -- .../org/chromium/chrome/browser/widget/prefeditor/EditorDialog.java | 6 +++--- ui/android/java/res/values-v17/styles.xml | 6 ++++++ ui/android/java/res/values/colors.xml | 5 +++++ ui/android/java/res_night/values-night/colors.xml | 4 ++++ 7 files changed, 21 insertions(+), 10 deletions(-) commit 520b0ae7823ceb4bdec52a3de747b52e03964948 Author: Sidney San Martín <sdy@chromium.org> Date: Thu Mar 21 17:42:24 2019 +0000 [Mac] Initial implementation of immersive fullscreen. This change lets the toolbar hide and show automatically in fullscreen by adding a Mac implementation of ImmersiveModeController. It's temporarily guarded by a flag because some things need to be finished before this launches: - Support the toolbar always being visible. - Don't hide the toolbar when a bubble or other child window opens. Other things would be nice to have but may not block launch: - Animation. - Native toolbar support (or another approach that hides the title bar.) The changes in -[RenderWidgetHostViewCocoa shouldIgnoreMouseEvent:] cause it to ignore mouse events which don't hit test to the view's own subtree, and to clear the cursor when ignoring a mouse event. (tracking areas don't call |hitTest:|; they produce events in their bounds regardless of hit testing/overlapping views.) This way, when the mouse cursor is over the ImmersiveToolbarOverlayView, which overlaps the RenderWidgetHostViewCocoa, it won't change the cursor, set tooltips, or send events to its renderer. Includes pair programming with lgrey@chromium.org. Bug: 868398 Change-Id: Ia88544a1c8cd4743e4e84a6582765df9c8390c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1427799 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#643000} chrome/browser/about_flags.cc | 4 + chrome/browser/flag-metadata.json | 5 + chrome/browser/flag_descriptions.cc | 4 + chrome/browser/flag_descriptions.h | 3 + chrome/browser/ui/BUILD.gn | 2 + .../frame/browser_non_client_frame_view_mac.h | 4 +- .../frame/browser_non_client_frame_view_mac.mm | 46 +-- .../ui/views/frame/immersive_mode_controller.h | 1 + .../immersive_mode_controller_factory_views.cc | 8 + .../ui/views/frame/immersive_mode_controller_mac.h | 14 + .../views/frame/immersive_mode_controller_mac.mm | 354 +++++++++++++++++++++ chrome/common/chrome_features.cc | 2 + chrome/common/chrome_features.h | 2 + .../renderer_host/render_widget_host_view_cocoa.mm | 8 +- .../render_widget_host_view_mac_unittest.mm | 8 +- tools/metrics/histograms/enums.xml | 2 + 16 files changed, 441 insertions(+), 26 deletions(-) commit 3558536963b742d80967cc7180214bfa170a894e Author: Mike Dougherty <michaeldo@chromium.org> Date: Thu Mar 21 17:36:54 2019 +0000 Remove old previously fixed TODOs. Bug: 228179 Change-Id: I1536048b571840909f3bc14cdd5826526c3df173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532055 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#642999} ios/web/public/web_state/ui/crw_context_menu_delegate.h | 1 - ios/web/web_state/ui/crw_context_menu_controller.h | 1 - 2 files changed, 2 deletions(-) commit 14149a9470318c6d6ca68a00f82bcfc618dbae59 Author: rbpotter <rbpotter@chromium.org> Date: Thu Mar 21 17:35:50 2019 +0000 Print Preview: Refactor settings behavior and print preview model This CL refactors SettingsBehavior to be an API for manipulating settings on print preview model. All settings are modified from the model and the model now fires all settings related events. This removes 2 way bindings for print preview's |settings| and reduces the friction for adding new settings by removing two observers that list out many settings individually. This also makes it easier to add OS-specific code, for future Chrome OS changes. As part of the refactoring, this CL removes a complicated set of observers in the preview area, in favor of a single verification of the print preview ticket before sending to the C++ handler. Also use new destinationState in preview area directly, instead of print-preview-app setting the state. This means that preview area and destination settings are now consistent, i.e. they both set their own states, which are used by print-preview-app to determine its state. Bug: 942345 Change-Id: I85cc64ad9843db0fc02c0020bf6d837648d00750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519766 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#642998} chrome/browser/printing/print_browsertest.cc | 2 +- .../browser/resources/print_preview/new/BUILD.gn | 2 +- .../new/advanced_options_settings.html | 3 +- .../print_preview/new/advanced_options_settings.js | 5 +- .../browser/resources/print_preview/new/app.html | 37 +- chrome/browser/resources/print_preview/new/app.js | 48 +- .../resources/print_preview/new/dpi_settings.js | 13 +- .../browser/resources/print_preview/new/header.js | 14 +- .../print_preview/new/media_size_settings.js | 13 +- .../browser/resources/print_preview/new/model.html | 1 - .../browser/resources/print_preview/new/model.js | 672 +++++++++++++-------- .../new/pages_per_sheet_settings.html | 1 + .../print_preview/new/pages_per_sheet_settings.js | 2 + .../resources/print_preview/new/preview_area.html | 2 +- .../resources/print_preview/new/preview_area.js | 345 ++++++----- .../print_preview/new/settings_behavior.html | 2 + .../print_preview/new/settings_behavior.js | 51 +- .../print_preview/print_preview_resources.grd | 3 +- .../webui/print_preview/advanced_dialog_test.js | 15 +- .../data/webui/print_preview/advanced_item_test.js | 17 +- .../webui/print_preview/color_settings_test.js | 24 +- .../webui/print_preview/copies_settings_test.js | 23 +- .../webui/print_preview/custom_margins_test.js | 77 +-- .../webui/print_preview/destination_select_test.js | 16 +- .../print_preview/destination_settings_test.js | 15 +- .../data/webui/print_preview/dpi_settings_test.js | 18 +- .../test/data/webui/print_preview/header_test.js | 41 +- .../webui/print_preview/layout_settings_test.js | 17 +- .../webui/print_preview/margins_settings_test.js | 32 +- .../print_preview/media_size_settings_test.js | 19 +- chrome/test/data/webui/print_preview/model_test.js | 9 +- .../new_print_preview_ui_browsertest.js | 2 + .../print_preview/other_options_settings_test.js | 64 +- .../print_preview/pages_per_sheet_settings_test.js | 31 +- .../webui/print_preview/pages_settings_test.js | 28 +- .../webui/print_preview/preview_generation_test.js | 20 +- .../print_preview/print_header_interactive_test.js | 52 +- .../data/webui/print_preview/restore_state_test.js | 4 +- .../webui/print_preview/scaling_settings_test.js | 38 +- .../webui/print_preview/settings_select_test.js | 15 +- 40 files changed, 884 insertions(+), 909 deletions(-) commit fa2eff839b55dd0816baa35ba8955dada5f9bf03 Author: Becca Hughes <beccahughes@chromium.org> Date: Thu Mar 21 17:35:04 2019 +0000 [Media Notification] Tweak layout Tweak layout to better align with the mocks. BUG=897836 Change-Id: I7aa2eb205e5e7b093d8fa8b33550a7e81a892df7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531018 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#642997} ash/media/media_notification_item.cc | 3 ++ ash/media/media_notification_view.cc | 63 +++++++++++++++++++-------- ash/media/media_notification_view.h | 3 ++ ash/media/media_notification_view_unittest.cc | 9 ++++ 4 files changed, 61 insertions(+), 17 deletions(-) commit 246f73d978ddacde64dcbdc68d7e32aca3701f4e Author: Stephane Zermatten <szermatt@chromium.org> Date: Thu Mar 21 17:34:45 2019 +0000 [Autofill Assistant] Fix issue with highlighted area staying at the wrong y offset after a fling. Before this change, the highlighted area could get stuck at the wrong scroll offset after a fling and not change until the user does something. With this change, the position of the highlighted area fixes itself and resets the offset. After this change, the highlighted area is fixed automatically next time the position of the element is refreshed. This change is a quick and safe temporary fix that forces the model to report all updates to the touchable area lets TouchEventFilterView know that the touchable area it has is still valid, and ignore the scroll offsets. Bug: b/129048184 Change-Id: I464b0ee1bee8da2545be29fc578d9fbc36d9a421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533897 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#642996} .../browser/autofill_assistant/overlay/AssistantOverlayModel.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Updated tag 'tree_truth' (was 02aeec31042e)