Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 39852 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8918350845594411168 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itveVfSR/luci_context.626157919 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm237-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 43ba728a69e39b11 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 1f478d5afed6c730023f9e59d9cf74d1ff4d1a56 [Mac Updater] Teach the relauncher about the update staged key. Avi Drissman, Thu Mar 21 19:02:16 2019 +0000 9bf336f3b2fa83d54b96fc0a127a2a160750f17d Add OzonePlatform::InitializedHostProperties. kylechar, Thu Mar 21 18:59:37 2019 +0000 87d367f45299a22c6a734ce3d5ecac533a47c72e Roll src/third_party/angle 3a0e5bebc040..f2bf49e20849 (2 commits) chromium-autoroll, Thu Mar 21 18:59:23 2019 +0000 f7badf291d20be5a895c106fcb88269c246e9fd8 Reland "Async Clipboard Tests: Use quotes as per style guide." Darwin Huang, Thu Mar 21 18:58:31 2019 +0000 01e51f2fe38db3fe9a67886be2c0a439d404ec90 [IOS] Clean up iframe messaging support base::Feature code Moe Ahmadi, Thu Mar 21 18:55:42 2019 +0000 9aff8196a6def6382fc51b0307ed2df1bc2b0acc Add base::mac::ScopedMachVM::reset_unaligned() Robert Sesek, Thu Mar 21 18:50:01 2019 +0000 9360f9688ec7a7334037ddf0344d00f66a7b0b30 System Clipboard: Make all write functions commit separately. Darwin Huang, Thu Mar 21 18:49:30 2019 +0000 98f4fd656ece25550007a584768a1d149aa3adef Roll src/third_party/pdfium 8f387edb2584..0e609bb98723 (6 commits) chromium-autoroll, Thu Mar 21 18:46:49 2019 +0000 0664b2596aedc900cd897a6b7a6de47e43fc116a WebView: Rework AwMetricsServiceClient Paul Miller, Thu Mar 21 18:44:49 2019 +0000 849b6234000683e6c46f5b4cd580be127cba1010 Reland "[ios] Validate PendingItem when updating NavigationItem in NTP helper." Justin Cohen, Thu Mar 21 18:42:06 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 1f478d5afed6c730023f9e59d9cf74d1ff4d1a56 Author: Avi Drissman <avi@chromium.org> Date: Thu Mar 21 19:02:16 2019 +0000 [Mac Updater] Teach the relauncher about the update staged key. If Chrome for the Mac is restarted to take an update, the relauncher will need to wait for the update to be applied. Add a class that knows how to watch for the staging key, and have the relauncher use it. BUG=496298 Change-Id: Ieb2102429c969f87dda64cba2f4a3d725b0babe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1527330 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#643047} chrome/browser/mac/relauncher.h | 14 ++- chrome/browser/mac/relauncher.mm | 44 +++++++-- chrome/common/BUILD.gn | 2 + chrome/common/mac/staging_watcher.h | 37 ++++++++ chrome/common/mac/staging_watcher.mm | 125 ++++++++++++++++++++++++++ chrome/common/mac/staging_watcher_unittest.mm | 117 ++++++++++++++++++++++++ chrome/test/BUILD.gn | 1 + 7 files changed, 331 insertions(+), 9 deletions(-) commit 9bf336f3b2fa83d54b96fc0a127a2a160750f17d Author: kylechar <kylechar@chromium.org> Date: Thu Mar 21 18:59:37 2019 +0000 Add OzonePlatform::InitializedHostProperties. Add a properties struct to OzonePlatform for properties that are known after host process initialization. This struct is used to store if we support overlays and replaces OverlayManagerOzone::SupportsOverlays(). The overlay validation logic is moving out of the host process and into the GPU process with OOP-D, so OverlayManagerOzone will no longer exist in the host process. Also remove the caching logic of RendererSettings in HostContextFactoryPrivate. We need to create the RendererSettings object after OzonePlatform::InitializeForUI() has run. Bug: 930173 Change-Id: Iae90006a1a654f96a08e7f2080b63efa92e04281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512674 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by: Robert Kroeger <rjkroege@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#643046} components/viz/host/renderer_settings_creation.cc | 11 +++++++++-- .../compositor/gpu_process_transport_factory.cc | 9 ++++----- .../browser/compositor/gpu_process_transport_factory.h | 2 -- ui/compositor/host/host_context_factory_private.cc | 3 +-- ui/compositor/host/host_context_factory_private.h | 1 - ui/ozone/common/stub_overlay_manager.cc | 4 ---- ui/ozone/common/stub_overlay_manager.h | 2 -- ui/ozone/platform/cast/overlay_manager_cast.cc | 4 ---- ui/ozone/platform/cast/overlay_manager_cast.h | 2 -- ui/ozone/platform/drm/common/drm_overlay_manager.cc | 4 ---- ui/ozone/platform/drm/common/drm_overlay_manager.h | 8 -------- ui/ozone/platform/drm/host/drm_display_host_manager.cc | 11 +++++------ ui/ozone/platform/drm/host/drm_display_host_manager.h | 15 +++++++++------ ui/ozone/platform/drm/ozone_platform_gbm.cc | 10 ++++++++-- ui/ozone/public/overlay_manager_ozone.h | 5 ----- ui/ozone/public/ozone_platform.cc | 13 +++++++++++++ ui/ozone/public/ozone_platform.h | 18 +++++++++++++++++- 17 files changed, 66 insertions(+), 56 deletions(-) commit 87d367f45299a22c6a734ce3d5ecac533a47c72e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 21 18:59:23 2019 +0000 Roll src/third_party/angle 3a0e5bebc040..f2bf49e20849 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/3a0e5bebc040..f2bf49e20849 git log 3a0e5bebc040..f2bf49e20849 --date=short --no-merges --format='%ad %ae %s' 2019-03-21 jonahr@google.com Fix locale being reset to default after ShCompileTest.DecimalSepLocale 2019-03-21 tobine@google.com Vulkan:Integrate SecondaryCommandBuffers Created with: gclient setdep -r src/third_party/angle@f2bf49e20849 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:943140 TBR=jmadill@chromium.org Change-Id: I581668a0c2c92cfd7515377f2e55869dd14bd051 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534536 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#643045} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f7badf291d20be5a895c106fcb88269c246e9fd8 Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Mar 21 18:58:31 2019 +0000 Reland "Async Clipboard Tests: Use quotes as per style guide." This is a reland of db06615901b73ccd41abb8e15954061c61bec3fd Original change's description: > Async Clipboard Tests: Use quotes as per style guide. > > Use ' (single-quotes) for js string quotes, and " (double-quotes) for HTML > string quotes. This was inconsistent before this CL, so make it more > consistent as per the Google JS/HTML style guides. > > Reference: > - https://google.github.io/styleguide/jsguide.html#features-strings-use-single-quotes > - https://google.github.io/styleguide/htmlcssguide.html#HTML_Quotation_Marks > > Change-Id: I794b278b2020a329f6e3ea0deeb6136ae04122c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531710 > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Darwin Huang <huangdarwin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642594} Change-Id: I6c2eec84e4f4a39cebe36fc7b168273ea3b7636e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534778 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#643044} .../async-navigator-clipboard-basics.https.html | 30 ++++++++++---------- .../async-write-blobtext-read-blobtext.https.html | 10 +++---- .../async-write-blobtext-read-text.https.html | 6 ++-- .../async-write-text-read-blobtext.https.html | 10 +++---- .../async-write-text-read-text.https.html | 6 ++-- .../async-clipboard/readtext-denied.https.html | 2 +- .../async-clipboard/readtext-granted.https.html | 2 +- .../async-clipboard/writetext-denied.https.html | 4 +-- .../async-clipboard/writetext-granted.https.html | 4 +-- .../clipboard/copy-image-at-with-pinch-zoom.html | 10 +++---- .../blink/web_tests/clipboard/copy-image-at.html | 10 +++---- .../wpt/clipboard-apis/async-interfaces.https.html | 16 +++++------ .../async-navigator-clipboard-basics.https.html | 32 +++++++++++----------- .../async-write-blobs-read-blobs-manual.https.html | 14 +++++----- ...-write-blobtext-read-blobtext-manual.https.html | 10 +++---- ...sync-write-blobtext-read-text-manual.https.html | 6 ++-- .../async-write-image-read-image-manual.https.html | 16 +++++------ ...sync-write-text-read-blobtext-manual.https.html | 10 +++---- .../async-write-text-read-text-manual.https.html | 6 ++-- .../wpt/clipboard-apis/copy-event-manual.html | 6 ++-- .../wpt/clipboard-apis/cut-event-manual.html | 6 ++-- .../wpt/clipboard-apis/paste-event-manual.html | 8 +++--- .../clipboard/async-write-blobs-read-blobs.html | 14 +++++----- .../clipboard/async-write-image-read-image.html | 16 +++++------ 24 files changed, 127 insertions(+), 127 deletions(-) commit 01e51f2fe38db3fe9a67886be2c0a439d404ec90 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Thu Mar 21 18:55:42 2019 +0000 [IOS] Clean up iframe messaging support base::Feature code Bug: 887985,881364 Change-Id: I40d6b2f6e57c1a3059d266e7d6093712d1d2b9ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525042 Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#643043} .../autofill/core/common/autofill_features.cc | 4 - .../autofill/core/common/autofill_features.h | 1 - components/autofill/ios/browser/BUILD.gn | 2 - components/autofill/ios/browser/autofill_agent.mm | 67 ++-- .../ios/browser/autofill_agent_unittests.mm | 338 --------------------- .../autofill/ios/browser/autofill_driver_ios.mm | 21 +- .../ios/browser/autofill_driver_ios_webstate.h | 41 --- .../ios/browser/autofill_driver_ios_webstate.mm | 48 --- .../autofill/ios/browser/autofill_switches.cc | 9 - .../autofill/ios/browser/autofill_switches.h | 1 - components/autofill/ios/browser/autofill_util.h | 16 +- components/autofill/ios/browser/autofill_util.mm | 56 +--- .../autofill/ios/browser/js_suggestion_manager.mm | 8 +- .../ios/form_util/form_activity_tab_helper.mm | 8 +- .../password_manager/ios/password_form_helper.mm | 4 +- ios/chrome/browser/about_flags.mm | 3 - ios/chrome/browser/ios_chrome_flag_descriptions.cc | 5 - ios/chrome/browser/ios_chrome_flag_descriptions.h | 4 - .../ui/autofill/form_input_accessory_mediator.mm | 10 +- .../manual_fill/manual_fill_injection_handler.mm | 66 ++-- .../manual_fill/password_view_controller_egtest.mm | 3 - ios/web/features.mm | 3 - ios/web/public/features.h | 3 - ios/web/web_state/ui/crw_web_controller.mm | 33 +- .../internal/autofill/cwv_autofill_controller.mm | 6 +- 25 files changed, 68 insertions(+), 692 deletions(-) commit 9aff8196a6def6382fc51b0307ed2df1bc2b0acc Author: Robert Sesek <rsesek@chromium.org> Date: Thu Mar 21 18:50:01 2019 +0000 Add base::mac::ScopedMachVM::reset_unaligned() In certain circumstances, like managing regions of memory sent over Mach IPC as OOL memory, the address/size may not be a multiple of PAGE_SIZE. This also adds a test for ScopedMachVM. Bug: 932175 Change-Id: I9c48534fefd8c66122d74ff7ed0b78a719cc0fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532745 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#643042} base/BUILD.gn | 1 + base/mac/scoped_mach_vm.cc | 17 ++- base/mac/scoped_mach_vm.h | 8 ++ base/mac/scoped_mach_vm_unittest.cc | 221 ++++++++++++++++++++++++++++++++++++ 4 files changed, 241 insertions(+), 6 deletions(-) commit 9360f9688ec7a7334037ddf0344d00f66a7b0b30 Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Mar 21 18:49:30 2019 +0000 System Clipboard: Make all write functions commit separately. Make write functions commit separately, so that writing of multiple types to the system clipboard is more consistent, and so that there aren't two parallel write implementations. Bug: 941085 Change-Id: I056972f30f13763b9bb6b483e7ea2773a68d2fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530831 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#643041} .../renderer/core/clipboard/system_clipboard.cc | 29 +--------------------- .../renderer/core/clipboard/system_clipboard.h | 16 +++--------- .../core/editing/commands/clipboard_commands.cc | 4 +++ .../renderer/core/editing/editing_utilities.cc | 1 + .../blink/renderer/core/editing/editor_test.cc | 1 + .../blink/renderer/core/exported/web_frame_test.cc | 1 + .../core/exported/web_plugin_container_impl.cc | 1 + .../core/exported/web_plugin_container_test.cc | 1 + .../renderer/core/inspector/dev_tools_host.cc | 1 + .../svg/unsafe_svg_attribute_sanitization_test.cc | 1 + .../modules/clipboard/clipboard_promise.cc | 5 ++-- 11 files changed, 19 insertions(+), 42 deletions(-) commit 98f4fd656ece25550007a584768a1d149aa3adef Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 21 18:46:49 2019 +0000 Roll src/third_party/pdfium 8f387edb2584..0e609bb98723 (6 commits) https://pdfium.googlesource.com/pdfium.git/+log/8f387edb2584..0e609bb98723 git log 8f387edb2584..0e609bb98723 --date=short --no-merges --format='%ad %ae %s' 2019-03-21 tsepez@chromium.org Call host.response() in xfa_host_pseudomodel javascript test. 2019-03-21 tsepez@chromium.org Remove CPFDXFA_Context::GetXFAApp() 2019-03-21 thestig@chromium.org Combine code in CFXJSE_FormCalcContext::GenerateSomExpression(). 2019-03-21 zhuo@hexoasis.com FX_GetNextFile: use stat.st_mode instead of dirent.d_type 2019-03-21 zhuo@hexoasis.com Rename "FX_FileHandle" to "FX_FolderHandle" 2019-03-21 thestig@chromium.org Rename CPDF_NPageToOneExporter members. Created with: gclient setdep -r src/third_party/pdfium@0e609bb98723 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I13922054b92bcfdf30b1be07f7373f7c028a5bc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534538 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#643040} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0664b2596aedc900cd897a6b7a6de47e43fc116a Author: Paul Miller <paulmiller@google.com> Date: Thu Mar 21 18:44:49 2019 +0000 WebView: Rework AwMetricsServiceClient The overarching goals of this change are to: - Only retain the client ID while we have consent for metrics. - Clean up tech debt. Specifically, for tech debt: - Move the client ID from WebView's special "metrics_guid" file into prefs, like Chrome. This requires 2 steps: 1. In this change, we check for any existing metrics_guid file. If it exists, copy the client ID into prefs and delete the file. 2. In a follow-up change, after ~all clients have deleted the file, we'll remove the file-handling code. - Generate client IDs in MetricsStateManager::ForceClientIdCreation(), like Chrome. (WebView previously generated its client ID in its own special function, AwMetricsServiceClient::LoadOrCreateClientId().) - Simplify the communication between the Java and native AwMetricsServiceClient classes. Make the native side wholly responsible for managing the race condition between native initialization and getting the consent setting back from GMS. Previously, native would inform Java when native initialization was finished, and only then would the Java side pass the consent setting to native. Now, the Java side passes the consent setting as soon as possible, so the Java side needn't keep track of the native side's state. See the new comments in aw_metrics_service_client.h for details. (This will all get simpler in the follow-up change, after which native initialization will no longer be asynchronous, because we won't have to load the metrics_guid file.) - Add lots of tests and comments, since AwMetricsServiceClient has become rather complicated since it was first added. BUG=939002 Change-Id: I5c599b307bc88841ad6cf316a58a5baffe750673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505898 Reviewed-by: Changwan Ryu <changwan@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#643039} android_webview/browser/aw_feature_list_creator.cc | 2 + .../browser/aw_metrics_service_client.cc | 218 +++++++++++---------- .../browser/aw_metrics_service_client.h | 127 +++++++++--- .../browser/aw_metrics_service_client_unittest.cc | 217 ++++++++++++++++++++ .../android_webview/AwMetricsServiceClient.java | 67 ++----- android_webview/test/BUILD.gn | 1 + 6 files changed, 444 insertions(+), 188 deletions(-) commit 849b6234000683e6c46f5b4cd580be127cba1010 Author: Justin Cohen <justincohen@google.com> Date: Thu Mar 21 18:42:06 2019 +0000 Reland "[ios] Validate PendingItem when updating NavigationItem in NTP helper." This reverts commit b01361ba281737b4352426f1d085cce1c6beaead. Reason for revert: Check for nil last committed rather than HasCommitted. Original change's description: > Revert "[ios] Validate PendingItem when updating NavigationItem in NTP helper." > > This reverts commit 37db17fa2230fb0645bec12bcb841b305bce7d30. > > Reason for revert: Seems there's still a !context->HasCommitted bug > outstanding. Re-land this after that's fixed. > > Original change's description: > > [ios] Validate PendingItem when updating NavigationItem in NTP helper. > > > > GetPendingItem() may not return the NavigationItem associated with a > > NavigationContext in some rare circumstances. Instead, validate that the item > > is indeed an NTP about://newtab URL, and update the page again on > > -DidFinishNavigation. > > > > Bug: 941245 > > Change-Id: I4e10091259dc4438b2e33e3c50e6b60a8e2f1fd3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1520699 > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#640420} > > TBR=justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org > > Change-Id: Ib0e8a1eab55f5dd3e8b883892bfcbafd9fa58bfd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 941245 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522587 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#640588} TBR=justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 941245 Change-Id: I97185ee72c20a97a89a385bf9a2266d694b5ee24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533287 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#643038} ios/chrome/browser/ntp/new_tab_page_tab_helper.h | 6 +++- ios/chrome/browser/ntp/new_tab_page_tab_helper.mm | 15 +++++----- .../ntp/new_tab_page_tab_helper_unittest.mm | 34 ++++++++++++++++++++++ 3 files changed, 47 insertions(+), 8 deletions(-) commit 6dc07d0b5db7a793692c3323cc122955182e327a Author: Marijn Kruisselbrink <mek@chromium.org> Date: Thu Mar 21 18:41:26 2019 +0000 [AppCache] Remove NOTIMPLEMENTED from OnTransferSizeUpdated. As far as I can tell just ignoring UpdateURLLoaderRequest::OnTransferSizeUpdated is the right thing to do, so get rid of the NOTIMPLEMENTED to avoid spamming log messages. Bug: none Change-Id: Ic08f3dceaed1f83fb667a43be84217d886e9ef2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534147 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#643037} content/browser/appcache/appcache_update_url_loader_request.cc | 1 - 1 file changed, 1 deletion(-) commit 3da7b67221a8263c944c7aa39ce1c194b374e032 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Thu Mar 21 18:41:01 2019 +0000 [layoutng] Split SelfNeedsLayout into two different flags One for "style has changed" and one for "available space has changed". This allows for more exact fragment caching in LayoutNG; when style has changed, we always need to relayout, but when the available space has changed, we may be able to reuse our cached fragment (subject to existing logic in LayoutNGMixin<Base>::CachedLayoutResult). In a followup CL, I would like to switch some ForceChildLayout calls to use this new flag as well. Change-Id: Ia45012046c25c7277fed0ea56fe2c0edb74db379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526625 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#643036} .../blink/renderer/core/layout/layout_block.cc | 2 + .../blink/renderer/core/layout/layout_object.cc | 2 +- .../blink/renderer/core/layout/layout_object.h | 52 ++++++++++++++++------ .../renderer/core/layout/ng/layout_ng_mixin.cc | 10 ++--- 4 files changed, 47 insertions(+), 19 deletions(-) commit 74a39de5976e911a737eeb2f168a44f22adc28a8 Author: Sajad Maysam <sajadm@google.com> Date: Thu Mar 21 18:39:53 2019 +0000 Click-through shadows for secondary UI. Allows events to pass through shadows on secondary UI. Did not use GetWindowMask to determine hit testing outside the bounds of border due to GetWindowMask not supporting Dialogs with arrows and not returning a mask for some dialogs. We also avoid using expensive SkPath contains logic by just using RRectF contains method. Bug: 944310 Change-Id: Ife54aa8997df9284fad29240c0d4a53402bbb494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516031 Commit-Queue: Sajad Maysam <sajadm@google.com> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Dana Fried <dfried@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#643035} ui/views/bubble/bubble_border.cc | 4 ---- ui/views/bubble/bubble_border.h | 4 ++++ ui/views/bubble/bubble_dialog_delegate_view_unittest.cc | 14 ++++++++------ ui/views/bubble/bubble_frame_view.cc | 10 ++++++++++ 4 files changed, 22 insertions(+), 10 deletions(-) commit b2dee2811c112dbdbfcfc9069a919c55e538c434 Author: Natalie Chouinard <chouinard@chromium.org> Date: Thu Mar 21 18:39:24 2019 +0000 Remove unused flag The enable-ntp-snippets-increased-visibility flag has no active usage. Bug: 944340 Change-Id: I631b55d27476227718c681b1a9fc742e5be4d7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533174 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#643034} .../chromium/chrome/browser/ChromeFeatureList.java | 1 - .../chrome/browser/ntp/snippets/SnippetsConfig.java | 19 ------------------- chrome/android/java_sources.gni | 1 - chrome/browser/about_flags.cc | 4 ---- chrome/browser/android/chrome_feature_list.cc | 1 - chrome/browser/flag-metadata.json | 5 ----- chrome/browser/flag_descriptions.cc | 6 ------ chrome/browser/flag_descriptions.h | 3 --- components/ntp_snippets/features.cc | 4 ---- components/ntp_snippets/features.h | 3 --- 10 files changed, 47 deletions(-) commit 5d9b8c8dd1b303859ed3ec397dbff36f289702e2 Author: Michael Montvelishsky <mont@chromium.org> Date: Thu Mar 21 18:37:50 2019 +0000 [Chromecast] Allow mapping volume 1.0 to less than 0 dBFS Change-Id: Id572aac7c56530a4218a1dcd2f9f4e6377185f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1516280 Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#643033} chromecast/media/cma/backend/volume_map.cc | 3 --- 1 file changed, 3 deletions(-) commit 87995fb41feb2fa7907e4eaf03f0ada83f6b53b2 Author: Lei Zhang <thestig@chromium.org> Date: Thu Mar 21 18:36:29 2019 +0000 Enable PdfIsolation feature by default. Remove PDFIsolatedExtensionTest since all PDFExtensionTests are isolated now. BUG=809614 Change-Id: Ia26a970748049036a8c5c3e1e61ab537cb50989e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533295 Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#643032} chrome/browser/pdf/pdf_extension_test.cc | 36 ++----------------------------- content/public/common/content_features.cc | 2 +- 2 files changed, 3 insertions(+), 35 deletions(-) commit 20edccd790db759fd8f7365d4f0bdcfb23a5a7b5 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Mar 21 18:36:26 2019 +0000 Add tests for pixel-snapping under 3d transform Bug: 936006 Change-Id: Ic5ba433e0f4eb2332259a20b4bdf11407ca6b6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534561 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#643031} .../subpixel-perspective-backface-hidden-ref.html | 4 ++++ .../css-transforms/subpixel-perspective-backface-hidden.html | 12 ++++++++++++ .../subpixel-perspective-translate-z-0-ref.html | 4 ++++ .../css-transforms/subpixel-perspective-translate-z-0.html | 10 ++++++++++ 4 files changed, 30 insertions(+) commit fd848eb61b774732344d42c5fde77c6a81c7d3a3 Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Thu Mar 21 18:35:23 2019 +0000 PM: Eliminate CuID in node constructors, delay initialization to JoinGraph. Bug: 910288 Change-Id: I2e81f4a8defc667fb983170ebebb60a7d6d75f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531378 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#643030} .../performance_manager/graph/frame_node_impl.cc | 22 ++++++++++------- .../performance_manager/graph/frame_node_impl.h | 6 ++--- chrome/browser/performance_manager/graph/graph.cc | 9 ++++--- .../performance_manager/graph/graph_test_harness.h | 25 +++---------------- .../graph/node_attached_data_unittest.cc | 4 +--- .../browser/performance_manager/graph/node_base.cc | 10 ++++---- .../browser/performance_manager/graph/node_base.h | 28 +++++++++++++++------- .../performance_manager/graph/page_node_impl.cc | 18 ++++++++------ .../performance_manager/graph/page_node_impl.h | 6 ++--- .../performance_manager/graph/process_node_impl.cc | 10 ++++---- .../performance_manager/graph/process_node_impl.h | 5 ++-- .../performance_manager/graph/system_node_impl.cc | 5 +--- .../performance_manager/graph/system_node_impl.h | 3 +-- .../performance_manager/performance_manager.cc | 4 +--- 14 files changed, 72 insertions(+), 83 deletions(-) commit 03faebbf75f0806365cb7668111baf3781481e47 Author: Xiaohui Chen <xiaohuic@google.com> Date: Thu Mar 21 18:35:20 2019 +0000 assistant: do not take screenshot in overview mode The overview mode animation will be killed and the UI will be in a strange state. Bug: 941276 Test: locally build and run with overview mode, then OKG does not Test: break OKG. Change-Id: I91ea9f95a7a4de0c398c035b9f2ec93e379831f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526693 Reviewed-by: Yue Li <updowndota@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#643029} ash/assistant/assistant_screen_context_controller.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 2e7239ecd4f60a334dbd082e71300fa2b87ee63a Author: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Date: Thu Mar 21 18:33:36 2019 +0000 Roll src-internal a8f7a1f5d626..bcbac1bf64b6 (2 commits) https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a8f7a1f5d626..bcbac1bf64b6 Created with: gclient setdep -r src-internal@bcbac1bf64b6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=melandory@chromium.org,nektar@chromium.org,fdegans@chromium.org,patricialor@chromium.org Change-Id: I3b29a8c53e152471014a6149df0074ca518f6c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534068 Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#643028} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8c9c36220d67ee9ea6a4d830b7020cceb52e5aeb Author: bsheedy <bsheedy@chromium.org> Date: Thu Mar 21 18:31:21 2019 +0000 Support OpenVR in VR perf tests Adds support for the real and mock OpenVR runtimes during the VR perf tests on Windows. As a result, also fixes several issues in the mock implementation that the perf test caught. Bug: 939178 Change-Id: Idb3f2fa7104c7f4f5da2af00c8b511ef3f4316ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531376 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#643027} device/vr/openvr/test/fake_openvr_impl_api.cc | 4 +- tools/perf/contrib/vr_benchmarks/BUILD.gn | 7 ++ .../vr_benchmarks/desktop_runtimes/base_runtime.py | 13 +-- .../desktop_runtimes/oculus_runtimes.py | 6 +- .../desktop_runtimes/openvr_runtimes.py | 112 ++++++++++++++++++++- .../contrib/vr_benchmarks/shared_vr_page_state.py | 12 +++ tools/perf/contrib/vr_benchmarks/vr_benchmarks.py | 10 ++ .../contrib/vr_benchmarks/webvr_sample_pages.py | 6 +- .../perf/contrib/vr_benchmarks/webvr_wpr_pages.py | 3 +- .../contrib/vr_benchmarks/webxr_sample_pages.py | 6 +- 10 files changed, 157 insertions(+), 22 deletions(-) commit 161241b7fd0a0373564bc400015ad7f229ec2c3d Author: chaopeng <chaopeng@chromium.org> Date: Thu Mar 21 18:25:17 2019 +0000 Call platform API for fallback cursor mode. Bug: 907116 Change-Id: Ie76a13bcdbfc7014f65d92cf63d835f54cb97be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525353 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#643026} .../renderer_host/input/input_router_client.h | 6 ++++ .../renderer_host/input/input_router_impl.cc | 13 +++++++ .../renderer_host/input/input_router_impl.h | 8 +++++ .../input/input_router_impl_unittest.cc | 7 ++++ .../renderer_host/input/mock_input_router_client.h | 5 +++ .../renderer_host/render_widget_host_impl.cc | 11 ++++++ .../renderer_host/render_widget_host_impl.h | 5 +++ .../render_widget_host_view_android.cc | 14 ++++++++ .../render_widget_host_view_android.h | 5 +++ .../renderer_host/render_widget_host_view_base.cc | 8 +++++ .../renderer_host/render_widget_host_view_base.h | 7 ++++ content/common/input/input_handler.mojom | 6 ++++ .../renderer/input/widget_input_handler_manager.cc | 18 ++++++++++ .../renderer/input/widget_input_handler_manager.h | 3 ++ content/renderer/render_widget.cc | 12 +++++++ content/renderer/render_widget.h | 5 +++ content/renderer/render_widget_unittest.cc | 6 ++++ third_party/blink/public/web/web_widget_client.h | 7 ++++ .../blink/renderer/core/page/chrome_client_impl.cc | 22 ++++++++++-- .../chromium/ui/base/TouchlessEventHandler.java | 16 +++++++++ .../org/chromium/ui/base/ViewAndroidDelegate.java | 15 ++++++-- ui/android/view_android.cc | 40 +++++++++++++++++----- ui/android/view_android.h | 4 +++ 23 files changed, 231 insertions(+), 12 deletions(-) commit 3724b1d8a93562382454d7b46d273c7375178fcd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Mar 21 18:24:03 2019 +0000 Roll src/third_party/webrtc 94b57c044e81..ab9735f6ca22 (1 commits) https://webrtc.googlesource.com/src.git/+log/94b57c044e81..ab9735f6ca22 git log 94b57c044e81..ab9735f6ca22 --date=short --no-merges --format='%ad %ae %s' 2019-03-21 ivoc@webrtc.org Return nullptr instead of crashing in NetEqTestFactory Created with: gclient setdep -r src/third_party/webrtc@ab9735f6ca22 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia99a48e33dcf3bfca10974345de6c358a419b6ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534067 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#643025} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f36b79b078c4d6d9121011b6350bdd418725e482 Author: Kevin Ellis <kevers@chromium.org> Date: Thu Mar 21 18:23:50 2019 +0000 Simplify TickAnimationWorklets Animation worklets do not using monotonic time for computing local time. The patch removes the superfluous parameter. Bug: 937975 Change-Id: I8ffe17e5564f56de4aeefc0c7ae4eabd2702890e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534278 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#643024} cc/animation/animation_host.cc | 4 ++-- cc/animation/animation_host.h | 2 +- cc/animation/animation_host_unittest.cc | 2 +- cc/trees/layer_tree_host_impl.cc | 3 +-- cc/trees/mutator_host.h | 2 +- 5 files changed, 6 insertions(+), 7 deletions(-) commit 0113e3844523404d2e00df692b8cce75d609209c Author: dstockwell <dstockwell@google.com> Date: Thu Mar 21 18:21:48 2019 +0000 pdf: Fix externs for ink_api DOMMatrix was used by ink_api in [1] but the extern was missed because the build rule had the wrong dependency. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1517474 Change-Id: I9f725729ae23fc32d87dccf8b283aa725fbcc42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529974 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#643023} chrome/browser/resources/pdf/ink/BUILD.gn | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) commit 83f1a0d148a2d3cf228faac7179a44016b76355f Author: Xida Chen <xidachen@chromium.org> Date: Thu Mar 21 18:21:30 2019 +0000 Move PaintWorkletPainterClient setter to WebWidgetClient (2/6) This CL follows the logic in a landed CL: https://chromium-review.googlesource.com/c/chromium/src/+/1490496. This CL is also part of a prototype: https://chromium-review.googlesource.com/c/chromium/src/+/1495445 in order to implement the paint worklet dispatching logic. Bug: 884698 Change-Id: I0b69dd6e1e7a9844d372123093429b7c1a83a249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525314 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#643022} content/renderer/compositor/layer_tree_view.cc | 6 ------ content/renderer/compositor/layer_tree_view.h | 2 -- content/renderer/render_widget.cc | 6 ++++++ content/renderer/render_widget.h | 2 ++ third_party/blink/public/platform/web_layer_tree_view.h | 4 ---- third_party/blink/public/web/web_widget_client.h | 4 ++++ 6 files changed, 12 insertions(+), 12 deletions(-) commit 9ccaf60f4efe844ba9a29be01a6eb16f624d6b41 Author: Vladimir Levin <vmpstr@chromium.org> Date: Thu Mar 21 18:20:42 2019 +0000 Reland "[DL]: Fix yielding budget to ensure it marks the next phase."" This relands the yielding budget update to ensure that we process the next phase after completing a phase. This includes a fix to initialize |next_phase_from_start_of_lifecycle_| variable in the yielding budget, since we can access it prior to normal initialization in the following scenario: e.dl.update(); e.appendChild(div); The append would check if we can style it while inserting it, which would check the budget before the lifecycle update phase begins (which is what normally initializes the variable). R=chrishtr@chromium.org Bug: 882663 Change-Id: I6f8ad99ec0455769b3f16e630abcfd7a3dd9a3d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534136 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#643021} .../core/display_lock/display_lock_budget_test.cc | 99 ++++++++++++++++++++-- .../core/display_lock/display_lock_context.cc | 13 +++ .../core/display_lock/display_lock_context.h | 4 + .../display_lock/yielding_display_lock_budget.cc | 15 +++- .../display_lock/yielding_display_lock_budget.h | 1 + .../blink/renderer/core/dom/container_node.cc | 5 ++ .../blink/renderer/core/layout/layout_object.cc | 9 +- 7 files changed, 138 insertions(+), 8 deletions(-) commit 316f0788b54341440db403e768dc3cf62612a1c9 Author: Eugene But <eugenebut@chromium.org> Date: Thu Mar 21 18:16:59 2019 +0000 Allow ios/web/common from ios/chrome. ios/web/common directory contains common code shared between //ios/web and the rest of the layers (//components, //ios/chrome, //ios/web_view). Bug: 942244 Change-Id: I81f430cadf9bafa5ee2d1188e0cd9ff58dc76bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533084 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#643020} ios/chrome/DEPS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 6ddc0ac99e4c93f84b432702e641b424d6f83c71 Author: Etienne Pierre-doray <etiennep@chromium.org> Date: Thu Mar 21 18:16:21 2019 +0000 [TaskScheduler]: Refactor TaskRunner ownership cycle. This CL takes Task out of the reference loop, so that TaskSource refers to its TaskRunner directly. Task can be replaced by PendingTask as a result (will be done as a follow-up). A TaskRunner reference is cleared when the TaskSource becomes empty and set by the caller when pushing a task to a Sequence. Change-Id: I9ffeca51d392ba286494ef85bac9697da48b893d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506769 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by: Gabriel Charette <gab@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#643019} base/task/task_scheduler/delayed_task_manager.cc | 18 ++++++--- base/task/task_scheduler/delayed_task_manager.h | 12 ++++-- .../delayed_task_manager_unittest.cc | 36 ++++++++++------- .../task/task_scheduler/priority_queue_unittest.cc | 3 +- .../scheduler_parallel_task_runner.cc | 3 +- .../scheduler_sequenced_task_runner.cc | 6 ++- .../scheduler_single_thread_task_runner_manager.cc | 13 ++++--- .../task_scheduler/scheduler_worker_unittest.cc | 9 +++-- base/task/task_scheduler/sequence.cc | 45 +++++++++++++++++----- base/task/task_scheduler/sequence.h | 21 +++++----- base/task/task_scheduler/sequence_unittest.cc | 18 ++++++--- base/task/task_scheduler/task.cc | 6 +-- base/task/task_scheduler/task.h | 13 +------ base/task/task_scheduler/task_scheduler_impl.cc | 12 ++++-- base/task/task_scheduler/task_source.cc | 11 +++++- base/task/task_scheduler/task_source.h | 34 +++++++++++++++- base/task/task_scheduler/task_source_unittest.cc | 5 ++- base/task/task_scheduler/task_tracker.cc | 43 ++++++++++++--------- .../task_scheduler/task_tracker_posix_unittest.cc | 8 ++-- base/task/task_scheduler/task_tracker_unittest.cc | 31 +++++++++------ base/task/task_scheduler/test_utils.cc | 16 ++++++-- base/task/task_scheduler/test_utils.h | 14 +++++-- 22 files changed, 251 insertions(+), 126 deletions(-) commit e6395fe3fa388382be11bd72f96ddc4204b544e7 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Mar 21 18:12:01 2019 +0000 Import wpt@6ed3fe181b545df8586b3581abc31714f9356725 Using wpt-import in Chromium 4fdf6c43808e69a44aeb0d3cc8ddc63cf29cde6d. With Chromium commits locally applied on WPT: 68d5240e06 "[ChromeDriver] Set key modifiers with mouse actions" 73fa2b382e "[wpt] Fix actionsWithKeyPressed.html.ini" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-method-basic-card NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I6eb3c867aa982696aa0c59ca784a671800b45c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534143 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#643018} third_party/blink/web_tests/TestExpectations | 2 + .../web_tests/external/WPT_BASE_MANIFEST_5.json | 26 +++- .../apply_the_modifiers.html | 152 +++++++++++++++++++++ .../steps_for_selecting_the_payment_handler.html | 100 ++++++++++++++ .../external/wpt/tools/manifest/manifest.py | 23 ++-- .../third_party/py/doc/announce/release-1.4.0.txt | 4 +- .../third_party/py/doc/announce/release-1.4.1.txt | 4 +- 7 files changed, 290 insertions(+), 21 deletions(-) commit 813b5a1c1e34ea9decba440078c76b15e7e737b4 Author: Zhenyao Mo <zmo@chromium.org> Date: Thu Mar 21 18:11:53 2019 +0000 Implement an interactive bisect_variations.py script on top of the split_variations_cmd.py So far it works on Mac, Windows, and Linux. BUG=932197 TEST=manual R=mguaypaq@chromium.org,asvitkine@chromium.org,kbr@chromium.org Change-Id: I44f751914ec5364d08da6f9eb1964b2e92806a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507243 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#643017} tools/variations/bisect_variations.py | 294 ++++++++++++++++++++++ tools/variations/split_variations_cmd.py | 24 +- tools/variations/split_variations_cmd_unittest.py | 8 + 3 files changed, 320 insertions(+), 6 deletions(-) Updated tag 'tree_truth' (was ec406dd62373)