Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/ /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 38485 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: LOGDOG_STREAM_PREFIX: buildbucket/ LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itHShswR/luci_context.801269572 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm2480-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: SWARMING_TASK_ID: 43bae0fdd96f8411 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 9ba136948587d54cf489e15035b059979e4bee15 Splitting AuthenticatorImpl into AuthenitcatorCommon. Manas Verma, Thu Mar 21 21:01:00 2019 +0000 0f9f96d22b6b5fcd466f7e453d9ca4e51d219ac1 [Locked Fullscreen] Move Chrome OS specific code out of tabs_api Ivan Sandrk, Thu Mar 21 20:58:40 2019 +0000 b9005e2af3628378dc3eb003c41d0a12138339c5 History WebUI: Remove unused variable in history_focus_test.js Dmitry Iljinskiy, Thu Mar 21 20:57:23 2019 +0000 12b19b1a3f7eb4bd1964df20bcad58ba6c985a72 [Extensions Bindings] Remove guards around bindingUtil in //chrome Devlin Cronin, Thu Mar 21 20:57:06 2019 +0000 d4e7513f548f21e41cc6dc0012b462fff12836df Remove ununsed error handling classes Antonio Gomes, Thu Mar 21 20:55:57 2019 +0000 56aa396c1e99ece23b711fb831c5505225b0b1b1 Fix crash caused by dup-sections in Passwords VC. Yi Su, Thu Mar 21 20:55:24 2019 +0000 4685a848c08a5e0a0597066abb156b4eecfa5ef6 DevTools: Fix initial position of DevTools window in certain configs Jeff Fisher, Thu Mar 21 20:54:36 2019 +0000 e430b8a332b8e9e39cb490cf16f120ae812393ac Use UniquePtrComparator in content/public/test. David Benjamin, Thu Mar 21 20:46:27 2019 +0000 49e7949ededaa81be876983fed2cefa834516901 AccessibilityNotificationWaiter should listen to all frames Dominic Mazzoni, Thu Mar 21 20:46:16 2019 +0000 328fccb1759e19336253d579e56387ac2d609ee4 DNR: Have RulesetSource constructor take in the ID and priority. Karan Bhatia, Thu Mar 21 20:44:33 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 9ba136948587d54cf489e15035b059979e4bee15 Author: Manas Verma <> Date: Thu Mar 21 21:01:00 2019 +0000 Splitting AuthenticatorImpl into AuthenitcatorCommon. This CL introduces, which performs most of the functionality in AuthenticatorImpl. This class is meant to reduce code repetition when introducing ChromeInternalAuthenticatorImpl. See go/authenticator-util and go/autofill-auth-client-dd for more information. Bug: 941873 Change-Id: Idd3c535714c69146ee5094e201de301d3da41dee Reviewed-on: Commit-Queue: Manas Verma <> Reviewed-by: Kim Paulhamus <> Cr-Commit-Position: refs/heads/master@{#643111} content/browser/ | 2 + content/browser/webauth/ | 95 +- content/browser/webauth/authenticator_common.h | 82 +- content/browser/webauth/ | 1315 +------------------- content/browser/webauth/authenticator_impl.h | 140 +-- .../browser/webauth/ | 40 +- 6 files changed, 123 insertions(+), 1551 deletions(-) commit 0f9f96d22b6b5fcd466f7e453d9ca4e51d219ac1 Author: Ivan Sandrk <> Date: Thu Mar 21 20:58:40 2019 +0000 [Locked Fullscreen] Move Chrome OS specific code out of tabs_api Create a new tabs_util file and move the platform specific code there. Additionally, add myself as an owner for this file (since it does locked fullscreen related stuff). Bug: 937786 Change-Id: I89678386121522d4b5c6d709973ff32c3624d525 Reviewed-on: Commit-Queue: Ivan Ĺ andrk <> Reviewed-by: Karan Bhatia <> Cr-Commit-Position: refs/heads/master@{#643110} chrome/browser/extensions/ | 3 + chrome/browser/extensions/api/tabs/OWNERS | 2 + chrome/browser/extensions/api/tabs/ | 83 +++------------------- chrome/browser/extensions/api/tabs/ | 13 ++++ chrome/browser/extensions/api/tabs/tabs_util.h | 24 +++++++ .../extensions/api/tabs/ | 66 +++++++++++++++++ 6 files changed, 116 insertions(+), 75 deletions(-) commit b9005e2af3628378dc3eb003c41d0a12138339c5 Author: Dmitry Iljinskiy <> Date: Thu Mar 21 20:57:23 2019 +0000 History WebUI: Remove unused variable in history_focus_test.js Change-Id: I8ba3cd9673eea1a97fb17e878123fe2c1377eff5 Reviewed-on: Reviewed-by: Demetrios Papadopoulos <> Commit-Queue: Dmitry Iljinskiy <> Cr-Commit-Position: refs/heads/master@{#643109} chrome/test/data/webui/history/history_focus_test.js | 2 -- 1 file changed, 2 deletions(-) commit 12b19b1a3f7eb4bd1964df20bcad58ba6c985a72 Author: Devlin Cronin <> Date: Thu Mar 21 20:57:06 2019 +0000 [Extensions Bindings] Remove guards around bindingUtil in //chrome Custom bindings in JS files used to require guards around bindingUtil, since it was only set if native extension bindings were used. Now that native extension bindings are the only form of bindings, we can remove the guards and JS versions of the same invocations. Bug: 938998 Change-Id: I971155cd514222264d8df4a3d6878f8f0d7ca0b4 Reviewed-on: Reviewed-by: Karan Bhatia <> Commit-Queue: Devlin <> Cr-Commit-Position: refs/heads/master@{#643108} .../extensions/automation_custom_bindings.js | 10 +---- .../extensions/browser_action_custom_bindings.js | 17 ++------ .../certificate_provider_custom_bindings.js | 21 ++-------- .../extensions/desktop_capture_custom_bindings.js | 19 ++++----- .../extensions/downloads_custom_bindings.js | 7 +--- .../file_browser_handler_custom_bindings.js | 7 +--- .../file_manager_private_custom_bindings.js | 13 ++---- .../file_system_provider_custom_bindings.js | 47 ++++++++++------------ .../extensions/input.ime_custom_bindings.js | 7 +--- .../extensions/media_galleries_custom_bindings.js | 8 ++-- .../extensions/notifications_custom_bindings.js | 27 +++---------- .../extensions/omnibox_custom_bindings.js | 16 ++------ .../extensions/page_action_custom_bindings.js | 8 +--- .../extensions/platform_keys/subtle_crypto.js | 19 ++------- .../extensions/sync_file_system_custom_bindings.js | 8 +--- .../extensions/system_indicator_custom_bindings.js | 8 +--- .../extensions/tab_capture_custom_bindings.js | 23 +++-------- .../extensions/terminal_private_custom_bindings.js | 8 +--- .../resources/extensions/tts_custom_bindings.js | 7 +--- .../extensions/tts_engine_custom_bindings.js | 15 ++----- .../extensions/web_view/chrome_web_view.js | 17 ++------ ...brtc_desktop_capture_private_custom_bindings.js | 18 ++++----- 22 files changed, 95 insertions(+), 235 deletions(-) commit d4e7513f548f21e41cc6dc0012b462fff12836df Author: Antonio Gomes <> Date: Thu Mar 21 20:55:57 2019 +0000 Remove ununsed error handling classes This CL removes the following classes: - ErrorCallbackBase - ScriptErrorCallback - PromiseErrorCallback ... and as well the left over ReportError overloads in DOMFileSystemBase, DOMFileSystem and DOMFileSystemSync classes. Note that in order to remove the ReportError overloaded methods, some left-over calls to them in and were converted to using BindOnce error callbacks. BUG=933878 Change-Id: I20c9e8ebce9c1d723b95e2d98121425059a5ef7d Reviewed-on: Commit-Queue: Antonio Gomes <> Reviewed-by: Marijn Kruisselbrink <> Cr-Commit-Position: refs/heads/master@{#643107} .../renderer/modules/filesystem/ | 15 ---- .../renderer/modules/filesystem/dom_file_system.h | 4 -- .../modules/filesystem/dom_file_system_base.h | 2 - .../modules/filesystem/ | 5 -- .../modules/filesystem/dom_file_system_sync.h | 1 - .../modules/filesystem/ | 22 +++--- .../modules/filesystem/ | 81 +++++----------------- .../modules/filesystem/file_system_callbacks.h | 41 +---------- .../filesystem/ | 22 +++--- 9 files changed, 38 insertions(+), 155 deletions(-) commit 56aa396c1e99ece23b711fb831c5505225b0b1b1 Author: Yi Su <> Date: Thu Mar 21 20:55:24 2019 +0000 Fix crash caused by dup-sections in Passwords VC. Currently, activating search bar in PasswordsTableViewController will remove the "save passwords" switch section, and deactivating the search bar will add it back. However, PasswordsTableViewController.loadModel doesn't check the status of search bar when adding switch section, so dup-sections will happen in this scenario: 1. PasswordsTableViewController is inited; 2. Switch section is added in |loadModel|; 3. User activates the search bar; 4. Switch section is removed in |willPresentSearchController|; 5. |onGetPasswordStoreResults| is called, which will call |loadModel|; 6. |loadModel| adds the switch section; 7. User deactivates the search bar; 8. Another switch section is added back in |willDismissSearchController|. And dup switch sections will cause a crash in following steps: 1. User taps "Edit"; 2. User selects the switch item in the second switch section; 3. User taps "Delete". The crash happens because the SettingsSwitchItem will be cast to Passwords SavedFormContentItem, which leads to corrupted memory. Bug: 943649 Change-Id: Ic486886cefb1aceda3a8a986502a8ffb1a34e019 Reviewed-on: Commit-Queue: Yi Su <> Auto-Submit: Yi Su <> Reviewed-by: Sergio Collazos <> Cr-Commit-Position: refs/heads/master@{#643106} .../password/ | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) commit 4685a848c08a5e0a0597066abb156b4eecfa5ef6 Author: Jeff Fisher <> Date: Thu Mar 21 20:54:36 2019 +0000 DevTools: Fix initial position of DevTools window in certain configs When DevTools opens in particular monitor configurations, the tools are positioned incorrectly, which results on them slowly migrating offscreen with each successive close and open. This is caused when the last known location of the tools is on a secondary display that has a different scale factor than the primary display. When window bounds are saved in prefs::kAppWindowPlacement, their pixel cooridinates are first normalized to density independent pixels (DIPs.) When a window is restored to its last saved position, these coordinates are supposed to be translated back, but this was not happening correctly, resulting in the devtools window being positioned offset from its last location. Why this was happening had to do with a nuance of how and when window placement is retrieved. DevToolsWindow::CreateDevToolsBrowser() creates a Browser object, but it does not actually pass in the saved bounds at this time. Instead, BrowserFrame::InitBrowserFrame() calls its super method Widget::Init() with its own set of Widget::InitParams that has a default empty bounds. The way this was supposed to work is that Widget::SetInitialBounds retrieves any previously saved bounds with Widget::GetSavedWindowPlacement and applies them with a call to SetBounds(). However, the timing of operations inside Widget::Init() created undesired behavior. Before Widget::SetInitialBounds() is called, Init() first calls into InitNativeWidget(), which ends up calling into DesktopWindowTreeHostWin::Init, which takes in the initial bounds, translates them into real screen coordinates, and creates the window via the HwNDMessageHandler. This means that, initially, there is an invisible window created at (0,0) on the primary display. After this window is created, the call to Widget::SetInitialBounds() happens, and the saved bounds is passed along to DesktopWindowTreeHost::SetBoundsInDIP. This method translates the coordinates from DIP to real screen pixels using ScreenWin::DIPToScreenRectInWindow. ScreenWin::DIPToScreenRectInWindow then calls ScreenWin::DIPToScreenRect to do the translation. This is where one problem arises, since DIPToScreenRect uses the HWND of the already created window to retrieve scaling information. Since the HWND was created on the primary display, if the saved position is not on the primary display, it is now retrieving the incorrect scale factor and translates the DIP coorindates incorrectly for the target display. My original solution to this problem was to ignore the HWND in this case and determine the appropriate ScreenWinDisplay using only the dip_bounds. This resulted in the coordinates being mapped correctly, however when the window position was updated with SetWindowPos(), HWNDMessageHandler::OnDpiChanged would get called because the window moved to a different screen and the window's size would get up-scaled again, even though DIPToScreenRect had already calculated the proper final size. Instead, this fix modifies BrowserFrame::InitBrowserFrame to ensure that the Widget::InitParams of the frame pull the correct kAppWindowPlacement bounds from prefs before the window is positioned initially. This makes sure that the HWND is created on the appropriate screen from the start and avoids any trouble from moving the window after creation. Bug: 783199 Change-Id: Ie3cc24378054111d4e5d4103ce984362dc7581d5 Reviewed-on: Commit-Queue: Jeff Fisher <> Reviewed-by: Scott Violet <> Reviewed-by: Peter Kasting <> Cr-Commit-Position: refs/heads/master@{#643105} chrome/browser/devtools/ | 2 + chrome/browser/ui/views/frame/ | 7 +++- .../ui/views/frame/ | 45 ++++++++++++++++++++++ chrome/test/ | 1 + chrome/test/base/ | 13 ++++++- chrome/test/base/in_process_browser_test.h | 16 ++++++-- ui/display/win/screen_win.h | 8 ++-- .../desktop_aura/ | 3 ++ 8 files changed, 87 insertions(+), 8 deletions(-) Updated tag 'tree_truth' (was e430b8a332b8)