Back to build
Raw log | Switch to full mode | Login

/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh /b/swarming/w/ir/cache/builder/src src in dir /b/swarming/w/ir/k: allow_subannotations: False cmd: ['/b/swarming/w/ir/cache/builder/src/build/tree_truth.sh', '/b/swarming/w/ir/cache/builder/src', 'src'] env: {'CHROME_HEADLESS': '1'} env_prefixes: {} env_suffixes: {} infra_step: False name_tokens: ('tree truth steps',) ok_ret: frozenset([0]) trigger_specs: () full environment: ADDRFAM: inet BOTO_CONFIG: /b/swarming/w/ir/tmp/gsutil_task/.boto BUILDBUCKET_EXPERIMENTAL: FALSE CHROME_HEADLESS: 1 CIPD_CACHE_DIR: /b/swarming/cipd_cache/cache CIPD_PROTOCOL: v2 DEVSHELL_CLIENT_PORT: 44544 DOCKER_CONFIG: /b/swarming/w/ir/tmp/docker_cfg_task DOCKER_TMPDIR: /b/swarming/w/ir/tmp/docker_tmp_task GIT_CONFIG_NOSYSTEM: 1 GIT_TERMINAL_PROMPT: 0 HOME: /home/chrome-bot IFACE: eth0 INFRA_GIT_WRAPPER_HOME: /b/swarming/w/ir/tmp/git_home_task LOGDOG_COORDINATOR_HOST: logs.chromium.org LOGDOG_STREAM_PREFIX: buildbucket/cr-buildbucket.appspot.com/8916983715940115408 LOGDOG_STREAM_PROJECT: chromium LOGDOG_STREAM_SERVER_PATH: unix:/b/swarming/w/ir/tmp/ld.sock LOGICAL: eth0 LUCI_CONTEXT: /b/swarming/w/itJfJJEe/luci_context.342063639 MAC_CHROMIUM_TMPDIR: /b/swarming/w/ir/tmp/t METHOD: dhcp NO_GCE_CHECK: False PATH: /b/swarming/w/ir/cipd_bin_packages:/b/swarming/w/ir/cipd_bin_packages/bin:/b/swarming/cipd_cache/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin PWD: /b/swarming/w/ir/k PYTHONIOENCODING: UTF-8 PYTHONUNBUFFERED: 1 ROOT_SETUP_LOG: /var/log/messages/chromebuild/root-setup.log SHLVL: 1 STARTUP_LOG: /var/log/messages/chromebuild/startup.log SWARMING_BOT_ID: swarm989-c4 SWARMING_EXTERNAL_BOT_SETUP: 1 SWARMING_HEADLESS: 1 SWARMING_SERVER: https://chromium-swarm.appspot.com SWARMING_TASK_ID: 440828e95594e511 TEMP: /b/swarming/w/ir/tmp/t TEMPDIR: /b/swarming/w/ir/tmp/t TERM: linux TMP: /b/swarming/w/ir/tmp/t TMPDIR: /b/swarming/w/ir/tmp/t UPSTART_EVENTS: net-device-up UPSTART_INSTANCE: UPSTART_JOB: chromebuild-startup USER: chrome-bot USERNAME: chrome-bot VPYTHON_VIRTUALENV_ROOT: /b/swarming/w/ir/cache/vpython _: /b/swarming/w/ir/cipd_bin_packages/vpython !@@@BUILD_STEP Brief summary of recent CLs in every branch@@@ src: 5ca9617685dff37428c991415efad93ef7fb44e7 [omnibox]: Clean up classifications for historyUrl "url-what-you-typed" manuk, Fri Apr 5 21:09:06 2019 +0000 d6a4d7f28a0b44edb36cedb8cb07a84820c44622 Removed #import <EarlGrey/EarlGrey.h> from ios/chrome/test/earl_grey/chrome_earl_grey_ui.h Maksym Onufriienko, Fri Apr 5 21:07:31 2019 +0000 dc21174461ba56cd2c8db84b908e75d2b26a4f28 Reverting http://crrev.com/c/1545366. Aaron Colwell, Fri Apr 5 21:04:01 2019 +0000 ab68c05beb790d04d1cb7fd8faa0a197fb40d399 CacheStorage: Move Legacy classes to separate dir. Ben Kelly, Fri Apr 5 21:01:47 2019 +0000 0a611f37b80a2b3ba7a3916d0408de7d2309e5cd Disable UDPSocketTest.SharedMulticastAddress on iOS. Misha Efimov, Fri Apr 5 20:59:31 2019 +0000 1d172268ba9d21e2c9c16bf19f835dd02f225617 IDL: Replace implemented [NoInterfaceObject] with mixin Hitoshi Yoshida, Fri Apr 5 20:55:54 2019 +0000 8b5f6a79bed95e04136092b369cf36528f43a9ab Blockfile cache: fix EntryImpl field destruction order. Maks Orlovich, Fri Apr 5 20:52:41 2019 +0000 282db7945e8bd9dd8f13865ecb78efe3bed7b685 Sniff real MIME types of images to enforce unoptimized image policies. Paul Meyer, Fri Apr 5 20:50:58 2019 +0000 881ecfecade55008a5d0370f98afdc5cab49717c Import wpt@c3c423be44cc049b7bf951ca3c755afd72a8d0ec Chromium WPT Sync, Fri Apr 5 20:49:06 2019 +0000 d8d6676b74dfd8de29b3711db17b433b816cc70d Add tests for color inversion of SVG images when inverting all images. Aran Gilman, Fri Apr 5 20:48:05 2019 +0000 ================================================================= !@@@BUILD_STEP New commits in repo src@@@ commit 5ca9617685dff37428c991415efad93ef7fb44e7 Author: manuk <manukh@chromium.org> Date: Fri Apr 5 21:09:06 2019 +0000 [omnibox]: Clean up classifications for historyUrl "url-what-you-typed" This is the 6th refactoring CL aimed at reducing duplication and inconsistency for classifying omnibox results. The historyUrl, zeroSuggest, and clipboard providers can provide "url-what-you-typed" suggestions; e.g. the input text 'google.com' can trigger a historyUrl suggestion with contents 'google.com' and URL 'http://google.com/'. The zeroSuggest and clipboard providers explicitly clear the classifications of their suggestions (probably because there's no user text associated with the suggestions). The historyUrl "url-what-you-typed" suggestions classify their descriptions as other historyUrl suggestions (which was cleaned up in the 5th CL crrev.com/c/1552140). Therefore, this CL only addresses historyUrl "url-what-you-typed" suggestions' contents' classifications. Previously, the contents were classified using AutocompleteMatch::ClassifyMatchInString and AutocompleteMatch::ClassifyLocationInString. Specifically, if the user input began with 'view-source:' and the colon was not followed by a protocol (e.g. 'http'), then ClassifyMatchInString was used and the first occurrence of the (slightly modified to be a valid URL) user input was bolded. Otherwise, if the input did not begin with 'view-source:' or the input began with 'view-source:<protocal>', then ClassifyLocationInString was used to bold a number of characters equal to the length of the user input, offset by the length of the prefix (e.g. 'http://www.') in the destination URL but not the user input (e.g. if the user typed 'google.com', the URL would be 'http://google.com/', and the missing prefix length would be 5) minus the length of the prefix trimmed from the URL when setting the contents text. This CL simplifies "url-what-you-typed" classifications to simply bold from the start of the contents text for the length of the user input. In most scenarios, this is effectively the same as before. In the few cases where the new behavior differs from the old, the new behavior is the more desirable: 1) Typing 'chrome:', 'chrome:/' or 'chrome:// will suggest 'chrome://version. Previously, 'chrome://' would not bold the suggestion, though the other inputs would bold the entire suggestion; this was because the URL would be fixed to chrome://. With this CL, all 3 inputs bold the entire suggestion. 2) Typing 'view-source:x' or 'view-source:x/' will suggest 'view-source:x'. Previously, 'view-source:x/' would not bold the suggestion, even though 'view-source:x', 'view-source:x/y', and 'x.com/' would. With this CL, all those examples will bold their suggestions. The reason these cases failed previously was because they have Worth noting, the "url-what-you-typed" classification could be further simplified to simply bold the entire suggestion. However, this would produce less desirable bolding for inputs such as 'file:/' or 'view-source:/'. Both before this CL and with this CL, those inputs bold only the typed number of '/'s, i.e., '[file:/]//' and '[view-source:file:/]//' respectively. Bug: 366623 Change-Id: I5df1b55db8d76408b0d3fb4d6017c6497b17a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554058 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#648333} components/omnibox/browser/history_url_provider.cc | 26 +++++--------- .../browser/history_url_provider_unittest.cc | 42 +++++++++++----------- 2 files changed, 30 insertions(+), 38 deletions(-) commit d6a4d7f28a0b44edb36cedb8cb07a84820c44622 Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Fri Apr 5 21:07:31 2019 +0000 Removed #import <EarlGrey/EarlGrey.h> from ios/chrome/test/earl_grey/chrome_earl_grey_ui.h EG1 and EG2 do not share a common set of headers, so any file that directly includes EarlGrey.h cannot be compiled under EG2. Scrubbing the headers will enable us (in a future CL) to share these helpers between EG1 and EG2. Files that need to change was found by: git grep --files-with-matches ios/chrome/test/earl_grey/chrome_earl_grey_ui.h . | grep .m | xargs grep -L '<EarlGrey/EarlGrey.h>' All *.mm file that have chrome_earl_grey_ui.h also have chrome_earl_grey.h So it means that after http://crrev/c/1554188 only 2 files need to be changed. Bug: 922813 Change-Id: Ia8f740f30071797ea91c1047dcef582d59c05c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552161 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#648332} ios/chrome/test/earl_grey/chrome_earl_grey_ui.h | 3 ++- ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) commit dc21174461ba56cd2c8db84b908e75d2b26a4f28 Author: Aaron Colwell <acolwell@google.com> Date: Fri Apr 5 21:04:01 2019 +0000 Reverting http://crrev.com/c/1545366. Restoring |pending_state_map_| and the code that posts a task to the IO thread to destroy the SecurityState because we get a lot of RenderFrameMessageFilter::GetCookies() and RenderFrameMessageFilter::SetCookies() crashes without this. Change-Id: Ia6d483f91eda89f38779e88bf8cb17565870bfbb Bug: 943887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554407 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Auto-Submit: Aaron Colwell <acolwell@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#648331} .../browser/child_process_security_policy_impl.cc | 175 ++++++++++++-------- .../browser/child_process_security_policy_impl.h | 15 ++ .../child_process_security_policy_unittest.cc | 176 +++++++++++++++++++-- 3 files changed, 288 insertions(+), 78 deletions(-) commit ab68c05beb790d04d1cb7fd8faa0a197fb40d399 Author: Ben Kelly <wanderview@chromium.org> Date: Fri Apr 5 21:01:47 2019 +0000 CacheStorage: Move Legacy classes to separate dir. This is a follow-on to crrev.com/c/1542177 where we split CacheStorage/CacheStorageCache into separate interface and implementation classes. This CL moves the new LegacyCacheStorage and LegacyCacheStorageCache classes into separate files in a new "legacy" directory. This CL only moves code and updates include paths. It does not modify any functional code. Bug: 940449 Change-Id: I41059a3545f716042ed55a03a011264684054d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548298 Reviewed-by: Victor Costan <pwnall@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#648330} content/browser/BUILD.gn | 5 +- content/browser/cache_storage/cache_storage.cc | 1348 ------------------- content/browser/cache_storage/cache_storage.h | 294 +---- .../browser/cache_storage/cache_storage_cache.h | 490 +------ .../cache_storage/cache_storage_cache_unittest.cc | 2 +- .../browser/cache_storage/cache_storage_manager.h | 2 +- .../cache_storage/legacy/legacy_cache_storage.cc | 1357 ++++++++++++++++++++ .../cache_storage/legacy/legacy_cache_storage.h | 310 +++++ .../legacy_cache_storage_cache.cc} | 2 +- .../legacy/legacy_cache_storage_cache.h | 511 ++++++++ 10 files changed, 2187 insertions(+), 2134 deletions(-) commit 0a611f37b80a2b3ba7a3916d0408de7d2309e5cd Author: Misha Efimov <mef@chromium.org> Date: Fri Apr 5 20:59:31 2019 +0000 Disable UDPSocketTest.SharedMulticastAddress on iOS. Bug: 947115 Change-Id: I2629dc9b057697613857c9d27deb29b01a581e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545708 Auto-Submit: Misha Efimov <mef@chromium.org> Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648329} net/socket/udp_socket_unittest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 1d172268ba9d21e2c9c16bf19f835dd02f225617 Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Apr 5 20:55:54 2019 +0000 IDL: Replace implemented [NoInterfaceObject] with mixin Historically, we used [NoInterfaceObject] and 'implements' to make interface mixins. Now interface mixin was supported. So let's replace them. All interfaces updated in this CL are defined to be mixins in specs. This CL also disables to 'impelemnt' [NoInterfaceObject] interfaces. Note: We are still using 'implements' which needs to be replaced with 'includes'. Bug: 781257 Change-Id: I754ec1047b8e4944d95dcc0103d0afafb1cabf67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552206 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#648328} .../renderer/bindings/scripts/interface_dependency_resolver.py | 3 +-- third_party/blink/renderer/core/css/font_face_source.idl | 5 ++--- third_party/blink/renderer/core/dom/accessibility_role.idl | 3 +-- third_party/blink/renderer/core/dom/aria_attributes.idl | 3 +-- third_party/blink/renderer/core/dom/child_node.idl | 5 ++--- .../renderer/core/dom/document_and_element_event_handlers.idl | 5 ++--- third_party/blink/renderer/core/dom/document_or_shadow_root.idl | 5 ++--- third_party/blink/renderer/core/dom/global_event_handlers.idl | 5 ++--- .../blink/renderer/core/dom/non_document_type_child_node.idl | 5 ++--- third_party/blink/renderer/core/dom/non_element_parent_node.idl | 5 ++--- third_party/blink/renderer/core/dom/nonced_element.idl | 4 +--- third_party/blink/renderer/core/dom/parent_node.idl | 5 ++--- third_party/blink/renderer/core/fetch/body.idl | 5 ++--- .../blink/renderer/core/frame/navigator_automation_information.idl | 7 +++---- .../blink/renderer/core/frame/navigator_concurrent_hardware.idl | 5 ++--- third_party/blink/renderer/core/frame/navigator_cookies.idl | 3 +-- third_party/blink/renderer/core/frame/navigator_device_memory.idl | 5 ++--- third_party/blink/renderer/core/frame/navigator_id.idl | 3 +-- third_party/blink/renderer/core/frame/navigator_language.idl | 5 ++--- third_party/blink/renderer/core/frame/navigator_on_line.idl | 3 +-- third_party/blink/renderer/core/frame/navigator_user_agent.idl | 4 ++-- third_party/blink/renderer/core/frame/window_event_handlers.idl | 5 ++--- .../blink/renderer/core/frame/window_or_worker_global_scope.idl | 3 +-- .../blink/renderer/core/html/html_hyperlink_element_utils.idl | 4 +--- .../renderer/core/svg/svg_filter_primitive_standard_attributes.idl | 4 +--- third_party/blink/renderer/core/svg/svg_fit_to_view_box.idl | 4 +--- third_party/blink/renderer/core/svg/svg_tests.idl | 4 +--- third_party/blink/renderer/core/svg/svg_uri_reference.idl | 4 +--- third_party/blink/renderer/core/svg/svg_zoom_and_pan.idl | 4 +--- third_party/blink/renderer/core/workers/abstract_worker.idl | 3 +-- third_party/blink/renderer/modules/canvas/canvas2d/canvas_path.idl | 4 +--- .../renderer/modules/credentialmanager/credential_user_data.idl | 3 +-- .../modules/webgl/webgl2_compute_rendering_context_base.idl | 4 +--- .../blink/renderer/modules/webgl/webgl2_rendering_context_base.idl | 4 +--- .../blink/renderer/modules/webgl/webgl_rendering_context_base.idl | 7 +------ 35 files changed, 51 insertions(+), 99 deletions(-) commit 8b5f6a79bed95e04136092b369cf36528f43a9ab Author: Maks Orlovich <morlovich@chromium.org> Date: Fri Apr 5 20:52:41 2019 +0000 Blockfile cache: fix EntryImpl field destruction order. The order was wrong in that sparse_ destruction should happen before net_log_ destruction since ~SparseControl can touch the netlog. The default order generally didn't matter since ~EntryImpl normally destroys sparse_ manually --- except it fails to do so when the backend is already dead. (There are a lot of other things going wrong here --- in particular some writes are just dropped on the floor since EntryImpl::WriteData doesn't work past ~BackendImpl --- and the semantics of the backend destructor in blockfile in generally are messy and also largely in an unrealistic mode in unit tests --- but that's no reason to have a silly UaF, is it?). Bug: 947757 Change-Id: I9d4bb994c5f4ada1a073882f31671feb25b2be1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554290 Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#648327} net/disk_cache/blockfile/entry_impl.h | 5 +++-- net/disk_cache/entry_unittest.cc | 30 ++++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 2 deletions(-) commit 282db7945e8bd9dd8f13865ecb78efe3bed7b685 Author: Paul Meyer <paulmeyer@chromium.org> Date: Fri Apr 5 20:50:58 2019 +0000 Sniff real MIME types of images to enforce unoptimized image policies. This patch adds a function to sniff the real MIME types of images in image_decoder. This function will be used by the unoptimized images feature policies in order to determine the which policy to enforce for each image. Bug: 943203 Change-Id: I40b296a32bf49e0aa4a2e5ee9656a73eec5984ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551483 Reviewed-by: Leon Scroggins <scroggo@chromium.org> Reviewed-by: Chris Blume <cblume@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648326} .../core/loader/resource/image_resource_content.cc | 28 +++++++++++++++------- .../platform/image-decoders/image_decoder.cc | 25 +++++++++++++++++++ .../platform/image-decoders/image_decoder.h | 3 +++ 3 files changed, 47 insertions(+), 9 deletions(-) commit 881ecfecade55008a5d0370f98afdc5cab49717c Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 20:49:06 2019 +0000 Import wpt@c3c423be44cc049b7bf951ca3c755afd72a8d0ec Using wpt-import in Chromium a9df9320602c191f7f2c0e245fb77482f4eabbf6. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874cf2 "[WPT] Fix JSON decoding errors in referrer-policy on Safari" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I0fd8d8c3e4c0e4dd9756d1749b8942f6daa755b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554838 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648325} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 22 ++++++++-------- .../events/EventTarget-dispatchEvent-expected.txt | 29 ++++++++++++++++++++++ .../wpt/dom/events/EventTarget-dispatchEvent.html | 4 +-- 3 files changed, 42 insertions(+), 13 deletions(-) commit d8d6676b74dfd8de29b3711db17b433b816cc70d Author: Aran Gilman <gilmanmh@google.com> Date: Fri Apr 5 20:48:05 2019 +0000 Add tests for color inversion of SVG images when inverting all images. These tests cover darkModeImagePolicy=0 (invert all images). A follow-up CL will add tests for darkModeImagePolicy=2 (selectively invert images). Bug: 936905, 947434 Change-Id: I3199b5884abb2524f754178896f92720e9f48bab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546512 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#648324} third_party/blink/web_tests/VirtualTestSuites | 5 +++++ .../paint/dark-mode/svg-invert-all/resources/circle.svg | 3 +++ .../paint/dark-mode/svg-invert-all/svg-as-image.html | 2 ++ .../paint/dark-mode/svg-invert-all/svg-in-html.html | 4 ++++ .../dark-mode/svg-invert-all/svg-as-image-expected.png | Bin 0 -> 21631 bytes .../dark-mode/svg-invert-all/svg-in-html-expected.png | Bin 0 -> 21631 bytes .../dark-mode/svg-invert-all/svg-as-image-expected.png | Bin 0 -> 21249 bytes .../dark-mode/svg-invert-all/svg-in-html-expected.png | Bin 0 -> 20910 bytes .../dark-mode/svg-invert-all/svg-as-image-expected.png | Bin 0 -> 21877 bytes .../dark-mode/svg-invert-all/svg-in-html-expected.png | Bin 0 -> 21877 bytes .../dark-mode/svg-invert-all/svg-as-image-expected.png | Bin 0 -> 21854 bytes .../dark-mode/svg-invert-all/svg-in-html-expected.png | Bin 0 -> 21627 bytes .../dark-mode/paint/dark-mode/svg-invert-all/README.txt | 3 +++ 13 files changed, 17 insertions(+) commit 692c172303068af96e29bc43aaf0a0c93f0028fc Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 20:47:33 2019 +0000 Roll src/third_party/catapult 9057b413d4b1..27980609ac44 (7 commits) https://chromium.googlesource.com/catapult.git/+log/9057b413d4b1..27980609ac44 git log 9057b413d4b1..27980609ac44 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 benjhayden@chromium.org Migrate place-holder from dom-module to Polymer.html 2019-04-05 benjhayden@chromium.org Migrate cp-dialog from dom-module to Polymer.html 2019-04-05 benjhayden@chromium.org Migrate cp-input from dom-module to Polymer.html 2019-04-05 benjhayden@chromium.org Migrate cp-toast from dom-module to Polymer.html 2019-04-05 benjhayden@chromium.org Migrate expand-button from dom-module to Polymer.html 2019-04-05 nazabris@microsoft.com [Tracing] Fix flow arrows for large traces 2019-04-05 bmeurer@chromium.org Add grouping for Maps and DescriptorArrays. Created with: gclient setdep -r src/third_party/catapult@27980609ac44 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:950011,chromium:950011,chromium:950011,chromium:950011 TBR=crouleau@chromium.org Change-Id: I69bd84f1cbe0e30f029847cfb4e8c6e8ea685cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554590 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648323} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1ba32483ecd2179bde8e27239fa68dd8262768bb Author: Caitlin Fischer <caitlinfischer@google.com> Date: Fri Apr 5 20:43:44 2019 +0000 [Autofill] Adds ability to show new label formats. This happens when the autofill-use-improved-label-disambiguation flag is enabled on the following kinds of forms: address, address plus phone, address plus email, and contact. This does not happen on address plus contact forms. When I delete a few fields so that the form is one of aforementioned types, this is what appears when the name field is focused: https://screenshot.googleplex.com/nPMuzDRpo3S. Bug: 949957 Change-Id: I200645396a37cd09811129f3e1fdbcc2afc45791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554047 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#648322} components/autofill/core/browser/BUILD.gn | 1 - .../autofill/core/browser/label_formatter.cc | 3 +- .../autofill/core/browser/personal_data_manager.cc | 27 +++-- .../core/browser/personal_data_manager_unittest.cc | 111 +++++++++++++++++++++ .../autofill/core/browser/suggestion_selection.cc | 10 ++ .../autofill/core/browser/suggestion_selection.h | 6 ++ 6 files changed, 144 insertions(+), 14 deletions(-) commit 0b6b686113946a50dbee281f8e8cd8c8524a0ed2 Author: Justin DeWitt <dewittj@chromium.org> Date: Fri Apr 5 20:42:10 2019 +0000 [Touchless] Fix compile of NoTouchActivityTest ThreadUtils -> TestThreadUtils Change-Id: Ic93894b71e5385cf7b93b381d9d90bdb8c000144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555234 Auto-Submit: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#648321} .../org/chromium/chrome/browser/touchless/NoTouchActivityTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 07dca1401053d346e4d67814e4920199da987bb8 Author: Henrique Grandinetti <hgrandinetti@chromium.org> Date: Fri Apr 5 20:38:35 2019 +0000 Sync Parent Access Code config to known user storage. Bug: 946802 Change-Id: I2154c3499924af299a9a52bad52b86abe473ec75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542154 Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#648320} chrome/browser/chromeos/preferences.cc | 15 +++++++ chrome/common/pref_names.cc | 6 +++ chrome/common/pref_names.h | 1 + components/user_manager/known_user.cc | 72 ++++++++++++++++++++++++---------- components/user_manager/known_user.h | 16 ++++++++ 5 files changed, 89 insertions(+), 21 deletions(-) commit 157fe9aa3d54e095d99c53f401cb658f60b172fe Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 5 20:37:36 2019 +0000 Add experimental testing config for LazyFrames Adds lazyloading of cross-origin iframes feature to testing config. Bug: 937983 Change-Id: I0ce0b375d9ecef33b57e1e26ceffff61ad6951ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554100 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#648319} testing/variations/fieldtrial_testing_config.json | 15 +++++++++++++++ 1 file changed, 15 insertions(+) commit e138574c55b60a5d3fa8c46481428c70ce27f0a7 Author: Christopher Cameron <ccameron@chromium.org> Date: Fri Apr 5 20:37:25 2019 +0000 Remove unused app flags and features and entrails Remove unused app flags and features: * features::kBookmarkApps * switches::kDisableHostedAppsInWindows, switches::kEnableHostedAppsInWindows - Were macOS-only to disable creating bookmark apps, or to disable opening bookmark apps in windows. - This feature is now enabled on all platforms. * switches::kDisableMacViewsNativeAppWindows, switches::kDisableAppInfoDialogMac, switches::kEnableAppInfoDialogMac - These were never actually queried. Remove the entrails of these features: * CanHostedAppsOpenInWindows - Now always returns true. * IsNewBookmarkAppsEnabled - Now always returns true. Remove from about:flags the following features, but do not remove the features themselves: * features::kCreateAppWindowsInAppShimProcessName - This may still be useful for debugging RemoteMacViews issues TBR=benwells Bug: 937166 Change-Id: Ie19fdbbc85b0115f53e295f5d61eeb8e523bafa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551574 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#648318} chrome/browser/about_flags.cc | 12 ----- .../app_shim/app_shim_interactive_uitest_mac.mm | 8 ---- .../apps/platform_apps/platform_app_launch.cc | 7 --- .../management/chrome_management_api_delegate.cc | 9 ---- .../management/chrome_management_api_delegate.h | 2 - .../api/management/management_apitest.cc | 19 ++------ chrome/browser/extensions/extension_util.cc | 20 -------- chrome/browser/extensions/extension_util.h | 10 ---- chrome/browser/extensions/launch_util.cc | 22 ++------- chrome/browser/extensions/tab_helper.cc | 19 +++----- chrome/browser/resources/ntp4/apps_page.js | 23 +++------- .../ui/app_list/extension_app_context_menu.cc | 27 ++++------- .../launcher/extension_launcher_context_menu.cc | 13 ++---- .../ui/ash/launcher/launcher_controller_helper.cc | 14 +++--- chrome/browser/ui/browser_browsertest.cc | 14 ++---- chrome/browser/ui/browser_command_controller.cc | 7 +-- .../app_shim_menu_controller_mac_browsertest.mm | 9 ---- .../ui/extensions/hosted_app_browsertest.cc | 3 -- .../startup/startup_browser_creator_browsertest.cc | 9 ++-- chrome/browser/ui/toolbar/app_menu_model.cc | 7 +-- .../app_info_dialog_views_browsertest.cc | 12 ----- .../apps/app_info_dialog/app_info_summary_panel.cc | 53 ++++------------------ .../extensions/bookmark_app_confirmation_view.cc | 18 +++----- chrome/browser/ui/views/toolbar/toolbar_view.cc | 4 +- chrome/browser/ui/webui/ntp/ntp_resource_cache.cc | 7 --- chrome/common/chrome_features.cc | 6 --- chrome/common/chrome_features.h | 4 -- chrome/common/chrome_switches.cc | 17 ------- chrome/common/chrome_switches.h | 5 -- .../browser/api/management/management_api.cc | 10 +--- .../api/management/management_api_delegate.h | 8 ---- 31 files changed, 67 insertions(+), 331 deletions(-) commit da15621ef5d721af63de8c4f0b013617abfeac0d Author: danakj <danakj@chromium.org> Date: Fri Apr 5 20:34:43 2019 +0000 Reland "Move RequestDecode and RequestPresentationCallback from WebLayerTreeView (8/n)" This is a reland of 07221eb8f25da04080febdc4f18e306eb6d612a5 Original change's description: > Move RequestDecode and RequestPresentationCallback from WebLayerTreeView (8/n) > > The RequestDecode() method moves to WebWidgetClient, and is implemented > in RenderWidget. > > The RequestPresentationCallback() is removed, and a method is added as > WebWidgetTestProxy::RequestCompositeAndPresentation() for test_runner to use > instead. It acts like RequestPresentation() but forces the scheduled sync > composite to run the full compositor stack instead of just the main frame > animation step. > > This removes the LayerTreeView::SynchronouslyComposite() method and > changes callers to it to call WebWidgetTestProxy::ScheduleAnimation() > instead of duplicating that logic out in production code. > > This moves ~60 lines of production code into content/shell/test_runner/ > to remove them from chrome.exe, as well as straight up removing another > ~80 lines of production code. Now RenderWidget and LayerTreeView > have no concept of synchronous composites, as they are entirely > managed by WebWidgetTestProxy. > > We now have only one caller of LayerTreeHost::Composite() in web tests > instead of previously having 4. > > R=dcheng@chromium.org > > Bug: 912193 > Change-Id: I26cd9cbbe503e9b876a146f2eebccbf8e9121190 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544820 > Commit-Queue: Philip Rogers <pdr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Auto-Submit: danakj <danakj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645998} Bug: 912193 Change-Id: I33a171a7efa054d716fa9f31432734c500557bb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549414 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#648317} content/renderer/compositor/layer_tree_view.cc | 66 ------------ content/renderer/compositor/layer_tree_view.h | 19 ---- .../compositor/layer_tree_view_unittest.cc | 3 +- content/renderer/render_widget.cc | 16 +-- content/renderer/render_widget.h | 14 ++- .../shell/renderer/web_test/blink_test_runner.cc | 13 ++- content/shell/test_runner/test_runner.cc | 32 +++--- content/shell/test_runner/test_runner.h | 3 +- .../test_runner/test_runner_for_specific_view.cc | 2 +- content/shell/test_runner/web_test_runner.h | 16 ++- content/shell/test_runner/web_widget_test_proxy.cc | 117 +++++++++++++++++---- content/shell/test_runner/web_widget_test_proxy.h | 19 ++++ .../blink/public/platform/web_layer_tree_view.h | 12 --- third_party/blink/public/web/web_widget.h | 6 -- third_party/blink/public/web/web_widget_client.h | 7 ++ .../blink/renderer/core/exported/web_view_impl.cc | 5 - .../blink/renderer/core/exported/web_view_impl.h | 2 - .../renderer/core/frame/web_frame_widget_base.cc | 7 +- 18 files changed, 194 insertions(+), 165 deletions(-) commit 79b7efd18bc7f0d329f8588a0d75f7d2f21d1450 Author: siyua <siyua@chromium.org> Date: Fri Apr 5 20:33:20 2019 +0000 [AF][Paradise] Refactor Setting's Page Button Prerequisites checks This CL was reverted (crrev.com/c/1524716) as it broke the Guest window setting's page since Guest window does not have a profile. Fix it by returning is_guest_mode before checking if migration is enabled. Bug: 897998 Change-Id: Ib7098506688c363d8200010435e5c45ad0e3396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554109 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#648316} .../settings/autofill_page/payments_section.html | 2 +- .../settings/autofill_page/payments_section.js | 137 +-------------- .../md_settings_localized_strings_provider.cc | 59 ++----- .../data/webui/settings/payments_section_test.js | 195 +-------------------- 4 files changed, 24 insertions(+), 369 deletions(-) commit f7d34072328824864ec3aed5bc514d841c7adf94 Author: Francois Doray <fdoray@chromium.org> Date: Fri Apr 5 20:28:50 2019 +0000 Update //components/README.md. Chrome developers don't have a shared understanding of the purpose of //components and what dependencies from/on //components are allowed. This CL solves that problem by updating the README file of //components. See discussion https://groups.google.com/a/chromium.org/d/msg/chromium-dev/f2u9klk8W1w/gbiO7p0rAwAJ Change-Id: I2722967e6a374f106325ccccf3e8d6c9d58e27e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549603 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#648315} components/README | 56 --------------------------- components/README.md | 104 +++++++++++++++++++++++++++++++++++++++++++++++++++ content/DEPS | 2 +- 3 files changed, 105 insertions(+), 57 deletions(-) commit 35137a85d0d0d21780950436a804ee9834b38d46 Author: Dan Rubery <drubery@chromium.org> Date: Fri Apr 5 20:28:17 2019 +0000 Reland "Add browser test for Safe Browsing Hash computation" This reverts commit 6433110604fee53caaaf7d6f21be728b40574454, relanding commit 3459ca5a7d7081c8b09581c079a2cc17d825f113. The test was flaky due to doing a poor job tracking the number of completed/pending downloads, so it would try to verify the expectations before the download had actually completed. I changed this test to use some testing utils provided by the downloads team, which seem to be more reliable. Bug: 948282 Change-Id: I99f244b92ffd103ca0de049b8901d58f75a0e681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554193 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#648314} .../download_protection_service_browsertest.cc | 121 +++++++++++++++++++++ chrome/test/BUILD.gn | 1 + .../download_protection/zipfile_two_archives.zip | Bin 0 -> 276 bytes .../data/safe_browsing/rar/has_two_archives.rar | Bin 0 -> 122 bytes .../safe_browsing/web_ui/safe_browsing_ui.cc | 19 ++-- components/safe_browsing/web_ui/safe_browsing_ui.h | 5 + 6 files changed, 137 insertions(+), 9 deletions(-) commit a29696705e370b3475393f0ff2698820c444095f Author: Lucas Tenório <ltenorio@chromium.org> Date: Fri Apr 5 20:24:18 2019 +0000 Add unit tests for the AppControllerService. This is the first batch of tests covering the AppControllerService and its interaction with the AppServiceProxy and the ArcAppListPrefs. For the moment we are only testing the GetApps() method and what it returns, the next steps will be to: - Implement a fake AppControllerClient to receive app updates and check if they are receiving those as expected. - Use a mock/fake version of the AppServiceProxy to test the Launch and Uninstall methods. This depends on http://crrev/c/1552211. - Implement tests for the LaunchHomeUrl and GetAndroidId methods. Bug: 927809 Change-Id: I5f2244784eee056856c3b716acb66487d7f9852e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553203 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#648313} chrome/browser/chromeos/BUILD.gn | 1 + .../app_controller_service_unittest.cc | 330 +++++++++++++++++++++ 2 files changed, 331 insertions(+) commit 16d540bd4fc27a7931a0aec3f092e7b90e580a11 Author: Yi Gu <yigu@chromium.org> Date: Fri Apr 5 20:22:20 2019 +0000 [Code Health] Disable flaky web test on Win7 This is reported via Findit: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVybgsSBUZsYWtlImNjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQtY3Jvc3Mtb3JpZ2luLXN0YWNrLW92ZXJmbG93Lmh0bWwM TBR=tsepez@chromium.org Bug: 937546 Change-Id: I41737b5c06506f04e3724fd640f6c3ddc653ddcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553932 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648312} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit 930fdcac4e9a63ec7c38cf32c8fef15ab4f0b553 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 20:21:47 2019 +0000 Roll src/third_party/skia 774aeba9d0eb..c7755d947084 (3 commits) https://skia.googlesource.com/skia.git/+log/774aeba9d0eb..c7755d947084 git log 774aeba9d0eb..c7755d947084 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 kjlubick@google.com [canvaskit] Bump GPU resource cache to 256MB 2019-04-05 mtklein@google.com update SkMallocPixelRef docs 2019-04-05 kjlubick@google.com [CanvasKit] Add basic support for SkPicture Created with: gclient setdep -r src/third_party/skia@c7755d947084 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: Ia9e1c0da1e1ebff2f29b5f467fb5da8ab910b323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554414 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648311} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8de17c3b7a09b90e6af33355515b14c113943e74 Author: sczs <sczs@chromium.org> Date: Fri Apr 5 20:21:06 2019 +0000 [ios] Calculates the InfobarBanner presentation container height dynamically. - Updates InfobarBannerVC so the size of its view its driven by the intrinsic content size of the labels. - InfobarBannerPresentationController uses the intrinsic size of the InfobarBanner to calculate its height. This helps size the banner correctly for multi-line labels or when using larger fonts in dynamic type. Screenshots: https://drive.google.com/open?id=1xEjxOZH8pyHhAE0Q6xII-PgAXChdgPZ4 https://drive.google.com/open?id=1kAn_Z1yxVabuKhtDhWn2mq8qhRY0J9D1 https://drive.google.com/open?id=1cRgiZI57F56zev_pm8ton2oquFw942dd Bug: 911864 Change-Id: I26f19750109879656dc6c26da1afd6fef5984477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553946 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648310} .../banners/infobar_banner_view_controller.mm | 13 +++++---- .../infobars/coordinators/infobar_coordinator.mm | 4 +++ .../presentation/infobar_banner_positioner.h | 5 ++++ .../infobar_banner_presentation_controller.mm | 32 +++++++++++++--------- .../infobars/sc_infobar_banner_coordinator.mm | 22 ++++++++++++++- 5 files changed, 56 insertions(+), 20 deletions(-) commit 7a84687985b3e1bde0d5a46f4747f1377d66170b Author: Kyle Horimoto <khorimoto@chromium.org> Date: Fri Apr 5 20:19:18 2019 +0000 [CrOS Cellular] Add skeleton cellular activation UI. This UI is the update to the original UI and is only displayed when the kUpdatedCellularActivationUi flag is enabled. This CL: (1) Adds cellular_setup_resources.grd which includes the dialog's HTML source and updates build files which use these new resources. (2) Adds a dialog class and WebUIController for this UI and integrates it with ChromeWebUIControllerFactory. (3) Adds debug UI in chrome://network which launches the activation UI in a dialog. Bug: 948942 Change-Id: I0ee4eae37c048dcb39cafa9a6b9eda40bcf3f152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553041 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#648309} chrome/BUILD.gn | 1 + chrome/app/chromeos_strings.grdp | 9 ++ chrome/browser/resources/chromeos/BUILD.gn | 13 +++ .../resources/chromeos/cellular_setup/OWNERS | 2 + .../cellular_setup/cellular_setup_dialog.html | 23 +++++ .../cellular_setup/cellular_setup_resources.grd | 25 ++++++ .../chromeos/cellular_setup/i18n_setup.html | 3 + .../resources/chromeos/network_ui/network_ui.html | 14 +++ .../resources/chromeos/network_ui/network_ui.js | 21 ++++- chrome/browser/ui/BUILD.gn | 4 + .../ui/webui/chrome_web_ui_controller_factory.cc | 3 + .../cellular_setup/cellular_setup_dialog.cc | 99 ++++++++++++++++++++++ .../cellular_setup/cellular_setup_dialog.h | 48 +++++++++++ .../cellular_setup_dialog_launcher.cc | 12 ++- .../cellular_setup_localized_strings_provider.cc | 38 +++++++++ .../cellular_setup_localized_strings_provider.h | 30 +++++++ chrome/browser/ui/webui/chromeos/network_ui.cc | 38 ++++++++- chrome/chrome_paks.gni | 2 + chrome/common/webui_url_constants.cc | 2 + chrome/common/webui_url_constants.h | 2 + tools/gritsettings/resource_ids | 4 +- 21 files changed, 385 insertions(+), 8 deletions(-) commit 372b7b3757d4f3e4072d8c8c2ed129009f64298f Author: Saman Sami <samans@chromium.org> Date: Fri Apr 5 20:18:57 2019 +0000 Enable 3 GLOnlyRendererPixelTest for SkiaRenderer Two are already working and one only needs a fuzzy comparator. The remaining 2 GLOnlyRendererPixelTest that still cannot be enabled are annotated with the reason they're failing. Bug: 939442, 924565 Change-Id: I7896fc364be9403cd1f9e0d5ef0c870ad17bf5de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554837 Reviewed-by: weiliangc <weiliangc@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#648308} .../viz/service/display/renderer_pixeltest.cc | 30 +++++++++++++++++----- 1 file changed, 23 insertions(+), 7 deletions(-) commit b22a35e6e60c3cf3737c148c8eb27c08e87f36dc Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Apr 5 20:16:57 2019 +0000 JSONSchemaCompiler: Support nodoc for enum values in IDL schema files. This is useful for not generating documentation for specific enum values. BUG=947591 Change-Id: I9bd28bd9dc48a8babd02ee59e9b8b45099076736 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552295 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#648307} tools/json_schema_compiler/idl_schema.py | 2 ++ tools/json_schema_compiler/idl_schema_test.py | 19 +++++++++++++++++++ tools/json_schema_compiler/test/idl_basics.idl | 8 ++++++++ 3 files changed, 29 insertions(+) commit fcd2c80d5d3a8c8756165d3994111e10adc0cfe2 Author: Ian Clelland <iclelland@chromium.org> Date: Fri Apr 5 20:15:59 2019 +0000 Parse values in feature policy declarations. This extends the parser for feature policy declarations to include an optional "(value)" after any origin. This allows declarations such as: fullscreen 'self'(true) or more usefully, unoptimized-images 'self'(1.5) https://photos.example.com(3.0) and allows the value to be configured per-origin. Floats and bools are supported, as those are the value types which are currently implemented. Bug: 924568 Change-Id: I24b407100039b3612341c884247c298525e4ce69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1506097 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#648306} .../renderer/core/feature_policy/feature_policy.cc | 154 ++++++++-- .../core/feature_policy/feature_policy_test.cc | 338 ++++++++++++++++++++- .../parameters/feature-parameters-inf.html | 21 ++ .../parameters/feature-parameters-inf.html.headers | 1 + .../parameters/feature-parameters-with-frames.html | 44 +++ .../parameters/feature-parameters.html | 28 ++ .../parameters/feature-parameters.html.headers | 1 + .../resources/feature-parameters-frame.html | 50 +++ .../parameters/resources/sample-1.png | Bin 0 -> 428 bytes .../wpt/feature-policy/resources/featurepolicy.js | 13 + 10 files changed, 620 insertions(+), 30 deletions(-) commit 4a1b49bcce39dc5270e8cb7dde7ab926e2c5b7b0 Author: shrekshao <shrekshao@google.com> Date: Fri Apr 5 20:14:56 2019 +0000 Update CheckDrawingFeedbackLoops logic to pass conformance test Changes made on top of this old change: https://codereview.chromium.org/2461973002/ Bug: 660844 Change-Id: Ic96af6326c17467c3518a7f3de8fd799637c3daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545116 Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: James Darpinian <jdarpinian@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#648305} .../gpu_tests/webgl2_conformance_expectations.py | 5 +- .../gpu_tests/webgl_conformance_expectations.py | 13 +++- gpu/command_buffer/service/framebuffer_manager.cc | 31 +++++++- gpu/command_buffer/service/framebuffer_manager.h | 8 ++ .../service/framebuffer_manager_unittest.cc | 90 ++++++++++++++++++++++ gpu/command_buffer/service/gles2_cmd_decoder.cc | 88 ++++++++++++--------- 6 files changed, 191 insertions(+), 44 deletions(-) commit 229ba21ca8d4a42160a9a1ae34f3c26b24ff30fa Author: Kurt Horimoto <kkhorimoto@chromium.org> Date: Fri Apr 5 20:14:24 2019 +0000 [iOS] Create OverlayService model classes. The public interface of OverlayService will use OverlayRequests and OverlayResponses to hold user data used by clients to specify the types of overlays being shown by the service. OverlayRequests are used by the service to schedule the presentation of overlays. When a user interacts with overlay UI, an OverlayResponse is supplied to the OverlayRequest that triggered the UI. This response will ultimately be passed to the callback for that overlay. Each request and response is constructed with an OverlayUserData that stores client information with requests and response. OverlayRequests should be created using an OverlayUserData subclass that holds the information necessary to configure the overlay UI. OverlayResponses should be created using an OverlayUserData subclass that holds information about the user's interaction with the overlay UI. Bug: 1524991 Change-Id: Ia8472dd094e342998cda43dd9e5f8d5f037c1681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548572 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#648304} ios/chrome/browser/overlays/BUILD.gn | 52 ++++++++++++++++ ios/chrome/browser/overlays/README.md | 71 ++++++++++++++++++++++ ios/chrome/browser/overlays/overlay_request.h | 62 +++++++++++++++++++ .../browser/overlays/overlay_request_impl.cc | 28 +++++++++ ios/chrome/browser/overlays/overlay_request_impl.h | 30 +++++++++ .../browser/overlays/overlay_request_unittest.cc | 20 ++++++ ios/chrome/browser/overlays/overlay_response.h | 51 ++++++++++++++++ .../browser/overlays/overlay_response_impl.cc | 17 ++++++ .../browser/overlays/overlay_response_impl.h | 22 +++++++ .../browser/overlays/overlay_response_unittest.cc | 20 ++++++ ios/chrome/browser/overlays/overlay_user_data.h | 61 +++++++++++++++++++ ios/chrome/browser/overlays/test/BUILD.gn | 19 ++++++ .../overlays/test/fake_overlay_user_data.cc | 9 +++ .../browser/overlays/test/fake_overlay_user_data.h | 24 ++++++++ ios/chrome/test/BUILD.gn | 1 + 15 files changed, 487 insertions(+) commit 63bcf45be00466e032719c809f0e916b07466665 Author: Tarun Bansal <tbansal@chromium.org> Date: Fri Apr 5 20:12:43 2019 +0000 Enable signal strength based ECT capping Around 30-40% more previews with no significant change in opt-out rate. See the bug for details. Change-Id: I299dc5f15e32033f2f463d3b49fc3f30e157593d Bug: 924160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552573 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648303} net/nqe/network_quality_estimator_params.cc | 2 +- testing/variations/fieldtrial_testing_config.json | 22 ---------------------- 2 files changed, 1 insertion(+), 23 deletions(-) commit dbd6ce1b7818ea450913601c026b7bf863d5101e Author: Avi Drissman <avi@chromium.org> Date: Fri Apr 5 20:06:37 2019 +0000 Revert "Allow proto_library()'s proto_out_dir to be a source-root-absolute path" This reverts commit 6a2e4d995d70a670b11c65f4e23fc17705b55ed2. Reason for revert: Deterministic Linux bot is failing; this is our best guess. We believe this doesn't do the right thing for incremental builds. See bug 950052. Original change's description: > Allow proto_library()'s proto_out_dir to be a source-root-absolute path > > Also: > * Adds a disabled-behind-gn-arg check for targets that generate > .pb.cc files outside of their target_gen_dir. > This is the main motivation for the change > * Adds a public_include_dirs template arg to serve the use-case > some targets have of wanting their #include paths to look > differently. > > I hope to change the disabled check into an assert once I fix & roll > subrepos. > > Bug: 944928 > Change-Id: Ib8157b7a5cb653fafaf751661bf979fe4b3c6152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535535 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jonathan Metzman <metzman@chromium.org> > Auto-Submit: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648186} TBR=thakis@chromium.org,agrieve@chromium.org,metzman@chromium.org Change-Id: I960fd7e87b04953f4b75e58dde346699f71925db No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 944928, 950052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555046 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648302} testing/libfuzzer/fuzzers/BUILD.gn | 2 +- .../fuzzers/javascript_parser_proto_fuzzer.cc | 2 +- .../fuzzers/javascript_parser_proto_to_string.h | 2 +- testing/libfuzzer/proto/BUILD.gn | 5 +- .../src/google/cacheinvalidation/BUILD.gn | 3 +- third_party/protobuf/proto_library.gni | 99 +++++----------------- tools/traffic_annotation/auditor/BUILD.gn | 2 + ui/accessibility/BUILD.gn | 5 +- 8 files changed, 35 insertions(+), 85 deletions(-) commit 9e6da53e23fdacbe835c0dfd995dee8497991cd1 Author: Collin Baker <collinbaker@chromium.org> Date: Fri Apr 5 19:59:45 2019 +0000 Revert "Move SeparatorView into its own file" This reverts commit 172df5f36a2167a7b945ff97cd6e9b9b5b7437d0. Reason for revert: <INSERT REASONING HERE> Original change's description: > Move SeparatorView into its own file > > SeparatorView paints a separator for IconLabelBubbleView in certain > cases. This moves it into its own file and loosens the coupling > between the two, while trying not to change any behavior (yet). > > This is in preparation for moving the separator out of > IconLabelBubbleView entirely. > > Bug: 946293 > Change-Id: Ia3b7c9c51c781dc75a7bcb33064d8cf0dc8c44ea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540682 > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Auto-Submit: Collin Baker <collinbaker@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#645150} TBR=bsep@chromium.org,collinbaker@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 946293 Change-Id: I874381204cd63d11b63c740a84556b3656d9f3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553934 Reviewed-by: Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#648301} chrome/browser/ui/BUILD.gn | 2 - .../views/location_bar/icon_label_bubble_view.cc | 136 +++++++++++++-------- .../ui/views/location_bar/icon_label_bubble_view.h | 32 ++++- .../icon_label_bubble_view_unittest.cc | 1 - .../location_bar/location_bar_separator_view.cc | 64 ---------- .../location_bar/location_bar_separator_view.h | 47 ------- 6 files changed, 111 insertions(+), 171 deletions(-) commit 04f4bdc299b98a4082400c93979e85dede0cfbb2 Author: Chris Cunningham <chcunningham@chromium.org> Date: Fri Apr 5 19:56:44 2019 +0000 Have WebContentDecryptionModuleAccessImpl::Create() return unique_ptr Small modernization to clarify semantics and avoid base::WrapUnique() calls downstream. Change-Id: I12ce3c1f08531c7fcf357a4d723f1cdeff64d036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553871 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648300} media/blink/webcontentdecryptionmoduleaccess_impl.cc | 4 ++-- media/blink/webcontentdecryptionmoduleaccess_impl.h | 17 +++++++++-------- media/blink/webmediacapabilitiesclient_impl.cc | 4 ++-- .../blink/public/platform/web_encrypted_media_request.h | 6 ++++-- .../navigator_request_media_key_system_access.cc | 7 ++++--- .../blink/renderer/platform/encrypted_media_request.h | 5 ++++- .../platform/exported/web_encrypted_media_request.cc | 4 ++-- 7 files changed, 27 insertions(+), 20 deletions(-) commit d3b3ab90a1f2f625a64c55e1c55c5b342b84b09f Author: Ken Rockot <rockot@google.com> Date: Fri Apr 5 19:55:49 2019 +0000 [mojo-core] Add the concept of port slots Ports are the two-way relocatable messaging endpoints used as a backing for Mojo message pipe handles. Each port is essentially a message- receiving queue, and the mutual independence of each port's queue is fundamental to a port's ability to be relocated efficiently and thus be suitable to support message pipes. This CL introduces the concept of "slots" on an individual port, effectively allowing for messages in the port's queue to be routed to different consumers referencing the port. Messages are now sent on a specific slot by the sender, and received on a corresponding peer slot on the peer port. If multiple messages are received for different slots on a port, they still must be read (and are still only exposed) in sequential order. This is a precursor to supporting shared message ordering across multiple independent message pipes in Mojo, a feature which will ultimately replace the bindings concept of "associated interfaces". See bug for design doc link. Bug: 941809 Change-Id: I84e6f35831d918178e9eb2cc32c8701d1808e4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538778 Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#648299} mojo/core/node_controller.cc | 8 +- mojo/core/node_controller.h | 2 +- mojo/core/ports/BUILD.gn | 2 + mojo/core/ports/event.cc | 53 +++- mojo/core/ports/event.h | 56 +++++ mojo/core/ports/message_queue.cc | 121 ++++++--- mojo/core/ports/message_queue.h | 62 ++++- mojo/core/ports/node.cc | 513 +++++++++++++++++++++++++++----------- mojo/core/ports/node.h | 89 ++++++- mojo/core/ports/node_delegate.h | 8 +- mojo/core/ports/port.cc | 21 ++ mojo/core/ports/port.h | 33 ++- mojo/core/ports/ports_unittest.cc | 417 ++++++++++++++++++++++++++++++- mojo/core/ports/slot_ref.cc | 28 +++ mojo/core/ports/slot_ref.h | 43 ++++ 15 files changed, 1243 insertions(+), 213 deletions(-) commit 303aecdffa3365f19f2c8aa3c3806ff459cc6d30 Author: Scott Chen <scottchen@chromium.org> Date: Fri Apr 5 19:46:47 2019 +0000 removing scottchen@chromium.org from OWNERS I won't be on the Chrome team anymore, removing myself from OWNERS so I don't accidentally delay people's CLs :) Bug: None Change-Id: If2ad520a75b0bc385f4b20b81bf8cbef66b9c0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553651 Auto-Submit: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#648298} chrome/browser/resources/welcome/OWNERS | 1 - chrome/browser/ui/webui/welcome/OWNERS | 1 - components/country_codes/OWNERS | 1 - third_party/node/OWNERS | 1 - third_party/polymer/OWNERS | 1 - ui/webui/PLATFORM_OWNERS | 1 - ui/webui/resources/cr_elements/OWNERS | 1 - 7 files changed, 7 deletions(-) commit 7d98b2a03a0f146cdb7b8cd7acff0329ccd5cf93 Author: Toni Barzic <tbarzic@chromium.org> Date: Fri Apr 5 19:44:55 2019 +0000 Fix powerwash flow for views base login Check for showing powerwash and enable debugging dialogs on boot were only handled in response to signin screen loads from web UI login implementation (on gaia screen load, and account picker load). This replaces check during account picker show with a check in login display host mojo, just before the login display view is initialized. (The account picker web UI is not generally expected to show on startup). BUG=944345 Change-Id: I1fa41fb64a3ba8c900e29695f47277c679581471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554830 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#648297} .../chromeos/login/ui/login_display_host_mojo.cc | 31 ++++++++++++++++++++++ .../chromeos/login/ui/login_display_host_mojo.h | 4 +++ 2 files changed, 35 insertions(+) commit d285bff60abcadb66ac3c9611c3ccc5fe1775f02 Author: Koji Ishii <kojii@chromium.org> Date: Fri Apr 5 19:41:44 2019 +0000 [LayoutNG] Fix |ForceLayout()| not mark container's |NeedsCollectInlines| This patch fixes |LayoutObject::ForceLayout()| not to mark |NeedsCollectInlines|. This fix not only prevents crashes, but also reduces the number of |CollectInlines| from 5 to 3, for the test case in issue 948587. Bug: 948587 Change-Id: If218978790af4ba0492e0d0b8fc5b8d011da63b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554469 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#648296} third_party/blink/renderer/core/layout/layout_object.cc | 1 - .../core/layout/ng/inline/ng_inline_node_test.cc | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) commit 9812e7c8aa3841ee9e02d4e142b4e44f5074418c Author: Antonio Gomes <tonikitoo@igalia.com> Date: Fri Apr 5 19:33:35 2019 +0000 Factor out blink::VideoTrackAdapterSettings out of video_track_adapter.cc/h This CL is a preparation for moving blink::VideoTrackAdapter out of the Blink exposed API. VideoTrackAdapter class is not used by out of blink apart from VideoTrackAdapter::CalculateDesiredSize, a static/public method only used by tests in [1]. On the other hand, blink::VideoTrackAdapterSettings also defined in the same public file (public/web/modules/mediastream/video_track_adapter.h) is used by //content. This CL a preparation CL that factor out blink::VideoTrackAdapterSettings out of video_track_adapter.h|cc, as a preparation to stop exposing VideoTrackAdapter as part of Blink's public API altogether. Next, both [1] and video_track_adapter.h will be moved down to third_party/blink/renderer/modules/mediastream/. [1] //content/renderer/media/stream/video_track_adapter_unittest.cc R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org BUG=949956,919392 Change-Id: I420d1be033ca1acf30cf407518578f5569c08fc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554900 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#648295} .../media/stream/apply_constraints_processor.h | 2 +- .../stream/media_stream_video_source_unittest.cc | 2 +- .../stream/media_stream_video_track_unittest.cc | 2 +- .../media/stream/mock_media_stream_registry.cc | 2 +- .../stream/user_media_client_impl_unittest.cc | 1 + .../media/stream/video_track_adapter_unittest.cc | 1 + .../media_stream_video_webrtc_sink_unittest.cc | 2 +- third_party/blink/public/BUILD.gn | 1 + .../mediastream/media_stream_constraints_util.h | 2 +- .../web/modules/mediastream/video_track_adapter.h | 53 ++------------- .../mediastream/video_track_adapter_settings.h | 77 ++++++++++++++++++++++ .../blink/renderer/modules/mediastream/BUILD.gn | 1 + .../media_stream_video_capturer_source_test.cc | 2 +- .../modules/mediastream/video_track_adapter.cc | 45 +------------ .../mediastream/video_track_adapter_settings.cc | 56 ++++++++++++++++ 15 files changed, 151 insertions(+), 98 deletions(-) commit ce344e32af16d35cfd1a03bf37ccddd7a1b9753b Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 5 19:31:29 2019 +0000 [remoting][FTL] Separate callbacks in StartReceivingMessages() This CL separates callback being passed to StartReceivingMessages() into an on_ready callback that is called whenever the stream is ready, and an on_closed callback whenever the stream fails to start or is closed. Previously there is no way to get notified when the stream is first started then get closed. This allows FtlSignalStrategy to handle stream failure after the stream is started. Bug: 947337 Change-Id: I65220ad98cd188a5e9cedf918b8a38beb90e8438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553385 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#648294} .../signaling/ftl_message_reception_channel.cc | 33 ++++++++---- remoting/signaling/ftl_message_reception_channel.h | 9 ++-- .../ftl_message_reception_channel_unittest.cc | 63 +++++++++++++--------- remoting/signaling/ftl_messaging_client.cc | 6 ++- remoting/signaling/ftl_messaging_client.h | 9 ++-- .../signaling/ftl_messaging_client_unittest.cc | 17 +++--- remoting/signaling/message_reception_channel.h | 10 ++-- remoting/test/ftl_services_playground.cc | 40 ++++++++++---- remoting/test/ftl_services_playground.h | 6 ++- 9 files changed, 128 insertions(+), 65 deletions(-) commit 732a8dcd8c71656bc7750969ff8f7913b1ef8bdf Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 5 19:23:28 2019 +0000 Reland "Fix quic webdriver test" This is a reland of 4e001d88abace91d72273268bfc9545bfb8dd1da crbug.com/950008 disables the failing tests, and this CL is not the culprit. Original change's description: > Fix quic webdriver test > > Net.QuicAlternativeProxy.* histogram is not recorded with servicification. > So that check is removed in the test. The DataReductionProxy.Quic.ProxyStatus > histogram used in the test should be sufficient. > > Bug: 934875 > Change-Id: I1cdb16e347bd4cf852cc30481887a94dabceef8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551710 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647481} TBR=robertogden@chromium.org Bug: 934875 Change-Id: I85227992bdb5ac9d1abcf24e080f9d0a40af3e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554294 Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#648293} .../content/common/data_reduction_proxy_url_loader_throttle.cc | 2 +- tools/chrome_proxy/webdriver/quic.py | 9 --------- 2 files changed, 1 insertion(+), 10 deletions(-) commit 79d81a1b88d9266c2f90d6bfa7c2a4b5c693bcf8 Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Apr 5 19:22:44 2019 +0000 Optimize ProgressTracker This CL does two things: 1. Keep track of updates to all progress items in two new members. This eliminates the need to iterate through all the items in MaybeSendProgress. 2. Stop allocating ProgressItems on the heap with unique_ptr. This should make all map operations much faster. The Progress item is just two int64s. Bug: 673189 Change-Id: I926d84ef5fb25713a85f184ab76d322fc0ab91d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554059 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#648292} .../blink/renderer/core/loader/progress_tracker.cc | 76 ++++++++++++---------- .../blink/renderer/core/loader/progress_tracker.h | 9 ++- 2 files changed, 48 insertions(+), 37 deletions(-) commit 44fc12ef5b28d574f3e23cf957b64c759295b8b6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 19:18:43 2019 +0000 Roll src/third_party/perfetto 3c836b671503..cc57bf714a30 (5 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/3c836b671503..cc57bf714a30 git log 3c836b671503..cc57bf714a30 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 rsavitski@google.com no_destructor_unittest: skip death tests under chromium build 2019-04-05 lalitm@google.com Merge "trace_processor: fix UI query for thread time by p-state" 2019-04-05 lalitm@google.com trace_processor: print non-zero error stats and stop counter events from log spam 2019-04-05 lalitm@google.com trace_processor: improve trace processor's iterator API 2019-04-04 rsavitski@google.com Introduce base::NoDestructor<T> to simplify static objects Created with: gclient setdep -r src/third_party/perfetto@cc57bf714a30 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:129749217,chromium:126443808,chromium:118867986 TBR=perfetto-bugs@google.com Change-Id: I34eb143effcb687253586ed6ccbe9197ffbc0e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554413 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648291} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 999b543fcc6ad5f4970424a0b4fdd731f409be87 Author: bsheedy <bsheedy@chromium.org> Date: Fri Apr 5 19:18:39 2019 +0000 Change most XR browser test expects to asserts Changes the majority of EXPECT_* macros in the XR browser tests to ASSERT_*. This is because expectation failures are non-fatal, while assertion failures are. In most cases, it doesn't make sense for us to continue the test once a check fails, as many assumptions afterwards will be wrong. Some EXPECT_* uses that make sense to be ASSERT_* are left as-is due to the restriction that fatal failure-generating macros can only be used in void-returning functions. Bug: 949772 Change-Id: I8258ebaaeae4b02d148f254a47635cbcc98e9a8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554832 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#648290} chrome/browser/vr/test/xr_browser_test.cc | 14 +++++++------- chrome/browser/vr/test/xr_browser_test.h | 2 +- chrome/browser/vr/webxr_vr_frame_pose_browser_test.cc | 14 +++++++------- chrome/browser/vr/webxr_vr_pixel_browser_test.cc | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) commit 3886d8cc60aa49cb290ca93f571a2effd9646e92 Author: Natalie Chouinard <chouinard@chromium.org> Date: Fri Apr 5 19:15:01 2019 +0000 diagnose_bloat.py: Generate HTML report Add step to generate a supersize HTML report from the first to last build revisions. Sample output: http://gpaste/5150957543358464 Change-Id: I35ed0f3a05389e7ccb5eb93405df2197358bf9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554828 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#648289} tools/binary_size/diagnose_bloat.py | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) commit 3f2285d27ee93d5a69ba49ab92cdf527f324c877 Author: Tommy C. Li <tommycli@chromium.org> Date: Fri Apr 5 19:13:58 2019 +0000 Omnibox: Code health - Remove LocationBarModel::input_in_progress() LocationBarModel was originally designed to provide data on the current navigation entry's state, as described by the class comment. Eventually, it grew to track input_in_progress() state as well, duplicating this state canonically tracked by OmniboxEditModel. This CL removes this method. All of the callsites (other than a few) have already been migrated to calling the View to determine if user input is in progress. This is part of the overall UI architecture effort. Bug: 912722 Change-Id: I609f98b53e1013be0db20a684d357dd71f7f055e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546623 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#648288} .../ui/omnibox/chrome_omnibox_edit_controller.cc | 1 - .../ui/views/location_bar/location_bar_view.cc | 7 ++--- components/omnibox/browser/location_bar_model.h | 32 ++++++---------------- .../ui/omnibox/web_omnibox_edit_controller_impl.mm | 2 -- 4 files changed, 11 insertions(+), 31 deletions(-) commit 4885fee3a125a83c642c0c10c472284ede501de7 Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Fri Apr 5 19:13:19 2019 +0000 Removed #import <EarlGrey/EarlGrey.h> from ios/chrome/test/earl_grey/chrome_earl_grey.h EG1 and EG2 do not share a common set of headers, so any file that directly includes EarlGrey.h cannot be compiled under EG2. Scrubbing the headers will enable us (in a future CL) to share these helpers between EG1 and EG2. Added #import <EarlGrey/EarlGrey.h> to each file in which there is #import "ios/chrome/test/earl_grey/chrome_earl_grey.h" Files that need to change was found by: git grep --files-with-matches ios/chrome/test/earl_grey/chrome_earl_grey.h . | grep .m | xargs grep -L '<EarlGrey/EarlGrey.h>' Added #include "ios/web/public/test/element_selector.h" for files below to fix issue `forward declaration of class here @class ElementSelector`: - ios/chrome/browser/ui/download/download_manager_egtest.mm - ios/chrome/browser/web/tab_order_egtest.mm Bug:922813 Change-Id: I52527ceb805afea38ba0c6b9aa08ba85820257dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554188 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#648287} ios/chrome/browser/autofill/automation/automation_egtest.mm | 1 - ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm | 2 ++ ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm | 1 + ios/chrome/browser/translate/legacy_translate_infobar_egtest.mm | 1 + ios/chrome/browser/translate/translate_egtest.mm | 1 + .../ui/activity_services/activity_service_controller_egtest.mm | 1 + ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm | 2 ++ ios/chrome/browser/ui/autofill/save_profile_egtest.mm | 2 ++ ios/chrome/browser/ui/download/download_manager_egtest.mm | 1 + ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm | 1 + .../browser/ui/payments/payment_request_accessibility_egtest.mm | 2 ++ .../ui/payments/payment_request_can_make_payment_egtest.mm | 2 ++ .../ui/payments/payment_request_cancel_pay_abort_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_egtest_base.mm | 2 ++ .../browser/ui/payments/payment_request_journey_logger_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_misc_egtest.mm | 2 ++ .../browser/ui/payments/payment_request_modifiers_egtest.mm | 2 ++ .../browser/ui/payments/payment_request_payment_app_egtest.mm | 2 ++ .../payments/payment_request_payment_method_identifier_egtest.mm | 2 ++ .../ui/payments/payment_request_payment_response_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_show_egtest.mm | 2 ++ .../browser/ui/payments/payment_request_use_stats_egtest.mm | 2 ++ ios/chrome/browser/ui/popup_menu/popup_menu_egtest.mm | 1 + .../ui/settings/autofill/autofill_credit_card_settings_egtest.mm | 1 + .../ui/settings/autofill/autofill_profile_settings_egtest.mm | 1 + .../ui/settings/clear_browsing_data/clear_browsing_data_egtest.mm | 1 + .../browser/ui/settings/password/passwords_settings_egtest.mm | 1 + ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm | 2 ++ ios/chrome/browser/ui/webui/inspect/inspect_ui_egtest.mm | 1 + ios/chrome/browser/ui/webui/web_ui_egtest.mm | 1 + ios/chrome/browser/web/browsing_egtest.mm | 2 ++ ios/chrome/browser/web/forms_egtest.mm | 1 + ios/chrome/browser/web/navigation_egtest.mm | 1 + .../browser/web/push_and_replace_state_navigation_egtest.mm | 1 + ios/chrome/browser/web/tab_order_egtest.mm | 2 ++ ios/chrome/test/earl_grey/chrome_earl_grey.h | 8 ++++++-- ios/chrome/test/earl_grey/chrome_earl_grey.mm | 2 +- ios/chrome/test/earl_grey/device_check_egtest.mm | 1 + 40 files changed, 64 insertions(+), 4 deletions(-) commit 9763bf843ddb4c9bb7a60e26871d392ea8403533 Author: Alex Cooper <alcooper@chromium.org> Date: Fri Apr 5 19:12:54 2019 +0000 Cleanup overlay_binding in compositor_base CleanUp When we receive a device disconnect while presenting, we weren't closing the overlay binding, which was causing a DCHECK in mojo because it was being default closed/destructed on the wrong thread. Bug: 950040 Change-Id: If3729b277f69883bb2e81a9308fe6dafc94f3ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553173 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648286} device/vr/windows/compositor_base.cc | 1 + 1 file changed, 1 insertion(+) commit cfc2cf28c628c48691afffe17f1bdefa9dc651b8 Author: Charlie Reis <creis@chromium.org> Date: Fri Apr 5 19:12:12 2019 +0000 Require MHTML subframes to commit in main frame's process. This was causing renderer kills before, but we suspect the repro steps might have been fixed. BUG=948246 Change-Id: I3379dd128048a26655877704197c27cd19424ea9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553078 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#648285} .../browser/frame_host/render_frame_host_impl.cc | 27 ++++++++++++---------- 1 file changed, 15 insertions(+), 12 deletions(-) commit b5b7e446ba09c26924b95f644e07e2d3272a2154 Author: Natalie Chouinard <chouinard@chromium.org> Date: Fri Apr 5 19:11:19 2019 +0000 Mark Downloads category as deprecated This category is no longer in use. Mark the category as deprecated and cleanup code references. Bug: 947080, 947082 Change-Id: I26c7e52b87ef2775e468f10d25d93140ab029989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547932 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Patrick Noland <pnoland@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#648284} .../chrome/browser/ntp/cards/ActionItem.java | 5 - .../browser/ntp/cards/SuggestionsCategoryInfo.java | 28 --- .../browser/ntp/snippets/SnippetArticle.java | 77 +-------- .../ntp/snippets/SnippetArticleViewHolder.java | 2 +- .../browser/ntp/snippets/SnippetsBridge.java | 12 -- .../chrome/browser/suggestions/ImageFetcher.java | 81 --------- .../browser/suggestions/SuggestionsBinder.java | 55 ------ .../SuggestionsEventReporterBridge.java | 10 -- .../browser/suggestions/SuggestionsMetrics.java | 4 - .../suggestions/SuggestionsNavigationDelegate.java | 38 +---- .../browser/ntp/snippets/ArticleSnippetsTest.java | 40 ----- .../ntp/cards/SuggestionsCategoryInfoTest.java | 21 --- .../browser/ntp/cards/SuggestionsSectionTest.java | 21 --- .../suggestions/SuggestionsImageFetcherTest.java | 19 +-- chrome/browser/android/ntp/ntp_snippets_bridge.cc | 18 -- components/ntp_snippets/category.h | 2 +- .../click_based_category_ranker_unittest.cc | 34 +--- .../category_rankers/constant_category_ranker.cc | 1 - .../constant_category_ranker_unittest.cc | 4 +- components/ntp_snippets/category_unittest.cc | 9 +- components/ntp_snippets/content_suggestion.cc | 13 -- components/ntp_snippets/content_suggestion.h | 31 ---- .../ntp_snippets/content_suggestions_metrics.cc | 17 +- .../content_suggestions_metrics_unittest.cc | 6 +- .../content_suggestions_service_unittest.cc | 187 ++------------------- .../remote/remote_suggestion_unittest.cc | 2 - tools/metrics/actions/actions.xml | 9 + tools/metrics/histograms/enums.xml | 2 +- 28 files changed, 45 insertions(+), 703 deletions(-) commit f0d4d0c352c6dc47ce4f4e53f7964f4b22742e80 Author: Kyle Horimoto <khorimoto@chromium.org> Date: Fri Apr 5 19:11:00 2019 +0000 [CrOS Cellular] Prepare to create new Cellular Setup dialog. This CL: (1) Creates the //c/b/ui/webui/chromeos/cellular_setup directory and moves the existing MobileSetupDialog and related classes to this directory. This was completed via the following command: ./tools/git/move_source_file.py chrome/browser/ui/webui/chromeos/mobile_setup_* chrome/browser/ui/webui/chromeos/cellular_setup/ (2) Adds a OpenCellularSetupDialog() function which opens the existing MobileSetupDialog. A follow-up CL will update this function to open the updated dialog when the kUpdatedCellularActivationUi flag is enabled. (3) Updates existing comments on the old dialog to make it clear that this UI is being deprecated. Bug: 948942 Change-Id: Ib8e67908de6b0ab7ad4314856cc29c81d69f4e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552252 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#648283} chrome/browser/ui/BUILD.gn | 10 +++++---- .../network/network_connect_delegate_chromeos.cc | 4 ++-- .../ui/webui/chrome_web_ui_controller_factory.cc | 4 ++-- .../ui/webui/chromeos/cellular_setup/OWNERS | 2 ++ .../cellular_setup_dialog_launcher.cc | 21 +++++++++++++++++++ .../cellular_setup_dialog_launcher.h | 24 ++++++++++++++++++++++ .../{ => cellular_setup}/mobile_setup_dialog.cc | 6 +++++- .../{ => cellular_setup}/mobile_setup_dialog.h | 20 ++++++++++++------ .../{ => cellular_setup}/mobile_setup_ui.cc | 6 +++++- .../{ => cellular_setup}/mobile_setup_ui.h | 12 ++++++++--- 10 files changed, 90 insertions(+), 19 deletions(-) commit e2dfc51f0ed9ecf551cfdb01dd282182def0827d Author: Yi Gu <yigu@chromium.org> Date: Fri Apr 5 19:06:41 2019 +0000 [Animation Worklet] Migrate animator state to new global scope Major changes: - Consolidate stateful global scope and stateless global scope. i.e. only select one global scope randomly upon mutation. - No longer create animator instances on both global scopes. Instead, create one instance on the selected global scope and upon switching global scopes create a new one on the new global scope with all the properties transferred. For stateful animators, the state gets transferred as well. Bug: 914918 Change-Id: I13837eb787dcc671492e8c5fbba6176a3bf34cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1488312 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648282} .../renderer/bindings/modules/v8/generated.gni | 2 + .../animation_worklet_global_scope.cc | 111 ++++++++++-- .../animation_worklet_global_scope.h | 22 ++- .../animation_worklet_global_scope.idl | 4 +- .../animation_worklet_proxy_client.cc | 43 ++--- .../animation_worklet_proxy_client.h | 21 +-- .../animation_worklet_proxy_client_test.cc | 197 ++++++++++----------- .../renderer/modules/animationworklet/animator.cc | 24 +++ .../renderer/modules/animationworklet/animator.h | 15 ++ .../animationworklet/animator_definition.cc | 3 +- .../modules/animationworklet/animator_definition.h | 7 +- .../animationworklet/worklet_animation_options.h | 5 +- .../animation-worklet/stateful-animator.https.html | 162 +++++++++++++++++ 13 files changed, 440 insertions(+), 176 deletions(-) commit c7aab29ebbec32c0156113e7c35308549fe495fb Author: Simon La Macchia <smacchia@amazon.com> Date: Fri Apr 5 19:06:08 2019 +0000 Add mediaNotificationInfo null checks to onStop()/onMediaSessionAction() Problem: MediaSessionCompat is making calls when mMediaNotificationInfo is no longer available, causing NPE crash in onStop() and onMediaSessionAction(). Solution: Add null check for mMediaNotificationInfo into onStop() and onMediaSessionAction() callbacks to prevent NPE crashes. This solution mirrors previous NPE fix for onPause() and onPlay() callbacks. See: https://chromium-review.googlesource.com/c/chromium/src/+/955694/ Bug: NONE Change-Id: Ie5775f0d9098cb9693fe7f2d2422404d5612feb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549757 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Simon La Macchia <smacchia@amazon.com> Cr-Commit-Position: refs/heads/master@{#648281} .../chrome/browser/media/ui/MediaNotificationManager.java | 10 ++++++++++ 1 file changed, 10 insertions(+) commit 7d928e2d2153e76191917dd8cd08c574c98a56eb Author: Eric Seckler <eseckler@chromium.org> Date: Fri Apr 5 19:05:35 2019 +0000 Reland "devtools/tracing: Support perfetto backend + proto output." This is a reland of 399f00ea535f61c24649bef5c3c612c8e0aa615e. Addresses test failures of crbug.com/948875 by ensuring that the PerfettoTracingSession waits until startup tracing is fully enabled before attempting to disable it again. Original change's description: > devtools/tracing: Support perfetto backend + proto output. > > Adds the ability for TracingHandler to use the new Perfetto Consumer > interface to control a tracing session. For now, we still support the > old TracingController backend via a new TracingSession virtual class. > > Also adds a proto output format option to the protocol. > Further adds necessary missing methods to the perfetto ConsumerHost > interface. > > To support startup tracing with perfetto + retrieving of the trace via > DevTools, TracingHandler needs to become the consumer that initiates > and controls the startup session, instead of TracingController. > Otherwise, the trace data can't be read via DevTools. For this, we add a > new command line flag. > > Background: We're replacing the old tracing backend (TracingController + > TraceLog) with Perfetto! In this process, former clients of > TracingController become consumers of the Perfetto service instead. > > Bug: 925142, 938879 > Change-Id: I2ac389e4b9a6d258b784acaf76043417be4f4f3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505934 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646895} Bug: 925142, 938879, 948875 TBR: dgozman@chromium.org,dcheng@chromium.org,perezju@chromium.org Change-Id: Ie80d261b9940b2de1917729736f6bb116290302d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553594 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#648280} components/tracing/common/trace_startup_config.cc | 32 +- components/tracing/common/trace_startup_config.h | 21 +- components/tracing/common/tracing_switches.cc | 12 + components/tracing/common/tracing_switches.h | 1 + content/browser/browser_main_loop.cc | 71 +---- content/browser/browser_main_loop.h | 19 -- content/browser/browser_main_runner_impl.cc | 24 +- .../browser/devtools/protocol/tracing_handler.cc | 353 ++++++++++++++++++++- .../browser/devtools/protocol/tracing_handler.h | 8 + .../browser/tracing/startup_tracing_browsertest.cc | 5 +- content/browser/tracing/tracing_controller_impl.cc | 86 +++++ content/browser/tracing/tracing_controller_impl.h | 24 ++ services/tracing/BUILD.gn | 10 - services/tracing/perfetto/consumer_host.cc | 139 +++++++- services/tracing/perfetto/consumer_host.h | 21 +- .../perfetto/perfetto_tracing_coordinator.cc | 61 +--- services/tracing/public/cpp/BUILD.gn | 8 + .../tracing/public/cpp/perfetto/perfetto_config.cc | 83 +++++ .../tracing/public/cpp/perfetto/perfetto_config.h | 24 ++ .../tracing/public/mojom/perfetto_service.mojom | 27 ++ .../public/mojom/trace_config_mojom_traits.cc | 10 + .../public/mojom/trace_config_mojom_traits.h | 5 + .../renderer/core/inspector/browser_protocol.pdl | 12 + .../timeline/tracing-proto-format-expected.txt | 3 + .../timeline/tracing-proto-format-expected.txt | 4 + .../timeline/tracing-proto-format.js | 21 ++ 26 files changed, 872 insertions(+), 212 deletions(-) commit c75bbec2c82c7ae110ca2e9857bdfb483d929318 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 19:00:03 2019 +0000 Roll src/third_party/swiftshader bd3af855ae74..484e08e0fae6 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/bd3af855ae74..484e08e0fae6 git log bd3af855ae74..484e08e0fae6 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 bclayton@google.com SpirvShader: Rework pointer types Created with: gclient setdep -r src/third_party/swiftshader@484e08e0fae6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126330097 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Id2b780a876d01e7f6bed3c73b0a1002c2b861f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554432 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648279} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit f80720dd1008cabc24213a89ce799e2c45b76267 Author: Alexei Filippov <alph@chromium.org> Date: Fri Apr 5 18:54:53 2019 +0000 Disable flaky SelectToSpeakTest.FocusRingMovesWithMouse test BUG=950049 TBR=nektar@chromium.org,avi@chromium.org Change-Id: I07d3e741c02eeae93be6d9c2647aedad4a735ebe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1555000 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#648278} chrome/browser/chromeos/accessibility/select_to_speak_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit ec8eda706849db217a93562af7d673847a986fb0 Author: Yashar Dabiran <yashard@google.com> Date: Fri Apr 5 18:52:35 2019 +0000 Fix origin trials bindings generation for ServiceWorkerGlobalScope For ServiceWorkerGlobalScope, TrustedTypePolicyFactory interface attributes are defined in "service_worker_global_scope_core_constructors.idl" which was not visible to the origin trials code generator. The issue is fixed by passing all the generated dependency idl files to the build. * Due to bug 358074, it is not possible to add the new dependency to the modules build only. Bug: 937945 Change-Id: I999cde5830730f4366c5abbe9adbc478f84a0e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553665 Commit-Queue: Yashar Dabiran <yashard@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#648277} third_party/blink/renderer/bindings/modules/v8/BUILD.gn | 5 ++--- third_party/blink/renderer/bindings/scripts/scripts.gni | 6 ++++-- .../webexposed/global-interface-listing-service-worker-expected.txt | 3 +++ 3 files changed, 9 insertions(+), 5 deletions(-) commit f860a7767d774dc16538d3273a4d5eb7a7bcc9de Author: Avi Drissman <avi@chromium.org> Date: Fri Apr 5 18:51:20 2019 +0000 Correctly disable CloseOnLoadcommit BUG=949923 NOTRY=true TBR=lfg@chromium.org Change-Id: I35423dcb50326c9654329560be2edf542973a6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553178 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648276} chrome/browser/apps/guest_view/web_view_browsertest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 8ce015974cca365627b2674ad46b6b7df9943a2c Author: Dominik Laskowski <domlaskowski@chromium.org> Date: Fri Apr 5 18:49:03 2019 +0000 display: Clean up content protection This CL cleans up the DisplayConfigurator API for content protection, specifically removing INVALID_CLIENT_ID in favor of an optional type, as well as renaming functions and callbacks for consistency with QueryContentProtectionTask and ApplyContentProtectionTask. Bug: 929449 Test: display_unittests Change-Id: I8081c964041e37682ce3555394ecf6fc4987eae6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553581 Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#648275} ash/display/display_output_protection.cc | 12 +- .../display/output_protection_controller_ash.cc | 28 ++- .../display/output_protection_controller_ash.h | 3 +- ui/display/manager/display_configurator.cc | 158 ++++++++------- ui/display/manager/display_configurator.h | 83 ++++---- .../manager/display_configurator_unittest.cc | 211 ++++++++++----------- 6 files changed, 239 insertions(+), 256 deletions(-) commit ad6570b9518a183801ee642ef82127a3e9694871 Author: Caleb Rouleau <crouleau@chromium.org> Date: Fri Apr 5 18:48:00 2019 +0000 Revert "Chunk perf data into 30 MB chunks instead of 1 MB." This reverts commit 81eedac1e9f603d55798f99d37936b8ffd7b2570. Reason for revert: possibly causing rendering.desktop to not be able to upload data. probably the dashboard is not intaking the data since the chunks are too big again. Original change's description: > Chunk perf data into 30 MB chunks instead of 1 MB. > > Locally, I timed the process_perf_results() call in > ProcessPerfResultsIntegrationTest.testIntegration before and after this change. > > Before: > Test #1: 40.6 seconds > Test #2: 38.8 seconds > > After: > Test #1: 24.4 seconds > Test #2: 24.7 seconds > > I expect the difference on the waterfall to be more dramatic than this since > the waterfall test results have a much more unequal distribution of perf data > sizes, so we tend to get stuck chunking up some huge benchmark. > > Bug: 947035 > Change-Id: Ib2a5075dc2504d0bec37750cd73eba57dbc19d11 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548356 > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Ben Hayden <benjhayden@chromium.org> > Reviewed-by: Ben Hayden <benjhayden@chromium.org> > Auto-Submit: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646552} TBR=benjhayden@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 947035 Change-Id: I90493939c018cce504491dd99c5d0a8dd22fb94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554885 Reviewed-by: Caleb Rouleau <crouleau@chromium.org> Reviewed-by: Ben Hayden <benjhayden@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#648274} tools/perf/core/upload_results_to_perf_dashboard.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit e4d6afae3954135a8a69fa3de6e635d1181a2c72 Author: Jose Dapena Paz <jose.dapena@lge.com> Date: Fri Apr 5 18:47:56 2019 +0000 crc32c: Re-enable crc and crypto extensions to arm64 crc32c build. The commit https://crrev.com/c/1492489 introduces a regression on GCC build, as GCC will not enable the aarch64 feature modifiers crc and crypto anymore. This change keeps clang implementation using the target feature extensions, but keeps the old implementation for GCC. Bug: 819294 Change-Id: I343ba9587e0356ecdab2ed95513d6d58feb5e75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553319 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#648273} third_party/crc32c/BUILD.gn | 2 ++ 1 file changed, 2 insertions(+) commit 3e9f7b57accb84698ae7afadcc80254709fd5c54 Author: Henrique Nakashima <hnakashima@chromium.org> Date: Fri Apr 5 18:44:56 2019 +0000 Unregister ControllerImpl as observer of NavigationMonitor. When ControllerImpl is initialized, it adds itself as an observer of NavigationMonitor. This CL makes ControllerImpl unregister itself in its destructor, ensuring no events are sent from NavigationMonitorImpl to a dangling pointer. Bug: 943724 Change-Id: I0e6b122bf3a0efccaf867a4bcd71e2c9e13d09a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553648 Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#648272} chrome/browser/download/download_service_factory.cc | 2 ++ .../download/internal/background_service/controller_impl.cc | 1 + .../background_service/navigation_monitor_impl_unittests.cc | 9 +++++++++ 3 files changed, 12 insertions(+) commit 9d0eb97a32a6b7291901aee0ddc18c168eec52c0 Author: Xida Chen <xidachen@chromium.org> Date: Fri Apr 5 18:44:45 2019 +0000 Ensure that PaintWorkletImageCache works without a painter Right now in the PaintWorkletImageCache, we did do null check on the |painter_| member to ensure that there is no crash when it is null. This CL adds unit testing to ensure that it is functioning as it should be. Also, in order to fix a potential crash in GetPaintRecordAndRef, the ScopedResult now takes a sk_sp<PaintRecord> instead of a const PaintRecord*. Bug: 939192 Change-Id: I6282618566d931a6aea2e4d5674ed835d85c91d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518292 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by: vmpstr <vmpstr@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648271} cc/paint/image_provider.cc | 13 +++++-------- cc/paint/image_provider.h | 7 ++++--- cc/paint/paint_op_buffer_unittest.cc | 22 +++++++++++----------- cc/raster/paint_worklet_image_provider.cc | 6 +++--- cc/tiles/paint_worklet_image_cache.cc | 11 +++++------ cc/tiles/paint_worklet_image_cache.h | 4 ++-- cc/tiles/paint_worklet_image_cache_unittest.cc | 20 +++++++++++++++++++- 7 files changed, 49 insertions(+), 34 deletions(-) commit 50483d82a43730cd095813dc4b64c2cfbe96d804 Author: Jose Dapena Paz <jose.dapena@lge.com> Date: Fri Apr 5 18:43:11 2019 +0000 LocalFrameView: fix DisallowLayoutInvalidationScope GCC build GCC visibility evaluation is different from Clang. In this case build breaks because the lambda function declared in .h does not have access to ForAllChildLocalFrameViews yet. Moving the implementation of DisallowLayoutInvalidationScope constructor and destructor to .cc fixes the problem. BUG=chromium:819294 Change-Id: I82e8b135aa911c878413998a24cacce03d2662c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550373 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#648270} .../blink/renderer/core/frame/local_frame_view.cc | 24 ++++++++++++++++++++++ .../blink/renderer/core/frame/local_frame_view.h | 21 ++----------------- 2 files changed, 26 insertions(+), 19 deletions(-) commit 0f89e955332d7631dd5bb2791702bad7694f583f Author: yilkal <yilkal@chromium.org> Date: Fri Apr 5 18:42:56 2019 +0000 Don't launch browser at KioskNext sign in. Don't launch startup chrome browser window when a KioskNext login happens. Bug: 938532 Change-Id: I61c0a13b298bc45e4945425c14874e9231952233 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529889 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#648269} ash/kiosk_next/kiosk_next_shell_controller.cc | 13 +++++++-- ash/kiosk_next/kiosk_next_shell_controller.h | 2 +- .../kiosk_next_shell_controller_unittest.cc | 27 ++++++++---------- ash/shell.cc | 2 +- .../chromeos/login/session/user_session_manager.cc | 3 -- chrome/browser/chromeos/preferences.cc | 4 +++ .../ui/ash/kiosk_next_shell_client_browsertest.cc | 15 ++++++++++ .../browser/ui/startup/startup_browser_creator.cc | 32 +++++++++++++++++----- 8 files changed, 68 insertions(+), 30 deletions(-) commit f384207e04ad27f58287e972907f17ad66acc115 Author: Dominick Ng <dominickn@chromium.org> Date: Fri Apr 5 18:40:21 2019 +0000 Add doc on Controlling Permissions Access to Powerful Web Platform APIs. Bug: None Change-Id: I8ebd9d26de723b78ca5aa971632def596d6a2c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536038 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Reviewed-by: Christopher Thompson <cthomp@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648268} ...rmissions-for-powerful-web-platform-features.md | 388 +++++++++++++++++++++ 1 file changed, 388 insertions(+) commit fa6e363739dadf8ec3bead2ccd727b6c959b4358 Author: Jamie Madill <jmadill@chromium.org> Date: Fri Apr 5 18:40:07 2019 +0000 Revert "Add new ANGLE Linux and Mac tester configs." This reverts commit fab66bae0415f0995ffc1a64a0c3c62386944ac0. Reason for revert: <INSERT REASONING HERE> Original change's description: > Add new ANGLE Linux and Mac tester configs. > > These configs will replace linux_angle_rel_ng and mac_angle_rel_ng. > They initially mirror the configuration but will soon be updated to > run only the subsets of tests that are most relevant to ANGLE. This > should reduce flakiness in ANGLE and reduce load for Chrome. > > Also updates related configuration files to include linux-angle-rel > and mac-angle-rel. > > Bug: 822310 > Change-Id: I2b40ed45f5d9e105c088ab166bd2207c96280151 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551463 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647854} TBR=kbr@chromium.org,jbudorick@chromium.org,jmadill@chromium.org Change-Id: I8ec1017835d224282688c4bd089c05d41fe9f3c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 822310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553176 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#648267} infra/config/cr-buildbucket.cfg | 2 - infra/config/luci-milo.cfg | 12 - testing/buildbot/chromium.gpu.fyi.json | 2624 ---------------------------- testing/buildbot/generate_buildbot_json.py | 5 - testing/buildbot/waterfalls.pyl | 61 - tools/mb/mb_config.pyl | 2 - 6 files changed, 2706 deletions(-) commit bfe3141ff1ebf93cc5b154688f77186b805cf56c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 18:36:21 2019 +0000 Roll src/third_party/chromite c5403d69e17c..c6dfce981f13 (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c5403d69e17c..c6dfce981f13 git log c5403d69e17c..c6dfce981f13 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 pprabhu@chromium.org config: Migrate eve,grunt,samus,veyron_minnie PFQs to Skylab Created with: gclient setdep -r src/third_party/chromite@c6dfce981f13 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I9c87453962754875e705a7ae28726567a8a52808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554431 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648266} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cdbd8d25b5a3b35bc382e4f23a5d7cccd7e6bef3 Author: Lucas Tenório <ltenorio@chromium.org> Date: Fri Apr 5 18:33:16 2019 +0000 Send the Android ID to Kiosk Next Home as a hex string. Bug: 927809 Change-Id: Ia2380f18ef87e7c93a40858d62777810d1e86d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553207 Reviewed-by: Aga Wronska <agawronska@chromium.org> Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Cr-Commit-Position: refs/heads/master@{#648265} .../browser/chromeos/kiosk_next_home/app_controller_service.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) commit 0e3688fc1b8ad2e9af9c5b1a5bef66391f9fb3a3 Author: Natalie Chouinard <chouinard@chromium.org> Date: Fri Apr 5 18:30:36 2019 +0000 Migrate ImageMetadataStoreLevelDB to new API leveldb_proto databases will soon be migrated from unique LevelDB instances to a single shared underlying database. Because of this, we need to migrate to the new API to construct and initialize the database. Bug: 941795 Change-Id: I8a13c590361c812303304428252bb6fdc905dc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548533 Reviewed-by: ssid <ssid@chromium.org> Reviewed-by: Brandon Wylie <wylieb@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#648264} .../image_fetcher/image_fetcher_service_factory.cc | 6 ++++- .../core/cache/image_cache_unittest.cc | 8 +++---- .../core/cache/image_metadata_store_leveldb.cc | 26 +++++++++------------- .../core/cache/image_metadata_store_leveldb.h | 16 ++++++++----- .../cache/image_metadata_store_leveldb_unittest.cc | 6 ++--- .../core/cached_image_fetcher_unittest.cc | 6 ++--- .../public/shared_proto_database_client_list.cc | 4 +++- .../public/shared_proto_database_client_list.h | 3 ++- 8 files changed, 40 insertions(+), 35 deletions(-) commit 257000c9a3391069fc3771af54f609f8cd061b9a Author: Philip Rogers <pdr@chromium.org> Date: Fri Apr 5 18:29:42 2019 +0000 [BlinkGenPropertyTrees] Fix under-invalidation of backface-visibility Backface visibility does not depend on having a PaintLayer but the invalidation logic did. This patch extracts out the invalidation of paint properties into LayoutBoxModelObject::StyleDidChange. This patch also removes outdated code that caused repaints for backface visibility changes. Bug: 946541 Change-Id: Ib6790b9c7d442d8e8971185c2eda2a99f10e8506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553168 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648263} .../core/layout/layout_box_model_object.cc | 46 +++++++++++----------- .../core/paint/paint_property_tree_update_tests.cc | 9 +++++ 2 files changed, 32 insertions(+), 23 deletions(-) commit 20363ece87c60507bfe001a61c307401e7b1292d Author: Marcin Bojanczyk <marcinjb@chromium.org> Date: Fri Apr 5 18:29:05 2019 +0000 Add ACEH testing to Chrome Proxy release tests. The data saver proxy will start returning a new header (Access-Control-Expose-Headers) to all proxy responses soon. This change adds tests to various proxy test cases to ensure that the ACEH header is present and contains the expected values. It is expected that the ACEH header will now contain "Chrome-Proxy", "Chrome-Proxy-Content-Transform" and "Via" (the values set by the proxy), but it may also contain other values that are provided by the origin. Bug: 949301 Change-Id: Ibe00cf4027202d95435a6e266d925767c51327c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551494 Reviewed-by: Robert Ogden <robertogden@chromium.org> Commit-Queue: Marcin Bojanczyk <marcinjb@google.com> Cr-Commit-Position: refs/heads/master@{#648262} tools/chrome_proxy/webdriver/bypass.py | 14 ++++---- tools/chrome_proxy/webdriver/client_config.py | 2 +- tools/chrome_proxy/webdriver/common.py | 39 ++++++++++++++++++---- .../webdriver/compression_regression.py | 2 +- tools/chrome_proxy/webdriver/data_use.py | 2 +- tools/chrome_proxy/webdriver/fallback.py | 4 +-- tools/chrome_proxy/webdriver/html5.py | 2 +- tools/chrome_proxy/webdriver/lite_page.py | 2 +- tools/chrome_proxy/webdriver/lofi.py | 6 ++-- tools/chrome_proxy/webdriver/quic.py | 4 +-- .../webdriver/reenable_after_bypass.py | 4 +-- tools/chrome_proxy/webdriver/safebrowsing.py | 2 +- tools/chrome_proxy/webdriver/smoke.py | 6 ++-- tools/chrome_proxy/webdriver/video.py | 16 ++++----- 14 files changed, 65 insertions(+), 40 deletions(-) commit 5d55f18b67178b8f70d4d68d92ad539f52190c69 Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 5 18:24:51 2019 +0000 Reland "Record quic proxy server status with servicification" This is a reland of 758594644b2cc51bd1e858e5985dcfd383530780 crbug.com/950008 disables the failing tests, and this CL is not the culprit. Original change's description: > Record quic proxy server status with servicification > > Also fixes a webdriver test when QUIC availability status of data saver > proxy is recorded. > > Bug: 934875 > Change-Id: I1320fb26b284bd23ae431f045e3e8724aa814cda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549927 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647087} TBR=robertogden@chromium.org Bug: 934875 Change-Id: I0ff1dda635440ad2b77b2affa3b67191f59216f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553870 Reviewed-by: rajendrant <rajendrant@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#648261} .../data_reduction_proxy_url_loader_throttle.cc | 13 +++++++++++++ .../core/browser/data_reduction_proxy_delegate.cc | 20 ++------------------ .../core/browser/data_reduction_proxy_delegate.h | 13 ------------- .../data_reduction_proxy_delegate_unittest.cc | 15 ++++----------- .../common/data_reduction_proxy_bypass_protocol.cc | 15 +++++++++++++++ .../common/data_reduction_proxy_bypass_protocol.h | 14 ++++++++++++++ 6 files changed, 48 insertions(+), 42 deletions(-) commit 4a9c823ae892679604147f985a21f4fd50fbc7f1 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Fri Apr 5 18:24:42 2019 +0000 Add visual debugging support for accessibility image descriptions When the --enable-experimental-accessibility-labels-debugging flag is passed, images on the page will be drawn with a colored outline indicating their image annotation status, and hovering over an image will show its status and any annotated text. Bug: 905419 Change-Id: I6121ab7f1256e0ddf006e320539e2f9a861e7d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553676 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#648260} .../renderer_host/render_process_host_impl.cc | 1 + .../renderer/accessibility/blink_ax_tree_source.cc | 23 ++++-- .../renderer/accessibility/blink_ax_tree_source.h | 4 ++ .../accessibility/render_accessibility_impl.cc | 84 +++++++++++++++++++++- .../accessibility/render_accessibility_impl.h | 10 +++ ui/accessibility/accessibility_switches.cc | 5 ++ ui/accessibility/accessibility_switches.h | 1 + 7 files changed, 123 insertions(+), 5 deletions(-) commit 32ff182e94dd3222a4d3af7820be5e1476158117 Author: Alex Cooper <alcooper@chromium.org> Date: Fri Apr 5 18:23:43 2019 +0000 Ensure that stationary reference spaces are rejected if not supported Per the explainer, stationary reference spaces are hardware dependent. If we've created a "sensorless" session, then we can't support any reference space other than the identity space. This adds a flag so that the xr_session class can explicitly know if it is intended to be a sensorless session and will therefore reject requests for any reference space other than the identity. This resulted in needing to updated the sample pages to fallback to an identity space if their inline stationary request was rejected. Bug: 946784 Change-Id: Ia1f6b65b7c379b7d8c0a6fcaa413ff40a4dce81d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549317 Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#648259} chrome/browser/vr/BUILD.gn | 1 + chrome/browser/vr/test/webxr_vr_browser_test.h | 20 ++++++++++++++++ .../browser/vr/webxr_vr_spatial_tracking_test.cc | 9 +++++++ .../test_stationary_reference_space_rejects.html | 28 ++++++++++++++++++++++ third_party/blink/renderer/modules/xr/xr.cc | 9 +++---- third_party/blink/renderer/modules/xr/xr.h | 3 ++- .../blink/renderer/modules/xr/xr_session.cc | 12 ++++++++-- third_party/blink/renderer/modules/xr/xr_session.h | 7 +++++- .../webxr_test_pages/webxr-samples/360-photos.html | 10 ++++++++ .../webxr-samples/fallback-rendering.html | 12 +++++++++- .../webxr-samples/input-selection.html | 10 ++++++++ .../webxr-samples/input-tracking.html | 10 ++++++++ .../webxr-samples/magic-window.html | 10 ++++++++ .../webxr-samples/positional-audio.html | 12 +++++++++- .../webxr-samples/reduced-bind-rendering.html | 12 +++++++++- .../webxr_test_pages/webxr-samples/room-scale.html | 10 ++++++++ .../webxr-samples/spectator-mode.html | 10 ++++++++ .../webxr-samples/stereo-video.html | 12 +++++++++- .../webxr-samples/tests/cube-sea.html | 12 +++++++++- .../webxr-samples/tests/offscreen-canvas.html | 10 ++++++++ .../webxr-samples/tests/permission-request.html | 10 ++++++++ .../webxr-samples/tests/pointer-painter.html | 10 ++++++++ .../webxr-samples/tests/sponza.html | 12 +++++++++- .../webxr-samples/viewport-scaling.html | 10 ++++++++ 24 files changed, 247 insertions(+), 14 deletions(-) commit 42eac830fca821f62885075360482bd1c7ee1709 Author: Justin DeWitt <dewittj@chromium.org> Date: Fri Apr 5 18:23:37 2019 +0000 Revert "[Touchless]: Update Most Likely carousel image loading" This reverts commit 820a904b9e831ceb51d40a6fa7db7f17d9d74ef1. Reason for revert: Likely cause of ANRs during layout Original change's description: > [Touchless]: Update Most Likely carousel image loading > > Resolve CL comments from https://chromium-review.googlesource.com/c/chromium/src/+/1535227 > > Bug: 936050 > Change-Id: Ia5a8223577cfa43a5ea38a9a6165f7fd0d266993 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545194 > Commit-Queue: Cathy Li <chili@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Justin DeWitt <dewittj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#646435} TBR=dewittj@chromium.org,twellington@chromium.org,chili@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 936050 Change-Id: I1bda48ed4e5eebdcb8b2f03426c0aef3237acfff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553876 Reviewed-by: Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#648258} .../java/res/drawable/ic_apps_black_24dp.xml | 5 +- .../browser/touchless/SiteSuggestionsAdapter.java | 63 +++++++++++++--------- .../touchless/SiteSuggestionsCoordinator.java | 8 ++- .../browser/touchless/SiteSuggestionsMediator.java | 3 +- 4 files changed, 43 insertions(+), 36 deletions(-) commit 34928e3abf80b30c0a49f0c553a1cb980f3f65ee Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Fri Apr 5 18:18:40 2019 +0000 [LayoutNG] Reduce amount ShouldBeConsideredAsReplaced is called. ... and fix some spelling. There should be no functionality change. Change-Id: Ie9df7676656d8e4efc789bc05a4e627d87686f1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554056 Reviewed-by: Aleks Totic <atotic@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648257} .../core/layout/ng/ng_out_of_flow_layout_part.cc | 58 +++++++++++----------- 1 file changed, 29 insertions(+), 29 deletions(-) commit 07b6341557a021f0e50ed4be7e0ddac8cfd132b4 Author: Becca Hughes <beccahughes@chromium.org> Date: Fri Apr 5 18:14:34 2019 +0000 [Media Notification] Add histogram for user action Add a Media.Notification.UserAction histogram that records the action when a user clicks on a button. BUG=949303 Change-Id: Ie819885677a41a4fd64de53e8f359770cb1249c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551929 Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#648256} ash/media/media_notification_item.cc | 11 ++++++++++- ash/media/media_notification_item.h | 3 +++ ash/media/media_notification_view_unittest.cc | 15 +++++++++++++++ tools/metrics/histograms/enums.xml | 11 +++++++++++ tools/metrics/histograms/histograms.xml | 9 +++++++++ 5 files changed, 48 insertions(+), 1 deletion(-) commit a9df9320602c191f7f2c0e245fb77482f4eabbf6 Author: dpapad <dpapad@chromium.org> Date: Fri Apr 5 18:11:02 2019 +0000 File Manager: Convert banners.js and location_line.js to ES6 class syntax. This is in preparation of removing the custom cr.EventTarget implementation in favor of native EventTarget, which requires all subclasses to be ES6 classes, otherwise a runtime "Illegal invocation" error is thrown. Bug: 854268,778674 Change-Id: Ice80144e128fb414d2d5d46d8b2a04a439d0dafe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554280 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#648255} .../file_manager/foreground/js/ui/banners.js | 1161 ++++++++++---------- .../file_manager/foreground/js/ui/location_line.js | 709 ++++++------ 2 files changed, 941 insertions(+), 929 deletions(-) commit fc8683a9a9a9e75a93ff734a41eb54f9a0515d3f Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 18:08:39 2019 +0000 Import wpt@6f655784b91ad6203191a230fd514201024defed Using wpt-import in Chromium 4cda67aad619795edb785be6c19d8c2852d99e42. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874cf2 "[WPT] Fix JSON decoding errors in referrer-policy on Safari" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I2faa671eb66454ebe253001476cb194604199b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554734 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648254} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 6 ++-- .../selection-start-end-extra-expected.txt | 5 +-- .../selection-start-end-extra.html | 36 ++++++++++++++++++++-- 3 files changed, 39 insertions(+), 8 deletions(-) commit ef0b0acc2dbea1ae586b0e110ab226255470ccbb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 18:07:10 2019 +0000 Roll src/third_party/skia 69da7ad49b55..774aeba9d0eb (5 commits) https://skia.googlesource.com/skia.git/+log/69da7ad49b55..774aeba9d0eb git log 69da7ad49b55..774aeba9d0eb --date=short --no-merges --format='%ad %ae %s' 2019-04-05 fmalita@chromium.org [skottie] Add support for pre-decoding images at load time 2019-04-05 brianosman@google.com Always mark bitmap glyph runs as such, to ensure they are properly regenerated 2019-04-05 bsalomon@google.com Blacklist mobi_wsj.skp on IntelIris 540 and 655 2019-04-05 robertphillips@google.com Favor full screen clears for platforms that desire initialized memory 2019-04-05 reed@google.com Revert "Move localmatrix routines to shaderbase, no need to be public." Created with: gclient setdep -r src/third_party/skia@774aeba9d0eb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: I37c09741a9296e49b068dd61dab54e2f9fa2a7d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554430 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648253} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5c9a1fa510255a1abf8d667f052046336b660381 Author: Renjie <renjietang@chromium.org> Date: Fri Apr 5 18:07:01 2019 +0000 Make sure DNS resolution end time is recoreded when race_stale_dns_on_connection experiment is on. Normally after DoResolveHost(), DoResolveHostComplete() will be called and dns end time is recorded. But when the race experiment is on, OnResolveHostComplete() might jump straight to DaValidateHost(). So time recording is added in OnResolveHostComplete(). In some cases where DoResolveHostComplete() is called after OnResolveHostComplete(), the dns end time will be recorded twice. But since it will be overwritten, it won't cause any trouble. Fixes internal b/129947008. Change-Id: If8533eace5f37752839234788cb8b1d6999571b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554107 Reviewed-by: Ryan Hamilton <rch@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#648252} net/quic/quic_stream_factory.cc | 1 + 1 file changed, 1 insertion(+) commit 423c24bc32f07b86db77406694c92a9ca731b55f Author: Robert Sesek <rsesek@chromium.org> Date: Fri Apr 5 17:59:58 2019 +0000 Clean up sandbox code in renderer_main_platform_delegate_mac.mm. With the V2 sandbox architecture on Mac, processes are sandboxed as part of process launching. This removes a conditional branch that was used during the rollout of the V2 sandbox. It also removes the very hacky DisconnectCFNotificationCenter(), which is no longer needed since the static initializer discussed in the (deleted) comment can no longer acquire the Mach resource. Bug: 689306 Change-Id: I2e099f640ee2dff7ce0e91cf211bcef4e14db1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553799 Reviewed-by: Greg Kerr <kerrnel@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#648251} .../renderer_main_platform_delegate_mac.mm | 111 ++------------------- 1 file changed, 9 insertions(+), 102 deletions(-) commit e7e0cb28451457cb5b6d0e85da6e9bb0f2b17a12 Author: Yue Zhang <yuezhanggg@google.com> Date: Fri Apr 5 17:59:48 2019 +0000 Fix crash for scrolling up BottomSheet when it's hiding Modify onTouchListener for BottomSheet to ignore scrolling-up action when the BottomSheet is already going to hide. Bug: 948520 Change-Id: I291bbe1862373a6cb7979a83f28b3abbb7ad9737 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554739 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@google.com> Cr-Commit-Position: refs/heads/master@{#648250} .../org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 8a55381ddf27fef7adeadd5c3bb9c62115e77eb4 Author: Xiaoqian Dai <xdai@chromium.org> Date: Fri Apr 5 17:58:29 2019 +0000 Fix the crash that happens when close an Arc window that's being dragged. Arc app window can be closed during dragging. We should reset its window state delegate when it's destroyed so that we won't try to do any dragging operation on a to-be-closed window. Bug: 902410 Change-Id: Ie67a1b9fe648ade9cd0252d2cbee78d0b7b902b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554128 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#648249} ash/wm/window_state.cc | 3 +- components/exo/client_controlled_shell_surface.cc | 4 ++ .../client_controlled_shell_surface_unittest.cc | 74 ++++++++++++++++++++++ 3 files changed, 80 insertions(+), 1 deletion(-) commit 39efedcc7fcf80f6b9f2ae0283e5baf5145d79ce Author: Greg Thompson <grt@chromium.org> Date: Fri Apr 5 17:57:46 2019 +0000 Don't fail mini_installer_tests if the log file could not be deleted. BUG=949727 R=avi@chromium.org Change-Id: I70d481a1ac82957de3b4ae363ffaf99a917bf4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554494 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648248} .../mini_installer/test_chrome_with_chromedriver.py | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) commit 72566df473e59086e3aacdc3281247ba6e7814f5 Author: Daniel Rubery <drubery@chromium.org> Date: Fri Apr 5 17:55:27 2019 +0000 Patch unrar to fix bug with NOVOLUME This CL ports a patch from the unrar developers to fix the extraction of multi-part RAR archives, while NOVOLUME is defined. Once the changes land upstream, we should be able to drop this patch. Bug: 949787 Change-Id: I966fd2ee93b192028519ebcac03ba24f48bfe33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553166 Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#648247} third_party/unrar/README.chromium | 3 +++ third_party/unrar/patches/fix_novolume.patch | 24 ++++++++++++++++++++++++ third_party/unrar/src/extract.cpp | 6 ++++-- 3 files changed, 31 insertions(+), 2 deletions(-) commit 75f4b052a7455317057172ec764bfbd87fa535dd Author: Donn Denman <donnd@chromium.org> Date: Fri Apr 5 17:55:21 2019 +0000 [TTS] Add a flag and logic for use Translate Model Adds a flag/Feature and a new helper for accessing selected Translate info from Java. Also does some refactoring of Contextual Search Translation to use an interface, with old and new implementations to help ease the transition. DETAILS: 1) Adds a new chrome://flags Feature for using the Chrome Translation model instead of the legacy Contextual Search Heuristics. 2) Updates the TranslateBridge.java by adding new translate methods needed by Contextual Search. 3) Refactors Contextual Search. We used to call back to the manager for native method access by putting translate code in the delegate. Now the native translate code is in the TranslateBridge, and the manager has a new interface that is implemented with the old legacy code OR a new class that uses the new utility. BUG=644909, 857163 Change-Id: I855e9fb64486b7cf19e5a5a81c3f3427ec8676e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538485 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#648246} chrome/android/chrome_java_sources.gni | 2 + chrome/android/chrome_junit_test_java_sources.gni | 1 + .../chromium/chrome/browser/ChromeFeatureList.java | 2 + .../contextualsearch/ContextualSearchManager.java | 8 +- .../ContextualSearchTranslateController.java | 73 +++++------ .../ContextualSearchTranslation.java | 41 +++++++ .../ContextualSearchTranslationImpl.java | 98 +++++++++++++++ .../contextualsearch/ContextualSearchUma.java | 11 -- .../chrome/browser/translate/TranslateBridge.java | 36 ++++++ .../ContextualSearchTranslationImplTest.java | 135 +++++++++++++++++++++ chrome/browser/about_flags.cc | 5 + chrome/browser/android/chrome_feature_list.cc | 4 + chrome/browser/android/chrome_feature_list.h | 1 + .../contextualsearch/contextual_search_delegate.cc | 6 +- .../contextualsearch/contextual_search_delegate.h | 2 + chrome/browser/flag-metadata.json | 5 + chrome/browser/flag_descriptions.cc | 6 + chrome/browser/flag_descriptions.h | 3 + .../browser/translate/android/translate_bridge.cc | 59 ++++++++- tools/metrics/histograms/enums.xml | 2 + tools/metrics/histograms/histograms.xml | 6 +- 21 files changed, 451 insertions(+), 55 deletions(-) commit 6b2a0e9a6a7c6c1a626cd9ce0c14c65e3d3508b3 Author: Dana Fried <dfried@chromium.org> Date: Fri Apr 5 17:47:20 2019 +0000 Avoid capturing thumbnails when pages haven't been rendered. Previously, if the user didn't sit on a tab for a period of time, no thumbnail was captured (to prevent small partial updates/pages which haven't painted yet from being captured during tab scrub with ctrl-tab). This was an okay proxy for what we wanted, but there is also a signal that the web contents send which we can use better. In this CL we replace the time-based system with one based on whether the page has been painted at all. Bug: 928954 Change-Id: I51caf4c370fbfe05b7dc5cb291f2e69d6148291e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552943 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#648245} .../ui/thumbnails/thumbnail_page_event_adapter.cc | 5 +++++ .../ui/thumbnails/thumbnail_page_event_adapter.h | 1 + .../browser/ui/thumbnails/thumbnail_page_observer.h | 3 +++ chrome/browser/ui/thumbnails/thumbnail_tab_helper.cc | 19 ++++++++++--------- chrome/browser/ui/thumbnails/thumbnail_tab_helper.h | 4 ++-- 5 files changed, 21 insertions(+), 11 deletions(-) commit 680019b87902571ab03dfc86be758cd7bc282de9 Author: Boris Sazonov <bsazonov@chromium.org> Date: Fri Apr 5 17:47:17 2019 +0000 [Signin][Android] Fix crash in FakeAccountManagerDelegate.hasFeatures Adds check for null AccountHolder, as hasFeatures is invoked asynchronously from AccountManagerFacade, so the account may have disappeared in the meantime. Bug: 949872 Change-Id: I133cbe9cf2f8292877e8f6835ff855e3acfcb0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554353 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#648244} .../components/signin/test/util/FakeAccountManagerDelegate.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) commit 126ee3366da9ddd7d0ddfa79928c174224dbe31b Author: Sergey Ulanov <sergeyu@chromium.org> Date: Fri Apr 5 17:45:54 2019 +0000 [Fuchsia] Disable dav1d on arm64 dav1d crashes on Fuchsia, on both x64 and arm64, but was disabled only on x64. Bug: 930300 Change-Id: I828f3c728249b8f09de9cc1c644f69950b3ee1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553312 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#648243} media/media_options.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 24512356f6d6ec27edc1d5547677a26e4ce6dab7 Author: Piotr Bialecki <bialpio@chromium.org> Date: Fri Apr 5 17:45:50 2019 +0000 Roll ARCore SDK version to 1.8 Stop using API deprecated in version 1.7. Remove special-casing for -Wextra-semi. Bug: 931379,936004 Change-Id: Ib547ef4fe0dde124753561d47a34eeb075e3b883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548322 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Klaus Weidner <klausw@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#648242} DEPS | 4 +- chrome/android/java/AndroidManifest.xml | 2 +- .../monochrome_public_apk.AndroidManifest.expected | 2 +- chrome/browser/android/vr/BUILD.gn | 5 -- .../android/vr/arcore_device/arcore_impl.cc | 7 +- .../android/vr/arcore_device/arcore_shim.cc | 85 +++++++++++----------- third_party/android_deps/BUILD.gn | 2 +- .../libs/com_google_ar_core/README.chromium | 2 +- .../android_deps/libs/com_google_ar_core/cipd.yaml | 4 +- .../com_google_ar_core/com_google_ar_core.info | 2 +- tools/android/roll/android_deps/build.gradle | 2 +- 11 files changed, 59 insertions(+), 58 deletions(-) commit b4f136f445addf09cf787ea81ff70079780e1922 Author: Jeffrey Kardatzke <jkardatzke@google.com> Date: Fri Apr 5 17:43:18 2019 +0000 Fix .vscode dir ignoring VSCode is creating .vscode dirs within the subdirs of my checkout, and to get it to ignore them this change is needed. Bug: None Change-Id: I7b7ffc1ae89907c8cbc1adc42b9e43ffe8fc1e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553391 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#648241} .gitignore | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 752f807f31a2fe02024234b82ee07a765323d0f7 Author: Yann Dago <ydago@chromium.org> Date: Fri Apr 5 17:42:00 2019 +0000 Management WebUI: Do not show consumer email addresses in the page Currently if you log into chrome with a consumer email, it will show that gmail or googlemail manages your account when it is not true. Bug: 949500 Change-Id: Ida3d61b88702026bce9b3a0132f058afd42dbbfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553507 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#648240} chrome/browser/ui/webui/management_ui_handler.cc | 15 ++++-- .../ui/webui/management_ui_handler_unittest.cc | 53 ++++++++++++++++++++++ 2 files changed, 65 insertions(+), 3 deletions(-) commit 781a1ccc8e2f544aef938fa93e3c22a2b5a53e7f Author: Willie Koomson <wvk@google.com> Date: Fri Apr 5 17:39:50 2019 +0000 Remove NewProcessTypes feature and turn on new process types This commit removes the NewProcessTypes feature and turns on the new process types by default. TBR=cmtm@chromium.org Test: TabManagerDelegate unit tests and manual memory pressure tests Bug: 920015 Change-Id: Ia814d0d109e3c971aa4eed91cf53911a6320910d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1468264 Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: Willie Koomson <wvk@google.com> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Chris Morin <cmtm@chromium.org> Cr-Commit-Position: refs/heads/master@{#648239} chrome/browser/chromeos/arc/process/arc_process.cc | 4 +- .../browser/resource_coordinator/lifecycle_unit.cc | 8 +- .../browser/resource_coordinator/lifecycle_unit.h | 2 +- .../tab_manager_delegate_chromeos.cc | 66 ++---------- .../tab_manager_delegate_chromeos.h | 61 ++++++----- .../tab_manager_delegate_chromeos_unittest.cc | 120 +++++++++++---------- .../resource_coordinator/tab_manager_features.cc | 7 -- .../resource_coordinator/tab_manager_features.h | 3 - .../resource_coordinator/test_lifecycle_unit.cc | 3 +- .../resource_coordinator/test_lifecycle_unit.h | 3 + 10 files changed, 119 insertions(+), 158 deletions(-) commit 9a333abe37431413a944343885aa62f96a3a13c1 Author: Mike Wittman <wittman@chromium.org> Date: Fri Apr 5 17:39:41 2019 +0000 [Sampling profiler] Support adding an auxiliary unwinder Adds the plumbing to supply an auxiliary unwinder to the StackSamplingProfiler, to be used in addition to the native unwinder. This functionality will be used to supply a custom unwinder for v8 frames. Bug: 909957 Change-Id: I3d5211ea6a1c508ac9d733d584debb1af13a315c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554250 Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#648238} base/profiler/stack_sampler.h | 5 ++++ base/profiler/stack_sampler_impl.cc | 4 +++ base/profiler/stack_sampler_impl.h | 4 ++- base/profiler/stack_sampling_profiler.cc | 34 ++++++++++++++++++++++ base/profiler/stack_sampling_profiler.h | 5 ++++ chrome/common/thread_profiler.cc | 9 ++++++ chrome/common/thread_profiler.h | 8 +++++ components/tracing/common/stack_sampler_android.cc | 4 +++ components/tracing/common/stack_sampler_android.h | 3 +- 9 files changed, 74 insertions(+), 2 deletions(-) commit fbddc8e85863c3462850f4911ea143809a49fa73 Author: Min Qin <qinmin@chromium.org> Date: Fri Apr 5 17:38:46 2019 +0000 Use default download directory first if the last download dir is not writable This CL asks Chrome to use the default download dir first if the last download dir is no longer writable. If the default download dir is empty or if is the same as the last download dir, fallback_directory will be used. BUG=913282 Change-Id: I3f7427dae168f2237ec944001e1322bb538c6ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553800 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#648237} .../internal/common/download_path_reservation_tracker.cc | 15 ++++++++++----- .../common/download_path_reservation_tracker_unittest.cc | 14 +++++++++++++- 2 files changed, 23 insertions(+), 6 deletions(-) commit 3dcda026398c62e90ae30195e720edee7aa1a903 Author: Alexei Filippov <alph@chromium.org> Date: Fri Apr 5 17:38:36 2019 +0000 Revert "Use a per-frame task runner at mojom::SafeBrowsing binding" This reverts commit 62d62d74162a0dbe87705d711f18bb2e215431aa. Reason for revert: Made ServiceWorkerTest.UpdateRefreshesServiceWorker superflaky https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNjJkNjJkNzQxNjJhMGRiZTg3NzA1ZDcxMWYxOGJiMmUyMTU0MzFhYQw Original change's description: > Use a per-frame task runner at mojom::SafeBrowsing binding > > This CL switches task runners at several places from per-thread to > per-frame. The purpose of this change is to make it possible to freeze > tasks for bfcache. > > We found an actual case that JavaScript is executed: > ./tools/perf/run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:media:soundcloud:2018 > > As this is a non-standard JavaScript API execution, we adopted > kInternalDefault as the task type. > > Bug: 913912 > Change-Id: I512355bda609c82be436e1fa1c162a74ab8b046a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536036 > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647684} TBR=avi@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org NOTRY=true # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 913912 Change-Id: I28b764182d3e4bb80cfe68365283ccbc0b905139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553872 Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#648236} .../renderer/url_loader_throttle_provider_impl.cc | 31 ++++++---------------- .../renderer/url_loader_throttle_provider_impl.h | 5 ---- 2 files changed, 8 insertions(+), 28 deletions(-) commit 792e4f17187c9155a6c1dbf55334f5d159443858 Author: Ella Ge <eirage@chromium.org> Date: Fri Apr 5 17:32:15 2019 +0000 Reland "Make AverageLag calculation keeps track of accumulated delta" This reverts commit 40da44663947df7efe3c63f39a066ef765dc84b8. Reason for revert: Reland with fixes The tests was failing on MSAN build due to use-of-uninitialized-value. This is because two values in the class missed " = 0". Original change's description: > Revert "Make AverageLag calculation keeps track of accumulated delta" > > This reverts commit ffb9f231a67d7fb6b18144acb6356f50cb56ab35. > > Reason for revert: this patch causes the following failures on Linux ChromiumOS MSan Tests. > e.g. > https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests > non_single_process_mash_content_unittests, viz_content_unittests, non_single_process_mash_content_browsertests, content_browsertests, content_unittests > > content_unittests: > RenderWidgetHostLatencyTrackerTest.TestTouchToScrollHistograms > [ RUN ] RenderWidgetHostLatencyTrackerTest.TestTouchToScrollHistograms > ==21893==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x558c7b1b0740 in ui::AverageLagTracker::LagBetween(base::TimeTicks, base::TimeTicks, ui::LatencyInfo const&, base::TimeTicks) ./../../ui/latency/average_lag_tracker.cc:120:7 > #1 0x558c7b1ae316 in ui::AverageLagTracker::AddLatencyInFrame(ui::LatencyInfo const&, base::TimeTicks, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../ui/latency/average_lag_tracker.cc:87:11 > #2 0x558c7b1d325a in ui::LatencyTracker::ComputeEndToEndLatencyHistograms(base::TimeTicks, base::TimeTicks, ui::LatencyInfo const&) ./../../ui/latency/latency_tracker.cc:263:26 > #3 0x558c7b1d111a in ui::LatencyTracker::OnGpuSwapBuffersCompleted(ui::LatencyInfo const&) ./../../ui/latency/latency_tracker.cc:113:5 > #4 0x558c75f1435f in content::RenderWidgetHostLatencyTrackerTest_TestTouchToScrollHistograms_Test::TestBody() ./../../content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc:633:22 > > > Original change's description: > > Make AverageLag calculation keeps track of accumulated delta > > > > Previous we calculate the Lag area per events and seperate into two reports > > by the 1 second gap. However that design does not work well with scroll > > prediction. > > > > This CL changes following: > > 1. Rewrites the AverageLag calculation to compute the area between the > > accumulated_event_delta_(actual finger absolute scroll position) and the > > rendered_accumulated_delta_ (rendered absolute scroll position). > > Detail see the explainer doc: > > https://docs.google.com/document/d/1e8NuzPblIv2B9bz01oSj40rmlse7_PHq5oFS3lqz6N4/ > > > > 2. Wrap the AverageLag into a AverageLagTracker class, so fields only for > > AverageLag wouldn't be access by other part of LatencyTracker. And also > > add unit tests. > > 3. Because the latency_info.scroll_update_delta is initialize at browser, > > where the event delta is in DIP coordinate space. All events are scale to > > physical pixel when route to renderer, so we also need to scale the > > latency_info together with the events. > > > > Bug: 946212 > > Change-Id: Iec2b3fdbd866efe71fe6e0066cee831e30316261 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542222 > > Commit-Queue: Ella Ge <eirage@chromium.org> > > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#647989} > > TBR=tdresser@chromium.org,nzolghadr@chromium.org,eirage@chromium.org > > Change-Id: Id4b581628937ccd697f74713402c3a55201eed13 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 946212 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554206 > Reviewed-by: Takashi Sakamoto <tasak@google.com> > Commit-Queue: Takashi Sakamoto <tasak@google.com> > Cr-Commit-Position: refs/heads/master@{#648077} TBR=tasak@google.com,tdresser@chromium.org,nzolghadr@chromium.org,eirage@chromium.org Bug: 946212 Change-Id: Id052a34f814fb616bb8f4738ab6d9a2f1d66fcff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554736 Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#648235} .../renderer_host/input/input_router_impl.cc | 22 +- .../render_widget_host_latency_tracker_unittest.cc | 111 --------- ui/latency/BUILD.gn | 3 + ui/latency/average_lag_tracker.cc | 159 +++++++++++++ ui/latency/average_lag_tracker.h | 78 +++++++ ui/latency/average_lag_tracker_unittest.cc | 248 +++++++++++++++++++++ ui/latency/latency_tracker.cc | 130 +---------- ui/latency/latency_tracker.h | 38 +--- 8 files changed, 508 insertions(+), 281 deletions(-) commit 725918214a97bdbd1453cd49b6e3d6b9d8762a4a Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 5 17:31:14 2019 +0000 Disable flaky tests The tests specifically fail in chromeos. But disabling the test completely for now. Bug: 950008 Change-Id: Ie79786d3e2249a71f883b744c0c403b39c6c5be1 notry: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554829 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648234} .../browser/data_reduction_proxy/data_reduction_proxy_browsertest.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 55bf732665277d0ccdb864eef88db2586f8e3d01 Author: Kurt Catti-Schmidt <kschmi@microsoft.com> Date: Fri Apr 5 17:29:01 2019 +0000 AXPosition::CreateNextCharacterPosition stops short of last character CreateNextCharacterPosition has a restriction that enforces it to be strictly less than MaxTextOffset. This restriction prevents it from reaching the end of an anchor. This change allows CreateNextCharacterPosition to reach MaxTextOffset (and thus the end of an anchor). Unit tests were updated and added for this scenario. Bug: 928948 Change-Id: Ic4781120e91c2c9f3d3d12ba05f86e949be64f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536807 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#648233} ui/accessibility/ax_node_position_unittest.cc | 40 +++++++++++++++++++-------- ui/accessibility/ax_position.h | 7 +++-- 2 files changed, 34 insertions(+), 13 deletions(-) commit b88212eca7de98368fcbb57db8601ae7b489009c Author: Eugene But <eugenebut@google.com> Date: Fri Apr 5 17:28:57 2019 +0000 Call SetKeepRenderProcessAlive on WebState in ios/web tests. This should prevent tests from flakily failing on devices. Also adjust expectations in ForwardPostNavigation because ShouldAllowResponse is not called after SetKeepRenderProcessAlive is set to true. Bug: 948963, 948973, 948970, 948968, 948966, 944886 Change-Id: I21d20d9bf9484417aa4f2e3ef5a45047cbea2988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553501 Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#648232} ios/web/test/web_int_test.mm | 1 + ios/web/web_state/web_state_observer_inttest.mm | 9 ++------- ios/web/web_state/web_state_unittest.mm | 3 +++ 3 files changed, 6 insertions(+), 7 deletions(-) commit 957715a4815e74b33f689714d9d5d9d54c84223e Author: Raul Tambre <raul@tambre.ee> Date: Fri Apr 5 17:26:09 2019 +0000 Support Python 3 in //chrome/browser/resources/discards/generate_graph_tab.py The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I3d827e2281ac5249062540c1f330371bb9d14ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554677 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#648231} chrome/browser/resources/discards/generate_graph_tab.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit c179aecf42ee0caf5e9c25d7b70ec99f8dccae39 Author: Alexei Filippov <alph@chromium.org> Date: Fri Apr 5 17:24:47 2019 +0000 Revert "Bypass ThemePainter for text fields when dark mode enabled." This reverts commit 64ad1dfdf791ee9a44fa788bef1882ff0835c876. Reason for revert: virtual/dark-mode/paint/dark-mode/native-theme-on/text-input-elements.html does not work on Mac https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20(retina)/12336 Original change's description: > Bypass ThemePainter for text fields when dark mode enabled. > > This is a temporary workaround until a concept of dark mode can be > added to ThemePainter, as discussed in this email thread from > chromium-dev@: > > https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/q7BXL6rpY9A > > Bug: 937872 > Change-Id: Ia928775fe95d5de42ae295c2f644bcb3ec85413c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539888 > Commit-Queue: Aran Gilman <gilmanmh@google.com> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648196} TBR=futhark@chromium.org,gilmanmh@google.com Change-Id: Icfc9a65f7a7ee612fb4f9a8b3643dc2769dedc7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 937872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554887 Reviewed-by: Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#648230} .../blink/renderer/core/paint/theme_painter_default.cc | 12 ++---------- third_party/blink/web_tests/VirtualTestSuites | 10 ---------- .../dark-mode/native-theme-off/text-input-elements.html | 1 - .../dark-mode/native-theme-on/text-input-elements.html | 1 - .../native-theme-off/text-input-elements-expected.png | Bin 3031 -> 0 bytes .../native-theme-on/text-input-elements-expected.png | Bin 2961 -> 0 bytes .../native-theme-off/text-input-elements-expected.png | Bin 1831 -> 0 bytes .../native-theme-on/text-input-elements-expected.png | Bin 1784 -> 0 bytes .../native-theme-off/text-input-elements-expected.png | Bin 3018 -> 0 bytes .../native-theme-on/text-input-elements-expected.png | Bin 2984 -> 0 bytes .../native-theme-off/text-input-elements-expected.png | Bin 1815 -> 0 bytes .../native-theme-on/text-input-elements-expected.png | Bin 1767 -> 0 bytes .../native-theme-off/text-input-elements-expected.png | Bin 3031 -> 0 bytes .../native-theme-on/text-input-elements-expected.png | Bin 2961 -> 0 bytes .../native-theme-off/text-input-elements-expected.png | Bin 1830 -> 0 bytes .../native-theme-on/text-input-elements-expected.png | Bin 1782 -> 0 bytes .../paint/dark-mode/native-theme-off/README.txt | 3 --- .../dark-mode/paint/dark-mode/native-theme-on/README.txt | 3 --- 18 files changed, 2 insertions(+), 28 deletions(-) commit 4c6cf6c689a168f7ae4406a27e635f2ca4e3d699 Author: Hector Carmona <hcarmona@chromium.org> Date: Fri Apr 5 17:21:16 2019 +0000 Navi Dark Mode: Organize icons and add dark mode variants. Bug: 943628 Change-Id: Iffdf3c54f272e438403cdaaecc1b7864a5e01e91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549991 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#648229} .../onboarding_welcome/email/nux_email.html | 8 +- .../google_apps/nux_google_apps.html | 8 +- .../images/email_provider_1x.png | Bin 1107 -> 0 bytes .../images/email_provider_2x.png | Bin 1956 -> 0 bytes .../onboarding_welcome/images/google_apps_1x.png | Bin 1154 -> 0 bytes .../onboarding_welcome/images/google_apps_2x.png | Bin 2207 -> 0 bytes .../images/module_icons/email_dark.svg | 1 + .../images/module_icons/email_light.svg | 1 + .../images/module_icons/google_dark.svg | 1 + .../images/module_icons/google_light.svg | 1 + .../images/module_icons/set_default_dark.svg | 1 + .../images/module_icons/set_default_light.svg | 1 + .../images/module_icons/wallpaper_dark.svg | 1 + .../images/module_icons/wallpaper_light.svg | 1 + .../images/ntp_background_1x.png | Bin 1408 -> 0 bytes .../images/ntp_background_2x.png | Bin 2761 -> 0 bytes .../images/set_as_default_1x.png | Bin 1361 -> 0 bytes .../images/set_as_default_2x.png | Bin 2662 -> 0 bytes .../ntp_background/nux_ntp_background.html | 8 +- .../onboarding_welcome_resources.grd | 180 +++++++++++---------- .../set_as_default/nux_set_as_default.html | 8 +- .../ui/webui/welcome/welcome_ui_unittest.cc | 2 +- 22 files changed, 123 insertions(+), 99 deletions(-) commit f091fe9429dc5fe310a9a35e52276b08e4474b80 Author: Nate Chapin <japhet@chromium.org> Date: Fri Apr 5 17:20:46 2019 +0000 Drop a '0' I accidentally added to a timeout Change-Id: I97c225586d4cf78c1c4061152e82671974feaa65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554821 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#648228} third_party/blink/web_tests/http/tests/resources/slow-notify-done.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e10c0ea0e9a48a0e33e596292f5e05e7c24cc238 Author: Daniel Cheng <dcheng@chromium.org> Date: Fri Apr 5 17:19:38 2019 +0000 Change net::IsPortAllowedForScheme to pass scheme by base::StringPiece. Change-Id: I925ceed806682d1ec69e7699a7f12350241185fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553678 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#648227} content/renderer/pepper/pepper_websocket_host.cc | 3 ++- net/base/port_util.cc | 2 +- net/base/port_util.h | 3 ++- net/http/http_stream_factory_job.cc | 2 +- net/url_request/ftp_protocol_handler.cc | 2 +- third_party/blink/renderer/platform/weborigin/known_ports.cc | 2 +- 6 files changed, 8 insertions(+), 6 deletions(-) commit 85a3821e53b90b747cd014134540496d82b80084 Author: rajendrant <rajendrant@chromium.org> Date: Fri Apr 5 17:17:14 2019 +0000 Enable site-breakdown with PLM feature by default This CL removes the feature since the code is enabled. Bug: 949778 Change-Id: I470bbee9f4eb4f9415daadf1d18267c5ec141680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554127 Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#648226} .../data_saver_site_breakdown_metrics_observer.cc | 2 -- ..._site_breakdown_metrics_observer_browsertest.cc | 6 +--- .../data_reduction_proxy_data_use_observer.cc | 2 -- .../data_reduction_proxy_network_delegate.cc | 3 +- ...ta_reduction_proxy_network_delegate_unittest.cc | 4 --- .../core/common/data_reduction_proxy_features.cc | 6 ---- .../core/common/data_reduction_proxy_features.h | 1 - .../core/common/data_reduction_proxy_params.cc | 6 ---- .../core/common/data_reduction_proxy_params.h | 4 --- testing/variations/fieldtrial_testing_config.json | 34 ---------------------- 10 files changed, 2 insertions(+), 66 deletions(-) commit 424a65cd192f3c6ce5ca8f33be00fa5d27a07e36 Author: Peng Huang <penghuang@chromium.org> Date: Fri Apr 5 17:16:44 2019 +0000 SharedImage: do not pass sk_surface to BeginReadAccess(). We pass sk_surface to BeginReadAccess(), because it is used to flush in EndReadAccess(). But calling flush() in EndReadAccess() is not good, because EndReadAccess() could be called by another skia flush() call indirectlly. Also we don't want the representation to hold a ref of a sk surface. It is because the sk surface could be backing by a swapchain image, when the window is resized, the backing image will be destroyed, hold a ref of the sk surface is not safe. Bug: 934254 Change-Id: Iff12be608a776c8f4e80fca20880d5b5d0c45142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545986 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648225} .../skia_output_surface_impl_non_ddl.cc | 12 +--- .../skia_output_surface_impl_on_gpu.cc | 3 +- .../external_vk_image_skia_representation.cc | 28 +++++--- .../external_vk_image_skia_representation.h | 8 ++- ...shared_image_backing_factory_ahardwarebuffer.cc | 79 +++++++++++----------- ...age_backing_factory_ahardwarebuffer_unittest.cc | 34 +++------- .../shared_image_backing_factory_gl_texture.cc | 2 +- ...ed_image_backing_factory_gl_texture_unittest.cc | 4 +- .../shared_image_backing_factory_iosurface.mm | 2 +- ...red_image_backing_factory_iosurface_unittest.cc | 4 +- .../service/shared_image_representation.h | 3 +- gpu/command_buffer/service/wrapped_sk_image.cc | 2 +- 12 files changed, 80 insertions(+), 101 deletions(-) commit 8746bab81873ac4f5277a99e10c8988eb20a3dc3 Author: Patrick Monette <pmonette@chromium.org> Date: Fri Apr 5 17:16:03 2019 +0000 Remove the kAugmentedZoneIdentifier feature Now always add the source and referrer URLs on Windows 10+ when not using the Attachment Services. Bug: 949656 Change-Id: Ia55f59a679a1f521a697ed1e2193ed24d030f2d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553803 Reviewed-by: Asanka Herath <asanka@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#648224} .../download/quarantine/quarantine_features_win.cc | 5 - .../download/quarantine/quarantine_features_win.h | 2 - components/download/quarantine/quarantine_win.cc | 8 +- .../download/quarantine/quarantine_win_unittest.cc | 153 ++------------------- 4 files changed, 17 insertions(+), 151 deletions(-) commit c2b8a9e48016bc8f04f680cb7e8e1e56f3659aa3 Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Fri Apr 5 17:10:52 2019 +0000 Removed #import <EarlGrey/EarlGrey.h> from web_view_shell_matchers.h EG1 and EG2 do not share a common set of headers, so any file that directly includes EarlGrey.h cannot be compiled under EG2. Scrubbing the headers will enable us (in a future CL) to share these helpers between EG1 and EG2. Bug: 922813 Change-Id: I63f062e61ef84b0f467712ecf190eb21e100fed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553900 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Cr-Commit-Position: refs/heads/master@{#648223} ios/web_view/shell/test/earl_grey/web_view_shell_matchers.h | 4 +++- ios/web_view/shell/test/earl_grey/web_view_shell_matchers.mm | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) commit acb8dcbf28182032547a686f7bacae7c315c26e2 Author: Camille Lamy <clamy@chromium.org> Date: Fri Apr 5 17:09:57 2019 +0000 Fix DidCreateNewEntry in NavigationSimulator This CL fixes the way we compute whether the navigation resulted in a new NavigationEntry in NavigationSimulator, fixes some unit_tests that were relying on improper behavior and converts some content_unittests that needed the behavior fixed to switch to using NavigationSimulator. Bug: 728571 Change-Id: I087c0882f2f1bcc804a843b0ece1f7cc4bc36bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550444 Auto-Submit: Camille Lamy <clamy@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: François Doray <fdoray@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#648222} .../complex_tasks/task_tab_helper_unittest.cc | 24 ++++++++----- .../tab_metrics_logger_unittest.cc | 2 +- .../ui/toolbar/back_forward_menu_model_unittest.cc | 13 +++++-- .../navigation_controller_impl_unittest.cc | 41 ++++++++-------------- content/test/navigation_simulator_impl.cc | 21 ++++++++--- content/test/navigation_simulator_impl.h | 9 ++++- 6 files changed, 67 insertions(+), 43 deletions(-) commit 37de4c4dd2cc58d547efe9d3da8c900906499369 Author: Xing Liu <xingliu@chromium.org> Date: Fri Apr 5 17:06:30 2019 +0000 Download: Add a feature flag for showing SD card image in gallery app. This CL adds a feature flag for showing image download on external SD card in Android gallery app. Bug: 924940 Change-Id: I6bcc84f6ceaf5070216296fdeb258d20cfcb5487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554131 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648221} .../java/src/org/chromium/chrome/browser/ChromeFeatureList.java | 2 ++ chrome/browser/android/chrome_feature_list.cc | 4 ++++ chrome/browser/android/chrome_feature_list.h | 1 + 3 files changed, 7 insertions(+) commit 4c919d144a51d016da7cd5192d2e0e78086f81ce Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 5 17:05:49 2019 +0000 [remoting][FTL] Use new ChromotingMessage This CL updates the ChromotingMessage definition to keep in sync with the internal version. Bug: 947337 Change-Id: I63828203e8480d24c8eb706221eded5c262dff2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554191 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#648220} remoting/signaling/BUILD.gn | 1 + remoting/signaling/chromoting_message.proto | 21 +++++++ remoting/signaling/ftl.proto | 4 -- remoting/signaling/ftl_messaging_client.cc | 9 +-- remoting/signaling/ftl_messaging_client.h | 14 ++--- .../signaling/ftl_messaging_client_unittest.cc | 69 +++++++++++++--------- remoting/test/ftl_services_playground.cc | 9 ++- remoting/test/ftl_services_playground.h | 2 +- 8 files changed, 81 insertions(+), 48 deletions(-) commit ca503c2e02b3227a2c91e2855c862484aea07219 Author: Yusuf Ozuysal <yusufo@google.com> Date: Fri Apr 5 17:04:51 2019 +0000 Add a new feature flag to control downloading DFM This adds a new feature flag to control downloading the Tab Management DFM so that it is possible to have a control group that also attempts to download as well. Three different groups are registered in two synthetic fields trials 1) DownloadAttempted 2) Downloaded/Disabled 3) Downloaded/Enabled 3 is the baseline for users getting the feature. BUG=944683 Change-Id: Ib414135197135e506887eb91acbe67315c9e9726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535170 Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#648219} .../tab_management/TabGroupUiCoordinator.java | 9 ++++++++ .../tab_management/TabManagementModuleImpl.java | 9 ++++++++ .../TabManagementModuleProvider.java | 24 ++++++++++++++++++++++ .../chromium/chrome/browser/ChromeFeatureList.java | 1 + .../chrome/browser/util/FeatureUtilities.java | 16 +++++++++++---- chrome/browser/android/chrome_feature_list.cc | 4 ++++ chrome/browser/android/chrome_feature_list.h | 1 + 7 files changed, 60 insertions(+), 4 deletions(-) commit b4bf6cdc3828877bc3fe822c8cfd32a4a5073d05 Author: Steven Bennetts <stevenjb@chromium.org> Date: Fri Apr 5 17:02:57 2019 +0000 Extract Shill clients from DBusThreadManager Currently DBusThreadManager owns both the dbus::Bus instance, the dbus thread, and all dbus clients. This makes it impossible to restrict clients to specific processes (i.e. chrome and ash). This CL extracts the Shill clients which will eventually be chrome only. Note: This keeps the DBusThreadManager accessors to avoid unnecessary churn in src/chrome code, since src/chrome will depend on both DBusThreadManager and chromeos/network (and therefore chromeos/dbus/shill) for the foreseeable future. It does however remove dependencies from chromeos/network so that the //chromeos/dbus dependency can be removed from there in a followup. Bug: 948390 Change-Id: I665cf36dd154753a61d4dc65891ef84af1164e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552419 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#648218} .../api/vpn_provider/vpn_provider_apitest.cc | 92 ++++------- chromeos/dbus/BUILD.gn | 2 + chromeos/dbus/README.md | 9 ++ chromeos/dbus/dbus_clients_common.cc | 72 --------- chromeos/dbus/dbus_clients_common.h | 19 --- chromeos/dbus/dbus_thread_manager.cc | 68 +++----- chromeos/dbus/dbus_thread_manager.h | 22 ++- chromeos/dbus/shill/fake_gsm_sms_client.cc | 12 +- chromeos/dbus/shill/fake_gsm_sms_client.h | 7 - chromeos/dbus/shill/fake_modem_messaging_client.cc | 2 - chromeos/dbus/shill/fake_modem_messaging_client.h | 1 - chromeos/dbus/shill/fake_shill_device_client.cc | 36 ++--- chromeos/dbus/shill/fake_shill_device_client.h | 1 - chromeos/dbus/shill/fake_shill_ipconfig_client.cc | 4 +- chromeos/dbus/shill/fake_shill_ipconfig_client.h | 1 - chromeos/dbus/shill/fake_shill_manager_client.cc | 59 +++---- chromeos/dbus/shill/fake_shill_manager_client.h | 1 - chromeos/dbus/shill/fake_shill_profile_client.cc | 27 +--- chromeos/dbus/shill/fake_shill_profile_client.h | 1 - chromeos/dbus/shill/fake_shill_service_client.cc | 52 ++----- chromeos/dbus/shill/fake_shill_service_client.h | 1 - .../fake_shill_third_party_vpn_driver_client.cc | 2 - .../fake_shill_third_party_vpn_driver_client.h | 1 - chromeos/dbus/shill/fake_sms_client.cc | 5 +- chromeos/dbus/shill/fake_sms_client.h | 1 - chromeos/dbus/shill/gsm_sms_client.cc | 43 ++++-- chromeos/dbus/shill/gsm_sms_client.h | 23 ++- chromeos/dbus/shill/gsm_sms_client_unittest.cc | 12 +- chromeos/dbus/shill/modem_messaging_client.cc | 41 ++++- chromeos/dbus/shill/modem_messaging_client.h | 22 ++- .../dbus/shill/modem_messaging_client_unittest.cc | 12 +- chromeos/dbus/shill/shill_clients.cc | 60 +++++++ chromeos/dbus/shill/shill_clients.h | 29 ++++ chromeos/dbus/shill/shill_device_client.cc | 45 ++++-- chromeos/dbus/shill/shill_device_client.h | 29 ++-- .../dbus/shill/shill_device_client_unittest.cc | 11 +- chromeos/dbus/shill/shill_ipconfig_client.cc | 50 ++++-- chromeos/dbus/shill/shill_ipconfig_client.h | 25 +-- .../dbus/shill/shill_ipconfig_client_unittest.cc | 11 +- chromeos/dbus/shill/shill_manager_client.cc | 44 ++++-- chromeos/dbus/shill/shill_manager_client.h | 25 +-- .../dbus/shill/shill_manager_client_unittest.cc | 11 +- chromeos/dbus/shill/shill_profile_client.cc | 44 ++++-- chromeos/dbus/shill/shill_profile_client.h | 27 ++-- .../dbus/shill/shill_profile_client_unittest.cc | 11 +- chromeos/dbus/shill/shill_service_client.cc | 42 +++-- chromeos/dbus/shill/shill_service_client.h | 30 ++-- .../dbus/shill/shill_service_client_unittest.cc | 11 +- .../shill/shill_third_party_vpn_driver_client.cc | 50 ++++-- .../shill/shill_third_party_vpn_driver_client.h | 30 +++- ...shill_third_party_vpn_driver_client_unittest.cc | 11 +- chromeos/dbus/shill/sms_client.cc | 41 +++-- chromeos/dbus/shill/sms_client.h | 22 ++- .../geolocation/simple_geolocation_unittest.cc | 15 +- chromeos/network/auto_connect_handler.cc | 3 +- chromeos/network/client_cert_resolver.cc | 3 +- chromeos/network/client_cert_resolver_unittest.cc | 18 +-- .../network/fast_transition_observer_unittest.cc | 9 +- chromeos/network/geolocation_handler.cc | 15 +- chromeos/network/geolocation_handler_unittest.cc | 10 +- ...naged_network_configuration_handler_unittest.cc | 20 ++- chromeos/network/network_activation_handler.cc | 24 ++- chromeos/network/network_cert_migrator.cc | 8 +- chromeos/network/network_cert_migrator_unittest.cc | 15 +- chromeos/network/network_configuration_handler.cc | 26 ++-- .../network_configuration_handler_unittest.cc | 25 ++- chromeos/network/network_connect_unittest.cc | 12 +- chromeos/network/network_connection_handler.cc | 1 - .../network/network_connection_handler_impl.cc | 5 +- chromeos/network/network_device_handler_impl.cc | 51 +++--- .../network/network_device_handler_unittest.cc | 16 +- chromeos/network/network_profile_handler.cc | 14 +- chromeos/network/network_sms_handler.cc | 42 +++-- chromeos/network/network_sms_handler_unittest.cc | 9 +- chromeos/network/network_state_handler_unittest.cc | 172 +++++++++------------ chromeos/network/network_state_test_helper.cc | 28 ++-- chromeos/network/network_state_test_helper.h | 2 +- chromeos/network/policy_applicator.cc | 16 +- chromeos/network/proxy/proxy_config_handler.cc | 8 +- .../proxy/proxy_config_service_impl_unittest.cc | 6 +- .../proxy/ui_proxy_config_service_unittest.cc | 8 +- chromeos/network/shill_property_handler.cc | 32 ++-- .../network/shill_property_handler_unittest.cc | 47 +++--- 83 files changed, 1022 insertions(+), 948 deletions(-) commit 476115b6c94da667feaa450ededc696528060fcf Author: John Budorick <jbudorick@chromium.org> Date: Fri Apr 5 17:02:06 2019 +0000 Add sizes to the luci cronet bots. Still need to resolve perf dashboard uploads, though. Bug: 861983 Change-Id: Ic8fb6bdcb15ce9cb07a5e6de639db69246839fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553036 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648217} testing/buildbot/chromium.android.json | 36 ++++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 16 +++++++++++++++ 2 files changed, 52 insertions(+) commit c8a4e62df6f9e7422d1f047004a1abaeec0f52ce Author: Mike Wasserman <msw@chromium.org> Date: Fri Apr 5 17:01:47 2019 +0000 Remove WidgetCreationType; use WindowService::IsProxyWindow instead Bug: 865616 Test: No regressions cycling focus, etc. Change-Id: Ia3c676b70e2611c9e5f04682f1f82f6e3ffcc16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551458 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#648216} ash/wm/non_client_frame_controller.cc | 1 - ash/wm/top_level_window_factory_unittest.cc | 2 -- ash/wm/widget_finder.cc | 9 ++++----- ash/wm/window_properties.cc | 5 ----- ash/wm/window_properties.h | 23 ----------------------- 5 files changed, 4 insertions(+), 36 deletions(-) commit 37663bcca78b1a5154560a27f7496cf408b74167 Author: Guido Urdaneta <guidou@chromium.org> Date: Fri Apr 5 17:00:06 2019 +0000 [RTCPeerConnection] Update negotiationneeded tests and expectations The failure expectations will be updated once the WebRTC fix for negotiationneeded is rolled into Chrome. See https://webrtc-review.googlesource.com/c/src/+/131283 Bug: 740501 Change-Id: Ib2cc7b4c05f65e678bb23fe7d6c531f91a2bc92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552868 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#648215} third_party/blink/web_tests/TestExpectations | 5 + ...PeerConnection-onnegotiationneeded-expected.txt | 10 -- .../RTCPeerConnection-onnegotiationneeded.html | 138 +++++++++++++++++++-- .../RTCPeerConnection-AddRemoveStream.html | 10 +- 4 files changed, 134 insertions(+), 29 deletions(-) commit a86fffe480067543ee1eb6523bc317a50c7267aa Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Apr 5 16:58:12 2019 +0000 [remoting][FTL] Add FTL channel type to SignalingAddress This CL adds an FTL channel type to SignalingAddress. It translates FTL username and registration ID into a JID like format, which will be used by the existing Jingle session stack when using FTL messaging service. The format definition is local to the binary and irrelevant to the wire format. Bug: 947337 Change-Id: I5c9292a7198dae42f69c195b4291b6ff5b5c8bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552439 Reviewed-by: Joe Downing <joedow@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#648214} remoting/signaling/signaling_address.cc | 53 +++++++++++++++++++++--- remoting/signaling/signaling_address.h | 17 +++++++- remoting/signaling/signaling_address_unittest.cc | 50 ++++++++++++++++++++++ 3 files changed, 112 insertions(+), 8 deletions(-) commit a85f2591c6c428140541dc16d17cfb54a11decfa Author: Xida Chen <xidachen@chromium.org> Date: Fri Apr 5 16:58:08 2019 +0000 Implement PaintWorkletProxyClient::Paint (6/6) This is part of a prototype: https://chromium-review.googlesource.com/c/chromium/src/+/1495445 This CL impelments the PaintWorkletProxyClient::Paint function, which retrieves the CSSPaintDefinition from its associated global scope, and call the Paint function on it, to execute the JS paint callback, and obtain the PaintRecord as a result. In the PaintWorkletPaintDispatcher::Paint, we go through the painter map and use the worklet_id as a key to find the right painter to paint the current image. TBR=andruud@chromium.org Bug: 884698 Change-Id: Ib5ee44b5dd5f613e1ae4abc5bc1869f3b825de82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531153 Reviewed-by: Xida Chen <xidachen@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#648213} cc/paint/paint_worklet_input.h | 1 + cc/test/test_paint_worklet_input.cc | 4 ++ cc/test/test_paint_worklet_input.h | 2 + .../renderer/core/css/cssom/paint_worklet_input.h | 2 +- .../modules/csspaint/css_paint_definition.cc | 19 ++---- .../modules/csspaint/css_paint_definition.h | 12 ++-- .../renderer/modules/csspaint/paint_worklet.cc | 21 ++++++- .../modules/csspaint/paint_worklet_proxy_client.cc | 13 +++++ .../modules/csspaint/paint_worklet_proxy_client.h | 5 ++ .../csspaint/paint_worklet_proxy_client_test.cc | 67 ++++++++++++++++++++++ .../modules/csspaint/paint_worklet_test.cc | 16 +++++- .../graphics/paint_worklet_paint_dispatcher.cc | 59 ++++++++++++++++++- .../graphics/paint_worklet_paint_dispatcher.h | 6 ++ .../platform/graphics/paint_worklet_painter.h | 3 + .../platform_paint_worklet_layer_painter.h | 2 + 15 files changed, 205 insertions(+), 27 deletions(-) commit bf0774a94184c835d58fa1cc38533ddad3051e1b Author: Aga Wronska <agawronska@chromium.org> Date: Fri Apr 5 16:49:14 2019 +0000 Enable ParentAccessCode feature by default Bug: 943765 Change-Id: I6b089e88046ec4a6c59234470ee9398d033ad710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553311 Reviewed-by: Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#648212} .../event_based_status_reporting_service_unittest.cc | 8 ++++++++ .../parent_access_code/parent_access_service_unittest.cc | 2 +- chrome/common/chrome_features.cc | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) commit bc8808864443e1c10bc3657cde87d3d17c1bc1ce Author: Alex Clarke <alexclarke@chromium.org> Date: Fri Apr 5 16:48:00 2019 +0000 Prioritize StartupTaskRunner tasks On android this is used to split the BrowserMainLoop startup tasks into chunks. The original reasoning was because startup was slow and to allow input events to process. Currently that doesn't work because the android message pump processes all C++ tasks before yielding, however long term the scheduler team would like to fix that. So rather than remove the android task runner we just prioritise. Bug: 863341 Change-Id: Ic8f8c3c17a79678bdace8a5141ef490cb5bb01de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550452 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648211} content/browser/browser_main_loop.cc | 19 ++++++++++++++++- content/browser/browser_main_loop.h | 6 ++++++ .../browser/scheduler/UiThreadSchedulerTest.java | 7 +++++++ content/public/test/android/BUILD.gn | 3 +++ .../test/util/UiThreadSchedulerTestUtils.java | 24 ++++++++++++++++++++++ .../test/android/ui_thread_scheduler_test_utils.cc | 17 +++++++++++++++ 6 files changed, 75 insertions(+), 1 deletion(-) commit ea6a3ccadc2e3f407ea62283f0b38c95e714a67e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 16:47:23 2019 +0000 Roll src/third_party/swiftshader 72438f160d73..bd3af855ae74 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/72438f160d73..bd3af855ae74 git log 72438f160d73..bd3af855ae74 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 srisser@google.com Improve the dEQP documentation for Linux. Created with: gclient setdep -r src/third_party/swiftshader@bd3af855ae74 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I04e7bbf6973cfaca3e5fbfb59118a20299b60148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554575 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648210} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit bddb7089706f6dcec5393a6488c6f447d2de327d Author: jonross <jonross@chromium.org> Date: Fri Apr 5 16:38:57 2019 +0000 Add SkiaRenderer Vulkan FYI bot to GPU.FYI CI bots We are looking to add a new bot to the GPU.FYI CI bots. This will be used to allow us to isolate a new subset of tests for the SkiaRenderer Vulkan project. This change adds "GPU FYI Linux SkiaRenderer Vulkan (NVIDIA)" to the GPU.FYI CI configuration. It is initially adding gpu_fyi_linux_release_gtests to help confirm that the bot is running. We will switch this to a subset of blink_web_tests running SkiaRenderer and Vulkan configurations. This is being tracked in: https://chromium-review.googlesource.com/c/chromium/src/+/1500784 Bug: 946770 Change-Id: I043eca2f7e86344d03e6bd3700b664089f0b5098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544196 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648209} infra/config/cr-buildbucket.cfg | 5 + infra/config/luci-milo.cfg | 5 + infra/config/luci-scheduler.cfg | 11 ++ testing/buildbot/chromium.gpu.fyi.json | 190 +++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 10 ++ 5 files changed, 221 insertions(+) commit 03272727e036ddcf239be1eb82ac94d28c6ab6b1 Author: Victor Fei <vicfei@microsoft.com> Date: Fri Apr 5 16:37:58 2019 +0000 Implemented ITextRangeProvider::Select Implemented Select of ITextRangeProvider with associated unittests. Bug: 928948 Change-Id: I70da089007e347ca6f385a7f5f1619d077f95b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548087 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#648208} .../ax_platform_node_textprovider_win_unittest.cc | 3 + .../ax_platform_node_textrangeprovider_win.cc | 13 +- ...platform_node_textrangeprovider_win_unittest.cc | 188 +++++++++++++++++++++ ui/accessibility/platform/test_ax_node_wrapper.cc | 23 ++- ui/accessibility/platform/test_ax_node_wrapper.h | 4 + 5 files changed, 228 insertions(+), 3 deletions(-) commit bd654a8223b9320aaaace34fd3771894e98e9cfe Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 16:36:14 2019 +0000 Update V8 to version 7.5.202. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/57dbf99e..72592828 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4384ec560b029f01bf9c34735f5e8608aa477c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554733 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648207} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7b46c9fc1a6ae7b31fa21aaf0b0fddf19cc90532 Author: Stephane Zermatten <szermatt@chromium.org> Date: Fri Apr 5 16:35:20 2019 +0000 [Autofill Assistant] Add support for checking inner text in Selector. With this patch, selectors can apply a condition on the element's innerText, so that only the element matching the given regexp are taken into account. This allows looking for an element given its inner text. This change is meant to allow detecting changes resulting from a click, for b/129834241 and allow accessing or clicking on elements based on their inner text, for b/129131029. Bug: b/129834241,b/129131029 Change-Id: I73a1546d0b48174e0c1784dad0a094e6f83aea9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552814 Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648206} components/autofill_assistant/browser/BUILD.gn | 1 + components/autofill_assistant/browser/selector.cc | 23 ++++++++-- components/autofill_assistant/browser/selector.h | 10 +++++ .../browser/selector_unittest.cc | 49 ++++++++++++++++++++++ .../autofill_assistant/browser/service.proto | 12 +++++- .../autofill_assistant/browser/web_controller.cc | 42 +++++++++++++++---- .../browser/web_controller_browsertest.cc | 39 +++++++++++++++++ .../autofill_assistant_target_website.html | 10 +++++ 8 files changed, 172 insertions(+), 14 deletions(-) commit 929008a42e15f578e591687120ec1d70dbe93737 Author: Raul Tambre <raul@tambre.ee> Date: Fri Apr 5 16:35:10 2019 +0000 Support Python 3 in //chrome/browser/search/tools/generate_integrity_header.py The script still works with Python 2. There are no intended behaviour changes. Bug: 941669 Change-Id: I9172d03828e785e6c257fd70e7750cdcfd253939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554765 Commit-Queue: Raul Tambre <raul@tambre.ee> Commit-Queue: Kyle Milka <kmilka@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#648205} chrome/browser/search/tools/generate_integrity_header.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 21cbdaf5adc67f1e9605cafb2bbd6897254cadf0 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 16:32:39 2019 +0000 Roll src/third_party/skia 568eb8db6d17..69da7ad49b55 (6 commits) https://skia.googlesource.com/skia.git/+log/568eb8db6d17..69da7ad49b55 git log 568eb8db6d17..69da7ad49b55 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 herb@google.com Use canonical colors for luminance color 2019-04-05 reed@google.com Move localmatrix routines to shaderbase, no need to be public. 2019-04-05 robertphillips@google.com checkCommandBuffers when skipping a submit in submitCommandBuffer 2019-04-05 mtklein@google.com lift main-thread limit on iOS bots 2019-04-05 nigeltao@google.com Rewrite some SkWuffsCodec designated initializers 2019-04-05 brianosman@google.com Use GrGLenum consistently for cached program binaryFormat Created with: gclient setdep -r src/third_party/skia@69da7ad49b55 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:929858,chromium:949567 TBR=jlavrova@chromium.org Change-Id: I2864c1cbaa10f8f7f896c03f6520c2eaaedd11aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554574 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648204} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a7d7a15a4688447bdccc2f1c0ef343565f33e8ca Author: Nico Weber <thakis@chromium.org> Date: Fri Apr 5 16:32:35 2019 +0000 Reland "[mb] change mb_config for debug bot doing local build" This reverts commit 3c4aba3c1d922ffcd96a54d2db767a0372cb120f. Reason for revert: Different fix landed, let's see if that helps first. Original change's description: > Revert "[mb] change mb_config for debug bot doing local build" > > This reverts commit 6ce865dc25bdcec8a13471c4368958a3f690755b. > > Reason for revert: Deterministic Linux (dbg) is unhappy after this commit: > > Step(‘generate .isolate files’) failed with return_code 1 > MBErr: Must specify a build --phase for Deterministic Linux (dbg) on chromium.linux > > Original change's description: > > [mb] change mb_config for debug bot doing local build > > > > Changed mb_config doing first build without goma, but doing second build > > with goma. This is used to verify artifact from goma is the same with > > from local build. > > > > This config will be used for recipe changed in > > https://chromium-review.googlesource.com/c/chromium/tools/build/+/1545145 > > > > Also changed to use 32 core bot for the builder. > > > > Plan: > > 1. Change the bot to use 32 core cpu: https://chrome-internal-review.googlesource.com/c/infradata/config/+/1125041 > > 2. Pause builder. > > 3. Merge this CL and recipe change > > 4. Un-pause builder. > > 5. (optional) if there are yet another binary differences, update whitelist. > > > > Bug: 947903 > > Change-Id: I6e6038c23a3988d79d2469018cb62c0f5dc15392 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547486 > > Reviewed-by: smut <smut@google.com> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#648080} > > TBR=thakis@chromium.org,smut@google.com,dpranke@chromium.org,tikuta@chromium.org,jbudorick@chromium.org > > Change-Id: I59b585a2437074b9491ecc91e8c707ed6374f258 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 947903 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554782 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648202} TBR=avi@chromium.org,thakis@chromium.org,smut@google.com,dpranke@chromium.org,tikuta@chromium.org,jbudorick@chromium.org Change-Id: I3ab4e58931d09eab3009fd0563422fca3ce1c670 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553167 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#648203} infra/config/cr-buildbucket.cfg | 5 +++++ tools/mb/mb_config.pyl | 13 ++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) commit 3c4aba3c1d922ffcd96a54d2db767a0372cb120f Author: Avi Drissman <avi@chromium.org> Date: Fri Apr 5 16:30:42 2019 +0000 Revert "[mb] change mb_config for debug bot doing local build" This reverts commit 6ce865dc25bdcec8a13471c4368958a3f690755b. Reason for revert: Deterministic Linux (dbg) is unhappy after this commit: Step(‘generate .isolate files’) failed with return_code 1 MBErr: Must specify a build --phase for Deterministic Linux (dbg) on chromium.linux Original change's description: > [mb] change mb_config for debug bot doing local build > > Changed mb_config doing first build without goma, but doing second build > with goma. This is used to verify artifact from goma is the same with > from local build. > > This config will be used for recipe changed in > https://chromium-review.googlesource.com/c/chromium/tools/build/+/1545145 > > Also changed to use 32 core bot for the builder. > > Plan: > 1. Change the bot to use 32 core cpu: https://chrome-internal-review.googlesource.com/c/infradata/config/+/1125041 > 2. Pause builder. > 3. Merge this CL and recipe change > 4. Un-pause builder. > 5. (optional) if there are yet another binary differences, update whitelist. > > Bug: 947903 > Change-Id: I6e6038c23a3988d79d2469018cb62c0f5dc15392 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547486 > Reviewed-by: smut <smut@google.com> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#648080} TBR=thakis@chromium.org,smut@google.com,dpranke@chromium.org,tikuta@chromium.org,jbudorick@chromium.org Change-Id: I59b585a2437074b9491ecc91e8c707ed6374f258 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 947903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554782 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648202} infra/config/cr-buildbucket.cfg | 5 ----- tools/mb/mb_config.pyl | 13 +------------ 2 files changed, 1 insertion(+), 17 deletions(-) commit 9597c6424d124c5725f236f2e671d0b561058d6b Author: Peter K. Lee <pkl@chromium.org> Date: Fri Apr 5 16:26:27 2019 +0000 Add MaterialComponents/MaterialCards.h This will be needed later for a piper roll. Bug: 947494 Change-Id: I4771216a429ba4aed45291b1011cddfe9c0ff250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554057 Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Auto-Submit: Peter Lee <pkl@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#648201} ios/third_party/material_components_ios/BUILD.gn | 1 + 1 file changed, 1 insertion(+) commit d14c5f0d5da9a119785fd67bf9889517d1ce2071 Author: Peter K. Lee <pkl@chromium.org> Date: Fri Apr 5 16:25:25 2019 +0000 Remove usage of IsUIRefreshPhase1Enabled() in tab/grid/toolbar Bug: 884724 Change-Id: I0c34a8311b1e5c020b69d32bdb46a5028c696f1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546615 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#648200} .../browser/ui/tab_grid/tab_grid_mediator.mm | 15 ++++-------- ios/chrome/browser/ui/tabs/tab_view.mm | 28 ++++++---------------- .../adaptive_toolbar_view_controller_unittest.mm | 4 ---- 3 files changed, 11 insertions(+), 36 deletions(-) commit ad46c5358c1a7a686380e61958cdca5126d7be5c Author: Robert Kaplow <rkaplow@chromium.org> Date: Fri Apr 5 16:25:22 2019 +0000 Add system_ram aggregation for Touch metrics. This adds an extra country&ram split along with the country split. Change-Id: I98ff21c91a31b79933a8cddf7cee820acad47916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536994 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#648199} services/metrics/ukm_api.md | 1 + tools/metrics/ukm/ukm.xml | 2 ++ 2 files changed, 3 insertions(+) commit be6b5588e8b5c413dc7e464666bfeb1bdd34c8b4 Author: Stephane Zermatten <szermatt@chromium.org> Date: Fri Apr 5 16:18:01 2019 +0000 [Autofill Assistant] Remove more cases where OTHER_ACTION_STATUS is thrown. With this change, OTHER_ACTION_STATUS is only returned by webtools_controller and only in the cases where an error would indicate a bug in the client code, that is when: - finding the document element; There should always be one. - getting details about a node that was just reported by devtools; It should always be possible. - executing a hardcoded javascript snippet; Snippets should never throw. In case these do actually happen, this change includes detailed debugging information that should help us figure out where the error happened and what the cause is. This change also replaces OTHER_ACTION_STATUS with a more specific code in the following cases: - when trying to select an option that doesn't exist. This is a script error. - when the server returned details information that the client does not understand. - when the server returned prompt action without choices. This is an invalid action definition. Bug: b/129254215 Change-Id: I0dad7818ca3c4e1330b23d0a5386bc09617f69c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547524 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#648198} .../browser/actions/prompt_action.cc | 2 +- .../browser/actions/prompt_action_unittest.cc | 5 +- .../browser/actions/show_details_action.cc | 2 +- .../autofill_assistant/browser/client_status.cc | 27 +++++- .../autofill_assistant/browser/client_status.h | 16 +++- .../autofill_assistant/browser/service.proto | 54 ++++++++++++ .../autofill_assistant/browser/web_controller.cc | 98 +++++++++++++++++----- .../browser/web_controller_browsertest.cc | 2 +- 8 files changed, 174 insertions(+), 32 deletions(-) commit 2c524fde0ea3c0b7d930862fa8ef7b80be20be1c Author: Parastoo Geranmayeh <parastoog@google.com> Date: Fri Apr 5 16:17:51 2019 +0000 [AF] distinguish [un]supported fields for validation Some field types are not supported for the validation, meaning that the loaded rules do not have data for that level to validate the users' data. They need to be distinguished from the supported ones. Otherwise, the validation process would be inconsistent. For that purpose, they'll be treated like VALID fields. Example: For US, if state is invalid, city would be considered as invalid too, whereas if state is valid, it would not be validated because it's not supported. Therefore, UNSUPPORTED should dominate INVALID validity type. Change-Id: I4c291488b1d016f9afc54463b742f2d6afc88111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531655 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Mathieu Perreault <mathp@chromium.org> Reviewed-by: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#648197} .../autofill/core/browser/autofill_profile.cc | 1 - .../browser/autofill_profile_validation_util.cc | 29 ++++- .../autofill_profile_validation_util_unittest.cc | 26 ++++- .../browser/autofill_profile_validator_unittest.cc | 130 +++++++++++++-------- .../core/browser/personal_data_manager_unittest.cc | 2 +- .../chromium/chrome_address_validator_unittest.cc | 60 +++++----- 6 files changed, 159 insertions(+), 89 deletions(-) commit 64ad1dfdf791ee9a44fa788bef1882ff0835c876 Author: Aran Gilman <gilmanmh@google.com> Date: Fri Apr 5 16:16:50 2019 +0000 Bypass ThemePainter for text fields when dark mode enabled. This is a temporary workaround until a concept of dark mode can be added to ThemePainter, as discussed in this email thread from chromium-dev@: https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/q7BXL6rpY9A Bug: 937872 Change-Id: Ia928775fe95d5de42ae295c2f644bcb3ec85413c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539888 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#648196} .../blink/renderer/core/paint/theme_painter_default.cc | 12 ++++++++++-- third_party/blink/web_tests/VirtualTestSuites | 10 ++++++++++ .../dark-mode/native-theme-off/text-input-elements.html | 1 + .../dark-mode/native-theme-on/text-input-elements.html | 1 + .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 3031 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 2961 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 1831 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 1784 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 3018 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 2984 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 1815 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 1767 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 3031 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 2961 bytes .../native-theme-off/text-input-elements-expected.png | Bin 0 -> 1830 bytes .../native-theme-on/text-input-elements-expected.png | Bin 0 -> 1782 bytes .../paint/dark-mode/native-theme-off/README.txt | 3 +++ .../dark-mode/paint/dark-mode/native-theme-on/README.txt | 3 +++ 18 files changed, 28 insertions(+), 2 deletions(-) commit 2ec537f3c50ce8c79a071728762141c35ccd2323 Author: Martin Robinson <mrobinson@igalia.com> Date: Fri Apr 5 16:10:24 2019 +0000 Add AtkText support for text-insert and text-remove These events allow the AT to be notified of changes to text content. Currently, these are only sent for editable nodes or nodes which are descendants of live regions. Bug: 866338 Change-Id: Ia0dd5251ff958d42f20f443bdb7eb21531602ad7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547731 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#648195} .../accessibility_event_recorder_auralinux.cc | 22 +++- .../dump_accessibility_events_browsertest.cc | 5 + ...-changed-contenteditable-expected-auralinux.txt | 24 +++++ .../event/text-changed-contenteditable.html | 21 ++++ .../platform/ax_platform_node_auralinux.cc | 50 +++++++++ .../platform/ax_platform_node_auralinux.h | 1 + ui/accessibility/platform/ax_platform_node_base.cc | 118 +++++++++++++++++++++ ui/accessibility/platform/ax_platform_node_base.h | 12 +++ ui/accessibility/platform/ax_platform_node_win.cc | 111 +------------------ ui/accessibility/platform/ax_platform_node_win.h | 7 -- 10 files changed, 251 insertions(+), 120 deletions(-) commit e0eb7435dd9149966e8a212c5c1e2fd1e760f408 Author: Lily Chen <chlily@chromium.org> Date: Fri Apr 5 16:09:30 2019 +0000 SQLitePersistentReportingAndNELStore: Notify even if load fails When loading NEL policies from the database, (previously) on failure we would just do nothing and return. Thus the caller would not know that loading failed. Now we notify the caller that loading NEL policies failed by running the given NELPoliciesLoadedCallback with an empty vector of NEL policies. Bug: 895821 Change-Id: I5034b97a143f9936b03fff0cd970b010d7fc0a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553944 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#648194} .../sqlite_persistent_reporting_and_nel_store.cc | 45 ++++++++++++++++------ ..._persistent_reporting_and_nel_store_unittest.cc | 14 +++++++ 2 files changed, 48 insertions(+), 11 deletions(-) commit 8a5cd30a3140082f706a54846d6a6e02252e80f2 Author: Joe Mason <joenotcharles@google.com> Date: Fri Apr 5 16:01:10 2019 +0000 Add chrome_cleaner/executables subdir R=proberge Bug: 830892 Change-Id: I4242031b2fd63eea82ef4873135743db3bfd8e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553801 Commit-Queue: Joe Mason <joenotcharles@google.com> Reviewed-by: proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#648193} chrome/chrome_cleaner/BUILD.gn | 15 +- .../components/recovery_component.cc | 3 +- chrome/chrome_cleaner/constants/BUILD.gn | 24 + .../constants/chrome_cleaner.rc.version | 46 ++ .../constants/chrome_cleanup_tool_exe.ver | 2 + .../constants/software_reporter_tool_exe.ver | 2 + chrome/chrome_cleaner/executables/BUILD.gn | 152 +++++ .../executables/chrome_cleaner_main.cc | 628 +++++++++++++++++++++ .../executables/chrome_reporter_main.cc | 317 +++++++++++ .../executables/shutdown_sequence.cc | 36 ++ .../chrome_cleaner/executables/shutdown_sequence.h | 30 + 11 files changed, 1253 insertions(+), 2 deletions(-) commit cea8e3ed6a330fb5e026522ccb4654571754a76c Author: Xida Chen <xidachen@chromium.org> Date: Fri Apr 5 15:58:00 2019 +0000 [Code Cleanup] Remove DumpWithoutCrashing in TouchActionFilter Bug: 948895 Change-Id: I26635821c7206f07876b291a1364869015f776dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553281 Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#648192} content/browser/renderer_host/input/touch_action_filter.cc | 5 ----- 1 file changed, 5 deletions(-) commit 275a7f1964b59c0b3baab417519ea40601c22d2c Author: Per Åhgren <peah@chromium.org> Date: Fri Apr 5 15:50:14 2019 +0000 Corrected the Aec3FilterAnalyzerIncrementalAnalysisKillSwitch test config This CL corrects the field trial testing config for the WebRTC-Aec3FilterAnalyzerIncrementalAnalysisKillSwitch Bug: chromium:946927 Change-Id: I0e9b223945879863e49d376f61e35b0d47f6db92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552219 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#648191} testing/variations/fieldtrial_testing_config.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 6b7db232fde790f0a21eadba9e471cfef55b6eea Author: Vadym Doroshenko <dvadym@chromium.org> Date: Fri Apr 5 15:47:27 2019 +0000 Set new-password-form-parsing by default. Also this patch has minor updates for tests: 1.password_form_manager_unittest.cc set to run only without the new parser. 2.password_form_manager_unittest.cc and password_form_filling_unittest.cc: removed expectation on AllowPasswordGenerationForForm, because this function is for old architecture. 3.password_generation_frame_helper_unittest.cc: PasswordGenerationFrameHelperTest.DetectFormsEligibleForGeneration doesn't make sense with the new parsing, so the new parsing is disabled for it. 4.password_manager_unittest.cc: a.expectation of GetLogins(). WillOnce->WillRepeatedly, because now both old and new password managers call it. b.turned off wait for server predictions by default (only tests that deal with it should turn it on). Bug: 831123 Change-Id: I555cf84c2887bb87773a9bf0d12c7df27d579c21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547984 Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#648190} .../browser/new_password_form_manager_unittest.cc | 2 - .../core/browser/password_form_filling_unittest.cc | 4 - .../core/browser/password_form_manager_unittest.cc | 6 ++ .../password_generation_frame_helper_unittest.cc | 9 +++ .../core/browser/password_manager_unittest.cc | 91 ++++++++++++++++------ .../core/common/password_manager_features.cc | 2 +- .../passwords/password_controller_unittest.mm | 21 ++++- 7 files changed, 103 insertions(+), 32 deletions(-) commit 72219565e93a53a0c4b46b2a7d007380855af709 Author: John Budorick <jbudorick@chromium.org> Date: Fri Apr 5 15:41:28 2019 +0000 android: use generic wrapper generation for test runner scripts. Bug: 816629 Change-Id: I0f2674fa2d4e68bbe6d25175feceb6cd44750fc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1324377 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#648189} PRESUBMIT.py | 1 - build/android/gyp/create_test_runner_script.py | 163 --------------------- build/android/gyp/create_test_runner_script.pydeps | 7 - build/android/gyp/generate_android_wrapper.py | 42 ++++++ build/android/gyp/util/build_utils.py | 8 +- build/android/test_runner.py | 2 +- build/config/android/internal_rules.gni | 139 ++++++++++-------- build/util/generate_wrapper.gni | 1 + build/util/generate_wrapper.py | 17 ++- 9 files changed, 134 insertions(+), 246 deletions(-) commit 6716700301b80d7003fa0a9c417e7efd8ef381ac Author: Shu Chen <shuchen@chromium.org> Date: Fri Apr 5 15:37:16 2019 +0000 [Mojo-IMF] Defines/implements mojo interface - ImeEngineClient. - Makes InputMethodChromeOS as an ImeEngineClient. - Hooks up WindowTreeHostMus/WindowTreeClient to connect to ImeEngine. - Makes calls from ImeEngine to ImeEngineClient. Bug: 937167 Change-Id: I0d27ce6e9bc547f4d269cdfe0ef38e8e83673267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546795 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#648188} ash/ime/ime_engine_factory_registry_unittest.cc | 9 ++ .../chromeos/input_method/input_method_engine.cc | 19 +-- .../input_method/input_method_engine_unittest.cc | 20 +++ services/ws/window_service_unittest.cc | 9 ++ ui/aura/mus/window_tree_client.cc | 6 + ui/aura/mus/window_tree_client.h | 2 + ui/aura/mus/window_tree_host_mus.cc | 7 + ui/aura/mus/window_tree_host_mus.h | 3 + ui/aura/mus/window_tree_host_mus_delegate.h | 6 + ui/base/ime/BUILD.gn | 46 ++++-- ui/base/ime/candidate_window.h | 6 +- ui/base/ime/character_composer.h | 2 +- ui/base/ime/chromeos/BUILD.gn | 1 + ui/base/ime/chromeos/input_method_chromeos.cc | 158 +++++++++++++++++---- ui/base/ime/chromeos/input_method_chromeos.h | 8 ++ .../ime/chromeos/input_method_chromeos_unittest.cc | 68 +++++++++ ui/base/ime/composition_text.h | 2 +- ui/base/ime/ime_text_span.h | 2 +- ui/base/ime/infolist_entry.h | 2 +- ui/base/ime/input_method_delegate.cc | 7 + ui/base/ime/input_method_delegate.h | 15 ++ ui/base/ime/mojo/ime.mojom | 19 +++ ui/base/ime/mojo/ime_types.typemap | 2 +- ui/keyboard/BUILD.gn | 1 + ui/keyboard/test/run_all_unittests.cc | 2 + 25 files changed, 371 insertions(+), 51 deletions(-) commit 70fd6368956446eb940cc975845ddc02faa82090 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 15:35:57 2019 +0000 Roll src/third_party/webrtc ae2213b38d42..59e875ce18bb (2 commits) https://webrtc.googlesource.com/src.git/+log/ae2213b38d42..59e875ce18bb git log ae2213b38d42..59e875ce18bb --date=short --no-merges --format='%ad %ae %s' 2019-04-05 philipel@webrtc.org Tune VideoCodecTestLibvpx.MultiresVP8 thresholds. 2019-04-05 srte@webrtc.org Reduce flakiness of repeating task test. Created with: gclient setdep -r src/third_party/webrtc@59e875ce18bb The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I704b36bdcd6c85c424a1da65f9ec00707d12ab22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554613 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648187} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6a2e4d995d70a670b11c65f4e23fc17705b55ed2 Author: Andrew Grieve <agrieve@google.com> Date: Fri Apr 5 15:24:40 2019 +0000 Allow proto_library()'s proto_out_dir to be a source-root-absolute path Also: * Adds a disabled-behind-gn-arg check for targets that generate .pb.cc files outside of their target_gen_dir. This is the main motivation for the change * Adds a public_include_dirs template arg to serve the use-case some targets have of wanting their #include paths to look differently. I hope to change the disabled check into an assert once I fix & roll subrepos. Bug: 944928 Change-Id: Ib8157b7a5cb653fafaf751661bf979fe4b3c6152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535535 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#648186} testing/libfuzzer/fuzzers/BUILD.gn | 2 +- .../fuzzers/javascript_parser_proto_fuzzer.cc | 2 +- .../fuzzers/javascript_parser_proto_to_string.h | 2 +- testing/libfuzzer/proto/BUILD.gn | 5 +- .../src/google/cacheinvalidation/BUILD.gn | 3 +- third_party/protobuf/proto_library.gni | 99 +++++++++++++++++----- tools/traffic_annotation/auditor/BUILD.gn | 2 - ui/accessibility/BUILD.gn | 5 +- 8 files changed, 85 insertions(+), 35 deletions(-) commit 3b2be77f57eeb2f4d0bcee47a24a156880686922 Author: Jimmy Gong <jimmyxgong@google.com> Date: Fri Apr 5 15:23:41 2019 +0000 Add isPrinterValid to printer edit dialog - Helper function to check if a configured printer has valid properties. Bug: 893986 Test: End to End Change-Id: I6dd1ba2c1a839e68a4c84e04d1ab6abd81926c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546613 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#648185} .../settings/printing_page/cups_edit_printer_dialog.js | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) commit 271fe9bbd9acb1539f2624c6facad37394c21164 Author: Xi Han <hanxi@google.com> Date: Fri Apr 5 15:16:28 2019 +0000 Update description for the SimpleKeyedServiceFactory. See https://docs.google.com/document/d/1caWonaPnBhMb6sk4syNe0BbdsQih13S6QmDW237Mcrg/edit?usp=sharing or more details. Change-Id: I9baad54bb11c5cb668d6c0a3ae8409803cae4116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549344 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#648184} .../core/simple_keyed_service_factory.h | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) commit 95f2552cf35e5a7e336903ba403581a60254b62b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 15:10:36 2019 +0000 Roll src/third_party/swiftshader 477476160732..72438f160d73 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/477476160732..72438f160d73 git log 477476160732..72438f160d73 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 bclayton@google.com Fix DescriptorUpdateTemplate::updateDescriptorSet Created with: gclient setdep -r src/third_party/swiftshader@72438f160d73 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123244275 TBR=swiftshader-team+autoroll@chromium.org Change-Id: If0fa8c29b7940544324f2181a48dbc3531408b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554571 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648183} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 4cda67aad619795edb785be6c19d8c2852d99e42 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 15:05:08 2019 +0000 Roll src/third_party/skia 558637996569..568eb8db6d17 (3 commits) https://skia.googlesource.com/skia.git/+log/558637996569..568eb8db6d17 git log 558637996569..568eb8db6d17 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 jvanverth@google.com Some more Metal memory fixes. 2019-04-05 jvanverth@google.com Add mm files to cmake sources 2019-04-05 robertphillips@google.com Stop using pendingIO in read/writeSurfacePixels (take 2) Created with: gclient setdep -r src/third_party/skia@568eb8db6d17 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: Ib12e3a9c843ee22a367572b0603889647c5276bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554569 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648182} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 01a1bbaafedccfd77d4db8b959005e10e4c2a88d Author: Joe Mason <joenotcharles@google.com> Date: Fri Apr 5 14:59:33 2019 +0000 Fix chrome_cleanup_tool crash using the test engine R=proberge Bug: 830892 Change-Id: I2eb678ea3341c91de72a5eb829ce6357f37377e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554124 Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#648181} .../scanner/force_installed_extension_scanner_impl.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) commit d3b8c290b089ceb0c0996f7370f70c4963452870 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Apr 5 14:58:12 2019 +0000 Problems with scrolling and char extents in tall paras NOTRY=true Bug: 948612 Change-Id: I8e0744298c0e947f5e6b4fc1878dcf03d56d61b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553818 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#648180} .../accessibility/accessibility_win_browsertest.cc | 190 +++++++++++++++++++++ .../accessibility/browser_accessibility_com_win.cc | 10 +- 2 files changed, 197 insertions(+), 3 deletions(-) commit aa891f17e0c1125126c12e1b287014dd69806e93 Author: Haojian Wu <hokein.wu@gmail.com> Date: Fri Apr 5 14:56:52 2019 +0000 [clang] Add clangd documentation Add documentation for how to use clangd in chromium. Change-Id: I889bb3c05c6cf547ae9624e13baff7aa7031e016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538094 Auto-Submit: Haojian Wu <hokein.wu@gmail.com> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#648179} docs/clangd.md | 62 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 62 insertions(+) commit 9f57e19170ed93da4a2e308b356919ebbc301cc7 Author: Lucas Furukawa Gadani <lfg@chromium.org> Date: Fri Apr 5 14:56:10 2019 +0000 Portals: Add flag to enable/disable portals in about:flags. Bug: 865565 Change-Id: I72563a04cb7fac4f7a17b9405237e83a8fd19f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553658 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#648178} chrome/browser/about_flags.cc | 4 ++++ chrome/browser/flag-metadata.json | 5 +++++ chrome/browser/flag_descriptions.cc | 6 ++++++ chrome/browser/flag_descriptions.h | 3 +++ tools/metrics/histograms/enums.xml | 2 ++ 5 files changed, 20 insertions(+) commit 00b1a32526cbc50136b01f1160245ff8985a8c71 Author: Haojian Wu <hokein.wu@gmail.com> Date: Fri Apr 5 14:52:42 2019 +0000 [clang] Add a script to fetch and build tools in clang-tools-extra repo. This would allow chromium-devs to build other clang tools (e.g. clangd) easily. Most code are moved from clang_tidy_tool.py. Change-Id: Ibba23115dee3774948b610d6f23eb16629e8d13f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526041 Auto-Submit: Haojian Wu <hokein.wu@gmail.com> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#648177} tools/clang/scripts/build_clang_tools_extra.py | 91 ++++++++++++++++++++++++++ tools/clang/scripts/clang_tidy_tool.py | 73 +++------------------ 2 files changed, 100 insertions(+), 64 deletions(-) commit 0f4a210f44968fe130e1f61e43b7786c7822f0fd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 14:52:10 2019 +0000 Roll Fuchsia SDK from 891704345208 to 891702240315 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1afde2db4ee72dfbd92a03ffd47cf70d22fae07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554570 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648176} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 9ef8b6ebe397e7a492210006d949423ba27f5acd Author: Saman Sami <samans@chromium.org> Date: Fri Apr 5 14:51:01 2019 +0000 Remove SurfaceDependencyTracker This CL removes SurfaceDependencyTracker and reimplements tracking of dependencies in SurfaceAllocationGroup. In addition to improving code health, the new approach allows us to implement a better fix for the throttling bug (898460), which is included in this CL. TBR=sky@chromium.org Bug: 942093 Change-Id: I3bdb67e3e03cbfc90ee112a59b396fdd0f63da50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539860 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#648175} .../viz/host/host_frame_sink_manager_unittest.cc | 1 + components/viz/service/BUILD.gn | 2 - components/viz/service/display/display.h | 1 + .../compositor_frame_sink_support_unittest.cc | 1 + .../surface_synchronization_unittest.cc | 69 +++++-- .../viz/service/frame_sinks/video_detector.cc | 1 + .../viz/service/hit_test/hit_test_aggregator.h | 1 + .../viz/service/hit_test/hit_test_manager.cc | 1 + components/viz/service/surfaces/surface.cc | 198 +++++++-------------- components/viz/service/surfaces/surface.h | 40 ++--- .../service/surfaces/surface_allocation_group.cc | 86 ++++++++- .../service/surfaces/surface_allocation_group.h | 59 +++++- .../service/surfaces/surface_dependency_tracker.cc | 167 ----------------- .../service/surfaces/surface_dependency_tracker.h | 76 -------- components/viz/service/surfaces/surface_manager.cc | 52 +++--- components/viz/service/surfaces/surface_manager.h | 32 +--- .../viz/service/surfaces/surface_unittest.cc | 1 - content/public/test/hit_test_region_observer.cc | 1 + 18 files changed, 319 insertions(+), 470 deletions(-) commit f2a8186fd9fd05abc55cbdbbcd53a27062392965 Author: Saman Sami <samans@chromium.org> Date: Fri Apr 5 14:50:20 2019 +0000 Fix background tabs blank on Android with SkiaRenderer The thumbnail for background tabs is an ETC1 image for which we don't currently have the correct set up in resource_format_utils. Bug: 949168 Change-Id: I53c5315a0afb0d962769fe1e18cb5453e700ddb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553300 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648174} components/viz/common/resources/resource_format_utils.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 697c78b784e40657b329eb7df40fd3ad8e1ebc99 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 14:49:53 2019 +0000 Update V8 to version 7.5.199. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c6983f48..57dbf99e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4d3f655b1ceb50d44a403ad7dcd8f56deeb03b11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554728 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648173} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d516bf9d801a5e6b7e29244016e8af9440564998 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Apr 5 14:46:50 2019 +0000 Revert accidental checkin of 2 files TBR=dmazzoni@chromium.org NOTRY=true Bug: None Change-Id: Idb99b1d9759e7345de85b82418081dd367e3eee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554051 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#648172} .../accessibility/accessibility_win_browsertest.cc | 190 --------------------- .../accessibility/browser_accessibility_com_win.cc | 10 +- 2 files changed, 3 insertions(+), 197 deletions(-) commit e475ec7b906743e93d87c8b1d4abc162a204744b Author: Robbie Gibson <rkgibson@google.com> Date: Fri Apr 5 14:26:09 2019 +0000 🦁Load answer images in Omnibox popup This CL adds actually loading the answer images in the omnibox popup. It also fixes the issue from CL 1545886 and uses a separate image view for the answer image instead of using the UIButton for it. Bug: 945323 Change-Id: Ibbe77deeac21ca31ecc35fe5db5047f272326686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549122 Reviewed-by: Mark Cogan <marq@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#648171} ios/chrome/browser/ui/elements/BUILD.gn | 2 + .../extended_touch_target_button.h | 6 +- .../extended_touch_target_button.mm | 2 +- ios/chrome/browser/ui/location_bar/BUILD.gn | 3 +- .../ui/location_bar/location_bar_steady_view.mm | 2 +- ios/chrome/browser/ui/omnibox/popup/BUILD.gn | 1 + .../ui/omnibox/popup/omnibox_popup_row_cell.h | 3 + .../ui/omnibox/popup/omnibox_popup_row_cell.mm | 99 ++++++++++++++++------ .../omnibox/popup/omnibox_popup_view_controller.mm | 1 + 9 files changed, 86 insertions(+), 33 deletions(-) commit defd862a6840f4236c44a29f4e996a0cf148119f Author: Robert Sesek <rsesek@chromium.org> Date: Fri Apr 5 14:21:21 2019 +0000 [Mac] Allow multiple selection in the task manager. Bug: 949190 Change-Id: Iee9c6372cb21847bcba8eb15ea3fedc971539a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553580 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#648170} chrome/browser/ui/cocoa/task_manager_mac.mm | 1 + 1 file changed, 1 insertion(+) commit a234448057d1ac1d5830773f387fda20cf1d01da Author: Yao Xiao <yaoxia@chromium.org> Date: Fri Apr 5 14:20:41 2019 +0000 Send deprecation message for DownloadInAdFrameWithoutUserGesture. blink LGTMs: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tXKnmZD3P9o Bug: 929911 Change-Id: I4b247242000c634201366a4cfd538a9163a29303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553205 Reviewed-by: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#648169} .../observers/use_counter_page_load_metrics_observer.cc | 8 ++++++++ 1 file changed, 8 insertions(+) commit 9047ea8b772bf27617811eec0504b01dd3a77a28 Author: Jonathan Backer <backer@chromium.org> Date: Fri Apr 5 14:18:40 2019 +0000 Draw a 1x1 solid white texture on unknown mailbox It's red on DCHECK enabled builds to help make races more apparent. Bug: 948249 Change-Id: I7e9937f5ed8b0df193041d0f65e32a39ed92ab1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553902 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#648168} .../display_embedder/skia_output_surface_impl.cc | 12 +++++++ .../display_embedder/skia_output_surface_impl.h | 4 +++ .../skia_output_surface_impl_on_gpu.cc | 42 +++++++++++++++++++--- .../skia_output_surface_impl_on_gpu.h | 9 +++++ 4 files changed, 62 insertions(+), 5 deletions(-) commit 36e181cd1db181f48fce03eb24a6708f3f4afc54 Author: Peter K. Lee <pkl@chromium.org> Date: Fri Apr 5 14:16:52 2019 +0000 Remove usage of IsUIRefreshPhase1Enabled() from infobars. Bug: 884724 Change-Id: I778c0ae5eafcd0bc6acac7ca71f7e3bebf4aad9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546522 Auto-Submit: Peter Lee <pkl@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#648167} ios/chrome/browser/ui/autofill/save_card_infobar_view.mm | 7 +------ ios/chrome/browser/ui/infobars/confirm_infobar_view.mm | 7 +------ ios/chrome/browser/ui/translate/translate_infobar_view.mm | 7 +------ 3 files changed, 3 insertions(+), 18 deletions(-) commit fb6a79e5166eda63ed735479ecc1840b8e98dabd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 14:16:34 2019 +0000 Roll src/third_party/webrtc ff393129580b..ae2213b38d42 (1 commits) https://webrtc.googlesource.com/src.git/+log/ff393129580b..ae2213b38d42 git log ff393129580b..ae2213b38d42 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 nisse@webrtc.org Delete compatibility alias webrtc::kI420 Created with: gclient setdep -r src/third_party/webrtc@ae2213b38d42 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I27133b4e7da0e8af6ce0d312a889c62c744d59c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554568 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648166} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 09e6ac429375a0ffae178796f6bd838b58efc742 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 14:08:20 2019 +0000 [Sheriff] Disable OCSPVerify/HTTPSOCSPVerifyTest.VerifyResult/* on Mac The tests are flaky on Mac TBR=pauljensen@chromium.org Bug: 949958 Change-Id: I1f0b360ea30952de4fb5ae0cf9f437611592c0c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554625 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648165} net/url_request/url_request_unittest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 5aba4af5874a7888b721d09d227bf4837239a8da Author: Sigurdur Asgeirsson <siggi@chromium.org> Date: Fri Apr 5 14:04:26 2019 +0000 PM: Implement PerformanceManager::CallOnGraph. Also retire PerformanceManager::DistributeMeasurementBatchToSystemNode, which can now be implemented in terms of this more general primitive. Bug: 910288 Change-Id: I8bc42d580d6d499563ee3c40515f9894c5132c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553810 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#648164} .../performance_manager/performance_manager.cc | 23 ++++++++++------------ .../performance_manager/performance_manager.h | 19 +++++++++--------- .../performance_manager_unittest.cc | 17 +++++++++++++++- .../resource_coordinator/render_process_probe.cc | 18 ++++++++++++++++- .../resource_coordinator/render_process_probe.h | 6 ++++++ 5 files changed, 58 insertions(+), 25 deletions(-) commit 9bf1fcaac336f014c24944e3e8973cf2f7387fa7 Author: Joe Mason <joenotcharles@google.com> Date: Fri Apr 5 14:01:58 2019 +0000 Refactor chrome_cleaner build to get rid of public_deps - Moves all dependencies except for simple protos and collections of constants from public_deps to deps to make the dependency graph more explicit. - Adds targets that will be used in an upcoming commit that adds the executables/ subdir: facade_interface_header, *_logging_definitions, *_settings_definitions. - Add missed engines/DEPS file. R=proberge Bug: 830892 Change-Id: If40b6d74a92564826de63b5da77d86016697941a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553589 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: proberge <proberge@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#648163} chrome/chrome_cleaner/components/BUILD.gn | 1 + chrome/chrome_cleaner/engines/DEPS | 3 ++ chrome/chrome_cleaner/engines/controllers/BUILD.gn | 16 ++++++- chrome/chrome_cleaner/logging/BUILD.gn | 51 ++++++++++++++++++---- chrome/chrome_cleaner/os/BUILD.gn | 2 +- chrome/chrome_cleaner/scanner/BUILD.gn | 5 +-- chrome/chrome_cleaner/settings/BUILD.gn | 33 ++++++++++++++ chrome/chrome_cleaner/test/BUILD.gn | 1 + 8 files changed, 98 insertions(+), 14 deletions(-) commit 7178dc7056c14ba2b606bcc3ee91ace07ba74438 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 13:59:34 2019 +0000 Import wpt@77525b8ae8a8b194c62168029c78f57d54d012e7 Using wpt-import in Chromium a054fbb89d8a09992998fc760290b1ef91140eb6. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874cf2 "[WPT] Fix JSON decoding errors in referrer-policy on Safari" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ia79aa060dc2c68b2a1a70a39f69a0de722c41a89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553869 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648162} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 47 +++++++++++++++-- .../css-text/line-breaking/line-breaking-013.html | 60 +++++++++++++++++++++ .../css-text/line-breaking/line-breaking-014.html | 61 ++++++++++++++++++++++ .../reference/line-breaking-013-ref.html | 41 +++++++++++++++ .../Event-dispatch-on-disabled-elements.html | 29 ++++++---- .../web_tests/external/wpt/interfaces/webxr.idl | 9 ++++ .../wpt/webxr/idlharness.https.window-expected.txt | 4 +- 7 files changed, 238 insertions(+), 13 deletions(-) commit c2b048cc2dd4894de5495fb38df49965c2bed835 Author: Hans Wennborg <hans@chromium.org> Date: Fri Apr 5 13:50:28 2019 +0000 Roll clang 356356:357692. Ran `tools/clang/scripts/upload_revision.py 357692`. Bug: 945170 Change-Id: I3dc05a48cef0b005235fb585e73fa0c282eea924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552811 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#648161} tools/clang/scripts/update.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit cb6bdcc92fa9e9aaf4478617ff03e8d5cdecb1c4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 13:47:59 2019 +0000 Roll src/third_party/swiftshader d67ee5f5ee36..477476160732 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d67ee5f5ee36..477476160732 git log d67ee5f5ee36..477476160732 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 bclayton@google.com SpirvShader: Make value names more consistent Created with: gclient setdep -r src/third_party/swiftshader@477476160732 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I500e35bb5f6a5599445127ba904fc41eb1839c1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554566 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648160} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 58338dee91d8fe1055386e0c3df2849e1afd1ebe Author: Rohit Rao <rohitrao@chromium.org> Date: Fri Apr 5 13:42:18 2019 +0000 [ios] Removes GREYAssert() from ios/web/public/test/earl_grey. GREYAssert() cannot be used in the app process under EG2, so remove uses from helpers as part of the migration. Instead of asserting, these helpers now return a bool (or some other suitable sentinel value such as nil) indicating success or failure. BUG=922813 Change-Id: Ia8c588fe62d7b2db28016b9bfa63c9579ff88d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553699 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#648159} ios/chrome/test/earl_grey/chrome_earl_grey.mm | 6 ++- ios/web/public/test/earl_grey/js_test_util.h | 13 +---- ios/web/public/test/earl_grey/js_test_util.mm | 58 ++++++++++++----------- ios/web/public/test/earl_grey/web_view_actions.mm | 24 +++++----- ios/web/shell/test/earl_grey/shell_earl_grey.mm | 7 ++- 5 files changed, 53 insertions(+), 55 deletions(-) commit 50335ea3d69907e0e40a473450488309a4d432da Author: Caitlin Fischer <caitlinfischer@google.com> Date: Fri Apr 5 13:40:28 2019 +0000 [Autofill] Show the name before the phone in labels. Focusing on an email field in a contact form or an address field in an address phone form currently formats the disambiguating info as follows: (774) 800-7474 • Pilar Flores Now it will be formatted as Pilar Flores • (774) 800-7474. It feels a bit more natural to see the name first. Note that this change was implemented in address contact forms in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/1542559 Bug: 936168 Change-Id: I7f5e81ec3f4c7374589161fccce0f4cef41e953b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554046 Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#648158} .../core/browser/address_email_form_label_formatter.cc | 4 ++-- .../core/browser/address_phone_form_label_formatter.cc | 13 ++++++------- .../browser/address_phone_form_label_formatter_unittest.cc | 6 +++--- .../autofill/core/browser/contact_form_label_formatter.cc | 12 ++++++------ .../core/browser/contact_form_label_formatter_unittest.cc | 8 ++++---- 5 files changed, 21 insertions(+), 22 deletions(-) commit d248df7f7a72e1ae12281b8b5bdd40444fbc845d Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 13:38:13 2019 +0000 [Sheriff] Disable TabMetricsLoggerTest.GetHasFormEntry on ChromeOS The test is flaky (crashing) TBR=fdoray@chromium.org Bug: 949288 Change-Id: I5f7b2bcc17d4f59ff357c87ae5b7ae7ea199a576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554624 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648157} .../browser/resource_coordinator/tab_metrics_logger_unittest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 977fe98911dcfbc226c02cdbda219e97b1e798bd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 13:36:42 2019 +0000 Roll src/third_party/skia 604d5a3fca01..558637996569 (1 commits) https://skia.googlesource.com/skia.git/+log/604d5a3fca01..558637996569 git log 604d5a3fca01..558637996569 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 robertphillips@google.com Disable the TextureStripAtlasManagerColorFilterTest on MoltenVK Created with: gclient setdep -r src/third_party/skia@558637996569 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: Ifc9acb73f5f277279d1d06afeebaf663586c9f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554565 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648156} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 19b1e5e4e1914b5b7464062ec300b817d2bac53d Author: Charlie Harrison <csharrison@chromium.org> Date: Fri Apr 5 13:30:53 2019 +0000 [url] Make path URL parsing more lax Parsing the path component of a non-special URL like javascript or data should not fail for invalid URL characters like \uFFFF. See this bit in the spec: https://url.spec.whatwg.org/#cannot-be-a-base-url-path-state Note: some failing WPTs are added which are because url parsing replaces invalid characters (e.g. \uFFFF) with the replacement char \uFFFD, when that isn't in the spec. Bug: 925614 Change-Id: I450495bfdfa68dc70334ebed16a3ecc0d5737e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551917 Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#648155} .../external/wpt/url/resources/urltestdata.json | 16 +++++++++++++++ .../linux/external/wpt/url/a-element-expected.txt | 3 ++- .../external/wpt/url/a-element-origin-expected.txt | 3 ++- .../wpt/url/a-element-origin-xhtml-expected.txt | 3 ++- .../external/wpt/url/a-element-xhtml-expected.txt | 3 ++- .../external/wpt/url/url-constructor-expected.txt | 3 ++- .../linux/external/wpt/url/url-origin-expected.txt | 3 ++- .../mac/external/wpt/url/a-element-expected.txt | 3 ++- .../external/wpt/url/a-element-origin-expected.txt | 3 ++- .../wpt/url/a-element-origin-xhtml-expected.txt | 3 ++- .../external/wpt/url/a-element-xhtml-expected.txt | 3 ++- .../external/wpt/url/url-constructor-expected.txt | 3 ++- .../mac/external/wpt/url/url-origin-expected.txt | 3 ++- .../win/external/wpt/url/a-element-expected.txt | 3 ++- .../external/wpt/url/a-element-origin-expected.txt | 3 ++- .../wpt/url/a-element-origin-xhtml-expected.txt | 3 ++- .../external/wpt/url/a-element-xhtml-expected.txt | 3 ++- .../external/wpt/url/url-constructor-expected.txt | 3 ++- .../win/external/wpt/url/url-origin-expected.txt | 3 ++- url/url_canon_pathurl.cc | 23 +++++++++++----------- url/url_canon_unittest.cc | 10 +++++++--- 21 files changed, 71 insertions(+), 32 deletions(-) commit 9fd7dd691ab14791bc6efeabab641966c4b0807a Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 13:27:33 2019 +0000 Disable TabHoverCardBubbleViewInteractiveUiTest.HoverCardHidesOnAnyKeyPressInSameWindow on Windows It is flaky on Win10. TBR=kylixrd@chromium.org Bug: 947668 Change-Id: I933f79fe47c105d7d1fde8452b1a4d2fe3b87bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553325 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648154} .../views/tabs/tab_hover_card_bubble_view_interactive_uitest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit 3effd1f73c279346f5cd3b4be23da88d33cb3ff3 Author: Colin Blundell <blundell@chromium.org> Date: Fri Apr 5 13:13:09 2019 +0000 Rip out infra for sending notification that Google signin failed There are multiple layers of infrastructure for sending the IdentityManager observer callback that a Google signin failed. It turns out that this callback is never invoked: the only starting point is SigninManager::HandleAuthError(), and that method is never called. This CL rips out all of the infrastructure. Bug: 814787 Change-Id: I2eb295d2c9aa918e3301b91b5202321093666956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554487 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#648153} .../sync_file_system/drive_backend/sync_engine.cc | 7 ------- .../sync_file_system/drive_backend/sync_engine.h | 2 -- .../browser/ui/webui/signin/login_ui_test_utils.cc | 8 +------- .../signin/core/browser/about_signin_internals.cc | 5 ----- .../signin/core/browser/about_signin_internals.h | 2 -- components/signin/core/browser/signin_manager.cc | 6 ------ components/signin/core/browser/signin_manager.h | 6 ------ .../signin/core/browser/signin_manager_base.h | 3 --- .../signin/core/browser/signin_manager_unittest.cc | 13 +----------- services/identity/public/cpp/identity_manager.cc | 5 ----- services/identity/public/cpp/identity_manager.h | 6 ------ .../public/cpp/primary_account_mutator_unittest.cc | 24 +--------------------- .../public/cpp/test_identity_manager_observer.cc | 17 --------------- .../public/cpp/test_identity_manager_observer.h | 9 -------- .../public/objc/identity_manager_observer_bridge.h | 3 --- .../objc/identity_manager_observer_bridge.mm | 7 ------- 16 files changed, 3 insertions(+), 120 deletions(-) commit 7e59ce77374ab65273a3b1a03c3137162d37bdb3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 13:11:18 2019 +0000 Roll src/third_party/webrtc 5684af5d6334..ff393129580b (1 commits) https://webrtc.googlesource.com/src.git/+log/5684af5d6334..ff393129580b git log 5684af5d6334..ff393129580b --date=short --no-merges --format='%ad %ae %s' 2019-04-05 titovartem@google.com Add ability to have multiple connected remote endpoints Created with: gclient setdep -r src/third_party/webrtc@ff393129580b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia1080ba0b714bfb1cc87f8c3128f9a7e15134695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554726 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648152} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9ef43fcd41fceea5d36bbee8cb57d8eaa93b1dbc Author: Mohamed Abdelhalim <zetamoo@chromium.org> Date: Fri Apr 5 13:09:43 2019 +0000 Navigation: Make NavigationThrottleRunner owned by NavigationRequest. This includes moving functions that access the NavigationThrottleRunner to NavigationRequest. Bug: 916537 Change-Id: I3fa0dd84152d43b2e5b84af3044607d8c0a28872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549059 Commit-Queue: Mohamed Abdelhalim <zetamoo@google.com> Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Auto-Submit: Mohamed Abdelhalim <zetamoo@google.com> Cr-Commit-Position: refs/heads/master@{#648151} .../browser/frame_host/navigation_handle_impl.cc | 262 +------------------ .../browser/frame_host/navigation_handle_impl.h | 83 +----- .../frame_host/navigation_handle_impl_unittest.cc | 14 +- content/browser/frame_host/navigation_request.cc | 284 ++++++++++++++++++++- content/browser/frame_host/navigation_request.h | 99 ++++++- content/public/browser/navigation_throttle.cc | 5 +- 6 files changed, 396 insertions(+), 351 deletions(-) commit 2d7b5edb3646289432f80aba30d8e59e4d00bfae Author: Evan Shrubsole <eshr@google.com> Date: Fri Apr 5 13:07:08 2019 +0000 Change P2PSendPacketMetrics send_time to be based on rtc::TimeMillis P2PSendPacketMetrics.send_time should be represented consistently by the webrtc clock. Various issues occur on webrtc otherwise, as different clocks are used for different event types. To illustrate the clock differences, I have a test comparing chrome's clock to webrtc's clock. It shows that there is a difference on Windows and iOS https://chromium-review.googlesource.com/c/chromium/src/+/1514840 Bug: webrtc:10407 Change-Id: I818dfc25a18337b896c382d77b70854020cff3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526045 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648150} content/renderer/p2p/ipc_socket_factory.cc | 6 +---- services/network/p2p/socket_tcp.cc | 16 ++++++------ services/network/p2p/socket_tcp_unittest.cc | 2 +- services/network/p2p/socket_test_utils.h | 4 +-- services/network/p2p/socket_udp.cc | 35 ++++++++++++++------------ services/network/p2p/socket_udp.h | 4 +-- services/network/public/cpp/p2p_param_traits.h | 2 +- services/network/public/cpp/p2p_socket_type.h | 9 ++++--- 8 files changed, 40 insertions(+), 38 deletions(-) commit 11e75c79e1ac1718d0d8ce23dd0e8a6f5596d6d0 Author: Allen Bauer <kylixrd@chromium.org> Date: Fri Apr 5 12:48:12 2019 +0000 Initial commit of properties. Converted enabled to property. Use enabled changed callback for Link() class. Removed OnViewEnabledChanged from ViewObserver. Bug: 938501 Change-Id: I789f36b221f89d03e45941e2673d541b53b0ea7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503340 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#648149} ui/views/controls/link.cc | 8 ++- ui/views/controls/link.h | 3 +- ui/views/view.cc | 67 +++++++++++++++++++------ ui/views/view.h | 124 ++++++++++++++++++++++++++++++++++++++++++++-- ui/views/view_observer.h | 3 -- ui/views/view_unittest.cc | 26 +++++----- 6 files changed, 191 insertions(+), 40 deletions(-) commit 575a622e8d60f6b895ddec3279b92031cb3b263a Author: Marc Treib <treib@chromium.org> Date: Fri Apr 5 12:46:22 2019 +0000 Cleanup: Remove unused RegisterMergeDataFinishedCallback from PrefServiceSyncable and PrefModelAssociator Bug: none Change-Id: I2f02806babcbcc85427119640c3e70acbf972204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553553 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#648148} components/sync_preferences/pref_model_associator.cc | 12 ------------ components/sync_preferences/pref_model_associator.h | 8 -------- components/sync_preferences/pref_service_syncable.cc | 5 ----- components/sync_preferences/pref_service_syncable.h | 2 -- .../sync_preferences/pref_service_syncable_unittest.cc | 15 --------------- 5 files changed, 42 deletions(-) commit 56568ec96b13b4308ef6292e83369d8424562864 Author: Maksim Moskvitin <mmoskvitin@google.com> Date: Fri Apr 5 12:46:15 2019 +0000 [Sync::USS] Introduce NigoriSyncBridgeImpl skeleton Bug: 922900 Change-Id: I007aa799925889db4c731aaca99fcc28e86ab1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530996 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#648147} components/sync/BUILD.gn | 2 + components/sync/nigori/nigori_sync_bridge_impl.cc | 99 +++++++++++++++++++++++ components/sync/nigori/nigori_sync_bridge_impl.h | 68 ++++++++++++++++ 3 files changed, 169 insertions(+) commit ce94b6fdbaee3a52f0a4f9071f2206ecb64a1e2b Author: Yi Su <mrsuyi@chromium.org> Date: Fri Apr 5 12:31:51 2019 +0000 Keep custom search engines when region changes. Currently Chrome iOS doesn't keep custom search engines when user changes region in System Settings. This CL fixes it. Bug: 917373 Change-Id: I91954fcdf29515b4b4799c93b7fae894483c9319 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554660 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648146} .../browser/search_engines/search_engines_util.cc | 26 +++++++++++++--------- 1 file changed, 16 insertions(+), 10 deletions(-) commit 9bf17bb8ebbde01dd19c2c9c2422091f2f74edfe Author: Yi Su <mrsuyi@chromium.org> Date: Fri Apr 5 12:27:49 2019 +0000 Enable feature flag kDisplaySearchEngineFavicon. The feature "Improve favicons for iOS custom search engine settings" is finished. This CL sets the feature flag "kDisplaySearchEngineFavicon" to "ENABLED_BY_DEFAULT". Bug: 910525 Change-Id: If857a0db0a417c1ae8cfbd1acedac22e939822b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552856 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648145} ios/chrome/browser/ui/ui_feature_flags.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 78bbba0741c9d9319afe2eb927b2237e435a02e6 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 12:17:36 2019 +0000 [Sheriff] Disable FileAnalyzerTest.LargeRarSkipsContentInspection It is flaky on every platform. Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/22389 TBR=vakh@chromium.org Bug: 949399 Change-Id: I0fd61604b7e352c08e8037cb35ad238bbb7b2777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553552 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648144} .../safe_browsing/download_protection/file_analyzer_unittest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit ff5c21b84e9db779f56cccf9ca6f0fe2a301e024 Author: Peter E Conn <peconn@chromium.org> Date: Fri Apr 5 12:10:33 2019 +0000 🛃 Account for multiple Tabs in Custom Tabs close button. Previously the Custom Tabs close button would close the entire Custom Tab Activity. With this change, the close button will close only the current Tab. This will result in Tabs that were opened by following target="_blank" links being closed, revealing the Tab behind. This behaviour only occurs when the Custom Tab has a landing page criterion. Bug: 947941 Change-Id: Ic6fb05b943a431294318791f76c450c9c36c3592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553322 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#648143} .../browser/customtabs/CloseButtonNavigator.java | 60 ++++++- .../CustomTabActivityNavigationController.java | 33 ++-- .../content/CustomTabActivityTabController.java | 2 +- .../browser/customtabs/CustomTabActivityTest.java | 166 ++++++++++++------ .../customtabs/CloseButtonNavigatorTest.java | 190 +++++++++++++++++---- .../CustomTabActivityNavigationControllerTest.java | 14 -- chrome/test/data/android/cct_target_blank.html | 8 + 7 files changed, 342 insertions(+), 131 deletions(-) commit 76461f0a69daf00be18ae872ca5e3b95e7728021 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 12:07:41 2019 +0000 Roll src/third_party/webrtc a55644813876..5684af5d6334 (1 commits) https://webrtc.googlesource.com/src.git/+log/a55644813876..5684af5d6334 git log a55644813876..5684af5d6334 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 hbos@webrtc.org VideoSendStream::Stats::total_encode_time_ms added. Created with: gclient setdep -r src/third_party/webrtc@5684af5d6334 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7cc3414ab5525e86c00e9cceff4987dfea1d26a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554723 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648142} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ed62dbf88a550c7013ec62e42a9636049b4de5aa Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 11:56:52 2019 +0000 Roll src/third_party/chromite fe63720b9960..c5403d69e17c (7 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/fe63720b9960..c5403d69e17c git log fe63720b9960..c5403d69e17c --date=short --no-merges --format='%ad %ae %s' 2019-04-05 saklein@chromium.org chromite.api.TestService/DebugInfoTest: Add service. 2019-04-05 saklein@chromium.org Build API: Update READMEs. 2019-04-05 dhanyaganesh@chromium.org Buildbucket V2: GetBuildStatus equivalent function 2019-04-05 zhizhouy@google.com Fix PGO builder's profdata path error 2019-04-05 evanhernandez@chromium.org chromite: Remove cros tryjob branch-util. 2019-04-05 dhanyaganesh@chromium.org InsertBuildMessage: The function requires a list of IDs 2019-04-05 manojgupta@google.com chromeos_config: Create amd64-generic-coverage-fuzzer builder. Created with: gclient setdep -r src/third_party/chromite@c5403d69e17c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ica524dcdd6f0c1c089c6b50b2ecd7e7bd0bfa6ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554721 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648141} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a054fbb89d8a09992998fc760290b1ef91140eb6 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 11:49:30 2019 +0000 Import wpt@3315f6a940117b71680fbc6769112cdbfe2426cc Using wpt-import in Chromium 1919d3fedd529cdb2b7b3b0ce85aa8cc360e6777. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874cf2 "[WPT] Fix JSON decoding errors in referrer-policy on Safari" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I75d2859654ebaae4edcd92530e345ed87d1b781a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554443 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648140} .../blink/web_tests/external/WPT_BASE_MANIFEST_5.json | 18 ++++++++++++++---- .../web_tests/external/wpt/interfaces/wake-lock.idl | 8 +++++++- .../web_tests/external/wpt/interfaces/webrtc-stats.idl | 3 +++ .../wpt/wake-lock/idlharness.https.any-expected.txt | 9 ++++++--- .../wake-lock/idlharness.https.any.worker-expected.txt | 7 +++++-- 5 files changed, 35 insertions(+), 10 deletions(-) commit ccf1248b8bf55a5f4301065f2c81b7dee4e87fbd Author: Mihai Sardarescu <msarda@chromium.org> Date: Fri Apr 5 11:47:45 2019 +0000 Use up to 3 minutes to log the duration for Signin.Reconcilor.Duration metrics. A failure in a account reconcilor takes in general more than 10 seconds. On iOS, successful reconcilor operation are also slow and a significant part of them take more than 10 seconds. This means that Signin.Reconcilor.Duration.{Success|Failure} do not really allow us to understand how much time it takes for a reconcile operation as a lot of the counts go in the last bucket (the one from 10000 - 2147483647): Internal links: https://uma.googleplex.com/p/chrome/histograms/?endDate=20190319&dayCount=28&histograms=Signin.Reconciler.Duration.Failure%2CSignin.Reconciler.Duration.Success&fixupData=true&showMax=true&filters=platform%2Ceq%2Ci%2Cchannel%2Ceq%2C4%2Cisofficial%2Ceq%2CTrue&implicitFilters=isofficial This CL tracks the same event in a custom times hitogram that uses 100 buckets, from 1 millisecond up to 3 minutes. Change-Id: I3fed4e9eb690fa24d458733ca05968aa9e27550a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535880 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#648139} .../core/browser/account_reconcilor_unittest.cc | 8 ++++---- components/signin/core/browser/signin_metrics.cc | 8 ++++++-- tools/metrics/histograms/histograms.xml | 23 ++++++++++++++++++++++ 3 files changed, 33 insertions(+), 6 deletions(-) commit 6c207bd7f8df7fe4266942c7b8102a34f14a6dd5 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 11:47:12 2019 +0000 [Sheriff] Disable virtual/streams-native/http/tests/fetch/serviceworker/referrer-base-https-other-https.html It is flaky on Win7 trybots Bug: 949882 No-presubmit: true Change-Id: Ic732c722b10c383853ae752d5c08d0bbfd439a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554622 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648138} third_party/blink/web_tests/TestExpectations | 3 +++ 1 file changed, 3 insertions(+) commit b413e5fb1ae7c22151f4f027b6360e6835d58b61 Author: Henrik Boström <hbos@chromium.org> Date: Fri Apr 5 11:37:07 2019 +0000 Make the stats whitelist more aligned with the spec. Spec: https://w3c.github.io/webrtc-stats/ This makes our whitelist reflect the RTCRtpStreamStats hierarchy, allowing up-to-date versions of RTCOutboundRtpStreamStats and RTCInboundRtpStreamStats to be exposed to the web. Whitelisting RTCRemoteInboundRtpStreamStats and RTCRemoteOutboundRtpStreamStats becomes a one-line change in a follow-up CL, but that is blocked on implementation for now, since whitelisted dictionaries that don't appear are currently tagged as "missing" which fails the test. Bug: webrtc:10428 Change-Id: I2be030268281e2a92ebf390d4750d9347e2e5686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554664 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#648137} chrome/test/data/webrtc/peerconnection_getstats.js | 191 +++++++++++++++------ 1 file changed, 139 insertions(+), 52 deletions(-) commit 9dc056a976652652ec977c5d6c7c204dbf9d75c0 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 11:11:24 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/geolocation As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/geolocation, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic66a343d7bf50a8baf87faf957daeeed0db7ea96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553271 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648136} .../renderer/modules/geolocation/coordinates.h | 17 -------------- .../renderer/modules/geolocation/geo_notifier.cc | 6 ++--- .../renderer/modules/geolocation/geo_notifier.h | 16 ------------- .../renderer/modules/geolocation/geolocation.cc | 27 +++++++++++----------- .../modules/geolocation/geolocation_error.h | 4 ---- .../renderer/modules/geolocation/geoposition.h | 4 ---- .../renderer/modules/geolocation/position_error.h | 4 ---- 7 files changed, 17 insertions(+), 61 deletions(-) commit e077ad65604e9a56c4c741b8ef054c42973da6a8 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Apr 5 11:01:32 2019 +0000 Worker: Don't call WorkerThread::GetTaskRunner() after worker thread termination starts After WorkerThread::Terminate() (WebSharedWorkerImpl::TerminateWorkerThread()) is called, WorkerThread::GetTaskRunner() must not be called from the main thread because the underlying WorkerScheduler can be destroyed on the worker thread. Bug: 944424 Change-Id: I5074db897c0ec7448b13730e459769d988d6f173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549804 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#648135} third_party/blink/renderer/core/exported/web_shared_worker_impl.cc | 2 ++ third_party/blink/renderer/core/workers/worker_thread.h | 1 + 2 files changed, 3 insertions(+) commit 62788d302da70f089d0a15045659a2a3b6c0fd88 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 10:43:56 2019 +0000 Roll src/third_party/swiftshader 0e3d328ac338..d67ee5f5ee36 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/0e3d328ac338..d67ee5f5ee36 git log 0e3d328ac338..d67ee5f5ee36 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 swiftshader.regress@gmail.com Regres: Update test lists @ 0e3d328a Created with: gclient setdep -r src/third_party/swiftshader@d67ee5f5ee36 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I5063e4dcc337ed291531c8dc2dccae34c0cb414d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554428 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648134} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 0521e86c59feb8f7c156037f3416ef17ef8a4c7a Author: Marc Treib <treib@chromium.org> Date: Fri Apr 5 10:33:27 2019 +0000 Reenable TwoClientWalletSyncTest.UpdateServerAddressMetadataWhileNotSyncing It was previously flaky on TSan, which was (hopefully) addressed by https://crrev.com/c/1550359. Bug: 947692 Change-Id: I832ded695a096b03f30a7d7dbfab811405b9fe16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554663 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#648133} .../sync/test/integration/two_client_wallet_sync_test.cc | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) commit 0e3ae12bb3fce52fc29d3f4234e10b6e8ef26571 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 10:19:19 2019 +0000 Disable WebViewTest.CloseOnLoadcommit on chromeos dbg and asan It is flaky (crashing) TBR=lfg@chromium.org Bug: 949923 Change-Id: Ib31144c54d046c734272625c60926c1cb4f7529a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553547 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648132} chrome/browser/apps/guest_view/web_view_browsertest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) commit f014717763fa1689ae9a912f2a35ec30c9539b4c Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 10:13:16 2019 +0000 Revert "Record quic proxy server status with servicification" This reverts commit 758594644b2cc51bd1e858e5985dcfd383530780. Reason for revert: Suspected of breaking DataReductionProxyFallbackBrowsertest.ProxyBlockedOnAuthError DataReductionProxyFallbackBrowsertest.RedirectCycle on linux-chromeos-dbg Bug:949577 Original change's description: > Record quic proxy server status with servicification > > Also fixes a webdriver test when QUIC availability status of data saver > proxy is recorded. > > Bug: 934875 > Change-Id: I1320fb26b284bd23ae431f045e3e8724aa814cda > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549927 > Commit-Queue: rajendrant <rajendrant@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647087} TBR=robertogden@chromium.org,rajendrant@chromium.org,ryansturm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 934875 Change-Id: Iddbf7208e399a78ea635e5520a7fc3cc0cc66917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554343 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648131} .../data_reduction_proxy_url_loader_throttle.cc | 13 ------------- .../core/browser/data_reduction_proxy_delegate.cc | 20 ++++++++++++++++++-- .../core/browser/data_reduction_proxy_delegate.h | 13 +++++++++++++ .../data_reduction_proxy_delegate_unittest.cc | 15 +++++++++++---- .../common/data_reduction_proxy_bypass_protocol.cc | 15 --------------- .../common/data_reduction_proxy_bypass_protocol.h | 14 -------------- 6 files changed, 42 insertions(+), 48 deletions(-) commit cb013a5cee3c0c99a1aac48dfc9abd6b38799b70 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 10:03:56 2019 +0000 Roll AFDO from 75.0.3756.0_rc-r1-merged to 75.0.3757.0_rc-r1-merged This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I012f1b955960505ecbc99d87c0dc302f08e8b187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554429 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648130} chrome/android/profiles/newest.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 840288ac9d95363867755075339131b2236a8992 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 10:01:16 2019 +0000 Roll src/third_party/webrtc 144575b65a35..a55644813876 (1 commits) https://webrtc.googlesource.com/src.git/+log/144575b65a35..a55644813876 git log 144575b65a35..a55644813876 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 benwright@webrtc.org Don't recreate the VideoReceiveStream on SetFrameDecryptor in the MediaEngine. Created with: gclient setdep -r src/third_party/webrtc@a55644813876 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9a866050ec103283a4bb844d32ce2c3dd07eab28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554582 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648129} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d1430814bc0f746eda0e0f7407f403a9a5145bb1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 10:00:56 2019 +0000 Roll src/third_party/angle 9de3ddb511bc..b9a71427efd2 (2 commits) https://chromium.googlesource.com/angle/angle.git/+log/9de3ddb511bc..b9a71427efd2 git log 9de3ddb511bc..b9a71427efd2 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src e2ddb9371edb..e8c2d95ed45f (7 commits) 2019-04-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-headers/src 111a25e4ae45..2434b89345a5 (1 commits) Created with: gclient setdep -r src/third_party/angle@b9a71427efd2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Iace5e329f943e67fe80699fd65868424320afce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554581 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648128} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aead70d6b2a895afb3dccaae2c473a486c2e7c77 Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Apr 5 09:56:16 2019 +0000 media/test/data: Add RGBA and BGRA raw image Bug: 944823 Test: None Change-Id: I904ea85f3a7c08fc75c0c494054f8132bb911253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554208 Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#648127} media/test/data/README.md | 10 ++ media/test/data/bear_320x192.bgra | 180 +++++++++++++++++++++++++++++++++ media/test/data/bear_320x192.bgra.json | 6 ++ media/test/data/bear_320x192.rgba | 180 +++++++++++++++++++++++++++++++++ media/test/data/bear_320x192.rgba.json | 6 ++ 5 files changed, 382 insertions(+) commit d971719259634c992add1d386ce35f22e5885e12 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 09:53:32 2019 +0000 Roll src/third_party/catapult 140c2d87a328..9057b413d4b1 (1 commits) https://chromium.googlesource.com/catapult.git/+log/140c2d87a328..9057b413d4b1 git log 140c2d87a328..9057b413d4b1 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 pasko@chromium.org android_platform_backend: adjust app package extraction Created with: gclient setdep -r src/third_party/catapult@9057b413d4b1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948901,chromium:949321 TBR=crouleau@chromium.org Change-Id: I761dc0ff78ee1c6bcc1a1c15de238f9a40282647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554641 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648126} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c209c7d766e286fc06162e935d656bda6e76ea92 Author: jdoerrie <jdoerrie@chromium.org> Date: Fri Apr 5 09:51:46 2019 +0000 [base] Introduce base::Value ExtractKey and ExtractPath This change introduces base::Value's ExtractKey and ExtractPath to provide an API that can transfer ownership of values out of an existing dictionary. This change is motivated by the fact that this was possible in the old Remove*() API, but wasn't possible with RemoveKey and RemovePath. Bug: 646113 Change-Id: I8de4956b78652f990ecbc3f20aa757bcd6ad1dd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550471 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#648125} base/values.cc | 52 +++++++++++++++++++++++------------- base/values.h | 71 +++++++++++++++++++++++++++++++------------------ base/values_unittest.cc | 48 ++++++++++++++++++++++++++++++--- 3 files changed, 122 insertions(+), 49 deletions(-) commit 1919d3fedd529cdb2b7b3b0ce85aa8cc360e6777 Author: v.paturi <v.paturi@samsung.com> Date: Fri Apr 5 09:37:05 2019 +0000 Refactor DarkModeImageClassifier::ShouldApplyDarkModeFilterToImage(). A virtual classification method is implemented in the Image class which is overridden in the appropriate derived classes. Change-Id: Ic35dde52bc2c162bc55297bad82dd8f4e60ef81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551720 Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Reviewed-by: Stephen Chenney <schenney@chromium.org> Reviewed-by: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#648124} .../blink/renderer/core/svg/graphics/svg_image.h | 8 ++++ .../core/svg/graphics/svg_image_for_container.h | 10 ++++- .../renderer/platform/graphics/bitmap_image.cc | 8 ++++ .../renderer/platform/graphics/bitmap_image.h | 3 ++ .../graphics/dark_mode_image_classifier.cc | 45 +++++++--------------- .../platform/graphics/dark_mode_image_classifier.h | 10 ++--- .../graphics/dark_mode_image_classifier_test.cc | 37 +++++++++++------- .../renderer/platform/graphics/graphics_context.cc | 3 +- .../renderer/platform/graphics/graphics_context.h | 2 - .../blink/renderer/platform/graphics/image.cc | 16 ++++++++ .../blink/renderer/platform/graphics/image.h | 38 ++++++++++++------ 11 files changed, 111 insertions(+), 69 deletions(-) commit 6321914000583844dfc0a715bcaa8d262a9abaf7 Author: Dan Elphick <delphick@chromium.org> Date: Fri Apr 5 09:20:45 2019 +0000 [v8] Fix uses of deprecated Object::Set in components/plugins/renderer Uses Context version of Object::Set and calls Check on the result as these are cases where it cannot fail. Bug: v8:7283, v8:8834 Change-Id: I8dd6d7d45d6ad750f9e4255654d025da8892443f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552834 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648123} components/plugins/renderer/webview_plugin.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) commit 4ef8f1967a446b35de058aa09a606c3f7bb47977 Author: vitaliii <vitaliii@chromium.org> Date: Fri Apr 5 09:17:45 2019 +0000 Reland "[Sync::Scrypt] Enable Scrypt encryption by default." This reverts commit c16219a600177badafe9db8b259e1c41cc2a502c. Reason for revert: Enable using Scrypt to derive the key when encrypting data with a new custom passphrase in Chrome Sync (starting from M75). The feature was previously enabled in M74, but we haven't got Stable approval yet, so I merged a CL disabling it there: https://chromium-review.googlesource.com/c/chromium/src/+/1552848 This CL reenables the feature in M75. Original change's description: > Revert "[Sync::Scrypt] Enable Scrypt encryption by default." > > This reverts commit 2def4cc965a76cb8ee5bc85496d96f6c5a103095. > > Reason for revert: > > The experiment is going slower than expected and as a result we haven't > got an approval for Stable yet. Thus, disable using Scrypt to derive the key > when encrypting data with a new custom passphrase in Chrome Sync. > > I will merge this CL into M74 Beta and then revert it to reenable the > feature for M75, since there is no straightforward approval process for landing > CLs directly on the branch. > > Original change's description: > > [Sync::Scrypt] Enable Scrypt encryption by default. > > > > Enable using Scrypt to derive the key when encrypting data with a new > > custom passphrase in Chrome Sync (starting from M74). > > > > I manually tested the functionality locally. > > We have a kill switch, which we can use if we decide not to launch > > in M73/M74. > > > > Bug: 875901 > > Change-Id: I37dee9a66e0f519e963a6b3a13887c3bf8b2e049 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497141 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: vitaliii <vitaliii@chromium.org> > > Auto-Submit: vitaliii <vitaliii@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#638495} > > TBR=treib@chromium.org,vitaliii@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 875901 > Change-Id: If0e4a4f57c9bcf2027676fe39e60ab43be4eb592 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550422 > Auto-Submit: vitaliii <vitaliii@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647281} TBR=treib@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875901 Change-Id: Ie1cfa8ec3cc313e15be7e68d294c1b7cab397fe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554486 Commit-Queue: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#648122} components/sync/engine/sync_engine_switches.cc | 2 +- .../sync_encryption_handler_impl_unittest.cc | 26 ++++++++++++---------- 2 files changed, 15 insertions(+), 13 deletions(-) commit 3c4f9921286d79e63d1a2e93b355de3ea46fac7b Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 09:14:25 2019 +0000 Disable PasswordManagerBrowserTest.DeleteFrameBeforeSubmit The test is flaky on every platform except Win7 rel. TBR=vasilii@chromium.org Bug: 949908 Change-Id: Icfe39a1fd4d811158ffdd6a3f6fc4f0552b8e5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554620 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648121} chrome/browser/password_manager/password_manager_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e7c3d280a01766033263450b9f16a12f888a058b Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Apr 5 09:08:25 2019 +0000 media/gpu/test: ImageProcessorClient: Do not pass with std::move(frame) to ProcessVideoFrame() If std::move(frame) is called, |frame| become invalid from the second ProcessVideoFrame(). |frame| should be passed without calling std::move(). Bug: None Test: image_processor_test Change-Id: Ibd679c4b8f43d0176fb6713b7fadb21c97a5f82d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554468 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#648120} media/gpu/test/image_processor/image_processor_client.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit fa94ad009a5229595d02a806e6e21d87b876d0d4 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 09:04:45 2019 +0000 Roll src/third_party/webrtc 1c747f5717bc..144575b65a35 (3 commits) https://webrtc.googlesource.com/src.git/+log/1c747f5717bc..144575b65a35 git log 1c747f5717bc..144575b65a35 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e05071635b..f91f825874 (647992:648096) 2019-04-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b95224d1f4..e05071635b (647872:647992) 2019-04-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4aff3b8e0f..b95224d1f4 (647765:647872) Created with: gclient setdep -r src/third_party/webrtc@144575b65a35 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I621c093840e842af22a21144acd4daabf4e80e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553798 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648119} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 5997e01b8bb7f892439f14e0ec941409f66694f6 Author: Michael Lippautz <mlippautz@chromium.org> Date: Fri Apr 5 09:00:11 2019 +0000 heap: Remove unused testing reason Re-use the same GCReason for all forced garbage collections and thread more calls through the testing bottleneck. Bug: 948807 Change-Id: Ie10701ca4bd0048027fe220072d3ab758b884871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553539 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648118} .../core/v8/script_promise_resolver_test.cc | 55 ++++++-------- .../bindings/core/v8/script_streamer_test.cc | 5 +- .../blink/renderer/core/dom/dom_node_ids_test.cc | 5 +- .../renderer/core/dom/mutation_observer_test.cc | 5 +- .../renderer/core/dom/weak_identifier_map_test.cc | 5 +- .../blink/renderer/core/exported/web_heap.cc | 5 +- .../frame/csp/content_security_policy_fuzzer.cc | 5 +- .../renderer/core/imagebitmap/image_bitmap_test.cc | 5 +- .../canvas2d/canvas_rendering_context_2d_test.cc | 6 +- .../blink/renderer/platform/heap/blink_gc.h | 4 +- .../platform/heap/blink_gc_memory_dump_provider.cc | 2 +- .../blink/renderer/platform/heap/heap_compact.cc | 5 +- .../platform/heap/heap_stats_collector_test.cc | 87 +++++++++++----------- .../blink/renderer/platform/heap/heap_test.cc | 10 +-- .../renderer/platform/heap/heap_test_utilities.cc | 8 +- .../renderer/platform/heap/heap_thread_test.cc | 2 +- .../platform/heap/incremental_marking_test.cc | 3 +- .../blink/renderer/platform/heap/thread_state.cc | 31 ++++---- .../blink/renderer/platform/heap/thread_state.h | 7 +- .../platform/heap/thread_state_scheduling_test.cc | 2 +- .../renderer/platform/lifecycle_context_test.cc | 2 +- .../platform/loader/fetch/memory_cache_test.cc | 5 +- third_party/blink/renderer/platform/timer_test.cc | 9 ++- 23 files changed, 130 insertions(+), 143 deletions(-) commit 83588d6ed473f923a46484958d440da0b8a51b1b Author: Hirokazu Honda <hiroh@chromium.org> Date: Fri Apr 5 08:59:14 2019 +0000 media/gpu/test: ImageProcessorClient: Use bytes for width and height in libyuv::CopyPlane() |width| is in bytes in libyuv::CopyPlane(). We formerly pass width in pixels. This should matter when a pixel format is used whose pixel is composed of more than one bytes. Bug: None Test: image_processor_test Change-Id: I98e90be70c8d0128319172d4d19f3a8017b65d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553129 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#648117} media/gpu/test/image_processor/image_processor_client.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 52b60b4ef79ab047a56157a6708ca87c16faa213 Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Apr 5 08:59:06 2019 +0000 Revert "Make dialogs not draggable (Widgets with MODAL_TYPE_NONE remain" This reverts commit 0a25dcdee8f2c3cfd95a16fe3a1ae76a17303e4a. Reason for revert: Suspected of making DialogTest.InitialFocusWithDeactivatedWidget very flaky on Mac Bug:949911 Original change's description: > Make dialogs not draggable (Widgets with MODAL_TYPE_NONE remain > draggable). > > This change makes the title area of a dialog act as the client. Also > removed code so system menu does not appear on dialogs. This makes more > sense since the system dialog has properties such as move (which is now > illegal, also it doesn't work), and resize (illegal), and close with > hints of using Alt+F4 (Alt+F4 does not close dialogs). > > Bug: 930782 > Change-Id: I0956b85df2c3059af7b38b63ccf8774ccd150158 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536198 > Commit-Queue: Charlene Yan <cyan@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647985} TBR=tapted@chromium.org,bsep@chromium.org,cyan@chromium.org Change-Id: I800192f4a32822b68b9027f0b7b1ebcab9e22684 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 930782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553544 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#648116} .../bubble/bubble_dialog_delegate_view_unittest.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 23 +++--- ui/views/window/dialog_delegate_unittest.cc | 81 +++++++--------------- 3 files changed, 38 insertions(+), 68 deletions(-) commit c4f9ca956e86e3e327e82da8b953c7fdbb53b5d2 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 08:55:55 2019 +0000 Roll src/third_party/catapult 810aaa1e1846..140c2d87a328 (1 commits) https://chromium.googlesource.com/catapult.git/+log/810aaa1e1846..140c2d87a328 git log 810aaa1e1846..140c2d87a328 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 pasko@chromium.org android_platform_backend: more verbose emptiness Created with: gclient setdep -r src/third_party/catapult@140c2d87a328 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:949321 TBR=crouleau@chromium.org Change-Id: Ie75c79c52ca89cadb2284d72ae6d94d1631725fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553797 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648115} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 1658efa16e590207600b9c00ebc599dc9d624099 Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Apr 5 08:32:12 2019 +0000 service worker: Remove most "S13nServiceWorker" occurrences. Non-S13nServiceWorker is no longer supported, so S13nServiceWorker can be assumed without mentioning it. Bug: 926114 Change-Id: If41849dc07d37da18636ef04882c585ed77c730e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548969 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648114} .../service_worker/embedded_worker_instance.cc | 2 +- .../service_worker_context_wrapper.h | 1 - .../service_worker_fetch_dispatcher.cc | 85 ---------------------- .../service_worker_fetch_dispatcher.h | 10 +-- .../service_worker_installed_script_loader.h | 5 +- .../service_worker_navigation_loader.cc | 9 +-- .../service_worker_navigation_loader.h | 1 - .../service_worker_new_script_loader.h | 1 - .../service_worker/service_worker_provider_host.h | 7 -- .../service_worker_registration_unittest.cc | 15 ++-- .../service_worker_script_loader_factory.h | 1 - .../service_worker/service_worker_version.cc | 4 +- .../service_worker/service_worker_version.h | 30 +++----- .../worker_host/worker_script_loader_factory.h | 1 - content/renderer/loader/web_url_request_util.h | 2 +- .../loader/web_worker_fetch_context_impl.h | 14 +--- .../controller_service_worker_impl.h | 5 +- .../service_worker_context_client.cc | 3 - .../service_worker/service_worker_context_client.h | 1 - .../service_worker_network_provider_for_frame.cc | 6 +- .../service_worker_network_provider_for_frame.h | 1 - .../service_worker_provider_context.h | 11 +-- .../service_worker_provider_context_unittest.cc | 20 +++-- .../service_worker_provider_state_for_client.h | 4 - .../service_worker_subresource_loader.h | 2 - .../network/throttling/throttling_controller.cc | 8 -- .../network/throttling/throttling_controller.h | 10 --- .../service_worker/controller_service_worker.mojom | 3 - .../controller_service_worker_mode.mojom | 6 -- .../mojom/service_worker/embedded_worker.mojom | 29 ++++++-- .../mojom/service_worker/service_worker.mojom | 5 +- .../service_worker/service_worker_container.mojom | 3 - .../service_worker/service_worker_provider.mojom | 2 - .../mojom/worker/shared_worker_factory.mojom | 13 ++-- .../web_service_worker_network_provider.h | 1 - .../core/exported/web_shared_worker_impl.cc | 15 ++-- .../modules/exported/web_embedded_worker_impl.cc | 13 +--- 37 files changed, 82 insertions(+), 267 deletions(-) commit 0a0f7641aa5cd076140b833e81dc142b77818a83 Author: Clemens Arbesser <arbesser@google.com> Date: Fri Apr 5 08:29:19 2019 +0000 [Autofill Assistant] Introducing a new custom widget for use in the AA payment request. This CL introduces the AssistantChoiceList, a custom UI view container which automatically displays its children as choices in a vertical list. Each choice has a radio button and an optional 'edit' button. At the bottom of the list is an optional 'add' button. A number of custom view attributes control the layout and look of this widget. Most importantly, this container allows adding arbitrary children as 'content', in contrast to regular RadioButtons which only support a built-in TextView. This CL is part of an ongoing effort to modularize the PR UI. In upcoming CLs, this widget will be used in all other PR sections. For now, only the terms & conditions section is changed to cut down on CL size. This CL also fixes a bug where the font color of the terms & conditions text was not correctly set. There should be no other user-visible changes. Before: https://screenshot.googleplex.com/eZ7xYVVwRBq.png After: https://screenshot.googleplex.com/mFUxpwn3NVj.png Bug: 806868 Change-Id: I27252596567341624d7dd25342c1ee84336b2f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532565 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#648113} .../android/features/autofill_assistant/BUILD.gn | 2 + .../ic_autofill_assistant_add_circle_24dp.xml | 16 + .../layout/autofill_assistant_payment_request.xml | 23 +- .../java/res/values-v17/attrs.xml | 14 + .../payment/AssistantChoiceList.java | 339 +++++++++++++++++++++ .../payment/AssistantPaymentRequestUI.java | 28 +- 6 files changed, 397 insertions(+), 25 deletions(-) commit 0c85e786ffeca0d2d5f922d309b256dab9c828b1 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 08:25:54 2019 +0000 Import wpt@ad8be3278b9adfecc450bf1795f8137dcd584624 Using wpt-import in Chromium 6ce865dc25bdcec8a13471c4368958a3f690755b. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874cf2 "[WPT] Fix JSON decoding errors in referrer-policy on Safari" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I68579da5fa9f08b4111769184dc701acaaf4a2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553614 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648112} third_party/blink/web_tests/TestExpectations | 27 +++ .../web_tests/external/WPT_BASE_MANIFEST_5.json | 270 +++++++++++++++++++++ .../text-decoration-line-001-manual.html | 33 +++ .../text-decoration-line-002-manual.html | 32 +++ .../text-decoration-line-003-manual.html | 32 +++ .../text-decoration-line-004-manual.html | 32 +++ .../text-decoration-line-040-manual.html | 40 +++ .../text-decoration-line-040a-manual.html | 37 +++ .../text-decoration-line-041-manual.html | 34 +++ .../text-decoration-line-044-manual.html | 39 +++ .../text-decoration-line-045-manual.html | 33 +++ .../text-decoration-line-046a-manual.html | 37 +++ .../text-decoration-line-048-manual.html | 35 +++ .../text-decoration-line-048a-manual.html | 40 +++ .../text-decoration-line-049-manual.html | 41 ++++ .../text-decoration-line-082-manual.html | 34 +++ .../text-decoration-line-085-manual.html | 34 +++ .../text-decoration-line-090-manual.html | 34 +++ .../text-decoration-line-090a-manual.html | 39 +++ .../text-decoration-line-091-manual.html | 34 +++ .../text-decoration-line-091a-manual.html | 39 +++ .../text-decoration-line-092-manual.html | 34 +++ .../text-decoration-line-092a-manual.html | 39 +++ .../text-decoration-line-095-manual.html | 34 +++ .../text-decoration-line-095a-manual.html | 39 +++ .../text-decoration-line-096-manual.html | 34 +++ .../text-decoration-line-096a-manual.html | 39 +++ .../text-decoration-line-097-manual.html | 34 +++ .../text-decoration-line-097a-manual.html | 39 +++ 29 files changed, 1268 insertions(+) commit 6efb96fecef40a5b2f550c4de37edbef2d9dde90 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Apr 5 08:19:24 2019 +0000 Apply testharness.js to non-pixel web tests from dom/domparsing This CL removes js-test.js and applies testharness.js from test files in dom/domparsing. The previous change for dom/domparsing is crrev.com/c/1553120 and it completes converting in dom/domparsing. The changed test files on this CL are listed up below. third_party/blink/web_tests/dom/domparsing/xmlserializer-attribute-entities.html third_party/blink/web_tests/dom/domparsing/xmlserializer-attribute-namespace.html third_party/blink/web_tests/dom/domparsing/xmlserializer-attribute-ns-prefix.html third_party/blink/web_tests/dom/domparsing/xmlserializer-attribute-special-namespaces.html third_party/blink/web_tests/dom/domparsing/xmlserializer-doctype.html third_party/blink/web_tests/dom/domparsing/xmlserializer-doctype2.html third_party/blink/web_tests/dom/domparsing/xmlserializer-double-xmlns.html third_party/blink/web_tests/dom/domparsing/xmlserializer-entities.html third_party/blink/web_tests/dom/domparsing/xmlserializer-serialize-to-string-exception.html third_party/blink/web_tests/dom/domparsing/xmlserializer-xml-namespace.html Bug: 936364 Change-Id: I469adfa27107b35b9086bd8fc99087b0c8727834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553268 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#648111} .../xmlserializer-attribute-entities-expected.txt | 10 ---- .../xmlserializer-attribute-entities.html | 12 ++-- .../xmlserializer-attribute-namespace-expected.txt | 30 ---------- .../xmlserializer-attribute-namespace.html | 50 ++++++++-------- .../xmlserializer-attribute-ns-prefix-expected.txt | 10 ---- .../xmlserializer-attribute-ns-prefix.html | 18 ++++-- ...lizer-attribute-special-namespaces-expected.txt | 15 ----- ...xmlserializer-attribute-special-namespaces.html | 21 +++---- .../domparsing/xmlserializer-doctype-expected.txt | 2 - .../dom/domparsing/xmlserializer-doctype.html | 26 ++------- .../domparsing/xmlserializer-doctype2-expected.txt | 14 ----- .../dom/domparsing/xmlserializer-doctype2.html | 16 ++++-- .../xmlserializer-double-xmlns-expected.txt | 10 ---- .../dom/domparsing/xmlserializer-double-xmlns.html | 10 ++-- .../domparsing/xmlserializer-entities-expected.txt | 1 - .../dom/domparsing/xmlserializer-entities.html | 16 ++---- ...izer-serialize-to-string-exception-expected.txt | 66 ---------------------- ...mlserializer-serialize-to-string-exception.html | 61 ++++---------------- .../xmlserializer-xml-namespace-expected.txt | 1 - .../domparsing/xmlserializer-xml-namespace.html | 23 ++++---- 20 files changed, 105 insertions(+), 307 deletions(-) commit c00d45b48ea18964552eb7d9f0c1eb6e9124eac2 Author: David Staessens <dstaessens@chromium.org> Date: Fri Apr 5 08:16:14 2019 +0000 media/gpu/test: Move common video decoder test initialization to environment. This CL moves some common video decoder test initialization (mojo, logging) to the test environment, so it can be shared between the video decoder and video decoder perf tests. This CL also moves some unnecessary includes out of the test environment's header file. TEST=ran new VDA (perf) tests on nocturne BUG=925714 Change-Id: Ibaea0e64ec9f9d1c7fb662714474ea8cbfbc27a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552382 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#648110} media/gpu/BUILD.gn | 2 -- media/gpu/test/BUILD.gn | 1 + .../video_player/video_player_test_environment.cc | 25 ++++++++++++++++++++-- .../video_player/video_player_test_environment.h | 16 ++++++-------- media/gpu/video_decode_accelerator_perf_tests.cc | 9 -------- media/gpu/video_decode_accelerator_tests.cc | 9 -------- 6 files changed, 31 insertions(+), 31 deletions(-) commit dfb0c86b89a93835a0b211cae70d316da38b0460 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 08:03:57 2019 +0000 Roll src/third_party/angle fb201c5e208d..9de3ddb511bc (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/fb201c5e208d..9de3ddb511bc git log fb201c5e208d..9de3ddb511bc --date=short --no-merges --format='%ad %ae %s' 2019-04-05 spang@chromium.org Generate entrypoints for GL_EXT_memory_object_fd & GL_EXT_semaphore_fd Created with: gclient setdep -r src/third_party/angle@9de3ddb511bc The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I43894f9f4a65727a9727557649f5b5c07132c08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553617 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648109} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit c021748aacf9da63277e1b00a3c231d635548dd9 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 08:01:08 2019 +0000 Roll src/third_party/skia 1f58a8e457ba..604d5a3fca01 (1 commits) https://skia.googlesource.com/skia.git/+log/1f58a8e457ba..604d5a3fca01 git log 1f58a8e457ba..604d5a3fca01 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@604d5a3fca01 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: I8e5e3dda51f5666bc75e5b74ac2978fa18d9cae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553618 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648108} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ccdb33af4bb8edf64e5e0ba60c64f98011c9a2bf Author: Yi Su <mrsuyi@chromium.org> Date: Fri Apr 5 07:59:42 2019 +0000 Display favicons in Search Engine Settings. This CL enables Search Engine Settings to display favicons for search engines. A new TableViewItem is created as ios/chrome/browser/ui/settings/cells/search_engine_item.* which reuses the TableViewURLItem to display the favicon, the short name and the keyword of a TemplateURL. This feature is shipped behind the flag: kDisplaySearchEngineFavicon. old UI: https://drive.google.com/open?id=1zUIW7IDDAAa-aj3OJT7swteirYc3RM_s https://drive.google.com/open?id=1w4kyGX8kJ64gLWpDhq9cTb340Hvw1zjl new UI: https://drive.google.com/open?id=1O4WjdfUviAeOgMuL2-KufPufhGxdshtk https://drive.google.com/open?id=1HWHDPEVF16vwku1zUiwhYoD7s7159ld5 Bug: 433824, 910525 Change-Id: I03c99ab5d3fc06f4e3f1f8c63e648a8d003504c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1365238 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648107} ios/chrome/browser/ui/settings/BUILD.gn | 2 + ios/chrome/browser/ui/settings/cells/BUILD.gn | 6 + .../browser/ui/settings/cells/search_engine_item.h | 30 +++ .../ui/settings/cells/search_engine_item.mm | 86 +++++++ .../settings/cells/search_engine_item_unittest.mm | 72 ++++++ .../search_engine_table_view_controller.mm | 285 ++++++++++++--------- ...search_engine_table_view_controller_unittest.mm | 259 +++++++++++-------- 7 files changed, 514 insertions(+), 226 deletions(-) commit 1d81464c735323856dd1139138ad03961c57ba93 Author: Roman Sorokin <rsorokin@chromium.org> Date: Fri Apr 5 07:58:32 2019 +0000 cros: Add Attestation enrollment browser test. cryptohome and CA network communication is mocked. Also fixes certificate_based_register handling in policy_testserver.py This is reland of CL:1523099. Reason it was reverted fixed in CL:1552079 TBR=pmarko@chromium.org,jdufault@chromium.org Bug: 934224, 943473 Change-Id: I3f08706d8fd7b0e0294eceeaeb6754c5dfd3a19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554483 Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#648106} .../enrollment_local_policy_server_browsertest.cc | 35 ++++++++++++++++++---- .../login/test/local_policy_test_server_mixin.cc | 4 +++ .../policy/device_cloud_policy_initializer.cc | 5 ++++ .../policy/device_cloud_policy_initializer.h | 2 ++ chrome/browser/policy/test/policy_testserver.py | 14 +++++++-- .../core/common/cloud/cloud_policy_client.cc | 4 ++- 6 files changed, 54 insertions(+), 10 deletions(-) commit 71b951a962d6a519e48e25334cc4ecfe63f8f802 Author: Yuichiro Hanada <yhanada@google.com> Date: Fri Apr 5 07:57:32 2019 +0000 Send VK bounds changes even when ARC++ app is not focused. We need to send VK bounds change even when ARC++ app is not focused to update the size of the dummy IME view in Android. If we don't update the size, WM can move up views in the apps not to be covered by the dummy IME view. Bug: b/124401771 Bug: 943370 Change-Id: I5a2f9a32f6c30d636e6aaad79bc04a36451166c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553048 Auto-Submit: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#648105} components/arc/ime/arc_ime_service.cc | 2 -- 1 file changed, 2 deletions(-) commit 934b39bfed3485fab447575f2eec4d1d012e931c Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 07:54:22 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/crypto As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/crypto, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I63d62e2c8f991a4fa205c6a9d03ac5d7bdb19f9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554203 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648104} .../v8_script_value_deserializer_for_modules.cc | 2 +- .../v8_script_value_serializer_for_modules_test.cc | 2 +- .../blink/renderer/modules/crypto/crypto.cc | 2 +- .../blink/renderer/modules/crypto/crypto_key.h | 4 ---- .../renderer/modules/crypto/crypto_result_impl.cc | 12 +++++------ .../renderer/modules/crypto/crypto_result_impl.h | 2 -- .../renderer/modules/crypto/dom_window_crypto.cc | 2 +- .../blink/renderer/modules/crypto/subtle_crypto.cc | 24 +++++++++++----------- .../blink/renderer/modules/crypto/subtle_crypto.h | 2 -- .../modules/crypto/worker_global_scope_crypto.cc | 2 +- .../modules/peerconnection/rtc_peer_connection.cc | 2 +- 11 files changed, 23 insertions(+), 33 deletions(-) commit 2ea4d82031fbb71c1e410a2a6bb706c7bd6a3a40 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 07:52:40 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/gamepad As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/gamepad, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Id95c530d7aff74dfcdcbb6a8d80d2dcefb709a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553126 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648103} .../blink/renderer/modules/gamepad/gamepad.cc | 9 ++---- .../blink/renderer/modules/gamepad/gamepad.h | 2 -- .../renderer/modules/gamepad/gamepad_button.cc | 4 --- .../renderer/modules/gamepad/gamepad_button.h | 2 -- .../modules/gamepad/gamepad_comparisons_test.cc | 32 ++++++++++++---------- .../blink/renderer/modules/gamepad/gamepad_list.h | 2 -- .../blink/renderer/modules/gamepad/gamepad_pose.h | 2 -- .../renderer/modules/gamepad/navigator_gamepad.cc | 6 ++-- 8 files changed, 22 insertions(+), 37 deletions(-) commit 953e9e5583bba3926a7e7a96ef5370d433988710 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 07:38:40 2019 +0000 Roll Fuchsia SDK from 891707580481 to 891704345208 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4c1803f17e4e2cd4c3581b1a8a1d938e346eaac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554442 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648102} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 6421f718a3c047e4e3b9299782f82ea71749272c Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 07:24:47 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/encryptedmedia As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/encryptedmedia, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ib61dfe43a020e7368b24b403d06e0cdd2691a2f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554204 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648101} .../encryptedmedia/html_media_element_encrypted_media.cc | 3 ++- .../renderer/modules/encryptedmedia/media_key_session.cc | 8 -------- .../blink/renderer/modules/encryptedmedia/media_key_session.h | 4 ---- .../renderer/modules/encryptedmedia/media_key_status_map.cc | 6 +----- .../modules/encryptedmedia/media_key_system_access.cc | 2 +- .../blink/renderer/modules/encryptedmedia/media_keys.cc | 11 ++--------- .../blink/renderer/modules/encryptedmedia/media_keys.h | 5 ----- 7 files changed, 6 insertions(+), 33 deletions(-) commit e4e1de722414c20cab2f4aba438f1db701b2098a Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 07:24:32 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/csspaint As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/csspaint, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic8a81ea53319b1a97d63873d430790510adf743a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553266 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648100} .../renderer/modules/csspaint/css_paint_definition.cc | 17 ++--------------- .../renderer/modules/csspaint/css_paint_definition.h | 9 --------- .../modules/csspaint/paint_rendering_context_2d.h | 9 --------- .../modules/csspaint/paint_rendering_context_2d_test.cc | 2 +- .../blink/renderer/modules/csspaint/paint_size.h | 4 ---- .../blink/renderer/modules/csspaint/paint_worklet.cc | 7 +------ .../blink/renderer/modules/csspaint/paint_worklet.h | 1 - .../modules/csspaint/paint_worklet_global_scope.cc | 2 +- 8 files changed, 5 insertions(+), 46 deletions(-) commit e116eb5e36c78568ee6fbdf03656fb6fe1c71b8d Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Apr 5 07:18:50 2019 +0000 Add tests for FetchDataLoader::CreateLoaderAsDataPipe Bug: None Change-Id: Ia26cb3c0c2118fc9a3e87775256c246a88717fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552394 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648099} .../renderer/core/fetch/fetch_data_loader_test.cc | 193 +++++++++++++++++++-- 1 file changed, 175 insertions(+), 18 deletions(-) commit 0cf92ee610b54bafcb39652026cc0028a519a6d2 Author: Miyoung Shin <myid.shin@igalia.com> Date: Fri Apr 5 07:16:39 2019 +0000 Use double type to text_metrics.idl This CL updates IDL file to follow spec APIs and Blink implementation uses already double type. Bug: 938800 Change-Id: I6d2c9dc8e0e038d702f65e5dff0688eebac8f4c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553270 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#648098} third_party/blink/renderer/core/html/canvas/text_metrics.idl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 302a42b55d570a7b4d3ad919654ddf927d513a80 Author: Jia <jiameng@chromium.org> Date: Fri Apr 5 07:11:39 2019 +0000 [On-device adaptive brightness] Move adapter decision into one function. This cl moves all decision makings into CanAdjustBrightness. The purposes are * better structure * in the next cl, we will log reasons of adapter behaviour. Bug: 881215 Change-Id: Ib721b6365153aac0233b5744ec9de7d4b32d8594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548966 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by: Michael Martis <martis@chromium.org> Cr-Commit-Position: refs/heads/master@{#648097} .../power/auto_screen_brightness/adapter.cc | 159 +++++++++++++-------- .../power/auto_screen_brightness/adapter.h | 73 +++++++--- 2 files changed, 152 insertions(+), 80 deletions(-) commit f91f825874d583df50e1e21e4da671fc2d210090 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Fri Apr 5 07:00:32 2019 +0000 Use IsRangeValueSupported to identify if AtkValue should be implemented Non-focusable splitters were implementing AtkValue because we were doing a role check without taking the focusable state into account. There is ui::IsRangeValueSupported() which does handles all the cases we should be at the platform-independent level. So use it instead. It is unlikely that there will be widgets for which only ATK expects range support. Bug: 949803 Change-Id: I5670c33d56d27dfa0a28e87d0af50e602cb1bdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553206 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Auto-Submit: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#648096} .../aria/aria-expanded-expected-auralinux.txt | 6 +++--- .../aria/aria-listbox-expected-auralinux.txt | 2 +- .../aria/aria-orientation-expected-auralinux.txt | 6 +++--- .../aria/aria-separator-expected-auralinux.txt | 2 +- .../data/accessibility/html/hr-expected-auralinux.txt | 4 ++-- ui/accessibility/platform/ax_platform_node_auralinux.cc | 16 ++-------------- 6 files changed, 12 insertions(+), 24 deletions(-) commit 797ed9118c65197c0adcc4b1c518ef4d1a70e4c5 Author: Miyoung Shin <myid.shin@igalia.com> Date: Fri Apr 5 07:00:12 2019 +0000 Fix a typo of spec links in webaudio idl files. Bug: 938800 Change-Id: Ieb2efcd411c083006158ab33fe3d26cf9f539b1c No-try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554207 Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#648095} .../blink/renderer/modules/webaudio/audio_buffer_source_options.idl | 2 +- .../blink/renderer/modules/webaudio/offline_audio_context_options.idl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit a8b3d74d9e8d59139396b931af7687072fa05d80 Author: Makoto Shimazu <shimazu@chromium.org> Date: Fri Apr 5 06:55:51 2019 +0000 Add ServiceWorkerUpdateDelay experiment This expeirment is to explore duration from naviagtion to starting an update of a service worker script. This CL adds a variable update_delay_in_ms, which varies a delay from network quiet to an update task. There is another variable which is duration from navigation request to network idle, but this CL doesn't add it since TTFMP seems depending on the value. Bug: 945717 Change-Id: I78f31d6f8ffdf890eeb42e122a158d25c581546d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552760 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648094} content/browser/service_worker/service_worker_version.cc | 13 ++++++++++--- third_party/blink/common/features.cc | 5 +++++ third_party/blink/public/common/features.h | 1 + 3 files changed, 16 insertions(+), 3 deletions(-) commit 72827ba87d6df1d160c29a9b19bd42306d7bfe60 Author: Eric Lawrence <ericlaw@microsoft.com> Date: Fri Apr 5 06:55:32 2019 +0000 Update autofill build.gn and DEPS after features launched The autofill build files included unneeded references that were to be removed after the associated features had launched. The features were launched, so the references should be removed. Bug: 677925, 739343, 753806 Change-Id: I220e4eab986a4e535c38d78d54b83011bd9c40b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553713 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#648093} components/autofill/content/renderer/BUILD.gn | 8 -------- components/autofill/content/renderer/DEPS | 17 ----------------- .../content/renderer/password_autofill_agent.cc | 3 --- .../content/renderer/password_form_conversion_utils.cc | 1 - .../password_form_conversion_utils_browsertest.cc | 1 - 5 files changed, 30 deletions(-) commit 1e59bd7c42f0d90d832e15354aadc722306720f5 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 06:53:33 2019 +0000 Roll src/third_party/skia f8f4cd0ecae7..1f58a8e457ba (2 commits) https://skia.googlesource.com/skia.git/+log/f8f4cd0ecae7..1f58a8e457ba git log f8f4cd0ecae7..1f58a8e457ba --date=short --no-merges --format='%ad %ae %s' 2019-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 43997017b0ed..fb201c5e208d (6 commits) 2019-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 3ae962179e68..3e2882be2dde (447 commits) Created with: gclient setdep -r src/third_party/skia@1f58a8e457ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: I9f56221623b206456b0cf91815576a73c6672b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553615 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648092} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ba4261ba8f47199af28c6f5efdfc22b4971b0df5 Author: Ramin Halavati <rhalavati@chromium.org> Date: Fri Apr 5 06:34:59 2019 +0000 Remove inititial focus of incognito window count menu. Incognito window count menu was initially focused on its disabled title card which resulted in transfer of focus to the next button and making it highlighted. Initial focus is removed from the menu to avoid this behavior. Bug: 949072 Change-Id: I4bef34734ffde8d01a86c239082973b7c9e6a371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552081 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#648091} chrome/browser/ui/views/profiles/incognito_menu_view.cc | 4 ---- chrome/browser/ui/views/profiles/incognito_menu_view.h | 1 - 2 files changed, 5 deletions(-) commit 931e13685a1e4f4b1c4a2d76e36e1f127b75ab80 Author: Morten Stenshorne <mstensho@chromium.org> Date: Fri Apr 5 06:29:16 2019 +0000 Get the preferred main size from a size-contained flex item's box. Assuming 0 won't do in all cases, at least not for multicol, since we have to take column-gap and column-width into account. With contain:size we're supposed to pretend that a box has no contents, which doesn't imply that we can ignore column-gap and column-width. This only fixes it when the main axis is the inline axis. When it's the block axis, it might be safe to return 0 (which is what we still do). This improves the rendering of css/vendor-imports/mozilla/mozilla-central-reftests/contain/contain-size-multicol-003.html but we still fail. Bug: 863454 Change-Id: I444f94321dc1b10741515d8527ed4fdd72e6a15e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552039 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#648090} .../renderer/core/layout/layout_flexible_box.cc | 6 ++--- .../contain-size-multicol-as-flex-item.html | 30 ++++++++++++++++++++++ 2 files changed, 33 insertions(+), 3 deletions(-) commit 62aeca425a8a90f7d9fa5b807faa099ee68b1dd1 Author: Rakina Zata Amni <rakina@chromium.org> Date: Fri Apr 5 06:22:56 2019 +0000 Add use counter for constructable stylesheet features To track usages. Bug: 944631 Change-Id: Ib1b399d144f4f01b8a2c8dc502a0bc572bb27355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553125 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#648089} third_party/blink/public/mojom/web_feature/web_feature.mojom | 3 +++ third_party/blink/renderer/core/css/css_style_sheet.idl | 4 ++-- third_party/blink/renderer/core/dom/document_or_shadow_root.idl | 2 +- tools/metrics/histograms/enums.xml | 3 +++ 4 files changed, 9 insertions(+), 3 deletions(-) commit a66191ec56833dd9ac1db26d330a6c51b1fe2986 Author: Daniel Bratell <bratell@opera.com> Date: Fri Apr 5 06:08:01 2019 +0000 Make blink/core expose blink/core/* in gn Since nobody is allowed to depend on core's sub targets it's necessary to have blink/core expose them. This has no immediately visible impact since the private dependency will have ensured build order and gn's dependency checks are disabled in blink/core (because it's a mess and kind of works anyway). Bug: 800764 Change-Id: I31c326f893f1c2c90a27fdfa195ff719784ab8ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552847 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#648088} third_party/blink/renderer/core/BUILD.gn | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) commit 03ce7226087bd219969ba40e3968beaf4ac649bb Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Fri Apr 5 06:07:23 2019 +0000 Switch third_party/blink/renderer/core/editing to use new downcast helpers (2/n) Bug: 891908 Change-Id: If45e55d04de09945834f5b8671e23fc993fd8ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553259 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648087} .../core/editing/commands/composite_edit_command.h | 12 +++++++----- .../renderer/core/editing/commands/edit_command.cc | 5 +++-- .../core/editing/commands/replace_selection_command.h | 6 ------ .../core/editing/markers/active_suggestion_marker.h | 6 ------ .../renderer/core/editing/markers/composition_marker.h | 6 ------ .../core/editing/markers/document_marker_controller.cc | 18 +++++++++--------- .../editing/markers/spell_check_marker_list_impl.h | 15 ++++++++------- .../core/editing/markers/suggestion_marker_list_impl.h | 12 +++++++----- .../renderer/core/editing/markers/text_match_marker.h | 12 +++++++----- .../editing/markers/text_match_marker_list_impl.cc | 4 ++-- .../core/editing/markers/text_match_marker_list_impl.h | 12 +++++++----- .../renderer/core/paint/inline_text_box_painter.cc | 4 ++-- .../renderer/core/paint/ng/ng_text_fragment_painter.cc | 3 +-- third_party/blink/renderer/core/testing/internals.cc | 2 +- 14 files changed, 54 insertions(+), 63 deletions(-) commit 0913489cdebf105c0446e6e242f49e36342a5188 Author: Abhijeet Kandalkar <abhijeet@igalia.com> Date: Fri Apr 5 05:55:05 2019 +0000 Switch third_party/blink/renderer/core/editing to use new downcast helpers (1/n) This CL removes DEFINE_TYPE_CASTS for TypingCommand, SpellCheckMarker, StyleableMarker, SuggestionMarker to use new downcast helpers. Bug: 891908 Change-Id: If0a22bc8ab20c22beae23976a0a1f5b302814fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552215 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648086} .../editing/commands/editing_commands_utilities.cc | 6 +++--- .../renderer/core/editing/commands/typing_command.h | 12 +++++++----- .../editing/markers/document_marker_controller.cc | 4 ++-- .../markers/document_marker_controller_test.cc | 15 +++++++-------- .../core/editing/markers/spell_check_marker.h | 12 +++++++----- .../core/editing/markers/styleable_marker.h | 12 +++++++----- .../core/editing/markers/suggestion_marker.h | 12 +++++++----- .../editing/markers/suggestion_marker_list_impl.cc | 2 +- .../core/editing/spellcheck/spell_checker.cc | 2 +- .../core/editing/spellcheck/spell_checker_test.cc | 6 +++--- .../suggestion/text_suggestion_controller.cc | 21 +++++++++------------ .../suggestion/text_suggestion_controller_test.cc | 6 +++--- .../renderer/core/paint/inline_text_box_painter.cc | 2 +- .../core/paint/ng/ng_text_fragment_painter.cc | 2 +- .../blink/renderer/core/testing/internals.cc | 12 +++++++----- 15 files changed, 66 insertions(+), 60 deletions(-) commit 7beb46dc6f71c8e6fdbbd16a143783b32a21acda Author: Luciano Pacheco <lucmult@chromium.org> Date: Fri Apr 5 05:47:13 2019 +0000 [Files app] ES6 class for some (toolbar|list_thumbnail)_controller.js Bug: 778674 Change-Id: Icc03e1770e7deb15ad063b7265197a8de6bcde92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554460 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#648085} .../foreground/js/list_thumbnail_loader.js | 760 +++++++++++---------- .../foreground/js/toolbar_controller.js | 371 +++++----- 2 files changed, 570 insertions(+), 561 deletions(-) commit bf79b329940e712f0227c4fb0d707b21f2b7d13f Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 05:46:26 2019 +0000 Roll src/third_party/angle 7a8c3e5ebe3e..fb201c5e208d (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/7a8c3e5ebe3e..fb201c5e208d git log 7a8c3e5ebe3e..fb201c5e208d --date=short --no-merges --format='%ad %ae %s' 2019-04-05 spang@chromium.org Implement resource management for GL_EXT_memory_object Created with: gclient setdep -r src/third_party/angle@fb201c5e208d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: Idb9ea7f4c5c68a2f30cbc186f8237f662d5e0d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553867 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648084} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 123c1117a48653148f83b8b3269df95db9bb39b6 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 05:46:05 2019 +0000 Roll src/third_party/skia 51874e3e3712..f8f4cd0ecae7 (2 commits) https://skia.googlesource.com/skia.git/+log/51874e3e3712..f8f4cd0ecae7 git log 51874e3e3712..f8f4cd0ecae7 --date=short --no-merges --format='%ad %ae %s' 2019-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 225a13016b1c..0e3d328ac338 (5 commits) 2019-04-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@f8f4cd0ecae7 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: Ifb202d6a72386dd20ed41fe80f287c1202969f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553446 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648083} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 695e802ee27e6e8f95956c86839b7e16abcb7ec6 Author: Yoshifumi Inoue <yosin@chromium.org> Date: Fri Apr 5 05:44:10 2019 +0000 Converts drag-in-iframe.html to utilize w3c test harness Because of "drag-in-iframe.html" doesn't require pixel comparison, this patch converts "drag-in-iframe.html" to utilize w3c test harness with introducing |internals.getDragCaret()| to check position of drag caret in test scripts, for ease of maintenance. Note: This patch helps to utilize --enable-display-compositor-pixel-dump. Bug: 891427 Change-Id: Ie1ae56ac971271bccd6109a5044d25b433620f92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552397 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#648082} .../blink/renderer/core/editing/drag_caret.h | 2 +- .../blink/renderer/core/testing/internals.cc | 12 ++++++ .../blink/renderer/core/testing/internals.h | 1 + .../blink/renderer/core/testing/internals.idl | 1 + .../renderer/core/testing/static_selection.cc | 16 ++++++++ .../blink/renderer/core/testing/static_selection.h | 3 ++ .../renderer/core/testing/static_selection.idl | 1 + third_party/blink/web_tests/TestExpectations | 1 - .../editing/selection/drag-in-iframe.html | 42 +++++++++++---------- .../editing/selection/drag-in-iframe-expected.png | Bin 12706 -> 0 bytes .../editing/selection/drag-in-iframe-expected.png | Bin 5348 -> 0 bytes .../editing/selection/drag-in-iframe-expected.png | Bin 5244 -> 0 bytes 12 files changed, 58 insertions(+), 21 deletions(-) commit ae159fee22102b3571331e8db56c2b53d1f86b6d Author: Takashi Sakamoto <tasak@google.com> Date: Fri Apr 5 05:42:58 2019 +0000 Revert "Reland "Reland "Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient.""" This reverts commit f562370074d92739b58fafb9ffd2c7b6630ba2da. Reason for revert: this patch causes net_unittests failure on linux-chromeos-dbg. https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/11696 NetworkChangeNotifierPosixTest.OnIPAddressChanged NetworkChangeNotifierPosixTest.OnMaxBandwidthChanged E.g. [ RUN ] NetworkChangeNotifierPosixTest.OnIPAddressChanged Received signal 11 <unknown> 000000000000 #5 0x7f623369421e net::NetworkChangeNotifierPosix::CreateDnsConfigService() #6 0x7f623369501d base::internal::FunctorTraits<>::Invoke<>() #7 0x7f6233694f31 base::internal::InvokeHelper<>::MakeItSo<>() #8 0x7f6233694eb7 _ZN4base8internal7InvokerINS0_9BindStateIMN3net26NetworkChangeNotifierPosixEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE Original change's description: > Reland "Reland "Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient."" > > This is a reland of 5db69e59c9c38230e5b2223de0de0e42998a5763 with a flaky test fixed. > > The original version of this CL added a unit test that recently started > flaking due to crrev.com/c/1538608. That CL made it so the > DnsConfigService was created on the UI thread, but would run and be torn > down on its own SequencedTaskRunner. However, there are a couple > SerialWorkers owned by the DnsConfigService that make sure they're > destroyed on the same sequence they're created on, which isn't the > correct sequence anymore. This CL makes the DnsConfigService be > created on its SequencedTaskRunner so that when it gets destroyed, > everything will happen on the correct sequence. See crrev.com/c/1336066 > for related information. > > Original change's description: > > Reland "Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient." > > > > This is a reland of d0310b0c0221e3f44da813443ca11c9869620cb4 > > > > Original change's description: > > > Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient. > > > > > > Bug: 942782 > > > Change-Id: Ia2971348153d54cd87a48e8045efc9d31948db8a > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529354 > > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#641801} > > > > Bug: 942782 > > Change-Id: Ie2331fe506b7b8839d9ae998bb3fd338747e0b24 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529664 > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#642597} > > Bug: 942782 > Change-Id: I72aec3991a421ee29dddf05334eb87e3b972484a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548355 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647991} TBR=stevenjb@chromium.org,pauljensen@chromium.org,rmcelrath@chromium.org Change-Id: I6a2e19aa141162d952193d9b4d2bdb53da3fc793 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 942782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553046 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#648081} .../chromeos/network_change_manager_client.cc | 5 ++- .../chromeos/network_change_manager_client.h | 2 -- .../network_change_manager_client_unittest.cc | 38 ---------------------- net/base/network_change_notifier.cc | 2 +- net/base/network_change_notifier_posix.cc | 21 +++++------- net/base/network_change_notifier_posix.h | 12 +++---- 6 files changed, 17 insertions(+), 63 deletions(-) commit 6ce865dc25bdcec8a13471c4368958a3f690755b Author: Takuto Ikuta <tikuta@chromium.org> Date: Fri Apr 5 05:37:55 2019 +0000 [mb] change mb_config for debug bot doing local build Changed mb_config doing first build without goma, but doing second build with goma. This is used to verify artifact from goma is the same with from local build. This config will be used for recipe changed in https://chromium-review.googlesource.com/c/chromium/tools/build/+/1545145 Also changed to use 32 core bot for the builder. Plan: 1. Change the bot to use 32 core cpu: https://chrome-internal-review.googlesource.com/c/infradata/config/+/1125041 2. Pause builder. 3. Merge this CL and recipe change 4. Un-pause builder. 5. (optional) if there are yet another binary differences, update whitelist. Bug: 947903 Change-Id: I6e6038c23a3988d79d2469018cb62c0f5dc15392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547486 Reviewed-by: smut <smut@google.com> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#648080} infra/config/cr-buildbucket.cfg | 5 +++++ tools/mb/mb_config.pyl | 13 ++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) commit 09102147c7868f3f7840b792025d6ede8089dea7 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 05:35:25 2019 +0000 Update V8 to version 7.5.198. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e73a792c..c6983f48 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic385c158b7d3975064e2fb9e15d563c6c33f89f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554425 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648079} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 767fe5a548a1503d2dfd57290446d0e66a74a49b Author: Morten Stenshorne <mstensho@chromium.org> Date: Fri Apr 5 05:32:55 2019 +0000 Document::View() may return nullptr. This crash was introduced by https://chromium-review.googlesource.com/c/chromium/src/+/1497755 which effectively changed from checking for nullptr to not doing it. Bug: 948889 Change-Id: Ie3b2d434a130a165e8f19a4cc1cd818da803ca2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552826 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#648078} .../blink/renderer/core/html/html_plugin_element.cc | 3 ++- third_party/blink/renderer/core/testing/internals.cc | 3 ++- .../move-own-container-into-child-iframe-crash.html | 15 +++++++++++++++ 3 files changed, 19 insertions(+), 2 deletions(-) commit 40da44663947df7efe3c63f39a066ef765dc84b8 Author: Takashi Sakamoto <tasak@google.com> Date: Fri Apr 5 05:30:26 2019 +0000 Revert "Make AverageLag calculation keeps track of accumulated delta" This reverts commit ffb9f231a67d7fb6b18144acb6356f50cb56ab35. Reason for revert: this patch causes the following failures on Linux ChromiumOS MSan Tests. e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests non_single_process_mash_content_unittests, viz_content_unittests, non_single_process_mash_content_browsertests, content_browsertests, content_unittests content_unittests: RenderWidgetHostLatencyTrackerTest.TestTouchToScrollHistograms [ RUN ] RenderWidgetHostLatencyTrackerTest.TestTouchToScrollHistograms ==21893==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x558c7b1b0740 in ui::AverageLagTracker::LagBetween(base::TimeTicks, base::TimeTicks, ui::LatencyInfo const&, base::TimeTicks) ./../../ui/latency/average_lag_tracker.cc:120:7 #1 0x558c7b1ae316 in ui::AverageLagTracker::AddLatencyInFrame(ui::LatencyInfo const&, base::TimeTicks, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../ui/latency/average_lag_tracker.cc:87:11 #2 0x558c7b1d325a in ui::LatencyTracker::ComputeEndToEndLatencyHistograms(base::TimeTicks, base::TimeTicks, ui::LatencyInfo const&) ./../../ui/latency/latency_tracker.cc:263:26 #3 0x558c7b1d111a in ui::LatencyTracker::OnGpuSwapBuffersCompleted(ui::LatencyInfo const&) ./../../ui/latency/latency_tracker.cc:113:5 #4 0x558c75f1435f in content::RenderWidgetHostLatencyTrackerTest_TestTouchToScrollHistograms_Test::TestBody() ./../../content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc:633:22 Original change's description: > Make AverageLag calculation keeps track of accumulated delta > > Previous we calculate the Lag area per events and seperate into two reports > by the 1 second gap. However that design does not work well with scroll > prediction. > > This CL changes following: > 1. Rewrites the AverageLag calculation to compute the area between the > accumulated_event_delta_(actual finger absolute scroll position) and the > rendered_accumulated_delta_ (rendered absolute scroll position). > Detail see the explainer doc: > https://docs.google.com/document/d/1e8NuzPblIv2B9bz01oSj40rmlse7_PHq5oFS3lqz6N4/ > > 2. Wrap the AverageLag into a AverageLagTracker class, so fields only for > AverageLag wouldn't be access by other part of LatencyTracker. And also > add unit tests. > 3. Because the latency_info.scroll_update_delta is initialize at browser, > where the event delta is in DIP coordinate space. All events are scale to > physical pixel when route to renderer, so we also need to scale the > latency_info together with the events. > > Bug: 946212 > Change-Id: Iec2b3fdbd866efe71fe6e0066cee831e30316261 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542222 > Commit-Queue: Ella Ge <eirage@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647989} TBR=tdresser@chromium.org,nzolghadr@chromium.org,eirage@chromium.org Change-Id: Id4b581628937ccd697f74713402c3a55201eed13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554206 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#648077} .../renderer_host/input/input_router_impl.cc | 22 +- .../render_widget_host_latency_tracker_unittest.cc | 111 +++++++++ ui/latency/BUILD.gn | 3 - ui/latency/average_lag_tracker.cc | 159 ------------- ui/latency/average_lag_tracker.h | 78 ------- ui/latency/average_lag_tracker_unittest.cc | 248 --------------------- ui/latency/latency_tracker.cc | 130 ++++++++++- ui/latency/latency_tracker.h | 38 +++- 8 files changed, 281 insertions(+), 508 deletions(-) commit a974eb612100cd7afcb57efaf78af7be9e38b5f4 Author: Takashi Sakamoto <tasak@google.com> Date: Fri Apr 5 05:21:56 2019 +0000 Revert "[Extensions] Refactor appOrExtension calls for icon alt text" This reverts commit ce9bb17e6fc003a40baba8ce0af644064dcfa2aa. Reason for revert: this patch causes the following tests' failures on mulitple-builers. e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/10570 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/57711 ... browser_tests and webui_polymer1_browser_tests: CrExtensionsShortcutTest.IsValidKeyCode CrExtensionsShortcutTest.KeyStrokeToString CrExtensionsShortcutTest.Layout CrExtensionsShortcutTest.ScopeChange Original change's description: > [Extensions] Refactor appOrExtension calls for icon alt text > > This refactor makes appOrExtension calls for icon alt text less verbose > by factoring away the loadTimeData strings for appIcon and extensionIcon > into appOrExtensionIconLabel > > Change-Id: I1c6c8a71a1ba8abb8d6072c63e199cd1c05178e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497309 > Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647837} TBR=rdevlin.cronin@chromium.org,dpapad@chromium.org,kelvinjiang@chromium.org Change-Id: Ib323aea82fdb069f837906b012ff40f2bdf82646 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554463 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#648076} .../resources/md_extensions/activity_log/activity_log.html | 5 ++++- chrome/browser/resources/md_extensions/detail_view.html | 5 ++++- chrome/browser/resources/md_extensions/item.html | 5 ++++- chrome/browser/resources/md_extensions/item_behavior.html | 2 -- chrome/browser/resources/md_extensions/item_behavior.js | 10 ---------- chrome/browser/resources/md_extensions/keyboard_shortcuts.html | 5 ++++- chrome/browser/resources/md_extensions/kiosk_dialog.html | 5 ++++- chrome/browser/resources/md_extensions/options_dialog.html | 5 ++++- 8 files changed, 24 insertions(+), 18 deletions(-) commit b8e609b22802532afe6289d880de58de0f459eca Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Apr 5 05:20:47 2019 +0000 IDL parser: Actually disable defaulted_states for compatibility This is a follow-up of https://crrev.com/c/1550377. Since blink uses a subclass of IDLParser (BlinkIDLParser) which creates its own yaccobj, we have to disable defaulted_states in BlinkIDLParser too. Bug: 949670 Change-Id: If556b7ce42a72fac7e67c18f051cf3ae838cd547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553267 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#648075} third_party/blink/renderer/bindings/scripts/blink_idl_parser.py | 2 ++ 1 file changed, 2 insertions(+) commit 80c0dc6863d4d8bff1b085883eb219a5409d8484 Author: Austin Eng <enga@chromium.org> Date: Fri Apr 5 05:20:44 2019 +0000 Add configs for Linux and Windows Dawn DEPS trybots Bug: chromium:948902 Change-Id: I74af889f4efc290eec3ca6aa3728c45d6a7317b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554186 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648074} tools/mb/mb_config.pyl | 3 +++ 1 file changed, 3 insertions(+) commit d68ad2e75b721fcbac672497f3fc7c3e374e16ca Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Apr 5 05:17:44 2019 +0000 (Reland) PlzSharedWorker: Send cookies for shared worker script fetch This is a reland CL of https://chromium-review.googlesource.com/c/chromium/src/+/1481286 ... that was reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1538198 The difference from the original CL is to wait until CaptureHeaderHandler() calls before checking the |headers_map_| in TestWorkerScriptFetchWithThirdPartyCookieBlocking(). The original CL does not wait for it, checks the non-updated header map, and fails. <Original CL description> This CL makes sure to send cookies for shared worker script fetch when PlzSharedWorker (NetworkService) is enabled. Before this CL, HTTP requests for shared worker scripts don't contain cookies when third-party cookie blocking is enabled. This is wrong because worker script fetch is always same-origin, and the cookies should be sent with the HTTP requests regardless of the configuration of third-party cookie blocking. Bug: 933287 Change-Id: Id43fa5c5e43008ac9b8ebe2c60b27c044b8b21ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547487 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648073} chrome/browser/OWNERS | 2 + chrome/browser/chrome_worker_browsertest.cc | 137 +++++++++++++++++++++ chrome/test/BUILD.gn | 1 + .../worker_host/worker_script_fetch_initiator.cc | 1 + 4 files changed, 141 insertions(+) commit 355dcee9a27888560be68fcfb1ef28bb0c693bfb Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 05:07:44 2019 +0000 Roll src/third_party/glslang/src 3416d48b594a..e06c7e9a515b (1 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/3416d48b594a..e06c7e9a515b git log 3416d48b594a..e06c7e9a515b --date=short --no-merges --format='%ad %ae %s' 2019-04-05 johnkslang@users.noreply.github.com Merge pull request #1750 from greg-lunarg/kg103 Created with: gclient setdep -r src/third_party/glslang/src@e06c7e9a515b The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7acae3a47ca6dda008aadc0a627994e2e4e7285e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553866 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648072} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 515436e2468db5e27882b7c3bb73a929146c638f Author: Khushal <khushalsagar@chromium.org> Date: Fri Apr 5 05:03:51 2019 +0000 cc: Clamp picture shader tile rects to max texture size. Using an image shader with a tile size > max texture size is not supported by skia. To avoid this, clamp the tile rect for these shaders to max texture size. This is consistent with the behaviour internally in skia (see SkPictureShader::refBitmapShader). R=enne@chromium.org Bug: 948052 Change-Id: I45250d6498a66ee81091b7eb4a70afa9c887226e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552291 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by: enne <enne@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#648071} cc/paint/oop_pixeltest.cc | 36 ++++++++++++++++++++++++++++ cc/paint/paint_filter.cc | 2 +- cc/paint/paint_op_buffer.cc | 4 +++- cc/paint/paint_op_buffer_serializer.cc | 11 +++++++-- cc/paint/paint_op_writer.cc | 6 +++-- cc/paint/paint_shader.cc | 16 +++++++++++++ cc/paint/paint_shader.h | 1 + cc/paint/scoped_raster_flags.cc | 10 ++++---- cc/paint/scoped_raster_flags.h | 3 ++- cc/paint/scoped_raster_flags_unittest.cc | 6 ++--- cc/paint/skia_paint_canvas.cc | 40 ++++++++++++++++++-------------- cc/paint/skia_paint_canvas.h | 6 +++++ cc/paint/skia_paint_canvas_unittest.cc | 15 ++---------- cc/test/test_skcanvas.cc | 4 +++- cc/test/test_skcanvas.h | 6 ++++- 15 files changed, 120 insertions(+), 46 deletions(-) commit 2fb30e36dbeddf65aa1529e337ebba0cbd36b47c Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Apr 5 04:57:04 2019 +0000 Add use counters for ReadableStream methods Add use counters for getReader, pipeThrough and pipeTo. Bug: 828034 Change-Id: I268373d8ac518919bd74f400e8ec3aea91a11690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554205 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#648070} third_party/blink/public/mojom/web_feature/web_feature.mojom | 3 +++ third_party/blink/renderer/core/streams/readable_stream.idl | 6 +++--- tools/metrics/histograms/enums.xml | 3 +++ 3 files changed, 9 insertions(+), 3 deletions(-) commit 0d92ed324e681684d67411e241849c11ddecd7b2 Author: Alan Cutter <alancutter@chromium.org> Date: Fri Apr 5 04:51:19 2019 +0000 Clean up unused AnimatableValue interpolation code The last use of GetInterpolatedCompositorValue() was removed by: https://chromium-review.googlesource.com/c/chromium/src/+/1133125/ This means we can remove AnimatableValue::InterpolateTo and associated functions. Change-Id: I761646194a30354c612f10e9389d793b74ae11a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553122 Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#648069} third_party/blink/renderer/core/animation/BUILD.gn | 4 -- .../core/animation/animatable/animatable_double.cc | 44 ------------- .../core/animation/animatable/animatable_double.h | 4 -- .../animatable/animatable_filter_operations.cc | 72 ---------------------- .../animatable/animatable_filter_operations.h | 9 ++- .../animation/animatable/animatable_transform.cc | 46 -------------- .../animation/animatable/animatable_transform.h | 4 -- .../core/animation/animatable/animatable_value.cc | 50 --------------- .../core/animation/animatable/animatable_value.h | 22 ------- .../core/animation/transition_interpolation.cc | 6 -- .../core/animation/transition_interpolation.h | 2 - 11 files changed, 4 insertions(+), 259 deletions(-) commit 8749ef79bdf4690edd1434de537f376e2c8e7070 Author: David Bokan <bokan@chromium.org> Date: Fri Apr 5 04:45:09 2019 +0000 Reland [BGPT] Remove no-op compositing scroll offset updates [Reland Note] Base patchset has original change. Fixed test to make sure refrence composites like the test to avoid pixel differences. The linked bug is caused by the compositing pipeline in Blink failing to see that a scroll offset needs to be pushed to CC. The sequence of events is: - Scroller starts at offset 0 - User scrolls on compositor to |y| - Commit pushes |y| to the scroller on the main thread - Main thread executes JS scroll handler which resets offset to 0 - Compositing update compares the current offset with the last sent to CC and notes they're both 0. No other changes have occured so we avoid pushing 0 to CC. CC remains at |y|. This is fixed in BGPT because the scroll offset is reflected back to the cc::Layer in PaintLayerScrollableArea::UpdateScrollOffset, it doesn't have to rely on a ScrollingCoordinator update being called during a compositing update. This CL explicitly removes the scroll update step in ScrollingCoordinator::ScrollableAreaScrollLayerDidChange when BGPT is enabled. The scroll offset is now pushed to cc::Layer in three places: -PaintLayerScrollableArea::UpdateCompositingLayersAfterScroll: Called whenever the scroll offset in Blink changes, including receiving updates from CC. -CompositedLayerMapping::UpdateScrollingLayers Called when a cc::Layer is first created for a scrollable area. This covers the case where a scroller becomes composited already having some scroll offset. This was missing test coverage so added one. -CompositedLayerMapping::UpdateScrollingLayerGeometry Called when the scroll origin changes from the last time we performed an update. Since cc::Layers use scroll position, a change in scroll origin will change the scroll position without any change to the PLSA's scroll offset. This is preferable to tracking the offset sent to CC because changes can occur on both threads simultaneously, making edge cases like this one common. Tracking sent scroll origin is safe because it cannot change from the compositor thread. TBR=chrishtr@chromium.org,pdr@chromium.org Bug: 930636 Change-Id: I380b57eaf627dc765c1b6e1f406b1421fe8628c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554423 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#648068} .../blink/renderer/core/frame/visual_viewport.cc | 10 ++- .../core/page/scrolling/scrolling_coordinator.cc | 14 +++- .../core/page/scrolling/scrolling_coordinator.h | 5 +- .../page/scrolling/scrolling_coordinator_test.cc | 48 +++++++++++++ .../paint/compositing/composited_layer_mapping.cc | 15 ++--- .../paint/compositing/composited_layer_mapping.h | 1 + .../enable-blink-features=CompositeAfterPaint | 3 + .../reset-scroll-in-onscroll-expected.html | 34 ++++++++++ .../fast/scrolling/reset-scroll-in-onscroll.html | 64 ++++++++++++++++++ .../fast/scrolling/scroll-then-composite.html | 78 ++++++++++++++++++++++ ...isual-viewport-scrolled-from-main-expected.html | 9 +++ .../visual-viewport-scrolled-from-main.html | 31 +++++++++ 12 files changed, 295 insertions(+), 17 deletions(-) commit e0e7c94aa707bb04455a24c30f031fbf761ca6f5 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Apr 5 04:36:19 2019 +0000 Apply testharness.js to some of non-pixel web tests from dom/domparsing This CL removes js-test.js and applies testharness.js from some test files in dom/domparsing. The changed test files are listed up below. The rest of files in dom/domparsing will be handled in a follow-up CL. third_party/blink/web_tests/dom/domparsing/dom-parse-serialize-display.html third_party/blink/web_tests/dom/domparsing/dom-parse-serialize-xmldecl.html third_party/blink/web_tests/dom/domparsing/dom-parse-serialize.html third_party/blink/web_tests/dom/domparsing/domparser-assign-variable.html third_party/blink/web_tests/dom/domparsing/domparser-parsefromstring-mimetype-support.html third_party/blink/web_tests/dom/domparsing/namespaces-1.html third_party/blink/web_tests/dom/domparsing/serialize-cdata.html third_party/blink/web_tests/dom/domparsing/xhtml-serialize.html Bug: 936364 Change-Id: I3a2d7c074dab2cfaa7aac5ffd93606e814441fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553120 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#648067} .../dom-parse-serialize-display-expected.txt | 24 --------- .../domparsing/dom-parse-serialize-display.html | 53 ++++++------------ .../domparsing/dom-parse-serialize-expected.txt | 23 -------- .../dom-parse-serialize-xmldecl-expected.txt | 14 ----- .../domparsing/dom-parse-serialize-xmldecl.html | 19 +++---- .../dom/domparsing/dom-parse-serialize.html | 35 +++--------- .../domparser-assign-variable-expected.txt | 1 - .../dom/domparsing/domparser-assign-variable.html | 20 +++---- ...r-parsefromstring-mimetype-support-expected.txt | 49 ----------------- ...domparser-parsefromstring-mimetype-support.html | 62 +++------------------- .../dom/domparsing/namespaces-1-expected.txt | 19 ------- .../web_tests/dom/domparsing/namespaces-1.html | 38 ++++--------- .../dom/domparsing/serialize-cdata-expected.txt | 5 -- .../web_tests/dom/domparsing/serialize-cdata.html | 16 +++--- .../dom/domparsing/xhtml-serialize-expected.txt | 7 --- .../web_tests/dom/domparsing/xhtml-serialize.html | 35 +++--------- 16 files changed, 70 insertions(+), 350 deletions(-) commit e755af789a4216fa9a230967c2c4ca3a9a0dd9f6 Author: Robert Liao <robliao@chromium.org> Date: Fri Apr 5 04:35:59 2019 +0000 Subset of Clang-Tidy for //ui/views on Linux This is a run of clang-tidy with the existing .clang-tidy config on //ui/views without modernize-use-default-member-init and readability-redundant-member-init. BUG=940732 TBR=sky@chromium.org,thomasanderson@chromium.org Change-Id: I8a7f2566c963eb2ef10bcaac331b00756de5b6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554242 Reviewed-by: Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#648066} .../controls/textfield/textfield_model_unittest.cc | 28 +++---- ui/views/controls/textfield/textfield_unittest.cc | 6 +- ui/views/linux_ui/linux_ui.cc | 2 +- ui/views/linux_ui/status_icon_linux.cc | 9 +-- ui/views/linux_ui/window_button_order_provider.cc | 5 +- ui/views/test/test_desktop_screen_x11.cc | 8 +- .../test/ui_controls_factory_desktop_aurax11.cc | 25 +++--- ui/views/test/x11_property_change_waiter.cc | 6 +- .../desktop_drag_drop_client_aurax11.cc | 55 +++++++------ .../desktop_drag_drop_client_aurax11_unittest.cc | 36 ++++----- ui/views/widget/desktop_aura/desktop_screen_x11.cc | 2 +- .../desktop_aura/desktop_screen_x11_unittest.cc | 90 ++++++++-------------- .../desktop_aura/desktop_window_tree_host_x11.cc | 32 ++++---- ...ktop_window_tree_host_x11_interactive_uitest.cc | 13 ++-- .../desktop_window_tree_host_x11_unittest.cc | 30 ++++---- .../widget/desktop_aura/window_event_filter.cc | 2 +- .../widget/desktop_aura/x11_desktop_handler.cc | 10 ++- .../desktop_aura/x11_desktop_window_move_client.cc | 8 +- .../desktop_aura/x11_topmost_window_finder.cc | 5 +- ...x11_topmost_window_finder_interactive_uitest.cc | 9 +-- .../desktop_aura/x11_whole_screen_move_loop.cc | 10 ++- .../widget/desktop_aura/x11_window_event_filter.cc | 3 +- ui/views/window/dialog_delegate.cc | 2 +- 23 files changed, 181 insertions(+), 215 deletions(-) commit 26ff31415e37286e40e65378aaf26d3bd2f8993a Author: Lei Zhang <thestig@chromium.org> Date: Fri Apr 5 04:30:19 2019 +0000 Add a dummy printing::MetaFileSkia to CapturePixelsForPrinting(). The printing code in content::RenderFrameProxy::Print() expects there to be one. Provide one just like in non-test uses. This fixes a crash in layout tests, so update the expectations. BUG=932916,949003 Change-Id: I135421ec9a667392f7be4f8b88f2cacf2b55e415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549756 Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#648065} content/shell/test_runner/BUILD.gn | 1 + content/shell/test_runner/DEPS | 4 ++++ content/shell/test_runner/pixel_dump.cc | 13 +++++++++---- third_party/blink/web_tests/TestExpectations | 4 ++-- 4 files changed, 16 insertions(+), 6 deletions(-) commit d190cc2a75a60bd6fa64bfbf6a375a228acf9c92 Author: Christopher Lam <calamity@chromium.org> Date: Fri Apr 5 04:28:25 2019 +0000 [OneShotEvent] Fix comment typo. TBR=danakj@chromium.org Bug: None Change-Id: I67dc582ea49ec7756d8c01547f9260b685b5d8ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553265 Reviewed-by: calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#648064} base/one_shot_event.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6ca6ae0b0a3f7b44934d9df963886f5f13858d94 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Apr 5 04:26:49 2019 +0000 Add autotestPrivate.showVirtualKeyboardIfEnabled This will be used by a Tast testcase to open ARC IME. Tast side WIP CL is here: https://crrev.com/c/1545141 TEST=tast run eve-DUT arc.AndroidIMEInBrowser BUG=b:120575505 Change-Id: I58e50c6f3b214a7f33f22500b05c6cf8a2dce68e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551731 Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Darren Shen <shend@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#648063} .../autotest_private/autotest_private_api.cc | 25 ++++++++++++++++++++++ .../autotest_private/autotest_private_api.h | 12 +++++++++++ chrome/common/extensions/api/autotest_private.idl | 3 +++ .../browser/extension_function_histogram_value.h | 1 + tools/metrics/histograms/enums.xml | 1 + 5 files changed, 42 insertions(+) commit deba90268a4cd58524876f6123e67ed8d6fe1eb7 Author: Mingyun Li <mekiali@chromium.org> Date: Fri Apr 5 04:19:47 2019 +0000 Add SpecialUserProvider which provides special user related functionality. BUG=944726 Change-Id: Ib50e8dc8c817d8f71afe8585bd31e0b1e4b6d1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548887 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Mingyun Li <mekiali@chromium.org> Cr-Commit-Position: refs/heads/master@{#648062} ios/chrome/app/BUILD.gn | 1 + ios/chrome/browser/prefs/BUILD.gn | 1 + ios/chrome/browser/prefs/browser_prefs.mm | 3 +++ ios/chrome/browser/providers/BUILD.gn | 1 + ios/public/provider/chrome/browser/BUILD.gn | 1 + .../chrome/browser/chrome_browser_provider.h | 4 +++ .../chrome/browser/chrome_browser_provider.mm | 4 +++ .../chrome/browser/test_chrome_browser_provider.h | 2 ++ .../chrome/browser/test_chrome_browser_provider.mm | 6 +++++ ios/public/provider/chrome/browser/user/BUILD.gn | 29 ++++++++++++++++++++++ .../chrome/browser/user/special_user_prefs.h | 15 +++++++++++ .../chrome/browser/user/special_user_prefs.mm | 18 ++++++++++++++ .../chrome/browser/user/special_user_provider.h | 25 +++++++++++++++++++ .../chrome/browser/user/special_user_provider.mm | 17 +++++++++++++ .../browser/user/test_special_user_provider.h | 21 ++++++++++++++++ .../browser/user/test_special_user_provider.mm | 13 ++++++++++ 16 files changed, 161 insertions(+) commit 0aebed37752779dffbda58f36f0d4b406512b78b Author: Matt Falkenhagen <falken@chromium.org> Date: Fri Apr 5 04:12:07 2019 +0000 service worker: Don't create script loader bundle for installed workers. This is an optimization. Installed workers never request scripts from network (if they try, network error is returned by ServiceWorkerScriptLoaderFactory), so the bundle doesn't need to be created for them. This doesn't teach DevTools code to skip the bundle for installed service workers, since that case doesn't need to be optimized. As a result, ServiceWorkerDevToolsAgentHost::UpdateLoaderFactories will still make the bundle for installed workers. Bug: 948503 Change-Id: I90c2ad9eee27a4b6892605a79ec7309bacbe45d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547721 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#648061} .../service_worker/embedded_worker_instance.cc | 56 ++++++++++++---------- .../service_worker_script_loader_factory.cc | 16 ++++--- .../service_worker_script_loader_factory.h | 17 +++++-- 3 files changed, 55 insertions(+), 34 deletions(-) commit 71f7de5e45116d10d71bba15e4b5f398760a8c41 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri Apr 5 04:07:08 2019 +0000 Move existing logs to FIDO in device-log Adds a log to note which caBLE UUID was found, as well as a few other helpful caBLE/BLE logs. Bug: 939384 Change-Id: I988e063ddb98f085fee38db0abe9c00dd542490a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554182 Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Auto-Submit: Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#648060} device/fido/ble/fido_ble_connection.cc | 86 +++++++++++++---------- device/fido/ble/fido_ble_device.cc | 2 + device/fido/ble/fido_ble_discovery_base.cc | 11 +-- device/fido/ble/fido_ble_transaction.cc | 24 ++++--- device/fido/cable/fido_cable_device.cc | 5 +- device/fido/cable/fido_cable_discovery.cc | 31 ++++---- device/fido/cable/fido_cable_handshake_handler.cc | 3 +- device/fido/device_response_converter.cc | 3 +- device/fido/fido_device.cc | 8 ++- 9 files changed, 97 insertions(+), 76 deletions(-) commit a5822210bb793c9135816d1b05ac955c7057b428 Author: Eric Willigers <ericwilligers@chromium.org> Date: Fri Apr 5 03:59:33 2019 +0000 Web Share: Enable Level 2 on Android Intent to Ship is posted: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Cr7Jrb9XMgE/lja4PhCtBgAJ Bug: 903010 Change-Id: I4d81104def5af7dd3b5bbce38bde022aac34f617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551730 Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#648059} chrome/renderer/chrome_content_renderer_client.cc | 1 + third_party/blink/public/platform/web_runtime_features.h | 1 + third_party/blink/renderer/platform/exported/web_runtime_features.cc | 4 ++++ 3 files changed, 6 insertions(+) commit 3e2882be2ddeaaad85c29469d785f08a90a25e8e Author: Jeevan Shikaram <jshikaram@chromium.org> Date: Fri Apr 5 03:53:24 2019 +0000 [App Management] Permissions which aren't requested by ARC apps aren't rendered. Permissions that are not requested in an Android's app manifest are not rendered in the App Management page. Bug: 942405, 906508 Change-Id: I52f314a5d503f5322410644b8e26a02d465bbb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551722 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#648058} .../app_management/arc_permission_view.html | 3 +- .../resources/app_management/fake_page_handler.js | 5 +- .../resources/app_management/permission_item.html | 24 ++++++---- .../resources/app_management/permission_item.js | 27 +++++++++++ .../app_management/app_management_browsertest.js | 14 ++++++ .../app_management/arc_permission_view_test.js | 55 ++++++++++++++++++++++ 6 files changed, 116 insertions(+), 12 deletions(-) commit 3a7ba9761092c197ba6b09f2050498471b19712f Author: Meredith Lane <meredithl@chromium.org> Date: Fri Apr 5 03:37:17 2019 +0000 Adds test image for css alt text Previous commit contained references to an image that didn't actually exist. This adds a small test image and updates the references. BUG=860016 Change-Id: I2e6db786e74ffe5c510ce2c98932bc12f356d2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552389 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#648057} third_party/blink/web_tests/accessibility/bullet.png | Bin 0 -> 547 bytes .../blink/web_tests/accessibility/css-alt-text.html | 10 +++++----- 2 files changed, 5 insertions(+), 5 deletions(-) commit 0abe7eeed2661c460a6f05e6af0485dc2dc335c0 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Apr 5 03:35:57 2019 +0000 Download infobars : Disabled animations for power saver mode Bug: 940376 Change-Id: I703a336d1cdcd5dcbbe57588131b8c829e25950b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554243 Reviewed-by: Xing Liu <xingliu@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#648056} .../chrome/browser/download/DownloadInfoBarController.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit a4ecf464fc3d0176bee74be65f5fe9dd00b1b156 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Fri Apr 5 03:30:39 2019 +0000 Android: Enable overscroll navigation in explore site page Explore site page layout now gets HistoryNavigationLayout which gives overscroll history navigation UI. Bug: 865567 Change-Id: I410109ef4d20da9293ec226129c0864688de3c6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554200 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#648055} .../java/res/layout/explore_sites_page_layout.xml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) commit 4325e1e31cb950f9ae4c5c8fbaa7b031ad4ab530 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 03:29:06 2019 +0000 Update V8 to version 7.5.196. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2f88b9b2..e73a792c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib873ffb794cdc5e01c985897769ae72fbbad307d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553667 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648054} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e62cb31077793733c591db5e381ba5eca7e893ee Author: chrome-release-bot <chrome-release-bot@chromium.org> Date: Fri Apr 5 03:15:13 2019 +0000 Updating trunk VERSION from 3757.0 to 3758.0 # This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: Id2eea8d6ebe1942ba6acdd286c282a1276338768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554252 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#648053} chrome/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 50233933d5b714f5200b35c6bf15a3ef2f03715c Author: Krishna Govind <govind@chromium.org> Date: Fri Apr 5 03:08:58 2019 +0000 Updating XTBs based on .GRDs from branch master TBR=meacer@chromium.org Change-Id: I71df0a914e083ad8762760a81ddebfcb11f7d49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553318 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#648052} .../strings/ash_components_strings_de.xtb | 2 +- ash/strings/ash_strings_am.xtb | 1 - ash/strings/ash_strings_ar.xtb | 1 - ash/strings/ash_strings_bg.xtb | 1 - ash/strings/ash_strings_bn.xtb | 3 +- ash/strings/ash_strings_ca.xtb | 1 - ash/strings/ash_strings_cs.xtb | 1 - ash/strings/ash_strings_da.xtb | 1 - ash/strings/ash_strings_de.xtb | 7 +- ash/strings/ash_strings_el.xtb | 9 +- ash/strings/ash_strings_en-GB.xtb | 9 +- ash/strings/ash_strings_es-419.xtb | 3 +- ash/strings/ash_strings_es.xtb | 1 - ash/strings/ash_strings_et.xtb | 1 - ash/strings/ash_strings_fa.xtb | 1 - ash/strings/ash_strings_fi.xtb | 1 - ash/strings/ash_strings_fil.xtb | 1 - ash/strings/ash_strings_fr.xtb | 1 - ash/strings/ash_strings_gu.xtb | 1 - ash/strings/ash_strings_hi.xtb | 1 - ash/strings/ash_strings_hr.xtb | 1 - ash/strings/ash_strings_hu.xtb | 1 - ash/strings/ash_strings_id.xtb | 1 - ash/strings/ash_strings_it.xtb | 1 - ash/strings/ash_strings_iw.xtb | 1 - ash/strings/ash_strings_ja.xtb | 11 +- ash/strings/ash_strings_kn.xtb | 1 - ash/strings/ash_strings_ko.xtb | 1 - ash/strings/ash_strings_lt.xtb | 1 - ash/strings/ash_strings_lv.xtb | 1 - ash/strings/ash_strings_ml.xtb | 1 - ash/strings/ash_strings_mr.xtb | 1 - ash/strings/ash_strings_ms.xtb | 1 - ash/strings/ash_strings_nl.xtb | 1 - ash/strings/ash_strings_no.xtb | 1 - ash/strings/ash_strings_pl.xtb | 3 +- ash/strings/ash_strings_pt-BR.xtb | 1 - ash/strings/ash_strings_pt-PT.xtb | 1 - ash/strings/ash_strings_ro.xtb | 1 - ash/strings/ash_strings_ru.xtb | 1 - ash/strings/ash_strings_sk.xtb | 1 - ash/strings/ash_strings_sl.xtb | 1 - ash/strings/ash_strings_sr.xtb | 1 - ash/strings/ash_strings_sv.xtb | 1 - ash/strings/ash_strings_sw.xtb | 1 - ash/strings/ash_strings_ta.xtb | 1 - ash/strings/ash_strings_te.xtb | 1 - ash/strings/ash_strings_th.xtb | 1 - ash/strings/ash_strings_tr.xtb | 3 +- ash/strings/ash_strings_uk.xtb | 1 - ash/strings/ash_strings_vi.xtb | 1 - ash/strings/ash_strings_zh-CN.xtb | 3 +- ash/strings/ash_strings_zh-TW.xtb | 1 - ...ndroid_chrome_autofill_assistant_strings_el.xtb | 1 + ...oid_chrome_autofill_assistant_strings_en-GB.xtb | 1 + .../translations/android_chrome_strings_am.xtb | 2 - .../translations/android_chrome_strings_ar.xtb | 4 +- .../translations/android_chrome_strings_bg.xtb | 2 - .../translations/android_chrome_strings_bn.xtb | 2 - .../translations/android_chrome_strings_ca.xtb | 4 +- .../translations/android_chrome_strings_cs.xtb | 2 - .../translations/android_chrome_strings_da.xtb | 2 - .../translations/android_chrome_strings_de.xtb | 2 - .../translations/android_chrome_strings_el.xtb | 11 +- .../translations/android_chrome_strings_en-GB.xtb | 11 +- .../translations/android_chrome_strings_es-419.xtb | 2 - .../translations/android_chrome_strings_es.xtb | 2 - .../translations/android_chrome_strings_et.xtb | 2 - .../translations/android_chrome_strings_fa.xtb | 2 - .../translations/android_chrome_strings_fi.xtb | 3 +- .../translations/android_chrome_strings_fil.xtb | 2 - .../translations/android_chrome_strings_fr.xtb | 2 - .../translations/android_chrome_strings_gu.xtb | 2 - .../translations/android_chrome_strings_hi.xtb | 2 - .../translations/android_chrome_strings_hr.xtb | 2 - .../translations/android_chrome_strings_hu.xtb | 2 - .../translations/android_chrome_strings_id.xtb | 2 - .../translations/android_chrome_strings_it.xtb | 2 - .../translations/android_chrome_strings_iw.xtb | 2 - .../translations/android_chrome_strings_ja.xtb | 4 +- .../translations/android_chrome_strings_kn.xtb | 2 - .../translations/android_chrome_strings_ko.xtb | 2 - .../translations/android_chrome_strings_lt.xtb | 2 - .../translations/android_chrome_strings_lv.xtb | 2 - .../translations/android_chrome_strings_ml.xtb | 3 +- .../translations/android_chrome_strings_mr.xtb | 2 - .../translations/android_chrome_strings_ms.xtb | 2 - .../translations/android_chrome_strings_nl.xtb | 2 - .../translations/android_chrome_strings_no.xtb | 3 +- .../translations/android_chrome_strings_pl.xtb | 2 - .../translations/android_chrome_strings_pt-BR.xtb | 2 - .../translations/android_chrome_strings_pt-PT.xtb | 2 - .../translations/android_chrome_strings_ro.xtb | 2 - .../translations/android_chrome_strings_ru.xtb | 5 +- .../translations/android_chrome_strings_sk.xtb | 2 - .../translations/android_chrome_strings_sl.xtb | 2 - .../translations/android_chrome_strings_sr.xtb | 2 - .../translations/android_chrome_strings_sv.xtb | 2 - .../translations/android_chrome_strings_sw.xtb | 2 - .../translations/android_chrome_strings_ta.xtb | 2 - .../translations/android_chrome_strings_te.xtb | 4 +- .../translations/android_chrome_strings_th.xtb | 2 - .../translations/android_chrome_strings_tr.xtb | 4 +- .../translations/android_chrome_strings_uk.xtb | 3 +- .../translations/android_chrome_strings_vi.xtb | 6 +- .../translations/android_chrome_strings_zh-CN.xtb | 5 +- .../translations/android_chrome_strings_zh-TW.xtb | 2 - chrome/app/resources/chromium_strings_bn.xtb | 2 +- chrome/app/resources/generated_resources_am.xtb | 33 +- chrome/app/resources/generated_resources_ar.xtb | 39 +- chrome/app/resources/generated_resources_bg.xtb | 33 +- chrome/app/resources/generated_resources_bn.xtb | 43 +- chrome/app/resources/generated_resources_ca.xtb | 42 +- chrome/app/resources/generated_resources_cs.xtb | 35 +- chrome/app/resources/generated_resources_da.xtb | 35 +- chrome/app/resources/generated_resources_de.xtb | 47 +- chrome/app/resources/generated_resources_el.xtb | 52 +- chrome/app/resources/generated_resources_en-GB.xtb | 52 +- .../app/resources/generated_resources_es-419.xtb | 33 +- chrome/app/resources/generated_resources_es.xtb | 33 +- chrome/app/resources/generated_resources_et.xtb | 33 +- chrome/app/resources/generated_resources_fa.xtb | 33 +- chrome/app/resources/generated_resources_fi.xtb | 32 +- chrome/app/resources/generated_resources_fil.xtb | 33 +- chrome/app/resources/generated_resources_fr.xtb | 33 +- chrome/app/resources/generated_resources_gu.xtb | 35 +- chrome/app/resources/generated_resources_hi.xtb | 16 +- chrome/app/resources/generated_resources_hr.xtb | 35 +- chrome/app/resources/generated_resources_hu.xtb | 33 +- chrome/app/resources/generated_resources_id.xtb | 43 +- chrome/app/resources/generated_resources_it.xtb | 43 +- chrome/app/resources/generated_resources_iw.xtb | 33 +- chrome/app/resources/generated_resources_ja.xtb | 49 +- chrome/app/resources/generated_resources_kn.xtb | 33 +- chrome/app/resources/generated_resources_ko.xtb | 33 +- chrome/app/resources/generated_resources_lt.xtb | 33 +- chrome/app/resources/generated_resources_lv.xtb | 33 +- chrome/app/resources/generated_resources_ml.xtb | 51 +- chrome/app/resources/generated_resources_mr.xtb | 33 +- chrome/app/resources/generated_resources_ms.xtb | 37 +- chrome/app/resources/generated_resources_nl.xtb | 39 +- chrome/app/resources/generated_resources_no.xtb | 33 +- chrome/app/resources/generated_resources_pl.xtb | 33 +- chrome/app/resources/generated_resources_pt-BR.xtb | 37 +- chrome/app/resources/generated_resources_pt-PT.xtb | 33 +- chrome/app/resources/generated_resources_ro.xtb | 39 +- chrome/app/resources/generated_resources_ru.xtb | 33 +- chrome/app/resources/generated_resources_sk.xtb | 33 +- chrome/app/resources/generated_resources_sl.xtb | 33 +- chrome/app/resources/generated_resources_sr.xtb | 35 +- chrome/app/resources/generated_resources_sv.xtb | 33 +- chrome/app/resources/generated_resources_sw.xtb | 33 +- chrome/app/resources/generated_resources_ta.xtb | 28 +- chrome/app/resources/generated_resources_te.xtb | 39 +- chrome/app/resources/generated_resources_th.xtb | 33 +- chrome/app/resources/generated_resources_tr.xtb | 41 +- chrome/app/resources/generated_resources_uk.xtb | 33 +- chrome/app/resources/generated_resources_vi.xtb | 39 +- chrome/app/resources/generated_resources_zh-CN.xtb | 44 +- chrome/app/resources/generated_resources_zh-TW.xtb | 33 +- chrome/app/resources/google_chrome_strings_bn.xtb | 2 +- .../camera/src/strings/camera_strings_el.xtb | 3 + .../camera/src/strings/camera_strings_en-GB.xtb | 3 + .../chromevox/strings/chromevox_strings_ca.xtb | 4 +- .../chromevox/strings/chromevox_strings_el.xtb | 7 + .../chromevox/strings/chromevox_strings_en-GB.xtb | 7 + .../strings/select_to_speak_strings_ca.xtb | 6 +- .../gaiacp/strings/gaia_resources_am.xtb | 1 - .../gaiacp/strings/gaia_resources_ar.xtb | 1 - .../gaiacp/strings/gaia_resources_bg.xtb | 1 - .../gaiacp/strings/gaia_resources_bn.xtb | 1 - .../gaiacp/strings/gaia_resources_ca.xtb | 11 +- .../gaiacp/strings/gaia_resources_cs.xtb | 1 - .../gaiacp/strings/gaia_resources_da.xtb | 1 - .../gaiacp/strings/gaia_resources_de.xtb | 1 - .../gaiacp/strings/gaia_resources_el.xtb | 4 +- .../gaiacp/strings/gaia_resources_en-GB.xtb | 4 +- .../gaiacp/strings/gaia_resources_es-419.xtb | 1 - .../gaiacp/strings/gaia_resources_es.xtb | 1 - .../gaiacp/strings/gaia_resources_et.xtb | 1 - .../gaiacp/strings/gaia_resources_fa.xtb | 1 - .../gaiacp/strings/gaia_resources_fi.xtb | 1 - .../gaiacp/strings/gaia_resources_fil.xtb | 1 - .../gaiacp/strings/gaia_resources_fr.xtb | 1 - .../gaiacp/strings/gaia_resources_gu.xtb | 1 - .../gaiacp/strings/gaia_resources_hi.xtb | 1 - .../gaiacp/strings/gaia_resources_hr.xtb | 1 - .../gaiacp/strings/gaia_resources_hu.xtb | 1 - .../gaiacp/strings/gaia_resources_id.xtb | 1 - .../gaiacp/strings/gaia_resources_it.xtb | 1 - .../gaiacp/strings/gaia_resources_iw.xtb | 1 - .../gaiacp/strings/gaia_resources_ja.xtb | 1 - .../gaiacp/strings/gaia_resources_kn.xtb | 1 - .../gaiacp/strings/gaia_resources_ko.xtb | 1 - .../gaiacp/strings/gaia_resources_lt.xtb | 1 - .../gaiacp/strings/gaia_resources_lv.xtb | 1 - .../gaiacp/strings/gaia_resources_ml.xtb | 1 - .../gaiacp/strings/gaia_resources_mr.xtb | 1 - .../gaiacp/strings/gaia_resources_ms.xtb | 1 - .../gaiacp/strings/gaia_resources_nl.xtb | 1 - .../gaiacp/strings/gaia_resources_no.xtb | 1 - .../gaiacp/strings/gaia_resources_pl.xtb | 1 - .../gaiacp/strings/gaia_resources_pt-BR.xtb | 1 - .../gaiacp/strings/gaia_resources_pt-PT.xtb | 1 - .../gaiacp/strings/gaia_resources_ro.xtb | 1 - .../gaiacp/strings/gaia_resources_ru.xtb | 1 - .../gaiacp/strings/gaia_resources_sk.xtb | 1 - .../gaiacp/strings/gaia_resources_sl.xtb | 1 - .../gaiacp/strings/gaia_resources_sr.xtb | 1 - .../gaiacp/strings/gaia_resources_sv.xtb | 1 - .../gaiacp/strings/gaia_resources_sw.xtb | 1 - .../gaiacp/strings/gaia_resources_ta.xtb | 1 - .../gaiacp/strings/gaia_resources_te.xtb | 1 - .../gaiacp/strings/gaia_resources_th.xtb | 1 - .../gaiacp/strings/gaia_resources_tr.xtb | 1 - .../gaiacp/strings/gaia_resources_uk.xtb | 1 - .../gaiacp/strings/gaia_resources_vi.xtb | 1 - .../gaiacp/strings/gaia_resources_zh-CN.xtb | 11 +- .../gaiacp/strings/gaia_resources_zh-TW.xtb | 1 - chromeos/strings/chromeos_strings_de.xtb | 2 +- .../policy/resources/policy_templates_am.xtb | 13 + .../policy/resources/policy_templates_ar.xtb | 21 +- .../policy/resources/policy_templates_bg.xtb | 15 +- .../policy/resources/policy_templates_bn.xtb | 21 +- .../policy/resources/policy_templates_ca.xtb | 13 + .../policy/resources/policy_templates_cs.xtb | 15 +- .../policy/resources/policy_templates_da.xtb | 13 + .../policy/resources/policy_templates_de.xtb | 21 +- .../policy/resources/policy_templates_el.xtb | 80 +++ .../policy/resources/policy_templates_en-GB.xtb | 80 +++ .../policy/resources/policy_templates_es-419.xtb | 71 +-- .../policy/resources/policy_templates_es.xtb | 13 + .../policy/resources/policy_templates_et.xtb | 17 +- .../policy/resources/policy_templates_fa.xtb | 13 + .../policy/resources/policy_templates_fi.xtb | 13 + .../policy/resources/policy_templates_fil.xtb | 13 + .../policy/resources/policy_templates_fr.xtb | 13 + .../policy/resources/policy_templates_gu.xtb | 17 +- .../policy/resources/policy_templates_hi.xtb | 197 +++---- .../policy/resources/policy_templates_hr.xtb | 21 +- .../policy/resources/policy_templates_hu.xtb | 13 + .../policy/resources/policy_templates_id.xtb | 17 +- .../policy/resources/policy_templates_it.xtb | 21 +- .../policy/resources/policy_templates_iw.xtb | 13 + .../policy/resources/policy_templates_ja.xtb | 29 +- .../policy/resources/policy_templates_kn.xtb | 13 + .../policy/resources/policy_templates_ko.xtb | 21 +- .../policy/resources/policy_templates_lt.xtb | 13 + .../policy/resources/policy_templates_lv.xtb | 13 + .../policy/resources/policy_templates_ml.xtb | 13 + .../policy/resources/policy_templates_mr.xtb | 13 + .../policy/resources/policy_templates_ms.xtb | 43 +- .../policy/resources/policy_templates_nl.xtb | 13 + .../policy/resources/policy_templates_no.xtb | 13 + .../policy/resources/policy_templates_pl.xtb | 13 + .../policy/resources/policy_templates_pt-BR.xtb | 19 +- .../policy/resources/policy_templates_pt-PT.xtb | 13 + .../policy/resources/policy_templates_ro.xtb | 15 +- .../policy/resources/policy_templates_ru.xtb | 13 + .../policy/resources/policy_templates_sk.xtb | 15 +- .../policy/resources/policy_templates_sl.xtb | 13 + .../policy/resources/policy_templates_sr.xtb | 13 + .../policy/resources/policy_templates_sv.xtb | 13 + .../policy/resources/policy_templates_sw.xtb | 13 + .../policy/resources/policy_templates_te.xtb | 15 +- .../policy/resources/policy_templates_th.xtb | 13 + .../policy/resources/policy_templates_tr.xtb | 15 +- .../policy/resources/policy_templates_uk.xtb | 13 + .../policy/resources/policy_templates_vi.xtb | 23 +- .../policy/resources/policy_templates_zh-CN.xtb | 563 ++++++++++++++++++++- .../policy/resources/policy_templates_zh-TW.xtb | 13 + components/strings/components_strings_am.xtb | 1 + components/strings/components_strings_ar.xtb | 5 +- components/strings/components_strings_bg.xtb | 1 + components/strings/components_strings_bn.xtb | 5 +- components/strings/components_strings_ca.xtb | 1 + components/strings/components_strings_cs.xtb | 1 + components/strings/components_strings_da.xtb | 1 + components/strings/components_strings_de.xtb | 3 +- components/strings/components_strings_el.xtb | 1 + components/strings/components_strings_en-GB.xtb | 1 + components/strings/components_strings_es-419.xtb | 1 + components/strings/components_strings_es.xtb | 1 + components/strings/components_strings_et.xtb | 1 + components/strings/components_strings_fa.xtb | 1 + components/strings/components_strings_fi.xtb | 1 + components/strings/components_strings_fil.xtb | 1 + components/strings/components_strings_fr.xtb | 1 + components/strings/components_strings_gu.xtb | 1 + components/strings/components_strings_hi.xtb | 1 + components/strings/components_strings_hr.xtb | 1 + components/strings/components_strings_hu.xtb | 1 + components/strings/components_strings_id.xtb | 1 + components/strings/components_strings_it.xtb | 1 + components/strings/components_strings_iw.xtb | 1 + components/strings/components_strings_ja.xtb | 5 +- components/strings/components_strings_kn.xtb | 1 + components/strings/components_strings_ko.xtb | 1 + components/strings/components_strings_lt.xtb | 1 + components/strings/components_strings_lv.xtb | 1 + components/strings/components_strings_ml.xtb | 5 +- components/strings/components_strings_mr.xtb | 1 + components/strings/components_strings_ms.xtb | 5 +- components/strings/components_strings_nl.xtb | 1 + components/strings/components_strings_no.xtb | 1 + components/strings/components_strings_pl.xtb | 1 + components/strings/components_strings_pt-BR.xtb | 1 + components/strings/components_strings_pt-PT.xtb | 1 + components/strings/components_strings_ro.xtb | 1 + components/strings/components_strings_ru.xtb | 1 + components/strings/components_strings_sk.xtb | 1 + components/strings/components_strings_sl.xtb | 1 + components/strings/components_strings_sr.xtb | 1 + components/strings/components_strings_sv.xtb | 1 + components/strings/components_strings_sw.xtb | 1 + components/strings/components_strings_te.xtb | 1 + components/strings/components_strings_th.xtb | 1 + components/strings/components_strings_tr.xtb | 1 + components/strings/components_strings_uk.xtb | 1 + components/strings/components_strings_vi.xtb | 5 +- components/strings/components_strings_zh-CN.xtb | 8 +- components/strings/components_strings_zh-TW.xtb | 3 +- .../app/strings/resources/ios_strings_el.xtb | 3 + .../app/strings/resources/ios_strings_en-GB.xtb | 3 + remoting/resources/remoting_strings_ja.xtb | 2 +- .../translations/ui_chromeos_strings_ja.xtb | 2 +- .../translations/ui_chromeos_strings_zh-CN.xtb | 1 + ui/strings/translations/ui_strings_el.xtb | 1 + ui/strings/translations/ui_strings_en-GB.xtb | 1 + 329 files changed, 1953 insertions(+), 2112 deletions(-) commit 14edf735c14f1430daa20358c14a5a4197957586 Author: Alexander Alekseev <alemate@chromium.org> Date: Fri Apr 5 03:01:01 2019 +0000 Chrome OS: Add missing import of I18nBehavior to oobe_supervision_transition.js Bug: 949828 Change-Id: Iaf637ea478972bd4449ba0e9e303ed686b250243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554137 Reviewed-by: Toni Baržić <tbarzic@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#648051} chrome/browser/resources/chromeos/login/oobe_supervision_transition.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d8f243a43e73ac41527688cc24d932cc77acc40c Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Fri Apr 5 02:51:02 2019 +0000 Import wpt@0cde5f6b37c9b3e3f9153eb1b172680e9aea9bf9 Using wpt-import in Chromium e62c687108e0b8adc9ef974a80811a42b2504cf9. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" adc34f41f6 "Fix web_test pointerevent_coordinates_when_locked on wpt" c27a874cf2 "[WPT] Fix JSON decoding errors in referrer-policy on Safari" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I82dcb55600b36309a92d85bc42b7a7e33b656608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553315 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648050} .../web_tests/external/WPT_BASE_MANIFEST_5.json | 30 +++++++++++----------- .../loop-from-ended.tentative.html | 4 ++- 2 files changed, 18 insertions(+), 16 deletions(-) commit 7dd3ec9d208693c060ceefe2f8d6071cb31e63d8 Author: Austin Eng <enga@chromium.org> Date: Fri Apr 5 02:42:41 2019 +0000 Run gl_tests and gl_unittests in gpu_dawn_integration_gtests This change partitions tests of Dawn into those that test only Dawn and those that test both Dawn and integration with Chromium. Dawn-only tests are on ToT Dawn whereas integration tests are run with DEPS Dawn. gpu_dawn_tests are still part of some of the GPU FYI test suites because some Dawn trybots still mirror the GPU FYI bots. Change-Id: I85ba10a15a3ac20d6583b72ac5b0c5e96b217d88 Bug: chromium:948902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553121 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648049} testing/buildbot/chromium.dawn.json | 200 ++++++++++++++++++++++++++++++++++++ testing/buildbot/test_suites.pyl | 44 ++++++-- testing/buildbot/waterfalls.pyl | 38 +++---- 3 files changed, 254 insertions(+), 28 deletions(-) commit 64db0578191d7de441ac29cd4112de280fde985d Author: Takashi Sakamoto <tasak@google.com> Date: Fri Apr 5 02:40:01 2019 +0000 Revert "Process touch events during the tab-dragging window move" This reverts commit 402ea29b3de92edfce2b9d73605adfb29a9351f1. Reason for revert: caused interactive_ui_tests failure on Linux ChromiumOS Msan Tests bot: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/12183 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8917064469538663120/+/steps/interactive_ui_tests/0/logs/Deterministic_failure:_TabDragging__x2f_DetachToBrowserTabDragControllerTest.DeleteTabsWhileDetached__x2f_0__status_CRASH_/0 deterministic failures [caused step to fail]: TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragMaxTabToNonMaxWindowInSeparateDisplay/0 TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragTabToWindowInSeparateDisplay/0 TabDragging/DetachToBrowserInSeparateDisplayTabDragControllerTest.DragTabToWindowOnSecondDisplay/0 TabDragging/DetachToBrowserTabDragControllerTest.DeleteTabsWhileDetached/0 TabDragging/DetachToBrowserTabDragControllerTest.DeleteTabsWhileDetached/1 TabDragging/DetachToBrowserTabDragControllerTest.DragAllToSeparateWindow/0 TabDragging/DetachToBrowserTabDragControllerTest.DragAllToSeparateWindow/1 TabDragging/DetachToBrowserTabDragControllerTest.DragAllToSeparateWindowAndCancel/0 TabDragging/DetachToBrowserTabDragControllerTest.DragAllToSeparateWindowAndCancel/1 TabDragging/DetachToBrowserTabDragControllerTest.DragSingleTabToSeparateWindow/0 TabDragging/DetachToBrowserTabDragControllerTest.DragSingleTabToSeparateWindow/1 TabDragging/DetachToBrowserTabDragControllerTest.DragToSeparateWindow/0 TabDragging/DetachToBrowserTabDragControllerTest.DragToSeparateWindow/1 TabDragging/DetachToBrowserTabDragControllerTest.FastResizeDuringDragging/0 TabDragging/DetachToBrowserTabDragControllerTest.FastResizeDuringDragging/1 Original change's description: > Process touch events during the tab-dragging window move > > When the touch events move very quickly on detaching, some > touch events are already queued, those queued touch events > aren't processed properly. > > - Detach() aren't releasing the capture on the source widget. > This means those queued touch events are targeted to the > source widget instead of the moving widget, but the touch > history is already transferred to the moving widget, which > makes troubles on gesture recognition. We can release the > capture on the detach on this specific situation. > - the recognized gestures are sent to the root window of > the moving widget and nobody can handle. The new class > RemainingGestureEventHandler handles them. > - RemainingGestureEventHandler should not handle events > originated from ET_TOUCH_CANCELLED -- some test cases > actually fail if so. ET_TOUCH_CANCELLED can happen internally > within the browser (like Window::CleanupGestureState()), > but that's not the intention of this class. > > Bug: 943316 > Test: the new test case in interactive_ui_tests > Change-Id: I679562d7707342874960dd7ff4d70d749f1ad437 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545113 > Reviewed-by: Jun Mukai <mukai@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Jun Mukai <mukai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647789} TBR=mukai@chromium.org,sky@chromium.org Change-Id: I55fe6f467da626ebbfa1ce6826507e4827af43c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 943316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553044 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#648048} .../browser/ui/views/tabs/tab_drag_controller.cc | 19 ----- .../tabs/tab_drag_controller_interactive_uitest.cc | 30 -------- ui/aura/mus/window_tree_client_unittest.cc | 80 ---------------------- ui/aura/mus/window_tree_host_mus.cc | 31 +-------- 4 files changed, 1 insertion(+), 159 deletions(-) commit 70b178083ae9487ad00dd1b7fafad6fad8ff3e5a Author: Hitoshi Yoshida <peria@chromium.org> Date: Fri Apr 5 02:34:40 2019 +0000 IDL compiler: Support interface mixin Historically, we are using [NoInterfaceObject] extended attribute for both interface mixins and non-exposed interfaces. We had to check each [NoInterfaceObject] interfaces were implemented to distinguish them. Now [NoInterfaceObject] is obsolete in the spec, and this CL starts to support interface mixins. It allows us to update IDL files more consistent, and distinguishes mixins and non-exposed interfaces easily. Bug: 781257 Change-Id: Icf302fe8ae633814251c35195ed2898aa8df6a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547621 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#648047} .../scripts/generate_global_constructors.py | 8 +- .../renderer/bindings/scripts/idl_definitions.py | 1 + .../scripts/interface_dependency_resolver.py | 33 +++-- .../blink/renderer/bindings/scripts/utilities.py | 9 +- .../renderer/bindings/scripts/v8_interface.py | 9 +- .../bindings/tests/idls/core/test_interface.idl | 5 +- ...est_implements.idl => test_interface_mixin.idl} | 7 +- ...implements_2.idl => test_interface_mixin_2.idl} | 6 +- ...implements_3.idl => test_interface_mixin_3.idl} | 7 +- .../tests/results/core/test_interface_or_long.cc | 4 +- .../core/test_interface_or_test_interface_empty.cc | 4 +- .../tests/results/core/v8_test_interface.cc | 157 ++------------------- .../tests/results/core/v8_test_interface.h | 9 -- .../blink/tools/blinkpy/bindings/bindings_tests.py | 6 +- 14 files changed, 56 insertions(+), 209 deletions(-) commit 08f2e476f755ef000490e38c979654781466869d Author: chaopeng@chromium.org <chaopeng@chromium.org> Date: Fri Apr 5 02:33:39 2019 +0000 Adding different level of not expose key events Change current not expose key event to be: 1. Not expose key events to js 2. Expose key events to js but not cancellabel unless it is in editor Bug: 920818 Change-Id: Ibcffe76c6239444ffc4d04cac033e805e96de943 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553641 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#648046} .../renderer/core/editing/editing_utilities.cc | 19 +++++++++++ .../renderer/core/editing/editing_utilities.h | 3 ++ .../blink/renderer/core/events/keyboard_event.cc | 5 +-- .../blink/renderer/core/events/keyboard_event.h | 10 ++++-- .../renderer/core/input/event_handler_test.cc | 32 ++++++++++++++++-- .../renderer/core/input/keyboard_event_manager.cc | 39 ++++++++++++++++++---- 6 files changed, 94 insertions(+), 14 deletions(-) commit 05eb2706c703db9c13463f5e1fba637c571d0366 Author: Joanmarie Diggs <jdiggs@igalia.com> Date: Fri Apr 5 02:31:29 2019 +0000 Implement support for new ARIA meter role This role is part of reaching role parity with HTML5. As such, they should be exposed via platform accessibility APIs in the same way as their native host language counterparts. Thus just add them to the map of ARIA roles to internal roles. Also update the mapping of meters on macOS to LevelIndicatorRole, which is consistent both with the platform mappings specified in the AAMs (HTML and Core) as well as with the current nightly builds of Safari. Add LevelIndicatorRole to the properties which support AXValue, AXMinValue, and AXMaxValue. Bug: 944554 Change-Id: I0d2dce1ec413f69a0b133d86d7afb3726e09da51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536746 Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Auto-Submit: Joanmarie Diggs <joanmarie.diggs@gmail.com> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#648045} .../accessibility/browser_accessibility_cocoa.mm | 14 ++------------ .../dump_accessibility_tree_browsertest.cc | 4 ++++ .../aria/aria-meter-expected-android.txt | 3 +++ .../aria/aria-meter-expected-auralinux.txt | 3 +++ .../accessibility/aria/aria-meter-expected-blink.txt | 7 +++++++ .../accessibility/aria/aria-meter-expected-mac.txt | 3 +++ .../accessibility/aria/aria-meter-expected-win.txt | 3 +++ content/test/data/accessibility/aria/aria-meter.html | 19 +++++++++++++++++++ .../data/accessibility/html/meter-expected-mac.txt | 2 +- .../blink/renderer/modules/accessibility/ax_object.cc | 1 + ui/accessibility/platform/ax_platform_node_mac.mm | 2 +- 11 files changed, 47 insertions(+), 14 deletions(-) commit 9caae42b4621229775ec21c16a837251223872c6 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Fri Apr 5 02:29:37 2019 +0000 Android: Factor overscroll navigation logic out to NavigationHandler HistoryNavigationLayout and SwipeRefreshLayout have the overscroll navigation logic using SideSlideLayout in common. This CL factors out the commong logic into NavigationHandler. Bug: 865567 Change-Id: I8c4759a1ce2598121f8330923101ded0fb0e7c86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542754 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#648044} chrome/android/chrome_java_sources.gni | 1 + .../chrome/browser/SwipeRefreshHandler.java | 105 ++-------- .../gesturenav/HistoryNavigationLayout.java | 185 ++++------------- .../browser/gesturenav/NavigationHandler.java | 231 +++++++++++++++++++++ 4 files changed, 280 insertions(+), 242 deletions(-) commit 3b71a22cebd4f2b19e460108d49534485c756ae3 Author: Mitsuru Oshima <oshima@chromium.org> Date: Fri Apr 5 02:27:07 2019 +0000 Fix errors in histograms.xml * base=true was incorrectly set to wrong histograms (old instead of new) * units for presentation time should be ms not % * fixed suffix relations to match the actual code. - Apps.PaginationTransition.DragScroll.PresentationTime.* should use TabletorClamshellMode - Ash.Overview.AnimationSmoothness.Enter and Ash.Overview.AnimationSmoothness.Exit does not use TabletOrClamshellMode (I added one for overview animation, but forgot to remove them from TabletOrClamshellMode) Bug: None Change-Id: I140d6f9b24e9b256ffcdde428f94736606b28dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551454 Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#648043} tools/metrics/histograms/histograms.xml | 56 ++++++++++++++++----------------- 1 file changed, 28 insertions(+), 28 deletions(-) commit 8b2f1c15b856e080d48321ce7abff98221f02e91 Author: Yaron Friedman <yfriedman@chromium.org> Date: Fri Apr 5 02:24:02 2019 +0000 [Touchless] Disable Web app actions notifications. Not a workable use-case for this build. Bug: b/129958014 Change-Id: I492281531aaf8be05ea091596150cbc615fd6438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554102 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648042} .../chrome/browser/webapps/WebappActionsNotificationManager.java | 5 +++++ 1 file changed, 5 insertions(+) commit 95dea86f00379b19f73b1a95ebbc69b808da4167 Author: Sébastien Séguin-Gagnon <sebsg@chromium.org> Date: Fri Apr 5 02:20:10 2019 +0000 [SendTabToSelf] Adds ClientService and its Factory for iOS. Bug: 944602 Change-Id: Ie9a1759f6770735f252092ff3c3635b984042fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553817 Reviewed-by: Peter Lee <pkl@chromium.org> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#648041} .../send_tab_to_self_client_service.cc | 3 +- ios/chrome/browser/browser_state/BUILD.gn | 1 + .../browser_state_keyed_service_factories.mm | 2 + ios/chrome/browser/send_tab_to_self/BUILD.gn | 22 ++++++++ .../send_tab_to_self_client_service_factory.h | 46 +++++++++++++++++ .../send_tab_to_self_client_service_factory.mm | 58 ++++++++++++++++++++++ .../send_tab_to_self_client_service_ios.cc | 43 ++++++++++++++++ .../send_tab_to_self_client_service_ios.h | 53 ++++++++++++++++++++ 8 files changed, 227 insertions(+), 1 deletion(-) commit 7ea38b6e40fee5b4c69b3356ed2f01163afd6570 Author: Alexander Timin <altimin@chromium.org> Date: Fri Apr 5 02:18:40 2019 +0000 [bfcache] Account for cache-control directives for bfcache Disable back-forward cache when cache-control: no-cache or cache-control: no-store are present. Note: for now these are only used for collecting metrics for estimating potential bfcache impact. BUG=933147 R=haraken@chromium.org,toyoshim@chromium.org Change-Id: I5ab75758c4a2e4fe7069875b1e88007b6738ac58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530983 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#648040} .../blink/renderer/core/frame/ad_tracker_test.cc | 5 +- .../blink/renderer/core/loader/document_loader.cc | 11 ++++ .../scheduler/scheduler_affecting_features_test.cc | 71 ++++++++++++++++++++++ .../blink/renderer/core/testing/sim/sim_network.cc | 6 ++ .../blink/renderer/core/testing/sim/sim_request.cc | 25 +++----- .../blink/renderer/core/testing/sim/sim_request.h | 23 ++++--- .../platform/loader/fetch/resource_fetcher.cc | 6 ++ .../platform/loader/fetch/resource_fetcher.h | 5 ++ .../platform/loader/fetch/resource_loader.cc | 13 ++++ .../platform/scheduler/common/scheduling_policy.cc | 5 +- .../scheduler/main_thread/frame_scheduler_impl.cc | 6 +- .../scheduler/main_thread/frame_scheduler_impl.h | 2 + .../main_thread/page_scheduler_impl_unittest.cc | 20 +++--- .../platform/scheduler/public/frame_scheduler.h | 3 + .../platform/scheduler/public/scheduling_policy.h | 11 ++-- .../test/renderer_scheduler_test_support.cc | 1 + 16 files changed, 171 insertions(+), 42 deletions(-) commit 4a2ce1efa2e3c1146ab146312acd5c1c9c02809b Author: Darwin Huang <huangdarwin@chromium.org> Date: Fri Apr 5 02:18:01 2019 +0000 Async Clipboard: Split out Clipboard type-specific logic for Encoding/Decoding. - clipboard-type-dependent code mostly split out to ClipboardReader/ClipboardWriter. - ClipboardWriter/ClipboardReader have two child/sub/derived classes, one for images and one for text. - Also did minor refactoring, like appending a '_' for the clipboard promise's sequence checker and removing the clipboardtype member var. Bug: 150835 Change-Id: Ic870db9b5a0be7635419330d1c24b96eb51f0edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1535339 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#648039} .../blink/renderer/modules/clipboard/BUILD.gn | 6 +- .../modules/clipboard/clipboard_file_reader.cc | 38 --- .../modules/clipboard/clipboard_file_reader.h | 45 ---- .../modules/clipboard/clipboard_promise.cc | 268 ++++----------------- .../renderer/modules/clipboard/clipboard_promise.h | 45 +--- .../renderer/modules/clipboard/clipboard_reader.cc | 78 ++++++ .../renderer/modules/clipboard/clipboard_reader.h | 32 +++ .../renderer/modules/clipboard/clipboard_writer.cc | 167 +++++++++++++ .../renderer/modules/clipboard/clipboard_writer.h | 63 +++++ 9 files changed, 404 insertions(+), 338 deletions(-) commit 82deafbd724b23648efe875da5577557d1dc446d Author: Eric Willigers <ericwilligers@chromium.org> Date: Fri Apr 5 02:00:43 2019 +0000 Web Share: Limit permitted file extensions For the initial implementation of sharing on Android, we allow only common audio, image, text and video file extensions. In particular, this blocks executable files from being shared. BUG=903010 Change-Id: I18968c7c70c6f778e6c64dd62bb1e9cc4a667d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1449436 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#648038} chrome/android/chrome_junit_test_java_sources.gni | 1 + .../chrome/browser/webshare/ShareServiceImpl.java | 53 +++++++++++++++++-- .../browser/webshare/ShareServiceImplTest.java | 61 ++++++++++++++++++++++ 3 files changed, 112 insertions(+), 3 deletions(-) commit 23eda3a8c58a3084ce407f647ed0194fc8698918 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Fri Apr 5 01:59:41 2019 +0000 Only use alertdialog role for dialogs that do not have initial focus Bug: None Change-Id: I937ddd82cb5c144bca2be147083e79743aae3b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551708 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Nektarios Paisios <nektar@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#648037} ash/app_list/views/app_list_view.cc | 2 +- ash/app_list/views/app_list_view.h | 2 +- ash/assistant/ui/assistant_container_view.cc | 2 +- ash/assistant/ui/assistant_container_view.h | 2 +- ash/shelf/shelf_bubble.cc | 2 +- ash/shelf/shelf_bubble.h | 2 +- ash/system/tray/tray_bubble_view.cc | 2 +- ash/system/tray/tray_bubble_view.h | 2 +- .../extensions/extension_install_dialog_view.cc | 2 +- .../extensions/extension_install_dialog_view.h | 2 +- .../feature_promos/feature_promo_bubble_view.cc | 2 +- .../feature_promos/feature_promo_bubble_view.h | 2 +- chrome/browser/ui/views/find_bar_host.cc | 2 +- chrome/browser/ui/views/find_bar_host.h | 2 +- .../location_bar_bubble_delegate_view.cc | 7 +- .../ui/views/profiles/profile_menu_view_base.cc | 2 +- .../ui/views/profiles/profile_menu_view_base.h | 2 +- .../accessibility/accessibility_win_browsertest.cc | 190 +++++++++++++++++++++ .../accessibility/browser_accessibility_com_win.cc | 10 +- ui/chromeos/search_box/search_box_view_base.cc | 2 +- ui/chromeos/search_box/search_box_view_base.h | 2 +- ui/views/bubble/bubble_dialog_delegate_view.cc | 9 +- ui/views/bubble/bubble_dialog_delegate_view.h | 2 +- ui/views/widget/widget_delegate.cc | 2 +- ui/views/widget/widget_delegate.h | 2 +- ui/views/window/dialog_delegate.cc | 7 +- ui/views/window/dialog_delegate.h | 2 +- 27 files changed, 236 insertions(+), 31 deletions(-) commit c68ab88112ecc53e7797c587828493cb89861a8e Author: Becky Zhou <huayinz@chromium.org> Date: Fri Apr 5 01:59:38 2019 +0000 [Dark] Update tab loading background color for dark mode Bug: 944895, 944638 Change-Id: Ibfa0330c18b60517d3c3e61233f1c829a2934d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552422 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#648036} .../chrome/browser/compositor/CompositorView.java | 4 +-- .../browser/compositor/layouts/LayoutManager.java | 4 +-- .../layouts/phone/stack/StackViewAnimation.java | 3 +- .../src/org/chromium/chrome/browser/tab/Tab.java | 10 ------- .../chrome/browser/tab/TabThemeColorHelper.java | 34 ++++++++++++++++++++++ .../browser/web_contents/web_contents_android.cc | 6 +++- 6 files changed, 45 insertions(+), 16 deletions(-) commit 6e2cb30923a62fa89ca0df78398442a7d2585d82 Author: Scott Chen <scottchen@chromium.org> Date: Fri Apr 5 01:57:42 2019 +0000 Settings: remove private properties from default browser test Bug: None Change-Id: Ie03d9fad69d6b1920c8d5485c2e40dd7fe8815d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553668 Auto-Submit: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#648035} .../webui/settings/default_browser_browsertest.js | 46 ++++++++++++---------- 1 file changed, 25 insertions(+), 21 deletions(-) commit ede92bcdd9d271c8c35d89729734414da2352cf9 Author: Tim Song <tengs@chromium.org> Date: Fri Apr 5 01:54:43 2019 +0000 Ash Tray: Use SetIsFastRoundedCorner() for tray bubble. BUG=945936 Change-Id: Ic69644735f9afdba7af414912f9ede7816206b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554120 Reviewed-by: Malay Keshav <malaykeshav@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#648034} ash/system/tray/tray_bubble_view.cc | 1 + 1 file changed, 1 insertion(+) commit 26d4e720f158ac7103b696a6583d9c84cf04d8e5 Author: Ian Vollick <vollick@chromium.org> Date: Fri Apr 5 01:54:21 2019 +0000 Support negative outline offset on video/canvas elements Updates the logic in CLM to create the decoration_outline_layer_ and the GraphicsLayerTreeBuilder to ensure that the layer isn't clobbered when stitching together the full GraphicsLayer tree. Also updates the paint order in paint_layer_painter to ensure that the outline draws atop the video controls. Bug: 947541 Change-Id: Ibe6a7dc56529557b9b6f63f1910c3f3002433c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546185 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648033} .../paint/compositing/composited_layer_mapping.cc | 37 ++++++++++++++++------ .../paint/compositing/composited_layer_mapping.h | 3 ++ .../compositing/graphics_layer_tree_builder.cc | 8 ++++- .../renderer/core/paint/paint_layer_painter.cc | 10 +++++- .../video/video-neg-offset-outline-expected.html | 12 +++++++ .../video/video-neg-offset-outline.html | 11 +++++++ .../webgl-with-neg-outline-offset-expected.html | 13 ++++++++ .../webgl/webgl-with-neg-outline-offset.html | 23 ++++++++++++++ 8 files changed, 105 insertions(+), 12 deletions(-) commit 5084d89d50df91778c36cf3fd6e09b047b50a24d Author: Ben Pastene <bpastene@chromium.org> Date: Fri Apr 5 01:53:38 2019 +0000 Use the host-side tast bin to run tast tests instead of the DUT-side local_test_runner. This is done by using cros_run_test's "--tast" feature instead of using its "--remote-cmd" option. The tast bin has a lot more features, one of which is better result reporting. Leveraging these more accurate results will come in a follow-up. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel Bug: 923426 Change-Id: I6e30c62c0a1bba0444d3b6d25a0e59a70de50263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553805 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#648032} build/chromeos/test_runner.py | 67 +++++++++++++++++++++++++++-------------- build/config/chromeos/rules.gni | 6 ++++ 2 files changed, 51 insertions(+), 22 deletions(-) commit 73046e99333e78c801b5ed6390b8a7d927a27648 Author: John Lee <johntlee@chromium.org> Date: Fri Apr 5 01:53:08 2019 +0000 Settings WebUI: Filter out languages that do not support spellcheck Bug: 848536 Change-Id: I14582a4ae42c6a6356e492667e49ac1c9c7d3053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553445 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#648031} .../resources/settings/languages_page/languages_page.js | 17 +++++++++-------- .../webui/settings/fake_language_settings_private.js | 1 + chrome/test/data/webui/settings/languages_page_tests.js | 10 ++++++++++ 3 files changed, 20 insertions(+), 8 deletions(-) commit 50d6a153040c0bee8cb3926cf507ae4398d610d9 Author: Alexey Baskakov <loyso@chromium.org> Date: Fri Apr 5 01:49:31 2019 +0000 WebApp: Remove unused boolmark_app_helper.h includes. Mark BookmarkAppHelper as DEPRECATED. Bug: 915043 Change-Id: I1c9be41803219b0e9f34f4411303ef4c81768417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554201 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#648030} chrome/browser/extensions/bookmark_app_helper.h | 2 ++ .../browser/extensions/bookmark_app_navigation_throttle_browsertest.cc | 1 - chrome/browser/extensions/convert_web_app_unittest.cc | 1 - chrome/browser/extensions/extension_browsertest.cc | 1 - 4 files changed, 2 insertions(+), 3 deletions(-) commit 2d8ad76070a840ce3821f3d28e55cd952f7640c0 Author: Erik Luo <luoe@chromium.org> Date: Fri Apr 5 01:44:27 2019 +0000 DevTools: prepare Computed sidebar for groups Computed sidebar - Removes even/odd striping - Extracts a function to build a property's TreeElement Bug: 929536 Change-Id: I727cf1efa5ac65277a046b52575f35102323c38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548446 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#648029} .../front_end/elements/ComputedStyleWidget.js | 135 +++++++++++---------- .../front_end/elements/computedStyleWidgetTree.css | 5 - 2 files changed, 74 insertions(+), 66 deletions(-) commit a86087dd88b87af4e096b6e81a6e40a7d4e37fd1 Author: Andrew Luo <aluo@chromium.org> Date: Fri Apr 5 01:38:30 2019 +0000 Roll CTS tests to 7.0_r30 and 8.0_r18, re-enabling android.webkit.cts.WebViewSslTest#testSecureServerRequiringClientCertDoesCancelRequest. Test: run_cts.py -f android.webkit.cts.WebViewSslTest#testSecureServerRequiringClientCertDoesCancelRequest Bug: 922400 Change-Id: I3299e83513edf779e656cbd0a0f13ee1b3b9c405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552486 Reviewed-by: Ben Pastene <bpastene@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#648028} DEPS | 2 +- android_webview/tools/cts_archive/cipd.yaml | 10 +++--- android_webview/tools/cts_archive/version.txt | 2 +- .../tools/cts_config/webview_cts_gcs_path.json | 40 ++++++++-------------- testing/buildbot/chromium.android.fyi.json | 2 +- testing/buildbot/chromium.android.json | 4 +-- testing/buildbot/test_suites.pyl | 2 +- 7 files changed, 26 insertions(+), 36 deletions(-) commit c019e83c1e58554365d4c4e78db8551cfdb2634e Author: Sadrul Habib Chowdhury <sadrul@chromium.org> Date: Fri Apr 5 01:35:31 2019 +0000 ash: Convert SplitViewTest to a performance-test. The changes: . Create UIPerformanceTest to report the tracing categories for measuring UI performance. . Convert SplitViewTest to subclass from UIPerformanceTest instead of InProcessBrowserTest. . SplitViewTest overrides GetUMAHistogramNames() to enumerate the list of UMA metrics to track. The way to collect performance metrics from this test, manually: . Run the test, with --trace-dir=<path to directory> (the directory should already exist). . . Run the following command: ./third_party/catapult/tracing/bin/run_metric \ <trace-file> renderingMetric umaMetric . Inspect the frame_times, ui_frame_times and ui_percentage_smooth, and Ash.SplitViewResize.PresentationTime.TabletMode.MultiWindow metrics. BUG=945709 Change-Id: Ic2a44da0c75afacc271127217d1716248724319f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553907 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#648027} chrome/browser/ui/ash/split_view_interactive_uitest.cc | 10 ++++++++-- chrome/test/base/perf/performance_test.cc | 10 ++++++++++ chrome/test/base/perf/performance_test.h | 18 +++++++++++++++--- 3 files changed, 33 insertions(+), 5 deletions(-) commit e99debf527eb4b78f4ed44727e4311ca209a18c7 Author: Eric Willigers <ericwilligers@chromium.org> Date: Fri Apr 5 01:32:05 2019 +0000 Web Share: share file as mojom blob Mojom bindings and Renderer code for sharing files. Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/AiKgWvv3cq0/xAsjfSfMDQAJ Bug: 903010 Change-Id: I07c155761ad5fcaa692116521a018c1d9d7df428 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1460583 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#648026} chrome/android/BUILD.gn | 1 + chrome/android/chrome_java_sources.gni | 2 + chrome/android/chrome_junit_test_java_sources.gni | 1 + .../chromium/chrome/browser/share/ShareHelper.java | 29 +++- .../chromium/chrome/browser/share/ShareParams.java | 50 +++++- .../chrome/browser/webshare/BlobReceiver.java | 174 +++++++++++++++++++++ .../chrome/browser/webshare/ShareServiceImpl.java | 105 ++++++++++++- .../browser/webshare/SharedFileCollator.java | 90 +++++++++++ .../org/chromium/chrome/browser/WebShareTest.java | 5 + .../browser/webshare/SharedFileCollatorTest.java | 107 +++++++++++++ third_party/blink/public/mojom/BUILD.gn | 23 ++- .../blink/public/mojom/webshare/webshare.mojom | 11 +- third_party/blink/renderer/modules/BUILD.gn | 1 + .../renderer/modules/webshare/navigator_share.cc | 33 +++- .../renderer/modules/webshare/navigator_share.h | 6 +- .../modules/webshare/navigator_share_test.cc | 169 ++++++++++++++++++++ 16 files changed, 776 insertions(+), 31 deletions(-) commit ccf92878b2e859200f25267977289a5001536d85 Author: Dan Beam <dbeam@chromium.org> Date: Fri Apr 5 01:24:05 2019 +0000 Flags: update chrome://flags for dark mode (and otherwise retouch) Screenshots: https://imgur.com/a/WFbTEpH R=asvitkine@chromium.org BUG=945872 Change-Id: Ie3677172495bc619419c49dafa88d3040e86812a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547960 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#648025} chrome/browser/ui/webui/flags_ui.cc | 12 +- components/flags_ui/resources/flags.css | 251 ++++++++++++++++++++----------- components/flags_ui/resources/flags.html | 8 +- 3 files changed, 175 insertions(+), 96 deletions(-) commit b8d1e4e19e86e2ae4cb6cd1b2fd95e0d58653bf1 Author: Adam Ettenberger <adettenb@microsoft.com> Date: Fri Apr 5 01:20:41 2019 +0000 Fire UIA Property Changed event for UIA_FlowsFromPropertyId 1. Add AXEventGenerator::Event::FLOW_FROM_CHANGED 2. Fire FLOW_FROM_CHANGED for each node id that was added/removed from ax::mojom::IntListAttribute::kFlowtoIds Bug: 928949 Change-Id: I59eb217fb0d81f4351c4a0c70d7454608f2359e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547766 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Adam Ettenberger <adettenb@microsoft.com> Cr-Commit-Position: refs/heads/master@{#648024} .../extensions/automation_ax_tree_wrapper.cc | 1 + .../extensions/automation_ax_tree_wrapper.cc | 1 + .../browser_accessibility_manager_android.cc | 1 + .../browser_accessibility_manager_mac.mm | 1 + .../browser_accessibility_manager_win.cc | 3 ++ .../dump_accessibility_events_browsertest.cc | 5 ++ .../event/aria-flow-to-expected-uia-win.txt | 19 +++++++ .../event/aria-flow-to-expected-uia-win7.txt | 11 ++++ .../data/accessibility/event/aria-flow-to.html | 58 ++++++++++++++++++++++ ui/accessibility/ax_event_generator.cc | 23 ++++++++- ui/accessibility/ax_event_generator.h | 6 +++ ui/accessibility/ax_event_generator_unittest.cc | 42 ++++++++++++++++ 12 files changed, 170 insertions(+), 1 deletion(-) commit 0c4f18d125da15d531b63bf51ecb321208a87401 Author: Hao Zhang <hozhng@google.com> Date: Fri Apr 5 01:20:25 2019 +0000 [Autofill] Do not discard form data after dynamic *credit card* form submission This cl is mostly similar wtih 1137021 but apply only to credit card form. Description from 1137021: Prior to this change form data were being discarded after a dynamic form submission. This was because the dynamically changed form was being added to the cache with its user entered/autofilled values. At the time of submission, form data were being discarded as they were thought to be the initial values of the fields at page load. This CL changes AutofillHandler::OnFormsSeen (which is called on dynamic form changes) to attempt to find a previously cached version of the form first. Prior to addition to the cache, form values are overridden by the cached values. This prevents those values from getting confused with the initial form values at the time of submission. Bug: 947312 Change-Id: If50377ecba76bd931c545ecb347ce1b681959c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545210 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#648023} chrome/browser/about_flags.cc | 4 + chrome/browser/flag-metadata.json | 5 + chrome/browser/flag_descriptions.cc | 6 + chrome/browser/flag_descriptions.h | 3 + .../autofill/save_card_bubble_views_browsertest.cc | 157 ++++++++++++++------- .../content/browser/content_autofill_driver.h | 1 + .../autofill/core/browser/autofill_handler.cc | 28 +++- .../autofill/core/browser/autofill_handler.h | 14 ++ .../autofill/core/browser/autofill_manager.cc | 2 +- components/autofill/core/browser/form_structure.cc | 23 ++- components/autofill/core/browser/form_structure.h | 2 +- .../core/common/autofill_payments_features.cc | 4 + .../core/common/autofill_payments_features.h | 1 + .../credit_card_upload_form_address_and_cc.html | 11 ++ .../data/autofill/credit_card_upload_form_cc.html | 68 +++++++++ tools/metrics/histograms/enums.xml | 2 + 16 files changed, 269 insertions(+), 62 deletions(-) commit 0a4104adb99a63e9636c0bdc05307a3e7702d26f Author: Minggang Wang <minggang.wang@intel.com> Date: Fri Apr 5 01:19:02 2019 +0000 TaskManager: Show ServiceWorker tasks in TaskManager This patch creates ServiceWorkerProvider/ServiceWorkerTask to track all service worker status changes. During the initializing stage, the ServiceWorkerProvider will iterate all service workers' running status and add itself as an observer of the ServiceWorkerContext. Then, the provider will create tasks according to the running status. Through the invoking of the callback, the provider can create/delete the ServiceWorkerTask dynamically. As the type of the ServiceWorkerTask is SERVICE_WORKER, a new type of porcess which is service_worker is added accordingly. BUG=716609 Change-Id: Id6c153794c9e2d3d569a367d46710613f6b176a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1406147 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Makoto Shimazu <shimazu@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#648022} chrome/app/generated_resources.grd | 3 + chrome/browser/BUILD.gn | 4 + .../extensions/api/processes/processes_api.cc | 3 + .../task_manager/providers/service_worker_task.cc | 35 +++ .../task_manager/providers/service_worker_task.h | 35 +++ .../providers/service_worker_task_provider.cc | 240 +++++++++++++++++ .../providers/service_worker_task_provider.h | 108 ++++++++ .../service_worker_task_provider_browsertest.cc | 292 +++++++++++++++++++++ chrome/browser/task_manager/providers/task.h | 1 + .../task_manager/sampling/task_manager_impl.cc | 2 + chrome/common/extensions/api/processes.idl | 1 + chrome/test/BUILD.gn | 1 + .../service_worker/service_worker_browsertest.cc | 100 +++++++ .../service_worker/service_worker_context_core.cc | 8 + .../service_worker_context_unittest.cc | 100 ++++++- .../service_worker_context_wrapper.cc | 114 ++++++++ .../service_worker_context_wrapper.h | 29 ++ content/public/browser/BUILD.gn | 1 + content/public/browser/service_worker_context.h | 21 ++ .../browser/service_worker_context_observer.h | 17 ++ .../public/browser/service_worker_running_info.h | 36 +++ content/public/test/fake_service_worker_context.cc | 11 + content/public/test/fake_service_worker_context.h | 5 + 23 files changed, 1160 insertions(+), 7 deletions(-) commit aaea666d028aa259a3183f0a77f87bbc1302945b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 01:16:40 2019 +0000 Roll src/third_party/chromite c012fdb54ccb..fe63720b9960 (4 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/c012fdb54ccb..fe63720b9960 git log c012fdb54ccb..fe63720b9960 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 manojgupta@chromium.org Revert "generic_stages: temporarily ignore all target prebuilts." 2019-04-04 dhanyaganesh@chromium.org buildbucket_v2: Send CIDB ID to Buildbucket for now 2019-04-04 dhanyaganesh@chromium.org BuildStore: Shuffle GetBuildStatus logic 2019-04-04 dhanyaganesh@chromium.org GetBuildStages: Remove the unused build_ids argument Created with: gclient setdep -r src/third_party/chromite@fe63720b9960 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Icfd47994127d58f5ffe11ae88f2290b3fca3e0b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553926 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648021} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit d3253d2cbc77f6d31ee08f7d50b8bda7b41ee37b Author: Andrey Kosyakov <caseq@chromium.org> Date: Fri Apr 5 01:16:03 2019 +0000 DevTools: support network interception for service workers ... when enabled through worker-specific target (i.e. after worker start has been initiated). - introduce EmbeddedWorkerInstanceClient::UpdateLoaderFactories() to push new loader factories to worker that has already been started; - introduce Fetch domain on ServiceWorkerDevToolsAgentHost and wire it accordingly; - make Fetch handler's UpdaterLoaderFactoriesCallback async; - extract script loader factory creation logic into EmbeddedWorkerInstance::MakeScriptLoaderFactoryAssociatedPtrInfo; - simplify ServiceWorkerProviderHost::CompleteStartWorkerPreparation() Bug: 944584 Change-Id: I7993c7dd000f1e8defa8a10d1d1808ef699642a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548590 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648020} .../devtools/browser_devtools_agent_host.cc | 3 +- .../browser/devtools/devtools_instrumentation.cc | 7 +- content/browser/devtools/protocol/fetch_handler.cc | 35 ++-- content/browser/devtools/protocol/fetch_handler.h | 12 +- content/browser/devtools/protocol_config.json | 2 +- .../devtools/render_frame_devtools_agent_host.cc | 11 +- .../devtools/service_worker_devtools_agent_host.cc | 41 ++++- .../devtools/service_worker_devtools_agent_host.h | 2 + .../service_worker/embedded_worker_instance.cc | 204 ++++++++++++--------- .../service_worker/embedded_worker_instance.h | 35 ++-- .../fake_embedded_worker_instance_client.h | 3 + .../service_worker/service_worker_provider_host.cc | 26 +-- .../service_worker/service_worker_provider_host.h | 20 +- .../service_worker_script_loader_factory.cc | 5 + .../service_worker_script_loader_factory.h | 2 + .../service_worker/service_worker_test_utils.cc | 8 +- .../embedded_worker_instance_client_impl.cc | 7 + .../embedded_worker_instance_client_impl.h | 3 + .../service_worker_context_client.cc | 9 + .../service_worker/service_worker_context_client.h | 4 + .../mojom/service_worker/embedded_worker.mojom | 7 + .../inspector-protocol/fetch/abort-navigation.js | 2 +- .../fetch/resources/fetch-data.txt | 1 + .../fetch/resources/fetch-test.js | 5 +- .../fetch/resources/service-worker-import.js | 1 + .../fetch/resources/service-worker.html | 8 - .../fetch/resources/service-worker.js | 7 + .../fetch/service-worker-interception-expected.txt | 11 +- .../service-worker-interception-late-expected.txt | 8 + .../fetch/service-worker-interception-late.js | 73 ++++++++ .../fetch/service-worker-interception.js | 13 +- 31 files changed, 387 insertions(+), 188 deletions(-) commit e14a221527cc52545e4db304ab6bb780b2e55153 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 01:14:42 2019 +0000 Roll src/third_party/angle 27f115aa0b80..7a8c3e5ebe3e (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/27f115aa0b80..7a8c3e5ebe3e git log 27f115aa0b80..7a8c3e5ebe3e --date=short --no-merges --format='%ad %ae %s' 2019-04-04 spang@chromium.org Generate entrypoints for GL_EXT_memory_object & GL_EXT_semaphore Created with: gclient setdep -r src/third_party/angle@7a8c3e5ebe3e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I9ef18752a6742413e7669ead5e99e97914aba599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553927 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#648019} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e3c28ff5ee18bb80656092f9f9abb6bf0a39135b Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 01:12:57 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/credentialmanager As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/credentialmanager, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ib66149adf074f3c20c5a3aad898ea65b63066e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552396 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648018} .../authenticator_assertion_response.cc | 9 ------- .../authenticator_assertion_response.h | 6 ----- .../authenticator_attestation_response.cc | 8 ------- .../authenticator_attestation_response.h | 5 ---- .../credentialmanager/authenticator_response.cc | 5 ---- .../credentialmanager/authenticator_response.h | 2 -- .../credentialmanager/credentials_container.cc | 28 ++++++++++------------ .../credentialmanager/credentials_container.h | 2 -- .../credentials_container_test.cc | 14 +++++------ .../credentialmanager/navigator_credentials.cc | 2 +- .../credentialmanager/public_key_credential.cc | 9 ------- .../credentialmanager/public_key_credential.h | 6 ----- 12 files changed, 19 insertions(+), 77 deletions(-) commit 26655986c1d3fb9f405fe1894a2b29457674896e Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 01:12:38 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/cookie_store As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/cookie_store, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I436d8f98ce24c6b3620cc7930efdd3f01ae59326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552395 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648017} third_party/blink/renderer/modules/cookie_store/cookie_store.h | 8 -------- .../cookie_store/service_worker_global_scope_cookie_store.cc | 5 +++-- .../blink/renderer/modules/cookie_store/window_cookie_store.cc | 5 +++-- 3 files changed, 6 insertions(+), 12 deletions(-) commit f53afb84115b1c6d3786417cd0fc1a8b2ce8ac7c Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 01:11:52 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/accessibility As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/accessibility, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I955d8b6119196997db6fe36e6615fbac8f3b4266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552207 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648016} .../modules/accessibility/ax_image_map_link.cc | 5 --- .../modules/accessibility/ax_image_map_link.h | 1 - .../modules/accessibility/ax_inline_text_box.cc | 7 ---- .../modules/accessibility/ax_inline_text_box.h | 3 -- .../modules/accessibility/ax_layout_object.cc | 5 --- .../modules/accessibility/ax_layout_object.h | 2 -- .../renderer/modules/accessibility/ax_list.cc | 5 --- .../blink/renderer/modules/accessibility/ax_list.h | 2 -- .../renderer/modules/accessibility/ax_list_box.cc | 5 --- .../renderer/modules/accessibility/ax_list_box.h | 2 -- .../modules/accessibility/ax_list_box_option.cc | 5 --- .../modules/accessibility/ax_list_box_option.h | 2 -- .../renderer/modules/accessibility/ax_menu_list.cc | 5 --- .../renderer/modules/accessibility/ax_menu_list.h | 2 -- .../modules/accessibility/ax_menu_list_option.h | 5 --- .../modules/accessibility/ax_menu_list_popup.h | 4 --- .../modules/accessibility/ax_node_object.cc | 5 --- .../modules/accessibility/ax_node_object.h | 1 - .../modules/accessibility/ax_object_cache_impl.cc | 40 ++++++++++++---------- .../modules/accessibility/ax_progress_indicator.cc | 7 ---- .../modules/accessibility/ax_progress_indicator.h | 2 -- .../modules/accessibility/ax_radio_input.cc | 5 --- .../modules/accessibility/ax_radio_input.h | 2 -- .../renderer/modules/accessibility/ax_slider.cc | 9 ----- .../renderer/modules/accessibility/ax_slider.h | 4 --- .../renderer/modules/accessibility/ax_svg_root.cc | 5 --- .../renderer/modules/accessibility/ax_svg_root.h | 2 -- .../modules/accessibility/ax_validation_message.h | 4 --- 28 files changed, 22 insertions(+), 124 deletions(-) commit feb5b5fab6c9b1faf930da803efb464755728442 Author: Gyuyoung Kim <gyuyoung@igalia.com> Date: Fri Apr 5 01:11:13 2019 +0000 Remove Create() methods which use MakeGarbageCollected<> in modules/canvas As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/modules/canvas, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: I78f10524e2b433907fd4d53145da7ceeca455c9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552214 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#648015} .../canvas/canvas2d/base_rendering_context_2d.cc | 18 +++++++++--------- .../renderer/modules/canvas/canvas2d/canvas_gradient.h | 10 ---------- .../renderer/modules/canvas/canvas2d/canvas_pattern.h | 7 ------- .../canvas/canvas2d/canvas_rendering_context_2d.cc | 4 ++-- .../canvas2d/canvas_rendering_context_2d_state.h | 4 ---- .../canvas2d/canvas_rendering_context_2d_test.cc | 14 +++++--------- .../renderer/modules/canvas/canvas2d/hit_region.h | 8 -------- 7 files changed, 16 insertions(+), 49 deletions(-) commit e62c687108e0b8adc9ef974a80811a42b2504cf9 Author: Austin Eng <enga@chromium.org> Date: Fri Apr 5 01:07:21 2019 +0000 Add new chromium.dawn waterfall with Windows and Linux builders and testers Bug: chromium:948902 Change-Id: Icd20a45db4abc74d519ed15c3e10c1af6dd8a04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547961 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#648014} infra/config/cr-buildbucket.cfg | 112 +++++++++++++++ infra/config/luci-milo.cfg | 104 ++++++++++++++ infra/config/luci-scheduler.cfg | 198 ++++++++++++++++++++++++++ testing/buildbot/chromium.dawn.json | 274 ++++++++++++++++++++++++++++++++++++ testing/buildbot/waterfalls.pyl | 131 +++++++++++++++++ tools/mb/mb_config.pyl | 25 +++- 6 files changed, 842 insertions(+), 2 deletions(-) commit 5b45617a259ed1ddd64a9217efdfd5aa58044395 Author: Pavel Feldman <pfeldman@chromium.org> Date: Fri Apr 5 01:02:51 2019 +0000 DevTools: move the area screenshot logic from native code into the JS. - This change makes inspector overlay host a bit more generic and routes its messages into the tools. - It moves the screenshot area coordinates handling from native to JS - Fixes a minor screenshot bug. Change-Id: Ic869a8a2d5e357faffb5a4bd5f07e786d6d9d449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546757 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648013} .../renderer/core/inspector/inspect_tool_common.js | 9 ++ .../core/inspector/inspect_tool_highlight.html | 15 +-- .../core/inspector/inspect_tool_paused.html | 8 +- .../core/inspector/inspect_tool_screenshot.html | 97 +++++++++++++++--- .../blink/renderer/core/inspector/inspect_tools.cc | 111 ++++++++++----------- .../blink/renderer/core/inspector/inspect_tools.h | 20 ++-- .../core/inspector/inspector_overlay_agent.cc | 73 +++++++------- .../core/inspector/inspector_overlay_agent.h | 14 ++- .../core/inspector/inspector_overlay_host.cc | 21 ++-- .../core/inspector/inspector_overlay_host.h | 16 ++- .../core/inspector/inspector_overlay_host.idl | 3 +- .../debugger-resume-button-in-overlay.js | 3 + 12 files changed, 222 insertions(+), 168 deletions(-) commit b9102b1ae55fea868434a554f7dc2917b6cb18a5 Author: Martin Kreichgauer <martinkr@google.com> Date: Fri Apr 5 01:02:40 2019 +0000 webauthn: add validation error strings ahead of 75 string freeze I anticipate that we might need them for consistency with the in-request PIN entry UI, so I'm adding them now before the 75 string freeze. Bug: 870892 Change-Id: I9e69b481b8a28a4fc690fb3d5de5e0860e96dc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553808 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#648012} chrome/app/settings_strings.grdp | 12 ++++++++++++ 1 file changed, 12 insertions(+) commit 2cd1186c2f53e3e28a514bf95e4eabacf2ae897e Author: Matt Reynolds <mattreynolds@google.com> Date: Fri Apr 5 00:57:57 2019 +0000 Update Stadia gamepad device ID to release version This CL updates the product ID for the Stadia controller to match the product ID of the release version. (18d1:9400) BUG=943726 Change-Id: I99f40b47835bdbf83107317e0bfac884855070fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548042 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#648011} device/gamepad/gamepad_id_list.cc | 1 + device/gamepad/gamepad_id_list.h | 2 +- device/gamepad/gamepad_standard_mappings_linux.cc | 2 +- device/gamepad/gamepad_standard_mappings_mac.mm | 2 +- device/gamepad/gamepad_standard_mappings_win.cc | 2 +- device/gamepad/hid_haptic_gamepad_base.cc | 2 +- tools/metrics/histograms/enums.xml | 1 + 7 files changed, 7 insertions(+), 5 deletions(-) commit 6e5b10a2837045e8f193f01fcd5e6dd9ae57d591 Author: Randy Rossi <rmrossi@chromium.org> Date: Fri Apr 5 00:57:07 2019 +0000 Fix screen reader crash CastWebContentsImpl was returning instances in the global list of instances (GetAll()) even though the web contents had been nulled out via WebContentsDestroyed observer call. This caused tabs_api to iterate over web contents impl that had no web contents and seg fault. Bug: b/129958157 Test: Manual build cast_shell, turn on screen reader for home hub Change-Id: Ie0f321b200664321c4806afa82600275e4fa5718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553647 Reviewed-by: Sean Topping <seantopping@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#648010} chromecast/browser/cast_web_contents_impl.cc | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) commit 75e794e49c62d5ea87f63cf259180aae29a7072f Author: Jeevan Shikaram <jshikaram@chromium.org> Date: Fri Apr 5 00:56:36 2019 +0000 [App Service] Change ARC uninstall flow to use a dialog. Changed the uninstall flow of an ARC app to use the same function as the launcher. Bug: 949410 Change-Id: I17ba01386cd465458f0adfe75cb51fc5675104ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552393 Reviewed-by: Dominick Ng <dominickn@chromium.org> Reviewed-by: Nigel Tao <nigeltao@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#648009} chrome/browser/apps/app_service/arc_apps.cc | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) commit e78b4f6f791b36723e154a62c6d64a2122572c7b Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Apr 5 00:53:46 2019 +0000 Apply testharness.js to non-pixel web tests from dom/document_fragment This CL removes js-test.js and applies testharness.js from test files in dom/document_fragment. Bug: 936364 Change-Id: I007bfa8fcf9c56512afb5ad71cfca07dcc3eee58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552959 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#648008} .../document-fragment-constructor-expected.txt | 16 ----- .../document-fragment-constructor.html | 25 ++++---- .../get-element-by-id-expected.txt | 14 ----- .../dom/document_fragment/get-element-by-id.html | 19 +++--- .../parent-node-interface-expected.txt | 38 ----------- .../document_fragment/parent-node-interface.html | 73 +++++++++++----------- ...ling-rules-under-document-fragment-expected.txt | 10 --- .../sibling-rules-under-document-fragment.html | 11 ++-- 8 files changed, 64 insertions(+), 142 deletions(-) commit cf094cc50177c51f78fddf56de193fcf888a741e Author: Nektarios Paisios <nektar@chromium.org> Date: Fri Apr 5 00:53:08 2019 +0000 Garbage collected objects in non garbage collected containers should be marked persistent R=dmazzoni@chromium.org Change-Id: Ic1b2affe8428d4f73522be6ae7e88f7e66fcf22c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553500 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#648007} .../renderer/modules/accessibility/accessibility_object_model_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b1a9b9ada5d572b23356ae6fc86fd5b7ad57de76 Author: Maggie Cai <mxcai@chromium.org> Date: Fri Apr 5 00:52:36 2019 +0000 Don't show intent picker bubble automatically in non-chromeos platforms. When we navigate to a site, if there are apps installed, intent picker bubble will show up automatically. This CL updates to only do this in chromeos platform. BUG=939205 Change-Id: I38de400cd8f8c9ac2024efa2990a879d11a0cbf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530278 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by: David Jacobo <djacobo@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#648006} .../apps/intent_helper/apps_navigation_throttle.cc | 48 +++++++++++++++++----- .../apps/intent_helper/apps_navigation_throttle.h | 21 ++++++++-- .../chromeos_apps_navigation_throttle.cc | 31 +++++++------- .../chromeos_apps_navigation_throttle.h | 13 +++--- .../views/intent_picker_bubble_view_browsertest.cc | 17 +++++++- 5 files changed, 96 insertions(+), 34 deletions(-) commit 2e37ace86d022e77cd40dbb8b6497b2310c59a6e Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Fri Apr 5 00:51:48 2019 +0000 CORB allowlist additions - 2019-04-03. Bug: 949462 Bug: 949483 Change-Id: I4de33a40a52abc9c82c598bec7829793248aaeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554114 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#648005} extensions/browser/url_loader_factory_manager.cc | 2 ++ 1 file changed, 2 insertions(+) commit f2be0db4552074ad11c49ccf819aebd6fb92521b Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Apr 5 00:50:45 2019 +0000 Apply testharness.js to non-pixel web tests from dom/document_type This CL removes js-test.js and applies testharness.js from test files in dom/document_type. Bug: 936364 Change-Id: If681defc1d5e07d3998a6fe22903ffe8ad38a2d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553039 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#648004} .../dom/document_type/clone-node-expected.txt | 25 ------------- .../web_tests/dom/document_type/clone-node.html | 41 +++++++++++----------- .../next-element-sibling-expected.txt | 9 ----- .../dom/document_type/next-element-sibling.html | 11 +++--- .../previous-element-sibling-expected.txt | 9 ----- .../document_type/previous-element-sibling.html | 11 +++--- .../dom/document_type/remove-expected.txt | 11 ------ .../blink/web_tests/dom/document_type/remove.html | 15 ++++---- 8 files changed, 37 insertions(+), 95 deletions(-) commit 364de85cce3e42dfc60f52aab0d60ddf8fea8d81 Author: Karan Bhatia <karandeepb@chromium.org> Date: Fri Apr 5 00:49:29 2019 +0000 DNR: Add metrics for the result of reading dynamic JSON rules from disk. Add a new histogram Extensions.DeclarativeNetRequest.ReadDynamicRulesJSONStatus to log the result of reading dynamic JSON rules from disk. This should help reflect the various ways in reading dynamic rules from disk can fail. BUG=930961 Change-Id: I668d6efb444bc5e3ee6f7f7200491bd96df7c4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548332 Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#648003} .../api/declarative_net_request/constants.cc | 2 ++ .../api/declarative_net_request/constants.h | 1 + .../declarative_net_request_api.cc | 1 + .../file_sequence_helper.cc | 2 ++ .../file_sequence_helper_unittest.cc | 31 ++++++++++++++++++++-- .../api/declarative_net_request/ruleset_source.h | 16 +++++++---- .../browser/api/declarative_net_request/utils.cc | 6 +++++ .../browser/api/declarative_net_request/utils.h | 4 +++ tools/metrics/histograms/enums.xml | 8 ++++++ tools/metrics/histograms/histograms.xml | 12 +++++++++ 10 files changed, 76 insertions(+), 7 deletions(-) commit a29a7a88ad56147d3e894546fc9214b3c2d42d80 Author: Toni Barzic <tbarzic@chromium.org> Date: Fri Apr 5 00:47:06 2019 +0000 Fix welcome screen keyboard dropdown This fixes an issue where the keyboard dropdown element kept updating excesively, causing UI jank. The behavior is combination of two issues: * oobe_i18n_dropdown.js adding select event listeners on every item list change * welcome_screen requesting input method update on every on every request to set input method, even if the input method ID has not changed This meant that on each user interaction with the select element, welcome screen UI would process n select change events, each sending a message to welcome screen handler. And that message would cause input method update, causing the dropdown list to get updated, and another select-item event listener getting added to the dropdown. (and thus the number of unnecessary dropdown updates would grow exponentially with every user interaction). BUG=939710 Change-Id: I8ff7a9558cc622a9dd19e62fcacf867b3a7757bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554143 Reviewed-by: Alexander Alekseev <alemate@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#648002} chrome/browser/chromeos/login/screens/welcome_screen.cc | 4 ++++ chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js | 8 +++++++- 2 files changed, 11 insertions(+), 1 deletion(-) commit 6848a053e9c81511292e05106e111044db9c6af3 Author: Shakti Sahu <shaktisahu@chromium.org> Date: Fri Apr 5 00:46:21 2019 +0000 Night mode chip colors Updated the chip background and text colors for night mode. UX : https://drive.google.com/corp/drive/folders/1inbpgwbojsRrPkwmupS-VI5-LVSa3-7- Bug: 945015 Change-Id: If7437cad1b0ad36c0b49b913e27fe8dedf2eda14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553656 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#648001} .../browser/download/home/filter/chips/ChipsCoordinator.java | 1 - ui/android/java/res/color/chip_background_color.xml | 9 ++++----- ui/android/java/res/color/chip_text_color.xml | 4 ++-- ui/android/java/res/values/color_palette.xml | 2 ++ ui/android/java/res/values/colors.xml | 9 +++++++-- ui/android/java/res_night/values-night/colors.xml | 5 +++++ ui/android/java/res_night/values-night/dimens.xml | 11 +++++++++++ 7 files changed, 31 insertions(+), 10 deletions(-) commit 087fc9644902c0985227136fc87de271e4f4aa90 Author: Julie Jeongeun Kim <jkim@igalia.com> Date: Fri Apr 5 00:40:39 2019 +0000 Apply testharness.js to non-pixel web tests from dom/comment This CL removes js-test.js and applies testharness.js from test files in dom/comment. Bug: 936364 Change-Id: I7d639be6094fa7278ab6bd6e1c91ff21c8aa6dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552762 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#648000} .../dom/comment/comment-constructor-expected.txt | 20 ------------- .../web_tests/dom/comment/comment-constructor.html | 33 +++++++++++----------- .../web_tests/dom/comment/remove-expected.txt | 11 -------- .../blink/web_tests/dom/comment/remove.html | 15 +++++----- 4 files changed, 23 insertions(+), 56 deletions(-) commit 288854e0103e75ef8ba0f835e01d0e9f1005f81b Author: Joel Hockey <joelhockey@chromium.org> Date: Fri Apr 5 00:40:12 2019 +0000 FilesApp: Add crostini multi-VM support Most FMP crostini-related functions now take vmName as an extra param, and use the default 'termina' value. Other VM names can be used in future. Bug: 946273 Change-Id: I7d8cb9e2e1586290bf64aab05c26184c3fff68cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548973 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#647999} .../extensions/file_manager/event_router.cc | 7 +- .../extensions/file_manager/event_router.h | 1 + .../file_manager/event_router_unittest.cc | 6 +- .../extensions/file_manager/private_api_misc.cc | 8 +- .../common/extensions/api/file_manager_private.idl | 21 ++- .../api/file_manager_private_internal.idl | 11 +- .../file_manager_private_custom_bindings.js | 13 +- .../api_test/file_browser/crostini_test/test.js | 15 +- .../externs/file_manager_private.js | 13 +- ui/file_manager/externs/background/crostini.js | 20 ++- .../file_manager/background/js/crostini.js | 78 +++++++--- .../background/js/crostini_unittest.js | 162 +++++++++++---------- .../file_manager/foreground/js/constants.js | 6 + .../file_manager/foreground/js/file_manager.js | 5 +- .../foreground/js/file_manager_commands.js | 14 +- .../file_manager/foreground/js/file_tasks.js | 12 +- .../foreground/js/file_tasks_unittest.js | 6 +- .../file_manager/test/crostini_share.js | 16 +- .../file_manager/test/crostini_tasks.js | 4 +- .../js/chrome_file_manager_private_test_impl.js | 6 +- 20 files changed, 258 insertions(+), 166 deletions(-) commit 62c3e5a35e19a8a81a95517897fdcfbe553ae6e1 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 00:26:29 2019 +0000 Roll src/third_party/depot_tools 9f74913e5162..dbc721d65f0d (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9f74913e5162..dbc721d65f0d git log 9f74913e5162..dbc721d65f0d --date=short --no-merges --format='%ad %ae %s' 2019-04-04 dschuff@chromium.org Add gclient recipe_modules config for emscripten_releases LUCI project Created with: gclient setdep -r src/third_party/depot_tools@dbc721d65f0d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I729b9447b1319315ed376a8a2613e06dff391c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553787 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647998} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 51c3e7139282dad65aad09d7b2f72a9fc14e8e38 Author: cjamcl@google.com <cjamcl@google.com> Date: Fri Apr 5 00:26:25 2019 +0000 [Devtools] Typo fix in protocol json Change-Id: Id333e490263dc017ae2018c53d08de644fc8e222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540146 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#647997} third_party/blink/renderer/core/inspector/browser_protocol-1.3.json | 2 +- third_party/blink/renderer/core/inspector/browser_protocol.pdl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit 268a4de9045ff23f15b299d2122584be21bddd3c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 00:25:25 2019 +0000 Roll src/third_party/perfetto e382e0ed7613..3c836b671503 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/e382e0ed7613..3c836b671503 git log e382e0ed7613..3c836b671503 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 treehugger-gerrit@google.com Merge "--help takes no argument." Created with: gclient setdep -r src/third_party/perfetto@3c836b671503 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib75a41fda3b9d4400aa07b9098b93c10f870b9cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553962 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647996} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit a986018efb9f3e5ff2d8fbe40675cb76af1cda3c Author: Marcin Wiącek <marcin@mwiacek.com> Date: Fri Apr 5 00:25:21 2019 +0000 Video code optimization inside photo_capabilities Before CL: code has got various methods for getting and setting int, bool, double or other parameters. After CL: values are saved in tables, which are indexed by enums. Change-Id: Ibde91d176be59528ae8c3ccbf80a436b912b0f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509475 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#647995} .../src/org/chromium/media/PhotoCapabilities.java | 628 ++++----------------- .../src/org/chromium/media/VideoCaptureCamera.java | 78 ++- .../org/chromium/media/VideoCaptureCamera2.java | 120 ++-- media/capture/video/android/photo_capabilities.cc | 289 ++-------- media/capture/video/android/photo_capabilities.h | 129 +++-- .../video/android/video_capture_device_android.cc | 140 +++-- 6 files changed, 433 insertions(+), 951 deletions(-) commit 6a7745fd5b928351dae39f56f57f943e5acd45f5 Author: Hanfeng Zhu <hanfeng@google.com> Date: Fri Apr 5 00:23:00 2019 +0000 Disable signin promos for special users. Add a new method "isSignInPromoAllowed()" in SigninPromoController to check whether promos are allowed. The reason is that in some regions signing in may be problematic, thus promos should be suppressed. Bug: 948983 Change-Id: I389b1d2d693a0bcb63571e78991f7287f734672f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548875 Commit-Queue: Hanfeng Zhu <hanfeng@google.com> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#647994} .../browser/bookmarks/BookmarkPromoHeader.java | 4 +-- .../browser/firstrun/FirstRunFlowSequencer.java | 7 ++++ .../chrome/browser/ntp/RecentTabsManager.java | 3 +- .../chrome/browser/ntp/cards/SignInPromo.java | 17 +++++---- .../browser/preferences/SignInPreference.java | 3 +- .../browser/signin/SigninPromoController.java | 10 +++++- .../firstrun/FirstRunFlowSequencerTest.java | 41 ++++++++++++++++++++++ 7 files changed, 73 insertions(+), 12 deletions(-) commit 683b4bcc4e3f5fe6fcc2bcea4944d30b163eebfd Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Fri Apr 5 00:22:13 2019 +0000 Roll Fuchsia SDK from 891710789886 to 891707580481 The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib1d477e68ea9e382607170879aad91778540c106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553785 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647993} build/fuchsia/linux.sdk.sha1 | 2 +- build/fuchsia/mac.sdk.sha1 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) commit e05071635b90616fd3a3bf74bf528bb6507ef172 Author: Shu Chen <shuchen@chromium.org> Date: Fri Apr 5 00:13:55 2019 +0000 Refactoring ui::InputMethod interface to support DispatchKeyEvent with a callback. This is to make WindowTreeClient can dispatch key events in a standard way, so that it can hook up with InputMethodChromeOS later. Bug: 937167 Change-Id: If8b8f506402c230e9b0fcf062f6a5b9c99dd5072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545722 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#647992} .../ime_driver/input_method_bridge_chromeos.cc | 3 +- ui/aura/mus/input_method_mus.cc | 49 +++++++++++++++------- ui/aura/mus/input_method_mus.h | 16 +++++-- ui/aura/mus/window_tree_client.cc | 14 ++++++- ui/base/ime/chromeos/input_method_chromeos.cc | 13 +++++- ui/base/ime/chromeos/input_method_chromeos.h | 15 +++++-- .../ime/chromeos/input_method_chromeos_unittest.cc | 27 ++++++------ ui/base/ime/dummy_input_method.cc | 4 ++ ui/base/ime/dummy_input_method.h | 1 + ui/base/ime/input_method.h | 17 ++++++++ ui/base/ime/input_method_base.cc | 4 ++ ui/base/ime/input_method_base.h | 1 + ui/base/ime/mock_input_method.cc | 4 ++ ui/base/ime/mock_input_method.h | 1 + 14 files changed, 128 insertions(+), 41 deletions(-) commit f562370074d92739b58fafb9ffd2c7b6630ba2da Author: Robbie McElrath <rmcelrath@chromium.org> Date: Fri Apr 5 00:13:51 2019 +0000 Reland "Reland "Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient."" This is a reland of 5db69e59c9c38230e5b2223de0de0e42998a5763 with a flaky test fixed. The original version of this CL added a unit test that recently started flaking due to crrev.com/c/1538608. That CL made it so the DnsConfigService was created on the UI thread, but would run and be torn down on its own SequencedTaskRunner. However, there are a couple SerialWorkers owned by the DnsConfigService that make sure they're destroyed on the same sequence they're created on, which isn't the correct sequence anymore. This CL makes the DnsConfigService be created on its SequencedTaskRunner so that when it gets destroyed, everything will happen on the correct sequence. See crrev.com/c/1336066 for related information. Original change's description: > Reland "Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient." > > This is a reland of d0310b0c0221e3f44da813443ca11c9869620cb4 > > Original change's description: > > Use NetworkChangeNotifier to initialize the connection type in NetworkChangeManagerClient. > > > > Bug: 942782 > > Change-Id: Ia2971348153d54cd87a48e8045efc9d31948db8a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529354 > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#641801} > > Bug: 942782 > Change-Id: Ie2331fe506b7b8839d9ae998bb3fd338747e0b24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529664 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#642597} Bug: 942782 Change-Id: I72aec3991a421ee29dddf05334eb87e3b972484a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548355 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by: Paul Jensen <pauljensen@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647991} .../chromeos/network_change_manager_client.cc | 5 +-- .../chromeos/network_change_manager_client.h | 2 ++ .../network_change_manager_client_unittest.cc | 38 ++++++++++++++++++++++ net/base/network_change_notifier.cc | 2 +- net/base/network_change_notifier_posix.cc | 21 +++++++----- net/base/network_change_notifier_posix.h | 12 ++++--- 6 files changed, 63 insertions(+), 17 deletions(-) commit 566613568b38f2509a5f34aaf95dee7838cd4cca Author: Frank Tang <ftang@chromium.org> Date: Fri Apr 5 00:01:06 2019 +0000 Roll ICU to ICU 64.1 + Chromium patches See https://chromium-review.googlesource.com/c/chromium/deps/icu/+/1552155 for changes. ICU data size increased by 40-50 kBs depending on platforms, but it's almost offset by a recent v8 change that utilizes ICU (https://chromium-review.googlesource.com/c/v8/v8/+/1478710) and the net size change of two CLs (this and v8 CL https://chromium-review.googlesource.com/c/v8/v8/+/1536559 ) is 2.4 kB (android), 8.4kB (iOS), and 20.4 kB (desktop). Binary-Size: ICU data size increase is offset by a recent v8 change. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Test: *_unittests, layout_tests, webkit* tests Bug: chromium:943348 Change-Id: I37b2cdecfa25a49335081b983fe8c208e33754f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536613 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647990} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ffb9f231a67d7fb6b18144acb6356f50cb56ab35 Author: Ella Ge <eirage@chromium.org> Date: Thu Apr 4 23:57:40 2019 +0000 Make AverageLag calculation keeps track of accumulated delta Previous we calculate the Lag area per events and seperate into two reports by the 1 second gap. However that design does not work well with scroll prediction. This CL changes following: 1. Rewrites the AverageLag calculation to compute the area between the accumulated_event_delta_(actual finger absolute scroll position) and the rendered_accumulated_delta_ (rendered absolute scroll position). Detail see the explainer doc: https://docs.google.com/document/d/1e8NuzPblIv2B9bz01oSj40rmlse7_PHq5oFS3lqz6N4/ 2. Wrap the AverageLag into a AverageLagTracker class, so fields only for AverageLag wouldn't be access by other part of LatencyTracker. And also add unit tests. 3. Because the latency_info.scroll_update_delta is initialize at browser, where the event delta is in DIP coordinate space. All events are scale to physical pixel when route to renderer, so we also need to scale the latency_info together with the events. Bug: 946212 Change-Id: Iec2b3fdbd866efe71fe6e0066cee831e30316261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542222 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#647989} .../renderer_host/input/input_router_impl.cc | 22 +- .../render_widget_host_latency_tracker_unittest.cc | 111 --------- ui/latency/BUILD.gn | 3 + ui/latency/average_lag_tracker.cc | 159 +++++++++++++ ui/latency/average_lag_tracker.h | 78 +++++++ ui/latency/average_lag_tracker_unittest.cc | 248 +++++++++++++++++++++ ui/latency/latency_tracker.cc | 130 +---------- ui/latency/latency_tracker.h | 38 +--- 8 files changed, 508 insertions(+), 281 deletions(-) commit 3f340fe033bd3487ed78b5ef10f851b53b848097 Author: Kent Tamura <tkent@chromium.org> Date: Thu Apr 4 23:52:46 2019 +0000 Remove tkent@ from core/dom and blink_perf.dom owners tkent@ is not responsible for DOM any longer. Change-Id: I710d2effaf13f75ed0028549fa010be886c6ff1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552201 Reviewed-by: Annie Sullivan <sullivan@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#647988} third_party/blink/renderer/core/dom/OWNERS | 1 - tools/perf/benchmark.csv | 2 +- tools/perf/benchmarks/blink_perf.py | 3 +-- 3 files changed, 2 insertions(+), 4 deletions(-) commit 9229314a9c1ed889e62078f1b8a20b25581359e5 Author: Eugene But <eugenebut@google.com> Date: Thu Apr 4 23:49:53 2019 +0000 Fix WebStateTest.RestoreLargeSession on device. Call SetKeepRenderProcessAlive on test web state to prevent web process suspension. Bug: 946898 Change-Id: I494c3cead7a90a83e2f9e4a4cd397ebd42928bc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554111 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#647987} ios/web/web_state/web_state_unittest.mm | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit d80cef3a2205fbb2d3d8935076fb0dfa4622af79 Author: Shimi Zhang <ctzsm@chromium.org> Date: Thu Apr 4 23:47:02 2019 +0000 Revert "Re-enabling tests that rely on IsAfterStartup." This reverts commit 75af59bc1d41c559cea70dd5487e7897ba9154a3. Reason for revert: These tests are still flaky. Original change's description: > Re-enabling tests that rely on IsAfterStartup. > > These tests were disabled due to a couple of changes to the code > that started causing them to be flaky. This was due to them using > the AfterStartup task queue. To remedy this, a function was added, > "SetBrowserStartupIsCompleteForTesting" was added to allow tasks > entered into that queue to not be delayed when testing. The tests > themselves are reenabled here, and the function is called in the > appropriate place prior to the ruleset being loaded. > > Bug: 899903 > Change-Id: I5a61a6b8045433ec9b4d816c0437c6d5ba89951f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552106 > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647800} TBR=thakis@chromium.org,csharrison@chromium.org,eseckler@chromium.org,ericrobinson@chromium.org Change-Id: Ic91dac1b3611243f4a36f73da1d74f9f861e88e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 899903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553607 Reviewed-by: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#647986} .../src/org/chromium/chrome/browser/SubresourceFilterTest.java | 6 ++++++ .../android/subresource_filter/test_subresource_filter_publisher.cc | 4 ---- 2 files changed, 6 insertions(+), 4 deletions(-) commit 0a25dcdee8f2c3cfd95a16fe3a1ae76a17303e4a Author: Charlene Yan <cyan@chromium.org> Date: Thu Apr 4 23:45:41 2019 +0000 Make dialogs not draggable (Widgets with MODAL_TYPE_NONE remain draggable). This change makes the title area of a dialog act as the client. Also removed code so system menu does not appear on dialogs. This makes more sense since the system dialog has properties such as move (which is now illegal, also it doesn't work), and resize (illegal), and close with hints of using Alt+F4 (Alt+F4 does not close dialogs). Bug: 930782 Change-Id: I0956b85df2c3059af7b38b63ccf8774ccd150158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536198 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#647985} .../bubble/bubble_dialog_delegate_view_unittest.cc | 2 +- ui/views/bubble/bubble_frame_view.cc | 23 +++--- ui/views/window/dialog_delegate_unittest.cc | 81 +++++++++++++++------- 3 files changed, 68 insertions(+), 38 deletions(-) commit a4068e82cabe78398ab59d6b9cc38cf032446461 Author: Mitsuru Oshima <oshima@chromium.org> Date: Thu Apr 4 23:45:23 2019 +0000 Do not update the shelf bounds during overview animation This leads to workspace change, which in turns tries to update the window bounds based on wrong workarea. Bug: 947343 Test: covered by unittets Change-Id: Iddc5cf0fd822257666a445576fee9af2a1eecc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553460 Reviewed-by: Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#647984} ash/shelf/shelf_layout_manager.cc | 4 ++ ash/shelf/shelf_layout_manager_unittest.cc | 87 ++++++++++++++++++++++++++---- 2 files changed, 82 insertions(+), 9 deletions(-) commit 1e0b0b6ab58f277e4ecc681b4cee65bd956fcc50 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 23:43:06 2019 +0000 Roll src/third_party/swiftshader e6ab01f42ade..0e3d328ac338 (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/e6ab01f42ade..0e3d328ac338 git log e6ab01f42ade..0e3d328ac338 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 bclayton@google.com SpirvRoutine: Verify create functions are called once per id Created with: gclient setdep -r src/third_party/swiftshader@0e3d328ac338 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@chromium.org Change-Id: I3783ea843a28355ae8e072170bdf611186026a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553922 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647983} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 7ac75ae5c76dbcf73f87f2f29da7cc314ceba45b Author: Marcin Wiącek <marcin@mwiacek.com> Date: Thu Apr 4 23:41:47 2019 +0000 Improve code consistency/readability inside ModelType enum & @IntDef Current: 1. various enum in C++ have different naming for last entry indicating number of entries (and this is not consistent in codebase). 2. last entry is moved with java_cpp_enum to Java and included inside @IntDef (is added as one of allowed values which is logic error in situation when it just indicates number of entries). This concrete CL is improving ModelType by changing last entry name to NUM_ENTRIES (java_cpp_enum treats it in special way and is putting it into @IntDef, but doesn't define as correct @IntDef value; This can decrease amount of logic errors and is consistent with native Java @IntDef definitions in Chrome) BUG=919666 TBR=markusheintz@chromium.org Change-Id: I8cbe2e3937a6df2672098c5900d3cd7c903b9fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545925 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#647982} .../sync/profile_sync_service_factory_unittest.cc | 2 +- .../core/browser/sync/password_syncable_service.cc | 2 +- components/sync/base/model_type.cc | 25 +++++++++++----------- components/sync/base/model_type.h | 4 ++-- components/sync/base/model_type_unittest.cc | 10 ++++----- components/sync/base/sync_prefs.cc | 2 +- .../sync/driver/async_directory_type_controller.cc | 2 +- components/sync/driver/backend_migrator.cc | 2 +- .../sync/driver/backend_migrator_unittest.cc | 2 +- components/sync/driver/data_type_manager_impl.cc | 2 +- .../sync/driver/directory_data_type_controller.cc | 5 +++-- .../sync/driver/frontend_data_type_controller.cc | 2 +- .../sync/driver/glue/sync_backend_host_core.cc | 10 ++++----- .../sync/driver/model_association_manager.cc | 4 ++-- components/sync/driver/model_type_controller.cc | 4 ++-- components/sync/driver/profile_sync_service.cc | 2 +- components/sync/driver/startup_controller.cc | 2 +- components/sync/driver/test_sync_service.cc | 4 ++-- .../sync/engine/cycle/sync_cycle_snapshot.cc | 6 +++--- .../engine/cycle/sync_cycle_snapshot_unittest.cc | 17 ++++++++------- .../sync/engine/sync_backend_registrar_unittest.cc | 2 +- components/sync/engine/sync_status.cc | 4 ++-- components/sync/engine_impl/cycle/sync_cycle.cc | 6 +++--- .../sync/engine_impl/debug_info_event_listener.h | 2 +- .../js_mutation_event_observer_unittest.cc | 14 ++++++------ ...js_sync_encryption_handler_observer_unittest.cc | 2 +- .../js_sync_manager_observer_unittest.cc | 15 +++++++------ components/sync/engine_impl/model_type_registry.cc | 4 ++-- components/sync/engine_impl/sync_manager_impl.cc | 6 +++--- components/sync/engine_impl/syncer_proto_util.cc | 2 +- .../sync/model/data_type_error_handler_impl.cc | 2 +- .../model_impl/blocking_model_type_store_impl.cc | 2 +- .../client_tag_based_model_type_processor.cc | 4 ++-- .../protocol/proto_value_conversions_unittest.cc | 2 +- components/sync/protocol/proto_visitors.h | 2 +- components/sync/syncable/directory.cc | 6 +++--- components/sync/syncable/directory.h | 8 +++---- components/sync/syncable/nigori_util.cc | 6 +++--- components/sync/syncable/parent_child_index.cc | 4 ++-- .../sync_bookmarks/bookmark_model_associator.cc | 7 +++--- .../sync/profile_sync_service_factory_unittest.cc | 2 +- 41 files changed, 108 insertions(+), 103 deletions(-) commit 289c3c2cf0f99e53550a8a112e3c51f402ef068c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 23:38:55 2019 +0000 Roll src/third_party/chromite f2ceeca98c82..c012fdb54ccb (2 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/f2ceeca98c82..c012fdb54ccb git log f2ceeca98c82..c012fdb54ccb --date=short --no-merges --format='%ad %ae %s' 2019-04-04 zamorzaev@chromium.org Reland "chromeos_config: Enable Skylab for CTS qual tests" 2019-04-04 ehislen@google.com Adding dustbuster's wristpin board to buildbot. Created with: gclient setdep -r src/third_party/chromite@c012fdb54ccb The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: I62edf081cab6b1da32b9958965b19165f2cf849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553961 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647981} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3f2680aa9b69199ed76962d6bc522f80e817c333 Author: Xing Liu <xingliu@chromium.org> Date: Thu Apr 4 23:38:39 2019 +0000 Notification scheduler: Do not sort impression with std::map. This CL changes the container of impression data to plain deque. Using std::map to sort may erase duplicate element in the map. Although it might not happen in real world. Bug: 949336 Change-Id: Ie3683961eba4ad84a34e9f9fc4c6a4b684276b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552379 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#647980} .../notifications/scheduler/display_decider.cc | 4 +--- .../scheduler/impression_history_tracker.cc | 2 +- .../scheduler/impression_history_tracker_unittest.cc | 20 +++++++++++++++----- .../notifications/scheduler/impression_types.cc | 3 +-- .../notifications/scheduler/impression_types.h | 3 ++- .../notifications/scheduler/test/test_utils.cc | 6 +++--- 6 files changed, 23 insertions(+), 15 deletions(-) commit f93bf42468f108274e3ea97853679047465a8412 Author: David Bokan <bokan@chromium.org> Date: Thu Apr 4 23:35:45 2019 +0000 WebView checks outer viewport user_input_scrollable The linked bug was occuring because WebView would try to scroll using the SetSynchronousInputHandlerRootScrollOffset API. This method has some bespoke logic for distributing the scroll to the viewport layers, including incorrect handling of the user_input_scrollable bit: it would check if the visual viewport is scrollable but not the outer viewport. This means it would not respect overflow: hidden on a the layout viewport. In this CL I remove the special path for the SynchronousInputHandler in LayerTreeImpl::DistributeRootScrollOffset and use a somewhat modified Viewport::ScrollBy, adding the user_input_scrollable checks there. This does change the order the scroll is applied in to inner first. Everywhere else in Chrome we scroll inner first. The DistributeRootScrollOffset method was added way back in: https://codereview.chromium.org/1038173002 and explicitly mentioned scrolling outer first due to the first scrolled layer updating the root scroll delegate; however, we seem to no longer have that logic and I've tried the repro in the linked bug to confirm this CL doesn't break it. Bug: 925795 Change-Id: I8a2198b78fbfacc258591fa8efba9d16529004e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546583 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647979} cc/layers/viewport.cc | 11 +-- cc/layers/viewport.h | 4 +- cc/trees/layer_tree_host_impl.cc | 20 +++- cc/trees/layer_tree_host_impl_unittest.cc | 151 +++++++++++++++++++++++------- cc/trees/layer_tree_impl.cc | 43 --------- cc/trees/layer_tree_impl.h | 4 - 6 files changed, 137 insertions(+), 96 deletions(-) commit 6ad59ee2d37a44e52ff628e95aa2d9e5bf7a60eb Author: Xing Liu <xingliu@chromium.org> Date: Thu Apr 4 23:34:01 2019 +0000 Notification scheduler: Pass dependencies into scheduler internal code. This CL adds the pipeline to pass in dependencies into notification scheduler internal code. Also, we add the core glue layer notification_scheduler.h, which will owns subsystems and do actual work. TBR=peter@chromium.org Bug: 930968 Change-Id: I63a733736ea429147057f99ac0a275eaaf8f69f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548547 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#647978} .../notification_schedule_service_factory.cc | 14 +++++-- chrome/browser/notifications/scheduler/BUILD.gn | 22 ++++++++-- .../notification_schedule_service_impl.cc | 10 +++-- .../scheduler/notification_schedule_service_impl.h | 8 +++- .../scheduler/notification_scheduler.cc | 47 ++++++++++++++++++++++ .../scheduler/notification_scheduler.h | 38 +++++++++++++++++ .../scheduler/notification_scheduler_context.cc | 12 +++--- .../scheduler/notification_scheduler_context.h | 13 +++++- .../scheduler/schedule_service_factory_helper.cc | 24 +++++++++++ .../scheduler/schedule_service_factory_helper.h | 27 +++++++++++++ 10 files changed, 194 insertions(+), 21 deletions(-) commit a66cc0fc49807e77f909c6a2ae888299d90dfa85 Author: Bailey Berro <baileyberro@chromium.org> Date: Thu Apr 4 23:33:18 2019 +0000 Introduce reconfigureCupsPrinter method - addCupsPrinter was being called in two places, to add a manually configured printer and to reconfigure and edited printer. - HandleAddCupsPrinter determined whether this was an edit or and add based on whether or not the Printer had an id, but printer always has and id so: 1. don't rely on that as an indication of add vs edit 2. enforce that there is always an id. - Also, piggyback a small correction to a log. Bug: 949086 Change-Id: I684149ea2c796a9b6b995f317170264096c8b0a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551080 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Sean Kau <skau@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647977} .../printing_page/cups_edit_printer_dialog.js | 4 +- .../printing_page/cups_printers_browser_proxy.js | 10 +++++ .../settings/chromeos/cups_printers_handler.cc | 52 +++++++++++++++------- .../settings/chromeos/cups_printers_handler.h | 7 ++- .../data/webui/settings/cups_printer_page_tests.js | 8 +++- 5 files changed, 60 insertions(+), 21 deletions(-) commit a5fe52bd38de9b7c2922e7d79464e1d8d957ae25 Author: Dana Fried <dfried@chromium.org> Date: Thu Apr 4 23:32:54 2019 +0000 Hover cards that are fading out shouldn't be re-shown on page update. Now we take whether the tab is fading out into our decision to refresh. Bug: 910739 Change-Id: Ic83809f6c0c83757ebb248c062911985324bad23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554126 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#647976} chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.cc | 4 ++++ chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h | 2 ++ chrome/browser/ui/views/tabs/tab_strip.cc | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) commit bd9fce0f961fa30b5150b3ebbdefd939e8baf43c Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Apr 4 23:32:35 2019 +0000 Revert "Enable SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations" This reverts commit 92e619b781b3f9861b43f94f04d3c73b4788798e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 647820 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTJlNjE5Yjc4MWIzZjk4NjFiNDNmOTRmMDRkM2M3M2I0Nzg4Nzk4ZQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/11742 Sample Failed Step: content_browsertests on (none) GPU on Mac on Mac-10.13.6 Sample Flaky Test: SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations Original change's description: > Enable SitePerProcessAccessibilityBrowserTest.TwoCrossSiteNavigations > > I can't reproduce any flakiness. > > TBR=aboxhall@chromium.org > Bug: 835455 > > Change-Id: Ib8fadd7af546a07625e75d02efec1df6c472964d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541673 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647820} Change-Id: I960f1004d8e387dfdd80df5531d3165097513b53 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 835455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553606 Cr-Commit-Position: refs/heads/master@{#647975} .../accessibility/site_per_process_accessibility_browsertest.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit e075ec975d8a6f99e909948daaf4570f3344fc41 Author: Jazz Xu <jazzhsu@chromium.org> Date: Thu Apr 4 23:14:50 2019 +0000 [Media Controls] bottom progress UI Progress bar UI for touchless device. Bug: 942153 Change-Id: I572585e03fd5eae7ead67581002b70ba3d39a84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549564 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#647974} .../blink/renderer/modules/media_controls/BUILD.gn | 4 + .../elements/media_control_timeline_element.cc | 30 ++----- .../media_controls/media_controls_shared_helper.cc | 55 +++++++++++++ .../media_controls/media_controls_shared_helper.h | 25 ++++++ .../elements/media_controls_touchless_element.cc | 4 + .../elements/media_controls_touchless_element.h | 4 + .../media_controls_touchless_timeline_element.cc | 95 ++++++++++++++++++++++ .../media_controls_touchless_timeline_element.h | 47 +++++++++++ .../touchless/media_controls_touchless_impl.cc | 4 + .../touchless/media_controls_touchless_impl.h | 1 + .../media_controls_touchless_impl_test.cc | 49 ++++++++++- ...edia_controls_touchless_media_event_listener.cc | 6 ++ ...trols_touchless_media_event_listener_observer.h | 1 + .../touchless/resources/mediaControlsTouchless.css | 20 +++++ 14 files changed, 321 insertions(+), 24 deletions(-) commit 6b3237c84c305e950b7e92502617336a2a6145d1 Author: Vladimir Levin <vmpstr@chromium.org> Date: Thu Apr 4 23:12:15 2019 +0000 DL: Rename DisplayLockCommitting invalidation reason to just DisplayLock. This patch renames the invalidation reason since we're using it in more cases than just commit. R=chrishtr@chromium.org, rakina@chromium.org Bug: 882663 Change-Id: I14245a842d81dde45bed28a86ff7d3944c620334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551823 Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#647973} .../blink/renderer/core/display_lock/display_lock_context.cc | 8 +++----- .../blink/renderer/core/inspector/inspector_trace_events.cc | 2 +- .../blink/renderer/core/inspector/inspector_trace_events.h | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) commit cef97b945609619d937da359b0ccb36c0ef39494 Author: Rayan Kanso <rayankans@chromium.org> Date: Thu Apr 4 23:12:11 2019 +0000 Update the DevTools Background Services UI. As per the UX meeting, the following changes have been made: - Toolbar refresh/clear were removed and delete was renamed to clear. - Instead of Popovers a container at the bottom will show the metadata. Screenshots: https://bugs.chromium.org/p/chromium/issues/detail?id=942174#c10 Bug: 942174 Change-Id: Ibb99ade117666367903c739ed5f3acee1f550c18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551661 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#647972} .../front_end/resources/BackgroundServiceView.js | 132 +++++++++------------ .../front_end/resources/backgroundServiceView.css | 17 +-- 2 files changed, 59 insertions(+), 90 deletions(-) commit 69a95a8c82ea1ab41507ecb3e41629de33634cc8 Author: Robert Sesek <rsesek@chromium.org> Date: Thu Apr 4 23:08:13 2019 +0000 Further reduce scope of ChannelMac DumpWithoutCrashing. This narrows the DumpWithoutCrashing to just failures of TryDispatchMessage(). Off a hunch, a crash key is set in GetReadPlatformHandles() to determine if that's where the failure is occurring. Bug: 946372 Change-Id: Ie249ae13486e4646d6d54f6fc7899085da420bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554140 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#647971} mojo/core/channel_mac.cc | 41 ++++++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 13 deletions(-) commit 903490edaa2084fe6a266febcecb373927cffb4b Author: Takumi Fujimoto <takumif@chromium.org> Date: Thu Apr 4 23:06:03 2019 +0000 [Cast dialog] Anchor dialog to browser window if it exists On Mac, there is an issue where if the Cast dialog isn't anchored to a view, it loses focus immediately after opening, causing itself to close. This change [1] made the dialog not anchored when centered, even if there is a browser window to be anchored to. This CL reverts that. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1519469 Bug: 946388 Change-Id: I9bbe4fb6e915181b33cf4613d8eb5957a9e8f522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554105 Reviewed-by: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#647970} chrome/browser/ui/views/media_router/cast_dialog_view.cc | 10 ++++++++++ chrome/browser/ui/views/media_router/cast_dialog_view.h | 7 +++++++ .../views/media_router/media_router_dialog_controller_views.cc | 6 ++---- 3 files changed, 19 insertions(+), 4 deletions(-) commit b10aad4ab119ea8a1828203271264da452e56aa3 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 23:05:43 2019 +0000 Roll src/third_party/skia e4628b10722f..51874e3e3712 (2 commits) https://skia.googlesource.com/skia.git/+log/e4628b10722f..51874e3e3712 git log e4628b10722f..51874e3e3712 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 bungeman@google.com Allow selection of shaper wrapping algorithm. 2019-04-04 halcanary@google.com SkPDF: Use fewer complex PathOps to speed up clipping Created with: gclient setdep -r src/third_party/skia@51874e3e3712 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:947381 TBR=jlavrova@chromium.org Change-Id: I316cee0d8ba5695a9c6aaff94388fcdbb3a456a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553783 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647969} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 07ea9b8b887e361538059c87dd4db412a5b3a3b6 Author: chaopeng@chromium.org <chaopeng@chromium.org> Date: Thu Apr 4 23:01:04 2019 +0000 Fix spat back key handling We are actually receiving spatnav back key with key up type. Move the event handing to keyup section. Bug: 940495 Change-Id: I21b7719c88a46b4e39ac9eae278b807074c9a640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553655 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#647968} .../blink/renderer/core/input/keyboard_event_manager.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) commit 200abd62a22a433cc155d6718c2718693654aa61 Author: kylechar <kylechar@chromium.org> Date: Thu Apr 4 22:57:13 2019 +0000 Make VizCompositorThread TYPE_DEFAULT on Windows. When Chrome is launched by a service in a console session, which seems to how Chrome is launched from some automation frameworks, creating a message only window for MessagePumpForUI fails in the GPU process. As a result VizCompositorThread fails to run any tasks and nothing is ever drawn, see https://crbug.com/942023. The display compositor thread was originally made TYPE_UI on Windows in https://crrev.com/c/1025954. This was to allow using a child HWND created in the GPU process for software composited output. That code was deleted in https://crrev.com/c/1450399 so the thread shouldn't need to be TYPE_UI anymore. Bug: 942023 Change-Id: I2a7dbf46a3a772b5ab1a9a20367d3e7f08116cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549763 Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#647967} components/viz/service/main/viz_compositor_thread_runner.cc | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) commit 0ddf56ea95849b6ac267a2d5ebb31d30968db78a Author: Peter Collingbourne <pcc@chromium.org> Date: Thu Apr 4 22:56:26 2019 +0000 Remove the enable_64_bit_browser GN flag. Looks like the targets have been enabled for over a month without any problems, so it's time to remove the flag that enables them. Bug: 907640 Change-Id: I5eb68758ab8b1db67b50c496de686dec3e9c2e33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1533313 Commit-Queue: Peter Collingbourne <pcc@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#647966} android_webview/BUILD.gn | 14 ++++++-------- build/config/android/config.gni | 3 --- chrome/android/BUILD.gn | 16 +++++++--------- 3 files changed, 13 insertions(+), 20 deletions(-) commit 950b4fbb944a2ddf6d62eb34e0deb7122daf78d8 Author: danakj <danakj@chromium.org> Date: Thu Apr 4 22:55:40 2019 +0000 Mark fast/css/font-face-default-font.html as Timeout on Android. This test is failing on the KitKat bot, and is the last test keeping the bot red for layout tests. TBR=vmpstr@chromium.org Bug: 947542 Change-Id: I85ec29ca74c5cb68f8850480acb6a1b2af2432c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553908 Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#647965} third_party/blink/web_tests/TestExpectations | 1 + 1 file changed, 1 insertion(+) commit ef7e8155a08190291e4a99fd1cb8d359c1981a81 Author: Khushal <khushalsagar@chromium.org> Date: Thu Apr 4 22:54:07 2019 +0000 cc: Don't cache discardable memory for uploaded images. The GpuImageDecodeCache has 2 layers of caching for decodes images, one is in GPU memory and the other is cpu discardable. The cpu discardable cache is meant to be a fallback for when the uploaded image is evicted from GPU memory, so we only need to reupload but skip the decode in these cache miss cases. The cache hit rate for this cpu discardable memory is at max ~2.5% on Android (see Renderer4.GpuImageDecodeState UMA for Used,relocked). This is low enough that its likely not worth putting pressure on the discardable system. In particular for platforms where cpu discardable is a chrome wide limit and not discardable memory that can be reclaimed by the OS. This change removes the cpu discardable caching for these cases. R=ericrk@chromium.org Bug: 946196 Change-Id: If089621967c9a797b69c5cdbda43a5ec23ecb698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553959 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#647964} cc/tiles/gpu_image_decode_cache.cc | 9 +++++++++ cc/tiles/gpu_image_decode_cache_unittest.cc | 6 ------ 2 files changed, 9 insertions(+), 6 deletions(-) commit 116e8fc12b212ea384053f2f811f1bec3cef91ed Author: Darwin Huang <huangdarwin@chromium.org> Date: Thu Apr 4 22:53:58 2019 +0000 ui/base/clipboard: Replace std::make_pair with initializer lists. See this link for motivation: https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#variable-initialization Bug: 949428 Change-Id: Ib1a3efdbd28e97286b2c62ece5fedc8978037032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552491 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647963} ui/base/clipboard/clipboard.cc | 4 ++-- ui/base/clipboard/custom_data_helper.cc | 2 +- ui/base/clipboard/custom_data_helper_unittest.cc | 12 ++++++------ 3 files changed, 9 insertions(+), 9 deletions(-) commit 8662f53e48fddb06cda9b8ea39b675501a92367c Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Apr 4 22:52:59 2019 +0000 Use DisplayCaptureSurfaceType and CursorCaptureType's mojo counterparts As part of the effort to clean the amount of APIs exposed by Blink to the rest of Chromium, classes, methods and enums are being audit. At first, it was verified that blink::ToWebDisplaySurface and blink::ToWebCursorCaptureType exposed APIs are only used by one call site in Blink. While moving these methods out of the Blink API it was verified both enums could be replaced by there mojom counterparts, eliminating the original enums and the conversion methods altogether. This CL implements it. BUG=919392 R=haraken@chromium.org CC=blink-reviews-vendor@chromium.org Change-Id: I4ab8b8618c043b70524ce266910c227305eca242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553339 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#647962} third_party/blink/public/platform/DEPS | 1 + .../blink/public/platform/web_media_stream_track.h | 12 +++------- .../media_stream_constraints_util_video_device.h | 6 ----- .../media_stream_constraints_util_video_device.cc | 26 ---------------------- .../modules/mediastream/media_stream_track.cc | 14 ++++++------ .../mediastream/media_stream_video_track.cc | 4 ++-- 6 files changed, 13 insertions(+), 50 deletions(-) commit ab45afe4f1a577bfe0e96ced7ce162e38c7f312c Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Thu Apr 4 22:52:49 2019 +0000 Show thumbnail of current tab for tab grid Before this CL, thumbnail of current tab would not be available unless after visiting another tab. This doesn't look good in TabListMode.GRID, namely grid tab switcher and tab grid sheet. This CL requests a thumbnail when showing the tab grid, without going through the (de)compression and disk IO, so the latency is acceptable. Bug: 940554 Change-Id: Ifd8f419b58f054303051e9eb26a7314e2731c624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1525627 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#647961} .../tab_management/MultiThumbnailCardProvider.java | 7 +- .../tasks/tab_management/TabListMediator.java | 10 ++- .../tab_management/TabListViewHolderTest.java | 5 +- .../GridTabSwitcherMediatorUnitTest.java | 5 +- .../tab_management/TabListMediatorUnitTest.java | 4 +- .../layouts/content/TabContentManager.java | 55 +++++++++++-- .../android/compositor/tab_content_manager.cc | 90 ++++++++++++++-------- .../android/compositor/tab_content_manager.h | 18 +++-- 8 files changed, 140 insertions(+), 54 deletions(-) commit fca04b5b1ce6576ccc910a4a89cb9e655560bedd Author: Ian Kilpatrick <ikilpatrick@chromium.org> Date: Thu Apr 4 22:45:24 2019 +0000 [LayoutNG] Small cleanups related to OOF-positioned code. As above, noticed some missing anonymous namespaces, comment structure, and other small things. Change-Id: Ia353980daf216ca2d0445ca9d7b6ca6baffa2d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553910 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#647960} .../core/layout/ng/layout_ng_block_flow.cc | 14 ++-- .../core/layout/ng/ng_block_layout_algorithm.cc | 5 +- .../core/layout/ng/ng_box_fragment_builder.cc | 23 ++++--- .../core/layout/ng/ng_column_layout_algorithm.cc | 5 +- .../core/layout/ng/ng_fieldset_layout_algorithm.cc | 5 +- .../core/layout/ng/ng_flex_layout_algorithm.cc | 5 +- .../core/layout/ng/ng_out_of_flow_layout_part.cc | 75 ++++++++++++---------- .../core/layout/ng/ng_out_of_flow_layout_part.h | 35 +++++----- .../core/layout/ng/ng_page_layout_algorithm.cc | 5 +- 9 files changed, 92 insertions(+), 80 deletions(-) commit 22e2cb168d8263fb91c2ed5b3e651c6e81ac7c12 Author: Benjamin Shaya <bshaya@chromium.org> Date: Thu Apr 4 22:44:58 2019 +0000 [chromecast] Enable resampling in CMA mixer! Bug: internal b/128456898 Test: cplay with resampler Change-Id: I85bcf5fb3603d77d2177c114710c031bc6b52d3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548038 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Benjamin Shaya <bshaya@chromium.org> Cr-Commit-Position: refs/heads/master@{#647959} chromecast/media/cma/backend/cplay/cplay.cc | 11 +- chromecast/media/cma/backend/filter_group.cc | 114 ++++++++++++++------- chromecast/media/cma/backend/filter_group.h | 32 ++++-- .../media/cma/backend/filter_group_unittest.cc | 23 ++--- chromecast/media/cma/backend/mixer_input.cc | 13 ++- chromecast/media/cma/backend/mixer_input.h | 3 - chromecast/media/cma/backend/mixer_pipeline.cc | 13 +-- chromecast/media/cma/backend/mixer_pipeline.h | 2 +- .../cma/backend/mock_post_processor_factory.h | 4 +- .../media/cma/backend/post_processing_pipeline.h | 4 +- .../cma/backend/post_processing_pipeline_impl.cc | 41 +++++--- .../cma/backend/post_processing_pipeline_impl.h | 5 +- .../post_processors/post_processor_wrapper.cc | 2 +- chromecast/media/cma/backend/stream_mixer.cc | 26 ++--- chromecast/media/cma/backend/stream_mixer.h | 2 +- 15 files changed, 180 insertions(+), 115 deletions(-) commit b8824f485c9cbae28931f6f1856ee84c93e153ad Author: Siddhartha S <ssid@chromium.org> Date: Thu Apr 4 22:43:56 2019 +0000 leveldb_proto: Fix data and proto conversion to not require copy BUG=944919 Change-Id: Icf6ef7d56cea1c0fd4b28122f538242f32d72848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551713 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by: Xing Liu <xingliu@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#647958} .../browser/notifications/scheduler/icon_store.cc | 4 ++-- .../browser/notifications/scheduler/icon_store.h | 4 ++-- .../notifications/scheduler/icon_store_unittest.cc | 2 +- .../notifications/scheduler/proto_conversion.cc | 20 ++++++++------------ .../notifications/scheduler/proto_conversion.h | 6 ++---- .../scheduler/proto_conversion_unittest.cc | 4 ++-- .../leveldb_proto/internal/proto_database_impl.h | 16 ++++++++-------- .../internal/proto_database_impl_unittest.cc | 22 ++++++++++------------ components/leveldb_proto/testing/fake_db.h | 21 +++++++++++---------- 9 files changed, 46 insertions(+), 53 deletions(-) commit 4f53499af8eed4b57b97a87bcb7367761755f597 Author: Sunny Sachanandani <sunnyps@chromium.org> Date: Thu Apr 4 22:43:25 2019 +0000 gpu: Crash keys for debugging decode swap chain creation Bug: 848093 Change-Id: I5b04216ccc962aa2ff4c02bb6d76f741e609a5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553909 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#647957} gpu/ipc/service/direct_composition_surface_win.cc | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) commit c625be6160f20e71a8e89fddb4961900d15ee071 Author: Mark Lieu <mtlieuu@chromium.org> Date: Thu Apr 4 22:42:49 2019 +0000 Add serialized MHTML data streaming from Renderer to Browser This change introduces the usage of Mojo data pipes when saving MHTML files. MHTML data will be streamed from the Renderer to the Browser, where it will then be written to the final destination file. This is an intermediary step to eventually also have the Browser calculate the contents digest. This change is controlled by a feature flag. Bug: 915966 Change-Id: I95fe188b257a60cc8e3ab4e5782fe02df2f7d9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500020 Commit-Queue: Mark Lieu <mtlieuu@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Brian White <bcwhite@chromium.org> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#647956} .../offline_pages/offline_page_mhtml_archiver.cc | 3 +- .../download/mhtml_generation_browsertest.cc | 311 +++++++++++++++++--- .../browser/download/mhtml_generation_manager.cc | 326 +++++++++++++++------ .../browser/download/mhtml_generation_manager.h | 8 - content/common/download/mhtml_file_writer.mojom | 20 +- content/public/common/mhtml_generation_params.h | 4 +- content/renderer/BUILD.gn | 2 + content/renderer/mhtml_handle_writer.cc | 176 +++++++++++ content/renderer/mhtml_handle_writer.h | 120 ++++++++ content/renderer/render_frame_impl.cc | 95 +++--- content/renderer/render_frame_impl.h | 4 +- content/test/data/page_with_multiple_iframes.html | 11 + tools/metrics/histograms/histograms.xml | 34 ++- 13 files changed, 919 insertions(+), 195 deletions(-) commit 4a737dc5584fff8eb3a2a4c07155f992938632c4 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 4 22:42:19 2019 +0000 Disable PaintPropertyTreeBuilderTest.SimpleScrollChangeDoesNotCausePacUpdate for CAP The test has been failing since I let CompositeAfterPaint imply BlinkGenPropertyTrees [1]. Before that, the test didn't run for the CompositeAfterPaint configuration in which BlinkGenPropertyTrees was not enabled. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1553502 TBR=vmpstr@chromium.org Change-Id: Ief61e1270173cd51006d5371af66c626d10cc33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553395 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#647955} .../blink/renderer/core/paint/paint_property_tree_builder_test.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) commit 8ed0fd3f8c5f8b2b44244e1363b24469dd91fe75 Author: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Apr 4 22:41:11 2019 +0000 Update V8 to version 7.5.195. Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ff262b4a..2f88b9b2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I64aaab6a56c484525ad860d2140847f7a498bc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553906 Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647954} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 3f1677fbd4b90c2d1b90770cd305627ecea1cf7b Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 22:40:53 2019 +0000 Roll src/third_party/angle 896e7ded5f25..27f115aa0b80 (1 commits) https://chromium.googlesource.com/angle/angle.git/+log/896e7ded5f25..27f115aa0b80 git log 896e7ded5f25..27f115aa0b80 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 syoussefi@chromium.org Vulkan: clean up framebuffer clear Created with: gclient setdep -r src/third_party/angle@27f115aa0b80 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I8572d22c09f8db35f03945770ec8184f54fbf3e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553781 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647953} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit aacf7691537c820560c5784c77d77c84013a79ff Author: Dan Harrington <harringtond@chromium.org> Date: Thu Apr 4 22:36:21 2019 +0000 Remove unsafe int->enum casts In each case, we're storing integers in a database and casting to the enum when reading from the database. If the database is corrupt (or if we add an enum value and then the user downgrades), we're at risk of crashing later on. This should fix all occurences within offline_pages/ Bug: 944674 Change-Id: I37491a6aa132feef6e8e13f66f1734a18013acdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534472 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#647952} components/offline_items_collection/core/BUILD.gn | 1 + .../offline_items_collection/core/fail_state.cc | 49 ++++++++++++++++++++++ .../offline_items_collection/core/fail_state.h | 6 +++ .../core/background/request_queue_store.cc | 29 ++++++++++++- .../core/background/save_page_request.h | 2 +- .../offline_pages/core/prefetch/prefetch_types.cc | 31 ++++++++++++++ .../offline_pages/core/prefetch/prefetch_types.h | 6 ++- .../prefetch/store/prefetch_store_test_util.cc | 6 ++- .../prefetch/tasks/metrics_finalization_task.cc | 9 ++-- .../prefetch/tasks/stale_entry_finalizer_task.cc | 7 +++- tools/metrics/histograms/enums.xml | 3 ++ 11 files changed, 139 insertions(+), 10 deletions(-) commit 54d690b417830bc66c6e14625ae3220822815d40 Author: Mike Reed <reed@google.com> Date: Thu Apr 4 22:35:18 2019 +0000 getLocalMatrix is going away, so remove the logging. See https://skia-review.googlesource.com/c/skia/+/206165 Bug: skia:8941 Change-Id: I139e4769ca74d2ba10a004004646f7e7c696e5b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554040 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#647951} third_party/blink/renderer/platform/graphics/logging_canvas.cc | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 3b30be89576200dae851b7b44c6926153f2a90e1 Author: Ryan Sturm <ryansturm@chromium.org> Date: Thu Apr 4 22:34:12 2019 +0000 Bits to bytes conversion fix Bug: 949746 Change-Id: I8fe0495dd42ffd7236d4f285c5b428692ed3ab82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553947 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#647950} components/previews/content/previews_hints.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) commit 525f1700f14585fc35dcaee7edd83beb851891f6 Author: Mike Wittman <wittman@chromium.org> Date: Thu Apr 4 22:32:52 2019 +0000 [Sampling profiler] Move UnwindResult into Unwinder header All uses of UnwindResult are now through the Unwinder, so provide the enum in its header. Bug: 909957 Change-Id: Id40178901747591360d525cf6fcb4579df9e1347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542055 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#647949} base/BUILD.gn | 1 - base/profiler/thread_delegate.h | 1 - base/profiler/unwind_result.h | 25 ------------------------- base/profiler/unwinder.h | 14 +++++++++++++- 4 files changed, 13 insertions(+), 28 deletions(-) commit 1fe9f05fb50121fa748266f497dc0aabcc542bb8 Author: bsheedy <bsheedy@chromium.org> Date: Thu Apr 4 22:28:06 2019 +0000 Fail XR browser tests if required flags not passed Cause the XR browser tests to fail if they are run without the required flags (--enable-gpu, --enable-pixel-output-in-tests, --test-launcher-jobs=1). Some of the tests fail without these flags, but in non-obvious ways. Failing immediately if they aren't present is both faster and provides more feedback. Bug: 949617 Change-Id: I5d028cdae30b0f0fa4bddc1d2b58689172b25911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553392 Reviewed-by: Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#647948} chrome/browser/vr/test/xr_browser_test.cc | 25 ++++++++++++++++++++++++- chrome/browser/vr/test/xr_browser_test.h | 3 +++ 2 files changed, 27 insertions(+), 1 deletion(-) commit 45b874d04708dba640026fd9fa0f06033f4495ad Author: Malay Keshav <malaykeshav@chromium.org> Date: Thu Apr 4 22:26:20 2019 +0000 Use SkRRect transform API to apply transform Use SkRRect's transform API to apply any transform on rounded corner bounds. This would allow for axis aligned rotations to work as well. Bug: 947074 Change-Id: I256caed94dcb7caa244f854fee36b09d09e2ee99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551451 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#647947} cc/trees/draw_property_utils.cc | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) commit e8e148056cebd87c8140538932b86ee1c7d60098 Author: Jay Harris <harrisjay@chromium.org> Date: Thu Apr 4 22:24:03 2019 +0000 Plumbs file_handlers in the WebAppManifest through to the extension manifest. Previously, while we could parse the fields into the blink::Manifest the data was never saved with the Extension. Bug: 829689 Change-Id: I494790faac621d0cde838defe8f5b71d97319657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1476884 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#647946} chrome/browser/extensions/convert_web_app.cc | 45 ++++++++++++++ .../browser/extensions/convert_web_app_unittest.cc | 68 ++++++++++++++++++++++ .../components/web_app_install_utils.cc | 3 + .../components/web_app_install_utils_unittest.cc | 18 ++++++ chrome/common/web_application_info.h | 4 ++ extensions/common/api/_manifest_features.json | 5 +- extensions/common/manifest_constants.cc | 2 + extensions/common/manifest_constants.h | 1 + .../common/manifest_handlers/file_handler_info.cc | 11 ++++ .../file_handler_manifest_unittest.cc | 44 ++++++++++++++ .../file_handlers_valid_hosted_app.json | 32 ++++++++++ 11 files changed, 232 insertions(+), 1 deletion(-) commit d10785e43f7898717959696e0b6d227e4fce3017 Author: Daniel Cheng <dcheng@chromium.org> Date: Thu Apr 4 22:21:15 2019 +0000 Get rid of the need for custom contexts during Mojo serialization. The serialization traits for WTF::String are the only thing that still depends on the custom context. Getting rid of them requires returning a wrapper object to hold any needed storage alive until Mojo serialization can actually write the bytes to the wire. Unfortunately, returning a wrapper object like this seems to increase binary size: it's not 100% clear why this is the case. The regression is ~40KB. Followup patches will look into ways of reducing this cost. Bug: 651713 Change-Id: I58225f4514c02b281c88ecd26760b8316dace3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549963 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#647945} mojo/public/cpp/bindings/lib/serialization_util.h | 56 --------------------- .../public/cpp/bindings/lib/string_serialization.h | 9 ++-- mojo/public/cpp/bindings/lib/string_traits_wtf.cc | 57 ++-------------------- mojo/public/cpp/bindings/string_traits.h | 28 ++--------- mojo/public/cpp/bindings/string_traits_stl.h | 4 +- .../cpp/bindings/string_traits_string_piece.h | 8 +-- mojo/public/cpp/bindings/string_traits_wtf.h | 8 +-- .../struct_serialization_declaration.tmpl | 4 +- .../union_serialization_declaration.tmpl | 11 ++--- .../v8/serialization/v8_script_value_serializer.cc | 4 +- .../core/frame/csp/content_security_policy.cc | 4 +- .../renderer/core/frame/csp/csp_directive_list.cc | 4 +- .../renderer/core/inspector/devtools_session.cc | 5 +- .../core/streams/miscellaneous_operations_test.cc | 3 +- .../modules/webgl/webgl_rendering_context_base.cc | 4 +- .../blink/renderer/platform/exported/web_string.cc | 2 +- .../tracing/web_memory_allocator_dump.cc | 3 +- .../tracing/web_process_memory_dump.cc | 17 +++---- third_party/blink/renderer/platform/link_hash.cc | 8 +-- third_party/blink/renderer/platform/mojo/DEPS | 1 + .../platform/mojo/big_string_mojom_traits.cc | 4 +- .../platform/mojo/string16_mojom_traits.cc | 48 ++++++------------ .../renderer/platform/mojo/string16_mojom_traits.h | 39 +++++++++++++-- .../renderer/platform/weborigin/known_ports.cc | 3 +- .../blink/renderer/platform/weborigin/kurl.cc | 47 +++++++++--------- .../renderer/platform/weborigin/security_origin.cc | 5 +- third_party/blink/renderer/platform/wtf/BUILD.gn | 1 + .../platform/wtf/text/string_utf8_adaptor.cc | 29 +++++++++++ .../platform/wtf/text/string_utf8_adaptor.h | 41 +++++++--------- 29 files changed, 172 insertions(+), 285 deletions(-) commit 96742159d57191982efe2753e067c0d0b64bf2db Author: James Cook <jamescook@chromium.org> Date: Thu Apr 4 22:17:56 2019 +0000 chromeos: Add host, URL, and WebUI controller for chrome://os-settings/ Start with a "hello world" page that opens in the existing settings window. Bug: 948298 Change-Id: I97cdf29412d3abd58a0065c8e1c19f3056b3f25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549751 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#647944} chrome/browser/browser_resources.grd | 3 ++ chrome/browser/resources/chromeos/os_settings.html | 7 +++++ chrome/browser/ui/BUILD.gn | 2 ++ .../browser/ui/settings_window_manager_chromeos.cc | 4 +-- .../ui/webui/chrome_web_ui_controller_factory.cc | 4 +++ .../ui/webui/settings/chromeos/os_settings_ui.cc | 34 ++++++++++++++++++++++ .../ui/webui/settings/chromeos/os_settings_ui.h | 27 +++++++++++++++++ chrome/browser/ui/webui/settings/md_settings_ui.h | 2 -- chrome/common/webui_url_constants.cc | 2 ++ chrome/common/webui_url_constants.h | 2 ++ 10 files changed, 82 insertions(+), 5 deletions(-) commit f11e00a602ba639ef08167b51f1162500dcc3397 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 22:15:28 2019 +0000 Roll src/third_party/perfetto 9ea63e7d30e8..e382e0ed7613 (1 commits) https://android.googlesource.com/platform/external/perfetto.git/+log/9ea63e7d30e8..e382e0ed7613 git log 9ea63e7d30e8..e382e0ed7613 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 treehugger-gerrit@google.com Merge "Add total unwinding time to stats." Created with: gclient setdep -r src/third_party/perfetto@e382e0ed7613 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7a2e2998249d22879ab3998bbf599954e7fc60bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553016 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647943} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cc93a50e985434d1e37fa68ef01cc71f9cef18cf Author: Khushal <khushalsagar@chromium.org> Date: Thu Apr 4 22:12:57 2019 +0000 gpu: Add finch param to blacklist SurfaceControl on specific builds. R=ericrk@chromium.org Bug: 948946 Change-Id: I7ca2f7cbc7e9772a36e699908684b8356daee6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548444 Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#647942} gpu/config/gpu_finch_features.cc | 42 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 40 insertions(+), 2 deletions(-) commit 34f27e3a53b34f81bdc6872991af31346b161dc6 Author: Scott Chen <scottchen@chromium.org> Date: Thu Apr 4 22:12:41 2019 +0000 Move more TODOs off scottchen TBR=dpapad@chromium.org,johntlee@chromium.org,tommycli@chromium.org,tangltom@chromium.org Bug: None Change-Id: I1ba1d2a9d3b77a459f2043bf40d9b2fbceab2bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553904 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Tommy Li <tommycli@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647941} chrome/browser/resources/md_extensions/keyboard_shortcuts.html | 2 +- chrome/browser/resources/md_extensions/shared_style.html | 4 ++-- chrome/browser/resources/settings/autofill_page/autofill_section.js | 2 -- chrome/browser/resources/settings/people_page/people_page.js | 4 ++-- chrome/browser/resources/settings/privacy_page/privacy_page.js | 2 +- chrome/browser/resources/settings/route.js | 4 ++-- .../browser/resources/signin/sync_confirmation/sync_confirmation.js | 2 +- chrome/browser/ui/webui/extensions/chromeos/kiosk_apps_handler.cc | 4 ++-- chrome/test/data/webui/settings/people_page_test.js | 2 +- ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js | 2 -- ui/webui/resources/cr_elements/cr_view_manager/cr_view_manager.js | 4 ++-- ui/webui/resources/cr_elements/shared_vars_css.html | 2 +- 12 files changed, 15 insertions(+), 19 deletions(-) commit 5f212fb693d8f9ae5e4bd73d7ab89a35a6478179 Author: Scott Chen <scottchen@chromium.org> Date: Thu Apr 4 22:09:49 2019 +0000 Move extern TODOs to dpapad TBR=dpapad@chromium.org Bug: None Change-Id: I9f45a4034d5804ce3cd2d6b5cae0569010fdafea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552242 Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Auto-Submit: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#647940} third_party/closure_compiler/externs/pending.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit b4300409e3322923d61de62b9279ab55511a6491 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 22:09:02 2019 +0000 Roll src/third_party/chromite 9c05b2b13859..f2ceeca98c82 (3 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/9c05b2b13859..f2ceeca98c82 git log 9c05b2b13859..f2ceeca98c82 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 mikenichols@chromium.org chromeos-config: Add sarien factory branch 2019-04-04 chrome-bot@chromium.org Update config settings by config-updater. 2019-04-04 jclinton@chromium.org Space out release builder invocations to avoid contention Created with: gclient setdep -r src/third_party/chromite@f2ceeca98c82 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@chromium.org Change-Id: Ied168cf31b97f04d7e8aa09155543e6a398404f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553444 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647939} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit eceb0ef926a38c55d3daad98f7449688da627e60 Author: Majid Valipour <majidvp@chromium.org> Date: Thu Apr 4 22:08:41 2019 +0000 [cc] Keep kInvalidElementId internal to ElementId The default ctor creates an invalid Id so there is not need to expose the exact value that represents the invalid Id. Change-Id: I287872dd1977227edc1fa89118117f397c5e1b25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526723 Reviewed-by: enne <enne@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#647938} cc/layers/layer_sticky_position_constraint.cc | 4 +--- cc/trees/element_id.cc | 2 ++ cc/trees/element_id.h | 12 +++++++----- 3 files changed, 10 insertions(+), 8 deletions(-) commit b3086c72f6691ba76dbcef10c20a2c0549aa45ff Author: Darren Shen <shend@chromium.org> Date: Thu Apr 4 22:07:55 2019 +0000 vk: Move keyboard rebuild code from a11y controller to keyboard. There's a corner case for the virtual keyboard where the keyboard has to be rebuilt if we are going between compact and full layout (see bug). Originally the code was in a11y controller, but it doesn't really make sense to be there: 1. It's an implementation detail that should be encapsulated in the VK. 2. If SetAccessibilityKeyboardEnabled is called outside of a11y controller, then the logic breaks. We move this to KeyboardController as part of the flag enable/clear logic. Bug: 946358 Change-Id: If2c4b9c632006406551304e29f8a96e13779315c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551726 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#647937} ash/accessibility/accessibility_controller.cc | 17 ------------- .../accessibility_controller_unittest.cc | 25 ------------------- ui/keyboard/keyboard_controller.cc | 29 ++++++++++++++++------ ui/keyboard/keyboard_controller.h | 4 +++ ui/keyboard/keyboard_util_unittest.cc | 22 ++++++++++++++++ 5 files changed, 47 insertions(+), 50 deletions(-) commit 28ac9722e2c821b11cbd05dd46de7a37d04c1f23 Author: Jinsuk Kim <jinsukkim@chromium.org> Date: Thu Apr 4 22:07:34 2019 +0000 Android: ActivityTabProvider implements Supplier<Tab> ActivityTabProvider can then be used as Supplier<Tab> in various places with minimum exposure of its other methods. Bug: 937946 Change-Id: Ice2c602dd10653aad70d7954edbf5e4e6edd3261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552380 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#647936} .../java/src/org/chromium/chrome/browser/ActivityTabProvider.java | 8 +++++--- .../autofill/keyboard_accessory/ManualFillingMediator.java | 2 +- .../controller/TrustedWebActivityOpenTimeRecorder.java | 2 +- .../compositor/bottombar/ephemeraltab/EphemeralTabPanel.java | 2 +- .../browser/contextualsearch/ContextualSearchTabHelper.java | 2 +- .../customtabs/CustomTabBrowserControlsVisibilityDelegate.java | 2 +- .../browser/customtabs/content/CustomTabActivityTabProvider.java | 2 +- .../customtabs/dynamicmodule/DynamicModulePageLoadObserver.java | 2 +- .../chrome/browser/gesturenav/HistoryNavigationLayout.java | 4 ++-- .../chromium/chrome/browser/omaha/UpdateInfoBarController.java | 6 +++--- .../omnibox/suggestions/editurl/EditUrlSuggestionProcessor.java | 6 +++--- .../browser/send_tab_to_self/SendTabToSelfShareActivity.java | 2 +- .../java/src/org/chromium/chrome/browser/toolbar/HomeButton.java | 2 +- .../browser/toolbar/ToolbarButtonInProductHelpController.java | 7 +++---- .../chrome/browser/widget/bottomsheet/BottomSheetController.java | 4 ++-- .../src/org/chromium/chrome/browser/ActivityTabProviderTest.java | 2 +- .../src/org/chromium/chrome/browser/OSKOverscrollTest.java | 2 +- .../autofill/keyboard_accessory/ManualFillingControllerTest.java | 2 +- .../content/CustomTabActivityContentTestEnvironment.java | 2 +- .../browser/send_tab_to_self/SendTabToSelfShareActivityTest.java | 2 +- 20 files changed, 32 insertions(+), 31 deletions(-) commit 8810efdd49c565613c2fb3537cae34bf3c15fb97 Author: Nate Fischer <ntfschr@chromium.org> Date: Thu Apr 4 22:04:54 2019 +0000 apk_operations: add set-webview-provider command This adds the "set-webview-provider" command to apk_operations.py, to be exposed in generated wrapper scripts. This aids WebView development: * Developers can switch provider without importing 'adb' in their $PATH * This command always passes the correct package name (which can be easy to get wrong, if changing package name via GN args) This updates developer documentation to showcase the new command. Bug: 949431, 918221 Test: $ out/Default/bin/system_webview_google_apk set-webview-provider Test: $ out/Default/bin/monochrome_apk set-webview-provider Test: $ out/Default/bin/system_webview_apk set-webview-provider \ Test: (works when I change the package name via GN args) Change-Id: Ifaa7ab74be8b5a8bb6033e7f50114351b42377d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552570 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#647935} android_webview/docs/quick-start.md | 9 ++------- build/android/apk_operations.py | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 7 deletions(-) commit c40b450053b0335a7d493adfbd135f21e107a6f3 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Thu Apr 4 22:01:17 2019 +0000 Show the IPH when a tab group is created In the TabGroupsAndroid feature, show the "Your tabs are grouped together here" IPH in the tab switcher if a tab group is already created. Bug: 930972 Change-Id: I706603a5920b27783eefbb3791281bae6e81adbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504393 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#647934} .../tasks/tab_management/TabGridViewBinder.java | 3 ++ .../tasks/tab_management/TabListMediator.java | 33 ++++++++++++++++++++++ .../tasks/tab_management/TabProperties.java | 9 ++++-- 3 files changed, 42 insertions(+), 3 deletions(-) commit ebd122d0d015a3583943cc44290176b497367796 Author: Ella Ge <eirage@chromium.org> Date: Thu Apr 4 22:00:43 2019 +0000 Revert "Make AverageLag count scroll prediction change" This reverts commit 6c1aaacd098d1c5fdf372b2bf532783c418f9c9a. Reason for revert: The fix is incorrect proper fix in following CLs Original change's description: > Make AverageLag count scroll prediction change > > AverageLag are calculated from latency_info.scroll_update_delta. > It was set from GestureScrollUpdate event's delta_y; however, scroll > prediction is done after scroll_update_delta set, which means the > AverageLag did not count in the prediction result. > > This CL adds setting the scroll_update_delta from GSU, so it will > count in the prediction change as well. > > Bug: 836352 > Change-Id: I979e0da617dbfdfa6735aee33958cb9dac9b8331 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1509102 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#638732} # Not skipping CQ checks because original CL landed > 1 day ago. TBR: nzolghadr@chromium.org Bug: 946212 Change-Id: I8395282e50322edc9d6272701934483fb8711b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549343 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#647933} ui/events/blink/input_handler_proxy.cc | 7 --- ui/events/blink/input_handler_proxy_unittest.cc | 61 ------------------------- 2 files changed, 68 deletions(-) commit 2a257f23c8bf961d993bac01bf1d2aa0624e838c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 21:58:36 2019 +0000 Roll src/third_party/catapult 144122958b28..810aaa1e1846 (1 commits) https://chromium.googlesource.com/catapult.git/+log/144122958b28..810aaa1e1846 git log 144122958b28..810aaa1e1846 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 simonhatch@chromium.org Pinpoint - Retry on urlfetch timeouts. Created with: gclient setdep -r src/third_party/catapult@810aaa1e1846 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:948232 TBR=crouleau@chromium.org Change-Id: I4d05108795786f1d67e80b831da10b82c8f6f5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553011 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647932} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit ecf37f6b2a6a5925337f82d3fb1131a8a7f4dfa2 Author: Ken MacKay <kmackay@chromium.org> Date: Thu Apr 4 21:56:39 2019 +0000 [Chromecast] Re-enable AudioVideoPipelineDeviceTest.Mp4Playback Bug: internal b/115400220 Change-Id: Ie14223988f50cebce496df70e46f24d30fbae8fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553583 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#647931} chromecast/BUILD.gn | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) commit 6433110604fee53caaaf7d6f21be728b40574454 Author: Findit <findit-for-me@appspot.gserviceaccount.com> Date: Thu Apr 4 21:51:14 2019 +0000 Revert "Add browser test for Safe Browsing Hash computation" This reverts commit 3459ca5a7d7081c8b09581c079a2cc17d825f113. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 647848 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzQ1OWNhNWE3ZDcwODFjOGIwOTU4MWMwNzlhMmNjMTdkODI1ZjExMww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/34199 Sample Failed Step: browser_tests on Windows-10-15063 Sample Flaky Test: DownloadProtectionServiceBrowserTest.VerifyRarHash Original change's description: > Add browser test for Safe Browsing Hash computation > > This CL adds a browser test for ZIP and RAR extraction, and verifies > that the hashes of the computed entries are correct. These tests fail > without the patches from https://crrev/c/1540418 and > https://crrev/c/1535258 > > Bug: 948282 > Change-Id: I56091af9246948208ba5d36db00718f34c647edf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548443 > Commit-Queue: Daniel Rubery <drubery@chromium.org> > Reviewed-by: Varun Khaneja <vakh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647848} Change-Id: I97a0be75c01cc3a8efddab0d555b9a7319ee4076 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 948282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1554108 Cr-Commit-Position: refs/heads/master@{#647930} .../download_protection_service_browsertest.cc | 121 --------------------- chrome/test/BUILD.gn | 1 - .../download_protection/zipfile_two_archives.zip | Bin 276 -> 0 bytes .../data/safe_browsing/rar/has_two_archives.rar | Bin 122 -> 0 bytes .../safe_browsing/web_ui/safe_browsing_ui.cc | 19 ++-- components/safe_browsing/web_ui/safe_browsing_ui.h | 5 - 6 files changed, 9 insertions(+), 137 deletions(-) commit 2611cb77d052828f24358dd860145c86fff0ec3d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 21:49:27 2019 +0000 Roll src/third_party/swiftshader d39c96e96a31..e6ab01f42ade (1 commits) https://swiftshader.googlesource.com/SwiftShader.git/+log/d39c96e96a31..e6ab01f42ade git log d39c96e96a31..e6ab01f42ade --date=short --no-merges --format='%ad %ae %s' 2019-04-04 senorblanco@chromium.org Implement an Android NDK build of SwiftShader using the CMake files. Created with: gclient setdep -r src/third_party/swiftshader@e6ab01f42ade The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/129942368 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I937f5232fab296ea4feafb881aa700eecb061ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553014 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647929} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9df14d3a135b7447db232bc41b2ea6809dedd90d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 21:46:45 2019 +0000 Roll src/native_client de8da4841bc3..2c300847c770 (1 commits) https://chromium.googlesource.com/native_client/src/native_client.git/+log/de8da4841bc3..2c300847c770 git log de8da4841bc3..2c300847c770 --date=short --no-merges --format='%ad %ae %s' 2019-04-04 raul@tambre.ee Support Python 3 in //tools/win_as.py Created with: gclient setdep -r src/native_client@2c300847c770 The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:941669 TBR=mseaborn@chromium.org Change-Id: I52f1999637ff218e88c08e67533c4714edbbba02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553013 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647928} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit e74ee67c10894d8e08e6d9de064b25142850ab79 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Apr 4 21:46:25 2019 +0000 Support multi VM for crostini path sharing in prefs Old: crostini.shared_paths was a list of paths. E.g. ['path1', 'path2'] New: guest_os.paths_shared_to_vms is a dictionary which maps from path to a list of vm names. E.g. {'path1': ['vm1'], 'path2': ['vm1', 'vm2'] Bug: 946273 Change-Id: Ibb75cb89bc1b5f4fca59eae62045ec32247aba4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547480 Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Nicholas Verne <nverne@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#647927} .../browser/chromeos/crostini/crostini_manager.cc | 8 +- .../chromeos/crostini/crostini_pref_names.cc | 7 + .../chromeos/crostini/crostini_pref_names.h | 2 + .../chromeos/crostini/crostini_share_path.cc | 181 ++++++--- .../chromeos/crostini/crostini_share_path.h | 19 +- .../crostini/crostini_share_path_unittest.cc | 430 ++++++++++++--------- .../file_manager/file_manager_private_apitest.cc | 13 +- .../extensions/file_manager/private_api_misc.cc | 3 +- .../extensions/api/settings_private/prefs_util.cc | 4 +- chrome/browser/prefs/browser_prefs.cc | 3 + .../crostini_page/crostini_browser_proxy.js | 11 +- .../crostini_page/crostini_shared_paths.js | 35 +- .../ui/webui/settings/chromeos/crostini_handler.cc | 8 +- .../api_test/file_browser/crostini_test/test.js | 14 +- .../test/data/webui/settings/crostini_page_test.js | 39 +- .../webui/settings/test_crostini_browser_proxy.js | 9 +- 16 files changed, 467 insertions(+), 319 deletions(-) commit 510dcfc4b99f6ff6bacb119f920f3c1007bb9e45 Author: Olivier Yiptong <oyiptong@chromium.org> Date: Thu Apr 4 21:41:05 2019 +0000 appcache-internals page: Organize details for better readability Organizes the details section into a table so that information is easier to visually parse. Change-Id: I6c302a42a51bccfff819d6a83e7823110dbd9388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553956 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#647926} .../resources/appcache/appcache_internals.css | 10 +++++- .../resources/appcache/appcache_internals.html | 38 ++++++++++++++-------- 2 files changed, 34 insertions(+), 14 deletions(-) commit ec57c898b710ad576edfd7001863b756c88824a1 Author: Alexei Filippov <alph@chromium.org> Date: Thu Apr 4 21:40:45 2019 +0000 DevTools: Make use of Runtime.sharedInstance for PerfUI.LineLevelProfile Change-Id: Ic07bc33cdd12a18395fd28a458daf10a8e344d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553700 Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#647925} .../blink/renderer/devtools/front_end/Runtime.js | 5 +++-- .../devtools/front_end/perf_ui/LineLevelProfile.js | 18 ------------------ .../devtools/front_end/perf_ui/LiveHeapProfile.js | 2 +- .../devtools/front_end/profiler/CPUProfileView.js | 2 +- .../devtools/front_end/timeline/TimelinePanel.js | 4 ++-- .../timeline-js/timeline-js-line-level-profile.js | 4 ++-- 6 files changed, 9 insertions(+), 26 deletions(-) commit 7bc19075851ae39e69fbc0e0fc3b412ffbc73ee7 Author: Archana Simha <archanasimha@google.com> Date: Thu Apr 4 21:38:17 2019 +0000 Remove the enum V4UsageStatus and the enclosing namespace V4FeatureList since it is not longer used in the codebase. R=vakh Bug: 691026 Change-Id: I94cf0bf0e700fd2cdc86e6b8928e1efe5749bc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553304 Reviewed-by: Daniel Rubery <drubery@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Archana Simha <archanasimha@google.com> Cr-Commit-Position: refs/heads/master@{#647924} chrome/browser/safe_browsing/BUILD.gn | 1 - .../safe_browsing_service_browsertest.cc | 1 - .../safe_browsing/test_safe_browsing_service.cc | 1 - components/safe_browsing/db/BUILD.gn | 13 --------- components/safe_browsing/db/v4_feature_list.cc | 24 --------------- components/safe_browsing/db/v4_feature_list.h | 34 ---------------------- .../safe_browsing/db/v4_local_database_manager.cc | 1 - 7 files changed, 75 deletions(-) commit d01a6c68cd9f440b1082d809d0c5f3f2dbde97ae Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 4 21:37:52 2019 +0000 Inline static Create() in FilterEffect classes As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in //third_party/blink/renderer/platform/graphics/filters, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ife4722f8bc87ec886f1ecb3af0231753c13a27a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550424 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#647923} .../core/layout/svg/svg_layout_tree_as_text.cc | 8 ++- .../renderer/core/paint/filter_effect_builder.cc | 57 +++++++++++----------- .../svg/graphics/filters/svg_filter_builder.cc | 12 +++-- .../renderer/core/svg/svg_fe_blend_element.cc | 5 +- .../core/svg/svg_fe_color_matrix_element.cc | 5 +- .../core/svg/svg_fe_component_transfer_element.cc | 5 +- .../renderer/core/svg/svg_fe_composite_element.cc | 3 +- .../core/svg/svg_fe_convolve_matrix_element.cc | 3 +- .../core/svg/svg_fe_diffuse_lighting_element.cc | 3 +- .../core/svg/svg_fe_displacement_map_element.cc | 3 +- .../core/svg/svg_fe_drop_shadow_element.cc | 3 +- .../renderer/core/svg/svg_fe_flood_element.cc | 3 +- .../core/svg/svg_fe_gaussian_blur_element.cc | 4 +- .../renderer/core/svg/svg_fe_merge_element.cc | 2 +- .../renderer/core/svg/svg_fe_morphology_element.cc | 3 +- .../renderer/core/svg/svg_fe_offset_element.cc | 5 +- .../core/svg/svg_fe_specular_lighting_element.cc | 3 +- .../blink/renderer/core/svg/svg_fe_tile_element.cc | 3 +- .../renderer/core/svg/svg_fe_turbulence_element.cc | 3 +- .../renderer/platform/graphics/filters/fe_blend.cc | 4 -- .../renderer/platform/graphics/filters/fe_blend.h | 2 - .../platform/graphics/filters/fe_box_reflect.h | 4 -- .../platform/graphics/filters/fe_color_matrix.cc | 6 --- .../platform/graphics/filters/fe_color_matrix.h | 2 - .../graphics/filters/fe_component_transfer.cc | 10 ---- .../graphics/filters/fe_component_transfer.h | 7 --- .../platform/graphics/filters/fe_composite.cc | 9 ---- .../platform/graphics/filters/fe_composite.h | 7 --- .../platform/graphics/filters/fe_composite_test.cc | 12 +++-- .../graphics/filters/fe_convolve_matrix.cc | 13 ----- .../platform/graphics/filters/fe_convolve_matrix.h | 9 ---- .../graphics/filters/fe_diffuse_lighting.cc | 11 ----- .../graphics/filters/fe_diffuse_lighting.h | 6 --- .../graphics/filters/fe_displacement_map.cc | 9 ---- .../graphics/filters/fe_displacement_map.h | 5 -- .../platform/graphics/filters/fe_drop_shadow.cc | 11 ----- .../platform/graphics/filters/fe_drop_shadow.h | 3 -- .../renderer/platform/graphics/filters/fe_flood.cc | 6 --- .../renderer/platform/graphics/filters/fe_flood.h | 2 - .../platform/graphics/filters/fe_gaussian_blur.cc | 4 -- .../platform/graphics/filters/fe_gaussian_blur.h | 2 - .../renderer/platform/graphics/filters/fe_merge.cc | 4 -- .../renderer/platform/graphics/filters/fe_merge.h | 2 - .../platform/graphics/filters/fe_morphology.cc | 7 --- .../platform/graphics/filters/fe_morphology.h | 5 -- .../platform/graphics/filters/fe_offset.cc | 4 -- .../renderer/platform/graphics/filters/fe_offset.h | 2 - .../graphics/filters/fe_specular_lighting.cc | 12 ----- .../graphics/filters/fe_specular_lighting.h | 7 --- .../renderer/platform/graphics/filters/fe_tile.cc | 4 -- .../renderer/platform/graphics/filters/fe_tile.h | 2 - .../platform/graphics/filters/fe_turbulence.cc | 12 ----- .../platform/graphics/filters/fe_turbulence.h | 3 -- .../renderer/platform/graphics/filters/filter.cc | 19 ++------ .../renderer/platform/graphics/filters/filter.h | 7 +-- .../graphics/filters/image_filter_builder_test.cc | 13 ++--- .../graphics/filters/paint_filter_effect.cc | 5 -- .../graphics/filters/paint_filter_effect.h | 2 - .../platform/graphics/filters/source_alpha.cc | 4 -- .../platform/graphics/filters/source_alpha.h | 2 - .../platform/graphics/filters/source_graphic.cc | 4 -- .../platform/graphics/filters/source_graphic.h | 2 - 62 files changed, 95 insertions(+), 304 deletions(-) commit 1233d5faf9da91745b487eeea46be71dc343554a Author: Henrique Ferreiro <hferreiro@igalia.com> Date: Thu Apr 4 21:37:11 2019 +0000 Inline static Create() in incremental_marking_test As advised in [1], this CL removes unnecessary Foo::Create() factory functions which return an instance created by MakeGarbageCollected<Foo> in blink/renderer/platform/heap/incremental_marking_test.cc, then this CL makes the callers use MakeGarbageCollected<Foo> instead of Foo::Create() factory functions. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBgAJ Bug: 939691 Change-Id: Ic99fd5dc842051d76ba9af6e7500cb72b71039eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552800 Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#647922} .../platform/heap/incremental_marking_test.cc | 295 ++++++++++----------- 1 file changed, 143 insertions(+), 152 deletions(-) commit f6d67c29b52bce66e2814d666dfe68e330bc7904 Author: Eric Aleshire <ericale@google.com> Date: Thu Apr 4 21:34:24 2019 +0000 Replace #import <EarlGrey/EarlGrey.h> with predeclarations in shell_actions.h. EG1 and EG2 do not share a common set of headers, so any file that directly includes EarlGrey.h cannot be compiled under EG2. Scrubbing the headers will enable us (in a future CL) to share these helpers between EG1 and EG2. Bug: 922813 Change-Id: I2bf84c92fbce3349e680c8b23c52318baac530e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553816 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Auto-Submit: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#647921} ios/web/shell/test/earl_grey/shell_actions.h | 5 +++-- ios/web/shell/test/earl_grey/shell_actions.mm | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) commit c7ef15e4505887c0f62747247196bbd837db189b Author: James Cook <jamescook@chromium.org> Date: Thu Apr 4 21:32:07 2019 +0000 Add per-file owners for SettingsWindowManager It's used on Chrome OS to show combined browser and OS settings in a window. Bug: none Change-Id: Ib7277c04eb0002aaf1d9cc41fc2ae7a72a192d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553949 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#647920} chrome/browser/ui/OWNERS | 2 ++ 1 file changed, 2 insertions(+) commit 12fa215e0ab070a77988962752a28022fb19c292 Author: PKH <pkotwicz@chromium.org> Date: Thu Apr 4 21:28:42 2019 +0000 Remove unused WebappActivity.ActivityType BUG=None R=peconn TBR=yfriedman Change-Id: Ic11ffd16e5ac275f9107e770b05aa777bb870d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1550682 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#647919} chrome/android/chrome_test_java_sources.gni | 1 - .../customtabs/CustomTabIntentDataProvider.java | 2 +- .../chrome/browser/webapps/WebappActivity.java | 12 ---------- .../chrome/browser/webapps/WebappActivityTest.java | 28 ---------------------- 4 files changed, 1 insertion(+), 42 deletions(-) commit c27a874cf23d743c33a34fbd376a772616989d5d Author: Hiroshige Hayashizaki <hiroshige@chromium.org> Date: Thu Apr 4 21:28:39 2019 +0000 [WPT] Fix JSON decoding errors in referrer-policy on Safari In referrer-policy tests, image.py encodes information such as request headers into pixel values and the tests decode the pixels back to JSON using canvas. However on wpt.fyi on Safari this decoding flakily fails with SyntaxError: JSON Parse error: Unexpected identifier "z". This is probably because pixel values on canvas are affected by color profiles. This CL encodes one bit per one color channel in a pixel as 0 or 255 (rather than 8 bits per channel as 0-255), so that small changes to pixel values don't affect decoding result. Bug: 906850 Change-Id: Id14c73289592d729d92f710a7436a661c54b16f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546367 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#647918} .../common/security-features/resources/common.js | 42 +++++++++++++++------- .../common/security-features/subresource/image.py | 17 ++++----- 2 files changed, 37 insertions(+), 22 deletions(-) commit ad399e9c255df3f6044cf882fb1a970a471c7b92 Author: Per Åhgren <peah@chromium.org> Date: Thu Apr 4 21:27:35 2019 +0000 Extend the expiration date of AEC3 jitter metrics This CL extends the expiration date of the jitter metrics of the WebRTC AEC3. They are valuable for assessing the stability of the platform pipelines. Bug: webrtc:8671 Change-Id: Ide169dc655db5c4191da4e0fef8fec0eb666477b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552828 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#647917} tools/metrics/histograms/histograms.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit e0b5969a048000f534c62107f97143920b45f2f8 Author: Kyle Milka <kmilka@chromium.org> Date: Thu Apr 4 21:27:31 2019 +0000 [NTP] Enable typechecking of NTP javascript Add build target for local_ntp/ js files so it gets built as part of webui_closure_compile. Fix the errors that were reported. Bug: 947180 Change-Id: I1be68b229aa6b68f626d02194f922b1c0644b5c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545359 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by: Dan Beam <dbeam@chromium.org> Reviewed-by: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#647916} chrome/app/generated_resources.grd | 3 + .../IDS_NTP_CUSTOM_BG_IMAGE_SELECTED.png.sha1 | 1 + chrome/browser/resources/BUILD.gn | 1 + chrome/browser/resources/local_ntp/BUILD.gn | 28 ++ .../resources/local_ntp/custom_backgrounds.js | 127 +++---- .../resources/local_ntp/custom_links_edit.js | 4 +- chrome/browser/resources/local_ntp/doodles.js | 23 +- chrome/browser/resources/local_ntp/externs.js | 381 +++++++++++++++++++++ chrome/browser/resources/local_ntp/local_ntp.js | 50 ++- .../resources/local_ntp/most_visited_single.js | 60 ++-- .../resources/local_ntp/most_visited_util.js | 15 +- chrome/browser/resources/local_ntp/utils.js | 2 +- chrome/browser/resources/local_ntp/voice.js | 39 +-- chrome/browser/search/local_ntp_source.cc | 12 +- .../local_ntp/custom_backgrounds_browsertest.js | 12 +- 15 files changed, 600 insertions(+), 158 deletions(-) commit f8e8db05a6da9aa52dd31f5e379b1a6aab5a9be4 Author: Tomasz Wiszkowski <ender@google.com> Date: Thu Apr 4 21:26:30 2019 +0000 Update translate icon asset with K, L and M friendly version. This change updates translate icon with a simpler version, that works well with older Android versions. Bug: 949335 Change-Id: Ib43bd7c38329bdd5f94a90dec6f4d412644d6229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553705 Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#647915} .../java/res/drawable/logo_translate_round.xml | 64 ++++++++-------------- 1 file changed, 24 insertions(+), 40 deletions(-) commit d0f7e0a0a611751426f8baa4364d3f63ed378eb3 Author: Aditya Keerthi <adityakeerthi@google.com> Date: Thu Apr 4 21:26:26 2019 +0000 TaskScheduler: Add support for COM MTA threads in PlatformNativeWorkerPoolWin Currently, SchedulerWorkerPoolImpl can create COM MTA threads on Windows, through the use of a WorkerEnvironment parameter in Start(). PlatformNativeWorkerPoolWin lacks the ability to create COM MTA threads. Certain Windows APIs (such as WMI) can only be called on COM MTA threads. For this reason, it is essential that PlatformNativeWorkerPoolWin has the ability to create COM MTA threads. The lack of support was discovered through a failing DCHECK, which served to ensure that WMI calls were only being made from COM MTA threads. In order to support the creation of COM MTA threads, a WorkerEnvironment parameter was added to PlatformNativeWorkerPool::Start. Note that the Windows Thread Pool API does not provide an interface to initialize/uninitialize COM MTA in threads created by the pool. Additionally, the API does not provide the ability to know when a worker thread has been created/destroyed. For this reason, a ThreadLocalOwnedPointer<ScopedCOMInitializer> is used in PlatformNativeWorkerPoolWin. The ThreadLocalOwnedPointer ensures that we never initialize COM MTA twice in the same thread and that COM MTA is uninitialized once the thread is destroyed. Bug: 756547, 949075 Change-Id: I3602566aa18f00d7054f5c26742f93860e62b923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551913 Commit-Queue: Aditya Keerthi <adityakeerthi@google.com> Reviewed-by: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#647914} .../task_scheduler/platform_native_worker_pool.cc | 4 +- .../task_scheduler/platform_native_worker_pool.h | 5 +- .../platform_native_worker_pool_win.cc | 23 ++++++ base/task/task_scheduler/scheduler_worker_pool.h | 10 +++ .../task_scheduler/scheduler_worker_pool_impl.cc | 1 + .../task_scheduler/scheduler_worker_pool_impl.h | 10 --- .../scheduler_worker_pool_impl_unittest.cc | 88 +--------------------- .../scheduler_worker_pool_unittest.cc | 43 ++++++++++- base/task/task_scheduler/task_scheduler_impl.cc | 10 +-- 9 files changed, 89 insertions(+), 105 deletions(-) commit b641169152a93e78e69d3a73f6bcfd55d0831144 Author: Jason Chase <chasej@chromium.org> Date: Thu Apr 4 21:25:26 2019 +0000 Remove unnecessary virtual test suite file A readme file was added for a new virtual test suite in cl 1546420, but did not end up needing the test suite. This CL cleans up the file that was missed in that CL: https://chromium-review.googlesource.com/c/chromium/src/+/1546420 Change-Id: Ib83bc42676cc6fa8ab7824b6c3c1d5dbeb7836ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551799 Reviewed-by: Ian Clelland <iclelland@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#647913} .../http/tests/origin_trials/webexposed/README.txt | 3 --- 1 file changed, 3 deletions(-) commit 4bcee5d24e5d1fce37f05985def9c12405f2c30a Author: David Bokan <bokan@chromium.org> Date: Thu Apr 4 21:25:22 2019 +0000 Remove VisualViewport::VisibleRectInDocument This method is misnamed, it returns the visible rect in the root scroller. That's already provided by and removed the VisualViewport method. RootFrameViewport: :VisibleContentRect so I've replaced all occurences Change-Id: I22a7cbef04f502bffcf83a110470b771e0cb9391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553251 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#647912} .../blink/renderer/core/exported/web_frame_test.cc | 46 +++++++++++++--------- .../blink/renderer/core/exported/web_view_impl.cc | 9 +++-- .../blink/renderer/core/frame/visual_viewport.cc | 10 ----- .../blink/renderer/core/frame/visual_viewport.h | 5 --- .../renderer/core/frame/visual_viewport_test.cc | 26 ------------ 5 files changed, 32 insertions(+), 64 deletions(-) commit 14dae5385707fd95dc5c906e681bfd66bacef10e Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 21:24:20 2019 +0000 Roll src/third_party/skia e21616804a5a..e4628b10722f (1 commits) https://skia.googlesource.com/skia.git/+log/e21616804a5a..e4628b10722f git log e21616804a5a..e4628b10722f --date=short --no-merges --format='%ad %ae %s' 2019-04-04 malaykeshav@chromium.org Make SkRRect work with axis aligned rotation transforms Created with: gclient setdep -r src/third_party/skia@e4628b10722f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@chromium.org Change-Id: Ide271495b77cf26567d4a42d046322460f138582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553861 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647911} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 748c80010e89d78315b634689a29618ed24c35d0 Author: Chromium WPT Sync <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Date: Thu Apr 4 21:24:16 2019 +0000 Import wpt@2ba0f1706ca93896aa898e7b7e992503f242e5d6 Using wpt-import in Chromium ac64ac50e8292c154ed4743cc861a95991a1f6ab. With Chromium commits locally applied on WPT: 0a8f3ffa48 "Use testdriver Action API in WPT pointerevent touch tests - Part 2" e46d3296e8 "Revise tests for datachannel ID handling" 80389713fa "Rebase and fix tests for WebRTC DataChannel after landing WebRTC fix" 30c9194463 "Change XRRigidTransform inverse method to attrib" 421cce6c8b "Fix a lot of RTCDataChannel parameter checks" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ia5555daed23d262a1fa2d8224f24ac7f751b3559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553644 Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647910} third_party/blink/web_tests/TestExpectations | 26 ++ .../web_tests/external/WPT_BASE_MANIFEST_5.json | 488 ++++++++++++--------- ...on-001.html => text-decoration-001-manual.html} | 0 ...on-002.html => text-decoration-002-manual.html} | 0 ...on-003.html => text-decoration-003-manual.html} | 0 ...on-004.html => text-decoration-004-manual.html} | 0 ...on-040.html => text-decoration-040-manual.html} | 0 ...-040a.html => text-decoration-040a-manual.html} | 0 ...on-041.html => text-decoration-041-manual.html} | 0 ...on-044.html => text-decoration-044-manual.html} | 0 ...on-045.html => text-decoration-045-manual.html} | 0 ...-046a.html => text-decoration-046a-manual.html} | 0 ...on-048.html => text-decoration-048-manual.html} | 0 ...-048a.html => text-decoration-048a-manual.html} | 0 ...on-049.html => text-decoration-049-manual.html} | 0 ...on-082.html => text-decoration-082-manual.html} | 0 ...on-085.html => text-decoration-085-manual.html} | 0 ...on-090.html => text-decoration-090-manual.html} | 0 ...-090a.html => text-decoration-090a-manual.html} | 0 ...on-091.html => text-decoration-091-manual.html} | 0 ...-091a.html => text-decoration-091a-manual.html} | 0 ...on-092.html => text-decoration-092-manual.html} | 0 ...-092a.html => text-decoration-092a-manual.html} | 0 ...-095a.html => text-decoration-095a-manual.html} | 0 ...on-096.html => text-decoration-096-manual.html} | 0 ...-096a.html => text-decoration-096a-manual.html} | 0 ...on-097.html => text-decoration-097-manual.html} | 0 ...-097a.html => text-decoration-097a-manual.html} | 0 28 files changed, 303 insertions(+), 211 deletions(-) commit bbc257cf31a377d3bdb79ba88d059f37a08456ed Author: Bill Orr <billorr@chromium.org> Date: Thu Apr 4 21:23:12 2019 +0000 Enable Windows Mixed Reality by default After this change, WMR is enabled by default but can be disabled. Sandboxing the process where desktop VR APIs are hosted is also enabled by default but can be disabled. Note that the actual use of the API via web APIs is still blocked behind the WebXR and WebVR flags. This change also disables WMR for browser tests that assume OpenVR is the only available runtime. Bug: 925995 Change-Id: Icc4cca9e1dcae780cb6f52bb295694d3381ecde5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1552159 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Brian Sheedy <bsheedy@chromium.org> Reviewed-by: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#647909} chrome/browser/vr/BUILD.gn | 2 ++ chrome/browser/vr/test/webvr_browser_test.h | 30 ++++++++++++++++++++++++++ chrome/browser/vr/test/webxr_vr_browser_test.h | 30 ++++++++++++++++++++++++++ chrome/browser/vr/test/xr_browser_test.cc | 2 +- chrome/browser/vr/test/xr_browser_test.h | 1 + chrome/common/chrome_features.cc | 2 +- services/service_manager/sandbox/features.cc | 2 +- 7 files changed, 66 insertions(+), 3 deletions(-) commit 8ac39328330738ded0e2fc1fe94e56efd7ed88d1 Author: Joshua Pawlicki <waffles@chromium.org> Date: Thu Apr 4 21:22:46 2019 +0000 Remove XML from update_client. Bug: 881076 Change-Id: Ic40bff48042a2d0b3096232cd59f7880eb49b161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546200 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Sorin Jianu <sorin@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#647908} .../extension_update_client_base_browsertest.cc | 18 +- .../extension_update_client_base_browsertest.h | 4 +- .../updater/update_service_browsertest.cc | 184 +------- .../data/update_client/updatecheck_reply_1.xml | 18 - .../data/update_client/updatecheck_reply_4.xml | 16 - .../update_client/updatecheck_reply_noupdate.xml | 10 - .../updatecheck_reply_parse_error.xml | 4 - .../update_client/updatecheck_reply_unknownapp.xml | 4 - components/update_client/BUILD.gn | 13 - components/update_client/DEPS | 2 - components/update_client/ping_manager_unittest.cc | 81 ---- components/update_client/protocol_handler.cc | 12 - components/update_client/protocol_handler.h | 7 - components/update_client/protocol_parser.cc | 5 - components/update_client/protocol_parser_xml.cc | 422 ------------------ components/update_client/protocol_parser_xml.h | 30 -- .../update_client/protocol_parser_xml_unittest.cc | 489 --------------------- .../update_client/protocol_serializer_xml.cc | 200 --------- components/update_client/protocol_serializer_xml.h | 28 -- .../protocol_serializer_xml_unittest.cc | 91 ---- .../update_client/request_sender_unittest.cc | 9 +- components/update_client/test_configurator.cc | 9 +- .../update_client/update_checker_unittest.cc | 391 ++++------------ components/update_client/update_client_unittest.cc | 30 +- 24 files changed, 121 insertions(+), 1956 deletions(-) commit 2e4201380b45aef024d168a8f63a9cfce6415ff2 Author: Tim Song <tengs@chromium.org> Date: Thu Apr 4 21:21:41 2019 +0000 Add tengs to ash/system/message_center and ash/system/unified OWNERS. Change-Id: I57d3a8f1de7e677aea97d10f543e888bbaa4a1c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546428 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#647907} ash/system/unified/OWNERS | 2 ++ ui/message_center/OWNERS | 1 + 2 files changed, 3 insertions(+) commit fc21074ff0ce59f2d6ab16f53e6aa22820a4bedf Author: Eugene But <eugenebut@chromium.org> Date: Thu Apr 4 21:21:37 2019 +0000 Move referrer_util.h to ios/web/common. ios/web/common directory contains common code shared between //ios/web and the rest of the layers (//components, //ios/chrome, //ios/web_view). This directory does not contain the public API to create and manage web contents (//ios/web/public is public API directory). Bug: 942244 Change-Id: I249dbb2b0bbae69b58632dfd4b7c3175657773a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549579 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#647906} components/sessions/BUILD.gn | 1 + components/sessions/ios/DEPS | 1 + .../sessions/ios/ios_serialized_navigation_driver.cc | 2 +- ios/chrome/browser/ui/browser_view/BUILD.gn | 1 + .../browser/ui/browser_view/browser_view_controller.mm | 2 +- ios/chrome/browser/web/BUILD.gn | 1 + ios/chrome/browser/web/image_fetch_tab_helper.mm | 2 +- ios/web/BUILD.gn | 2 +- ios/web/common/BUILD.gn | 9 +++++++++ ios/web/common/DEPS | 1 + ios/web/{public => common}/referrer_util.cc | 7 +++---- ios/web/{public => common}/referrer_util.h | 11 +++++------ ios/web/{public => common}/referrer_util_unittest.cc | 2 +- ios/web/public/BUILD.gn | 17 ++++++++++++++--- ios/web/web_state/BUILD.gn | 1 + ios/web/web_state/context_menu_params_utils.mm | 2 +- ios/web/web_state/context_menu_params_utils_unittest.mm | 2 +- ios/web/web_state/ui/crw_web_controller.mm | 2 +- 18 files changed, 45 insertions(+), 21 deletions(-) commit f4eec90c8c0a91667ac0cd9baf3bc09721a3de21 Author: Scott Violet <sky@chromium.org> Date: Thu Apr 4 21:20:34 2019 +0000 content: converts NavigationEntry extra-data to base::SupportsUserData This also adds cloning to SupportsUserData::Data, which is used by NavigationEntry. As part of this I had to shuffle some code around because of naming conflicts. TEST=covered by tests Change-Id: I6a1f1af8cf7d1ed64620a03d9fe13d8d35acc7c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549654 Reviewed-by: kylechar <kylechar@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#647905} base/supports_user_data.cc | 17 +++++++- base/supports_user_data.h | 13 +++++-- chrome/browser/loader/chrome_navigation_data.cc | 41 +++++++++++++++----- chrome/browser/loader/chrome_navigation_data.h | 4 +- .../browser/mojo_safe_browsing_impl.cc | 29 +++++++++++--- .../browser/mojo_safe_browsing_impl.h | 8 ++-- .../content/content_record_password_state.cc | 44 +++++++++++++-------- ...ntent_serialized_navigation_builder_unittest.cc | 42 ++++++++++++-------- .../frame_host/navigation_controller_android.cc | 45 ++++++++++++++++++++-- .../browser/frame_host/navigation_entry_impl.cc | 20 +--------- content/browser/frame_host/navigation_entry_impl.h | 9 ----- .../frame_host/navigation_entry_impl_unittest.cc | 21 ---------- content/public/browser/navigation_entry.h | 14 ++----- 13 files changed, 186 insertions(+), 121 deletions(-) commit c69580783764f34430036b59538778163e537a6d Author: liberato@chromium.org <liberato@chromium.org> Date: Thu Apr 4 21:20:31 2019 +0000 Normalize RandomTree histograms at the leaves. Each tree in a RandomTree ensemble should get one vote. It should not be the case that trees that happen to send many instances to a leaf should get more votes in the final, aggregated histogram than any other tree in the ensemble. This CL adds TargetDistribution::Normalize to address this. Note that it doesn't make kUnordered targets produce a single best choice for their one vote. Instead, it normalizes whatever histogram it has, and adds them all together. It's unclear if this is better or worse than taking the max at each leaf first. Change-Id: I8b6abd248d3bd940bcf85811d4029003d11a2068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546507 Reviewed-by: Dan Sanders <sandersd@chromium.org> Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#647904} media/learning/impl/BUILD.gn | 6 +- media/learning/impl/distribution_reporter.cc | 6 +- media/learning/impl/distribution_reporter.h | 9 +- .../impl/distribution_reporter_unittest.cc | 4 +- .../learning/impl/extra_trees_trainer_unittest.cc | 15 +- .../learning/impl/learning_task_controller_impl.cc | 5 +- .../impl/learning_task_controller_impl_unittest.cc | 8 +- media/learning/impl/lookup_table_trainer.cc | 7 +- .../learning/impl/lookup_table_trainer_unittest.cc | 18 +-- media/learning/impl/model.h | 6 +- media/learning/impl/one_hot.cc | 2 +- media/learning/impl/one_hot.h | 3 +- media/learning/impl/random_tree_trainer.cc | 69 ++++---- media/learning/impl/random_tree_trainer.h | 19 +-- .../learning/impl/random_tree_trainer_unittest.cc | 30 ++-- media/learning/impl/target_distribution.h | 94 ----------- .../learning/impl/target_distribution_unittest.cc | 164 ------------------- ...{target_distribution.cc => target_histogram.cc} | 51 +++--- media/learning/impl/target_histogram.h | 98 +++++++++++ media/learning/impl/target_histogram_unittest.cc | 179 +++++++++++++++++++++ media/learning/impl/voting_ensemble.cc | 4 +- media/learning/impl/voting_ensemble.h | 3 +- 22 files changed, 411 insertions(+), 389 deletions(-) commit 95a2e995b5e989bb0750c3e4fe7de50804afe492 Author: Avi Drissman <avi@chromium.org> Date: Thu Apr 4 21:18:40 2019 +0000 Revert "Re-enable fast/css/outline-offset-large.html" This reverts commit 3e71e116e2d3e0a224973a93338a992c781a5497. Reason for revert: Breaks on Win7: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20(1) Original change's description: > Re-enable fast/css/outline-offset-large.html > > TBR=fs@opera.com > BUG=637055 > > Change-Id: I28e5c3fb3c31c1c6e99cf9a33bb8d5284231840e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548423 > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Commit-Queue: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647819} TBR=fs@opera.com,schenney@chromium.org Change-Id: I1fc8067a4c56eb4ea54679a5c0bf108ca19d58ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 637055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553953 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#647903} third_party/blink/web_tests/TestExpectations | 2 ++ 1 file changed, 2 insertions(+) commit 37fb4fcc567eb891ad9db30da2ba55c7451c27c0 Author: Rohit Rao <rohitrao@chromium.org> Date: Thu Apr 4 21:04:27 2019 +0000 Revert "Removed #import <EarlGrey/EarlGrey.h> from ios/chrome/test/earl_grey/chrome_earl_grey.h" This reverts commit 4f6d01ebfde064a2758ed31b87a58e8bce89bbac. Reason for revert: Breaks compile. Original change's description: > Removed #import <EarlGrey/EarlGrey.h> from ios/chrome/test/earl_grey/chrome_earl_grey.h > > EG1 and EG2 do not share a common set of headers, > so any file that directly includes EarlGrey.h cannot be compiled under EG2. > Scrubbing the headers will enable us (in a future CL) > to share these helpers between EG1 and EG2. > > Added #import <EarlGrey/EarlGrey.h> to each file > in which there is #import "ios/chrome/test/earl_grey/chrome_earl_grey.h" > > Files that need to change was found by: > git grep --files-with-matches ios/chrome/test/earl_grey/chrome_earl_grey.h . | grep .m | xargs grep -L '<EarlGrey/EarlGrey.h>' > > > Bug: 922813 > Change-Id: Ic526ee33d0a971a218e9400ec2dda1e184bae377 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551862 > Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#647895} TBR=rohitrao@chromium.org,eugenebut@chromium.org,lindsayw@chromium.org,ericale@chromium.org,monufriienko@chromium.org Change-Id: I66cf2122579b9cc94b24dde6069f1fea86cacd90 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553950 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#647902} ios/chrome/browser/autofill/automation/automation_egtest.mm | 1 + ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm | 2 -- ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm | 1 - ios/chrome/browser/translate/legacy_translate_infobar_egtest.mm | 1 - ios/chrome/browser/translate/translate_egtest.mm | 1 - .../ui/activity_services/activity_service_controller_egtest.mm | 1 - ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm | 2 -- ios/chrome/browser/ui/autofill/save_profile_egtest.mm | 2 -- ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm | 1 - .../browser/ui/payments/payment_request_accessibility_egtest.mm | 2 -- .../ui/payments/payment_request_can_make_payment_egtest.mm | 2 -- .../ui/payments/payment_request_cancel_pay_abort_egtest.mm | 2 -- ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm | 2 -- ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm | 2 -- ios/chrome/browser/ui/payments/payment_request_egtest_base.mm | 2 -- .../browser/ui/payments/payment_request_journey_logger_egtest.mm | 2 -- ios/chrome/browser/ui/payments/payment_request_misc_egtest.mm | 2 -- .../browser/ui/payments/payment_request_modifiers_egtest.mm | 2 -- .../browser/ui/payments/payment_request_payment_app_egtest.mm | 2 -- .../payments/payment_request_payment_method_identifier_egtest.mm | 2 -- .../ui/payments/payment_request_payment_response_egtest.mm | 2 -- ios/chrome/browser/ui/payments/payment_request_show_egtest.mm | 2 -- .../browser/ui/payments/payment_request_use_stats_egtest.mm | 2 -- ios/chrome/browser/ui/popup_menu/popup_menu_egtest.mm | 1 - .../ui/settings/autofill/autofill_credit_card_settings_egtest.mm | 1 - .../ui/settings/autofill/autofill_profile_settings_egtest.mm | 1 - .../ui/settings/clear_browsing_data/clear_browsing_data_egtest.mm | 1 - .../browser/ui/settings/password/passwords_settings_egtest.mm | 1 - ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm | 2 -- ios/chrome/browser/ui/webui/inspect/inspect_ui_egtest.mm | 1 - ios/chrome/browser/ui/webui/web_ui_egtest.mm | 1 - ios/chrome/browser/web/browsing_egtest.mm | 2 -- ios/chrome/browser/web/forms_egtest.mm | 1 - ios/chrome/browser/web/navigation_egtest.mm | 1 - .../browser/web/push_and_replace_state_navigation_egtest.mm | 1 - ios/chrome/browser/web/tab_order_egtest.mm | 1 - ios/chrome/test/earl_grey/chrome_earl_grey.h | 8 ++------ ios/chrome/test/earl_grey/chrome_earl_grey.mm | 2 +- ios/chrome/test/earl_grey/device_check_egtest.mm | 1 - 39 files changed, 4 insertions(+), 62 deletions(-) commit de56521931d1e70c5dbe6e2ef75ee7a0814038ee Author: John Lee <johntlee@chromium.org> Date: Thu Apr 4 20:48:12 2019 +0000 Settings WebUI: Update spellcheck label and sync spellcheck toggles This makes sure that when a user explicitly enables 'Enhanced spell check', spell check is turned on. Similarly, when a user explicitly disables all spell check, the spelling service is turned off. Bug: 848536 Change-Id: I90f655ca91429398a9244044b6a87f6bf5edc806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1549903 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by: Scott Chen <scottchen@chromium.org> Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#647901} chrome/app/settings_strings.grdp | 6 +++--- .../settings/languages_page/languages_page.html | 1 + .../settings/languages_page/languages_page.js | 15 +++++++++++++++ .../browser/resources/settings/privacy_page/BUILD.gn | 1 + .../privacy_page/personalization_options.html | 2 ++ .../settings/privacy_page/personalization_options.js | 15 +++++++++++++++ .../test/data/webui/settings/languages_page_tests.js | 9 +++++++++ .../webui/settings/personalization_options_test.js | 19 +++++++++++++++++++ 8 files changed, 65 insertions(+), 3 deletions(-) commit 91e792b300e7ed8f2a512adab1df8afc27bbe46d Author: Nick Harper <nharper@chromium.org> Date: Thu Apr 4 20:45:50 2019 +0000 Add calendar.google.com to, remove chart.apis.google.com from HSTS preload list Change-Id: I7b5547c9a1764071a8f7c673403906434d311e7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553590 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by: David Benjamin <davidben@chromium.org> Reviewed-by: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#647900} net/http/transport_security_state_static.json | 16 ++++++---------- net/http/transport_security_state_unittest.cc | 1 - 2 files changed, 6 insertions(+), 11 deletions(-) commit 92e357a1c880d33054b809d8495f4e22cc3d8367 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Apr 4 20:45:40 2019 +0000 Roll src/third_party/webrtc f75d458951d0..1c747f5717bc (1 commits) https://webrtc.googlesource.com/src.git/+log/f75d458951d0..1c747f5717bc git log f75d458951d0..1c747f5717bc --date=short --no-merges --format='%ad %ae %s' 2019-04-04 srte@webrtc.org Preparing VideoReceiveStream for move to TaskQueue. Created with: gclient setdep -r src/third_party/webrtc@1c747f5717bc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4cbf215bf3e0402ce537fb3d795ed8a403f1dbdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553010 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#647899} DEPS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit cd48360fd18715967a9388a247d2a8d365c560e5 Author: Brandon Wylie <wylieb@chromium.org> Date: Thu Apr 4 20:43:19 2019 +0000 [Image Fetcher] AsyncTask -> PostTask and better testability Now that the new PostTask API is out, using that for off-thread disk reads. Since there's no great way to test the tasks end-to-end (that I could find), I structed the code in a more testable way that makes testing the end-to-end functionality of the post task api unnecessary. Bug: 947176 Change-Id: I2d20486d92fbfb954ec18cc02994e61aaadc4111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540366 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Filip Gorski <fgorski@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#647898} .../browser/image_fetcher/CachedImageFetcher.java | 125 ++++++++++----------- .../image_fetcher/CachedImageFetcherTest.java | 94 +++------------- 2 files changed, 77 insertions(+), 142 deletions(-) commit ec93f3453c945e6068f8642fb88740e67f6e0a4d Author: Antonio Gomes <tonikitoo@igalia.com> Date: Thu Apr 4 20:42:51 2019 +0000 Use blink's WebPrerenderRelType in //chrome ... rather than duplicating it. This CL makes use of blink's PrerenderRelType in //chrome, and delete //chrome's own duplication of it. For this, public/common/prerender is created and prerender_rel_type.h added there (as well as an OWNER file). R=haraken@chromium.org,thestig@chromium.org BUG=949575 Change-Id: Ibc3cacf133283f408aa4bbd0d74482c9d7412cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553680 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#647897} chrome/browser/prerender/prerender_link_manager.cc | 9 +++------ chrome/browser/prerender/prerender_manager.cc | 7 ++++--- chrome/browser/prerender/prerender_unittest.cc | 3 ++- chrome/common/prerender_types.h | 7 ------- third_party/blink/public/common/BUILD.gn | 1 + third_party/blink/public/common/prerender/OWNERS | 3 +++ .../public/common/prerender/prerender_rel_type.h | 19 +++++++++++++++++++ third_party/blink/public/platform/web_prerender.h | 7 ------- .../blink/renderer/core/exported/prerendering_test.cc | 1 + third_party/blink/renderer/core/loader/link_loader.cc | 2 +- 10 files changed, 34 insertions(+), 25 deletions(-) commit 0f75b5b58517efd9d84c76c75f3f344803c8875c Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Thu Apr 4 20:41:13 2019 +0000 Change CHECKs for debugging crbug.com/816810 to DCHECK Bug: 816810 Change-Id: I7d3a9062f940cf0b16350c9cd2d7cae3d95ef152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1553807 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#647896} .../renderer/core/paint/pre_paint_tree_walk.cc | 21 ++++++++++++--------- .../blink/renderer/core/paint/pre_paint_tree_walk.h | 2 ++ 2 files changed, 14 insertions(+), 9 deletions(-) commit 4f6d01ebfde064a2758ed31b87a58e8bce89bbac Author: Maksym Onufriienko <monufriienko@chromium.org> Date: Thu Apr 4 20:39:26 2019 +0000 Removed #import <EarlGrey/EarlGrey.h> from ios/chrome/test/earl_grey/chrome_earl_grey.h EG1 and EG2 do not share a common set of headers, so any file that directly includes EarlGrey.h cannot be compiled under EG2. Scrubbing the headers will enable us (in a future CL) to share these helpers between EG1 and EG2. Added #import <EarlGrey/EarlGrey.h> to each file in which there is #import "ios/chrome/test/earl_grey/chrome_earl_grey.h" Files that need to change was found by: git grep --files-with-matches ios/chrome/test/earl_grey/chrome_earl_grey.h . | grep .m | xargs grep -L '<EarlGrey/EarlGrey.h>' Bug: 922813 Change-Id: Ic526ee33d0a971a218e9400ec2dda1e184bae377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1551862 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#647895} ios/chrome/browser/autofill/automation/automation_egtest.mm | 1 - ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm | 2 ++ ios/chrome/browser/metrics/tab_usage_recorder_test_util.mm | 1 + ios/chrome/browser/translate/legacy_translate_infobar_egtest.mm | 1 + ios/chrome/browser/translate/translate_egtest.mm | 1 + .../ui/activity_services/activity_service_controller_egtest.mm | 1 + ios/chrome/browser/ui/autofill/save_card_infobar_egtest.mm | 2 ++ ios/chrome/browser/ui/autofill/save_profile_egtest.mm | 2 ++ ios/chrome/browser/ui/find_bar/find_in_page_egtest.mm | 1 + .../browser/ui/payments/payment_request_accessibility_egtest.mm | 2 ++ .../ui/payments/payment_request_can_make_payment_egtest.mm | 2 ++ .../ui/payments/payment_request_cancel_pay_abort_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_data_url_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_debit_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_egtest_base.mm | 2 ++ .../browser/ui/payments/payment_request_journey_logger_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_misc_egtest.mm | 2 ++ .../browser/ui/payments/payment_request_modifiers_egtest.mm | 2 ++ .../browser/ui/payments/payment_request_payment_app_egtest.mm | 2 ++ .../payments/payment_request_payment_method_identifier_egtest.mm | 2 ++ .../ui/payments/payment_request_payment_response_egtest.mm | 2 ++ ios/chrome/browser/ui/payments/payment_request_show_egtest.mm | 2 ++ .../browser/ui/payments/payment_request_use_stats_egtest.mm | 2 ++ ios/chrome/browser/ui/popup_menu/popup_menu_egtest.mm | 1 + .../ui/settings/autofill/autofill_credit_card_settings_egtest.mm | 1 + .../ui/settings/autofill/autofill_profile_settings_egtest.mm | 1 + .../ui/settings/clear_browsing_data/clear_browsing_data_egtest.mm | 1 + .../browser/ui/settings/password/passwords_settings_egtest.mm | 1 + ios/chrome/browser/ui/tab_grid/tab_grid_egtest.mm | 2 ++ ios/chrome/browser/ui/webui/inspect/inspect_ui_egtest.mm | 1 + ios/chrome/browser/ui/webui/web_ui_egtest.mm | 1 + ios/chrome/browser/web/browsing_egtest.mm | 2 ++ ios/chrome/browser/web/forms_egtest.mm | 1 + ios/chrome/browser/web/navigation_egtest.mm | 1 + .../browser/web/push_and_replace_state_navigation_egtest.mm | 1 + ios/chrome/browser/web/tab_order_egtest.mm | 1 + ios/chrome/test/earl_grey/chrome_earl_grey.h | 8 ++++++-- ios/chrome/test/earl_grey/chrome_earl_grey.mm | 2 +- ios/chrome/test/earl_grey/device_check_egtest.mm | 1 + 39 files changed, 62 insertions(+), 4 deletions(-) commit 97dbb19221ce902812a0efec17835c391b1521e8 Author: Mike Wittman <wittman@chromium.org> Date: Thu Apr 4 20:39:03 2019 +0000 [Sampling profiler] Separate native unwinder from thread delegate Separates the native unwinder functionality from the stack and register copying functionality. Passes the native unwinder via dependency injection. Bug: 909957 Change-Id: I4238fda3f38dcf4a56d2fb0d4cd18f936fc5ce32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542430 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#647894} base/BUILD.gn | 1 + base/profiler/native_unwinder.h | 20 +++++++++ base/profiler/native_unwinder_mac.cc | 7 +++- base/profiler/native_unwinder_mac.h | 2 +- base/profiler/native_unwinder_win.cc | 7 +++- base/profiler/native_unwinder_win.h | 1 + base/profiler/stack_sampler_impl.cc | 6 ++- base/profiler/stack_sampler_impl.h | 3 ++ base/profiler/stack_sampler_impl_unittest.cc | 63 +++++++++++++++++----------- base/profiler/stack_sampler_mac.cc | 9 ++-- base/profiler/stack_sampler_win.cc | 5 ++- base/profiler/thread_delegate.h | 10 ----- base/profiler/thread_delegate_mac.cc | 15 +------ base/profiler/thread_delegate_mac.h | 10 +---- base/profiler/thread_delegate_win.cc | 8 ---- base/profiler/thread_delegate_win.h | 5 --- base/profiler/unwinder.h | 14 ++++--- 17 files changed, 100 insertions(+), 86 deletions(-) Updated tag 'tree_truth' (was 073ade76f7c0)